# issues

state: closed
title: `fprintd` fails to start if `/var/lib/fprint` doesn't exist
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/issues/62082
updated_at: 2019-05-26 17:21:07
body:
  ## Issue description
  ```
  ● fprintd.service - Fingerprint Authentication Daemon                                                                                                                                                                                 
     Loaded: loaded (/nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/lib/systemd/system/fprintd.service; linked; vendor preset: enabled)                                                                             
     Active: failed (Result: exit-code) since Sun 2019-05-26 13:29:11 BST; 7s ago                                                                                                                                                       
       Docs: man:fprintd(1)                                                                                                                                                                                                             
    Process: 20686 ExecStart=/nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/libexec/fprintd (code=exited, status=226/NAMESPACE)                                                                                     
   Main PID: 20686 (code=exited, status=226/NAMESPACE)                                                                                                                                                                                  
                                                                                                                                                                                                                                        
  May 26 13:29:11 clipper systemd[1]: Starting Fingerprint Authentication Daemon...                                                                                                                                                     
  May 26 13:29:11 clipper systemd[20686]: fprintd.service: Failed to set up mount namespacing: No such file or directory                                                                                                                
  May 26 13:29:11 clipper systemd[20686]: fprintd.service: Failed at step NAMESPACE spawning /nix/store/ypvxva9bkk8b4g09r0jilzjkqd292yw2-fprintd-thinkpad-0.8.1/libexec/fprintd: No such file or directory                              
  May 26 13:29:11 clipper systemd[1]: fprintd.service: Main process exited, code=exited, status=226/NAMESPACE                                                                                                                           
  May 26 13:29:11 clipper systemd[1]: fprintd.service: Failed with result 'exit-code'.                                                                                                                                                  
  May 26 13:29:11 clipper systemd[1]: Failed to start Fingerprint Authentication Daemon.                                                                                                                                                
  ```

  Creating `/var/lib/fprint` fixes this.


  ### Steps to reproduce

  Remove `/var/lib/fprint` and restart `fprintd`.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.45, NixOS, 19.09pre180814.28b4f7b6ace (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(michael): `""`
   - channels(root): `"nixos-19.09pre180814.28b4f7b6ace, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: `fprintd` looks for configuration file in strange location
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/issues/62083
updated_at: 2019-05-27 16:05:36
body:
  ## Issue description
  After fixing https://github.com/NixOS/nixpkgs/issues/62082
  ```
  ● fprintd.service - Fingerprint Authentication Daemon
     Loaded: loaded (/nix/store/5d1hb5s4xqz7ylz5bm7z7r805mvg4zpa-fprintd-0.8.1/lib/systemd/system/fprintd.service; linked; vendor preset: enabled)
     Active: inactive (dead)
       Docs: man:fprintd(1)

  May 26 13:38:37 clipper systemd[1]: Started Fingerprint Authentication Daemon.
  May 26 13:38:37 clipper fprintd[26899]: Could not open fprintd.conf: No such file or directory
  May 26 13:39:01 clipper systemd[1]: Stopping Fingerprint Authentication Daemon...
  May 26 13:39:01 clipper systemd[1]: Stopped Fingerprint Authentication Daemon.
  May 26 13:39:01 clipper systemd[1]: Starting Fingerprint Authentication Daemon...
  May 26 13:39:01 clipper systemd[1]: Started Fingerprint Authentication Daemon.
  May 26 13:39:01 clipper fprintd[27096]: Could not open fprintd.conf: No such file or directory
  May 26 13:42:16 clipper systemd[1]: Starting Fingerprint Authentication Daemon...
  May 26 13:42:16 clipper systemd[1]: Started Fingerprint Authentication Daemon.
  May 26 13:42:16 clipper fprintd[30658]: Could not open fprintd.conf: No such file or directory
  ```

  Stracing `fprintd` reveals that it is trying to open `${prefix}/etc/fprintd.conf` (yes, literal `${prefix}`) which is nonsense. Looks like somehow `sysconfdir` is misconfigured during the build?

  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.45, NixOS, 19.09pre180814.28b4f7b6ace (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(michael): `""`
   - channels(root): `"nixos-19.09pre180814.28b4f7b6ace, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: fprintd: set sysconfdir
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/62085
updated_at: 2019-05-27 16:07:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/62083. The [Arch config](https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/fprintd) does this too.

  I'm slightly unsure if this is the right thing to do: the alternative would be to set it to `/etc` and copy the config file over in the module. That would mean that other services could potentially modify it, I'm not sure if that's desirable.

  cc @abbradar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos: add `StateDirectory` for fprintd
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/62088
updated_at: 2019-05-26 17:23:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes https://github.com/NixOS/nixpkgs/issues/62082. There is a MR open upstream to fix this with `StateDirectory`, but for now this seems like a good fix.

  cc @abbradar 



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libtins: 4.0 -> 4.2 / compactor: 0.11.1 -> 0.12.2
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/62090
updated_at: 2019-05-27 16:00:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Version updates
  Fix `compactor` builds (currently failing on Hydra)

  cc @fdns 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix chrootenv segfaulting on exit
user_login: Laaas
html_url: https://github.com/NixOS/nixpkgs/pull/62091
updated_at: 2019-05-27 15:51:50
body:
  ###### Motivation for this change
  chrootenv (and therefore all users of FHS envs) segfaults on exit if you allow more than 2^19 file descriptors per process.

  ###### Things done
  glibc 2.27 (and possibly other versions) can't handle an `nopenfd` value larger than 2^19 in `ntfw`, so the value of getdtablesize() was clamped to 2^19.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Control+letter doesn't work in terminal
user_login: mrkkrp
html_url: https://github.com/NixOS/nixpkgs/issues/62092
updated_at: 2019-05-27 12:27:10
body:
  ## Issue description

  Control+letter doesn't work in terminal. For example if I press `Ctrl+L` `^L` is printed and no cleaning of screen takes place. It may be related to behavior of the `readline` library but I lack expertise to say for sure.

  In addition, my prompt is displayed in the following fashion:

  ```
  \[\][\[\]mark@nixos:~]$\[\]
  ```

  The two issues may be related.

  ### Steps to reproduce

  I'm on `f52505fac8c82716872a616c501ad9eff188f97f` 19.03. It should be enough to switch to that version of NixOS and open any terminal emulator. I tried with `cool-retro-term` and `konsole`.

  ## Technical details

  > Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the results.

  Here we go:

  - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.git.f52505f (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.3pre6631_e58a7144`
   - channels(mark): `"nixos-18.09.2337.5d972dd2c94"`
   - nixpkgs: `/home/mark/nixpkgs`


state: closed
title: dropbox: 63.4.107 -> 73.4.118
user_login: siddharthist
html_url: https://github.com/NixOS/nixpkgs/pull/62093
updated_at: 2019-05-27 05:27:23
body:
  ###### Motivation for this change
  You can't login to the dropbox client otherwise, it complains about too old of a version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gopass: Use latest buildGoPackage
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/62094
updated_at: 2019-05-27 08:09:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Go `1.10` is marked as broken on Darwin(see https://github.com/NixOS/nixpkgs/pull/56744/files#diff-0ed9de1390061094a04a4f8c69e29a87R185 in #56744)
  There's no reason not to use the latest available Go version to build `gopass` though, since it builds just fine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kitty: 0.13.3 -> 0.14.0
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/62095
updated_at: 2019-06-26 20:46:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upstream update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/kvmgt: fix starting condition
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/62096
updated_at: 2019-06-17 17:31:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Instead of #48640. I've asked on related mailing lists and systemd.path helper was the solution that worked https://www.freedesktop.org/software/systemd/man/systemd.path.html

  cc @Mic92 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: intel-ocl: fix source URL
user_login: fadenb
html_url: https://github.com/NixOS/nixpkgs/pull/62097
updated_at: 2019-05-27 17:09:01
body:
  ###### Motivation for this change
  Current source download fails with 404.
  File seems to be available via http**s**.

  This should probably be backported to 19.03?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hashcat-utils: init at 1.9
user_login: fadenb
html_url: https://github.com/NixOS/nixpkgs/pull/62098
updated_at: 2019-05-27 13:10:44
body:
  ###### Motivation for this change
  I was lacking a tool in NixOS to convert bettercap output to something hashcat will work with ;)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: osquery: 3.2.9 -> 3.3.2
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/62099
updated_at: 2019-05-28 07:15:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Bumps `osquery` to the latest version available and clean up the derivation.

  The PR consists of two commits:

  * 36cdfa3: add `libelfin`, a new dependency of `osquery`.
  * 64f373d: bump `osquery` to 3.3.2, please read the commit message for all details.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: uefi-firmware-parser: init at 1.8
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/62100
updated_at: 2019-05-29 09:17:04
body:
  ###### Motivation for this change

  Sometimes you have to dig deep into the rabbit hole when debugging stuff. This makes proprietary UEFI more transparent by slicing and dicing them into more usable parts.

  ###### Things done

  Tested by actually using the thing against an UEFI binary. It worked as expected.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - ☑️ Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - ☑️ Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: throttled: fix for Intel CPU throttling issues
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/62101
updated_at: 2019-06-11 10:10:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  `throttled` is a project that fixes some of the Intel CPU throttling issues primarily (but not exclusively) affecting Lenovo machines.

  It is a slightly less ad-hoc version of the fix that we have in [`nixos-hardware`](https://github.com/NixOS/nixos-hardware/blob/master/common/pc/laptop/cpu-throttling-bug.nix), and hopefully could replace it. Crucially, it seems to be maintained.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Service request: Signal DBus Service
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/62102
updated_at: 2019-05-29 16:56:51
body:
  As described on the [signal-cli Wiki](https://github.com/AsamK/signal-cli/wiki/DBus-service). 

  > signal-cli can run in daemon mode and provides an experimental dbus interface.

  This specifically requires `jni/unix-java.so`, and requires a separate user and a configuration file.

  The suggested manual process goes something like this:
  ```
  cp data/org.asamk.Signal.conf /etc/dbus-1/system.d/
  cp data/org.asamk.Signal.service /usr/share/dbus-1/system-services/
  cp data/signal.service /etc/systemd/system/
  sed -i -e "s|%dir%|<INSERT_INSTALL_PATH>|" -e "s|%number%|<INSERT_YOUR_NUMBER>|" /etc/systemd/system/signal.service
  systemctl daemon-reload
  systemctl enable signal.service
  systemctl reload dbus.service
  ```

  But it would be nice to have it packaged up as a Nix service.


state: open
title: nixos/exwm: allow custom Emacs load script
user_login: Vizaxo
html_url: https://github.com/NixOS/nixpkgs/pull/62104
updated_at: 2019-05-27 01:56:25
body:
  Add config option services.xserver.windowManager.exwm.loadScript,
  which is passed to Emacs (as the -l option) to load after the user's init file.

  ###### Motivation for this change
  This allows me to specify that `(exwm-enable)` should be run on the exwm Emacs instance, without putting it in my general Emacs config.

  ###### Things done

  Tested on my NixOS box, both with default configuration (leaves everything as it currently is), and with example configuration (adding `(exwm-enable)`).

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x]  NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: init maintainers/scripts/update-hackage
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62105
updated_at: 2019-05-28 09:17:05
body:
  There are 3 scripts to update the haskell infra at https://github.com/NixOS/cabal2nix
  This moves the command to regenerate pkgs/development/haskell-modules/hackage-packages.nix
  in nixpkgs to ease the process.
  The user still needs to download the hackage repo and point the script at it.

  As I was dealing with haskell problems, I tried to experiment things but having the scripts in cabal2nix are too integrated for quick experiments (automatically pull repos/commit things). 
  I am not sure how much of these scripts should go into nixpkgs but this single script allows to tweak
  pkgs/development/haskell-modules/configuration-hackage2nix.yaml and regenerate pkgs/development/haskell-modules/hackage-packages.nix which is good enough as a start
  @peti 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: srandrd: init at v0.6.0
user_login: utdemir
html_url: https://github.com/NixOS/nixpkgs/pull/62106
updated_at: 2019-05-28 06:33:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  srandrd is a handy utility to run a command when display configuration changes.

  It's a simple c script without many dependencies, and I tested that it works on my NixOS machine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tmatrix: init at 1.0
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62107
updated_at: 2019-05-28 23:03:21
body:
  ###### Motivation for this change
  Because it's really cool. Nice package, @M4444!

  ![test](https://raw.githubusercontent.com/M4444/TMatrix/v1.0/assets/img/TMatrix.gif)

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  ---


state: closed
title: Dropbox doesn't use a hash to verify its installer download
user_login: ryantm
html_url: https://github.com/NixOS/nixpkgs/issues/62108
updated_at: 2019-06-28 08:54:16
body:
  ## Issue description

  Using fetchurl to download the Dropbox installer along with a hash of the installer would be nice, because it would help verify that the installer being used is what the packagers intended on using.

  Is there some reason not to do this? Like, maybe Dropbox regularly replaces the binary at a certain URL.

  ref https://github.com/NixOS/nixpkgs/blob/d5dbfad91add6a0e51fd7619322b5382b8ad7074/pkgs/applications/networking/dropbox/default.nix#L17

  @siddharthist @ttuegel 


state: closed
title: genymotion: refactor src from requireFile to fetchurl
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/pull/62109
updated_at: 2019-05-29 05:50:08
body:
  The old src url was updated by the host, making the required file inaccessible. The new url links directly to the required file.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The old src URL was updated by the host, making the required file inaccessible.

  ###### Things done
  The old URL was to an html page which shows the most recent version of genymotion.
  There was recently a major version update (2.8.0 -> 3.0.2) which now occupies the old URL.
  I tried updating our nix expression to the latest package, but ran into issues linking `xcb`.
  Next I tried finding the old file but could not locate it through genymotion's webpage, or various search engines.
  Next I looked at the download URL associated with the newest version. I swapped out the version numbers of the URL, and luckily the file was still available at it's direct path.
  I am updating the Nix expression to include this direct path so that it will provide a more helpful message to users.
  I am hoping to save future users from the trouble of tracking the file down.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/issues/62110
updated_at: 2019-06-02 20:50:12
title:
  flexget: Could not find a version that satisfies the requirement zxcvbn-python (from FlexGet==2.20.22) (from versions: )

body:
  ## Issue description

  Tried to update my server but it refuses to build because of flexget.

  ```
  installing                                                                                                                                                                                                                                           
  /build/FlexGet-2.20.22/dist /build/FlexGet-2.20.22                                                                                                                                                                                                   
  62006 blocks                                                                                                                                                                                                                                         
  Processing ./FlexGet-2.20.22-py2.py3-none-any.whl                                                                                                                                                                                                    
  Requirement already satisfied: plumbum in /nix/store/038fqm2pfkqnnpg0n4xqsx63x2f58ymf-python3.7-plumbum-1.6.7/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.6.7)                                                                            
  Requirement already satisfied: flask-login in /nix/store/q7br28fv69w138f87qh3cp23d6alzkq8-python3.7-Flask-Login-0.4.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.4.1)                                                                    
  Requirement already satisfied: sqlalchemy in /nix/store/5wr1fcd6b4dl29qa6dmj5krrzb3n1hgd-python3.7-SQLAlchemy-1.2.14/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.2.14)                                                                    
  Requirement already satisfied: jinja2 in /nix/store/n1dcmv0ii513dhlnllc790vfn8i9j9lj-python3.7-Jinja2-2.10.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.10.1)                                                                            
  Requirement already satisfied: beautifulsoup4 in /nix/store/4dnq4cahbnprg2gja6nqicf9cxwyyc0v-python3.7-beautifulsoup4-4.7.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (4.7.1)                                                              
  Requirement already satisfied: zipp in /nix/store/2apb5lkyajs6z4h105v9dinci5h0nhf4-python3.7-zipp-0.3.3/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.3.3)                                                                                  
  Requirement already satisfied: python-dateutil in /nix/store/f7scw09h769xnc9chnbviw7pxjb4z0p0-python3.7-python-dateutil-2.8.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.8.0)                                                            
  Requirement already satisfied: babelfish in /nix/store/v9077b38ma9fmvibrf4gqrdkxpljzq8k-python3.7-babelfish-0.5.5/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.5.5)                                                                        
  Requirement already satisfied: portend in /nix/store/bkfmvpirgaggn7h4gb1da5q17mm27riz-python3.7-portend-2.3/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.3)                                                                                
  Requirement already satisfied: flask in /nix/store/g6ggi7qjn007aabga980bixkaa0xisc2-python3.7-Flask-1.0.2/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.0.2)                                                                                
  Requirement already satisfied: html5lib in /nix/store/v1yg31pa0blvg514b25b29v6px8ikm7y-python3.7-html5lib-1.0.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.0.1)                                                                          
  Requirement already satisfied: future in /nix/store/7mmjc2sk83h0lqd96fi6hpj01a1dnyhk-python3.7-future-0.17.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.17.1)                                                                            
  Requirement already satisfied: jsonschema in /nix/store/5z3pax2qlzqyy4xbx0wn0yc3gdv1kpil-python3.7-jsonschema-2.6.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.6.0)                                                                      
  Requirement already satisfied: rebulk in /nix/store/q6am78ybqvqrxd4hxx5sizqzgpzg9a30-python3.7-rebulk-1.0.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.0.0)                                                                              
  Requirement already satisfied: importlib-metadata in /nix/store/0jakyb1kipi89451s5ihrcbax0s8f8wn-python3.7-importlib-metadata-0.8/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.8)                                                          
  Requirement already satisfied: markupsafe in /nix/store/b2wy5p5bykcnkwz5q1w8qq4qfzr4arc7-python3.7-MarkupSafe-1.1.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.1.1)                                                                      
  Requirement already satisfied: aniso8601 in /nix/store/9mddxkwljdgjszla8gcw8y041p4mzgy8-python3.7-aniso8601-6.0.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (6.0.0)                                                                        
  Requirement already satisfied: flask-restplus in /nix/store/dsvzd1kl4wpb5mzv49n6b2wnykq4wjcz-python3.7-flask-restplus-0.12.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.12.1)                                                            
  Requirement already satisfied: rpyc in /nix/store/4925hxjf12raqqw0drryfamwzxd043fp-python3.7-rpyc-4.0.2/lib/python3.7/site-packages (from FlexGet==2.20.22) (4.0.2)                                                                                  
  Requirement already satisfied: tzlocal in /nix/store/fb8axcm7zvzswx00w0bs6lqryrqgl14g-python3.7-tzlocal-1.5.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.5.1)                                                                            
  Requirement already satisfied: cheroot in /nix/store/gqw890qwlwhymc0fhzfqkbak0xf2cd38-python3.7-cheroot-6.3.3/lib/python3.7/site-packages (from FlexGet==2.20.22) (6.3.3)                                                                            
  Requirement already satisfied: idna in /nix/store/n2mzl8vljdksdqybihdy9mm5v7hm19q5-python3.7-idna-2.8/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.8)                                                                                      
  Requirement already satisfied: webencodings in /nix/store/c1s4ps9h4vy6b22jd9jwz6h2im6ng6k4-python3.7-webencodings-0.5.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.5.1)                                                                  
  Requirement already satisfied: tempora in /nix/store/8xy0iai5m6lggh9cy9q805najc30pnlw-python3.7-tempora-1.14.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.14.1)                                                                          
  Requirement already satisfied: werkzeug in /nix/store/993f9ldw2dpxw5lj5a7z5vywa6xs80qx-python3.7-Werkzeug-0.15.2/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.15.2)                                                                        
  Requirement already satisfied: flask-compress in /nix/store/83nnd4rgc7pz367g8p85pgyl2ww2b8l9-python3.7-Flask-Compress-1.4.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.4.0)                                                              
  Requirement already satisfied: cherrypy in /nix/store/alw46yyv7jansxr7dk387qn9zi7h2654-python3.7-cherrypy-18.1.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (18.1.1)                                                                        
  Requirement already satisfied: pyrss2gen in /nix/store/yddl7vlsn5fy3ynmfb3zd8s3222bdgbv-python3.7-PyRSS2Gen-1.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.1)                                                                            
  Requirement already satisfied: colorclass in /nix/store/syhf1g4sll26i70jfcyjs2qx8lsbvlyg-python3.7-colorclass-2.2.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.2.0)                                                                      
  Requirement already satisfied: pyyaml in /nix/store/z0sqda5bg0l4p0851nw05h7hii0jj1kr-python3.7-PyYAML-5.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (5.1)                                                                                  
  Requirement already satisfied: flask-cors in /nix/store/vr9m0356bcdlwblw4gxwzb1fm8sqbrg6-python3.7-Flask-Cors-3.0.7/lib/python3.7/site-packages (from FlexGet==2.20.22) (3.0.7)                                                                      
  Requirement already satisfied: itsdangerous in /nix/store/xdq121znj8padmqby7hp8i4q40xna0lh-python3.7-itsdangerous-1.1.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.1.0)                                                                  
  Requirement already satisfied: click in /nix/store/yipqg38jl18vq6cqrzi28kapm2gjmg82-python3.7-click-7.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (7.0)                                                                                    
  Requirement already satisfied: pynzb in /nix/store/r39sl6r3mxfjsvqs7jsx2vhazi5w6814-python3.7-pynzb-0.1.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.1.0)                                                                                
  Requirement already satisfied: pytz in /nix/store/9vs1phwnsrvm1dli78ihk8rgz508malf-python3.7-pytz-2019.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (2019.1)                                                                                
  Requirement already satisfied: chardet in /nix/store/wbbwikfkc7fbida822a5z9b4xmsnwm3d-python3.7-chardet-3.0.4/lib/python3.7/site-packages (from FlexGet==2.20.22) (3.0.4)                                                                            
  Requirement already satisfied: urllib3 in /nix/store/ch6pz5kfg0bd3sfyf1813cpskg7lidns-python3.7-urllib3-1.24.2/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.24.2)                                                                          
  Requirement already satisfied: terminaltables in /nix/store/3wab57vfbvbq2alfg21a09as3g19qk81-python3.7-terminaltables-3.1.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (3.1.0)                                                              
  Requirement already satisfied: flask-restful in /nix/store/6r09f4nin02l8ck8ww4665vnfxca5a04-python3.7-Flask-RESTful-0.3.6/lib/python3.7/site-packages (from FlexGet==2.20.22) (0.3.6)                                                                
  Requirement already satisfied: certifi in /nix/store/02nzlzdw0kiici9368jp5s84cpbqxkva-python3.7-certifi-2018.11.29/lib/python3.7/site-packages (from FlexGet==2.20.22) (2018.11.29)                                                                  
  Requirement already satisfied: guessit in /nix/store/pjihjgwg9jscc7yz5p1mq7k1nx6vfng6-python3.7-guessit-3.0.3/lib/python3.7/site-packages (from FlexGet==2.20.22) (3.0.3)                                                                            
  Requirement already satisfied: pyparsing in /nix/store/5ydkc9jcaaxlz58dr7gvyhi3gcmafsfy-python3.7-pyparsing-2.3.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.3.1)                                                                        
  Requirement already satisfied: requests in /nix/store/d0wcd9mid6067i6va19lwiv29hln6n2j-python3.7-requests-2.21.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.21.0)                                                                        
  Requirement already satisfied: progressbar in /nix/store/8n9sx9krvy86yanz9x36c5zdbhq7bzs2-python3.7-progressbar-2.5/lib/python3.7/site-packages (from FlexGet==2.20.22) (2.5)                                                                        
  Requirement already satisfied: six in /nix/store/dy5wi2sqnhbnlpvjr8a0z96id1mq243j-python3.7-six-1.12.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (1.12.0)                                                                                  
  Requirement already satisfied: feedparser in /nix/store/cljj2y3pcgnjndwdm8abl5s0axj1k900-python3.7-feedparser-5.2.1/lib/python3.7/site-packages (from FlexGet==2.20.22) (5.2.1)                                                                      
  Requirement already satisfied: apscheduler in /nix/store/bfkid5s0qiy5745i7v018kga2lymhkfr-python3.7-APScheduler-3.6.0/lib/python3.7/site-packages (from FlexGet==2.20.22) (3.6.0)                                                                    
  Collecting zxcvbn-python (from FlexGet==2.20.22)                                                                                                                                                                                                     
    Could not find a version that satisfies the requirement zxcvbn-python (from FlexGet==2.20.22) (from versions: )                                                                                                                                    
  cannot build derivation '/nix/store/d0rph7w6dsh7p0yrsrqmaqfhkmbg8716-system-path.drv': 1 dependencies couldn't be built                                                                                                                              
  cannot build derivation '/nix/store/gwjl6bqiv1bd6pi78gmpfsm7jnagd13j-nixos-system-servi-19.09pre180832.c7bcd4277cc.drv': 1 dependencies couldn't be built
  ```

  ### Steps to reproduce

  1. Use Nixos Unstable
  2. Add flexget as service
  3. Rebuild

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`                                                                                                                                                                                                                          
   - host os: `Linux 4.19.44, NixOS, 19.09pre180029.82435a53e9a (Loris)`                                                                                                                                                                               
   - multi-user?: `yes`                                                                                                                                                                                                                                
   - sandbox: `yes`                                                                                                                                                                                                                                    
   - version: `nix-env (Nix) 2.2.2`                                                                                                                                                                                                                    
   - channels(hyper): `""`                                                                                                                                                                                                                             
   - channels(root): `"nixos-19.09pre180832.c7bcd4277cc"`                                                                                                                                                                                              
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: exodus: init at 19.5.24
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/62111
updated_at: 2019-05-27 11:04:10
body:
  ###### Motivation for this change

  Initial packaging of exodus wallet.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
  - [X] Tested with Trezor hardware wallet

  ---


state: closed
title: build-support/writers: actually run checks
user_login: Lassulus
html_url: https://github.com/NixOS/nixpkgs/pull/62112
updated_at: 2019-05-28 10:07:23
body:
  ###### Motivation for this change
  actually run the check phase of the nix-writers. This is currently only implemented for writePython{2,3}


state: open
title: pixiecore: initial commit
user_login: RaunoVV
html_url: https://github.com/NixOS/nixpkgs/pull/62113
updated_at: 2019-06-13 21:36:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Initial commit for pixiecore tool: https://github.com/danderson/netboot/tree/master/pixiecore

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnuradio: rename plugins gnuradio-* -> gr-*
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/62115
updated_at: 2019-05-28 14:04:59
body:
  ###### Motivation for this change
  Harmonize plugin names with repology (see https://github.com/NixOS/nixpkgs/issues/60006). In most cases this is also the official package name of the plugins. This will allow for auto updater to check for updates.


  ###### Things done
  * Globally renamed all plugins to gr-*
  * added aliases to maintain backwards compatibility

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Delete NIXOS_EXTRA_MODULE_PATH environment variable?
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/62116
updated_at: 2019-06-16 17:11:01
body:
  ## Issue description

  Could we delete the environment variable  `NIXOS_EXTRA_MODULE_PATH`?

  From the docs: https://nixos.org/nixos/manual/#sec-importing-modules

  it is yet another source of implicit state with no good reason for it to be there.
  You can already import modules by path using:

  ```
  imports = [ ./my-module.nix ]
  ```

  The original commit message that introduced this:

  ```
  tree 233e56b7fec3f3c24b55bc322f219dec09fb0be8
  parent 8bfd6af9ed0eb774035431dab663ee131941a971
  author Mathijs Kwik <mathijs@bluescreen303.nl> Tue Dec 16 17:07:14 2014 +0100
  committer Mathijs Kwik <mathijs@bluescreen303.nl> Tue Dec 16 19:13:15 2014 +0100

  nixos: allow adding extra modules through environment

  This is useful for adding extra functionality or defaults to _every_
  nixos evaluation.

  My use case is overriding behaviour for all nixos tests, for example
  setting packageOverrides to newer versions and changing some default
  dependencies/settings.

  By making this accessible through an environment variable, this can now
  be fully accomplished externally. No more need to fork
  nixos/nixpkgs (which becomes a maintenance burden), just use the channel
  instead and plug in via this envvar.

  ```

  The usecase described in the commit message seems to be superseded by the fact
  that nixos tests are now part of the `all-packages.nix` fixpoint.  

  ```
    nixosTests = import ../../nixos/tests/all-tests.nix {
      inherit pkgs;
      system = stdenv.hostPlatform.system;
      callTest = t: t.test;
    };

  ```

  So overriding packages for all tests should work fine, with for example `packageOverrides` or `overlays`

  ### Rationale

  I'm slowly cleaning up `eval-config.nix` to a point that we can basically replace all its uses with `lib.evalModules` as was suggested in the comments of `eval-config.nix`
  ```
  # !!! Please think twice before adding to this argument list!
  # Ideally eval-config.nix would be an extremely thin wrapper
  # around lib.evalModules, so that modular systems that have nixos configs
  # as subcomponents (e.g. the container feature, or nixops if network
  # expressions are ever made modular at the top level) can just use
  # types.submodule instead of using eval-config.nix
  ```



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: pythonPackages.salmon-mail: fix build
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/62117
updated_at: 2019-05-30 09:51:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Python package `salmon-mail` failed to build because it had set an upper bound for a dependency and nixpkgs contains too new version of that dependency. This upper bound seems to be just some installation convenience thing, not a compatibility issue, so I just removed the upper bound.

  For more information:

  - https://github.com/moggers87/salmon/issues/90
  - https://github.com/moggers87/salmon/blob/3.1.0/setup.py#L10

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: unbreak haskellPackages.bitset
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/62118
updated_at: 2019-06-04 16:29:29
body:
  ## Issue description

  I want to use http://hackage.haskell.org/package/bitset in my program but it fails with
  ```
  these derivations will be built:
    /nix/store/rkc0b0cpaaazzq6lnd9dl60vg3ik3g0r-bitset-1.4.8.drv
    /nix/store/66spfy08yf7dwh2svp4rxqdnq6x2ida9-hoogle-local-0.1.drv
    /nix/store/0j7j9flmj65bcq3phibijwmsr09yy2lz-ghc-8.6.4-with-packages.drv
  these paths will be fetched (0.01 MiB download, 0.01 MiB unpacked):
    /nix/store/i1wk5a1pjdw8dyr2cn58qrc5layk5f4d-bitset-1.4.8.tar.gz
  copying path '/nix/store/i1wk5a1pjdw8dyr2cn58qrc5layk5f4d-bitset-1.4.8.tar.gz' from 'https://cache.nixos.org'...
  building '/nix/store/rkc0b0cpaaazzq6lnd9dl60vg3ik3g0r-bitset-1.4.8.drv'...
  setupCompilerEnvironmentPhase
  Build with /nix/store/zqqbh40bpbw2j2v4phb948bpvsl76wpd-ghc-8.6.4.
  unpacking sources
  unpacking source archive /nix/store/i1wk5a1pjdw8dyr2cn58qrc5layk5f4d-bitset-1.4.8.tar.gz
  source root is bitset-1.4.8
  setting SOURCE_DATE_EPOCH to timestamp 1394469221 of file bitset-1.4.8/tests/Tests.hs
  patching sources
  compileBuildDriverPhase
  setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
  [1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )

  Setup.hs:38:24: error: [-Wdeprecations, -Werror=deprecations]
      In the use of ‘die’ (imported from Distribution.Simple.Utils):
      Deprecated: "Messages thrown with die can't be controlled with Verbosity; use die' instead, or dieNoVerbosity if Verbosity truly is not available"
     |
  38 |             Nothing -> die "Failed to find GCC!"
     |                        ^^^

  ```
  triggered on the line https://github.com/lambda-llama/bitset/blob/55c5af3bbaa0a394bac98a37c3be20351ebfc2a6/Setup.hs#L41

  Seems like this is part of the standard:
  http://hackage.haskell.org/package/Cabal-2.4.1.0/docs/Distribution-Simple-Program-Types.html#g:2

  I've added 
  ```
    bitset = overrideCabal (super.bitset) (drv: {
        preCompileBuildDriver = ''
           setupCompileFlags+=" --with-gcc=${pkgs.gcc}/bin/gcc"
         '';
     });
  ```
  in pkgs/development/haskell-modules/configuration-common.nix with the hope of fixing this but --with-gcc doesn't seem like a valid option. any idea ?

  ### Steps to reproduce
  `nix-shell -p haskellPackages.bitset ~/nixpkgs`


  ## Technical details

  current unstable


state: closed
title: qgis: 3.4.7 -> 3.4.8
user_login: lsix
html_url: https://github.com/NixOS/nixpkgs/pull/62119
updated_at: 2019-05-28 00:55:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Once merged, I’ll backport it to `release-19.03`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ndstool: init at 2.1.2
user_login: marius851000
html_url: https://github.com/NixOS/nixpkgs/pull/62120
updated_at: 2019-05-28 01:52:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  use this in one of my program

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: packageOverrides not applied to replaceStdenv's argument. Breaks ccacheStdenv
user_login: Piezoid
html_url: https://github.com/NixOS/nixpkgs/issues/62121
updated_at: 2019-06-13 13:36:38
body:
  ## Issue description

  `packageOverrides` are not (no longer ?) applied in the `pkgs` argument of `replaceStdenv`, making the documentation of `ccacheStdenv` obsolete or unclear.
  It seems that an overlay should be used instead. (#43266)

  The inline doc in `pkgs/top-level/all-packages.nix` says:

  ```
  Wrapper that works as gcc or g++
  It can be used by setting in nixpkgs config like this, for example:
     replaceStdenv = { pkgs }: pkgs.ccacheStdenv;
  But if you build in chroot, you should have that path in chroot
  If instantiated directly, it will use $HOME/.ccache as the cache directory,
  i.e. /homeless-shelter/.ccache using the Nix daemon.
  You should specify a different directory using an override in
  packageOverrides to set extraConfig.

  Example using Nix daemon (i.e. multiuser Nix install or on NixOS):
     packageOverrides = pkgs: {
      ccacheWrapper = pkgs.ccacheWrapper.override {
        extraConfig = ''
          export CCACHE_COMPRESS=1
          export CCACHE_DIR=/nix/var/ccache
          export CCACHE_UMASK=007
        '';
      };
  You can use a different directory, but whichever directory you choose
  should be owned by user root, group nixbld with permissions 0770.
  ```

  ### Steps to reproduce

  However with this `config.nix`:

  ```nix
  {
      replaceStdenv = { pkgs }: builtins.trace "###Deref ccacheStdenv###" pkgs.ccacheStdenv;
      packageOverrides = pkgs: {
          ccacheWrapper = builtins.trace "###Deref ccacheWrapper###" (pkgs.ccacheWrapper.override {
              extraConfig = builtins.trace "###Deref extraConfig###" ''
                  export CCACHE_DIR=/nix/var/ccache
                  export CCACHE_UMASK=007
              '';
          });
      };
  }
  ```

  A build like `nix-build -A gnum4 ~/repos/nixpkgs --keep-failed` fail with:
  ```ccache: error: Failed to create directory /homeless-shelter/.ccache/tmp: Permission denied```
  indicating that the `extraConfig` environment variables failled to apply.

  Furthermore, only the `trace: ###Deref ccacheStdenv###` show up. This demonstrate that my overlayed `ccacheWrapper` is never evaluated.

  **Using this overlay `~/.config/nixpkgs/overlays/ccacheWrapper.nix` worked:**
  ```nix
  self: super: {
    ccacheWrapper =super.ccacheWrapper.override {
      extraConfig = ''
        export CCACHE_DIR=/nix/var/ccache
        export CCACHE_UMASK=007
      '';
      };
  }
  ```


state: closed
title: terraform-provider-elasticsearch: init at 0.6.0
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/62122
updated_at: 2019-05-27 17:34:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I would like to use https://github.com/phillbaker/terraform-provider-elasticsearch.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport "terraform-provider-elasticsearch: init at 0.6.0" to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/62123
updated_at: 2019-05-27 17:34:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This backports https://github.com/NixOS/nixpkgs/pull/62122.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: abbaye-des-morts: init at 2.0.1
user_login: marius851000
html_url: https://github.com/NixOS/nixpkgs/pull/62124
updated_at: 2019-06-01 14:39:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  A fun game I discovered and wanted to play. Packaged it BTW.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tk: add missing headers for Darwin
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/62125
updated_at: 2019-05-27 18:54:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR adds the missing headers to tk, which are used to build tix.

  ```console
  In file included from ./generic/tixInputO.c:17:
  In file included from private_headers/generic/tkInt.h:19:
  private_headers/generic/tkPort.h:25:11: fatal error: 'tkMacOSXPort.h' file not found
  #       include "tkMacOSXPort.h"
                  ^~~~~~~~~~~~~~~~
  1 error generated.
  make: *** [Makefile:294: tixInputO.o] Error 1
  builder for '/nix/store/4m3ibf7zdkx658rbd3082c1dn67sb4wc-tix-8.4.3.drv' failed with exit code 2
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.streamz: Fix build
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62126
updated_at: 2019-05-28 00:53:50
body:
  Can't test tcp in the sandbox

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doctl: 1.16.0 -> 1.18.0
user_login: kuznero
html_url: https://github.com/NixOS/nixpkgs/pull/62127
updated_at: 2019-05-28 13:55:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade `doctl` (Digital Ocean cli) to latest version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scalapack: Increase individual test timeout to prevent hydra failures
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62128
updated_at: 2019-05-27 21:02:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Build occasionally failed (see https://hydra.nixos.org/job/nixpkgs/trunk/scalapack.x86_64-linux/all?page=1) due to individual tests timing out:

  ```
  95/96 Test #93: xcheevr ..........................***Timeout 1500.05 sec

  [...]

  95% tests passed, 5 tests failed out of 96

  Total Test time (real) = 4836.54 sec

  The following tests FAILED:
           44 - xdllt (Timeout)
           45 - xcllt (Timeout)
           91 - xssyevr (Timeout)
           92 - xdsyevr (Timeout)
           93 - xcheevr (Timeout)
  Errors while running CTest
  make: *** [Makefile:141: test] Error 8
  builder for '/nix/store/kszycfkp7aimpxx8j9kr3lgk3iiwb5sj-scalapack-2.0.2.drv' failed with exit code 2
  ```

  As I found out through http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4861, this 1500s timeout is built into cmake itself and can only be overwritten globally by passing `--timeout` to ctest, which is what this PR does with a value of 10000s.

  An alternative would be to just disable the tests, which might be desirable, because they take ~1h20 to run, in comparison to the ~10 minutes of the build itself! Honestly this is a huge waste of build power, and I doubt the tests will ever give us a failure anyways.

  Ping @costrouc @markuskowa 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: geeqie: use wrapGAppsHook
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/62129
updated_at: 2019-05-28 05:05:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This makes user choosed icon themes work in geeqie

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: uwsgi: enable on darwin
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/62130
updated_at: 2019-05-28 09:12:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Document: bridged nixos-container to get IP via DHCP
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/62131
updated_at: 2019-06-12 08:55:36
body:
  ## Issue description

  I want to spawn a nixos-container that gets an IP via DHCP in the same network as my notebook (as it was connected to the same switch).

  This works with VMs in VirtualBox using the "Bridged Adapter" setting.

  How can i achieve that using nixos-container?

  A documentation would be great!

  https://nixos.org/nixos/manual/index.html#ch-containers

  It currently only explains NAT, but i want to access the container from the network using it's own IP.

  ### Steps to reproduce

  I tried

  ```
    networking.bridges = {
      br0 = {
        interfaces = [ "enp0s31f6" ];
      };
    };

    networking.networkmanager.unmanaged = [ "interface-name:vb-*" ];

    containers = {
      target0 = {
        autoStart = true;
        config = targetConfig;
        privateNetwork = true;
        hostBridge = "br0";
        #localAddress = "192.168.0.100/24";
      };
    };
  ```

  Inside container config:
  ```
  ...
  { boot.isContainer = true;
    networking.useDHCP = mkForce true;
    networking.firewall.enable = false;
  ...
  ```

  With this config, my notebooks network stops working and the container has a link local address.

  ```
  [root@ethmoid:~]# nixos-container run target0 -- ip a
  1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      inet 127.0.0.1/8 scope host lo
         valid_lft forever preferred_lft forever
      inet6 ::1/128 scope host 
         valid_lft forever preferred_lft forever
  2: eth0@if114: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
      link/ether 3a:0b:9c:e6:ee:8c brd ff:ff:ff:ff:ff:ff link-netnsid 0
      inet 169.254.129.65/16 brd 169.254.255.255 scope global noprefixroute eth0
         valid_lft forever preferred_lft forever
      inet6 fe80::380b:9cff:fee6:ee8c/64 scope link 
         valid_lft forever preferred_lft forever
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.44, NixOS, 19.03.172657.cdec6217d98 (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172657.cdec6217d98, nixos-hardware, nixos-unstable-19.09pre180241.971b731fc18"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: tetra-gtk-theme: 201905 -> 201905r1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/62132
updated_at: 2019-06-10 00:06:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Rename to `adementary-theme`, following upstream (https://github.com/hrdwrrsk/adementary-theme/issues/29)
  - Update to version [201905r1](https://github.com/hrdwrrsk/adementary-theme/releases)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: reaverwps-t6x: 1.6.3 -> 1.6.5
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62134
updated_at: 2019-05-28 17:13:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/t6x/reaver-wps-fork-t6x/releases/tag/v1.6.5
  https://github.com/t6x/reaver-wps-fork-t6x/releases/tag/v1.6.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Adds Citrix workspace app package
user_login: garry-cairns
html_url: https://github.com/NixOS/nixpkgs/pull/62135
updated_at: 2019-05-28 06:50:48
body:
  Citrix workspace is replacing Citrix receiver as per
  https://docs.citrix.com/en-us/citrix-workspace-app.html
  Creates Citrix workspace package using the citrix-receiver package as a template.
  Built and used locally.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tmux module: Fix escaping in TMUX_TMPDIR
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/62136
updated_at: 2019-05-31 19:42:48
body:
  5404595b55eeefae69f2952a34dfc70e32523060 relocated code but kept
  one backslah too many, leading to

  $ tmux
  error creating /run/user/1000/tmux-1000 (No such file or directory)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pympress: init at 1.2.0
user_login: tbenst
html_url: https://github.com/NixOS/nixpkgs/pull/62137
updated_at: 2019-07-13 03:16:21
body:
  ###### Motivation for this change
  Pympress is a simple yet powerful PDF reader designed for dual-screen presentations.

  ###### Things done

  Added pympress and dependency python-vlc

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xv: 0.1.0 -> 0.1.1
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/62138
updated_at: 2019-06-01 03:56:02
body:
  ###### Motivation for this change
  https://github.com/chrisvest/xv/releases/tag/0.1.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (with sandbox)
     - [X] macOS (without sandbox)
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  The release notes for xv 0.1.1 talk about exposing other Cursive backends and give an example of Windows. It seems that the Cursive library doesn't support ncurses on Windows. I chose the `pancurses` library instead for Windows, but I don't have any way of actually testing this. I did check and it looks like the `pancurses-rs` crate bundles and compiles PDCurses itself for Windows, so there should be no need for any new build inputs on Windows.


state: closed
title: cargo-make: 0.19.2 -> 0.19.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62139
updated_at: 2019-05-29 07:49:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-make` to the latest release.
  https://github.com/sagiegurari/cargo-make/releases/tag/0.19.3

  **Note**: `doCheck` is set as `false`. 
   Some tests fail because they need network access. However, Travis-CI ensures a proper build.

  https://travis-ci.org/sagiegurari/cargo-make/jobs/537918655
  https://travis-ci.org/sagiegurari/cargo-make/jobs/537918656
  https://travis-ci.org/sagiegurari/cargo-make/jobs/537918657
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python gtk can't find icons
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/issues/62140
updated_at: 2019-06-04 13:17:23
body:
  ## Issue description

  Python with gtk can't find icons if I use non-standard icon theme.

  cc @jtojnar

  ### Steps to reproduce

  1. Install some WM and breeze-icons, don't install gnome3.adwaita-icon-theme or Gnome
  2. Use lxappearance and qt5ct to choose breeze icon theme
  3. `nix-shell -p gobjectIntrospection "[ libappindicator-gtk3 ]" "python3.withPackages (ps: with ps; [ pygobject3 ])" --run python3`
  ```python
  Python 3.7.3 (default, Mar 25 2019, 20:59:09) 
  [GCC 7.4.0] on linux
  Type "help", "copyright", "credits" or "license" for more information.
  >>> import gi
  >>> gi.require_version('Gtk', '3.0')
  >>> from gi.repository.Gtk import IconTheme
  >>> icon_theme = IconTheme.get_default()

  (.:19879): Gtk-WARNING **: 08:28:24.200: Theme parsing error: gtk.css:68:35: The style property GtkButton:child-displacement-x is deprecated and shouldn't be used anymore. It will be removed in a future version

  (.:19879): Gtk-WARNING **: 08:28:24.200: Theme parsing error: gtk.css:69:35: The style property GtkButton:child-displacement-y is deprecated and shouldn't be used anymore. It will be removed in a future version

  (.:19879): Gtk-WARNING **: 08:28:24.201: Theme parsing error: gtk.css:73:46: The style property GtkScrolledWindow:scrollbars-within-bevel is deprecated and shouldn't be used anymore. It will be removed in a future version
  >>> list(filter(lambda x: x == "/run/current-system/sw/share/icons", icon_theme.get_search_path()))
  ['/run/current-system/sw/share/icons']
  >>> list(filter(lambda x: x == "transmission" or x == "emacs", icon_theme.list_icons()))
  ['transmission', 'emacs']
  >>> icon_theme.has_icon("emacs")
  True
  >>> icon_theme.has_icon("transmission")
  False
  >>> icon_theme.get_icon_sizes("emacs")
  [-1]
  >>> icon_theme.get_icon_sizes("transmission")
  []
  >>> icon_theme.list_contexts()
  /tmp/nix-shell-15152-0/rc: строка 1: 19879 Segmentation fault      python3
  ```
  Though system has these icons
  ```bash
  $ find /run/current-system/sw/share/icons -name "transmission*"
  /run/current-system/sw/share/icons/hicolor/48x48/apps/transmission.png
  /run/current-system/sw/share/icons/hicolor/16x16/apps/transmission.png
  /run/current-system/sw/share/icons/hicolor/22x22/apps/transmission.png
  /run/current-system/sw/share/icons/hicolor/scalable/apps/transmission.svg
  /run/current-system/sw/share/icons/hicolor/256x256/apps/transmission.png
  /run/current-system/sw/share/icons/hicolor/32x32/apps/transmission.png
  /run/current-system/sw/share/icons/hicolor/24x24/apps/transmission.png
  $ find /run/current-system/sw/share/icons -name "emacs*"
  /run/current-system/sw/share/icons/hicolor/48x48/apps/emacs.png
  /run/current-system/sw/share/icons/hicolor/16x16/apps/emacs.png
  /run/current-system/sw/share/icons/hicolor/128x128/apps/emacs.png
  /run/current-system/sw/share/icons/hicolor/scalable/mimetypes/emacs-document.svg
  /run/current-system/sw/share/icons/hicolor/scalable/mimetypes/emacs-document23.svg
  /run/current-system/sw/share/icons/hicolor/scalable/apps/emacs.svg
  /run/current-system/sw/share/icons/hicolor/32x32/apps/emacs.png
  /run/current-system/sw/share/icons/hicolor/24x24/apps/emacs.png
  ```
  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: webkitgtk: 2.24.1 -> 2.24.2
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/62141
updated_at: 2019-05-28 08:08:37
body:
  https://webkitgtk.org/2019/05/17/webkitgtk2.24.2-released.html

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hashcat: 5.0.0 -> 5.1.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62142
updated_at: 2019-06-06 08:40:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/hashcat/hashcat/releases/tag/v5.1.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @kierdavis @zimbatm


state: closed
title: nnn: 2.4 -> 2.5
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62143
updated_at: 2019-05-28 10:30:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/jarun/nnn/releases/tag/v2.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vokoscreen: 2.5.0 -> 2.5.8-beta
user_login: GRBurst
html_url: https://github.com/NixOS/nixpkgs/pull/62144
updated_at: 2019-05-31 19:36:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update ancient version of vokoscreen to current beta. See discussion in #61053. The beta seems to very stable (tested it multiple times).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: protonmail-bridge: 1.1.4 -> 1.1.5
user_login: GRBurst
html_url: https://github.com/NixOS/nixpkgs/pull/62145
updated_at: 2019-05-29 02:03:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update to latest version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jetbrains.webstorm: 2019.1.2 -> 2019.1.3
user_login: sonercirit
html_url: https://github.com/NixOS/nixpkgs/pull/62146
updated_at: 2019-05-28 12:17:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  updated with update.pl, have not tested the package
  @c0bw3b can you take a look?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wxGTK31: 3.1.0 -> 3.1.2
user_login: ArdaXi
html_url: https://github.com/NixOS/nixpkgs/pull/62147
updated_at: 2019-06-09 11:40:55
body:
  ###### Motivation for this change
  In #55475 a crash bug was introduced in Prusa Slicer. After some investigation, this seemed to be a bug in wxWidgets 3.1.0 that was no longer present in 3.1.2. As 3.1.2 has been out for a while, it seemed like a good idea to upgrade the package.

  3.1.2 no longer accepts the `compat2[46]` options, which is why I copied the old file over and removed those configure flags. They seemed to be passed downstream however, so I did not remove the arguments entirely.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fixed derivation build error for jre on aarch64
user_login: netixx
html_url: https://github.com/NixOS/nixpkgs/issues/62148
updated_at: 2019-06-09 11:26:33
body:
  ## Issue description
  Error while building/downloading jre on aarch64:
  ```
  trying https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.3%2B7/OpenJDK11U-jre_aarch64_linux_hotspot_11.0.3_7.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  copying path '/nix/store/z39750n18nyhw7048ds8zpsgjs0ccdsn-gpgme-1.12.0' from 'https://cache.nixos.org'...
  100   643    0   643    0     0   1432      0 --:--:-- --:--:-- --:--:--  1432
  building '/nix/store/sf46lc0xzj3mkbc83wpnlzchj9l2m3ga-container-init.drv'...
  building '/nix/store/9biqlgm8db790xr5x33349dxs4rqkr4x-dbus-catalog.xml.drv'...
  copying path '/nix/store/n8b5350v0xswvl08mlra5asyy8nfsrdl-volume_key-0.3.11' from 'https://cache.nixos.org'...
  building '/nix/store/wgyac8d2yi0phyfbaq13rj2w7chg5mlp-etc-10-nixos.rules.drv'...
  building '/nix/store/lks66gm13aj64zw9qclj8vy213ra47lh-etc-bashrc.drv'...
  100 38.8M  100 38.8M    0     0  7149k      0  0:00:05  0:00:05 --:--:-- 9334k
  hash mismatch in fixed-output derivation '/nix/store/pc2krcggyflqbgpz6zlpzxr7hjyfdlif-OpenJDK11U-jre_aarch64_linux_hotspot_11.0.3_7.tar.gz':
    wanted: sha256:0hisjzgv29x2af0wvpy1c9j027qvv08cd9r9f0hg40wdczbbgxaa
    got:    sha256:0r45f358ih5xmygqm91g6nkq9d6nnjl8zz75kl4xbij00svzlcfy
  cannot build derivation '/nix/store/qcnj8vqvf5p11s4421j3rjbby7qn2hn5-adoptopenjdk-jre-hotspot-bin-11.0.3.drv': 1 dependencies couldn't be built
  ```


  ### Steps to reproduce
  The error occured when I added `services.xserver.desktopManager.kodi.enable = true;`. But any use of the jre under aarch64 should give the same result as long as free packages are used (i.e. not using the oracle jre build).


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"aarch64-linux"`
   - host os: `Linux 5.0.12, NixOS, 19.03.172463.6e29f22551d (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172753.f197f57bd33"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: hcxtools: init at 5.1.4
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62149
updated_at: 2019-05-30 07:13:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/ZerBea/hcxtools

  > Small set of tools convert packets from captures (h = hash, c = capture, convert and calculate candidates, x = different hashtypes) for the use with latest hashcat or John the Ripper. The tools are 100% compatible to hashcat and John the Ripper and recommended by hashcat.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.pyglet: hardcode library paths
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/62150
updated_at: 2019-05-28 12:58:36
body:
  ###### Motivation for this change

  The new way to find libraries (basically a switch statement) isn't particularly pretty, but its simple and reliable. The old way failed to load `libc`, since `libc.so` is actually a linker script so we need to directly provide the path to `libc.so.6`. Other libraries were missing completely.

  I tried to run the Cartpole example of rl-coach, which failed to render anything before and runs perfectly now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk-gnutella: 1.1.9 -> 1.1.14
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/62151
updated_at: 2019-05-28 12:54:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Package refresh
  and fix its build since it is currently failing on Hydra

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: atlassian-crowd: 3.4.3 -> 3.4.4
user_login: ciil
html_url: https://github.com/NixOS/nixpkgs/pull/62152
updated_at: 2019-05-29 15:07:07
body:
  Security update as per [upstream advisory](https://confluence.atlassian.com/crowd/crowd-security-advisory-2019-05-22-970260700.html).

  Fixes CVE-2019-11580.

  Will backport to 19.03 as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avahi: set service directory and refactor module
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/62153
updated_at: 2019-06-11 18:11:53
body:
  Re-opened PR against staging, includes changes proposed in #61945.

  ###### Motivation for this change
  Before this PR avahi used to look for service definitions in `etc/avahi/services` in its store path.
  First this leads to the situation mentioned in #60939 and it also makes adding custom services quite user-unfriendly, because they would have to be added to the build output of avahi.

  ###### Things done

  ##### Package:
  For the build `AVAHI_SERVICE_DIR` is now set to `/etc/avahi/services`.

  ##### Module:
  Types are now specified for all options.
  The fixed uid and gid for the avahi user have been removed
  and the avahi user is now in the avahi group.
  The the generic opening of the firewall for UDP port 5353 is
  now optional, but still defaults to true.

  The option `extraServiceFiles` was added to specify avahi
  service definitions, which are then placed in `/etc/avahi/services`.

  ##### Manual:
  Added a section mentioning the changes for avahi.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  #### fixes #60939

  /cc @Infinisil 


state: closed
title: halide: fix to llvm6
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/62154
updated_at: 2019-05-31 09:06:18
body:
  ###### Motivation for this change
  Halide fails to build with llvm7. The next halide release should be compatible with llvm7.

  cc @ck3d 

  ###### Things done
  * set `llvmPackages` to `llvmPackages_6`

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: NixOS tests waitForUnit does not handle oneshots
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/62155
updated_at: 2019-05-28 13:22:57
body:
  ## Issue description

  `$machine->waitForUnit(<oneshot>)`  fails when waiting for a unit that
  doesn't linger after activating.  I need a way to test that a oneshot fired, but
  I currently can't do that.

  ### Steps to reproduce

  The following test https://github.com/NixOS/nixpkgs/commit/55fb87d2b871db9f4bcb0e79651acf0228c9de52

  fails with:

  ```
  machine# [    7.379766] hello[606]: Hello, world!
  (sic)
  machine# [    8.686200] systemd[1]: Reached target Multi-User System.
  machine# [    8.690688] systemd[1]: Startup finished in 3.896s (kernel) + 4.760s (userspace) = 8.656s.
  machine: running command: systemctl --no-pager show "hello.service"

  machine: running command: systemctl --no-pager show "hello.service"
  machine: exit status 0
  (0.05 seconds)
  machine: running command: systemctl list-jobs --full 2>&1
  machine: exit status 0
  (0.03 seconds)
  machine: running command: systemctl --no-pager show "hello.service"
  machine: exit status 0
  (0.03 seconds)
  (10.65 seconds)
  error: unit ‘hello.service’ is inactive and there are no pending jobs
  (10.65 seconds)
  unit ‘hello.service’ is inactive and there are no pending jobs
  cleaning up
  killing machine (pid 597)
  (0.00 seconds)
  vde_switch: EOF on stdin, cleaning up and exiting
  vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
  builder for '/nix/store/x1vijpwc2pqdmx2rpssmviifafxjb65d-vm-test-run-oneshot.drv' failed with exit code 255
  error: build of '/nix/store/x1vijpwc2pqdmx2rpssmviifafxjb65d-vm-test-run-oneshot.drv' failed

  ```

  eventhough the oneshot did fire


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: Fix pkgs.biber for Darwin (alt)
user_login: boronine
html_url: https://github.com/NixOS/nixpkgs/pull/62156
updated_at: 2019-05-29 18:22:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR contains an alternative solution for https://github.com/NixOS/nixpkgs/pull/35477

  See comment: https://github.com/NixOS/nixpkgs/pull/35477#issuecomment-496517903

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/syncthing: run init only if a devices or folders are set
user_login: Lassulus
html_url: https://github.com/NixOS/nixpkgs/pull/62157
updated_at: 2019-05-30 01:02:19
body:
  ###### Motivation for this change
  All Folders/Devices which got added through the webinterface got removed. This fixes that issue


state: closed
title: swig: use pname and standardize meta
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/62158
updated_at: 2019-07-16 17:12:47
body:
  - pname makes it easier to override the version in an overlay and looks generally cleaner
  - Updated the meta sections to match between the various versions

  No real functional change, just cleanup.

  ###### Things done
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/mlmmj: use appropriate postfix options
user_login: fgaz
html_url: https://github.com/NixOS/nixpkgs/pull/62159
updated_at: 2019-06-18 09:05:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Use the appropriate options instead of extra*

  should make the module more interoperable with others

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested on my personal mail server


state: open
title: nixos/mlmmj: add more list headers
user_login: fgaz
html_url: https://github.com/NixOS/nixpkgs/pull/62160
updated_at: 2019-06-18 09:05:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  since we already add a couple of default headers, it makes sense to have
  a sensible default and add the unsubscribe header and friends

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qView: init at 2.0
user_login: acowley
html_url: https://github.com/NixOS/nixpkgs/pull/62161
updated_at: 2019-05-29 03:26:24
body:
  A fast, unobtrusive Qt-based image viewer.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trezord-go: 2.0.26 -> 2.0.27
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/62162
updated_at: 2019-05-29 14:39:35
body:
  ###### Motivation for this change

  https://github.com/trezor/trezord-go/releases/tag/v2.0.27

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.applicationinsights: init at 0.11.9
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62163
updated_at: 2019-06-03 00:50:59
body:
  ###### Motivation for this change
  Add more Azure support into Nixos packages.

  Not related to #60435 (separate pypi package and repo)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh result/
  /nix/store/hgyfrsfw3my1p14lbsmdz02ynmqz7cc0-python3.5-applicationinsights-0.11.9          95.0M


state: closed
title: orgPackages: 2018-12-30 -> 2019-05-27
user_login: benley
html_url: https://github.com/NixOS/nixpkgs/pull/62164
updated_at: 2019-06-21 18:41:56
body:
  ###### Motivation for this change
  Periodic update.  Includes org-mode 9.2.0 -> 9.2.3.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trinity: small clean up
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62165
updated_at: 2019-06-04 17:56:44
body:
  This also fixes the build with https://github.com/kernelslacker/trinity/commit/a5f32b9714613404e9f4699aaaad720f2bb033b4

  Ping @dezgeg

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.dynd: Fix build
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62166
updated_at: 2019-06-01 08:45:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  Ping @teh 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add libGL* aliases
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62167
updated_at: 2019-06-17 19:18:30
body:
  This should make things cleaner. Removes a few things from all-packages.nix that were unnecessary. Adds some aliases:

  - libGL_driver
  - mesa_noglu
  - mesa_driver

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add missing KDE applications
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/62168
updated_at: 2019-07-07 10:20:35
body:
  ## Issue description

  It would be good to package all of the KDE apps. Here is a list of a few that are missing in Nixpkgs. Feel free to add them!

  - [ ] analitza
  - [ ] audiocd-kio
  - [ ] blinken
  - [ ] bomber
  - [ ] bovo
  - [ ] cantor
  - [ ] cervisia
  - [ ] granatier
  - [ ] juk
  - [ ] kaffeine
  - [ ] kalgebra
  - [ ] kalzium
  - [ ] kamera
  - [ ] kanagram
  - [ ] kapman
  - [ ] kapptemplate
  - [ ] katomic
  - [ ] kblackbox
  - [ ] kblocks
  - [ ] kbounce
  - [ ] kbreakout
  - [ ] kbruch
  - [ ] kcron
  - [ ] kdiamond
  - [ ] kfloppy
  - [ ] kfourinline
  - [ ] kgeography
  - [ ] kgoldrunner
  - [ ] khangman
  - [ ] kigo
  - [ ] killbots
  - [ ] kiriki
  - [ ] kiten
  - [ ] kjumpingcube
  - [ ] klettres
  - [ ] klickety
  - [ ] klines
  - [ ] kmag
  - [ ] kmahjongg
  - [ ] kmines
  - [ ] kmousetool
  - [ ] kmouth
  - [ ] knavalbattle
  - [ ] knetwalk
  - [ ] kolf
  - [ ] kollision
  - [ ] kopete
  - [ ] kpat
  - [ ] kreversi
  - [ ] kshisen
  - [ ] ksirk
  - [ ] ksnakeduel
  - [ ] ksquares
  - [ ] kstars
  - [ ] ksudoku
  - [ ] kteatime
  - [ ] ktimer
  - [ ] ktuberling
  - [ ] kturtle
  - [ ] kubrick
  - [ ] kwave
  - [ ] kwordquiz
  - [ ] libkcompactdisc
  - [ ] lokalize
  - [ ] lskat
  - [ ] palapeli
  - [ ] parley
  - [ ] rocs
  - [ ] step
  - [ ] svgpart
  - [ ] sweeper
  - [ ] tellico
  - [ ] [umbrello](https://github.com/vcunat/nixpkgs/pull/new/p/umbrello)

  ### Steps to reproduce

  Up to date list here: https://repology.org/projects/?inrepo=kde_neon_user_lts&notinrepo=nix_unstable

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: Support libGL in non-NixOS Nixpkgs
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/62169
updated_at: 2019-07-06 08:31:37
body:
  ## Issue description

  Trying to figure out some solutions for https://github.com/NixOS/nixpkgs/issues/9415, but wanted to see whether these ideas are workable. Feedback on this is appreciated!

  The main goal here is to make libGL work out of the box on Nixpkgs without NixOS installed. This has been an issue for a long time, and could be fixed with adding `LD_LIBRARY_PATH`. I want this to work out of the box, though. I think there are two things we can do to improve this experience:

  - Patch libglvnd to fallback to `__GLX_VENDOR_LIBRARY_NAME=mesa` when no system GL driver is found. This is software-based and slower, but at least it will work in a "pure" way. This could increase closure size, but I think those drivers might already be there.

  - Add `/usr/lib/libGL.so` to the OpenGL RUNPATH. This is the location in almost every Linux distro, so it should be fairly predictable for us to use. This could be a libglvnd wrapped libGL though? This was already done for `/run/opengl-driver` in #60985. Ideally we could add `/usr/lib/libGL.so` without adding `/usr/lib/` to avoid adding tons of impurities.

  Discussed in https://discourse.nixos.org/t/software-rendering-using-mesa-not-possible/3023/8

  /cc @ambrop72 @vcunat @edahlgren @abbradar 


state: closed
title: spectacle: fix qdbus path in desktop shortcut
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/62170
updated_at: 2019-05-28 22:49:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Since KDE 19.04 the desktop shortcut of Spectacle is calling qdbus which is not in the PATH

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python2Packages.cmd2_8: 0.8.0 -> 0.8.9, fix build
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62171
updated_at: 2019-05-30 15:00:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  I haven't tried to build it on darwin

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kernel: Enable IPv6 support for IPVS (CONFIG_IP_VS_IPV6 y)
user_login: dsx
html_url: https://github.com/NixOS/nixpkgs/pull/62172
updated_at: 2019-06-08 08:23:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  IPv6 support for IPVS exists since 2.6.10 (released on December 24, 2004). With massive IPv6 adoption world-wide it is quite reasonable to have this enabled by default.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana: 6.2.0 -> 6.2.1
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/62173
updated_at: 2019-05-29 15:37:21
body:
  ###### Motivation for this change
  [Latest patch release](https://github.com/grafana/grafana/releases/tag/v6.2.1) that includes a few bug fixes and two enhancements.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (x86_64-linux & aarch64-linux)
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  **needs to be backported to 19.03**


state: closed
title: pingus: Fix build
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62174
updated_at: 2019-05-28 23:30:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Broken since #50293

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wordpress: create module to replace the httpd subservice
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/62175
updated_at: 2019-07-04 00:44:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Ultimately to remove usage of mod_php in all nixos modules.
  See https://github.com/NixOS/nixpkgs/pull/57752 for prior work, which is still pending.

  NOTE:
  - I have not updated relevant documentation yet, I'm waiting to get some feedback on the actual code before I do that.
  - Certain chunks of code were copy+pasted from the httpd subservice with as little fixup as possible, because I have never run a wordpress site so don't know that much about it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodePackages: init openstf
user_login: jollheef
html_url: https://github.com/NixOS/nixpkgs/pull/62176
updated_at: 2019-05-29 14:39:14
body:
  Hello,

  This commit introduce npm package for openstf.io.

  Node v10 is not yet supported by STF, so it's defined only for node v8.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: opengl: provide swrast as fallback when no GL drivers are found
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62177
updated_at: 2019-07-06 05:46:06
body:
  When no libGL drivers are found, we will fall back to “libGLX_mesa.so”
  which corresponds to the mesa “swrast” driver. This uses some X11 apis
  for rendering, and is suitable for many use cases of . This is still
  not as good as having the hardware drivers. Adding libGLX_mesa.so to
  the closures ends up adding about 1MB, which is signifcant but still
  acceptable.

  Fixes #62032
  Fixes #62169
  Fixes #9415

  /cc @ambrop72 @edahlgren

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Enables systemd-boot for ARM + fixes meson cpu families
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/62178
updated_at: 2019-05-29 03:18:38
body:
  See #61847 for the original PR.

  Targeting `staging` because the change to `meson` anyway causes a big rebuild to happen. (I had misled myself in believing that crossFile wouldn't be changed for non-cross, but its value change, thus the environment variable changes too.)

  * * *

  Note about `cpu_family`:

  This adds a lookup table to map between meson cpu families and our cpu names.

   * https://mesonbuild.com/Reference-tables.html#cpu-families

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - 🔲 Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - 🔲 Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kvantum: init at 0.11.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/62179
updated_at: 2019-06-18 18:29:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [`kvantum`](https://github.com/tsujan/Kvantum/tree/master/Kvantum) to nixpkgs.

  > Kvantum (by Pedram Pourang, a.k.a. Tsu Jan tsujan2000@gmail.com) is an SVG-based theme engine for Qt, tuned to KDE and LXQt, with an emphasis on elegance, usability and practicality. Its homepage is https://github.com/tsujan/Kvantum.
  > 
  > Kvantum has a default dark theme, which is inspired by the default theme of Enlightenment. Creation of realistic themes like that for KDE was my first reason to make Kvantum but it goes far beyond its default theme: you could make themes with very different looks and feels for it, whether they be photorealistic or cartoonish, 3D or flat, embellished or minimalistic, or something in between, and Kvantum will let you control almost every aspect of Qt widgets.
  > 
  > Kvantum also comes with extra themes that are installed as root with Qt5 installation and can be selected and activated by using Kvantum Manager.

  ![Default](https://user-images.githubusercontent.com/1217934/58519384-afb6b480-8189-11e9-8337-64a4fc52eef7.png)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: openssl: 1.1.1c, 1.0.2s
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62180
updated_at: 2019-05-29 17:46:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  These updates are described in this message:

  https://mta.openssl.org/pipermail/openssl-announce/2019-May/000150.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: newt: 0.52.20 -> 0.52.21
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62181
updated_at: 2019-06-04 06:32:25
body:
  ###### Motivation for this change

  https://pagure.io/newt/blob/134326743ac8063f79b6b34eb9d80ffdd55e6540/f/CHANGES#_1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: moosefs: 3.0.104 -> 3.0.105
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62182
updated_at: 2019-05-29 13:39:44
body:
  ###### Motivation for this change



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: earlyoom: 1.2 -> 1.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62183
updated_at: 2019-05-29 11:28:22
body:
  ###### Motivation for this change

  https://github.com/rfjakob/earlyoom/blob/v1.3/README.md#changelog

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libcanberra: add patch to stop crashing on wayland
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/62184
updated_at: 2019-05-30 07:55:33
body:
  ###### Motivation for this change

  Without the applied patch libcanberra assumes the display is an X11
  display and subsequently crashes on wayland.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libqalculate,qalculate-gtk: 3.1.0 -> 3.2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62185
updated_at: 2019-05-29 06:53:53
body:
  ###### Motivation for this change

  https://qalculate.github.io/news.html

  Also used by `nasc`, FWIW.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firejail: 0.9.58.2 -> 0.9.60
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62186
updated_at: 2019-05-31 03:43:46
body:
  ###### Motivation for this change

  https://firejail.wordpress.com/download-2/release-notes/

  (link not specific to this version, sorry!)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yubikey-manager: 2.1.0 -> 2.1.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62187
updated_at: 2019-05-29 06:29:02
body:
  ###### Motivation for this change

  https://developers.yubico.com/yubikey-manager/Release_Notes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: iptables: 1.8.2 -> 1.8.3, libnftnl: 1.1.2 -> 1.1.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62188
updated_at: 2019-06-04 06:35:17
body:
  ###### Motivation for this change

  Submitting together since iptables bump requires libnftnl update.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: e2fsprogs: 1.45.1 -> 1.45.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62189
updated_at: 2019-06-04 06:37:32
body:
  ###### Motivation for this change

  http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.45.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fonttools: 3.41.0 -> 3.42.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62190
updated_at: 2019-05-30 06:41:21
body:
  ###### Motivation for this change

  https://github.com/fonttools/fonttools/releases/tag/3.42.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: joplin-desktop: 1.0.143 -> 1.0.158
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62191
updated_at: 2019-05-29 10:48:07
body:
  ###### Motivation for this change

  https://github.com/laurent22/joplin/releases/tag/v1.0.158

  and previous, see:

  https://github.com/laurent22/joplin/releases

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mplus-outline-fonts: 063 -> 063a
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62192
updated_at: 2019-05-29 15:09:22
body:
  ###### Motivation for this change

  https://osdn.net/projects/mplus-fonts/news/26002
  (google translate helps for those who can't read this, including me :))

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xonsh: 0.9.0 -> 0.9.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62194
updated_at: 2019-05-29 06:31:26
body:
  ###### Motivation for this change

  Update, woohoo!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mno16: init at 1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62195
updated_at: 2019-05-31 03:35:38
body:
  ###### Motivation for this change

  tiny monospaced font :D

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: harfbuzz: 2.3.1 -> 2.5.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62196
updated_at: 2019-05-31 04:12:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  We skipped 2.4.0 due to upstream repeatedly (!) changing the tarball,
  hopefully that's over now :3.

  https://github.com/harfbuzz/harfbuzz/releases/tag/2.5.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: agave: 009 -> v10
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62197
updated_at: 2019-05-31 03:34:32
body:
  ###### Motivation for this change

  https://github.com/agarick/agave/releases/tag/v10

  Powerline glyphs and other goodness!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dedup: 1.0 -> 2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62199
updated_at: 2019-05-30 08:36:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update deps, enable tests.

  https://git.2f30.org/dedup/file/CHANGELOG.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodejs-10_x: 10.15.3 -> 10.16.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62200
updated_at: 2019-05-30 03:13:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://nodejs.org/en/blog/release/v10.16.0/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: feedreader: 2.8.2 -> 2.9.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62201
updated_at: 2019-05-29 10:39:52
body:
  ###### Motivation for this change

  update goodness

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnupg: 2.2.15 -> 2.2.16
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62202
updated_at: 2019-05-29 08:47:31
body:
  ###### Motivation for this change

  https://dev.gnupg.org/T4509

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matrix-synapse: 0.95.5 -> 0.95.5.1
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62203
updated_at: 2019-05-30 01:15:47
body:
  ###### Motivation for this change

  This version is needed for compatibility with 1.0.0 and the new v4 rooms.

  Also, enable systemd support based on host OS.

  https://matrix.org/blog/2019/05/21/synapse-0-99-5-1-released

  I will deploy this tonight to test it out.

  Cc:  @ralith @roblabla @ekleog @pacien 


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: quaternion: 0.0.9.4 -> 0.0.9.4c
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62204
updated_at: 2019-06-14 01:52:35
body:
  ###### Motivation for this change

  The libqmatrixclient change is needed to fix a bug with direct chats being marked unread incorrectly and the quaternion change is technically not needed as the changes only relate to appstream packaging but as we are rebuilding it anyway due to libqmatrixclient changing, we might as well.

  Will test it out tonight.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages.phpstan: 0.11.7 -> 0.11.8
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62205
updated_at: 2019-05-29 10:18:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.8

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: watchexec: 1.10.1 -> 1.10.2
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62206
updated_at: 2019-05-29 11:16:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/watchexec/watchexec/releases/tag/1.10.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xarchiver: 0.5.4.12 -> 0.5.4.14
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62207
updated_at: 2019-05-29 10:21:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changelog seems only at the level of 5.4.x:

  https://github.com/ib/xarchiver/blob/0.5.4.14/ChangeLog

  Commits from 0.5.4.12 to 0.5.4.14:

  https://github.com/ib/xarchiver/compare/0.5.4.12...0.5.4.14


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sysdig: 0.25 -> 0.26.1
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/62208
updated_at: 2019-05-29 08:25:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  fixes build with 5.1 kernel.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yubico-manager-qt can't find ykpers lib
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/issues/62210
updated_at: 2019-05-31 08:48:07
body:
  ## Issue description
  Can't configure yubikey OTP with `yubikey-manager-qt`, a small red square appear at the bottom of the screen when getting to the OTP page.

  ```
  $LC_ALL=C ykman-gui --log-level DEBUG
  [...]
  2019-05-29T10:41:04+0200 ERROR [yubikey.wrapped:64] Uncaught exception
  Traceback (most recent call last):
    File "qrc:///py/yubikey.py", line 49, in wrapped
      return f(*args, **kwargs)
    File "qrc:///py/yubikey.py", line 255, in slots_status
      with self._open_otp_controller() as controller:
    File "qrc:///py/yubikey.py", line 139, in _open_otp_controller
      'Could not find the "ykpers" library. Please ensure that '
  Exception: Could not find the "ykpers" library. Please ensure that YubiKey Manager was installed correctly.
  ```

  I am guessing the issue comes from https://github.com/NixOS/nixpkgs/commit/703e8763d5d0eca99e0d86c22f4d863b903fbb0f#diff-9105fd92b2a32108e337391d7b9a23bbL53.
  ### Steps to reproduce
  1. Start `yubikey-manager-qt`
  2. Connect a yubikey
  3. Got to the page Applications -> OTP


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.45, NixOS, 19.03.172745.37698198717 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172745.37698198717, nixos-hardware, nixos-unstable-19.09pre180241.971b731fc18"`
   - channels(bricewge): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  - YubiKey Manager 1.1.1

  @avdv @Ma27 


state: open
title: deployment.autoLuks deprecation
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/issues/62211
updated_at: 2019-07-04 21:24:53
body:
  ## Issue description

  This issue is a placeholder for all those users raising their voices in response to the deprecation of NixOps `deployment.autoLuks` introduced in #61321 (and backported to 19.03).

  **Please let us know if you are using the feature!**

  NixOps `deployment.autoLuks` is a feature to automatically handle block devices and luks encryption without storing secrets on the target devices.


  Even in its current state it seems to be halfway broken (e.g. removing a LUKS device panics systemd), and [people expressed doubts on whether it's being used at all](https://github.com/NixOS/nixops/pull/1156#issuecomment-496507442).

  Looking at the NixOps repository and searching for public infrastructure repositories didn't yield a large (or any) userbase of the feature. Thus we are asking for feedback if you are using it. 

  The changes previously done to our systemd fork included changes to the startup unit ordering. The local filesystems were no longer part of the very basic system init, allowing sshd and similar processes to start without finishing all mount units.

  Due to those relaxed boot requirements a bunch of errors with state and runtime directories appeared. There were some fixes but they are still incomplete (e.g. `nixos-rebuild switch` regenerates all the state directories but reboots do not have the same guarantee).
  Backing out of these changes and restoring a sane boot order for the price of requiring a few more lines of configuration in NixOps setups seems like a reasonable tradeoff.


  ### Why did this become necessary?

  In the past our systemd fork carried a patch (https://github.com/NixOS/systemd/commit/ce79214307f59fdd567271a0cad7be67e05c46ab) that removed the `local-fs.target` from the `sysinit.target`. This allowed services such as sshd to start while not all of the local filesystems were mounted, thus making it possible to send over keys using `sshd.service`. While probably a plausible workaround at the time this caused a bit of weird behavior down the road.

  Systemd didn't support `_netdev` and subsequently struggled with all kinds of network block devices until roughly 2014.


  Since systemd supports managing `StateDirectory`, `RuntimeDirectory` , etc (https://www.freedesktop.org/software/systemd/man/systemd.exec.html) and `systemd-tmpfiles` (https://www.freedesktop.org/software/systemd/man/systemd-tmpfiles.html) and their usage increased (even inside systemd itself), the amount of unexpected side effects did increase.

  While probably not noticeable for most people there is a race condition between the folders in `/run/` and `/var/lib/` being generated and the remaining system coming up. In many cases we might just be lucky that all the directories exist. In general it lead to many `PreStart` scripts that created those directories, if they are missing. Those in turn required to be priviledged since most daemons are not being run with root privileges. The option we used to turn those scripts into privileged scripts is now deprecated. We have an ongoing effort to replace them where possible (#56265, #62050, …).

  Besides those, we are trying to reduce the amount of custom patches that are being applied to systemd. In the long run it should become easier to maintain our systemd package. Eventually we would like to upstream some of our changes in a portable way. Things that aren't strictly required for systemd to work on NixOS should therefore go away.


  ### What can I do to make it work again?

  Make sure you add `_netdev` <!-- add where? fstab? $nix.conf file? --> to all the filesystems you are mounting via the `autoLuks` module. Adding that option moves them from the `local-fs.target` to `remote-fs.target` which will allow your system to start the sshd even without the luks volumes. Afterwards you can use `nixops send-keys` again.

  Do not forget to read the error message you got and set the option that was mentioned there.


state: closed
title: krita: 4.1.8 -> 4.2.0
user_login: d3rped
html_url: https://github.com/NixOS/nixpkgs/pull/62212
updated_at: 2019-06-01 14:43:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Krita 4.2.0 has been [released](https://krita.org/en/krita-4-2-release-notes/).

  ###### Things done
  - Updated version number and checksum
  - Added new dependency [quazip](https://krita.org/en/item/new-test-builds-changes-to-flow-and-saving-loading/)

  ###### Things to do
  - [ ] we may need to update qt5, are [these changes](https://phabricator.kde.org/T10838) already in nixpkgs? 
  - [ ] update [gmic_krita_qt](https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/graphics/gmic_krita_qt/default.nix), I should probably make a [separate PR](https://github.com/NixOS/nixpkgs/pull/62270) for that. (haven't used this so far, ?the current version seems to work with Krita 4.2.0 though?)
  - [x] **DONE:** I'm not really familiar with CMake magic, I've set `QUAZIP_INCLUDE_DIR` and `QUAZIP_LIBRARIES` as environment variables but they are still not found during build...  the relevant CMake files can be found [here](https://github.com/KDE/krita/blob/v4.2.0/CMakeLists.txt#L778) and [here](https://github.com/KDE/krita/blob/v4.2.0/libs/store/CMakeLists.txt).
  - [x] **DONE:** It now fails bceause ~~there are ?missing functions? in quazip~~ I'm an idiot - `QUAZIP_LIBRARIES` does not expect a directory.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: conmon: 0.0.1pre52_6905a4d -> 0.2.0
user_login: saschagrunert
html_url: https://github.com/NixOS/nixpkgs/pull/62213
updated_at: 2019-06-11 17:48:55
body:
  Update conmon to v0.2.0 and move it into a dedicated package. Since we
  are now using conmon as dedicated package, cri-o does not need to built
  it, too.

  cc @vdemeester @thoughtpolice 


state: closed
title: mill: 0.3.6 -> 0.4.0
user_login: karolchmist
html_url: https://github.com/NixOS/nixpkgs/pull/62214
updated_at: 2019-06-01 20:35:31
body:
  ###### Motivation for this change

  Update to the latest version of mill : https://github.com/lihaoyi/mill/releases

  The `mill` binary changed and the result built file was no longer working, so I've adapted the `makeWrapper` command as well.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: igprof: init at v5.9.16
user_login: ktf
html_url: https://github.com/NixOS/nixpkgs/pull/62215
updated_at: 2019-06-02 09:55:23
body:
  ###### Motivation for this change

  Add IgProf profiler.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ddclient fails to build due to a comment in a multi-line command
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/62216
updated_at: 2019-05-30 21:56:55
body:
  ## Issue description

  Building `ddclient` on nixpkgs master fails with the error:

  ```
  [...]
  configuring
  /nix/store/f0rda5z44drinxg2b2iyx0qdrw32b02q-builder.sh: line 19: --replace: command not found
  note: keeping build directory '/tmp/nix-build-perl5.28.2-ddclient-3.9.0.drv-3'
  builder for '/nix/store/9fzb76zh997rr8m9w7rr8zh6py63ihh8-perl5.28.2-ddclient-3.9.0.drv' failed with exit code 127
  error: build of '/nix/store/9fzb76zh997rr8m9w7rr8zh6py63ihh8-perl5.28.2-ddclient-3.9.0.drv' failed
  ```

  The problem seems to be comment in a multi-line command in `preConfigure` phase introduced in PR https://github.com/NixOS/nixpkgs/pull/62068:
  ``` nix
    preConfigure = ''
      touch Makefile.PL
      substituteInPlace ddclient \
        --replace 'in the output of ifconfig' 'in the output of ip addr show' \
        --replace 'ifconfig -a'               '${iproute}/sbin/ip addr show' \
        --replace 'ifconfig $arg'             '${iproute}/sbin/ip addr show $arg' \
     # Until we get the patchShebangs fixed (issue #55786) we need to patch this manually
        --replace '/usr/bin/perl'		    '${perl}/bin/perl'
    '';
  ```

  cc @mmahut @aanderse 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.4, NixOS, 19.09pre180832.c7bcd4277cc (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre181008.eccb90a2d99"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: recurseIntoAttrs of coqPackages
user_login: CohenCyril
html_url: https://github.com/NixOS/nixpkgs/pull/62217
updated_at: 2019-06-15 16:22:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The purpose of this PR is to trigger the build of coqPackages in hydra to make available directly all the binary `.vo` final

  @vbgl was this the right thing to do?

  ###### Things done
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rofi-pass: refactor add new optional dependency pass-otp
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/62218
updated_at: 2019-05-30 13:42:37
body:
  ###### Motivation for this change

  Rofi-pass as of a year ago added support for OTP passwords. This
  dependency is "optional" but extremely nice to have as a default.

  https://github.com/carnager/rofi-pass#requirements

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: add a callNode2nix similar to callCabal2nix
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/62219
updated_at: 2019-05-29 14:13:59
body:
  ## Issue description
  I am trying to package https://github.com/iamcco/markdown-preview.nvim (tried another preview plugin before but it would show an empty preview ;s ). This one relies on node packages so I've dived into the node ecosystem (also because I would be interested in fetching node packages for coc.nvim ).

  My understanding (since the doc is so short: https://nixos.org/nixpkgs/manual/#node.js-packages) is that one needs to write a generate.sh and pkgs.json  (taking pkgs/development/web/remarkjs/ as an example) and calling generate.sh will generate nodepkgs.nix node-env.nix.

  My question is then:
  - can I just skip the previous steps and do node.withPackages(p: [] ) ?
  - would it be possible to add a callNode2nix as callCabal2nix ? this would allow to alleviate some workload and generate the code from the source pacakges.json instead of providing ours ? 


state: closed
title: keybase,keybase-gui: 3.2.2 -> 4.0.0
user_login: madjar
html_url: https://github.com/NixOS/nixpkgs/pull/62220
updated_at: 2019-06-04 15:01:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade keybase to 4.0.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfsUnstable: 0.8.0-rc5 -> 0.8.0 [19.03 backport]
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/62222
updated_at: 2019-05-30 06:39:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zbar: 0.22 -> 0.23
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/62223
updated_at: 2019-06-02 10:33:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update zbar to `0.23` and add dbus configuration `org.linuxtv.Zbar.conf` to the closure.
  This version adds support for `--nodbus` to avoid errors like `Name Error (Connection ":1.1753" is not allowed to own the service "org.linuxtv.Zbar" due to security policies in the configuration file)` when dbus isn't in `services.dbus.packages`, as it's currently the case.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  @delroth @rasendubi 
  ---


state: closed
title: ddclient: fix fallout from #62068
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/62224
updated_at: 2019-05-29 18:54:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/62216

  @romildo Thanks. I feel pretty silly about that...
  @mmahut Sorry. I really should have done a final check on your PR. My bad.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xbanish: 1.5 -> 1.6
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/62225
updated_at: 2019-05-29 20:34:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Updating xbanish to `1.6`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @choochootrain 


state: closed
title: colorls: init at 1.2.0
user_login: lukebfox
html_url: https://github.com/NixOS/nixpkgs/pull/62226
updated_at: 2019-05-31 16:59:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `colorls` is a tool which beautifies the terminal's ls command, with color and icons.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/malloc: add scudo from LLVM compiler-rt
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/62227
updated_at: 2019-05-29 18:23:26
body:
  ###### Motivation for this change

  The Scudo allocator is a good compromise between security, performance and compatibility. The GrapheneOS allocator which is currently the only "secure" allocator option in NixOS is incompatible with Nix itself (due to coping badly with tons of small allocs) and has a fairly big overhead.

  Scudo doesn't go as far in terms of error checking as the Graphene allocator (Graphene is closer to ASAN/MSAN). But being able to run Nix is fairly important :-) It's around a 20% CPU time increase on some test nix evaluations I've done compared to libc malloc.

  See:

  - https://llvm.org/docs/ScudoHardenedAllocator.html
  - https://android-developers.googleblog.com/2019/05/queue-hardening-enhancements.html which mentions Android Q planning to use Scudo for some security critical components.

  @joachifm

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Upgrading the latest bootable Azure image to stable requires stepping, results in broken image
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/62228
updated_at: 2019-06-03 05:53:44
body:
  ## Issue description

  1. The Azure images are old. One of them doesn't work. I believe the one that does work is the NixOps bootstrap image and lacks a channel out of the box. For the sake of this bug, I'm starting with this VHD: "https://nixos.blob.core.windows.net/images/nixos-image-16.09.1694.019dcc3-x86_64-linux.vhd"

  2. You cannot upgrade from the latest to `19.03` or `nixos-unstable` directly. Instead I've found that I can do 16.09 -> 17.03 -> 18.03 -> 19.03 and everything works out. (I'll include the outputs from failed attempts when I try again. It did try to workaround not having the right version of Nix, but it basically kept failing on an evaluation in some specific gtk derivation deep down in.)

  3. Except not really. If you upgrade to nixos-unstable and shut down the VM and try to start it, it will fail. It looks like the Grub entries are using FSUUID values and maybe the right kernel module isn't loaded for them to appear under those names? All I know is that the partuuid is there before shutdown, and then grub complains it can't find it on boot.

  ![screenshot-1559158913](https://user-images.githubusercontent.com/327028/58586088-28138900-820f-11e9-8fee-e7f9dac7c719.png)

  I'll be repeating this again today, in an attempt to get something work stably.


state: closed
title: tahoe-lafs: Fix build
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62229
updated_at: 2019-05-30 06:38:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://hydra.nixos.org/build/94279549

  Ping @MostAwesomeDude 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pytorch and torchvision conflict when building with cuda support
user_login: stites
html_url: https://github.com/NixOS/nixpkgs/issues/62230
updated_at: 2019-05-29 20:30:25
body:
  ## Issue description

  @teh @thoughtpolice

  Including both `pytorch` and `torchvision` on `<unstable>.python36.withPackages` fails to compile when pytorch is overloaded with cuda support. It looks like there's just a doubly-imported `.convert-caffe2-to-onnx-wrapped` file, although I think the same probably goes for all of the shared transitive dependencies. Here are the logs:

  ```
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/cjrd7vaq3vq5wa3yshwqkxpl1s28fjs9-python3-3.6.8-env.drv
    /nix/store/cknj80r4cvd38ndf7v6ib3ra3387a8ck-system-path.drv
    /nix/store/vhygvkslg4c6liz1n3kjbsai02r7vgl3-xsession.drv
    /nix/store/llpaf8aknf52lxzg8872b0jdqq88hfgv-desktops.drv
    /nix/store/p5ric6q3aj2vqvb927y80za8k95wc3jp-xsession-wrapper.drv
    /nix/store/3xr2hschpif91jb7v05bv815kb4pdv22-lightdm.conf.drv
    /nix/store/gyr4ip1x2dwsdladmmbw1jjrdapfjsih-unit-accounts-daemon.service.drv
    /nix/store/y1rj4v4pr68fb075k0f27p6zgmi6bvjc-dbus-1.drv
    /nix/store/h0sclbfx3s9k3xrvkgms7v2bk61p8a98-unit-dbus.service.drv
    /nix/store/h4bdb7pv5305k43awrgq0l9hv2x5rr7q-user-units.drv
    /nix/store/m8vh4pfznrw3n7r9lf1iyywmyajzpzyg-unit-dbus.service.drv
    /nix/store/r7icywrm8lfbpdxff50h04971a4y9pr8-unit-polkit.service.drv
    /nix/store/wvmxjkcj72zmimsw55g2hfkkak049wr1-unit-systemd-fsck-.service.drv
    /nix/store/lkv5w7wsh0ji7xdqq1ib5w25kk0k5765-system-units.drv
    /nix/store/nngczgipn903c9zj50rf4y1ry6ka76d0-etc.drv
    /nix/store/pzl9w1qxss6gzylvqram735md6ry21qw-nixos-system-mirzakhani-19.03.172657.cdec6217d98.drv
  building '/nix/store/cjrd7vaq3vq5wa3yshwqkxpl1s28fjs9-python3-3.6.8-env.drv'...
  collision between `/nix/store/y8d5r83m7gq19d9y8whn0mhs019yih0a-python3.6-pytorch-1.0.0/bin/.convert-caffe2-to-onnx-wrapped' and `/nix/store/pinfh35jcjldm4rmw4f1fb99a77xvqfr-python3.6-pytorch-1.0.0/bin/.convert-caffe2-to-onnx-wrapped'
  builder for '/nix/store/cjrd7vaq3vq5wa3yshwqkxpl1s28fjs9-python3-3.6.8-env.drv' failed with exit code 255
  cannot build derivation '/nix/store/cknj80r4cvd38ndf7v6ib3ra3387a8ck-system-path.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/y1rj4v4pr68fb075k0f27p6zgmi6bvjc-dbus-1.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/gyr4ip1x2dwsdladmmbw1jjrdapfjsih-unit-accounts-daemon.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/r7icywrm8lfbpdxff50h04971a4y9pr8-unit-polkit.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/wvmxjkcj72zmimsw55g2hfkkak049wr1-unit-systemd-fsck-.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/vhygvkslg4c6liz1n3kjbsai02r7vgl3-xsession.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/llpaf8aknf52lxzg8872b0jdqq88hfgv-desktops.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/h0sclbfx3s9k3xrvkgms7v2bk61p8a98-unit-dbus.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/m8vh4pfznrw3n7r9lf1iyywmyajzpzyg-unit-dbus.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/p5ric6q3aj2vqvb927y80za8k95wc3jp-xsession-wrapper.drv': 2 dependencies couldn't be built
  cannot build derivation '/nix/store/3xr2hschpif91jb7v05bv815kb4pdv22-lightdm.conf.drv': 2 dependencies couldn't be built
  cannot build derivation '/nix/store/lkv5w7wsh0ji7xdqq1ib5w25kk0k5765-system-units.drv': 4 dependencies couldn't be built
  cannot build derivation '/nix/store/h4bdb7pv5305k43awrgq0l9hv2x5rr7q-user-units.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/nngczgipn903c9zj50rf4y1ry6ka76d0-etc.drv': 5 dependencies couldn't be built
  cannot build derivation '/nix/store/pzl9w1qxss6gzylvqram735md6ry21qw-nixos-system-mirzakhani-19.03.172657.cdec6217d98.drv': 2 dependencies couldn't be built
  error: build of '/nix/store/pzl9w1qxss6gzylvqram735md6ry21qw-nixos-system-mirzakhani-19.03.172657.cdec6217d98.drv' failed
  ```

  ### Steps to reproduce

  On an unstable branch, or with `unstable = import <unstable> { };` in packageOverrides (I also set `config = config // <allowUnfree>` but this isn't neccesary to reproduce). This must be on unstable to include fix from #58934 -- you must also use python36 since python37 is still broken via #58934. 

  Add the following to your `/etc/nixos/configuration.nix`:

  ```nix
  environment.systemPackages = with pkgs; [
    (unstable.python36.withPackages (ps: with ps; [
        (pytorch.override {
          cudaSupport = true;
          cudatoolkit = pkgs.cudatoolkit_10;
          cudnn = pkgs.cudnn_cudatoolkit_10;
        })
        torchvision
    ]))
  ];
  ```

  And run `nixos-rebuild build`. You can also set `cudaSupport = false;` in the pytorch overrides to watch this build successfully.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.44, NixOS, 19.03.172657.cdec6217d98 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(stites): `"home-manager"`
   - channels(root): `"nixos-19.03.172657.cdec6217d98, unstable-19.09pre180301.650a295621b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: pythonPackages.pyworld: init at 0.2.8
user_login: hyphon81
html_url: https://github.com/NixOS/nixpkgs/pull/62231
updated_at: 2019-05-30 17:46:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.curio: patch tests
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62232
updated_at: 2019-07-09 07:46:44
body:
  ###### Motivation for this change
  The tests currently will fail with 
  ```
  $ nix-shell -p python36Packages.curio
  ...
  running install tests
  ImportError while loading conftest '/build/curio-0.9/tests/conftest.py'.
  py._path.local.LocalPath.ImportMismatchError: ('conftest', '/Users/beazley/Desktop/Projects/junk/curio/tests/conftest.py', local('/build/curio-0.9/tests/conftest.py'))
  ```

  The package was distributed with a `tests/__pycache__/`  that is causing it to read invalid information.

  [I opened an issue on his repo to fix the pypi distribution](https://github.com/dabeaz/curio/issues/301), this is an temporary fix

  @marsam 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.cython: 0.29.7 -> 0.29.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62233
updated_at: 2019-05-30 06:52:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/cython/cython/releases/tag/0.29.9
  https://github.com/cython/cython/releases/tag/0.29.8

  (This seems reasonable to update minors, but apologies if not just LMK
  :))

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresql litters $out/share directory
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/62235
updated_at: 2019-06-02 00:50:47
body:
  ## Issue description

  postgresql is littered with files in $out/share. They should go in $out/share/postgresql.

  ### Steps to reproduce

  ```
  $ ls -1 /nix/store/rgnwfbhybj5zykg4fy38yd8f229ga44f-postgresql-9.6.12/share
  conversion_create.sql
  extension
  information_schema.sql
  pg_hba.conf.sample
  pg_ident.conf.sample
  pg_service.conf.sample
  postgres.bki
  postgres.description
  postgres.shdescription
  postgresql.conf.sample
  psqlrc.sample
  recovery.conf.sample
  snowball_create.sql
  sql_features.txt
  system_views.sql
  timezonesets
  tsearch_data
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: New `environment.memoryAllocator.provider` does not apply to daemons
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/issues/62236
updated_at: 2019-05-30 09:31:55
body:
  ## Issue description

  https://github.com/NixOS/nixpkgs/pull/60187 from @joachifm introduced the ability to configure the memory allocator used on the system. However, as currently implemented, the chosen allocator is only used by user environments that source /etc/profile. Importantly, systemd units do not implicitly end up using the allocator, which greatly limits the usefulness of the setting for security hardening.

  ### Steps to reproduce

  1. `environment.memoryAllocator.provider = "scudo"; # or whatever you prefer`
  2. `grep scudo /proc/xxx/maps` where xxx is the PID of a system daemon exposed to the internet (e.g. sshd).

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.5-hardened, NixOS, 19.09.git.024f0fa (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(delroth): `""`
   - nixpkgs: `/nix/store/hwyj31rbiqyyn9lc38l8m8j0rjinqm83-nixpkgs`


state: closed
title: openimageio2: init at 2.0.8
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/62237
updated_at: 2019-05-31 11:56:08
body:
  ###### Motivation for this change
  We already have an older version which some programs still depend on so I added it as a separate expression.

  cc @cillianderoiste 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Diffed the directory tree of `openimage` and there do not appear to be any changes.
  - [x] Built app against `openimage2`
  - [x] Checked that the `.pc` file in `openimage2` looks correct
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/malloc: apply allocator settings to systemd units
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/62238
updated_at: 2019-05-31 04:53:53
body:
  ###### Motivation for this change

  #62236 

  This PR uses systemd's system.conf/user.conf "DefaultEnvironment" feature to set the allocator's LD_PRELOAD near-globally.

  I've only tested this with Scudo, not with Graphene, so no idea if it's going to break Graphene allocator systems further than they are already. With this PR, I see almost all processes on my system using the configured allocator. The only exceptions are:

  - chromium (but that's expected, they have their own allocator I imagine)
  - sddm-helper and 1-2 /bin/sh processes it spawns. Haven't looked into what's going on there, but I don't particularly care much either.

  @GrahamcOfBorg test hardened

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gscan2pdf: 2.3.0 -> 2.5.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62239
updated_at: 2019-06-07 19:26:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://mail.gnome.org/archives/gnome-announce-list/2019-May/msg00008.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libertinus: 6.8 -> 6.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62240
updated_at: 2019-06-04 06:30:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Improved version of one of the key open fonts!

  https://github.com/alif-type/libertinus/releases/tag/v6.9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: national-park-typeface: init at 206464
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62241
updated_at: 2019-06-04 06:30:04
body:
  ###### Motivation for this change

  Add this unique font :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nodePackages: automatic regeneration is hard to audit
user_login: ryantm
html_url: https://github.com/NixOS/nixpkgs/issues/62243
updated_at: 2019-06-03 19:21:44
body:
  When the nodePacakges is regenerated, like in https://github.com/NixOS/nixpkgs/pull/62221, it is hard to determine if the changes are okay. My main concern at this point is the file contains many fetchurl URLs linking to https://registry.npmjs.org/. What if one of them points at some malicious place instead?

  I think it would be better if this node-packages file just contained the sha512 hash, because the fetchurl portion can be refactored into one function that transforms the attrset, adding in the fetchurl part.


state: open
title: OBS-Studio: Stage is transparent under Wayland (sway)
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/62244
updated_at: 2019-05-30 06:43:49
body:
  ## Issue description

  When using OBS-Studio with Wayland, the stage is transparent instead of visible. This makes using OBS highly impractical. It can be worked around by launching with `env QT_QPA_PLATFORM=xcb obs`

  ### Steps to reproduce

  1. Make sure you're using Wayland. (It's possible this only repros under Sway.
  2. Make sure `qt5.qtwayland` is available in your (system) environment.
  3. Open OBS-Studio with the QT Wayland backend.
  4. Observe the other windows or background shining through.

  ![output](https://user-images.githubusercontent.com/327028/58612966-30001700-8269-11e9-9094-48cb1ff627b8.png)

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: Python package set
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/62245
updated_at: 2019-06-15 09:00:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update some packages I maintain along with patch updates for all other packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: datadog-agent: fix sha256 sum
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62246
updated_at: 2019-05-30 15:48:31
body:
  ###### Motivation for this change
  Fix sha256 sum in datadog agent v6.11.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex: 1.15.4.994 -> 1.15.6.1079
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/62247
updated_at: 2019-06-03 21:02:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to latest version (non plexpass).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
  Sucessfully running and tested on my NixOS server.


  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: solc: 0.5.8 -> 0.5.9
user_login: sifmelcara
html_url: https://github.com/NixOS/nixpkgs/pull/62248
updated_at: 2019-06-01 13:44:51
body:
  ###### Motivation for this change
  Update the package.

  ###### Things done

  I only tested it on NixOS and Linux. (it should also be fine on darwin).

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.salmon-mail: 3.1.0 -> 3.1.1
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/62249
updated_at: 2019-05-31 05:15:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade salmon-mail. Use this instead of #62117.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gpxsee: 7.1 -> 7.8
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62251
updated_at: 2019-06-07 20:10:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  [changelog](https://build.opensuse.org/package/view_file/home:tumic:GPXSee/gpxsee/gpxsee.changes)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [systemd] drop "Start getty on lxc" / 8967446c29e0fa1a8a641989b59e1c8f61b392e7
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/issues/62252
updated_at: 2019-05-30 11:08:19
body:
  This probably became obsolete due to https://github.com/systemd/systemd/blob/master/src/getty-generator/getty-generator.c#L109.


state: closed
title: iperf manpage missing
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/issues/62255
updated_at: 2019-06-08 08:21:52
body:
  ## Issue description

  iperf has a manpage according to https://linux.die.net/man/1/iperf, but it’s not in the nix package.

  ### Steps to reproduce

  ```
  nix-shell -p iperf --run 'man iperf'
  ```

  cc @fpletz as maintainer.


state: closed
title: dune: 1.9.2 -> 1.10.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62256
updated_at: 2019-07-05 12:28:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/ocaml/dune/releases/tag/1.10.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefoxPackages.tor-browser: 8.0.9 -> 8.5.0
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/62257
updated_at: 2019-05-30 13:47:56
body:
  # `git log`

  - firefoxPackages.tor-browser: 8.0.9 -> 8.5.0

    Actually, more like -> 8.5.0.1 as this version is made against the
    branch with the pending fixup patch applied.

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (2):
      - firefoxPackages.tor-browser
      - tor-browser-bundle
  - On aarch64-linux: ditto
  - On x86_64-darwin:
    - Updated (1):
      - firefoxPackages.tor-browser

  /cc @joachifm


state: closed
title: flexget: fix build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62258
updated_at: 2019-06-02 20:51:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Flexget uses `zxcvbn-python` instead of `zxcvbn`. Fixes https://github.com/NixOS/nixpkgs/issues/62110

  cc: @sjau 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.gruvbox-community: init at 2019-05-31
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/62259
updated_at: 2019-05-31 20:55:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The [original Gruvbox colorscheme](https://github.com/morhetz/gruvbox) has gone unmaintained for a while. A [new fork](https://github.com/gruvbox-community/gruvbox) has been made recently and already has good number of fixes and merged PRs. Since it is pretty hard to have breaking changes with a colorscheme, it seemed logical to me to push it to nixpkgs ^^

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yubikey-manager: add zsh completion and manual
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/62260
updated_at: 2019-05-30 19:41:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add manual and zsh completion to `yubikey-manager`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @Mic92 @benley 


state: closed
title: yubikey-manager-gui: revert part of 2e359d9
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/62261
updated_at: 2019-05-31 08:54:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes #62210 by reverting part of 2e359d9.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @Ma27 I would like your take on this since you cleaned up #55587 with the aforementioned commit.


state: open
title: lib/make-ext4: bump fudge factor to 96 MiB
user_login: yegortimoshenko
html_url: https://github.com/NixOS/nixpkgs/pull/62262
updated_at: 2019-05-31 02:26:23
body:
  ###### Motivation for this change

  `resize2fs` seems to have a block miscalculation bug that requires fudge factor increase from 16 MiB all the way up to ~96 MiB~ 128 MiB.

  I'm pretty sure miscalculation bug is specific to Aarch64, since I can build ext4 images that are only 20-30 blocks away on x86-64 just fine, however I'm not entirely sure since I haven't tested it with exact same filesystems.

  Issue can be reproduced by running `nix-build https://github.com/transumption/holoportos/archive/6b6497c1fde9c143be16be83948d950670f27d11.tar.gz -A artifacts.installers.holoport-nano`. I can create minimal repro if necessary: that said, the only variable that should affect this behavior is the closure size.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (both Aarch64 and x86-64)
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: unit: 1.8.0 -> 1.9.0
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62263
updated_at: 2019-06-05 04:40:38
body:
  ###### Motivation for this change
  Update nginx unit to v1.9.0
  Changes with Unit 1.9.0:
  - Feature: request routing by arguments, headers, and cookies.
  - Feature: route matching patterns allow a wildcard in the middle.
  - Feature: POST operation for appending elements to arrays in configuration.
  - Feature: support for changing credentials using CAP_SETUID and CAP_SETGID capabilities on Linux without running main process as privileged user.
  - Bugfix: memory leak in the router process might have happened when a client prematurely closed the connection.
  - Bugfix: applying a large configuration might have failed.
  - Bugfix: PUT and DELETE operations on array elements in configuration did not work.
  - Bugfix: request schema in applications did not reflect TLS connections.
  - Bugfix: restored compatibility with Node.js applications that use ServerResponse._implicitHeader() function; the bug had appeared in 1.7.
  - Bugfix: various compatibility issues with Node.js applications.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update packet python
user_login: mmlb
html_url: https://github.com/NixOS/nixpkgs/pull/62265
updated_at: 2019-06-04 21:11:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  New release of packet-python that brings in a few small features and also allows for testing from the sdist.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: routinator: init at 0.4.0
user_login: 0x4A6F
html_url: https://github.com/NixOS/nixpkgs/pull/62267
updated_at: 2019-07-11 22:44:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Adding package for [routinator](https://www.nlnetlabs.nl/projects/rpki/routinator/).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Git currently does not build on i686
user_login: petersjt014
html_url: https://github.com/NixOS/nixpkgs/issues/62268
updated_at: 2019-06-02 19:26:54
body:
  ## Issue description

  Right now Git is not building on i686. This is also blocking any derivations that depend on it.

  ### Steps to reproduce

  Run `nixos-rebuild build --upgrade` on a baremetal i686 machine. I suspect that adding something along the lines of `--argstr system i686-linux` might accomplish the same on x86-64 (I think that's how that flag works)--if not, using a qemu vm almost certainly would.

  ## Technical details

  The full build log is [here](http://0x0.st/zBP7.txt), but the main issue appears to be test failure(s) near the very end:

  ```
  ...
  t9832-unshelve.sh .................................. skipped: skipping git p4 tests; no p4 or p4d
  t9833-errors.sh .................................... skipped: skipping git p4 tests; no p4 or p4d
  t9901-git-web--browse.sh ........................... ok
  /build/git-2.19.2/t/../contrib/completion/git-completion.bash: line 377: compgen: command not found
  t9902-completion.sh ................................ ok
  t9903-bash-prompt.sh ............................... ok

  Test Summary Report
  -------------------
  t4202-log.sh                                     (Wstat: 256 Tests: 84 Failed: 3)
    Failed tests:  26-27, 30
    Non-zero exit status: 1
  t7810-grep.sh                                    (Wstat: 256 Tests: 221 Failed: 5)
    Failed tests:  37, 81, 182-183, 201
    Non-zero exit status: 1
  Files=832, Tests=19441, 3627 wallclock secs (16.09 usr  3.24 sys + 1190.40 cusr 2055.47 csys = 3265.20 CPU)
  Result: FAIL
  make[1]: *** [Makefile:52: prove] Error 1
  make[1]: Leaving directory '/build/git-2.19.2/t'
  make: *** [Makefile:2642: test] Error 2
  builder for '/nix/store/j6m2p15kppcjng80i565nwhb6f8hhidx-git-2.19.2.drv' failed with exit code 2
  cannot build derivation '/nix/store/sjjjh89knhw2p9y0abx9fg7d975x2l53-gpgme-1.12.0.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/p6nh6z7znkcksq9fz96k90xyapadxi96-rustc-1.32.0.drv': 1 dependencies couldn't be built
  ...
  ```

  It looks like the lack of `compgen` might be the only issue, but since the tests immediately before and after the error pass I don't know for sure.

  `nix-info`:

  ```
   - system: `"i686-linux"`
   - host os: `Linux 4.19.44, NixOS, 19.03.172657.cdec6217d98 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172764.50d5d73e22b, nixos-unstable-19.09pre181008.eccb90a2d99"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: nixos/bird: Fix reload
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/62269
updated_at: 2019-06-10 07:45:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  When calling reload, bird attempts to reload the file that was given in
  the command line. As the change of ${configFile} is never picked up,
  bird will just reload the old file.
  This way, the configuration is placed at a known location and updated.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] gmic_krita_qt: 2.3.6 -> 2.6.4
user_login: d3rped
html_url: https://github.com/NixOS/nixpkgs/pull/62270
updated_at: 2019-05-31 02:20:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update Krita's gmic "plugin"

  ###### Things done
  Update version number and checksums.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  ###### Things to do
  - [ ] gmic_krita_qt fails to link against fftw.
  If anyone has some time I would be happy about a few hints.

  ### Relevant Information:
  **Error Message:**
  ```
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/build/gmic/src/gmic.cpp.o: in function `_GLOBAL__sub_I_gmic.cpp':
  gmic.cpp:(.text.startup+0x2): undefined reference to `fftw_init_threads'
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/src/FilterSelector/FiltersModelReader.cpp.o: in function `_GLOBAL__sub_I_FiltersModelReader.cpp':
  FiltersModelReader.cpp:(.text.startup+0x2f): undefined reference to `fftw_init_threads'
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/src/CroppedImageListProxy.cpp.o: in function `_GLOBAL__sub_I_CroppedImageListProxy.cpp':
  CroppedImageListProxy.cpp:(.text.startup+0x2b): undefined reference to `fftw_init_threads'
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/src/CroppedActiveLayerProxy.cpp.o: in function `_GLOBAL__sub_I_CroppedActiveLayerProxy.cpp':
  CroppedActiveLayerProxy.cpp:(.text.startup+0x2b): undefined reference to `fftw_init_threads'
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/src/FilterSyncRunner.cpp.o: in function `_GLOBAL__sub_I_FilterSyncRunner.cpp':
  FilterSyncRunner.cpp:(.text.startup+0x2f): undefined reference to `fftw_init_threads'
  /nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ld: CMakeFiles/gmic_krita_qt.dir/src/FilterThread.cpp.o:FilterThread.cpp:(.text.startup+0x2f): more undefined references to `fftw_init_threads' follow
  collect2: error: ld returned 1 exit status
  ```

  This is quite weird as the previous version was also linked against this library as well.
  **CMakeLists.txt file diff:**
  ```
    message(FATAL_ERROR "\nVersion numbers of files 'gmic.h' (" |	  message(FATAL_ERROR "\nVersion numbers of files 'gmic.h' ("
      add_definitions(-Dgmic_prelease=${PRERELEASE_DATE})	      |	    add_definitions(-Dgmic_prerelease="${PRERELEASE_DATE}")
  add_definitions(-Dcimg_use_rng)				      <
  							      >	SET(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
  							      >	SET(CMAKE_INSTALL_RPATH "$ORIGIN/")
  							      >
  							      >	    set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -s"
  							      >	    if (WIN32)
  							      >	        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}
  							      >	    endif()
  # qt5_create_translation(				      |	set(gmic_translation_files
  #     qmic_qt_QM					      <
  #     ${CMAKE_SOURCE_DIR}/translations			      <
  #     ${gmic_qt_SRCS}					      <
  #     translations/cs.ts				      <
  #     translations/de.ts				      <
  #     translations/es.ts				      <
  #     translations/fr.ts				      <
  #     translations/id.ts				      <
  #     translations/it.ts				      <
  #     translations/nl.ts				      <
  #     translations/pl.ts				      <
  #     translations/pt.ts				      <
  #     translations/ru.ts				      <
  #     translations/ua.ts				      <
  #     translations/ja.ts				      <
  #     translations/zh.ts				      <
  # )							      <
  qt5_add_translation(gmic_qt_QM				      <
  							      >	)
  							      >
  							      >	set_source_files_properties(${gmic_translation_files} PROPERT
  							      >
  							      >	# qt5_create_translation(
  							      >	#     qmic_qt_QM
  							      >	#     ${CMAKE_SOURCE_DIR}/translations
  							      >	#     ${gmic_qt_SRCS}
  							      >	#     ${gmic_translation_files}
  							      >	# )
  							      >
  							      >	qt5_add_translation(gmic_qt_QM
  							      >	    ${gmic_translation_files}
  							      >	    install(TARGETS gmic_gimp_qt RUNTIME DESTINATION bin)
  							      >	    install(TARGETS gmic_krita_qt RUNTIME DESTINATION bin)
  							      >	    install(TARGETS gmic_qt RUNTIME DESTINATION bin)
  							      >
  							      >	elseif (${GMIC_QT_HOST} STREQUAL "paintdotnet")
  							      >
  							      >	    set (gmic_qt_SRCS ${gmic_qt_SRCS} src/Host/PaintDotNet/ho
  							      >	    add_definitions(-DGMIC_HOST=paintdotnet)
  							      >	    add_executable(gmic_paintdotnet_qt ${gmic_qt_SRCS} ${gmic
  							      >	    target_link_libraries(
  							      >	      gmic_paintdotnet_qt
  							      >	      PRIVATE
  							      >	      ${gmic_qt_LIBRARIES}
  							      >	      )
      message(FATAL_ERROR "GMIC_QT_HOST is not defined as gimp, |	    message(FATAL_ERROR "GMIC_QT_HOST is not defined as gimp,
  ```
  The following two issues also apply to the previous version (so it's unlikely that they are relevant)
  FFTW3 is found but there is no path or version number?
  ```
  -- Found ZLIB: /nix/store/ynykygggqw7l6wy5cp45565c0phxh8kv-zlib-1.2.11/lib/libz.so (found version "1.2.11")
  -- Found PNG: /nix/store/phv46yv3c6jraiv2aq6i1dgs9pjr3l8q-libpng-apng-1.6.37/lib/libpng.so (found version "1.6.37")
  -- Found PkgConfig: /nix/store/cnxbsf7l63nzy1bssrllxc39lm9wys28-pkg-config-0.29.2/bin/pkg-config (found version "0.29.2")
  -- Found FFTW3
  -- FFTW Found Version:
  -- Found CURL: /nix/store/kzrl9md38ms37pay33kdi97rpcb099v1-curl-7.64.1/lib/libcurl.so (found version "7.64.1")
  -- Found OpenMP_C: -fopenmp (found version "4.5")
  -- Found OpenMP_CXX: -fopenmp (found version "4.5")
  -- Found OpenMP: TRUE (found version "4.5")
  ```

  Also `fftw` has the required libraries in it's lib folder and `fftw.dev` has the required header files.


state: closed
title: postgresql: install in $out/share/postgresql
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62271
updated_at: 2019-06-01 19:00:04
body:
  Fixes #62235

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emacsqlite: strip binary
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62272
updated_at: 2019-05-31 14:31:18
body:
  Had gcc in closure which is not wanted. Use stripDebugList to make it
  strip in share/.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add treewide bad platforms
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62273
updated_at: 2019-05-31 14:30:43
body:
  More rounds of bad platforms / broken things. 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: inter: 3.5 -> 3.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62274
updated_at: 2019-06-01 14:05:02
body:
  ###### Motivation for this change

  https://github.com/rsms/inter/releases/tag/v3.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xorg.xorgserver: 1.20.4 -> 1.20.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62275
updated_at: 2019-06-05 04:17:26
body:
  ###### Motivation for this change

  https://lists.x.org/archives/xorg-announce/2019-May/002993.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libfilezilla: 0.13.0 -> 0.16.0; filezilla: -> 3.42.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62276
updated_at: 2019-06-09 11:23:22
body:
  ###### Motivation for this change

  Should be bumped together for API reasons I believe,
  but might as well since filezilla is only user of it :).


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcalcli: 4.1.0 -> 4.1.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62279
updated_at: 2019-06-01 11:01:59
body:
  ###### Motivation for this change

  https://github.com/insanum/gcalcli/releases/tag/v4.1.1

  Appears minor.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xournalpp: 1.0.8 -> 1.0.12
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62280
updated_at: 2019-06-23 08:48:50
body:
  ###### Motivation for this change

  * revisit plugin support, drop old patch
  * use lua5_3 as it seems to expect (require)
  * disable format hardening, fix build

  https://github.com/xournalpp/xournalpp/releases/tag/1.0.12

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - Runs and minor interactions seem reasonable, tablet/pen input not
      tested since I don't have such devices O:).
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dbeaver: 6.0.4 -> 6.0.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62281
updated_at: 2019-05-31 14:52:18
body:
  ###### Motivation for this change

  https://dbeaver.io/2019/05/19/dbeaver-6-0-5/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libidn2: 2.1.1a -> 2.2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62282
updated_at: 2019-06-08 08:24:52
body:
  ###### Motivation for this change

  https://lists.gnu.org/archive/html/info-gnu/2019-05/msg00015.html

  Only build-tested the package itself, rebuild bit too hefty for me
  right now :3.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: simp_le: 0.9.0 -> 0.14.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62283
updated_at: 2019-06-01 06:17:15
body:
  ###### Motivation for this change

  https://github.com/zenhack/simp_le#0140

  (intermediate versions are listed below)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


  Rudimentary testing only so far, and FWIW using acme 0.34.2, FWIW ( #61203 )

  Should confirm NixOS test (and that the test uses this :P),
  may confirm on live deployment but no timetable on that.

  ---


state: closed
title: pythonPackages.apprise: init at 0.7.6
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62284
updated_at: 2019-06-04 01:36:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/caronc/apprise

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skaffold: 0.29.0 -> 0.30.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/62285
updated_at: 2019-05-31 09:05:11
body:
  ###### Motivation for this change

  Update to latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: minishift: 1.33.0 -> 1.34.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/62286
updated_at: 2019-06-01 21:58:38
body:
  ###### Motivation for this change

  Bump to latest release :angel: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skopeo: 0.1.35 -> 0.1.36
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/62287
updated_at: 2019-06-02 12:47:32
body:
  ###### Motivation for this change

  Bump to latest release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/wireguard: should use WG_ENDPOINT_RESOLUTION_RETRIES
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/issues/62288
updated_at: 2019-05-31 21:17:19
body:
  ## Issue description

  In https://github.com/NixOS/nixpkgs/pull/61971 there was an option introduced that indefinitely tries to restart the wireguard service until all
  peer hostnames are resolved. Instead it should use `WG_ENDPOINT_RESOLUTION_RETRIES`
  as introduced by 
  https://git.zx2c4.com/WireGuard/commit?id=a1a1c1723b6423e43d71cfa52862fad9bbcd265b
  instead. This feature will be available in the next snapshot release of wireguard.
  cc @sjau @Ma27 @zx2c4


state: closed
title: dapper: init at v0.4.1
user_login: ngerstle-cognite
html_url: https://github.com/NixOS/nixpkgs/pull/62289
updated_at: 2019-06-06 07:48:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add the dapper (https://github.com/rancher/dapper) tool. 
  The dapper tool wraps docker and eases building of software (such as k3s) inside of docker containers for consistency.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: php: 7.1.29 -> 7.1.30, 7.2.18 -> 7.2.19, 7.3.5 -> 7.3.6
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62290
updated_at: 2019-06-01 13:53:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] php: 7.1.29 -> 7.1.30, 7.2.18 -> 7.2.19, 7.3.5 -> 7.3.6
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62291
updated_at: 2019-06-01 13:54:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Backport of #62290

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] php: 7.1.29 -> 7.1.30, 7.2.18 -> 7.2.19
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62292
updated_at: 2019-06-01 13:54:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Backport of #62290

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitea: 1.8.1 -> 1.8.2
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62293
updated_at: 2019-05-31 13:38:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.8.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @disassembler @kolaente @aanderse 


state: closed
title: [19.03] gitea: 1.8.1 -> 1.8.2
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62294
updated_at: 2019-06-01 13:54:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.8.2
  (cherry picked from commit aa1ca7b972853241cc56c725d15f89fdbfc9a886)

  Backport of  #62293

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @disassembler @kolaente @aanderse


state: open
title: initrd-network service: stop networking before stage-2
user_login: sshisk
html_url: https://github.com/NixOS/nixpkgs/pull/62297
updated_at: 2019-05-31 10:52:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Allow system networking to take over temporary initrd one. Before this network interface names could change depending on whether initrd networking was enabled.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luaPackages.luadbi: 0.7.1 -> 0.7.2
user_login: sshisk
html_url: https://github.com/NixOS/nixpkgs/pull/62298
updated_at: 2019-06-11 14:16:32
body:
  Fixes a nasty memory leak in Prosody.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/62299
updated_at: 2019-05-31 11:49:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: openspace: 0.11.1 -> 0.14.0
user_login: timjrd
html_url: https://github.com/NixOS/nixpkgs/pull/62300
updated_at: 2019-06-02 11:31:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upgrading from [OpenSpace](https://www.openspaceproject.com/) `0.11.1` to `0.14.0`, and cleaning up the package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.lab: 0.15.3 -> 0.16.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62301
updated_at: 2019-05-31 17:57:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/zaquestion/lab/releases/tag/v0.16.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.merlin: 3.2.2 -> 3.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62302
updated_at: 2019-06-03 15:19:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/ocaml/merlin/releases/tag/v3.3.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.git-standup: init at 2.3.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62303
updated_at: 2019-06-01 09:41:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/kamranahmedse/git-standup/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libsodium: 1.0.17 -> 1.0.18
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62304
updated_at: 2019-06-01 10:35:34
body:
  ###### Motivation for this change

  https://github.com/jedisct1/libsodium/releases/tag/1.0.18-RELEASE

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: azimuth: 1.0.2 -> 1.0.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62305
updated_at: 2019-06-01 01:08:36
body:
  ###### Motivation for this change

  Pew Pew!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


