# issues

state: open
title: lvm2: 2.03.01 -> 2.03.03
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62942
updated_at: 2019-06-12 04:40:36
body:
  ###### Motivation for this change

  May still be a pre-release? Can't find that reference now but FYI.

  https://sourceware.org/git/?p=lvm2.git;a=tag;h=refs/tags/v2_03_03
  https://sourceware.org/git/?p=lvm2.git;a=tag;h=refs/tags/v2_03_02

  Testing and review, please!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Python modules/robotframework sshlibrary
user_login: talkara
html_url: https://github.com/NixOS/nixpkgs/pull/62943
updated_at: 2019-06-18 19:10:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.mlgmpidl: 1.2.8 -> 1.2.10
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/62944
updated_at: 2019-06-17 06:32:39
body:
  ###### Motivation for this change

  Bugfix release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vlc: 3.0.7 - security!
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62945
updated_at: 2019-06-11 14:18:35
body:
  ###### Motivation for this change

  http://www.jbkempf.com/blog/post/2019/VLC-3.0.7-and-security

  NEWS here: https://www.videolan.org/developers/vlc-branch/NEWS
  (will likely always point to latest release, FWIW, scroll as needed)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Resilio sync configuration fix and NixOS test
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/62948
updated_at: 2019-07-08 08:32:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This change bundles two commits:

  - The first commit fixes an error in the configuration when `directoryRoot` is used. The option was placed in the wrong section for current versions of Resilio Sync.
  - The second commit adds tests for Resilio Sync. This test would have caught the configuration error solved in the first commit.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: temporal_tables: init at 1.2.0
user_login: ggPeti
html_url: https://github.com/NixOS/nixpkgs/pull/62950
updated_at: 2019-06-11 16:06:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aerc: 0.1.0 -> 0.1.1
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/62951
updated_at: 2019-06-11 06:23:11
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wasmtime: 0.1.0 -> 20190521
user_login: asymmetric
html_url: https://github.com/NixOS/nixpkgs/pull/62953
updated_at: 2019-06-20 19:32:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to latest unstable. The 0.1.0 version used by the previous version of the package was incorrect, as that's just a placeholder that Cargo adds by default.

  Spoke to one of the maintainers and they've made no releases to date, and he mentioned that now would be a good time to package since things are relatively stable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: auditd service: make more useful
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/62954
updated_at: 2019-07-20 12:18:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Enable kernel audit and install userspace utilities by default.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: resolvconf service: init
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/62955
updated_at: 2019-07-18 07:10:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This is a refactor of how resolvconf is managed on NixOS. We split it
  into a separate service which is enabled internally depending on whether
  we want /etc/resolv.conf to be managed by it. Various services now take
  advantage of those configuration options, in particular NetworkManager
  which fixes #61490.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested that #61490 is fixed.


state: closed
title: NetworkManager fixes
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/62956
updated_at: 2019-07-13 19:31:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Assortment of NetworkManager fixes that I did while working on https://github.com/NixOS/nixpkgs/pull/62955. In particular `insertNameservers` and `appendNameservers` now work simultaneously and `strongswan` configuration isn't installed when not enabled.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: vulkan-validation-layers: 1.1.101.0 -> 1.1.106.0
user_login: Ralith
html_url: https://github.com/NixOS/nixpkgs/pull/62957
updated_at: 2019-06-28 19:09:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Updates to match the rest of the vulkan packages, and in doing so fixes a forgotten sha256 update. I also cleaned up dependencies a bit.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: `nixos-rebuild switch` spends too much time checking ACME certs
user_login: majewsky
html_url: https://github.com/NixOS/nixpkgs/issues/62958
updated_at: 2019-06-21 11:00:00
body:
  I have a NixOS server hosting websites on multiple domains. It provides nearly a dozen unique domains:

  ```
  $ systemctl show acme-certificates.target | grep Wants | tr ' ' '\n' | wc -l         
  11
  ```

  I noticed that `sudo nixos-rebuild switch` is taking a rather long time on that server, and went to investigate. With no changes to the `configuration.nix` or the channels, it takes almost 20 seconds to do a no-op switch:

  ```
  $ ( echo start; sudo nixos-rebuild switch 2>&1; echo done ) | while read LINE; do echo "$(date +%s.%N) $LINE"; done
  1560184891.708082156 start
  1560184892.703134201 building Nix...
  1560184893.479601133 building the system configuration...
  1560184899.042561931 updating GRUB 2 menu...
  1560184899.173778641 activating the configuration...
  1560184899.272107865 setting up /etc...
  1560184899.786263303 reloading user units for stefan...
  1560184899.902325272 setting up tmpfiles
  1560184910.582049876 done
  ```

  After some further digging, it turns out that a rather large amount of time (10 seconds) is spent in [this `systemctl start` invocation](https://github.com/NixOS/nixpkgs/blob/c58b5f6f4bc5ef11b2581e851aca63773a429db6/nixos/modules/system/activation/switch-to-configuration.pl#L438). In particular, what's taking a long time is

  ```
  $ time sudo systemctl start acme-certificates.target
  sudo systemctl start acme-certificates.target  0,01s user 0,02s system 0% cpu 10,227 total
  ```

  This starts every `acme-$DOMAIN.service` unit (apparently one by one, without any parallelization, if the timing is any indication). This should be no big deal because no certificates need to be renewed most of the time, but simp_le, being a Python program, just takes about a second for anything because of the whole interpreter-startup and reading-code and compiling steps.

  As a user, I would like `nixos-rebuild switch` to take less time to make the edit-rebuild-test loop more fluent. I can see two major venues:

  1. Since a replacement for simp_le is being considered in #34941, I would like the replacement to be something that doesn't start an entire dynamic-language interpreter, so that `systemctl start acme-$DOMAIN.service` finishes in less than a second.

  2. From the timings that I've seen, `systemctl start acme-certificates.target` appears to be starting its constituent units serially. Can we enable some parallelization here? (Or is it already parallelizing, but without it helping the overall runtime?)

  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.48, NixOS, 19.03.172865.4fb3b869e21 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172865.4fb3b869e21"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: udocker seems to not work
user_login: pinage404
html_url: https://github.com/NixOS/nixpkgs/issues/62959
updated_at: 2019-06-10 16:53:25
body:
  ## Issue description

  I just discovered `udocker` and i can't use it on NixOS


  ### Steps to reproduce

  Pulling image seems good

  ```sh
  udocker pull alpine
  Warning: no engine available and autoinstall disabled
  Downloading layer: sha256:e7c96db7181be991f19a9fb6975cdbbd73c65f4a2681348e63a141a2192a5f10
  Downloading layer: sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4
  ```

  Trying to run image fail because it try to mount some specials folders

  ```sh
  udocker run alpine
  Warning: no engine available and autoinstall disabled
  Error: invalid host volume path: /lib/modules
  ```

  The [documentation says](https://indigo-dc.gitbooks.io/udocker/doc/user_manual.html):

  > `--nosysdirs` prevent udocker from mapping /proc /sys /run and /dev inside the container

  Trying without mounting folder fail because it can't find `proot`

  ```sh
  udocker run --nosysdirs alpine
  Warning: no engine available and autoinstall disabled
  Error: proot executable not found
  ```

  Start a shell with `proot` still fail because it can't find `proot`

  ```sh
  nix-shell --command fish --packages proot
  udocker run --nosysdirs alpine
  Warning: no engine available and autoinstall disabled
  Error: proot executable not found
  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.48, NixOS, 19.03.172844.caacbe98ce1 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(pinage404): `"home-manager-19.03, nixos-19.03.172852.5121b483edc, nixos-unstable-19.09pre182256.168d1031af4"`
   - channels(root): `"nixos-19.03.172852.5121b483edc"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: vimPlugins.indentLine: init at 2019-02-22
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62960
updated_at: 2019-06-11 16:16:26
body:
  ###### Motivation for this change
  Adds a vertical line to show indentation level.

  Tested using overlay, works well :).

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh /nix/store/kds5s2p76mpjrzy9qnkjxq6y80ar5hpx-vimplugin-indentLine-2019-02-22
  /nix/store/kds5s2p76mpjrzy9qnkjxq6y80ar5hpx-vimplugin-indentLine-2019-02-22       41.5K


state: closed
title: vimPlugins: update plugins
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62961
updated_at: 2019-06-11 16:15:49
body:
  ###### Motivation for this change
  While doing #62960 noticed that a lot of plugins were out of date, this is to bump their versions.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages.timescaledb: 1.3.0 -> 1.3.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62962
updated_at: 2019-06-11 03:29:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/timescale/timescaledb/releases/tag/1.3.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos-generate-config: add size attribute for swap *files*
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/62963
updated_at: 2019-06-13 14:03:09
body:
  ###### Motivation for this change
  Up until now, the output has been the same for swap devices and swap
  files:

    { device = "/var/swapfile"; }

  Whereas for swap *files* it's more correct to output the size as well,
  which is what this change does:

    { device = "/var/swapfile"; size = 8192; }

  (The size attribute can be changed and NixOS will update the underlying
  swap file size.)

  Another option is to not output anything for swap *files*, since they
  can be handled completely declaratively in configuration.nix.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luaPackages.luadbi: 0.7.1 -> 0.7.2
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62964
updated_at: 2019-06-15 10:03:55
body:
  ###### Motivation for this change
  Update lua package luadbi to v0.7.2 and fix worked prosody with mysql database.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jellyfin: 10.3.4 -> 10.3.5
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/62965
updated_at: 2019-06-11 19:37:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changelog (includes major security fix): https://github.com/jellyfin/jellyfin/releases/tag/v10.3.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos-generate-config: add support for bcache
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/62966
updated_at: 2019-06-12 09:42:24
body:
  ###### Motivation for this change
  Add "bcache" to boot.initrd.availableKernelModules if a bcache device is
  detected.

  This fixes a problem I've had one too many times: I install NixOS and
  forget to add "bcache", resulting in an unbootable machine (until fixed
  with Live CD). Now NixOS will do it for me.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wine: 4.8 -> 4.9, 4.0 -> 4.0.1
user_login: avnik
html_url: https://github.com/NixOS/nixpkgs/pull/62967
updated_at: 2019-06-15 16:32:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Regular wine unstable/staging update. (stable updated as well).
  combined win32/64 build tested.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab-runner: 11.11.0 -> 11.11.2
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/62968
updated_at: 2019-06-10 20:25:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Several fixes: https://gitlab.com/gitlab-org/gitlab-runner/blob/v11.11.2/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos-generate-config: add dm-snapshot module if LVM is detected
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/62969
updated_at: 2019-06-16 13:30:59
body:
  ###### Motivation for this change
  Without this, the system becomes unbootable if the user creates a LVM
  snapshot and reboots.

  Fixes https://github.com/NixOS/nixpkgs/issues/33646

  (The same kind of problem was fixed in RHEL a few years back:
  https://bugzilla.redhat.com/show_bug.cgi?id=1287940)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: uvloop isn't using system libuv
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/62970
updated_at: 2019-06-11 02:04:41
body:
  ## Issue description

  uvloop should have a way to build with the system libuv. However, currently, it is trying to build libuv itself each time.

  See https://github.com/MagicStack/uvloop/blob/master/setup.py#L72

  https://hydra.nixos.org/build/94429522

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: bundlerApp: Set up passthru properly
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/62971
updated_at: 2019-06-16 22:08:10
body:
  ###### Motivation for this change
  The manual [documents](https://nixos.org/nixpkgs/manual/#sec-language-ruby) both bundlerEnv and bundlerApp as providing `env` and `wrappedRuby` attributes on the resulting derivations. However only bundlerEnv actually had these attributes. Update bundlerApp to provide the same passthru that bundlerEnv does.

  Since bundlerApp already let the user provide their own passthru, I've chosen to allow that to take precedence over the default passthru, meaning the user may overwrite `env` or `wrappedRuby` with their own attributes if they choose to do so.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I have not actually tested the impact of this change on the nixpkgs repository. It shouldn't result in rebuilding any `bundlerApp` packages as it only affects `passthru`. I did test the one package I actually care about (the package whose environment I want access to in a `nix-shell`). Given that any manually-provided `passthru` argument will overwrite what I'm adding, this change should be purely additive.


state: closed
title: bind: Remove deprecated flag from rndc-confgen
user_login: m1cr0man
html_url: https://github.com/NixOS/nixpkgs/pull/62972
updated_at: 2019-06-11 07:14:27
body:
  Fixes bind.service startup issue after NixOS/nixpkgs#61619

  ###### Motivation for this change

  The bind service won't start on current unstable channel.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: zoneminder: add perlPackages.DeviceSerialPort for zmtrigger.pl
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62974
updated_at: 2019-06-11 06:48:33
body:
  ###### Motivation for this change

  zmtrigger.pl needs perlPackages.DeviceSerialPort in order to work.

  Additionally, we open the relevant port on NixOS.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/documentation: nixos-help: use w3m(1) by default
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/62975
updated_at: 2019-06-11 09:19:52
body:
  It is referenced in various places, but does not work out of the box:

  	$ nixos-help
  	/run/current-system/sw/bin/nixos-help: unable to start a web browser; please set $BROWSER

  In the user-hidden fallbacks to xdg-open(1) and w3m(1), `nixos-help`
  expects tools to be deliberately installed by users.

  For default installations and new users in general, this is unlikely to
  be the case.  Conversely, chances to use `nixos-help` are even higher
  in such cases.

  Use w3m-nographics by default to ensure documentation is always
  available.  The documentation browser on ttyS8 already does so, but is
  not accessible in every installation, e.g. VMs with only ttyS0 and SSH
  available.

  This obsoletes including it in the base profile's systemPackages,
  so remove the @TODO as done.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: octopus: 8.4 -> 9.0
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/62976
updated_at: 2019-06-12 07:36:48
body:
  ###### Motivation for this change
  Regular update: https://octopus-code.org/wiki/Changes

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hwloc: 2.0.3 -> 2.0.4
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/62977
updated_at: 2019-06-11 14:24:31
body:
  ###### Motivation for this change
  Regular update: https://raw.githubusercontent.com/open-mpi/hwloc/v2.0/NEWS

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: amp: init at 2019.06.11
user_login: sbourdeauducq
html_url: https://github.com/NixOS/nixpkgs/pull/62978
updated_at: 2019-06-20 01:03:29
body:
  ###### Motivation for this change
  Add a package for a nice text editor.

  ###### Things done
  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.coc-nvim: 0.0.67-> 0.0.69
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62979
updated_at: 2019-06-11 14:44:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Not sure that helps but was motivated by 
  https://github.com/neoclide/coc.nvim/issues/865

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: VirtualBox VERR_VERSION_MISMATCH
user_login: mhwombat
html_url: https://github.com/NixOS/nixpkgs/issues/62980
updated_at: 2019-06-18 12:10:31
body:
  ## Issue description

  I am running VirtualBox 6.0.8 r130520 (Qt5.6.2) on a Windows host. I attempted to upgrade my NixOS, which is running inside virtualbox, to `unstable`, but I get the following error.

  ```
  # nixos-rebuild switch --upgrade
  unpacking channels...
  building Nix...
  building the system configuration...
  updating GRUB 2 menu...
  activating the configuration...
  setting up /etc...
  reloading user units for sddm...
  reloading user units for amy...
  setting up tmpfiles
  warning: the following units failed: virtualbox.service

  ● virtualbox.service - VirtualBox Guest Services
     Loaded: loaded (/nix/store/713scd5fzydjf93kwzspvmzcf1xzc2hr-unit-virtualbox.service/virtualbox.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Tue 2019-06-11 14:38:58 IST; 28ms ago
    Process: 30009 ExecStart=VBoxService --foreground (code=exited, status=1/FAILURE)
   Main PID: 30009 (code=exited, status=1/FAILURE)

  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.011784 main     6.0.8 r130520 started. Verbose level = 0
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.012596 main     vbglR3GuestCtrlDetectPeekGetCancelSupport: Supported (#1)
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.012838 main     Error: Failed to become guest control master: VERR_VERSION_MISMATCH
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.013335 main     Error: Service 'control' failed to initialize: VERR_VERSION_MISMATCH
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.013465 main     Session 0 is about to close ...
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.013558 main     Stopping all guest processes ...
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.013656 main     Closing all guest files ...
  Jun 11 14:38:58 eamybut-nixos VBoxService[30009]: 13:38:58.013774 main     Ended.
  Jun 11 14:38:58 eamybut-nixos systemd[1]: virtualbox.service: Main process exited, code=exited, status=1/FAILURE
  Jun 11 14:38:58 eamybut-nixos systemd[1]: virtualbox.service: Failed with result 'exit-code'.
  warning: error(s) occurred while switching to the new configuration
  ```

  ### Steps to reproduce

  `nixos-rebuild switch --upgrade`

  ## Technical details

  ```
  # nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/g6vh8lppwlrn2428wbjnrsgis2qwlgq0-bash-interactive-4.4-p23-dev
  copying path '/nix/store/g6vh8lppwlrn2428wbjnrsgis2qwlgq0-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.118, NixOS, 19.09pre182429.98e3b90b6c8 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre182429.98e3b90b6c8"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  Here's my automatically generated hardware configuration:

  ```
  # cat /etc/nixos/hardware-configuration.nix
  # Do not modify this file!  It was generated by ‘nixos-generate-config’
  # and may be overwritten by future invocations.  Please make changes
  # to /etc/nixos/configuration.nix instead.
  { config, lib, pkgs, ... }:

  {
    imports = [ ];

    boot.initrd.availableKernelModules = [ "ata_piix" "ohci_pci" "ehci_pci" "sd_mod" "sr_mod" ];
    boot.kernelModules = [ ];
    boot.extraModulePackages = [ ];

    fileSystems."/" =
      { device = "/dev/disk/by-uuid/5d24f3b2-37ff-4a68-ae37-2bc627a56fc7";
        fsType = "ext4";
      };

    swapDevices = [ ];

    nix.maxJobs = lib.mkDefault 1;
    virtualisation.virtualbox.guest.enable = true;
  }
  ```

  This worked fine on NixOS 18.09, but I need to use `unstable` to take advantage of some of the fixes.

  I have temporarily worked around this by commenting out the `virtualisation.virtualbox.guest.enable = true;` line.


state: closed
title: Mptcp tools
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62981
updated_at: 2019-06-27 07:53:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  One of the pain point of MPTCP is - because it's not upstream yet - it's kinda hard to configure as standard tools may need to be overriden with their MPTCP fork.
  Nix makes it easier.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pgcenter: 0.6.1 -> 0.6.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62982
updated_at: 2019-06-11 20:00:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/lesovsky/pgcenter/releases/tag/v0.6.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex: 1.15.6.1079 -> 1.15.8.1198
user_login: elseym
html_url: https://github.com/NixOS/nixpkgs/pull/62983
updated_at: 2019-06-11 18:02:27
body:
  ###### Motivation for this change
  Update to latest version (non plexpass).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: redmine: 4.0.3 -> 4.0.4, 3.4.10 -> 3.4.11
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/62984
updated_at: 2019-06-13 01:04:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  version bump

  http://www.redmine.org/projects/redmine/wiki/Changelog_4_0
  http://www.redmine.org/projects/redmine/wiki/Changelog_3_4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: android-file-transfer: 3.8 -> 3.9
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62985
updated_at: 2019-06-12 06:55:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/whoozle/android-file-transfer-linux/releases/tag/v3.9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @xaverdh


state: closed
title: Add Bash completions for ZFS.
user_login: caadar
html_url: https://github.com/NixOS/nixpkgs/pull/62986
updated_at: 2019-06-12 22:15:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  zfs and zpool commands bash completion support.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: exiftool: 11.48 -> 11.50
user_login: bdesham
html_url: https://github.com/NixOS/nixpkgs/pull/62987
updated_at: 2019-06-12 14:07:54
body:
  ###### Motivation for this change

  Latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: redmine: 4.0.3 -> 4.0.4, 3.4.10 -> 3.4.11 [backport]
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/62988
updated_at: 2019-06-13 01:05:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  backport of https://github.com/NixOS/nixpkgs/pull/62984

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.cli-helpers: 1.2.0 -> 1.2.1
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62989
updated_at: 2019-06-12 16:02:19
body:
  ###### Motivation for this change
  Noticed it was out of date.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/ixmsj9sdkr4yz6amixg2mvwmh6f6rwca-python3.7-cli_helpers-1.2.0   97.4M

  $ nix path-info -Sh ./result
  /nix/store/qkgy9i5chxvkw51j3xx9i2b6af5bm6ag-python3.7-cli_helpers-1.2.1   97.4M


state: closed
title: matrix-synapse: 0.99.5.2 -> 1.0.0
user_login: fpletz
html_url: https://github.com/NixOS/nixpkgs/pull/62990
updated_at: 2019-06-12 15:16:25
body:
  ###### Motivation for this change
  https://matrix.org/blog/2019/06/11/synapse-1-0-0-released
  https://matrix.org/blog/2019/06/11/introducing-matrix-1-0-and-the-matrix-org-foundation

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: papirus-icon-theme: 20190501 -> 20190521
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/62991
updated_at: 2019-06-12 11:35:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - papirus-icon-theme: 20190501 -> [20190521](https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/releases/tag/20190521)
  - papirus-icon-theme: use pname instead of name
  - papirus-icon-theme: restrict to linux platforms
  - papirus-icon-theme: add maintainer

  Supersedes https://github.com/NixOS/nixpkgs/pull/62494.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: plan9port: build everything on Darwin
user_login: eraserhd
html_url: https://github.com/NixOS/nixpkgs/pull/62992
updated_at: 2019-06-11 23:35:22
body:
  A commit in 2014 (see #2266) disabled building parts which depended on X11 on Mac OS.  There's no explanation given in the pull request.  In any case, many people install plan9port on Darwin specifically to use the UI components.

  Aside from this, the derivation was broken on Mac OS, probably because people put the `which` and `perl` dependencies inside the !isDarwin conditional.  Some programs worked, however the static libraries did not build, so this could not be used as a buildInput to build programs
  which need the libraries.  This fixes that.

  ###### Motivation for this change

  Specifically experienced on Mac OS:

  * `$out/plan9/bin/rc` was missing.
  * `$out/plan9/lib/lib*.a` was missing, preventing `9l` from working.


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS **(Same hash and path size as before)**
     - [x] macOS **(path size 111,256,024 -> 215,351,448)**
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`) **(see note)**
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date **(no docs in this repo)**
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  There's a *lot* of binaries, so I didn't run them all.  I did test the things that I needed that were missing on Mac OS (`rc` and `9l`), and they work.

  `nix-review` reported that no packages were built.

  This should be safe.

  ---


state: closed
title: beignet: 1.3.2 -> unstable-2018.08.20
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/62993
updated_at: 2019-06-17 13:46:17
body:
  Update ```beignet``` to the latest (yet abandoned an year ago) version, mainly for Coffee Lake support
  See https://github.com/NixOS/nixpkgs/pull/55583#issuecomment-499558877
  cc @gloaming @7c6f434c 

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  list of available OpenCL devices on ThinkPad P52, all work:
  ![](http://i.imgur.com/jr0K03f.png)


state: closed
title: cbatticon: 1.6.8 -> 1.6.9
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/62994
updated_at: 2019-06-15 12:23:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [1.6.9](https://github.com/valr/cbatticon/releases/tag/1.6.9)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: melpa-stable-packages: remove unstable packages
user_login: rasendubi
html_url: https://github.com/NixOS/nixpkgs/pull/62995
updated_at: 2019-06-12 02:14:28
body:
  ###### Motivation for this change

  During the last [melpa-stable-packages update](https://github.com/NixOS/nixpkgs/pull/62784), there was an update script invocation error which resulted in melpa-stable-packages to also include all the unstable packages.

  I have re-run the script correctly, so this commit removes all the unstable packages that were accidentally included.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Skaware 2019-06
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/62996
updated_at: 2019-06-18 08:55:07
body:
  @GrahamcOfBorg build skawarePackages

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitlbee-discord: fix build
user_login: jb55
html_url: https://github.com/NixOS/nixpkgs/pull/62997
updated_at: 2019-06-12 07:35:47
body:
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.cmd2_8: remove
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62998
updated_at: 2019-06-12 02:56:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I'm not sure what to do about this one - alongside the up-to-date version of  `pythonPackages.cmd2` we also have `pythonPackages.cmd2_8` (0.8.0). It seems we've been keeping this for python 2.7 (see commit message 65b15ba6a96760125cc3984893f587af1ffacaac), and indeed `cmd2` actually supports py2.7 right up to 0.8.6 (https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md#085-april-15-2018).

  But unfortunately the recent bump of `pyparsing` from 2.3.0 to 2.3.1 (c78bf91587a4692cc852c004866e83fdb7020f53) broke even 0.8.6's tests (probably because of https://github.com/pyparsing/pyparsing/blob/2809cc975277e5b8c9160e1bac903d414eab305d/CHANGES#L100). So we'd either have to disable more tests than I'd like or maintain an old version of `pyparsing` too. And seeing as there don't actually seem to be any in-tree reverse dependencies of `cmd2_8`, it seems most sensible to just remove it - we can't go on offering a whole parallel package selection for 2.7...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: alsaLib bump to 1.1.9 broke pulseaudio (no outputs found)
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/issues/62999
updated_at: 2019-06-11 21:49:58
body:
  ## Issue description

  After the recent alsaLib bump from 1.1.8 to 1.1.9 pulseaudio has stopped finding audio outputs on my system. `journalctl -b` contains the following relevant errors:

  ```
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] ltdl-bind-now.c: Failed to open module /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-card.so: /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc$
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] modinfo.c: Failed to open module "/nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-card": file not found
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] ltdl-bind-now.c: Failed to open module /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-sink.so: /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc$
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] modinfo.c: Failed to open module "/nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-sink": file not found
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] ltdl-bind-now.c: Failed to open module /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-source.so: /nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9$
  Jun 11 23:32:54 lowell.delroth.net xsession[1723]: E: [pulseaudio] modinfo.c: Failed to open module "/nix/store/hfvl7fdbdg0fhwxnkd8y32lw5kicw9yc-pulseaudio-12.2/lib/pulse-12.2/modules/module-alsa-source": file not found
  ```

  https://bugzilla.opensuse.org/show_bug.cgi?id=1132880 seems related.

  ### Steps to reproduce

  For me, nothing but upgrading to latest nixpkgs master. But I'm surprised nobody else has reported this issue so far, there might be something specific to my system.


state: closed
title: sidequest: init at 0.3.1
user_login: joepie91
html_url: https://github.com/NixOS/nixpkgs/pull/63000
updated_at: 2019-07-18 12:54:52
body:
  ###### Motivation for this change

  Adds SideQuest, an application store / sideloading tool for the Oculus Quest and some other VR headsets.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Also verified that loading Beat Saber songs works with my Quest (which uses a separate tool, QuestSaberPatch, that is downloaded on runtime). Have not tested other sideloading capabilities with this expression, but if uploading a new Beat Saber APK works, I see no reason why those features shouldn't.

  ---


state: closed
title: haskell.compiler.ghcHEAD: 20190115 -> 20190601
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/63001
updated_at: 2019-06-28 22:58:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I want a recent version for trying out https://gitlab.haskell.org/ghc/ghc/merge_requests/668

  I'm not entirely sure on the version naming, I chose 8.9 because 8.8 is branched off already, and HEAD will once become 8.10

  I included the patch not propagated in https://github.com/NixOS/nixpkgs/commit/e001b99710cebbbe5f64d2dbac5dbf8f417962a2, because I still ran into https://github.com/haskell/haddock/issues/900 when compiling the polysemy-zoo package, see https://github.com/commercialhaskell/stackage/pull/4562#issuecomment-493898672. Not entirely sure why that patch doesn't appear to be in HEAD.

  Since recent times, current ghcHEAD failed in nixpkgs, see https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.haskell.compiler.ghcHEAD.x86_64-linux, but this updated versions builds just fine.

  Ping @peti @ryantm @deepfire @Ericson2314 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.flask_migrate: 2.3.1 -> 2.5.2
user_login: Gerschtli
html_url: https://github.com/NixOS/nixpkgs/pull/63002
updated_at: 2019-06-13 07:06:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes build and update python package `flask_migrate` 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pytest-testmon: init at 0.9.16
user_login: dmvianna
html_url: https://github.com/NixOS/nixpkgs/pull/63004
updated_at: 2019-06-13 02:09:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add new package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sops: 3.3.0 -> 3.3.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63005
updated_at: 2019-06-12 07:17:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/mozilla/sops/releases/tag/3.3.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pytest-watch: init at 4.2.0
user_login: dmvianna
html_url: https://github.com/NixOS/nixpkgs/pull/63007
updated_at: 2019-06-17 06:00:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: svgbob: init at 2018-10-05
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63008
updated_at: 2019-06-13 02:07:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/ivanceras/svgbob/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages.pg_bigm: init at 1.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63009
updated_at: 2019-06-14 05:34:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://pgbigm.osdn.jp/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parity: 2.4.6 -> 2.4.8, parity-beta: 2.5.1 -> 2.5.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63011
updated_at: 2019-06-27 03:35:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `parity` and `parity-beta` to the latest release.
  https://github.com/paritytech/parity-ethereum/releases/tag/v2.4.8
  https://github.com/paritytech/parity-ethereum/releases/tag/v2.5.3

  cc @akru to review. Thank you!
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tflint: init at 0.8.3
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63012
updated_at: 2019-06-17 03:02:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/wata727/tflint

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: joker: 0.12.2 -> 0.12.4
user_login: andrestylianos
html_url: https://github.com/NixOS/nixpkgs/pull/63013
updated_at: 2019-07-13 18:42:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Nix MUST override user locale variables
user_login: fare
html_url: https://github.com/NixOS/nixpkgs/issues/63014
updated_at: 2019-06-12 17:26:33
body:
  ## Issue description

  While building source code, compilers and build tools should ALWAYS process each and every source file using the encoding with which the file was written by its authors and released by its maintainers, and NEVER process any of those files with the locale inherited from the end-user when it introduces any discrepancy whatsoever. The proper thing to do is thus to NEVER, EVER heed the user-inherited locale variables `LANG` and `LC_*` — the very idea flies in the face of the determinism aimed at by Nix. Not even in an impure shell should use the user locale, unless explicitly requested — and any discrepancy in encoding should then lead to a prominent warning unless explicitly hushed.

  The only imaginable defaults that make any sense for the locale are: `POSIX`, `C.UTF-8`, and `en_US.UTF-8`. The `POSIX` default would impose needless pain for no gain whatsoever in a day where UTF-8 is now a widely accepted and supported standard, so the only sensible and useful defaults are `C.UTF-8` and `en_US.UTF-8`. Between those two, the actual default should be chosen based on which is easiest to deploy in the base Nix environment while breaking the fewest programs. I suspect it's `en_US.UTF-8`.

  I was faced with this bug while building with `stack` a haskell program that depended on `language-javascript`, and had a painful debug session until I found how to configure a suitable `shell.nix` for `stack.yaml`. Drilling to root causes led me to find that it's a fundamental bug in all of Nix, Cabal, Hackage and Stack. Remarkably, I fixed the very same issue in Common Lisp, where the build system ASDF assumes that all source code is UTF-8 by default, unless overridden by the library maintainers, and never ever heeding user locale. The switch was slightly painful, hounding maintainers of tens of libraries and actually pulling the switch only a year after warning everyone. The switch should be simpler in Nix, where all software is in the same repository.

  See also:
  https://www.snoyman.com/blog/2016/12/beware-of-readfile
  https://github.com/agda/agda/issues/2922
  https://github.com/input-output-hk/cardano-sl/commit/ed8c892ce0273d19a4cef6973d1d9e80257329ef

  ### Steps to reproduce

  ```
  stack build language-javascript
  ```

  Result:
  ```
  --  While building package language-javascript-0.6.0.12 using:
        /home/fare/.stack/setup-exe-cache/x86_64-linux-nix/Cabal-simple_mPHDZzAJ_2.4.0.1_ghc-8.6.5 --builddir=.stack-work/dist/x86_64-linux-nix/Cabal-2.4.0.1 build --ghc-options " -ddump-hi -ddump-to-file -fdiagnostics-color=always"
      Process exited with code: ExitFailure 1
      Logs have been written to: /home/fare/.stack/global-project/.stack-work/logs/language-javascript-0.6.0.12.log

      Configuring language-javascript-0.6.0.12...
      Preprocessing library for language-javascript-0.6.0.12..
      happy: src/Language/JavaScript/Parser/Grammar7.y: hGetContents: invalid argument (invalid byte sequence)
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.3, NixOS, 19.03.172627.c21f08bfedd (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172866.4649b6ef4b5"`
   - channels(fare): `""`
   - nixpkgs: `/home/fare/src/nixos/nixpkgs`

  NB: my nixpkgs was an unmodified nixpkgs-unstable at 61f0936.


state: closed
title: less: 530 -> 551
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63015
updated_at: 2019-06-15 16:45:16
body:
  ###### Motivation for this change

  At long last! \o/

  pname-ify while visiting.

  http://greenwoodsoftware.com/less/news.551.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - ALLVM :innocent:
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: 67.0.1 -> 67.0.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63016
updated_at: 2019-07-01 15:51:35
body:
  ###### Motivation for this change

  I believe this is updated by someone else regularly,
  but noticed and was curious so submitting in case
  it's useful.  Simple the result of running the updateScript's
  for these :).

  https://www.mozilla.org/en-US/firefox/67.0.2/releasenotes/


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xorg.xcalc: 1.0.7 -> 1.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63018
updated_at: 2019-06-12 07:27:54
body:
  xcalc: ensure "app-defaults" resources are installed+found, works now

  ###### Motivation for this change

  https://lists.x.org/archives/xorg-announce/2019-June/002996.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: browsh: 1.5.0 -> 1.5.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63019
updated_at: 2019-06-12 07:27:27
body:
  ###### Motivation for this change

  * update/regen deps.nix

  https://github.com/browsh-org/browsh/releases/tag/v1.5.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nghttp2: 1.38.0 -> 1.39.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63020
updated_at: 2019-06-15 16:17:34
body:
  ###### Motivation for this change

  https://nghttp2.org/blog/2019/06/11/nghttp2-v1-39-1/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dbus: 1.12.14 -> 1.12.16
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63021
updated_at: 2019-06-15 16:17:00
body:
  ###### Motivation for this change

  https://gitlab.freedesktop.org/dbus/dbus/blob/dbus-1.12.16/NEWS

  It's short and explains the CVE a bit, including below:

  > CVE-2019-12749: Do not attempt to carry out DBUS_COOKIE_SHA1
  > authentication for identities that differ from the user running the
  > DBusServer. Previously, a local attacker could manipulate symbolic
  > links in their own home directory to bypass authentication and connect
  > to a DBusServer with elevated privileges. The standard system and
  > session dbus-daemons in their default configuration were immune to this
  > attack because they did not allow DBUS_COOKIE_SHA1, but third-party
  > users of DBusServer such as Upstart could be vulnerable.   Thanks to Joe
  > Vennix of Apple Information Security.   (dbus#269, Simon McVittie)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pygraphviz: 1.3.1 -> 1.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63022
updated_at: 2019-06-15 18:07:42
body:
  ###### Motivation for this change

  https://github.com/pygraphviz/pygraphviz/releases

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: txr: 216 -> 217
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/63023
updated_at: 2019-06-18 01:59:55
body:
  ###### Motivation for this change

  http://www.kylheku.com/cgit/txr/tree/RELNOTES?id=txr-217

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: midisheetmusic: always bring timidity dependency
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/63024
updated_at: 2019-07-18 10:31:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Currently after system upgrade, if midisheetmusic is got from binary cache, it shows `The Timidity MIDI player is not installed` error. This is because timidity is not present in nix store at user side.

  Instead of #53813 cc @FRidh

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: No haddock manpage
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/63026
updated_at: 2019-06-13 16:32:02
body:
  ## Issue description

  I develop a package using `shellFor { withHoogle = true; }`. I can start haddock but ` man haddock` fails.

  On nixos-unstable.


state: open
title: nixos containers: containers/*/var/empty not removable, even by root
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63028
updated_at: 2019-07-02 05:01:14
body:
  ## Issue description

  I played around with nixos-containers and want to remove it now.

  ```
  [root@ethmoid:~]# rm -rf /var/lib/containers
  rm: cannot remove '/var/lib/containers/target0/var/empty': Operation not permitted

  [root@ethmoid:~]# rmdir /var/lib/containers/target0/var/empty/
  rmdir: failed to remove '/var/lib/containers/target0/var/empty/': Operation not permitted

  [root@ethmoid:~]# stat /var/lib/containers/target0/var/empty
    File: /var/lib/containers/target0/var/empty
    Size: 4096      	Blocks: 8          IO Block: 4096   directory
  Device: fe00h/65024d	Inode: 19923225    Links: 2
  Access: (0555/dr-xr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
  Access: 2019-05-27 20:13:10.248103372 +0200
  Modify: 2019-05-27 20:13:10.248103372 +0200
  Change: 2019-05-28 21:02:26.399695454 +0200
   Birth: -
  ```
  Even root is not allowed to write!

  ```
  [root@ethmoid:~]# nixos-container destroy target0

  [root@ethmoid:~]# chmod +w /var/lib/containers/target0/var/empty
  chmod: changing permissions of '/var/lib/containers/target0/var/empty': Operation not permitted

  [root@ethmoid:~]# chattr -i /var/lib/containers/target0/var/empty

  [root@ethmoid:~]# rm -rf /var/lib/containers

  [root@ethmoid:~]# ll /var/lib/containers/target0/var/empty
  ls: cannot access '/var/lib/containers/target0/var/empty': No such file or directory
  ```

  It seems the immutable bit was set.

  ```
  [root@targets-host2:~]# lsattr -d /var/lib/containers/target1/var/empty/
  ----i---------e---- /var/lib/containers/target1/var/empty/
  ```

  Does that makes sense or can we prevent it from happening?

  ### Steps to reproduce

  1. create nixos containerhttps://nixos.org/nixos/manual/index.html#ch-containers
  1. remove container
  1. try to remove all state

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.49, NixOS, 19.03.172866.4649b6ef4b5 (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172866.4649b6ef4b5, nixos-hardware, nixos-unstable-19.09pre182429.98e3b90b6c8"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nixos/stunnel: Fix CA files
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/63029
updated_at: 2019-06-15 08:10:30
body:
  The default is the .crt file from the ssl package.
  However, with CApath, it's assumed to be a directory containing
  certificates, while with CAfile, it's properly recognised as a file.

  Relevant strace output:
  stat("/etc/ssl/certs/ca-certificates.crt/2e5ac55d.0", 0x7fc580f3d610) = -1 ENOTDIR (Not a directory)

  cc @lschuermann

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flashplayer: 32.0.0.192 -> 32.0.0.207 [Critical security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/63030
updated_at: 2019-06-12 19:36:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Critical security fixes
  - Other bug fixes

  https://helpx.adobe.com/security/products/flash-player/apsb19-30.html
  https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  - Built packages
    - `nix-env -i -f . -A pkgs.flashplayer`
    - `nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone`
    - `nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"`

  - Played those videos with Firefox (x86_64) and Chromium (x86_64)
    - https://get.adobe.com/flashplayer/about/
    - https://www.dhs.state.il.us/accessibility/tests/flash/video.html

  ---


state: closed
title: firefox, firefox-bin: 67.0.1 -> 67.0.2
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/63031
updated_at: 2019-06-12 17:40:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Bug fixes

  https://www.mozilla.org/en-US/firefox/67.0.2/releasenotes/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Tested only `firefox-bin`. `firefox` is being built.

  ---


state: closed
title: brave out of date
user_login: FelschR
html_url: https://github.com/NixOS/nixpkgs/issues/63032
updated_at: 2019-06-16 01:10:21
body:
  The [most recent brave version](https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/browsers/brave/default.nix) is from over 3 months ago.

  Some background info:
  Previously it was updated automatically by @r-ryantm, @ryantm's bot that runs [nixpkgs-update](https://github.com/ryantm/nixpkgs-update).
  But the last builds have failed, e.g.: [2019-05-11 log](https://gist.githubusercontent.com/ryantm/cb351942c38cd4dfcf2cc2e4235f3352/raw/b2ce7ce8058520579d60863c5a58956220298bf2/ups.log)


state: open
title: nixos/doc: documentation angle bracket syntax
user_login: tobiasBora
html_url: https://github.com/NixOS/nixpkgs/pull/63033
updated_at: 2019-06-12 13:40:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Lack of documentation for `<...>` syntax, and add link to https://nixos.org/nixos/options.html. The goal is to partially solve the 3 year old bug https://github.com/NixOS/nix/issues/338.

  ###### Things done

  I just modified `nixos/doc/manual/configuration/customizing-packages.xml` and `nixos/doc/manual/configuration/summary.xml`, and then I ran `make` in `nixos/doc/manual`, and `nix-build nixos/release.nix -A manual.x86_64-linux` at the source. 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: chromedriver: 2.46 -> 75.0.3770.8
user_login: sergiosoriaolivares
html_url: https://github.com/NixOS/nixpkgs/pull/63034
updated_at: 2019-06-13 10:01:30
body:
  ###### Motivation for this change
  Updating chromedriver in order have NIX updated to later version


  ###### Things done
  Just updating chromedriver version.
  Sha captured with the help of nix-prefetch-url --unpack --type sha256 https://chromedriver.storage.googleapis.com/75.0.3770.8/chromedriver_linux64.zip


state: closed
title: go: 1.12.5->1.12.6, 1.11.10->1.11.11
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/63035
updated_at: 2019-06-12 16:26:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upstream update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.flask_script: fix hash
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/63036
updated_at: 2019-06-13 01:55:17
body:
  the old hash was for 2.0.5, so the store path for the dist-info was:
  /nix/store/v5sgpkxpp950chzdzzj4b5yl9r0w0by7-python3.7-Flask-Script-2.0.6/lib/python3.7/site-packages/Flask_Script-2.0.5.dist-info

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: google-cloud-sdk: kubeconfig: don't store absolute path to gcloud binary
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63037
updated_at: 2019-06-19 08:22:31
body:
  ###### Motivation for this change
  I got bitten too often by a hardcoded and disappearing path to `gcloud` in the kubectl config.

  This PR fixes the google-cloud-sdk derivation to allow to apply patches on top of it, then patches google-cloud-sdk to not store absolute paths in configuration files.

  Description from that patch:

  > The `gcloud beta container clusters get-credentials $cluster \
  > --region $region --project $project`
  > command can be used to write kubectl config files.
  > 
  > In that file, normally the absolute path to the `gcloud` binary is
  > stored.
  > 
  > This is a bad idea in NixOS. We might eventually garbage-collect that
  > specific gcloud binary - and in general, would expect a nix-shell
  > provided gcloud to be used.
  > 
  > In its current state, token renewal would just start to break with the
  > following error message:
  > 
  > Unable to connect to the server: error executing access token command "/nix/store/…/gcloud config config-helper --format=json": err=fork/exec /nix/store/…/gcloud: no such file or directory output= stderr=
  > 
  > Avoid this by storing just `gcloud` inside `cmd-path`, which causes
  > kubectl to lookup the gcloud command from $PATH, which is more likely to
  > keep working.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - x ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @arianvp 


state: closed
title: bazel: 0.26.0 -> 0.26.1
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63038
updated_at: 2019-06-12 17:25:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/bazelbuild/bazel/compare/0.26.0...0.26.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Crystal: Missing YAML dependency
user_login: alexherbo2
html_url: https://github.com/NixOS/nixpkgs/issues/63039
updated_at: 2019-06-25 04:59:56
body:
  [Crystal] requires [LibYAML] for its [YAML][Crystal/YAML] module.

  [Crystal]: https://crystal-lang.org
  [Crystal/YAML]: https://crystal-lang.org/api/YAML.html
  [LibYAML]: https://pyyaml.org/wiki/LibYAML


state: closed
title: brave: 0.61.50 -> 0.65.118
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63040
updated_at: 2019-06-16 01:10:24
body:
  Also corrects indentation and adds changelog meta attribute.

  https://github.com/brave/brave-browser/blob/v0.65.118/CHANGELOG.md

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/63032 though the more subtle issue here is that the version information for this package at [repology](https://repology.org/project/brave/versions) is incorrect.
  Where `0.67.72` is reported as the latest but it should be tracking stable releases at `0.65.x`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: eksctl: init at 0.1.35
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63041
updated_at: 2019-06-15 13:20:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `eksctl` is a CLI for Amazon EKS 
  https://eksctl.io
  https://github.com/weaveworks/eksctl

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: waf: Added support for optional extra tools
user_login: xbreak
html_url: https://github.com/NixOS/nixpkgs/pull/63042
updated_at: 2019-06-25 07:12:05
body:
  The list of tools `withTools` are included as extra tools when building waf.

  Example:

      mywaf = callPackage ../development/tools/build-managers/waf {
        python = python3;
        withTools = [ "doxygen" ];
      };

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  waf carries many extra tools (under `waflib/extras`) that are not included by default. This PR enables users to create a waf version with a selection of these extra tools using `withTools` .

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions (CentOS 7.4)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
  - [x] Tested on local waf project
  ---


state: open
title: pkgsCross.armv7l-hf-multiplatform.talloc fails to build
user_login: Thra11
html_url: https://github.com/NixOS/nixpkgs/issues/63043
updated_at: 2019-06-29 20:52:53
body:
  ## Issue description
  `pkgsCross.armv7l-hf-multiplatform.talloc` fails to build. Very similar output to #62540.

  ### Steps to reproduce

  ## Technical details
  ```
  nix-build -I nixpkgs=/home/thrall/nixpkgs -E '(import <nixpkgs>{}).pkgsCross.armv7l-hf-multiplatform.talloc'
  these derivations will be built:
    /nix/store/vd7xkzz3p040k9ly85n41m9cwsm13vhw-talloc-2.1.14-armv7l-unknown-linux-gnueabihf.drv
  building '/nix/store/vd7xkzz3p040k9ly85n41m9cwsm13vhw-talloc-2.1.14-armv7l-unknown-linux-gnueabihf.drv'...
  unpacking sources
  unpacking source archive /nix/store/vhibvjl3g3rgi9hl0ik068w70gsv02bq-talloc-2.1.14.tar.gz
  source root is talloc-2.1.14
  setting SOURCE_DATE_EPOCH to timestamp 1531374876 of file talloc-2.1.14/wscript
  patching sources
  updateAutotoolsGnuConfigScriptsPhase
  configuring
  configure flags: --cross-compile --cross-execute=/nix/store/879f9z1lry114x7v83zwffg9jwz986a7-bash-4.4-p23/bin/bash\ -c\ \'\'\ -- --prefix=/nix/store/927s5j6fv5zha2x9y25ch61sx5yin5bn-talloc-2.1.14-armv7l-unknown-linux-gnueabihf --enable-talloc-compat1 --bundled-libraries=NONE --builtin-libraries=replace configure
  Checking for program gcc or cc           : armv7l-unknown-linux-gnueabihf-gcc 
  Checking for program cpp                 : not found 
  Checking for program ar                  : armv7l-unknown-linux-gnueabihf-ar 
  Checking for program ranlib              : armv7l-unknown-linux-gnueabihf-ranlib 
  Checking for gcc                         : ok  
  Checking for program git                 : not found 
  Check for -MD                            : yes 
  Checking for program gdb                 : not found 
  Checking for header sys/utsname.h        : yes 
  Checking uname sysname type              : Traceback (most recent call last):
    File "buildtools/bin/waf", line 76, in <module>
      Scripting.prepare(t, cwd, VERSION, wafdir)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Scripting.py", line 145, in prepare
      prepare_impl(t, cwd, ver, wafdir)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Scripting.py", line 135, in prepare_impl
      main()
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Scripting.py", line 188, in main
      fun(ctx)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Scripting.py", line 241, in configure
      conf.sub_config([''])
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Configure.py", line 237, in sub_config
      self.recurse(k, name='configure')
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Utils.py", line 656, in recurse
      f(self)
    File "/build/talloc-2.1.14/wscript", line 38, in configure
      conf.RECURSE('lib/replace')
    File "./buildtools/wafsamba/samba_utils.py", line 452, in RECURSE
      return ctx.sub_config(relpath)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Configure.py", line 237, in sub_config
      self.recurse(k, name='configure')
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Utils.py", line 656, in recurse
      f(self)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Utils.py", line 743, in wrap
      ret = fun(k)
    File "/build/talloc-2.1.14/lib/replace/wscript", line 28, in configure
      conf.RECURSE('buildtools/wafsamba')
    File "./buildtools/wafsamba/samba_utils.py", line 452, in RECURSE
      return ctx.sub_config(relpath)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Configure.py", line 237, in sub_config
      self.recurse(k, name='configure')
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Utils.py", line 656, in recurse
      f(self)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Utils.py", line 743, in wrap
      ret = fun(k)
    File "/build/talloc-2.1.14/lib/replace/../../buildtools/wafsamba/wscript", line 317, in configure
      conf.CHECK_UNAME()
    File "./buildtools/wafsamba/samba_conftests.py", line 452, in CHECK_UNAME
      msg="Checking uname %s type" % v):
    File "./buildtools/wafsamba/samba_autoconf.py", line 456, in CHECK_CODE
      conf.COMPOUND_END(conf.env[define])
    File "./buildtools/wafsamba/samba_autoconf.py", line 69, in COMPOUND_END
      p(result)
    File "/build/talloc-2.1.14/third_party/waf/wafadmin/Configure.py", line 299, in check_message_2
      self.log.write(sr)
  TypeError: expected a string or other character buffer object
  builder for '/nix/store/vd7xkzz3p040k9ly85n41m9cwsm13vhw-talloc-2.1.14-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 1
  error: build of '/nix/store/vd7xkzz3p040k9ly85n41m9cwsm13vhw-talloc-2.1.14-armv7l-unknown-linux-gnueabihf.drv' failed
  ```
  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"aarch64-linux"`
   - host os: `Linux 3.10.104, Ubuntu, 18.04.2 LTS (Bionic Beaver)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - nixpkgs: `/home/thrall/nixpkgs`
  ```


state: closed
title: winePackages.fonts: init at 4.0
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63044
updated_at: 2019-06-17 23:24:11
body:
  ###### Motivation for this change
  > Wine's fonts should be a natural candidate for their own subpackage

  https://wiki.winehq.org/Packaging

  They are a replacement for some Microsoft fonts not available in other
  replacement packages, e.g. Tahoma.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab: 11.10.4 -> 11.10.5
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63045
updated_at: 2019-06-15 19:29:57
body:
  ###### Motivation for this change

  Security update to 11.10.5

  https://about.gitlab.com/2019/06/03/security-release-gitlab-11-dot-11-dot-1-released/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: `__OSX_AVAILABLE_STARTING` error when building on macOS 10.14
user_login: ktf
html_url: https://github.com/NixOS/nixpkgs/issues/63046
updated_at: 2019-06-15 16:28:04
body:
  ## Issue description

  When building something on macOS 10.14, using today's nixpkgs I get:

  ```
  /nix/store/lki08vfid5qgxc3niygjxq6w2yy3s02k-apple-framework-Security/Library/Frameworks/Security.framework/Headers/SecCertificate.h:146:5: error:
        expected function body after function declarator
      __OSX_AVAILABLE_STARTING(__MAC_10_12_4, __IPHONE_10_3);
  ```

  which is then followed by a bunch of undefined references to `Security.framework` structs. Am I missing anything trivial?

  ### Steps to reproduce


  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.1`
   - channels(ktf): `"nixpkgs-18.09pre154109.571b40d3f50, nixpkgs-19.03-19.03pre172363.b12b1e2f428, nixpkgs-unstable-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/Users/ktf/src/nix/nixpkgs`

  ```
  → which clang
  /nix/store/1af9gw0gimxrhzzf5zbhajzs9110ff6p-clang-wrapper-7.1.0/bin/clang
  ```


state: closed
title: zfs: fix install completions
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63047
updated_at: 2019-06-13 02:07:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The install command in https://github.com/NixOS/nixpkgs/pull/62986 was missing the completion file

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab: add link to nixos test in passthru.tests
user_login: Ekleog
html_url: https://github.com/NixOS/nixpkgs/pull/63048
updated_at: 2019-06-17 17:07:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Get tooling to automatically consider the nixos test when checking the derivation looks sane. Should not change anything meaningful :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] Windows Subsystem for Linux
user_login: ghuntley
html_url: https://github.com/NixOS/nixpkgs/pull/63049
updated_at: 2019-07-19 20:21:20
body:
  # backstory

  See https://github.com/NixOS/nixpkgs/issues/30391

  # technical information

  WSL2 is different to WSL1, see https://docs.microsoft.com/en-us/windows/wsl/wsl2-install for specifics but overall does not change how operating system distributions should package, register and ship their distribution into the app store. 

  See below for reference implementations for WSL1 which also work for WSL2:
  - https://github.com/microsoft/WSL-DistroLauncher 
  - https://salsa.debian.org/rhaist-guest/WSL/blob/master/create-targz.sh
  - https://wslstorestorage.blob.core.windows.net/wslblob/Ubuntu.1604.2017.711.0_v1.appx
  - https://github.com/Microsoft/WSL/issues/2618
  - https://github.com/DDoSolitary/LxRunOffline/releases
  - https://github.com/Microsoft/WSL/blob/master/CONTRIBUTING.md#8-detailed-logs

  # contacts at microsoft

  There's certain discussions I'll be able to have with Microsoft that others won't (NDA info stuffs) but for everything else these two folks are our contacts:

  - https://twitter.com/benhillis (software engineer)
  - https://twitter.com/craigaloewen (program management)


  # next steps
  - [x] Registered an account for the NixOS Foundation in the MSFT app store and reserve "NixOS" as an app name. 
  - [ ] Identify people to help out (comment on this PR and I'll grant you push access)
  - [ ] WSL does not support systemd without https://github.com/arkane-systems/genie so we need to check it out.
  - [ ] Create expression that generates an installation of nixos (without grub, containermode?) that produces a `install.tar.gz`
  - [ ] Import `https://github.com/microsoft/WSL-DistroLauncher`, customize it and consume `install.tar.gz`.
  - [ ] Iterate until it works on a Windows 10 machine
  - [ ] Send the `appx` to Microsoft (speak with Geoff) for pre-check verification.
  - [ ] How do we make this repeatable ala @GrahamcOfBorg? `WSL-DistroLauncher`  requires windows.
  - [ ] Obtain appstore credentials from @edolstra 
  - [ ] Automatic (or manual via shell script) uploading of the generated `appx` to the Windows Store


state: closed
title: cloud-nuke: init at 0.1.7
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63050
updated_at: 2019-06-19 12:22:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/gruntwork-io/cloud-nuke

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: noah: init at 0.5.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63051
updated_at: 2019-06-22 18:18:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/linux-noah/noah

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: fix nix-hacks.patch with the latest version of Bazel
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63052
updated_at: 2019-06-13 14:14:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The build is failing if `enableNixHacks = true;`.

  **NOTE**: This PR should be squashed when merging.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel-watcher: 0.9.1 -> 0.10.3
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63054
updated_at: 2019-06-13 04:57:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: makemkv: 1.14.3 -> 1.14.4
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/63055
updated_at: 2019-06-15 09:01:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changes:

  - Support for AACS v70
  - Many small improvements

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [WIP] gitlab: 11.10.4 -> 11.11.3
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63056
updated_at: 2019-07-10 08:33:02
body:
  ###### Motivation for this change

  Major gitlab upgrade 11.10.4 -> 11.11.3.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.bistro: init at 0.4.0
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/63057
updated_at: 2019-06-20 07:29:24
body:
  ###### Motivation for this change

  [bistro](https://github.com/pveber/bistro) is an OCaml library to build and run computations represented by a collection of interdependent scripts, as is often found in applied research (especially computational biology).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages.{bignums, coqprime}: enable for Coq 8.10
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/63058
updated_at: 2019-06-18 07:29:17
body:
  ###### Motivation for this change

  Libraries for latest version of Coq.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coreutils: Skip inotify dir-recreate test
user_login: saschagrunert
html_url: https://github.com/NixOS/nixpkgs/pull/63059
updated_at: 2019-06-18 09:20:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Some target platforms, especially when building inside a container
  have issues with the inotify test. I also saw issues related to that
  test under macOS so I would suggest in skipping that for now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  Relates to #59934


state: closed
title: gtk3: re-enable demos
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/63060
updated_at: 2019-06-20 06:52:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Demos are quite useful in debugging and developing gtk.
  They also end up in `gtk3.dev`, and do not impact the closure size of a
  running system.

  Plus, it has been five years now that they are disabled ;-)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Vulnerability roundup 69: binutils-2.31.1: 3 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63061
updated_at: 2019-06-13 17:01:54
body:
  [search](https://search.nix.gsc.io/?q=binutils&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=binutils+in%3Apath&type=Code)

  * [ ] [CVE-2018-17358](https://nvd.nist.gov/vuln/detail/CVE-2018-17358) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2018-17359](https://nvd.nist.gov/vuln/detail/CVE-2018-17359) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2018-17360](https://nvd.nist.gov/vuln/detail/CVE-2018-17360) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: 98e3b90b6c8; nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: bubblewrap-0.3.1: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63062
updated_at: 2019-06-17 08:19:27
body:
  [search](https://search.nix.gsc.io/?q=bubblewrap&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=bubblewrap+in%3Apath&type=Code)

  * [x] [CVE-2019-12439](https://nvd.nist.gov/vuln/detail/CVE-2019-12439) (nixos-19.03)

  Scanned versions: nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: curl-7.64.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63063
updated_at: 2019-06-16 16:23:38
body:
  [search](https://search.nix.gsc.io/?q=curl&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=curl+in%3Apath&type=Code)

  * [x] [CVE-2019-5435](https://nvd.nist.gov/vuln/detail/CVE-2019-5435) (nixos-19.03)

  Scanned versions: nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: dhcpcd-7.1.1: 4 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63064
updated_at: 2019-06-23 08:24:16
body:
  [search](https://search.nix.gsc.io/?q=dhcpcd&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=dhcpcd+in%3Apath&type=Code)

  * [x] [CVE-2019-11577](https://nvd.nist.gov/vuln/detail/CVE-2019-11577) (nixos-19.03)
  * [x] [CVE-2019-11578](https://nvd.nist.gov/vuln/detail/CVE-2019-11578) (nixos-19.03)
  * [x] [CVE-2019-11579](https://nvd.nist.gov/vuln/detail/CVE-2019-11579) (nixos-19.03)
  * [x] [CVE-2019-11766](https://nvd.nist.gov/vuln/detail/CVE-2019-11766) (nixos-19.03)

  Scanned versions: nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: glib-2.58.2: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63065
updated_at: 2019-06-16 16:23:22
body:
  [search](https://search.nix.gsc.io/?q=glib&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=glib+in%3Apath&type=Code)

  * [x] [CVE-2019-12450](https://nvd.nist.gov/vuln/detail/CVE-2019-12450) (nixos-19.03)

  Scanned versions: nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: go-1.12.5: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63066
updated_at: 2019-07-13 13:34:44
body:
  [search](https://search.nix.gsc.io/?q=go&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=go+in%3Apath&type=Code)

  * [ ] [CVE-2018-17075](https://nvd.nist.gov/vuln/detail/CVE-2018-17075) (nixos-unstable)
  * [x] [CVE-2019-11888](https://nvd.nist.gov/vuln/detail/CVE-2019-11888) (nixos-unstable)

  Scanned versions: nixos-unstable: 98e3b90b6c8. May contain false positives.


state: closed
title: Vulnerability roundup 69: gvfs-1.38.2: 3 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63067
updated_at: 2019-06-25 15:28:45
body:
  [search](https://search.nix.gsc.io/?q=gvfs&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gvfs+in%3Apath&type=Code)

  * [x] [CVE-2019-12447](https://nvd.nist.gov/vuln/detail/CVE-2019-12447) (nixos-19.03)
  * [x] [CVE-2019-12448](https://nvd.nist.gov/vuln/detail/CVE-2019-12448) (nixos-19.03)
  * [x] [CVE-2019-12449](https://nvd.nist.gov/vuln/detail/CVE-2019-12449) (nixos-19.03)

  Scanned versions: nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: jquery-1.11.3: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63068
updated_at: 2019-06-18 07:38:41
body:
  [search](https://search.nix.gsc.io/?q=jquery&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=jquery+in%3Apath&type=Code)

  * [ ] [CVE-2015-9251](https://nvd.nist.gov/vuln/detail/CVE-2015-9251) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: 98e3b90b6c8; nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: libgit2-0.26.6: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63069
updated_at: 2019-06-17 07:42:45
body:
  [search](https://search.nix.gsc.io/?q=libgit2&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libgit2+in%3Apath&type=Code)

  * [x] [CVE-2018-10887](https://nvd.nist.gov/vuln/detail/CVE-2018-10887) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2018-10888](https://nvd.nist.gov/vuln/detail/CVE-2018-10888) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: 98e3b90b6c8; nixos-19.03: 4649b6ef4b5. May contain false positives.


state: closed
title: Vulnerability roundup 69: qemu-4.0.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/63070
updated_at: 2019-06-17 05:59:21
body:
  [search](https://search.nix.gsc.io/?q=qemu&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=qemu+in%3Apath&type=Code)

  * [x] [CVE-2019-12155](https://nvd.nist.gov/vuln/detail/CVE-2019-12155) (nixos-unstable)

  Scanned versions: nixos-unstable: 98e3b90b6c8. May contain false positives.


state: closed
title: maintainers: add dmvianna
user_login: dmvianna
html_url: https://github.com/NixOS/nixpkgs/pull/63071
updated_at: 2019-06-13 08:36:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add maintainer (myself)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cannot bind port in sandbox on macOS
user_login: nmattia
html_url: https://github.com/NixOS/nixpkgs/issues/63072
updated_at: 2019-06-24 14:03:37
body:
  ## Issue description

  It's not possible to bind a localhost port in the sandbox on macOS. The permissions is denied for `localhost`, `127.0.0.1` and `::1`. According to [bazel people](https://source.bazel.build/bazel/+/6b8c7ca48e9e48a9906c031346dc4a924b7ef559:src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java;l=691) it should work with IPv6, however for me it fails as well.

  Is there any known workaround?

  ### Steps to reproduce

  ``` nix
  { pkgs ? import <nixpkgs> {} }:

  pkgs.runCommand "sandbox-test" { buildInputs = [ pkgs.haskellPackages.wai-app-static ]; }
  ''
    warp -p 3000 --host ::1 # same with localhost, 127.0.0.1, 0.0.0.0
    touch $out
  ''
  ```

  gives

  ```
  warp: Network.Socket.bind: permission denied (Operation not permitted)
  ```
  ## Technical details

  ```
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.6.0, macOS 10.14.5`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(nicolas): `"nixpkgs-19.09pre181045.61f0936d1cd"`
   - nixpkgs: `/nix/store/4xv5p5hjlnqvkx1k73vgm3cn6xiar0wr-source`
  ```


state: open
title: pytorch-1.1.0
user_login: juliendehos
html_url: https://github.com/NixOS/nixpkgs/issues/63073
updated_at: 2019-07-18 02:08:15
body:
  Hi,
  I'm trying to build pytorch-1.1.0 on NixOS 19.03 and unstable but it fails. Any idea ?
  @teh @thoughtpolice 

  nix config: https://github.com/juliendehos/nixpkgs/commit/db04f3e9269251e4979ce230beddfb3abe27450c

  full log: https://gist.github.com/juliendehos/25653c6286001007e52ebbed466fbfab

  partial log:
  ```
  Building wheel torch-1.1.0
  -- Building version 1.1.0
  ['cmake',
   '-DBUILDING_WITH_TORCH_LIBS=ON',
   '-DBUILD_BINARY=False',
   '-DBUILD_CAFFE2_OPS=True',
   '-DBUILD_PYTHON=True',
   '-DBUILD_SHARED_LIBS=ON',
   '-DBUILD_TEST=True',
   '-DBUILD_TORCH=ON',
   '-DCAFFE2_STATIC_LINK_CUDA=False',
   '-DCMAKE_BUILD_TYPE=Release',
   '-DCMAKE_CXX_FLAGS= ',
   '-DCMAKE_C_FLAGS= ',
   '-DCMAKE_EXE_LINKER_FLAGS=',
   '-DCMAKE_INSTALL_PREFIX=/build/source/torch',
   '-DCMAKE_PREFIX_PATH=/nix/store/7yw89ki05nsw4kz05hqnqccnk6m3wpam-openblas-0.3.6:/nix/store/ars3pcklw0gan1hvjz9a07bgysfjb66v-numactl-2.0.12:/nix/store/szxc9q0vbzfixbgmwwb99dasf1j8065x-python3.7-bootstrapped-pip-19.0.3:/nix/store/wvwmzd5ab015276vvnif907aqgjnc80l-python3.7-cffi-1.12.3-dev:/nix/store/pyx1bq09y1bdhwili4anwgcizvmyj51j-libffi-3.2.1-dev:/nix/store/kwl4klw1a0mqgarxqa8bq25kf7i6c5k9-libffi-3.2.1:/nix/store/js4lkkp5725vd0nasrqj8vdc5qx3c7zn-python3.7-pycparser-2.19:/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3:/nix/store/zhhnxn9np7ly8gdycldvkdkzc7sgkjrq-python3.7-setuptools-41.0.1:/nix/store/zhhnxn9np7ly8gdycldvkdkzc7sgkjrq-python3.7-setuptools-41.0.1:/nix/store/x7qqhwj2jx30bvcy0lif47wa97kfzqgb-python3.7-cffi-1.12.3:/nix/store/gch9w32080lpnxixcabmwnl1gdrkz6n3-python3.7-numpy-1.16.3:/nix/store/z4rbwzhmws8ds2dca4diwvncw0qf4113-python3.7-PyYAML-5.1',
   '-DCMAKE_SHARED_LINKER_FLAGS=',
   '-DINSTALL_TEST=True',
   '-DNCCL_EXTERNAL=False',
   '-DNUMPY_INCLUDE_DIR=/nix/store/gch9w32080lpnxixcabmwnl1gdrkz6n3-python3.7-numpy-1.16.3/lib/python3.7/site-packages/numpy/core/include',
   '-DONNX_ML=False',
   '-DONNX_NAMESPACE=onnx_torch',
   '-DPYTHON_EXECUTABLE=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/bin/python3.7',
   '-DPYTHON_INCLUDE_DIR=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/include/python3.7m',
   '-DPYTHON_LIBRARY=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/lib/libpython3.7m.so.1.0',
   '-DTHD_SO_VERSION=1',
   '-DTORCH_BUILD_VERSION=1.1.0',
   '-DUSE_CUDA=False',
   '-DUSE_DISTRIBUTED=True',
   '-DUSE_FBGEMM=True',
   '-DUSE_FFMPEG=False',
   '-DUSE_LEVELDB=False',
   '-DUSE_LMDB=False',
   '-DUSE_MKLDNN=True',
   '-DUSE_NCCL=False',
   '-DUSE_NNPACK=True',
   '-DUSE_NUMPY=True',
   '-DUSE_OPENCV=False',
   '-DUSE_QNNPACK=True',
   '-DUSE_ROCM=False',
   '-DUSE_SYSTEM_EIGEN_INSTALL=OFF',
   '-DUSE_SYSTEM_NCCL=False',
   '-DUSE_TENSORRT=False',
   '-DMKLDNN_ENABLE_CONCURRENT_EXEC=ON',
   '/build/source']
  Traceback (most recent call last):
    File "nix_run_setup", line 8, in <module>
      exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    File "setup.py", line 725, in <module>
      build_deps()
    File "setup.py", line 285, in build_deps
      build_dir='build')
    File "/build/source/tools/build_pytorch_libs.py", line 259, in build_caffe2
      my_env)
    File "/build/source/tools/build_pytorch_libs.py", line 239, in run_cmake
      check_call(cmake_args, cwd=build_dir, env=my_env)
    File "/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/lib/python3.7/subprocess.py", line 347, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['cmake', '-DBUILDING_WITH_TORCH_LIBS=ON', '-DBUILD_BINARY=False', '-DBUILD_CAFFE2_OPS=True', '-DBUILD_PYTHON=True', '-DBUILD_SHARED_LIBS=ON', '-DBUILD_TEST=True', '-DBUILD_TORCH=ON', '-DCAFFE2_STATIC_LINK_CUDA=False', '-DCMAKE_BUILD_TYPE=Release', '-DCMAKE_CXX_FLAGS= ', '-DCMAKE_C_FLAGS= ', '-DCMAKE_EXE_LINKER_FLAGS=', '-DCMAKE_INSTALL_PREFIX=/build/source/torch', '-DCMAKE_PREFIX_PATH=/nix/store/7yw89ki05nsw4kz05hqnqccnk6m3wpam-openblas-0.3.6:/nix/store/ars3pcklw0gan1hvjz9a07bgysfjb66v-numactl-2.0.12:/nix/store/szxc9q0vbzfixbgmwwb99dasf1j8065x-python3.7-bootstrapped-pip-19.0.3:/nix/store/wvwmzd5ab015276vvnif907aqgjnc80l-python3.7-cffi-1.12.3-dev:/nix/store/pyx1bq09y1bdhwili4anwgcizvmyj51j-libffi-3.2.1-dev:/nix/store/kwl4klw1a0mqgarxqa8bq25kf7i6c5k9-libffi-3.2.1:/nix/store/js4lkkp5725vd0nasrqj8vdc5qx3c7zn-python3.7-pycparser-2.19:/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3:/nix/store/zhhnxn9np7ly8gdycldvkdkzc7sgkjrq-python3.7-setuptools-41.0.1:/nix/store/zhhnxn9np7ly8gdycldvkdkzc7sgkjrq-python3.7-setuptools-41.0.1:/nix/store/x7qqhwj2jx30bvcy0lif47wa97kfzqgb-python3.7-cffi-1.12.3:/nix/store/gch9w32080lpnxixcabmwnl1gdrkz6n3-python3.7-numpy-1.16.3:/nix/store/z4rbwzhmws8ds2dca4diwvncw0qf4113-python3.7-PyYAML-5.1', '-DCMAKE_SHARED_LINKER_FLAGS=', '-DINSTALL_TEST=True', '-DNCCL_EXTERNAL=False', '-DNUMPY_INCLUDE_DIR=/nix/store/gch9w32080lpnxixcabmwnl1gdrkz6n3-python3.7-numpy-1.16.3/lib/python3.7/site-packages/numpy/core/include', '-DONNX_ML=False', '-DONNX_NAMESPACE=onnx_torch', '-DPYTHON_EXECUTABLE=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/bin/python3.7', '-DPYTHON_INCLUDE_DIR=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/include/python3.7m', '-DPYTHON_LIBRARY=/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/lib/libpython3.7m.so.1.0', '-DTHD_SO_VERSION=1', '-DTORCH_BUILD_VERSION=1.1.0', '-DUSE_CUDA=False', '-DUSE_DISTRIBUTED=True', '-DUSE_FBGEMM=True', '-DUSE_FFMPEG=False', '-DUSE_LEVELDB=False', '-DUSE_LMDB=False', '-DUSE_MKLDNN=True', '-DUSE_NCCL=False', '-DUSE_NNPACK=True', '-DUSE_NUMPY=True', '-DUSE_OPENCV=False', '-DUSE_QNNPACK=True', '-DUSE_ROCM=False', '-DUSE_SYSTEM_EIGEN_INSTALL=OFF', '-DUSE_SYSTEM_NCCL=False', '-DUSE_TENSORRT=False', '-DMKLDNN_ENABLE_CONCURRENT_EXEC=ON', '/build/source']' returned non-zero exit status 1.
  builder for '/nix/store/0j949x31b7fg26m8kbqar4ynl54qq5b1-python3.7-pytorch-1.1.0.drv' failed with exit code 1
  error: build of '/nix/store/0j949x31b7fg26m8kbqar4ynl54qq5b1-python3.7-pytorch-1.1.0.drv' failed
  ```


state: closed
title: bazel: add update script to update srcDeps from WORKSPACE file
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/63077
updated_at: 2019-06-18 15:47:03
body:
  This adds an automated updater that can “parse” the bazel WORKSPACE file to dump most dependencies into a JSON file, meaning we don’t have to update dependencies by hand (and also don’t forget when updating bazel).

  cc @groodt @uri-canva 

  After I implemented it, I actually noticed that the bazel build itself doesn’t use these dependencies, only if you want to run the tests afterwards they are needed, and we disabled the tests :( 

  So the next step is to move the `installTests` into a different derivation, like we do with `passthru.tests`.

  @GrahamcOfBorg build bazel.tests

  ###### Things done

  <!-- Plea check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: inconsolata-nerdfont: init at 2.0.0
user_login: dmvianna
html_url: https://github.com/NixOS/nixpkgs/pull/63079
updated_at: 2019-06-13 12:52:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  nerdfonts-2.0.0 is a 2GB download. Each of these is < 10 MB download. It makes sense to provide separate packages for each font. This prevents issues such as described in #47921.

  ###### Things done

  I build both, installed on my system and checked their presence with font-manager.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Improve ZFS Bash completions user expirience
user_login: caadar
html_url: https://github.com/NixOS/nixpkgs/pull/63081
updated_at: 2019-06-20 19:29:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ZFS needs a completions/zpool because completions/zfs is not sourced until the user attempts to autocomplete the zfs command. So zpool completions requires to try complete zfs
  command at first. Let's make zfs and zpool completions independant in work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: SPAdes: init at 3.13.1
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/63082
updated_at: 2019-07-06 12:35:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Bioinformatic tool used into my laboratory

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos-generate-config: don't generate swapDevices for *files*
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/63083
updated_at: 2019-06-16 13:26:39
body:
  ###### Motivation for this change
  Up until now, the output has been the same for swap devices and swap
  files:

    { device = "/var/swapfile"; }

  Whereas for swap *files* it's easier to manage them declaratively in
  configuration.nix:

    { device = "/var/swapfile"; size = 8192; }

  (NixOS will create the swapfile, and later resize it, if the size
  attribute is changed.)

  With the assumption that swap files are specified in configuration.nix,
  it's silly to output them to hardware-configuration.nix.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package qt4 requires missing patch
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/issues/63084
updated_at: 2019-06-13 16:51:21
body:
  The following URL: https://git.archlinux.org/svntogit/packages.git/plain/trunk/qt4-gcc6.patch?h=packages/qt4&id=ca773a144f5abb244ac4f2749eeee9333cac001f

  referenced here: https://github.com/NixOS/nixpkgs/blob/49dc8087a20e0d742d38be5f13333a03d171006a/pkgs/development/libraries/qt-4.x/4.8/default.nix#L87

  now returns a page with an error `Invalid branch: packages/qt4`

  Appears to affect master and nixos-19.03. 


state: open
title: locate index service don't index binaries
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63086
updated_at: 2019-06-13 15:12:46
body:
  ## Issue description

  Ubuntu
  ```
  [davidak@ethmoid:~]$ docker run -ti --rm debian
  root@98bef3f4278e:/# apt update
  root@98bef3f4278e:/# apt install locate
  root@98bef3f4278e:/# updatedb       
  root@98bef3f4278e:/# locate -eir "/bash$"
  /bin/bash
  /usr/share/doc/bash
  /usr/share/lintian/overrides/bash
  /usr/share/menu/bash
  ```

  I expect to find bash binary also on NixOS, but output is empty.

  ```
  [admin@target1:~]$ locate -eir "/bash$"

  ```

  bash is an symlink to `/nix/store` which is excluded from index
  ```
  [root@target1:~]# which bash
  /run/current-system/sw/bin/bash
  ```

  Does locate not index symlinks? Maybe it could follow them?

  ### Steps to reproduce

  Add this lines to `configuration.nix`:
  ```
    # Install locate, build database at 2:15 AM every day
    environment.systemPackages = with pkgs; [ findutils ];
    services.locate.enable = true;
  ```

  Run:

  ```
  [admin@target1:~]$ locate -eir "/bash$"

  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.46, NixOS, 19.03.172758.36516712916 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Fix ddclient extraConfig
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/63087
updated_at: 2019-06-21 07:54:28
body:
  This superceeds https://github.com/NixOS/nixpkgs/pull/39092

  According to commit ba0ba6dc7934a6b4cc5d4090739a3a1c839afe67 (which is cherry-picked here, but completely rewritten), the domains should be last.

  This commit fixes this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Not tested at all.

  Unfortunately, ddclient has no maintainer but @dezgeg was the person who edited the file recently (as in "was the last one touching the ddlcient package defintion), so they get pinged here (sorry).


state: closed
title: gappa: update and add Coq support library
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/63088
updated_at: 2019-06-19 09:24:42
body:
  ###### Motivation for this change

  Use up-to-date gappa from Coq.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Tootle - has no icons , crash on startup after add account
user_login: pirboazo
html_url: https://github.com/NixOS/nixpkgs/issues/63089
updated_at: 2019-06-17 10:20:22
body:
  ## Issue description
  Hi @dtzWill 
  i open 3 issues on tootle  : https://github.com/bleakgrey/tootle
  No icons 
  ![Selection_023](https://user-images.githubusercontent.com/1702929/59446476-dddefa00-8e01-11e9-961a-4be0c3f444e1.png)
  Impossible to mdify setting 
  crash after append a new account.



  ### Steps to reproduce
  Just install and launch application


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/m57p0m5m6fz7j58g1bamsrxq5prsgpl2-bash-interactive-4.4-p23-dev
  copying path '/nix/store/m57p0m5m6fz7j58g1bamsrxq5prsgpl2-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.50, NixOS, 19.03.172880.49dc8087a20 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172880.49dc8087a20"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: kernel.nix: boot.vesa implies nomodeset
user_login: wmertens
html_url: https://github.com/NixOS/nixpkgs/pull/63090
updated_at: 2019-06-20 21:11:45
body:
  Without nomodeset the console is reset to 80x25 after Grub.

  ###### Motivation for this change

  The standard configuration, even with `boot.vesa = true`, results in a tiny virtual console.

  ###### Things done

  Tested this configuration on a VM; did not test this actual change.


state: open
title: Fix bug. Replace networking.enableIntel2200BGFirmware
user_login: NilsIrl
html_url: https://github.com/NixOS/nixpkgs/pull/63091
updated_at: 2019-06-24 00:34:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  When running `nixos-install` the error `error: The option networking.enableIntel2200BGFirmware defined in /mnt/etc/nixos/hardware-configuration.nix does not exist` shows up.

  To fix this I was told to replace it with `hardware.enableRedistributableFirmware` by @srhb on IRC.

  ###### Things done

  Installed nixos on a laptop.

  ---


state: closed
title: pythonPackages.toggl-cli: init at 2.1.0 (and its dependencies)
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63092
updated_at: 2019-06-18 18:53:49
body:
  ###### Motivation for this change

  - pythonPackages.togglCli: init at 2.1.0

  And its dependencies:

  - pythonPackages.validate_email: init at 1.3
  - pythonPackages.readchar: init at 2.0.1
  - pythonPackages.inquirer: init at 2.6.3
  - pythonPackages.PTable: init at 0.9.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Qt macdeploytool complains about not finding qmlimportscanner
user_login: arximboldi
html_url: https://github.com/NixOS/nixpkgs/issues/63093
updated_at: 2019-06-25 13:34:09
body:
  ## Issue description

  When running the `macdeploytool` provided by the `qt5.qttools` package, it complains about not finding the `qmlimportscanner` tool, which is provided by `q5.qtdeclarative`.

  I have not found a suitable workaround, since it seems like the location of the scanner is hardcoded inside `macdeploytool` 😢 

  ### Steps to reproduce

  Invoke `macdeploytool` on a project using Qt. How to use this tool is explained here: https://doc.qt.io/qt-5/deployment.html


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-darwin"`
   - host os: `Darwin 16.7.0, macOS 10.12.6`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(raskolnikov): `"darwin, nixpkgs-19.09pre181045.61f0936d1cd"`
   - nixpkgs: `/Users/raskolnikov/.nix-defexpr/channels/nixpkgs`


state: open
title: python package xgboost: libxgboost.so, 6: image not found?
user_login: clojurians-org
html_url: https://github.com/NixOS/nixpkgs/issues/63094
updated_at: 2019-06-13 16:50:29
body:
  ## Issue description

  i can use numpy package to enter the repl, but it failed with xgboost.
  even i add system library dependecy in default.nix, it still fail with "image not found"
  in fact, it's dylib format on my mac os
  ```
  larrys-MBP:tmp larluo$ ls -l /nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/
  total 4120
  -r-xr-xr-x  1 larluo  wheel  2106704 Jan  1  1970 libxgboost.dylib
  ```

  ### Steps to reproduce
  ```
  nix-shell -p python37Packages.numpy --run "python3"
  nix-shell -p python37Packages.xgboost --run "python3"

  larrys-MBP:tmp larluo$ cat default.nix 
  with import <nixpkgs> {}; 
  with python37Packages;

  buildPythonPackage rec {
    name = "larluo";
    src = ./. ;

    buildInputs = [ pkgs.xgboost ];
    propagatedBuildInputs = [ xgboost  ];

  }

  nix-shell
  ```

  the log:
  ```
  adding 'xgboost-0.72.dist-info/METADATA'                                                                                                                          
  adding 'xgboost-0.72.dist-info/WHEEL'                                                                                                                             
  adding 'xgboost-0.72.dist-info/top_level.txt'                                                                                                                     
  adding 'xgboost-0.72.dist-info/RECORD'                                                                                                                            
  removing build/bdist.macosx-10.6-x86_64/wheel                                                                                                                     
  installing                                                                                                                                                        
  /private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/dist /private/var/folders/_3/80s5534109d2j8
  3cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package                                                                                  
  Processing ./xgboost-0.72-py3-none-any.whl                                                                                                                        
  Requirement already satisfied: scipy in /nix/store/mhgmmg0bb3q8b37l7p2qfhfcrsw8kw89-python3.7-scipy-1.2.1/lib/python3.7/site-packages (from xgboost==0.72) (1.2.1$
  Requirement already satisfied: numpy in /nix/store/6xh6gincdymys2wkzl2mwgf0742njad2-python3.7-numpy-1.16.2/lib/python3.7/site-packages (from xgboost==0.72) (1.16$
  2)                                                                                                                                                                
  Installing collected packages: xgboost                                                                                                                            
  Successfully installed xgboost-0.72                                                                                                                               
  /private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package                                            
  post-installation fixup                                                                                                                                           
  strip is /nix/store/xcvvrjbck0n51603nnkyba3dszmhndi0-cctools-binutils-darwin/bin/strip                                                                            
  stripping (with command strip and flags -S) in /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib                                             
  patching script interpreter paths in /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72                                                           
  /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib/python3.7/site-packages/xgboost/build-python.sh: interpreter directive changed from "/bin/s
  h" to "/nix/store/yvw6l7vm91jnm2rb3ypzp563vnlns30s-bash-4.4-p23/bin/sh"                                                                                           

  ...
  ...
  /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib/python3.7/site-packages/xgboost/rabit/test/local_recover.py: interpreter directiv[496/1883]
  from "/usr/bin/python" to "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/bin/python"
  running install tests
  EEEEEEEEEEEEEE
  ======================================================================
  ERROR: Failure: OSError (dlopen(/nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/libxgboost.so, 6): image not found)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/tests/python/test_basic.py", line 3, in <module>
      import xgboost as xgb
    File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/__init__.py", line 11, in <
  module>
      from .core import DMatrix, Booster
    File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/core.py", line 115, in <mod
  ule>
      _LIB = _load_lib()
    File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/core.py", line 109, in _loa
  d_lib
      lib = ctypes.cdll.LoadLibrary(lib_path[0])
    File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/ctypes/__init__.py", line 434, in LoadLibrary
      return self._dlltype(name)
    File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/ctypes/__init__.py", line 356, in __init__
      self._handle = _dlopen(self._name, mode)
  OSError: dlopen(/nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/libxgboost.so, 6): image not found
  ```

  ## Technical details
  ```
  larrys-MBP:tmp larluo$ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.01 MiB download, 0.03 MiB unpacked):
    /nix/store/qdgab1z17d2pff5ipzrlhhmhcpv8zyrr-nix-info
    /nix/store/w6j2wz4dkb2ma2v64ramg0z7nngisi2r-DarwinTools-1
  copying path '/nix/store/w6j2wz4dkb2ma2v64ramg0z7nngisi2r-DarwinTools-1' from 'https://cache.nixos.org'...
  copying path '/nix/store/qdgab1z17d2pff5ipzrlhhmhcpv8zyrr-nix-info' from 'https://cache.nixos.org'...
   - system: `"x86_64-darwin"`
   - host os: `Darwin 16.0.0, macOS 10.12`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(larluo): `"nixpkgs-19.09pre178484.8bc70c937b3"`
   - nixpkgs: `/Users/larluo/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: opencascade: build with vtk and freeimage, patch for fontconfig support
user_login: gebner
html_url: https://github.com/NixOS/nixpkgs/pull/63095
updated_at: 2019-06-14 15:46:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  OpenCASCADE didn't find any fonts on NixOS, see https://github.com/tpaviot/oce/pull/714

  cc maintainer @viric 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: building java targets fails because bazel downloads ijar binary
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/issues/63096
updated_at: 2019-06-24 20:28:41
body:
  ## Issue description

  Bazel fetches a binary at runtime and tries to execute it, which of course fails on NixOS:

  ```
  ERROR: /home/philip/.cache/bazel/_bazel_philip/cccb2d2da8416067607b8c5cff088df0/external/org_apache_spark_spark_core_2_10/BUILD:7:1: Extracting interface @org_apache_spark_spark_core_2_10//:org_apache_spark_spark_core_2_10 failed (Exit 1) ijar failed: error executing command external/remote_java_tools_linux/java_tools/ijar/ijar external/org_apache_spark_spark_core_2_10/spark-core_2.10-1.6.0.jar ... (remaining 3 argument(s) skipped)

  Use --sandbox_debug to see verbose messages from the sandbox
  src/main/tools/linux-sandbox-pid1.cc:427: "execvp(external/remote_java_tools_linux/java_tools/ijar/ijar, 0x62e860)": No such file or directory
  ```

  Related to https://github.com/bazelbuild/bazel/issues/8575

  ### Steps to reproduce

  Build any Java rule with bazel 0.26.1 in nixpkgs on NixOS.

  cc @groodt @kalbasit


state: open
title: fbthrift: init at v2019.06.10.00
user_login: pierreis
html_url: https://github.com/NixOS/nixpkgs/pull/63097
updated_at: 2019-06-13 22:49:47
body:
  ###### Motivation for this change

  Added Fbthrift library and its dependencies

  **New packages**:

  1. Fbthrift (v2019.06.10.00)
  2. Fizz (v2019.06.10.00)
  3. Wangle (v2019.06.10.00)
  4. rsocket-cpp (git master)

  **Updated packages**

  1. Folly (v2019.05.27.00 >> v2019.06.10.00)

  **Fixed packages**

  1. Fixed fmt cmake manifest generation


  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: GitHub Semantic
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/63098
updated_at: 2019-06-27 06:27:20
body:
  [Semantic](https://github.com/github/semantic) is a Haskell library and command line tool for parsing, analyzing, and comparing source code.

  > Semantic uses tree-sitter to generate parse trees, but layers in a more generalized notion of syntax terms across all supported programming languages.

  This means that is can produce syntax-aware diffs, in many programming languages.


state: closed
title: rustc: 1.34.2 -> 1.35.0
user_login: edolstra
html_url: https://github.com/NixOS/nixpkgs/pull/63099
updated_at: 2019-07-03 08:43:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: drop unmaintained phabricator package, service, and httpd subservice
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63100
updated_at: 2019-06-15 11:17:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Stuck on a version from 2014, time for someone to either take this on or drop it.

  If everyone agrees this should be dropped then I'll add release notes before we merge.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/gitea: Generate a JWT secret for git LFS
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/63101
updated_at: 2019-06-27 18:06:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages: fix + add multinomials 1.3 + coqeal 1.0.0
user_login: CohenCyril
html_url: https://github.com/NixOS/nixpkgs/pull/63102
updated_at: 2019-06-13 23:29:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding latest releases of multinomials and coqeal + fixing mathcomp extra packages (i.e. reducing the number of dependencies by taking into account arguments that used to be ignored and fixing the naming policy)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Deprecate types.loaOf [WIP]
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/63103
updated_at: 2019-07-04 08:02:59
body:
  ###### Motivation for this change
  Fix issue #1800.

  It turns out this is a lot of work: there are many instances of lists being used instead of sets.
  The main culprits are `users.users` and `environment.etc`.
  I think I have identified most of them but there are still some, moreover all this changes should be properly tested so I definitely need some help.


state: open
title: Boost 1.70 cmake config broken
user_login: ktf
html_url: https://github.com/NixOS/nixpkgs/issues/63104
updated_at: 2019-06-24 23:10:37
body:
  ## Issue description

  Looks like the CMake config files produced by boost 1.70 do not work correctly because they assume the headers and the library to be in the same top-level folder (they are not, due to the fact there is "out" and "dev").

  ### Steps to reproduce

  Have a Cmakefile which does `find_package(Boost REQUIRED COMPONENTS unit_test_framework)` and try to build it.

  ## Technical details

  ```
  → nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.1`
   - channels(ktf): `"nixpkgs-18.09pre154109.571b40d3f50, nixpkgs-19.03-19.03pre172363.b12b1e2f428, nixpkgs-unstable-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/Users/ktf/src/nix/nixpkgs`
  ```


state: open
title: habitat: 0.32.2 -> 0.82.0
user_login: boj
html_url: https://github.com/NixOS/nixpkgs/pull/63105
updated_at: 2019-06-25 16:06:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New attempt after closing https://github.com/NixOS/nixpkgs/pull/46138

  Fixes the cargoSha256 problem here for habitat: https://github.com/NixOS/nixpkgs/pull/62047

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cocoapods: 1.7.1 -> 1.7.2
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/63106
updated_at: 2019-06-15 18:49:22
body:
  Also update cocoapods-beta to match.

  ###### Motivation for this change

  https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Lua/luarocks packaging improvements
user_login: Shados
html_url: https://github.com/NixOS/nixpkgs/pull/63108
updated_at: 2019-07-06 04:04:52
body:
  ###### Motivation for this change
  I got annoyed by some issues in the existing luarocks packaging infrastructure while trying to use it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
      - Well, I used `--dry-run` and built the attrs separately for easier debugging
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
      - "Relevant documentation" is only up to date in the sense that there is no existing `buildLuarocksPackage` documentation, something this PR does not change ;).
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Details of the changes are given in the commit messages. Broadly:
  - Improved the `update-luarocks-packages` script
  - Fixed several bugs in and made improvements to `buildLuarocksPackages`
  - Migrated as many Lua packages as possible from hand-written derivations to generated luarocks-based ones

  I've done some history editing to break up the commits into somewhat-logical groupings to make things easier to look through. Interim commits don't necessarily represent a working state for nixpkgs, though.

  Some possible issues:
  - prosody's `withDBI` argument won't work on its own now, as `luadbi` has been split into the front-end `luadbi` module and the back-end `luadbi-mysql`, `luadbi-postgresql`, and `luadbi-sqlite3` modules. I *think* it should be sufficient to build prosody with arguments like `withDBI = true; withExtraLibs = [ lua.pkgs.luadbi-sqlite3 ];`, for example, but I don't have a prosody setup to test with.
  - I've removed various Darwin-specific makefile/builder tweaks in the Lua packages that were moved to generated luarocks ones. These *should* be unnecessary in the new packages, as in each case the package uses luarocks `builtin` build type, which is theoretically cross-platform. But I don't have a mac to test this assertion with.
  - I've tested that the main executables of each affected package (that has executables) run without throwing related errors, but that's not a guarantee they're working, of course.
  - `torchPackages` were broken before, and still are now. I spent some time and effort looking into getting them to build, but while most of it isn't too bad, torch itself and some of its dependent torch-specific packages do some fairly wonky things and make bad assumptions in their cmake files.
      - e.g. torch assumes that the location of the `lua` binary and the install directory for torch are under a shared `$PREFIX`, and that it is OK to write to the system Lua share directory.
      - They've been broken in unstable for months now. Is anyone actually using this in nixpkgs? @grwlf?


state: closed
title: cargo-xbuild: 0.5.11 -> 0.5.12
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63109
updated_at: 2019-06-14 11:11:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-xbuild` to the latest release.
  https://github.com/rust-osdev/cargo-xbuild/releases/tag/v0.5.12

  `cargo-xbuild` is a subcommand for `cargo`. You need to invoke `cargo-xbuild` via `cargo` command.
  To test the binary files in `./result/bin`, consider the following commands:
  ```
  [john@nixos:~/result/bin] PATH=.:$PATH cargo xbuild --version
  cargo-xbuild 0.5.12
  ```
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libreoffice-fresh: doesn't build on unstable
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/63110
updated_at: 2019-06-16 13:52:41
body:
  ## Issue description

  As the title says. Been like that for a week or so.

  On unstable as of 2019-06-14

  Cc: @pbogdan @7c6f434c 


state: open
title: ExifTool 11.50 won’t launch on macOS
user_login: bdesham
html_url: https://github.com/NixOS/nixpkgs/issues/63111
updated_at: 2019-06-23 04:34:53
body:
  ## Issue description

  I just upgraded nixpkgs.perlPackages.ImageExifTool from 11.49 to 11.50. When I try to run it I get this error:

  ```
  $ exiftool --version
  zsh: /Users/bdesham/.nix-profile/bin/exiftool: bad interpreter: /nix/store/h400cvgl5nd2a2sq6qlzzxxs26dqpj7g-perl-5.28.2/bin/perl -w -I/nix/store/h400cvgl5nd2a2sq6qlzzxxs26dqpj7g-perl-5.28.2/: exec format error

  $ which exiftool
  /Users/bdesham/.nix-profile/bin/exiftool

  $ head -n 5 /Users/bdesham/.nix-profile/bin/exiftool
  #!/nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/bin/perl -w -I/nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/lib/perl5/site_perl -I/nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/lib/perl5/site_perl -I/nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/lib/perl5/site_perl -I/nix/store/afidq126rg2mdszla89ycc2vzrcp4fd2-perl5.28.2-Image-ExifTool-11.49/lib/perl5/site_perl
  #------------------------------------------------------------------------------
  # File:         exiftool
  #
  # Description:  Read/write meta information

  $ stat /nix/store/h400cvgl5nd2a2sq6qlzzxxs26dqpj7g-perl-5.28.2/bin/perl
    File: /nix/store/h400cvgl5nd2a2sq6qlzzxxs26dqpj7g-perl-5.28.2/bin/perl
    Size: 9548      	Blocks: 24         IO Block: 4096   regular file
  [...]

  $ stat /nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/lib/perl5/site_perl
    File: /nix/store/70v8qw138g1n8fipfwm8gk75mdri7qga-perl-5.28.2/lib/perl5/site_perl
    Size: 96        	Blocks: 0          IO Block: 4096   directory
  [...]
  ```

  If I try from bash (which is not my usual shell and which isn’t set up for Nix), the message is even more gruesome:

  ```
  bash-3.2$ ~/.nix-profile/bin/exiftool --version
  /Users/bdesham/.nix-profile/bin/exiftool: line 12: use: command not found
  /Users/bdesham/.nix-profile/bin/exiftool: line 13: require: command not found
  /Users/bdesham/.nix-profile/bin/exiftool: line 15: my: command not found
  /Users/bdesham/.nix-profile/bin/exiftool: line 18: my: command not found
  /Users/bdesham/.nix-profile/bin/exiftool: line 19: BEGIN: command not found
  /Users/bdesham/.nix-profile/bin/exiftool: line 21: syntax error near unexpected token `('
  /Users/bdesham/.nix-profile/bin/exiftool: line 21: `    $exeDir = ($0 =~ /(.*)[\\\/]/) ? $1 : '.';'
  ```

  If I roll back to version 11.49 the command works fine from zsh and from bash. Version 11.50 works fine for me on an Ubuntu 16.04.6 system.

  Fun fact: [I was the one who broke this](https://github.com/NixOS/nixpkgs/pull/62987) 😳 I had tested it successfully on a different macOS system, one running Mojave. The failing system is High Sierra (10.13.6). I will try to see if I can fix this but I thought I should report the problem ASAP.

  ### Steps to reproduce

  1. `nix-env -iA nixpkgs.perlPackages.ImageExifTool`
  2. `exiftool --help`

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 17.7.0, macOS 10.13.6`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(bdesham): `"nixpkgs-19.09pre182717.b58ada326aa"`
   - nixpkgs: `/Users/bdesham/.nix-defexpr/channels/nixpkgs`


state: closed
title: Pulseaudio no longer working
user_login: karolchmist
html_url: https://github.com/NixOS/nixpkgs/issues/63112
updated_at: 2019-06-14 07:38:59
body:
  ## Issue description

  I'm on `nixos-unstable` channel, and since I've updated to the latest version, my audio is not working. I'm using xfce4 + i3.

  The log is :

  ```
  Jun 13 16:36:19 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:36:21 hermes systemd[1054]: Started Sound Service.
  Jun 13 16:39:58 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:39:58 hermes pulseaudio[2849]: E: [pulseaudio] pid.c: Daemon already running.
  Jun 13 16:39:58 hermes pulseaudio[2849]: E: [pulseaudio] main.c: pa_pid_file_create() failed.
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:39:58 hermes systemd[1054]: Failed to start Sound Service.
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Service RestartSec=500ms expired, scheduling restart.
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Scheduled restart job, restart counter is at 1.
  Jun 13 16:39:58 hermes systemd[1054]: Stopped Sound Service.
  Jun 13 16:39:58 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:39:58 hermes pulseaudio[2859]: E: [pulseaudio] pid.c: Daemon already running.
  Jun 13 16:39:58 hermes pulseaudio[2859]: E: [pulseaudio] main.c: pa_pid_file_create() failed.
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 16:39:58 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:39:58 hermes systemd[1054]: Failed to start Sound Service.
  Jun 13 16:39:59 hermes systemd[1054]: pulseaudio.service: Service RestartSec=500ms expired, scheduling restart.
  Jun 13 16:39:59 hermes systemd[1054]: pulseaudio.service: Scheduled restart job, restart counter is at 2.
  Jun 13 16:39:59 hermes systemd[1054]: Stopped Sound Service.
  Jun 13 16:39:59 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:39:59 hermes pulseaudio[2860]: E: [pulseaudio] pid.c: Daemon already running.
  Jun 13 16:39:59 hermes pulseaudio[2860]: E: [pulseaudio] main.c: pa_pid_file_create() failed.
  Jun 13 16:39:59 hermes systemd[1054]: pulseaudio.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 16:39:59 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:39:59 hermes systemd[1054]: Failed to start Sound Service.
  Jun 13 16:40:00 hermes systemd[1054]: pulseaudio.service: Service RestartSec=500ms expired, scheduling restart.
  Jun 13 16:40:00 hermes systemd[1054]: pulseaudio.service: Scheduled restart job, restart counter is at 3.
  Jun 13 16:40:00 hermes systemd[1054]: Stopped Sound Service.
  Jun 13 16:40:00 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:40:00 hermes pulseaudio[2861]: E: [pulseaudio] pid.c: Daemon already running.
  Jun 13 16:40:00 hermes pulseaudio[2861]: E: [pulseaudio] main.c: pa_pid_file_create() failed.
  Jun 13 16:40:00 hermes systemd[1054]: pulseaudio.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 16:40:00 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:40:00 hermes systemd[1054]: Failed to start Sound Service.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Service RestartSec=500ms expired, scheduling restart.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Scheduled restart job, restart counter is at 4.
  Jun 13 16:40:01 hermes systemd[1054]: Stopped Sound Service.
  Jun 13 16:40:01 hermes systemd[1054]: Starting Sound Service...
  Jun 13 16:40:01 hermes pulseaudio[2863]: E: [pulseaudio] pid.c: Daemon already running.
  Jun 13 16:40:01 hermes pulseaudio[2863]: E: [pulseaudio] main.c: pa_pid_file_create() failed.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Main process exited, code=exited, status=1/FAILURE
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:40:01 hermes systemd[1054]: Failed to start Sound Service.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Service RestartSec=500ms expired, scheduling restart.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Scheduled restart job, restart counter is at 5.
  Jun 13 16:40:01 hermes systemd[1054]: Stopped Sound Service.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Start request repeated too quickly.
  Jun 13 16:40:01 hermes systemd[1054]: pulseaudio.service: Failed with result 'exit-code'.
  Jun 13 16:40:01 hermes systemd[1054]: Failed to start Sound Service.
  ```

  If I roll back to the previous generation, it works. Here is the content of my working generation in `/boot/loader/entries/`: 
  ```
  title NixOS
  version Generation 327 NixOS 19.09.git.1dc26c3, Linux Kernel 4.19.48, Built on 2019-06-07
  linux /efi/nixos/gs2w3h2bh8ijf64w76i28fdm1b9hll41-linux-4.19.48-bzImage.efi
  initrd /efi/nixos/i3yhhq578llzx29ka5gi6qa6hdy0q0s2-initrd-linux-4.19.48-initrd.efi
  options systemConfig=/nix/store/fdmmbpw9ddijiyc08v17gfqd08aw84ki-nixos-system-hermes-19.09.git.1dc26c3 init=/nix/store/fdmmbpw9ddijiyc08v17gfqd08aw84ki-nixos-system-hermes-19.09.git.1dc26c3/init loglevel=4
  machine-id c7a12c3b528541a288f7aadd812d94ab
  ```

  Here is the one that is not working:
  ```
  title NixOS
  version Generation 328 NixOS 19.09.git.168d103, Linux Kernel 4.19.48, Built on 2019-06-10
  linux /efi/nixos/9q7x71w8hflqal6zdp93anhx0mydqknb-linux-4.19.48-bzImage.efi
  initrd /efi/nixos/c0c78izv0g25b31brl40vngj236c2awy-initrd-linux-4.19.48-initrd.efi
  options systemConfig=/nix/store/9qpf2chnwf4p3kiw0izkhxgn3v9vh8aq-nixos-system-hermes-19.09.git.168d103 init=/nix/store/9qpf2chnwf4p3kiw0izkhxgn3v9vh8aq-nixos-system-hermes-19.09.git.168d103/init loglevel=4
  machine-id c7a12c3b528541a288f7aadd812d94ab
  ```

  I've upgraded since the to the newest git commit `98e3b90`, still the same 

  ### Steps to reproduce

  - Reboot the system based on git commit `168d103`
  - pulseaudio doesn't work
  - there is no audio whatsoever
  - the mic doesn't work


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.48, NixOS, 19.09.git.1dc26c3 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(karol): `""`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`


state: closed
title: initial vdr plugin xineliboutput-2.1.0
user_login: ck3d
html_url: https://github.com/NixOS/nixpkgs/pull/63113
updated_at: 2019-06-20 19:24:21
body:
  Needed to patch package xineLib to fix usage of XINE_PLUGIN_PATH .

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libtensorflow: 1.9.0 -> 1.13.1
user_login: kuznero
html_url: https://github.com/NixOS/nixpkgs/pull/63114
updated_at: 2019-06-16 17:45:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `libtensorflow` to latest stable version `1.13.1`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gimp: 2.10.10 → 2.10.12
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/63115
updated_at: 2019-06-14 10:07:57
body:
  ###### Motivation for this change
  Supercedes: https://github.com/NixOS/nixpkgs/pull/62356

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: opendune: support ALSA and pulseaudio (move to SDL2)
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63116
updated_at: 2019-06-14 08:52:31
body:
  ###### Motivation for this change

  Add support for ALSA and pulseaudio and move to SDL2.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Cc: @nand0p 
  ---


state: open
title: macse: init at 2.03
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/63117
updated_at: 2019-06-14 09:07:30
body:
  ###### Motivation for this change
  Bioinformatic tool used in my laboratory

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wallabag: 2.3.7 -> 2.3.8
user_login: schneefux
html_url: https://github.com/NixOS/nixpkgs/pull/63120
updated_at: 2019-06-15 11:39:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updated wallabag. Fixes a memory leak (https://github.com/wallabag/wallabag/issues/3926).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: shaarli-material: remove
user_login: schneefux
html_url: https://github.com/NixOS/nixpkgs/pull/63121
updated_at: 2019-07-04 14:29:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  shaarli-material is a theme plugin for the shaarli web application.
  The version of the theme needs to match shaarli's or else there are server errors, broken scripts and broken styling. shaarli-material is behind by almost a year, so the two versions of shaarli + shaarli-material in the nix store do not work together.
  The build process for shaarli-material has changed in 0.10.3 and now depends on npm packages and a gulp script (changelog: https://github.com/kalvn/Shaarli-Material/releases) and I do not know how to update the build recipe for it.
  I have not managed to set up a working shaarli + shaarli-material configuration with the prebuilt assets from the GitHub releases page either.

  So I'd like to drop the package because it has been unusable for a year, is too difficult to maintain and apparently not used by anyone.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flatpak: Preserve pixbuf path in validate-icon
user_login: mat8913
html_url: https://github.com/NixOS/nixpkgs/pull/63122
updated_at: 2019-06-15 10:29:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Without this, `flatpak-validate-icon` fails on SVG files and I can't build any flatpaks which have SVG icons.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I tested with:

  ```
  $ git checkout 46e1c7f17aafaab18091f8fe04c1586f4ab932af^; nix-build . -A flatpak; ./result/libexec/flatpak-validate-icon --sandbox 16 16 ~/.local/share/flatpak/exports/share/icons/hicolor/symbolic/apps/org.gnome.Boxes-symbolic.svg; echo $?
  HEAD is now at 29dc0ba6577 vimPlugins: update (#63119)
  /nix/store/5nw27q7hb34a9bd49zdpg44fc8p1kh0k-flatpak-1.2.4
  Format not recognized
  1
  $ git checkout 46e1c7f17aafaab18091f8fe04c1586f4ab932af; nix-build . -A flatpak; ./result/libexec/flatpak-validate-icon --sandbox 16 16 ~/.local/share/flatpak/exports/share/icons/hicolor/symbolic/apps/org.gnome.Boxes-symbolic.svg; echo $?
  Previous HEAD position was 29dc0ba6577 vimPlugins: update (#63119)
  HEAD is now at 46e1c7f17aa flatpak: Preserve pixbuf path in validate-icon
  /nix/store/4a8j3i5k7d0f9skxwwfknsk7czk1ndfv-flatpak-1.2.4
  0
  ```

  ---


state: closed
title: gnome3 settings doesn't open anymore
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/63123
updated_at: 2019-06-17 08:34:11
body:
  ## Issue description

  It crashes with:
  ```
  Jun 14 14:54:01 t490s .gnome-control-[32688]: Settings schema 'org.gnome.mutter.wayland.keybindings' is not installed

  ```


  ### Steps to reproduce

  Open the Keyboard settings option through the search bar.  Gnome control center won't start up.
  Any subsequent starts will also crash.



  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.39, NixOS, 19.03pre-git (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172880.49dc8087a20"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```


state: closed
title: gnome3.gnome-control-center: Add mutter to dependencies
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/63124
updated_at: 2019-06-15 14:41:52
body:
  ###### Motivation for this change
  #59765 fixed the keybndings issue #19590 only partially, we still need to make the gschemas available.

  Closes: https://github.com/NixOS/nixpkgs/issues/63123

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: hpmyroom: init at 11.0.0.0240
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63125
updated_at: 2019-06-24 15:16:36
body:
  ###### Motivation for this change
  To join a web conference instantiated by HPE's MyRoom this client can be used.
  Everything seems to work, voice chat, screen sharing. It only doesn't show my webcam but I have never used that feature or know how (apart from the "Testing" screen).
  Since I can't find a license, I classified it as nonfree and we can't build it with hydra and distribute it in the cache. 

  There is a Darwin binary but I don't know how to patchelf there or whether it works there.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcc8 should be the default compiler
user_login: tobim
html_url: https://github.com/NixOS/nixpkgs/issues/63126
updated_at: 2019-06-14 16:53:44
body:
  ## Issue description
  #53760 was merged into staging, but somehow got dropped.

  It would be helpful if the process with the `staging` and `staging-next` branches was documented better. In case it already is documented, that should be more discoverable.
  Maybe the [manual section](https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch) could be extended a little?

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: trimal: init at 1.4.1
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/63127
updated_at: 2019-06-14 16:04:07
body:
  ###### Motivation for this change
  Bioinformatic tool used into my lab

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Enabling `services.restya-board` results in type error for `phpfpm.poolConfigs`
user_login: Slabity
html_url: https://github.com/NixOS/nixpkgs/issues/63128
updated_at: 2019-06-17 15:31:12
body:
  ## Issue description
  ```
  error: The option value `services.phpfpm.poolConfigs.restya-board' in `/nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/web-apps/restya-board.nix' is not of type `strings concatenated with "\n"'.
  ```


  ### Steps to reproduce
  Set `services.restya-board.enable = true;` in a NixOS configuration.


  ## Technical details
  It looks like #56625 changed the type of `services.phpfpm.poolConfigs.restya-board` from a string to a set, which the configuration does not see as compatible.


state: closed
title: rPackages.git2r: Use system libgit2
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/pull/63129
updated_at: 2019-06-14 15:24:51
body:
  Otherwise git2r builds a bundled libgit2

  ###### Motivation for this change
  Use the system's libgit2, where a binary substitution is usually available, instead of building one from source.

  Thanks to manveru on IRC for finding that pkgconfig is also needed.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zabbix: adding zabbix proxy support
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63130
updated_at: 2019-07-16 15:48:17
body:
  ###### Motivation for this change

  Adding zabbix proxy support by creating a new zabbix proxy module along with zabbix-proxy subpackages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: thunderbird, thunderbird-bin: 60.7.0 -> 60.7.1 [High security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/63131
updated_at: 2019-06-15 17:53:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  - High security fixes
  - Other bug fix

  https://www.thunderbird.net/en-US/thunderbird/60.7.1/releasenotes/
  https://www.mozilla.org/en-US/security/advisories/mfsa2019-17/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mididings: init at 20120419
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/63133
updated_at: 2019-06-16 12:08:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  mididings is a MIDI router and processor based on Python, supporting ALSA and JACK MIDI. It is available under the GNU GPL and currently runs on Linux.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Updated proj to 6.1.0
user_login: o1lo01ol1o
html_url: https://github.com/NixOS/nixpkgs/pull/63134
updated_at: 2019-07-13 10:38:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/captive-browser: fix module
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63135
updated_at: 2019-06-15 09:37:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes the broken metrics evaluation which was caused by a `trace`
  warning in stdout which confused `jq` in `pkgs/top-level/metrics.nix`.

  Also made the `bind-device` feature optional as suggested after the
  merge.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chromium: 75.0.3770.80 -> 75.0.3770.90
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/63136
updated_at: 2019-06-18 22:42:06
body:
  ###### Motivation for this change

  Fixes CVE-2019-5842 Use-after-free in Blink

  https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop_13.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I tested chromium (stable) only where everything seems to be working.


state: closed
title: [19.03] chromium: 75.0.3770.80 -> 75.0.3770.90 (backport)
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/63137
updated_at: 2019-06-18 21:45:35
body:
  ###### Motivation for this change

  Fixes CVE-2019-5842 Use-after-free in Blink

  https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop_13.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I did not test, but problems with stable seem very unlikely.


state: closed
title: nix crashes/fails on cache update/searching with newest release of nixpkgs
user_login: zetok
html_url: https://github.com/NixOS/nixpkgs/issues/63138
updated_at: 2019-07-02 03:36:39
body:
  ## Issue description

  Not sure what the actual issue is. Running the same command can result in different outcomes, depending on (I guess) how stars align. It started happening after I've ran `nix-channel --update`.

  Output from some runs:

  ```
  $ nix search -u libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  Aborted (core dumped)
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  Segmentation fault (core dumped)
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  error: infinite recursion encountered, at /nix/store/b3nbg096np1s7wdkzxnd56z4jq9bvg3i-nixpkgs-19.09pre182571.e829aeefa35/nixpkgs/pkgs/applications/editors/emacs-modes/melpa-stable-packages.nix:21:63
  ```

  Third time's the charm!

  With that I've searched around and found https://github.com/NixOS/nix/issues/2147 . Using workaround from the linked in the issue bugzilla entry ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83754#c1 ):

  ```
  $ ulimit -s 819200
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  error: attribute 'isFunction' missing, at /nix/store/0bkw60rp78dslmvd0yf596n8bms2s326-nixpkgs/nixpkgs/lib/customisation.nix:70:47
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  Segmentation fault (core dumped)
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  Segmentation fault (core dumped)
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  Segmentation fault (core dumped)
  $ nix-env -qaP libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  error: infinite recursion encountered, at /nix/store/ipgl2f85s51gx0xfb3l03ri0krijpyxx-nixpkgs-19.09pre182717.b58ada326aa/nixpkgs/pkgs/applications/editors/emacs-modes/melpa-packages.nix:21:56
  $ nix search -u libreoffice
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
  $ echo $?
  0
  ```


  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.7-gentoo, Gentoo, noversion`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - channels(zetok): `"nixpkgs-19.09pre182717.b58ada326aa"`
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
   - nixpkgs: `/home/zetok/.nix-defexpr/channels/nixpkgs


state: closed
title: picolisp: fix help functionality
user_login: yrashk
html_url: https://github.com/NixOS/nixpkgs/pull/63139
updated_at: 2019-06-16 06:50:15
body:
  Currently, trying to use help results in something like this:

  ```
  : (help 'db)
  ========================================
  w3m: Can't exec
  =======================================
  ```

  By including `w3m` as an input, the behaviour changes to:

  ```
  : (help 'db)
  ========================================
  (db 'sym 'cls ['hook] 'any ['sym 'any ..]) -> sym | NIL
  Returns a database object of class cls, where the values for the sym arguments
  correspond to the any arguments. If a matching object cannot be found, NIL is
  returned. sym, cls and hook should specify a tree for cls or one of its
  superclasses. See also aux, collect, request, fetch, init and step.

  ========================================
  -> db
  ```

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libreoffice: fix build
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63140
updated_at: 2019-06-15 18:09:18
body:
  ###### Motivation for this change
  Fix build libreoffice after update mariadb to 10.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: znc: 1.7.2 -> 1.7.3 Security, 19.03
user_login: tokudan
html_url: https://github.com/NixOS/nixpkgs/pull/63141
updated_at: 2019-06-16 10:28:46
body:
  ###### Motivation for this change

  Cherry-pick the commit from master, due to CVE-2019-9917.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux: Enable kernel config option for raw HID devices
user_login: luaduck
html_url: https://github.com/NixOS/nixpkgs/pull/63142
updated_at: 2019-06-25 15:08:18
body:
  ###### Motivation for this change

  Uninterruptable Power Supplies (accessed via things like `apcupsd` and `apctest`) such as APC's USB models show up as HID devices, but are not explicitely _HID_ devices (and need to be communicated to in RAW). Annoyingly, this requires a non-standard build flag to be set at kernel build time to get them to work, otherwise `apcupsd` just sits and complains about an unavailable UPS.

  You also get some relevant scrollback in dmesg:
  ```
  [  890.567023] usb 1-1.1.2: new low-speed USB device number 6 using dwc2
  [  890.891728] hid-generic 0003:051D:0002.0002: device has no listeners, quitting
  ```

  ###### Things done

  Set the `USB_HIDDEV` kernel build flag to `yes`. More information on this flag: https://cateee.net/lkddb/web-lkddb/USB_HIDDEV.html

  I'm 99.9% confident that this won't have any adverse effect on any system; it's purely additive, and just exposes these devices on `/dev/usb/hiddevX`. The flag was added way back in 2.6.22 (and even earlier). Willing to be proved wrong.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: arm-embedded GCC breaks Zephyr RTOS on nRF51 (Cortex-M0)
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/issues/63143
updated_at: 2019-06-15 03:05:55
body:
  ## Issue description

  `pkgsCross.arm-embedded.buildPackages.gcc9` causes Zephyr RTOS to immediately crash on boot for all non-trivial applications. This also occurs with GCC 7, but I did most of my testing with GCC 9 for easier comparison with Arch Linux's `arm-none-eabi-gcc` package, which has GCC 9.1 and works correctly.

  I have reproduced this on the Nordic nRF51822, which has an ARM Cortex-M0 CPU. I have no other hardware available to test.

  The output of `diffoscope --tool-prefix-binutils arm-none-eabi- zephyr.nix.strip.elf zephyr.arch.strip.elf` can be seen [here](https://gist.github.com/lopsided98/e55e9b407da5bc713813c26a0875fae1).


  Most of the differences seem to be caused by different offsets (which is unexpected, but doesn't seem to be the root cause of the problem), but I did notice this:
  ```
  │  Hex dump of section '.ARM.attributes':
  │    0x00000000 412e0000 00616561 62690001 24000000 A....aeabi..$...
  │ -  0x00000010 0541524d 2076364b 00060907 4d080109 .ARM v6K....M...
  │ +  0x00000010 05436f72 7465782d 4d300006 0c074d09 .Cortex-M0....M.
  │    0x00000020 01120414 01150117 0318011a 011e04   ...............
  ```
  This makes me suspect that Nix's GCC is getting confused about the architecture and potentially generating code for the wrong CPU.

  ### Steps to reproduce

  Create a Zephyr application for the nRF51 that calls `k_sleep` in an infinite loop. Compile in a nix-shell environment as shown below. Flash the result to the device and observe that it immediately crashes with a hard fault.

  <details>
    <summary>shell.nix</summary>

  ```
  let
    pkgs = import <nixpkgs> { overlays = [ (import ../nix) ]; };
  in

  with pkgs;

  let 
    gcc = pkgsCross.arm-embedded.buildPackages.gcc9;
    binutils = pkgsCross.arm-embedded.buildPackages.binutils;
    toolchain = buildEnv {
      name = "arm-toolchain";
      paths = [ gcc binutils ];
    };
  in mkShell {
    name = "water-level-monitor-env";
    buildInputs = with python3Packages; [
      which
      git
      gcc
      binutils
      cmake
      dtc
      gperf
      west
      wheel
      breathe
      sphinx
      docutils
      sphinx_rtd_theme
      sphinxcontrib-svg2pdfconverter
      junit2html
      pyyaml
      ply
      gitlint
      pyelftools
      pyocd
      pyserial
      pykwalify
      colorama
      pillow
      intelhex
      pytest
      gcovr
    ];
    
    GNUARMEMB_TOOLCHAIN_PATH = toolchain;
  }
  ```
  </details>
  This environment is what I use for development, but it cannot be easily reproduced because many of the packages are not in upstream nixpkgs. I can publish these packages somewhere if someone wants to reproduce this environment.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.7-arch1-1-ARCH, Arch Linux, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixpkgs"`
   - nixpkgs: `/home/ben/Documents/Projects/nixpkgs`


state: closed
title: odyssey: 2019-03-12 -> 1.0rc
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63145
updated_at: 2019-06-20 03:02:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog https://github.com/yandex/odyssey/releases/tag/1.0rc

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.cmd2: 0.9.12 -> 0.9.13
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/63146
updated_at: 2019-06-19 09:27:54
body:
  Changelog: https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aarch64: misc. graphical boot fixes
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/63147
updated_at: 2019-06-24 18:53:02
body:
  ### Motivation for this change

  Two main changes

  #### 1. HDMI for Allwinner SoCs

  The `SUN8I_DE2_CCU` configuration has been enabled for the Allwinner Display Engine 2.0.

  This makes the HDMI output work for Allwinner boards I tried.

  #### 2. `availableKernelModules` for early mode setting

  This adds the required kernel modules to the initrd so they are available earlier, allowing the modesetting to happen as early as possible. It ends up, both for vc4 and de2 to be right at the tail end of stage-1, but definitely before stage-2 has mounted the filesystems.

  This means that on initial boot, it is more obvious that the board isn't hanging during boot, and the user will see the messages from the partition resizing processes, among other boot messages.

  ### Things done

  Tested on:

   * Raspberry Pi 3B
   * Pine A64-LTS
   * Orange Pi Zero Plus2 H5

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - ☑️ Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - ☑️ Tested execution of all binary files (usually in `./result/bin/`)
  - ☑️ Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: reviewdog: init at 0.9.12
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63148
updated_at: 2019-06-16 00:01:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/reviewdog/reviewdog

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/tests/prosody: update prosody tests
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63150
updated_at: 2019-06-20 08:13:14
body:
  ###### Motivation for this change
  Moved ejabberd and prosody tests to xmpp folder.
  Update prosody test to check work in local network.
  Add test prosody test with mysql database.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.SysCPU: remove broken attribute
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63151
updated_at: 2019-06-17 23:23:01
body:
  ###### Motivation for this change
  Still not back on CPAN but on metacpan.

  Proof: Metacpan is in our mirror list and https://cpan.metacpan.org/authors/id/M/MZ/MZSANFORD/Sys-CPU-0.61.tar.gz yields the same hash.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Zoneminder doesn't start mysql
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/issues/63152
updated_at: 2019-06-21 15:59:35
body:
  ## Issue description
  Zoneminder needs mysql to work at all but the service config doesn't start it.

  I would either add
  ```
    services.mysql = {
      enable = true;
      package = pkgs.mysql;
    };
  ```

  to the zoneminder service or tell people to start mysql themselves in the documentation.

  I thought something was broken because I expect a service to start all its integral dependencies.

  cc @peterhoeg @amazari 

  ### Steps to reproduce
  ```
    services.zoneminder = {
      enable = true;
      database = {
        createLocally = true;
      };
    };
  ```

  Can't connect to database as shown at https://localhost:8095.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.5, NixOS, 19.09.git.98e3b90 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/store/y337wsnm6rkkcbhhljs0asc97s79m209-source`


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63155
updated_at: 2019-06-15 13:53:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Want to use the latest vimtex version because of a new filter mechanism.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpfpm: do not run anything as root
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63156
updated_at: 2019-06-28 20:03:54
body:
  ###### Motivation for this change
  Work phpfpm in rootless mode.

  Services who use php-fpm:
  - [x] roundcube
  - [x] zoneminder
  - [x] icingaweb2
  - [x] limesurvey
  - [x] matomo
  - [x] nextcloud
  - [x] restya-board
  - [x] selfoss
  - [x] tt-rss



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Parallel building of sqlite does not necessarily build
user_login: praetorg
html_url: https://github.com/NixOS/nixpkgs/issues/63157
updated_at: 2019-07-01 15:27:14
body:
  ## Issue description

  commit 93982349c8ed4ddc88e62cb970ac6fdd331ee766 unbuildable on my machine. sqlite3.h cannot be found (race?). Zen architecture, 6c 12t. I reverted to previous commit and it built without issue.

  ### Steps to reproduce

  Build sqlite on zen architecture. I can't test whether zen+ or further works.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.0, NixOS, 19.09.git.318355d (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre180355.64248ab967d"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: bitwarden-cli 1.7.4: build failed
user_login: Kjuvi
html_url: https://github.com/NixOS/nixpkgs/issues/63158
updated_at: 2019-06-15 14:12:17
body:
  ## Issue description

  bitwarden-cli 1.7.4 don't build on unstable

  ### Steps to reproduce

  nix-env -iA nixos.bitwarden-cli

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.50, NixOS, 19.09pre182743.7815c86c104 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(kjuvi): `""`
   - channels(root): `"nixos-19.09pre182743.7815c86c104"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: oclgrind: init at 18.3.
user_login: athas
html_url: https://github.com/NixOS/nixpkgs/pull/63159
updated_at: 2019-07-14 15:03:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Oclgrind is an indispensable Valgrind-like tool for OpenCL programming.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opencv: 4.0.1 -> 4.1.0
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63160
updated_at: 2019-06-16 06:57:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/opencv/opencv/wiki/ChangeLog#version410

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.geary: add libunity
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/63161
updated_at: 2019-06-16 00:18:54
body:
  ###### Motivation for this change
  Adds unread mail counter to dash to dock:

  ![image](https://user-images.githubusercontent.com/705123/59552901-12cb8800-8f8d-11e9-8d3e-8294a85ef6f6.png)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opencv: 3.4.5 -> 3.4.6
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63162
updated_at: 2019-06-16 06:55:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/opencv/opencv/wiki/ChangeLog#version346

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doc/idris: Fix install instructions
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/63163
updated_at: 2019-06-19 15:10:33
body:
  Because of nix-env weirdness, I introduced a mistake in the docs in
  https://github.com/NixOS/nixpkgs/pull/50182, this fixes it.

  Ping @mpickering @dckc 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grsync: init at 1.2.6
user_login: kuznero
html_url: https://github.com/NixOS/nixpkgs/pull/63164
updated_at: 2019-06-18 13:27:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add GRsync (a rsync GUI).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/system/boot/initrd-openvpn: New openvpn options for initrd
user_login: Amarandus
html_url: https://github.com/NixOS/nixpkgs/pull/63165
updated_at: 2019-07-18 21:34:43
body:
  The module in this commit adds new options that allows the integration of an OpenVPN client into the initrd.

  ###### Motivation for this change

  The main motivation for this change is the ability to remotely unlock LUKS containers on hosts that are behind a restrictive firewall, but are able to connect to other hosts. Using a VPN connection allows that host to tunnel into a network that might be reachable by external devices (either by providing a public IPv4/6 address or by connecting into a private VPN).

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libelf: Add patch to prevent -Wundef warnings.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/63166
updated_at: 2019-06-24 02:00:45
body:
  The Linux kernel includes libelf headers with -Wundef and -Werror enabled, resulting in an error when the headers are found through -I as opposed to -isystem.

  Fixes https://github.com/NixOS/nixpkgs/issues/59929

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  Tested doing the things in the linked issue and confirmed the issue is gone with this patch. Note that this included a rebuild of various things including gcc.

  Note that the libelf upstream site is dead.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xastir: 2.1.0 -> 2.1.2
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/63167
updated_at: 2019-06-24 06:12:31
body:
  Version 2.1.2 is compatible with recent versions of proj (see #63134)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Python: handle circular test dependencies
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/issues/63168
updated_at: 2019-06-15 17:21:35
body:
  ## Issue description

  It's not uncommon for test tools to depend on each other in each others `checkInputs`. 

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: 64-bit wine prefix creation fails to copy 32-bit libraries due to wrapper
user_login: joakim1999
html_url: https://github.com/NixOS/nixpkgs/issues/63170
updated_at: 2019-07-15 10:40:15
body:
  Referencing issue #60260 point 5. I have encountered issues with wine due to this on several occasions. The most severe is that when you create a 64-bit wine prefix with the package wineWowPackages.full it will create a prefix with ONLY 64-bit dlls. The syswow64 folder is completely empty. This may cause alot of issues and needs to be dealt with.

  If you want to see this yourself I have made a nix-shell command that reproduces and logs only 64-bit dlls being copied and the error where wine can't be loaded as an ELF executable:
  `nix-shell -p wineWowPackages.full --run "WINEPREFIX=$HOME/.problematicwine WINEDEBUG=+wineboot,+setupapi wineboot 2>&1 | grep -e fakedlls -e ELF -A 5 -B 5"
  `

  _Originally posted by @joakim1999 in https://github.com/NixOS/nixpkgs/issues/60260#issuecomment-502386680_


state: closed
title: pythonPackages.antlr4-python2-runtime: init at 4.7.2
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63173
updated_at: 2019-06-15 19:05:02
body:
  ###### Motivation for this change
  Breaking apart #62746 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/1914j8xz98m1fh0zbhck6hc3hc7qx5xf-python2.7-antlr4-python2-runtime-4.7.2        95.4M


state: closed
title: pythonPackages.pydocumentdb: init at 2.3.3
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63175
updated_at: 2019-07-09 07:10:02
body:
  ###### Motivation for this change
  Dependency for a few other packages i would like to upload here.

  This package is now continued on as `azure-cosmos`. `pydocumentdb` is meant to be the package before they moved to a `azure.cosmos` namespace. 

  This package should never need a bump.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/ydn3ibyky880424imcq818lvff6y083j-python3.7-pydocumentdb-2.3.3         106.0M


state: closed
title: pythonPackages.azure-cosmos: init at 3.1.0
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63176
updated_at: 2019-07-09 07:09:56
body:
  ###### Motivation for this change
  follow up to #63175

  This is the currently maintained version of pydocumentdb. 

  not related to #60435 separate repo, just similar name.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/2j40nsvfj0ppx35k5lk9mifi4br0lh81-python3.6-azure-cosmos-3.1.0         104.7M


state: closed
title: treewide: remove unused variables
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/63177
updated_at: 2019-06-17 08:08:59
body:
  Rerun the bot which did https://github.com/NixOS/nixpkgs/pull/43857
  It should have no effect besides the cleanup


state: closed
title: qemu: CVE-2019-12155
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63178
updated_at: 2019-06-16 07:19:46
body:
  ###### Motivation for this change

  Fixes #63070.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome-mpv: 0.13 -> 0.16
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/63179
updated_at: 2019-06-16 10:52:45
body:
  ###### Motivation for this change

  Updating to newest version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gthumb: 3.6.2 -> 3.8.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63180
updated_at: 2019-06-16 10:46:52
body:
  * enable clutter-gtk support
    Upstream defaults to it so we probably should as well.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes build with exiv2 0.27.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bmake: init at 20121212
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/63181
updated_at: 2019-06-16 19:30:29
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS


state: open
title: qemu unexpectedly closed
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/issues/63182
updated_at: 2019-06-16 04:53:45
body:
  ## Issue description

  I have a server with several guest VMs. Upon using latest unstable, none of them are able to start anymore.

  ### Steps to reproduce

  ```
  root@h-b:~# virsh start mail
  error: Failed to start domain mail
  error: internal error: qemu unexpectedly closed the monitor: 2019-06-16 04:50:50.126+0000: Domain id=2 is tainted: high-privileges
  2019-06-16T04:50:53.160896Z qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10 read: 21 device: 1 cmask: ff wmask: c0 w1cmask:0
  2019-06-16T04:50:53.160908Z qemu-system-x86_64: Failed to load PCIDevice:config
  2019-06-16T04:50:53.160912Z qemu-system-x86_64: Failed to load virtio-balloon:virtio
  2019-06-16T04:50:53.160914Z qemu-system-x86_64: error while loading state for instance 0x0 of device '0000:00:08.0/virtio-balloon'
  2019-06-16T04:50:53.161065Z qemu-system-x86_64: load of migration failed: Invalid argument
  ```

  However, using 2019-06-07 - 19.09pre181346.b3dd39ca0e9 still works fine.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.50, NixOS, 19.09pre182743.7815c86c104 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre182743.7815c86c104"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Could an interrupted nixos-rebuild fail to release locks, preventing future rebuilds?
user_login: 8573
html_url: https://github.com/NixOS/nixpkgs/issues/63183
updated_at: 2019-06-16 16:00:26
body:
  ## Issue description

  I ran `nixos-rebuild switch --upgrade` and it seemingly hung for hours at "created 16760 symlinks in user environment", late in the rebuild process, until I interrupted it with Control-C. I then tried to run it again, and it hung much earlier in the process, with the message "waiting for locks or build slots...", just after printing a list of the derivations that would be built. I interrupted and re-ran it again, and I get the same result: seemingly hanging at "waiting for locks or build slots...".

  Is it plausible that my interrupting the first invocation of `nixos-rebuild` caused it to exit without releasing necessary locks, thereby preventing future rebuilds from succeeding? If so, how could I fix the locks in question so that I can rebuild?

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.33-hardened, NixOS, 19.09pre182256.168d1031af4 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre182743.7815c86c104"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.vsts: init at 0.1.25
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63184
updated_at: 2019-07-15 19:12:10
body:
  ###### Motivation for this change
  Another dependency for for the `azure-cli` package.

  This is the final version for the `vsts` package as it has been rebranded to `azure-devops` for future development.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/njn49gjkdi0c18x48bd9qnfq22rs755i-python3.6-vsts-0.1.25        125.7M

  It is a big boi


state: closed
title: theft: 0.4.4 -> 0.4.5, fix pkg-config file
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/63186
updated_at: 2019-06-16 16:45:50
body:
  The libtheft.pc file was using prefix=/usr/local for its own relative
  -L/-l/-I parameters for GCC, giving incorrect results. (This is really
  more of an upstream bug.)

  This also adds myself to the maintainer list, and enables builds on
  non-Linux platforms.

  Signed-off-by: Austin Seipp <as@fastly.com>

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.azure-devops: init at 5.0.0b8
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63187
updated_at: 2019-06-16 08:38:57
body:
  ###### Motivation for this change
  Follow up to #63184

  This is the "new" azure-devops package after vsts was rebranded to azure-devops.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh ./result
  /nix/store/j2xpynp8kxi476vk0rz0q89sqa1cn9wm-python3.6-azure-devops-5.0.0b8       126.1M


state: closed
title: qemu: CVE-2019-12155
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63188
updated_at: 2019-06-16 07:43:01
body:
  (cherry picked from commit a4e6261173a18d9e0cb2f02b73fb7fbae91ecaaf)

  ###### Motivation for this change

  Fixes #63178.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zziplib: CVE-2018-17828
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63189
updated_at: 2019-06-16 11:47:41
body:
  ###### Motivation for this change

  Fixes #61961.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


