# issues

state: open
title: pythonPackages.z3c_checkversions: init at 1.1
user_login: talkara
html_url: https://github.com/NixOS/nixpkgs/pull/63514
updated_at: 2019-06-20 07:07:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nheko: 0.6.3 -> 0.6.4, mtxclient: 0.2.0 -> 0.2.1
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/63515
updated_at: 2019-06-19 17:55:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update package nheko

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` (Non depend on it)
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  #### Other information

  - Updated the URL of mtxclient to use the `Nheko-Reborn` GitHub namspace.
  - Made both nheko and mtxclient aware of nlohmann_json with `-Dnlohmann_json_DIR` in `cmakeFlags`.


state: closed
title: CVE-2019-11707: Firefox Type confusion in Array.pop
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/issues/63519
updated_at: 2019-06-19 12:55:02
body:
  Firefox needs updating to 67.0.3 to fix this flaw:

  > A type confusion vulnerability can occur when manipulating JavaScript objects due to issues in Array.pop. This can allow for an exploitable crash. We are aware of targeted attacks in the wild abusing this flaw.

  https://www.mozilla.org/en-US/security/advisories/mfsa2019-18/


state: closed
title: setup.sh: add dontConfigure
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63520
updated_at: 2019-07-03 00:05:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  People have been using `dontConfigure` in expressions expecting that it would disable the `configurePhase`.
  Let's make this actually do something.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-graph: init at 0.2.0-d895af1
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63521
updated_at: 2019-06-20 07:25:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [`cargo-graph`](https://github.com/kbknapp/cargo-graph) is a handy tool to have around to visualize Cargo dependency graphs.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luarocks: 3.0.4 -> 3.1.3
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/63523
updated_at: 2019-06-20 05:15:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`- I ran this command but I don't think all Lua packages were rebuild so I'm not sure about this one.
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Also: Updated `darwin.patch` for new version of the patched file.

  ---


state: closed
title: rclone: 1.47.0 -> 1.48.0
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/63524
updated_at: 2019-06-20 01:32:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - non depend.
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sourcetrail: 2019.1.11 -> 2019.2.39
user_login: midchildan
html_url: https://github.com/NixOS/nixpkgs/pull/63525
updated_at: 2019-07-20 12:13:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  - update to newer version
  - enable python indexing

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: eksctl: 0.1.35 -> 0.1.38
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63526
updated_at: 2019-06-22 05:28:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `eksctl` to the latest release.
  https://github.com/weaveworks/eksctl/releases/tag/0.1.38
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: tor-browser: remove --no-remote option
user_login: KaiHa
html_url: https://github.com/NixOS/nixpkgs/pull/63527
updated_at: 2019-06-21 06:15:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The `-no-remote` option prevents opening new tabs in an running
  tor-browser session. E.g. executing `tor-browser https://example.com`
  from the command line always starts a new session regardless of a
  running instance

  Please note, I have no clue what the original reason was to add the
  option `-no-remote`. Maybe this has severe security implications, I
  simply don't know.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Get qt512.x86_64-darwin (and qt513.x86_64-darwin)
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/63528
updated_at: 2019-06-24 00:44:36
body:
  ## Issue description

  We are currently stuck on qt 5.11 on darwin/macOS. To get things consistent, this should update to qt 5.12 (or even 5.13) soon.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: vagrant: Don't patch salt provisioner's shebang
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/63529
updated_at: 2019-07-01 23:22:03
body:
  The script is intended to run on remote systems, not on the local
  system. The shebang **has** to work where nix and the current store does
  not exist.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - ☑️ Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - ☑️ Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.hakyll-images: unmark as broken
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/63530
updated_at: 2019-07-10 08:07:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Builds and works fine now

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.ndg-httpsclient: 0.4.2 -> 0.5.1
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63531
updated_at: 2019-07-09 07:05:43
body:
  ###### Motivation for this change
  Noticed it was out of date.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  ```
  $ nix-shell -p nix-review --command "nix-review wip"
  ...
  [13 built, 110 copied (141.7 MiB), 37.8 MiB DL]
  19 package were build:
  beets certbot mopidy-gmusic python27Packages.Quandl python27Packages.acme python27Packages.github3_py python27Packages.gmusicapi python27Packages.gpsoauth python27Packages.lektor python27Packages.ndg-httpsclient python37Packages.acme python37Packages.github3_py python37Packages.gmusicapi python37Packages.gplaycli python37Packages.gpsoauth python37Packages.lektor python37Packages.ndg-httpsclient searx simp_le
  ```

  $ nix path-info -Sh /nix/store/688plz0xwdwwmb8srfwkbyy3q68sis32-python2.7-ndg-httpsclient-0.4.2
  /nix/store/688plz0xwdwwmb8srfwkbyy3q68sis32-python2.7-ndg-httpsclient-0.4.2      102.7M

  $ nix path-info -Sh ./result
  /nix/store/7iwm6rmvzdygwpj4hsar6x14w813xrxm-python2.7-ndg-httpsclient-0.5.1      102.7M


state: closed
title: bazel: 0.26.1 -> 0.27.0
user_login: guibou
html_url: https://github.com/NixOS/nixpkgs/pull/63532
updated_at: 2019-06-24 20:28:41
body:
  - Upgrade to bazel 0.27
  - Fixs for newly introduced bin/bash hardcoded reference
  - Bazel now references `remote_java_tools_xxx` which contains prebuilt
    binaries. We prefetch them, fix them, and force bazel to use the
    fixed repository.

  It also closes #63096

  ###### Motivation for this change

  Bazel upgrade and bug fixing.

  Note: instead of fixing #63096 and upgrading to bazel in two separates commits, I've done everything in once. I think it reduce the pull request pressure.

  There is no test which proves that I really fixed stuffs, but I'm now able to build rules_haskell with bazel 0.27, which was not possible due to #63096. See https://github.com/tweag/rules_haskell/issues/956

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Breakage due to systemd 242 parsing of \ in ExecStart= & other options
user_login: Pneumaticat
html_url: https://github.com/NixOS/nixpkgs/issues/63533
updated_at: 2019-07-10 15:09:18
body:
  ## Issue description

  It appears that since #61321, which upgraded systemd, systemd has a backwards-incompatible form of option parsing where trailing `\`s now escape empty lines *up until* the next line with text on it. This means that in a unit file like so:

  ```
  [Unit]
  After=kubelet-online.service
  Before=kube-node-online.target
  ConditionPathExists=/var/lib/kubernetes/secrets/ca.pem
  ConditionPathExists=/var/lib/kubernetes/secrets/kube-proxy-client.pem
  ConditionPathExists=/var/lib/kubernetes/secrets/kube-proxy-client-key.pem
  Description=Kubernetes Proxy Service

  [Service]
  Environment="KUBECONFIG=/nix/store/xai0d9pw3wfy6fk66slf5x8pqild428z-kube-proxy-kubeconfig"
  Environment="LOCALE_ARCHIVE=/nix/store/fnr9mys8l5224sqc7vgisgb66s5429f4-glibc-locales-2.27/lib/locale/locale-archive"
  Environment="PATH=/nix/store/bw5a40lav31rqhvjc058izbkidn8xgcc-iptables-1.8.3/bin:/nix/store/kli9f92sdhhmvkgshzjlq2l3q52mh5q5-conntrack-tools-1.4.5/bin:/nix/store/k49nnjscfzgyrhbyfhf3pv2dmqiwi22w-kubectl-1.14.3/bin:/nix/store/i4r7xx7sj1bjgvj9p6dv59f1mb329ivw-coreutils-8.31/bin:/nix/store/dbbvnc30cjg8hdy77b2xhvsbwjkn3b8q-findutils-4.6.0/bin:/nix/store/22zkpn538ji8b3382syvs1kd3c34909v-gnugrep-3.3/bin:/nix/store/87wqi5b61fb90kgz95vbiwhdymfnw8q7-gnused-4.7/bin:/nix/store/izi6x20cncdvx742il1f38rycyk8b4wr-systemd-242/bin:/nix/store/bw5a40lav31rqhvjc058izbkidn8xgcc-iptables-1.8.3/sbin:/nix/store/kli9f92sdhhmvkgshzjlq2l3q52mh5q5-conntrack-tools-1.4.5/sbin:/nix/store/k49nnjscfzgyrhbyfhf3pv2dmqiwi22w-kubectl-1.14.3/sbin:/nix/store/i4r7xx7sj1bjgvj9p6dv59f1mb329ivw-coreutils-8.31/sbin:/nix/store/dbbvnc30cjg8hdy77b2xhvsbwjkn3b8q-findutils-4.6.0/sbin:/nix/store/22zkpn538ji8b3382syvs1kd3c34909v-gnugrep-3.3/sbin:/nix/store/87wqi5b61fb90kgz95vbiwhdymfnw8q7-gnused-4.7/sbin:/nix/store/izi6x20cncdvx742il1f38rycyk8b4wr-systemd-242/sbin"
  Environment="TZDIR=/nix/store/9lyxln5y04lj5vg7npzvid0f8ampva1s-tzdata-2019a/share/zoneinfo"



  ExecStart=/nix/store/gpx46s19nh708bqbia98iw4jcnlqhkbi-kubernetes-1.14.3/bin/kube-proxy \
            --bind-address=0.0.0.0 \
            --cluster-cidr=10.1.0.0/16 \
             \
            --kubeconfig=/nix/store/xai0d9pw3wfy6fk66slf5x8pqild428z-kube-proxy-kubeconfig \
             \
            

  ExecStartPre=/nix/store/vbpbg0ry6ingf4s8iyg9y8skil9pnbjv-unit-script-kube-proxy-pre-start
  Restart=on-failure
  RestartSec=5
  Slice=kubernetes.slice
  WorkingDirectory=/var/lib/kubernetes
  ```

  The `ExecStartPre=...` line is *included* as part of the `ExecStart=` line. Since kube-proxy does not expect any arguments, this means that kube-proxy fails to start and enters a crash loop.

  I see that #63197 has already been made to address this for Kubernetes (although it's incomplete, as I had this issue with `kube-proxy` in this case).

  I also had the issue with `earlyoom`, since [the optional lines](https://github.com/NixOS/nixpkgs/blob/9a14ef6f4b329186dd56056a7c5dfc5de9f2df57/nixos/modules/services/system/earlyoom.nix#L102) mean that it can end up having a trailing \\. It is likely that other services may also be affected (silently so, if they do not crash).

  ### Steps to reproduce

  Attempt to use either `earlyoom` or `kube-proxy`, in this case.

  ## Technical details

  - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09.git.f8731a7 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(kevin): `"nixpkgs-19.03pre167327.11cf7d6e1ff"`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`


state: closed
title: pythonPackages.redis-py: init at 3.1.0
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/pull/63534
updated_at: 2019-06-19 20:49:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Required for a project.
  This is a nearly identical copy of `pythonPackages.redis` which uses a different module name "redis-py". There seems to have been disagreement among users of the module, some of whom believed that the name "redis" did not properly distinguish itself from the actual application "redis". In any case other modules that I required need the module to use "redis-py" as it's name.

  ###### Things done

  A copy of 'pythonPackages.redis' was made and renamed. The proper license was also added.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Using Virtualbox 6 (unstable) in 19.03
user_login: fdietze
html_url: https://github.com/NixOS/nixpkgs/issues/63535
updated_at: 2019-06-20 18:00:28
body:
  My goal is to get `VirtualBox 6` in nixos `19.03`.

  I have this in my `configuration.nix`:

  ```nix
  { config, pkgs, lib, ... }:
  let
    unstable = import <nixpkgs-unstable> {};
  in
  {
    boot.kernelPackages = pkgs.linuxPackages_5_1;

    virtualisation.virtualbox = {
      host.enable = true;
      host.enableExtensionPack = true;
      host.package = unstable.virtualbox;
    };
  }
  ```

  my channels:
  ```bash
  $ sudo nix-channel --list
  nixos https://nixos.org/channels/nixos-19.03
  nixos-hardware https://github.com/NixOS/nixos-hardware/archive/master.tar.gz
  nixpkgs-unstable https://nixos.org/channels/nixpkgs-unstable
  ```

  But it fails when doing `nixos-rebuild switch`:

  ```bash
  $ sudo nixos-rebuild switch --upgrade
  unpacking channels...
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/ygv9b01jw63bzz4j9pgrspqwv0gjxpcf-system-path.drv
    /nix/store/4hmv17c02kk6p3npc17gwx854vbhh0f7-dbus-1.drv
    /nix/store/61dw82dljkrryq5mcz73d7xcxjy69jnj-unit-accounts-daemon.service.drv
    /nix/store/6731kggilb9apzw7g20wwyp00p54k0ji-virtualbox-modules-6.0.8-5.1.11.drv
    /nix/store/7h47aimcf1xj6xnajzxl7qablpifd3q4-unit-systemd-fsck-.service.drv
    /nix/store/shqn9sk6qwsfqr1q3fkzqsc0n1zanng4-kernel-modules.drv
    /nix/store/7i5cns5w6lbz1d946bf3gzs4qs0hqczx-kernel-modules-shrunk.drv
    /nix/store/cna6kfb0szdb4agrlf8k6igiwmnbar7p-unit-dbus.service.drv
    /nix/store/8cdbzw4lh1bcvxhyvr9ihnggj7ykqlwg-user-units.drv
    /nix/store/a7155g8rqx2zwc9kv9dws97g5qlwv6dw-stage-1-init.sh.drv
    /nix/store/g7pyrcm2x70k4sks2wydjj8ci9w9k02j-unit-dbus.service.drv
    /nix/store/ms623zlf9n0dw9ddlfh1qvpc3qmyz6gy-initrd.drv
    /nix/store/khmkaxslw328l4h53pcn3730r2y231rx-unit-polkit.service.drv
    /nix/store/xc95agpgzp19rhafjaf27gjzmhgrjhvy-system-units.drv
    /nix/store/nmdc7p7j0hpasp82mikvnbyqdsxh1a9a-etc.drv
    /nix/store/ig2g107q3ywss08pxm6aq524g1rw7cak-nixos-system-gurke-19.03.172921.d77e3bd6613.drv
  building '/nix/store/ygv9b01jw63bzz4j9pgrspqwv0gjxpcf-system-path.drv'...
  building '/nix/store/6731kggilb9apzw7g20wwyp00p54k0ji-virtualbox-modules-6.0.8-5.1.11.drv'...
  unpacking sources
  unpacking source archive /nix/store/g6r9qn2x0kjjhrz4j8wkc8l2crrh46gx-virtualbox-6.0.8-modsrc
  source root is virtualbox-6.0.8-modsrc
  patching sources
  applying patch /nix/store/r3liap9h7si2hw8rl5ziqd34076m5hgy-fix_kerndir.patch
  can't find file to patch at input line 5
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/vboxdrv/Makefile.include.header b/vboxdrv/Makefile.include.header
  |index 8df1eb4d25..5a3e5604e7 100644
  |--- a/vboxdrv/Makefile.include.header
  |+++ b/vboxdrv/Makefile.include.header
  --------------------------
  File to patch:
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  can't find file to patch at input line 17
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/vboxnetadp/Makefile.include.header b/vboxnetadp/Makefile.include.header
  |index 8df1eb4d25..5a3e5604e7 100644
  |--- a/vboxnetadp/Makefile.include.header
  |+++ b/vboxnetadp/Makefile.include.header
  --------------------------
  File to patch:
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  can't find file to patch at input line 29
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/vboxnetflt/Makefile.include.header b/vboxnetflt/Makefile.include.header
  |index 8df1eb4d25..5a3e5604e7 100644
  |--- a/vboxnetflt/Makefile.include.header
  |+++ b/vboxnetflt/Makefile.include.header
  --------------------------
  File to patch:
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  can't find file to patch at input line 41
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |diff --git a/vboxpci/Makefile.include.header b/vboxpci/Makefile.include.header
  |index 8df1eb4d25..5a3e5604e7 100644
  |--- a/vboxpci/Makefile.include.header
  |+++ b/vboxpci/Makefile.include.header
  --------------------------
  File to patch:
  Skip this patch? [y]
  Skipping patch.
  1 out of 1 hunk ignored
  builder for '/nix/store/6731kggilb9apzw7g20wwyp00p54k0ji-virtualbox-modules-6.0.8-5.1.11.drv' failed with exit code 1
  cannot build derivation '/nix/store/shqn9sk6qwsfqr1q3fkzqsc0n1zanng4-kernel-modules.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/ig2g107q3ywss08pxm6aq524g1rw7cak-nixos-system-gurke-19.03.172921.d77e3bd6613.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/ig2g107q3ywss08pxm6aq524g1rw7cak-nixos-system-gurke-19.03.172921.d77e3bd6613.drv' failed
  ```

  What could be wrong?

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.03.172921.d77e3bd6613 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(felix): `"nixpkgs-19.09pre182971.a1dd419c1ff"`
   - channels(root): `"nixos-19.03.172921.d77e3bd6613, nixos-hardware, nixpkgs-unstable-19.09pre182717.b58ada326aa"`
   - nixpkgs: `/home/felix/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: mate.marco: 1.22.1 -> 1.22.2; mate.mate-themes: 3.22.19 -> 3.22.20
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63536
updated_at: 2019-06-22 14:08:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  mate.marco: 1.22.1 -> [1.22.2](https://github.com/mate-desktop/marco/releases/tag/v1.22.2)
  mate.mate-themes: 3.22.19 -> [3.22.20](https://github.com/mate-desktop/mate-themes/releases/tag/v3.22.20)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: pythonPackages.channels_redis: init at 2.4.0
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/pull/63537
updated_at: 2019-06-19 23:41:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Required for project.

  ###### Things done

  Added "Channels Redis" python module.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.google-appengine: init at 1.5.1
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/pull/63538
updated_at: 2019-06-19 21:36:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Required for a project.

  ###### Things done

  Added "Google App Engine" python module.
  Note that this depends on another of my open PRs which adds `ez_setup` python module.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: usbguard-nox: init at 0.7.4
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/63539
updated_at: 2019-06-22 18:44:10
body:
  ###### Motivation for this change

  I wanted to use usbguard on a server that doesn't need Qt.

  This adds usbguard-nox, which is just usbguard without the Qt GUI that brings in Qt dependencies.

  Also add an option to the module to select which package to use.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I confirmed that `usbguard` and `usbguard-nox` build, and that the service works with both `usbguard` and `usbguard-nox`.

  cc maintainer @tnias 


state: closed
title: nixos/prometheus-node-exporter: fix systemd unit for systemd 242
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/63540
updated_at: 2019-06-25 22:40:26
body:
  ###### Motivation for this change

  Fix #63383

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I confirmed that the service starts now.

  cc maintainers @benley @fpletz


state: open
title: NixOS config option to disable networking entirely
user_login: jameysharp
html_url: https://github.com/NixOS/nixpkgs/pull/63541
updated_at: 2019-07-18 08:33:05
body:
  ###### Motivation for this change

  I've had some success at building single-purpose read-only root filesystem images by heavily customizing NixOS configuration options and package overrides. (I'd like to see NixOS supplant Yocto :smiling_imp:)

  But one of the things I couldn't disable was support for networking. I could turn off most individual services, like a DHCP client, but there was still some core stuff wasting space and boot time in my images. Most NixOS users will leave networking enabled, but for specialized applications it's really helpful to just turn it off entirely.

  ###### Things done

  Even after reading [the manual](https://nixos.org/nixos/manual/index.html#sec-running-nixos-tests-interactively) I don't understand how to run the tests. I ran:

  ```
  nix-build tests/networking.nix --arg networkd true
  ```

  I don't know what it would look like if it failed, but I got 12 `result*` symlinks at the end, and spot-checking logs looks okay I guess?

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.msrestazure: 0.6.0 -> 0.6.1
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63542
updated_at: 2019-07-09 07:05:31
body:
  ###### Motivation for this change
  Noticed it was out of date

  Added myself as a maintainer because my day job is working on AzureML now, so I have a reason to keep this up to date. (This package is fundamental to `azure-sdk` and `azure-cli`)

  Both packages now run tests. (msrestazure was just collecting `0 tests` before)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  ```
  $ nix-shell -p nix-review --command "nix-review wip"
  ...
  [17 built, 0.0 MiB DL]
  15 package were build:
  nixops_1_6_1 python27Packages.azure-mgmt-common python27Packages.azure-mgmt-compute python27Packages.azure-mgmt-network python27Packages.azure-mgmt-resource python27Packages.azure-mgmt-storage python27Packages.msrest python27Packages.msrestazure python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-network python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-storage python37Packages.msrest python37Packages.msrestazure
  ```

  ```
  $ nix path-info -Sh ./result
  /nix/store/xxk7gbny0dh67av8lv3hc6jrh41kngrl-python3.7-msrest-0.6.7       113.1M
  ```
  ```
  $ nix path-info -Sh ./result
  /nix/store/bnczfr25ysqibway86qj6v8gdpf0yx46-python3.6-msrestazure-0.6.1  113.3M
  ```


state: open
title: fastlane: 2.107.0 -> 2.127.1
user_login: nicknovitski
html_url: https://github.com/NixOS/nixpkgs/pull/63543
updated_at: 2019-07-15 18:04:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - ~[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))~
  - ~[ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`~
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Kubernetes: syntax error near unexpected token `done'
user_login: ebonetti
html_url: https://github.com/NixOS/nixpkgs/issues/63544
updated_at: 2019-06-25 16:50:28
body:
  ## Issue description
  Experimenting with kubernetes with master and node on localhost: kubernetes roles are well defined, still `nixos-rebuild switch --upgrade` fails:

  ```
  warning: the following units failed: kube-control-plane-online.service

  ● kube-control-plane-online.service - Kubernetes control plane is online
     Loaded: loaded (/nix/store/ab32b9pq98p733chdlmgrxg6lx2mldp5-unit-kube-control-plane-online.service/kube-control-plane-online.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Thu 2019-06-20 01:04:58 CEST; 1s ago
    Process: 4147 ExecStartPre=/nix/store/wdnlnknjn74rlydq4h0268084pyvm8bz-unit-script-kube-control-plane-online-pre-start (code=exited, status=2)

  Jun 20 01:04:58 nixos systemd[1]: Starting Kubernetes control plane is online...
  Jun 20 01:04:58 nixos wdnlnknjn74rlydq4h0268084pyvm8bz-unit-script-kube-control-plane-online-pre-start[4147]: /nix/store/wdnlnknjn74rlydq4h0268084pyvm8bz-unit-script-kube-control-plane-online-pre-start: line 5: syntax error near unexpected token `done'
  Jun 20 01:04:58 nixos systemd[1]: kube-control-plane-online.service: Control process exited, code=exited, status=2/INVALIDARGUMENT
  Jun 20 01:04:58 nixos systemd[1]: kube-control-plane-online.service: Failed with result 'exit-code'.
  Jun 20 01:04:58 nixos systemd[1]: Failed to start Kubernetes control plane is online.
  warning: error(s) occurred while switching to the new configuration
  ```


  ### Steps to reproduce

  ```
    services.kubernetes = {
     roles = ["master" "node"];
     addons.dashboard.enable = true;
     masterAddress = "localhost";
    };
  ```

  ## Technical details

  ```
  sudo nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.52, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96"`
   - channels(ebonetti): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  Thanks for this great OS, keep up the great work :)
  Enrico Bonetti Vieno


state: open
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/pull/63545
updated_at: 2019-07-12 20:46:27
title:
  pythonPackages.{hiredis,aioredis,channels_redis,django-crispy-forms,django-filter}: init; Added baddecisionsalex to maintainers.

body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Required packages for a project at work.

  ###### Things done

  * adding BadDecisionsAlex to maintainer's list.
  * pythonPackages.django-filter: init at 2.1.0
  * pythonPackages.django-crispy-forms: init at 1.7.2
  * pythonPackages.channels_redis: init at 2.4.0
  * pythonPackages.aioredis: init at 1.2.0
  * pythonPackages.hiredis: init at 1.0.0

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: darwin.adv_cmds.x86_64-darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/63546
updated_at: 2019-06-21 14:18:20
body:
  ## Issue description

  This was broken recently:

  https://hydra.nixos.org/job/nixpkgs/trunk/darwin.adv_cmds.x86_64-darwin

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: luaPackages.luadbi-mysql: Fix linking issue
user_login: Shados
html_url: https://github.com/NixOS/nixpkgs/pull/63547
updated_at: 2019-06-20 19:28:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes [an issue](https://github.com/NixOS/nixpkgs/pull/63108#issuecomment-503667274) in the wake of #63108 being merged.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.imgaug: mark as broken
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63548
updated_at: 2019-07-09 07:05:25
body:
  ###### Motivation for this change
  I was trying to fix this build, then gave up when i saw what it would take to implement `opencv-python` bindings. [take a look if you are curious/crazy](https://github.com/skvark/opencv-python/blob/master/setup.py)

  Felt like just marking it as broken was the more correct thing to do than leaving it a false-positive.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sensu-go: 5.9.0 -> 5.10.0
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/63549
updated_at: 2019-06-21 02:26:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitkraken: 5.0.4 -> 6.0.0
user_login: evanjs
html_url: https://github.com/NixOS/nixpkgs/pull/63550
updated_at: 2019-07-19 01:46:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  - A new major release for GitKraken is now available

  ###### Things done
  - Bump GitKraken to 6.0.0
  - Add new dependency on libuuid (libuuid.so.1) 
  - Add new dependency on at_spi2_atk (libatk-bridge-2.0.so.0)

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Closure size is slightly larger now
  ```
  $ nix path-info -S /nix/store/b566xa8w0apraw2v826jd6c9sv3h2kxi-gitkraken-5.0.4
  /nix/store/b566xa8w0apraw2v826jd6c9sv3h2kxi-gitkraken-5.0.4       706752728

  $ nix path-info -S /nix/store/56j0aq1wqf86sv21jr4xhmsxrr1wha8a-gitkraken-6.0.0
  /nix/store/56j0aq1wqf86sv21jr4xhmsxrr1wha8a-gitkraken-6.0.0       929702928
  ```


state: closed
title: roon-server: init at 100600401
user_login: Steell
html_url: https://github.com/NixOS/nixpkgs/pull/63551
updated_at: 2019-07-02 02:06:33
body:
  ###### Motivation for this change
  I use this to organize and listen to my music. Also, I haven't seen much movement on PR #51308, so this addresses the comments left there.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pdfcpu: init at 0.1.25
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/63552
updated_at: 2019-06-21 07:03:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - non depend upon it.
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: lib/modules: add mkUnset, mkOverrideUnset
user_login: rhendric
html_url: https://github.com/NixOS/nixpkgs/pull/63553
updated_at: 2019-07-17 08:13:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Using only `mkForce`/`mkOverride`, a module or configuration has no way
  of removing an attribute specified elsewhere; the best you could do is
  to replace that attribute with a null, empty set, or similar. This may
  result in undesired behavior, if a module implementation takes some
  action for every attribute in a set, for example.

  `mkOverrideUnset` is a function intended to be used like `mkOverride`: a
  `config.some.attribute.path = lib.mkOverrideUnset p` means that, if `p`
  is the winning priority among all definitions of `some.attribute.path`,
  then `some.attribute.path` will not exist at all in the final
  configuration values.

  `mkUnset` is a shorthand for `mkOverrideUnset 50`, analogous to
  `mkForce`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: keybase: add git-remote-keybase to build
user_login: jacobgreenleaf
html_url: https://github.com/NixOS/nixpkgs/pull/63554
updated_at: 2019-07-07 18:00:27
body:
  ###### Motivation for this change

  The base package of `keybase` provides just the `keybase` binary. Keybase also provides a [git remote helper](https://git-scm.com/docs/git-remote-helpers) binary under [`go/kbfs/kbfsgit/git-remote-keybase`](https://github.com/keybase/client/tree/master/go/kbfs/kbfsgit/git-remote-keybase) that allows users to clone encrypted repositories using the `keybase://...` scheme. 

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```
  $ nix-build -A keybase
  $ /nix/store/wzbhqizqizn6riink0nk6brlhfiys92z-keybase-4.0.0-bin/bin/git-remote-keybase
  Usage:
    git-remote-keybase -version

  To run against remote KBFS servers:
    git-remote-keybase     [-debug]
      [-bserver=host:port] [-mdserver=host:port]
      [-log-to-file] [-log-file=path/to/file] [-clean-bcache-cap=0] <remote> [keybase://<repo>]
  [...snip...]
  $ nix-env -f . -iA keybase
  installing 'keybase-4.0.0'
  building '/nix/store/bx1bwr3qb4fqvpbk3kmz7w0sx0hk4a6i-user-environment.drv'...
  created 5 symlinks in user environment
  $ git clone keybase://team/[snip]
  Cloning into 'gatewayV2'...
  Initializing Keybase... done.
  Syncing with Keybase... done.
  Counting: 1.79 MB... done.
  Cryptographic cloning: (100.00%) 1.79/1.79 MB... done.


state: closed
title: Backport "cargo-graph: init at 0.2.0-d895af1" to 19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63556
updated_at: 2019-06-21 08:41:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport https://github.com/NixOS/nixpkgs/pull/63521 to 19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libssh2: 1.8.2 -> 1.9.0
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63557
updated_at: 2019-07-03 07:59:22
body:
  ###### Motivation for this change
  Update libssh2 to 1.9.0
  Changelog - https://www.libssh2.org/changes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Set taffybar version for now
user_login: IvanMalison
html_url: https://github.com/NixOS/nixpkgs/pull/63558
updated_at: 2019-06-20 09:10:24
body:
  Fixes #63500

  I wasn't really sure how to test this since I think something needs to get executed to regenerate hackage-packages. @peti help?


state: closed
title: sage: fix threejs r105
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63560
updated_at: 2019-06-20 12:55:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/issues/62736#issuecomment-503757429

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sage: fix threejs r105 [19.03]
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63561
updated_at: 2019-06-20 12:55:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of bugfix in https://github.com/NixOS/nixpkgs/pull/63560.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kops: 1.11.1->1.12.1
user_login: ari-becker
html_url: https://github.com/NixOS/nixpkgs/pull/63562
updated_at: 2019-06-25 20:50:14
body:
  ###### Motivation for this change
  Package update: https://github.com/kubernetes/kops/releases/tag/1.12.1

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Side note: it would be helpful to have more explicit instructions for how to test. I tried some stuff with `nix-build` before giving up and submitting this without testing.


state: open
title: Generate Tags file for all Haskell Libraries in scope
user_login: rsoeldner
html_url: https://github.com/NixOS/nixpkgs/issues/63563
updated_at: 2019-07-05 21:19:10
body:
  Would like to generate a tags file for all libraries in scope - similiar to withHoogle. Has someone done this before ?


state: closed
title: Archive fetched by fetchFromGitHub is unpacked regardless of hash check
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/issues/63564
updated_at: 2019-06-20 14:49:56
body:
  ## Issue description
  I was experimenting with fixing the ue4 package, and noticed that the archive, when fetched from fetchFromGitHub is unpacked regardless of the hash check.
  Couldn't this be a possible security risk if say, something crazy like a code execution exploit was MITM'd in it's place or something else? (Although, the gzip and tar code is pretty solid)
  We should be hash checking the sha256 of the archive before doing anything with it.


state: closed
title: cargo-bloat: 0.7.0 -> 0.7.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63565
updated_at: 2019-06-21 01:22:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-bloat` to the latest version.
  https://github.com/RazrFalcon/cargo-bloat/releases/tag/v0.7.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luaPackages.luaexpat: Downgrade to fix prosody issue and match typical distros
user_login: Shados
html_url: https://github.com/NixOS/nixpkgs/pull/63566
updated_at: 2019-06-24 02:08:30
body:
  ###### Motivation for this change
  Matches version used on most distros. Fixes an issue with prosody. Detailed reasoning behind this can be found [here](https://github.com/NixOS/nixpkgs/pull/63108#issuecomment-504015507). As mentioned there, I'm tracking the prosody issue for it, so if some suitable resolution arises there I'll PR an update and remove the version specifier in `luarocks-packages.csv`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: (backport) fswatch: Enable FSEvents API on Darwin
user_login: knl
html_url: https://github.com/NixOS/nixpkgs/pull/63567
updated_at: 2019-06-20 16:15:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This brings a fix from master.

  On Darwin we can benefit from FSEvents API (that fswatch supports) in order to
  have better monitoring of file system changes.

  (cherry picked from commit a0bbe1aa27f7a0d97813e87087baf16e069c8067)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package Request: intel/compute-runtime
user_login: OpenSourceAnarchist
html_url: https://github.com/NixOS/nixpkgs/issues/63568
updated_at: 2019-06-23 22:21:14
body:
  ## Issue description

  compute-runtime, also known as Intel NEO, is an updated OpenCL driver for Broadwell+ Intel processors. It is available here: https://github.com/intel/compute-runtime

  Beignet and intel-ocl has been deprecated for all newer Intel processors (Broadwell+) in favor of compute-runtime. For legacy hardware, beignet is required.

  For newer hardware, this package is a requirement for OpenCL functionality. For instance, Ice Lake processors will not be supported on beignet, but are fully supported by Intel NEO.

  See the ebuild for https://packages.gentoo.org/packages/dev-libs/intel-neo and the PKGBUILD for https://www.archlinux.org/packages/community/x86_64/intel-compute-runtime/


state: closed
title: luaPackages.bit32: Tiny patch to fix a LuaJIT-incompatible declaration
user_login: Shados
html_url: https://github.com/NixOS/nixpkgs/pull/63569
updated_at: 2019-06-28 10:25:51
body:
  ###### Motivation for this change
  Makes it build cleanly against LuaJIT.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luajitPackages: Improve derivation names
user_login: Shados
html_url: https://github.com/NixOS/nixpkgs/pull/63570
updated_at: 2019-06-24 02:05:43
body:
  ###### Motivation for this change
  `"lua" + lua.luaversion + "-"` resolves to `"lua51-"` for both Lua 5.1 and LuaJIT packages. With this, LuaJIT packages instead get `lua.name + "-"`, which currently resolves to `"luajit-2.1.0-beta3-"`. This makes it easy to distinguish the two package sets in store paths, etc.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Singularity to 3.2.x or 3.3.0-rc1
user_login: bbarker
html_url: https://github.com/NixOS/nixpkgs/issues/63571
updated_at: 2019-06-20 15:15:09
body:
  ## Issue description

  Singularity is currently at 3.0.1 in nixpkgs; as advised upstream (https://github.com/sylabs/singularity/issues/3764#issuecomment-503908802), 3.0.x has many bugs and 3.1.x has severe security issues. The upstream issue also points out an issue I had, which *may* be fixed by updating.


state: closed
title: buildPerlPackage: name -> (pname, version)
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/63572
updated_at: 2019-06-28 21:56:28
body:
  ###### Motivation for this change

  Deprecating ```buildPerlPackage```'s ```name``` in favor of ```pname``` and ```version```, because ```name``` is tricky to parse sometimes (https://github.com/NixOS/nixpkgs/issues/61691)

  User's code should not be broken, using ```name``` works as before, just print a warning


state: closed
title: python3.pkgs.scikitlearn build broken
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/issues/63573
updated_at: 2019-07-13 08:42:28
body:
  ## Issue description

  The testsuite of scikitlearn on python3 was broken by the scipy 1.3.0 update in 1fcf121b62f11b5171e030ca59c722a28ff4f6a3. It fails with the same error that was reported [here](https://github.com/scikit-learn/scikit-learn/issues/13868). It doesn't fail on python2 since we still used scipy 1.2.1 there.

  CC @FRidh 


state: closed
title: openjfx11: init at 11.0.3+1
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/63574
updated_at: 2019-06-28 12:38:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  JavaFX (modern Java GUI framework) support in our GUI OpenJDK build. This allows for running JavaFX applications on NixOS. I don't know if any way to split it from OpenJDK and install it separately (perhaps via a symlink farm) exists; this is a [documented way to integrate OpenJFX](https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-IntegrationwithOpenJDK).

  Before:
  ```
  /nix/store/wkd27f2vi5vfx6c8cb0gcjaaxmhcfk4v-openjdk-11.0.3-ga	 637.7M
  ```
  After:
  ```
  /nix/store/vm1hzj1gs67xb0rqxndjrwvhxqz4j03y-openjdk-11.0.3-ga	 859.2M
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  OpenJFX 8 is quite a bit different so it's subject to future work.


state: closed
title: dafny: 2.1.0 -> 2.3.0
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/63575
updated_at: 2019-06-26 17:20:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: sd-image-aarch64 shouldn't import profiles/installation-device.nix
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/issues/63576
updated_at: 2019-06-21 00:14:19
body:
  ## Issue description
  When downloading the aarch64 sdcard image, the `/etc/nixos/configuration.nix` provided there imports `nixos/modules/installer/cd-dvd/sd-image-aarch64.nix`, which imports `nixos/modules/profiles/installation-device.nix`, which (among others) enables the nixos manual on tty8, force-enables the documentation, disabes sudo and udisks, disables sshd on bootup and enables automatic login as root without password.

  We probably want to provide a different configuration.nix in `/etc/nixos/configuration.nix` not importing installer-related things (or at least make it easy to disable them). 

  ### Steps to reproduce
   - Download the aarch64 sdcard image
   - flash it to a raspberry pi3
   - edit /etc/nixos/configuration.nix (add `services.openssh.enable = true` for example)
   - call `nixos-rebuild switch`
   - wonder why it's not started

  ## Technical details
  `nixos-sd-image-19.09pre183392.83ba5afcc96-aarch64-linux.img`

  cc @NinjaTrappeur


state: closed
title: i3lock-pixeled: 1.2.0 -> 1.2.1
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63577
updated_at: 2019-06-20 17:50:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://gitlab.com/Ma27/i3lock-pixeled/-/tags/1.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nix-optimise doesn't run in a container of *any* host
user_login: rhendric
html_url: https://github.com/NixOS/nixpkgs/issues/63578
updated_at: 2019-06-25 17:18:45
body:
  ## Issue description

  Since #48098, the `nix-optimise` service contains a `ConditionVirtualization` attribute that prevents the service from running inside a containerized installation of NixOS. The rationale for this change, as stated, is that `nix-optimise` should run on a NixOS host and not its containers. However, the `ConditionVirtualization` restriction is too broad, as it disables `nix-optimize` even when running inside a non-NixOS host. Containerization is, after all, an increasingly popular way of sampling less-mainstream Linux distros from inside a more familiar host, and as such NixOS features shouldn't assume that they're being hosted by NixOS whenever they're running in a container.

  Is testing the host OS from a module possible? Wrapping the `ConditionVirtualization` in a `mkIf` that does that would satisfy me (just as one example solution—so would other hypothetical solutions that let `nix-optimise` run under non-NixOS hosts).

  ### Steps to reproduce

  * Install NixOS as a container in a non-NixOS host (see #9884 for tips)
  * Set `nix.optimise.automatic = true;` in `configuration.nix`
  * See that `nix-optimise` doesn't run (`systemctl status nix-optimise`)

  #### Workaround

  It's a hack, but: `systemd.services.nix-optimise.unitConfig.ConditionVirtualization = pkgs.lib.mkForce null;` will do the trick. (This does still leave an awkward `ConditionVirtualization=` empty entry in the resulting service file, if you bother to check with `systemctl cat nix-optimise`... not that it *really* matters, as far as I can tell, but `mkUnset` from #63553 would be cleaner than `mkForce null`.)

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.5-arch1-2-ARCH, NixOS, 19.03.172927.30a82bba734 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172927.30a82bba734, nixos-unstable-19.09pre173349.07b42ccf2de"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: wxGTK31 cannot be overriden
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/63579
updated_at: 2019-06-24 01:43:06
body:
  ## Issue description

  I am trying to package [codelite](https://codelite.org/)-13.0.0, which depends on wxWidgets 3.1 or later. I am putting the following in `/alt/nixpkgs/pkgs/top-level/all-packages.nix`:

  ``` nix
    codelite = callPackage ../applications/editors/codelite {
      wxGTK = wxGTK31.override { withGtk2 = false; withWebKit = true; };
    };
  ```

  But it does not work:

  ```
  $ nix-build --option sandbox true -K -A codelite
  error: anonymous function at /alt/nixpkgs/pkgs/development/libraries/wxwidgets/3.1/default.nix:1:1 called with unexpected argument 'withGtk2', at /alt/nixpkgs/lib/customisation.nix:69:12
  (use '--show-trace' to show detailed location information)
  ```

  Currently [`wxGTK31`](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/wxwidgets/3.1/default.nix#L7) is defined using `overrideAttribs`

  cc @volth 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: buildBazelPackage: fix directory symlink handling, disable multithreaded fetching
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63580
updated_at: 2019-06-24 22:38:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The previous behaviour would work fine as long as `symlink` is a link to
  a file. If is a link to a directory though, the new `ln` wouldn't
  overwrite it but would create a new link *in that directory* (with the
  name of the link source).

  Instead, we can precompute the target location, then first remove the
  symlink and write the new one in its place.

  CC @uri-canva 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zabbix:1.8 -> 4.0 | remove old packages
user_login: PsyanticY
html_url: https://github.com/NixOS/nixpkgs/pull/63581
updated_at: 2019-07-12 13:35:59
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind: 9.14.2 -> 9.14.3 (CVE-2019-6471)
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/63582
updated_at: 2019-06-20 18:23:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [CVE-2019-6471](https://kb.isc.org/docs/cve-2019-6471)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind: 9.12.4-P1 -> 9.12.4-P2 (CVE-2019-6471)
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/63583
updated_at: 2019-06-20 19:33:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  CVE-2019-6471

  Stable version of #63582.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: openssh: use SUID ssh-keysign path
user_login: edef1c
html_url: https://github.com/NixOS/nixpkgs/pull/63585
updated_at: 2019-07-10 23:56:29
body:
  ###### Motivation for this change

  ssh-keysign is used for host-based authentication, and is designed to be used
  as SUID-root program. OpenSSH defaults to referencing it from libexec, which
  cannot be made SUID in Nix.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: CVE-2019-11708
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/63586
updated_at: 2019-06-20 19:42:33
body:
  Here we go again!

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  CVE-2019-11708.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.dm-sonnet: update bazel fetch hash
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63587
updated_at: 2019-06-20 20:16:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changed after the bazel 0.26 update in https://github.com/NixOS/nixpkgs/pull/62336.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: CVE-2019-11708
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/63588
updated_at: 2019-06-20 20:22:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  CVE-2019-11708

  Backport of #63586.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] nixos/mautrix-telegram: add module
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/63589
updated_at: 2019-07-10 12:04:52
body:
  ###### Motivation for this change

  This PR adds a module for mautrix-telegram.
  The module has been tested and is confirmed to work.

  A patch has been submitted and merged upstream (https://github.com/tulir/mautrix-telegram/pull/332) to allow API tokens to be supplied securely through environment variables instead of being written to the world-readable nix store.

  The module is based on https://github.com/NixOS/nixpkgs/pull/60151.

  ###### Blockers

  - [x] ~~Safe Telegram API token handling: https://github.com/NixOS/nixpkgs/pull/63947~~
  - [x] ~~Removal of app service registration (to protect the AS' token)~~
  - [ ] Serialisation of the config attribute set which contains `mkOverride` values (https://github.com/NixOS/nixpkgs/pull/63589#discussion_r299780638)
  - [ ] Rename `services.mautrix-telegram.config` to `services.mautrix-telegram.settings`?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC: @Vskilet, @Ma27 


state: closed
title: python.pkgs.rl-coach: 0.12.0 -> 0.12.1
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63590
updated_at: 2019-06-20 21:18:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adds support for scipy 1.3 and thereby unbreaks the build.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3.pkgs.scikitlearn: 0.20.3 -> 0.21.2
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63591
updated_at: 2019-06-22 15:59:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Splits scikitlearn into a python2 (0.20.x) and a python3 (>0.20)
  version.

  Currently blocked by https://github.com/NixOS/nixpkgs/issues/63573.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xtrace: 1.3.1 -> 1.4.0
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/63592
updated_at: 2019-06-25 16:40:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This one could not be updated automatically anymore. The source
  repository has changed.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: patchwork: 3.11.4 -> 3.14.1
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63593
updated_at: 2019-06-22 20:38:33
body:
  This updates patchwork from 3.11.4 to 3.14.1, and uses the `appimageTools`
  machinery to extract the AppImage instead of the wrapper used before.

  On top of that, we install a `.desktop` file, so its available from the
  application menu.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @Infinisil @NinjaTrappeur @thedavidmeister 


state: closed
title: samba: 4.10.4 -> 4.10.5 (security fix)
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/63594
updated_at: 2019-06-24 20:27:29
body:
  ###### Motivation for this change
  Security release fixing CVE-2019-12435 & CVE-2019-12436

  https://www.samba.org/samba/history/samba-4.10.5.html
  https://nvd.nist.gov/vuln/detail/CVE-2019-12435
  https://nvd.nist.gov/vuln/detail/CVE-2019-12436

  I still haven't finished the full `nox-review`, but thought I should post it anyway.

  `release-19.03` isn't vulnerable to either.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wxGTK31: 3.1.0 -> 3.1.2; use a real derivation
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63595
updated_at: 2019-06-24 11:37:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Uses a real derivation for `wxGTK31`, instead of overriding `wxGTK30` because some configure options for both packages diverge, and the way `wxGTK31` is currently defined does not allow overriding it. Fixes https://github.com/NixOS/nixpkgs/issues/63579.

  - Update to version [3.1.2](https://www.wxwidgets.org/downloads/)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: fetchers: use a meaningful name
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/63596
updated_at: 2019-06-24 11:02:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This adds a meaningful name to source packages fetched with fetch*
  helper functions.  The idea is to guess a good name based on the repo
  name and the revision. When the revision is a hash, it is truncated to
  length 10.

  To get an idea of the generated names, please look at
  https://gist.github.com/layus/7b176dd31b87a30be274d6de40f658b8. This was
  generated with nox-review and also hints at the massive rebuild incurred.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffsend: 0.2.46 -> 0.2.48
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/63597
updated_at: 2019-06-21 05:57:35
body:
  ###### Motivation for this change
  https://github.com/timvisee/ffsend/releases/tag/v0.2.47
  https://github.com/timvisee/ffsend/releases/tag/v0.2.48

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS (with sandboxing)
     - [X] macOS (without sandboxing)
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zfs: Remove requestEncryptionCredentials assertion
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/63598
updated_at: 2019-06-21 11:17:23
body:
  zfs >= 0.8 supporting encryption is now stable


  Ping @Mic92 @petabyteboy 
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/openvpn: support setting IP forwarding
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63599
updated_at: 2019-06-21 03:37:22
body:
  ###### Motivation for this change

  IP forwarding is needed for many of the OpenVPN use cases, so make it configurable through the openvpn module.

  Been using this for ages here.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fail2ban: fix dovecot filter's journalmatch
user_login: steadmon
html_url: https://github.com/NixOS/nixpkgs/pull/63600
updated_at: 2019-06-21 03:54:16
body:
  The dovecot filter config distributed with fail2ban watches for log
  entries with a journalmatch filter of "_SYSTEMD_UNIT=dovecot.service",
  but NixOS's Dovecot runs as dovecot2.service. Fix the journalmatch
  config to match NixOS's Dovecot.


  ###### Motivation for this change
  fail2ban doesn't currently work with dovecot because the upstream config uses a different name for the dovecot systemd service than NixOS.

  ###### Things done

  I'm afraid I am very new to Nix / NixOS and I'm not sure how to test this.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresql: 9.4.22 -> 9.4.23, 9.5.17 -> 9.5.18, 9.6.13 -> 9.6.14, 10.8 -> 10.9, 11.3 -> 11.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63601
updated_at: 2019-06-23 16:39:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://www.postgresql.org/about/news/1949/

  backport please

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: warning: Nix search path entry 'nixpkgs' does not exist, ignoring
user_login: jamesray1
html_url: https://github.com/NixOS/nixpkgs/issues/63602
updated_at: 2019-06-22 05:42:02
body:
  ## Issue description
  ```shell
  $ nix-shell https://holochain.love
  unpacking 'https://holochain.love'...
  error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at /nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix:3:19
  (use '--show-trace' to show detailed location information)
  ```
  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   12:18:21  jr@fm  ~  ⬡ v8.16.0 
  $ nix-shell -p nix-info --run "nix-info -m"
  error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at (string):1:13

   17:13:10  ✘  jr@fm  ~  ⬡ v8.16.0 
  $ inxi -Fxxx
  System:    Host: fm Kernel: 5.1.9-2-MANJARO x86_64 bits: 64 compiler: gcc v: 8.3.0 Desktop: KDE Plasma 5.16.80 tk: Qt 5.12.3 
             wm: kwin_x11 dm: SDDM Distro: Manjaro Linux 
  Machine:   Type: Desktop Mobo: ASUSTeK model: TUF B450M-PLUS GAMING v: Rev X.0x serial: <root required> 
             UEFI: American Megatrends v: 1002 date: 03/07/2019 
  CPU:       Topology: 8-Core model: AMD Ryzen 7 2700X bits: 64 type: MT MCP arch: Zen+ rev: 2 L2 cache: 4096 KiB 
             flags: avx avx2 lm nx pae sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3 svm bogomips: 118220 
             Speed: 2726 MHz min/max: 2200/3700 MHz boost: enabled Core speeds (MHz): 1: 2179 2: 2020 3: 1874 4: 1837 5: 2803 
             6: 1736 7: 1727 8: 2504 9: 1999 10: 1855 11: 2281 12: 1823 13: 1721 14: 2008 15: 2715 16: 1978 
  Graphics:  Device-1: NVIDIA TU104 [GeForce RTX 2080] vendor: ASUSTeK driver: nvidia v: 430.26 bus ID: 07:00.0 
             chip ID: 10de:1e82 
             Display: x11 server: X.Org 1.20.5 driver: nvidia compositor: kwin_x11 tty: N/A 
             OpenGL: renderer: GeForce RTX 2080/PCIe/SSE2 v: 4.6.0 NVIDIA 430.26 direct render: Yes 
  Audio:     Device-1: NVIDIA vendor: ASUSTeK driver: snd_hda_intel v: kernel bus ID: 07:00.1 chip ID: 10de:10f8 
             Device-2: Advanced Micro Devices [AMD] Family 17h HD Audio vendor: ASUSTeK driver: snd_hda_intel v: kernel 
             bus ID: 09:00.3 chip ID: 1022:1457 
             Device-3: Microsoft type: USB driver: snd-usb-audio,uvcvideo bus ID: 1-1:2 chip ID: 045e:0810 
             Sound Server: ALSA v: k5.1.9-2-MANJARO 
  Network:   Device-1: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet vendor: ASUSTeK driver: r8168 v: 8.047.01-NAPI 
             port: f000 bus ID: 05:00.0 chip ID: 10ec:8168 
             IF: enp5s0 state: up speed: 100 Mbps duplex: half mac: 40:b0:76:5c:8c:4c 
  Drives:    Local Storage: total: 1.36 TiB used: 26.18 GiB (1.9%) 
             ID-1: /dev/nvme0n1 vendor: Samsung model: SSD 970 EVO Plus 500GB size: 465.76 GiB speed: 31.6 Gb/s lanes: 4 
             serial: S4EVNG0M116780W rev: 1B2QEXM7 scheme: GPT 
             ID-2: /dev/sda type: USB vendor: Seagate model: Expansion size: 931.51 GiB serial: NA8GPRR8 rev: 0707 scheme: MBR 
  Partition: ID-1: / size: 389.04 GiB used: 26.18 GiB (6.7%) fs: ext4 dev: /dev/nvme0n1p2 
             ID-2: swap-1 size: 69.20 GiB used: 0 KiB (0.0%) fs: swap dev: /dev/nvme0n1p3 
  Sensors:   System Temperatures: cpu: 29.0 C mobo: N/A gpu: nvidia temp: 25 C 
             Fan Speeds (RPM): cpu: 0 gpu: nvidia fan: 20% 
  Info:      Processes: 325 Uptime: 7h 07m Memory: 62.91 GiB used: 4.99 GiB (7.9%) Init: systemd v: 242 Compilers: gcc: 8.3.0 
             Shell: zsh v: 5.7.1 running in: code inxi: 3.0.34 

   17:13:34  jr@fm  ~  ⬡ v8.16.0 
  ```

  Also
  ```
   11:35:22  ✘  jr@fm  ~  ⬡ v8.16.0 
  $ echo $NIX_PATH


   12:14:39  jr@fm  ~  ⬡ v8.16.0  33m58s 
  $ nix-shell https://holochain.love --show-trace -I /nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix
  error: while evaluating the file '/nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix':
  file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at /nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix:3:19

   12:15:23  ✘  jr@fm  ~  ⬡ v8.16.0 
  $ nix-shell https://holochain.love --show-trace -I nixpkgs                                                                       
  warning: Nix search path entry 'nixpkgs' does not exist, ignoring
  error: while evaluating the file '/nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix':
  file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at /nix/store/2wyxwa5902pa00kf4wm2gmr8npxvw12q-holochain.love/nixpkgs/nixpkgs.nix:3:19
  ```


state: closed
title: Enable cross compilation on buildGoPackage
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/63603
updated_at: 2019-07-12 15:16:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Current `buildGoPackage` family of functors does not set necessary cross-compilation flags to `go` calls. This PR will enable true cross-compilation by inheriting the necessary flags from the `go` derivation, such as `GOARCH`, `GOOS`, `CC` and `CXX`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cni-plugins: add version pin
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/63604
updated_at: 2019-06-21 08:52:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR adds a version pin to `cni-plugins` to allow sandboxed builds; and relaxes the constraint on the target platform, so that we can cross compile this package to, for example, `aarch64` once #63603 is merged.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add NodeJS v10 to nixos-small channel
user_login: wmertens
html_url: https://github.com/NixOS/nixpkgs/pull/63605
updated_at: 2019-06-21 09:09:00
body:
  v10 is the LTS but it is a breaking change to make it the default on 18.03 so it would be good to add it as build.

  This will increase the build time and closure size of nixos-small, but it would be useful for at least my servers.


state: closed
title: elixir_1_9: init at 1.9.0
user_login: cw789
html_url: https://github.com/NixOS/nixpkgs/pull/63606
updated_at: 2019-07-03 18:05:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I just prepared this PR.
  The use of `C.UTF-8` instead of `glibcLocales - en_US.UTF-8` needs to be tested if it doesn't have any side affects on Elixir.
  Should only be merged when Elixir `v1.9.0` is released, as I removed the then deprecated `v1.4`.


state: open
title: nixos/bluetooth: don't install obex tools by default
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/63607
updated_at: 2019-07-04 08:01:49
body:
  ###### Motivation for this change
  Currently setting `hardware.bluetooth.enable = true` install the OpenOBEX tools along with bluez.
  Since sharing files over bluetooth seems pretty uncommon and the packages are more than 200MB I propose we don't install them by default.

  ---


state: closed
title: SDL_gpu: init at 20190124
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/pull/63608
updated_at: 2019-07-12 10:17:58
body:
  ###### Motivation for this change

  I'm using this package with SDL2.

  Notes:

    - The library is supposed to work with SDL1 and SDL2. I've only packaged the SDL2 version right now. I'm hoping if somebody still uses SDL1, the derivation will be extended accordingly.
    - I'm aware of the strange `sed` command in the `patchPhase`. Replacing all of the `OUTPUT_DIR` variables isn't necessary and would have broken the build as far as I can ascertain.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: udev: change error message if RUN entry is not executable
user_login: tokudan
html_url: https://github.com/NixOS/nixpkgs/pull/63609
updated_at: 2019-06-24 12:21:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The current error message leads to confusion as seen for example here (https://discourse.nixos.org/t/udev-extrarules-with-external-script/3229).
  As the check explicitely checks if the entry is executable, it should be reflected in the error message.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: conftest: init at 0.7.0
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/63610
updated_at: 2019-06-24 19:59:31
body:
  ###### Motivation for this change
  Add [conftest](https://github.com/instrumenta/conftest).

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: buildbot: hash mismatch
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/issues/63611
updated_at: 2019-06-21 22:41:42
body:
  ## Issue description

  It seems like some of the buildbot python modules were updated silently, without a change in the version number.

  ```
  hash mismatch in fixed-output derivation '/nix/store/klp31bajf9ngfg6clxprpcnva98lyg62-buildbot-console-view-2.3.1.tar.gz':
    wanted: sha256:1yh8xij3wizz0f88chjpdijm7i35ql87g84ph3f76sqyr6aj6ckw
    got:    sha256:1y523hadw3398jwfpmi2f4g0s6dp9y191qzycrsbvbj147dp0qra

  hash mismatch in fixed-output derivation '/nix/store/053sp3s749ldnl37g9xgyw5v3hp94vkc-buildbot-wsgi-dashboards-2.3.1.tar.gz':
    wanted: sha256:13lr7lzi9sv0s6xrfalq0dkcys6fp7hn0787rjhnz9gc7x83aqjv
    got:    sha256:1jhvq61x0bzh03nd2ac11swdjn0ndnx3ac7x9v3m3v0pgr08rc28

  hash mismatch in fixed-output derivation '/nix/store/ikgybjqcys4csd5blmx90icpq52yd3x8-buildbot-waterfall-view-2.3.1.tar.gz':
    wanted: sha256:04iihy1s9r4n5jlk57pdjy3yvp6zym2iv2bgqjhw6fy0hff5j8ys
    got:    sha256:1prfr03igcmagydvxqhrh6k6wz16vk6fwgrm143jh3xmml6f16ll
  ```

  and possibly more

  ### Steps to reproduce

  `nix-shell -p python3.pkgs.buildbot-full`

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  pbb@onyx ~> nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96, unstable"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```


state: open
title: [WIP] Update Azure sdk
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63612
updated_at: 2019-07-19 21:03:35
body:
  ###### Motivation for this change
  Author for #60435 hasn't been heard from for almost a month. 

  Had to pin azure-storage for nixops_1_6_1.

  Eventually I hope to fix the `pythonPackages.azure`, as it's currently horribly broken. Also hope to restore proper support for azure in nixops (but that will be much later)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] nixos/acme: switch to lego and support DNS challenge
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/pull/63613
updated_at: 2019-06-30 13:03:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  We use Let's Encrypt with DNS-based ACME challenges at work, so I needed this. I have seen multiple other people request DNS challenge support (#34941, #35168). 

  - I have not tested if HTTP challenge still works with this at all
  - Todo: Is anything else needed to support wildcard certificates?
  - Todo: Documentation on how to use DNS challenge

  The following changes would be breaking:

  - As far as I could see, lego requires an email address to create an account
  - I could not see any possibility to specify different webroots when requesting one certificate for multiple domains
  - The plugin system that was used with simp_le is not supported. Some common files are generated in the post run script.
  - The remaining validity before renewal is now specified in days instead of minutes

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libreoffice-fresh: 6.2.3.2 -> 6.2.4.2
user_login: AluisioASG
html_url: https://github.com/NixOS/nixpkgs/pull/63614
updated_at: 2019-06-21 13:19:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  Tested on top of NixOS cd5da0d166d9b5c02d2be70a60a88dc167286798.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: hcloud: v1.11.0 -> v1.12.0
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/pull/63615
updated_at: 2019-06-26 13:01:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  closure size did not increase significantly

  ---


state: open
title: [WIP] tensorflow: re-enable build from source
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63616
updated_at: 2019-07-18 11:54:25
body:
  ###### Motivation for this change

  This resurrects the tensorflow source build. Its WIP because it builds an unreleased tensorflow version (current release didn't support the current bazel) and needs some cleanup, but it works. Builds upon https://github.com/NixOS/nixpkgs/pull/63580.

  My motivation for this was that I need to run tensorflow on a VM without avx instructions while the official wheel requires avx (https://github.com/tensorflow/tensorflow/issues/17411). There are still cpus sold without AVX support, so we shouldn't require it by default.

  Not sure yet if I'll actually push it over the finish line, since it "works for me" for now. But anyway, here it is.

  CC @volth, @abbradar who have touched the source build before.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libvisual for darwin blocks nixpkgs-unstable
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/issues/63617
updated_at: 2019-06-21 17:17:41
body:
  ## Issue description

  The `libvisual` build is failing, and seems to block the nixpkgs-unstable channel.
  https://hydra.nixos.org/build/95015893

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  cc @NixOS/darwin-maintainers 


state: closed
title: tomcat: CVE-2019-10072
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/63618
updated_at: 2019-06-24 07:05:01
body:
  ###### Motivation for this change
  According to this announcement:
  http://mail-archives.us.apache.org/mod_mbox/www-announce/201906.mbox/%3Cca69531a-1592-be7b-60ce-729549c7f812%40apache.org%3E

  .. both the 8.5 and 9 versions we have in nixpkgs are vulnerable. I ran the tomcat nixos test with `services.tomcat.package` set to `tomcat85` and `tomcat9`. Both tests passed locally.

  Not sure of the severity of the CVE. Perhaps this should be backported to 19.03 as well.

  @grahamcofborg build tomcat85 tomcat9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cool-retro-term doesn't start
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/issues/63619
updated_at: 2019-06-22 07:12:57
body:
  ## Issue description

  ```
  nix-shell -p cool-retro-term --run cool-retro-term

  QQmlApplicationEngine failed to load component
  qrc:/main.qml:24 module "QtGraphicalEffects" is not installed

  Cannot load QML interface
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.51, NixOS, 19.09pre182971.a1dd419c1ff (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(philipp): `""`
   - channels(root): `"nixos-19.09pre182971.a1dd419c1ff"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: mathematica: 11.3 -> 12.0
user_login: entonderfurchtlose
html_url: https://github.com/NixOS/nixpkgs/pull/63620
updated_at: 2019-06-26 14:45:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add support for Mathematica 12.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yj: init at 4.0.0
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/63621
updated_at: 2019-06-24 14:16:22
body:
  Converter between json/yaml/toml (minimal wrapper around go libraries)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zoneminder: fix some issues with database.createLocally option
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63622
updated_at: 2019-06-27 00:37:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/63152

  Not tested, or even built... I haven't used `zoneminder` yet so completely depending on @peterhoeg and @JohnAZoidberg for all testing and review.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: idrisPackages.tparsec: 2018-12-21 -> 2019-06-18
user_login: clayrat
html_url: https://github.com/NixOS/nixpkgs/pull/63623
updated_at: 2019-06-22 19:10:10
body:
  ###### Motivation for this change

  update idrisPackages.tparsec to latest rev

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: 2019.06.08 -> 2019.06.21
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63624
updated_at: 2019-06-21 17:46:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes yet another youtube issue.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: 2019.06.08 -> 2019.06.21 [19.03]
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63625
updated_at: 2019-06-21 17:47:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/63624.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefoxPackages.tor-browser: 8.5.0 -> 8.5.2
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/63626
updated_at: 2019-06-21 18:38:04
body:
  # `git log`

  - firefoxPackages.tor-browser: 8.5.0 -> 8.5.2

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (2):
      - firefoxPackages.tor-browser
      - tor-browser-bundle
  - On aarch64-linux: ditto
  - On x86_64-darwin:
    - Updated (1):
      - firefoxPackages.tor-browser

  /cc @joachifm


state: closed
title: gstreamer: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/63627
updated_at: 2019-07-10 22:34:46
body:
  ###### Motivation for this change

  Another fix to unblock `qt5.qtmultimedia` #63617.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: openalSolf, mpv: fix, enable HRTF support
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/63628
updated_at: 2019-06-21 19:03:53
body:
  # What? Why?

  Fixing HRTF (see https://en.wikipedia.org/wiki/Head-related_transfer_function) functionality in `openalSolf` and then enabling it by defeault in `mpv` is the simplest way I found to get proper sound output for media files with more than two channels of audio.

  For instance, say you want to properly hear all of the channels of a 5.1 movie while wearing stereo headphones. Applying this patchset makes it magically work in plain simple `mpv` without any hacking with ALSA mapping tables, PulseAudio, jackd, etc.

  As a nice bonus, using this also allows to map `mpv` sound output with a HRTF. The default HRTF that comes with `openalSolf` is not particularly awesome, but it works, and it can be easily configured via `~/.alsoftrc` if desired.

  # `git log`

  - openalSolf: make it search its own $out for data files

    Without those data files HRTF will silently fail to initialize.

    It searches /usr and /usr/local by default but we don't have those paths.
    It also searches XDG_DATA_DIRS but using that requires configuration by the
    user. This patch makes makes it just work.

    How to play with it:

    - Build `mpv` with `openalSoft` support.

    - cat << EOF > ~/.alsoftrc
    [general]
    hrtf = true
    EOF

    - Wear stereo headphones.

    - Play a file with 6 or more channels with `mpv -ao openal $file`, e.g.
      https://archive.org/download/5.1SurroundSoundTestFilesVariousFormatsAACAC3MP4DTSWAV/5.1%20Surround%20Sound%20AAC%20Test.mp4

    - Try `hrtf = false` to hear the difference.

  - mpv: enable openal support by default

    See the previous commit.

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (189):
      - _90secondportraits
      - airwave
      - alienarena
      - allegro
      - allegro5
      - alure
      - andyetitmoves
      - arx-libertatis
      - assaultcube
      - astromenace
      - atanks
      - attract-mode
      - bino3d
      - blackshades
      - blender
      - cgui
      - csfml
      - curseradio
      - deepin.dde-file-manager
      - deepin.deepin-movie-reborn
      - desmume
      - dhewm3
      - digikam
      - digikam5
      - dolphinEmu
      - dolphinEmuMaster
      - duckmarines
      - dumb
      - dwarf_fortress
      - dwarf-fortress
      - dwarf-fortress-packages.dwarf-fortress_0_43_05
      - dwarf-fortress-packages.dwarf-fortress_0_44_05
      - dwarf-fortress-packages.dwarf-fortress_0_44_09
      - dwarf-fortress-packages.dwarf-fortress_0_44_10
      - dwarf-fortress-packages.dwarf-fortress_0_44_11
      - dwarf-fortress-packages.dwarf-fortress-full
      - dwarf-fortress-packages.dwarf-fortress-original
      - dwarf-fortress-packages.dwarf-therapist
      - EmptyEpsilon
      - endless-sky
      - extremetuxracer
      - ffmpeg-full
      - flightgear
      - freealut
      - freeorion
      - fsuae
      - garden-of-coloured-lights
      - gemrb
      - gnome-mpv
      - gzdoom
      - handbrake
      - higan
      - hydron
      - ioquake3
      - kdeApplications.konquest
      - kdeApplications.libkdegames
      - kodiPlugins.steam-launcher
      - libretro.dolphin
      - libsForQt511.libqtav
      - libsForQt5.libqtav
      - linux-steam-integration
      - liquidsoap
      - liquidwar5
      - love
      - love_0_7
      - love_0_8
      - love_0_9
      - love_11
      - lugaru
      - lutris
      - mars
      - megaglest
      - meguca
      - minetest
      - minetestclient_4
      - mosdepth
      - mpc-qt
      - mpv
      - mpv-with-scripts
      - mrrescue
      - naev
      - nim
      - nrpl
      - olive-editor
      - openal
      - openarena
      - openclonk
      - opendungeons
      - openmw
      - openmw-tes3mp
      - openra
      - openraPackages.engines.bleed
      - openraPackages.engines.playtest
      - openraPackages.mods.ca
      - openraPackages.mods.d2
      - openraPackages.mods.dr
      - openraPackages.mods.gen
      - openraPackages.mods.kknd
      - openraPackages.mods.mw
      - openraPackages.mods.ra2
      - openraPackages.mods.raclassic
      - openraPackages.mods.rv
      - openraPackages.mods.sp
      - openraPackages.mods.ss
      - openraPackages.mods.ura
      - openraPackages.mods.yr
      - openrw
      - openspades
      - orthorobot
      - pipelight
      - playonlinux
      - plex-media-player
      - python27Packages.mpv
      - python27Packages.pydub
      - python37Packages.mpv
      - python37Packages.pydub
      - qtox
      - quake3demo
      - quake3game
      - racer
      - rigsofrods
      - rimshot
      - rpcs3
      - scorched3d
      - sfml
      - sienna
      - simgear
      - slade
      - sladeUnstable
      - solarus
      - solarus-quest-editor
      - soundkonverter
      - speed_dreams
      - spring
      - springLobby
      - steam
      - steamcmd
      - steam-run
      - steam-run-native
      - stuntrally
      - superTux
      - superTuxKart
      - tdesktop
      - tdm
      - tome4
      - torcs
      - toxic
      - trigger
      - ue4demos.black_jack
      - ue4demos.blueprint_examples_demo
      - ue4demos.card_game
      - ue4demos.effects_cave_demo
      - ue4demos.elemental_demo
      - ue4demos.landscape_mountains
      - ue4demos.matinee_demo
      - ue4demos.mobile_temple_demo
      - ue4demos.realistic_rendering
      - ue4demos.reflections_subway
      - ue4demos.scifi_hallway_demo
      - ue4demos.shooter_game
      - ue4demos.strategy_game
      - ue4demos.stylized_demo
      - ue4demos.swing_ninja
      - ue4demos.tappy_chicken
      - ue4demos.vehicle_game
      - ultimatestunts
      - unigine-valley
      - urbanterror
      - ut2004demo
      - utox
      - vapor
      - vbam
      - voxelands
      - warsow
      - warsow-engine
      - warzone2100
      - wine
      - wineFull
      - wine-staging
      - wineStaging
      - winetricks
      - wineWowPackages.full
      - yquake2
      - yquake2-all-games
      - yquake2-ctf
      - yquake2-ground-zero
      - yquake2-the-reckoning
      - zdoom
      - zeroad
  - On aarch64-linux:
    - Updated (127):
      - _90secondportraits
      - alienarena
      - allegro
      - allegro5
      - alure
      - arx-libertatis
      - assaultcube
      - astromenace
      - atanks
      - attract-mode
      - bino3d
      - blackshades
      - cgui
      - csfml
      - curseradio
      - deepin.dde-file-manager
      - deepin.deepin-movie-reborn
      - desmume
      - dhewm3
      - digikam
      - digikam5
      - duckmarines
      - dumb
      - EmptyEpsilon
      - endless-sky
      - extremetuxracer
      - ffmpeg-full
      - flightgear
      - freealut
      - freeorion
      - garden-of-coloured-lights
      - gemrb
      - gnome-mpv
      - handbrake
      - higan
      - hydron
      - ioquake3
      - kdeApplications.konquest
      - kdeApplications.libkdegames
      - libretro.dolphin
      - libsForQt511.libqtav
      - libsForQt5.libqtav
      - liquidsoap
      - liquidwar5
      - love
      - love_0_7
      - love_0_8
      - love_0_9
      - love_11
      - lugaru
      - mars
      - megaglest
      - meguca
      - minetest
      - minetestclient_4
      - mosdepth
      - mpc-qt
      - mpv
      - mpv-with-scripts
      - mrrescue
      - naev
      - nim
      - olive-editor
      - openal
      - openarena
      - opendungeons
      - openmw
      - openmw-tes3mp
      - openra
      - openraPackages.engines.bleed
      - openraPackages.engines.playtest
      - openraPackages.mods.ca
      - openraPackages.mods.d2
      - openraPackages.mods.dr
      - openraPackages.mods.gen
      - openraPackages.mods.kknd
      - openraPackages.mods.mw
      - openraPackages.mods.ra2
      - openraPackages.mods.raclassic
      - openraPackages.mods.rv
      - openraPackages.mods.sp
      - openraPackages.mods.ss
      - openraPackages.mods.ura
      - openraPackages.mods.yr
      - openrw
      - openspades
      - orthorobot
      - plex-media-player
      - python27Packages.mpv
      - python27Packages.pydub
      - python37Packages.mpv
      - python37Packages.pydub
      - qtox
      - quake3demo
      - quake3game
      - rimshot
      - scorched3d
      - sfml
      - sienna
      - simgear
      - solarus
      - solarus-quest-editor
      - soundkonverter
      - speed_dreams
      - stuntrally
      - superTux
      - superTuxKart
      - tdesktop
      - torcs
      - toxic
      - trigger
      - ultimatestunts
      - urbanterror
      - utox
      - vapor
      - vbam
      - voxelands
      - warsow
      - warsow-engine
      - warzone2100
      - yquake2
      - yquake2-all-games
      - yquake2-ctf
      - yquake2-ground-zero
      - yquake2-the-reckoning
      - zdoom
      - zeroad
  - On x86_64-darwin:
    - Updated (20):
      - curseradio
      - freealut
      - gemrb
      - mpc-qt
      - mpv
      - mpv-with-scripts
      - nim
      - openal
      - openrw
      - openspades
      - plex-media-player
      - python27Packages.mpv
      - python37Packages.mpv
      - qtox
      - sfml
      - yquake2
      - yquake2-all-games
      - yquake2-ctf
      - yquake2-ground-zero
      - yquake2-the-reckoning


state: closed
title: vdr: 2.4.0 -> 2.4.1
user_login: ck3d
html_url: https://github.com/NixOS/nixpkgs/pull/63630
updated_at: 2019-06-24 08:32:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  vdr got an update with fixes

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: xpra faults on startup
user_login: ornxk
html_url: https://github.com/NixOS/nixpkgs/issues/63631
updated_at: 2019-06-21 20:40:20
body:
  ## Issue description
  xpra version 2.5 as of commit d77e3bd661354ea775a8cacc97bb59ddde513c09 (the commit that marked xpra as not broken) fails to start, giving a type error. The latest commit failed to build at all.

  This happens after I loaded the uinput module with modprobe, and set its device node to be owned by my user.

  ```
  $ Entering daemon mode; any further errors will be reported to:
    /run/user/1000/xpra/:100.log
  $ cat /run/user/1000/xpra/:100.log
  xpra main error:
  Traceback (most recent call last):
    File "/nix/store/1lms1r8fqjxsdziqmshv0mp2r7ir410x-xpra-2.5/lib/python3.7/site-packages/xpra/scripts/main.py", line 93, in main
      return run_mode(script_file, err, options, args, mode, defaults)
    File "/nix/store/1lms1r8fqjxsdziqmshv0mp2r7ir410x-xpra-2.5/lib/python3.7/site-packages/xpra/scripts/main.py", line 421, in run_mode
      return run_server(error_cb, options, mode, script_file, args, current_display)
    File "/nix/store/1lms1r8fqjxsdziqmshv0mp2r7ir410x-xpra-2.5/lib/python3.7/site-packages/xpra/scripts/server.py", line 617, in run_server
      return do_run_server(error_cb, opts, mode, xpra_file, extra_args, desktop_display)
    File "/nix/store/1lms1r8fqjxsdziqmshv0mp2r7ir410x-xpra-2.5/lib/python3.7/site-packages/xpra/scripts/server.py", line 895, in do_run_server
      uinput_uuid = get_rand_chars(UINPUT_UUID_LEN)
    File "/nix/store/1lms1r8fqjxsdziqmshv0mp2r7ir410x-xpra-2.5/lib/python3.7/site-packages/xpra/os_util.py", line 219, in get_rand_chars
      return b"".join(chars[random.randint(0, len(chars)-1)] for _ in range(l))
  TypeError: sequence item 0: expected a bytes-like object, int found
  ```

  ## Technical details
  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.41, NixOS, 19.03.172883.1601f559e89 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(marisa): `"nixos-19.03.172883.1601f559e89, nixos-unstable-19.09pre182743.7815c86c104, nixpkgs-unstable-19.09pre182717.b58ada326aa"`
   - channels(alice): `"nixos-19.03.172883.1601f559e89"`
   - channels(root): `"nixos-19.03.172883.1601f559e89, unstable-19.09pre179307.bc94dcf5002"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: Add libinput xorg configuration for mouse pointers (in addition to touchpad).
user_login: blargg
html_url: https://github.com/NixOS/nixpkgs/issues/63633
updated_at: 2019-06-23 07:32:01
body:
  ## Issue description
  There doesn't currently seem to be a way to set the mouse pointer speed and acceleration profile for mouse pointers (other than `services.xserver.extraConfig`). For touch pads, we already have `services.xserver.libinput.accelSpeed` and related options. The xorg config this generates chooses to only apply to touchpads. [source](https://github.com/NixOS/nixpkgs/blob/ea18186b4acae88832baa35caa95d95449c0ede0/nixos/modules/services/x11/hardware/libinput.nix#L215)


  ### Proposed Solution
  From what I've seen, it seems like libinput is the correct way to set the mouse speed on linux. We should make options so that we can set these for mouse pointers as well.

  We can add an additional option to libinput, called `pointerType`, which will allow you to set if the options will be applied to a pointer or to a touchpad (and later extended if there are other filters that we need).

  This will not allow someone to set the speed differently for a mouse pad and pointer on the same computer (e.g. If you have a laptop and you want your usb mouse and touchpad, you cannot set both). I think this could be extended into that later.


  ### Steps to reproduce
  N/A (missing functionality)


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.52, NixOS, 19.03.172927.30a82bba734 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(tom): `"unstable-19.09pre182717.b58ada326aa"`
   - channels(root): `"nixos-19.03.172927.30a82bba734, unstable-19.09pre182717.b58ada326aa"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: moodle: init at 3.7.1
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63634
updated_at: 2019-07-11 14:14:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://discourse.nixos.org/t/writing-my-own-local-httpd-subservice/3194

  ###### Things not yet done but need to be before merged
  - [ ] Find a maintainer so `meta` can be completed in the package
  - [ ] Testing by someone who actually knows how to use `moodle`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gstreamer for steam-run build broken on master
user_login: marzipankaiser
html_url: https://github.com/NixOS/nixpkgs/issues/63635
updated_at: 2019-06-22 08:30:29
body:
  ## Issue description
  Build fails for `steam-run` when using current nixpkgs master:
      
  ```
  $ nix-shell '<nixpkgs>' -A steam-run --pure
  these derivations will be built:
    /nix/store/vzvp6d8mml24f0f98a1c4pb6gpacd9kh-gst-plugins-base-1.16.0.drv
    /nix/store/xn3kz23bpi2i2h96b89y2fmq7qsfz4g3-gst-plugins-ugly-1.16.0.drv
    /nix/store/831qz5iw51p27fja2fq0vy7v820zkys4-steam-run-usr-multi.drv
    /nix/store/g9qgp240gmj8hgg0k771hay72qlr2p3r-gst-plugins-base-1.16.0.drv
    /nix/store/4vxlg34v3lfx8i6jzhdbjmx1zf5kpv72-gst-plugins-ugly-1.16.0.drv
    /nix/store/vz2fxafddp9zfl09jcran3x790idbi49-steam-run-usr-target.drv
    /nix/store/080al2r06g3f03wa0sxvq7c7b3riz6l7-steam-run-fhs.drv
    /nix/store/20cnnn682bki449wnx2rz3xmcj8amjpl-steam-run-init.drv
  building '/nix/store/g9qgp240gmj8hgg0k771hay72qlr2p3r-gst-plugins-base-1.16.0.drv'...
  building '/nix/store/vzvp6d8mml24f0f98a1c4pb6gpacd9kh-gst-plugins-base-1.16.0.drv'...
  unpacking sources
  unpacking source archive /nix/store/ny4rkf83c82k6vn17vpzpq6y4p8f1r3i-gst-plugins-base-1.16.0.tar.xz
  unpacking sources
  unpacking source archive /nix/store/ny4rkf83c82k6vn17vpzpq6y4p8f1r3i-gst-plugins-base-1.16.0.tar.xz
  source root is gst-plugins-base-1.16.0
  source root is gst-plugins-base-1.16.0
  setting SOURCE_DATE_EPOCH to timestamp 1555629612 of file gst-plugins-base-1.16.0/po/zh_CN.po
  patching sources
  applying patch /nix/store/x7py1q1yqdc1kkk9k469qi24mm83j7rd-fix_pkgconfig_includedir.patch
  patching file pkgconfig/meson.build
  patching script interpreter paths in .
  setting SOURCE_DATE_EPOCH to timestamp 1555629612 of file gst-plugins-base-1.16.0/po/zh_CN.po
  patching sources
  applying patch /nix/store/x7py1q1yqdc1kkk9k469qi24mm83j7rd-fix_pkgconfig_includedir.patch
  patching file pkgconfig/meson.build
  ./depcomp: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  patching script interpreter paths in .
  ./config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./depcomp: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./test-driver: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./common/extract-release-date-from-doap-file: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./test-driver: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./common/download-translations: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./common/extract-release-date-from-doap-file: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./common/download-translations: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./common/check-exports: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./common/scangobj-merge.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/wd9cd2hhfim7i64ff1p1vsm6cb5kf4gq-python3-3.7.3/bin/python"
  ./common/check-exports: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./common/gst-indent: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./common/scangobj-merge.py: interpreter directive changed from "/usr/bin/python" to "/nix/store/4c4ajgdnhlqk994hilagk5cgv7vw9yzg-python3-3.7.3/bin/python"
  ./compile: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./common/gst-indent: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./compile: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./config.rpath: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./missing: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./config.rpath: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  ./configure: interpreter directive changed from " /bin/sh" to "/nix/store/j1qjqdwxlyc62fadqw4kya5cn0qyf2sc-bash-4.4-p23/bin/sh"
  ./missing: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  configuring
  ./configure: interpreter directive changed from " /bin/sh" to "/nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/sh"
  meson flags: --buildtype=release         --libdir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/lib --libexecdir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/libexec         --bindir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/bin --sbindir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/sbin         --includedir=/nix/store/47yy0agwxzl5wks4zjjilpcgk66mawai-gst-plugins-base-1.16.0-dev/include         --mandir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/share/man --infodir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/share/info         --localedir=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0/share/locale         -Dauto_features=disabled         --prefix=/nix/store/qls86h2ipf9x79i05msba23v4rbb9wic-gst-plugins-base-1.16.0 -Dauto_features=enabled -Dexamples=disabled -Dgl-graphene=disabled -Dgl_winsys=[x11,wayland] -Dgtk_doc=disabled
  configuring
  meson flags: --buildtype=release         --libdir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/lib --libexecdir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/libexec         --bindir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/bin --sbindir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/sbin         --includedir=/nix/store/mgw15jqamf2jw0qqfdch3vb68qjm8b7w-gst-plugins-base-1.16.0-dev/include         --mandir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/share/man --infodir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/share/info         --localedir=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0/share/locale         -Dauto_features=disabled         --prefix=/nix/store/hzlqdrgln5kmlp3sqdl8nblhlpi5kqd0-gst-plugins-base-1.16.0 -Dauto_features=enabled -Dexamples=disabled -Dgl-graphene=disabled -Dgl_winsys=[x11,wayland] -Dgtk_doc=disabled
  gcc: error: /build/gst-plugins-base-1.16.0/build/meson-private/sanitycheckobjc.m: Objective-C compiler not installed on this system
  gcc: error: /build/gst-plugins-base-1.16.0/build/meson-private/sanitycheckobjc.m: Objective-C compiler not installed on this system
  The Meson build system
  Version: 0.49.2
  Source dir: /build/gst-plugins-base-1.16.0
  Build dir: /build/gst-plugins-base-1.16.0/build
  Build type: native build
  Project name: gst-plugins-base
  Project version: 1.16.0
  Native C compiler: /nix/store/x3fl1fblijxrmnsiwipsssqhpffz168r-gcc-wrapper-7.4.0/bin/cc (gcc 7.4.0 "gcc (GCC) 7.4.0")
  Build machine cpu family: x86
  Build machine cpu: i686
  Native C++ compiler: /nix/store/x3fl1fblijxrmnsiwipsssqhpffz168r-gcc-wrapper-7.4.0/bin/c++ (gcc 7.4.0 "g++ (GCC) 7.4.0")
  Compiler for language objc not found.
  Compiler for C supports link arguments -Wl,-Bsymbolic-functions: YES
  Compiler for C supports arguments -fvisibility=hidden: YES
  Compiler for C supports arguments -fno-strict-aliasing: YES
  Has header "dlfcn.h" : YES
  Has header "emmintrin.h" : YES
  Has header "inttypes.h" : YES
  Has header "memory.h" : YES
  Has header "process.h" : NO
  Has header "smmintrin.h" : YES
  Has header "stdint.h" : YES
  Has header "stdlib.h" : YES
  Has header "strings.h" : YES
  Has header "string.h" : YES
  Has header "sys/socket.h" : YES
  Has header "sys/stat.h" : YES
  Has header "sys/types.h" : YES
  Has header "sys/wait.h" : YES
  Has header "unistd.h" : YES
  Has header "winsock2.h" : NO
  Has header "xmmintrin.h" : YES
  Has header "linux/dma-buf.h" : YES
  Library m found: YES
  Checking for function "dcgettext" with dependency -lm: YES
  Checking for function "gmtime_r" with dependency -lm: YES
  Checking for function "lrintf" with dependency -lm: YES
  Checking for function "mmap" with dependency -lm: YES
  Checking for function "log2" with dependency -lm: YES
  Checking for size of "char" : 1
  Checking for size of "int" : 4
  Checking for size of "long" : 4
  Checking for size of "short" : 2
  Checking for size of "void*" : 4
  Compiler for C++ supports arguments -Waggregate-return: YES
  Compiler for C supports arguments -Wmissing-declarations: YES
  Compiler for C++ supports arguments -Wmissing-declarations: YES
  Compiler for C supports arguments -Wredundant-decls: YES
  Compiler for C++ supports arguments -Wredundant-decls: YES
  Compiler for C supports arguments -Wundef: YES
  Compiler for C++ supports arguments -Wundef: YES
  Compiler for C supports arguments -Wwrite-strings: YES
  Compiler for C++ supports arguments -Wwrite-strings: YES
  Compiler for C supports arguments -Wformat: YES
  Compiler for C++ supports arguments -Wformat: YES
  Compiler for C supports arguments -Wformat-nonliteral: YES
  Compiler for C++ supports arguments -Wformat-nonliteral: YES
  Compiler for C supports arguments -Wformat-security: YES
  Compiler for C++ supports arguments -Wformat-security: YES
  Compiler for C supports arguments -Winit-self: YES
  Compiler for C++ supports arguments -Winit-self: YES
  Compiler for C supports arguments -Wmissing-include-dirs: YES
  Compiler for C++ supports arguments -Wmissing-include-dirs: YES
  Compiler for C supports arguments -Waddress: YES
  Compiler for C++ supports arguments -Waddress: YES
  Compiler for C supports arguments -Wno-multichar -Wmultichar: YES
  Compiler for C++ supports arguments -Wno-multichar -Wmultichar: YES
  Compiler for C supports arguments -Wvla: YES
  Compiler for C++ supports arguments -Wvla: YES
  Compiler for C supports arguments -Wpointer-arith: YES
  Compiler for C++ supports arguments -Wpointer-arith: YES
  Compiler for C supports arguments -Wmissing-prototypes: YES
  Compiler for C supports arguments -Wdeclaration-after-statement: YES
  Found pkg-config: /nix/store/y1anxcj45n8w4pbzjlq5m10b2fnhc3jw-pkg-config-0.29.2/bin/pkg-config (0.29.2)
  Dependency x11 found: YES 1.6.7
  Dependency glib-2.0 found: YES 2.60.3
  Dependency gobject-2.0 found: YES 2.60.3
  Dependency gio-2.0 found: YES 2.60.3
  Dependency gio-unix-2.0 found: YES 2.60.3
  Dependency gmodule-no-export-2.0 found: YES 2.60.3
  Dependency gdk-pixbuf-2.0 skipped: feature examples disabled
  Dependency gtk+-3.0 skipped: feature examples disabled
  Dependency gtk+-x11-3.0 skipped: feature examples disabled
  Dependency gstreamer-1.0 found: YES 1.16.0
  Dependency gstreamer-base-1.0 found: YES 1.16.0
  Dependency gstreamer-net-1.0 found: YES 1.16.0
  Found CMake: NO
  Dependency gstreamer-check-1.0 found: NO (tried pkgconfig)
  Looking for a fallback subproject for the dependency gstreamer-check-1.0
  Couldn't use fallback subproject in subprojects/gstreamer for the dependency gstreamer-check-1.0
  Reason: Failed to initialize 'subprojects/gstreamer':
  Subproject directory not found and gstreamer.wrap file not found

  meson.build:303:0: ERROR:  Dependency "gstreamer-check-1.0" not found, tried pkgconfig

  A full log can be found at /build/gst-plugins-base-1.16.0/build/meson-logs/meson-log.txt
  builder for '/nix/store/vzvp6d8mml24f0f98a1c4pb6gpacd9kh-gst-plugins-base-1.16.0.drv' failed with exit code 1
  cannot build derivation '/nix/store/xn3kz23bpi2i2h96b89y2fmq7qsfz4g3-gst-plugins-ugly-1.16.0.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/831qz5iw51p27fja2fq0vy7v820zkys4-steam-run-usr-multi.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/080al2r06g3f03wa0sxvq7c7b3riz6l7-steam-run-fhs.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/20cnnn682bki449wnx2rz3xmcj8amjpl-steam-run-init.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/20cnnn682bki449wnx2rz3xmcj8amjpl-steam-run-init.drv' failed

  ```
  The meson-logs mentioned in the output do not exist anywhere as far as I can tell.

  The build works fine on a718f72a8e88a97bb4381a4ece5d63c69ab1a217.

  ### Steps to reproduce
  Try to build `steam-run` from current master (987ec8aed453ea944a4d53aa0ee47d8371c6844c).


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.12, NixOS, 19.09pre-git (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `""`
   - channels(gaisseml): `""`
   - nixpkgs: `/nix/store/rs0pi5j63ihrvfalfc6q5cy02q9x4rd2-src/nixpkgs`

  `nix-info` output looks that way since I build from a nixpkgs git checkout and do not use channels.


state: closed
title: distgen: init at 1.3
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/63636
updated_at: 2019-07-12 17:45:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This tool is mainly used in openshift to build source to image containers.
  Building a [source to image container](https://github.com/sclorg/s2i-python-container) required `dg` to be present.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gstreamer: re-enable auto_features
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/63637
updated_at: 2019-06-22 09:14:36
body:
  ###### Things done

  /cc @jtojnar 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "Remove amdadlsdk and amdappsdk."
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/63638
updated_at: 2019-06-24 01:42:31
body:
  # `git log`

  - Revert "Remove amdadlsdk and amdappsdk."

    This reverts commit 08ea7c7ee28a24226c051b467ae0fef0584cfe40.

    This was a part of #61823.

    Firstly, that commit removed those attributes without removing the files
    they refer to, which is strange.

    Secondly, I have a very old but GPGPU-capabale AMD card which doesn't work
    with newer OpenCL infrastructure and hence needs these packages to do GPGPU.

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - New (6):
      - amdadlsdk
      - amdappsdk26
      - amdappsdk27
      - amdappsdk28
      - amdappsdk
      - amdappsdkFull
  - On aarch64-linux:
    - New (1):
      - amdadlsdk
  - On x86_64-darwin: noop

  /cc @ambrop72 @joachifm from that PR


state: closed
title: matrix-synapse: fix documentation
user_login: Ekleog
html_url: https://github.com/NixOS/nixpkgs/pull/63639
updated_at: 2019-07-13 16:17:15
body:
  cc @jtojnar @florianjacob from the `git blame`.

  My synapse deployment would work properly only with this change, but pinging you to check whether you have the same thing or it's some other configuration difference that forced me to add that. :)


state: closed
title: thunderbird, thunderbird-bin: 60.7.1 -> 60.7.2 [Critical security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/63640
updated_at: 2019-06-22 08:32:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Critical security fixes

  https://www.thunderbird.net/en-US/thunderbird/60.7.2/releasenotes/
  https://www.mozilla.org/en-US/security/known-vulnerabilities/thunderbird/#thunderbird60.7.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: VLC needs libaacs for encrypted Blu Ray
user_login: WhittlesJr
html_url: https://github.com/NixOS/nixpkgs/issues/63641
updated_at: 2019-06-24 18:46:01
body:
  ## Issue description

  I think all it needs is libaacs in its buildInputs. I tried doing this myself, but ran into multiple build errors, which are seemingly not caused by the change... even just trying to rebuild it with no substantial changes (at 83ba5afcc9682b52b39a9a958f730b966cc369c5) gives me build errors. How is this building and why can't I build it??

  ```
  configuring
  fixing libtool script ./autotools/ltmain.sh
  no configure script, doing nothing
  sed: can't read config.h: No such file or directory
  builder for '/nix/store/db0fcyq3f005549ksxwx7jrx4hz5jcbh-vlc-3.0.7.1.drv' failed with exit code 2
  ```

  ### Steps to reproduce

  Try to rebuild VLC on your own.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs` (overridden during rebuild)


state: open
title: Fix Handbrake build on Darwin by turning off GUI support
user_login: bdesham
html_url: https://github.com/NixOS/nixpkgs/pull/63643
updated_at: 2019-07-19 17:39:52
body:
  ###### Motivation for this change

  * **Fix cairo build on macOS** by disabling Xlib support.
  * **Fix ffmpeg-full build on macOS** by making sure that the `nvenc` option is not used.
  * **Fix handbrake build** by adding a dependency on lzma (for all platforms) and adding some Darwin-specific libraries and patches.
  * **Fix mp4v2 build** by building against the C++03 standard. The package has some code that is not valid under the newer standards.
  * **Add [video-transcoding](https://github.com/donmelton/video_transcoding),** a set of scripts for transcoding, inspecting, and converting videos.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @codyopel @fuuzetsu @Anton-Latukha @wmertens


state: closed
title: buildbot: 2.3.0 -> 2.3.1
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/63644
updated_at: 2019-06-23 15:06:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  Updates buildbot to the latest version.

  I was not able to run the NixOS test on master due to #63627, which broke the test infrastructure, but the test passed on unstable.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bazel: add fixed output test case
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63645
updated_at: 2019-06-24 14:20:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Feels like a horrible hack, but it should make sure that downstream
  hashes are preserved between bazel versions.

  The hash changed in the 0.24 -> 0.26 update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.r2pipe: 1.3.1 -> 1.4.1
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63646
updated_at: 2019-06-22 08:56:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sccache: init at 0.2.8
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/63648
updated_at: 2019-06-23 11:58:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This is the beginning of a new compiler cache support for NixOS, starting with the bare package. As discussed here: https://discourse.nixos.org/t/use-sccache-for-rust-compilation-cache/3228 . Currently tests are disabled due to https://github.com/mozilla/sccache/issues/460 .

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - not applicable.
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - non depend.
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Unp fixes
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/63649
updated_at: 2019-06-24 14:18:24
body:
  ##### Motivation for this change

  `unrar` was in the default build, making unp unfree. Also fixes the manpage (see commits)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @timor 
  @GrahamcOfBorg build unp


state: closed
title: cargo-edit: 0.3.2 -> 0.3.3
user_login: killercup
html_url: https://github.com/NixOS/nixpkgs/pull/63650
updated_at: 2019-06-22 13:45:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  upstream update that simplifies nix build

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zola: 0.7.0 -> 0.8.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/63651
updated_at: 2019-06-27 09:39:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [changelog](https://github.com/getzola/zola/blob/master/CHANGELOG.md#080-2019-06-22)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update deepin packages
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63652
updated_at: 2019-06-22 21:04:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update Deepin Desktop Environment packages:

  - deepin.dde-calendar: 1.2.6 -> 1.2.10
  - deepin.dde-api: 3.18.3 -> 3.18.4.1
  - deepin.dde-daemon: 3.27.1 -> 3.27.2.5
  - deepin.dde-dock: 4.9.9 -> 4.10.3
  - deepin.dde-file-manager: 4.8.6.2 -> 4.8.6.4
  - deepin.dde-polkit-agent: 0.2.6 -> 0.2.10
  - deepin.dde-qt-dbus-factory: 1.1.1 -> 1.1.5
  - deepin.dde-session-ui: 4.9.6 -> 4.9.11
  - deepin.deepin-anything: 0.0.7 -> 0.1.0
  - deepin.deepin-desktop-base: 2019.04.24 -> 2019.06.19
  - deepin.deepin-desktop-schemas: 3.13.0 -> 3.13.6
  - deepin.deepin-gtk-theme: 17.10.10 -> 17.10.11
  - deepin.deepin-icon-theme: 15.12.69 -> 15.12.71
  - deepin.deepin-image-viewer: 1.3.13 -> 1.3.17
  - deepin.deepin-menu: 3.4.6 -> 3.4.8
  - deepin.deepin-movie-reborn: 3.2.22.1 -> 3.2.24
  - deepin.deepin-screenshot: 4.1.10 -> 4.2.1
  - deepin.deepin-terminal: 3.2.2.1 -> 3.2.6
  - deepin.dtkcore: 2.0.12.1 -> 2.0.14
  - deepin.dtkwidget: 2.0.12.3 -> 2.0.14
  - deepin.go-dbus-factory: 0.7.0 -> 0.9.0
  - deepin.go-gir-generator: 2.0.1 -> 2.0.2
  - deepin.qt5dxcb-plugin: 1.1.27 -> 1.2.2
  - deepin.qt5integration: 0.3.11 -> 0.3.12

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: Cargo build without cargoSha256, use Cargo.lock instead
user_login: nmattia
html_url: https://github.com/NixOS/nixpkgs/issues/63653
updated_at: 2019-06-22 14:14:28
body:
  ## Issue description

  I’ve been experimenting with a [new build platform][naersk] that doesn’t require specifying a `cargoSha256` but instead relies on the information contained in the `Cargo.lock`. There are some open issues, maybe someone here will have good solutions!

  (note: happy to move this to discourse if needed)

  The problems with the current rust platform (in particular with `cargoSha256`) is that it’s

  1. unergonomic: every single dependency update requires the developer to update the `cargoSha256`. This means tweaking the existing checksum, re-building, copying the new hash, etc. This becomes a huge mess when lots of developers are working on the same cargo project.
  1. not repeatable: if a developer forgets to update the hash, nix will use the old dependencies (nix store lookup by `sha256`) and in some cases the build may succeed nonetheless (think: security patch in a dependency, which doesn’t tinker with the crate’s interface). However a build on a different machine — where the vendored crates haven’t been cached yet — will result in a hash mismatch.

  ### How

  The idea is to leverage the “recently” added `builtins.fromTOML` to read the `Cargo.lock` in Nix directly and fetch all crates before the build even begins (I’ve done [something similar](https://github.com/nmattia/napalm) for npm). The lockfile looks something like this:

  ``` toml
  [[package]]
  name = "aho-corasick"
  version = "0.6.10"
  source = "registry+https://github.com/rust-lang/crates.io-index"
  dependencies = [
   "memchr 2.2.0 (registry+https://github.com/rust-lang/crates.io-index)",
  ]
  ...

  [metadata]
  "checksum aho-corasick 0.6.10 (registry+https://github.com/rust-lang/crates.io-index)" = "81ce3d38065e618af2d7b77e10c5ad9a069859b4be3c2250f674af3840d9c8a5"
  ```

  Quoting [naersk] (the POC for this new platform):

  ``` nix
      # XXX: the actual crate format is not documented but in practice is a
      # gzipped tar; we simply unpack it and introduce a ".cargo-checksum.json"
      # file that cargo itself uses to double check the sha256
  ```

  The corollary is that the lockfile contains all the information Nix needs in order to download dependencies (at least for crates coming from [crates.io], see below for git dependencies).

  ### Current status

  The POC works surprisingly well. Most libs build out of the box but there are some issues that worry me a bit.

  #### Libs that build

  * https://github.com/rust-lang/rustfmt
  * https://github.com/fastly/lucet
  * https://github.com/phiresky/ripgrep-all
  * https://github.com/rust-lang/rustlings
  * https://github.com/pingcap/talent-plan
  * https://github.com/target/

  (I basically went through the list of [trending rust repos](https://github.com/trending/rust))


  #### Missing

  * crate-level incrementality: currently all dependencies are built alongside the main crate. This is not _too bad_ (rustc is pretty fast) but [it could be improved](https://github.com/nmattia/naersk/blob/80820020f6dcff53a5f2847aa6a70d3a0d53f069/default.nix#L2).
  * [cargo doesn’t register checksums for git dependencies](https://github.com/rust-lang/cargo/issues/7059): this is a pretty nasty issue, because `fetchFromGitHub` and friends require a `sha256`. There are some workarounds:
    * use `builtins.fetchgit` ... which doesn’t require a `sha256`. The major drawbacks is that `fetchgit` will redownload the repo every hour and doesn’t support submodules. Moreover it’s somewhat ugly.
    * use `cargoSha256` for git deps ... which is somewhat work ergonomic than having a single `cargoSha256` for _all_ deps, but still not ideal
    * track git dependencies outside of cargo ... e.g. “vendor” the dependencies through nix. The major drawback is that — while it’s fairly easy to do source replacement in a `nix-build`/derivation — it’s a pain to make sure that `cargo` (in a dev’s terminal) uses the same dependencies. There are some workarounds that can be implemented in a nix-shell (`shellHook` setting `$CARGO_HOME` with custom config, or `shellHook` that symlinks the store paths in $PWD) but it’s still very, very suboptimal.

  CC @grahamc @basvandijk 

  [naersk]: https://github.com/nmattia/naersk
  [crates.io]: https://crates.io/


state: open
title: dotnet-sdk: 2.2.203 -> 2.2.300 (core 2.2.4 -> 2.2.5)
user_login: mtrsk
html_url: https://github.com/NixOS/nixpkgs/pull/63654
updated_at: 2019-06-22 14:33:43
body:
  ###### Motivation for this change
  Updating dotnet-sdk to 2.2.300 and core to 2.2.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: sequoia-tool: init at 0.9.0
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/63655
updated_at: 2019-07-15 18:40:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  A user-friendly PGP tool: https://sequoia-pgp.org/

  - The command-line program is actually called "sq" but the Rust package is called "sequoia-tool". I wasn't sure which to choose so I went with the one with the least chance of collision.
  - ~~I didn't manage to build it entirely on my laptop because it kept running out of memory / space, so if someone would like to test it locally, or trigger ofborg, I would really appreciate it ^^~~

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dua: init at 2.1.5
user_login: killercup
html_url: https://github.com/NixOS/nixpkgs/pull/63656
updated_at: 2019-07-03 11:15:10
body:
  > A tool to conveniently learn about the disk usage of directories, fast!

  Adds lock file that was missing from upstream repo.

  Adds myself to maintainers list.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add initial version of nice alternative to `du`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: conmon: 0.2.0 -> 0.3.0
user_login: saschagrunert
html_url: https://github.com/NixOS/nixpkgs/pull/63657
updated_at: 2019-06-23 13:58:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update common to the latest package

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: podman: 1.3.2 -> 1.4.2
user_login: saschagrunert
html_url: https://github.com/NixOS/nixpkgs/pull/63658
updated_at: 2019-07-04 18:24:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update podman to the latest version
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.hdbscan: fix build
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/63659
updated_at: 2019-06-25 15:33:29
body:
  ###### Motivation for this change
  Newer `hdbscan` came sooner than I was expecting. don't need the upstream patch anymore. Also seems to need `joblib`, added for the benefit of the py27 version, whose `scikitlearn` doesn't include it.

  ~Won't build until https://github.com/NixOS/nixpkgs/issues/63573 is fixed, hence draft.~
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: teamspeak_server: fix build
user_login: Gerschtli
html_url: https://github.com/NixOS/nixpkgs/pull/63660
updated_at: 2019-07-21 14:17:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update teamspeak_server

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: new: python-modules/tinytag at 1.2.2
user_login: deepfire
html_url: https://github.com/NixOS/nixpkgs/pull/63661
updated_at: 2019-06-23 16:11:31
body:
  ###### Motivation for this change
  Adds a python tagging library.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: syncthing: remote devices lost on reboot
user_login: smithtim
html_url: https://github.com/NixOS/nixpkgs/issues/63662
updated_at: 2019-06-30 12:29:24
body:
  ## Issue description

  All remote devices that I have added to syncthing disappear when I reboot my machine.

  ### Steps to reproduce

  Add a remote device to syncthing.  Reboot.  The remote device has disappeared from the syncthing GUI and is no longer synced.

  ### More information

  Syncthing config is stored in `/var/lib/syncthing/config.xml`.  This file includes a list of all remote devices that have been added.  Restarting syncthing with `systemctl restart syncthing` preserves the list of remote devices, as expected.  But rebooting the machine causes them to disappear from the file.

  ## Technical details

  - system: `"x86_64-linux"`
   - host os: `Linux 4.19.44, NixOS, 19.09pre180443.4dd5c93998d (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre180443.4dd5c93998d"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: protobuf: remove 3.4 and 3.5
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/63663
updated_at: 2019-06-23 15:06:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Unless I missed something, protobuf 3.4 and 3.5 are not used in nixpkgs anymore and can be removed.

  ###### Things done

  Remove protobuf 3.4 and 3.5.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rust: fix building in debug mode
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63666
updated_at: 2019-07-17 21:21:07
body:
  ###### Motivation for this change

  #56540 broke a few things regarding rust builds and did not have the intended effect:

  - bdd3c3fdcb11416d2e2ef459c2e28caa2235f0f3 intended to support debug builds, but passes an invalid `--debug` flag to `cargo build`
  - 60761e65ba38280ce19e1d7e3c4ffd883212a96c intended to make sense of cargo target directories, but breaks cargo.
    1. it deletes `$CARGO_TARGET_DIR/debug`, and symlinking/moving `$CARGO_TARGET_DIR/x86_64-unknown-linux-gnu/debug` to it, assuming they're redundant?
    2. this is an incorrect change, as cargo seems to produce and use both directories for different purposes? Each directory has its own lock file, which cargo attempts to use. When both lock files are symlinked to be the same thing, cargo will deadlock itself.
    3. this prevents `cargo test` from working, the only reason it happens to work now is because this step mangles the release directory, while the default `checkPhase` builds tests in debug mode. Changing `buildType` to `debug` or using `cargo test --release` instead will expose the deadlock.
    4. buildRustPackage provides `releaseDir` for this, anything that hard-codes target/release are messy hm...
        - messageformat=json stuff could maybe be used to find binary paths for packaging purposes instead? This is a a rather annoying and [long-standing](https://github.com/rust-lang/cargo/issues/3670) [limitation](https://github.com/rust-lang/cargo/issues/1924) of cargo.

  cc @illegalprime @Ericson2314

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
    - will try this soon, it might take a while..?
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Gitolite: Make directory readable for the group
user_login: bake
html_url: https://github.com/NixOS/nixpkgs/pull/63668
updated_at: 2019-07-13 10:24:18
body:
  ###### Motivation for this change

  Using a frontend like GitWeb or cgit together with Gitolite requires the HTTPD serving the UI and Gitolite sharing a group and [setting UMASK](https://nixos.org/nixos/options.html#services.gitolite.extragitoliterc) to [something like `0027`](https://gitolite.com/gitolite/rc.html#specific-variables). This however does not modify permissions on [Gitolites directory](https://nixos.org/nixos/options.html#services.gitolite.datadir) in which it stores repositories.

  Is this usecase common enough to change the permissions by default?

  ###### Things done

  Setting the directory permissions to allow users in the same group as Gitolite to read its directory. This should be enough if it is in an already readable directory like `/var/lib` or `/home`.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rambox-pro: 1.1.2 -> 1.1.4
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/63669
updated_at: 2019-06-22 20:27:57
body:
  ###### Motivation for this change
  Upgraded the rambox-pro package I previously created from 1.1.2 to 1.1.4 and added necessary changes to accomplish this.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: acpilight: fix build error
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63670
updated_at: 2019-06-24 23:52:40
body:
  ###### Motivation for this change

  `udevadm trigger` should not run as part of make install. The offending line is [Makefile#17](https://gitlab.com/wavexx/acpilight/blob/master/Makefile#L17), would a patch be more appropriate or is this change fine?

  The package doesn't seem to depend on udev beyond providing rules files, it seems like a recent systemd update broke this, [previously it was fine](https://hydra.nixos.org/job/nixpkgs/trunk/acpilight.x86_64-linux) but really shouldn't have been running that command anyway.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "python37Packages.aiorpcx: 0.17.0 -> 0.18.3"
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63671
updated_at: 2019-06-23 09:33:23
body:
  This reverts commit 299996bc38da10452680ce1d1e18ab5db07387b7.

  ###### Motivation for this change

  [electrum](https://hydra.nixos.org/job/nixpkgs/trunk/electrum.x86_64-linux) no longer builds as it has not yet released an update that supports version 0.18, and is the only package that depends on aiorpcx.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-inspect: init at 0.10.1
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/63672
updated_at: 2019-07-07 12:01:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Repo: https://github.com/mre/cargo-inspect

  This tool is similar to `cargo-expand` but also print the desugared code.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: codespell: init at 1.15.0
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63673
updated_at: 2019-07-17 18:32:48
body:
  ###### Motivation for this change
  With codespell it's easy to check the spelling of variables and comments in source code.
  Hint: Can easily be tried on nixpkgs (`./result/bin/codespell ~/clone/nixpkgs`)- I might open a PR fixing spelling mistakes in nixpkgs.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  `fetchPypi` is preferred for Python projects over `fetchFromGitHub` (or other repo fetchers) because it usually contains the same code but possibly less other unnecessary files for running the program (e.g. documentation), right?


state: closed
title: microcodeIntel: 20190514 -> 20190618
user_login: mweinelt
html_url: https://github.com/NixOS/nixpkgs/pull/63674
updated_at: 2019-06-22 22:50:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The upstream release tag (https://github.com/intel/Intel-Linux-Processor-Microcode-Data-Files/releases/tag/microcode-20190618) doesn't feature release notes, but e.g. Debian has a changelog entry that reads like this:

  ```
  intel-microcode (3.20190618.1) unstable; urgency=medium

    * New upstream microcode datafile 20190618
      + SECURITY UPDATE
        Implements MDS mitigation (RIDL, Fallout, Zombieload), INTEL-SA-00223
        CVE-2018-12126, CVE-2018-12127, CVE-2018-12130, CVE-2019-11091
        for Sandybridge server and Core-X processors
      + Updated Microcodes:
        sig 0x000206d6, pf_mask 0x6d, 2019-05-21, rev 0x061f, size 18432
        sig 0x000206d7, pf_mask 0x6d, 2019-05-21, rev 0x0718, size 19456
    * Add some missing (minor) changelog entries to 3.20190514.1
    * Reformat 3.20190514.1 changelog entry to match rest of changelog

   -- Henrique de Moraes Holschuh <hmh@debian.org>  Wed, 19 Jun 2019 09:05:54 -0300
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.dde-launcher: init at 4.6.13
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63675
updated_at: 2019-06-26 04:05:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [dde-launcher](https://github.com/linuxdeepin/dde-launcher), the launcher of Deepin Desktop Environment.

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: gst-plugins-good: Remove jack2 by default
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/pull/63677
updated_at: 2019-06-24 14:51:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This should be a simple typo introduced in https://github.com/NixOS/nixpkgs/pull/54398/commits/8d495e04c886939098358437f21becb1cbb0badd#diff-c366b8ce64df5be37708454f340e869eR72
  which created the enableJack flag but didn't remove the dependency from the previous line.

  /cc @nh2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jazzy: 0.9.6 -> 0.10.0
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/63678
updated_at: 2019-07-15 00:11:54
body:
  Also define passthru.updateScript.

  ###### Motivation for this change
  https://github.com/realm/jazzy/releases/tag/v0.10.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Nix package search shows wrong nix expression for Wego
user_login: cvoges12
html_url: https://github.com/NixOS/nixpkgs/issues/63679
updated_at: 2019-06-23 02:07:27
body:
  The [Nix package search](https://nixos.org/nixos/packages.html#wego) shows the wrong location in "nix expressions" for the package [Wego](https://github.com/NixOS/nixpkgs/blob/982b5ee26f079656875e299b772147217fcc09a2/pkgs/applications/misc/wego/default.nix). 

  The location shown on nixos.org is `lib/attrsets.nix` when the true nix expression is `pkgs/applications/misc/wego`. This should probably be replaced.


state: closed
title: buildGoPackage: keep string context
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/63680
updated_at: 2019-06-23 02:07:27
body:
  In Nix, each string has a context that it carries of where it
  originated. Some functions like filterAttrs modify the context of its
  args when doing comparisons. That is important because we use the
  string context of “name” to get where a derivation was defined. This
  causes some builtins like unsafeGetAttrPos to report incorrectly that
  the string was set in lib/attrsets.nix and reporting that as the
  source file. Using removeAttrs avoids this problem.

  Fixes #63679

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubecfg: 0.9.1 -> 0.12.0
user_login: groodt
html_url: https://github.com/NixOS/nixpkgs/pull/63681
updated_at: 2019-06-26 18:57:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update kubecfg: 0.9.1 -> 0.12.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skim: 0.6.4 -> 0.6.8
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/63682
updated_at: 2019-06-24 20:31:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  [changelog](https://github.com/lotabout/skim/blob/master/CHANGELOG.md#068-2019-06-23)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.camelcasemotion: init at 2019-06-06
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/63683
updated_at: 2019-06-23 12:02:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  A quite convenient vim plugin: https://github.com/bkad/camelcasemotion

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.tmux-complete-vim: init at 2019-05-13
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/63684
updated_at: 2019-06-23 11:59:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  A very nice to have vim plugin for Tmux users: https://github.com/wellle/tmux-complete.vim

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: documize-community: 2.5.1 -> 3.0.0
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63685
updated_at: 2019-06-23 23:43:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/documize/community/releases/tag/v3.0.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mlarchive2maildir: init at 0.0.6
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63686
updated_at: 2019-06-23 12:16:52
body:
  This adds mlarchive2maildir, a tool to import mail from (pipermail)
  archives into maildir.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: neomutt: remove mutt wrapper
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63687
updated_at: 2019-06-23 13:58:18
body:
  Since Oct 14, 2017 we warned users still executing `neomutt`
  through the `mutt` binary, so we can assume everybody read the notice,
  updated his config, and can drop the wrapper.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: systemd-timesyncd state directory issue
user_login: mweinelt
html_url: https://github.com/NixOS/nixpkgs/issues/63688
updated_at: 2019-06-24 11:22:31
body:
  ## Issue description

  After upgrading from 19.03 to unstable on aarch64 (RPI3B+) systemd-timesyncd would not start anymore through the systemd-timesyncd.service unit. Starting it manually still works.


  ```
  Jan 01 01:00:16 prusa systemd[1]: Starting Network Time Synchronization...
  Jan 01 01:00:16 prusa systemd[658]: systemd-timesyncd.service: Failed to set up special execution directory in /var/lib: Not a directory
  Jan 01 01:00:16 prusa systemd[658]: systemd-timesyncd.service: Failed at step STATE_DIRECTORY spawning /nix/store/1vsy3mgiaz1pdrdzk89ih4snivjpmkz7-systemd-242/lib/systemd/systemd-timesyncd: Not a directory
  Jan 01 01:00:16 prusa systemd[1]: systemd-timesyncd.service: Main process exited, code=exited, status=238/STATE_DIRECTORY
  Jan 01 01:00:16 prusa systemd[1]: systemd-timesyncd.service: Failed with result 'exit-code'.
  Jan 01 01:00:16 prusa systemd[1]: Failed to start Network Time Synchronization.
  ```

  @andir @flokli 

  ### Steps to reproduce

  No custom configuration, just rebuild with nixos-unstable on aarch64.

  ## Technical detail

  ```
  system: "aarch64-linux", multi-user?: yes, version: nix-env (Nix) 2.2.2, channels(root): "nixos-19.09pre183392.83ba5afcc96", nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos
  ```

  ```
  # systemctl cat systemd-timesyncd
  # /nix/store/1vsy3mgiaz1pdrdzk89ih4snivjpmkz7-systemd-242/example/systemd/system/systemd-timesyncd.service
  #  SPDX-License-Identifier: LGPL-2.1+
  #
  #  This file is part of systemd.
  #
  #  systemd is free software; you can redistribute it and/or modify it
  #  under the terms of the GNU Lesser General Public License as published by
  #  the Free Software Foundation; either version 2.1 of the License, or
  #  (at your option) any later version.

  [Unit]
  Description=Network Time Synchronization
  Documentation=man:systemd-timesyncd.service(8)
  ConditionCapability=CAP_SYS_TIME
  ConditionVirtualization=!container
  DefaultDependencies=no
  After=systemd-remount-fs.service systemd-sysusers.service
  Before=time-set.target sysinit.target shutdown.target
  Conflicts=shutdown.target
  Wants=time-set.target time-sync.target

  [Service]
  AmbientCapabilities=CAP_SYS_TIME
  CapabilityBoundingSet=CAP_SYS_TIME
  ExecStart=!!/nix/store/1vsy3mgiaz1pdrdzk89ih4snivjpmkz7-systemd-242/lib/systemd/systemd-timesyncd
  LockPersonality=yes
  MemoryDenyWriteExecute=yes
  NoNewPrivileges=yes
  PrivateDevices=yes
  PrivateTmp=yes
  ProtectControlGroups=yes
  ProtectHome=yes
  ProtectHostname=yes
  ProtectKernelModules=yes
  ProtectKernelTunables=yes
  ProtectSystem=strict
  Restart=always
  RestartSec=0
  RestrictAddressFamilies=AF_UNIX AF_INET AF_INET6
  RestrictNamespaces=yes
  RestrictRealtime=yes
  RestrictSUIDSGID=yes
  RuntimeDirectory=systemd/timesync
  StateDirectory=systemd/timesync
  SystemCallArchitectures=native
  SystemCallErrorNumber=EPERM
  SystemCallFilter=@system-service @clock
  Type=notify
  User=systemd-timesync
  WatchdogSec=3min

  [Install]
  WantedBy=sysinit.target
  Alias=dbus-org.freedesktop.timesync1.service

  # /nix/store/cvx4m6zr6vm7sq6l2s6ikz4h8k21m8j6-system-units/systemd-timesyncd.service.d/overrides.conf
  [Unit]
  X-Restart-Triggers=/nix/store/ynq5694asx2ls1xv3qzrmq6ix8sz7mfw-etc-timesyncd.conf

  [Service]
  Environment="LOCALE_ARCHIVE=/nix/store/c8vaf64n7df2ajm3am63ic31ndvscb8z-glibc-locales-2.27/lib/locale/locale-archive"
  Environment="PATH=/nix/store/45qngjhkziscswfjpzp4lsmaxlff7v2q-coreutils-8.31/bin:/nix/store/pg2ldnp4c5irh74p7kqpqxvnsnb6ips1-findutils-4.6.0/bin:/nix/store/ka8mp6n5j8s86w2rrc72q4iixxrczwnx-gnugrep-3.3/bin:/nix/store/4dw5y9i9vjcjvi14xd8dqp7dl2dr39pn-gnused-4.7/bin:/nix/store/1vsy3mgi>
  Environment="TZDIR=/nix/store/9pcv9z9vf4mj828d4hpkk7wmxf5hv7i7-tzdata-2019a/share/zoneinfo"
  ```


state: closed
title: asciidoctor: add rouge to dependencies
user_login: svalaskevicius
html_url: https://github.com/NixOS/nixpkgs/pull/63689
updated_at: 2019-06-26 20:38:34
body:
  ###### Motivation for this change

  Add syntax highlighting support via rouge.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: megasync: init at 4.1.1.0
user_login: michojel
html_url: https://github.com/NixOS/nixpkgs/pull/63690
updated_at: 2019-06-25 08:04:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: stack2nix build broken
user_login: jerith666
html_url: https://github.com/NixOS/nixpkgs/issues/63691
updated_at: 2019-06-24 05:01:36
body:
  bisected down to this range of revisions, so cc @peti, @Infinisil :

  ```
  *   61508b5d92d (refs/bisect/bad) Merge pull request #63001 from Infinisil/update/ghcHEAD
  |\  
  | * c382915e281 haskell.compiler.ghcHEAD: 20190115 -> 20190601
  * |   d9d29d9115b Merge pull request #63129 from jabranham/r-git2r
  |\ \  
  | * | 00b202e34a2 rPackages.git2r: Use system libgit2
  * | | b30b8f9f699 haskell-stack: fix the build some more
  * | | d7ddf86d2ae pandoc: disable test suite to fix the build
  |/ /  
  * | 21fdd139680 hackage-packages.nix: automatic Haskell package set update
  * | 9b68353c728 haskell-stack: add plenty of overrides to fix the build in LTS-13.x
  * | c2e65c0186e all-cabal-hashes: update to Hackage at 2019-06-14T00:22:02Z
  * | 4b3e62d561d hackage2nix: update list of broken builds
  * | a8a43ab9eda pandoc: update build dependency version for the new 2.7.3 release
  * | 9df1e349e8b (HEAD) hackage2nix: disable broken builds to fix Hydra evaluation
  * | af37181eedc haskell-ip: use version 1.5.x to fix the build
  * | e1126316d72 haskell-constraints-deriving: disable test suite to fix the build
  * | 0a253d7043e haskell-cryptol: update overrides for new sbv version
  * | caeebbb5f71 haskell-hslua-module-system: re-enable the build; it succeeds fine now
  * | 65ca963e0bf haskell-tasty-lua: disable test suite to fix the build
  * | 142b8b510c0 haskell-hlint: use the latest ghc-lib-parser version
  * | 09b0c366472 haskell-pandoc: update overrides for latest version
  * | bb5ef7900dc hackage-packages.nix: automatic Haskell package set update
  * | c0c65d67176 LTS Haskell 13.25
  o | b8c827c2660 (refs/bisect/good-b8c827c2660f9ee63b905ccddbfa794b410d86b9) fuse3: 3.5.0 -> 3.6.1
   /  
  o 0e1d92260a2 Merge pull request #62968 from bachp/gitlab-runner-11.11.2
  ```

  officially marked broken in 7a569985214906d618ed4b2ad4f0629842cc2ec2

  build fails with:

  ```
  Using Cabal-2.4.0.1 compiled by ghc-8.6
  Using compiler: ghc-8.6.5
  Using install prefix:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3
  Executables installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/bin
  Libraries installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/lib/ghc-8.6.5/x86_64-linux-ghc-8.6.5/stack2nix-0.2.3-BK4PWjh7xCKKuz2o4oiJjE
  Dynamic Libraries installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/lib/ghc-8.6.5/x86_64-linux-ghc-8.6.5
  Private executables installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/libexec/x86_64-linux-ghc-8.6.5/stack2nix-0.2.3
  Data files installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/share/x86_64-linux-ghc-8.6.5/stack2nix-0.2.3
  Documentation installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/share/doc/x86_64-linux-ghc-8.6.5/stack2nix-0.2.3
  Configuration files installed in:
  /nix/store/cswq5ig2f3jl9l2wcip3glfmsdfp28bf-stack2nix-0.2.3/etc
  No alex found
  Using ar found on system at:
  /nix/store/zizh5qzhcn4wzm06z99297ckalwrrpfk-binutils-2.31.1/bin/ar
  No c2hs found
  No cpphs found
  No doctest found
  Using gcc version 7.4.0 given by user at:
  /nix/store/7nvy9l5jcp1c6z6n96l1a5x1bwbvamqn-gcc-wrapper-7.4.0/bin/gcc
  Using ghc version 8.6.5 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/ghc
  Using ghc-pkg version 8.6.5 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/ghc-pkg
  No ghcjs found
  No ghcjs-pkg found
  No greencard found
  Using haddock version 2.22.0 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/haddock
  No happy found
  Using haskell-suite found on system at: haskell-suite-dummy-location
  Using haskell-suite-pkg found on system at: haskell-suite-pkg-dummy-location
  No hmake found
  Using hpc version 0.67 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/hpc
  Using hsc2hs version 0.68.5 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/hsc2hs
  No hscolour found
  No jhc found
  Using ld found on system at:
  /nix/store/q91askppkv5sph6swscbiy3r613cv7xg-binutils-wrapper-2.31.1/bin/ld
  No pkg-config found
  Using runghc version 8.6.5 found on system at:
  /nix/store/8b732fcj71j3mxp99g8104q9r88m5can-ghc-8.6.5/bin/runghc
  Using strip version 2.31 found on system at:
  /nix/store/zizh5qzhcn4wzm06z99297ckalwrrpfk-binutils-2.31.1/bin/strip
  Using tar found on system at:
  /nix/store/lxyzb5ijv5rijj6lfykhr5lhgcx3jlcw-gnutar-1.32/bin/tar
  No uhc found
  *** abort because of serious configure-time warning from Cabal
  builder for '/nix/store/pbmkhpcfpg8sdsfal5z0sm5yq1fg9qpl-stack2nix-0.2.3.drv' failed with exit code 1
  error: build of '/nix/store/pbmkhpcfpg8sdsfal5z0sm5yq1fg9qpl-stack2nix-0.2.3.drv' failed
  ```

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.46, NixOS, 19.09.git.553e9a7 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-16.03.1299.a8e0739"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Add python packages
user_login: Gerschtli
html_url: https://github.com/NixOS/nixpkgs/pull/63692
updated_at: 2019-07-07 20:56:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Added multiple python packages because of missing dependencies

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mkAliasOptionModule doesn't work if the newly created option doesn't have any definitions
user_login: j-piecuch
html_url: https://github.com/NixOS/nixpkgs/issues/63693
updated_at: 2019-06-23 21:18:11
body:
  ## Issue description

  The value of an option created using `mkAliasOptionModule` throws an error when evaluated if the newly created option doesn't have any definitions, even if the target option (the one that the newly created option is an alias of) is defined.

  ### Steps to reproduce

  test.nix:
  ```nix
  lib:

  with lib;

  let

    someModule = {
      options.foo = mkOption {
        type = types.bool;
        default = true;
      };
    };

  in

  evalModules {
    modules =
      [ someModule
        (mkAliasOptionModule [ "bar" ] [ "foo" ])
      ];
    check = false;
  }
  ```

  Let's load it in the REPL:
  ```
  nix-repl> :l <nixpkgs>
  Added 10082 variables.

  nix-repl> cfg = import ./test.nix lib

  nix-repl> cfg.config.foo
  true

  nix-repl> cfg.config.bar
  error: The option `bar' is used but not defined.
  ```

  ## Comments

  Here's what I think is going on:
  1. `mkAliasOptionModule` sets the `apply` attribute of the newly created option ([code](https://github.com/NixOS/nixpkgs/blob/80172aa0a6fad62d1371dee8318725573e7ac808/lib/modules.nix#L721)), so that when its value is computed, it evaluates to the value of the target option. So, in principle, evaluating `cfg.config.bar` should evaluate to **exactly** the same thing as `cfg.config.foo`.
  2. This doesn't happen, because the option `bar` does not have any definitions, and the `apply` attribute of the option isn't used ([code](https://github.com/NixOS/nixpkgs/blob/80172aa0a6fad62d1371dee8318725573e7ac808/lib/modules.nix#L330)).

  ~~A workaround would be for `mkAliasOptionModule` to define the newly created option, but give it a very high priority number (so that its priority is very low) and a value that throws an error when evaluated.~~
  The solution is to add an additional flag, `applyOptional`, that tells whether to apply the `apply` function to an optional value of the option.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.50, NixOS, 19.03.172883.1601f559e89 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(kuba): `"home-manager-19.03"`
   - channels(root): `"home-manager-19.03, nixos-19.03.172883.1601f559e89"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.hidapi: enable on darwin
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63695
updated_at: 2019-06-24 01:53:24
body:
  ###### Motivation for this change

  Package is cross-platform, and only uses libusb on linux and bsd.

  Is the `with` too messy?

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/testing: remove leftover of virtualisation.qemu.program
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/63696
updated_at: 2019-06-23 17:26:53
body:
  ###### Motivation for this change
  Fix #63299 

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix misuses of overrideCC
user_login: tobim
html_url: https://github.com/NixOS/nixpkgs/pull/63698
updated_at: 2019-06-23 22:21:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  As stated in https://github.com/NixOS/nixpkgs/issues/63293#issuecomment-504464858 `overrideCC` has to be called with a compiler from `buildPackages`, otherwise it breaks cross builds.

  ###### Things done
  - Replace uses of `overrideCC` with indirections to `gccXStdenv`.

  Note that I did very limited testing on this. I tried to build `apt` for `raspberryPi` but that fails at some perl library dependency.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hostapd: add noscan mode
user_login: NinjaTrappeur
html_url: https://github.com/NixOS/nixpkgs/pull/63699
updated_at: 2019-06-25 22:08:59
body:
  ###### Motivation for this change

  Hostapd is preventing us to create any overlapping BSSs in HT40+/- mode.

  Not being able to create those overlapping BSSs is basically
  preventing us to use 802.11n in any urban area where chances to
  overlap with another SSID are extremely high.

  ###### Things done

  Applies OpenWRT's noscan patch to hostapd and the relevant option to
  the hostapd module.

  This noscan patch adds a new `noscan` option allowing us to create
  some overlapping BSSs in HT40+/- mode.

  This option is disabled by default, we leave this up to the end
  user whether it should be enabled or not.

  Not being able to create those overlapping BSSs is basically
  preventing us to use 802.11n in any urban area where chances to
  overlap with another SSID are extremely high.

  The patch we are using is coming from the OpenWRT project. 

  This patch is applied to the default hostapd package in both OpenWRT and Archlinux.

  Note: The hostapd systemd service was disabled by default, I enabled it in a second commit. Hope not being too sneaky by doing that. If that's the case, don't hesitate to discard the second commit of this PR.

  ------


  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  --------------

  cc @flokli  @Phreedom @Ma27 @bobvanderlinden 


state: closed
title: Improve composability of mkShell
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63701
updated_at: 2019-06-24 08:48:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This improves the composability of `mkShell` in two ways: 

  * `shellHook` is now also composed. For example running the following expression with `nix-shell`:

  ```nix
  let
    pkgs = import <nixpkgs> {};

    shell1 = pkgs.mkShell {
      shellHook = ''
        echo shell1
      '';
    };

    shell2 = pkgs.mkShell {
      shellHook = ''
        echo shell2
      '';
    };

    shell3 = pkgs.mkShell {
      inputsFrom = [ shell1 shell2 ];
      shellHook = ''
        echo shell3
      '';
    };
  in shell3
  ```

  will now result in:

  ```
  shell2
  shell1
  shell3
  ```

  Note that packages in the front of `inputsFrom` have precedence over packages in the back. The outermost `mkShell` has precedence over all.

  * `mergeInputs` will now result in a more sensible order of `$PATH`. For example running following with `nix-shell`:

  ```nix
  let
    pkgs = import <nixpkgs> {};

    shell1 = pkgs.mkShell {
      buildInputs = [ pkgs.htop ];
    };

    shell2 = pkgs.mkShell {
      buildInputs = [ pkgs.hello ];
    };

    shell3 = pkgs.mkShell {
      inputsFrom = [ shell1 shell2 ];
      buildInputs = [ pkgs.tree ];
    };

  in shell3
  ```

  results in the following `$PATH`:

  ```
  $ echo $PATH
  ...
  /nix/store/yifq4bikf7m07160bpia7z48ciqddbfi-tree-1.8.0/bin:
  /nix/store/vhxqk81234ivqw1a7j200a1c69k8mywi-htop-2.2.0/bin:
  /nix/store/n9vm3m58y1n3rg3mlll17wanc9hln58k-hello-2.10/bin
  ...
  ```

  Previously the order was:

  ```
  /nix/store/n9vm3m58y1n3rg3mlll17wanc9hln58k-hello-2.10/bin
  /nix/store/vhxqk81234ivqw1a7j200a1c69k8mywi-htop-2.2.0/bin:
  /nix/store/yifq4bikf7m07160bpia7z48ciqddbfi-tree-1.8.0/bin:
  ```

  The new order makes more sense because it allows to override `$PATH` in the outermost `mkShell` and this order is consistent with the `shellHook` precedence.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ksonnet: remove package
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63702
updated_at: 2019-06-23 22:51:10
body:
  The team behind ksonnet was aquired by VMware, and they decided to end
  work on ksonnet:

  From https://blogs.vmware.com/cloudnative/2019/02/05/welcoming-heptio-open-source-projects-to-vmware:

  > Prior to the acquisition, Heptio had been shifting focus and resources
  > away from ksonnet; with the acquisition, we felt it was the right time
  > to rethink our investment in ksonnet. As a result, work on ksonnet will
  > end and the GitHub repositories will be archived. It’s extremely
  > difficult to step back from a project we have worked so hard on, but
  > we’re excited about our new ideas and vision for changing how developers
  > experience the Kubernetes and cloud native ecosystems.

  Since my initial addition of ksonnet in #43644, there were some new versions released, but no bumps appeared in nixpkgs, so I'm not sure somebody is actually using it - escpecially, with all development being ended now, we shouldn't ship this in nixpkgs IMHO.

  cc @colemickens @groodt 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: override systemd unit file execstart for bluetooth
user_login: acrylix
html_url: https://github.com/NixOS/nixpkgs/issues/63703
updated_at: 2019-06-24 06:08:16
body:
  ## Issue description

  hello, I'm trying to disable a bluez plugin by appending an extra option for the execStart command for `bluetooth.service`, what would be correct way to do this?

  I've tried something along the lines of:

  ```
    systemd.user.services.bluetooth = {
        description = "Bluetooth Service";
        serviceConfig = {
          Type = "dbus";
          BusName = "org.bluez";
          ExecStart = "${pkgs.bluez}/libexec/bluetooth/bluetoothd --noplugin=avrcp";
        };
        wantedBy = [ "bluetooth.target" ];
    };
  ```

  but after a rebuild & restart, content of `/etc/systemd/system/bluetooth.service` still stayed the same.

  on non-nix systems I am able to do this via `systemctl edit --full bluetooth.service` and edit the unit files directly, 

  any examples is appreciated!

  ## Technical details

  ```
  - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(michael): `"home-manager"`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: cmake: 3.13.4 -> 3.14.5
user_login: tobim
html_url: https://github.com/NixOS/nixpkgs/pull/63704
updated_at: 2019-07-03 06:50:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://cmake.org/cmake/help/v3.14/release/3.14.html

  ###### Things done
  Besides the updated version and Hash, I applied these changes to the expression:
  - Remove `with stdenv.lib` statement to make the origin of various functions clearer at their call sites.
  - Calculate `Major.Minor` from `version`, instead of the other way around. Hopefully making this package auto-updater friendly.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] Add intel-compute-runtime / Intel NEO driver stack
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/pull/63705
updated_at: 2019-07-02 12:14:23
body:
  ###### Motivation for this change
  Add `intel-compute-runtime` aka NEO, Intel's new open-source OpenCL GPGPU driver, which replaces Beignet for newer Intel processors.

  ## TO INSTALL
  ```
  hardware.opengl.extraPackages = with pkgs; [ intel-gmmlib intel-graphics-compiler intel-compute-runtime ];
  ```
  Note that this driver may be installed in parallel with `intel-ocl`. The latter provides and OpenCL device for the CPU, not the iGPU; relative performance may differ depending on workload.

  ## TODO:
  - ~~Update to later versions as much as possible~~
  - Finalise changes to `cc-wrapper.sh` and push them into `build-support` on `staging`
  - Find a way to automatically make gmmlib and IGC available to the driver instead of requiring the user to add them to `opengl.extraPackages`
  - ~~Assess if there is a saner way to package opencl-clang and its patches~~
  - Push .cmake patches upstream
  - ~~Prepare for opencl-clang_8 etc.~~
  - Would it make sense to put this under llvmPackages?
  - Check and fix tests where possible

  ## NOTES
  - The SPIRV-LLVM-Translator and OpenCL Clang projects have seperate branches and releases depending on LLVM version; I targeted LLVM 7 as that's what we have in release now. On my system I am running these patches rebased onto `release-19.03` and it appears to be working well.
  - ~~Built largely as per instructions here: https://github.com/JacekDanecki/compute-runtime/wiki/How-to-build-Neo-components-(system-llvm-clang-7)~~
  - cc-wrapper.sh has to be modified as the extra options it passes cause Clang to barf with errors about unrecognised flags when attempting to compile with `-x cl`

  ###### Things done
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @volth @OpenSourceAnarchist


state: closed
title: cargo-license: init at 0.2.0
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63706
updated_at: 2019-06-25 13:34:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Qt5 + Darwin fixes
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/63707
updated_at: 2019-06-24 00:37:55
body:
  Fixing qt5 and darwin building.

  - Support qt5.12
  - patch for missing qmlimportscanner in macdeployqt
  - add MetalKit

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Adopt "clear linux" patches?
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/63708
updated_at: 2019-07-03 19:43:13
body:
  Has anyone spent much time looking at Clear Linux and the patches they carry that get them such noticeable perf bumps?

  I'd be curious to see if we could (optionally) support some of those patches in nixpkgs?


state: closed
title: i3-layout-manager: init at unstable-2019-06-19
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63709
updated_at: 2019-07-09 21:31:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Simple script which is a wrapper for i3's layout persist functionality[1] that
  automates the manual editing of the exported layout JSON.

  [1] https://i3wm.org/docs/layout-saving.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rofi: 1.5.2 -> 1.5.3
user_login: IvanMalison
html_url: https://github.com/NixOS/nixpkgs/pull/63710
updated_at: 2019-06-24 02:03:14
body:
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Coc update
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/63711
updated_at: 2019-06-24 02:56:31
body:
  ###### Motivation for this change

  Following up on my suggestion, coc.nvim now returns a boolean when lsp requests fail, allowing to provide a backup solution .

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Use -isystem for dependency headers
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/63712
updated_at: 2019-06-24 15:45:43
body:
  ## Issue description

  Our usage of ```-I``` instead of ```-isystem``` can lead to weird errors like in https://github.com/NixOS/nixpkgs/issues/59929. Basically, we GCC emits warnings from headers included with ```-I```, but not with those included with ```-isystem```. We probably don't want to include warnings from headers included as dependencies. This should make logs a lot easier to read. Likewise, we should always use ```-iframework``` for framework directories.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: Mptcp kernel updates
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/63713
updated_at: 2019-06-25 10:00:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  0.94 was updated twice and 0.95 branch was released yesterday https://github.com/multipath-tcp/mptcp/releases/tag/v0.95

  I did some cleanup (added a shared structured config)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: xournalpp / xournal++ crashes at startup
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/63715
updated_at: 2019-06-24 08:01:52
body:
  ## Issue description

  Xournalpp crashes immediately.

  ### Steps to reproduce'

  I don't have KDE nor GNOME installed in case that matters.

  ```
  $ nix-build '<nixpkgs>' -A xournalpp
  $ result/bin/xournalpp


  ** (xournalpp:2719): WARNING **: 08:08:07.696: Failed to load "colornames.ini" (/home/jluttine/.xournalpp/colornames.ini): No such file or directory

  ALSA lib pcm_dsnoop.c:638:(snd_pcm_dsnoop_open) unable to open slave
  ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
  ALSA lib pcm.c:2636:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
  ALSA lib pcm.c:2636:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
  ALSA lib pcm.c:2636:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
  ALSA lib pcm_dmix.c:1108:(snd_pcm_dmix_open) unable to open slave
  Cannot connect to server socket err = No such file or directory
  Cannot connect to server request channel
  jack server is not running or cannot be started
  JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
  JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for -1, skipping unlock
  **
  Gtk:ERROR:gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Icon 'image-missing' not present in theme breeze (gtk-icon-theme-error-quark, 0)

  ** (xournalpp:2719): WARNING **: 08:08:07.827: [Crash Handler] Crashed with signal 6

  ** (xournalpp:2719): WARNING **: 08:08:07.832: [Crash Handler] Wrote crash log to: /home/jluttine/.xournalpp/errorlogs/errorlog.20190624-080807.log
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found
  sh: addr2line: command not found

  ** (xournalpp:2719): WARNING **: 08:08:07.942: Trying to emergency save the current open document…

  ** (xournalpp:2719): WARNING **: 08:08:07.943: Successfully saved document to "/home/jluttine/.xournalpp/emergencysave.xopp"

  ```



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  ]$ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.09.git.4ab1c14 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: open
title: nixos/mosquitto: make the tests run
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63716
updated_at: 2019-06-24 06:14:55
body:
  ###### Motivation for this change

  The test would randomly work/not-work due to races between subscribers and publishers.

  We are now using a hardcoded 5 second delay, which is *super* ugly but at least it works consistently here.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mosquitto: 1.6.2 -> 1.6.3
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63717
updated_at: 2019-06-25 01:28:48
body:
  ###### Motivation for this change

  https://github.com/eclipse/mosquitto/blob/master/ChangeLog.txt

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport "Improve composability of mkShell" to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63718
updated_at: 2019-07-01 12:37:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/63701 to `release-19.03`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: lib: add applyOptional field to options, use it in mkAliasOptionModule (fixes #63693)
user_login: j-piecuch
html_url: https://github.com/NixOS/nixpkgs/pull/63719
updated_at: 2019-06-24 07:43:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This fixes #63693.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Raspberry Pi 4 support
user_login: majewsky
html_url: https://github.com/NixOS/nixpkgs/issues/63720
updated_at: 2019-07-03 19:57:55
body:
  Raspberry Pi just announced immediate availability of the [Model 4](https://www.raspberrypi.org/blog/raspberry-pi-4-on-sale-now-from-35/). It will probably be some time until the aarch64 maintainers can get their hands on these, but I figured this can go into the backlog already.


state: closed
title: libressl: add openssl license
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63721
updated_at: 2019-07-01 13:52:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  LibreSSL is also licensed under the OpenSSL license. See:

  https://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/lib/libssl/LICENSE?rev=1.12&content-type=text/plain

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37Packages.black tests fail on Darwin
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/issues/63722
updated_at: 2019-06-24 15:06:56
body:
  ## Issue description

  `python37Packages.black` tests fails on Darwin in sandbox mode:


  ```
  running install tests
  ============================= test session starts ==============================
  platform darwin -- Python 3.7.3, pytest-4.2.1, py-1.7.0, pluggy-0.8.1
  rootdir: /private/var/folders/r2/zwnv7zsd4bd99mqkn4mhqxn800034l/T/nix-build-python3.7-black-19.3b0.drv-0/black-19.3b0, inifile:
  collected 91 items / 3 deselected / 88 selected

  tests/test_black.py ...FFFUnclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x1048d2860>
  Unclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x102a83208>
  Unclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x104fd1be0>
  F.FFFUnclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x105103908>
  Unclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x103536c88>
  Unclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x1035d92b0>
  Unclosed client session
  client_session: <aiohttp.client.ClientSession object at 0x1054311d0>
  FFFF..................................... [ 59%]
  ....................................                                     [100%]

  =================================== FAILURES ===================================
  ________________________ BlackTestCase.test_blackd_fast ________________________

  self = <test_black.BlackTestCase testMethod=test_blackd_fast>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_fast(self) -> None:
          with open(os.devnull, "w") as dn, redirect_stderr(dn):
              app = blackd.make_app()
  >           async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1508: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ________________ BlackTestCase.test_blackd_invalid_line_length _________________

  self = <test_black.BlackTestCase testMethod=test_blackd_invalid_line_length>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_invalid_line_length(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1531: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  _______________ BlackTestCase.test_blackd_invalid_python_variant _______________

  self = <test_black.BlackTestCase testMethod=test_blackd_invalid_python_variant>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_invalid_python_variant(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1439: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ____________________ BlackTestCase.test_blackd_line_length _____________________

  self = <test_black.BlackTestCase testMethod=test_blackd_line_length>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_line_length(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1521: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ________________________ BlackTestCase.test_blackd_pyi _________________________

  self = <test_black.BlackTestCase testMethod=test_blackd_pyi>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_pyi(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1463: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ___________________ BlackTestCase.test_blackd_python_variant ___________________

  self = <test_black.BlackTestCase testMethod=test_blackd_python_variant>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_python_variant(self) -> None:
          app = blackd.make_app()
          code = (
              "def f(\n"
              "    and_has_a_bunch_of,\n"
              "    very_long_arguments_too,\n"
              "    and_lots_of_them_as_well_lol,\n"
              "    **and_very_long_keyword_arguments\n"
              "):\n"
              "    pass\n"
          )
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1484: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ______________ BlackTestCase.test_blackd_request_needs_formatting ______________

  self = <test_black.BlackTestCase testMethod=test_blackd_request_needs_formatting>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_request_needs_formatting(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1387: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  _________________ BlackTestCase.test_blackd_request_no_change __________________

  self = <test_black.BlackTestCase testMethod=test_blackd_request_no_change>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_request_no_change(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1397: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ________________ BlackTestCase.test_blackd_request_syntax_error ________________

  self = <test_black.BlackTestCase testMethod=test_blackd_request_syntax_error>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_request_syntax_error(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1406: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  _________________ BlackTestCase.test_blackd_supported_version __________________

  self = <test_black.BlackTestCase testMethod=test_blackd_supported_version>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_supported_version(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1429: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  ________________ BlackTestCase.test_blackd_unsupported_version _________________

  self = <test_black.BlackTestCase testMethod=test_blackd_unsupported_version>

      @unittest.skipUnless(has_blackd_deps, "blackd's dependencies are not installed")
      @async_test
      async def test_blackd_unsupported_version(self) -> None:
          app = blackd.make_app()
  >       async with TestClient(TestServer(app)) as client:

  tests/test_black.py:1419: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:392: in __aenter__
      await self.start_server()
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:253: in start_server
      await self._server.start_server(loop=self._loop)
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:105: in start_server
      _sock = get_port_socket(self.host, self.port)
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

  host = '127.0.0.1', port = 0

      def get_port_socket(host: str, port: int) -> socket.socket:
          s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
  >       s.bind((host, port))
  E       PermissionError: [Errno 1] Operation not permitted

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:65: PermissionError
  =============================== warnings summary ===============================
  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:194
    /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:194: PytestWarning: cannot collect test class 'TestServer' because it has a __init__ constructor
      class TestServer(BaseTestServer):

  /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:226
    /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/test_utils.py:226: PytestWarning: cannot collect test class 'TestClient' because it has a __init__ constructor
      class TestClient:

  tests/test_black.py::BlackTestCase::test_blackd_fast
  tests/test_black.py::BlackTestCase::test_blackd_invalid_line_length
  tests/test_black.py::BlackTestCase::test_blackd_invalid_python_variant
  tests/test_black.py::BlackTestCase::test_blackd_line_length
  tests/test_black.py::BlackTestCase::test_blackd_main
  tests/test_black.py::BlackTestCase::test_blackd_pyi
  tests/test_black.py::BlackTestCase::test_blackd_python_variant
  tests/test_black.py::BlackTestCase::test_blackd_request_needs_formatting
  tests/test_black.py::BlackTestCase::test_blackd_request_no_change
  tests/test_black.py::BlackTestCase::test_blackd_request_syntax_error
  tests/test_black.py::BlackTestCase::test_blackd_supported_version
  tests/test_black.py::BlackTestCase::test_blackd_unsupported_version
    /nix/store/rbjvv2hi1mdi4fx49ddf6jzpvq829gpq-python3.7-aiohttp-3.5.4/lib/python3.7/site-packages/aiohttp/web_urldispatcher.py:151: DeprecationWarning: Bare functions are deprecated, use async ones
      "use async ones", DeprecationWarning)

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  ======= 11 failed, 77 passed, 3 deselected, 14 warnings in 12.68 seconds =======
  builder for '/nix/store/9f7x4jwhx3g881nx5yik6f97ly8d87jb-python3.7-black-19.3b0.drv' failed with exit code 1
  error: build of '/nix/store/9f7x4jwhx3g881nx5yik6f97ly8d87jb-python3.7-black-19.3b0.drv' failed
  ```

  ### Steps to reproduce

  `nix-shell - p python37Packages.black`

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.6.0, macOS 10.14.5`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(smaret): `"nixpkgs-19.03pre170546.0f43790d2ce"`
   - nixpkgs: `/nix/store/lgd8al5g6wd3hscir5bwskx1gzsvmirg-master.tar.gz`


