# issues

state: open
title: mariadb: duplicating binary files in client and server packages
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/issues/63723
updated_at: 2019-07-21 08:48:30
body:
  ## Issue description
  https://github.com/NixOS/nixpkgs/commit/1db3a91bab24e2e6ec3fa78de5be8b6c938cb0c0#commitcomment-34044268
  mysql_upgrade requires availability of mysqlcheck, which is in the package mariadb.client
  In other operating systems they are separated - mysql_upgrade -> mariadb.server, mysqlcheck -> mariadb.client. And when the server is installed the client is automatically installed.


state: open
title: terminus-font: enable characters variants switching
user_login: caadar
html_url: https://github.com/NixOS/nixpkgs/pull/63724
updated_at: 2019-06-24 09:08:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Terminus font upstream provides patchset for characters variants (see homepage at http://terminus-font.sourceforge.net#variants).

  Some alternative variants so common, that e.g. centered tilde is mentioned as "perhaps should be the default".

  This PR adds useful ability to switch alternative terminus font variants by Nix.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: crystal: init at 0.29.0
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63725
updated_at: 2019-06-26 02:51:28
body:
  ###### Motivation for this change

  Supersedes #63427
  Fixes #63039

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/lidarr: allow specifying package
user_login: davidtwco
html_url: https://github.com/NixOS/nixpkgs/pull/63726
updated_at: 2019-06-28 08:29:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Allows users of `services.lidarr` to specify the package that is used with `services.lidarr.package`. The current version of `lidarr` in the 19.03 channel is too old to fetch from the lidarr.audio API, so this provides users an easy way to change to the unstable package if they wish.

  cc @etu

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport "cargo-license: init at 0.2.0" to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63728
updated_at: 2019-06-26 13:53:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/63706 to `release-19.03`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: PythonPackages: add rig + sentinel
user_login: timor
html_url: https://github.com/NixOS/nixpkgs/pull/63729
updated_at: 2019-06-25 07:17:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Rig is a python module used in Neural Network research.  Sentinel is a dependency.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: buildRustPackage uses different compilation options for tests
user_login: nmattia
html_url: https://github.com/NixOS/nixpkgs/issues/63730
updated_at: 2019-06-24 19:44:47
body:
  ## Issue description

  https://github.com/NixOS/nixpkgs/blob/57b1f5386289dbe4be14ac8960687c12334d6dfb/pkgs/build-support/rust/default.nix#L105-L106

  https://github.com/NixOS/nixpkgs/blob/57b1f5386289dbe4be14ac8960687c12334d6dfb/pkgs/build-support/rust/default.nix#L124

  By defaul buildRustPackage runs
   * cargo build --release
   * cargo test
  Which means that
   1. All libraries must be recompiled for the tests to run
   2. The code being tested has different compilation options

  It'd be nicer to use `cargo test --${buildType}`


state: closed
title: LP and optimization packages
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/63731
updated_at: 2019-06-24 13:24:54
body:
  ###### Motivation for this change

  Fallout from ICFPC 2019 ;)

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I'll merge after tests pass.


state: closed
title: pythonPackages.black: fix tests in sandbox mode on Darwin
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/pull/63733
updated_at: 2019-06-24 18:10:45
body:
  ###### Motivation for this change

  Fixes #63722

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: wpsoffice needs update
user_login: gyren
html_url: https://github.com/NixOS/nixpkgs/issues/63736
updated_at: 2019-07-03 13:48:55
body:
  Current version of wpsoffice in nixpkgs is 10.1.0.5672 while the latest release is 11.1.0.8392 , and the old version package isn't available from official website.

  The latest resource could be found [here](http://wps-community.org/downloads). Does anybody update this package?


state: open
title: vlang: init at 0.1.15
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/pull/63738
updated_at: 2019-07-18 00:13:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  V is an interesting new language, might as well have a package for it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plata-theme: 0.8.3 -> 0.8.6
user_login: tadfisher
html_url: https://github.com/NixOS/nixpkgs/pull/63739
updated_at: 2019-07-02 20:34:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `plata-theme` to 0.8.6.

  Reintroduce the `mateSupport` option, which requires `mate.marco` and `gtk3` for building. This defaults to `true` to mirror the upstream defaults.

  Replace `gnome2.glib` argument with `glib` to fix evaluation when `allowAliases = false`, letting `r-ryantm` update the package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: paraview fetch fails: git-lfs
user_login: dylex
html_url: https://github.com/NixOS/nixpkgs/issues/63740
updated_at: 2019-06-25 14:41:35
body:
  ## Issue description

  Trying to build paraview fails on fetch during submodule vtk-m of submodule VTK, which for some reason tries to run git-lfs. (Maybe something to do with https://gitlab.kitware.com/vtk/vtk-m/blob/master/.gitattributes ?)  Since this happens during fetch, just adding a dep on git-lfs is insufficient.

  ### Steps to reproduce

  ```
  nix-build -A paraview
  ...
  Submodule 'VTK-m' (https://gitlab.kitware.com/vtk/vtk-m.git) registered for path 'ThirdParty/vtkm/vtk-m'
  Initialized empty Git repository in /mnt/home/sw/nix/store/0ai3rsy2158q2jp6sp0c8l7z6xz1jbj4-source/VTK/ThirdParty/vtkm/vtk-m/.git/
  remote: Enumerating objects: 52877, done.
  remote: Counting objects: 100% (52877/52877), done.
  remote: Compressing objects: 100% (15294/15294), done.
  remote: Total 52877 (delta 41556), reused 45937 (delta 37500)
  Receiving objects: 100% (52877/52877), 16.86 MiB | 15.16 MiB/s, done.
  Resolving deltas: 100% (41556/41556), done.
  From https://gitlab.kitware.com/vtk/vtk-m
   * [new branch]      hooks      -> origin/hooks
   * [new branch]      master     -> origin/master
   * [new tag]         v1.0.0     -> v1.0.0
   * [new tag]         v1.1.0     -> v1.1.0
   * [new tag]         v1.2.0     -> v1.2.0
   * [new tag]         v1.3.0     -> v1.3.0
  git-lfs filter-process: git-lfs: command not found
  fatal: the remote end hung up unexpectedly
  Unable to checkout a891e6d90a9f07a08ef4187a659c1f25c353668d from https://gitlab.kitware.com/vtk/vtk-m.git.
  ```


state: open
title: rtl8723de
user_login: rndd-AK
html_url: https://github.com/NixOS/nixpkgs/issues/63741
updated_at: 2019-06-26 03:41:46
body:
  ## wifi is dead

  I really apologies is this is a dumb issue. But during two weeks I've tried to set up this wifi driver https://github.com/smlinux/rtl8723de

  ### Steps to reproduce

  here is my configuration.nix     https://github.com/rndd-AK/configs/tree/master/nixos

  ## Technical details

  [rndd@core:~]$ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.11, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96"`
   - channels(rndd): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: journalwatch: fix pytest checks
user_login: florianjacob
html_url: https://github.com/NixOS/nixpkgs/pull/63742
updated_at: 2019-06-26 19:49:40
body:
  (cherry picked from commit ee20ba83144551497fcecedca277f5de32e81c0c)

  Reason: The more strict dependency handling of buildPythonPackage in
  19.03 uncovered the error of having pytest as buildInput instead of
  checkInput, which leads to a broken package on 19.03.

  (Backport of relevant commit from #59424)


state: closed
title: gildas: 20190601_b -> 20190601_c
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/pull/63743
updated_at: 2019-07-02 09:07:33
body:
  ###### Motivation for this change

  Update gildas to the latest upstream.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-protobuf: 2018-01-04 -> 1.3.1
user_login: q3k
html_url: https://github.com/NixOS/nixpkgs/pull/63744
updated_at: 2019-06-25 20:00:03
body:
  ###### Motivation for this change

  Update to officially released, new version.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rust-bindgen: 0.49.0 -> 0.49.2
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63745
updated_at: 2019-06-25 14:59:27
body:
  ###### Motivation for this change

  Update fixes a checkPhase test on darwin.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-expand: fix darwin build
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63746
updated_at: 2019-06-25 14:59:02
body:
  ###### Motivation for this change

  [Fix link error on darwin](https://hydra.nixos.org/build/94791128).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: acpilight: 1.1 -> 1.2
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63747
updated_at: 2019-06-25 14:06:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://gitlab.com/wavexx/acpilight/-/tags/v1.2

  Just a few little changes including fixing the udev rules.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: munin: Use `outPath` for packages in `makeFlags`
user_login: maljub01
html_url: https://github.com/NixOS/nixpkgs/pull/63748
updated_at: 2019-06-24 22:59:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  With this change, evaluating the `makeFlags` attribute does not result in building the referenced packages.

  This makes it possible for users to override `buildInputs` and remove inputs they don't want without having to also make a modified copy of the `makeFlags` attribute.

  An example use case is to remove the `jre` dependency.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-tools: 2019.1.1 -> 2019.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63749
updated_at: 2019-06-25 19:17:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog https://staticcheck.io/changes/2019.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages.timescaledb: 1.3.1 -> 1.3.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63750
updated_at: 2019-06-27 02:29:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/timescale/timescaledb/releases/tag/1.3.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gst-launch-1.0 prints printf usage on run
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/63751
updated_at: 2019-07-16 08:54:55
body:
  ## Issue description

  On Ubuntu:

  ```
  NIX_PATH=nixpkgs=https://github.com/NixOS/nixpkgs/archive/426028047db79f1ec567a0f60dcebc0b8ef1ddab.tar.gz nix-shell -p gst_all_1.gstreamer --run 'gst-launch-1.0 --version'
  printf: usage: printf [-v var] format [arguments]
  gst-launch-1.0 version 1.16.0
  GStreamer 1.16.0
  Unknown package origin
  ```

  Why `printf: usage: printf [-v var] format [arguments]`?

  It seems the wrapper is wrong somehow.

  Contents:

  ```
  #! /nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/bash -e
  export GST_PLUGIN_SYSTEM_PATH=$GST_PLUGIN_SYSTEM_PATH${GST_PLUGIN_SYSTEM_PATH:+:}$(unset _tmp; for profile in $NIX_PROFILES; do _tmp=$profile/lib/gstreamer-1.0${_tmp:+:}$_tmp; done; printf $_tmp)
  exec -a "$0" "/nix/store/l94mb3cy5scyxvrhn04039l2yn183zbb-gstreamer-1.16.0-dev/bin/.gst-launch-1.0-wrapped"  "${extraFlagsArray[@]}" "$@"
  ```

  Perhaps in `printf $_tmp`, `$_tmp` doesn't exist?

  ```
  $ bash -x /nix/store/l94mb3cy5scyxvrhn04039l2yn183zbb-gstreamer-1.16.0-dev/bin/gst-launch-1.0 
  ++ unset _tmp
  ++ printf
  printf: usage: printf [-v var] format [arguments]
  + export GST_PLUGIN_SYSTEM_PATH=
  + GST_PLUGIN_SYSTEM_PATH=
  + exec -a /nix/store/l94mb3cy5scyxvrhn04039l2yn183zbb-gstreamer-1.16.0-dev/bin/gst-launch-1.0 /nix/store/l94mb3cy5scyxvrhn04039l2yn183zbb-gstreamer-1.16.0-dev/bin/.gst-launch-1.0-wrapped
  ```

  CC @jtojnar 


state: closed
title: nixos/cgit: fix config example
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/63752
updated_at: 2019-06-26 17:59:40
body:
  ###### Motivation for this change

  The order of the keys matters: `scan-path` must be the last key for other settings to be taken into account.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: lesspass: init at 8.0.1
user_login: jasoncarr0
html_url: https://github.com/NixOS/nixpkgs/pull/63753
updated_at: 2019-06-25 23:30:53
body:
  ###### Motivation for this change

  Adding LessPass CLI tool

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: DNS: regular problems again (unknown/captive APs)
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/63754
updated_at: 2019-07-05 21:17:56
body:
  ## Issue description
  I just can't seem to escape network/dns oddities in my NixOS laptop. I don't know exactly what's going on, so I'm going to try to coherently dump what I know and think is relevant:

  0. I use NetworkManager.

  1. I started traveling two weeks ago. I noticed that my NixOS box was virtually unusable on most wifi networks I connected to.

  2. Sometimes *nothing* would work - couldn't trigger a captive portal (I know neverssl.com to trigger an http redirect), couldn't hit DNS on 1.1.1.1/8.8.8.8, etc.

  3. Mostly noticed that DNS would work JUST FINE when trying `dig @{router_ip} somehost.com` 

  4. Noticed that basically all of my problems would go away if I merely replaced the contents of /etc/resolv.conf to point at the router.

  5. I disabled `systemd-resolved` in my nixos config and basically all of these problems disappeared.

  BUT, now we're back to the original issue, somehow, sort of? The usual suspect (restart NSCD) has not helped, but I keep finding myself in this case:

  1. I have Firefox open, everything seems to be more or less working. I hadn't tried Github, but gmail, mozilla's bugtracker, riot, all worked fine. They weren't pre-existing tabs either, I opened them AFTER connecting to this current wifi network.  (It's also unlikely they were cached, this was a completely clean session/boot after having been in Windows)

  2. I can't `git pull` from github. Flat out can't, I get: `ssh: Could not resolve hostname github.com: Name or service not known`

  3. `nmtui` -> disconnect -> connect (same network)

  4. `git pull` works just fine

  I can't think of anything I'm doing that is abnormal. Does anyone have any debugging tips. I can live with this (weird dns issues -> check systemd-resolved OR check nscd OR try reconnecting == 100% unblock rate), but it's not ideal.

  ## Questions

  1. Is `nm` + `systemd-resolved` a supported configuration, upstream? In NixOS?

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: freeciv_gtk: use gtk3
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/63755
updated_at: 2019-06-25 07:50:09
body:
  ##### Motivation for this change

  Switching from GTK2 to GTK3.

  * Improves the zoom handling on Linux/Wayland.
  * Fixes a segfault on MacOS.
  * Looks nicer (subjective).

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rpc.statd runs as root - it shouldn't
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/63756
updated_at: 2019-06-25 02:41:11
body:
  ## Issue description

  Because ```/var/lib/nfs``` is owned by ```root```, ```rpc.statd``` doesn't drop privileges on start.

  ### Steps to reproduce

  we should probably do what redhat does:

  1. Create a "rpcuser"
  2. Use a systemd-tmpfiles fragment to set ownership of ```/var/lib/nfs``` to our newly created user


state: closed
title: terraform_0_12: 0.12.2 -> 0.12.3
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63757
updated_at: 2019-06-25 14:33:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/hashicorp/terraform/releases/tag/v0.12.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vale: 1.4.2 -> 1.4.3
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63758
updated_at: 2019-06-25 11:14:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changes: https://github.com/errata-ai/vale/compare/v1.4.2...v1.4.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rls: fix darwin build
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/63759
updated_at: 2019-06-25 03:42:41
body:
  ##### Motivation for this change

  [Fixes broken darwin builds](https://hydra.nixos.org/build/94805508).

  caveat: I'm not really sure why `-C rpath` isn't needed on Linux, `rustlib/` is just magically getting added to rpath on linux but not on darwin?

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: freeciv_qt: init at 2.6.0
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63760
updated_at: 2019-06-26 02:50:45
body:
  ### Motivation for this change

  FreeCiv has a nice Qt5 frontend - let's support that.

  A few other bits:

  1. Move from gtk2 to gtk3 for the GTK client
  2. Use system lua instead of building it each time
  3. Upstream has moved to github from sourceforge
  4. name -> pname

  Cc: @nbp

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: franz: use wrapGAppsHook
user_login: contrun
html_url: https://github.com/NixOS/nixpkgs/pull/63761
updated_at: 2019-07-04 10:20:44
body:
  I encountered crashes while opening the file selection dialog. 

  ```
  (franz:11597): GLib-GIO-ERROR **: 14:08:20.102: No GSettings schemas are installed on the system
  [1]    11597 trace trap  franz
  ```

  This error is also presented in various other gtk applications (e.g. https://github.com/NixOS/nixpkgs/issues/45286). I used the same trick to fix this error.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rust: fix rust build-support debug build type
user_login: AtkinsChang
html_url: https://github.com/NixOS/nixpkgs/pull/63762
updated_at: 2019-07-17 08:49:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  `buildType` introduced in #56540 is not working because there is no `--debug` options for cargo.

  According to cargo:
  ```
  Compilation can be configured via the use of profiles which are configured in
  the manifest. The default profile for this command is `dev`, but passing
  the --release flag will use the `release` profile instead.
  ```
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: prometheus-node-exporter: 0.17.0 -> 0.18.1; set version information
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/63763
updated_at: 2019-06-25 07:33:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package update.

  Note there are breaking changes, documented in the [upstream release notes][].

  The version information has more fields, which the push gateway sets fully: https://github.com/NixOS/nixpkgs/blob/e478e6bdff2f8de59ecebd5e3377d03d5150e8a0/pkgs/servers/monitoring/prometheus/pushgateway.nix#L22-L26

  I didn't think the dummy values contributed much, so omitted them.

  [upstream release notes]: https://github.com/prometheus/node_exporter/releases/tag/v0.18.0


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fix haskellPackages.c2hsc tests: Cannot find executable '/usr/bin/gcc'
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/63764
updated_at: 2019-07-04 18:43:16
body:
  ## Issue description

  on nixos-unstable, all tests fail with the same error

  ```

    ./Data/C2Hsc.hs:76:21:
    126) sanity check processes smoke.h
         uncaught exception: ErrorCall
         Cannot find executable '/usr/bin/gcc'
         CallStack (from HasCallStack):
           error, called at ./Data/C2Hsc.hs:76:21 in c2hsc-0.7.1-3JuJhZH6Z289AkCUwvWCmG:Data.C2Hsc

    To rerun use: --match "/sanity check/processes smoke.h/"

  Randomized with seed 1538989878

  Finished in 0.0204 seconds
  126 examples, 126 failures
  Test suite test: FAIL
  Test suite logged to: dist/test/c2hsc-0.7.1-test.log
  0 of 1 test suites (0 of 1 test cases) passed.
  note: keeping build directory '/tmp/nix-build-c2hsc-0.7.1.drv-1'
  builder for '/nix/store/48scdj7crhfipy3v20cw9jc3qc9fxlrd-c2hsc-0.7.1.drv' failed with exit code 1
  cannot build derivation '/nix/store/n5ybp0q7fxkpvaq1jvxcrb2aliifd69q-ghc-8.6.5-with-packages.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/n5ybp0q7fxkpvaq1jvxcrb2aliifd69q-ghc-8.6.5-with-packages.drv' failed
  ```

  ### Steps to reproduce
  `nix build haskellPackages.c2hsc`


  ## Technical details
   current unstable


state: open
title: On unstable channel GRUB failed with ZFS root/boot
user_login: caadar
html_url: https://github.com/NixOS/nixpkgs/issues/63765
updated_at: 2019-07-19 14:03:53
body:
  ## Issue description

  GRUB can't boot system on ZFS root/boot partitions when on unstable channel.

  Boot info on console:

  ```GRUB loading…
  Welcome to GRUB!

  Attempting to decript master key…
  Enter passphrase for hd0,gpt3 (.....):
  Slot 0 opened
  error: symbol 'grub_file_filters' not found.
  Entering rescue mode…
  grub rescue>
  ```

  ### Steps to reproduce
  `````
  $ sudo nix-channel --list
  nixos https://nixos.org/channels/nixos-unstable
  $ sudo nixos-rebuild switch --update
  ...
  updating GRUB menu...
  ...
  Installing for i386-pc platform.
  You have a memory leak (not released memory pool):
  [0xebb8b0] dtree
  Internal error: Unreleased memory pool(s) found.
  ...
  Installation finished. No error reported.
  Warning: the new NixOS configuration has an init that is incompatible
  with the current configuration.
  The new configuration won't take effect until you reboot the system.
  warning: error(s) occurred while switching to the new configuration
  `````

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  `````
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/sy0n5vqn2l16hb3w0yjxkixbfdmsvabk-bash-interactive-4.4-p23-dev
  copying path '/nix/store/sy0n5vqn2l16hb3w0yjxkixbfdmsvabk-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.03.172783.a0b7a7913c4 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(scr): `""`
   - channels(root): `"nixos-19.09pre183392.83ba5afcc96"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  `````

  Some relevant settings:
  ```
  boot.loader.grub.enable = true;
  boot.loader.grub.version = 2;
  boot.loader.grub.enableCryptodisk = true;
  boot.loader.grub.copyKernels = true;
  boot.supportedFilesystems = [ "zfs" ];
  boot.zfs.enableUnstable = false;
  boot.zfs.forceImportAll = false;
  boot.zfs.forceImportRoot = false;
  ```
  EFI not used.

  ZFS version: stable or unstable
  GRUB: 2.02 (works), 2.04-rc1 (seems doesn't work)


state: open
title: Add configurationLimit to systemd-boot to prevent running out of disk…
user_login: domenkozar
html_url: https://github.com/NixOS/nixpkgs/pull/63766
updated_at: 2019-07-20 00:03:40
body:
  Backports 224a6562a4880195afa5c184e755b8ecaba41536 with backwards compatible default.

  I'd like to backport this as this is blocking me using stable, as my /boot runs out of disk space.

  The tricky bit of python is:

  ```python
  >>> list(range(0, 10))
  [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
  >>> list(range(0, 10)[-0:])
  [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
  >>> list(range(0, 10)[-9:])
  [1, 2, 3, 4, 5, 6, 7, 8, 9]

  ```


state: closed
title: flow: 0.101.0 -> 0.102.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63767
updated_at: 2019-06-25 15:31:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/facebook/flow/releases/tag/v0.102.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Hardening: Lynis recommendations
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63768
updated_at: 2019-07-03 20:19:58
body:
  ## Issue description

  I scanned my NixOS desktop with lynis.

  ```
    Lynis security scan details:

    Hardening index : 64 [############        ]
  ```

  We might want to implement the recommendations, by default or special profile. (maybe the hardening profile already has them? https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/profiles/hardened.nix)

  ```
  [+] Kernel Hardening
  ------------------------------------
    - Comparing sysctl key pairs with scan profile
      - fs.protected_hardlinks (exp: 1)                         [ OK ]
      - fs.protected_symlinks (exp: 1)                          [ OK ]
      - fs.suid_dumpable (exp: 0)                               [ OK ]
      - kernel.core_uses_pid (exp: 1)                           [ DIFFERENT ]
      - kernel.ctrl-alt-del (exp: 0)                            [ OK ]
      - kernel.dmesg_restrict (exp: 1)                          [ DIFFERENT ]
      - kernel.kptr_restrict (exp: 2)                           [ DIFFERENT ]
      - kernel.randomize_va_space (exp: 2)                      [ OK ]
      - kernel.sysrq (exp: 0)                                   [ DIFFERENT ]
      - kernel.yama.ptrace_scope (exp: 1 2 3)                   [ DIFFERENT ]
      - net.ipv4.conf.all.accept_redirects (exp: 0)             [ OK ]
      - net.ipv4.conf.all.accept_source_route (exp: 0)          [ OK ]
      - net.ipv4.conf.all.bootp_relay (exp: 0)                  [ OK ]
      - net.ipv4.conf.all.forwarding (exp: 0)                   [ DIFFERENT ]
      - net.ipv4.conf.all.log_martians (exp: 1)                 [ DIFFERENT ]
      - net.ipv4.conf.all.mc_forwarding (exp: 0)                [ OK ]
      - net.ipv4.conf.all.proxy_arp (exp: 0)                    [ OK ]
      - net.ipv4.conf.all.rp_filter (exp: 1)                    [ DIFFERENT ]
      - net.ipv4.conf.all.send_redirects (exp: 0)               [ DIFFERENT ]
      - net.ipv4.conf.default.accept_redirects (exp: 0)         [ DIFFERENT ]
      - net.ipv4.conf.default.accept_source_route (exp: 0)      [ DIFFERENT ]
      - net.ipv4.conf.default.log_martians (exp: 1)             [ DIFFERENT ]
      - net.ipv4.icmp_echo_ignore_broadcasts (exp: 1)           [ OK ]
      - net.ipv4.icmp_ignore_bogus_error_responses (exp: 1)     [ OK ]
      - net.ipv4.tcp_syncookies (exp: 1)                        [ OK ]
      - net.ipv4.tcp_timestamps (exp: 0 1)                      [ OK ]
      - net.ipv6.conf.all.accept_redirects (exp: 0)             [ DIFFERENT ]
      - net.ipv6.conf.all.accept_source_route (exp: 0)          [ OK ]
      - net.ipv6.conf.default.accept_redirects (exp: 0)         [ DIFFERENT ]
      - net.ipv6.conf.default.accept_source_route (exp: 0)      [ OK ]
  ```

  cc @joachifm 

  ### Steps to reproduce

  1. `nix run -f channel:nixos-unstable nixpkgs.lynis -c lynis audit system -Q`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.49, NixOS, 19.03.172866.4649b6ef4b5 (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172979.8634c3b6199, nixos-hardware, nixos-unstable-19.09pre183392.83ba5afcc96"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: bazelisk: 0.0.7 -> 0.0.8
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63769
updated_at: 2019-07-19 22:56:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matcha: 2019_05_09 -> 2019-06-22
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63770
updated_at: 2019-06-28 01:58:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to revision from 2019-06-22.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: gitlab-runner: 11.11.2 -> 12.0.2
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/63771
updated_at: 2019-07-12 17:43:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to latest version: https://gitlab.com/gitlab-org/gitlab-runner/blob/v12.0.0/CHANGELOG.md

  The major version bump is not a significant change from the runners perspective.

  The removed config options were not used in the nix module so there is no change to the service required.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-license: add meta.homepage
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/63772
updated_at: 2019-06-25 13:33:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes: https://github.com/NixOS/nixpkgs/pull/63706#discussion_r296755428

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: installation-device.nix: explain sshd usage, don't include clone-config
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63773
updated_at: 2019-06-29 13:43:21
body:
  ###### Motivation for this change
  The configuration used to build an installation medium isn't really
  suitable to be (re)used when building a real system.
      
  For example, it enables automatic root login without a password on the
  console, installs sshd, but prevents it from starting on boot.
      
  This can be very misleading when users try to derive their real system
  from it - they should use nixos-generate-config instead, as described in
  the manual.

  Also update the mingetty helpLine to describe the sshd setup.
    
  Closes #63576
  Closes #26776




  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fetchgit: set GIT_CONFIG_NOSYSTEM
user_login: dylex
html_url: https://github.com/NixOS/nixpkgs/issues/63774
updated_at: 2019-06-26 12:38:21
body:
  ## Issue description

  I ran into #63740 because fetchGit loads the system /etc/gitconfig, which didn't apply within the build environment. I'm proposing that nix-prefetch-git should set `GIT_CONFIG_NOSYSTEM` to ensure purity during fetching. Happy to supply a PR for this if this sounds reasonable.

  ### Steps to reproduce

  Put something bad in `/etc/gitconfig` (in my case it was the `[filter "lfs"]` that git-lfs installs) and try to build something that triggers this (in my case paraview).


state: open
title: qt5.12 base: Add patch to fix QTBUG-73459
user_login: bebehei
html_url: https://github.com/NixOS/nixpkgs/pull/63775
updated_at: 2019-07-17 08:48:34
body:
  ###### Motivation for this change

  QT 5.12 introduced a regression, where a QT program wouldn't show its
  tray icon, if there was no tray bar during program startup.

  It got fixed already in Qt 5.12.4, but according to #57042 and its
  sibling issues/PRs it doesn't seem to get fixed in near future for
  nixpkgs.

  The bug on the qt bugtracker: https://bugreports.qt.io/browse/QTBUG-73459

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: solc: 0.5.9 -> 0.5.10
user_login: sifmelcara
html_url: https://github.com/NixOS/nixpkgs/pull/63776
updated_at: 2019-07-05 00:12:44
body:
  Update the package.

  ##### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/undervolt: fixes ExecStart formatting
user_login: zmlww
html_url: https://github.com/NixOS/nixpkgs/pull/63777
updated_at: 2019-06-25 16:57:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This is my first PR, so not sure if I did some of the testing stuff correctly. `nix-shell -p nix-review --run "nix-review rev  undervolt-fix"` reported "Nothing changed" for example. 

  Anyway, with the current `ExecStart` string, the service will fail as `systemd` appears to parse the `Restart=no` option as an argument to `undervolt`. This PR fixes that. 


state: closed
title: pythonPackages.python-dotenv: 0.10.2 -> 0.10.3
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/63778
updated_at: 2019-07-09 07:05:16
body:
  ###### Motivation for this change
  Noticed this was broken while doing a nix-review of another package, so I updated it as well.

  ```
  builder for '/nix/store/g4i52p8cfidrlvvbwk8f80xir8r89njr-python3.7-python-dotenv-0.10.2.drv' failed with exit code 1; last 10 log lines:
        import pytest
    ModuleNotFoundError: No module named 'pytest'
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  $ nix path-info -Sh ./result/
  /nix/store/wwf9j8h34sfwlmk26ysf68aikd7yf3sj-python3.7-python-dotenv-0.10.3        99.8M


state: closed
title: gildas: Gtk-WARNING **: cannot open display
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/issues/63779
updated_at: 2019-07-02 16:01:29
body:
  ## Issue description

  On Darwin, `gildas-20190601_b` gives the following error at run time:
  ```
  Gtk-WARNING **: 20:55:03.666: cannot open display
  ``` 
  and then it hangs. The bug occurred for the first time around June, 19th. Older generations work fine. `gildas` version hasn't changed meanwhile, so I suspect a problem with one of it dependency (`gtk2-x11`?).

  ### Steps to reproduce

  ```
  % nix-shell -p gildas --run astro
  ```

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.6.0, macOS 10.14.5`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(smaret): `"nixpkgs-19.03pre170546.0f43790d2ce"`
   - nixpkgs: `/nix/store/yhgaaym5g59wf4b0dh453n9yw4i1xwhw-master.tar.gz`


state: open
title: foxdot: init at 0.7.30
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/63780
updated_at: 2019-06-25 19:44:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Just adding the package that I was badly missing.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.dde-session-ui: 4.9.11 -> 4.9.12
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63781
updated_at: 2019-07-05 03:00:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Update to version 4.9.12
  - Revise hard coded paths
  - Wrap binaries in `lib/deepin-daemon/`

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: home-manager: 2019-05-24 -> 2019-06-25
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63782
updated_at: 2019-06-25 20:46:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: allow overriding config of wrapped package
user_login: rycee
html_url: https://github.com/NixOS/nixpkgs/pull/63783
updated_at: 2019-07-17 08:15:24
body:
  ###### Motivation for this change

  By moving the `cfg` variable into the wrapper arguments we are able to override it for an already wrapped package. For example, with this change one can have

      pkgs.firefox-devedition-bin.override {
        cfg.enableBrowserpass = true;
      }

  which would otherwise be difficult to accomplish for packages having a complicated wrapped definition in `all-packages.nix`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: systemd: apply systemd-stable 242 backports
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63784
updated_at: 2019-07-01 08:41:23
body:
  from https://github.com/NixOS/systemd/pull/29
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana: 6.2.4 -> 6.2.5
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/63785
updated_at: 2019-06-27 10:08:28
body:
  ###### Motivation for this change
  [Latest patch release](https://github.com/grafana/grafana/releases/tag/v6.2.5) which includes two enhancements and some bug fixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (x86_64-linux & aarch64-linux)
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  **needs to be backported to 19.03**


state: closed
title: mysql: drop support for deprecated package & module option
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63786
updated_at: 2019-06-27 16:14:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  - According to https://en.wikipedia.org/wiki/MySQL#Release_history MySQL 5.5 is past end of life so we shouldn't ship it anymore.
  - The `services.mysql.rootPassword` option was never a good idea as it stores a password in the nix store. I'm straight up removing the option, as opposed to marking as deprecated, because this option completely breaks `services.mysql.ensureUsers` and `services.mysql.ensureDatabases`, which *many* NixOS services use now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ping @Izorkin @dasJ @dermetfan @thefloweringash @orivej 


state: closed
title: Release 19.03 with kexectools fixed [closes #56290]
user_login: dysinger
html_url: https://github.com/NixOS/nixpkgs/pull/63787
updated_at: 2019-06-27 20:52:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #56290 

  ###### Things done

  Compared master with release-19.03 when my armv7l-linux cross compilation failed on a aarch64 host.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: timetable: init at 1.0.6
user_login: Kjuvi
html_url: https://github.com/NixOS/nixpkgs/pull/63788
updated_at: 2019-06-26 21:33:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add more curated apps from Elementary OS app store for Pantheon Desktop. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ldh_client
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/63789
updated_at: 2019-07-17 08:09:43
body:
  ###### Motivation for this change
  ldh_client is a setup helper for https://librem.one currently the program is only useful for auto configuring their vpn connection

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/gdm: add autoSuspend option
user_login: chpatrick
html_url: https://github.com/NixOS/nixpkgs/pull/63790
updated_at: 2019-07-07 04:00:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Since GNOME 3.28 [GDM auto-suspends after 20 minutes](https://gitlab.gnome.org/GNOME/gnome-control-center/issues/22). This is a problem if you just want to turn on your computer so you can SSH into it later.

  ###### Things done
  This commit adds an option to `gdm` that lets you turn this off. I think the previous dconf profile was invalid since `DCONF_PROFILE=/etc/dconf/profile/gdm dconf dump` complained.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vapoursynth: wrap vspipe
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/63791
updated_at: 2019-07-04 08:55:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  See #58859 (`vspipe` included with VapourSynth doesn't work), but less complex and hopefully merged faster.

  Apparently you don't even need to make it a python module for it to be usable, as `nix-shell -p python3 vapoursynth` seems to work fine. (I *think* it didn't when I made the first PR, but I may be wrong)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vapoursynth-editor: init at R19
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/63792
updated_at: 2019-07-04 10:44:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  VapourSynth isn't very useful standalone without an editor.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffms: symlink vapoursynth plugin
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/63793
updated_at: 2019-07-04 08:29:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ffms [includes a vapoursynth plugin](https://github.com/FFMS/ffms2#avisynth-and-vapoursynth-plugin), this makes a symlink in the regular location.

  As an example, [Arch makes the same symlink in their package](https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/ffms2#n34).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vscode-with-extensions: add missing URL handler
user_login: hyperfekt
html_url: https://github.com/NixOS/nixpkgs/pull/63794
updated_at: 2019-06-26 02:34:32
body:
  The URL handler for VS Code was not copied from the generic version.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.dtkcore: explicitly set DTK_VERSION
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63795
updated_at: 2019-06-26 02:17:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The build system fails to detect the version to build, defaulting to the minimum one. To circumvent that it has to be explicitly set.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.dde-daemon: 3.27.2.5 -> 3.27.2.6; fix some hard coded paths
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63796
updated_at: 2019-06-28 02:02:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - deepin.dde-daemon: 3.27.2.5 -> 3.27.2.6
  - deepin.dde-daemon: fix some hard coded paths 

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.deepin-calculator: init at 1.0.11
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63797
updated_at: 2019-06-26 23:04:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [deepin-calculator](https://github.com/linuxdeepin/deepin-calculator), an easy to use calculator for Deepin Desktop Environment.

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: KiCad 5 Simulator Fails to run
user_login: letres
html_url: https://github.com/NixOS/nixpkgs/issues/63798
updated_at: 2019-06-30 23:17:32
body:
  ## Issue description
  The simulator is unable to run and when attempted it has a segmentation fault.
  (ngspice is installed)

  ### Steps to reproduce
  Start kicad from terminal
  Open Eeschema under tools select simulate.
  It opens a kicad error window that says 
  "libngspice.so.0.0.0: cannot open shared 
  object file: No such file or directory"
  Click okay then open Eeschema which has a Warning window open that says
  "Missing ngspice shared library"
  After clicking Ok it closes and the terminal only has Segmentation Fault showing after the call.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.6, NixOS, 19.03.172801.1a27474d474 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172801.1a27474d474"`
   - channels(emmer): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nixos/postgresql-wal-receiver: add module
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/63799
updated_at: 2019-07-21 19:35:46
body:
  #### Motivation for this change

  This PR adds a service module for `pg_receivewal`, a program which streams the transaction log from a PostgreSQL cluster into a local directory for PITR.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nitro_luks: init at 1.0.1
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/63800
updated_at: 2019-06-26 06:16:15
body:
  ###### Motivation for this change
  I want to unlock my computer with my nitrokey. I don't know if this works as I am not sure of an easy way to build and test this. is there an easy way to build a nixos vm with luks encrypted image?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: amiri: init at 0.111
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/63801
updated_at: 2019-06-27 09:13:24
body:
  Amiri is a classical Arabic typeface in Naskh style for typesetting books and
  other running text.

  Homepage: https://www.amirifont.org/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hostapd: fix hostapd noscan patch url.
user_login: NinjaTrappeur
html_url: https://github.com/NixOS/nixpkgs/pull/63802
updated_at: 2019-06-26 07:51:55
body:
  ###### Motivation for this change

  Something somehow got wrong in #63699; some adjustments made after the
  review have been discarded :/ We are using a wrong openwrt upstream.

  My apologies.

  ###### Things done

  Changed the noscan patch url to proper openwrt repo.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC @flokli 


state: closed
title: linuxptp: init at 2.0
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/63803
updated_at: 2019-06-28 08:37:37
body:
  ###### Motvation for this change
  Linux command line tools for the precision time protocol (PTP) 

  ###### Things done
  tested `ptp4l` and `phc2sys` on a pair of Xeon systems with HW timestamping.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kops: 1.12.1->1.12.2
user_login: ari-becker
html_url: https://github.com/NixOS/nixpkgs/pull/63804
updated_at: 2019-06-26 12:48:49
body:
  ##### Motivation for this change
  Package update: https://github.com/kubernetes/kops/releases/tag/1.12.2

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Broken PostgreSQL with plugins
user_login: couchemar
html_url: https://github.com/NixOS/nixpkgs/issues/63805
updated_at: 2019-07-01 15:54:48
body:
  ## Issue description
  This commit https://github.com/NixOS/nixpkgs/commit/f5e7e1c24b020e786053e852bb35d8df7ae0a097 (https://github.com/NixOS/nixpkgs/pull/62271, https://github.com/NixOS/nixpkgs/issues/62235) broke working of the postgresql with plugins https://github.com/NixOS/nixpkgs/blob/cdb032dff2229ae0dbe90541052a7e16fa5398d9/nixos/modules/services/databases/postgresql.nix#L12-L23
  Now extensions are located in different directories: `share/extension` for `extraPlugins` and `share/postgresql/extension` for builtin plugins.


  ### Steps to reproduce
  ```
  $ cat test.nix 
  let pkgs = import (builtins.fetchTarball https://github.com/NixOS/nixpkgs/archive/master.tar.gz) {};
  in
  with pkgs;
  buildEnv {
    name = "test";
    paths = [postgresql postgresql.lib postgis];
    buildInputs = [ makeWrapper ];
    postBuild =
      ''
            mkdir -p $out/bin
            rm $out/bin/{pg_config,postgres,pg_ctl}
            cp --target-directory=$out/bin ${postgresql}/bin/{postgres,pg_config,pg_ctl}
            wrapProgram $out/bin/postgres --set NIX_PGLIBDIR $out/lib
      '';
  }

  $ nix-build test.nix
  /nix/store/h0r36qx8zy3n397lsw6ah9wd1myma6yr-test

  $ ls result/share/extension
  postgis--2.0.0--2.5.2.sql  postgis--2.4.4--2.5.2.sql
  ...

  $ ls result/share/postgresql/extension
  adminpack--1.0--1.1.sql          dict_int.control                      isn--unpackaged--1.0.sql
  ...
  ```



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.52, NixOS, 19.03.172979.8634c3b6199 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172979.8634c3b6199"`
   - channels(andrey): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs
  ```


state: closed
title: python.pkgs.dm-sonnet: fix build
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63806
updated_at: 2019-06-26 11:58:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix a build failure cause by the recent bazel update in https://github.com/NixOS/nixpkgs/pull/63532.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: conda: Remove version suffix
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/63807
updated_at: 2019-06-30 14:00:32
body:
  Currently the `conda-shell` binary is installed as
  `conda-shell-4.6.14` which is not very friendly to type.

  With this change the binary is simply installed as `conda-shell`.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @jluttine @bhipple 


state: open
title: gcc: support running the testsuite.
user_login: eddyb
html_url: https://github.com/NixOS/nixpkgs/pull/63808
updated_at: 2019-07-17 08:47:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I needed to submit a patch to GCC and they want confirmation of no regressions in the testsuite, and so I ended up using this expression with `nix-build` (parts specific to GCC trunk & my own patches omitted):
  ```nix
  with import <nixpkgs>{};
  gcc9.cc.overrideAttrs (gcc: {
      nativeBuildInputs = (gcc.nativeBuildInputs or []) ++ [ expect dejagnu ];
      builder = ./builder.sh; # with the changes in this PR
      doCheck = true;
      checkFlags = "-k";
  })
  ```
  Sadly, not all tests pass (it's unclear to me how many of those are broken upstream), so `doCheck = true` can't be turned on by default yet, but:
  * `expect` and `dejagnu` dependencies are needed to run the test suite in the first place
  * the `builder.sh` change allows `crt{1,i}.o` to be found for linking executable tests

  Overall, this did work well enough for me to be able to confirm the lack of regressions (by building GCC trunk and GCC trunk + my patch, and comparing the `.sum` files in the resulting build dirs).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.dm-sonnet: 1.30 -> 1.33
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63809
updated_at: 2019-07-02 09:19:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix.binaryCaches: always set https://cache.nixos.org
user_login: domenkozar
html_url: https://github.com/NixOS/nixpkgs/pull/63810
updated_at: 2019-06-26 18:39:04
body:
  There are many support questions when people add a new binary cache
  and they suddenly lose nixos substitutions.

  Most of the users want to keep that, so we're doing a breaking change.

  Previously to disable all binary caches one had to do:

  ```
    nix.binaryCache = [];
  ```

  Now the same is possible via:

  ```
    nix.binaryCache = lib.mkForce [];
  ```

  # TODO

  - [ ] nixos changelog
  - [ ] test


state: closed
title: elpi: 1.2.0 -> 1.4.1
user_login: CohenCyril
html_url: https://github.com/NixOS/nixpkgs/pull/63811
updated_at: 2019-06-27 11:30:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upgrade elpi to latest version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: supercollider: 3.9.3 -> 3.10.2
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/63812
updated_at: 2019-07-08 14:59:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updating to a newer version: https://github.com/supercollider/supercollider/releases/tag/Version-3.10.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: deepin.startdde: init at 3.14.6.4
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63813
updated_at: 2019-07-22 06:27:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Add [startdde](https://github.com/linuxdeepin/startdde), used for launching DDE components and invoking user's custom applications which are compliant with xdg autostart specification.

  - Add the nixos desktop service module.

  The packaging of Deepin Desktop Environment is alpha quality at this point. But at least it should be possible to run DDE for testing and bug fix purposes.

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: openhab: init at 2.4.0 and NixOS module [WIP]
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63814
updated_at: 2019-07-02 13:41:15
body:
  ###### Motivation for this change

  openHAB is a pretty nifty home-automation tool.

  This is still very much a WIP.

  Cc: @dotlambda might be interested

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.dm-sonnet: fix hash
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63815
updated_at: 2019-06-26 15:48:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Follow up to https://github.com/NixOS/nixpkgs/pull/63806, where I failed
  to update the hash.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rust-bindgen: 0.49.2 -> 0.49.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63816
updated_at: 2019-06-28 02:39:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `rust-bindgen` to the latest release.
  https://github.com/rust-lang/rust-bindgen/releases/tag/v0.49.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wine: Set WINELOADER in wrapper, wrap also wine64.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/63817
updated_at: 2019-07-15 10:40:16
body:
  Fixes #63170. Note that this brings back wrapping of wine64 which was removed in #28486 because the underlying issue is now fixed.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  Tested (on 19.03 branch) that with `wineWowPackages.full`:
  - `wineboot` populates the `syswow64` directory in addition to `system32` (before this fix `syswow64` was not populated),
  - `wine <32-bit-exe>` works,
  - `wine <64-bit-exe>` works,
  - `wine64 <32-bit-exe>` works,
  - `wine64 <64-bit-exe>` works,
  - running a 32-bit exe from within a 64-bit program works,
  - running a 64-bit exe from within a 32-bit program works.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: sddm doesn't start at boot when I enable plymouth
user_login: allowthere
html_url: https://github.com/NixOS/nixpkgs/issues/63818
updated_at: 2019-06-26 17:57:09
body:
  ## Issue description

  When I enable plymouth in my configuration.nix (`plymouth = {enable = true;theme = "breeze";};`), sddm fails to start.

  ## Technical details

  journalctl says:

  EE) /dev/dri/card0: failed to set DRM interface version 1.4: Permission denied

  ...

  (EE) Screen 0 deleted because of no matching config section.

  ...
  (EE) Screen 0 deleted because of no matching config section.

  ...

  (EE) modeset(0): drmSetMaster failed: Invalid argument

  Fatal server error:

  (EE) AddScreen/ScreenInit failed for driver 0


  I disabled plymouth and sddm starts again at boot.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.03.172979.8634c3b6199 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172979.8634c3b6199"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: netdata: 1.11.1 -> 1.15.0
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63819
updated_at: 2019-06-27 07:31:41
body:
  ###### Motivation for this change
  Update to version 1.15.0

  @Mic92 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/gnome3: enable networkmanagerapplet by default
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/63820
updated_at: 2019-06-30 21:28:34
body:
  ###### Motivation for this change
  networkmanagerapplet includes nm-connection-editor which is (apparently)
  required to edit bluetooth network connections in gnome-shell /
  gnome-control-center.

  Fixes this:

  ```
  .gnome-control-[5383]: Failed to launch nm-connection-editor: Failed to execute child process “nm-connection-editor” (No such file or directory)
  ```

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: NTPSec
user_login: georgyo
html_url: https://github.com/NixOS/nixpkgs/pull/63821
updated_at: 2019-07-01 17:52:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  NTPSec is fork of ntpd, and there for a  drop in replacement of it. It includes numerous security fixes and improvements, as well as implementations of secure time protocols such as NTS.

  Instead of creating a new ntpsec service configuration, I decided it would be better to just reuse the existing ntp configuration, and add a few more customizations to that that one.

  This is my first time trying to upstream a nix package, please feel free to point out anything I can do better.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions (archlinux)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.dde-control-center: init at 4.10.11
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63822
updated_at: 2019-06-28 02:28:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Get #59023 going for 19.09 :fireworks: 

  I've left the redshift functionality unpatched because it looked too impure for NixOS.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: shadowsocks-libev: fix shared libraries
user_login: uHOOCCOOHu
html_url: https://github.com/NixOS/nixpkgs/pull/63823
updated_at: 2019-06-27 03:30:49
body:
  #### Motivation for this change

  Fix errors about shared libraries. Seems caused by #63185
  ```
  ss-local: error while loading shared libraries: libipset.so: cannot open shared object file: No such file or directory
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
    - `34693840 (33.09 MiB) -> 34882760 (33.27 MiB)`
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zoneminder: Fix package and service build
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63824
updated_at: 2019-07-07 10:20:32
body:
  ###### Motivation for this change
  NixOS wouldn't build because the nginx config checker fails.

  Location without a trailing slash "could allow an attacker to read file
  stored outside the target folder.", source:
  https://github.com/yandex/gixy/blob/master/docs/en/plugins/aliastraversal.md

  Shouldn't change the behaviour according to
  https://serverfault.com/questions/607615/using-trailing-slashes-in-nginx-configuration/607731#607731

  cc @peterhoeg @aanderse

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Can be tested with this minimal config:
  ```
    services.zoneminder = {
      enable = true;
      database = {
        createLocally = true;
        username = "zoneminder";
      };
    };
  ```


state: closed
title: gnome3.gnome-user-docs: Add meta attributes
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/63825
updated_at: 2019-07-04 10:27:07
body:
  ###### Motivation for this change
  Doesn't have meta attributes (license, homepage).

  cc @jtojnar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.pytest-mock bulid fails
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/issues/63826
updated_at: 2019-07-03 12:53:50
body:
  ## Issue description

  Caused by the pytest update in 1a7ffb4140b8fff7a0a23d261be17533fa97d978. Upstream issue filed at https://github.com/pytest-dev/pytest-mock/issues/149.


state: open
title: monosat: Fix Linux build
user_login: acairncross
html_url: https://github.com/NixOS/nixpkgs/pull/63827
updated_at: 2019-07-05 21:26:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The Linux build was broken because the CMake build process for this package builds both static and shared libraries, but the static library dependencies weren't being provided. For some reason this doesn't seem to be a problem for the Darwin build:
  Linux: https://hydra.nixos.org/job/nixpkgs/trunk/monosat.x86_64-linux
  Darwin: https://hydra.nixos.org/job/nixpkgs/trunk/monosat.x86_64-darwin

  The closure size seems large compared to the Darwin build. Is this normal?
  `/nix/store/1n2vwa7hc2wr882szg8s4dcajqc46m5b-monosat-09yhym2      511.3M`

  ~~I'm not sure how to build the accompanying Python package.~~

  @copumpkin 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] signal-desktop: 1.25.1 -> 1.25.3 (backport)
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/63828
updated_at: 2019-07-03 11:29:13
body:
  (cherry picked from commit 4ae993455deeec79254712bdeb4e5a75b9ef7da8)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pkgsi686Linux.qt5.qtbase fails to build
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/issues/63829
updated_at: 2019-07-09 02:56:57
body:
  ## Issue description

  Seems to be related to #36946/#36947. Makes it so I can't use `wine`, which depends on it for some reason

  ```
  .obj/qpathsimplifier.o:qpathsimplifier.cpp:function (anonymous namespace)::PathSimplifier::intersectNodes(QDataBuffer<(anonymous namespace)::PathSimplifier::Element*>&, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*): error: undefined reference to '__divmoddi4'
  .obj/qpathsimplifier.o:qpathsimplifier.cpp:function (anonymous namespace)::PathSimplifier::intersectNodes(QDataBuffer<(anonymous namespace)::PathSimplifier::Element*>&, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*): error: undefined reference to '__divmoddi4'
  .obj/qpathsimplifier.o:qpathsimplifier.cpp:function (anonymous namespace)::PathSimplifier::intersectNodes(QDataBuffer<(anonymous namespace)::PathSimplifier::Element*>&, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*): error: undefined reference to '__divmoddi4'
  .obj/qpathsimplifier.o:qpathsimplifier.cpp:function (anonymous namespace)::PathSimplifier::intersectNodes(QDataBuffer<(anonymous namespace)::PathSimplifier::Element*>&, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*, (anonymous namespace)::PathSimplifier::BoundingVolumeHierarchy::Node*): error: undefined reference to '__divmoddi4'
  collect2: error: ld returned 1 exit status
  make[2]: *** [Makefile:1312: ../../lib/libQt5Gui.so.5.12.0] Error 1
  make[2]: Leaving directory '/build/qtbase-everywhere-src-5.12.0/src/gui'
  make[1]: *** [Makefile:448: sub-gui-make_first] Error 2
  make[1]: Leaving directory '/build/qtbase-everywhere-src-5.12.0/src'
  make: *** [Makefile:49: sub-src-make_first] Error 2
  builder for '/nix/store/y37l40jih7j4db0n8x9mn0digdxcyp61-qtbase-5.12.0.drv' failed with exit code 2
  error: build of '/nix/store/y37l40jih7j4db0n8x9mn0digdxcyp61-qtbase-5.12.0.drv' failed
  ```

  ### Steps to reproduce

  - Update to latest git master nixpkgs
  - `nix-build '<nixpkgs>' -A pkgsi686Linux.qt5.qtbase`

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.15, NixOS, 19.09.git.5500538 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/etc/nixos/nixpkgs`


state: closed
title: qmapshack: 1.12.3 -> 1.13.0
user_login: sikmir
html_url: https://github.com/NixOS/nixpkgs/pull/63830
updated_at: 2019-06-28 08:37:29
body:
  ###### Motivation for this change

  [Changelog](https://bitbucket.org/maproom/qmapshack/src/default/changelog.txt):

  > V 1.13.0
  > * Live GPS data
  > * Add waypoint summary to project details
  > * Route history is buggy and causes data loss when auto-routing is enabled
  > * Suppress ascent/descent if wrong
  > * Partially: Support for PROJ 6.0.0
  > * Add Geocaching Attributes
  > * Mega-fancy tour description on screen
  > * Project Details: Add track points with additional information to lists
  > * Garmin Map: Fixing elevation marks
  > * Waypoint: copy coordinate to clipboard

  Patches originated from:
  * [FindPROJ4.patch](https://bitbucket.org/maproom/qmapshack/src/default/FindPROJ4.patch)
  * [FindQuaZip5.patch](https://bitbucket.org/maproom/qmapshack/src/default/FindQuaZip5.patch)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update prometheus-tor-exporter to v0.4
user_login: priegger
html_url: https://github.com/NixOS/nixpkgs/issues/63831
updated_at: 2019-07-05 04:49:05
body:
  ## Issue description

  The prometheus-tor-exporter gives a stack trace and the following error in the journal:

  > stem.OperationFailed: Not running in server mode

  This seems to be a "stem 1.7+ compatibility" issue.

  ### Steps to reproduce

  Configure tor and the prometheus tor exporter:

  >  services.tor = {
  >    enable = true;
  >    controlPort = 9051;
  >    client.enable = true;
  >  };
  >
  >  services.prometheus.exporters.tor = {
  >    enable = true;
  >    listenAddress = "127.0.0.1";
  >  };

  Activate the config using 

  `nixos-rebuild switch`

  ## Technical details

  There's a commit on prometheus-tor_exporter master that fixes this issue. I created a private nix overlay and bumped the tor exporter to HEAD as of 1 day ago, which fixed the issue for me. Today version v0.4 was released, which includes this fix.

  `nix-shell -p nix-info --run "nix-info -m"`
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.14, NixOS, 19.03.172968.3ddd23719bb (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172968.3ddd23719bb, unstable-19.09pre183693.baa75f0c25a"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Steam: unable to input umlauts and €
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63832
updated_at: 2019-07-11 20:09:13
body:
  ## Issue description

  I can't type öäüß€ in Steam (for example in store search box or chat).

  Maybe related:

  ```
  WARNING: setlocale('en_US.UTF-8') failed, using locale: 'C'. International characters may not work.
  ```
  ### Steps to reproduce

  My localization settings: https://github.com/davidak/nixos-config/blob/master/services/localization.nix

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.03.172979.8634c3b6199 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172979.8634c3b6199"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: WIP: linux_rpi: Update version to 20190620 / 4.19.50
user_login: luaduck
html_url: https://github.com/NixOS/nixpkgs/pull/63833
updated_at: 2019-07-03 19:51:31
body:
  ###### Motivation for this change

  Part of #63720

  There's a new kernel version released on the day the Raspberry Pi 4 was unveiled, and it contains changes required to boot the new chipset.

  (Note: This is just one part of many changes that are going to be required)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Package `guardian-agent`
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/63834
updated_at: 2019-07-16 19:53:53
body:
  **Package Request**: [guardian-agent](https://github.com/StanfordSNR/guardian-agent)

  `guardian-agent` is a way of being able to do agent forwarding when using mosh. It also allows verifying commands being executed. I don't fully understand how it works, but it seems valuable, especially as I shift back to using `mosh` on high-latency links.


state: open
title: raspberrypi-firmware: Update version to 1.20190620+1
user_login: luaduck
html_url: https://github.com/NixOS/nixpkgs/pull/63835
updated_at: 2019-06-26 22:44:28
body:
  #### Motivation for this change

  Part of #63720

  There's some new firmware released as of the day the Raspberry Pi 4 was unveiled, and it contains changes required to boot the new chipset.

  (Note: This is just one part of many changes that are going to be required)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: chromiumDev: doesn't build (part 2)
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/63836
updated_at: 2019-07-04 19:43:15
body:
  ## Issue description
  1. Update Chromium's upstream info (`cd pkgs/applications/networking/browsers/chromium; ./update.sh`)
  2. Try to build it. `nix-build -A chromiumDev`


  Result:
  ```
  ...
  ./testing/scripts/checkdeps.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"                                                   
  ./testing/scripts/grit_python_unittests.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"                                       
  ./testing/scripts/headless_python_unittests.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"                                   
  ./testing/scripts/check_network_annotations.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"                                   
  ./testing/scripts/run_gpu_integration_test_as_googletest.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/k4gf6ajykc2i8zp2zk5x0h7mf4r08cv6-python-2.7.16/bin/python"                      
  configuring
  ERROR Unresolved dependencies.
  //third_party/perfetto/gn:zlib(//build/toolchain/linux:clang_x64)                                         
    needs //third_party/zlib:zlib_config(//build/toolchain/linux:clang_x64)                                 

  builder for '/nix/store/4rr6jdym1zzk1xi639py3dyl34ykhjw3-chromium-unwrapped-77.0.3833.0.drv' failed with exit code 1
  cannot build derivation '/nix/store/91m7k31fhq61scmfkhlv6c0j6ch1vz0g-chromium-dev-77.0.3833.0.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/91m7k31fhq61scmfkhlv6c0j6ch1vz0g-chromium-dev-77.0.3833.0.drv' failed         


  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: Get in contact with Valve (Steam developers)
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63837
updated_at: 2019-07-21 15:48:28
body:
  In a recent blog article, Pierre-Loup Griffais said:

  > The Linux landscape has changed dramatically since we released the initial version of Steam for Linux, and as such, we are re-thinking how we want to approach distribution support going forward. There are several distributions on the market today that offer a great gaming desktop experience such as Arch Linux, Manjaro, Pop!_OS, Fedora, and many others. We'll be working closer with many more distribution maintainers in the future. If you're working on such a distribution and don't feel your project has a direct line of contact with us, by all means, have a representative [reach out directly](https://www.valvesoftware.com/en/contact?contact-person=Pierre-Loup%20Griffais).

  Source: https://steamcommunity.com/app/221410/discussions/0/1640915206447625383/

  E-Mail: pgriffais@valvesoftware.com

  From: https://steamcommunity.com/app/221410/discussions/0/1696043806550421224/

  We can use this offer to get in contact and tell them some pain points for us.

  Like:

  - disappearing Downloads / breaking URLs
  - ...

  What else are problems we have with Steam that upstream has to fix?

  Who wants to be a contact person for them?

  cc @abbradar @jagajaga @tadfisher 


state: closed
title: bazel-watcher is broken
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/issues/63838
updated_at: 2019-06-27 02:05:03
body:
  ## Issue description

  I can't build bazel-watcher on the latest master

  ### Steps to reproduce

  <details>
  <summary>Shell session</summary>

  ```sh-session
   λ  nix run -f https://github.com/kalbasit/nur-packages/archive/master.tar.gz nix-verify -c nix-verify -I nixpkgs=`pwd` -A bazel-watcher
  $ exec env -i NIXPKGS_ALLOW_UNFREE=1 nix-build -I nixpkgs=/yl/code/opensource/base/src/github.com/NixOS/nixpkgs -A bazel-watcher
  these derivations will be built:
    /nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv
  building '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' on 'ssh://builder@13.56.251.157'...
  unpacking sources
  unpacking source archive /nix/store/6waa28r78jwaarcbwh14vd2i8lzgrnhl-source
  source root is source
  patching sources
  configuring
  no configure script, doing nothing
  building
  patching script interpreter paths in .
  ./release/release.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/x6b81sfmbmkmcyqp2rmk6jgsmzvyrjj0-bash-4.4-p23/bin/bash"
  Extracting Bazel installation...
  Starting local Bazel server and connecting to it...
  Loading:
  Loading: 0 packages loaded
  INFO: Call stack for the definition of repository 'com_github_bazelbuild_bazel_integration_testing' which is a http_archive (rule definition at /build/output/external/bazel_tools/tools/build_defs/repo/http.bzl:237:16):
   - /build/source/WORKSPACE:17:1
  ERROR: An error occurred during the fetch of repository 'com_github_bazelbuild_bazel_integration_testing':
     java.io.IOException: Error downloading [https://github.com/bazelbuild/bazel-integration-testing/archive/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz] to /build/output/external/com_github_bazelbuild_bazel_integration_testing/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz: Unknown host: github.com
  ERROR: error loading package '': Encountered error while reading extension file 'tools/repositories.bzl': no such package '@com_github_bazelbuild_bazel_integration_testing//tools': java.io.IOException: Error downloading [https://github.com/bazelbuild/bazel-integration-testing/archive/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz] to /build/output/external/com_github_bazelbuild_bazel_integration_testing/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz: Unknown host: github.com
  ERROR: error loading package '': Encountered error while reading extension file 'tools/repositories.bzl': no such package '@com_github_bazelbuild_bazel_integration_testing//tools': java.io.IOException: Error downloading [https://github.com/bazelbuild/bazel-integration-testing/archive/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz] to /build/output/external/com_github_bazelbuild_bazel_integration_testing/83c0657f503f382f12bcd2ce3736a72196ef5e5e.tar.gz: Unknown host: github.com
  INFO: Elapsed time: 2.438s
  INFO: 0 processes.
  FAILED: Build did NOT complete successfully (0 packages loaded)
  FAILED: Build did NOT complete successfully (0 packages loaded)
  builder for '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' failed with exit code 1
  error: build of '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' on 'ssh://builder@13.56.251.157' failed: builder for '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' failed with exit code 1
  builder for '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' failed with exit code 1
  error: build of '/nix/store/fbxyc667imbrkhl7dp0npvynlca46w97-bazel-watcher-0.10.3.drv' failed
  ```
  </details>

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.6, NixOS, 19.03pre-git (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `""`
   - channels(kalbasit): `"home-manager-18.09, nixpkgs-18.09.932.09195057114"`
   - channels(yl): `""`
   - nixpkgs: `/run/current-system/nixpkgs`


  cc @Profpatsch @guibou 


state: open
title: Steam unable to detect OS (NixOS)
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/63839
updated_at: 2019-07-04 02:06:35
body:
  ## Issue description

  For visibility of our project it would be good if Steam can detect NixOS.

  Then it might appear in their stats: https://store.steampowered.com/hwsurvey/Steam-Hardware-Software-Survey-Welcome-to-Steam?platform=linux

  Error on console:

  `sh: lsb_release: command not found`

  Related to https://github.com/NixOS/nixpkgs/issues/22729


  Currently detected system informations:

  ```
  Betriebssystem:
      Linux 4.x (64 Bit)
      Kernel-Name: Linux
      Kernel-Version: 4.19.47
      X-Server-Vendor: The X.Org Foundation
      X-Server-Release: 12004000
      X-Fenstermanager: Mutter(Gala)
      Steam-Runtime-Version: <Runtime enabled>
  ```

  ### Steps to reproduce

  1. open steam
  2. view system informations

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.03.172783.a0b7a7913c4 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172783.a0b7a7913c4, nixos-hardware, nixos-unstable-19.09pre181392.4ab1c14714f"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: bazel-watcher: fix the build
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63841
updated_at: 2019-06-27 02:10:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Bazel is currently broken on master, this PR fixes it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  closes #63838


state: open
title: Mathematica: 11.3.0 -> 12.0.0
user_login: herberteuler
html_url: https://github.com/NixOS/nixpkgs/pull/63843
updated_at: 2019-07-02 16:07:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  Upgrade Mathematica to 12.0.0. This PR incorporates the ideas discussed in #63620.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zabbix: overhaul package & module
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63844
updated_at: 2019-07-12 10:31:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Team effort between @mmahut and myself to cleanup Zabbix in NixOS as the module & packages have become fairly unmaintained.

  I've been running this in a reasonably sized environment for about a month now.

  ###### Things not yet done 
  - [x] Write some release notes (@aanderse)
  - [ ] ~~Add a NixOS test which tests all of the server, proxy, and agent (@mmahut)~~
  - [ ] ~~test `zabbixProxy` module in a real environment (@aanderse)~~

  I'm comfortable to go ahead and merge this without a NixOS test in good faith that @mmahut will eventually get the up and running. As for the `zabbixProxy` module it will eventually get tested in my environment before 19.09 so I can fix an issues which may come up before then. At this point mostly waiting for @PsyanticY to give a thumbs up, as they had done some of the same work this PR does (my fault, I really should have searched for any open PRs when I pushed this).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: deepin.deepin-editor: init at 1.2.9
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/63845
updated_at: 2019-06-30 22:36:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [deepin-editor](https://github.com/linuxdeepin/deepin-editor), a desktop text editor that supports common text editing features.

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: cargo-make: 0.20.0 -> 0.21.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63846
updated_at: 2019-07-03 13:11:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-make` to the latest release.
  https://github.com/sagiegurari/cargo-make/releases/tag/0.21.0

  **Note**: `doCheck` is set as `false`.
  Some tests fail because they need network access. However, Travis-CI ensures a proper build.
  https://travis-ci.org/sagiegurari/cargo-make/jobs/550981829
  https://travis-ci.org/sagiegurari/cargo-make/jobs/550981830
  https://travis-ci.org/sagiegurari/cargo-make/jobs/550981831

  `cargo-make` is a subcommand for `cargo`. You need to invoke `cargo-make` via `cargo` command.
  To test the binary files in `./result/bin`, consider the following commands:
  ```
  [john@nixos:~/result/bin] PATH=.:$PATH cargo make --version
  cargo-make 0.21.0
  [john@nixos:~/result/bin] makers --version
  makers 0.21.0
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Pyls bumping
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/63847
updated_at: 2019-07-17 08:11:32
body:
  ###### Motivation for this change
  there were some bugs in pyls-mypy (would crash with coc). With this update it looks ok

  Pinging @jabranham since he made the last python-language-server update.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: minecraft-server: 1.14 -> 1.14.3
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/63848
updated_at: 2019-07-13 08:59:30
body:
  Also removes older versions from the top level of nixpkgs. They can
  still be accessed via minecraft-server-versions. This allows leaving
  all-packages.nix alone in future server bumps.

  cc @thoughtpolice @tomberek @costrouc — would very much appreciate your input on this because it's a minor breaking change.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixUnstable: pre6631_e58a7144 -> pre6631_324a5dc9
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63849
updated_at: 2019-06-27 10:30:13
body:
  ###### Motivation for this change
  Update nixUnstable to version pre6631_324a5dc9 (25.06.2019)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: soapyuhd: 0.3.5 -> 0.3.6
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/63850
updated_at: 2019-06-27 21:40:00
body:
  ###### Motivation for this change
  Minor update

  https://github.com/pothosware/SoapyUHD/blob/master/Changelog.txt

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia-settings: Install desktop file and icon.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/63851
updated_at: 2019-07-13 01:44:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  Tested that an entry appears in Xfce under the Settings group, has the right icon and starts the application.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: can't build clippy for rust development
user_login: thedavidmeister
html_url: https://github.com/NixOS/nixpkgs/issues/63852
updated_at: 2019-06-28 13:39:06
body:
  ## Issue description

  want to be able to build clippy so that it is available in nix-shell

  currently i have cargo in the nix shell by using the mozilla overlay

  ### Steps to reproduce

  i tried following the steps here: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md

  i forked the clippy repo to be able to build a Cargo.lock but natively nix can't build using a specific nightly or configure rust flags (or can it with the overlay?)

  i tried carnix over the same Cargo.lock but it only prefetched everything then spat out an empty `Cargo.nix` file

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: galario: init at 1.2.1
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/pull/63853
updated_at: 2019-07-09 13:47:45
body:
  ###### Motivation for this change

  Package [galario](https://github.com/mtazzari/galario/) for Nix.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: nomad: 0.8.7 -> 0.9.3
user_login: knl
html_url: https://github.com/NixOS/nixpkgs/pull/63854
updated_at: 2019-07-01 20:04:47
body:
  0.9 series require go 1.11.11+ so switching to default 1.12.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel-buildtools: 0.22.0 -> 0.26.0
user_login: u-quark
html_url: https://github.com/NixOS/nixpkgs/pull/63856
updated_at: 2019-07-09 17:44:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change

  Update to the latest version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Make nix package easier to override
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/63857
updated_at: 2019-07-02 13:28:24
body:
  Currently you (apparently) can't easily override `nix` with your own patched version by overriding `src` to your git fork.

  That is because that needs setting `fromGit = true` as an argument to the `common` function in https://github.com/NixOS/nixpkgs/blob/5f78fa399da1cbca3591930d58e2c2a68c8c8a44/pkgs/tools/package-management/nix/default.nix#L11

  and you can't get at that because `common` is in a `let` block and not exported.

  ---

  Would anyone mind if that was rewritten, so that we can use normal `.override`s for things like `fromGit`?

  Also, please let me know if this is already possible and I just haven't figured out how.


state: closed
title: rivet: 2.7.0 -> 2.7.2
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/63858
updated_at: 2019-07-01 14:10:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pulseaudio-modules-bt: Patch default settings for AAC encoding
user_login: talyz
html_url: https://github.com/NixOS/nixpkgs/pull/63859
updated_at: 2019-06-27 15:25:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The upstream defaults result in audibly worse quality than simply
  relying on the builtin SBC codec, making it somewhat useless. Attempt
  to fix this by setting saner defaults.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia_x11: 418.74 -> 430.26
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/63860
updated_at: 2019-07-01 20:30:25
body:
  This is quite late, released on the 10th.
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mopidy-gmusic: failed with exit code 25
user_login: codedmart
html_url: https://github.com/NixOS/nixpkgs/issues/63861
updated_at: 2019-07-09 20:05:37
body:
  ## Issue description
  Can't install mopidy-gmusic seeing a collision message and fails with exit code 25
  ```
  collision between `/nix/store/aksq045jzpi0yyxhlcmya3myzki28rsd-python2.7-backports.ssl_match_hostname-3.7.0.1/lib/python2.7/site-packages/backports/__init__.pyc' and 
  builder for '/nix/store/byfhf2k3l2z9c8ql147kppmz2f78kfs5-mopidy-with-extensions-2.2.2.drv' failed with exit code 25
  ```


  ### Steps to reproduce
  `/etc/nixos/configuration.nix`
  ```
  services.mopidy = {
    enable = true;
    extensionPackages = [ pkgs.mopidy-gmusic ];
  };
  ```


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.03.173000.1c6bdbc766e (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173000.1c6bdbc766e"`
   - channels(codedmart): `"home-manager-19.03"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nixos/mysql: run ExecStartPost as root (again) to preserve compatibility with secured installs
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63862
updated_at: 2019-07-01 10:39:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Partial revert of #61589 as it breaks `ensureDatabases` and `ensureUsers` on systems where `mysql` has been secured.

  For examples of broken setups:
  https://github.com/NixOS/nixpkgs/pull/61589#commitcomment-34044211
  https://github.com/NixOS/nixpkgs/pull/63634#issuecomment-506297751

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: yggdrasil: init at 0.3.5 and add service module
user_login: gazally
html_url: https://github.com/NixOS/nixpkgs/pull/63863
updated_at: 2019-07-08 21:36:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Use an encrypted ipv6 overlay network.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  See also #63855 by @Lassulus, which has a different derivation for `yggdrasil` which also works with the service module.  This is my first attempt to write a Go derivation so I'll be happy to rebase this pull request on #63855 if that is preferable.


state: open
title: datadog-agent: fix extraIntegrations
user_login: cransom
html_url: https://github.com/NixOS/nixpkgs/pull/63864
updated_at: 2019-07-01 16:01:36
body:
  The override that builds the custom python for integrations-core was overriding python, but pythonPackages was still being inherited from a call to `datadog-integrations-core {}`, causing service.datadog-agent.extraIntegrations to be ignored.

  ###### Motivation for this change

  `services.datadog-agent.extraIntegrations` failed to include varnish related files from datadogs `integration-core` repo when I tried to include varnish.


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  There isn't an integrated nixos test for datadog, but you can run the daemon and validate scripts without a functional API key or network access (assuming the checks don't need external network access). I used this snippet to validate my varnish change succeeded.

  ```
  import <nixpkgs/nixos/tests/make-test.nix> ({ pkgs, ...} : {
    name = "datadog";

    nodes = {
      machine =
        { ... }:
        {
          imports = [ ../modules/profiles/minimal.nix ];
          services.datadog-agent.enable = true;
          users.groups.varnish.members = [ "datadog" ];
          services.datadog-agent.apiKeyFile = "/dev/null";
          services.datadog-agent.extraIntegrations = {
            varnish = (ps: [ ]);
          };
          services.datadog-agent.checks = {
            varnish = {
              init_config = {};
              instances = [{
                varnishstat = "${pkgs.varnish}/bin/varnishstat";
              }];
            };
          };
          services.varnish.enable = true;
          services.varnish.config = ''
            vcl 4.0;
            backend foo {
              .host = "127.0.0.1";
              .port = "8080";
            }
          '';
        };
      };

      testScript = ''
        startAll;
        $machine->waitForUnit("varnish.service");
        $machine->succeed("sleep 30");
        $machine->fail("journalctl -b -u datadog-agent | grep -q 'Error running check varnish'");
      '';
    })
  ```


state: open
title: dockerTools: use skopeo on the right platform
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/63865
updated_at: 2019-07-03 13:22:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  When building a Docker image using any one of the `dockerTools` in `pkgsCross`, a `skopeo` on the host platform is chosen and usually this leads to unrecognised Exec format. This PR fixes this issue by assigning the right build packages on the build platform.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: alsa-firmware: enable cross compilation
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/63866
updated_at: 2019-06-28 10:26:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The Autoconf and Automake scripts in `alsa-firmware` incorrectly build the firmware writers to the host platform, which leads to incorrect Exec format if they are invoked by these scripts later to transform the firmware blobs. This PR will properly build the writers to the build platform instead.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/phpfpm: Remove usage of undefined variable fpmCfg
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/63867
updated_at: 2019-06-27 20:17:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ```
  error: undefined variable 'fpmCfg' at /nix/store/pnlg9bycirawpry9gx99yfnymszzlki5-source/nixos/modules/services/web-servers/phpfpm/default.nix:77:25
  ```

  cc @Izorkin 

  This seems to have been introduced in #63156

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mscgen: add darwin to meta.platforms
user_login: burke
html_url: https://github.com/NixOS/nixpkgs/pull/63868
updated_at: 2019-06-28 18:51:13
body:
  ###### Motivation for this change

  `mscgen` appears to work without issue on darwin, sort of...

  I built this without `sandbox = true` and it works fine, but with sandboxing enabled, it fails because it doesn't have permission to write to `/tmp` in:

  ```c
          static char tmpTemplate[] = "/tmp/mscgenXXXXXX";
          int h;

          outType  = ADRAW_FMT_PNG;
          outImage = tmpTemplate;

          /* Create temporary file */
          h = mkstemp(tmpTemplate);
  ```

  However, looking at the nearby `#ifdef`, this should be an issue on Linux too.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [-] NixOS
     - [x] macOS
     - [-] other Linux distributions
  - [-] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Wireguard doesn't bring up peers
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/issues/63869
updated_at: 2019-07-02 17:04:59
body:
  ## Issue description

  Using wireguard on a server with several peers added it looks like they aren't brought up properly and since the type is set to "oneshot" it won't even retry. Problem seems to be related to dns not being available.

  ### Steps to reproduce

  1. Setup a WG server somewhere

  2. Setup a wg on nixos where the server is set as peer and domain name is used instead of ip address (never tried with ip alone though), like

  ```
          wg_jl = {
              ips = [ "10.8.0.10/32" ];
              privateKey = "abc";
              peers = [ {
                  allowedIPs = [ "10.8.0.0/24" ];
                  endpoint = "vpn.domain.tld:51820";
                  publicKey = "xyz";
                  persistentKeepalive = 25;
              } ];
          };
  ```

  3. Rebuild

  4. Reboot

  5. Try to ping wg server at 10.8.0.1

  --> 100% packet loss

  For some reason systemctl does show it as started:

  ```
  ● wireguard-wg_jl.service - WireGuard Tunnel - wg_jl                                                                                                                                                                  "servi" 21:05 27-Jun-19
     Loaded: loaded (/nix/store/1jhgf70mi82wv9r8xzi7dgsmhp4kbjrd-unit-wireguard-wg_jl.service/wireguard-wg_jl.service; enabled; vendor preset: enabled)
     Active: active (exited) since Thu 2019-06-27 21:06:58 CEST; 1min 5s ago
    Process: 3089 ExecStart=/nix/store/d3ngi8wjx92d6wsvmw0ln6sg29mxn4qn-unit-script-wireguard-wg_jl-start (code=exited, status=0/SUCCESS)
   Main PID: 3089 (code=exited, status=0/SUCCESS)

  Jun 27 21:06:57 servi systemd[1]: Starting WireGuard Tunnel - wg_jl...
  Jun 27 21:06:58 servi systemd[1]: Started WireGuard Tunnel - wg_jl.
  ```

  Looking at that start unit file it has this content:

  ```
  #! /nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/bash -e
  modprobe wireguard || true



  ip link add dev wg_jl type wireguard

  ip address add 10.8.0.10/32 dev wg_jl

  wg set wg_jl private-key /nix/store/....-wg-key 

  ip link set up dev wg_jl
  ```


  and `ip addr show` also lists the ip:

  ```
  6: wg_jl: <POINTOPOINT,NOARP,UP,LOWER_UP> mtu 1420 qdisc noqueue state UNKNOWN group default qlen 1000
      link/none 
      inet 10.8.0.10/32 scope global wg_jl
         valid_lft forever preferred_lft forever
  ```

  Looking at the unit files `systemctl list-unit-files | grep wireguard` this pop ups:

  ```
  wireguard-wg_jl-peer-…e66I18brnJTKye\x2bYDXS8iQF-zDc\x3d.service enabled        
  wireguard-wg_jl.service                                          enabled 
  ```

  (How to make list-unit-files provide the full name of the file?)

  Looking at the status of the peer unit file **systemctl status wireguard-wg_jl-peer-{public key}.service**, this is returned:

  ```
  systemctl status wireguard-wg_jl-peer-{public key}.service 
  ● wireguard-wg_jl-peer-{public key}.service - WireGuard Peer - wg_jl - {public key}
     Loaded: loaded (/nix/store/f5kp5jammckjcpgjd7r8fa8gh0y5kzrj-unit-wireguard-wg_jl-peer-{public key}.service/wireguard-wg_jl-peer-{public key}.service; enabled>
     Active: failed (Result: exit-code) since Thu 2019-06-27 21:06:59 CEST; 15min ago
    Process: 3206 ExecStart=/nix/store/08ilzr9yicqvb5wz70c3przyl235vy9w-unit-script-wireguard-wg_jl-peer-{public key}-start (code=exited, status=1/FAILURE)
    Process: 3246 ExecStopPost=/nix/store/1j8smpfa9sgib8j4as6lpbsmpz4fcq9k-unit-script-wireguard-wg_jl-peer-{public key}-post-stop (code=exited, status=1/FAILURE)
   Main PID: 3206 (code=exited, status=1/FAILURE)

  Jun 27 21:06:59 servi 08ilzr9yicqvb5wz70c3przyl235vy9w-unit-script-wireguard-wg_jl-peer-{public key}-start[3206]: Name or service not known: `vpn.jus-law.ch:51820'
  Jun 27 21:06:59 servi 1j8smpfa9sgib8j4as6lpbsmpz4fcq9k-unit-script-wireguard-wg_jl-peer-{public key}-post-stop[3246]: Unable to modify interface: No such device
  Jun 27 21:06:58 servi systemd[1]: Starting WireGuard Peer - wg_jl - {public key}...
  Jun 27 21:06:59 servi systemd[1]: wireguard-wg_jl-peer-{public key}.service: Main process exited, code=exited, status=1/FAILURE
  Jun 27 21:06:59 servi systemd[1]: wireguard-wg_jl-peer-{public key}.service: Control process exited, code=exited, status=1/FAILURE
  Jun 27 21:06:59 servi systemd[1]: wireguard-wg_jl-peer-{public key}.service: Failed with result 'exit-code'.
  Jun 27 21:06:59 servi systemd[1]: Failed to start WireGuard Peer - wg_jl - {public key}.
  ```

  The unit file **/nix/store/f5kp5jammckjcpgjd7r8fa8gh0y5kzrj-unit-wireguard-wg_jl-peer-{public key}.service/wireguard-wg_jl-peer-{public key}.service** contains:

  ```
  [Unit]
  After=wireguard-wg_jl.service
  Description=WireGuard Peer - wg_jl - {public key}
  Requires=wireguard-wg_jl.service

  [Service]
  Environment="DEVICE=wg_jl"
  Environment="LOCALE_ARCHIVE=/nix/store/fnr9mys8l5224sqc7vgisgb66s5429f4-glibc-locales-2.27/lib/locale/locale-archive"
  Environment="PATH=/nix/store/0dlzvjdi3hg1wkqb6bwv1aihrxnkcdv8-iproute2-5.1.0/bin:/nix/store/9nss714lk1g40swq51115a4xnxpzndb5-wireguard-tools-0.0.20190601/bin:/nix/store/i4r7xx7sj1bjgvj9p6dv59f1mb329ivw-coreutils-8.31/bin:/nix/store/dbbv$
  Environment="TZDIR=/nix/store/9lyxln5y04lj5vg7npzvid0f8ampva1s-tzdata-2019a/share/zoneinfo"
  Environment="WG_ENDPOINT_RESOLUTION_RETRIES=infinity"



  ExecStart=/nix/store/08ilzr9yicqvb5wz70c3przyl235vy9w-unit-script-wireguard-wg_jl-peer-{public key}-start
  ExecStopPost=/nix/store/1j8smpfa9sgib8j4as6lpbsmpz4fcq9k-unit-script-wireguard-wg_jl-peer-{public key}-post-stop
  RemainAfterExit=true
  Type=oneshot
  ```

  And the ExecStart **/nix/store/08ilzr9yicqvb5wz70c3przyl235vy9w-unit-script-wireguard-wg_jl-peer-{public key}-start** contains:

  ```
  #! /nix/store/w9ngash2dw3pvl98ysd79qy2rkkmc8my-bash-4.4-p23/bin/bash -e
  wg set wg_jl peer {public key} endpoint vpn.domain.tld:51820 persistent-keepalive 25 allowed-ips 10.8.0.0/24
  ip route replace 10.5.0.0/24 dev wg_jl table main
  ```

  So, once the system is up and running, I have to re-issue `systemctl restart 'wireguard-wg_jl-peer-{public key}.service'` and then it works.

  For some reason those peer unit files aren't properly executed - likely because dns isn't available at that point.

  Changein them from oneshot to simple with retry on fail could improve the situation.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.09pre183832.20b993ef2c9 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(hyper): `""`
   - channels(root): `"nixos-19.09pre183832.20b993ef2c9"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: viking: 1.6.2 -> 1.7
user_login: sikmir
html_url: https://github.com/NixOS/nixpkgs/pull/63870
updated_at: 2019-06-27 22:25:14
body:
  ###### Motivation for this change

  [Viking 1.7 - released 2019-01-21](https://github.com/viking-gps/viking/releases/tag/Viking-1.7)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: lib: add mapDir and mapDirFiles
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/pull/63871
updated_at: 2019-07-11 11:16:06
body:
  Adds a function and a convenience function to `lib/filesystems.nix` for mapping a function over a directory.


state: closed
title: clipgrab: 3.8.2 -> 3.8.3
user_login: MarcFontaine
html_url: https://github.com/NixOS/nixpkgs/pull/63872
updated_at: 2019-07-01 20:10:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  clipgrap 3.8.2 no longer works with Youtube
  ###### Things done
  Update clipgrab from 3.8.2 to 3.8.3
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tensorflow: 1.13.1 -> 1.14 + dependencies
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63873
updated_at: 2019-06-27 21:46:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The upgrade part of https://github.com/NixOS/nixpkgs/pull/63616.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk3: 3.24.8 -> 3.24.10, meson!
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63874
updated_at: 2019-07-19 16:54:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  [GTK can now be built with the meson build system](https://gitlab.gnome.org/GNOME/gtk/blob/3.24.9/NEWS#L4).

  ~Did this pretty blindly, not ready for review yet.~

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mesa: fix build Aarch64
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63875
updated_at: 2019-07-09 11:49:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Was failing like

  ```
  meson.build:21:0: ERROR: Options "imx" are not in allowed choices: ", auto, kmsro, radeonsi, r300, r600, nouveau, freedreno, swrast, v3d, vc4, etnaviv, tegra, i915, svga, virgl, swr, panfrost, iris, lima"
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/loki: add module and test
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/63877
updated_at: 2019-07-08 14:30:13
body:
  ##### Things done
  This adds a basic module and a corresponding test for [Loki](https://grafana.com/loki). (follow-up PR of #62641).

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex-media-player: 2.23.0 -> 2.36.0
user_login: solson
html_url: https://github.com/NixOS/nixpkgs/pull/63878
updated_at: 2019-07-03 01:05:50
body:
  ###### Motivation for this change

  Updates Plex Media Player to version 2.36.0.988-0150ae52

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: fix the compilation of .proto on Darwin
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63879
updated_at: 2019-07-08 18:14:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  On Darwin, the last argument to GCC is coming up as an empty string. This is breaking the build of proto_library targets. However, I was not able to reproduce with the example [cpp project](https://github.com/bazelbuild/examples/tree/master/cpp-tutorial/stage3).

  This commit patches the cc_wrapper of Bazel that gets installed on
  Darwin to remove the last argument if it's an empty string. This is
  not a problem on Linux.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @guibou @Profpatsch 


state: closed
title: youtube-dl: 2019.06.21 -> 2019.06.27
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/63880
updated_at: 2019-06-28 15:34:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `youtube-dl` to the latest release.
  https://github.com/ytdl-org/youtube-dl/releases/tag/2019.06.27
  **NOTE**: Updates to `youtube-dl` should be backported, thanks!
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: protobuf3_8: init at 3.8.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63881
updated_at: 2019-07-15 11:34:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/protocolbuffers/protobuf/releases/tag/v3.8.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: syncplay: 1.6.3 -> 1.6.4a, and upgrade dependency from Qt4 to Qt5
user_login: solson
html_url: https://github.com/NixOS/nixpkgs/pull/63882
updated_at: 2019-07-03 06:37:41
body:
  ###### Motivation for this change

  It turns out Syncplay has had support for Qt5 for a while, and automatically detects whether it has access to PySide, which binds Qt4, or PySide2, which binds Qt5. By simply updating the dependencies, we can upgrade Syncplay to Qt5.

  Technically the upgrade to 1.6.4a is independent, but I figured I might as well do both. If there is any reason to keep a separate Qt4 version of Syncplay around, let me know. cc @enzime

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodejs-12_x: 12.4.0 -> 12.5.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63883
updated_at: 2019-07-04 03:52:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/nodejs/node/releases/tag/v12.5.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update `gomuks` to a newer revision
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/63884
updated_at: 2019-06-28 18:06:26
body:
  ## Issue description
  Looks like the current `gomuks` is 9+ months old.

  I took a crack at just updating the rev and sha256, but it looks like it might need a bit more attention (maybe just switching the derivation over to using the Go module functionality?).

  Leaving this mostly as a reminder to come back and look at this again soon.


  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: go-tools: 2019.2 -> 2019.2.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63885
updated_at: 2019-06-30 02:37:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/dominikh/go-tools/releases/tag/2019.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: packr: init at 2.5.1
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63886
updated_at: 2019-07-02 04:01:13
body:
  ###### Motivation for this change

  packr: init at 2.5.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prototool: init at 1.8.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63887
updated_at: 2019-07-01 03:50:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/uber/prototool

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trivial-builders: Fix writeShellScript example
user_login: Kirens
html_url: https://github.com/NixOS/nixpkgs/pull/63888
updated_at: 2019-06-29 21:08:52
body:
  ###### Motivation for this change
  `writeShellScript`, similarly to `writeScript`, results in an executable. However the example seems to imply that the script will be written to destination `name` in the result, which is not the case.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elisa: 0.3.0 -> 0.4.1
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/63889
updated_at: 2019-07-22 07:28:40
body:
  ###### Motivation for this change

  There seems to be something funky going on with QtMultimedia, so we use libvlc instead for the playback which fixes #50726

  Cc: @silverhook
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: factorio: alpha experimental 0.17.32 -> 0.17.52
user_login: priegger
html_url: https://github.com/NixOS/nixpkgs/pull/63890
updated_at: 2019-06-30 20:20:44
body:
  ###### Motivation for this change

  Update factorio experimental to the latest version, which fixes a bunch of bugs.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus-tor-exporter: 0.3 -> 0.4
user_login: priegger
html_url: https://github.com/NixOS/nixpkgs/pull/63891
updated_at: 2019-07-07 20:25:16
body:
  ###### Motivation for this change

  This fixes #63831. From the ticket:

  The prometheus-tor-exporter gives a stack trace and the following error in the journal:

      stem.OperationFailed: Not running in server mode

  This seems to be a "stem 1.7+ compatibility" issue fixed in 0.4.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.robotframework: 3.0.4 -> 3.1.2
user_login: talkara
html_url: https://github.com/NixOS/nixpkgs/pull/63892
updated_at: 2019-07-17 08:08:21
body:
  pythonPackages.robotframework: source file is zip formated

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gomuks: 2018-07-10 -> 2019-06-28
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63893
updated_at: 2019-06-28 18:06:26
body:
  #### Motivation for this change

  gomuks: 2018-07-10 -> 2019-06-28

  Fixes #63884.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/opengl: Don't set XDG_DATA_DIRS.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/63894
updated_at: 2019-07-11 18:26:25
body:
  This was added in #19936 so that vulkan-loader finds the ICD config files. It is
  not needed any more after #62869 where it was ensured that the loader looks in
  /run/opengl-driver(-32)/share.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Remove unnecessary setting of environment variable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  Tested that Vulkan (`vulkaninfo`, `vkcube`) still works with the following drivers: `ati`, `amdgpu`, `intel`, `nvidia`. I could not test `amdgpu-pro` because it's broken in nixos-unstable.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add luna
user_login: turion
html_url: https://github.com/NixOS/nixpkgs/issues/63895
updated_at: 2019-07-01 14:13:38
body:
  Luna is a functional programming language and graphical tool for data analysis. I would expect it to become sort of popular amongst Haskellish and Nixish people, therefore it sounds like a good idea to add it to `nixpkgs`.

  There is an issue to make Luna more nix-friendly: https://github.com/luna/luna-manager/issues/127

  But it seems like we need some more hands to make it work.


state: open
title: Graphical profile wrongly set PulseAudio system-wide
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/issues/63897
updated_at: 2019-07-04 22:40:57
body:
  ## Issue description
  Given the following  in `configuration.nix`:
  ```

  services.xserver = {
        enable = true;
        displayManager.slim.enable = true;
        desktopManager.plasma5 = {
          enable = true;
          enableQt4Support = false;
        };
        videoDrivers = ["intel" "nvidia" ];
        libinput.enable = true; 
      };

      # Enable sound in virtualbox appliances.
    hardware.pulseaudio.enable = true;
    hardware.pulseaudio.systemWide=true;
    sound.enable=true;
    environment.etc."pulse/system.pa".text="load-module pulse/system.pa";
  ```
  Sound still doesn't work,`pacmd list` gives me no PulseAudio daemon or not in execution ad session daemon, while 
  ```
  systemctl status pulseaudio
  ● pulseaudio.service - PulseAudio System-Wide Server
     Loaded: loaded (/nix/store/bwwv93ap5gxx1bxxpqsbhfz9fx5hva5b-unit-pulseaudio.service/pulseaudio.service; enabled; vendor preset: enabled)
     Active: active (running) since Fri 2019-06-28 15:22:00 CEST; 21min ago
   Main PID: 26632 (pulseaudio)
      Tasks: 6 (limit: 4915)
     Memory: 5.8M
     CGroup: /system.slice/pulseaudio.service
             ├─26632 /nix/store/31rrbkcb9cy0i8g249ydbjmd9j82pf4c-pulseaudio-12.2/bin/pulseaudio --daemonize=no --log-level=notice --system -n --file=/nix/store/59rhxwkg4d8ghkkwmgnifbsv57r0dxfd-default.pa
             └─26636 /nix/store/31rrbkcb9cy0i8g249ydbjmd9j82pf4c-pulseaudio-12.2/libexec/pulse/gsettings-helper

  giu 28 15:43:48 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:49 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:50 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:51 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:52 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:53 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:54 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:55 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:56 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  giu 28 15:43:57 nixos pulseaudio[26632]: W: [pulseaudio] protocol-native.c: Denied access to client with invalid authentication data.
  ```

  ### Steps to reproduce
  - Enable sound as above
  -Sound doesn't work


  ## Technical details

  - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.09pre183832.20b993ef2c9 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183832.20b993ef2c9"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: guardian-agent: init at 0.7.2-beta
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/63898
updated_at: 2019-07-16 20:20:01
body:
  ###### Motivation for this change

  guardian-agent: init at 0.7.2-beta

  Fixes #63834.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/kdeconnect:Added programs.kdeconnect option
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/pull/63899
updated_at: 2019-07-03 08:08:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  KdeConnect requires to open TCP and UDP ports to work properly

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/nextcloud: write config to additional config file
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63900
updated_at: 2019-07-21 20:17:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  One of the main problems of the Nextcloud module is that it's currently
  not possible to alter e.g. database configuration after the initial
  setup as it's written by their imperative installer to a file.

  After some research[1] it turned out that it's possible to override all values
  with an additional config file. The documentation has been
  slightly updated to remain up-to-date, but the warnings should
  remain there as the imperative configuration is still used and may cause
  unwanted side-effects.

  Also simplified the postgresql test which uses `ensure{Databases,Users}` to
  configure the database.

  Fixes #49783

  [1] https://github.com/NixOS/nixpkgs/issues/49783#issuecomment-483063922

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: znc: 1.7.3 -> 1.7.4
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63901
updated_at: 2019-06-29 18:28:31
body:
  ###### Motivation for this change
  Update to version 1.7.4
  Changelog - https://wiki.znc.in/ChangeLog/1.7.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: syslog-ng: 3.21.1 -> 3.22.1
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/63902
updated_at: 2019-06-29 18:28:24
body:
  ###### Motivation for this change
  Update to 3.22.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.baselines: 0.1.5 -> 0.1.6
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/63903
updated_at: 2019-06-28 21:23:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump. Unfortunately there is neither a pypi release, nor a github tag (https://github.com/openai/baselines/issues/928).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cc-wrapper: use -iframework instead of -F
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/63904
updated_at: 2019-07-03 21:11:12
body:
  This avoids dumping -Wall warnings when they appear in framework
  headers. As a result, we are closer to how regular headers are
  included (via -isystem).

  Also remove ccIncludeFlag lookup, this was unused & not very useful.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stellarium: 0.19.0 -> 0.19.1
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63905
updated_at: 2019-06-28 22:31:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/Stellarium/stellarium/releases/tag/v0.19.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fractal: fix build with gstreamer 1.16.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63906
updated_at: 2019-06-28 22:43:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Was going to push this one but it takes too long to build :smile: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vivaldi: widevine-support, fixed ffmpeg-support
user_login: betaboon
html_url: https://github.com/NixOS/nixpkgs/pull/63907
updated_at: 2019-06-29 14:11:08
body:
  ###### Motivation for this change
  I wanted widevine-support in vivaldi to enable streaming drm-content (eg. netflix)

  ###### Things done
  - updated vivaldi-ffmpeg-codecs
  - fixed how ffmpeg-codecs is installed (the way vivaldi detects it has changed)
  - packages widevine-cdm from google
  - extended vivaldi to allow installing with widevine support


  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] gnome3.gnome-control-center: fix hardcoded paths
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/63908
updated_at: 2019-06-30 20:00:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes #63820 for what appears to be an issue for 19.03.

  https://github.com/NixOS/nixpkgs/commit/7b8aad4b71bc31044d2c68a07f06d18f7b26a77d is just another backport I thought I should do while I was here.

  cc  @bjornfor 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/63909
updated_at: 2019-06-30 21:18:02
title:
  [r19.03] libvirt: add patches for CVE-2019-10132, CVE-2019-10161, CVE-2019-10166, CVE-2019-10167 & CVE-2019-10168

body:
  ###### Motivation for this change
  Yes, this is indeed every 4.10 commit in the repo _after_ the 4.10.0 release - they don't seem to be in a hurry to release 4.10.1. The fix for CVE-2019-10161 unfortunately breaks the darwin build for me (tested on macos 10.13), so at least having them as separate patches allows me to disable that patch for darwin. I'll open an upstream bug on that once I've also updated/patched `master`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tflint: 0.8.3 -> 0.9.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/63910
updated_at: 2019-06-29 15:13:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/wata727/tflint/releases/tag/v0.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/release-notes: fix bad merge of cargo-vendor entry and formatting
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/63911
updated_at: 2019-07-11 00:14:10
body:
  Fixes the bad merge of #62935 and fixes the overall formatting of the release notes. The inconsistent indentation has always annoyed me, so I decided to try and convert it all to single space, which seems to be the prevailing style.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Mesa Darwin support
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/63912
updated_at: 2019-07-09 17:02:13
body:
  Fixes Mesa on Darwin and simplifies some flags. Should go to staging

  This fixes the darwin build, while also using Meson’s auto features as
  much as possible. As a result, we avoid using having to specify
  default drivers and instead delegate that to Mesa’s build system.
  Removed other flags that were specified to the default in Mesa.

  The -fno-common is needed to address undefined symbol _lp_dummy_tile
  in the build.

  @eadwu 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nodePackages.tedicross: 0.8.7 -> 0.9.1
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/63913
updated_at: 2019-06-29 04:16:09
body:
  #### Motivation for this change

  This upgrades `nodePackages.tedicross` to the latest release.
  Tested and confirmed to work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Drop way-cooler?
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/issues/63914
updated_at: 2019-07-03 16:51:04
body:
  ## Issue description

  Could we drop way-cooler package? I've tested it and it doesn't look like a finished product at this moment. Any users that will be against that? I'm for to re-add it once they make a new release.

  Currently way-cooler is in a mass rewrite state. New version will use wlroots library instead of deprecated wlc, but what's more it will not be compatible with old version (in behaviour and Lua libraries). See https://github.com/way-cooler/way-cooler#development

  cc @primeos @yrashk @miltador 

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: nixos/synapse-bt: init
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/63916
updated_at: 2019-07-13 10:33:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Wanted to run this on my server.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This turned out a more complex than I would have liked, and it still isn't plug and play.

  I can't figure out a nice way to set default values for `services.synapse-bt.config.disk.{session,directory}`. I'd like to set this up using systemd-tmpfiles, but just using `mkDefault` like that doesn't work. Is setting them in the default value for the option okay?


state: closed
title: stow: 2.2.2 -> 2.3.0
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/63917
updated_at: 2019-06-29 14:46:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update stow to latest release `2.3.0`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: macOS Catalina 10.15 Beta
user_login: kirelagin
html_url: https://github.com/NixOS/nixpkgs/issues/63918
updated_at: 2019-06-29 13:02:21
body:
  So, I have just updated to macOS 10.15, and my `/nix` directory is gone. Thanks, apple!

  I’ll keep you posted :/.


state: closed
title: zsh-you-should-use: init at 1.1.0
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/63920
updated_at: 2019-07-09 21:28:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Simple zsh plugin that reminds you to use existing aliases. With
  `oh-my-zsh` it can be installed like this:

  ``` nix
  {
    programs.zsh.ohMyZsh = {
      customPkgs = [ pkgs.zsh-you-should-use ];
      plugins = [ "you-should-use" ];
    };
  }
  ```


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/63921
updated_at: 2019-07-03 19:27:49
title:
  libvirt: 5.3.0 -> 5.4.0 + patches for CVE-2019-10161, CVE-2019-10166, CVE-2019-10167 and CVE-2019-10168

body:
  ###### Motivation for this change
  See also #63909

  Multiple recent CVEs for libvirt (CVE-2019-10161, CVE-2019-10166, CVE-2019-10167 and CVE-2019-10168). Commits fixing these have been made to the repo, but no point release seems to be in sight yet, so adding them as patches after a bump to the most recent version.

  As in #63909, the fix for CVE-2019-10161 unfortunately breaks the darwin build for me (tested on macos 10.13), so I've conditionally disabled it and will raise it as an issue with upstream.

  This includes parallel bumps of `pythonPackages.libvirt` and `perlPackages.SysVirt` as requested in the main `libvirt` package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildGoModule fails to build derivations with more than one subPackage
user_login: gazally
html_url: https://github.com/NixOS/nixpkgs/issues/63923
updated_at: 2019-06-30 05:22:03
body:
  ## Issue description
  When more than one child package is given in subPackages, buildGoModule fails to build the second one.

  ### Steps to reproduce
  Build this derivation:
  ```
  { lib, buildGoModule, fetchFromGitHub }:

  buildGoModule rec {
    pname = "yggdrasil";
    version = "0.3.5";

    src = fetchFromGitHub {
      owner = "yggdrasil-network";
      repo = "yggdrasil-go";
      rev = "v${version}";
      sha256 = "0cbj9hqrgn93jlybf3mfpffb68yyizxlvrsh1s5q21jv2lhhjcwj";
    };

    modSha256 = "1r942mqlq9lqxizxi33768jp4j706mwa2fliz0qbkh98r4ri2292";

    subPackages = [ "cmd/yggdrasilctl" "cmd/yggdrasil"];

    buildFlagsArray = ''
       -ldflags=
           -X github.com/yggdrasil-network/yggdrasil-go/src/yggdrasil.buildVersion=${version}
           -X github.com/yggdrasil-network/yggdrasil-go/src/yggdrasil.buildName=${pname}
           -s -w
    '';

    meta = with lib; {
      description = "An experiment in scalable routing as an encrypted IPv6 overlay network";
      homepage = "https://yggdrasil-network.github.io/";
      license = licenses.lgpl3;
      maintainers = with maintainers; [ gazally lassulus ];
    };
  }
  ```

  Result:
  ```
  can't load package: package cmd/yggdrasil: cannot find package "." in:
          /nix/store/zvi4wy0kzh3iz7db7dl7p7dk1rqf7frj-go-1.12.6/share/go/src/cmd/yggdrasil
  builder for '/nix/store/3v6yv2gf73x9avw5j5jbmg3iksvwci0x-yggdrasil-0.3.5.drv' failed with exit code 1
  error: build of '/nix/store/3v6yv2gf73x9avw5j5jbmg3iksvwci0x-yggdrasil-0.3.5.drv' failed
  ```

  Notes:

  If you reverse the order of the subPackages then the error message will refer to cmd/yggdrasilctl instead.  If you include only one child package in subPackages, the derivation will build, and this:

  ```
  subPackages = [ "./cmd/yggdrasil" "./cmd/yggdrasilctl" ];
  ```
  makes the derivation build correctly.

  The problem is that the `echo "./$subPackages"` line in `getGoDirs` in `pkgs/development/go-modules/generic/default.nix` only adds the `"./"` onto the first item in the list.

  I'd like also to suggest a change to the description for subPackages in the manual, since I found the existing one confusing.  "`subPackages` tells the builder which child packages to build" would be clearer than "`subPackages` limits the builder from building child packages that have not been listed."  Also, since the value in the example for subPackages is `[ "." ]`, it would be nice to have an additional sentence describing what that means and why you would want to use that instead of leaving subPackages unspecified.

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.56, NixOS, 19.03.git.716e973 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173009.2516c454c35"`
   - channels(gem): `"nixos-19.03.173009.2516c454c35"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```


state: open
title: BPF Compiler Collection package broken
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/63924
updated_at: 2019-06-29 15:49:12
body:
  ## Issue description
  None of the tools from `linuxPackages.bcc` seem to actually work

  ### Steps to reproduce

  ```
  [arian@t490s:~]$ nix run nixpkgs.linuxPackages.bcc

  [arian@t490s:~]$ biolatency 
  chdir(/nix/store/5ldvscyj0ms5a730s88r52qx0h1wsgvm-linux-4.19.50-dev/lib/modules/4.19.55/build): No such file or directory
  Traceback (most recent call last):
    File "/nix/store/dld56xqsg19njqs8sb4zliz59xy2v0lb-bcc-0.8.0/share/bcc/tools/.biolatency-wrapped", line 116, in <module>
      b = BPF(text=bpf_text)
    File "/nix/store/dld56xqsg19njqs8sb4zliz59xy2v0lb-bcc-0.8.0/lib/python3.7/site-packages/bcc/__init__.py", line 320, in __init__
      raise Exception("Failed to compile BPF text")
  Exception: Failed to compile BPF text

  [arian@t490s:~]$ tcpconnect 
  chdir(/nix/store/5ldvscyj0ms5a730s88r52qx0h1wsgvm-linux-4.19.50-dev/lib/modules/4.19.55/build): No such file or directory
  Traceback (most recent call last):
    File "/nix/store/dld56xqsg19njqs8sb4zliz59xy2v0lb-bcc-0.8.0/share/bcc/tools/.tcpconnect-wrapped", line 248, in <module>
      b = BPF(text=bpf_text)
    File "/nix/store/dld56xqsg19njqs8sb4zliz59xy2v0lb-bcc-0.8.0/lib/python3.7/site-packages/bcc/__init__.py", line 320, in __init__
      raise Exception("Failed to compile BPF text")
  Exception: Failed to compile BPF text


  ```


  ## Technical details
  Nixos 19.03


state: open
title: redshift-wlroots: init at 1.12
user_login: matthias-t
html_url: https://github.com/NixOS/nixpkgs/pull/63926
updated_at: 2019-07-18 08:14:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Make redshift available on sway and other wlroots based wayland compositors. Can be used in `services.redshift.package`. See also #57602. Please review thoroughly as this is my first contribution and I have no idea what I'm doing.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: add a test asserting java and java proto
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63927
updated_at: 2019-07-08 18:08:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add a test asserting working with Java and compiling a Java protobuf.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvm_7,8: disable libpfm on aarch64
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/63928
updated_at: 2019-06-30 12:20:31
body:
  See https://github.com/nixos/nixpkgs/issues/56245

  Testing: 0 ..
  FAIL: LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest (2933 of 27000)
  ******************** TEST 'LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest' FAILED ********************
  Note: Google Test filter = PerfHelperTest.FunctionalTest
  [==========] Running 1 test from 1 test case.
  [----------] Global test environment set-up.
  [----------] 1 test from PerfHelperTest
  [ RUN      ] PerfHelperTest.FunctionalTest
  /build/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp:37: Failure
        Expected: CallbackEventName
              Which is: ""
              To be equal to: "CYCLES:u"
              /build/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp:38: Failure
              Value of: CallbackEventNameFullyQualifed
              Expected: isn't empty
                Actual: ""
                [  FAILED  ] PerfHelperTest.FunctionalTest (3 ms)
                [----------] 1 test from PerfHelperTest (3 ms total)

  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (3 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] PerfHelperTest.FunctionalTest

   1 FAILED TEST
   invalid event attribute - cannot create event CYCLES:u

  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

  1 warning(s) in tests.
  Testing Time: 108.19s
  ********************
  Failing Tests (1):
      LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest

    Expected Passes    : 25609
      Expected Failures  : 141
        Unsupported Tests  : 1249
          Unexpected Failures: 1
          make[3]: *** [CMakeFiles/check-all.dir/build.make:58: CMakeFiles/check-all] Error 1
          make[3]: Leaving directory '/build/llvm/build'
          make[2]: *** [CMakeFiles/Makefile2:365: CMakeFiles/check-all.dir/all] Error 2
          make[2]: Leaving directory '/build/llvm/build'
          make[1]: *** [CMakeFiles/Makefile2:372: CMakeFiles/check-all.dir/rule] Error 2
          make[1]: Leaving directory '/build/llvm/build'
          make: *** [Makefile:251: check-all] Error 2
          builder for '/nix/store/4kq72x6ahrigryr6yjjj7c7ayqy8z2sl-llvm-7.0.1.drv' failed with exit code 2Testing: 0 ..
          FAIL: LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest (2933 of 27000)
          ******************** TEST 'LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest' FAILED ********************
          Note: Google Test filter = PerfHelperTest.FunctionalTest
          [==========] Running 1 test from 1 test case.
          [----------] Global test environment set-up.
          [----------] 1 test from PerfHelperTest
          [ RUN      ] PerfHelperTest.FunctionalTest
          /build/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp:37: Failure
                Expected: CallbackEventName
                      Which is: ""
                      To be equal to: "CYCLES:u"
                      /build/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp:38: Failure
                      Value of: CallbackEventNameFullyQualifed
                      Expected: isn't empty
                        Actual: ""
                        [  FAILED  ] PerfHelperTest.FunctionalTest (3 ms)
                        [----------] 1 test from PerfHelperTest (3 ms total)

  [----------] Global test environment tear-down
  [==========] 1 test from 1 test case ran. (3 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] PerfHelperTest.FunctionalTest

   1 FAILED TEST
   invalid event attribute - cannot create event CYCLES:u

  ********************
  Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

  1 warning(s) in tests.
  Testing Time: 108.19s
  ********************
  Failing Tests (1):
      LLVM-Unit :: tools/llvm-exegesis/./LLVMExegesisTests/PerfHelperTest.FunctionalTest

    Expected Passes    : 25609
      Expected Failures  : 141
        Unsupported Tests  : 1249
          Unexpected Failures: 1
          make[3]: *** [CMakeFiles/check-all.dir/build.make:58: CMakeFiles/check-all] Error 1
          make[3]: Leaving directory '/build/llvm/build'
          make[2]: *** [CMakeFiles/Makefile2:365: CMakeFiles/check-all.dir/all] Error 2
          make[2]: Leaving directory '/build/llvm/build'
          make[1]: *** [CMakeFiles/Makefile2:372: CMakeFiles/check-all.dir/rule] Error 2
          make[1]: Leaving directory '/build/llvm/build'
          make: *** [Makefile:251: check-all] Error 2
          builder for '/nix/store/4kq72x6ahrigryr6yjjj7c7ayqy8z2sl-llvm-7.0.1.drv' failed with exit code 2

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: systemd: point to commit id instead of branch name
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/63929
updated_at: 2019-06-30 11:47:37
body:
  branch names are mutable, and with
  https://github.com/NixOS/systemd/pull/29 being merged in, the nixos-v242
  branch advanced from 5c20aab77900f478fd380ab189787d80e4a35963 to
  40eb070cb309ec09def0ecdeaf7514c702200835, causing systemd's
  fetchFromGitHub to fail with a sha256sum mismatch (when not relying on
  the cache).

  Fix this, by pointing systemd.src to the commit id before the branch
  advancement. This won't cause a rebuild, as the sha256 stayed the same.

  Fast-forwarding systemd to 40eb070cb309ec09def0ecdeaf7514c702200835 will
  be done in https://github.com/NixOS/nixpkgs/pull/63784 , which also uses
  the commit id, and not a branch name for rev.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] plemora: init at 1.0.0
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/63930
updated_at: 2019-07-03 18:50:56
body:
  My attempt at

  Closes #62820

  **Patches welcome!!!**

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpfpm: revert #63156
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63931
updated_at: 2019-07-03 15:07:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  #63156 introduced incompatible+breaking changes and is causing more issues than anticipated. The module is currently in a state which is hard to understand, has required at least one fix so far (#63867) due to #63156, has unused function arguments, and generally has caused some breakage.

  #63156 is a good change to make, but I think more work needs to be done first. I have taken the first steps toward that by cleaning up the module code so it is more understandable/easier to follow, which will hopefully result in less problems next time running phpfpm without root is attempted.

  Since the first 2 commits are reverts I suggest looking at this PR commit by commit.

  cc @Izorkin as the author of the PR
  cc @dasJ because I used #63842 in this PR

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.xkbcommon template haskell phase is failing
user_login: IvanMalison
html_url: https://github.com/NixOS/nixpkgs/issues/63933
updated_at: 2019-06-30 01:42:34
body:
  ```
  No uhc found
  building
  Preprocessing library for xkbcommon-0.0.3..
  Building library for xkbcommon-0.0.3..
  [ 1 of 13] Compiling Text.XkbCommon.InternalTypes ( dist/build/Text/XkbCommon/InternalTypes.hs, dist/build/Text/XkbCommon/InternalTypes.o )
  [ 2 of 13] Compiling Text.XkbCommon.Context ( dist/build/Text/XkbCommon/Context.hs, dist/build/Text/XkbCommon/Context.o )
  Warning: Can't find file "sys/time.h" in directories
          /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux
          .
    Asked for by: /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux/input.h  at line 13 col 1
  Warning: Can't find file "sys/ioctl.h" in directories
          /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux
          .
    Asked for by: /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux/input.h  at line 14 col 1
  Warning: Can't find file "sys/types.h" in directories
          /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux
          .
    Asked for by: /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux/input.h  at line 15 col 1
  Warning: Can't find file "linux/types.h" in directories
          /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux
          .
    Asked for by: /nix/store/gcfdxwj20x5lni3y66jbg9w59h394df4-linux-headers-4.19.16/include/linux/input.h  at line 16 col 1
  [ 3 of 13] Compiling Text.XkbCommon.KeyboardState ( dist/build/Text/XkbCommon/KeyboardState.hs, dist/build/Text/XkbCommon/KeyboardState.o )
  [ 4 of 13] Compiling Text.XkbCommon.Keymap ( dist/build/Text/XkbCommon/Keymap.hs, dist/build/Text/XkbCommon/Keymap.o )
  [ 5 of 13] Compiling Text.XkbCommon.Keysym ( dist/build/Text/XkbCommon/Keysym.hs, dist/build/Text/XkbCommon/Keysym.o )
  [ 6 of 13] Compiling Text.XkbCommon.KeysymPatterns ( dist/build/Text/XkbCommon/KeysymPatterns.hs, dist/build/Text/XkbCommon/KeysymPatterns.o )
  [ 7 of 13] Compiling Text.XkbCommon.ParseDefines ( Text/XkbCommon/ParseDefines.hs, dist/build/Text/XkbCommon/ParseDefines.o )
  [ 8 of 13] Compiling Text.XkbCommon.ModList ( Text/XkbCommon/ModList.hs, dist/build/Text/XkbCommon/ModList.o )
  [ 9 of 13] Compiling Text.XkbCommon.KeysymList ( Text/XkbCommon/KeysymList.hs, dist/build/Text/XkbCommon/KeysymList.o )
  [10 of 13] Compiling Text.XkbCommon.Constants ( Text/XkbCommon/Constants.hs, dist/build/Text/XkbCommon/Constants.o )
  [11 of 13] Compiling Text.XkbCommon.KeycodeList ( Text/XkbCommon/KeycodeList.hs, dist/build/Text/XkbCommon/KeycodeList.o )

  Text/XkbCommon/KeycodeList.hs:1:1: error:
      Exception when trying to run compile-time code:
        Language/Preprocessor/Cpphs/MacroPass.hs:(96,9)-(97,68): Non-exhaustive patterns in Cmd (Just hd) : _

      Code: runIO genKeycodes >>= return
    |
  1 | {-# LANGUAGE TemplateHaskell #-}
    | ^
  [12 of 13] Compiling Text.XkbCommon.Types ( Text/XkbCommon/Types.hs, dist/build/Text/XkbCommon/Types.o )
  [13 of 13] Compiling Text.XkbCommon   ( Text/XkbCommon.hs, dist/build/Text/XkbCommon.o )
  builder for '/nix/store/pl5ms9648s32rn5p6fv5pdb1ki95ipqm-xkbcommon-0.0.3.drv' failed with exit code 1
  ```

  It seems like the issue is that some of the header files that are expected to be available are not present as part of the derivation. Seems like the relevant header file is linux/input.hs:

  https://github.com/ongy/haskell-xkbcommon/blob/a1455b51c053289b1b5b27d19d4159180647228d/Text/XkbCommon/ParseDefines.hs#L37g 

  If my understanding is correct, what this is doing is basically using the cpp to expand the include directive. I tried adding pkgs.linuxHeaders as a librarySystemDepends but this didn't really help. Can someone with more experience with this sort of thing maybe point me in the right direction w.r.t. how I might make an include directive like that work?


state: closed
title: Language packs are not automatically installed for KDE apps
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/issues/63934
updated_at: 2019-07-12 05:44:25
body:
  ## Issue description

  Language packs for KDE apps are not installed even when the relevant options are installed
  See also https://github.com/NixOS/nixpkgs/issues/3541

  ### Steps to reproduce

  - Add `i18n.defaultLocale="it_IT.UTF_8";environment.systemPackages=[pkgs.ksysguard]`to `/etc/nixos/configutation.nix`
  - `nixos-rebuild switch`
  - See as some menu in KSysGuard entries are in Italian and other are in English.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.09pre183832.20b993ef2c9 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183832.20b993ef2c9"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nodePackages.undollar:init at 1.0.0
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/pull/63935
updated_at: 2019-06-30 00:14:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Undollar is a simple utility to ease copy-pasting scripting

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildGoModule: add ./ to all sub-packages
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/63936
updated_at: 2019-06-30 05:22:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  When $subPackages has more than one item, the build was failing because ./ was added only to the first subPackage. This commit adds ./ to all specified subPackages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  closes #63923

  cc @gazally @worldofpeace


state: closed
title: WakeSystem systemd timer option not working
user_login: xaverdh
html_url: https://github.com/NixOS/nixpkgs/issues/63937
updated_at: 2019-07-01 16:14:13
body:
  ## Issue description
  The `WakeSystem` allows systemd timers to wake up the system from suspend to ram.
  It works when using systemd-run, but *not* when creating a timer in my configuration.nix.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.14, NixOS, 19.09pre183832.20b993ef2c9 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre183832.20b993ef2c9"`
   - channels(pantarhei): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: texmacs: 1.99.2 -> 1.99.10
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/63938
updated_at: 2019-07-03 08:06:36
body:
  Packaging changes:

  * Switch from autoconf to cmake.
    Fixes error
      ```
      checking for guile-config... guile-config
      sh: =~: unknown operand
      ./configure: ./configure.lineno: line 8057: syntax error: bad substitution
      ```
    that appared with the new version.
  * Also add new dependencies for new features: git, python
    * (fixes all "missing" errors in cmake's output)
  * Stay at Qt4 for now to not introduce too many changes
    * Upgrading to Qt5 in the future is feasible (#33248); it builds
    * I'm not doing it here because Qt5 apps apparently don't run yet on non-NixOS

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New release with new features!

  https://github.com/texmacs/texmacs/releases/tag/v1.99.10

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - I ran texmacs on Ubuntu 16.04 in `nix-shell`, it worked as expected
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: keepassxc: 2.4.1 -> 2.4.3
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/63939
updated_at: 2019-07-04 08:17:42
body:
  Upgrade keepassxc to 2.4.3. Full changelog available at
  https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.3.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Steam + Bumblebee?
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/issues/63940
updated_at: 2019-07-17 08:48:34
body:
  ## Issue description

  Seems to be different to #32550

  Game fails to start with error
  ```
  X Error of failed request:  BadValue (integer parameter out of range for operation)
    Major opcode of failed request:  151 (GLX)
    Minor opcode of failed request:  24 (X_GLXCreateNewContext)
    Value in failed request:  0x0
    Serial number of failed request:  22
    Current serial number in output stream:  23
  ```

  ### Steps to reproduce

  1.
  ```nix
  hardware.bumblebee.enable = true;
  environment.systemPackages = with pkgs; [ steam ];
  environment.variables = {
    # to fix "X Error of failed request: BadMatch (invalid parameter attributes)"
    __GLVND_DISALLOW_PATCHING = "1";
  };
  ```
  2. Start Steam from console

  3. Set launch options of the game to `primusrun %command%` https://support.steampowered.com/kb_article.php?ref=6316-GJKC-7437

  4. Run the game

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.09.git.20b993e (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(gnidorah): `""`
   - channels(root): `"nixos-19.09pre172038.5d3fd3674a6"`
   - nixpkgs: `/home/gnidorah/tmp/nixpkgs`


state: open
title: DHCP in initrd
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/issues/63941
updated_at: 2019-07-02 15:12:31
body:
  ## Issue description

  I'm having issues to get dhcp address into the initrd and still have network manager work properly. The reason is I have a native root encrypted zfs notebook that I'd like to reboot remotely. So since the notebook is sometimes at home, sometimes at the office (with different subnets) I need to use dhcp in the initrd, otherwise I can't login remotely.


  ### Steps to reproduce

  Add:

  ```networking.useDHCP```

  to your configuration.nix and enable it. It will provide you with dynamic ip address in the initrd. However, useDHCP and `networking.networkmanager.enable = true;` don't mix so networkmanager has to be disabled. The problem with this approach is that once the system is fully booted (into KDE), there's no network manager available to easily turn on/off eth0, wifi0 etc......

  Another option I tried is to add 

  ```boot.kernelParams = [ "ip=dhcp" ];```

  to the configuration.nix. This works with some caveats: Suddenly my resolv.conf only had as single entry `options edns0` and wasn't able to resolve anything. I had to manually add nameserver x.x.x.x. A little solution was to use SystemD Resolved:

  ```
      services.resolved = {
          enable = true;
          fallbackDns = [ "10.0.0.1" "10.10.10.1" "10.100.100.1" "8.8.4.4" "8.8.8.8" ];
      };
  ```

  That worked with some minor caveats. However the main problem with using `boot.kernelParams = [ "ip=dhcp" ];` was that I just stopped the initrd bootup process waiting to obtain an ip address.

  So, how can I get simple dhcp obtained ip in the initrd while still being able to use network manager later on?

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: clojure: 1.10.0.442 -> 1.10.1.462
user_login: jlesquembre
html_url: https://github.com/NixOS/nixpkgs/pull/63942
updated_at: 2019-07-09 13:29:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updates jdk dependency from 8 to 11. Clojure 1.10.0 added support for
  jdk11, and was released with a new develper tool: REBL
  (https://github.com/cognitect-labs/REBL-distro). REBL depends on javafx,
  currently only supported on Nix by jdk11 (see #63574)

  I also added myself as maintainer and removed @the-kenny, I have the impression he is not interested anymore in maintaining this package.
  @the-kenny can you let me know if that's ok with you? If my assumption was wrong, I'll update the PR to add you back as maintainer. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: git-recent: 1.1.0 -> 1.1.1
user_login: jlesquembre
html_url: https://github.com/NixOS/nixpkgs/pull/63943
updated_at: 2019-06-30 14:43:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  git-recent: 1.1.0 -> 1.1.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mautrix-telegram: 0.5.2 -> 0.6.0
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/63947
updated_at: 2019-07-09 23:07:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Draft pull request in prevision of mautrix-telegram 0.6.0

  Also update:
   * mautrix-appservice: 0.3.10.dev1 -> 0.3.11
   * telethon: 1.6.2 -> 1.9.0 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Simgrid 3.22.2 to 3.23
user_login: mpoquet
html_url: https://github.com/NixOS/nixpkgs/pull/63948
updated_at: 2019-07-08 12:00:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Keep nixpkgs's SimGrid up-to-date.

  ###### Things done
  - Add myself to maintainers.
  - Update SimGrid to latest release, and add myself as a maintainer of this package.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: foswiki: drop package & httpd subservice
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/63949
updated_at: 2019-07-12 00:03:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The `foswiki` package is badly out of date and it is time to deprecate `httpd.extraSubservices` in favor of real modules. Since this package is so badly out of date no one should be using it so it is acceptable to simply drop the package/subservice instead of replacing it with a module. That being said... if anyone is motivated enough to create a `foswiki` module I'm sure that would be welcome.

  For prior work on the topic of deprecating `httpd.extraSubservices` see:
  - https://github.com/NixOS/nixpkgs/pull/57752
  - https://github.com/NixOS/nixpkgs/pull/62175
  - https://github.com/NixOS/nixpkgs/pull/62748
  - https://github.com/NixOS/nixpkgs/pull/63100
  - https://github.com/NixOS/nixpkgs/pull/63844

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libvirt-guests.sh: unable to connect to libvirt
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/issues/63950
updated_at: 2019-07-12 15:17:48
body:
  ## Issue description
  On shutdown, the error prevents my system from properly shutting down, requiring a hard shutdown. Don't actually know if this is what's blocking my system from shutting down since it "exits", but setting `virtualisation.libvirtd.enable = false` gets me a clean shutdown.

  The logs I can spot pertaining to libvirt.
  ```
  Jun 29 17:45:18 nixos systemd[1]: Reloading.
  Jun 29 17:45:18 nixos systemd[1]: libvirtd.service: Current command vanished from the unit file, execution of the command list won't be resumed.
  Jun 29 17:45:18 nixos systemd[1]: libvirt-guests.service: Current command vanished from the unit file, execution of the command list won't be resumed.
  Jun 29 17:45:18 nixos systemd[1]: Stopped target Remote File Systems.
  Jun 29 17:45:18 nixos systemd[1]: Stopped target Local File Systems.
  Jun 29 17:45:18 nixos systemd[1]: Stopped target virt-guest-shutdown.target.
  Jun 29 17:45:18 nixos systemd[1]: Stopping libvirtd.service...
  Jun 29 17:45:18 nixos .libvirtd-wrapp[27257]: internal error: Child process (/nix/store/dqswl7i664qvr89dlc1vfypn8jwpfkm4-iptables-1.8.3/bin/ebtables --concurrent -L) unexpected fatal signal 15
  Jun 29 17:45:18 nixos systemd[1]: libvirtd.service: Succeeded.
  Jun 29 17:45:18 nixos systemd[1]: Stopped libvirtd.service.
  ...
  Jun 29 17:45:19 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 10
  ...
  Jun 29 17:45:24 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 5
  Jun 29 17:45:25 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 4
  Jun 29 17:45:26 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 3
  Jun 29 17:45:27 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 2
  Jun 29 17:45:28 nixos libvirt-guests.sh[651]: Unable to connect to libvirt currently. Retrying .. 1Can't connect to default. Skipping.
  Jun 29 17:45:28 nixos systemd[1]: libvirt-guests.service: Succeeded.
  Jun 29 17:45:28 nixos systemd[1]: Stopped libvirt-guests.service.
  ```

  ### Steps to reproduce
  ```
    virtualisation = {
      libvirtd.enable = true;
    };
  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```markdown
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.15-hardened, NixOS, 19.09.git.5b7e371 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.3pre6779_324a5dc9`
   - channels(root): `"nixos-19.09pre182971.a1dd419c1ff"`
   - nixpkgs: `$HOME/Projects/nixpkgs`
  ```


state: closed
title: linuxPackages_5_0 not working even through it appears with nix search
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/issues/63951
updated_at: 2019-07-02 07:31:11
body:
  ## Issue description

  Even through 
  ```
  nix search linuxPackages_5_0
  * nixpkgs.linuxPackages_5_0.acpi_call (acpi-call-5.0.21)
    A module allowing arbitrary ACPI calls; use case: hybrid video

  * nixpkgs.linuxPackages_5_0.amdgpu-pro (amdgpu-pro-17.40-5.0.21)
    AMDGPU-PRO drivers

  * nixpkgs.linuxPackages_5_0.anbox (anbox-modules-2018-09-08-5.0.21)
    Anbox ashmem and binder drivers.

  * nixpkgs.linuxPackages_5_0.ati_drivers_x11 (ati-drivers-15.12-5.0.21)
    ATI Catalyst display drivers

  * nixpkgs.linuxPackages_5_0.batman_adv (batman-adv-2019.2-5.0.21)
    B.A.T.M.A.N. routing protocol in a linux kernel module for layer 2

  * nixpkgs.linuxPackages_5_0.bbswitch (bbswitch-0.8-5.0.21)
    A module for powering off hybrid GPUs

  * nixpkgs.linuxPackages_5_0.bcc (bcc-0.10.0)
    Dynamic Tracing Tools for Linux

  * nixpkgs.linuxPackages_5_0.beegfs-module (beegfs-module-7.0-5.0.21)
    High performance distributed filesystem with RDMA support

  * nixpkgs.linuxPackages_5_0.bpftrace (bpftrace-0.9)
    High-level tracing language for Linux eBPF

  * nixpkgs.linuxPackages_5_0.broadcom_sta (broadcom-sta-6.30.223.271-5.0.21)
    Kernel module driver for some Broadcom's wireless cards

  * nixpkgs.linuxPackages_5_0.can-isotp (can-isotp-20180629)
    Kernel module for ISO-TP (ISO 15765-2)

  * nixpkgs.linuxPackages_5_0.chipsec (chipsec-1.3.7)
    Platform Security Assessment Framework

  * nixpkgs.linuxPackages_5_0.cpupower (cpupower-5.0.21)
    Tool to examine and tune power saving features

  * nixpkgs.linuxPackages_5_0.cryptodev (cryptodev-linux-1.9-5.0.21)
    Device that allows access to Linux kernel cryptographic drivers

  * nixpkgs.linuxPackages_5_0.deepin-anything (deepin-anything-module-0.1.0-5.0.21)
    Deepin file search tool (kernel modules)

  * nixpkgs.linuxPackages_5_0.dpdk (dpdk-17.11.2-5.0.21)
    Set of libraries and drivers for fast packet processing

  * nixpkgs.linuxPackages_5_0.ena (ena-2.0.2-5.0.21)
    Amazon Elastic Network Adapter (ENA) driver for Linux
  lines 1-50
  ```
  if I add `boot.kernelPackages=pkgs.linuxPackages_5_0;` to `/etc/nixos/configuration.nix` I get
  ```
  sudo nixos-rebuild switch --upgrade                                                                                                                           02:14 Dur  ✔ 
  unpacking channels...
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
  error: The option `documentation.nixos.includeAllModules' defined in `/etc/nixos/configuration.nix' does not exist.
  (use '--show-trace' to show detailed location information)
  building Nix...
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
  building the system configuration...
  warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixos' does not exist, ignoring
  error: The option `documentation.nixos.includeAllModules' defined in `/etc/nixos/configuration.nix' does not exist.
  (use '--show-trace' to show detailed location information)
  ```



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.09pre183832.20b993ef2c9 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixpkgs-19.09pre183832.20b993ef2c9"`
   - channels(paki): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`


