# issues

state: closed
title: haskellPackages.shellFor: Fix ghc calls
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/46453
updated_at: 2018-10-10 12:24:58
body:
  ###### Motivation for this change
  This cost me a couple hours to figure out. The original error was
  ```
  Got error while processing diagnostics: <command line>: cannot satisfy -package-id hnix-0.5.2-5hMz8sQY4ky2OCdjsvbD9J
  ```
  from ghc-mod via [HIE](https://github.com/haskell/haskell-ide-engine). After a very long time of debugging, I finally figured out that the reason was that `shellFor` doesn't run any `shellHook` that sets up the correct `NIX_GHC*` env vars to have it find stuff. This PR just does a dirty fast fix by copying part of the logic in `generic-builder.nix`, please don't merge it like this.

  Ping @peti @ryantm @basvandijk @domenkozar (Ping the people I annoyed for hours in #haskell-ide-engine because of this: @alanz @DanielG)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ranger: 1.9.1 -> 1.9.2
user_login: toonn
html_url: https://github.com/NixOS/nixpkgs/pull/46454
updated_at: 2018-09-10 09:48:50
body:
  ###### Motivation for this change

  Ranger just got a new release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dbeaver: 5.1.6 -> 5.2.0
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/46456
updated_at: 2019-02-12 02:25:38
body:
  ###### Motivation for this change

   * [Updates dbeaver 5.2.0](https://dbeaver.io/2018/09/09/dbeaver-5-2/).

  ###### Things done

  - ✔️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ✔️ NixOS
  - ✔️ Tested execution of all binary files (usually in `./result/bin/`)
  - ✔️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  > *As a side note, #34182 is still open and I will still gladly accept any help in figuring out how to build this using the source release.*


state: closed
title: dbeaver: 5.1.6 -> 5.2.0 (18.09)
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/46457
updated_at: 2019-02-12 02:25:38
body:
  (cherry picked from commit cf3795a25ecbd00e6d5dc7125806fe2785b67afd)

  ###### Motivation for this change

   * [Updates dbeaver 5.2.0](https://dbeaver.io/2018/09/09/dbeaver-5-2/).

  This cherry-picks #46456 

  ###### Things done

  - ✔️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ✔️ NixOS
  - ✔️ Tested execution of all binary files (usually in `./result/bin/`)
  - ✔️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  > *As a side note, #34182 is still open and I will still gladly accept any help in figuring out how to build this using the source release.*


state: closed
title: busybox: 1.29.2 -> 1.29.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/46458
updated_at: 2018-09-10 06:45:12
body:
  Release includes possibly important change,
  reverting a commit causing a regression.

  https://git.busybox.net/busybox/commit/?h=1_29_stable&id=2993551efcb09ace35b40db608ab08159834692b


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/initrd-network: multiple DHCP fixes
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/46459
updated_at: 2018-11-21 07:32:23
body:
   * acquire DHCP on the interfaces with ```networking.interface.$name.useDHCP == true``` or on all interfaces if ```networking.useDHCP == true``` (was only "eth0", it is ```udhcpc```'s default behaviour)
   * respect ```mtu``` if it was in DHCP answer (it happens in the wild, on some hostings)
   * acquire and set up ```staticroutes``` (unlike others clients, ```udhcpc``` does not do the query by default); this supersedes https://github.com/NixOS/nixpkgs/pull/41829

  Shortly, it makes ```initrd-network``` closer to network in stage-2
  It fixes the practical cases where ```initrd-network``` has problems while stage-2 works well.


state: closed
title: dde-calendar: init at 1.2.5
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46460
updated_at: 2018-09-10 09:59:05
body:
  ###### Motivation for this change

  Add [dde-callendar](https://github.com/linuxdeepin/dde-calendar) (calendar for Deepin Desktop Environment).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: dtkwm: init at 2.0.9
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46461
updated_at: 2018-09-10 09:58:22
body:
  ###### Motivation for this change

  Add [dtkwm](https://github.com/linuxdeepin/dtkwm) (Deepint Tool Kit (Dtk) is the base development tool of all C++/Qt Developer work on Deepin).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: pacman: substitute paths in repo-add
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/46462
updated_at: 2018-09-23 19:57:48
body:
  ###### Motivation for this change

  The `repo-add` script assumes `bsdtar` and `openssl` are in the path, causing it to fail on NixOS.

  ###### Things done

  This PR substitutes those instances with the absolute paths.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin-image-viewer: init at 1.2.23
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46463
updated_at: 2018-09-11 13:38:29
body:
  ###### Motivation for this change

  Add [deepin-image-viewer](https://github.com/linuxdeepin/deepin-image-viewer) (Image Viewer for Deepin Desktop Environment).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Using overlays to change nixos module behaviour
user_login: netixx
html_url: https://github.com/NixOS/nixpkgs/issues/46464
updated_at: 2019-06-20 05:48:01
body:
  ## Issue description
  Hello,

  I have been reading about overlays, and I wonder if it is possible to use them to override behaviour of one or more nixos modules. The only examples I have seen with overlays concerned packages (and not nixos modules).

  Say for example, I wanted to implement [this PR](https://github.com/NixOS/nixpkgs/pull/35841) as an overlay because It is specific to my setup, could it be done with overlays ?

  In more details, how could I change `nixos/modules/tasks/network-interfaces-systemd.nix` code (without having to rebase patches on top of nixpks) ? Could overlays do that ?

  Thank you


state: closed
title: bazel: add bazel_jdk10 variant
user_login: uri-canva
html_url: https://github.com/NixOS/nixpkgs/pull/46465
updated_at: 2018-10-15 22:42:07
body:
  ###### Motivation for this change

  To build Java 10 projects with Bazel, it needs to run with Java 10, but Bazel itself can only be built with Java 8.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Why testing kernel always get compiled??? I don't need it.
user_login: unixbhaskar
html_url: https://github.com/NixOS/nixpkgs/issues/46466
updated_at: 2018-12-08 11:36:22
body:
  ## Issue description
  While updating the system.


  ### Steps to reproduce

  this is what basically I run a script 

  `
  nix-channel --update

  printf "\n\n\n${Bright}${Blue} Updating/Upgrading the environment${NOCOLOR} .....\n\n\n"                                              
                                                                                                                                        
  nix-env -u                                                                                                                            
                                                                                                                                    
                                                                                                                                      
                                                                                                                                        
  printf "\n\n\\n${Bright}${Yellow}Okay...lets rebuild the system... and switch to it!${NOCOLOR}\n\n\n"                                 
                                                                                                                                        
  nixos-rebuild switch  --upgrade                                                                                                       
                                                                                                                                        
                                                                                                                                        
  printf "\n\n\n\n${Bright}${Cyan} Cleaning out the garbages from the system${NOCOLOR} ....\n\n\n"                                      

  nix-collect-garbage -d

  `

  ## Technical details
  Well, every time I tried to update the system it brings down the RC kernel and build it, but left a stable kernel in the EFI dir! I am probably missing the essence of NixOS...please shed some light.

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  `
  nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (20.33 MiB download, 219.14 MiB unpacked):
    /nix/store/63j8mi5vjyxfc89rhjknwxaxqg3a2sx2-paxctl-0.9
    /nix/store/6yz7851vibc1xjxpiyfzqqi2ksbv6qah-binutils-wrapper-2.30
    /nix/store/bqp3d4yhpx6h60fv8jww5id0nkm44034-patchelf-0.9
    /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30
    /nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux
    /nix/store/iw94llkj05wgaz268mlzvgx8jkbi1ss0-gcc-wrapper-7.3.0
    /nix/store/kic17fw8wil74k04kzh3dha43izrr9j3-bash-interactive-4.4-p23-dev
    /nix/store/ql3azyviwyc6w73h6prk1j2945skfapf-gnumake-4.2.1
    /nix/store/ynb9h0q59ykdpmsn5m2qrkmnq1p683wr-expand-response-params
  copying path '/nix/store/kic17fw8wil74k04kzh3dha43izrr9j3-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
  copying path '/nix/store/ynb9h0q59ykdpmsn5m2qrkmnq1p683wr-expand-response-params' from 'https://cache.nixos.org'...
  copying path '/nix/store/bqp3d4yhpx6h60fv8jww5id0nkm44034-patchelf-0.9' from 'https://cache.nixos.org'...
  copying path '/nix/store/ql3azyviwyc6w73h6prk1j2945skfapf-gnumake-4.2.1' from 'https://cache.nixos.org'...
  copying path '/nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30' from 'https://cache.nixos.org'...
  copying path '/nix/store/63j8mi5vjyxfc89rhjknwxaxqg3a2sx2-paxctl-0.9' from 'https://cache.nixos.org'...
  copying path '/nix/store/6yz7851vibc1xjxpiyfzqqi2ksbv6qah-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
  copying path '/nix/store/iw94llkj05wgaz268mlzvgx8jkbi1ss0-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
  copying path '/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.18.6, NixOS, 19.03pre151875.7c1b85cf6de (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.1`
   - channels(root): `"nixos-18.03-18.03.133192.45f52f765cd, nixpkgs-19.03pre151875.7c1b85cf6de"`
   - channels(bhaskar): `""`
   - nixpkgs: `/root/.nix-defexpr/channels/nixpkgs`

  `


state: closed
title: Why was `safe-money` renamed to `safe-money_0_7`?
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/46467
updated_at: 2018-09-10 12:13:50
body:
  ## Issue description

  In commit https://github.com/NixOS/nixpkgs/commit/cd35b1cc9c48d2c3b008d14e1bb32823980e4dcd#diff-e4ed6fefa9564bfd27ee249e42e145e2R177732  `safe-money-0.7` was added to the hackage package set, which
  splits up  `safe-money` into `safe-money, safe-money-{aeson,cereal,serialise,xmlbf}`


  However, instead of updating the hash of the original `safe-money` derivation,
  a new derivation was introduced named `safe-money_0_7` and  all the packages
  `safe-money-*` now wrongly depend on `safe-money` instead of `safe-money_0_7`, breaking the builds.

  I'm not very familiar with the whole `hackage2nix` tooling, so I'm wonderng why it created
  a new `safe-money_0_7` package instead of updating the existing one?  And how would I make `hackage2nix` update the original `safe-money` package, instead of creating a new derivation name?


  CC @peti 


  This is currently blocking https://github.com/NixOS/nixpkgs/issues/45960


state: closed
title: ZHF 18.09: fix crypsetup build with python enabled.
user_login: AmineChikhaoui
html_url: https://github.com/NixOS/nixpkgs/pull/46468
updated_at: 2018-09-10 10:29:58
body:
  Fixes https://hydra.nixos.org/build/81028247.

  ###### Motivation for this change
   /cc ZHF #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonmagick: fix build
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46469
updated_at: 2018-09-10 10:18:16
body:
  ###### Motivation for this change

  The original build broke with the following linker issue:

  ```
    CXXLD    _PythonMagick.la
  /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/ld: cannot find -l-L/nix/store/4gh6ynzsd5ndx37hmkl62xa8z30k43y1-imagemagick-6.9.9-34/lib
  collect2: error: ld returned 1 exit status
  ```

  This happens since `BOOST_PYTHON_LIB` wasn't set properly, however
  `_PythonMagick.la` was linked with `-l$(BOOST_PYTHON_LIB)
  $(MAGICK_LIBS)`. With an empty `BOOST_PYTHON_LIB` the linker got
  confused.

  To work around this, the `boost` library directory needs to be specified
  explicitly. To ensure that the changes take effect, the original
  `configure` script shipped with `$src` needs to be removed and recreated
  using the `autoreconfHook`.

  Additionally the `imagemagick` license (https://spdx.org/licenses/ImageMagick.html)
  needs to be added to `lib/licenses.nix` to document the proper license
  of `pythonmagick` in the meta section.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: datadog module version 6: Configuration of modules is not idempotent
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/46470
updated_at: 2018-09-10 09:26:22
body:
  ## Issue description
  A directory `process.d` continues to exist after configuration has been updated destroying the main reason for using NixOS in the first place (idempotence).

  ### Steps to reproduce
  Add
  ```
      services.datadog-agent.checks = {
        process = {
          init_config = null;

          instances = [
            {name = "ssh";
              search_string= ["ssh" "sshd"];
            }
          ];
        };
  };
  ```

  Rebuild machine and then set 
  ```
    services.datadog-agent.checks = {};
  ```

  `stat /etc/datadog-agent/conf.d/process.d` will return the file. 

  Expected exit status of the above command is `1` (a state in which `/etc/datadog-agent/conf.d/process.d` does not exist). 

  ## People
  @rvl 
  @domenkozar 

  ## Technical details

  Applicable to every NixOS version ever released, AFAIK.


state: closed
title: et-book: init at 1.0
user_login: jethrokuan
html_url: https://github.com/NixOS/nixpkgs/pull/46471
updated_at: 2018-09-17 04:32:05
body:
  ###### Motivation for this change

  ET Bembo is a relatively popular font, surprised to see it yet to be packaged in Nixpkgs. The revision given is bogus, this font has not been updated for many years.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: building stack2nix fails
user_login: MMesch
html_url: https://github.com/NixOS/nixpkgs/issues/46472
updated_at: 2018-11-05 20:27:03
body:
  ## Issue description

  installing stack2nix fails with:

  ```
  configuring
  configureFlags: --verbose --prefix=/nix/store/7n21xmqrxsxrkab7hksw30k9iy2kj87g-stack2nix-0.2 --libdir=$prefix/lib/$compiler --libsubdir=$pkgid --with-gcc=gcc --package-db=/tmp/nix-build-stack2nix-0.2.drv-0/package.conf.d --ghc-option=-j8 --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --enable-library-vanilla --enable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/s2n99784krxl91mfw3cnn9ylbb5fjvkx-ncurses-6.1/lib --extra-lib-dirs=/nix/store/rxaclc3vhxbzgfllv7601i85z854h48a-gmp-6.1.2/lib
  Using Parsec parser
  Configuring stack2nix-0.2...
  CallStack (from HasCallStack):
    die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:958:20 in Cabal-2.2.0.1:Distribution.Simple.Configure
    configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:462:12 in Cabal-2.2.0.1:Distribution.Simple.Configure
    configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:596:20 in Cabal-2.2.0.1:Distribution.Simple
    confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.2.0.1:Distribution.Simple.UserHooks
    configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:178:19 in Cabal-2.2.0.1:Distribution.Simple
    defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:115:27 in Cabal-2.2.0.1:Distribution.Simple
    defaultMain, called at Setup.hs:2:8 in main:Main
  Setup: Encountered missing dependencies:
  cabal2nix ==2.10.*

  builder for '/nix/store/b2ym6k4kjbmybwsphfxw8f85h2j7dygx-stack2nix-0.2.drv' failed with exit code 1
  error: build of '/nix/store/b2ym6k4kjbmybwsphfxw8f85h2j7dygx-stack2nix-0.2.drv' failed
  ```

  ### Steps to reproduce

  ```
  $ nix-channel --list
  nixpkgs https://nixos.org/channels/nixpkgs-unstable
  $ nix-channel --update
  unpacking channels...
  created 2 symlinks in user environment
  $ nix-build -A stack2nix '<nixpkgs>'
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.15.0-33-generic, Ubuntu, 16.04.5 LTS (Xenial Xerus)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - channels(matto): `"nixpkgs"`
   - nixpkgs: `/home/matto/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: nixos/doc: Add stable pre-release warning
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/46473
updated_at: 2018-09-11 13:43:20
body:
  ###### Motivation for this change
  Add a note to hopefully dissuade users from picking the newest nixos-XX.YY channel without checking that it has been released.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: datadog-agent: 6.1.4 -> 6.4.2
user_login: domenkozar
html_url: https://github.com/NixOS/nixpkgs/pull/46474
updated_at: 2018-09-11 22:10:12
body:
  - bump package
  - build more integrations
  - add README how to update datadog

  TODO:
  - [x] systemd integrations fails (this was a permission error on my side)
  - [x] live process monitoring doesn't work (needs a separate package https://github.com/NixOS/nixpkgs/issues/46520)
   
  Fixes https://github.com/NixOS/nixpkgs/issues/46142


state: closed
title: openbsm: fix linux build
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46475
updated_at: 2018-09-10 21:00:02
body:
  ###### Motivation for this change

  See https://hydra.nixos.org/build/80705916

  To fix the linux build the patch `bsm-add-audit_token_to_pid.patch`
  mustn't be applied during Linux builds, only for Darwin as it's an
  Apple-only fix.

  The compiler failure occurred because `audit_token_t` is part of
  `<mach/mach.h>` which is not available on Linux.

  Addresses #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parallel: cleanup
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/46476
updated_at: 2018-10-02 16:26:26
body:
  ## Issue description

  Noticed build failure in derivation using parallel (the attribute/project name), and looking at it:

  * Wut re:trailing slash for line continuation that doesn't continue
  * Not wrapped properly: shebang isn't patched so fails since no /usr/bin/env in sandbox.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: haskellPackages.callCabal2nix has no way to specify cabal2nix flags
user_login: Taneb
html_url: https://github.com/NixOS/nixpkgs/issues/46477
updated_at: 2018-09-11 09:22:10
body:
  ## Issue description
  Often when developing Haskell with nix, we want to specify cabal flags. There's currently `haskell.lib.(en/dis)ableCabalFlag`, but this can't change the build inputs, which causes frustrating breakages. The solution to this is to pass the flag to `cabal2nix`. `haskellSrc2nix` already has the `extraCabal2nixOptions` parameter, which does exactly this, but there's no way to prapogate this from `callCabal2nix`.


state: open
title: building stackage-curator fails
user_login: MMesch
html_url: https://github.com/NixOS/nixpkgs/issues/46478
updated_at: 2018-09-10 11:18:12
body:
  ## Issue description

  fails with

  ```
  Preprocessing library for stackage-curator-0.16.0.0..
  Building library for stackage-curator-0.16.0.0..
  [ 1 of 22] Compiling Stackage.Types   ( Stackage/Types.hs, dist/build/Stackage/Types.o )

  Stackage/Types.hs:401:10: error:
      • No instance for (Semigroup SimpleDesc)
          arising from the superclasses of an instance declaration
      • In the instance declaration for ‘Monoid SimpleDesc’
      |
  401 | instance Monoid SimpleDesc where
      |          ^^^^^^^^^^^^^^^^^
  builder for '/nix/store/2ljfpa2ci5yp8s10s01g0x5bz7y5zvwa-stackage-curator-0.16.0.0.drv' failed with exit code 1
  error: build of '/nix/store/2ljfpa2ci5yp8s10s01g0x5bz7y5zvwa-stackage-curator-0.16.0.0.drv' failed
  ```

  (full [log](https://github.com/NixOS/nixpkgs/files/2366328/log.txt))

  ### Steps to reproduce

  ```
  nix-build -A haskellPackages.stackage-curator '<nixpkgs>'
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.15.0-33-generic, Ubuntu, 16.04.5 LTS (Xenial Xerus)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - channels(matto): `"nixpkgs"`
   - nixpkgs: `/home/matto/.nix-defexpr/channels/nixpkgs
  ```


state: closed
title: safe-money: Fix dependencies for safe-money-*
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/pull/46479
updated_at: 2018-09-20 14:43:44
body:
  ###### Motivation for this change

  `safe-money-*` all depend on `safe-money-0.7`, but hackage2nix made them incorrectly
  depend on `safe-money-0.6`.   In `safe-money-0.7` the `safe-money` package was split up
  into multiple packages. This is why this occurred.

  We should be able to remove this 'hack' as soon as the new Stackage LTS
  comes out, as safe-money-0.7 will then be the default version.

  fixes #46467 
  cc #45960 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nix.nixPath documentation needs to be better
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/46480
updated_at: 2019-02-13 22:29:51
body:
  ## Issue description
  `nix.nixPath` does not specify what it considers to be valid entries. E.g.:
  - are only absolute paths allowed or not? 
  - Can one specify `nixpkgs=<foo/nixpkgs>`?

  Does order matter?

  Existing documentation:

  ```
  The default Nix expression search path, used by the Nix evaluator to look up paths enclosed in angle brackets (e.g. <nixpkgs>).

  Type: list of strings

  Default: [ "nixpkgs=/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs" "nixos-config=/etc/nixos/configuration.nix" "/nix/var/nix/profiles/per-user/root/channels" ]

  Declared by:

  <nixpkgs/nixos/modules/services/misc/nix-daemon.nix>
  ```
  ## Technical details

  Applicable to all versions of NixOS.


state: closed
title: earlyoom: fix version number
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/46481
updated_at: 2018-09-10 12:32:15
body:
  ###### Motivation for this change
  Before:
  ```
  $ nix run nixpkgs.earlyoom -c earlyoom -h
  earlyoom (unknown version)
  Usage: earlyoom [-m PERCENT] [-s PERCENT] [-k|-i] [-h]
  -m ... set available memory minimum to PERCENT of total (default 10 %)
  -s ... set free swap minimum to PERCENT of total (default 10 %)
  -k ... use kernel oom killer instead of own user-space implementation
  -i ... user-space oom killer should ignore positive oom_score_adj values
  -d ... enable debugging messages
  -v ... print version information and exit
  -h ... this help text
  ```
  After:
  ```
  $ nix run nixpkgs.earlyoom -c earlyoom -h
  earlyoom 0.11
  Usage: earlyoom [-m PERCENT] [-s PERCENT] [-k|-i] [-h]
  -m ... set available memory minimum to PERCENT of total (default 10 %)
  -s ... set free swap minimum to PERCENT of total (default 10 %)
  -k ... use kernel oom killer instead of own user-space implementation
  -i ... user-space oom killer should ignore positive oom_score_adj values
  -d ... enable debugging messages
  -v ... print version information and exit
  -h ... this help text
  ```

  earlyoom's Makefile attempts to detect the current version using git,
  but we don't keep .git in its source, so this fails. We can however
  set the VERSION environment variable to override this, as we now do.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after): no change
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: WIP: haskell: Make linkWithGold use gold also for compiling Setup.hs
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/46482
updated_at: 2019-02-24 16:09:46
body:
  ###### Motivation for this change

  `linkWithGold` only uses `ld.gold` for the final link, not for building `Setup.hs` (which currently takes up to ~3 seconds on my machine for each Haskell package, which can add up to some time.)

  ###### This doesn't work yet

  This is WIP because it segfaults.

  If I try it on the `hello` Haskell package, I get a segfault when running `./Setup`:

  ```
  niklas@ares:/tmp/nix-build-hello-1.0.0.2.drv-1/hello-1.0.0.2$ ./Setup 
  Segmentation fault (core dumped)
  ```

  `gdb` shows:

  ```
  Program received signal SIGSEGV, Segmentation fault.
  0x0000000000000000 in ?? ()
  (gdb) bt
  #0  0x0000000000000000 in ?? ()
  #1  0x00007ffff7ad0c81 in frame_dummy ()
     from /nix/store/254rgj92dhkyg7sydb7al65gflnyjd7b-gmp-6.1.2/lib/libgmp.so.10
  #2  0x0000000000000000 in ?? ()
  ```

  and when I compile with `integer-simple`:

  ```
  Program received signal SIGSEGV, Segmentation fault.
  0x0000000000000000 in ?? ()
  (gdb) bt
  #0  0x0000000000000000 in ?? ()
  #1  0x000000000040ac7d in frame_dummy ()
  #2  0x0000000000000000 in ?? ()
  ```

  Not sure what's going on, why does the `Setup` segfault if linked with `ld.gold`?

  CC @basvandijk @peti 


state: closed
title: lxqt: move contents of base, core and optional to parent directory
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46484
updated_at: 2018-09-11 01:00:57
body:
  ###### Motivation for this change

  Move the contents of the `base`, `core` and `optional` subdirectories of `pkgs/desktops/lxqt/` to the parent directory. There are not that many packages for LXQt and keeping them together would be easier to work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: govendor: init at 1.0.9
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/46485
updated_at: 2018-09-10 16:59:10
body:
  ###### Motivation for this change

  needed govendor

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix Antimony
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/46486
updated_at: 2019-02-22 16:09:09
body:
  ###### Motivation for this change
  Fix for #45960 

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change (none)
  - [x] Tested the program
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Paperwork 1.2.4
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/46487
updated_at: 2019-05-18 16:01:41
body:
  ###### Motivation for this change
  update (most of these updates could be made standalone. tell me if you want to split.)

  ###### Things done

  The new home for paperwork is the gnome gitlab instance, but they have an unusual namespacing. Instead of the "traditional" owner/repo url, there are three levels: group/owner/repo: https://gitlab.gnome.org/World/OpenPaperwork/paperwork

  I have adapted `fetchFromGitLab` to take an optional `group` argument.

  I have checked that I can still scan/ocr succesfully with paperwork.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`) (just paperwork)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  cc @aszlig as maintainer.


state: closed
title: pythonPackages.{pydub,readme_renderer,pyfakefs,us,restview}: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46488
updated_at: 2018-09-13 09:42:10
body:
  ###### Motivation for this change

  Fix some random python packages for #45960.

  ###### Things done

  - [x] Built on NixOS in a sandbox
  - [x] passes nix-review
  ---


state: open
title: nixos: sound: warn about changes to defaults
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/46490
updated_at: 2018-09-23 17:40:53
body:
  ###### Motivation for this change

  I still think that change needs to be reverted, but if there's no will for that let's at the very least warn users about the problem that change introduced. Without this most ALSA users switching from releases before 18.03 will get sound, but won't get ALSA state save/restore. That would be very confusing.

  All modules and tests that want to be completely headless disable this option explicitly. I.e. you won't see this warning unless you are affected.

  ###### Things done

  - [X] Tested to work as expected.

  Please backport to 18.09.


state: closed
title: ammonite: 1.1.2 -> 1.2.0
user_login: oscarvarto
html_url: https://github.com/NixOS/nixpkgs/pull/46492
updated_at: 2018-09-11 09:26:10
body:
  ###### Motivation for this change

  Bumping ammonite version to 1.2.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -A ammonite`, then executing `amm`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  First PR to nixpkgs. I still don't know how to follow lots of the above checks. Will follow instructions if necessary.


state: closed
title: perlPackages: ZHF 18.09
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/46493
updated_at: 2018-09-10 20:15:13
body:
  ###### Motivation for this change

  ZHF 18.09 https://github.com/NixOS/nixpkgs/issues/45960

  ###### Things done

   * ```perlXXXPackages.MojoIOLoopForkCall``` fixed by undoing https://github.com/NixOS/nixpkgs/commit/471b3f1dec0a077748083d181660c0c6ddd21086 (not sure if we have do this)

   * ```perlXXXPackages.Connector``` tests fail in sandbox, got passed without sandbox

   * ```perl528Packages.MojoIOLoopForkCall``` failed with `-Werror=format-security`, hardening disabled


state: closed
title: networking.hostId: fix cmd in description
user_login: erikarvstedt
html_url: https://github.com/NixOS/nixpkgs/pull/46495
updated_at: 2018-09-11 09:40:37
body:
  Pad the hex literal with leading zeros to the required length of 8 bytes (32 bit).

  #### Question to reviewers:
  As `/etc/machine-id` is already a random, lower-case hex string, why not just use `head -c 8 /etc/machine-id`?


state: closed
title: vimPlugins: Fix update.py, add/update plugins
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/46496
updated_at: 2018-09-12 06:55:28
body:
  ###### Motivation for this change
  The `update.py` script in latest `master` was generating wrong `generated.nix` - the `repo` attr would have `.` replaced by `-`.(because `plugin.name` contains the name with `.` replaced by `-`). Refs #46394 
  Note, that `easymotion` vim plugin has been moved to easymotion/easymotion

  cc @Mic92 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bunny: 1.2 -> 1.3
user_login: buffet
html_url: https://github.com/NixOS/nixpkgs/pull/46498
updated_at: 2018-09-10 20:56:07
body:
  ###### Motivation for this change
  Newer version came out. This makes it available.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zsh: 5.6 -> 5.6.1
user_login: hrdinka
html_url: https://github.com/NixOS/nixpkgs/pull/46499
updated_at: 2018-09-12 07:38:53
body:
  ###### Motivation for this change

  This is a follow up to #46452 by @dtzWill

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pytestflakes: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46500
updated_at: 2018-09-11 09:17:06
body:
  ###### Motivation for this change

  ZHF #45960

  - disable a failing test case that looks broken
  - remove pytestcache depencency that was dropped upstream

  ###### Things done

  - [x] built on NixOS in a sandbox


state: closed
title: perl-Module-Build-XSUtil: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46501
updated_at: 2018-09-11 14:43:00
body:
  ###### Motivation for this change

  Fixes the darwin build.

  While building the tests LD gets called with -mmacosx-version-min=10.10
  which is a CC flag, causing the build to fail with LD=ld.  This is
  pretty common with perl packages.

  /cc ZHF #45961

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aws-vault: 4.1.0 -> 4.3.0, pass linker flag for specifying app version
user_login: ento
html_url: https://github.com/NixOS/nixpkgs/pull/46503
updated_at: 2018-09-11 16:23:54
body:
  ###### Motivation for this change

  Among other things, brings in fixes for compilation issues:

  - [v4.3.0](https://github.com/99designs/aws-vault/releases/tag/v4.3.0)
     > Update go-keychain to resolve Go 1.11 compilation issue
  - [v4.2.1](https://github.com/99designs/aws-vault/releases/tag/v4.2.1)
     > compatibility with go 1.10
  - [v4.2.0](https://github.com/99designs/aws-vault/releases/tag/v4.2.0)

  The linker flag makes it so that you get back the correct version string when you specify `--version`:

  ```sh
  $ aws-vault --version
  v4.3.0
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: taskjuggler: 3.5.0 -> 3.6.0
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/46504
updated_at: 2018-09-11 08:14:43
body:
  ###### Motivation for this change

  Seems to be fine with Ruby 2.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pulseaudio-modules-bt: init at unstable-2018-09-11
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/46505
updated_at: 2018-09-11 02:37:35
body:
  ###### Motivation for this change
  I want to use LDAC

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] ~~macOS~~
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I'm using this way on NixOS:
  ```nix
    hardware.pulseaudio = {
      enable = true;
      # Replace built in pulseaudio modules with enhanced bluetooth ones
      package = with pkgs; pulseaudioFull.overrideAttrs(oldAttrs: {
        postInstall = oldAttrs.postInstall + ''

          cp -a ${pulseaudio-modules-bt}/* $out/
        '';
      });
    };
  ```


state: open
title: adding widevine CDM support for qutebrowser
user_login: furrycatherder
html_url: https://github.com/NixOS/nixpkgs/issues/46506
updated_at: 2018-12-22 20:21:04
body:
  ## Issue description

  I have a package, `widevine-cdm`, mostly taken from the Chromium plugin:

  https://gist.github.com/73880669d67a02fcb64e447f8c077fc9

  And an overlay for `qutebrowser`:

  ```nix
  { pkgs ? import <nixpkgs> {} }:

  with pkgs;

  rec {
    qutebrowser = pkgs.qutebrowser.overrideAttrs (super: {
      propagatedBuildInputs = super.propagatedBuildInputs ++ [ widevine-cdm ];
      postFixup = ''
        ${super.postFixup}
        wrapProgram $out/bin/qutebrowser --add-flags "--set qt.args [ppapi-widevine-path=${widevine-cdm}/usr/lib/qt/plugins/ppapi/libwidevinecdmadapter.so]"
      '';
    });
  }
  ```

  But trying to watch Netflix gets me this error:

  ```
  [1:1:0910/214639.789895:ERROR:ppapi_thread.cc(317)] Failed to load Pepper module from /nix/store/9mqb31wvfx7wqargrh245h33gp3myir0-widevine-cdm-18.0.0.233/usr/lib/qt/plugins/ppapi/libwidevinecdmadapter.so (error: /nix/store/9mqb31wvfx7wqargrh245h33gp3myir0-widevine-cdm-18.0.0.233/usr/lib/qt/plugins/ppapi/libwidevinecdmadapter.so: cannot open shared object file: Operation not permitted)
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.69, NixOS, 19.03.git.571c6c6 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.1`
   - channels(sean): `"nixos-19.03pre151837.ca2ba44cab4"`
   - channels(root): `"nixos-19.03pre151837.ca2ba44cab4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: bazel-watcher: init at 4d5928e
user_login: kalbasit
html_url: https://github.com/NixOS/nixpkgs/pull/46509
updated_at: 2018-09-27 23:45:09
body:
  ###### Motivation for this change

  Tools for building Bazel targets when source files change. https://github.com/bazelbuild/bazel-watcher

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: installer: refactor
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46510
updated_at: 2018-09-23 18:12:50
body:
  ###### Motivation for this change
  Borrow the harmless refactoring in https://github.com/NixOS/nixpkgs/pull/42610

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.03] firefox: provide clang configure flags on i686
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/46511
updated_at: 2018-09-11 11:02:33
body:
  ###### Motivation for this change

  With the upgrade to firefox 62 (and potentially before) clang flags are now required on i686.

  This might just work as it is. I haven't had the time to run/check for rebuilds. I intend to do that in the evening / during the day.

  It seems that this would also be required on stable and the 18.09 release branch.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskell lib: add --enable-benchmarks in doBenchmark
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/46512
updated_at: 2018-09-18 13:04:28
body:
  ###### Motivation for this change
  `doBenchmark` adds the dependencies for benchmarks to be built, but does not actually build them. This is surprising - I would think that anyone setting this flag wants the build to check that the benchmarks build. They still aren't executed, but that's expensive and should probably indeed be done separately.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: texFunctions: Fix lhs2tex helper derivation
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/pull/46513
updated_at: 2018-09-11 10:03:42
body:
  The package lhs2tex function was moved to haskellPackages.lhs2tex
  quite some time ago, and  stdenv.bash does not exist anymore either.
  This simply seems to have been a case of code rot of code that
  wasn't used in quite a long time.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: headphones: init at 0.5.19
user_login: rembo10
html_url: https://github.com/NixOS/nixpkgs/pull/46514
updated_at: 2019-02-18 02:53:33
body:
  ###### Motivation for this change
  Add [headphones](https://github.com/rembo10/headphones) package and service for NixOS. I can add myself as a maintainer - I just wasn't sure if I should do that with this pull request or separately. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.khard: zsh autocompletion
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/46515
updated_at: 2018-10-04 06:29:46
body:
  'cos that's cool

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fetchNuGet: Add support for sha512
user_login: baracoder
html_url: https://github.com/NixOS/nixpkgs/pull/46516
updated_at: 2018-09-17 12:44:49
body:
  ###### Motivation for this change

  The goal is helping to package dotnet projects similar to `node2nix` or `pypi2nix`

  After `dotnet restore`, produces the file `project.assets.json` listing each nuget package with `sha512`.   `fetchurl` supports `sha512`, so it is  just forwarded.
  Using this, an expression can be created containing all nuget dependencies.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  There are no packages yet which would use sha512 in fetchNuGet, so I have tested this way:

  ```
  nix repl .
  Added 9404 variables.

  nix-repl> :b dotnetPackages.Fake 
  ```
  Which still builds and uses the cache.

  I have tested with the same version and sha512 [here](https://github.com/baracoder/dotnet2nix/blob/3493bf1608e6b939e022efa5b219c7b34575630b/default.nix#L9-L50)

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] ~~Tested execution of all binary files (usually in `./result/bin/`)~~
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert build host target platform deprecation on master
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/46517
updated_at: 2018-09-12 21:19:58
body:
  ###### Motivation for this change
  Unblocks nixpkgs.tarball
  https://github.com/NixOS/nixpkgs/pull/46059#issuecomment-419576235

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert build host target platform deprecation on release-18.09
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/46518
updated_at: 2018-09-11 23:55:06
body:
  ###### Motivation for this change
  Unblocks nixpkgs.tarball on release-18.09
  https://github.com/NixOS/nixpkgs/pull/46146#issuecomment-419457689

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.git-extras: install zsh completion
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/46519
updated_at: 2018-09-29 05:51:02
body:
  because there are so many freaking commands !

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: WIP/feedback request: add SSB tale:net
user_login: cryptix
html_url: https://github.com/NixOS/nixpkgs/pull/46521
updated_at: 2019-02-24 16:09:40
body:
  ###### Motivation for this change

  Opening this as a source-version of #46062 and to gather feedback on the approach. I'm still fairly novice in writing nix expressions and derivations but @NinjaTrappeur suggested I take over patchwork since I'm familiar with the project as a whole and have built an electron client myself. @samueldr also suggested in [this comment](https://github.com/NixOS/nixpkgs/pull/46062#issuecomment-419602936) that a source version would be preferable.

  [tale:net](https://t4l3.net/concept/) is not http://github.com/ssbc/patchwork/ but very similar in architecture and spirit. They are both based on http://scuttlebutt.nz/ and are electron apps. Once I figure out the remaining questions, I can adapt the same recipe for patchwork and [patchbay](https://github.com/ssbc/patchbay/)

  Also: This depends on #45997 but could be decoupled. I thought it would just be easier to test this with both new packages present.

  ps: See #46000 for two standalone tools without electron

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Question:

  * Is the _node2nix sub package_ approach sane?

  Previously, I just used [this shell.nix](https://github.com/talenet/talenet/tree/master/shell.nix) to develop. In it, I can run `npm i && npm run build` (which is an alias for `node .electron-vue/build.js && electron-builder`) and `run dev` to make builts and development versions.

  I discussed with @NinjaTrappeur that this invovles fetching a pre-built electron version from npmjs.com. I'd rather not do this.

  In principle it is enough to run `node .electron-vue/build.js && cd ./dist/electron && electron .` and this can work on archlinux, when all the node and electron ABI versions correctly line up.

  I'm having trouble understanding how to do the `npm i && node .electron-vue/build.js ` with node2nix, though. I generated the env from the source package.json and made some changes to it so that it doesn't import nixpkgs twice. The output looks fine but I'm not sure yet how to copy `node_modules` into this `out/` or if I should run the `node .electron-vue/build.js` in the embedded node env.

  * re #45997: is `propagateBuildInputs` the correct method to have this package as a runtime-dependency to talenet or should add something to the fixupPhase of the node-env?


state: closed
title: zsh-history-substring-search: init at 1.0.1
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/46522
updated_at: 2018-11-02 11:21:58
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linphone: enable gtk ui
user_login: stesie
html_url: https://github.com/NixOS/nixpkgs/pull/46523
updated_at: 2018-09-11 22:10:38
body:
  ###### Motivation for this change

  Linphone voip client currently depends on Gtk, yet the Gtk-based UI is *not* currently available.  This passes `ENABLE_GTK_UI=ON` to actually enable it.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openssl: 1.1.0 -> 1.1.1
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/46524
updated_at: 2018-09-13 13:09:11
body:
  ###### Motivation for this change

  From https://www.openssl.org/blog/blog/2018/09/11/release111/:

  > OpenSSL 1.1.1 is API and ABI compliant with OpenSSL 1.1.0 so most applications that work with 1.1.0 can gain many of the benefits of TLSv1.3 simply by dropping in the new OpenSSL version.

  Added `openssl_1_0` and `openssl_1_1` aliases because that's the level of granularity packages almost certainly want, and will make future upgrades like this much easier.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zeronet: Fix TOR permissions, add torAlways option
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/pull/46525
updated_at: 2018-09-16 21:41:28
body:
  (cherry picked from commit 9c97f37761a5eaa7387aabcd2c3cc631a2b712a3)
  ###### Motivation for this change
  As per @joachifm 's request.
  Fixing an important zeronet feature for a new release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dart: 1.24.3 -> 2.0.0
user_login: bitmappergit
html_url: https://github.com/NixOS/nixpkgs/pull/46526
updated_at: 2018-09-11 17:40:06
body:
  ###### Motivation for this change

  The Dart VM supplied by nixpkgs has been outdated for quite a while, and needed to be updated.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: open-vm-tools: /etc/os-release is too large
user_login: rawtaz
html_url: https://github.com/NixOS/nixpkgs/issues/46527
updated_at: 2018-09-22 11:17:52
body:
  ## Issue description
  The `vmwareGuest` service fails to start, giving the following error messages in ``/var/log/vmware-vmsvc.log``:
  ~~~
  [Sep 11 14:50:09.578] [ warning] [vmsvc] HostinfoReadDistroFile: input buffer too small
  [Sep 11 14:50:09.578] [ warning] [vmsvc] HostinfoOSData: Error: no distro file found
  [Sep 11 14:50:09.578] [ warning] [guestinfo] Failed to get OS info.
  ~~~

  ### Steps to reproduce
  - Install a fresh copy of NixOS 18.03 in a VM under VMware Fusion 10.1.3 on macOS 10.12.x.
  - Configure relevant parts in `/etc/nixos/configuration.nix`, e.g.:
  ~~~
  # Edit this configuration file to define what should be installed on
  # your system.  Help is available in the configuration.nix(5) man page
  # and in the NixOS manual (accessible by running ‘nixos-help’).

  { config, pkgs, ... }:

  {
    imports =
      [ # Include the results of the hardware scan.
        ./hardware-configuration.nix
      ];

    # Use the GRUB 2 boot loader.
    boot.loader.grub.enable = true;
    boot.loader.grub.version = 2;
    # boot.loader.grub.efiSupport = true;
    # boot.loader.grub.efiInstallAsRemovable = true;
    # boot.loader.efi.efiSysMountPoint = "/boot/efi";
    # Define on which hard drive you want to install Grub.
    boot.loader.grub.device = "/dev/sda"; # or "nodev" for efi only

    # networking.hostName = "nixos"; # Define your hostname.
    # networking.wireless.enable = true;  # Enables wireless support via wpa_supplicant.

    # Select internationalisation properties.
    # i18n = {
    #   consoleFont = "Lat2-Terminus16";
    #   consoleKeyMap = "us";
    #   defaultLocale = "en_US.UTF-8";
    # };

    # Set your time zone.
    # time.timeZone = "Europe/Amsterdam";

    # List packages installed in system profile. To search, run:
    # $ nix search wget
    environment.systemPackages = with pkgs; [
      mkpasswd
      vim
      rxvt_unicode
      firefox
    ];

    # Some programs need SUID wrappers, can be configured further or are
    # started in user sessions.
    # programs.bash.enableCompletion = true;
    # programs.mtr.enable = true;
    # programs.gnupg.agent = { enable = true; enableSSHSupport = true; };

    # List services that you want to enable:

    # Enable the OpenSSH daemon.
    services.openssh.enable = true;

    # Open ports in the firewall.
    # networking.firewall.allowedTCPPorts = [ ... ];
    # networking.firewall.allowedUDPPorts = [ ... ];
    # Or disable the firewall altogether.
    # networking.firewall.enable = false;

    # Enable CUPS to print documents.
    # services.printing.enable = true;

    # Enable sound.
    # sound.enable = true;
    # hardware.pulseaudio.enable = true;

    # Enable the X11 windowing system.
    # services.xserver.enable = true;
    # services.xserver.layout = "us";
    # services.xserver.xkbOptions = "eurosign:e";

    # Enable touchpad support.
    # services.xserver.libinput.enable = true;

    # Enable the KDE Desktop Environment.
    # services.xserver.displayManager.sddm.enable = true;
    # services.xserver.desktopManager.plasma5.enable = true;

    # Define a user account. Don't forget to set a password with ‘passwd’.
    users.extraUsers.rawtaz = {
      isNormalUser = true;
      uid = 1000;
      extraGroups = ["wheel"];
    };

    # This value determines the NixOS release with which your system is to be
    # compatible, in order to avoid breaking some software such as database
    # servers. You should change this only after NixOS release notes say you
    # should.
    system.stateVersion = "18.03"; # Did you read the comment?

    services.vmwareGuest.enable = true;
    services.vmwareGuest.headless = true;
    services.xserver.enable = true;
    services.xserver.windowManager.i3.enable = true;
    services.xserver.displayManager.lightdm.enable = true;
  }
  ~~~

  ## Technical details
  ~~~
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.67, NixOS, 18.03.133192.45f52f765cd (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ~~~

  ## Further comments and workaround
  Based on the code in https://github.com/vmware/open-vm-tools/blob/3a0205478e242bd672356d4eab6272d3b901fe6e/open-vm-tools/lib/misc/hostinfoPosix.c#L932 it seems that the contents of the file `/etc/os-release`, which is scanned by `open-vm-tools`, is simply too large:
  ~~~
  NAME=NixOS
  ID=nixos
  VERSION="18.03.133192.45f52f765cd (Impala)"
  VERSION_CODENAME=impala
  VERSION_ID="18.03.133192.45f52f765cd"
  PRETTY_NAME="NixOS 18.03.133192.45f52f765cd (Impala)"
  HOME_URL="https://nixos.org/"
  SUPPORT_URL="https://nixos.org/nixos/support.html"
  BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
  ~~~

  I tested that by creating a file `/etc/release` (which is also scanned by `open-vm-tools`), with only part of the contents:
  ~~~
  NAME=NixOS
  ID=nixos
  VERSION="18.03.133192.45f52f765cd (Impala)"
  VERSION_CODENAME=impala
  VERSION_ID="18.03.133192.45f52f765cd"
  PRETTY_NAME="NixOS 18.03.133192.45f52f765cd (Impala)"
  ~~~

  After a few seconds, when the `vmwareGuest` service tries to start again, there's only one of the previously three error messages in ``/var/log/vmware-vmsvc.log``:
  ~~~
  [Sep 11 14:50:09.578] [ warning] [vmsvc] HostinfoReadDistroFile: input buffer too small
  ~~~

  The `vmwareGuest` service started, the above error message is for the still remaining and too large `/etc/os-release` file (to verify, let the contents of `/etc/release` be identical to that of `/etc/os-release` and notice that the other error messages comes back in the log file).


state: closed
title: pdsh: set default module to ssh, remove obsolete fixes
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/46528
updated_at: 2018-09-29 09:00:39
body:
  ###### Motivation for this change
  Having `rsh` the default connection mechanism seems outdated (and unsafe).

  CC @peti for review and testing

  ###### Things done

  * Set default remote module to ssh
  * Remove `-lgcc_s` hack (seems not needed anymore?).
  * Remove `pam` dependency, is not recognized by configure
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: open-vm-tools: Shared folders not working
user_login: rawtaz
html_url: https://github.com/NixOS/nixpkgs/issues/46529
updated_at: 2019-02-18 09:54:55
body:
  ## Issue description
  Trying to enable shared folders in a NixOS 18.03 VM running under VMware Fusion 10.1.3 on macOS 10.12.x yields the following in `/var/log/vmware-vmsvc.log`:
  ~~~
  [Sep 11 15:22:27.541] [ warning] [vix] ToolsDaemonTcloMountHGFS: vmhgfs-fuse -> not available
  [Sep 11 15:22:27.542] [ message] [vix] ToolsDaemonTcloMountHGFS: no mount point found, create /mnt/hgfs
  [Sep 11 15:22:27.543] [ warning] [vix] ToolsDaemonTcloMountHGFS: failed to find mount -> 2
  [Sep 11 15:22:27.543] [ message] [vix] ToolsDaemonTcloMountHGFS: returning 20050 2
  ~~~

  After creating the directory `/mnt/hgfs` as requested in the error message above, the problem remains:
  ~~~
  [Sep 11 15:27:43.081] [ warning] [vix] ToolsDaemonTcloMountHGFS: vmhgfs-fuse -> not available
  [Sep 11 15:27:43.082] [ warning] [vix] ToolsDaemonTcloMountHGFS: failed to find mount -> 2
  [Sep 11 15:27:43.082] [ message] [vix] ToolsDaemonTcloMountHGFS: returning 20050 2
  ~~~

  Along with the error messages in the log file mentioned above, Fusion gives an error message dialog saying "Unable to update run-time folder sharing status: There was an error mounting the Shared Folders filesystem inside the guest operating system".

  Manually mounting a shared folder works, see below.

  ### Steps to reproduce
  - Install NixOS 18.03 in a VM running under VMware Fusion 10.1.3 on macOS 10.12.x.
  - Configure relevant parts in `/etc/nixos/configuration.nix`, e.g.:
  ~~~
  # Edit this configuration file to define what should be installed on
  # your system.  Help is available in the configuration.nix(5) man page
  # and in the NixOS manual (accessible by running ‘nixos-help’).

  { config, pkgs, ... }:

  {
    imports =
      [ # Include the results of the hardware scan.
        ./hardware-configuration.nix
      ];

    # Use the GRUB 2 boot loader.
    boot.loader.grub.enable = true;
    boot.loader.grub.version = 2;
    # boot.loader.grub.efiSupport = true;
    # boot.loader.grub.efiInstallAsRemovable = true;
    # boot.loader.efi.efiSysMountPoint = "/boot/efi";
    # Define on which hard drive you want to install Grub.
    boot.loader.grub.device = "/dev/sda"; # or "nodev" for efi only

    # networking.hostName = "nixos"; # Define your hostname.
    # networking.wireless.enable = true;  # Enables wireless support via wpa_supplicant.

    # Select internationalisation properties.
    # i18n = {
    #   consoleFont = "Lat2-Terminus16";
    #   consoleKeyMap = "us";
    #   defaultLocale = "en_US.UTF-8";
    # };

    # Set your time zone.
    # time.timeZone = "Europe/Amsterdam";

    # List packages installed in system profile. To search, run:
    # $ nix search wget
    environment.systemPackages = with pkgs; [
      mkpasswd
      vim
      rxvt_unicode
      firefox
    ];

    # Some programs need SUID wrappers, can be configured further or are
    # started in user sessions.
    # programs.bash.enableCompletion = true;
    # programs.mtr.enable = true;
    # programs.gnupg.agent = { enable = true; enableSSHSupport = true; };

    # List services that you want to enable:

    # Enable the OpenSSH daemon.
    services.openssh.enable = true;

    # Open ports in the firewall.
    # networking.firewall.allowedTCPPorts = [ ... ];
    # networking.firewall.allowedUDPPorts = [ ... ];
    # Or disable the firewall altogether.
    # networking.firewall.enable = false;

    # Enable CUPS to print documents.
    # services.printing.enable = true;

    # Enable sound.
    # sound.enable = true;
    # hardware.pulseaudio.enable = true;

    # Enable the X11 windowing system.
    # services.xserver.enable = true;
    # services.xserver.layout = "us";
    # services.xserver.xkbOptions = "eurosign:e";

    # Enable touchpad support.
    # services.xserver.libinput.enable = true;

    # Enable the KDE Desktop Environment.
    # services.xserver.displayManager.sddm.enable = true;
    # services.xserver.desktopManager.plasma5.enable = true;

    # Define a user account. Don't forget to set a password with ‘passwd’.
    users.extraUsers.rawtaz = {
      isNormalUser = true;
      uid = 1000;
      extraGroups = ["wheel"];
    };

    # This value determines the NixOS release with which your system is to be
    # compatible, in order to avoid breaking some software such as database
    # servers. You should change this only after NixOS release notes say you
    # should.
    system.stateVersion = "18.03"; # Did you read the comment?

    services.vmwareGuest.enable = true;
    services.vmwareGuest.headless = true;
    services.xserver.enable = true;
    services.xserver.windowManager.i3.enable = true;
    services.xserver.displayManager.lightdm.enable = true;
  }
  ~~~
  - Apply the workaround in #46527 to make the vmwareGuest service start at all.
  - Try to enable the Shared Folders feature by enabling the checkbox for it in the VM's settings.
  - Notice the error messages mentioned above.

  ## Technical details
  ~~~
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.67, NixOS, 18.03.133192.45f52f765cd (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ~~~

  ## Further comments and workaround
  The error messages in the log above says "vmhgfs-fuse -> not available". I'm not sure if that means it doesn't find the `vmhgfs-fuse` binary, or if that binary is reporting an error, but either way, that binary exists and works when one try to mount a shared folder manually:
  ~~~
  # which vmhgfs-fuse
  /run/current-system/sw/bin/vmhgfs-fuse

  # vmhgfs-fuse .host:/dotfiles /mnt/hgfs

  # mount
  <snip>
  vmhgfs-fuse on /mnt/hgfs type fuse.vmhgfs-fuse (rw,nosuid,nodev,relatime,user_id=0,group_id=0)
  ~~~

  The manually mounted folder works fine. It's just the automatic mounting that doesn't work.


state: closed
title: Updating and adding all dependencies of future openstack sdk modules pull request
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46531
updated_at: 2018-10-08 15:20:31
body:
  ###### Motivation for this change

  I am trying to package the openstack python modules. `oslo.config`, `oslo.db`, and `openstacksdk` have ALOT of dependencies that are not currently packaged in nix. Along the way I have move all dependencies that were in `python-packages.nix` to `python-modules/....`. There are a lot of package in this commit (sorry and it there is any what that I can make this easier please let me know). This set of commits prepares all the dependencies for openstack modules.

  I followed best practices. Testing was always used unless it created a circular dependency or was not packaged in the pypi repository. Otherwise tests were added to the package if it did not exist.

  To help with code review here all all the package versions that need to be built with GrahmcOfBorg.

  ```
  python27Packages.pathlib2
  python27Packages.ddt
  python27Packages.testrepository
  python27Packages.enum34
  python27Packages.eventlet
  python27Packages.ipaddress
  python27Packages.jmespath
  python27Packages.mock
  python27Packages.monotonic
  python27Packages.munch
  python27Packages.netaddr
  python27Packages.netifaces
  python27Packages.nose
  python27Packages.oauthlib
  python27Packages.warlock
  python27Packages.fasteners
  python27Packages.mox3
  python27Packages.traceback2
  python27Packages.linecache2
  python27Packages.pep8
  python27Packages.testscenarios
  python27Packages.paramiko
  python27Packages.prettytable
  python27Packages.pyinotify
  python27Packages.subunit
  python27Packages.xattr
  python27Packages.unittest2
  python27Packages.unicodecsv
  python27Packages.python-json-logger
  python27Packages.daiquiri
  python27Packages.python-coveralls
  python27Packages.flake8-polyfill
  python27Packages.flake8-docstrings
  python27Packages.runtest
  python27Packages.hacking
  python27Packages.reno
  python27Packages.cliff
  python27Packages.debtcollector
  python27Packages.stestr

  python36Packages.pathlib2
  python36Packages.ddt
  python36Packages.testrepository
  python36Packages.enum34
  python36Packages.eventlet
  python36Packages.ipaddress
  python36Packages.jmespath
  python36Packages.mock
  python36Packages.monotonic
  python36Packages.munch
  python36Packages.netaddr
  python36Packages.netifaces
  python36Packages.nose
  python36Packages.oauthlib
  python36Packages.warlock
  python36Packages.fasteners
  python36Packages.mox3
  python36Packages.traceback2
  python36Packages.linecache2
  python36Packages.pep8
  python36Packages.testscenarios
  python36Packages.paramiko
  python36Packages.prettytable
  python36Packages.pyinotify
  python36Packages.subunit
  python36Packages.xattr
  python36Packages.unittest2
  python36Packages.unicodecsv
  python36Packages.python-json-logger
  python36Packages.daiquiri
  python36Packages.python-coveralls
  python36Packages.flake8-polyfill
  python36Packages.flake8-docstrings
  python36Packages.runtest
  python36Packages.hacking
  python36Packages.reno
  python36Packages.cliff
  python36Packages.debtcollector
  python36Packages.stestr
  ```

  ###### Things done

  See individual commits for more detail.

  pythonPackages.pathlib2: refactor add testing all pass 
  pythonPackages.ddt: 1.0.0 -> 1.2.0
  pythonPackages.testrepository: refactor move to python-modules 
  pythonPackages.enum34: refactor move to python-modules 
  pythonPackages.eventlet: 0.20.0 -> 0.24.1
  pythonPackages.ipaddress: 1.0.18 -> 1.0.22
  pythonPackages.jmespath: 0.9.0 -> 0.9.3 
  pythonPackages.mock: refactor
  pythonPackages.monotonic: 1.3 -> 1.5
  pythonPackages.munch: refactor move to python-modules 
  pythonPackages.netaddr: refactor
  pythonPackages.netifaces: 0.10.6 -> 0.10.7
  pythonPackages.nose: refactor add meta move to python-modules 
  pythonPackages.oauthlib: 2.0.0 -> 2.1.0
  pythonPackages.warlock: 1.2.0 -> 1.3.0 
  pythonPackages.fasteners: refactor move to python-modules
  pythonPackages.mox3: 0.23.0 -> 0.26.0 
  pythonPackages.traceback2: refactor move to python-modules
  pythonPackages.linecache2: refactor move to python-modules
  pythonPackages.pep8: refactor move to python-modules
  pythonPackages.testscenarios: 0.4 -> 0.5.0
  pythonPackages.paramiko: refactor move to python-modules
  pythonPackages.prettytable: 0.7.1 -> 0.7.2
  pythonPackages.pyinotify: refactor move to python-modules 
  pythonPackages.subunit: 1.0.0 -> 1.3.0 
  pythonPackages.xattr: 0.7.8 -> 0.9.6 
  pythonPackages.unittest2: refactor move to python-modules
  pythonPackages.unicodecsv: refactor move to python-modules
  pythonPackages.python-json-logger: init at 0.1.9 
  pythonPackages.daiquiri: init at 1.5.0
  pythonPackages.python-coveralls: init at 2.9.1
  pythonPackages.flake8-polyfill: init at 1.0.2
  pythonPackages.flake8-docstrings: init at 1.3.0
  pythonPackages.runtest: init at 2.1.0
  pythonPackages.hacking: init at 1.1.0
  pythonPackages.reno: init at 2.10.0
  pythonPackages.cliff: init at 2.13.0
  pythonPackages.debtcollector: init at 1.20.0
  pythonPackages.stestr: init at 2.1.1


  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dart: 1.24.3 -> 2.0.0
user_login: bitmappergit
html_url: https://github.com/NixOS/nixpkgs/pull/46533
updated_at: 2018-09-30 21:44:06
body:
  ###### Motivation for this change
  Dart SDK version was outdated, updated to newest stable version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: misc pkgs: Darwin -> Linux cross compilation
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46534
updated_at: 2018-10-26 01:47:18
body:
  ###### Motivation for this change

  Carefully changed to not be a mass rebuild, I'll clean up after (or @oxij can call me out :)). Glibc patches delayed temporarily, but musl works fine.

  Fixes #27934

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC @3noch @periklis


state: closed
title: qutebrowser: Fix patching of standarddir.py
user_login: The-Compiler
html_url: https://github.com/NixOS/nixpkgs/pull/46535
updated_at: 2018-09-11 21:17:13
body:
  The original patch was broken since https://github.com/qutebrowser/qutebrowser/commit/a85e19a5e1ae6792159fe0922ee5ba57815df132 because an `APPNAME` variable was introduced there.

  I haven't done any testing at all, as I'm not a NixOS user (I'm the upstream maintainer).

  cc @abbradar who introduced the patching in 9b4a7984a4803ed5ab9c9515682778444370eb01


state: closed
title: Channels are not setup correctly in 18.09 OVA
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/46536
updated_at: 2019-01-25 02:10:44
body:
  ## Issue description
  Running the virtualbox image for NixOS 18.09, hit this usability issue.

  ### Steps to reproduce

  1. Download the .ova file from 
  https://releases.nixos.org/nixos/18.09/nixos-18.09beta78.6f3bd5db2f4/nixos-18.09beta78.6f3bd5db2f4-x86_64-linux.ova
  2. Start it up in VirtualBox.
  3. Once logged in, open a Konsole.
  4. Run ```nix run nixos.firefox -c firefox```.

  This results in:

  ```
  error: attribute 'nixos' in selection path 'nixos.firefox' not found
  ```

  On the other hand running this works as expected:

  ```
  nix run firefox -f /nix/var/nix/profiles/per-user/root/channels/nixos -c firefox
  ```

  ## Technical details

  Default NIX_PATH:

  ```
  [demo@nixos:~]$ echo $NIX_PATH
  /home/demo/.nix-defexpr/channels:nixpkgs=/nix/var/nix/profiles/per-user/root/channels/nixos:nixos-config=/etc/nixos/configuration.nix:/nix/var/nix/profiles/per-user/root/channels
  ```


state: closed
title: No obvious way to view manual in NixOS 18.09 VirtualBox image
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/46537
updated_at: 2018-09-23 23:45:04
body:
  ## Issue description

  Running the virtualbox image for NixOS 18.09, hit this usability issue.

  ### Steps to reproduce

  1. Download the .ova file from
  https://releases.nixos.org/nixos/18.09/nixos-18.09beta78.6f3bd5db2f4/nixos-18.09beta78.6f3bd5db2f4-x86_64-linux.ova
  2. Start it up in VirtualBox.
  3. Once logged in, click on the KDE menu.
  4. Click "Applications" -> "System" -> "View NixOS documentation in a web browser".

  KDE asks what to use to open the .html file. No real option is available, you will have to install it yourself.

  ### Possible solution

  It would make sense to include a simple browser for graphical users. Alternatively, package documentation as a PDF and include a PDF reader.


state: closed
title: sickgear: init at 0.17.5
user_login: rembo10
html_url: https://github.com/NixOS/nixpkgs/pull/46538
updated_at: 2018-09-13 15:28:17
body:
  ###### Motivation for this change
  Added [sickgear](https://github.com/SickGear/SickGear) package and nixos module. I can add myself as a maintainer on the next version bump and once #46514 is merged

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: KDE "Help Center" not working
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/46539
updated_at: 2018-09-23 23:46:36
body:
  ## Issue description

  Running the virtualbox image for NixOS 18.09, hit this usability issue.

  ### Steps to reproduce

  1. Download the .ova file from
  https://releases.nixos.org/nixos/18.09/nixos-18.09beta78.6f3bd5db2f4/nixos-18.09beta78.6f3bd5db2f4-x86_64-linux.ova
  2. Start it up in VirtualBox.
  3. Once logged in, open the help center from the KDE menu: "Applications" -> "Help Center"
  4. Try to open a few pages, resulting in:

  ```
  The requested help file could not be parsed:<br />/run/current-system/sw/share/doc/HTML/en//kcontrol/splashscreen/index.docbook
  ```


state: closed
title: perl-TestRunCmdLine: disable tests on darwin
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46540
updated_at: 2018-09-11 20:04:49
body:
  ###### Motivation for this change

  Fixes freecell-solver and possibly other builds.

  /cc ZHF #45961

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/initrd: Add thin-provisioning-tools binaries
user_login: YorikSar
html_url: https://github.com/NixOS/nixpkgs/pull/46541
updated_at: 2018-09-13 18:07:26
body:
  ###### Motivation for this change

  This enables usage of thin and cache volumes without ugly hacks (see #15516). With my conifiguration on 18.03, size of initrd before this change is 12470611 and after is 13542353, only 8.6% increase.

  These files are added to extra-utils:

  ```
  lrwxrwxrwx      11 result/bin/cache_check -> pdata_tools
  lrwxrwxrwx      11 result/bin/cache_dump -> pdata_tools
  lrwxrwxrwx      11 result/bin/cache_metadata_size -> pdata_tools
  lrwxrwxrwx      11 result/bin/cache_repair -> pdata_tools
  lrwxrwxrwx      11 result/bin/cache_restore -> pdata_tools
  lrwxrwxrwx      11 result/bin/era_check -> pdata_tools
  lrwxrwxrwx      11 result/bin/era_dump -> pdata_tools
  lrwxrwxrwx      11 result/bin/era_invalidate -> pdata_tools
  lrwxrwxrwx      11 result/bin/era_restore -> pdata_tools
  -r-xr-xr-x 1350576 result/bin/pdata_tools
  lrwxrwxrwx      11 result/bin/thin_check -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_delta -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_dump -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_ls -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_metadata_size -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_repair -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_restore -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_rmap -> pdata_tools
  lrwxrwxrwx      11 result/bin/thin_trim -> pdata_tools
  -r-xr-xr-x    7016 result/lib/libaio.so.1
  -r-xr-xr-x  221072 result/lib/libexpat.so.1
  -r--r--r--  100608 result/lib/libgcc_s.so.1
  -r-xr-xr-x 1558864 result/lib/libstdc++.so.6
  ```

  Fixes #15516


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dhcpcd: No need to hack around broken patchShebangs anymore
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46542
updated_at: 2018-09-11 23:03:20
body:
  ###### Motivation for this change

  Now that https://github.com/NixOS/nixpkgs/pull/43833 has landed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfs-unstable: 2018-09-02 -> 0.8.0-rc1
user_login: phryneas
html_url: https://github.com/NixOS/nixpkgs/pull/46543
updated_at: 2018-09-15 19:26:15
body:
  ###### Motivation for this change

  zfs 0.8.0-rc1 was released.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
    - `nix-build nixos/tests/zfs.nix -A unstable `
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: glibc: Use lib.enableFeature and friends
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46544
updated_at: 2018-09-11 21:51:12
body:
  ###### Motivation for this change

  Cleaning things up to get them out of the way for #46534.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pants: fix build
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46545
updated_at: 2018-09-11 21:32:47
body:
  ###### Motivation for this change

  See https://hydra.nixos.org/build/80727495

  `pants' works with requests==2.19 to build successfully and `nixpkgs' currently uses `requests==2.19.1`.
  Patching the version constraint in `setup.py' accordingly fixes the problem.

  Addresses #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: glibc: Use lib.enableFeature and friends for 18.09
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46546
updated_at: 2018-09-11 21:51:12
body:
  ###### Motivation for this change

  Backport of #46544

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: git2r: add SSH support
user_login: ivanbrennan
html_url: https://github.com/NixOS/nixpkgs/pull/46547
updated_at: 2018-09-18 22:27:46
body:
  Add `libssh2.dev` as a native build input to the git2r R module.

  ###### Motivation for this change

  When building the devtools R module, which depends on git2r, it reports that libssh2 cannot be found, and falls back to building without SSH support. Adding libssh2.dev to git2r's native build inputs fixes this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aria2: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46548
updated_at: 2018-09-11 22:17:00
body:
  Not released yet, see https://github.com/aria2/aria2/issues/1198

  /cc ZHF #45961

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.pyowm: fix python3 build
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46549
updated_at: 2018-09-12 11:22:14
body:
  ###### Motivation for this change

  See https://hydra.nixos.org/build/80714323

  Version 2.9 requires `geojson==2.x'. To allow 2.4, the constraint
  required some patching using `substituteInPlace'.

  Addresses #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add licenses
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/46550
updated_at: 2018-09-20 21:00:33
body:
  ###### Motivation for this change
  Another set for https://github.com/NixOS/nixpkgs/issues/43716

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scs: Fix darwin build
user_login: knedlsepp
html_url: https://github.com/NixOS/nixpkgs/pull/46551
updated_at: 2018-09-12 19:26:51
body:
  ###### Motivation for this change
  This fixes the darwin build of scs.
  /cc ZHF #45961


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Allow doCheck config of buildGoPackage
user_login: ramirez7
html_url: https://github.com/NixOS/nixpkgs/pull/46552
updated_at: 2018-10-06 03:45:25
body:
  ###### Motivation for this change
  Golang derivations created with `buildGoPackage` do not run tests upon `nix-build`. This PR exposes a `doCheck` arg that gets propagated to the derivation (it is `false` by default)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
    - Unsure how to do this? But the change is backwards-compatible
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [Golang] Link src root w/package path prefix in nix-shell
user_login: ramirez7
html_url: https://github.com/NixOS/nixpkgs/pull/46553
updated_at: 2019-07-03 20:08:02
body:
  ###### Motivation for this change
  A `buildGoPackage` derivation does not have its project root
  linked correctly in `$GOPATH` within `nix-shell`. This causes
  `go build/run/test` to all fail. `$PWD` is on `$GOPATH`, but the
  code there is not nested under a directory matching the
  import path, so imports fail.

  ###### Things done
  Modify `buildGoPackage`'s `shellHook` to `ln` project root under the package path of directories. **I used `$PWD` for project root, but I'm unsure if there's a better way to do that.**

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Feature/git annex remote google
user_login: poelzi
html_url: https://github.com/NixOS/nixpkgs/pull/46554
updated_at: 2018-09-18 17:15:19
body:
  ###### Motivation for this change

  add git-annex-remote-googledrive. This remote has more features then the rclone remote and allows you to export a repository to google drive.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia-x11: Fix vulkan VK_KHR_xcb_surface
user_login: danme
html_url: https://github.com/NixOS/nixpkgs/pull/46555
updated_at: 2018-09-23 20:28:44
body:
  ###### Motivation for this change

  Fixes the issue: https://github.com/NixOS/nixpkgs/issues/39149

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qutebrowser: patch all python scripts
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/46556
updated_at: 2019-02-23 09:37:52
body:
  ###### Motivation for this change
  Try to patch python scripts once and for all.
  This adds all the remaining dependencies needed by qutebrowser {user,}scripts.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change
  - [x] Tested compilation of all pkgs that depend on this change (mitmproxy fails but was already broken)
  - [x] Tested execution of all binary files
  - [x] Determined the impact on package closure size (≈1.03)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md) (new python modules need a maintainer).

  ---

  cc: @dustinlacewell (thank you for reporting the issue)


state: closed
title: iproute: add $dev output
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/46558
updated_at: 2018-09-12 12:55:04
body:
  to provide the user API include/ that was previously dropped.

  ###### Motivation for this change

  I needed some of the declaration there. It's not a big deal to copy/paste them but still there should be no need.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lollypop: wrap search provider
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46559
updated_at: 2018-09-14 03:26:04
body:
  ###### Motivation for this change
  The gnome search provider was not wrapped at `$out/libexec/lollypop-sp`.

  Also #43742 died of staleness :smile: 

  > @jtojnar 
  > Maybe using python.pkgs.buildPythonApplication would be better

  I've made this change :+1: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: eolie: 0.9.35 -> 0.9.36
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46560
updated_at: 2018-09-12 23:46:17
body:
  An update and use `buildPythonApplication`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix for pytorch-0.4.1 cuda-enabled build.
user_login: akamaus
html_url: https://github.com/NixOS/nixpkgs/pull/46562
updated_at: 2018-09-23 07:36:33
body:
  As reported at #46032 pytorch build currently fails. The reason, I believe, is ongoing pytorch and libcaffe merge and related dependencies problems. Basically this patch fixes hard-coded dependency inside build directory.

  Also openblas was updated because autograd tests failed with older version, see https://github.com/pytorch/pytorch/issues/11133. Patches were merged into upstream and no longer necessary.

  - Built on platform(s)
     - [ X] NixOS


state: closed
title: pythonPackages.Nikola: 7.8.15 -> 8.0.1
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/46564
updated_at: 2018-10-21 09:01:37
body:
  ###### Motivation for this change

  Upgrade Nikola to 8.0.0 and also add/update some dependencies.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: syncthing: 0.14.48 -> 0.14.50
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/46565
updated_at: 2018-09-13 10:47:39
body:
  ###### Motivation for this change

  Upgrade syncthing.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.ncm2: init at 2018-09-03
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/46566
updated_at: 2018-09-13 17:38:20
body:
  ###### Motivation for this change

  This is the new version of nvim-completion-manager. Should we remove the old plugin?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nano-wallet: 15.2 -> 16.0
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/46567
updated_at: 2018-09-15 14:51:29
body:
  ###### Motivation for this change

  Upgrade Nano cryptocurrency wallet.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mendeley: add custom citation styles
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/46568
updated_at: 2018-09-13 06:55:45
body:
  ## Issue description
  I try to change in mendeley the citation style to "ACM" so mendeley tries to fetch it and install it but of course it won't since it can't write in the store (I guess that's where it tries to write).


  ![mendeley](https://user-images.githubusercontent.com/886074/45415210-18233b80-b6b8-11e8-8714-d9523d0b4577.png)


  ### Steps to reproduce

   Click on View -> Citation style (https://www.mendeley.com/guides/using-citation-editor/06-changing-citation-styles)


state: open
title: i18n.defaultLocale is not respected in many programs
user_login: turion
html_url: https://github.com/NixOS/nixpkgs/issues/46569
updated_at: 2019-01-14 17:13:19
body:
  ## Issue description

  Here is an incomplete list of programs that don't respect the setting `i18n.defaultLocale`:

  * Thunderbird
  * Firefox
  * konsole

  For up-to-date Thunderbird and Firefox there is no easy way to switch the locale, so this is quite a blocker.

  ### Steps to reproduce

  * Set `i18n.defaultLocale = "de_DE.UTF-8";` in the main config, switch to that config
  * `nix-env -iA nixos.thunderbird`
  * `thunderbird`
  * All time stamps are displayed in AM/PM

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.68, NixOS, 19.03pre151837.ca2ba44cab4 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1`
   - channels(root): `"nixos-19.03pre151837.ca2ba44cab4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: android-file-transfer: 3.4 -> 3.5
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46570
updated_at: 2018-09-12 17:08:14
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @xaverdh


state: closed
title: prometheus-alertmanager module: implement meshing
user_login: globin
html_url: https://github.com/NixOS/nixpkgs/pull/46571
updated_at: 2018-11-14 17:59:40
body:
  ###### Motivation for this change

  Allow meshing in the prometheus alertmanager module.

  This has been used in production for quite some time and we just missed upstreaming it.
  Therefore, and due to it being a rather small change, I propose backporting to 18.09 (cc @vcunat, @samueldr)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - N/A macOS
     - N/A other Linux distributions
  - N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - N/A Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - N/A Tested execution of all binary files (usually in `./result/bin/`)
  - N/A Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mosquitto: ipv6 and tls cert store fixes
user_login: globin
html_url: https://github.com/NixOS/nixpkgs/pull/46572
updated_at: 2018-09-23 14:53:58
body:
  ###### Motivation for this change

  This fixes mosquitto not listening by default on IPv6 and not finding the cert store by default.

  I propose backporting this to 18.09 (cc @vcunat, @samueldr)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - N/A macOS
     - N/A other Linux distributions
  - N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - N/A Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - N/A Tested execution of all binary files (usually in `./result/bin/`)
  - N/A Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.10.5 -> 1.11.3
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/46573
updated_at: 2018-09-13 19:09:11
body:
  ###### Motivation for this change

  Since https://github.com/NixOS/nixpkgs/pull/45670 will not make it to 18.09, I'm PR'ing the kubernetes package separately. I'd like it if this could be backported to NixOS 18.09.

  Even though this PR has no module updates, the main purpose of issue #43882 was to upgrade to v1.11, thus:
  closes #43882 

  @srhb ping

  ###### Things done

  NixOS tests for rbac and dns runs clean.

  I've also tested this with a three node cluster in Google Cloud and it turns out that the existing kubernetes module works seamlessly with the 1.11.3 package, although some of the k8s components yield warnings for deprecated flags.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elf-header: Init at <libc version>
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46574
updated_at: 2018-09-15 18:02:45
body:
  ###### Motivation for this change

  This is used to build software working with ELF on platforms that don't provide that header as part of their libc. This is used for Darwin->Linux cross compilation.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Ecryptfs is broken with NixOS 18.03
user_login: Ekdohibs
html_url: https://github.com/NixOS/nixpkgs/issues/46575
updated_at: 2018-09-12 19:36:52
body:
  ## Issue description

  Ecryptfs doesn't work with NixOS 18.03.
  ```
  $ ecryptfs-mount-private 
  Enter your login passphrase:
  Inserted auth tok with sig [3a835b169926de15] into the user session keyring
  /nix/store/byzxnnj4nc9zrkaiigw7yxyi55r5hl7d-ecryptfs-111/bin/.ecryptfs-mount-private-wrapped: line 69: /run/wrappers/bin/mount.ecryptfs_private: No such file or directory
  ```

  ```
  $ mount.ecryptfs_private
  setreuid: Operation not permitted
  ```

  `ecryptfs-recover-private` however succeeds when run as root.

  ### Steps to reproduce

  Install the ecryptfs package. The problem appears with both user-installed and system-wide install.

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.51, NixOS, 18.03.132750.91b286c8935 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - channels(nathanael): `""`
   - channels(root): `"nixos-18.03.132750.91b286c8935, unstable-18.09pre143771.a8c71037e04"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ```


state: closed
title: tsung: Add package tsung version 1.7.0
user_login: uskudnik
html_url: https://github.com/NixOS/nixpkgs/pull/46577
updated_at: 2018-10-03 21:58:55
body:
  ###### Motivation for this change
  Add [tsung](http://tsung.erlang-projects.org/) package

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libxnd, libndtypes: refactor add support for darwin
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46578
updated_at: 2018-09-13 19:37:13
body:
  ###### Motivation for this change

  Prior build instructions were hacks because I did not understand that the configure script was choosing `ld` as the linker instead of using `gcc` to properly link. This commit fixes these issues and simplifies the build. 

  ###### Things done

  libxnd: refactor
  libndtypes: refactor

  Please ensure that this build works on darwin.


  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: masterpdfeditor: 5.1.12 -> 5.1.60
user_login: apeyroux
html_url: https://github.com/NixOS/nixpkgs/pull/46579
updated_at: 2018-12-25 22:31:48
body:
  ###### Motivation for this change

  masterpdfeditor: 5.1.12 -> 5.1.36

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vault: 0.10.4 -> 0.11.1
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/46580
updated_at: 2018-09-14 11:40:19
body:
  ###### Motivation for this change

  upgrade!

  changelog: https://github.com/hashicorp/vault/blob/v0.11.1/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add licenses
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/46581
updated_at: 2018-09-12 21:43:48
body:
  ###### Motivation for this change
  Another batch for https://github.com/NixOS/nixpkgs/issues/43716

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: weechatScripts.weechat-matrix-bridge: don't export `olm.lua' as script
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46582
updated_at: 2018-09-13 06:10:31
body:
  ###### Motivation for this change

  Loading olm.lua as weechat script with `/script load olm.lua' causes
  errors like this:

  ```
  /nix/store/43jbh7yxh8j4gjfzbvpd9clncah5dip1-weechat-matrix-bridge-2018-05-29/lib/ffi.so: undefined symbol: lua_tointeger
  ```

  As `olm.lua' is loaded by `matrix.lua' it doesn't need to be included
  manually by the weechat configuration.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: quantum-espresso, siesta init packages for density functional theory calculations
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46583
updated_at: 2018-09-14 22:24:25
body:
  ###### Motivation for this change

  Wanted to add two material science codes for calculating the electronic structure of materials. quantum-espresso has a serial and mpi version while siesta is serial for now. This is becuase siesta requires scalapack for mpi version.

  ###### Things done

  siesta: init at 4.1-b3
  quantum-espresso: init at 6.3

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: broken darwin packages (a)
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46584
updated_at: 2018-09-12 22:05:47
body:
  ###### Motivation for this change

  Marks various failing darwin builds as broken or linux only.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mitmproxy: 3.0.4 -> 4.0.4, fix tests
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46585
updated_at: 2018-09-13 00:20:40
body:
  ###### Motivation for this change

  ZHF #45960 . Previous version was [broken](https://hydra.nixos.org/job/nixpkgs/trunk/mitmproxy.x86_64-linux), tests failed: 

  - update to latest release
  - add missing checkInputs
  - apply upstream patch to fix some tests that failed due to expired test ssl certs
  - re-enable a previously disabled test case

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @fpletz @kamilchm 


state: closed
title: factorio: download using token, not password
user_login: elitak
html_url: https://github.com/NixOS/nixpkgs/pull/46586
updated_at: 2018-12-29 08:42:33
body:
  Downloads were broken by upstream devs' addition of CAPTCHA to the login form.

  Changed all references of password to token and used the new GET request + query string to fetch the files.

  Fixes #46267

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tor-browser-bundle-bin 8.0 crashes when attempting to save a page/image (GLib-GIO-ERROR)
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/issues/46587
updated_at: 2018-09-13 20:41:21
body:
  Cc @joachifm
   
  ## Issue description

  With the latest `tor-browser-bundle-bin`, attempting to save (e.g. by hitting `Ctrl+S`) a web page crashes the browser with the below error:

  ```
  (firefox:29801): GLib-GIO-ERROR **: No GSettings schemas are installed on the system
  ```

  ### Steps to reproduce

  Build (`/nix/store/gjbwaq6ldnm8k3iilnycvfnpxilnli27-tor-browser-bundle-bin-8.0`) and run:

   ```shell
  $ nix-build https://github.com/NixOS/nixpkgs/archive/master.tar.gz -A tor-browser-bundle-bin
  $ ./result/bin/tor-browser
  ```

  Hit `Ctrl+S`


state: closed
title: pythonPackages.BTrees: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46588
updated_at: 2018-09-13 00:33:40
body:
  ###### Motivation for this change

  ZHF #45960.
  A test case [failed since the update to 4.5.1](https://hydra.nixos.org/job/nixpkgs/trunk/python36Packages.BTrees.x86_64-linux), disable it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: leo-editor: 5.6 -> 5.7.3, fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46589
updated_at: 2018-09-13 10:18:55
body:
  ###### Motivation for this change

  ZHF #45960. 
  Previous version depended on qt56.qtwebengine which is [broken](https://hydra.nixos.org/job/nixpkgs/trunk/leo-editor.x86_64-linux).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Flash player download is broken (404s) again
user_login: Pneumaticat
html_url: https://github.com/NixOS/nixpkgs/issues/46591
updated_at: 2018-09-14 20:26:41
body:
  ## Issue description

  ```
  these paths will be fetched (0.61 MiB download, 2.47 MiB unpacked):
    /nix/store/06dlgkv81i9sgkjvj9l9jniz54xkh46f-nghttp2-1.32.0-dev
    /nix/store/4dkl9cpjdgys7q3dyry5nmsgvl3n8y93-nghttp2-1.32.0-bin
    /nix/store/5f4p2zfhbfhp75m6p29wl4x360c5ld9y-nghttp2-1.32.0
    /nix/store/ncvn44kqw3jcjsfi62n43ki932zyyhps-libssh2-1.8.0-dev
    /nix/store/qdcc6418a2xxlmfamm6ai1rrckxcia7f-mirrors-list
    /nix/store/sp9y40cncwvs6zip70wij05lin95c931-curl-7.61.0-dev
  copying path '/nix/store/qdcc6418a2xxlmfamm6ai1rrckxcia7f-mirrors-list' from 'https://cache.nixos.org'...
  copying path '/nix/store/5f4p2zfhbfhp75m6p29wl4x360c5ld9y-nghttp2-1.32.0' from 'https://cache.nixos.org'...
  copying path '/nix/store/ncvn44kqw3jcjsfi62n43ki932zyyhps-libssh2-1.8.0-dev' from 'https://cache.nixos.org'...
  copying path '/nix/store/4dkl9cpjdgys7q3dyry5nmsgvl3n8y93-nghttp2-1.32.0-bin' from 'https://cache.nixos.org'...
  copying path '/nix/store/06dlgkv81i9sgkjvj9l9jniz54xkh46f-nghttp2-1.32.0-dev' from 'https://cache.nixos.org'...
  copying path '/nix/store/sp9y40cncwvs6zip70wij05lin95c931-curl-7.61.0-dev' from 'https://cache.nixos.org'...
  building '/nix/store/hd40xqh22v2ghkg3k2rn92f5364d58hw-flash_player_npapi_linux.x86_64.tar.gz.drv'...

  trying https://fpdownload.adobe.com/get/flashplayer/pdc/30.0.0.154/flash_player_npapi_linux.x86_64.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download flash_player_npapi_linux.x86_64.tar.gz from any mirror
  ```

  Seems like Flash Player once again got updated, and they removed the old version. It would be nice to have a mirror somewhere for more permanent access.

  ### Steps to reproduce

  `nix-shell -p flashplayer`

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.18.6-ck1, NixOS, 19.03.git.52b9e64 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`


state: closed
title: dockerTools: use closureInfo to load hashes and closure sizes into the Nix DB
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/46592
updated_at: 2018-10-30 07:03:03
body:
  ###### Motivation for this change
  Since `closureInfo` is a good extension of `exportReferencesGraph`, we can use it to bootstrap Nix DB with this and possibly eliminates the need to recompute the hashes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: treewide: fix `config.allowAliases = false` evaluation
user_login: ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/46593
updated_at: 2018-09-13 16:46:21
body:
  ###### Motivation for this change

  Our configuration options should evaluate!

  ###### Things done

  tested evaluation with 
  ```
  nix-env -qa woeusb-3.2.2 -f . --attr-path --arg config '{ allowBroken = true; allowUnfree = true; allowAliases = false;}'
  ```

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome-builder: add ctags
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46594
updated_at: 2018-09-16 23:40:58
body:
  Gnome Builder uses Ctags for autocompletion.

  From looking at [this](https://gitlab.gnome.org/GNOME/gnome-builder/blob/master/data/gsettings/meson.build#L7) adding it as a build input should be sufficient.

  cc @jameysharp  @jtojnar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: seaview: init at 4.7
user_login: iimog
html_url: https://github.com/NixOS/nixpkgs/pull/46595
updated_at: 2018-09-13 12:10:45
body:
  ###### Motivation for this change

  Add package for seaview, a GUI for molecular phylogeny

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: unclutter-xfixes: make systemd user unit enabled when module is
user_login: NickHu
html_url: https://github.com/NixOS/nixpkgs/pull/46596
updated_at: 2019-04-12 17:27:04
body:
  See issue #23491; this actually fixes this small bug.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ X Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tamarin-prover: fix ghc 8.4 build
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/46597
updated_at: 2018-09-13 12:12:28
body:
  ###### Motivation for this change

  See https://hydra.nixos.org/build/81125645

  `tamarin-prover' upstream has a patch to fix GHC 8.4 compilation (and
  uses stack lts-12.1 now), but it's not released yet:

  https://github.com/tamarin-prover/tamarin-prover/commit/a08f6e400772899b9b0fc16befc50391cd70696b

  The build is divided in several derivations, therefore the patch had to
  be splitted and rebased for `lib/term', `lib/theory' and `lib/utils' to
  ensure that the patch applies properly during the `patchPhase'.

  Addresses #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 18.09: kubernetes: 1.10.5 -> 1.11.3
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/46598
updated_at: 2018-09-13 17:06:23
body:
  Backport of #46573 to 18.09. The module revamp did not make the cut for this release. See the comments on that PR for compatibility, namely that 1.11 works with our current modules (with the same issues that 1.10 has) and keeps us up to date.

  @samueldr I assume this is still an acceptable backport, as long as we don't touch the module, right?

  (cherry picked from commit a49f56c3b1a5dc88c1dfbb0412a790033ac0f6c3)

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: anki: 2.0.52 -> 2.1.4
user_login: NickHu
html_url: https://github.com/NixOS/nixpkgs/pull/46599
updated_at: 2018-11-15 22:41:21
body:
  New version of Anki. The jump from 2.0 -> 2.1 is somewhat major, especially
  considering it moved from python 2 to python 3.

  Note that this will not work with versions of qt that aren't 5.9, which
  currently does not build on NixOS. I got it to build by applying this patch

  ```patch
  diff --git a/pkgs/development/libraries/qt-5/modules/qtwebkit.nix b/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
  index 833433fabec..1970111fc09 100644
  --- a/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
  +++ b/pkgs/development/libraries/qt-5/modules/qtwebkit.nix
  @@ -35,7 +35,6 @@ qtModule {
   
     cmakeFlags = optionals (lib.versionAtLeast qtbase.version "5.11.0") [ "-DPORT=Qt" ];
   
  -  inherit src;
     inherit version;
   
     __impureHostDeps = optionals (stdenv.isDarwin) [
  ```

  I don't really know what's going on there, but once that builds, Anki seems to
  build fine and work well.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wolfssl: enable all features
user_login: mcmtroffaes
html_url: https://github.com/NixOS/nixpkgs/pull/46600
updated_at: 2018-09-17 12:36:01
body:
  ###### Motivation for this change

  Some websites won't load properly due to missing features. Simply enabling all features fixes this. This also matches how curl is currently tested with wolfssl on travis (see https://github.com/curl/curl/blob/66b3c186fa9a06d313501c80f02e7125acb78c3d/.travis.yml#L222 noting that --enable-tls13 is redundant in the more recent version of wolfssl used in nix, see https://github.com/wolfSSL/wolfssl/blob/v3.15.3-stable/configure.ac#L123 ).

  For example, without the "--enable-all" configure flag, the user gets an error message when trying to load nixos.org (here, using curl built against wolfssl), presumably due to a missing feature:

  ```
  curl: (51)      subject alt name(s) or common name do not match "nixos.org"
  ```

  This commit fixes this problem.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  No package currently depends on wolfssl, so for testing I recompiled curl against wolfssl using the following shell.nix:

  ```nix
  with import <nixpkgs> {};
  let
    curlwolfssl = (curl.override {
      openssl = wolfssl;
    }).overrideDerivation (oldAttrs: {
      configureFlags =
        # --with-ca-fallback does not work with wolfssl
        (builtins.filter (x: x != "--with-ca-fallback") oldAttrs.configureFlags)
        ++ ["--with-wolfssl=${wolfssl}" "--without-ssl"];
    });
  in
  {
    my-env = stdenv.mkDerivation {
      name = "my-env";
      buildInputs = [
        curlwolfssl
      ];
    };
  }
  ```

  I tested the resulting curl binary and compared its output against my local curl binary provided by Fedora:

  ```bash
  curl -2 https://nixos.org
  curl --cacert /etc/ssl/certs/ca-bundle.crt https://nixos.org > 1.txt
  /usr/bin/curl https://nixos.org > 2.txt
  diff 1.txt 2.txt
  ```

  The first line gives an error message "curl: (35) CyaSSL does not support SSLv2" confirming that CyaSSL - which is the old name for wolfssl still referred to by curl - is indeed used. Diff of output of local curl and this new curl shows identical outputs as expected.


state: closed
title: bat: 0.6.1 -> 0.7.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46601
updated_at: 2018-09-13 11:00:16
body:
  https://github.com/sharkdp/bat/releases/tag/v0.7.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.zodb: fix tests
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46602
updated_at: 2018-09-13 16:15:59
body:
  ###### Motivation for this change

  ZHF #45960 

  Tests failed after `persistent` was updated to 4.4. Apply an upstream patch to fix them.
  This should also fix `vulnix`.

  ###### Things done

  - [x] built in a sandbox on NixOS x64_64-linux
  - [x] passes nix-review

  ---


state: open
title: `fetchGit` requires `git` as runtime dependency
user_login: yorickvP
html_url: https://github.com/NixOS/nixpkgs/issues/46603
updated_at: 2019-02-04 04:37:20
body:
  ## Issue description

  nixos/nix#2419

  nix already requires git to build, but it fails to evaluate anything fetchGit without git installed. Maybe git should be a runtime dependency?




  ### Steps to reproduce

  Install nix but not git, use `fetchGit`


state: closed
title: [WIP] Wrap Nix to add Git as runtime dependency, resolves #46603
user_login: yegortimoshenko
html_url: https://github.com/NixOS/nixpkgs/pull/46604
updated_at: 2018-10-12 19:24:25
body:
  ###### Motivation for this change

  Potential resolution for #46603. Hasn't been tested yet.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sqlitebrowser crashes when run nix-shell
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/46605
updated_at: 2018-09-13 15:47:57
body:
  ## Issue description
  ```
  nix-shell -p --pure sqlitebrowser --run sqlitebrowser
  This application failed to start because it could not find or load the Qt platform plugin "xcb"
  in "".

  Reinstalling the application may fix this problem.
  /tmp/nix-shell-16530-0/rc: line 1: 17015 Aborted                 sqlitebrowser
  ```

  ### Steps to reproduce
  Full repro on my operating system: `nix-shell -p --pure sqlitebrowser --run sqlitebrowser`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.67, NixOS, 18.03.git.8b92a4e (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: mako: init at 1.1
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46606
updated_at: 2018-10-23 20:13:58
body:
  `mako` currently works on Sway 1.0 alpha.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Sickbeard/Sickgear/Sickrage: Init and module
user_login: rembo10
html_url: https://github.com/NixOS/nixpkgs/pull/46607
updated_at: 2018-09-29 19:26:56
body:
  ###### Motivation for this change
  This is an attempt to unify #46538, #46214 and #46340. Added packages for sickbeard, sickgear and sickrage, and added a nixos module to specify which package to use.
  @sterfield: I hope it's ok that I didn't merge your commit - since I made some changes to your package based on comments from @worldofpeace on #46514. I kept you as the maintainer for Sickrage though

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages: fix some broken builds
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46608
updated_at: 2018-09-14 08:58:51
body:
  ###### Motivation for this change

  ZHF #45960. Fix various broken python packages.

  ###### Things done

  - [x] Built in sandbox on NixOS x86_64-linux
  - [x] passes `nix-review`

  ---


state: closed
title: whipper: replace morituri
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/46609
updated_at: 2018-09-14 23:02:47
body:
  ###### Motivation for this change
  morituri has been dead for a while now and uses gst-python which is [no longer supported](https://bugzilla.gnome.org/show_bug.cgi?id=797138) wth Python 2. whipper is a maintained fork, packaged, for example, in Arch.

  cc @rycee @jgeerds @jansol 

  Closes: https://github.com/NixOS/nixpkgs/issues/27228

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scalapack: init at 2.0.2
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46610
updated_at: 2018-09-13 19:27:47
body:
  Added scalapack with flexibility to choose blas, lapack, and mpi
  implementation.

  ###### Motivation for this change

  Nixpkgs is perfect for scientific computing. Scalapack is a major dependency for many scientific codes.

  ###### Things done

  scalapack: init at 2.0.2

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: NetworkManager: fix VPN service source locations
user_login: benley
html_url: https://github.com/NixOS/nixpkgs/pull/46611
updated_at: 2018-09-13 18:29:57
body:
  ###### Motivation for this change

  These have all moved to lib/NetworkManager/VPN in the plugin build outputs rather than etc/NetworkManager/VPN.  This fixes the symlinks so NetworkManager can find its vpn plugins again.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: nix-selinux-policy: init at 1.0
user_login: e-user
html_url: https://github.com/NixOS/nixpkgs/pull/46612
updated_at: 2019-02-10 11:55:06
body:
  ###### Motivation for this change

  This basic SELinux policy for files in `/nix` is required to support running Nix in multi-user mode on SELinux-enabled systems.

  To test the output of this derivation, run `semodule -i result/nix.pp` after building and `restorecon -v` on files in `/nix` to verify that the contexts defined in `nix.fc` are applied.

  Required to fix https://github.com/NixOS/nix/issues/2374.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xpra: port to gtk3
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/46613
updated_at: 2018-10-18 03:59:36
body:
  ###### Motivation for this change
  Removing old cruft

  cc @atanasi @7c6f434c @calvertvl @offlinehacker @bjornfor 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Atlassian update
user_login: ciil
html_url: https://github.com/NixOS/nixpkgs/pull/46614
updated_at: 2018-09-13 17:53:05
body:
  ###### Motivation for this change
  Packet bump for our Atlassian packages. Will be backported to 18.09 as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parmetis: init at 4.0.3
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46615
updated_at: 2018-09-13 19:11:55
body:
  ###### Motivation for this change

  Parallel implementation of metis. Useful for petsc package #28368 compilation

  ###### Things done

  parmetis: init at 4.0.3

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Atlassian update 18.09
user_login: ciil
html_url: https://github.com/NixOS/nixpkgs/pull/46616
updated_at: 2018-09-14 03:40:16
body:
  ###### Motivation for this change
  Accompanying pull request for 18.09, see https://github.com/NixOS/nixpkgs/pull/46614

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana: 5.2.3 -> 5.2.4
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46617
updated_at: 2018-09-13 19:48:58
body:
  ###### Motivation for this change
  Fixed a [small issue](https://github.com/grafana/grafana/releases/tag/v5.2.4) concerning the grafana-cli.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana: 5.2.3 -> 5.2.4 (backport 18.09)
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46618
updated_at: 2018-11-13 14:09:03
body:
  (cherry picked from commit 68b25008e25bb5c1cbba1d3d89ecaa78ebf8a374)
  Fixed a [small issue](https://github.com/grafana/grafana/releases/tag/v5.2.4) concerning the grafana-cli.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  /cc @vcunat @samueldr 


state: closed
title: papi: init at 5.6.0
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46619
updated_at: 2018-09-13 21:35:06
body:
  papi is a high resolution performance counter.

  ###### Motivation for this change

  wanted to add a library I use for evaluating software performance.

  ###### Things done

  papi: init at 5.6.0

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus-dovecot-exporter: 0.1.1 -> 0.1.3
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46620
updated_at: 2018-09-14 01:59:26
body:
  ###### Motivation for this change
  Bugfixes in the [latest release](https://github.com/kumina/dovecot_exporter/blob/0.1.3/CHANGELOG.md)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus-dovecot-exporter: 0.1.1 -> 0.1.3 (backport 18.09)
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46621
updated_at: 2018-09-14 01:59:44
body:
  (cherry picked from commit 21324ef0e493dc0713bc3c83ea6e9b456c01810b) #46620

  ###### Motivation for this change
  Bugfixes in the [latest release](https://github.com/kumina/dovecot_exporter/blob/0.1.3/CHANGELOG.md)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  /cc @vcunat @samueldr 


state: closed
title: brlaser: cleanup and mark linux only
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46622
updated_at: 2018-09-13 21:13:29
body:
  The test binaries depend use open_memstream which isn't available on
  darwin.

      error: use of undeclared identifier 'open_memstream'

  /cc ZHF #45961

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mkspiffs: init at 0.2.3
user_login: haslersn
html_url: https://github.com/NixOS/nixpkgs/pull/46623
updated_at: 2018-09-14 21:09:36
body:
  ###### Motivation for this change

  There wasn't a derivation for mkspiffs yet, so I made one.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libx86emu: 2.0 -> 2.1
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/46624
updated_at: 2018-09-15 00:31:27
body:
  ###### Motivation for this change

  This updates libx86emu to 2.1.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-update: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46625
updated_at: 2018-09-13 22:28:12
body:
  ###### Motivation for this change

  On darwin libcurl is also needed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ceres-solver: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46626
updated_at: 2018-09-13 22:28:08
body:
  The Basel BUILD file conflicts with the cmake build directory on
  case-insensitive filesystems, eg. darwin.

  /cc ZHF #45961

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.dask-*: init
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46627
updated_at: 2018-09-18 18:11:05
body:
  ###### Motivation for this change

  Have been doing a lot of work with dask. Wanted to add most used dask modules.

  ###### Things done

  pythonPackages.dask-xgboost: init at 0.1.5
  pythonPackages.dask-image: init at 01.1
  pythonPackages.slicerator: init at 0.9.8
  pythonPackages.pims: init at 0.4.1
  pythonPackages.dask-jobqueue: init at 0.4.0
  pythonPackages.dask-glm: init at 0.1.0
  pythonPackages.dask-ml: init at 0.10.0
  pythonPackages.distributed: refactor fix broken build (did not register version properly)

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: broken darwin packages (c)
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46628
updated_at: 2018-09-14 16:46:12
body:
  ###### Motivation for this change

  Mark various packages linux only or broken on darwin.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: calaos_installer: fix darwin install
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/46629
updated_at: 2018-09-13 22:28:04
body:
  ###### Motivation for this change

  On darwin this builds an application instead of a binary.

  /cc ZHF #45961


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: any-nix-shell: init at 1.0.0
user_login: haslersn
html_url: https://github.com/NixOS/nixpkgs/pull/46630
updated_at: 2018-09-16 14:17:45
body:
  ###### Motivation for this change

  any-nix-shell adds fish and zsh support for nix-shell. More supported shells can be added in the future.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Test all nix expressions where applicable
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/issues/46632
updated_at: 2019-04-28 14:30:04
body:
  ## Issue description
  While the system we have right now is good for contributing, I think each new nix expression should have a test in `nixos/tests` written along with it in each new PR.
  We should do this retroactively where possible for all currently existing packages too.
  This way, we can ensure everything works with hydra, and be alerted quickly for broken, but successfully built expressions that may not be actively maintained and (user) tested anymore.

  Would it be possible to change the policy in [Contributing](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md) to do this?
  The flow I see is this:
  1. Make new expression for program X
  2. Test locally to ensure it works
  3. Make test in nixos/tests for it so hydra can do this automatically
  4. Submit PR after everything fits [Contributing](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Is this a good idea, something we should implement? I see more benefits that drawbacks.


state: closed
title: pdftag: 1.0.4 -> 1.0.5
user_login: leenaars
html_url: https://github.com/NixOS/nixpkgs/pull/46633
updated_at: 2018-09-14 00:17:49
body:
  ###### Motivation for this change

  New release that removes hard coded path and unnecessary license install, also see https://github.com/NixOS/nixpkgs/pull/45666

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: airsonic: provide additional jvm configuration
user_login: mdorman
html_url: https://github.com/NixOS/nixpkgs/pull/46634
updated_at: 2019-02-13 12:34:47
body:
  ###### Motivation for this change

  This allows the user, among other things, to configure jukebox output
  to go to non-default alsa devices.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nbd: add which to buildInputs
user_login: qolii
html_url: https://github.com/NixOS/nixpkgs/pull/46635
updated_at: 2018-09-14 18:27:43
body:
  ###### Motivation for this change
  The `nbd` build complains numerously about not being able to find the `which` package during its testing phase:
  ```
  make  check-TESTS
  make[3]: Entering directory '/build/nbd-3.18/tests/run'
  ./simple_test: line 9: which: not found
  ./cfg1
  5442: Requests: 0
  ** Message: 01:01:44.884: 5442: Throughput read test (without flushes) complete. Took 0.080 seconds to complete, 50.222Mib/s
  PASS: cfg1
  ./simple_test: line 9: which: not found
  ./cfgmulti
  5463: Requests: 0
  ** Message: 01:01:45.988: 5463: Throughput read test (without flushes) complete. Took 0.079 seconds to complete, 50.925Mib/s
  5469: Requests: 0
  ** Message: 01:01:46.068: 5469: Throughput read test (without flushes) complete. Took 0.077 seconds to complete, 52.084Mib/s
  PASS: cfgmulti
  ./simple_test: line 9: which: not found
  ./cfgnew
  5490: Requests: 0
  ** Message: 01:01:47.178: 5490: Throughput read test (without flushes) complete. Took 0.084 seconds to complete, 47.414Mib/s
  PASS: cfgnew
  ./simple_test: line 9: which: not found
  ./cfgsize
  ```
  and so on.

  I'm not sure why the build doesn't fail under these conditions, but anyway, simply adding `which` to its `buildInputs` fixes this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flatpak: 0.99.3 → 1.0.2
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/46636
updated_at: 2018-09-14 12:57:02
body:
  ###### Motivation for this change
  Flatpak update; cherry-picked from https://github.com/NixOS/nixpkgs/pull/45950 with some extra fixes

  cc @hedning 

  Closes: https://github.com/NixOS/nixpkgs/issues/43595 cc @x80486

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/rmilter: fix default bindSocket.path and bindSocket.address.
user_login: ju1m
html_url: https://github.com/NixOS/nixpkgs/pull/46637
updated_at: 2019-03-02 01:12:23
body:
  ###### Motivation for this change
  bindSocket.path must not be within a RuntimeDir to avoid it being deleted, and IPv6 port is after the bracket.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: warn if alias is used inside overrides
user_login: ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/46638
updated_at: 2018-09-19 02:21:30
body:
  This changes the vimPlugins structure to be like stage.nix and top-level/aliases.nix.

  vimPlugins was breaking evaluation if config.allowAliases was set to false, and we wanted to make sure it is harder to do that in the future.


state: open
title: top-level/aliases.nix warning about alias use broken
user_login: ryantm
html_url: https://github.com/NixOS/nixpkgs/issues/46639
updated_at: 2018-09-14 04:56:06
body:
  ## Issue description

  There is a warning in `top-level/aliases.nix` that is supposed to error out if an alias is used inside all-packages.nix but it does not work currently.

  ### Steps to reproduce

  Change 
  `wine = winePackages.full;` to `wine = wineFull;`
  run
  `nix-env -f . -iA wine`
  observe no error message.

  Change `checkInPkgs` in aliases.nix to check "self" instead of "super" and observe the error message appears:

  ```
  $ nix-env -f . -iA wine                                                                                                                                                                   
  error: Alias wineFull is still in all-packages.nix  
  ```
  I'm not sure the problem is directly with self or super here, because if I use super on [the work I've been doing on vimPlugins](https://github.com/NixOS/nixpkgs/pull/46638), it works fine.


state: closed
title: tensorflow-tensorboard-1.9.0 from master fails on start during locale setting
user_login: akamaus
html_url: https://github.com/NixOS/nixpkgs/issues/46641
updated_at: 2018-09-18 17:56:57
body:
  ## Issue description
  I installed tensorboard from master branch (at 24aea25528961d3) and found some weird behavior on start:
  ```
  % nix-shell-unstable -p python36Packages.tensorflow-tensorboard -p python36Packages.tensorflowWithoutCuda  --run 'tensorboard --logdir logs'         
  Traceback (most recent call last):
    File "/nix/store/8w94iidz1pmcqda6mswq3ra0azgp8v86-python3.6-tensorflow-tensorboard-1.9.0/bin/.tensorboard-wrapped", line 12, in <module>
      sys.exit(run_main())
    File "/nix/store/8w94iidz1pmcqda6mswq3ra0azgp8v86-python3.6-tensorflow-tensorboard-1.9.0/lib/python3.6/site-packages/tensorboard/main.py", line 46, in run_main
      tf.app.run(main)
    File "/nix/store/rsf4l1rff96ahssk1vswxi6kz1m1602b-python3.6-tensorflow-1.9.0/lib/python3.6/site-packages/tensorflow/python/platform/app.py", line 125, in run
      _sys.exit(main(argv))
    File "/nix/store/8w94iidz1pmcqda6mswq3ra0azgp8v86-python3.6-tensorflow-tensorboard-1.9.0/lib/python3.6/site-packages/tensorboard/main.py", line 55, in main
      default.get_assets_zip_provider())
    File "/nix/store/8w94iidz1pmcqda6mswq3ra0azgp8v86-python3.6-tensorflow-tensorboard-1.9.0/lib/python3.6/site-packages/tensorboard/program.py", line 167, in main
      util.setup_logging()
    File "/nix/store/8w94iidz1pmcqda6mswq3ra0azgp8v86-python3.6-tensorflow-tensorboard-1.9.0/lib/python3.6/site-packages/tensorboard/util.py", line 50, in setup_logging
      locale.setlocale(locale.LC_ALL, '')
    File "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/lib/python3.6/locale.py", line 598, in setlocale
      return _setlocale(category, locale)
  locale.Error: unsupported locale setting
  ```
  I decided to manually execute setlocale and found it works perfectly:
  ```
  % nix-shell-unstable -p python36 --pure                                                                                                                   ~/ML 

  [nix-shell:~/ML]$ python3
  Python 3.6.6 (default, Jun 27 2018, 05:47:41) 
  [GCC 7.3.0] on linux
  Type "help", "copyright", "credits" or "license" for more information.
  >>> import locale
  >>> locale.setlocale(locale.LC_ALL, '') # Testing the actual cmd
  'C'
  >>> locale.setlocale('') # trigger the error so path to interpreter is shown
  Traceback (most recent call last):
    File "<stdin>", line 1, in <module>
    File "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/lib/python3.6/locale.py", line 598, in setlocale
      return _setlocale(category, locale)
  TypeError: an integer is required (got type str)
  ```
  So Python is the same but behavior differs. Any ideas?


  ## Technical details
  % nix-shell -p nix-info --run "nix-info -m"                                                                                                  
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.65, NixOS, 18.03.git.6adb065 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.0.4`
   - channels(root): `""`
   - channels(test): `""`
   - channels(dvyal): `""`
   - nixpkgs: `/home/dvyal/nixpkgs`


state: closed
title: jenkins: 2.121.2 -> 2.138.1
user_login: bchallenor
html_url: https://github.com/NixOS/nixpkgs/pull/46642
updated_at: 2018-09-15 13:10:07
body:
  ###### Motivation for this change

  Multiple security vulnerabilities in Jenkins 2.137 and earlier, and LTS 2.121.2 and earlier

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flashplayer: 30.0.0.154 -> 31.0.0.108 [Important security fix]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/46643
updated_at: 2018-09-14 11:26:00
body:
  ###### Motivation for this change

  - Important security fix

  https://helpx.adobe.com/flash-player/release-note/fp_31_air_31_release_notes.html
  https://helpx.adobe.com/security/products/flash-player/apsb18-31.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  - Built packages
    - `nix-env -i -f . -A pkgs.flashplayer`
    - `nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone`
    - `nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger`
    - `nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"`
  - Played a video with Firefox and Chromium (x86_64).
  - Checked the version with Firefox, Chromium,  flashplayer-standalone, and flashplayer-standalone-debugger (x86_64) http://www.adobe.com/software/flash/about/


  ---


state: closed
title: trezord: 2.0.14 -> 2.0.19
user_login: 1000101
html_url: https://github.com/NixOS/nixpkgs/pull/46644
updated_at: 2018-09-14 15:03:57
body:
  ###### Motivation for this change
  I'd like to maintain the package up-to-date as we're the company releasing the original code.

  ###### Things done
  Updated version from 2.0.14 to 2.0.19. Reviewed and updated the service policies and rights.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scaleway-cli: 1.14 -> 1.17
user_login: brocking
html_url: https://github.com/NixOS/nixpkgs/pull/46645
updated_at: 2018-09-14 16:06:21
body:
  ###### Motivation for this change
  Package update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform-landscape: 0.1.18 -> 0.2.0
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/46646
updated_at: 2018-09-15 18:35:30
body:
  ###### Motivation for this change

  Avoids conflicts, because this had the `bundler` executable (amongst others) in $PATH, while only `landscape` should be available.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rustc: 1.27 -> 1.29
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/46647
updated_at: 2019-05-18 16:01:39
body:
  ###### Motivation for this change

  rls is buggy on 1.27

  Changelog: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1290-2018-09-13

  ###### Things done

  I tried to build with tests enabled. It first failed on some gdb tests which depend on the gdb version. I disabled them, and the next batch of tests also contained some failing tests so I gave up.

  I built eog (depending on librsvg), firefox and fd (on x86_64-linux). Firefox needs a patch from upstream. cc @taku0 who has been updating firefox for some time.

  cc @madjar @cstrahan @wizeman @globin @havvy @wkennington as maintainers.


state: closed
title: trezord: 2.0.12 -> 2.0.19
user_login: 1000101
html_url: https://github.com/NixOS/nixpkgs/pull/46648
updated_at: 2018-09-14 15:03:39
body:
  ###### Motivation for this change
  I'd like to maintain the package up-to-date as we're the company releasing the original code.

  ###### Things done
  Updated version from 2.0.14 to 2.0.19. Reviewed and updated the service policies and rights.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Increase Virtualbox disk image size
user_login: brainrape
html_url: https://github.com/NixOS/nixpkgs/pull/46649
updated_at: 2018-11-04 14:11:29
body:
  ###### Motivation for this change

  10G is not enough for a desktop installation, and resizing a disk image is a pain. 
  Let's increase the default disk size to 100G. It does not use more storage space.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update maintainer-list.nix
user_login: 1000101
html_url: https://github.com/NixOS/nixpkgs/pull/46650
updated_at: 2018-09-14 15:03:19
body:
  ###### Motivation for this change
  I'd like to maintain packages for SatoshiLabs (trezord). Hope my github name won't break something :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux_rpi: add support for 64-bit Raspberry Pi 3
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/46653
updated_at: 2018-09-24 13:09:35
body:
  ###### Motivation for this change

  The Raspberry Pi vendor kernel has a config for a 64-bit Raspberry Pi 3 kernel, but this is currently not supported in NixOS. I need this config to use a driver that is not included in the upstream kernel.

  The device trees are different for this config, so this requires a different `postFixup` phase for aarch64.

  This kernel boots correctly and I have not found any issues with it.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Walabot SDK and module
user_login: geistesk
html_url: https://github.com/NixOS/nixpkgs/pull/46654
updated_at: 2019-03-10 21:34:10
body:
  ###### Motivation for this change
  This PR adds the proprietary SDK for the [Walabot Makers](https://walabot.com/makers). Because of the nature of the library, which is only available as a pre-compiled shared library, a database must be present under `/var/lib/walabot`. The `walabot` NixOS-module creates this directory and populates it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`) (*none present*)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: CodiMD: init at 1.2.0, add module & test
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46655
updated_at: 2018-09-17 13:19:38
body:
  ###### Motivation for this change
  This adds the collaborative markdown editor [CodiMD](https://github.com/hackmdio/codimd), which is the OpenSource version of HackMD. For available features see https://demo.codimd.org/features.

  ###### Things done
  CodiMD uses a [vendored/forked](https://github.com/hackmdio/CodeMirror) version of CodeMirror as its editor, which is manually packaged in `codimd/CodeMirror/`.

  For now I included an [open PR](https://github.com/hackmdio/codimd/pull/940) as a patch, so that the service works properly. The module exposes all currently available options and generates a json config which is passed to the CodiMD service.

  The test consists of two subtest, one for sqlite and the other for postgres.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: datadog 6: logging agent
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/46660
updated_at: 2018-09-14 16:37:38
body:
  ## Issue description
  Datadog6 also has a "logging agent" (see agent status) output, which returns: 
  `Logs Agent is not running`. 

  The expected response is that it is running when it is instructed to run via: 

  ```
      services.datadog-agent.extraConfig = {
        logs_enabled = true;
      };
  ```

  ### Steps to reproduce
  ```
  agent status | grep 'Logs Agent is not running'
  ```

  ### Related people
  @rvl @domenkozar 

  ## Technical details

  `master`


state: closed
title: afew: add manpage
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46661
updated_at: 2018-09-14 22:00:19
body:
  ###### Motivation for this change

  Generate the `afew` manpage which was previously missing.
  (I did not add a separate `man` output, not worth it for a single 9kB manpage.)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] impact on closure size: +9kB
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc maintainers @andir @flokli @garbas


state: closed
title: geis: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46663
updated_at: 2018-09-14 21:59:53
body:
  ###### Motivation for this change

  ZHF #45960. 
  Disable format hardening, ignore some compiler warnings

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.grv: fix darwin build by using go 1.9
user_login: mbode
html_url: https://github.com/NixOS/nixpkgs/pull/46664
updated_at: 2018-09-15 07:30:25
body:
  cf. https://github.com/fsnotify/fsevents/issues/40

  /cc ZHF #45961

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: findutils: disable a bogus test
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/46666
updated_at: 2018-09-15 20:38:36
body:
  findutils fails to pass checkPhase on my Linux system that has a ```sysconf(_SC_OPEN_MAX)``` limit set. The test itself appears to be a common copypasta between gnu projects. Poking limits of available fd's is irrelevant to what findutils is designed to do, so I consider the test to be bogus.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lammps: update, hoomd-blue, dl_poly: init
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46667
updated_at: 2018-11-13 20:00:03
body:
  ###### Motivation for this change

  Adding molecular dynamics codes that our group uses at UTK. Hoomd-blue is the most interesting addition. While I have not added GPU support it is mpi enabled and a fun code to work with. I do not have enough experience packaging with GPUs yet (maybe will be packaged at a future date). Scales to 10K GPUs according to benchmarks.

  Would like to request @markuskowa for review.

  ###### Things done

  lammps: patch_2Aug2018 -> stable_22Aug2018
  dl-poly-classic: init 1.10
  hoomd-blue: init at 2.3.4 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nginx, postgresql: give corresponding groups permission to read
user_login: domenkozar
html_url: https://github.com/NixOS/nixpkgs/pull/46670
updated_at: 2019-07-22 00:17:30
body:
  The motivation here is that I'd like to add `datadog` user to `postgres` and `nginx` groups, which would allow datadog to read logs. I was actually the one that added exiting permissions to nginx back in 2013 and postgresql seems to date back to even svn in 2009.


state: closed
title: pythonPackages.jupyter-repo2docker: init at 0.6.0
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/46671
updated_at: 2018-10-14 10:25:40
body:
  ###### Motivation for this change

  Considering developing a nix environment for repo2docker so wanted to get it building first and add to package repository.

  ###### Things done

  pythonPackages.jupyter-repo2docker: init at 0.6.0 
  pythonPackages.python-json-logger: init at 0.1.9 
  pythonPackages.escapism: 0.0.1 -> 1.0.0 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: diagrams-builder pgf backend
user_login: Radvendii
html_url: https://github.com/NixOS/nixpkgs/issues/46672
updated_at: 2018-11-10 03:12:41
body:
  ## Issue description
  The diagrams-builder Haskell package (and the regular executable) don't include the pgf backend for some reason. What's needed is to add the `-fpgf` configure flag, add `diagrams-pgf` to `executableHaskellDepends`, and add `pgf` to the list of backends in the `diagrams-builder` package. I'm happy to make that pull request, but is there a reason this isn't default?

  Also, if it's not default, is there an easy way to do it post-facto? When I try to modify the haskell `diagrams-builder` package with `diagrams-builder.overrideAttrs { ... }` it complains that `executableHaskellDepends` isn't an existing attribute.


  ### Steps to reproduce
  Try to use `diagrams-builder-pgf` after installing the `diagrams-builder` package.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.63, NixOS, 18.09pre149415.8395f9aa85e (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.0.4`
   - channels(root): `"nixos-19.03pre152504.56b9f6fc8e1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: joker: 0.9.5 -> 0.9.7
user_login: andrestylianos
html_url: https://github.com/NixOS/nixpkgs/pull/46673
updated_at: 2018-11-08 22:19:37
body:
  ###### Motivation for this change
  Updating version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mkspiffs: init at 0.2.3
user_login: haslersn
html_url: https://github.com/NixOS/nixpkgs/pull/46674
updated_at: 2018-10-01 14:49:03
body:
  ###### Motivation for this change

  There wasn't a derivation for mkspiffs yet, so I made one.

  Supersedes #46623 as it does, besides the generic version, also contain the versions for arduino-esp32, arduino-esp8266 and esp-idf.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfs urgent: 0.7.10 has a bug
user_login: eighal
html_url: https://github.com/NixOS/nixpkgs/issues/46675
updated_at: 2018-09-15 02:39:07
body:
  ## Issue description

  A serious bug has just been announced for zfsonlinux version 0.7.10, which is currently included in NixOS unstable.

  ### Steps to reproduce

  I haven't reproduced the bug myself, but there's a clear bug report at https://github.com/zfsonlinux/zfs/issues/7906, and I have a reliable report of the bug being observed by a NixOS user (@clever).

  @clefru, could you please take the version of zfs in nixos-unstable back to 0.7.9 until this is resolved?  Thanks!


state: closed
title: spl/zfs: 0.7.10 -> 0.7.11
user_login: clefru
html_url: https://github.com/NixOS/nixpkgs/pull/46676
updated_at: 2018-09-14 23:25:30
body:
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/46675

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
    - nix-build -A stable nixos/tests/zfs.nix
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus-snmp-exporter: 0.11.0 -> 0.13.0
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/46677
updated_at: 2018-09-17 12:45:43
body:
  ###### Motivation for this change
  New features and a bugfix with the [two recent releases](https://github.com/prometheus/snmp_exporter/releases).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spl/zfs: 0.7.10 -> 0.7.11
user_login: clefru
html_url: https://github.com/NixOS/nixpkgs/pull/46678
updated_at: 2018-09-14 23:26:25
body:
  (cherry picked from commit 81082c6c60bfcfe2ffc20fb3cab406c621a8f7fe)

  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/46675

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
   - nix-build -A stable nixos/tests/zfs.nix
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Newtonsoft.Json: 6.0.8 -> 11.0.2
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/46679
updated_at: 2018-09-14 23:51:04
body:
  ###### Motivation for this change

  This upgrades Newtonsoft.Json and fixes a few failing packages, among which `openra`.

  I cherry-picked c632384 as @matthewbauer suggested.

  This is based on https://github.com/NixOS/nixpkgs/pull/44478.
  This replaces https://github.com/NixOS/nixpkgs/pull/46425
  This is part of https://github.com/NixOS/nixpkgs/issues/45960

  Ping @samueldr @nek0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux-libre is broken on master
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/issues/46680
updated_at: 2018-09-20 22:46:25
body:
  ### Issue description

  see https://hydra.nixos.org/build/81046125 and https://hydra.nixos.org/build/81046064.
  Might be related to recent kernel updates 4.18.6->4.18.7 and 4.14.68->4.14.69.

  cc @alyssais 


state: closed
title: kmsxx, kmscube: 2017-10-10 -> 2018-09-10, 2017-03-19 -> 2018-06-17
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/46681
updated_at: 2018-09-15 08:49:38
body:
  Revisiting KMS and noticed these were a bit old and seemed like updates were a good idea! :)


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
     - [x] Tested execution of at least some of the programs :innocent:
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zsh: 5.6.1 -> 5.6.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/46683
updated_at: 2018-09-15 08:54:20
body:
  From upstream's NEWS:

  > Changes from 5.6.1 to 5.6.2
  > ---------------------------
  >
  > Fix another SIGTTOU case.
  >
  > Fix SIGWINCH being ignored when zsh is not in the foreground.
  >
  > The release tarballs are now compressed using xz(1), whereas previously
  > both xz(1) and gzip(1) versions were available.  If this gets in your way,
  > give us a shout.
  >


  This fixed an issue that was driving me crazy trying to isolate,
  but may not happen to everyone.

  FWIW, it's basically exactly what you expect from the description above
  (so I was very excited when saw the commits leading to this release!)
  but I'll explain briefly in case anyone else encountered it:

  1. Terminal running vim
  2. Resize terminal
  3. Exit vim
  4. WTF my shell's RPROMPT is aligned wrong and various things
  (completion, etc.) are borked.  What gives?!

  Anyway, hope this helps! :)




  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elf-header: Init at <libc version> for 18.09
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46684
updated_at: 2018-09-15 18:02:44
body:
  ###### Motivation for this change

  backport for #46574.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: compton{,-git}: bump to v2, set COMPTON_VERSION so '--version' has sane output
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/46685
updated_at: 2018-09-20 08:00:19
body:
  Previously they both would claim to be 'git--' :).





  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Dell XPS 13 models need blacklisted Nouveau
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/issues/46686
updated_at: 2018-09-15 13:05:26
body:
  ## Issue description

  Hey I have been stumbling around for a few weeks now trying to fix my wake from suspend issues.
  It usually presents itself as closing and opening the lid, which results in the screen not waking properly.

  This can be resolved by blacklisting "nouveau" from kernelModules.
  Various other XPS issues are also present as a result of insufficient kernel modules being detected when creating hardware-configuration.nix
  These can be fixed by adding the list of modules seen on Arch's XPS 13 page.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: salt: fix darwin build by specifying dependency on tornado 4
user_login: mbode
html_url: https://github.com/NixOS/nixpkgs/pull/46687
updated_at: 2019-03-19 21:47:24
body:
  /cc ZHF #45961

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: click: 0.3.1 -> 0.3.2
user_login: mbode
html_url: https://github.com/NixOS/nixpkgs/pull/46688
updated_at: 2018-09-15 12:47:26
body:
  patch necessary to fix "error: the lock file needs to be updated but --frozen was passed to prevent this"

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: exfat: 1.2.8 -> 1.3.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46689
updated_at: 2018-09-15 10:31:48
body:
  https://github.com/relan/exfat/releases/tag/v1.3.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: apacheKafka: 1.1.0 -> 2.0.0, various patch upgrades for other versions
user_login: mbode
html_url: https://github.com/NixOS/nixpkgs/pull/46690
updated_at: 2018-09-22 15:03:41
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sequeler: 0.6.1 -> 0.6.2
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/46692
updated_at: 2018-09-15 19:36:12
body:
  ###### Motivation for this change
  Changelog: https://github.com/Alecaddd/sequeler/releases/tag/v0.6.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matcha: init at 2018-09-14
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46693
updated_at: 2018-09-16 02:26:31
body:
  ###### Motivation for this change

  Add [matcha](https://vinceliuice.github.io/theme-matcha), a flat Design theme for GTK 3, GTK 2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments like Gnome, Unity, Budgie, Pantheon, XFCE, Mate, etc.

  [See also](https://www.opendesktop.org/p/1187179).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: php: 7.2.8 -> 7.2.10, 7.1.21 -> 7.1.22
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/46694
updated_at: 2018-09-15 21:45:24
body:
  ###### Motivation for this change
  This should *not* be backported due to flag changes due to upstream bugs.

  Changelog 7.2.9: http://php.net/ChangeLog-7.php#7.2.9
  Changelog 7.2.10: http://php.net/ChangeLog-7.php#7.2.10
  Changelog 7.1.22: http://php.net/ChangeLog-7.php#7.1.22

  If someone could trigger a borg build for darwin as well it would be great since 7.2.9 seemed to fail on darwin in the 7.2.9 PR that never got merged due to darwin failure #45159.

  This fixes #45159.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @xeji @globin 


state: closed
title: paperwork: 1.2.2 -> 1.2.4
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/46695
updated_at: 2018-09-15 14:07:04
body:
  ###### Motivation for this change

  Update to latest stable version of paperwork. In the meantime (since the last bump) the source tree layout has changed and I switched to fetching the releases from PyPi instead. The source repository is lacking a few files (namely the version descriptions) on the release tags thus using those PyPi source releases seems to be a sane approach.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.ranger-vim: init at 2018-09-13
user_login: cjpbirkbeck
html_url: https://github.com/NixOS/nixpkgs/pull/46696
updated_at: 2018-09-15 14:46:27
body:
  ###### Motivation for this change

  Adds a plugin that integrates the ranger file manager into vim.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: php71: 7.1.21 -> 7.1.22
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/46697
updated_at: 2018-09-15 19:46:36
body:
  ###### Motivation for this change
  Changelog: https://secure.php.net/ChangeLog-7.php#7.1.22

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cni-plugins: 0.7.1 -> 0.7.3
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/46698
updated_at: 2018-09-15 14:40:02
body:
  Signed-off-by: Vincent Demeester <vincent@sbr.pm>

  ###### Motivation for this change

  Bump to latest fix version of `cni-plugins`

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: darwin.apple_sdk: update to 10.13
user_login: uri-canva
html_url: https://github.com/NixOS/nixpkgs/pull/46699
updated_at: 2018-09-21 02:09:18
body:
  ###### Motivation for this change

  10.10 SDKs don't support type arguments in Foundation classes, leading to "type arguments cannot be applied to non-parameterized class" errors.

  Based on 377cef8d16c47df74d2653432d9bba968236c8a0.

  ## WARNING:

  This will cause mass rebuilds on Darwin, and should be merged into staging I think, rather than master, please advise whether I should submit the PR against staging instead (it has merge conflicts between master and staging so if I submit it against staging it won't apply cleanly on master and vice versa).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: 0.16.1 -> 0.17.1
user_login: uri-canva
html_url: https://github.com/NixOS/nixpkgs/pull/46700
updated_at: 2018-09-17 23:04:41
body:
  ###### Motivation for this change

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Paket: 1.18.2 -> 5.179.1
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/46701
updated_at: 2018-09-15 14:04:10
body:
  ###### Motivation for this change

  The build for Paket currently is failing and is outdated. This PR will bring it up-to-date, although it won't build from source anymore.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Deedle: 1.2.0 -> 1.2.5
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/46702
updated_at: 2018-09-15 14:27:40
body:
  Deedle was outdated and the build was failing.

  This probably needs backporting to 18.09 (#45960)


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pyodbc: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46703
updated_at: 2018-09-15 21:14:52
body:
  ###### Motivation for this change

  ZHF #45960.
  Build failed with libiodbc after pyodbc 4.0.23->4.0.24 update: https://hydra.nixos.org/build/80724929.

  To fix, build with unixODBC instead of libiodbc, see discussion in https://github.com/mkleehammer/pyodbc/issues/444

  ###### Things done

  - [x] Built in a sandbox on NixOS

  ---


state: closed
title: stdenv/darwin: integrate a new CoreFoundation
user_login: copumpkin
html_url: https://github.com/NixOS/nixpkgs/pull/46704
updated_at: 2018-10-24 23:39:26
body:
  This also updates the bootstrap tool builder to LLVM 5, but not the ones we actually use for bootstrap. I'll make that change in a subsequent commit so as to provide traceable provenance of the bootstrap tools.

  ###### Motivation for this change

  We have a horribly out of date CoreFoundation in our stdenv and this should modernize it a bit, allowing us to finally advance some other packages and also remove some workarounds.

  ###### Things done

  [Here's an evaluation](https://hydra.nixos.org/eval/1478828?compare=1477805#tabs-now-fail) of the last state of this prior to me rebasing onto staging. I didn't feel like running a whole new eval after rebasing. Note that I also added the `CFFileDescriptor.h` stuff to support `watchman` properly since that eval, so if it complains that `watchman` is now failing, it's actually healthy again.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Failing tests for go-1.11 on i686-linux
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/issues/46705
updated_at: 2018-09-16 10:03:30
body:
  ## Issue description

  The build of go-1.11 on i686-linux is failing because one of the tests does not pass. We can see that happening on Hydra, for example:

  https://hydra.nixos.org/build/80999166/nixlog/12

  This issue has already been reported to go and is happening on some Debian 386 builds as well. For reference: https://github.com/golang/go/issues/25628

  Note that there are multiple tests failing due to this error. So this issue is related to #45960.

  ### Steps to reproduce

  ```
  nix-build -A go . --argstr system i686-linux
  ```

  Results in:

  ```
  --- FAIL: TestExtraFiles (0.08s)
      exec_test.go:607: Run: exit status 1; stdout "leaked parent file. fd = 44; want 43\n", stderr ""
  FAIL
  FAIL    os/exec 1.636s
  ```

  Note that x86_64 does pass the tests.

  A possible workaround for the moment is disabling checks for the go package for i686.


state: closed
title: go: skip flaky os/exec TestExtraFiles
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/46706
updated_at: 2018-09-16 10:28:12
body:
  ###### Motivation for this change

  Currently the builds regarding go 1.11 on i686-linux are failing. This hits a number of NixOS tests.

  The test only fails on i686 and not just on NixOS. It also happens on
  Debian. For more information:

  https://github.com/golang/go/issues/25628

  This probably needs to be backported to 18.09 (#45960)

  Closes #46705

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: darcs: unpin ghc (use 8.4.x) version
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/46707
updated_at: 2018-09-15 18:06:27
body:
  ###### Motivation for this change
  Fixes Hydra build
  /cc ZHF #45960

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: 2018.08.04 -> 2018.09.10
user_login: AndersonTorres
html_url: https://github.com/NixOS/nixpkgs/pull/46708
updated_at: 2019-01-31 09:26:16
body:
  ###### Motivation for this change

  Update version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Elm: widen language-glsl dependency, pick up minor updates
user_login: jerith666
html_url: https://github.com/NixOS/nixpkgs/pull/46710
updated_at: 2018-09-16 11:07:08
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: rust.section.md: remove nixcrate reference
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46711
updated_at: 2018-09-15 18:53:46
body:
  ###### Motivation for this change
  nixcrate is deprecated


  cc @matthewbauer
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ios-depoy: Add missing rsync dep
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46712
updated_at: 2018-09-15 22:24:09
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC @luigy


state: closed
title: ios-depoy: Add missing rsync dep
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/46713
updated_at: 2018-09-15 22:24:08
body:
  ###### Motivation for this change

  Backport of #46712.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC @luigy 


state: closed
title: tectonic: 0.1.8 -> 0.1.9
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46714
updated_at: 2018-09-15 21:05:50
body:
  https://github.com/tectonic-typesetting/tectonic/releases/tag/v0.1.9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @lluchs


state: closed
title: Emacs package updates
user_login: ttuegel
html_url: https://github.com/NixOS/nixpkgs/pull/46715
updated_at: 2018-09-15 21:03:36
body:
  ###### Motivation for this change

  This updates the `emacsPackagesNg` set to the latest MELPA and ELPA packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.03] php: 5.6.37 -> 5.6.38, 7.0.31 -> 7.0.32
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/46717
updated_at: 2018-09-15 21:30:04
body:
  ###### Motivation for this change
  These versions doesn't exist in unstable or 18.09 due to them both being EOL in december this year, but php tend to release bugfixes.

  We would need someone to trigger the darwin build to see if the same bug as in #46694 exists in these versions. If so we shouldn't merge this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @xeji 


state: open
title: Can we get rid of qt4?
user_login: copumpkin
html_url: https://github.com/NixOS/nixpkgs/issues/46719
updated_at: 2018-10-12 14:47:11
body:
  It uses a deprecated API in CoreFoundation on Darwin in a nontrivial way and I'd rather not jump through a bunch of hoops to support ancient code when QT5 has been out for over half a decade now 😄


state: closed
title: android-platform-tools: 26.0.2 -> 28.0.1
user_login: baldo
html_url: https://github.com/NixOS/nixpkgs/pull/46720
updated_at: 2018-10-06 03:42:31
body:
  ###### Motivation for this change

  Updating to latest platform tools for supporting newer devices.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Successfully tested by flashing my Pixel 2 and perfroming remote operations via adb.

  I do not have a MacOS device around for testing, but made sure the SHA256 hash for x86_64-darwin matches:

  ```
  nix-prefetch-url "https://dl.google.com/android/repository/platform-tools_r28.0.1-darwin.zip"
  path is '/nix/store/5ii60jmd4fd4r4g2f2y7f8b5i27r73g3-platform-tools_r28.0.1-darwin.zip'
  117syrddq1haicwyjzd1p4pfphj0wldjs7w10fpk3n2b7yp37j1v
  ```


state: closed
title: gn: generate last_commit_position.h without git
user_login: YorikSar
html_url: https://github.com/NixOS/nixpkgs/pull/46721
updated_at: 2018-09-16 11:56:10
body:
  ###### Motivation for this change

  For Git to work properly, I used fetchgit with leaveDotGit. This seems
  to be causing hash to change on different systems in different times.
  I've replaced generation of last_commit_position.h in tools/gen.py with
  just plain nix template. "gn --version" will loose a bit (just commit
  hash, without commit height in front of it), but I hope noone relies on
  it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Related PRs: #46328 #46718
  CC @volth @eadwu @7c6f434c @Mic92 


state: closed
title: scrcpy: 1.2 -> 1.3
user_login: baldo
html_url: https://github.com/NixOS/nixpkgs/pull/46722
updated_at: 2018-09-16 12:08:40
body:
  ###### Motivation for this change

  Update to newest version: Running 1.2 I ran into issues when changing my Pixel 2's resolution, 1.3 seems to have fixed those.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Also tested with updated android-platform-tools from PR #46720.


state: closed
title: git: 2.18.0 -> 2.19.0
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/46723
updated_at: 2018-09-24 11:56:56
body:
  ###### Motivation for this change

  Package update. PR is based on and aimed at staging due to the large number of packages affected.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emby: 3.4.1.0 -> 3.5.2.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46724
updated_at: 2018-09-20 10:35:10
body:
  ###### Motivation for this change
  An update and #44884 had conflicts.

  @numinit noticed this
  ```
  System.UnauthorizedAccessException: Access to the path "/nix/store/nfmvvn6jv5b29q8a1m8pz2mmx4y3fjfn-emby-3.5.2.0/bin/plugins/Emby.Server.CinemaMode.dll" or "/var/lib/emby/ProgramData-Server/plugins/Emby.Server.CinemaMode.dll" is denied.
    at System.IO.File.Copy (System.String sourceFileName, System.String destFileName, System.Boolean overwrite) [0x00192] in <2bf5cbaa96234d758393ee9c32a4b268>:0
    at Emby.Server.Implementations.ApplicationHost.CopyPlugins (System.String source, System.String target) [0x0008f] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.GetPluginAssemblies () [0x00023] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.GetComposablePartAssemblies () [0x00000] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.DiscoverTypes () [0x00015] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.Init () [0x0009b] in <ea7199aea78e429a84e168a1e154646a>:0
    at MediaBrowser.Server.Mono.MainClass.RunApplication (Emby.Server.Implementations.ServerApplicationPaths appPaths, MediaBrowser.Model.Logging.ILogManager logManager, Emby.Server.Implementations.StartupOptions options) [0x000c2] in <674f05e6c9e14fbaa7955ba5ed6025ed>:0
    at MediaBrowser.Server.Mono.MainClass.Main (System.String[] args) [0x0009c] in <674f05e6c9e14fbaa7955ba5ed6025ed>:0
  System.UnauthorizedAccessException
    at System.IO.File.Copy (System.String sourceFileName, System.String destFileName, System.Boolean overwrite) [0x00192] in <2bf5cbaa96234d758393ee9c32a4b268>:0
    at Emby.Server.Implementations.ApplicationHost.CopyPlugins (System.String source, System.String target) [0x0008f] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.GetPluginAssemblies () [0x00023] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.GetComposablePartAssemblies () [0x00000] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.DiscoverTypes () [0x00015] in <ea7199aea78e429a84e168a1e154646a>:0
    at Emby.Server.Implementations.ApplicationHost.Init () [0x0009b] in <ea7199aea78e429a84e168a1e154646a>:0
    at MediaBrowser.Server.Mono.MainClass.RunApplication (Emby.Server.Implementations.ServerApplicationPaths appPaths, MediaBrowser.Model.Logging.ILogManager logManager, Emby.Server.Implementations.StartupOptions options) [0x000c2] in <674f05e6c9e14fbaa7955ba5ed6025ed>:0
    at MediaBrowser.Server.Mono.MainClass.Main (System.String[] args) [0x0009c] in <674f05e6c9e14fbaa7955ba5ed6025ed>:0
  ```

  This is going on here [Emby.Server.Implementations.ApplicationHost.CopyPlugins](https://github.com/MediaBrowser/Emby/blob/f1998b6aa926269761071990e829ae4f5b351745/Emby.Server.Implementations/ApplicationHost.cs#L1814)
  Any ideas?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocaml ≤ 4.05: mark as broken on Aarch64
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/46726
updated_at: 2018-09-16 08:44:45
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/46640#issuecomment-421349499

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.odoc: init at 1.2.0
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/46727
updated_at: 2018-09-24 05:08:42
body:
  ###### Motivation for this change

  odoc is a documentation generator for OCaml.

  This PR also adds a few dependencies.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vim-tsx: init at 2017-03-16
user_login: samdroid-apps
html_url: https://github.com/NixOS/nixpkgs/pull/46728
updated_at: 2018-09-20 07:46:47
body:
  ###### Motivation for this change

  Add a plugin for vim that does highlighting for typescript jsx.

  example usage:

  ```nix
  let
    myVim = pkgs.vim_configurable.customize {                                   
      name = "vim";                                                      
      vimrcConfig.vam.pluginDictionaries = [                                           
        { name = "vim-tsx"; }
      ];
    };
  in
  ...
  ```

  Then you can view a tsx file.  [This is an example file](https://raw.githubusercontent.com/Lemoncode/react-typescript-samples/master/06%20AJAX%20Call/src/router.tsx) you could download to test.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: network-manager-applet fails at importing .ovpn file
user_login: candeira
html_url: https://github.com/NixOS/nixpkgs/issues/46729
updated_at: 2018-10-11 21:10:18
body:
  ## Issue description

  I have some .ovpn files that import well using network-manager-applet on my up-to-date Debian system, but the import process (or possibly the graphical UI saving process) mangles the key/ca/cert when importing on NixOS 18.03.

  Looks to me like a possible upstream regression, but I don't know how to deal with that, so...

  Here are the versions running on the Debian system:

  network-manager: 1.6.2-3
  network-manager-openvpn: 1.2.8-2
  network-manager-openvpn-gnome: 1.2.8-2

  Here are the versions running on the NixOS 18.03 system:

  network-manager: 1.10.2
  network-manager-openvpn: 1.8.0

  And on NixOS 18.09:

  network-manager: 1.12.0
  network-manager-openvpn: 1.8.4

  ### Steps to reproduce

  Via the GUI:
  - Using nm-applet, open "VPN Settings"
  - On the VPN Settings window, click on the "+" symbol next to "VPN"
  - On the Add VPN dialog, select "Import from file..."
  - On the file dialog, select and open a known good .ovpn file
  - At this point, the key/ca/cert seem fine on the configuration dialog. [1]
  - Still in the configuration dialog, enter user and password, and hit 'Save'.
  - Try to connect with the VPN. It will fail.
  - Re-open the configuration dialog, and see how the key is now empty, and both the ca and the cert point to the ca. [2]
  - Edit NetworkManager's openvpn configuration by hand in /etc/NetworkManager/system-connection/$yourconnectionname, to fix the ca/cert/key configuration.
  - Re-open the configuration dialog, and see how it shows an empty key field, and the ca file for both the ca and the cert, as above.

  [1]
  ![image](https://user-images.githubusercontent.com/91694/45593438-f7b1f480-b9c9-11e8-94a1-5b4f57e103b4.png)


  [2]
  ![image](https://user-images.githubusercontent.com/91694/45593420-c507fc00-b9c9-11e8-9f05-b6321c8c4809.png)


  ## Technical details

  [root@desire:/etc/nixos]# nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.68, NixOS, 18.03.git.dbdcdd3 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.0.4`
   - channels(kandinski): `"nixos-18.09-18.09beta230.32c008a946c"`
   - channels(root): `"nixos-18.03.133224.5f59ab7d4e0"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: cctools: support LTO on Darwin
user_login: copumpkin
html_url: https://github.com/NixOS/nixpkgs/pull/46730
updated_at: 2018-09-17 04:59:27
body:
  LTO is disabled during bootstrap to keep the bootstrap tools small and avoid unnecessary LLVM rebuilds, but is enabled in the final stdenv stage and should be usable by normal packages.

  ###### Motivation for this change

  Enables better optimization if packages want it. Also, why not? 😄 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.libnacl: fix build on darwin
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/46731
updated_at: 2018-09-16 08:34:17
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.asyncssh: 1.13.3 -> 1.14.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46732
updated_at: 2018-09-16 10:28:56
body:
  [Change Log](https://github.com/ronf/asyncssh/blob/0c610d0f296593f4814ff1f2a3be18ee26a7b204/docs/changes.rst#change-log)

  This includes changing the license from EPL 1.0 to EPL 2.0.

  `openssl` was added to `checkInputs` because this [test](https://github.com/ronf/asyncssh/blob/0c610d0f296593f4814ff1f2a3be18ee26a7b204/tests/test_public_key.py) fails very early on without it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/lightdm: use systemd.tmpfiles
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/46734
updated_at: 2018-09-17 12:23:46
body:
  ###### Motivation for this change
  A while ago I noticed with elementary that the data dir `/var/lib/lightdm-data/<username>` didn't have the correct permissions for their wallpaper switcher to set the greeters wallpaper (that is create a file there called `wallpaper`).

  So this is a general improvement that came out of that.

  ###### For Clarity
  I deleted `--log-dir=/var/log --run-dir=/run` in `execCmd` because these will be set to `/var/log/lightdm` and `/var/run/lightdm` by default.

  Also the correct `home` location is `/var/lib/lightdm`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnirehtet: 2.2.1 -> 2.3
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/46735
updated_at: 2018-09-18 07:00:01
body:
  https://github.com/Genymobile/gnirehtet/releases/tag/v2.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @symphorien


state: closed
title: mpack: Invoke /run/wrappers/bin/sendmail via execvp
user_login: clefru
html_url: https://github.com/NixOS/nixpkgs/pull/46736
updated_at: 2018-09-18 09:04:13
body:
  Calling /run/current-sw/bin/sendmail fails under postfix because
  setgid bits are not set. Switching the hardcoded path to an invocation
  via execvp should cover both cases, when the sendmail binary is
  setgid-wrapped and when it is not.

  ###### Motivation for this change
  mpack can't send mails under a postfix installation, as the setgid bits are missing in postdrop.
  ```
  $ strace -etrace=execve -f mpack -s ethereum-cc.pdf tmp.pdf clemens@endorphin.org                                                          execve("/home/clemens/.nix-profile/bin/mpack", ["mpack", "-s", "ethereum-cc.pdf", "tmp.pdf", "clemens@endorphin.org"], 0x7ffeb53e6220 /* 82 vars */) = 0
  strace: Process 36692 attached
  [pid 36692] execve("/usr/lib/sendmail", ["sendmail", "-oi", "clemens@endorphin.org"], 0x7ffe0fc75808 /* 82 vars */) = -1 ENOENT (No such file or directory)
  [pid 36692] execve("/run/current-system/sw/bin/sendmail", ["sendmail", "-oi", "clemens@endorphin.org"], 0x7ffe0fc75808 /* 82 vars */) = 0
  strace: Process 36693 attached
  [pid 36693] execve("/nix/store/a9ck93r3rw8frqph73fhgr0mfvs6dzv8-postfix-3.3.1/bin/postdrop", ["/nix/store/a9ck93r3rw8frqph73fhg"..., "-r"], 0x563f5b430220 /* 2 vars */) = 0
  postdrop: warning: mail_queue_enter: create file maildrop/528081.36693: Permission denied
  postdrop: warning: mail_queue_enter: create file maildrop/528270.36693: Permission denied
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sierra-gtk-theme: init at 2018-09-14
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/46737
updated_at: 2018-09-17 13:33:47
body:
  ###### Motivation for this change

  Add [sierra-gtk-theme](https://github.com/vinceliuice/Sierra-gtk-theme). Sierra is a Mac OSX like theme for GTK 3, GTK 2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments like Gnome, Pantheon, XFCE, Mate, etc.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: fetchgit with leaveDotGit: increase determinism, fix hashes
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/46739
updated_at: 2018-09-21 13:37:34
body:
  ###### Motivation for this change

  Increase determinism of ```fetchgit``` output when ```leaveDotGit``` is used.

  It is not the final solution, as @Mic92 pointed out, the hashes may change if a newer git changes its internal format, but if should prevent the mess like we had with ```gn``` recently (https://github.com/NixOS/nixpkgs/pull/46328 https://github.com/NixOS/nixpkgs/pull/46721 https://github.com/NixOS/nixpkgs/pull/46718)

  Also, fixed the hashes which are already incorrect.


state: closed
title: texlive: changes trigger mass rebuilds
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/issues/46740
updated_at: 2018-09-17 13:13:52
body:
  ### Issue description

  Pretty much any change to `texlive` or its packages triggers a mass rebuild (examples: #46376, #40232),  mainly because it is used to build documentation for many packages. 

  This makes `texlive` difficult to maintain/bugfix as any change must go through a staging iteration.

  My analysis (using `maintainers/scripts/rebuild-amount.sh`) indicates that the mass rebuild is mainly caused by `gtk-doc`, which depends on `texlive` via `dblatex`.

  ### How can we fix this? 

  I see 2 possible solutions (of course, any fix will cause a mass rebuild :smile:):

  1.  Build `gtk-doc` without `dblatex` by default, which removes the `texlive` dependency. It won't be able to generate pdf docs, but do we really need them? This is my recommendation.

  2. Duplicate `texlive` as `texlive-for-docs`  and use that for `gtk-doc` and other packages generating docs. `texlive-for-docs` won't need frequent updates, it's good enough if it works.

  ---

  cc  @vcunat @samueldr @jtojnar @pSub @veprbl @bhipple


state: closed
title: exim: parametrise package
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/46741
updated_at: 2018-09-16 23:43:00
body:
  This allows the definition of a custom derivation of Exim, which can be used to enable custom features such as LDAP and PAM support.

  The default behaviour remains unchanged (defaulting to pkgs.exim).

  ---

  As the default behaviour is preserved, could this be backported to `release-18.{03,09}` too?

  CC: @4z3 (Exim package maintainer)


state: closed
title: cmake: make overriding the install path easier
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/46742
updated_at: 2019-04-27 07:50:31
body:
  ## Issue description
  When trying to test the installPhase in a nix-shell, I usually do export out=$PWD/toto (export dev=$PWD/dev etc for each output).

  Now I did the same with a cmake-based project but the install folder remained the same, e.g., /nix/store/xxxxx . According to 
  https://github.com/NixOS/nixpkgs/blob/d499b7d821106964581cbb6eab5354fbdf7a6847/pkgs/development/tools/build-managers/cmake/setup-hook.sh#L29
  it's expected since the hook utilizes $prefix instead of $out. exporting $prefix from the shell is useless since nixpkgs overrides it somewhere it seems.

  In order to make the UI more consistent, would it be possible to replace the $prefix via $out ? Is there a reason not to ? 

  The alternative is to set `dontAddPrefix` and append to cmakeFlags -DCMAKE_INSTALL_PREFIX. Rather cumbersome when it's a matter of exporting out=/tmp for most programs.


state: closed
title: any-nix-shell: init at 1.1.0
user_login: haslersn
html_url: https://github.com/NixOS/nixpkgs/pull/46743
updated_at: 2018-10-08 19:41:30
body:
  ###### Motivation for this change

  This adds `fish` and `zsh` support for both `nix run` and `nix-shell`. More supported shells can be added in the future.

  Supersedes #46630 as this is version 1.1.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: exim: add optional support for PAM
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/46744
updated_at: 2018-09-17 09:13:21
body:
  CC: @4z3 (Exim package maintainer)

  It would be nice if this could be back-ported to `release-18.09` too if it's not too late.


state: closed
title: pythonPackages.dendropy: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46745
updated_at: 2018-09-16 21:42:49
body:
  ###### Motivation for this change

  Fixing another random failure for ZHF #45960. 

  Build [failed after update to 4.4.0](https://hydra.nixos.org/job/nixpkgs/trunk/python36Packages.dendropy.x86_64-linux/all) because the tests are incorrectly packaged in the pypi version.
  Switch to upstream github repo, fix tests, disable failing test cases.

  ###### Things done

  - [x] built in a sandbox on NixOS.

  ---


state: closed
title: geoclue2 keeps restarting
user_login: furrycatherder
html_url: https://github.com/NixOS/nixpkgs/issues/46746
updated_at: 2019-01-06 17:19:01
body:
  ## Issue description

  ```
  Sep 16 10:50:53 akita systemd[1]: Starting Location Lookup Service...
  Sep 16 10:50:53 akita systemd[1]: Started Location Lookup Service.
  Sep 16 10:50:59 akita systemd[1]: Starting Location Lookup Service...
  Sep 16 10:50:59 akita systemd[1]: Started Location Lookup Service.
  Sep 16 10:51:06 akita systemd[1]: Starting Location Lookup Service...
  Sep 16 10:51:06 akita systemd[1]: Started Location Lookup Service.
  Sep 16 10:51:12 akita systemd[1]: Starting Location Lookup Service...
  Sep 16 10:51:12 akita systemd[1]: Started Location Lookup Service.
  Sep 16 10:51:19 akita systemd[1]: Starting Location Lookup Service...
  Sep 16 10:51:19 akita systemd[1]: Started Location Lookup Service.
  ```
  Trying to run it manually gives

  ```
  (geoclue:12164): Geoclue-CRITICAL **: 10:59:11.310: Failed to acquire name 'org.freedesktop.GeoClue2' on system bus or lost it.
  ```
  ### Steps to reproduce
  ```
        redshift = {
          enable = true;
          provider = "geoclue2";
        };
  ```
  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.69, NixOS, 19.03pre152634.218ce4de508 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.1`
   - channels(sean): `"nixos-19.03pre151837.ca2ba44cab4"`
   - channels(root): `"nixos-19.03pre152634.218ce4de508"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: ipfs-migrator: 6 -> 7
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46747
updated_at: 2018-09-17 17:18:49
body:
  ###### Motivation for this change

  New version of the ipfs repo migration tools. This is required to migrate existing ipfs repos to repo v7.

  Needs backport to 18.09 since existing ipfs repos from 18.03 will have to be migrated to v7 in 18.09.

  ###### Things done

  - [x] built in a sandbox on NixOS

  ---


state: closed
title: vimPlugins: adding vim-sayonara/nvimdev/obsession
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/46748
updated_at: 2018-09-17 13:16:29
body:
  ###### Motivation for this change
  plugins I use ?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.primitive: 0.6.3.0 -> 0.6.4.0
user_login: nek0
html_url: https://github.com/NixOS/nixpkgs/pull/46749
updated_at: 2018-09-16 19:12:48
body:
  ###### Motivation for this change

  Upgrade the `primitive` package, because it is marked as deprecated on hackage.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: switch-to-configuration.pl:"reload user units" does not execute in user shell
user_login: jamesbroadhead
html_url: https://github.com/NixOS/nixpkgs/issues/46750
updated_at: 2018-09-18 19:47:15
body:
  ## Issue description
  ```
  $ nixos-rebuild switch --upgrade

  ... 
  activating the configuration...
  setting up /etc...
  reloading user units for jbo...
  /home/jbo/.git-completion.bash: line 2715: complete: command not found
  /home/jbo/.git-completion.bash: line 2715: complete: command not found
  /home/jbo/.bash_profile: line 114: set: vi: invalid option name
  setting up tmpfiles
  reloading the following units: dbus.service
  restarting the following units: polkit.service
  starting the following units: accounts-daemon.service
  $ 
  ```
  `set -o vi` is valid bash, and `complete` is a bash shell builtin.
  This implies to me that the 'reloading user units does not happen in the same shell the user has selected.

  Looks like the perl script uses the system default shell from `pkgs.stdenv` -- instead, it should probably select the users' default shell. 

  ### Steps to reproduce
  Add `set -o vi` to ~/.bashrc for a user, then run 
  `nixos-rebuild switch --upgrade`

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.69, NixOS, 19.03pre152634.218ce4de508 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.1`
   - channels(root): `"nixos-19.03pre152634.218ce4de508"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: vimPlugins: vim-plug, fixes and updates
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/46751
updated_at: 2018-09-20 07:41:16
body:
  ###### Motivation for this change
  I was unable to make https://github.com/fatih/vim-go work using either the "native" plugin manager, or vam, hence I added a simple `vim-plug` implementation, which fixed the issue.
  - Added `vim-plug` implementation of vim addon manager, accessible via `configure.plug`
  - Fixed `Shougo` username being spelled with lower-case. See https://github.com/Shougo
  - Updated some plugins along the way

  Example usage can be seen [here](https://github.com/rvolosatovs/infrastructure/blob/e78db7855199278a2b01a230e55e8688799460d4/nixpkgs/neovim/default.nix#L46-L48)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Gotools etc. update, remove goimports
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/46752
updated_at: 2018-09-20 07:18:27
body:
  ###### Motivation for this change
  `goimports` is severely outdated and the tool itself is included in `gotools`, hence I removed it and added an alias for backwards compatibility.
  Some updates included.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openspin: init at 2018-10-02
user_login: redvers
html_url: https://github.com/NixOS/nixpkgs/pull/46753
updated_at: 2018-10-17 01:18:04
body:
  ###### Motivation for this change
  OpenSpin is an open source compiler for the Parallax Propeller MCU.  Additional package for those propeller developers who run on NixOS.

  ###### Things done

  - [✔] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ✔] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [N/A] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [✔] Tested execution of all binary files (usually in `./result/bin/`)
  - [N/A] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [✔] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyo3-pack: init at 0.3.8
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/46754
updated_at: 2019-06-04 05:55:51
body:
  ###### Motivation for this change

  pyo3-pack is a utility for building Python modules in Rust. It works with binding crates such as pyo3 and cpython.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: arcanist: 20170323 -> 20180916
user_login: eliasp
html_url: https://github.com/NixOS/nixpkgs/pull/46755
updated_at: 2018-09-29 07:36:14
body:
  ###### Motivation for this change
  Making sure arcanist is up-to-date and not lagging behind too much…

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: top-level/release.nix: add patchShebangs test
user_login: copumpkin
html_url: https://github.com/NixOS/nixpkgs/pull/46756
updated_at: 2018-09-17 19:42:14
body:
  This is currently failing but nobody noticed!

  ###### Motivation for this change

  The failure causes all sorts of subtle issues so best to catch it early and loudly.


state: closed
title: Taffybar should use `ghc-8.2.x`
user_login: PierreR
html_url: https://github.com/NixOS/nixpkgs/issues/46757
updated_at: 2018-12-13 18:44:44
body:
  ## Issue description

  Taffybar (v.3.0.0) is (totally) broken when compiled with `ghc-8.4.x` due to a ghc regression that has been fixed in `ghci-8.6.x`.  See https://github.com/taffybar/taffybar/issues/358

  IIUC it is going to be shipped with that version of ghc. in `nixos-18.09`.

  ### Steps to reproduce

  Install `taffybar` using the current unstable channel in a nixos virtual machine (for instance virtualbox).
  Resize the main windows a couple of time => the taffybar disappeared killed with a segfault.


  ## Technical details
  ```
  λ ~ → nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.63, NixOS, 18.09pre149415.8395f9aa85e (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.0.4`
   - channels(vagrant): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: vivaldi: 1.15.1147.42-1 -> 1.15.1147.64-1
user_login: lluchs
html_url: https://github.com/NixOS/nixpkgs/pull/46758
updated_at: 2018-09-17 13:46:12
body:
  ###### Motivation for this change

  Package update. Also fixes the vivaldi-ffmpeg-codecs package.

  Fixes #39590

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.primitive: 0.6.3.0 -> 0.6.4.0
user_login: nek0
html_url: https://github.com/NixOS/nixpkgs/pull/46759
updated_at: 2018-09-17 10:18:24
body:
  ###### Motivation for this change

  Upgrade the package version due to the old version being marked as deprecated on hackage.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: particl-qt: init at 0.17.0.2
user_login: demyanrogozhin
html_url: https://github.com/NixOS/nixpkgs/pull/46760
updated_at: 2018-11-01 21:18:12
body:
  ###### Motivation for this change

  Particl QT wallet that can be used to activate cold staking with Ladger hardware wallet.
  Works Linux only so far.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk-doc: don't build with dblatex by default
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46761
updated_at: 2018-09-18 16:50:51
body:
  ###### Motivation for this change

  Fix #46740 . Make it optional: (`withDblatex ? false`) to remove the dependency of `gtk-doc` on texlive.
  Without `dblatex`, it cannot generate pdf docs, but most people wouldn't want those by default anyway.

  Now changes to `texlive` don't trigger mass rebuilds any more. 
  This may also help with https://github.com/NixOS/nixpkgs/pull/45950#issuecomment-421545698.

  ###### Things done

  - [x] built in sandbox on NixOS 

  ---

  cc @jtojnar 


state: closed
title: ostree: fix tests
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/46762
updated_at: 2018-09-17 07:27:23
body:
  ###### Motivation for this change

  `ostree` tests have never passed on hydra: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.ostree.x86_64-linux/all .
  This may be the combined result of some upstream issues and our specific test setup. 

  To make the tests pass:

  - Patch the tests with workarounds for https://github.com/ostreedev/ostree/issues/1592
  - Disable failing `test-gpg-verify-result.test`, see https://github.com/ostreedev/ostree/issues/1634

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @jtojnar


state: open
title: Installer tests don't show segfaults since the transition to nix 2.0 and nixos-enter
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/issues/46763
updated_at: 2018-09-17 17:23:52
body:
  ## Issue description

  I wasn't able to *conclusively* put the finger on one commit, but I was able to observe that at the merge of the branch `nix-2.0` the segfaults are not present in the installer test logs, while they are in the commit preceding the merge.

   * d586f5d97e8d37f43eae2fe5c98598ce1c393688 "Merge branch 'nix-2.0'"
   * c94ad64ae5573f529213c4d97baf3ea67e86b6b7 "rsbep: init at 0.1.0" (preceding good commit)

  This can also be observed on hydra, test failures for grub1 stopped showing the segfault.

  > The segfaulting part is `grub`, the "shell" part of grub. On current nixpkgs, it can be shown segfaulting easily > by using `nix-shell -p grub --run grub`.
  > 
  > ```
  > ~/tmp/nixpkgs/nixpkgs-test-segfault $ nix-shell -p grub --run grub
  > Probing devices to guess BIOS drives. This may take a long time.
  > /tmp/nix-shell-30209-0/rc: line 1: 31572 Segmentation fault      grub
  > ```

  This isn't the issue here, the issue here is that we probably need to *somehow* get back the segfaults into the logs for the installer tests.

  cc @edolstra, as he authored `nixos-enter`. I don't entirely know how it differs to what was previously done to chroot and install, in which it would matter for printing segfaults.

  ### Steps to reproduce

  Run the `grub1` installer tests for each of the previously listed commits.

  ##### d586f5d97e8d37f43eae2fe5c98598ce1c393688 "Merge branch 'nix-2.0'"

  ```
   $ nix-build nixos/tests/installer.nix -A grub1
  [...]
  machine# updating GRUB 1 menu...
  machine# installing the GRUB 1 boot loader on /dev/sda...
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 328: /tmp/grub-install.log.163: No such file or directory
  machine# grep: /tmp/grub-install.log.163: No such file or directory
  machine# sed: can't read /44V9x5vg6M/boot/grub/device.map: No such file or directory
  machine# grep: /44V9x5vg6M/boot/grub/device.map: No such file or directory
  machine# /dev/sda does not have any corresponding BIOS drive.
  machine# /nix/store/ixvwjckxam1rcvlklw1ap6pb3w0lr58w-install-grub.pl: installation of GRUB on /dev/sda failed
  machine: exit status 1
  machine: output:
  error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
  [...]
  ```

  ##### c94ad64ae5573f529213c4d97baf3ea67e86b6b7 "rsbep: init at 0.1.0" (preceding good commit)

  ```
   $ nix-build nixos/tests/installer.nix -A grub1
  machine# updating GRUB 1 menu...
  machine# installing the GRUB 1 boot loader on /dev/sda...
  machine# Probing devices to guess BIOS drives. This may take a long time.
  machine# [  356.570578] print_req_error: I/O error, dev fd0, sector 0
  machine# [  356.571452] floppy: error 10 while reading block 0
  machine# [  356.584831] show_signal_msg: 73 callbacks suppressed
  machine# [  356.584833] grub[27572]: segfault at f18 ip 0000000008049909 sp 00000000f7a15ffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 337: 27572 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# quit
  machine# EOF
  machine#
  machine# [  356.686294] grub[27644]: segfault at f18 ip 0000000008049909 sp 00000000f79f1ffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 411: 27644 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# dump ${root_drive}${tmp} ${img_file}
  machine# quit
  machine# EOF
  machine#
  machine# cmp: /tmp/grub-install.img.27565: No such file or directory
  machine# [  357.704025] grub[27649]: segfault at f18 ip 0000000008049909 sp 00000000f7971ffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 411: 27649 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# dump ${root_drive}${tmp} ${img_file}
  machine# quit
  machine# EOF
  machine#
  machine# cmp: /tmp/grub-install.img.27565: No such file or directory
  machine# [  358.722851] grub[27654]: segfault at f18 ip 0000000008049909 sp 00000000f7994ffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 411: 27654 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# dump ${root_drive}${tmp} ${img_file}
  machine# quit
  machine# EOF
  machine#
  machine# cmp: /tmp/grub-install.img.27565: No such file or directory
  machine# [  359.743449] grub[27659]: segfault at f18 ip 0000000008049909 sp 00000000f79dbffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 411: 27659 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# dump ${root_drive}${tmp} ${img_file}
  machine# quit
  machine# EOF
  machine#
  machine# cmp: /tmp/grub-install.img.27565: No such file or directory
  machine# [  360.760830] grub[27664]: segfault at f18 ip 0000000008049909 sp 00000000f7974ffc error 6 in grub[8048000+2a000]
  machine# /nix/store/6bf7yksn9q22p4bqh15ih4bvkmnir3pi-grub-0.97-patch-1.12/sbin/grub-install: line 411: 27664 Segmentation fault      $grub_shell --batch $no_floppy --device-map=$device_map  > $log_file <<EOF
  machine# dump ${root_drive}${tmp} ${img_file}
  machine# quit
  machine# EOF
  machine#
  machine# cmp: /tmp/grub-install.img.27565: No such file or directory
  machine# The file /tmp/EGzKVZ9VAl/boot/grub/stage1 not read correctly.
  machine# /nix/store/ixvwjckxam1rcvlklw1ap6pb3w0lr58w-install-grub.pl: installation of GRUB on /dev/sda failed
  machine: exit status 1
  machine: output:
  error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
  [...]
  ```

  ## Technical details

  *This is probably irrelevant, as the installer tests are not affected by this, I believe. See also the previous parts which are pretty technical.*

  ```
  system: "x86_64-linux", multi-user?: yes, version: nix-env (Nix) 2.0.4, channels(samuel): "unstable", channels(root): "nixpkgs-18.09pre144939.14a9ca27e69", nixpkgs: /etc/nixos/nixpkgs
  ```


state: open
title: future painpoints in building nix packages from source
user_login: waynr
html_url: https://github.com/NixOS/nixpkgs/issues/46764
updated_at: 2018-09-17 20:57:59
body:
  ## Issue description

  A few months ago I ran into a problem in which a github pull request commit was referenced by a nix package as a patch that should applied at build time. Not surprisingly, someone ended up force pushing their PR branch and effectively wiping out the patch, leading to pain when i attempted to build (I think it was Python3) from source.

  I happen to be waiting for another build at the moment so I thought I would see whether this problem remains. It does:

  ```
  <wayne@decay:~/projects/NixOS/nixpkgs>
  zsh/2 1933  (git)-[release-18.09]-% egrep -rn "github.*pull.*.patch"
  pkgs/os-specific/linux/acpi-call/default.nix:14:      url = "https://github.com/mkottman/acpi_call/pull/67.patch";
  pkgs/os-specific/linux/bbswitch/default.nix:19:    url = "https://github.com/Bumblebee-Project/bbswitch/pull/102.patch";
  pkgs/applications/audio/clementine/default.nix:26:      url = "https://github.com/clementine-player/Clementine/pull/5630.patch";
  pkgs/applications/science/logic/vampire/default.nix:25:      url = https://github.com/vprover/vampire/pull/54.patch;
  pkgs/applications/science/logic/vampire/default.nix:31:      url = https://github.com/vprover/vampire/pull/55.patch;
  pkgs/applications/science/logic/vampire/default.nix:37:      url = https://github.com/vprover/vampire/pull/56.patch;
  pkgs/applications/misc/mqtt-bench/default.nix:19:      url = "https://patch-diff.githubusercontent.com/raw/takanorig/mqtt-bench/pull/13.patch";
  pkgs/applications/misc/qsyncthingtray/default.nix:29:    url = "https://patch-diff.githubusercontent.com/raw/sieren/QSyncthingTray/pull/225.patch";
  pkgs/applications/misc/volnoti/default.nix:20:      url = "https://github.com/davidbrazdil/volnoti/pull/10.patch";
  pkgs/applications/networking/sync/lsyncd/default.nix:19:      url = "https://github.com/axkibe/lsyncd/pull/500/commits/0af99d8d5ba35118e8799684a2d4a8ea4b0c6957.patch";
  pkgs/servers/samba/4.x.nix:39:        url = "https://patch-diff.githubusercontent.com/raw/samba-team/samba/pull/107.patch";
  pkgs/servers/slimserver/default.nix:14:    url = "https://github.com/Logitech/slimserver/pull/204.patch";
  pkgs/development/python-modules/pycaption/default.nix:26:        url = "https://github.com/pbs/pycaption/pull/161.patch";
  pkgs/development/python-modules/rocket-errbot/default.nix:14:    url = "https://github.com/errbotio/rocket/pull/1.patch";
  pkgs/development/python-modules/grip/default.nix:31:      url = https://github.com/joeyespo/grip/pull/249.patch;
  pkgs/development/python-modules/blinkstick/default.nix:18:      url = https://github.com/arvydas/blinkstick-python/pull/54.patch;
  pkgs/development/libraries/jemalloc/default.nix:7:    url = "https://patch-diff.githubusercontent.com/raw/jemalloc/jemalloc/pull/1035.patch";
  pkgs/development/libraries/czmq/4.x.nix:14:      url = https://patch-diff.githubusercontent.com/raw/zeromq/czmq/pull/1618.patch;
  pkgs/development/libraries/bootil/default.nix:23:    url = https://github.com/garrynewman/bootil/pull/22.patch;
  pkgs/development/libraries/bootil/default.nix:24:    name = "github-pull-request-22.patch";
  pkgs/development/libraries/science/math/planarity/default.nix:28:      url = "https://github.com/graph-algorithms/edge-addition-planarity-suite/pull/3.patch";
  pkgs/development/libraries/science/math/lcalc/default.nix:63:    #   url = "https://github.com/dimpase/lcalc/pull/1/commits/0500c67b6aa1f492715591669f6647c8f7a3ea59.patch";
  pkgs/development/haskell-modules/configuration-ghc-8.2.x.nix:55:    url = "https://patch-diff.githubusercontent.com/raw/bmillwood/applicative-quoters/pull/7.patch";
  pkgs/development/haskell-modules/configuration-ghc-8.2.x.nix:80:          { url = https://github.com/NICTA/coordinate/pull/4.patch;
  pkgs/development/haskell-modules/configuration-common.nix:917:          { url = https://github.com/EduardSergeev/monad-memo/pull/4.patch;
  pkgs/development/haskell-modules/configuration-common.nix:1103:    url = "https://github.com/guillaume-nargeot/hpc-coveralls/pull/73/commits/344217f513b7adfb9037f73026f5d928be98d07f.patch";
  pkgs/development/haskell-modules/configuration-ghc-8.0.x.nix:47:    url = "https://patch-diff.githubusercontent.com/raw/bmillwood/applicative-quoters/pull/7.patch";
  pkgs/development/haskell-modules/configuration-halvm-2.4.0.nix:46:    url = "https://patch-diff.githubusercontent.com/raw/bmillwood/applicative-quoters/pull/7.patch";
  pkgs/development/compilers/elm/default.nix:97:                  url = "https://github.com/elm/compiler/pull/1784/commits/78d2d8eab310552b1b877a3e90e1e57e7a09ddec.patch";
  pkgs/development/tools/nrpl/default.nix:18:      url    = https://patch-diff.githubusercontent.com/raw/wheineman/nrpl/pull/12.patch;
  pkgs/tools/misc/youtube-dl/default.nix:30:      url = "https://github.com/rg3/youtube-dl/pull/17464/commits/6d7359775ae4eef1d1213aae81e092467a2c675c.patch";
  pkgs/tools/misc/ostree/default.nix:38:      url = https://github.com/ostreedev/ostree/pull/1633.patch;
  pkgs/tools/networking/ngrep/default.nix:16:      url = "https://patch-diff.githubusercontent.com/raw/jpr5/ngrep/pull/11.patch";
  pkgs/top-level/python-packages.nix:1133:        url = "https://patch-diff.githubusercontent.com/raw/aquynh/capstone/pull/783/commits/23fe9f36622573c747e2bab6119ff245437bf276.patch";
  pkgs/top-level/python-packages.nix:7160:        url = "https://github.com/wnielson/markdown-macros/pull/1.patch";
  ```

  ### Steps to reproduce

  `egrep -rn "github.*pull.*.patch"` from root of this git repo

  ## Technical details

  Eventually those PRs or their branches are going to change or go away. Patches used during builds should be stored directly in this git repo to reduce the likelihood of build failures. Future PRs should be rejected if they include references to transient VCS commits.


state: closed
title: haskellPackages: Fix ListLike for 8.02 and 8.22
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/46766
updated_at: 2018-09-17 13:24:56
body:
  ###### Motivation for this change

  This fixes *part of* the taffybar build on 8.2

  Ping @basvandijk @peti @ryantm

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


