# issues

state: open
title: Fix the rootPartitionUUID description
user_login: exarkun
html_url: https://github.com/NixOS/nixpkgs/pull/60174
updated_at: 2019-04-24 18:01:49
body:
  The value given here is used as the ext4 filesystem uuid.
  It is not used as the partition uuid.

  ###### Motivation for this change

  I tried to use this option so I could reliably identify the device to which an image had been written.  The uuid ended up in a different place than the description led me to believe.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix orca and re-add liblouis
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60175
updated_at: 2019-04-25 17:41:04
body:
  ###### Motivation for this change
  Orca was broken because of the `gobject-introspection` issue (56943). Adding it to the `propagatedBuildInputs` makes it runnable again. It can't connect to the d-bus but I guess that should work if you have your other braille tools set up properly.

  Also `libluois` was removed as a dependency because it had previously been broken - now it works again and we can use it as a dep here :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mousetweaks: init at 3.32.0
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60176
updated_at: 2019-04-28 19:03:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  We should have more accessibility programs.

  Runs fine but I haven't tested with Gnome so I don't know if it does the
  right thing. So I guess it's WIP.
  I'd be glad if somebody tried it on Gnome :)

  Solves #39509

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Google Cloud image breaks sudo on upgrade to 19.03
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/60177
updated_at: 2019-04-27 11:14:31
body:
  ## Issue description

  I booted the latest 18.09 image for Google, switched to my branch of nixpkgs (riding on top of `nixos-unstable`). Upon a `switch`, I became unable to elevate to root and was locked out of my instance.

  Upon rebuilding, I paid closer attention, the Google Accounts service is not dropping the sudoers configuration bits into the right /run/ directory, and so my user being in the `google-sudoers` group is appearing to have no effect.

  ```
  $ sudo ls /run/google-sudoers.d

  ```

  cc: @adisbladis 
  ref: https://github.com/NixOS/nixpkgs/pull/51566


state: closed
title: buildPython*: allow overriding strictDeps
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60178
updated_at: 2019-04-24 21:55:58
body:
  ###### Motivation for this change
  Fixes #59968 

  cc @worldofpeace @hedning @FRidh 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] torcs: fetch patch from stable source
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60179
updated_at: 2019-04-24 20:11:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of #59316 to unbreak Torcs on the release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/60180
updated_at: 2019-07-14 22:25:26
title:
  nixos/acme: nginx configuration test  fails  during nixos-rebuild switch when you have an existing virtualhost and add a new one

body:
  ## Issue description

  nginx failed to restart after I added a second virtualHost to my nginx config. 
  running `nixos-rebuild switch` a second time fixed the issue. But my website went down due to a `nixos-rebuild switch` which seems like there is a serious bug in the `enableACME` logic in the `nginx` module

  Friends of me also ran into this multiple times last week at their company


  ### Steps to reproduce

  1. Have a virtualHost with `enableACME = true`
  2. Add an extra virtualHost with `enableACME = true` and `nixos-rebuild switch`
  3. The `nginx` prestart script (`nginx -t`) fails

  This was the specific commit that failed to deploy: https://github.com/arianvp/nixos-stuff/commit/4fe0a777c1874696fd8b985f2b3f68fc01543a55

  Logs:

  ```
  Apr 24 14:27:56 arianvp.me systemd[1]: nginx.service: Current command vanished from the unit file, execution of the command list won't be resumed.
  Apr 24 14:27:56 arianvp.me systemd[1]: Stopping Nginx Web Server...
  -- Subject: Unit nginx.service has begun shutting down
  -- Defined-By: systemd
  -- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
  -- 
  -- Unit nginx.service has begun shutting down.
  Apr 24 14:27:56 arianvp.me systemd[1]: Stopped Nginx Web Server.
  -- Subject: Unit nginx.service has finished shutting down
  -- Defined-By: systemd
  -- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
  -- 
  -- Unit nginx.service has finished shutting down.
  Apr 24 14:27:56 arianvp.me systemd[1]: Starting Nginx Web Server...
  -- Subject: Unit nginx.service has begun start-up
  -- Defined-By: systemd
  -- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
  -- 
  -- Unit nginx.service has begun starting up.
  Apr 24 14:27:56 arianvp.me s0966gsjr6cilylnniqzh5l35z99jyng-unit-script-nginx-pre-start[18364]: nginx: [emerg] BIO_new_file("/var/lib/acme/techstock.photos/fullchain.pem") fai>
  Apr 24 14:27:56 arianvp.me s0966gsjr6cilylnniqzh5l35z99jyng-unit-script-nginx-pre-start[18364]: nginx: configuration file /nix/store/5g561hwc1lw3bbc29qdr83fwl5iykjnv-nginx.con>
  Apr 24 14:27:56 arianvp.me systemd[1]: nginx.service: Control process exited, code=exited status=1
  Apr 24 14:27:56 arianvp.me systemd[1]: nginx.service: Failed with result 'exit-code'.
  Apr 24 14:27:56 arianvp.me systemd[1]: Failed to start Nginx Web Server.
  -- Subject: Unit nginx.service has failed
  -- Defined-By: systemd
  -- Support: https://lists.freedesktop.org/mailman/listinfo/systemd-devel
  -- 
  -- Unit nginx.service has failed.
  -- 
  -- The result is RESULT.
  ```



  ## Technical details

  Nixos 19.03 but also happened on 18.03 to me in the past


state: closed
title: rls: 1.31.7 -> 1.34.0
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/60181
updated_at: 2019-05-18 15:58:43
body:
  ###### Motivation for this change

  Fix rls with rustc 1.34

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: grip-v0.7: indexed grip
user_login: tex
html_url: https://github.com/NixOS/nixpkgs/pull/60182
updated_at: 2019-05-10 20:42:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New CLI application for indexed grepping. Fast. Useful. Can be cross-compiled for Windows.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: testssl: 2.9.5-7 -> 3.0rc5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60183
updated_at: 2019-05-01 18:07:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  These updates aren't really in sequence as the numbers would suggest, but I decided to update and clean it up a bit to latest 2.9.5-8 and then to 3.0rc4. 
  Changelog: https://github.com/drwetter/testssl.sh/releases/tag/v2.9.5-8
  Changelog: https://github.com/drwetter/testssl.sh/releases/tag/3.0rc4

  The reasoning for this is that I'm going to backport 2.9.5-8 to stable and then have unstable upgraded to 3.0rc4.

  Upstream have stressed for a while that 3.0 is the new supported series but I think our stable can be fine on 2.9.5-8 for the rest of the lifetime.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Delete systemConfig kernel parameter?
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/60184
updated_at: 2019-06-04 16:39:52
body:
  While working on booting my Chromebook, @grahamc, @cleverca22, @samueldr, @lheckemann and me noticed that lot of scripts (for example the bit that generates GRUB `menuentry`s) set the kernel parameter `systemConfig=${config.system.build.toplevel}` but nothing appears to use it.

  We should find out what it was good for, when the last use case was removed, whether it's still desired and thus whether we should remove it everywhere. 

  Uses in nixpkgs commit 05a53ecd827c5910e34171e7681c56913b29add1:

  ```
  % git grep systemConfig
  nixos/modules/installer/cd-dvd/system-tarball-fuloong2f.nix:      init=/boot/init systemConfig=/boot/init ${toString config.boot.kernelParams}
  nixos/modules/installer/cd-dvd/system-tarball-pc.nix:      append ip=dhcp nfsroot=/home/pcroot systemConfig=${config.system.build.toplevel} init=${config.system.build.toplevel}/init rw
  nixos/modules/installer/cd-dvd/system-tarball-pc.nix:      append initrd=initrd ip=dhcp nfsroot=/home/pcroot systemConfig=${config.system.build.toplevel} init=${config.system.build.toplevel}/init rw
  nixos/modules/misc/crashdump.nix:        --command-line="systemConfig=$(readlink -f /run/current-system) init=$(readlink -f /run/current-system/init) irqpoll maxcpus=1 reset_devices ${kernelParams}"
  nixos/modules/profiles/docker-container.nix:    ln -fs $systemConfig/init /init
  nixos/modules/system/activation/activation-script.nix:            systemConfig=@out@
  nixos/modules/system/activation/activation-script.nix:            # The readlink is there to ensure that when $systemConfig = /system
  nixos/modules/system/activation/activation-script.nix:            ln -sfn "$(readlink -f "$systemConfig")" /run/current-system
  nixos/modules/system/activation/top-level.nix:      substituteInPlace $out/init --subst-var-by systemConfig $out
  nixos/modules/system/boot/loader/generic-extlinux-compatible/extlinux-conf-builder.sh:    echo "  APPEND systemConfig=$path init=$path/init $extraParams"
  nixos/modules/system/boot/loader/grub/install-grub.pl:        "systemConfig=" . Cwd::abs_path($path) . " " .
  nixos/modules/system/boot/loader/init-script/init-script-builder.sh:      echo "export systemConfig=$(readlink -f $path)"
  nixos/modules/system/boot/loader/systemd-boot/systemd-boot-builder.py:    kernel_params = "systemConfig=%s init=%s/init " % (generation_dir, generation_dir)
  nixos/modules/system/boot/stage-2-init.sh:systemConfig=@systemConfig@
  nixos/modules/system/boot/stage-2-init.sh:echo "booting system configuration $systemConfig" > /dev/kmsg
  nixos/modules/system/boot/stage-2-init.sh:$systemConfig/activate
  nixos/modules/system/boot/stage-2-init.sh:ln -sfn "$systemConfig" /run/booted-system
  nixos/modules/virtualisation/lxc.nix:    systemConfig =
  nixos/modules/virtualisation/lxc.nix:    environment.etc."lxc/lxc.conf".text = cfg.systemConfig;
  ```


state: closed
title: nextcloud: 15.0.6 -> 15.0.7
user_login: herrwiese
html_url: https://github.com/NixOS/nixpkgs/pull/60185
updated_at: 2019-05-02 20:41:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Admin panel is nagging again.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos: configurable system-wide malloc
user_login: joachifm
html_url: https://github.com/NixOS/nixpkgs/pull/60187
updated_at: 2019-05-29 19:30:44
body:
  A more general alternative to https://github.com/NixOS/nixpkgs/pull/59955 that allows choosing among a predefined set of providers.  The implementation is pretty bad but does "work".  Ideally this would be improved upon later.

  If this variant is deemed too much for the niche functionality it provides, I'm happy to go back to a more limited version under hardened. (From my pov, only the hardened allocator is really of interest).


state: closed
title: mesos: fix build by forcing protobuf 3.6
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60188
updated_at: 2019-05-11 15:51:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  mesos really seems to want protobuf 3.3, as dictated by maven. 3.4 is the closest we have, but appears to do the job.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: msmtp: 1.8.3 -> 1.8.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60189
updated_at: 2019-04-26 06:10:29
body:
  ###### Motivation for this change

  https://marlam.de/msmtp/news/msmtp-1-8-4/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mpop: 1.4.3 -> 1.4.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60190
updated_at: 2019-04-26 04:30:35
body:
  ###### Motivation for this change

  https://marlam.de/mpop/news/mpop-1-4-4/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: electron: 4.1.4 -> 4.1.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60191
updated_at: 2019-04-26 04:31:32
body:
  ###### Motivation for this change

  https://electronjs.org/releases/stable#4.1.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: electron_5: init at 5.0.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60192
updated_at: 2019-04-28 03:26:31
body:
  ###### Motivation for this change

  Copy of electron_4 expression with minor
  addition of at-spi2-core which is needed to launch.

  Not sure what apps are compatible just yet,
  so haven't tried it beyond the base screen.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gpgme: disable tests on darwin
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60193
updated_at: 2019-05-01 20:48:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  gpgme tests times out on darwin  https://hydra.nixos.org/build/92440044/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tmux: 2.8 -> 2.9
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60194
updated_at: 2019-04-26 03:50:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `tmux` to the latest release.
  https://github.com/tmux/tmux/releases/tag/2.9
  Changes: https://raw.githubusercontent.com/tmux/tmux/2.9/CHANGES

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xkcd-font: init at 2017-08-24
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60195
updated_at: 2019-04-25 20:01:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/ipython/xkcd-font/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mergerfs: fix for nixos systemd.mounts
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/pull/60196
updated_at: 2019-04-28 17:26:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  makes `mergerfs` available for use in `systemd.mounts.<foo>...` usage.
  see: https://github.com/NixOS/nixpkgs/pull/14302

  I'm using it in such a way right now, this should be relatively safe to just merge.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/gitea: Don't include not needed database options depending on type
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60197
updated_at: 2019-04-28 18:21:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This was discovered in https://github.com/NixOS/nixpkgs/pull/60014

  If this works as I expect I think we should backport #60014 to stable together with this fix, to get the security fixes over there at stable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @ajs124 @srhb 


state: closed
title: treewide: Add passthru.updateScript to gnome pkgs
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60198
updated_at: 2019-05-13 08:05:58
body:
  ###### Motivation for this change
  For packages that are hosted on the gnome mirror it's very easy.
  Inspired by https://github.com/NixOS/nixpkgs/issues/36150

  I changed some source URLs but they should be equivalent to the original.

  Changed some derivations to use `pname` instead of `name` so that causes many package rebuilds :/

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: evopedia: remove package
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/60199
updated_at: 2019-04-27 09:41:58
body:
  ###### Motivation for this change
  The last upstream update was in 2014. While the software might still work, its usefulness depends on data archives, which are not updated anymore and have not been for several years.

  Upstream suggests to use kiwix instead.

  I used to use this back in the day and ran one of the nodes for generating the archives, so I got notified about the discontinuation, by the author. When I spotted it in #33248, I thought it should probably be dropped.

  ---

  cc maintainer: @qknight


state: closed
title: neo.map: fix URL
user_login: samsonan-it
html_url: https://github.com/NixOS/nixpkgs/pull/60201
updated_at: 2019-05-10 17:14:29
body:
  ###### Motivation for this change
  Current URL is no longer available, due to the migration from svn to github.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add vim-visual-multi, fix order, update plugins
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/60202
updated_at: 2019-04-27 15:17:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/mg979/vim-visual-multi vim plugin, fix plugin ordering and update the plugins

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: futures-3.2.0 not supported for interpreter python3.7
user_login: memberbetty
html_url: https://github.com/NixOS/nixpkgs/issues/60203
updated_at: 2019-04-25 16:20:19
body:
  ## Issue description
  `nix-shell -I 'nixpkgs=./nixpkgs' --pure --show-trace` with nixpkgs containing 92f96b51d15, with:

  default.nix:
  ```
  with import <nixpkgs> {};
  stdenv.mkDerivation rec {
    name = "env";
    env = buildEnv { name = name; paths = buildInputs; };
    builder = builtins.toFile "builder.sh" ''
      source $stdenv/setup; ln -s $env $out
    '';
    buildInputs = [
      (python37.withPackages(ps: with ps;[requests jinja2 docopt google_api_python_client google-auth-httplib2 google-auth-oauthlib]))
      which
      zip
    ];
  }
  ```
  results in:
  ```
  error: while evaluating the attribute 'buildInputs' of the derivation 'env' at /foo/default.nix:3:3:
  while evaluating the attribute 'passAsFile' of the derivation 'python3-3.7.2-env' at /foo/nixpkgs/pkgs/build-support/trivial-builders.nix:7:14:
  while evaluating 'requiredPythonModules' at /foo/nixpkgs/pkgs/top-level/python-packages.nix:83:27, called from /foo/nixpkgs/pkgs/development/interpreters/python/wrapper.nix:14:13:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/pkgs/top-level/python-packages.nix:85:6:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating 'unique' at /foo/nixpkgs/lib/lists.nix:630:12, called from /foo/nixpkgs/lib/lists.nix:636:14:
  while evaluating anonymous function at /foo/nixpkgs/lib/lists.nix:139:16, called from undefined position:
  while evaluating the attribute 'outPath' at /foo/nixpkgs/lib/customisation.nix:150:7:
  while evaluating the attribute 'nativeBuildInputs' of the derivation 'python3.7-google-auth-oauthlib-0.2.0' at /foo/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:73:3:
  while evaluating 'getOutput' at /foo/nixpkgs/lib/attrsets.nix:464:23, called from undefined position:
  while evaluating 'callPackageWith' at /foo/nixpkgs/lib/customisation.nix:108:35, called from /foo/nixpkgs/pkgs/top-level/python-packages.nix:2652:13:
  while evaluating 'makeOverridable' at /foo/nixpkgs/lib/customisation.nix:67:24, called from /foo/nixpkgs/lib/customisation.nix:112:8:
  while evaluating anonymous function at /foo/nixpkgs/pkgs/development/python-modules/futures/default.nix:1:1, called from /foo/nixpkgs/lib/customisation.nix:69:12:
  while evaluating 'makeOverridablePythonPackage' at /foo/nixpkgs/pkgs/top-level/python-packages.nix:31:37, called from /foo/nixpkgs/pkgs/development/python-modules/futures/default.nix:3:1:
  while evaluating 'makeOverridable' at /foo/nixpkgs/lib/customisation.nix:67:24, called from /foo/nixpkgs/pkgs/top-level/python-packages.nix:33:12:
  while evaluating anonymous function at /foo/nixpkgs/pkgs/development/interpreters/python/build-python-package.nix:30:1, called from /foo/nixpkgs/lib/customisation.nix:69:12:
  while evaluating anonymous function at /foo/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:17:1, called from /foo/nixpkgs/pkgs/development/interpreters/python/build-python-package.nix:48:4:
  futures-3.2.0 not supported for interpreter python3.7
  ```

  The expected result is no such error. 


state: closed
title: hugo: 0.55.3 -> 0.55.4
user_login: callahad
html_url: https://github.com/NixOS/nixpkgs/pull/60205
updated_at: 2019-04-26 18:32:55
body:
  ###### Motivation for this change

  Version bump.

  - Release notes: https://gohugo.io/news/0.55.4-relnotes/
  - Commit diff: https://github.com/gohugoio/hugo/compare/v0.55.3...release-0.55.4

  ###### Things done

  Built and ran. Compiled my site. It works.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ledmon: init at 0.92
user_login: sorki
html_url: https://github.com/NixOS/nixpkgs/pull/60206
updated_at: 2019-04-26 17:48:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New package

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos-generate-config: do not build btrfs-tools when btrfs is not used
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60207
updated_at: 2019-05-22 12:32:01
body:
  cross-compilation of `btrfs-tools` is broken, and this usually needless dependency of each system closure on `btrfs-tools` prevents cross-compilation of whole system closures


state: closed
title: jetbrains-jdk: 8.202b1483.37 -> 11.0.2b164
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/60208
updated_at: 2019-04-29 21:12:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fancy Java 11 stuff. I haven't tested this exhaustively, but PHPStorm does run with this.

  cc @calbrecht 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.google-auth-oauthlib: fix python3 build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60209
updated_at: 2019-04-25 20:01:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/60203
  cc: @memberbetty 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.mutter328: backport changes from 3.32
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60210
updated_at: 2019-04-28 14:54:10
body:
  gsettings-desktop-schemas made the following change in 3.32[0]
  > Change tablets'/touchscreens' "display" setting to "output" one
  > with different semantics.

  That coincides with GNOME/mutter#133[1]

  This caused a segmentation fault in gala on Fedora[2]
  > Settings schema 'org.gnome.desktop.peripherals.touchscreen'
  > does not contain a key named 'display'

  I haven't experienced said segfault here in NixOS but I don't see
  a reason not to use the solution reached there, which was to backport
  relevant change[1] to mutter 3.28.

  [0]: https://gitlab.gnome.org/GNOME/gsettings-desktop-schemas/commit/c7eee129c6edbc1a5b121fa3327d83049325becb
  [1]: https://gitlab.gnome.org/GNOME/mutter/merge_requests/133
  [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1700337

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lorri: init at 2019-04-24
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60211
updated_at: 2019-04-25 18:17:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/target/lorri

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.gita: 0.8.2 -> 0.9.2
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/pull/60212
updated_at: 2019-05-01 17:17:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump, also overriding the pyyaml for python, since the package depends on the new version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyhamcrest is packaged as an application instead of a library
user_login: exarkun
html_url: https://github.com/NixOS/nixpkgs/issues/60213
updated_at: 2019-04-29 07:43:47
body:
  ## Issue description

  pyhamcrest is packaged using buildPythonApplication.  However, pyhamcrest is a library and not an application.

  ### Steps to reproduce

  Try to install pyhamcrest and then import it.  You cannot.

  ## Technical details

  ```
  exarkun@baryon:~/Environments/pyhamcrest]$ cat default.nix
  { pkgs ? import <nixpkgs> {} }:
  (pkgs.python27.withPackages (
    ps: [
      ps.pyhamcrest
    ]
  )).env

  [exarkun@baryon:~/Environments/pyhamcrest]$ nix-shell --command 'python -c "import hamcrest"'
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
  ImportError: No module named hamcrest

  [exarkun@baryon:~/Environments/pyhamcrest]$ 
  ```

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  [exarkun@baryon:~/Environments/pyhamcrest]$ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172231.7b36963e7a7 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: pythonPackages.pyhamcrest: switch from application to package
user_login: exarkun
html_url: https://github.com/NixOS/nixpkgs/pull/60214
updated_at: 2019-04-29 07:43:48
body:
  pyhamcrest is a testing library with no application component.

  closes https://github.com/NixOS/nixpkgs/issues/60213

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: patchShebangs: create timestamp in tmp dir
user_login: nmattia
html_url: https://github.com/NixOS/nixpkgs/pull/60215
updated_at: 2019-04-25 16:50:46
body:
  Creating the timestamp in the patched script's directory has a few
  drawbacks:

  * if "foo.timestamp" already exists, it will be overwritten
  * it requires the directory to be writable

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: service_identity: 17.0.0 -> 18.1.0
user_login: exarkun
html_url: https://github.com/NixOS/nixpkgs/pull/60216
updated_at: 2019-05-10 13:48:44
body:
  Newer version of Twisted requires newer version of service_identity for reasonable certificate subject checking.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: home-assistant: 0.91.4 -> 0.92.2
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/60217
updated_at: 2019-05-05 21:31:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://www.home-assistant.io/blog/2019/04/24/release-92/

  This was a complex update due to home-assistant/home-assistant#22699.
  The `parse-requirements.py` script needed quite some changes to account for the new `manifest.json`. But the new code turned out shorter than the old one.
  I also have completely rewritten the code that accounts for the `platform = "component"` way of configuration. The respective commit (d280603bd18cb27ce2e6bf6a0f8a163d8568214f) should be backported. This will make it rather useless to use `autoExtraComponents` with a pre-0.92 version of Home Assistant. Is this something that should be possible?

  Due to the extensive changes, I invite everyone to test thoroughly. Please bear in mind that you will need to apply d280603bd18cb27ce2e6bf6a0f8a163d8568214f to your nixpkgs checkout if you build your system from one of the release channels.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @netixx 


state: open
title: Fix letsencrypt
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/pull/60219
updated_at: 2019-07-14 22:43:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes https://github.com/NixOS/nixpkgs/issues/60180

  Futhermore refactors the module a bit. I'm trying to get rid of `PermissionStartOnly`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: home-manager: 2018-11-04 -> 2019-04-23
user_login: mtrsk
html_url: https://github.com/NixOS/nixpkgs/pull/60221
updated_at: 2019-04-26 02:19:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change
  Updating `home-manager` to a `2019-04-23` release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oraclejdk8: 8u201 -> 8u211
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60222
updated_at: 2019-04-27 10:53:01
body:
  version update

  ```oraclejdk8psu``` should be upgraded as well (8u202 -> 8u212), but currently there is no way to download.
  https://github.com/NixOS/nixpkgs/pull/59947 fixed only ```oraclejdk8``` but no ```oraclejdk8psu```. New urls for ```oraclejdk8psu``` should be discovered or it should be reworked to use manual download with ```requireFile``` as it was.


state: closed
title: nixos/window-managers/i3: write config file to `/etc/i3/config`
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/60223
updated_at: 2019-04-27 19:57:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The default config of i3 provides a key binding to reload, so changes
  take effect immediately:

  ```
  bindsym $mod+Shift+c reload
  ```

  Unfortunately the current module uses the store path of the `configFile`
  option. So when I change the config in NixOS, a store path will be
  created, but the current i3 process will continue to use the old one,
  hence a restart of i3 is required currently.

  This change links the config to `/etc/i3/config` and alters the X
  startup script accordingly so after each rebuild, the config can be
  reloaded.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openjdk11: Update source hashes for aarch64
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60224
updated_at: 2019-04-28 01:58:02
body:
  ###### Motivation for this change
  Seems like they replaced the release file.
  See: https://github.com/NixOS/nixpkgs/pull/59179#issuecomment-486742706
  and: https://hydra.nixos.org/eval/1516026?filter=jdk&compare=1516009&full=

  I haven't tested it as I don't have an aarch64 build machine and we don't have anything to bootstrap the cross compilation.
  But I updated with `pkgs/development/compilers/adoptopenjdk-bin/generate-sources.py` so it should be reasonably safe.

  Question: Why does the `jre` on `aarch64` default to `adoptopenjdk` while the `jdk` defaults to Oracle? See: https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L7459

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pwsafe: 1.06 -> 1.07
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60225
updated_at: 2019-04-25 19:23:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.cysignals: 1.9.0 -> 1.10.2
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/60226
updated_at: 2019-04-25 20:35:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: swi-prolog: updated version + packs support
user_login: barakber
html_url: https://github.com/NixOS/nixpkgs/pull/60227
updated_at: 2019-04-28 20:49:33
body:
  Using "extraPacks" and "extraLibraries" arguments
  it is possible to create fully functional virtual-envs
  for SWI-Prolog projects.
  (In a way similar to what "ghcWithPackages" does for Haskell)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.pysnooper: init at 0.1.0
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/pull/60228
updated_at: 2019-07-20 11:26:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  pysnooper is a python logging library, providing quick logging via decorator

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Awesome Window Manager appends same options to command line upon restarts
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/issues/60229
updated_at: 2019-05-07 06:07:37
body:
  ## Issue description
  On NixOS 19.03

  When running the Awesome Window Manager, if it's restarted within the same X session (e.g. by sending a `SIGHUP` or with the default shortcut `Ctrl+Mod4+R`), the same `--search` options are added to the command line.

  Example of relevant NixOS configuration:

  ```nix
  services.xserver = {
        enable = true;

        displayManager = {
        sddm.enable = true;
       };

        desktopManager = {
              default = "none";
              xterm.enable = true;
       };

        windowManager.awesome.enable = true;
  };
  ```

  ### Steps to reproduce

  1. Login using `sddm` into an X session that uses the `awesome+none`
  2. Open a terminal and run `ps aux | grep awesome | grep --color lgi`
  3. Observe that `lgi` is highlighted twice in line with https://github.com/NixOS/nixpkgs/blob/1746dc22e6db8fdf840717ea7800bacfc2f3f199/pkgs/applications/window-managers/awesome/default.nix#L51 https://github.com/NixOS/nixpkgs/blob/1746dc22e6db8fdf840717ea7800bacfc2f3f199/pkgs/applications/window-managers/awesome/default.nix#L52
  4. Restart awesome, e.g. by pressing `Ctrl+Mod4+R`
  5. Run `ps aux | grep awesome | grep --color lgi`
  6. Observe that the number of times that `lgi` is highlighted has doubled, i.e. the `--search` options have been appended to the previous command.

  Note that `windowManager.awesome.luaModules` is not affected, i.e. the `--search` options for those modules is not re-appended on restarts:

  https://github.com/NixOS/nixpkgs/blob/b3d9da5f0a3d2e967ce9a6f7b349150964a14493/nixos/modules/services/x11/window-managers/awesome.nix#L58


  ## Technical details
  NixOS
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36-hardened, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600"`
   - channels(user): `"unstable-19.09pre176329.d2602779281"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


  awesome 4.3 (Too long)
   - Compiled against Lua 5.2.4 (running with Lua 5.2)
   - D-Bus support: ✔
   - execinfo support: ✔
   - xcb-randr version: 1.6
   - LGI version: 0.9.2


state: closed
title: [Discussion] gzip and brotli for webapps
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/issues/60230
updated_at: 2019-06-02 14:38:38
body:
  ## Issue description

  nginx supports serving static [gzip](https://nginx.org/en/docs/http/ngx_http_gzip_static_module.html) and [brotli](https://github.com/google/ngx_brotli#brotli_static) files.
  Essentially, when opening a file, it looks for the corresponding `.gz` or `.br` file and serves this instead.
  This means the file can be served compressed without the overhead of on-the-fly compression.

  Currently, these files don't exist in our webapp packages. Generating them for every package would probably introduce a high load to Hydra, so compressing them by default might be a bad idea.
  So having a `compressBrotli` and `compressGzip` option per package (default: `false`) could solve this problem. Administratrators could override the corresponding packages if they's like to (building webapps locally should not be too expensive).
  Of course, this only makes sense for static assets (.css, .js, .xml, .json).

  So what do you think about this? Is it worth it? Do you see problems with this approach?


state: closed
title: nixos/tinc: remove ordering dependency on network.target
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/60231
updated_at: 2019-06-09 08:26:19
body:
  This allows configuring IP addresses on a tinc interface using
  networking.interfaces."tinc.${n}".ipv[46].addresses.

  Previously, this would fail with timeouts, because of the dependency
  chain
  ```
  tinc.${netname}.service
  --after--> network.target
  --after--> network-addresses-tinc.${n}.service (and network-link-…)
  --after--> sys-subsystem-net-devices-tinc.${n}.device
  ```
  But the network interface doesn't exist until tinc creates it! So
  systemd waits in vain for the interface to appear, and by then the
  network-addresses-* and network-link-* units have failed. This leads
  to the network link not being brought up and the network addresses not
  being assigned, which in turn stops tinc from actually working.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @volth frequent contributor to tinc module


state: closed
title: NixOS 19.03: Awesome Window Manager exposes lgi incorrectly in its LUA_PATH (regression)
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/issues/60232
updated_at: 2019-05-07 20:21:14
body:
  Cc @psychon and @blueyed who might have some insights in regard

  ## Issue description

  Since NixOS 19.03 the environment in the Awesome Window Manager exposes lgi incorrectly in its LUA_PATH (I think).

  The problem was solved in NixOS 18.09 in https://github.com/NixOS/nixpkgs/commit/5465d6f7ded73a815b4ed3953f6d00d0aa563ac3 but the the code was added again in NixOS 19.03 in https://github.com/NixOS/nixpkgs/commit/17d3eb2c9af719eac3668e7b88d65eca93750b41.

  It seems to me that the correct way of adding lgi to `LUA_PATH` (if at all needed) would be something like:

  ```nix
  --prefix LUA_PATH ';'  "${lgi}/share/lua/${lua.luaversion}/?/init.lua;${lgi}/share/lua/${lua.luaversion}/?.lua"
  ```

  This is because lgi's modules are supposed to be imported using the lgi "namespace", e.g.

  ```lua
  lgi_enum = require('lgi.enum')  -- OK
  lgi_enum = require('enum')      -- NOT OK
  ```

  A negative side effect is that there may be name clashes with other lua modules.

  I have come across this because I use a widget that has a transitive dependency on a module named `enum.lua`, and unfortunately lgi has a file with the same name that appears in the `LUA_PATH` before it, causing an error when I start Awesome. At the moment I have a rather drastic workaround where I rewrite `package.path` in my `~/.config/awesome/rc.lua` so that the correct library can be found.

  ### Steps to reproduce

  1. Configure NixOS 19.03 with awesome and extra lua modules that have a name conflict with lgi's modules

  ```nix
   services.xserver = {
     windowManager = {
        awesome = {
          enable = true;
          luaModules = with pkgs.extraLuaPackages; [ # need overalys for this to work!
            dbus_proxy
            enum
            power_widget
            upower_dbus
          ];
        };
      };
  };

    nixpkgs.overlays = with builtins; [
      (
        import (fetchGit {
          url = "https://github.com/stefano-m/nix-stefano-m-nix-overlays.git";
          rev = "9e489c50134b58fb9c4d14142c474ff792856146";
        })
      )
    ];
  ```

  2. Configure `~/.config/awesome/rc.lua` to use the modules

  ```lua
  local power = require("power_widget")
  ```

  3. Start awesome by logging in with your display manager (I use `sddm`)
  4. Observe that Awesome fails to start with  `attempt to call field 'new' (a nil value)`. In this case this is because `power_widget` transitively calls https://github.com/stefano-m/lua-upower_dbus/blob/8ef01571d13c3dd17e87e6ccec9aaccea22dd710/src/upower_dbus/init.lua#L74 `upower.enums.DeviceType = enum.new("DeviceType", DeviceType)` but lgi's `enum` module is found instead.

  ## Technical details
  NixOS 19.03
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36-hardened, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600"`
   - channels(stefano): `"unstable-19.09pre176329.d2602779281"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  awesome 4.3 (Too long)
  - Compiled against Lua 5.2.4 (running with Lua 5.2)
  - D-Bus support: ✔
  - execinfo support: ✔
  - xcb-randr version: 1.6
  - LGI version: 0.9.2


state: closed
title: oauth2_proxy: 20180325 -> 3.2.0
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/60233
updated_at: 2019-04-30 18:16:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  after bitly repo was frozen pusher is now the official hard fork
  https://github.com/bitly/oauth2_proxy/issues/628

  the module will need more testing to see if anything is broken

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dex-oidc: 2.4.1 -> 2.16.0
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/60234
updated_at: 2019-05-07 13:22:31
body:
  repo organisation changed from coreos to dexidp

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cryptsetup: create /run/cryptsetup
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/60235
updated_at: 2019-04-28 17:49:33
body:
  Needed since 2.0.0
  Changed to /run/cryptsetup from /run/lock/cryptsetup in 2.0.1

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Seeing the warning on boot was getting annoying.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pydf: init at 12
user_login: monsieurp
html_url: https://github.com/NixOS/nixpkgs/pull/60236
updated_at: 2019-04-26 07:30:59
body:
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.HTTPDaemon: 6.04 -> 6.01
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60238
updated_at: 2019-04-27 02:21:21
body:
  This undoes https://github.com/NixOS/nixpkgs/commit/6fb0e7a4e0fab0dd2f90a3c6eae8daf0ab40518d
  The only problem with 6.04 is: it got new dependencies which fail to cross-compile.
  Failure to cross-compile HTTP::Daemon leads to failure of LWP and XML::Parser, which are used in switch-to-configuration.pl
  Thus upgrade HTTPDaemon from 6.01 to 6.04 broke cross-compilation of whole system closures.


state: closed
title: [19.03] pytest-dependency fails to build
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/60239
updated_at: 2019-05-03 19:37:46
body:
  ## Issue description

  This expression fails to build on 19.03:

  https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pytest-dependency/default.nix

  The problem is that its checkPhase is not correct as the `pytest` command cannot be found. I believe that `pytest` should be in the `checkInputs` for it to succeed.

  ### Steps to reproduce

  Run the below inside `nix repl`

  ```
  pkgs = import (fetchTarball https://github.com/NixOS/nixpkgs-channels/archive/cf3e277dd0bd710af0df667e9364f4bd80c72713.tar.gz) {}
  :b pkgs.python3Packages.pytest-dependency
  ```

  The error is:

  ```
  nix-repl> :b pkgs.python3Packages.pytest-dependency 
  builder for '/nix/store/jcxfjkd3vazv36jmd2728xp9zr1kvqzs-python3.7-pytest-dependency-0.4.0.drv' failed with exit code 127; last 10 log lines:
    Successfully installed pytest-dependency-0.4.0
    /build/pytest-dependency-0.4.0
    post-installation fixup
    shrinking RPATHs of ELF executables and libraries in /nix/store/35gx0xf8f9j1jiwmmy7ly2hx3gvxzjkq-python3.7-pytest-dependency-0.4.0
    strip is /nix/store/0y7jmqnj48ikjh37n3dl9kqw9hnn68nq-binutils-2.31.1/bin/strip
    stripping (with command strip and flags -S) in /nix/store/35gx0xf8f9j1jiwmmy7ly2hx3gvxzjkq-python3.7-pytest-dependency-0.4.0/lib 
    patching script interpreter paths in /nix/store/35gx0xf8f9j1jiwmmy7ly2hx3gvxzjkq-python3.7-pytest-dependency-0.4.0
    checking for references to /build/ in /nix/store/35gx0xf8f9j1jiwmmy7ly2hx3gvxzjkq-python3.7-pytest-dependency-0.4.0...
    running install tests
    /nix/store/63karsgdg7fm3q0if4zfd7apbd8ac1ci-stdenv-linux/setup: line 1311: pytest: command not found
  [0 built (1 failed), 8 copied (8.9 MiB), 1.6 MiB DL]
  error: build of '/nix/store/jcxfjkd3vazv36jmd2728xp9zr1kvqzs-python3.7-pytest-dependency-0.4.0.drv' failed
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.31, Formbay ML 2 A, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```


state: closed
title: haskell: Introduce markUnbroken
user_login: bgamari
html_url: https://github.com/NixOS/nixpkgs/pull/60240
updated_at: 2019-07-16 17:11:29
body:
  ###### Motivation for this change

  Mark it easier to mark packages thought to be broken due only to version bounds as unbroken. See #59409.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sd: init at 0.5.0
user_login: Amar1729
html_url: https://github.com/NixOS/nixpkgs/pull/60241
updated_at: 2019-04-27 06:36:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Note on the relevant documentation -
  `sd` doesn't seem to build `man` pages yet


state: open
title: FSharp is out of date
user_login: brettgilio
html_url: https://github.com/NixOS/nixpkgs/issues/60242
updated_at: 2019-04-27 19:58:35
body:
  ## Issue description

  FSharp has two outputs, one for 4.0.0 and one for 4.1

  I do not know enough about Nix at the present to try and make a new output for the most recent 4.5. If somebody is free, could this be done?

  Thanks.

  ## Technical details

  brettg@guixsd ~/Repos/fst [env]$ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
    /nix/store/n8ryapl9c33h9w7ffrk7s592ah38a7cj-nix-info
  copying path '/nix/store/n8ryapl9c33h9w7ffrk7s592ah38a7cj-nix-info' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36-gnu`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(brettg): `"nixpkgs-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/home/brettg/.nix-defexpr/channels/nixpkgs`


state: closed
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/60243
updated_at: 2019-05-02 02:42:27
title:
  [19.03] buildPythonPackage/buildPythonApplication no longer provides pip nor other CLI executables in buildInputs or propagatedBuildInputs

body:
  Since upgrading to using 19.03, nix-shells that previously worked no longer did.

  I discovered that first pip was missing. And to bring pip back you need to explicitly put it in `nativeBuildInputs`. Furthermore to get any CLI executables out like the executables in `csvkit`, you also have to put that into `nativeBuildInputs` or `propagatedNativeBuildInputs`.

  Packages that provide executables to be used cannot just be put into `propagatedBuildInputs` as they could be before, they now have to be also in `nativeBuildInputs` as well. If they are python packages, and you want to use their CLI executables and libraries, where are you meant to put them? The manual does not explain this. https://nixos.org/nixpkgs/manual/#building-packages-and-applications

  Also why was this change made? Normal stdenv.mkDerivation still ensures that CLI executables are usable when they are inside the `buildInputs`.


state: closed
title: kfind: was not mentioned in all-packages.nix
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60244
updated_at: 2019-04-26 06:01:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  kfind was all there - just not mentioned in ```all-packages.nix```.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/modules/virtualization: Options to add an extra disk in virtualbox VM
user_login: dfordivam
html_url: https://github.com/NixOS/nixpkgs/pull/60246
updated_at: 2019-06-03 07:09:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The current VirtualBox VM creation has a limitation/bug due to which we cannot have more than 64gb storage. This is a workaround for that, and can also be useful in other cases.
  Ref: https://github.com/NixOS/nixpkgs/issues/59867

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rng-tools: fix missing opensc reference
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60247
updated_at: 2019-04-30 09:44:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  PKCS11 support wasn't actually working due to a missing library reference.

  Cc: @JohnAZoidberg 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] python3.pkgs.joblib fails to build due to test failure
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/60248
updated_at: 2019-04-29 02:27:19
body:
  Joblib when attempting to build on 19.03 `import (fetchTarball https://github.com/NixOS/nixpkgs-channels/archive/cf3e277dd0bd710af0df667e9364f4bd80c72713.tar.gz) {}` fails:

  ```
  =================================== FAILURES ===================================
  ________________________________ test_disk_used ________________________________

  tmpdir = local('/build/pytest-of-nixbld/pytest-0/test_disk_used0')

      def test_disk_used(tmpdir):
          cachedir = tmpdir.strpath
          # Not write a file that is 1M big in this directory, and check the
          # size. The reason we use such a big file is that it makes us robust
          # to errors due to block allocation.
          a = array.array('i')
          sizeof_i = a.itemsize
          target_size = 1024
          n = int(target_size * 1024 / sizeof_i)
          a = array.array('i', n * (1,))
          with open(os.path.join(cachedir, 'test'), 'wb') as output:
              a.tofile(output)
  >       assert disk_used(cachedir) >= target_size
  E       AssertionError: assert 1 >= 1024
  E        +  where 1 = disk_used('/build/pytest-of-nixbld/pytest-0/test_disk_used0')

  joblib/test/test_disk.py:32: AssertionError
  ============= 1 failed, 1031 passed, 79 skipped in 124.63 seconds ==============
  [INFO:MainProcess:MainThread] process shutting down
  [DEBUG:MainProcess:MainThread] running all "atexit" finalizers with priority >= 0
  [DEBUG:MainProcess:MainThread] Interpreter shutting down. Waking up queue_manager_threads [(<Thread(QueueManagerThread, started daemon 140737211524864)>, <joblib.externals.loky.process_executor._ThreadWakeup object at 0x7ffff4c28048>)]
  [DEBUG:MainProcess:QueueManagerThread] queue management thread shutting down
  [DEBUG:MainProcess:QueueManagerThread] closing call_queue
  [DEBUG:MainProcess:QueueManagerThread] telling queue thread to quit
  [DEBUG:MainProcess:QueueManagerThread] joining processes
  [DEBUG:MainProcess:QueueFeederThread] feeder thread got sentinel -- exiting
  [DEBUG:MainProcess:QueueManagerThread] queue management thread clean shutdown of worker processes: []
  [DEBUG:MainProcess:MainThread] running the remaining "atexit" finalizers
  builder for '/nix/store/sk913x41632c4413r87qpcddz9fgw43i-python3.6-joblib-0.13.2.drv' failed with exit code 1
  ```

  I saw this error before here: 
  https://github.com/NixOS/nixpkgs/issues/54875#issuecomment-458787619


state: closed
title: bind: 9.12.3-P4 -> 9.12.4-P1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60249
updated_at: 2019-04-26 08:20:38
body:
  ###### Motivation for this change

  https://www.openwall.com/lists/oss-security/2019/04/25/1

  CVE-2018-5743, CVE-2019-6467, and CVE-2019-6468

  * **backport**
  * **security**

  We may want to move to 9.14.1 since 9.12 EOL was May apparently,
  but since patches didn't apply and it's late I'll leave that
  for another time or someone else :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Let's make sure this builds on aarch (or at least doesn't newly fail)
  since the linked thread (see commit) has someone mentioning an issue.


state: closed
title: icu: 59 -> 64
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60250
updated_at: 2019-07-12 05:01:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/unicode-org/icu/releases/tag/release-64-2

  They say updates can go smoothly so let's try! (http://userguide.icu-project.org/icufaq)

  We should probably get rid of the old versions that are not needed anymore if everything builds after this. It doesn't look like they have any LTS versions - they're just releasing new versions.

  Obsoletes or resolves: #39388 and #52632

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.jinja2: 2.10 -> 2.10.1
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/60251
updated_at: 2019-04-26 11:46:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  fixes CVE-2019-10906
  https://palletsprojects.com/blog/jinja-2-10-1-released/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: you-get: 0.4.1270 -> 0.4.1295
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60252
updated_at: 2019-04-26 14:17:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `you-get` to the latest release.
  https://you-get.org/
  https://pypi.org/project/you-get/0.4.1295/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pulseeffects lacks icons
user_login: peti
html_url: https://github.com/NixOS/nixpkgs/issues/60253
updated_at: 2019-04-28 15:13:36
body:
  I've just run a recent version of `pulseeffects` from Nixpkgs `master` and although the tool works fine, I can't help but notice that all icons are missing, i.e. every button is replaced by some standard "missing" icon. Is that to be expected?


state: open
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60254
updated_at: 2019-05-04 19:36:41
title:
  gdk-pixbuf: Use a different GDK_PIXBUF_MODULE_FILE environment variable on 32-bit and 64-bit systems.

body:
  Pull request #42562 caused a regression that running a 32-bit program that uses
  gdk-pixbuf would result in a crash because it would try to load a 64-bit
  library and fail. This change fixes this issue by patching gdk-pixbuf and many
  places where this variable is defined to use different variable names on
  32-bit and 64-bit systems.

  ###### Motivation for this change

  Fix regression running 32-bit programs.

  This only intends to fix the 32-bit program issue. The situation is still a mess. The way I understand the situation is:

  - Desktops want to set `GDK_PIXBUF_MODULE_FILE` such that all GTK apps will be able to load SVG icons. I presume this is because the desktop comes with SVG icons and the apps should be able to use the desktop-provided icons to integrate visually.
  - Some apps need to specifically support SVG icons, probably because they ship with them. Those set `GDK_PIXBUF_MODULE_FILE` in the wrapper (the value comes from the gdk-pixbuf setup hook). In these cases the wrapper sets the variable to point to the cache file in librsvg.
  - Some apps set `GDK_PIXBUF_MODULE_FILE` in the wrapper without depending on librsvg, which results in the wraper setting the variable to the cache file from gdk-pixbuf. This wrapping might be to ensure the app works even if `GDK_PIXBUF_MODULE_FILE` is set incorrectly (e.g. when NixOS is updated, if running outside NixOS) (if it is not set gdk-pixbuf will use its default cache file). Note that these apps will never support SVG icons even if the desktop sets the variable, because the wrapper overrides it! That's why I added a librsvg dependency to some apps, but I didn't check this for the many apps that get wrapped indirectly via `wrapGAppsHook`.

  My suggestion going forward would be to try to ensure that (almost?) all GTK apps are wrapped to set `GDK_PIXBUF_MODULE_FILE` to the one from librsvg (yes, it results in a larger closure in some cases), and then remove the code in desktops to set the environment variable together with the gdk-pixbuf NixOS module.

  ###### Things done

  I have testes this on 19.03 branch and it seems to work as intended. I have checked that the correct variable is set by the gdk_pixbuf NixOS module and that the apps which set it in the wrapper set the correct variable. I have observed no breakage on my desktop system (KDE-based). I have tried running a 32-bit application (pavucontrol) and it does start and run (though there are errors loading 64-bit GVFS plugins).

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos: Get rid of systemConfig kernel parameter
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/pull/60256
updated_at: 2019-04-26 10:36:12
body:
  It was introduced in c10fe14 but removed in c4f910f.

  It remained such that people with older generations in their boot
  entries could still boot those. Given that the parameter hasn't had any
  use in quite some years, it seems safe to remove now.

  Fixes https://github.com/NixOS/nixpkgs/issues/60184

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: socat: fix darwin build
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/60257
updated_at: 2019-05-01 16:36:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Make it build on Darwin. I'll try to upstream it too.

  ```
  xio-termios.c:359:5: error: conflicting types for 'xiotermios_speed'
  int xiotermios_speed(int fd, int n, speed_t speed) {
      ^
  ./xio-termios.h:151:12: note: previous declaration is here
  extern int xiotermios_speed(int fd, int n, unsigned int speed);
             ^
  1 error generated.
  make: *** [<builtin>: xio-termios.o] Error 1
  ```

  https://hydra.nixos.org/build/92405399/nixlog/3/tail

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: acme.sh: use iproute on linux and netstat elsewhere
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/60258
updated_at: 2019-05-01 16:36:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Make acme.sh usable on Darwin. Tested with #60257 to get socat.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: docbook_xsl: path URL is no longer valid
user_login: samsonan-it
html_url: https://github.com/NixOS/nixpkgs/issues/60259
updated_at: 2019-05-05 16:37:07
body:
  ## Issue description

  docbook_xsl patch URL at
  pkgs/data/sgml+xml/stylesheets/xslt/docbook-xsl/default.nix
  is no longer valid:
  The requested URL https://src.fedoraproject.org/cgit/rpms/docbook-style-xsl.git/plain/docbook-style-xsl-non-recursive-string-subst.patch?id=bf9e5d16fd was not found on server.

  Alternative locations are, for example:
  https://src.fedoraproject.org/rpms/docbook-style-xsl/raw/master/f/docbook-style-xsl-non-recursive-string-subst.patch
  or
  https://gitweb.gentoo.org/repo/gentoo.git/plain/app-text/docbook-xsl-stylesheets/files/nonrecursive-string-subst.patch
  But they have differnet hashes and have to be double checked.


state: open
title: General problems with environment variable wrappers
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/issues/60260
updated_at: 2019-06-15 18:37:04
body:
  The use of wrapper scripts to set or change environment variables before running the real executable has become very widespread in nixpkgs. While they are important for making programs run out-of-the-box, wrappers have some general problems. Some of these could be fixed but some are perhaps unfixable. I'm writing this to generate some discussion to see if we could solve some of these issues or come up with an alternative solution.

  1. Environment variables are propagated to child processes. I believe this is the most problematic thing. The intent of the wrapper is to make the wrapped program run correctly, and the fact that child processes see the adjustment is unintended leakage of information/configuration. Any child process started by the wrapped program that also needs environment changes will generally have its own wrapper. This leakage could cause another application to run incorrectly or  differently than if it was started "cleanly".

  2. Wrappers which add to list-type variables (typically colon-separated) will add the value unconditionally without checking if it is already in the list.

  To observe (1) and (2) in action, open Konsole and run `echo "$XDG_DATA_DIRS"`. Then type `konsole` in the same terminal and run the echo in the new terminal. You will see that the variable contains two entries for `<konsole-store-path>/share`. You can keep repeating this to get `XDG_DATA_DIRS` that grows without bounds.

  3. Wrappers obscure the process name. Just look at a process list and find many `.something-wrapped` processes.

  4. People forget to make wrappers and/or don't know which variables need to be set. For example, probably most GTK apps need to have `GDK_PIXBUF_MODULE_FILE` set to point to some file in the `librsvg` package. It is far from obvious to a random person packaging an app that this is necessary (see #60254 and #42562).

  5. Wrappers break software that opens the executable and expects it to be an ELF binary. I have encountered this with Wine but I have not yet filed an issue (it results in very suble but widespread breakage). But this is uncommon.


state: open
title: ckb-next: 0.3.2 -> 0.4.0
user_login: kierdavis
html_url: https://github.com/NixOS/nixpkgs/pull/60262
updated_at: 2019-05-09 22:12:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Requested by a user.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) - *increase by 0.053%*
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: ckb-next service: apply udev rules provided by package
user_login: kierdavis
html_url: https://github.com/NixOS/nixpkgs/pull/60263
updated_at: 2019-05-09 22:06:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The package provides these udev rules with the presumption that OS maintainers will install and use them.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) - *increase by 0.21%*
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: minecraft-server: 1.13.2 -> 1.14
user_login: angristan
html_url: https://github.com/NixOS/nixpkgs/pull/60264
updated_at: 2019-05-13 12:18:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add latest version of minecraft-server.

  ###### Things done

  Added `minecraft-server_1_14`.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update home manager 2019 04 23
user_login: mtrsk
html_url: https://github.com/NixOS/nixpkgs/pull/60265
updated_at: 2019-04-28 04:12:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Sorry for the [double commit](https://github.com/NixOS/nixpkgs/pull/60221), I've seen the previous ones (just updating versions) and missed out that the [install script also changed](https://github.com/rycee/home-manager/blob/2c07829be2bcae55e04997b19719ff902a44016d/home-manager/default.nix), some new deps were also needed for it to work.

  ###### Things done

  Added `gnused` and `findutils` as arguments, modified the install script.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Jetbrains updates
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/pull/60267
updated_at: 2019-04-29 08:59:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update via script. Tested (only) idea together with #60208.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lorri: reserve attribute name
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/60268
updated_at: 2019-06-27 15:37:35
body:
  lorri is a nix-shell replacement for project development.
  Since it’s public beta announcement was noticed by many people, they
  are going to assume it is available from nixpkgs. We lead them to the
  installation instructions while the tool is not yet ready for nixpkgs.

  Related-issue: https://github.com/NixOS/nixpkgs/pull/60211

  - [x] tested warning thrown when the user tries to build lorri.


state: closed
title: matterbridge service does not allow package to be overriden
user_login: sbourdeauducq
html_url: https://github.com/NixOS/nixpkgs/issues/60269
updated_at: 2019-05-02 08:37:38
body:
  Usually, services allow overriding the package they use. The Matterbridge service lacks this feature, which would be quite useful to allow user patching of the Matterbridge source.

  Tentative patch (not tested):
  ```patch
  diff --git a/nixos/modules/services/networking/matterbridge.nix b/nixos/modules/services/networking/matterbridge.nix
  index 1fd63348c16..d1389bb89b2 100644
  --- a/nixos/modules/services/networking/matterbridge.nix
  +++ b/nixos/modules/services/networking/matterbridge.nix
  @@ -19,6 +19,13 @@ in
       services.matterbridge = {
         enable = mkEnableOption "Matterbridge chat platform bridge";
   
  +      package = mkOption {
  +        type = types.path;
  +        default = pkgs.matterbridge;
  +        defaultText = "pkgs.matterbridge";
  +        description = "The Matterbridge package.";
  +      };
  +
         configPath = mkOption {
           type = with types; nullOr str;
           default = null;
  @@ -109,7 +116,7 @@ in
         serviceConfig = {
           User = cfg.user;
           Group = cfg.group;
  -        ExecStart = "${pkgs.matterbridge.bin}/bin/matterbridge -conf ${matterbridgeConfToml}";
  +        ExecStart = "${cfg.package.bin}/bin/matterbridge -conf ${matterbridgeConfToml}";
           Restart = "always";
           RestartSec = "10";
         };

  ```

  Cc @ryantm 


state: closed
title: docbook-xsl: 1.79.1 → 1.79.2
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60270
updated_at: 2019-04-30 20:03:57
body:
  ###### Motivation for this change
  Nothing much changed other than adding the suffix `-nons` to Docbook 4 styles, making the Docbook 5 the variant without suffix:

  https://github.com/docbook/xslt10-stylesheets/releases/tag/release%2F1.79.2

  **I have decided to make `docbook_xsl` an alias of `docbook-xsl-nons` for now, to avoid confusion.**

  Will move the `aliases.nix` in later iteration.

  I also updated patch link that was broken to a newer version of the patch
  and started sharing it between the two packages.

  Closes: https://github.com/NixOS/nixpkgs/issues/60259

  ###### Things done

  I diffed the directory trees with 1.79.1, the only non-trivial change seems to be the merging of the schema files.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Enhance the Agda builder
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/issues/60271
updated_at: 2019-05-31 16:59:13
body:
  For my sins, I'm trying to integrate some Agda code into the testing part of a production system. I'd like to use the Agda builder from Nixpkgs, but it could do with a few enhancements. I thought I'd open an issue discussing those so I can see whether other people agree before I try to actually implement anything.

  Things I would like:
  - Support for library files.
      - The current builder passes all dependencies using `-i`, we could probably use `AGDA_DIR` or `--library-file` now for many libraries.
      - Would need to think of how to handle fallback for libraries that don't use library files yet.
  - `agdaWithPackages`
      - Obviously we'd want to preserve the existing ability for emacs to pick things up, but I think might be easier with `AGDA_DIR` now.
  - Easier configuration of build flags.
      - It's a bit annoying to try and override `buildFlags` at the moment.
  - Some simple enable/disable options for generating html/latex literate Agda output, and for producing compiled outputs via one of the backends.

  Mentioning some people who seem to be involved: @Fuuzetsu @siddharthist 


state: closed
title: GeoGebra: 472 -> 535
user_login: BenBals
html_url: https://github.com/NixOS/nixpkgs/pull/60272
updated_at: 2019-04-29 09:25:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  The main motivation for this update is that the old version is not available from GeoGebra-Servers anymore.


state: closed
title: R: 3.5.3 -> 3.6.0
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/pull/60273
updated_at: 2019-04-29 11:40:49
body:
  The patch is necessary for the test suite to pass without errors. The
  fix has already been made upstream but didn't make it into the 3.6.0
  release.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  upstream release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome-software: Failed to activate service 'org.freedesktop.PackageKit': timed out
user_login: angristan
html_url: https://github.com/NixOS/nixpkgs/issues/60274
updated_at: 2019-04-30 18:49:37
body:
  ## Issue description

  Opening gnome-softwares shows this:

  <img width="1440" alt="Screenshot 2019-04-26 at 18 12 56" src="https://user-images.githubusercontent.com/11699655/56822005-1a559700-6850-11e9-9cb1-c528a81fa5ae.png">

  And the whole app is empty.

  Journald logs:

  ```
  Apr 26 18:18:35 nixos dbus-daemon[778]: [system] Failed to activate service 'org.freedesktop.PackageKit': timed out (service_start_timeout=25000ms)
  Apr 26 18:18:35 nixos .gnome-software[1533]: not GsPlugin error g-dbus-error-quark:20: Error calling StartServiceByName for org.freedesktop.PackageKit: GDBus.Error:org.freedesktop.DBus.Error.TimedOut: Failed to activate service 'org.freedesktop.PackageKit': timed out (service_start_timeout=25000ms)
  ```

  ### Steps to reproduce

  Use GNOME (3.32.1) on unstable.

  My GNOME-related config:

  ```nix
    services.xserver.desktopManager.gnome3.enable = true;
    services.xserver.displayManager.gdm.enable = true;
    services.xserver.displayManager.gdm.wayland = false;
    environment.gnome3.excludePackages = with pkgs.gnome3; [
      epiphany
      evolution
      gnome-maps
      accerciser
    ];
    services.gnome3.gnome-keyring.enable = true;
    services.gnome3.chrome-gnome-shell.enable = true;
    services.gnome3.gvfs.enable = true;
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.9, NixOS, 19.09pre177249.dfd8f84aef1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre177249.dfd8f84aef1"`
   - channels(stanislas): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: python3Packages.spacy: fix build
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/60276
updated_at: 2019-05-02 16:51:21
body:
  spaCy 2.0.18 requires an older version of wheel. Remove upper bound.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: liblinear: 2.21 -> 2.30
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/60277
updated_at: 2019-05-02 16:51:10
body:
  This release adds parameter search for l2-regularized l2-loss SVR.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/issues/60278
updated_at: 2019-04-28 21:46:17
title:
  propagatedUserEnv could be extended to better specify how to integrate the package into the environment

body:
  ## Issue description

  Currently, `propagatedUserEnv` is used in many desktop-related packages, to ensure that the system or user environment has packages that are needed at runtime. In most cases the application locates such dependencies by searching in profile directories (often assisted by environment variables such as `XDG_DATA_DIRS` and `PATH`).

  However, whether the correct files are linked into the environment depends on how the environment is generated, especially on the `pathsToLink` used in `buildEnv`. This is currently not addressed well. For example, `system-path.nix` (which builds `/run/current-system/sw`) hardcodes a bunch of default entries for `pathsToLink`, and the Plasma NixOS module just adds `/share` to `pathsToLink` (which affects the entire system environment, not just Plasma things). One can grep the NixOS modules to see all cases where modules set `environment.pathsToLink` to ensure that some part of some packages is linked in.

  `nix-env` and other user environment managers also lack precise information about which paths need to be linked in. It seems to me that `nix-env` uses `pathsToLink=["/"]` but I am not 100% sure. Which ironically sometimes results in an app running fine when installed with `nix-env` but not in the system environment (because some needed paths were not linked).

  ## Proposal

  First, I don't like how `propagatedUserEnv` is implemented through shell scripts and `nix-support/propagated-user-env-packages`. Using `passthru` would be more elegant and would make it simpler to support including more detailed information about environment dependencies. So if we make improvements in this area, it should be a new system that uses `passthru`.

  It should be possible for a package to specify, via `passthru`, that it requires **specific paths from specific packages** to be linked in the environment. The `buildEnv` implementation would look at these specifications and ensure that the requested paths are linked. Paths not requested would not be linked if not required, e.g. a package requested in this way could end up with only `/share` linked and not `/bin` even if it has something in `/bin`.

  It could look like this in a package definition:
  ```nix
  passthru = {
      environmentDependencies = [
          { package = some_package; pathsToLink = [ "/share" ]; }
          { package = another_package; pathsToLink = [ "/bin" ]; }
      ];
  };
  ```

  From the perspective of `buildEnv`, these specifications are not recursive. In particular, `buildEnv` only considers the `environmentDependencies` of packages that are requested to be in the environment at the top level. Automatic propagation of `environmentDependencies` of a library to applications depending on it could be implemented via `mkDerivation` and additional `passthru` attributes (without `buildEnv` having to deal with this).

  The general idea of a package specifying how to integrate it into the environment could be extended to other kinds of specifications, like which environment variables need to be set (if perhaps the environment would someday be responsible for generating executable wrappers).


state: closed
title: editline: fix crash with term narrower than completions
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60279
updated_at: 2019-05-21 22:27:22
body:
  ###### Motivation for this change

  Fixes issue mentioned on #nixos earlier today by @edef1c.

  Repro instructions:

  * Open a terminal and resize it to very narrow (~20 should work,
  haven't calculated the breaking point)
  * Run `nix repl`
  * Type `:b ` and hit TAB for completions
  * Sadface

  Compare this with and without this change :).

  Submitted upstream, FWIW: https://github.com/troglobit/editline/pull/24

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pytest-dependency: fix build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60280
updated_at: 2019-05-23 04:10:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/60239
  cc: @CMCDragonkai 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: peco: fix incorrect termbox-go rev in deps.nix
user_login: samdoshi
html_url: https://github.com/NixOS/nixpkgs/pull/60281
updated_at: 2019-05-01 10:33:32
body:
  Peco 0.5.3 included an update to the `termbox-go` dependency to fix a bug, this change did not make it into `deps.nix`.

  See:

   - peco/peco#446
   - peco/peco#447
   - nsf/termbox-go#185


  ###### Motivation for this change

  Peco 0.5.3 is currently broken for me on 19.03 due to garbled text, see the linked issues above for an example.

  Also see the [`glide.lock`](https://github.com/peco/peco/blob/814932819adaed444cdfd32747de7047329f573f/glide.lock) for Peco 0.5.3 to see the mismatch.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: browserpass: Remove v2 and switch to buildGoModule
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60282
updated_at: 2019-04-28 19:18:49
body:
  ###### Motivation for this change
  See #58639


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: manim
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/60284
updated_at: 2019-04-28 06:21:46
body:
  # Manim - Mathematical Animation Engine

  Manim is an animation engine for explanatory math videos. It's used to create precise animations programmatically, as seen in the videos at [3Blue1Brown](https://www.3blue1brown.com/).

  Upstream repository: https://github.com/3b1b/manim

  This is a state-of-the-art mathematics animation utility installed with Python.


state: open
title: fcitx-configtool: Point exec_prefix to installed location of fcitx-remote
user_login: telotortium
html_url: https://github.com/NixOS/nixpkgs/pull/60285
updated_at: 2019-05-19 08:43:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes errors like this printed to the console when changing settings using `fcitx-config-gtk3`:

  ```
  (fcitx-config-gtk3:17980): GLib-WARNING **: 12:24:47.394: GError set over the top of a previous GError or uninitialized memory.
  This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
  The overwriting error message was: Failed to execute child process “/nix/store/02i4q909l3jk6080zb57jmd23ra4244x-fcitx-configtool-0.4.10/bin/fcitx-remote” (No such file or directory)
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: polkit: 0.115 -> 0.116
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60286
updated_at: 2019-04-27 05:15:15
body:
  ###### Motivation for this change

  * now uses mozjs60
  * drop CVE patches included in release

  * pname-ify
  * use flag arrays and placeholder

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: iosevka-bin: 2.2.0 -> 2.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60287
updated_at: 2019-04-27 05:32:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/be5invis/Iosevka/releases/tag/v2.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Minor bump.


state: closed
title: dhcpcd: 7.2.0 -> 7.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60288
updated_at: 2019-04-27 05:52:24
body:
  ###### Motivation for this change

  Includes security fixes!

  https://roy.marples.name/blog/dhcpcd-7-2-1-released

  Sending to staging, since that's where 7.2.0 is--
  but we may want to promote this directly
  or into staging-next?.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [Experiment] Separate security wrappers from NixOS
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60289
updated_at: 2019-04-30 22:31:31
body:
  ###### Motivation for this change
  Recently I had to use a nix-shell that installs setuid wrappers for some package-specific dependencies. Because the security wrapper logic was so deeply embedded in NixOS, I had to use NixOS to make the nix-shell work.

  This change allows you to set up security wrappers in your nix-shells with the same functionality as in NixOS. E.g. this should work:

  ```nix
  pkgs.stdenv.mkDerivation {
    # ...
    shellHook = ''
      sudo ${pkgs.security-wrappers {
          wrapperDir = toString ./wrappers/bin;
          wrappers = {
            fusermount.source = "${pkgs.fuse}/bin/fusermount";
          };
      }}/bin/setup
      export PATH="${toString ./wrappers/bin}:$PATH"
    '';
  }
  ```

  Or this is how you could build it directly:
  ```
  nix-build '<nixpkgs>' -A security-wrapper --arg wrappers '{ fusermount.source = "${(import <nixpkgs> {}).fuse}/bin/fusermount"; }' --arg wrapperDir "toString $PWD/wrappers/bin"
  ```

  Only very minimal tests were done, but it seems to work just fine. If anybody needs it, here you go.

  I also made minor changes like quoting all bash variables and removing some legacy code that didn't do anything (`WRAPPER_PATH`).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kexec-tools: use depsBuildBuild to get the right compiler
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/60291
updated_at: 2019-04-27 12:14:15
body:
  Need this to avoid this issue in pkgsStatic:

    ld: cannot find -lc

  /cc @ericson2314 @nh2

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openjdk8: Try to remove host kernel version impurity
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/60292
updated_at: 2019-04-27 12:39:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The openjdk build appears to check something *like* `uname` to determine the kernel version. This options disables that check, because it's broken *at least* on linux 5.x. I am frankly not sure whether this is the correct solution, but surely such a version check is an impurity regardless. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: accountsservice: 0.6.54 -> 0.6.55
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60293
updated_at: 2019-04-28 00:55:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://cgit.freedesktop.org/accountsservice/tag/?h=0.6.55

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xlayoutdisplay: 1.0.2 -> 1.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60294
updated_at: 2019-04-28 07:38:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/alex-courtis/xlayoutdisplay/releases/tag/v1.1.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnustep.libobjc: 1.8.1 -> 1.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60295
updated_at: 2019-04-27 22:14:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/gnustep/libobjc2/releases/tag/v1.9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: libobjc: 1.8.1 -> 1.9 -> 2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60296
updated_at: 2019-04-27 22:07:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Builds on #60295, moving to 2.0!

  I'm not sure if we want to stick with 1.x or not, hence the two PR's.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.ezdxf: 0.8.8 -> 0.9, fix build
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60297
updated_at: 2019-04-27 05:47:00
body:
  ...though this only "fixes" the py2.7 build by bumping to a version that has deprecated py2 support, and therefore disabled it, but it had to happen eventually...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sqlite: 3.27.2 -> 3.28.0 / patches for gnupatch and libxslt
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60298
updated_at: 2019-04-27 05:00:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updates and fixes as part of roundup 66 :
  Closes #60105 for `gnupatch`
  Closes #60109 for `sqlite`
  Closes #60115 for `libxslt`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Running latest TextAdept gives "seg fault".
user_login: JonathanILevi
html_url: https://github.com/NixOS/nixpkgs/issues/60299
updated_at: 2019-05-29 17:27:45
body:
  ## Issue description
  When running the textadept in `nixos-unstable` or `nixos-19.03` the only output is "Segmentation fault".  With `nixos-18.9` it works but is an old version.


  ### Steps to reproduce
  Install textadept from either unstable or 19.3 and execute it with `textadept` in a terminal.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.113, HixOS, 18.09.2532.571b40d3f50 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix 2.1.3)`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: gorun: Init at git-2018-04-08
user_login: Gonzih
html_url: https://github.com/NixOS/nixpkgs/pull/60300
updated_at: 2019-05-25 01:31:46
body:
  ###### Motivation for this change
  Added `gorun` tool that allows use go files in shebang fashion.
  This PR represents package definition ported from my own configuration in to mainstream repository.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind update (9.12.4-P1) build failure on aarch64
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/issues/60301
updated_at: 2019-04-27 21:39:11
body:
  The CVE fix in #60249, allegedly, is causing issues with aarch64 builds.

   * https://seclists.org/oss-sec/2019/q2/64

  This is holding back iso and sd_image for aarch64, thus holding back channel updates for unstable. Once backported (I feel it should be, being a CVE fix) this'll hold 19.03 back too.

  Not sure where to go from here, though I'm not sure the previously linked e-mail is a good report enough for upstream.

  [The failure on ofborg](https://logs.nix.ci/?key=nixos/nixpkgs.60249&attempt_id=7c23b89c-44ed-4727-a0bf-5fcf87b44efc) and [the check page](https://github.com/NixOS/nixpkgs/pull/60249/checks?check_run_id=111594598).

  Here's the failure from the hydra log:

  ```
  libtool: link: gcc -I/build/bind-9.12.4-P1 -I../.. -I./include -I./unix/include -I. -I/build/bind-9.12.4-P1/lib/ns/include -I../../lib/ns/include -I/build/bind-9.12.4-P1/lib/dns/include -I../../lib/dns/include -I/build/bind-9.12.4-P1/lib/bind9/include -I../../lib/bind9/include -I/build/bind-9.12.4-P1/lib/isccfg/include -I../../lib/isccfg/include -I/build/bind-9.12.4-P1/lib/isccc/include -I../../lib/isccc/include -I/build/bind-9.12.4-P1/lib/isc/include -I../../lib/isc -I../../lib/isc/include -I../../lib/isc/unix/include -I../../lib/isc/pthreads/include -I../../lib/isc/noatomic/include -I/nix/store/z3d9c33wjsd51v39qgqpqx55j9avg9a8-openssl-1.0.2r-dev/include -D_REENTRANT -DOPENSSL -DDIG_SIGCHASE=1 -D_GNU_SOURCE -g -O2 -I/nix/store/k9asakbdl56ggq9lipfxsfxhgr9hfs8d-libxml2-2.9.9-dev/include/libxml2 -W -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith -fno-strict-aliasing -fno-delete-null-pointer-checks -o .libs/named .libs/builtin.o .libs/config.o .libs/control.o .libs/controlconf.o .libs/fuzz.o .libs/log.o .libs/logconf.o .libs/main.o .libs/server.o .libs/statschannel.o .libs/tkeyconf.o .libs/tsigconf.o .libs/zoneconf.o unix/.libs/os.o unix/.libs/dlz_dlopen_driver.o  ../../lib/ns/.libs/libns.so -L/nix/store/z3d9c33wjsd51v39qgqpqx55j9avg9a8-openssl-1.0.2r-dev/lib -L/nix/store/x4lfgvbnlq88ynk0dzv1kxyg43s3dnqy-libxml2-2.9.9/lib ../../lib/dns/.libs/libdns.so ../../lib/bind9/.libs/libbind9.so /build/bind-9.12.4-P1/lib/isccfg/.libs/libisccfg.so ../../lib/isccfg/.libs/libisccfg.so /build/bind-9.12.4-P1/lib/dns/.libs/libdns.so ../../lib/isccc/.libs/libisccc.so /build/bind-9.12.4-P1/lib/isc/.libs/libisc.so ../../lib/isc/.libs/libisc.so -lcrypto -lcap -lpthread /nix/store/x4lfgvbnlq88ynk0dzv1kxyg43s3dnqy-libxml2-2.9.9/lib/libxml2.so -lz -lm -ldl -Wl,-rpath -Wl,/nix/store/7alp97b2r0bg940vxjj3zrlx284nz2nw-bind-9.12.4-P1-lib/lib -Wl,-rpath -Wl,/nix/store/x4lfgvbnlq88ynk0dzv1kxyg43s3dnqy-libxml2-2.9.9/lib
  /nix/store/kbz28l7mjcj1s1fpmn1k8n4dhn90lp5r-binutils-2.31.1/bin/ld: ../../lib/ns/.libs/libns.so: undefined reference to `isc_atomic_xadd'
  collect2: error: ld returned 1 exit status
  make[2]: *** [Makefile:539: named] Error 1
  make[2]: Leaving directory '/build/bind-9.12.4-P1/bin/named'
  make[1]: *** [Makefile:79: subdirs] Error 1
  make[1]: Leaving directory '/build/bind-9.12.4-P1/bin'
  make: *** [Makefile:88: subdirs] Error 1
  builder for '/nix/store/jc246n4ky0s4ni2sckm7fhqrrqnr9w9b-bind-9.12.4-P1.drv' failed with exit code 2
  ```

  ---

  cc @dtzWill 


state: open
title: glulxe: init at 0.5.4
user_login: kisonecat
html_url: https://github.com/NixOS/nixpkgs/pull/60302
updated_at: 2019-04-29 06:14:31
body:
  ###### Motivation for this change

  glulxe is available in guix but not in nixpkgs

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pazi: init at 0.2.0
user_login: bbigras
html_url: https://github.com/NixOS/nixpkgs/pull/60303
updated_at: 2019-04-27 13:36:48
body:
  ###### Motivation for this change

  Add pazi. A supposedly fast autojump tool.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: httplz: init at 1.5.0
user_login: bbigras
html_url: https://github.com/NixOS/nixpkgs/pull/60304
updated_at: 2019-04-27 11:58:02
body:
  ###### Motivation for this change

  Note that the project's name is "http" and it provides 2 identical binaries ("http" and "httplz").

  "http" collides with the very popular httpie's "http" so I named the package "httplz" and I only build the "httplz" binary.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Default kernel in nixos-19.03 doesn't find luks volume
user_login: dmvianna
html_url: https://github.com/NixOS/nixpkgs/issues/60305
updated_at: 2019-07-18 05:59:12
body:
  ## Issue description

  After switching from channel nixos-18.09 to nixos-19.03 and issuing 
  ```bash
  sudo nixos-rebuild switch --upgrade
  ```
  udev can't find the volume where my operating system is.

  ### Steps to reproduce

  configuration.nix
  ```
    # Use the systemd-boot EFI boot loader.
    boot.loader.systemd-boot.enable = true;
    boot.loader.efi.canTouchEfiVariables = true;
    
    # decrypt LUKS partition
    boot.initrd.luks.devices = [
      {
        name = "root";
        device = "/dev/nvme0n1p2";
        preLVM = true;
      }
    ];

    boot.extraModulePackages = [
      config.boot.kernelPackages.broadcom_sta
    ];
    boot.initrd.kernelModules = [
      "wl"
    ];
  ```
  command
  ```bash
  sudo nixos-rebuild switch --upgrade
  ```
  Note that the problem was solved by pinning the kernel to an older version
  ```nix
    # Pin kernel
    boot.kernelPackages = pkgs.linuxPackages_4_14;
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```bash
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.113, NixOS, 19.03.172361.cf3e277dd0b (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(dmvianna): `""`
   - channels(root): `"nixos-19.03.172361.cf3e277dd0b, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  The kernel that doesn't boot is Linux kernel 4.19.36. On 18.09 I was using Linux kernel 4.14.105.


state: closed
title: Unable to reset password from Spotify app
user_login: scalavision
html_url: https://github.com/NixOS/nixpkgs/issues/60306
updated_at: 2019-05-29 08:17:34
body:
  ## Issue description

  When pressing reset password button, nothing happens. When running Spotify from command line, these errors occurs:

  ```bash
  /nix/store/9iyjbk83bi8fn4ydf9v2hjasgy33nv3m-curl-7.64.0/lib/libcurl-gnutls.so.4: no version information available (required by /proc/self/exe)
  [0427/071846.984588:ERROR:sandbox_linux.cc(379)] InitializeSandbox() called with multiple threads in process gpu-process
  ```
  People can always reset their password through the web site, so I guess this issue is not too severe though ..

  ### Steps to reproduce

  Open the Spotify app, without being already logged in

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev
  copying path '/nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.110, NixOS, 18.09.2474.222950952f1 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2474.222950952f1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: cedille: 1.0.0 -> 1.1.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60307
updated_at: 2019-04-29 19:02:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/cedille/cedille/blob/master/CHANGELOG.md#cedille-11

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: documize-community: 2.2.1 -> 2.4.1
user_login: elseym
html_url: https://github.com/NixOS/nixpkgs/pull/60308
updated_at: 2019-04-28 09:03:01
body:
  ###### Motivation for this change

  bump to recently released version 2.4.1

  /cc @Ma27 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: documize-module: refactor and add more options
user_login: elseym
html_url: https://github.com/NixOS/nixpkgs/pull/60309
updated_at: 2019-04-28 09:02:35
body:
  ###### Motivation for this change
  adds all available [command line switches](https://github.com/documize/community/blob/v2.4.1/core/env/flags.go#L79-L87) and [some more documentation](https://docs.documize.com/s/VzO9ZqMOCgABGyfW/installation-guides/d/VzSL8cVZ4QAB2B4Y/environment-variables-and-command-lines-switches)

  /cc @Ma27 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wol: fix manpage generation
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60310
updated_at: 2019-04-29 07:41:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  perl was missing which is needed to generate the man page.

  Cc: @makefu 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kwalletcli: fix pinentry-kwallet
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60311
updated_at: 2019-04-29 07:41:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The standard builder doesn't fix up ```mksh``` scripts, so we have to do this manually in for ```pinentry-kwallet``` to actually work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kwin_x11 crashes when switching virtual desktop
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/60312
updated_at: 2019-06-24 02:27:23
body:
  ## Issue description

  On current nixos-unstable, KDE isn't working properly. Many animations seem to be somewhat broken, but most importantly, kwin_x11 crashes when switching from one virtual desktop to another if "Show on-screen display when switching" is enabled.

  This is what I can see in journalctl logs between two consecutive crashes:

  ```
  Apr 26 11:38:11 leevi xsession[2802]: KCrash: Application 'kwin_x11' crashing...
  Apr 26 11:38:11 leevi xsession[2802]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 178, resource id: 56623111, major code: 20 (GetProperty), minor code: 0
  Apr 26 11:38:11 leevi xsession[2802]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 179, resource id: 56623111, major code: 20 (GetProperty), minor code: 0
  Apr 26 11:38:11 leevi X[2653]: (II) modeset(0): EDID vendor "LGD", prod id 803
  Apr 26 11:38:11 leevi X[2653]: (II) modeset(0): Printing DDC gathered Modelines:
  Apr 26 11:38:11 leevi X[2653]: (II) modeset(0): Modeline "1920x1080"x0.0  138.00  1920 1952 1988 2088  1080 1085 1090 1102 -hsync -vsync (66.1 kHz eP)
  Apr 26 11:38:11 leevi xsession[2802]: qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 1242, resource id: 56623127, major code: 3 (GetWindowAttributes), minor code: 0
  Apr 26 11:38:11 leevi xsession[2802]: qt.qpa.xcb: QXcbConnection: XCB error: 9 (BadDrawable), sequence: 1243, resource id: 56623127, major code: 14 (GetGeometry), minor code: 0
  Apr 26 11:38:12 leevi xsession[2802]: Application::crashHandler() called with signal 11; recent crashes: 2
  Apr 26 11:38:13 leevi xsession[2802]: KCrash: Application 'kwin_x11' crashing...
  ```

  I don't know if this is an upstream or NixOS issue. I'm trying to find the breaking commit but it takes a lot of time because nix apparently needs to build quite a lot of stuff although I've tried to make as minimal system as possible.

  ### Steps to reproduce

  - Use, for instance, nixpkgs commit 2fed7f2a72bec221e738e61549e7a736292844ff.
  - Use KDE as your desktop manager.
  - System settings -> Desktop behaviour -> Virtual desktops -> Enable "Show on-screen display when switching".

  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.09.git.0df8ae8 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: closed
title: gpg build fails on mac os x
user_login: ssnnoo
html_url: https://github.com/NixOS/nixpkgs/issues/60313
updated_at: 2019-06-07 21:42:01
body:
  ## Issue description

  build of gpgme-1.13.0 fails on macosx


  .
  .
  .
  ```
  echo x > ./gpg-sample.stamp
  GNUPGHOME=/private/var/folders/md/87dsz37906dfbk6j6jkp_gg00000gn/T/nix-build-gpgme-1.13.0.drv-0/gpgme-1.13.0/tests/gpg LC_ALL=C GPG_AGENT_INFO= top_srcdir=../.. gpg --batch --no-permission-warning \
                 --import ./pubdemo.asc
  gpg: keybox '/private/var/folders/md/87dsz37906dfbk6j6jkp_gg00000gn/T/nix-build-gpgme-1.13.0.drv-0/gpgme-1.13.0/tests/gpg/pubring.kbx' created
  gpg: /private/var/folders/md/87dsz37906dfbk6j6jkp_gg00000gn/T/nix-build-gpgme-1.13.0.drv-0/gpgme-1.13.0/tests/gpg/trustdb.gpg: trustdb created
  gpg: key 2D727CC768697734: public key "Alfa Test (demo key) <alfa@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key FE180B1DA9E3B0B2: public key "Bob (demo key)" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 413F4AF31AFDAB6C: public key "Charlie Test (demo key) <charlie@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key EBA9F240EB9DC9E6: public key "Delta Test (demo key) <delta@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 318C1FAEFAEF6D1B: public key "Echelon (demo key)" imported
  gpg: can't connect to the agent: File name too long
  gpg: key D4BF57F37372E243: public key "Foxtrot Test (demo key) <foxtrot@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 168410A48FC282E6: public key "Golf Test (demo key) <golf@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 13DB965534C6E3F1: public key "Hotel Test (demo key) <hotel@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 1FE8FC6F04259677: public key "India Test (demo key) <india@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 0C820C71D2699313: public key "Juliet Test (demo key) <juliet@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key AD1B0FAD43C2D0C7: public key "Kilo Test (demo key) <kilo@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 37CAB51FB79103F8: public key "Lima Test (demo key) <lima@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key BE794852BE5CF886: public key "Mallory (demo key)" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 25B00FD430CEC684: public key "November Test (demo key) <november@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 5F6356BA6D9732AC: public key "Oscar Test (demo key) <oscar@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 5D15E01D3FF13206: public key "Papa test (demo key) <papa@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 1C67EC133C661C84: public key "Quebec Test (demo key) <quebec@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 3BDBEDB1777FBED3: public key "Romeo Test (demo key) <romeo@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key A5E67F7FA3AE3EA1: public key "Sierra Test (demo key) <sierra@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 58CB9A4C85A81F38: public key "Tango Test (demo key) <tango@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key A94C0F75653244D6: public key "Uniform Test (demo key) <uniform@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 47AF4B6961F04784: public key "Victor Test (demo key) <victor@example.org>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key DEF0F7B8EC67DBDE: public key "Whisky Test (demo key) <whisky@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 8979A6C5567FB34A: public key "XRay Test (demo key) <xray@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 9EEF34CD4B11B25F: public key "Yankee Test (demo key) <yankee@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: key 6BC4778054ACD246: public key "Zulu Test (demo key) <zulu@example.net>" imported
  gpg: can't connect to the agent: File name too long
  gpg: Total number processed: 26
  gpg:               imported: 26
  make[2]: *** [Makefile:1123: pubring-stamp] Error 2
  make[2]: Leaving directory '/private/var/folders/md/87dsz37906dfbk6j6jkp_gg00000gn/T/nix-build-gpgme-1.13.0.drv-0/gpgme-1.13.0/tests/gpg'
  make[1]: *** [Makefile:720: all-recursive] Error 1
  make[1]: Leaving directory '/private/var/folders/md/87dsz37906dfbk6j6jkp_gg00000gn/T/nix-build-gpgme-1.13.0.drv-0/gpgme-1.13.0/tests'
  make: *** [Makefile:534: all-recursive] Error 1
  builder for '/nix/store/mfhjkmflnhmajqwkbsf5f2prq6dwqzaf-gpgme-1.13.0.drv' failed with exit code 2
  error: build of '/nix/store/mfhjkmflnhmajqwkbsf5f2prq6dwqzaf-gpgme-1.13.0.drv' failed
  ```

  ### Steps to reproduce

  nix-env -i gpgme

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```shell
  nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (1.46 MiB download, 7.87 MiB unpacked):
    /nix/store/171bpg1afkf7viip3hp7h6z0qqcfx5wc-bash-interactive-4.4-p23-info
    /nix/store/2lg8zwayyvp9jmxgsv0pvg1rawk7xz34-bash-interactive-4.4-p23-dev
    /nix/store/5l3a9dl7fcgc0pj7xhsr5zviwlbc8bms-DarwinTools-1
    /nix/store/m1rhwwjbsw6z6w2k0fz0cg7jkhfd4nay-nix-info
    /nix/store/nz4nis3iyybzfcba7slbn50fgjbb23qx-bash-interactive-4.4-p23-doc
    /nix/store/p9swdwn1g807hwga8l5krdvyysdsdh91-readline-7.0p5
    /nix/store/r5f6lzwsi2jvq0015xk5c118iw2m2ipc-bash-interactive-4.4-p23-man
    /nix/store/rx77x01pv20r616z39m74wyjnym74gpr-bash-interactive-4.4-p23
  copying path '/nix/store/nz4nis3iyybzfcba7slbn50fgjbb23qx-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
  copying path '/nix/store/5l3a9dl7fcgc0pj7xhsr5zviwlbc8bms-DarwinTools-1' from 'https://cache.nixos.org'...
  copying path '/nix/store/171bpg1afkf7viip3hp7h6z0qqcfx5wc-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
  copying path '/nix/store/r5f6lzwsi2jvq0015xk5c118iw2m2ipc-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
  copying path '/nix/store/m1rhwwjbsw6z6w2k0fz0cg7jkhfd4nay-nix-info' from 'https://cache.nixos.org'...
  copying path '/nix/store/p9swdwn1g807hwga8l5krdvyysdsdh91-readline-7.0p5' from 'https://cache.nixos.org'...
  copying path '/nix/store/rx77x01pv20r616z39m74wyjnym74gpr-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
  copying path '/nix/store/2lg8zwayyvp9jmxgsv0pvg1rawk7xz34-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(sim): `"nixpkgs-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/Users/xxx/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: oraclejdk8cpu: 8u201 -> 8u211, oracledjdk8psu: 8u202 -> 8u212
user_login: livnev
html_url: https://github.com/NixOS/nixpkgs/pull/60314
updated_at: 2019-04-28 05:23:20
body:
  ###### Motivation for this change

  Version update (the old versions are no longer available for download). This also updates the PSU versions as requested in #60222. Thanks to the fix in #59947 all of the downloads work correctly, without manual prefetch (though to discover the hashes and token I needed to log in with an oracle account 😬 )

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: mkvtoolnix: 33.0.0 -> 33.1.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60315
updated_at: 2019-04-30 03:20:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `mkvtoolnix` to the latest release.
  https://gitlab.com/mbunkus/mkvtoolnix/blob/release-33.1.0/NEWS.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 1password: Update SHA256
user_login: kevingriffin
html_url: https://github.com/NixOS/nixpkgs/pull/60316
updated_at: 2019-04-29 02:35:46
body:
  ###### Motivation for this change
  AgileBits, the distributor of 1Password, recently started reporting a different SHA256 for their Darwin and 386 Linux builds. Their support person reports the following:

  > Yes we did indeed rebuild the CLI release as part of upgrades to our release infrastructure. The sig file shipped with the binaries is always re-generated along with those binaries, so validating that signature is the best way to ensure the builds are valid and safe.
  > 
  > Please let me know if you have any further questions!

  This would imply all three builds references in the nix package would see their signatures changed, but I could only find different signatures for the i686-linux and x86_64darwin builds.

  Edit: I received the changed signature for amd64, so I've updated my commit to include all three new signatures.

  My contact is Connor Hicks at support@1password.com 

  If further action is required to verify these signatures, I'd like to hear about it. It seems odd to me to resign the same version.

  A list of builds can be found at https://app-updates.agilebits.com/product_history/CLI

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 1Password doesn't build due to hash mismatch
user_login: kevingriffin
html_url: https://github.com/NixOS/nixpkgs/issues/60317
updated_at: 2019-04-29 05:57:02
body:
  ## Issue description
  1Password 0.5.5 (the latest version as of issue creation) doesn't install on Darwin due to a hash mismatch.

  Addressed in https://github.com/NixOS/nixpkgs/pull/60316

  ### Steps to reproduce

  `nix-env -iA nixpkgs._1password` on Darwin.

  ## Technical details
  ```nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixpkgs-19.09pre175347.02bb5e35eae"`
   - channels(kevin): `"darwin, nixpkgs-unstable-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/Users/kevin/.nix-defexpr/channels/nixpkgs````


state: closed
title: mate.{marco,mate-session-manager,mate-system-monitor}: 1.22.0 -> 1.22.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/60318
updated_at: 2019-04-28 03:41:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: sway: Read the configuration from /etc before /nix/store
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/60319
updated_at: 2019-04-27 20:38:19
body:
  This change will load all configuration files from /etc, to make it easy
  to override them, but fallback to /nix/store/.../etc/sway/config to make
  Sway work out-of-the-box with the default configuration on non NixOS
  systems.

  Notes: I'm using `mkOptionDefault` instead of `mkDefault` so that setting `environment.etc."sway/config".text = "...";` works as well (see `nixos/modules/system/etc/etc.nix`, which implements `text` via `source` and also uses `mkDefault`).

  See https://github.com/NixOS/nixpkgs/commit/578fe3f5a02f855c5d1ad14e2440b9359a750c40#r33300320 for the motivation of this change.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gallery-dl: init at 1.8.2
user_login: dawidsowa
html_url: https://github.com/NixOS/nixpkgs/pull/60322
updated_at: 2019-05-07 17:45:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add  https://github.com/mikf/gallery-dl

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.asana: 0.7.1 -> 0.8.2, disable for py3.7
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60323
updated_at: 2019-05-06 17:03:00
body:
  ###### Motivation for this change
  Bump and "fix" python 3.7 package by disabling it for 3.7 (upstream reportedly doesn't support 3.7 yet, blocked on https://bugs.python.org/issue34226)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/pazi: init
user_login: bbigras
html_url: https://github.com/NixOS/nixpkgs/pull/60324
updated_at: 2019-05-14 00:52:18
body:
  ###### Motivation for this change

  Shell integration.

  @teto

  ###### Things done

  I'm still running `nixos-build` but the module seems pretty simple. I'll update after testing.

  I manually tested that eval works for bash and zsh. And `pazi init fish | source` for fish.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/60325
updated_at: 2019-04-27 15:19:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bumps.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.fastpair: force use of pytest_3
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60326
updated_at: 2019-05-07 19:41:21
body:
  ###### Motivation for this change
  Fix build.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libsForQt5.qtkeychain: add libsecret support
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60327
updated_at: 2019-07-11 15:13:48
body:
  ###### Motivation for this change
  qtkeychain uses pkg-config to detect whether libsecret is available,
  otherwise it just builds a stub object file.

  We need libsecret support to allow nextcloud-client storing passwords
  on Freedesktop platforms.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: docker: 18.09.2 -> 18.09.5
user_login: neilmayhew
html_url: https://github.com/NixOS/nixpkgs/pull/60328
updated_at: 2019-04-27 22:03:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This version contains a number of important fixes and is the current stable release.

  Making the derivation overridable allows future Docker releases to be tested using a NixOS overlay similar to this:

  ```nix
  self: super:

  {
    docker = super.docker.override {
      version = "18.09.5";
      rev = "e8ff056dbcfadaeca12a5f508b0cec281126c01d";
      sha256 = "16nd9vg2286m6v47fjq2zicmfvi8vwiwn24yylxia8b9mk417kdb";
      runcRev = "2b18fe1d885ee5083ef9f0838fee39b62d653e30";
      runcSha256 = "0g0d9mh5fcvsjgddiyw98ph5zpz5ivlwy89m45jxwbzkxb21gy7w";
      containerdRev = "bb71b10fd8f58240ca47fbb579b9d1028eea7c84";
      containerdSha256 = "0npbzixf3c0jvzm159vygvkydrr8h36c9sq50yv0mdinrys2bvg0";
      tiniRev = "fec3683b971d9c3ef73f284f176672c44b448662";
      tiniSha256 = "1h20i3wwlbd8x4jr2gz68hgklh0lb0jj7y5xk1wvr8y58fip1rdn";
    };
  }
  ```


state: closed
title: awesome: refactor LUA_PATH env var and don't expose it at runtime
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/pull/60329
updated_at: 2019-05-08 19:57:03
body:
  Cc: @dtzWill

  This commit partly reinstates changes from 5465d6f that had been somehow
  reverted in 17d3eb2.  Also, a comment has been added in the hope that future
  changes won't do the same.

  Additionally, refactor the LUA_PATH env var to ensure that the internal lgi lua
  files can't be required explicitly and to avoid possible name clashes (this
  fixes issue #60232).

  Finally, rather than using prepending `?.lua` append `;;` to LUA_PATH. Quoting
  @psychon:

  > This is interpreted by Lua as "add the default search path here" (which does
  > indeed contain ?.lua, but also contains more).

  Testing done:

  - Build with `nix-build -I /path/to/repo -A awesome`
  - Start an X session with xterm only
  - Start xephyr, e.g. `Xephyr :1 -name xephyr -screen 512x384 -ac -br -noreset &`
  - Run awesome like `DISPLAY=:1.0 ./result/bin/awesome`. Additionally, add
    `--search` options to expose lua modules that have a name clash with lgi's
    internal ones (see #60232 for more details) and `require` them in `rc.lua` to
    prove that they are loaded correctly

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind: apply atomics to refcount patch
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/60330
updated_at: 2019-04-27 18:50:31
body:
  ###### Motivation for this change

  Fixing #60301 

  Upstream added a commit [1] right after the release that fixes the
  aarch64 atomic operation linker issue we have been seeing [2].

  [1] https://gitlab.isc.org/isc-projects/bind9/commit/d72f436b7d7c697b262968c48c2d7643069ab17f
  [2] https://github.com/NixOS/nixpkgs/issues/60301#issue-437896459

  cc @samueldr @grahamc 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS (aarch64 & amd64)
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wxwidgets 3.1.0 -> 3.1.2
user_login: lasandell
html_url: https://github.com/NixOS/nixpkgs/pull/60331
updated_at: 2019-04-27 18:00:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Need this dependency for another package I'm working on. :smile: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "nixos/switch-to-configuration: Never stop system.slice"
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/60332
updated_at: 2019-04-28 05:21:35
body:
  This change was only a temporary workaround and isn't required anymore,
  since /etc/systemd/system/system.slice should not be present on any
  recent NixOS system (which makes this change a no-op).

  This reverts commit 7098b0fcdfd7fa4b82c036d8116b60b78f497316.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  Tested it on my NixOS system - not extensively but the change is so trivial that it shouldn't cause any problems (apart from **very** old systems that still have `/etc/systemd/system/system.slice`).

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana_reporter: Fix library function name
user_login: azazel75
html_url: https://github.com/NixOS/nixpkgs/pull/60333
updated_at: 2019-05-03 04:29:10
body:
  ###### Motivation for this change
  Fix the expression for package `grafana_reporter`, without this fix it is unusable in its current state

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos.grafana: fix docstring typo
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/60334
updated_at: 2019-07-16 17:12:43
body:
  Simple typo fix to improve the docs!



  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana_reporter: 2.0.1 -> 2.1.0
user_login: azazel75
html_url: https://github.com/NixOS/nixpkgs/pull/60335
updated_at: 2019-05-05 01:57:17
body:
  ###### Motivation for this change
  Upgrade `grafana_reporter` package from version 2.0.1 to 2.1.0.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: metals: init at 0.6.1
user_login: Tomahna
html_url: https://github.com/NixOS/nixpkgs/pull/60336
updated_at: 2019-06-29 07:40:35
body:
  ###### Things done
  Initialize metals package. Note that this package includes wrappers for vim, sublime and emacs written according to the package documentation. As I only use emacs, it's the only one properly tested.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cubicsdr: init at 0.2.5
user_login: lasandell
html_url: https://github.com/NixOS/nixpkgs/pull/60337
updated_at: 2019-04-29 10:27:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Nice GUI client for SoapySDR devices, including RTL-SDR. I'm also working on support for SDRPlay.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coursier: 1.1.0-M10 -> 1.1.0-M14.1
user_login: Tomahna
html_url: https://github.com/NixOS/nixpkgs/pull/60338
updated_at: 2019-04-27 21:49:35
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wireguard: Add peers.*.publicKeyFile as an alternative to publicKey
user_login: thoferon
html_url: https://github.com/NixOS/nixpkgs/pull/60339
updated_at: 2019-05-25 19:33:53
body:
  ###### Motivation for this change

  When dealing with several servers, we might want a mechanism by which the servers share their public key with each other *after* being provisioned. Thus, we can't give the NixOS configuration the public keys directly because they are not known at that point in time. `publicKeyFile` solves the issue.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date (couldn't find any documentation in NixOS manual)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fix lua53Packages.lua
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60340
updated_at: 2019-04-28 07:48:39
body:
  ###### Motivation for this change

  Recent reworking broke lua53Packages.*, root cause
  being that lua53Packages.lua didn't have the overrides
  needed for the build to succeed.

  Instead of overrideAttrs, just plumb the needed additions
  directly into the mkDerivation call.

  * Check lua53Packages.lua builds successfully
  * Check lua53Packages.lua and lua5_3 are same derivation

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] bind: 9.12.3-P1 -> 9.12.4-P1
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/60341
updated_at: 2019-04-28 07:16:18
body:
  ###### Motivation for this change

  Backport of #60249 & #60330 

  cc @dtzWill @samueldr 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [S] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] bind: 9.12.3-P4 -> 9.12.4-P1
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/60342
updated_at: 2019-04-27 21:31:13
body:
  ###### Motivation for this change

  Backport of #60249 & #60330

  cc @dtzWill @samueldr

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luarocks-nix,luaPackages: formatting and additions; awesome: docs!
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60343
updated_at: 2019-05-10 21:57:02
body:
  ###### Motivation for this change

  I wanted the wonderful generated docs from awesome,
  but needed some new lua modules for this to happen.

  Along the way worked on formatting generated by luarocks-nix,
  but even so ultimately did a bit of post-processing.

  Marking draft because I don't want to actually point to my fork
  but haven't sent the changes upstream
  (which may need some tweaks or whatnot to be satisfactory).

  cc @teto

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dbeaver: 6.0.2 -> 6.0.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60344
updated_at: 2019-04-28 00:37:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://dbeaver.io/2019/04/21/dbeaver-6-0-3/

  Using 6.0.2, on launch it tells you new version is available
  and fills your screen with how great it is. xD.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: meta.platforms is broken
user_login: edolstra
html_url: https://github.com/NixOS/nixpkgs/issues/60345
updated_at: 2019-06-04 15:29:49
body:
  Once upon a time, `meta.platforms` contained more-or-less sensible information:
  ```
  $ nix-env -f channel:nixos-17.09 -qaA geeqie --json | jq .[].meta.platforms
  [
    "aarch64-linux",
    "armv5tel-linux",
    "armv6l-linux",
    "armv7l-linux",
    "mips64el-linux",
    "i686-linux",
    "x86_64-linux"
  ]
  ```

  Now, however, it contains a lot of irrelevant information, and **omits the thing that matters**, namely the platform names (e.g. `x86_64-linux`):
  ```
  $ nix-env -f channel:nixos-19.03 -qaA geeqie --json | jq .[].meta.platforms
  [
    {
      "abi": {
        "_type": "abi",
        "name": "gnu"
      },
      "kernel": {
        "_type": "kernel",
        "execFormat": {
          "_type": "exec-format",
          "name": "elf"
        },
        "families": {},
        "name": "linux"
      }
    },
    {
      "abi": {
        "_type": "abi",
        "float": "soft",
        "name": "gnueabi"
      },
      "kernel": {
        "_type": "kernel",
        "execFormat": {
          "_type": "exec-format",
          "name": "elf"
        },
        "families": {},
        "name": "linux"
      }
    },
    {
      "abi": {
        "_type": "abi",
        "float": "hard",
        "name": "gnueabihf"
      },
      "kernel": {
        "_type": "kernel",
        "execFormat": {
          "_type": "exec-format",
          "name": "elf"
        },
        "families": {},
        "name": "linux"
      }
    },
    {
      "kernel": {
        "_type": "kernel",
        "execFormat": {
          "_type": "exec-format",
          "name": "elf"
        },
        "families": {},
        "name": "linux"
      }
    }
  ]
  ```

  This broke the display of supported platforms at https://nixos.org/nixos/packages.html. It also seems horribly over-engineered to me. (I mean, it's one thing to be able to map platform types to information like executable formats, but it's going rather too far to use that information to *identify* the platform.)


state: closed
title: carla: init at 2.0.0
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/60346
updated_at: 2019-05-26 12:17:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  To have more choices in audio production software. Carla seems fairly used by people using the Jack ecosystem. #11190 mentions Carla, so @Pitometsu, @joelmo and @magnetophon might be interested.

  Tested (a bit) from the release-19.03 branch because I don't have the resources of compiling QT from scratch ^^

  If someone with a more complete audio setup wants to test it, I'd be happy :D 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.basemap: 1.0.7 -> 1.2.0, fixes build on py3.7
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60347
updated_at: 2019-05-06 15:26:01
body:
  ###### Motivation for this change
  Upstream seems to have moved to github without updating its pypi packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: check-meta: use system tuple in platforms
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/60349
updated_at: 2019-06-04 15:29:50
body:
  Fixes #60345

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virtualbox source and extension pack download site down
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/issues/60350
updated_at: 2019-04-30 00:37:57
body:
  ## Issue description

  The virtualbox download site is apparently down:

  https://forums.virtualbox.org/viewtopic.php?f=1&t=92880

  As a workaround, you can use an `http` URL instead of `https`.  For instance, to download the extension pack from 19.03, normally you'd use the following URL:

  ```console
  $ nix-prefetch-url https://download.virtualbox.org/virtualbox/5.2.26/Oracle_VM_VirtualBox_Extension_Pack-5.2.26.vbox-extpack
  ```

  Instead, you can use the following URL:

  ```console
  $ nix-prefetch-url http://download.virtualbox.org/virtualbox/5.2.26/Oracle_VM_VirtualBox_Extension_Pack-5.2.26.vbox-extpack
  ```

  ### Steps to reproduce

  Hopefully this will be fixed on Monday when people at Oracle come back to work.


state: closed
title: cockroachdb: 2.1.5 -> 2.1.6
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60351
updated_at: 2019-04-30 19:09:41
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: font-manager: "0.7.5" -> actual 0.7.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60352
updated_at: 2019-04-28 09:49:56
body:
  ###### Motivation for this change

  Move to actual tagged release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.PyChromecast: 3.2.0 -> 3.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60353
updated_at: 2019-04-28 05:30:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/balloob/pychromecast/releases/tag/3.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-expand: 0.4.11 -> 0.4.12
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60354
updated_at: 2019-04-29 02:39:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update cargo-expand to the latest release.

  https://github.com/dtolnay/cargo-expand/releases/tag/0.4.12
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zsh HISTFILE is exported when it should not be
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/issues/60355
updated_at: 2019-04-29 02:47:37
body:
  ## Issue description

  The nixpkgs zsh module https://github.com/NixOS/nixpkgs/blob/6a73992cfac4f2ab22d346c00228c3c224422865/nixos/modules/programs/zsh/zsh.nix#L192-L195 wants `HISTFILE` to not be exported, but `HISTFILE` is already exported at that point.

  ### Steps to reproduce

  Start a bash shell and observe zsh history get clobbered.

  or

  Run `typeset -p HISTFILE` and observe an `export HISTFILE=...`

  or

  Add `typeset -p HISTFILE || true` early to https://github.com/NixOS/nixpkgs/blob/6a73992cfac4f2ab22d346c00228c3c224422865/nixos/modules/programs/zsh/zsh.nix#L182-L183 and observe `export HISTFILE=/dev/null`.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37-hardened, NixOS, 19.09.git.2f96f26 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-18.09.1922.97e0d53d669"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: cdrtools broken on darwin
user_login: Amar1729
html_url: https://github.com/NixOS/nixpkgs/issues/60357
updated_at: 2019-07-12 15:26:09
body:
  ## Issue description
  Cdrtools ([current nixpkg](https://github.com/NixOS/nixpkgs/blob/92a047a6c4d46a222e9c323ea85882d0a7a13af8/pkgs/applications/misc/cdrtools/default.nix)) is compatible with darwin, but doesn't build here with nix yet.  

  Removing the incompatible dependencies on `acl` and `libcap` results in a failed build ([full log](https://gist.github.com/Amar1729/09e1be5a36c7ffaa0c66b0758994cff8#file-cdrtools-original-log)). Last few lines:
  ```
  creating xconfig.h
          ==> MAKING SYMLINKS in ./RULES/
          ==> MAKING SYMLINKS in ./TEMPLATES/
  sh conf/cc-config.sh cc cc incs/Dcc.i386-darwin
  Trying to find cc
  Found cc
  cc is clang
  Making clang the default compiler in 'incs/Dcc.i386-darwin'
          ==> MAKING DIRECTORY "incs/i386-darwin-clang/Inull"
          ==> CONFIGURING RULES "incs/i386-darwin-clang/rules.cnf"
  creating cache ./config.cache
  checking host system type... x86_64-apple-macosx18.5.0
  checking if sh is bash... yes
  checking if /bin/sh is bash... yes
  checking whether sh -ce is broken... no
  checking whether /bin/sh -ce is broken... no
  checking whether /bin/bosh is a working shell... no
  checking whether /opt/schily/bin/bosh is a working shell... no
  checking for cc... clang
  checking for gcc... (cached) clang
  checking whether the C compiler (clang   -O   -Llibs/i386-darwin-clang -L/usr/local/lib -framework IOKit -framework CoreFoundation) works... no
  configure: error: installation or configuration problem: C compiler cannot create executables.
  RULES/rules.cnf:71: incs/i386-darwin-clang/rules.cnf: No such file or directory
  make: *** [RULES/rules.cnf:59: incs/i386-darwin-clang/rules.cnf] Error 1
  builder for '/nix/store/2gp07d7nn4pw697y7n6rpkcpw638404s-cdrtools-3.02a06.drv' failed with exit code 2
  error: build of '/nix/store/2gp07d7nn4pw697y7n6rpkcpw638404s-cdrtools-3.02a06.drv' failed
  ```

  I've updated the package in the following ways:
  - `doBuild=false`
  - changed the installPhase to:
    - `make INS_BASE=#{out} INS_RBASE=#{out} DESTDIR=#{out} install`
  - included `darwin.IOKit`

  Last few lines of current build error:
  ```
  creating xconfig.h
          ==> MAKING "all" ON SUBDIRECTORY "SRCROOT/conf"
  make[1]: Entering directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/conf'
  make[1]: Nothing to be done for 'all'.
  make[1]: Leaving directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/conf'
          ==> MAKING "all" ON SUBDIRECTORY "SRCROOT/inc"
  make[1]: Entering directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
          ==> MAKING "all" ON SUBCOMPONENT "SRCROOT/inc/align_test.mk"
  make[2]: Entering directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
          ==> MAKING DIRECTORY "OBJ/i386-darwin-clang"
          ==> MAKING DIRECTORY "OBJ/i386-darwin-clang/man"
          ==> MAKING DEPENDENCIES "OBJ/i386-darwin-clang/align_test.d"
   ==> COMPILING "OBJ/i386-darwin-clang/align_test.o"
          ==> LINKING "OBJ/i386-darwin-clang/align_test"
  ld: warning: directory not found for option '-L../libs/i386-darwin-clang'
  ld: warning: directory not found for option '-L../libs/i386-darwin-clang'
          ==> GENERATING include file "../incs/i386-darwin-clang/align.h"
  make[2]: Leaving directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
          ==> MAKING "all" ON SUBCOMPONENT "SRCROOT/inc/avoffset.mk"
  make[2]: Entering directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
          ==> MAKING DEPENDENCIES "OBJ/i386-darwin-clang/avoffset.d"
   ==> COMPILING "OBJ/i386-darwin-clang/avoffset.o"
          ==> LINKING "OBJ/i386-darwin-clang/avoffset"
  ld: warning: directory not found for option '-L../libs/i386-darwin-clang'
  ld: warning: directory not found for option '-L../libs/i386-darwin-clang'
          ==> GENERATING include file "../incs/i386-darwin-clang/avoffset.h"
  /nix/store/jizc4dhwkp8kffbprbl3n9np8ipw6fz8-bash-4.4-p23/bin/bash: line 2: 58797 Segmentation fault: 11  OBJ/i386-darwin-clang/avoffset > ../incs/i386-darwin-clang/avoffset.h
  /nix/store/jizc4dhwkp8kffbprbl3n9np8ipw6fz8-bash-4.4-p23/bin/bash: line 2: 58801 Segmentation fault: 11  OBJ/i386-darwin-clang/avoffset > ../incs/i386-darwin-clang/avoffset.h
  make[2]: *** [../RULES/rules.inc:50: ../incs/i386-darwin-clang/avoffset.h] Error 139
  make[2]: Leaving directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
  make[1]: *** [../RULES/rules.mks:23: all] Error 2
  make[1]: Leaving directory '/private/var/folders/zk/t4rzq9t166x94d10mr4r1zl5yb8l3y/T/nix-build-cdrtools-3.02a06.drv-5/cdrtools-3.02/inc'
  make: *** [RULES/rules1.dir:25: all] Error 2
  builder for '/nix/store/6ib4cmkpr3wz0gil8xmw6alvay4kacys-cdrtools-3.02a06.drv' failed with exit code 2
  error: build of '/nix/store/6ib4cmkpr3wz0gil8xmw6alvay4kacys-cdrtools-3.02a06.drv' failed
  ```

  ([full log here](https://gist.github.com/Amar1729/09e1be5a36c7ffaa0c66b0758994cff8#file-cdrtools-log))


  - [the changes i've tried on my own fork](https://github.com/NixOS/nixpkgs/compare/master...Amar1729:darwin-fix/cdrtools?expand=1)
  - [`cdrtools` package in homebrew](https://github.com/Homebrew/homebrew-core/blob/7f5ad53584b5ac137fc4b9b41246180a0e5592dd/Formula/cdrtools.rb) for reference

  I'll make a PR if I can figure this out, but some of these issues are stumping me. Hoping someone else has some idea how to fix it.

  ### Steps to reproduce

  1. be on darwin and nixpkgs `master`
  2. `nix-build . -A cdrtools`


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(amar): `"nixpkgs-19.09pre177248.ed1b59a98e7"`
   - nixpkgs: `/Users/amar/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: Kubernetes: control-plane-online-pre-start failed
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/issues/60358
updated_at: 2019-05-14 00:22:36
body:
  ## Issue description

  The issue I'm seeing here is that kubernetes will not start properly with the following error:

  ```
  warning: the following units failed: kube-control-plane-online.service

  ● kube-control-plane-online.service - Kubernetes control plane is online
     Loaded: loaded (/nix/store/8cisr9kn686c6js5h5knr8ik9wjrdfaw-unit-kube-control-plane-online.service/kube-control-plane-online.service; enabled; vendor preset: enabled)
     Active: failed (Result: timeout) since Sun 2019-04-28 09:02:22 BST; 36ms ago
    Process: 60385 ExecStartPre=/nix/store/04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start (code=killed, signal=TERM)

  Apr 28 09:02:03 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:06 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:09 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:13 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:16 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:19 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:22 home 04ih2w1sky4qzpk5v6x5x3hcyqg5bn6w-unit-script-kube-control-plane-online-pre-start[60385]: Please enter Username: kubectl get --raw=/healthz: exit status 1
  Apr 28 09:02:22 home systemd[1]: kube-control-plane-online.service: Start-pre operation timed out. Terminating.
  Apr 28 09:02:22 home systemd[1]: kube-control-plane-online.service: Failed with result 'timeout'.
  Apr 28 09:02:22 home systemd[1]: Failed to start Kubernetes control plane is online.
  warning: error(s) occurred while switching to the new configuration
  ```

  Clearly it's awaiting an interactive input but isn't getting it so eventually times out.

  ### Steps to reproduce

  Using the following nix extract:

  ```
  { lib, pkgs, ... }:

  {
    environment =
    {
      etc."profile".text = lib.mkAfter "export KUBECONFIG=/etc/kubernetes/cluster-admin.kubeconfig";
      systemPackages = with pkgs; [ kubectl ];
    };

  services.kubernetes =
    {
      addons.dashboard.enable = true;
      kubelet.extraOpts = "--fail-swap-on=false";
      masterAddress = "localhost";
      roles = [ "master" "node" ];
    };
  }
  ```

  ## Technical details

  ```
  nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/1gw1mzd1dgxv9jl9292cy89agkn6igcw-bash-interactive-4.4-p23-dev
  copying path '/nix/store/1gw1mzd1dgxv9jl9292cy89agkn6igcw-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.9, NixOS, 19.09pre177249.dfd8f84aef1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre177249.dfd8f84aef1, nixos-small-19.09pre177262.fc48e74127c"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: monaco: init at unstable-2012-06-03
user_login: LinArcX
html_url: https://github.com/NixOS/nixpkgs/pull/60359
updated_at: 2019-04-28 18:43:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  A monospaced sans-serif typeface by Apple Inc.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Added missing dependency needed for testing flent
user_login: ahiaao
html_url: https://github.com/NixOS/nixpkgs/pull/60360
updated_at: 2019-07-02 03:40:27
body:
  Fixed failing package by adding a missing dependency needed during testing.
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gnucash: cannot open help files
user_login: zarelit
html_url: https://github.com/NixOS/nixpkgs/issues/60361
updated_at: 2019-04-28 09:18:57
body:
  ## Issue description

  `gnucash` application can't find help files

  ### Steps to reproduce

  Install `gnucash` from nixos release channel, go to main application screen, click on Help menu and select either "tutorial and concepts guide" or "contents". Application complains with a modal reporting "GnuCash could not find the files for the help documentation. This is likely because 'gnucash-docs' package is not installed."

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172361.cf3e277dd0b (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172361.cf3e277dd0b, nixos-hardware"`
   - channels(zarel): `"nixpkgs-19.09pre174594.0c0954781e2"`
   - nixpkgs: `/home/zarel/.nix-defexpr/channels/nixpkgs`


state: closed
title: xmobar: Add xmobar toplevel (backport to 19.03)
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/60362
updated_at: 2019-04-29 01:55:22
body:
  ###### Motivation for this change

  This backports https://github.com/NixOS/nixpkgs/pull/56425 to 19.03.

  #56425 adds `xmobar` to `pkgs/top-level/all-packages.nix`.  The justification is on that PR.

  Pinging @catern (the author of the original PR) and @srhb (the committer for the original PR).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: taskell: 1.3.2 -> 1.4.2
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/60363
updated_at: 2019-05-07 18:52:39
body:
  ###### Motivation for this change

  https://github.com/smallhadroncollider/taskell/issues/33

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildEnv: Don't warn about collisions if contents match when ignoreCollisions=true.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60365
updated_at: 2019-07-12 20:19:52
body:
  This prevents giving many false-positive collision warnings to NixOS users and makes it easier to see real collisions that should be addressed.

  Looking at the history, @aszlig at one time committed a version that behaved like this but then immediately [changed it](https://github.com/NixOS/nixpkgs/commit/bfb11fd0301c1c583319bd2e8211ef434e078792) to how it currently works, that is it warns for every collision without checking contents when ignoreCollision=true (as it is for the NixOS system path). While the resulting environment is indeed the same, I think it is worth doing the content check so that users are warned only about real collisions.

  This reduced the number of collision warnings on my desktop system from 388 to 56.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done
  I tested this with the NixOS system path in a hacky way so that it only affected that (the change as-is causes a mass rebuild because lots of things make use of buildEnv).

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pysonos: init at 0.0.11
user_login: juaningan
html_url: https://github.com/NixOS/nixpkgs/pull/60366
updated_at: 2019-05-03 09:09:37
body:
  pysonos package provides ability to control sonos media player using python. The original need was to use it with the home-assistant package, specifically the "sonos" component.


state: open
title: kernelshark: init at 0.9.8-c8d9e1a & trace-cmd: 2.6 -> 2.8-c8d9e1a
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/60367
updated_at: 2019-06-03 22:19:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://www.phoronix.com/scan.php?page=news_item&px=KernelShark-1.0-Soon

  Note that the `kernelshark-1.0` has not been released yet. This packages the latest git revision.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: R: add timokau as a maintainer
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/60368
updated_at: 2019-04-28 11:39:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I'm interested in R as a dependency for sage. R changes are likely to
  impact sage, so I'd like to get notified on those changes.

  This is mostly to get ofBorg to ping me on PRs such as https://github.com/NixOS/nixpkgs/pull/60273.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Opera web browser is outdated
user_login: jackTaw88
html_url: https://github.com/NixOS/nixpkgs/issues/60369
updated_at: 2019-05-05 17:22:10
body:
  Hi,

  Opera web browser is outdated. Thus it's vpn does not work. The vpn API has been changed on new years. I am reading from reddit: https://www.reddit.com/r/operabrowser/comments/bfk1ba/vpn_not_working_to_anyone_else/

  I will be happy if someone will update it.

  Thank you


state: closed
title: staruml: fix dependency libexpat.so.1
user_login: uHOOCCOOHu
html_url: https://github.com/NixOS/nixpkgs/pull/60370
updated_at: 2019-04-28 17:42:04
body:
  ###### Motivation for this change
  Fix missing shared library dependency `libexpat.so.1`.



  ###### Things done
  Add package `expat` to its `LD_LIBRARY_PATH` for wrapping.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
    - Before: 455599176 (434.49 MiB)
    - After: 464853368 (443.32 MiB)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Changelog meta entry
user_login: 7c6f434c
html_url: https://github.com/NixOS/nixpkgs/pull/60371
updated_at: 2019-05-10 16:55:30
body:
  ###### Motivation for this change

  There are various calls to pay attention to changelog. For easier location of the changelog and for better tooling support, we should allow putting a link to the changelog into `meta`.

  This only changes the documentation and the `meta` correctness check.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: nixos/luksroot: GPG Smartcard support for luks encrypted volumes in initrd
user_login: marenz2569
html_url: https://github.com/NixOS/nixpkgs/pull/60372
updated_at: 2019-05-13 12:50:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I do want to decrypt my luks volumes with a gpg smart card.
  You manually have to encrypt the passphrase for the decryption of luks and specify the gpg encrypted file.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: idrisPackages.build-idris-package: Install binaries
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60373
updated_at: 2019-04-30 22:28:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://discourse.nixos.org/t/buidling-hello-world-in-idris/2793

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: slack: dark mode css can be passed as argument
user_login: anpryl
html_url: https://github.com/NixOS/nixpkgs/pull/60375
updated_at: 2019-06-13 10:13:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Slack package has a dark mode, but current CSS for dark mode is broken for "All threads".
  I add an optional argument to derivation for CSS url.
  Default CSS url is an old one, so it is backward compatible.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mfoc: 0.10.6 -> 0.10.7
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60378
updated_at: 2019-04-28 17:35:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package refresh *and* 
  - one less SHA1 hash
  - one less fetchurl on GH archives
  - one less in-tree patch

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: service-wrapper: 16.04.0 -> 19.04
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60379
updated_at: 2019-04-28 17:25:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Resync with upstream
  \+ make `--version` output consistent with derivation

  cc @DerTim1 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rambox-pro: init at 1.1.2
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/60380
updated_at: 2019-05-01 18:20:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I use Rambox Pro extensively for my communication needs and whilst open source Rambox is packaged - the pro variant is not. I'd like to address this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: appimage: move extraPkgs default'ing to wrapAppImage
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60381
updated_at: 2019-04-30 08:00:45
body:
  cc @tilpner

  As discussed on IRC and the minetime PR.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: README: 18.09 -> 19.03
user_login: angristan
html_url: https://github.com/NixOS/nixpkgs/pull/60382
updated_at: 2019-05-07 14:48:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  Modified all occurrences of "18.09" to "19.03" 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pulseeffects can't find most of its plugins
user_login: peti
html_url: https://github.com/NixOS/nixpkgs/issues/60383
updated_at: 2019-04-28 19:58:13
body:
  I'm using the latest `pulseeffects` from `master` and it works fine, mostly. I notice the following errors during start-up, though:

  ~~~
  .pulseeffects-w[7916]: limiter plugin was not found!
  .pulseeffects-w[7916]: filter plugin was not found!
  .pulseeffects-w[7916]: reverb plugin was not found!
  .pulseeffects-w[7916]: bass_enhancer plugin was not found!
  .pulseeffects-w[7916]: exciter plugin was not found!
  .pulseeffects-w[7916]: multiband_compressor plugin was not found!
  .pulseeffects-w[7916]: gate plugin was not found!
  .pulseeffects-w[7916]: multiband_gate plugin was not found!
  .pulseeffects-w[7916]: deesser plugin was not found!
  .pulseeffects-w[7916]: stereo_tools plugin was not found!
  .pulseeffects-w[7916]: limiter plugin was not found!
  .pulseeffects-w[7916]: filter plugin was not found!
  .pulseeffects-w[7916]: reverb plugin was not found!
  .pulseeffects-w[7916]: gate plugin was not found!
  .pulseeffects-w[7916]: deesser plugin was not found!
  .pulseeffects-w[7916]: multiband_compressor plugin was not found!
  .pulseeffects-w[7916]: multiband_gate plugin was not found!
  .pulseeffects-w[7916]: unable to send notifications through org.freedesktop.Notifications: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Notifications was not provided by any .service files
  ~~~

  Looking at the build it seems like all recommended dependencies are there so it doesn't seem likely that those plugins weren't built, no? But why are they missing at run-time? And why are others (like the equalizer) *not* missing?


state: open
title: libmtp error: Error getting friendlyname.
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60384
updated_at: 2019-04-28 19:11:16
body:
  ## Issue description

  I tried to copy files from my Android smartphone to my notebook using Pantheon Files.

  For some files (all videos) i get this error:

  `libmtp error:  Error getting friendlyname.`

  It is reproducible with this files.

  syslog:

  ```
  Apr 28 20:08:23 X230 org.gtk.vfs.Daemon[1924]: mkdir failed on directory /var/cache/samba: Permission denied
  Apr 28 20:08:23 X230 org.gtk.vfs.Daemon[1924]: mkdir failed on directory /var/cache/samba: Permission denied
  Apr 28 20:08:23 X230 .io.elementary.[12341]: FileUtils.vala:311: Invalid mtp path
  Apr 28 20:08:24 X230 .io.elementary.[12341]: FileUtils.vala:311: Invalid mtp path
  Apr 28 20:08:26 X230 org.gtk.vfs.Daemon[1924]: mkdir failed on directory /var/cache/samba: Permission denied
  Apr 28 20:08:26 X230 org.gtk.vfs.Daemon[1924]: mkdir failed on directory /var/cache/samba: Permission denied
  Apr 28 20:08:29 X230 .io.elementary.[12341]: Sidebar.vala:932: Error querying smb://nas.lan/media/ filesystem info: No route to host
  ```

  I noticed that the files seem to be broken. The video player on the smartphone stops playing in the middle...

  @worldofpeace any idea?

  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172361.cf3e277dd0b (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172361.cf3e277dd0b, nixos-hardware, nixos-unstable-19.09pre177249.dfd8f84aef1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: gotools: 2019-03-05 -> 2019-05-24
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/60385
updated_at: 2019-05-25 12:56:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upstream update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: calf: 0.90.0 -> 0.90.2
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60389
updated_at: 2019-04-28 19:58:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/60383

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: tmux-xpanes: init at 4.1.0
user_login: monsieurp
html_url: https://github.com/NixOS/nixpkgs/pull/60390
updated_at: 2019-07-13 19:37:13
body:
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: ghq: 0.8.0 -> 0.10.2
user_login: cohei
html_url: https://github.com/NixOS/nixpkgs/pull/60391
updated_at: 2019-05-02 16:29:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  To use newer version of `ghq`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: leptonica: 1.74.1 -> 1.78.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60392
updated_at: 2019-05-10 15:57:36
body:
  ###### Motivation for this change

  Multiple CVE's, see 1.77.0 notes.

  http://www.leptonica.com/source/version-notes.html

  Assuming the CVE's impact the version we're using now,
  this should be backported please :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: leksah: Point to upstream repository for using it
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60393
updated_at: 2019-05-02 16:23:57
body:
  The build in nixpkgs was broken for forever. Trying to fix it would be
  painful, as leksah uses a lot of overrides and custom versions. In
  addition, leksah works best with the GHC version matching your project,
  which means we'd have to make sure it builds for each of our GHC
  versions.

  So instead let's just point users to the repo, which should have a working build.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ruby: rubygems 2.7.7 -> 3.0.3
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/60394
updated_at: 2019-05-01 23:23:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  With this change, we can finally easily upgrade Rubygems, and get off this ancient version. Patches no longer have to live on @zimbatm’s GitHub and be applied using a hack that can only handle a single patch. Hooray!

  Attempt 2, following #57809.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodePackages: update and add bash-language-server, typescript-language-server, and speed-test
user_login: malob
html_url: https://github.com/NixOS/nixpkgs/pull/60395
updated_at: 2019-05-10 18:18:21
body:
  ###### Motivation for this change

  Wanted these node packages available in nixpkgs, rather than having to install them manually.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: buildEnv: Skip paths excluded by pathsToLink as soon as they are encountered.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60396
updated_at: 2019-05-04 15:58:21
body:
  The current code only checked at the end of recursive processing which paths should be excluded by pathsToLink. This resulted in false-positive collision warnings or errors for excluded paths.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  False-positive collision warning from `nixos-rebuild` (`pathsToLink` excludes `/libexec` in my configuration):
  ```collision between `/nix/store/wmxqm38g1y1y7sd7s9vg7an3klffaiyz-gnutar-1.31/libexec/rmt' and `/nix/store/yxxfkhl59hsy6x198r2df2xr7jd75i23-cpio-2.12/libexec/rmt'```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  Tested with the NixOS system-path and checked that it produces the exact same result as before, but does not generate that collision warning.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virtualbox: 5.2.26 → 5.2.28
user_login: artemist
html_url: https://github.com/NixOS/nixpkgs/pull/60397
updated_at: 2019-04-30 15:34:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  VirtualBox is out of date

  ###### Things done
  Update the version and hashes in the package

  Note that at the time of posting, the HTTPS update site is down, so it will fail to build unless you manually prefetch it from the HTTP site.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vscode-extensions.WakaTime.vscode-wakatime: 1.3.0 -> 2.0.7
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/60398
updated_at: 2019-04-29 19:29:53
body:
  Looks like it works fine.
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: waifu2x-converter-cpp: init at 5.2.4
user_login: xzfc
html_url: https://github.com/NixOS/nixpkgs/pull/60399
updated_at: 2019-04-30 20:57:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add waifu2x-converter-cpp, an anime image superresolution tool.
  Tested on NVIDIA CUDA, and CPU. Not tested on OpenCL/AMDGPU.
  Previous PR: #50398.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Mate keybinding properties misses window management
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/60400
updated_at: 2019-05-01 23:06:50
body:
  ## Issue description

  The mate keybinding properties does not include window management actions, provided by the marco (the mate window manager) package.
  ![Screenshot from 2019-04-28 22-29-45](https://user-images.githubusercontent.com/1217934/56873028-b5dc3880-6a05-11e9-9142-a8d4fd935393.png)

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.9, NixOS, 19.09pre177249.dfd8f84aef1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre177249.dfd8f84aef1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: mate.mate-control-center: look up keyboard shortcuts in system data dirs
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/60401
updated_at: 2019-05-01 23:06:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes https://github.com/NixOS/nixpkgs/issues/60400.

  > The mate keybinding properties does not include window management actions, provided by the marco (the mate window manager) package.

  ![Screenshot from 2019-04-28 22-29-45](https://user-images.githubusercontent.com/1217934/56873203-17e96d80-6a07-11e9-9478-065f187f0b4f.png)

  Mate control center looks for keybinding shortcuts in files located at `${mate-control-center}/share/mate-control-center/keybindings/`.

  Marco installs its keybinding shortcut files at `${marco}/share/mate-control-center/keybindings/`, which is not being used by the mate control center.

  This PR:
  -  changes mate control center to look for keybinding shortcut files in the system data dirs (defined by the `XDG_DATA_DIRS` environment variable in the freedesktop standards), inspired by `gnome-control-center`
  - adds `${marco}/share` to `XDG_DATA_DIRS` in the wrapper for the mate control center applications.

  Tested on a virtual machine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: wol: fix manpage generation
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60402
updated_at: 2019-04-30 09:43:36
body:
  ###### Motivation for this change

  backport of https://github.com/NixOS/nixpkgs/pull/60310

  Cc: @Mic92 @makefu

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flow: 0.97.0 -> 0.98.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60403
updated_at: 2019-04-29 03:46:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/facebook/flow/releases/tag/v0.98.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


