# issues

state: closed
title: ipxe: enable UEFI support
user_login: edef1c
html_url: https://github.com/NixOS/nixpkgs/pull/60984
updated_at: 2019-05-25 09:57:13
body:
  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: libglvnd, ocl-icd, vulkan-loader: Add /run/opengl-driver(-32) to RUNPATH.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60985
updated_at: 2019-06-08 18:44:06
body:
  Previously we were relying on LD_LIBRARY_PATH to discover vendor driver libraries (libGL, ligGLX, libEGL, OpenCL and Vulkan). This has the problem that setuid programs (in particular VirtualBox) ignore LD_LIBRARY_PATH. Fix it by setting RUNPATH in various dispatch libraries to look in /run/opengl-driver(-32).

  Setting this on the VirtualBoxVM binary (which would be simpler) would not solve the problem, the RUNPATH must be on the library which performs the dlopen(). The dlopen man page claims that the RUNPATH from the executable is used but that is incorrect, only RUNPATH from the module performing dlopen() is used.

  Note that setting *RPATH* on the executable would work, but patchelf manipulates RUNPATH and not RPATH (RPATH is a legacy feature).

  Fixes https://github.com/NixOS/nixpkgs/issues/22760
  Fixes https://github.com/NixOS/nixpkgs/issues/18457.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  3D acceleration in VirtualBox does not work with NVidia drivers when hardening is enabled for VirtualBox (the default) (https://github.com/NixOS/nixpkgs/issues/22760)

  ###### Things done
  Tested this on 19.03, with this change there is no error when starting a VM with 3D acceleration enabled and the VM log shows that OpenGL was initialized successfully.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libiio: 0.17 -> 0.18
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60986
updated_at: 2019-05-11 02:56:41
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libiio/versions.



  meta.description for libiio is: '"API for interfacing with the Linux Industrial I/O Subsystem"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.18 with grep in /nix/store/36mdlj89c7scyycfx3khyv198i32z6d5-libiio-0.18
  - directory tree listing: https://gist.github.com/a1e65072697a49b6192d5d14b46f4638
  - du listing: https://gist.github.com/7174b5bc8cb098b66a723e50caea16e0

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  9 total rebuild path(s)

  3 package rebuild(s)

  3 x86_64-linux rebuild(s)
  3 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  3 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  libiio
  python27Packages.libiio
  python37Packages.libiio

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/36mdlj89c7scyycfx3khyv198i32z6d5-libiio-0.18 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libiio https://github.com/r-ryantm/nixpkgs/archive/480f86ea6d2f9b375632649273f09219c77b7ede.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/36mdlj89c7scyycfx3khyv198i32z6d5-libiio-0.18
  ls -la /nix/store/36mdlj89c7scyycfx3khyv198i32z6d5-libiio-0.18/bin
  ```


  </details>
  <br/>


  cc @thoughtpolice for testing.


state: closed
title: mdl: use bundlerApp
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60987
updated_at: 2019-05-07 22:09:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Just switch to the cleaner `bundlerApp`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libshout: 2.4.1 -> 2.4.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60988
updated_at: 2019-05-11 02:57:10
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libshout/versions.



  meta.description for libshout is: '"icecast 'c' language bindings"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.4.2 with grep in /nix/store/wywwh5l3lny0aw42pl8pq093npn1fxc6-libshout-2.4.2
  - directory tree listing: https://gist.github.com/7b7081c6d11c0d518ee51b25efdecec9
  - du listing: https://gist.github.com/0adfcf81321d94be03a036f4cc8b3c44

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  542 total rebuild path(s)

  177 package rebuild(s)

  177 x86_64-linux rebuild(s)
  174 i686-linux rebuild(s)
  27 x86_64-darwin rebuild(s)
  164 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  adapta-gtk-theme
  ahoviewer
  alarm-clock-applet
  aravis
  arc-theme
  audio-recorder
  baresip
  beets
  brasero
  brasero-original
  byzanz
  chrome-gnome-shell
  clementine
  clementineUnfree
  corebird
  cozy
  cutegram
  denemo
  dragon
  empathy
  enlightenment.econnman
  enlightenment.efl
  enlightenment.enlightenment
  enlightenment.ephoto
  enlightenment.rage
  enlightenment.terminology
  epiphany
  evince
  ezstream
  farstream
  feedreader
  freerdp
  freerdpUnstable
  gajim
  gcompris
  glom
  gmrender-resurrect
  gnome3.cheese
  gnome3.empathy
  gnome3.epiphany
  gnome3.evince
  gnome3.gnome-books
  gnome3.gnome-boxes
  gnome3.gnome-contacts
  gnome3.gnome-control-center
  gnome3.gnome-documents
  gnome3.gnome-music
  gnome3.gnome-session
  gnome3.gnome-shell
  gnome3.gnome-sound-recorder

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/wywwh5l3lny0aw42pl8pq093npn1fxc6-libshout-2.4.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libshout https://github.com/r-ryantm/nixpkgs/archive/e0f8ccf37f3419e83b82b0edcca74dfd473b62df.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/wywwh5l3lny0aw42pl8pq093npn1fxc6-libshout-2.4.2
  ls -la /nix/store/wywwh5l3lny0aw42pl8pq093npn1fxc6-libshout-2.4.2/bin
  ```


  </details>
  <br/>


state: closed
title: libwmf: 0.2.8.4 -> 0.2.12
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60989
updated_at: 2019-05-06 13:18:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Includes the previous security fixes:
  \- CVE-2006-3376
  \- CVE-2009-1364
  \- CVE-2015-0848+4588+4695+4696
  \- CVE-2016-9011

  \+ fixes CVE-2019-6978 (in libgd)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mediainfo: 18.12 -> 19.04
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60990
updated_at: 2019-05-11 02:57:47
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mediainfo/versions.



  meta.description for mediainfo is: '"Supplies technical and tag information about a video or audio file"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 19.04 with grep in /nix/store/iykgsw7zdjg8ivzwk73qikyzadx58qn1-mediainfo-19.04
  - directory tree listing: https://gist.github.com/9b74545c3f75cd85a76b030bd6ddfc76
  - du listing: https://gist.github.com/b251019e5e89d976a8fd4a6693a732f2

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  mediainfo

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/iykgsw7zdjg8ivzwk73qikyzadx58qn1-mediainfo-19.04 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A mediainfo https://github.com/r-ryantm/nixpkgs/archive/92e243d56d8d3ce73ab3271669239b0007302d0b.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/iykgsw7zdjg8ivzwk73qikyzadx58qn1-mediainfo-19.04
  ls -la /nix/store/iykgsw7zdjg8ivzwk73qikyzadx58qn1-mediainfo-19.04/bin
  ```


  </details>
  <br/>


  cc @devhell for testing.


state: closed
title: SDL2: add fcitx support
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/60991
updated_at: 2019-05-09 00:19:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This enables text input with fcitx.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-asm: 0.1.16 -> 0.1.17
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/60992
updated_at: 2019-06-04 05:55:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This version has some improvements across the board, such as improved
  demangling of LLVM-IR.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mercurialFull: 4.9.1 -> 5.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60993
updated_at: 2019-06-05 07:38:51
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mercurial-full/versions.



  meta.description for mercurialFull is: '"A fast, lightweight SCM system for very large distributed projects"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 5.0 with grep in /nix/store/fzmzbjwgna1nk2ybjaj61xj75r83zxmb-mercurial-5.0
  - directory tree listing: https://gist.github.com/9c9c99f219915e2008304926fad1a379
  - du listing: https://gist.github.com/5ec50feed9c107cfb0aa1b991efde0c2

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  75 total rebuild path(s)

  20 package rebuild(s)

  20 x86_64-linux rebuild(s)
  19 i686-linux rebuild(s)
  17 x86_64-darwin rebuild(s)
  19 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  cabal2nix
  dep2nix
  devpi-client
  gitAndTools.git-remote-hg
  gitAndTools.gitFastExport
  hydra
  mbed-cli
  mercurial
  mercurialFull
  mx
  nbstripout
  nix-prefetch-hg
  nix-prefetch-scripts
  nix-update-source
  pypi2nix
  python27Packages.hglib
  python27Packages.hgsvn
  python37Packages.hglib
  reposurgeon
  tortoisehg

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/fzmzbjwgna1nk2ybjaj61xj75r83zxmb-mercurial-5.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A mercurialFull https://github.com/r-ryantm/nixpkgs/archive/b0c7cf242f8b315a95712d2d3ab21b96a5823a26.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/fzmzbjwgna1nk2ybjaj61xj75r83zxmb-mercurial-5.0
  ls -la /nix/store/fzmzbjwgna1nk2ybjaj61xj75r83zxmb-mercurial-5.0/bin
  ```


  </details>
  <br/>


  cc @edolstra for testing.


state: closed
title: pstree: remove and alias to psmisc
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60994
updated_at: 2019-05-07 18:12:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Former `pstree` is abandonware at this point in time (the first src url is gone for example).
  And the maintained package `psmisc` provides a `pstree` tool with more options

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] matrix-synapse: 0.99.3 -> 0.99.3.2
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60995
updated_at: 2019-05-05 16:56:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  (cherry picked from commit f91b7984b4f82a3b4e1c5a42160fd59ddb1f5376)
   #60942

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Warn on deprecated /var/run in shell paths
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/60996
updated_at: 2019-06-20 19:35:58
body:
  ###### Motivation for this change

  The /var/run deprecation in nixpkgs removed
  /var/run/current-system/sw/<shell> from `environment.shells` and hence
  from `/etc/shells` without any warning to users still using
  `/var/run/..` paths in `users.defaultUserShell` or in `users.*.shell`.

  This PR tries to smooth the migration by throwing an error on such
  shells in configs.

  It may be better to warn instead of throwing an error, but at the same time you do not want users to be locked out of their machine because ssh thinks that their shell is invalid/not allowed.

  The issue was raised by @Mic92 in @peterhoeg 's PR https://github.com/NixOS/nixpkgs/pull/47856#pullrequestreview-161473775 but was lost in the other comments and the migration to another PR.

  ###### Things done

  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  /cc @bobvanderlinden, @globin, @flokli for working on #51918


state: closed
title: Installing make
user_login: ProgrammingHider
html_url: https://github.com/NixOS/nixpkgs/issues/60997
updated_at: 2019-05-06 18:49:18
body:
  Hello,
  I just did a clean install of NixOS 19.03(Koi) and wanted to compile dwm, but make was missing, so i typed in `sudo nix-env -i make`, and got an error. After doing `sudo nix-env -qa make`, make wasn't there. Does anyone know what package i have to install?

  Thanks in Advance


state: closed
title: pythonPackages.worldengine: fix tests by moving nose to checkInputs
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60998
updated_at: 2019-05-07 14:16:17
body:
  ###### Motivation for this change
  ~This is a draft PR because it sits on top of a required fix for `purepng` @ https://github.com/NixOS/nixpkgs/pull/60813, will rebase once that's merged.~ Done.

  The tests are all actually `unittest` tests, it seems `nose` is only necessary on python <3.5 where the naming of the test modules causes `unittest` itself not to be able to pick them up.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: initrd networking not working on aarch64
user_login: matthias-t
html_url: https://github.com/NixOS/nixpkgs/issues/60999
updated_at: 2019-05-05 17:24:50
body:
  ## Issue description

  I can't get initrd networking to work on aarch64.

  ```console
  $ dmesg
  ...
  stage-1-init: modprobe: FATAL: Module af_packet not found in directory /lib/modules/5.0.10
  ...
  ```

  ### Steps to reproduce

  - set `boot.initrd.network.enable = true` and `boot.initrd.kernelModules = [ "..." ]`
  - rebuild
  - reboot

  ## Technical details

  ```console
  $ zgrep PACKET /proc/config.gz
  CONFIG_PACKET=y
  CONFIG_PACKET_DIAG=m
  CONFIG_NET_VENDOR_PACKET_ENGINES=y 
  ```

  - hardware: Raspberry Pi 3 Model B
  - ethernet driver: `smsc95xx`

  ***
   - system: `"aarch64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.09pre178260.190727db4ea (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178260.190727db4ea"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nzbget: 20.0 -> 21.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61000
updated_at: 2019-05-11 02:58:16
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nzbget/versions.



  meta.description for nzbget is: '"A command line tool for downloading files from news servers"'.

  [Release on GitHub](https://github.com/nzbget/nzbget/releases/tag/v21.0)


  [Compare changes on GitHub](https://github.com/nzbget/nzbget/compare/v20.0...v21.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 21.0 with grep in /nix/store/9ida4zmh30skrzrl0wjvqxij052x946d-nzbget-21.0
  - directory tree listing: https://gist.github.com/029e2d8b1a1c80175ae7ea453fbacbd3
  - du listing: https://gist.github.com/803a8c4c0f4b383a8e69d42f0e98c750

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  nzbget

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/9ida4zmh30skrzrl0wjvqxij052x946d-nzbget-21.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A nzbget https://github.com/r-ryantm/nixpkgs/archive/661d9e59cd81efb5b93d84206af8e589ece3b47d.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/9ida4zmh30skrzrl0wjvqxij052x946d-nzbget-21.0
  ls -la /nix/store/9ida4zmh30skrzrl0wjvqxij052x946d-nzbget-21.0/bin
  ```


  </details>
  <br/>


  cc @pSub for testing.


state: closed
title: qscintilla: add qtmacextras to propagatedBuildInputs on darwin
user_login: ryan4729
html_url: https://github.com/NixOS/nixpkgs/pull/61001
updated_at: 2019-05-11 22:13:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I found that `qgis` failed to build on macOS because `python3Packages.qscintilla-qt5` was failing. The problem was that `qtmacextras` needs to be in the `buildInputs` of `python3Packages.qscintilla-qt5`. This change adds `qtmacextras` to `propagatedBuildInputs` of `qscintilla`. I wasn't sure if this is the right change, or if I should add `qtmacextras` directly to `python3Packages.qscintilla-qt5`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.re: 1.8.0 -> 1.9.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61002
updated_at: 2019-05-11 02:58:25
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-re/versions.



  meta.description for ocamlPackages.re is: '"Pure OCaml regular expressions, with support for Perl and POSIX-style strings"'.


  [Compare changes on GitHub](https://github.com/ocaml/ocaml-re/compare/1.8.0...1.9.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.9.0 with grep in /nix/store/3a7mj4jy60qkc4f0z2ri28amzxib16yp-ocaml4.06.1-re-1.9.0
  - directory tree listing: https://gist.github.com/9c9172e2296c42ee549565a71dd3cd65
  - du listing: https://gist.github.com/b48eb4a7b800bdb700c18e63e1e3d806

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  31 total rebuild path(s)

  8 package rebuild(s)

  8 x86_64-linux rebuild(s)
  8 i686-linux rebuild(s)
  8 x86_64-darwin rebuild(s)
  7 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  flow
  libbap
  ocaml-top
  patdiff
  pyre
  satysfi
  stog
  trv

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/3a7mj4jy60qkc4f0z2ri28amzxib16yp-ocaml4.06.1-re-1.9.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ocamlPackages.re https://github.com/r-ryantm/nixpkgs/archive/3571e09fb24e9da3ad240e9bc75e7ed9530071a8.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/3a7mj4jy60qkc4f0z2ri28amzxib16yp-ocaml4.06.1-re-1.9.0
  ls -la /nix/store/3a7mj4jy60qkc4f0z2ri28amzxib16yp-ocaml4.06.1-re-1.9.0/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: ocamlPackages.ppxlib: 0.5.0 -> 0.6.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61003
updated_at: 2019-05-11 02:58:22
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-ppxlib/versions.



  meta.description for ocamlPackages.ppxlib is: '"Comprehensive ppx tool set"'.


  [Compare changes on GitHub](https://github.com/ocaml-ppx/ppxlib/compare/0.5.0...0.6.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.6.0 with grep in /nix/store/p1l7820rs3nyyx928bjqngi7kcjfv3vs-ocaml4.06.1-ppxlib-0.6.0
  - directory tree listing: https://gist.github.com/67b0b9176c168f2ee571239d92667615
  - du listing: https://gist.github.com/fa9f1ca404e0545d5d26dda8d3dbaffc

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  20 total rebuild path(s)

  6 package rebuild(s)

  6 x86_64-linux rebuild(s)
  5 i686-linux rebuild(s)
  5 x86_64-darwin rebuild(s)
  4 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  flow
  jackline
  patdiff
  pyre
  satysfi
  stog

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/p1l7820rs3nyyx928bjqngi7kcjfv3vs-ocaml4.06.1-ppxlib-0.6.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ocamlPackages.ppxlib https://github.com/r-ryantm/nixpkgs/archive/bdd85ebab43e662dc87cbc0a7d7f3ce251cd603a.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/p1l7820rs3nyyx928bjqngi7kcjfv3vs-ocaml4.06.1-ppxlib-0.6.0
  ls -la /nix/store/p1l7820rs3nyyx928bjqngi7kcjfv3vs-ocaml4.06.1-ppxlib-0.6.0/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: ocamlPackages.ppx_derivers: 1.2 -> 1.2.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61004
updated_at: 2019-05-11 02:58:19
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-ppx_derivers/versions.



  meta.description for ocamlPackages.ppx_derivers is: '"Shared [@@deriving] plugin registry"'.

  [Release on GitHub](https://github.com/ocaml-ppx/ppx_derivers/releases/tag/1.2.1)


  [Compare changes on GitHub](https://github.com/diml/ppx_derivers/compare/1.2...1.2.1)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.2.1 with grep in /nix/store/r11558la8lpn7rldzgm5iihjsal1svwh-ocaml4.06.1-ppx_derivers-1.2.1
  - directory tree listing: https://gist.github.com/ddbc2a4800e6cd576f783721a080d865
  - du listing: https://gist.github.com/414acbbd98f90d6fd5e7cd964006c501

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  44 total rebuild path(s)

  12 package rebuild(s)

  12 x86_64-linux rebuild(s)
  11 i686-linux rebuild(s)
  11 x86_64-darwin rebuild(s)
  10 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  acgtk
  eff
  flow
  fstar
  jackline
  libbap
  ocamlformat
  patdiff
  pyre
  reason
  satysfi
  stog

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/r11558la8lpn7rldzgm5iihjsal1svwh-ocaml4.06.1-ppx_derivers-1.2.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ocamlPackages.ppx_derivers https://github.com/r-ryantm/nixpkgs/archive/8d9e99992eee499897dee18628d6a48362cb34db.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/r11558la8lpn7rldzgm5iihjsal1svwh-ocaml4.06.1-ppx_derivers-1.2.1
  ls -la /nix/store/r11558la8lpn7rldzgm5iihjsal1svwh-ocaml4.06.1-ppx_derivers-1.2.1/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: Please update to Firefox 66.0.4 (master and release branches) to fix broken addons
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/issues/61005
updated_at: 2019-05-06 00:26:59
body:
  ## Issue description

  As many already know, an issue with expired certificates made all Firefox addons suddenly "untrusted" by the browser:

  https://blog.mozilla.org/addons/2019/05/04/update-regarding-add-ons-in-firefox/

  Apparently a new release of Firefox with updated certificates has been published:

  https://ftp.mozilla.org/pub/firefox/releases/66.0.4/

  Would it be possible to update master and appropriate release branches please?

  See also #60916 

  Thanks


state: closed
title: prometheus_2: 2.8.1 -> 2.9.2
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/61006
updated_at: 2019-05-06 02:17:54
body:
  ###### Motivation for this change

  https://github.com/prometheus/prometheus/releases

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I am using 2.9.2 and it seems to work fine.


state: open
title: state-1-init failure with boot.panic_on_fail can lose error messages
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/issues/61007
updated_at: 2019-05-05 20:37:26
body:
  ## Issue description

  I've discovered this issue while running the NixOS tests for VirtualBox. There the tests set the `boot.panic_on_fail` kernel parameter resulting in `panicOnFail` being set to 1 in `stage-1-init.sh`. In my case the mount command for mounting the root filesystem failed, but I have only seen traces of a few earlier commands being executed, the kernel panic, but no error message from mount. I added a sleep between the mount and the following line that calls fail:

  ```
      # For CIFS mounts, retry a few times before giving up.
      local n=0
      while true; do
          mount "/mnt-root$mountPoint" && break
          sleep 3 # sleep added
          if [ "$fsType" != cifs -o "$n" -ge 10 ]; then fail; break; fi
          echo "retrying..."
          n=$((n + 1))
      done
  ```

  then I could see the errors from mount, the errors from mount somehow had time to go through. This error might be related to the fact that the console of this VM is a serial port.

  ### Steps to reproduce

  Do something that will result in mount failure in [virtualbox tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/virtualbox.nix), such as changing the share name of the share to be mounted:

  ```
      fileSystems."/" = {
        device = "vboxshare"; # change it so it will be wrong
        fsType = "vboxsf";
      };
  ```

  then run the tests:
  ```
  nix-build -A nixosTests.virtualbox
  ```

  You should get a kernel panic without seeing what the cause is (share does not exist).


state: open
title: chromium: add useOzone and 'chromiumOzone' variant
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/pull/61008
updated_at: 2019-07-04 20:27:49
body:
  ###### Motivation for this change

  Since I did this, apparently talked about it on HN, and someone asked in IRC, I figured I'd send this.

  This adds a new chromium variant that enables Ozone and builds relevant ozone backends.

  Last time I built it, it wasn't really usable due to where upstream is at with Wayland support. Furthermore, the HiDPI handling is pretty completely broken still.

  NOTE: I could use some advice on how to instruct Hydra to not build this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: foundationdb: add fdb 6.1 with cmake build
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/61009
updated_at: 2019-05-28 04:29:14
body:
  ###### Motivation for this change

  FoundationDB 6.1 is going to ship somewhat soon(-ish) and has a new CMake build system. While it would have been possible to keep wobbling on with the old one (a strange beast), CMake has a number of advantages and the overall result for the 6.1+ builds is looking much cleaner in the future with minimal patching, no old boost, or GCC 4.9, etc.

  Some notes:

    - Allow usage of `clang` and `libcxx` as the stdenv if `useClang = true`. This significantly shrinks (~45%) the resulting closure size because all foundationdb binaries are statically linked to their source code (effectively duplicating large amounts of the codebase in each binary). Enabled by default, tentatively.
      - LTO doesn't quite work right in some configurations, but should hopefully offer even further significant increases (~75%!) if we can figure it out.
      - LTO + LLD in `libcxxStdenv` needs investigation, it dramatically seems to reduce memory requirements but something weird happens and `libtls` doesn't get its `RPATH` appropriately set(????)
    - We only need *one* patch this time, which will hopefully be resolved upstream eventually. For us, this patch is completely positive and only fixes a build failure with libcxx. See the discussion in https://github.com/apple/foundationdb/pull/1533 for a path forwards.
    - The new build has a wonky layout in the install phase due to its strange `fdb_install` custom command, so unfortunately we still need a mostly custom install phase. I want to try and fix this so normal `ninja install` or whatever works (maybe I'm missing something) but it'll take more coordination upstream.
    - Tentatively using `gcc8Stdenv` for now as well, since it gives some binary size improvements. This can probably go away if we move to GCC 9.1 or something in `stdenv` (soon, hopefully!)
    - We now ship the tests that are run in the `.out` output. These are tiny compared to the binaries so it's not a big deal, but the improvement is that we can now run self-tests against any closures we build. (My intention is to eventually automate this and use it in some of the FoundationDB NixOS tests.)
      - Unfortunately, there's no way to get the enabled test list from CMake easily. :( I'd like to fix this upstream so we don't need `test-lists.txt`.

  This is a draft and a WIP, but the core shape looks OK I guess. This expression is also very viable and suitable for development on FDB itself using `nix-shell '<nixpkgs>' -A foundationdb61 --pure`, etc.

  ###### Still TODO

  - [x] Re-distribute the `fdb-java.jar` file again (should be easy, it gets built anyway).
  - [x] Re-implement `.pythonsrc` so the Python bindings still work.
  - [ ] I don't understand the `libtls` weirdness going on in the build system, it should just detect it from `buildInputs` I think...
  - [x] ~Find a way to get rid of `test-lists.txt`~
    - This will probably take some work upstream, see [some forum discussion](https://forums.foundationdb.org/t/show-the-fdb-forums-prototyping-simulation-runs-on-kubernetes/1357/2). For now, this is alright I guess...
  - [ ] Think about getting rid of older FoundationDB versions? Bonus points: we can finally get rid of `stdenv49` since nothing else needs it, and all the other old stuff! (The on-disk formats are still compatible, too!)

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: libvirt: 4.10.0 -> 5.3.0
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/61011
updated_at: 2019-06-28 20:06:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix.systemFeatures: minor fix
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/61012
updated_at: 2019-05-06 01:07:28
body:
  following up #59148
  I forgot the default case of the architectures which do not have minor brothers whose code they can run ("westmere" or any of AMDs)


state: closed
title: python37Packages.altair: 2.4.1 -> 3.0.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61013
updated_at: 2019-05-11 02:59:43
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-altair/versions.



  meta.description for python37Packages.altair is: '"A declarative statistical visualization library for Python."'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.0.0 with grep in /nix/store/210nh8li7j6fp2gq3s6iaywjjijmlrss-python3.7-altair-3.0.0
  - directory tree listing: https://gist.github.com/197d23b6608e2b267adf2f2f1fdce6e4
  - du listing: https://gist.github.com/2b937dfd6045039840c628cc32abb46e

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.altair
  python37Packages.altair

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/210nh8li7j6fp2gq3s6iaywjjijmlrss-python3.7-altair-3.0.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.altair https://github.com/r-ryantm/nixpkgs/archive/1eae2945b427a315529e7c91b73bdc31378d0641.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/210nh8li7j6fp2gq3s6iaywjjijmlrss-python3.7-altair-3.0.0
  ls -la /nix/store/210nh8li7j6fp2gq3s6iaywjjijmlrss-python3.7-altair-3.0.0/bin
  ```


  </details>
  <br/>


  cc @teh for testing.


state: closed
title: python37Packages.awkward: 0.8.15 -> 0.9.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61014
updated_at: 2019-05-11 02:59:46
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-awkward/versions.



  meta.description for python37Packages.awkward is: '"Manipulate jagged, chunky, and/or bitmasked arrays as easily as Numpy"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.9.0 with grep in /nix/store/aqkr51ihxli4z0h1izwn5ajs7k4rgjv3-python3.7-awkward-0.9.0
  - directory tree listing: https://gist.github.com/081e8d2f8dd6605024682c8ffe533a8b
  - du listing: https://gist.github.com/eb0cb47b727076a0fb23efac008aa710

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  24 total rebuild path(s)

  6 package rebuild(s)

  6 x86_64-linux rebuild(s)
  6 i686-linux rebuild(s)
  6 x86_64-darwin rebuild(s)
  6 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.awkward
  python27Packages.uproot
  python27Packages.uproot-methods
  python37Packages.awkward
  python37Packages.uproot
  python37Packages.uproot-methods

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/aqkr51ihxli4z0h1izwn5ajs7k4rgjv3-python3.7-awkward-0.9.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.awkward https://github.com/r-ryantm/nixpkgs/archive/93b82f7a045612f9407aa67f09480fd5396bc935.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/aqkr51ihxli4z0h1izwn5ajs7k4rgjv3-python3.7-awkward-0.9.0
  ls -la /nix/store/aqkr51ihxli4z0h1izwn5ajs7k4rgjv3-python3.7-awkward-0.9.0/bin
  ```


  </details>
  <br/>


  cc @costrouc for testing.


state: open
title: python37Packages.azure-mgmt-storage: 3.1.1 -> 3.3.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61015
updated_at: 2019-06-19 12:06:59
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-azure-mgmt-storage/versions.



  meta.description for python37Packages.azure-mgmt-storage is: '"Microsoft Azure SDK for Python"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.3.0 with grep in /nix/store/yj8nbkdxnnq8k07mzqm042f1vm3y61qx-python3.7-azure-mgmt-storage-3.3.0
  - directory tree listing: https://gist.github.com/8fb3c71dc5d4efb5b5d0b0e5a49174ac
  - du listing: https://gist.github.com/739bce116187cc9ceb5193469042af9a

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.azure-mgmt-storage
  python37Packages.azure-mgmt-storage

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/yj8nbkdxnnq8k07mzqm042f1vm3y61qx-python3.7-azure-mgmt-storage-3.3.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.azure-mgmt-storage https://github.com/r-ryantm/nixpkgs/archive/719c0560c7ec40ad26d84ee3002e3f1bbe13f773.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/yj8nbkdxnnq8k07mzqm042f1vm3y61qx-python3.7-azure-mgmt-storage-3.3.0
  ls -la /nix/store/yj8nbkdxnnq8k07mzqm042f1vm3y61qx-python3.7-azure-mgmt-storage-3.3.0/bin
  ```


  </details>
  <br/>


  cc @olcai for testing.


state: closed
title: python37Packages.braintree: 3.52.0 -> 3.53.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61016
updated_at: 2019-05-11 02:59:49
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-braintree/versions.



  meta.description for python37Packages.braintree is: '"Python library for integration with Braintree"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.53.0 with grep in /nix/store/ll1412mhqiv310wnjgk9lsklacy4wlgk-python3.7-braintree-3.53.0
  - directory tree listing: https://gist.github.com/0a01a18c666b149706e697849232c343
  - du listing: https://gist.github.com/76b41bef8297cb2f70724cdf19054748

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.braintree
  python37Packages.braintree

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/ll1412mhqiv310wnjgk9lsklacy4wlgk-python3.7-braintree-3.53.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.braintree https://github.com/r-ryantm/nixpkgs/archive/a784a005eb070b4f7b6ec2d6770cd65e64906f46.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/ll1412mhqiv310wnjgk9lsklacy4wlgk-python3.7-braintree-3.53.0
  ls -la /nix/store/ll1412mhqiv310wnjgk9lsklacy4wlgk-python3.7-braintree-3.53.0/bin
  ```


  </details>
  <br/>


  cc @ivegotasthma for testing.


state: closed
title: python37Packages.cerberus: 1.2 -> 1.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61017
updated_at: 2019-05-11 02:59:26
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-cerberus/versions.



  meta.description for python37Packages.cerberus is: '"Lightweight, extensible schema and data validation tool for Python dictionaries"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.3 with grep in /nix/store/f977n8hw6x84bl6w7l4ihjnyccqfnpiv-python3.7-Cerberus-1.3
  - directory tree listing: https://gist.github.com/57c4c54c23e64865592e3a6ce8d00386
  - du listing: https://gist.github.com/67f8961abafe61578302d062c2ad21aa

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  16 total rebuild path(s)

  4 package rebuild(s)

  4 x86_64-linux rebuild(s)
  4 i686-linux rebuild(s)
  4 x86_64-darwin rebuild(s)
  4 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.cerberus
  python27Packages.eve
  python37Packages.cerberus
  python37Packages.eve

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/f977n8hw6x84bl6w7l4ihjnyccqfnpiv-python3.7-Cerberus-1.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.cerberus https://github.com/r-ryantm/nixpkgs/archive/5489da1a2bf1c5f9a9075d29ca1fce97d57423fe.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/f977n8hw6x84bl6w7l4ihjnyccqfnpiv-python3.7-Cerberus-1.3
  ls -la /nix/store/f977n8hw6x84bl6w7l4ihjnyccqfnpiv-python3.7-Cerberus-1.3/bin
  ```


  </details>
  <br/>


state: closed
title: python37Packages.distributed: 1.26.1 -> 1.27.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61018
updated_at: 2019-05-11 02:59:55
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-distributed/versions.



  meta.description for python37Packages.distributed is: '"Distributed computation in Python."'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.27.1 with grep in /nix/store/4z3i8bp71gkl6467bybram10va7qk6vx-python3.7-distributed-1.27.1
  - directory tree listing: https://gist.github.com/b726804e0c82d69cf86af738ea2becf9
  - du listing: https://gist.github.com/dcc983a89a034d70d1d33036063efb8e

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  38 total rebuild path(s)

  10 package rebuild(s)

  10 x86_64-linux rebuild(s)
  10 i686-linux rebuild(s)
  10 x86_64-darwin rebuild(s)
  8 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.dask-jobqueue
  python27Packages.dask-mpi
  python27Packages.dask-xgboost
  python27Packages.distributed
  python27Packages.streamz
  python37Packages.dask-jobqueue
  python37Packages.dask-mpi
  python37Packages.dask-xgboost
  python37Packages.distributed
  python37Packages.streamz

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/4z3i8bp71gkl6467bybram10va7qk6vx-python3.7-distributed-1.27.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.distributed https://github.com/r-ryantm/nixpkgs/archive/c7e1b27602ef9dd163dcc25a57082581997bba1f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/4z3i8bp71gkl6467bybram10va7qk6vx-python3.7-distributed-1.27.1
  ls -la /nix/store/4z3i8bp71gkl6467bybram10va7qk6vx-python3.7-distributed-1.27.1/bin
  ```


  </details>
  <br/>


  cc @teh @costrouc for testing.


state: open
title: [wip] platform.gcc.arch: support for AMD CPUs
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/61019
updated_at: 2019-05-18 04:46:07
body:
  support for AMD CPUs in ```localSystem.hostPlatform.platform.gcc.arch```

  I have (or can rent) a test park of
   - [ ] ```AMD Opteron(tm) X2150 APU``` (corresponds to ```-march=btver2```)
   - [ ] ```AMD Opteron(tm) Processor 3365``` (corresponds to ```-march=bdver2```)
   - [ ] ```AMD EPYC 7401P 24-Core Processor``` (this one is problematic, ```-march=bdver4``` as well as ```-march=znver1``` enable too many features; the GCC flags should be either ```-march=bdver4 -mno-fma4 -mno-tbm -mno-xop -mno-lwp``` or ```-march=znver1 -mno-clzero mno-mwaitx -mno-xsaves```, which is impossible to set within constrains of #59225)
   - [x] ```AMD Ryzen 5 2400G with Radeon Vega Graphics``` (corresponds to ```-march=znver1```)

  cc: @matthewbauer @7c6f434c


state: closed
title: python37Packages.django-cors-headers: 2.5.2 -> 2.5.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61020
updated_at: 2019-05-11 03:00:01
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-django-cors-headers/versions.



  meta.description for python37Packages.django-cors-headers is: '"Django app for handling server Cross-Origin Resource Sharing (CORS) headers"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.5.3 with grep in /nix/store/kiw3h21varg5znvrnhs8zi7wb9h8bfjg-python3.7-django-cors-headers-2.5.3
  - directory tree listing: https://gist.github.com/c0f34a9916609b6fd221750b1ae9722b
  - du listing: https://gist.github.com/0743ba666ef133d89c13e8182d8701eb

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.django-cors-headers
  python37Packages.django-cors-headers

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/kiw3h21varg5znvrnhs8zi7wb9h8bfjg-python3.7-django-cors-headers-2.5.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.django-cors-headers https://github.com/r-ryantm/nixpkgs/archive/9260a4fa28f2931e182809d3ddad7678bdc67542.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/kiw3h21varg5znvrnhs8zi7wb9h8bfjg-python3.7-django-cors-headers-2.5.3
  ls -la /nix/store/kiw3h21varg5znvrnhs8zi7wb9h8bfjg-python3.7-django-cors-headers-2.5.3/bin
  ```


  </details>
  <br/>


  cc @ivegotasthma for testing.


state: closed
title: python37Packages.djangorestframework: 3.9.2 -> 3.9.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61021
updated_at: 2019-05-11 03:00:12
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-djangorestframework/versions.



  meta.description for python37Packages.djangorestframework is: '"Web APIs for Django, made easy"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.9.3 with grep in /nix/store/xl2kf3jzgrlhrxhrang043z1wdqw9p3f-python3.7-djangorestframework-3.9.3
  - directory tree listing: https://gist.github.com/1d2ace4e5efe65b89cf2315279c63ff4
  - du listing: https://gist.github.com/f0d054f2973b93aeaa04fd84771a016e

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  24 total rebuild path(s)

  6 package rebuild(s)

  6 x86_64-linux rebuild(s)
  6 i686-linux rebuild(s)
  6 x86_64-darwin rebuild(s)
  6 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.django-rest-auth
  python27Packages.djangorestframework
  python27Packages.djangorestframework-jwt
  python37Packages.django-rest-auth
  python37Packages.djangorestframework
  python37Packages.djangorestframework-jwt

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/xl2kf3jzgrlhrxhrang043z1wdqw9p3f-python3.7-djangorestframework-3.9.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.djangorestframework https://github.com/r-ryantm/nixpkgs/archive/38af84ad528ca442dc582cef5585690e3d5b22f5.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/xl2kf3jzgrlhrxhrang043z1wdqw9p3f-python3.7-djangorestframework-3.9.3
  ls -la /nix/store/xl2kf3jzgrlhrxhrang043z1wdqw9p3f-python3.7-djangorestframework-3.9.3/bin
  ```


  </details>
  <br/>


  cc @desiderius for testing.


state: closed
title: ruby: install ri docs to devdoc output
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/61022
updated_at: 2019-05-08 12:18:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This allows getting access to Ruby documentation through ri by doing

      nix-shell -p ruby ruby.devdoc

  or by installing the ruby.devdoc package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Cc: @manveru


state: open
title: Kubernetes.addons.dns: Intermittent name resolution with Alpine
user_login: azazel75
html_url: https://github.com/NixOS/nixpkgs/issues/61023
updated_at: 2019-05-06 00:20:53
body:
  ## Issue description
  Hello, 
  I've had some issues with an alpine:3.9 based container. After extensive digging ( see weaveworks/flux#1980 ) I think this is due to alpine's issues with name resolution ( a quick look into the  issues of the docker-alpine project shows that I'm not alone in that).  At this point it's unclear what's happening, I've tried to upgrade CoreDNS to 1.5.0 but the issue it's still there. 

  It has something to do with the searches into the declared domain (this is the file `/etc/resolv.conf`):
  ```
  # cat /etc/resolv.conf 
  nameserver 10.0.0.254
  search default.svc.cluster.local svc.cluster.local cluster.local foo.it
  options ndots:5
  ```

  Other base images like Busybox or Debian seems not to be affected by this 

  ### Steps to reproduce
  in my case:
  ```
  $ kubectl run -i --tty --image-pull-policy=Always --image alpine:3.9 dns-tests --restart=Never --rm /bin/sh
  If you don't see a command prompt, try pressing enter.
  / # ping -c 1 gitlab.com
  ping: bad address 'gitlab.com'
  / # ping -c 1 pippo.it
  ping: bad address 'pippo.it'
  # nslookup gitlab.com
  nslookup: can't resolve '(null)': Name does not resolve

  nslookup: can't resolve 'gitlab.com': Name does not resolve
  ```

  but explictly making the resolution absolute does the trick:
  ```
  / # nslookup gitlab.com.
  nslookup: can't resolve '(null)': Name does not resolve

  Name:      gitlab.com.
  Address 1: 35.231.145.151 151.145.231.35.bc.googleusercontent.com
  / # ping -c 1  gitlab.com.
  PING gitlab.com. (35.231.145.151): 56 data bytes
  64 bytes from 35.231.145.151: seq=0 ttl=42 time=103.690 ms

  --- gitlab.com. ping statistics ---
  1 packets transmitted, 1 packets received, 0% packet loss
  round-trip min/avg/max = 103.690/103.690/103.690 ms
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.03pre-git (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172477.8838032e905"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  K8s is installed from unstable:
  ```
  $ kubectl version
  Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"archive", BuildDate:"1970-01-01T00:00:01Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
  Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.0", GitCommit:"641856db18352033a0d96dbc99153fa3b27298e5", GitTreeState:"archive", BuildDate:"1970-01-01T00:00:01Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
  ```


state: closed
title: python37Packages.flask-pymongo: 2.2.0 -> 2.3.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61024
updated_at: 2019-05-11 02:59:29
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-flask-pymongo/versions.



  meta.description for python37Packages.flask-pymongo is: '"PyMongo support for Flask applications"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.3.0 with grep in /nix/store/z7sxixkg9prz0gfwfj9i2m5x2nhkxkcw-python3.7-Flask-PyMongo-2.3.0
  - directory tree listing: https://gist.github.com/161ff1770009ebbdc7f54f41ae21d572
  - du listing: https://gist.github.com/bdf423973b90ee030766495aabe7780c

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.flask-pymongo
  python37Packages.flask-pymongo

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/z7sxixkg9prz0gfwfj9i2m5x2nhkxkcw-python3.7-Flask-PyMongo-2.3.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.flask-pymongo https://github.com/r-ryantm/nixpkgs/archive/686975479e82e0aca7aabe064598d10ace200b28.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/z7sxixkg9prz0gfwfj9i2m5x2nhkxkcw-python3.7-Flask-PyMongo-2.3.0
  ls -la /nix/store/z7sxixkg9prz0gfwfj9i2m5x2nhkxkcw-python3.7-Flask-PyMongo-2.3.0/bin
  ```


  </details>
  <br/>


state: closed
title: nixos/kubernetes: upgrade CoreDNS 1.3.1 -> 1.5.0
user_login: azazel75
html_url: https://github.com/NixOS/nixpkgs/pull/61025
updated_at: 2019-05-18 09:19:05
body:
  ###### Motivation for this change
  Upgrade the installed version of the Kubernetes cluster dns service.  I was trying to solve #61023 which describes an issue with intermittent name resolution failure on alpine. When I saw that 1.3.1 is almost five months old I decided to try with this upgrade

  There has been a slightly change in the configuration of the service.  The the container failed  to start with the `proxy`. As it appears, [*proxy* plugin has been moved to to the external plugins](https://coredns.io/2019/03/03/coredns-1.4.0-release/) in 1.4.0 and `forward` can be used in its place. Also it's what the [default configuration of coredns](https://github.com/coredns/deployment/blob/master/kubernetes/coredns.yaml.sed#L64) is using.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37Packages.geoalchemy2: 0.6.1 -> 0.6.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/61026
updated_at: 2019-05-11 02:59:32
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-geoalchemy2/versions.



  meta.description for python37Packages.geoalchemy2 is: '"Toolkit for working with spatial databases"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.6.2 with grep in /nix/store/hx72fhq7lx5ik4lavgxsn1sf6m3874p3-python3.7-GeoAlchemy2-0.6.2
  - directory tree listing: https://gist.github.com/005119a94595b3f6fe7610fbcf127655
  - du listing: https://gist.github.com/0ad7d2b0274dcc7e07419fc584bf0190

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.geoalchemy2
  python37Packages.geoalchemy2

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/hx72fhq7lx5ik4lavgxsn1sf6m3874p3-python3.7-GeoAlchemy2-0.6.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.geoalchemy2 https://github.com/r-ryantm/nixpkgs/archive/effdf1bf3bd3e1fc8f6516a254ca93356590a4eb.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/hx72fhq7lx5ik4lavgxsn1sf6m3874p3-python3.7-GeoAlchemy2-0.6.2
  ls -la /nix/store/hx72fhq7lx5ik4lavgxsn1sf6m3874p3-python3.7-GeoAlchemy2-0.6.2/bin
  ```


  </details>
  <br/>


state: closed
title: Failed to install pipenv on unstable
user_login: greydot
html_url: https://github.com/NixOS/nixpkgs/issues/61027
updated_at: 2019-05-07 04:53:20
body:
  ## Issue description
  Pipenv fails to install due to "No matching distribution found for virtualenv-clone>=0.2.5 (from pipenv==2018.11.26)"
  Full output is here https://bpaste.net/show/d6941ff5a447

  ### Steps to reproduce
  Run `nix-shell -p pipenv`


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37, NixOS, 19.09pre178260.190727db4ea (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(void): `"nixpkgs-19.09pre178484.8bc70c937b3"`
   - channels(root): `"nixos-19.09pre178260.190727db4ea, nixpkgs-19.09pre178484.8bc70c937b3"`
   - nixpkgs: `/home/void/.nix-defexpr/channels/nixpkgs`


state: closed
title: cedille: fix hash
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61028
updated_at: 2019-05-07 23:40:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Cedille retagged v.1.1.1 https://github.com/cedille/cedille/releases/tag/v1.1.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: utillinux: 2.33.1 -> 2.33.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61030
updated_at: 2019-05-07 15:57:57
body:
  ###### Motivation for this change

  Minor bump, announcement:

  https://lkml.org/lkml/2019/4/9/474

  Minor touchup while visiting.

  2.34-rc1 was tagged 2019-04-30, FWIW,
  but no clue if that indicates anything :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dhcpcd: 7.2.1 -> 7.2.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61031
updated_at: 2019-05-06 18:48:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://roy.marples.name/archives/dhcpcd-discuss/0002428.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rngd: harden service config, settings from arch
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61032
updated_at: 2019-05-11 21:36:58
body:
  ###### Motivation for this change

  Noticed while investigating behavior by comparing
  settings used across distributions.

  Conceivably impacts anyone using NIST beacon or something (?!)
  but that's not a supported configuration anyway AFAIK.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.imread: 0.6 -> 0.7.0
user_login: luispedro
html_url: https://github.com/NixOS/nixpkgs/pull/61033
updated_at: 2019-07-10 09:44:49
body:
  Mostly trivial update of version and hashes, but also explicitly use the
  right dependencies

  ###### Motivation for this change

  Updates imread to latest version.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
        - [x] other Linux distributions


state: closed
title: firefox-bin: 66.0.3 -> 66.0.4, firefox-esr: 60.6.1esr -> 60.6.2esr
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/61034
updated_at: 2019-05-06 11:20:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Repaired certificate chain to re-enable web extensions that had been disabled

  https://www.mozilla.org/en-US/firefox/66.0.4/releasenotes/
  https://www.mozilla.org/en-US/firefox/60.6.2/releasenotes/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Tested only `firefox-bin`.

  `firefox` is updated by 1f6ddfc7e039e0f1003116b8e9e7110f363e26e2.

  ---


state: open
title: perlPackages.Po4a affects g++
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/issues/61035
updated_at: 2019-05-09 14:23:24
body:
  ## Issue description
  Adding `perlPackages.Po4a` changes which `g++` is used.
  I encountered it when trying to write a derivation which requires the `po4a-translate` command. But when I add `perlPackages.Po4a` to the `nativeBuildInputs` the C++ compiler is different and the project won't build anymore.
  Can be reproduced in the nix-shell as well.


  ### Steps to reproduce
  ```
  $ readlink -f $(which g++)
  /nix/store/w2px3blinprrzx6wva8x7m0l9l27jzj9-gcc-wrapper-7.4.0/bin/g++
  $ nix-shell -p perlPackages.Po4a
  $ readlink -f $(which g++)
  /nix/store/y60j0zq2j50iaaqjn39i18hkhp277zfy-gcc-wrapper-7.4.0/bin/g++
  ```


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.7, NixOS, 19.09pre177249.dfd8f84aef1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/store/vw34y7p1zml11w2cdsj4a6afgkj2w4pw-source`

  My version of NixOS is equivalent to [this](https://github.com/NixOS/nixpkgs-channels/commit/dfd8f84aef1) tree of nixpkgs-unstable.


state: closed
title: nixos/systemd-boot: add support for memtest86 EFI app
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/61036
updated_at: 2019-05-21 02:51:08
body:
  This commit adds support for installing the memtest86 EFI app and adding a boot entry for it with systemd-boot.

  In order to test this, you can set the following in `/etc/nixos/configuration.nix`:

  ```nix
  { config, pkgs, ...}:

  {
    boot.loader.systemd-boot.memtest86.enable = true;
  }
  ```

  This should work as long as you have `boot.loader.systemd-boot.enable` set to `true`.

  You'll also need `allowUnfree` set to `true`, since memtest86 is not open source.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I wanted a way to install memtest86 easily from NixOS.  This is a follow-up of #60967.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Adds pkgsCross.gnu32 and pkgsCross.gnu64 platforms
user_login: lionello
html_url: https://github.com/NixOS/nixpkgs/pull/61038
updated_at: 2019-05-09 23:17:23
body:
  ###### Motivation for this change

  Current Nixpkgs has many platforms listed under `pkgsCross` as targets, except the most common `x86_64-unknown-linux-gnu` and `i686-unknown-linux-gnu`. This MR adds those two for cross compiling *to* linux from, for example, Darwin. 

  For successful cross compiling, one of the first things that needs to be fixed is `binutils`, which currently does't compile on Darwin, so this MR alone does not help yet.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libnsl: 1.1.0 -> 1.2.0, drop included patches
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61039
updated_at: 2019-05-12 08:00:26
body:
  ###### Motivation for this change

  Prefer released version rather than vendored patches :).

  (release also touches up its pkgconfig files re:libtirpc)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jo: 1.1 -> 1.2
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/61040
updated_at: 2019-05-09 05:56:53
body:
  The "src.rev" was changed because upstream tag does not have the "v"
  prefix for this version.

  A little bit of code formatting was done as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions (centos 7)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] firefox-bin: 66.0.3 -> 66.0.4
user_login: tokudan
html_url: https://github.com/NixOS/nixpkgs/pull/61041
updated_at: 2019-05-06 15:44:24
body:
  (cherry picked from commit ad042f186f4242f9689805884914fd2ec9f52955)

  ###### Motivation for this change

  firefox-bin hasn't been updated by @edolstra, so this PR fixes this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-bloat: 0.6.2 -> 0.6.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/61042
updated_at: 2019-05-07 03:08:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-bloat` to the latest release.
  https://github.com/RazrFalcon/cargo-bloat/releases/tag/v0.6.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: awesome: refactor LUA_PATH env var and don't expose it at runtime (19.03 branch)
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/pull/61043
updated_at: 2019-05-07 07:39:26
body:
  Cherry-picked  c973e15fb6f to fix #60232 in the 19.03 branch. Hope this is the right way to do it. Thanks.

  This commit partly reinstates changes from 5465d6f that had been somehow
  reverted in 17d3eb2.  Also, a comment has been added in the hope that future
  changes won't do the same.

  Additionally, refactor the LUA_PATH env var to ensure that the internal lgi lua
  files can't be required explicitly and to avoid possible name clashes (this
  fixes issue #60232).

  Finally, rather than using prepending `?.lua` append `;;` to LUA_PATH. Quoting
  @psychon:

  > This is interpreted by Lua as "add the default search path here" (which does
  > indeed contain ?.lua, but also contains more).

  Testing done:

  - Build with `nix-build -I /path/to/repo -A awesome`
  - Start an X session with xterm only
  - Start xephyr, e.g. `Xephyr :1 -name xephyr -screen 512x384 -ac -br -noreset &`
  - Run awesome like `DISPLAY=:1.0 ./result/bin/awesome`. Additionally, add
    `--search` options to expose lua modules that have a name clash with lgi's
    internal ones (see #60232 for more details) and `require` them in `rc.lua` to
    prove that they are loaded correctly

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pipenv: fix missing dependency issue (#61027)
user_login: greydot
html_url: https://github.com/NixOS/nixpkgs/pull/61044
updated_at: 2019-05-15 14:12:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fix https://github.com/NixOS/nixpkgs/issues/61027

  ###### Things done
  Added missing package to propagatedBuildInputs.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elasticsearchPlugins: fix plugins, add s3-repository and gcs-repository plugin
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/pull/61045
updated_at: 2019-05-11 18:01:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixing of elasticsearch plugins and s3 and gcs repo integration

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages: enable on platforms where PostgreSQL is supported
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61046
updated_at: 2019-05-06 13:42:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  These packages are also supported on darwin.
  plv8, postgis, and pgrouting are also supposed to work on darwin, but needs a bit of work to enable them on darwin

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.seabreeze: init at 0.6.0
user_login: sjmackenzie
html_url: https://github.com/NixOS/nixpkgs/pull/61047
updated_at: 2019-05-09 04:28:24
body:
  ###### Motivation for this change
  Need to interface with a spectrometer

  ###### Things done
  added a python package 

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zmap: init at 2.1.1
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/61048
updated_at: 2019-05-10 20:38:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  zmap[1] is a fast network scanner for the IPv4 address space. This is
  the main package of the ZMap projects, there are further one that will
  be packaged soon.

  [1]: https://zmap.io/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doc/stdenv: put note about remote builds with breakpointHook into a <note>
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/61049
updated_at: 2019-05-07 21:55:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  With remote builds, the sandbox can't be accessed by `cntr` as it is on
  a different machine. I decided to document this in the manual as it took
  me admittedly too much time to figure this out.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pfstools: build pfsalign (fix #60843)
user_login: juliendehos
html_url: https://github.com/NixOS/nixpkgs/pull/61050
updated_at: 2019-05-13 08:15:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix #60843

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/prosody: add authentication option (fixes #53134)
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/pull/61051
updated_at: 2019-05-24 22:17:14
body:
  Replaces #53308

  Passwords should not be stored in plain text by default. On existing
  installations the next time a users user accounts will automatically
  be upgraded from plain to hashed one-by-one as they log in.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trivial-builders: add writeShellScript and minor cleaning
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/pull/61052
updated_at: 2019-05-12 17:55:21
body:
  Add writeShellScript
  Small whitespace additions
  Fix "Example:" docstring sections for some of the writeScript functions to use the correct function

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vokoscreen-beta: init at 2.5.8
user_login: GRBurst
html_url: https://github.com/NixOS/nixpkgs/pull/61053
updated_at: 2019-05-15 10:32:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Only the stable version of vokoscreen is available, but is missing multiple features that I needed.
  I already build and installed it locally and used it multiple times successfully :-)
  I guess it could be bundled with the stable version, but this may be more reasonable when the beta and stable version will be maintained continuously.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: curaLulzbot: 15.02.1-1.03-5064 -> 3.6.13
user_login: charles-dyfis-net
html_url: https://github.com/NixOS/nixpkgs/pull/61054
updated_at: 2019-07-13 21:17:49
body:
  ###### Motivation for this change

  Move Cura Lulzbot Edition to be based on the same generation of the codebase as the upstream (Ultimaker) branch, away from a many-year-old legacy tree.

  Since prior Lulzbot Edition packaging simply wrapped binaries unpacked from Debian binary packages, doing this right requires forking the same dependencies that Lulzbot has branched themselves as well.

  cc: @pjones, @abbradar, @orivej -- I didn't assume that anyone listed as a maintainer for upstream Cura and dependencies also wanted to own the lulzbot edition, but if anyone *does* want to be in the list, I'd be glad to not be there alone. :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  Resolves: #64469


state: closed
title: qscintilla: fix dylib names on Darwin
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/61056
updated_at: 2019-05-07 11:11:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  On Darwin dylibs are intended to have their install names set to their absolute path. Without an absolute path, applications using these libraries will have invalid references embedded, and will be unable to locate the libraries at runtime.

  Before
  ```
  $ otool -D $(nix-build channel:nixos-unstable -A qscintilla)/lib/libqscintilla2.dylib | tail -n 1
  libqscintilla2.12.dylib
  ```

  After
  ```
  $ otool -D $(nix-build . -A qscintilla)/lib/libqscintilla2.dylib | tail -n 1
  /nix/store/n72ds0cqcnpkq9066lxjas2k814j4i79-qscintilla-qt4-2.9.4/lib/libqscintilla2.12.0.2.dylib
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: i3status-rust: 0.9.0.2019-03-21 -> 0.9.0.2019-04-27
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/61057
updated_at: 2019-05-08 07:59:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/greshake/i3status-rust/compare/18300e6b...d04d08cb

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @backuitist


state: closed
title: Added EnableTextMode Dwarf Fortress for playing CLI
user_login: TrevtheForthDev
html_url: https://github.com/NixOS/nixpkgs/pull/61058
updated_at: 2019-05-09 09:25:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Wanted to play Dwarf Fortress in CLI so I could SSH on my phone and play it. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [*] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [* ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [* ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [*] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [*] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hdf4: fix tests on some machines
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/61059
updated_at: 2019-05-13 02:14:23
body:
  ###### Motivation for this change

  The hdf4 package has some problems with tests failing on certain machines. Based on my testing, a particular machine will either fail or pass reliably. I have not seen any transient failures.

  I discovered this issue because the Hydra builder ["ike" failed to build this package](https://hydra.nixos.org/build/92714668/nixlog/1) and therefore one of my builders attempted to build it and also failed. The build [previously succeeded on builder "t4a"](https://hydra.nixos.org/build/92341034/nixlog/3). I tested both commits, and both times was able to reproduce the failure, meaning that this is not a regression.

  Here are the results of tests on different machines:

  | Status | CPU | OS | Cores |
  :-------:|-------|-----|-----|
  | :heavy_check_mark: | i7-6700HQ | Arch Linux | 8 |
  | :heavy_check_mark: | Xeon E5-1620 v2 | NixOS | 8 |
  | :x: | Xeon E5-2640 v4 | Ubuntu 18.04 | 40 |
  | :x: | Xeon E5-2620 | Ubuntu 18.04 | 24 |
  | :x: | Xeon E5-2623 v3 | Fedora 30 | 16 |
  | :x: | Xeon E5-2660 v3 | Fedora 29 | 40 |
  | :x: | Xeon E5-2623 v3 | Fedora 24 | 16 |

  All of these test were done with sandboxing enabled.

  ###### Things done

  Interestingly, the most reliable way I can find to fix the tests is to enable all the tests. The tests that were previously disabled pass on all machines I was able to test, including armv7l and aarch64, and they seem to make the other failing tests pass as well. I was not able to test macOS, but that can be done by ofborg.

  I'm not sure what's going on here, but I suspect it fails on machines that have large numbers of cores, maybe due to a race condition.

  cc @knedlsepp

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: awesome: use makeWrapper rather than wrapProgram
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/pull/61060
updated_at: 2019-05-08 20:48:33
body:
  ###### Motivation for this change

  Using wrapProgram makes so that the generated "awesome" wrapper duplicates its
  command line options at every restart. This fixes #60229.

  As @psychon puts it:

  > AwesomeWM restarts via execvp(argv[0], argv). In NixOS, wrapProgram is used
  > to generate a wrapper around the real binary. wrapProgram calls makeWrapper
  > with --argv0 '$0'. I guess this is what makes awesomeWM run the wrapper again
  > on restart. Without this --argv0 awesomeWM would directly restart itself
  > instead of the wrapper, I think.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-co###### Motivation for this changentributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcc-arm-embedded: add darwin support
user_login: witkamp
html_url: https://github.com/NixOS/nixpkgs/pull/61061
updated_at: 2019-05-07 16:21:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This change was in 18.09 but was not merged into 19.03

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.lark-parser: enable majority of tests
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/61062
updated_at: 2019-05-11 21:02:33
body:
  ###### Motivation for this change
  ~This is a draft PR because it sits on top of https://github.com/NixOS/nixpkgs/pull/59661 - will rebase once that's merged.~ Done.

  Looks like most of `lark-parser`'s tests are fine, we just have to disable the tests of `Nearley.js` support.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update ultrastar creator and manager
user_login: Profpatsch
html_url: https://github.com/NixOS/nixpkgs/pull/61063
updated_at: 2019-05-07 00:02:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update broken versions (libbass, qt changed interface)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: influxdb: 1.7.5 -> 1.7.6
user_login: mstojcevich
html_url: https://github.com/NixOS/nixpkgs/pull/61064
updated_at: 2019-05-07 05:33:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Just a straightforward version bump.

  This version fixes a bug I was running into: https://github.com/influxdata/influxdb/issues/13010

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doge: init at 3.5.0
user_login: Gonzih
html_url: https://github.com/NixOS/nixpkgs/pull/61065
updated_at: 2019-05-07 19:31:11
body:
  ###### Motivation for this change
  Adding the most important tool without which workflow in terminal is almost impossible.

  The `doge` utility.

  ![doge](https://user-images.githubusercontent.com/266275/57262878-1ee23280-703c-11e9-9973-578911077665.png)


  ###### Things done


  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.leveldb: init at 0.194
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/61066
updated_at: 2019-05-11 01:06:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  http://chriswarbo.net/blog/2018-05-02-fixing_leveldb.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: haskell: add a callStack2nix function
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/61067
updated_at: 2019-06-04 17:39:06
body:
  `callStack2nix` is a function similar to `callCabal2nix`, but instead of just creating a .nix file for a single Haskell package, it creates a whole overlay based on an Stackage LTS resolver.

  This makes it very easy to build a Stack-based Haskell project with Nix.

  `callStack2nix` uses the `stack2nix` tool to produce a `.nix` file as output.  You can see an example of what one of these files look like in the `stack2nix` repo:

  https://raw.githubusercontent.com/input-output-hk/stack2nix/1143ceb8b395478d4e5bc8d2b0b0dee19e2f140a/stack2nix.nix

  There is another function, `callStack2nixPkgSet`, that actually does the import-from-derivation so that the package set produced from `callStack2nix` is usable.

  There is an example in the documentation, but here is a another example:

  ```nix
  let
    src = fetchFromGitHub {
      owner = "chrisdone";
      repo = "intero";
      rev = "8da81244783fbf03afb49660423c875f2e874fba";
      sha256 = "17vibxapzp4wf0dfc56x98wsf3wy98ghj5h10nyf7xcfwy6k0rja";
    };

    interoPkgSet = haskellPackages.callStack2nixPkgSet {
      name = "intero";
      inherit src;
      sha256 = "163mmyl1c718g3i5r7djr4x2m07id190zb3pjl69flh0wyxwzzzc";
      hackageSnapshotTimestamp = "2019-04-16T00:00:00Z";
      haskellPackagesCompiler = pkgs.haskell.packages.ghc822;
      doCheck = false;
      doHaddock = false;
    };

  in

  interoPkgSet.intero
  ```

  This example demonstrates using `callStack2nixPkgSet` to easily build the [intero](https://github.com/chrisdone/intero) tool.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I wanted an easy way to build a stack-based Haskell project with nix.

  Every once in a while it comes up on the issue tracker or IRC that someone wants an easy way to build a Stack-based Haskell project with nix, and there is currently no way to do this.  I think it would be nice to have a short-and-sweet method for doing this in nixpkgs.

  There are a few alternatives (like using `stack2nix` by hand to generate a package set, using `haskell.nix`, etc), but they all require more work and additional understanding to use.

  Pinging @peti. I opened this as a PR against `master`, because it doesn't really affect any of the other Haskell stuff, but I can always rebase it against the `haskell-updates` branch if this is easier.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sierra-gtk-theme: 2018-10-12 -> 2019-05-07
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/61068
updated_at: 2019-05-07 15:10:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [2019-05-07](https://github.com/vinceliuice/Sierra-gtk-theme/releases/tag/2019-05-07).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: public-sans: init at 1.002
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61069
updated_at: 2019-05-08 03:34:05
body:
  ###### Motivation for this change

  Open font! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libreoffice-fresh: 6.2.2.2 -> 6.2.3.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61070
updated_at: 2019-05-07 05:16:56
body:
  ###### Motivation for this change

  Bump! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - well most, anyway :).
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: creduce: 2.8.0 -> 2.9.0, llvm7
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61071
updated_at: 2019-05-07 09:05:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Harder, better, faster, stronger.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rngd: add option to run w/debug flag
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61072
updated_at: 2019-05-07 19:59:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Added while testing if adding hardening
  directives to the service blocked access
  to various sources, might be useful in the future.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mpv: fix darwin build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61073
updated_at: 2019-05-07 05:59:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  `nv-codec-headers` is only supported on Linux & windows

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages.timescaledb: 1.2.2 -> 1.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61074
updated_at: 2019-05-07 08:54:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/timescale/timescaledb/releases/tag/1.3.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flow: 0.98.0 -> 0.98.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61075
updated_at: 2019-05-07 06:16:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  changelog: https://github.com/facebook/flow/releases/tag/v0.98.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux_5_0: restore __kernel_fpu_{begin,restore}
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/61076
updated_at: 2019-06-22 11:11:45
body:
  In 5.0er these function were removed from the public interface also zfs needs
  them for AVX/AES-NI support. Without this patch for example throughput on a
  encrypted zfs dataset drops to 200 MB/s from 1.2 GB/s. These functions were
  removed as there was no user within the linux kernel tree itself.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: partitionmanager,kpmcore: 3.3.{0,1} -> 4.0.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61077
updated_at: 2019-06-20 15:48:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://stikonas.eu/wordpress/2019/05/02/kde-partition-manager-4-0/

  I've had some trouble with the permissions/auth situation,
  even running it as root doesn't seem to work?

  This may be my environment, but should hold off merging until
  someone reports the updated versions are working for them
  or I sort out what's going on locally :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: zerotierone doesn't leave networks if they are removed from nix config
user_login: wucke13
html_url: https://github.com/NixOS/nixpkgs/issues/61079
updated_at: 2019-05-07 08:53:57
body:
  ## Issue description
  Once a network was added, it must be manually removed by `sudo zerotier-cli leave $NETWORK_ID`. I think it would be preferable for the relevant module to remove all not explicitly listed networks - otherwise this config option won't be pure even after the initial generation of a peer id.

  ### Steps to reproduce

  1. Add a new network to `services.zerotierone.joinNetworks`
  2. `nixos-rebuild test`
  3. Remove the network from `services.zerotierone.joinNetworks`
  4. `nixos-rebuild test`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37, NixOS, 19.03.172470.a177da6b86e (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172470.a177da6b86e"`
   - channels(wucke13): `"nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: jellyfin: remove assertion if emby enabled: no emby module exists
user_login: DIzFer
html_url: https://github.com/NixOS/nixpkgs/pull/61080
updated_at: 2019-05-08 08:50:35
body:
  ###### Motivation for this change
  Jellyfin replaced the emby module, however the used PR expected the emby module to exist, and therefore had an assertion when `!config.services.emby.enable`, which prevents NixOS from rebuilding because there's no emby attribute in config.services.

  This commit removes such assertion, allowing jellyfin to be used again.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.elpi: 1.1.0 -> 1.2.0
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/61081
updated_at: 2019-05-11 20:59:35
body:
  ###### Motivation for this change

  Fixes and improvements: https://github.com/LPCIC/elpi/blob/master/Changelog.md#version-12-april-2019

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pfstools: add netpbm support (fix #60841)
user_login: juliendehos
html_url: https://github.com/NixOS/nixpkgs/pull/61083
updated_at: 2019-05-13 08:28:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  fix #60841

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.datasette: init at 0.27
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/61085
updated_at: 2019-05-08 23:20:57
body:
  ###### Motivation for this change

  Inspired by pycon talk about web server for sqlite databases

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Batch of cross compilation fixes
user_login: globin
html_url: https://github.com/NixOS/nixpkgs/pull/61086
updated_at: 2019-05-08 20:07:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix cross builds

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qutebrowser: 1.6.1 -> 1.6.2
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/61087
updated_at: 2019-05-07 19:06:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://lists.schokokeks.org/pipermail/qutebrowser/2019-May/000622.html


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opencsg: Darwin support and tidy
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/61088
updated_at: 2019-05-08 03:57:48
body:
  Regenerate the Makefiles using qmake to set the correct compiler and
  use the default installPhase.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Working towards building openscad for Darwin.

  The install name handling here is rather unpleasant. The library is ultimately corrected in the fixup phase by the hook, however the example application is already linked by then. Suggestions for improvement welcome.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: Fix Docker layers order
user_login: nlewo
html_url: https://github.com/NixOS/nixpkgs/pull/61089
updated_at: 2019-05-13 13:45:06
body:
  The layer order was not correct when a parent image was used: parent
  image layers were above the new created layer.

  This commits simplifies the code related to layer ordering. In
  particular, layers in `layer-list` are ordered from bottom-most to
  top-most. This is also the order of layers in the `rootfs.diff_ids`
  attribute of the image configuration.

  A test is added to avoid such kind of issues in the future.

  ###### Motivation for this change
  Fix bad behavior of our Docker tooling.



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Jetbrains IDEs
user_login: baracoder
html_url: https://github.com/NixOS/nixpkgs/pull/61090
updated_at: 2019-05-07 20:53:40
body:
  cc maintainers @miltador @loskutov 
  cc @MP2E @flokli @Mic92  who merged similar PRs

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Rider 2019 release, 
  Semi automatic update using update.pl

  ###### Things done

  Tested Rider, so far everything is to working as before.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rgbds: 0.2.4 -> 0.3.8
user_login: lfont
html_url: https://github.com/NixOS/nixpkgs/pull/61091
updated_at: 2019-05-07 18:56:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Switch to the new GitHub organization.
  - Updated to the latest published version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gpsbabel: 1.5.4 -> 1.6.0
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/61092
updated_at: 2019-05-07 20:31:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parinfer-rust: init at 0.3.1
user_login: eraserhd
html_url: https://github.com/NixOS/nixpkgs/pull/61093
updated_at: 2019-05-07 20:37:19
body:
  ###### Motivation for this change

  I'm the maintainer for parinfer-rust and will be relying on nix and NixOS from
  my dotfiles repo to configure my environment.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
    **(New package, no dependencies)**
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
    **Size: 29328840**
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.macropy: init at 1.10b2
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/61094
updated_at: 2019-05-20 13:19:29
body:
  ###### Motivation for this change

  Use macropy to abuse python syntax

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: systemd: Don't order systemd-user-sessions.service after network.target
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/pull/61098
updated_at: 2019-07-11 11:26:43
body:
  Fix delayed startups waiting for DHCP, see #60900

  The startup time issue seems much more annoying to me than the original SSH session issue, so I think we should merge this now. If others disagree, I guess we wait until we have a proper fix for the latter.

  ###### Motivation for this change
  Improve boot times for local NixOS users.

  ###### Things done

  I tested by overriding the package in `configuration.nix`:
  ```
  systemd.package = pkgs.callPackage /home/craig/nixpkgs/pkgs/os-specific/linux/systemd/default.nix {};
  ```


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.streamz: fix checks failures
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/61099
updated_at: 2019-05-07 21:03:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  streamz-dataframe tests are failing consistently
  -> remove them for now
  cc @costrouc 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virtualbox: python2 -> python3
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/61100
updated_at: 2019-05-10 12:54:57
body:
  ###### Motivation for this change

  I wasn't thrilled to see python2 in my system's runtime closure, so I fixed its only reference.

  [Also python2 is almost dead.](https://pythonclock.org/)

  I ran all the NixOS tests for Virtualbox on x86_64-linux, and they all passed.


state: closed
title: pythonPackages.tess: init at unstable-2019-05-07
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/61101
updated_at: 2019-05-08 04:02:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Used Tess for some graduate work a few years ago.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: x265: 2.9 -> 3.0
user_login: jlesquembre
html_url: https://github.com/NixOS/nixpkgs/pull/61103
updated_at: 2019-05-24 18:53:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update to 3.0

  Also, since version 2.6, x265 it's using `nasm` instead of `yasm`, see https://bitbucket.org/multicoreware/x265/src/feec4bdf98663ac4a2561b63e1ccec423c7d26a4/build/README.txt#lines-37
  That means that the x265 version from nix, wasn't using any of the CPU optimizations

  I also compiled with NUMA support by default. Not 100% sure, but it seems that NUMA systems will get a big performance win, while for non NUMA systems this change should be un-noticeable. For more info see:
  https://bitbucket.org/multicoreware/x265/commits/62b8fe990df5e560834e9b567a913238d8dd398e
  https://bitbucket.org/multicoreware/x265/issues/108/numa-pools

  I compressed a short video (~1 minute) with the same options, and the performance change was huge, it went down from 22 to 8 minutes

  ###### Things done


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/plasma5: Remove phonon-backend-gstreamer pinned to Qt 5.6
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/61104
updated_at: 2019-05-30 20:17:29
body:
  Adds closure size for seemingly no reason

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @bkchr @matthewbauer 


state: open
title: teamviewer: Build with latest qt5
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/61105
updated_at: 2019-06-17 18:30:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  See https://github.com/NixOS/nixpkgs/issues/33798

  Seems to work fine for me though I haven't tested connecting to anyone as I don't use teamviewer myself.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @jagajaga 


state: closed
title: statik doesn't evaluate for some reason
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/issues/61106
updated_at: 2019-05-11 15:42:06
body:
  ## Issue description
  meguca, which relies on it builds fine, but when using say, `nix-shell -p go nodejs emscripten gcc gnumake cmake pkgconfig go-bindata easyjson quicktemplate ffmpeg-full graphicsmagick ghostscript opencv statik`, we get this `error: undefined variable 'statik' at (string):1:251`

  I can't figure out why this is happening, as it's properly defined, or at least it seems to be in all-packages.nix


  ### Steps to reproduce
  See above.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.13, NixOS, 19.09pre178795.2ec5e9595be (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178795.2ec5e9595be, nixpkgs-19.09pre178484.8bc70c937b3"`
   - channels(okina): `"nixos-19.03pre166449.be445a9074f, nixpkgs-19.03pre166583.872502aa56b"`
   - nixpkgs: `/home/okina/.nix-defexpr/channels/nixpkgs`


state: closed
title: mp3cat init at 0.5
user_login: OmnipotentEntity
html_url: https://github.com/NixOS/nixpkgs/pull/61107
updated_at: 2019-05-12 11:57:41
body:
  Adding package mp3cat, a command line mp3 utility which will concatenate
  multiple mp3 files, and keep only the audio frames, discarding headers
  and so on.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  It's a reasonably useful single use utility.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bpftool: init at 5.1.1
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/61108
updated_at: 2019-05-13 03:13:40
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mkclean: init at 0.8.10
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/61109
updated_at: 2019-05-12 20:43:30
body:
  ###### Motivation for this change
  Add support for the mkclean tool which is very useful for cleaning up and improving the playback success rate of MKV files on platforms like Plex, etc.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.faker: fix build
user_login: mmlb
html_url: https://github.com/NixOS/nixpkgs/pull/61110
updated_at: 2019-05-08 01:51:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  pythonPackages.faker no longer builds

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: use llvm6 on darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61112
updated_at: 2019-05-12 19:22:01
body:
  https://hydra.nixos.org/build/92942635

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nethack-qt: use gcc
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61113
updated_at: 2019-05-12 19:22:31
body:
  Relies on gcc being accessible

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ruby: add ruby.withPackages
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/61114
updated_at: 2019-07-05 14:31:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This is mostly open for discussion, it allows usage of `ruby.withPackages` similar to the way python and haskell work.

  It also includes `ruby.gems`, with corresponding `ruby_2_3-gems` `ruby_2_4-gems` `ruby_2_5-gems` `ruby_2_6-gems` attributes in top-level to allow hydra to compile them.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: build the lazy_extractors module to improve startup time
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/61115
updated_at: 2019-05-08 19:22:40
body:
  ###### Motivation for this change

  `youtube-dl` [imports every extractor](https://github.com/ytdl-org/youtube-dl/blob/71ebd35d5003cfc5f4c8518249e03e1da0e620b4/youtube_dl/extractor/__init__.py#L9) it has unless the `youtube_dl/extractor/lazy_extractors.py` module is built.

  This updates nixpkgs' youtube-dl to build the module, improving startup time.

  Testing on an Intel 4790K / NVMe drive:

  before:

  ```
  # time youtube-dl --help > /dev/null
  youtube-dl --help > /dev/null  0.26s user 0.06s system 100% cpu 0.322 total

  # strace youtube-dl 'https://www.youtube.com/watch?v=nJ9IdzcQMoc' 2>&1 | grep extractor/ | grep \.pyc | wc -l
  789
  ```

  after:

  ```
  # time youtube-dl --help > /dev/null
  youtube-dl --help > /dev/null  0.13s user 0.05s system 100% cpu 0.182 total

  # strace youtube-dl 'https://www.youtube.com/watch?v=nJ9IdzcQMoc' 2>&1 | grep extractor/ | grep \.pyc | wc -l
  6
  ```


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: font-awesome: 5.8.1 -> 5.8.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/61117
updated_at: 2019-05-09 02:50:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `font-awesome` to the latest release.
  https://github.com/FortAwesome/Font-Awesome/releases/tag/5.8.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Added database from vim-awesome
user_login: SRGOM
html_url: https://github.com/NixOS/nixpkgs/pull/61118
updated_at: 2019-05-08 02:55:49
body:
  Database url: https://github.com/vim-awesome/vim-awesome/releases/download/v1.2/rethinkdb_dump_2016-04-14.tar.gz

  I added this because I think vim awesome is a great list, they include plugins by using statistics from publicly available dotfiles on github. 

  There are some repos which have duplicate names, e.g. `mileszs/ack.vim` and `tyok/ack.vim`. I am very new to nix so couldn't figure how this would be handled in the derivation generation but if this is going to be an issue then I can remove the duplicates.


state: closed
title: just: 0.4.2 -> 0.4.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/61120
updated_at: 2019-05-08 05:04:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `just` to the latest release.
  https://github.com/casey/just/releases/tag/v0.4.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefoxPackages.tor-browser: 8.0.8 -> 8.0.9
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/61121
updated_at: 2019-05-08 04:44:22
body:
  # `git log`

  - firefoxPackages.tor-browser: 8.0.8 -> 8.0.9

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (2):
      - firefoxPackages.tor-browser
      - tor-browser-bundle
  - On aarch64-linux: ditto
  - On x86_64-darwin:
    - Updated (1):
      - firefoxPackages.tor-browser

  /cc @joachifm


state: closed
title: timescaledb-tune: 0.5.0. -> 0.6.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/61122
updated_at: 2019-05-08 04:23:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changes: https://github.com/timescale/timescaledb-tune/compare/0.5.0...0.6.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Python 3.3 and 3.4 are EOL
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/issues/61123
updated_at: 2019-05-08 04:39:27
body:
  ## Issue description

  + Python 3.3 has reached EOL in September 29, 2017 https://www.python.org/dev/peps/pep-0398/#x-end-of-life
  + Python 3.4 has reached EOL in March 18, 2019 https://www.python.org/dev/peps/pep-0429/

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: Request to package tslint into nodePackages
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/61124
updated_at: 2019-05-10 14:25:38
body:
  Tslint is the primary linter for typescript files now. It's used as part of any typescript project. We have `nodePackages.typescript` but not `nodePackages.tslint`.

  https://github.com/palantir/tslint


state: open
title: X fails to start with modeset(0): failed to set mode: Invalid argument
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/61125
updated_at: 2019-05-08 05:33:44
body:
  ## Issue description

  This is an upstream issue, so I am logging it here in case others are having the same problem.

  Due to changes in X 1.20 and recent kernels, X will in some cases fail to start with ```modeset(0): failed to set mode: Invalid argument ```.

  The workaround: use ```intel``` instead of ```modesetting``` (on intel hardware).

  The kernel is being fixed so 5.1.x should be getting the fix.

  We definitely shouldn't do https://github.com/NixOS/nixpkgs/issues/55520 right now...

  Reference:
  - https://bugs.freedesktop.org/show_bug.cgi?id=109806
  - https://gitlab.freedesktop.org/xorg/xserver/issues/542



  ### Steps to reproduce

  1. Upgrade to latest ```nixos-unstable``` (2019-05-07)
  2. Use the ```modesetting``` driver
  3. Try to run ```sddm```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: taskell: 1.4.2 -> 1.4.3
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/61126
updated_at: 2019-05-15 05:49:04
body:
  ###### Motivation for this change

  Followup for #60363

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions (centos)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go: 1.12.5, 1.11.10
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61127
updated_at: 2019-05-21 10:25:20
body:
  ###### Motivation for this change

  https://groups.google.com/forum/#!topic/golang-dev/QwUlynmpl8A

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lighttpd: fix crosscompilation
user_login: deadloko
html_url: https://github.com/NixOS/nixpkgs/pull/61128
updated_at: 2019-05-09 17:11:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Lighttpd fails to cross compile.

  ###### Things done
  * Added pcre.dev as dependency, lighttpd requeres pcre-config to return lib location and compilation flags (actually just include directory).
  * Added preConfigure export with path to pcre-config.
  * Added stdenv.cc build dependency.
  * Tested (on arm board with services.lightppd.enable = true; services.lightppd.mod_status = true;) that server starts and pages /server-status, /server-config are available.
  * Tested that native compilation still work.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: notmuch: 0.28.3 -> 0.28.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61129
updated_at: 2019-05-08 21:32:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://notmuchmail.org/pipermail/notmuch/2019/027933.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gfortran: many versions
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/issues/61130
updated_at: 2019-05-09 06:34:22
body:
  This is a thread to gather feedback.  I see we have gfortran in five versions ATM, all being built on Hydra (for the two Linux platforms at least): 4.8, 4.9, 5, 6 and the default 7.  I see 8 is missing; I tried 9 would now build by the trivial copy&paste, so I expect we'll add that, but first I suggest revisiting the usefulness of the older versions &ndash; perhaps we should prune at least the set being built on Hydra?

  /cc random people that might be interested: @markuskowa, @ttuegel, @dtzWill.


state: closed
title: firefox: 66.0.4 -> 66.0.5, firefox-bin: 66.0.4 -> 66.0.5, firefox-beta-bin: 67.0b17 -> 670b18
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/61131
updated_at: 2019-05-08 11:21:41
body:
  ###### Motivation for this change

  For the firefox attribute the changelog can be seen at https://blog.mozilla.org/addons/2019/05/04/update-regarding-add-ons-in-firefox/comment-page-5/ It is yet another fixup of the certificate issue that started last week.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/61132
updated_at: 2019-05-08 11:21:49
title:
  [19.03] firefox: 66.0.4 -> 66.0.5, firefox-bin: 66.0.4 -> 66.0.5, firefox-beta-bin: 67.0b7 -> 670b18 

body:
  ###### Motivation for this change

  For the firefox attribute the changelog can be seen at https://blog.mozilla.org/addons/2019/05/04/update-regarding-add-ons-in-firefox/comment-page-5 It is yet another fixup of the certificate issue that started last week.

  Haven't tested yet since the build hasn't finished locally.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: shairport-sync: set sysconfdir to /etc/
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/61133
updated_at: 2019-05-24 21:38:01
body:
  since 2.8.5, shairport-sync uses the directory path sysconfdir to
  determine where to place the configuration file shairport-sync.conf.

  This led to shairport-sync complaining at startup:
  > configuration file name "/nix/store/i8gb0hsb2zczdl8g1h73pbcb952585l9-shairport-sync-3.2.2/etc/shairport-sync.conf" can not be resolved.

  Looking for a configuration file there doesn't make much sense, as we'd
  have to include configuration in the shairport-sync derivation itself.

  By setting sysconfdir to /etc/, shairport-sync will try to read its
  configuration from /etc/shairport-sync.conf, which is a more sane
  default.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: subversion: drop 1.8 / 1.9.9 -> 1.9.10 / 1.11.1 -> 1.12.0
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/61134
updated_at: 2019-05-10 09:20:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - v1.8 has been EOL for some time now
  - v1.9 and v1.10 are LTS and we were not shipping the latest patch version in 1.9.x
  - v1.12 is the new regular release replacing v1.11 (now unsupported)
  - the CPPFLAGS is not needed anymore and svn build fine with current GCC

  Hence the slight simplification of all attributes names declared from `all-packages`
  This mirrors upstream [release planning](https://subversion.apache.org/roadmap.html#release-planning).

  cc @NeQuissimus @lovek323 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kubernetes: bootstrap process is hacked-up together and broken
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/issues/61135
updated_at: 2019-07-08 13:37:42
body:
  ## Issue description

  I thought that we finally were at the point where whole kubernetes nixos module could be said to be stable, but idk why whole bootstrap process had to be so messed up. Sometimes things are supposed to be stateless, and introducing state only presents more problems. Systemd has tools that you can represent dependencies, but `ConditionPathExists` was not designed for this, but purely for disablng/enabling units based on paths. I can say i'm sad (panda), that i would probably replace my k8s tests with something else, as it's not only technical issue, but also the fact, that these changes can be merged into master so easily without even running any tests.

  @srhb @johanot @calbrecht 

  ### Steps to reproduce

  Just run tests and check how it fails.

  ## Technical details

  All custom magic scripts in kubernetes that do `until X; bad-check; done` and all `ConditionPathExists` attempts, and all unnecessary additional targets, that make me a sad panda.

  ### How to improve

  Remove all magic scripts and leave statelessness to do its magic.


state: closed
title: gallery-dl: 1.8.2 -> 1.8.3
user_login: dawidsowa
html_url: https://github.com/NixOS/nixpkgs/pull/61136
updated_at: 2019-05-08 16:05:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update gallery-dl to the latest release
  https://github.com/mikf/gallery-dl/releases/tag/v1.8.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: procs: init at 0.8.5
user_login: dalance
html_url: https://github.com/NixOS/nixpkgs/pull/61137
updated_at: 2019-05-09 00:55:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR adds procs, A modern replacement for ps written by Rust.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Avoid collisions between essential packages
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/61138
updated_at: 2019-05-08 15:42:20
body:
  ###### Motivation for this change
  Fix remaining collision between essential packages.
  See issue #55886.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python-packages: Set pythonPackages attr in pythonPackages scope
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/61139
updated_at: 2019-05-08 21:55:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  If we don't set this we are mixing python versions in the same package.
  Any package called from `python-packages.nix` using `pythonPackages` directly as an argument is currently wrong.

  Before:
  ```
  nix-repl> python3Packages.bugseverywhere.buildInputs
  [ «derivation /nix/store/csd0d2j3vgl5dnag6afi5q92xb64rv7z-python2.7-Jinja2-2.10.1.drv» «derivation /nix/store/gsj389hprxlr8a39b0ccszagirirf1lv-python2.7-cherrypy-17.4.1.drv» «derivation /nix/store/ysmd4wdkbi9gd6bw2ha92hwrd2k2xlnh-python2.7-bootstrapped-pip-19.0.3.drv» ]
  ```

  After:
  ```
  nix-repl> python3Packages.bugseverywhere.buildInputs
  [ «derivation /nix/store/m0mfx1i98ciby8mx8xjva98kinhqkj6r-python3.7-Jinja2-2.10.1.drv» «derivation /nix/store/2gqd0sbiwqmin2814ja83pnyal8pq86a-python3.7-cherrypy-18.1.1.drv» «derivation /nix/store/0rq8n7xq2ksxiq2y2d844i9516p0rd41-python3.7-bootstrapped-pip-19.0.3.drv» ]
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia_x11: 415.27 -> 418.43 - backport from master
user_login: yorickvP
html_url: https://github.com/NixOS/nixpkgs/pull/61140
updated_at: 2019-05-11 22:02:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes https://github.com/NixOS/nixpkgs/issues/57062 on 19.03

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  @grahamcofborg build linuxPackages_latest.nvidiaPackages.stable linuxPackages_5_0.nvidiaPackages.stable linuxPackages.nvidiaPackages.stable linuxPackages.nvidia_x11
  cc @eadwu 


state: open
title: perl-packages: Set perlPackages attr in perlPackages scope
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/61141
updated_at: 2019-05-08 15:22:32
body:
  Adopt python's change from https://github.com/NixOS/nixpkgs/pull/61139
  There is currently no bug to fix, it just makes the things more consistent and prevents hitting the bug in the future


state: open
title: treewide: Make all usage of python2Packages explicit
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/61142
updated_at: 2019-05-10 15:14:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This is in preparation for Python2 going EOL in 2020.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: allow overriding perl528 and perldevel in overlays
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/61143
updated_at: 2019-05-15 22:58:19
body:
  There was a mix of overrideable-in-overlays ```buildPackages.perl528``` & ```buildPackages.perldevel``` and local ```perl528``` & ```perldevel``` which were unaffected by overlays

  just a clean-up, it should not cause any rebuild (if ofborg will found rebuild, then I did something wrong here)


state: open
title: PYTHONPATH is not available in environment when using python.buildEnv or python.withPackages
user_login: aswan89
html_url: https://github.com/NixOS/nixpkgs/issues/61144
updated_at: 2019-05-10 14:25:00
body:
  ## Issue description

  When troubleshooting an issue (rstudio/reticulate#487 ) with the R package reticulate (designed to allow the use of python packages within R) it was discovered that the issue was related to reticulate relying on PYTHONPATH for finding the python packages of interest. 

  This was eventually solved with a call to mkShell and shellHooks to manually set PYTHONPATH but this seems like a counter-intuitive/hacky way to make python packages available to other software within a given environment. 

  I'm far from a competent python developer and I don't have a good understanding of what goes on to wrap python for use within Nix so it may be that there is an existing, less manual method for making python packages available to other software. 

  ### Steps to reproduce

  Current documentation suggests a number of ways to make python package available for development purposes but given that this application required both R and Python a shell.nix file seemed to be the best option. Using this as a shell.nix file:

  ```
  let pkgs = import <nixpkgs> {}; in
    let
    tarPyPacks = pkgs.python3.withPackages (p: [
      p.Keras p.numpy p.tensorflow
    ]);
    tarRPacks = pkgs.rWrapper.override { 
      packages = with pkgs.rPackages; [ 
        reticulate keras tensorflow 
      ];
    };
    in pkgs.mkShell {
      name = "forwardProgress";
      propagatedBuildInputs = [
        tarPyPacks
        tarRPacks
      ];
     }
  ```
  `echo $PYTHONPATH` does not return a value, nor does `os.environ['PYTHONPATH']` from within the python REPL. 

  Attempting to use reticulate functions within the generated environment causes a segfault, though I think that has more to do with their error handling.

  Changing the shell.nix file as follows remedies the problem:

  ```
  let pkgs = import <nixpkgs> {}; in
    let
    tarPyPacks = pkgs.python3.withPackages (p: [
      p.Keras p.numpy p.tensorflow
    ]);
    tarRPacks = pkgs.rWrapper.override { 
      packages = with pkgs.rPackages; [ 
        reticulate keras tensorflow 
      ];
    };
    in pkgs.mkShell {
      name = "forwardProgress";
      propagatedBuildInputs = [
        tarPyPacks
        tarRPacks
      ];
      shellHook = ''
         export PYTHONPATH="${tarPyPacks}/lib/python3.7:${tarPyPacks}/lib/python3.7/site-packages"
       '';
     }
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172500.aade6ded796 (Koi)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172500.aade6ded796"`
   - channels(andrew): `"nixos-18.09beta11.c0bde692f6c"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: AppArmor fails to load with kernel 5.1.0
user_login: attente
html_url: https://github.com/NixOS/nixpkgs/issues/61145
updated_at: 2019-05-13 06:57:15
body:
  ## Issue description

  Upgrading to kernel 5.1.0 from `pkgs.linuxPackages_latest` breaks apparmor, preventing it from loading. Furthermore, this also breaks `nixos-rebuild switch`, requiring a kernel downgrade to `pkgs.linuxPackages_5_0` (kernel 5.0.13) to fix this.

  The error is:

  ```➜  ~ sudo nixos-rebuild switch --upgrade             
  [sudo] password for william: 
  unpacking channels...
  building Nix...
  building the system configuration...
  activating the configuration...
  setting up /etc...
  reloading user units for william...
  setting up tmpfiles
  the following new units were started: cpu-throttling.service
  warning: the following units failed: apparmor.service

  ● apparmor.service
     Loaded: loaded (/nix/store/csxmp1iy3f5ijy8m0ajx6ch5n8milljc-unit-apparmor.service/apparmor.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Wed 2019-05-08 10:29:31 EDT; 17ms ago
    Process: 2996 ExecStart=/nix/store/5v3ysffjypsndwxkh16byzaa3g55lz4g-apparmor-parser-2.13.1/bin/apparmor_parser -rKv -I /nix/store/gj3zvpgbsnx85nbbrpb5s2kjz4y85w80-apparmor-profiles-2.13.1/etc/apparmor.d -I /nix/store/pmgymay0liaz5xy65z9n029v2qn6k79v-lxc-3.1.0/etc/apparmor.d /nix/store/pmgymay0liaz5xy65z9n029v2qn6k79v-lxc-3.1.0/etc/apparmor.d/usr.bin.lxc-start (code=exited, status=1/FAILURE)
   Main PID: 2996 (code=exited, status=1/FAILURE)

  May 08 10:29:31 helium systemd[1]: Starting apparmor.service...
  May 08 10:29:31 helium apparmor_parser[2996]: Warning from stdin (line 1): config file '/etc/apparmor/parser.conf' not found
  May 08 10:29:31 helium apparmor_parser[2996]: Cache read/write disabled: interface file missing. (Kernel needs AppArmor 2.4 compatibility patch.)
  May 08 10:29:31 helium apparmor_parser[2996]: Warning: unable to find a suitable fs in /proc/mounts, is it mounted?
  May 08 10:29:31 helium apparmor_parser[2996]: Use --subdomainfs to override.
  May 08 10:29:31 helium systemd[1]: apparmor.service: Main process exited, code=exited, status=1/FAILURE
  May 08 10:29:31 helium systemd[1]: apparmor.service: Failed with result 'exit-code'.
  May 08 10:29:31 helium systemd[1]: Failed to start apparmor.service.
  warning: error(s) occurred while switching to the new configuration
  ```

  I believe the main issue is from this line here: `apparmor_parser[2996]: Cache read/write disabled: interface file missing. (Kernel needs AppArmor 2.4 compatibility patch.)`

  ### Steps to reproduce

  `boot.kernelPackages = pkgs.linuxPackages_latest;` and `security.apparmor.enable = true;` should be sufficient to reproduce the problem, although apparmor was already implicitly enabled on my system. I believe it's because of lxd.

  ## Technical details

  ```
  ➜  ~ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.0, NixOS, 19.09pre178846.7defc47944f (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178846.7defc47944f, nixos-hardware"`
   - channels(william): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: kcc: init at 5.5.1
user_login: dawidsowa
html_url: https://github.com/NixOS/nixpkgs/pull/61146
updated_at: 2019-05-09 16:42:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add KindleComicConverter
  https://kcc.iosphe.re

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: memtest86+: update / remove legacy memtest86
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/61147
updated_at: 2019-05-17 15:39:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Legacy `memtest86` was broken since 16.09 and we are already using `memtest86+` from coreboot through `boot.loader.grub.memtest86.enable`.
  Coreboot marked a more recent commit as stable and called it `5.01 coreboot 002` (we were actually shipping `5.01 coreboot 001` up to now). I tested building and running it in a x64 NixOS VM without issue.

  This memtest is intended for BIOS-systems only.
  The newer `memtest86-efi` from PassMark will be available for UEFI systems (see #60967).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox-esr-60: 60.6.2esr -> 60.6.3esr
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/61149
updated_at: 2019-05-08 16:37:58
body:
  ###### Motivation for this change

  Fixes for the certificate issue that started last week: https://www.mozilla.org/en-US/firefox/60.6.3/releasenotes/


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] firefox-esr-60: 60.6.2esr -> 60.6.3esr
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/61150
updated_at: 2019-05-08 16:38:00
body:
  ###### Motivation for this change

  Fixes for the certificate issue that started last week: https://www.mozilla.org/en-US/firefox/60.6.3/releasenotes/


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bettercap: 2.11 -> 2.24
user_login: fadenb
html_url: https://github.com/NixOS/nixpkgs/pull/61154
updated_at: 2019-05-11 15:34:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  New release contains bugfixes and additional functionality.

  Have used this updated package for a few days without any issues.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: slack: dark-mode introduces XSS vulnerability
user_login: tadfisher
html_url: https://github.com/NixOS/nixpkgs/issues/61155
updated_at: 2019-06-16 13:53:01
body:
  ## Issue description

  The `slack` package includes the following Javascript snippet when `darkMode` is enabled:

  ```js
      document.addEventListener('DOMContentLoaded', function() {
      let tt__customCss = ".menu ul li a:not(.inline_menu_link) {color: #fff !important;}"
      $.ajax({
          url: 'https://cdn.rawgit.com/laCour/slack-night-mode/master/css/raw/black.css',
          success: function(css) {
              \$("<style></style>").appendTo('head').html(css + tt__customCss);
              \$("<style></style>").appendTo('head').html('#reply_container.upload_in_threads .inline_message_input_container {background: padding-box #545454}');
              \$("<style></style>").appendTo('head').html('.p-channel_sidebar {background: #363636 !important}');
              \$("<style></style>").appendTo('head').html('#client_body:not(.onboarding):not(.feature_global_nav_layout):before {background: inherit;}');
          }
        });
      });

  ```

  As this is executed in the context of an Electron app, a malicious script would at the minimum have full access to Slack data, and at worst have remote execution ability using Electron/Node.js APIs.

  Recommendation: Fetch the source for `black.css` using `fetchurl` or similar, and include in the package.


state: closed
title: icr: 0.5.0 -> 0.6.0
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/61156
updated_at: 2019-05-15 09:02:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  None other than fixing a failing build on Hydra
  Changelog: https://github.com/crystal-community/icr/releases/tag/v0.6.0
  cc @peterhoeg 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libpointmatcher: 2016-09-11 -> 1.3.1
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/61157
updated_at: 2019-05-08 20:07:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixing a recurring build failure on Hydra

  Changelog:
  https://github.com/ethz-asl/libpointmatcher/releases/tag/1.3.1
  cc @cryptix 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: public-inbox: init at 5a4caaca8f
user_login: catern
html_url: https://github.com/NixOS/nixpkgs/pull/61158
updated_at: 2019-07-02 14:49:48
body:
  ###### Motivation for this change

  Adds the public-inbox application, a suite of tools for managing public archives of mailing lists.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Hex offline not finding packages
user_login: mwilsoninsight
html_url: https://github.com/NixOS/nixpkgs/issues/61159
updated_at: 2019-07-16 12:33:12
body:
  ## Issue description

  In attempting to get Elixir's Phoenix up and running on Nix, I ran into the small issue that the package was out of date- as were some of its dependencies- either way, it will not build out-of-the-box in its currently offered state.
  So I started updating/adding to a checkout of `master`.

  I'm finding that I have to edit `./mix.exs` such that all of its dependencies are local path entries rather than hex entries. Otherwise the builds fail.

  For example, when building `plug_1_8_0`, I get this error for some of its dependencies:
  ```
  Unchecked dependencies for environment prod:
  * telemetry (Hex package)
    the dependency is not available, run "mix deps.get"
  * mime (Hex package)
    the dependency is not available, run "mix deps.get"
  * plug_crypto (Hex package)
    the dependency is not available, run "mix deps.get"
  ```

  ### Steps to reproduce

  - Clone nixpkgs
  - Add entry in beamPackages for `cowlib_2_7_3` (buildErlangMk)
  - Update `cowlib` to `cowlib_2_7_3`
  - Add entry in beamPackages for `cowboy_2_6_3` (buildErlangMk)
  - Update `cowboy` to `cowboy_2_6_3`
  - Add entry in beamPackages for `telemetry_0_4_0` (buildRebar3)
  - Add entry in beamPackages for `telemetry` and set it to `telemetry_0_4_0`
  - Add entry in beamPackages for `mime_1_3_1` (buildMix)
  - Update `mime` to `mime_1_3_1`
  - Add entry in beamPackages for `plug_crypto_1_0_0` (buildMix)
  - Add entry in beamPackages for `plug_crypto` and set it to `plug_crypto_1_0_0`
  - Add entry in beamPackages for `plug_1_8_0` (buildMix)
    - making sure the argument set includes `telemetry`, `mime`, and `plug_crypto` (change `cowboy_x_y_z` to `cowboy`)
    - _and_ that the `beamDeps` attribute passed into `buildMix` contains these, as well `cowboy`
  - Update `plug` to `plug_1_8_0`
  - `nix-env -if "</possibly/relative/path/to>/nixpkgs" -A beamPackages.plug`

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172231.7b36963e7a7 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `nixos-19.03.172231.7b36963e7a7`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: xrdp: fix rsakey.ini permissions
user_login: grwlf
html_url: https://github.com/NixOS/nixpkgs/pull/61160
updated_at: 2019-05-09 21:11:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  We discovered that xrdp service on nixos-19.03 (19.03.git.22b639eb3ea (Koi)) doesn't work if enabled like this:

  ```
    services.xrdp = {
      enable = true;
    };
  ```

  but works if one run corresponding systemd command as root. After enabling logs we found that xrdp reported about incorrect permissions of `rsakey.ini` file. This PR fixes the permissions at service startup.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: awesome: add optional gtk3 support
user_login: stefano-m
html_url: https://github.com/NixOS/nixpkgs/pull/61161
updated_at: 2019-05-12 23:27:39
body:
  ###### Motivation for this change

  Add optional gtk3 support to Awesome so that the `beautiful.gtk` module can be
  used.

  The `beautiful.gtk` uses `lgi` to obtain Gtk via gobject-introspect:

      return require('lgi').Gtk

  Since the current build does not include the typelib files needed, the above
  call fails.

  It turns out that both `gtk3` and `atk` (Accessibility toolkit) are needed, so
  this commit adds them as optional build inputs.

  Setting `gtk3Support` to `true` e.g. in an overlay will make `beautiful.gtk`
  work at the cost of an increased closure size (currently 99.6M vs 223.4M).

  Fixes https://github.com/NixOS/nixpkgs/issues/60538


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([`nix.useSandbox`](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Kernel config: use PREEMPT_VOLUNTARY
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/61162
updated_at: 2019-06-14 15:26:30
body:
  ###### Motivation for this change
  zfsonlinux/zfs#8545

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mendeley: 1.19.1 -> 1.19.5
user_login: tbenst
html_url: https://github.com/NixOS/nixpkgs/pull/61163
updated_at: 2019-05-09 15:34:54
body:
  ###### Motivation for this change
  Was hoping to fix crash on opening pdf files. Unfortunately, it remains in 1.19.5. Other crashes seem to be fixed though, like search is now working. A better option for running mendeley on nixos is here: https://github.com/NixOS/nixpkgs/issues/43461#issuecomment-490657645

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia_x11: 418.56 -> 418.74
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/61164
updated_at: 2019-05-10 20:25:43
body:
  Mirror link doesn't seem to be needed anymore.
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Nividia Drivers with Linux 5.1 are broken
user_login: ZigTag
html_url: https://github.com/NixOS/nixpkgs/issues/61165
updated_at: 2019-07-08 18:50:13
body:
  ## Issue description

  Nividia Prop drivers appears to have a missing dependancy and is unable to build correctly with the Linux 5.1 Kernel

  ### Steps to reproduce

  sudo nix-rebuild boot --upgrade

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.13, NixOS, 19.09pre178675.24debf74ef5 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178846.7defc47944f"`
   - channels(falcon): `"nixos-19.09pre177249.dfd8f84aef1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: renderdoc: 1.2 -> 1.4
user_login: jansol
html_url: https://github.com/NixOS/nixpkgs/pull/61166
updated_at: 2019-05-09 20:52:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

   New upstream version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: Koka
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/61167
updated_at: 2019-05-10 14:24:30
body:
  [Koka](https://github.com/koka-lang/koka) is a function-oriented language that separates pure values from side-effecting computations (The word ‘koka’ (or 効果) means “effect” or “effective” in Japanese). Koka is also flexible and fun: Koka has many features that help programmers to easily change their data types and code organization correctly even in large-scale programs, while having a small strongly-typed language core with a familiar JavaScript like syntax. 


state: closed
title: release-cross.nix changes/fixes
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61168
updated_at: 2019-06-04 00:13:43
body:
  Cleanup for the Hydra jobset that builds cross toolchains:

  https://hydra.nixos.org/jobset/nixpkgs/cross-trunk

  - get rid of androidndk that is no longer available
  - provide more verbose error messages in androidenv
  - use platforms for mesa support
  - make valgrind optional in mesa and disabled on aarch32 platforms

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: static: set default_library flag for meson in makeStaticLibrary
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61169
updated_at: 2019-05-18 20:02:34
body:
  Adds support for building static libraries with meson.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perl-libwww: don’t check on darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61170
updated_at: 2019-05-09 04:34:49
body:
  https://hydra.nixos.org/build/93312762

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux_testing_bcachefs,bcachefs-tools: 2019-04-04 -> 2019-05-08
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/61171
updated_at: 2019-05-17 11:22:29
body:
  This is either terribly broken or working fine.
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [19.03] tensorflow-tensorboard requires tensorflow python module to be importable
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/61173
updated_at: 2019-05-10 14:27:14
body:
  ## Issue description

  In the latest 19.03, the new `tensorflow-tensorboard` Nix package exports an executable called `tensorboard`. To run this executable it needs to be able to import `tensorflow`. Otherwise it comes up with an error:

  ```
  Traceback (most recent call last):
    File "/nix/store/4hpsjw1a9yvw2skx5kjjc0kp3lqy57ad-python3.6-tensorflow-tensorboard-1.13.0/bin/.tensorboard-wrapped", line 7, in <module>
      from tensorboard.main import run_main
    File "/nix/store/4hpsjw1a9yvw2skx5kjjc0kp3lqy57ad-python3.6-tensorflow-tensorboard-1.13.0/lib/python3.6/site-packages/tensorboard/main.py", line 42, in <module>
      import tensorflow as tf  # pylint: disable=unused-import
  ModuleNotFoundError: No module named 'tensorflow'
  ```

  Now usually I solved this inside `nix-shell` where I just add `tensorflowWithoutCuda` as a `propagatedBuildInput`, and then `tensorboard` works inside the nix-shell.

  However if I'm trying build a custom package that calls `tensorboard` via `subprocess.run` in Python, even if my own package has `tensorboardWithoutCuda` in the `propagatedBuildInputs`, the `tensorflow` Python module is not added to the PYTHONPATH for the `tensorboard` executable. So when your own custom executable calls `tensorboard`, it results in `tensorboard` reporting that it cannot find `tensorflow` module.

  ### Steps to reproduce

  ```nix
  {
    pkgs ? import ./pkgs.nix,
    pythonPath ? "python36"
  }:
    with pkgs;
    let
      python = lib.getAttrFromPath (lib.splitString "." pythonPath) pkgs;
    in
      python.pkgs.buildPythonApplication rec {
        pname = "tensorboard-dashboard";
        version = "0.0.1";
        src = lib.cleanSourceWith {
          filter = (path: type:
            ! (builtins.any
                (r: (builtins.match r (builtins.baseNameOf path)) != null)
                [
                  "pip_packages"
                  ".*\.egg-info"
                  "\.env"
                  "tmp"
                  "logs"
                ])
          );
          src = lib.cleanSource ./.;
        };
        nativeBuildInputs = [
          makeWrapper
          python.pkgs.pip
        ];
        propagatedNativeBuildInputs = (with python.pkgs;[
          tensorflow-tensorboard
        ]);
        propagatedBuildInputs = (with python.pkgs; [
          setuptools
          tensorflowWithoutCuda # tensorboard requires tensorflow
        ]);
        # remove this when setuptools becomes compatible with tensorflow's setuptools requirement
        installFlags = [ "--no-deps" ];
      }
  ```

  If you have a `setup.py` that registers this executable:

  ```py
  #!/usr/bin/env python3

  import subprocess

  def main():
      print('Running')
      subprocess.run(['tensorboard', '--help'])
      print('Ran')

  if __name__ == '__main__':
      main()
  ```


state: closed
title: upower: 0.99.9 -> 0.99.10
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/61174
updated_at: 2019-05-09 20:10:39
body:
  Using placeholder and drop the NIX_CFLAGS_LINK.

  https://gitlab.freedesktop.org/upower/upower/blob/UPOWER_0_99_10/NEWS

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: howl: 0.5.3 -> 0.6
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/61175
updated_at: 2019-05-09 15:02:23
body:
  ###### Motivation for this change

  This upgrades the `howl` package to the latest version.
  Changes have been successfully tested.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.i3ipc: 1.6.0 -> 1.7.1
user_login: Synthetica9
html_url: https://github.com/NixOS/nixpkgs/pull/61176
updated_at: 2019-05-14 16:45:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New version was released 2 hours before #61084 was merged, would've included it in that PR otherwise.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/jupiter: add a kernel jsFile option
user_login: jraygauthier
html_url: https://github.com/NixOS/nixpkgs/pull/61177
updated_at: 2019-05-16 05:02:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Required in order to get haskell syntax highlighting when using ihaskell as a jupyter kernel.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Relates to https://github.com/gibiansky/IHaskell/issues/920 and https://github.com/gibiansky/IHaskell/pull/1027


state: open
title: Package request: volt
user_login: mt-caret
html_url: https://github.com/NixOS/nixpkgs/issues/61178
updated_at: 2019-05-10 14:24:19
body:
  ## Issue description

  volt is a small client for Slack, among other services. I've been trying to patch it based on the instructions on the [wiki](https://nixos.wiki/wiki/Packaging/Binaries) and I got it to the point where I can see a window, but it doesn't seem to work correctly.

  Here's how far I got:
  ```
  { stdenv, curl, glfw, freetype, fetchzip }:
  stdenv.mkDerivation rec {
    pname = "volt";
    version = "0.80";

    src = fetchzip {
      url = "https://github.com/voltapp/volt/releases/download/${version}/volt_linux.zip";
      sha256 = "1kj7xb3lc48hca8jqf0c8ixr2wjaklgpkx679pah8iksdkqxz8pi";
      stripRoot = false;
    };

    buildPhase = ":";

    installPhase = ''
      mkdir -p $out/bin
      cp ./volt $out/bin/
    '';

    preFixup = let
      libPath = stdenv.lib.makeLibraryPath [ curl glfw freetype ];
    in ''
      patchelf \
        --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \
        --set-rpath "${libPath}" \
        $out/bin/volt
    '';

    dontStrip = true;

    meta = with stdenv.lib; {
      homepage = https://volt-app.com/;
      description = "a 300 KB desktop client for Slack, Skype, Gmail, Twitter, Facebook and more";
      license = license.proprietary;
      platforms = platforms.linux;
      maintainers = [ mt-caret ];
    };
  }
  ```

  ### Steps to reproduce

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: stdenv, cacert: $NIX_SSL_CERT_FILE changes
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/pull/61179
updated_at: 2019-05-19 12:48:03
body:
  ###### Motivation for this change

  Some SSL libs don't react to `$SSL_CERT_FILE`.  That actually makes sense to me, as we add this behavior as nixpkgs-specific, so it seems "safer" to use `$NIX_*`.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date: _docs are **still** missing ;-)_
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] Avoid collisions between essential packages
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/61180
updated_at: 2019-05-14 08:40:28
body:
  ###### Motivation for this change
  Backport #61138 to 19.03. This should finally close #55886.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files
  - [ ] Determined the impact on package closure size
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spl: fix build with linux 5.1
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/61181
updated_at: 2019-05-12 15:02:14
body:
  Upstream issue: https://github.com/zfsonlinux/zfs/issues/8697
  Upstream fix (zfs repo): 782dfae3218b5f2029ce78722b999cb04e8ef001

  This can't be applied cleanly as a patch, since spl has been moved
  into the zfs repo since 0.7.13.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc maintainers @fpletz @wizeman @globin


state: closed
title: kubernetes: 1.13.5 -> 1.13.6
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/61182
updated_at: 2019-05-11 07:21:25
body:
  ###### Motivation for this change
  Bump kubernetes revision.

  Tests run clean locally:
  ```
  $ nix-build nixos/release.nix -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode
  /nix/store/3mir42ixsa0c9jqf3g27nqa2p49ivgaj-vm-test-run-kubernetes-dns-singlenode
  /nix/store/nzj809jb8swd0g78h70csrs7kdkpwgp0-vm-test-run-kubernetes-dns-multinode
  /nix/store/f8iqn98k7r8m6ll51k0j7hnn4cipwin6-vm-test-run-kubernetes-rbac-singlenode
  /nix/store/3mdg3x892z25r3ywp5szn264gs9kd6p7-vm-test-run-kubernetes-rbac-multinode
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Jinja2 tests fail
user_login: mweinelt
html_url: https://github.com/NixOS/nixpkgs/issues/61183
updated_at: 2019-05-13 01:44:46
body:
  ## Issue description

  The tests for python27Packages.jinja2 fail and thereby the derivation fails to evaluate.

  ```
  builtins.Failed: [pytest] section in setup.cfg files is no longer supported, change to [tool:pytest] instead.
  ```
  (Full log below)

  ### Steps to reproduce

  I'm crosscompiling an aarch64 sd image with `services.octoprint.enable = true`.

  ## Technical details

  ```
  building '/nix/store/dmga5m047h3xsi7xi92vki0b96afns1g-python2.7-Jinja2-2.8.1.drv'...
  unpacking sources
  unpacking source archive /nix/store/iqjlvb13wk3lg5jdsxfkihzvwr3hfdak-Jinja2-2.8.1.tar.gz
  source root is Jinja2-2.8.1
  setting SOURCE_DATE_EPOCH to timestamp 1483017377 of file Jinja2-2.8.1/setup.cfg
  patching sources
  updateAutotoolsGnuConfigScriptsPhase
  configuring
  building
  running bdist_wheel
  The [wheel] section is deprecated. Use [bdist_wheel] instead.
  running build
  running build_py
  creating build
  creating build/lib
  creating build/lib/jinja2
  copying jinja2/debug.py -> build/lib/jinja2
  copying jinja2/lexer.py -> build/lib/jinja2
  copying jinja2/constants.py -> build/lib/jinja2
  copying jinja2/meta.py -> build/lib/jinja2
  copying jinja2/visitor.py -> build/lib/jinja2
  copying jinja2/parser.py -> build/lib/jinja2
  copying jinja2/__init__.py -> build/lib/jinja2
  copying jinja2/sandbox.py -> build/lib/jinja2
  copying jinja2/optimizer.py -> build/lib/jinja2
  copying jinja2/_compat.py -> build/lib/jinja2
  copying jinja2/ext.py -> build/lib/jinja2
  copying jinja2/bccache.py -> build/lib/jinja2
  copying jinja2/utils.py -> build/lib/jinja2
  copying jinja2/environment.py -> build/lib/jinja2
  copying jinja2/exceptions.py -> build/lib/jinja2
  copying jinja2/_stringdefs.py -> build/lib/jinja2
  copying jinja2/tests.py -> build/lib/jinja2
  copying jinja2/defaults.py -> build/lib/jinja2
  copying jinja2/compiler.py -> build/lib/jinja2
  copying jinja2/runtime.py -> build/lib/jinja2
  copying jinja2/loaders.py -> build/lib/jinja2
  copying jinja2/filters.py -> build/lib/jinja2
  copying jinja2/nodes.py -> build/lib/jinja2
  running egg_info
  writing requirements to Jinja2.egg-info/requires.txt
  writing Jinja2.egg-info/PKG-INFO
  writing top-level names to Jinja2.egg-info/top_level.txt
  writing dependency_links to Jinja2.egg-info/dependency_links.txt
  writing entry points to Jinja2.egg-info/entry_points.txt
  reading manifest file 'Jinja2.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  warning: no files found matching 'run-tests.py'
  warning: no files found matching '*' under directory 'custom_fixers'
  warning: no files found matching '*' under directory 'jinja2/testsuite/res'
  warning: no previously-included files matching '*' found under directory 'docs/_build'
  warning: no previously-included files matching '*.pyc' found under directory 'jinja2'
  warning: no previously-included files matching '*.pyc' found under directory 'docs'
  warning: no previously-included files matching '*.pyo' found under directory 'jinja2'
  warning: no previously-included files matching '*.pyo' found under directory 'docs'
  writing manifest file 'Jinja2.egg-info/SOURCES.txt'
  installing to build/bdist.linux-aarch64/wheel
  running install
  running install_lib
  creating build/bdist.linux-aarch64
  creating build/bdist.linux-aarch64/wheel
  creating build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/debug.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/lexer.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/constants.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/meta.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/visitor.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/parser.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/__init__.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/sandbox.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/optimizer.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/_compat.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/ext.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/bccache.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/utils.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/environment.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/exceptions.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/_stringdefs.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/tests.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/defaults.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/compiler.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/runtime.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/loaders.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/filters.py -> build/bdist.linux-aarch64/wheel/jinja2
  copying build/lib/jinja2/nodes.py -> build/bdist.linux-aarch64/wheel/jinja2
  running install_egg_info
  Copying Jinja2.egg-info to build/bdist.linux-aarch64/wheel/Jinja2-2.8.1-py2.7.egg-info
  running install_scripts
  adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
  adding license file "AUTHORS" (matched pattern "AUTHORS*")
  creating build/bdist.linux-aarch64/wheel/Jinja2-2.8.1.dist-info/WHEEL
  creating 'dist/Jinja2-2.8.1-py2.py3-none-any.whl' and adding 'build/bdist.linux-aarch64/wheel' to it
  adding 'jinja2/__init__.py'
  adding 'jinja2/_compat.py'
  adding 'jinja2/_stringdefs.py'
  adding 'jinja2/bccache.py'
  adding 'jinja2/compiler.py'
  adding 'jinja2/constants.py'
  adding 'jinja2/debug.py'
  adding 'jinja2/defaults.py'
  adding 'jinja2/environment.py'
  adding 'jinja2/exceptions.py'
  adding 'jinja2/ext.py'
  adding 'jinja2/filters.py'
  adding 'jinja2/lexer.py'
  adding 'jinja2/loaders.py'
  adding 'jinja2/meta.py'
  adding 'jinja2/nodes.py'
  adding 'jinja2/optimizer.py'
  adding 'jinja2/parser.py'
  adding 'jinja2/runtime.py'
  adding 'jinja2/sandbox.py'
  adding 'jinja2/tests.py'
  adding 'jinja2/utils.py'
  adding 'jinja2/visitor.py'
  adding 'Jinja2-2.8.1.dist-info/AUTHORS'
  adding 'Jinja2-2.8.1.dist-info/LICENSE'
  adding 'Jinja2-2.8.1.dist-info/METADATA'
  adding 'Jinja2-2.8.1.dist-info/WHEEL'
  adding 'Jinja2-2.8.1.dist-info/entry_points.txt'
  adding 'Jinja2-2.8.1.dist-info/top_level.txt'
  adding 'Jinja2-2.8.1.dist-info/RECORD'
  removing build/bdist.linux-aarch64/wheel
  installing
  /build/Jinja2-2.8.1/dist /build/Jinja2-2.8.1
  DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
  Processing ./Jinja2-2.8.1-py2.py3-none-any.whl
  Requirement already satisfied: MarkupSafe in /nix/store/xb8mfbqgq2983fxc40gi3dik2l62zgkl-python2.7-MarkupSafe-1.1.1/lib/python2.7/site-packages (from Jinja2==2.8.1) (1.1.1)
  Installing collected packages: Jinja2
  Successfully installed Jinja2-2.8.1
  /build/Jinja2-2.8.1
  post-installation fixup
  shrinking RPATHs of ELF executables and libraries in /nix/store/i2awlcln1mhsglc07srz7nmq615p718i-python2.7-Jinja2-2.8.1
  strip is /nix/store/q68bqrywsnamwdjw86f60zxgw26jpw4j-binutils-2.31.1/bin/strip
  stripping (with command strip and flags -S) in /nix/store/i2awlcln1mhsglc07srz7nmq615p718i-python2.7-Jinja2-2.8.1/lib
  patching script interpreter paths in /nix/store/i2awlcln1mhsglc07srz7nmq615p718i-python2.7-Jinja2-2.8.1
  checking for references to /build/ in /nix/store/i2awlcln1mhsglc07srz7nmq615p718i-python2.7-Jinja2-2.8.1...
  running install tests
  Traceback (most recent call last):
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/bin/.pytest-wrapped", line 11, in <module>
      sys.exit(main())
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 61, in main
      config = _prepareconfig(args, plugins)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 196, in _prepareconfig
      pluginmanager=pluginmanager, args=args
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/hooks.py", line 284, in __call__
      return self._hookexec(self, self.get_hookimpls(), kwargs)
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/manager.py", line 68, in _hookexec
      return self._inner_hookexec(hook, methods, kwargs)
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/manager.py", line 62, in <lambda>
      firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/callers.py", line 203, in _multicall
      gen.send(outcome)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/helpconfig.py", line 93, in pytest_cmdline_parse
      config = outcome.get_result()
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/callers.py", line 81, in get_result
      _reraise(*ex)  # noqa
    File "/nix/store/2fyagxnljg85hkzxn3x1aa8rwnarpp89-python2.7-pluggy-0.8.1/lib/python2.7/site-packages/pluggy/callers.py", line 187, in _multicall
      res = hook_impl.function(*args)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 655, in pytest_cmdline_parse
      self.parse(args)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 841, in parse
      self._preparse(args, addopts=addopts)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 778, in _preparse
      self._initini(args)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/__init__.py", line 709, in _initini
      config=self,
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/findpaths.py", line 122, in determine_setup
      rootdir, inifile, inicfg = getcfg([ancestor], config=config)
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/config/findpaths.py", line 41, in getcfg
      pytrace=False,
    File "/nix/store/i33qvbmfsw5zl25zkb88zziwkk16ab1h-python2.7-pytest-4.2.1/lib/python2.7/site-packages/_pytest/outcomes.py", line 113, in fail
      raise Failed(msg=msg, pytrace=pytrace)
  builtins.Failed: [pytest] section in setup.cfg files is no longer supported, change to [tool:pytest] instead.
  builder for '/nix/store/dmga5m047h3xsi7xi92vki0b96afns1g-python2.7-Jinja2-2.8.1.drv' failed with exit code 1
  cannot build derivation '/nix/store/zf9gv3s367h32qlb5x1rk3nidwrlf0jd-python2.7-Flask-0.10.1.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/76jxavcmxh9jkdibx898jssf6qg8i7zc-python2.7-Flask-Babel-0.12.2.drv': 1 dependencies couldn't be built
  ```

  I'm crosscompiling aarch64 with nixpkgs 475b4d1d42e72e46c3c829c3290a5f646bb2fc83.


state: open
title: Pantheon: suspend message has random icon
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/61184
updated_at: 2019-07-04 13:13:27
body:
  ## Issue description

  ![Screenshot from 2019-05-09 11-10-59](https://user-images.githubusercontent.com/91113/57441962-44915680-724b-11e9-8ee4-e36eea0c8cfe.png)

  I had an AppImage of [Pathephone](https://pathephone.github.io/) and added it to the menu. Then i removed the AppImage file but don't know how to remove the menu entry. In Pantheon, the icon of Pathephone is used in this suspend message, what makes no sense.

  On my other notebook, the icon of Signal is used.

  ![Screenshot from 2019-05-09 21-39-00](https://user-images.githubusercontent.com/91113/57481730-0d4e9400-72a3-11e9-8622-24eeae59c877.png)

  cc @worldofpeace 

  ### Steps to reproduce

  0. wait for the message to show up

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.40, NixOS, 19.03.172496.3e7300cf049 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172496.3e7300cf049, nixos-hardware, nixos-unstable-19.09pre178795.2ec5e9595be"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: elk: 7.0.0 -> 7.0.1
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/61185
updated_at: 2019-05-09 13:50:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Release notes:
  * https://www.elastic.co/guide/en/elasticsearch/reference/7.0/release-notes-7.0.1.html
  * https://www.elastic.co/guide/en/logstash/7.0/logstash-7-0-1.html
  * https://www.elastic.co/guide/en/kibana/7.0/release-notes-7.0.1.html
  * https://www.elastic.co/guide/en/beats/libbeat/7.0/release-notes-7.0.1.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nginx mime types
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/issues/61186
updated_at: 2019-05-14 14:13:22
body:
  ## Issue description

  The nginx config generated by the nginx module does not set a default mime type, resulting in many binary files (.opus, .mkv, .pkg) being displayed as text (text/plain).
  I suggest using the mime types list from mailcap, like ArchLinux does, and adding "default_type: application/octet-stream". 

  I fixed this for my setup temporarily like this: https://git.pbb.lc/petabyteboy/nixfiles/commit/21ee8ed7f87571353df5b86c4cd1bc7478fddcc0

  ### Steps to reproduce

  Set up a basic nginx server on NixOS. Put a .mkv or .opus file in the served directory. Try to download it. Its content will be shown as text in the browser.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.09pre177651.aeb464dfd37 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: linux_{5_0,5_1,testing}: restore __kernel_fpu_{begin,restore} [19.03]
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/61187
updated_at: 2019-05-09 12:00:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/61076

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Cannot update system with nixos-rebuild due to 443 from codeload.github.com
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/issues/61188
updated_at: 2019-05-09 20:43:18
body:
  ## Issue description
  Something changed between my current `nix-channel` generation (`nixos-19.03.172463.6e29f22551d`) and the latest version, whenever I update my channels and try to rebuild I get 

  ```text
  100   165    0   165    0     0    323      0 --:--:-- --:--:-- --:--:--   322
  curl: (7) Failed to connect to codeload.github.com port 443: Connection refused
  error: cannot download source from any mirror
  builder for '/nix/store/4fc8m653bapwm496vfdhh5z2jb0sqi1d-source.drv' failed with exit code 1
  cannot build derivation '/nix/store/4g2v05b0hcb3ayw14cnlzvpnyinnwhip-emacs-company-quickhelp-20180525.303.drv': 1 dependencies couldn't be built
  building '/nix/store/4gafajxzybavkwccj1axr17hydmyqp8q-source.drv'...
  building '/nix/store/4m8x232jpddd7i5zmqpjpjsmj1qkbll7-source.drv'...
  building '/nix/store/5awzsi2q1ailc51v64qcnzrqvz2kgywa-source.drv'...
  building '/nix/store/5d3li98539v7jzn6p9a4ib35xblhlbzy-source.drv'...
  cannot build derivation '/nix/store/0ffpjfq8nhhff8narc6qpsanscrg4z2h-emacs-with-packages-26.1.drv': 1 dependencies couldn't be built
  ```

  It is always a Emacs package from GitHub where it fails, so I think it is because I'm getting rate limited by them. However because of this I cannot update my system, I use `home-manager` as a NixOS module and my Emacs configuration is bundled together with my system and updated alongside the rest of my system.

  ### Steps to reproduce
  N/A (other than installing NixOS, cloning my dotfiles and install my `neptune` machine).


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```text
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.03.172392.6d7ed964296 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172463.6e29f22551d, unstable-19.09pre178260.190727db4ea"`
   - channels(sondre): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: Atom don't see branch of new git repo
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/61189
updated_at: 2019-05-16 19:12:10
body:
  ## Issue description

  cc @ysndr  @NeQuissimus 

  ### Steps to reproduce

  0. open Atom editor in a directory
  1. open git panel by clicking on the bottom right
  2. initialize repo using Atom
  3. Atom sais "Not on branch"

  ![Screenshot from 2019-05-09 16-12-48](https://user-images.githubusercontent.com/91113/57460401-538cfe80-7275-11e9-84ed-80faaf3baae8.png)

  But git on CLI sais:

  ```
  $ git status
  On branch master
  ```

  Restart of Atom don't helps.

  Even when i init the repo on CLI, Atom sees no branches! (not a problem in order repos)

  It's normal after the first commit using CLI.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.40, NixOS, 19.03.172496.3e7300cf049 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172496.3e7300cf049, nixos-hardware, nixos-unstable-19.09pre178795.2ec5e9595be"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Kube3d
user_login: ngerstle-cognite
html_url: https://github.com/NixOS/nixpkgs/pull/61190
updated_at: 2019-07-01 09:42:05
body:
  ###### Motivation for this change
  Add the k3d (https://github.com/rancher/k3d) tool.
  The k3d tool spins up a k3s kubernetes cluster.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matcha: 2018-12-24 -> 2019_05_09
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/61191
updated_at: 2019-05-10 02:45:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [2019_05_09](https://github.com/vinceliuice/matcha/releases/tag/2019_05_09).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: Failing to build packages with Cargo nightly
user_login: glasserc
html_url: https://github.com/NixOS/nixpkgs/issues/61192
updated_at: 2019-07-07 14:13:28
body:
  ## Issue description

  As of https://github.com/rust-lang/cargo/pull/6880, cargo now creates locks in `$CARGO_HOME/.cargo/.package-cache`. When trying to build some cargo packages using Rust nightly (from https://github.com/mozilla/nixpkgs-mozilla/), I've gotten failures such as https://gist.github.com/glasserc/ec065e3cf7706c13742dc16fb79a931b.

  ### Steps to reproduce

  I hit this while trying to build Gecko using mozilla/nixpkgs-mozilla#175. With that patch applied, from within a checkout of Gecko, I ran: `nix-shell ../nixpkgs-mozilla/release.nix -A gecko.x86_64-linux.gcc  --command fish` (and got the output shown above).

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.40, NixOS, 19.03.172500.aade6ded796 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(ethan): `""`
   - channels(root): `"nixos-19.03.172500.aade6ded796"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: Package Request: protontricks
user_login: MicrosoftTakeover
html_url: https://github.com/NixOS/nixpkgs/issues/61193
updated_at: 2019-07-20 00:53:02
body:
  A simple wrapper that does winetricks things for Proton enabled games, requires Winetricks.

  https://github.com/Matoking/protontricks


state: open
title: Pass CARGO_HOME on more invocations of cargo
user_login: glasserc
html_url: https://github.com/NixOS/nixpkgs/pull/61194
updated_at: 2019-06-18 09:25:24
body:
  Fixes #61192.

  ###### Motivation for this change

  Although this failure only occurs when using Cargo nightly, which isn't actually packaged here yet, this will eventually become a problem when nightly becomes stable.

  I'm not really sure that this is the right place for this change. Is the existing absence of `CARGO_HOME` meant to flush out reproducibility failures when cargo tries to download a package? Or was it just because previously `cargo` didn't need to do anything in the build or test phases so it wasn't necessary?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rtl8192eu: update at 4.4.1
user_login: troydm
html_url: https://github.com/NixOS/nixpkgs/pull/61195
updated_at: 2019-05-27 23:03:15
body:
  ###### Motivation for this change
  Latest commit in rtl8192eu module github repo contains fixes for compiling with 5.0 and 5.1 kernels so I've just updated git hash codes
  ###### Things done
  Updated git commit hashes to checkout latest rtl8192eu kernel module source code

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mupdf: 1.14.0 -> 1.15.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61196
updated_at: 2019-05-10 07:44:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Drop CVE patch, presumably included since it's from their repo :).
  (but not mentioned in release notes online)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go: 1.11.6 -> 1.11.10, 1.12.1 -> 1.12.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61197
updated_at: 2019-05-09 18:10:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Bump, here's the announcement:

  https://groups.google.com/forum/#!msg/golang-announce/GhnThAAITFI/G2khTjk2AwAJ

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: public-sans: 1.002 -> 1.003
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61198
updated_at: 2019-05-09 18:32:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/uswds/public-sans/releases/tag/v1.003

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: viu: 0.1 -> 0.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61199
updated_at: 2019-05-10 01:08:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/atanunq/viu/releases/tag/v0.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libosinfo, osinfo-db-tools: 1.4.0 -> 1.5.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61200
updated_at: 2019-05-10 01:09:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libxmlb: 0.1.8 -> 0.1.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61201
updated_at: 2019-05-11 09:30:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: glibc: add patch to use utf-8 when LANG is unset
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/61202
updated_at: 2019-07-17 19:56:19
body:
  This allows the default builder to use utf-8 encoding. Previously,
  when LANG and LC_ALL was left unset, glibc would default to “C”. This
  is not good in many.

  As a result of this, I think we can get rid of a lot of uses of LC_ALL
  in Nixpkgs, where utf-8 was needed. These can be found by grepping
  for:

    ```(?:LC_ALL|LANG) *= *["']?(?:en_US|C)\.UTF-8["']?```

  A lot of times the ones using en_US.UTF-8 also add glibcLocales.

  /cc @vaibhavsagar 


state: open
title: certbot: 0.31.0 -> ... -> 0.35.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61203
updated_at: 2019-06-07 03:47:38
body:
  ###### Motivation for this change

  Whoops, I guess I haven't been sending these for a while :3.

  Tests disabled because they require docker (integration testing),
  dunno if there's a way to run non-docker tests or such, suggestions
  welcome :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libinput: 1.13.1 -> 1.13.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/61204
updated_at: 2019-05-11 06:28:42
body:
  ###### Motivation for this change

  https://lists.freedesktop.org/archives/wayland-devel/2019-May/040548.html

  Perhaps notable is that this improves Apple touchpad support,
  but just a minor update :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pkgs.pkgsCross.raspberryPi.stdenv works but not pkgs.pkgsCross.raspberryPi.clangStdenv
user_login: tfc
html_url: https://github.com/NixOS/nixpkgs/issues/61205
updated_at: 2019-05-10 14:18:17
body:
  ## Issue description

  I tried to crosscompile a simple tiny C++ application on x86_64 for the Raspberry Pi using `pkgs.pkgsCross.raspberryPi`.
  This works nicely with `stdenv` from that set, but not with `clangStdenv`.

  ### Steps to reproduce

  The code is here: https://github.com/tfc/nix_cpp_crosscompile/

  Run the following nix command:

  ```bash
  $  nix-build release.nix -A raspberry-clang
  ```

  This will fail while trying to build `/nix/store/2kc1pn93i94k4c6cjgpsy3bssizi8760-cross-compile-example-armv6l-unknown-linux-gnueabihf.drv`.
  I am not sure how to debug this as in the cross compilation setup expressions i quickly feel lost.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```bash
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.9, NixOS, 19.03.172500.aade6ded796 (Koi)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(tfc): `"home-manager-19.03"`
   - channels(root): `"nixos-19.03.172500.aade6ded796, nixos-unstable-19.09pre178539.d457e31d9ec"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ```


state: closed
title: terraform_0_12: 0.12.0-beta1 -> 0.12.0-rc1
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/61207
updated_at: 2019-05-09 21:00:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: tla-bin
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/61208
updated_at: 2019-05-10 14:23:39
body:
  `nixpkgs` has the standard TLA+ IDE, but [tla-bin](https://github.com/pmer/tla-bin) is a common dependency for some integrations. It would be good to be able to install it on NixOS.


state: open
title: scopes: init
user_login: jacereda
html_url: https://github.com/NixOS/nixpkgs/pull/61209
updated_at: 2019-06-13 08:00:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


