# issues

state: closed
title: libu2f-host: 1.1.7 -> 1.1.9
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58309
updated_at: 2019-03-31 02:47:02
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libu2f-host/versions.



  meta.description for libu2f-host is: '"A C library and command-line tool that implements the host-side of the U2F protocol"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1.9 with grep in /nix/store/vyn1j1hggaah9x5vbk7jfgxlzf4x3zyb-libu2f-host-1.1.9
  - directory tree listing: https://gist.github.com/bdc19837acc4416316e6e443d7a687d7
  - du listing: https://gist.github.com/b6f5b6776ab81cf9448273cef0d5a00c

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  24 total rebuild path(s)

  7 package rebuild(s)

  7 x86_64-linux rebuild(s)
  6 i686-linux rebuild(s)
  5 x86_64-darwin rebuild(s)
  6 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  gen-oath-safe
  libu2f-host
  pam_u2f
  yubikey-manager
  yubikey-manager-qt
  yubikey-neo-manager
  yubioath-desktop

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/vyn1j1hggaah9x5vbk7jfgxlzf4x3zyb-libu2f-host-1.1.9 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libu2f-host https://github.com/r-ryantm/nixpkgs/archive/dc7596397cb44aaffc8bf8b13f4aee10e6b791d4.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/vyn1j1hggaah9x5vbk7jfgxlzf4x3zyb-libu2f-host-1.1.9
  ls -la /nix/store/vyn1j1hggaah9x5vbk7jfgxlzf4x3zyb-libu2f-host-1.1.9/bin
  ```


  </details>
  <br/>


state: closed
title: Switch meson to buildtype=plain
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/issues/58310
updated_at: 2019-06-25 17:30:58
body:
  The release buildtype adds custom flags to the compiler, reducing our control over builds (removed debugging info, changed optimization level, see http://mesonbuild.com/Quick-guide.html#using-meson-as-a-distro-packager and http://mesonbuild.com/Running-Meson.html#configuring-the-build-directory).

  We will need to verify whether everything (`CFLAGS` env var vs `-Dc_args` arg, cross-compilation) still works.

  cc @worldofpeace @hedning 


state: closed
title: libuv: 1.26.0 -> 1.27.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58311
updated_at: 2019-04-26 02:55:23
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libuv/versions.



  meta.description for libuv is: '"A multi-platform support library with a focus on asynchronous I/O"'.


  [Compare changes on GitHub](https://github.com/libuv/libuv/compare/v1.26.0...v1.27.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.27.0 with grep in /nix/store/2hx4bqjgdaxq481x0zqvicaw88f35am6-libuv-1.27.0
  - directory tree listing: https://gist.github.com/68c784b23c04712dd256bb797f41adc0
  - du listing: https://gist.github.com/899216e6345c210b31cebb1045a44f89

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  30360 total rebuild path(s)

  13975 package rebuild(s)

  7867 x86_64-linux rebuild(s)
  6812 i686-linux rebuild(s)
  3829 x86_64-darwin rebuild(s)
  11852 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  DisnixWebService
  EBTKS
  EmptyEpsilon
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  QuadProgpp
  R
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_stretch
  SDL_ttf
  SkypeExport
  TotalParserCombinators
  _20kly
  _90secondportraits
  a2jmidid
  aacskeys
  abc-verifier
  abcde
  abcl
  abcm2ps
  abiword
  accountsservice
  acgtk
  acoustidFingerprinter
  actdiag
  adapta-gtk-theme
  adlplug
  adms
  adobe-reader
  adom
  adoptopenjdk-bin
  adoptopenjdk-hotspot-bin-11
  adoptopenjdk-jre-bin
  adoptopenjdk-jre-hotspot-bin-11

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/2hx4bqjgdaxq481x0zqvicaw88f35am6-libuv-1.27.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libuv https://github.com/r-ryantm/nixpkgs/archive/e478cd322e1272467a30826a6aa2e928775f99b3.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/2hx4bqjgdaxq481x0zqvicaw88f35am6-libuv-1.27.0
  ls -la /nix/store/2hx4bqjgdaxq481x0zqvicaw88f35am6-libuv-1.27.0/bin
  ```


  </details>
  <br/>


  cc @cstrahan for testing.


state: closed
title: yuzu: init at 2019-05-03
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/58312
updated_at: 2019-07-19 23:34:32
body:
  ###### Motivation for this change

  Requested in #58176.

  Yuzu doesn't have stable releases yet, so this is based on the current latest git revision.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcc: fix gcc8 for cross-compiled targets
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/58313
updated_at: 2019-04-24 03:14:24
body:
  Adds EXTRA_TARGET_FLAGS missing from 412093994b9a4fe0fa7da99d1947effc85d9070b.

  Fixes #58164

  ###### Motivation for this change

  This seems to have been a mistaken deletion that prevented gcc8 from compiling when the target platform is not the host.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghostscript: add patch for CVE-2019-6116
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/58314
updated_at: 2019-03-28 22:29:37
body:
  ###### Motivation for this change

  This is tagged as version 9.26a in the ghostpdl repo, but unfortunately
  there are no tarballs released with that version number so far. We'll
  continue calling this version 9.26 for now for simplicity's sake (and we
  can switch to 9.26a and remove the patch when it's properly released).

  Fixes #58262
  Fixes #58089

  FYI @viric @dtzWill 

  This will need backporting to release-18.09 and release-19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: falkon: 3.0.1 -> 3.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58315
updated_at: 2019-03-26 16:16:57
body:
  ###### Motivation for this change

  \o/

  https://www.falkon.org/2019/03/19/falkon-310-released/

  This does not package the "experimental" python/qt plugin bits, FWIW.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libwpg: 0.3.2 -> 0.3.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58316
updated_at: 2019-04-14 04:56:30
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libwpg/versions.



  meta.description for libwpg is: '"C++ library to parse WPG"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.3.3 with grep in /nix/store/yj8i7yv8f7q63awma4m5kva0zanp190x-libwpg-0.3.3
  - directory tree listing: https://gist.github.com/590b92ca79e0a2bb1735f5b482ab38a5
  - du listing: https://gist.github.com/3c2fdbc8e6941b30a0932c9d874a4b36

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  103 total rebuild path(s)

  35 package rebuild(s)

  35 x86_64-linux rebuild(s)
  35 i686-linux rebuild(s)
  11 x86_64-darwin rebuild(s)
  22 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  adapta-gtk-theme
  arc-theme
  arx-libertatis
  asciidoc-full
  asciidoc-full-with-plugins
  bibata-cursors
  btrbk
  calligra
  capitaine-cursors
  dblatexFull
  disorderfs
  emojione
  fim
  gnome3.gnome-documents
  inkscape
  libcdr
  libmwaw
  libodfgen
  libreoffice
  libreoffice-fresh
  libreoffice-fresh-unwrapped
  libreoffice-still
  libreoffice-still-unwrapped
  libreoffice-unwrapped
  libvisio
  libwpg
  natron
  numix-cursor-theme
  numix-solarized-gtk-theme
  odpdown
  plata-theme
  twemoji-color-font
  udiskie
  unoconv
  wpa_supplicant_gui

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/yj8i7yv8f7q63awma4m5kva0zanp190x-libwpg-0.3.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libwpg https://github.com/r-ryantm/nixpkgs/archive/2a55cb0e25c28e2c94d25add3e6e3e466ab3a138.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/yj8i7yv8f7q63awma4m5kva0zanp190x-libwpg-0.3.3
  ls -la /nix/store/yj8i7yv8f7q63awma4m5kva0zanp190x-libwpg-0.3.3/bin
  ```


  </details>
  <br/>


state: closed
title: libxl: 3.8.1 -> 3.8.4
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58317
updated_at: 2019-03-31 02:47:07
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libxl/versions.



  meta.description for libxl is: '"A lbrary for parsing excel files"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.8.4 with grep in /nix/store/p0w9cygrlnxb4wz5zrw3nhsak2r4wxda-libxl-3.8.4
  - directory tree listing: https://gist.github.com/8e6a193fd9da9ba6678f80393faf9c82
  - du listing: https://gist.github.com/89b55c70703cc39f4cf4ffd1fc5a75d0

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  11 total rebuild path(s)

  9 package rebuild(s)

  9 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  libxl
  php71Packages-unit.php_excel
  php71Packages.php_excel
  php72Packages-unit.php_excel
  php72Packages.php_excel
  php73Packages-unit.php_excel
  php73Packages.php_excel
  phpPackages-unit.php_excel
  phpPackages.php_excel

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/p0w9cygrlnxb4wz5zrw3nhsak2r4wxda-libxl-3.8.4 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libxl https://github.com/r-ryantm/nixpkgs/archive/e65b0ac616061f08934589af7c60cd0f6fea182d.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/p0w9cygrlnxb4wz5zrw3nhsak2r4wxda-libxl-3.8.4
  ls -la /nix/store/p0w9cygrlnxb4wz5zrw3nhsak2r4wxda-libxl-3.8.4/bin
  ```


  </details>
  <br/>


state: closed
title: lighttpd: 1.4.52 -> 1.4.53
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58318
updated_at: 2019-03-31 02:47:11
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lighttpd/versions.



  meta.description for lighttpd is: '"Lightweight high-performance web server"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.4.53 with grep in /nix/store/5llrxsw5sygiilr1pk0n4ycy094p3gzb-lighttpd-1.4.53
  - directory tree listing: https://gist.github.com/13cc8c077e5fc6e2772aaca016f68ad5
  - du listing: https://gist.github.com/78deabf4a58fad2b0cd38baf231847d8

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  lighttpd

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/5llrxsw5sygiilr1pk0n4ycy094p3gzb-lighttpd-1.4.53 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A lighttpd https://github.com/r-ryantm/nixpkgs/archive/239eef8a32b341deefcf59a45d7f930f1cde379c.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/5llrxsw5sygiilr1pk0n4ycy094p3gzb-lighttpd-1.4.53
  ls -la /nix/store/5llrxsw5sygiilr1pk0n4ycy094p3gzb-lighttpd-1.4.53/bin
  ```


  </details>
  <br/>


  cc @bjornfor for testing.


state: closed
title: idrisPackages: Fix linking to gmp library and cc
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58319
updated_at: 2019-05-04 21:50:53
body:
  Fixes https://github.com/NixOS/nixpkgs/issues/54579 and probably https://github.com/NixOS/nixpkgs/issues/52796

  Ping @ar1a @marsam @shmish111 @mpickering 

  This has been broken since 5d18129ce8af9a69312818ea0a5a0029a04a2255,
  which updated idris from 1.3.0 to 1.3.1, which included
  https://github.com/idris-lang/Idris-dev/pull/4472 as the cause of the
  error. I'm still not entirely sure why this broke it though.

  This way should be rather future proof, it uses NIX_CFLAGS to pass
  gpm link flags to our CC wrapper directly. The
  `NIX_CC_WRAPPER_${stdenv.cc.infixSalt}_TARGET_HOST` part I'm pretty sure
  is needed for the CC wrapper to know that those CFLAGS are meant for the
  cc running on the HOST.

  The second commit just switches to stdenv's cc.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: idrisPackages.glfw: Fix runtime
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58320
updated_at: 2019-04-28 14:53:33
body:
  Fixes https://github.com/NixOS/nixpkgs/issues/55086

  Ping @locallycompact 

  In order to run programs, pkgconfig needs to be present so it can tell
  it where to find glfw3 and gl.

  The general idris fix in https://github.com/NixOS/nixpkgs/pull/58319 is also needed for it to work

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qtstyleplugin-kvantum{,-qt4}: 0.10.x -> 0.11.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58321
updated_at: 2019-04-17 18:17:41
body:
  ###### Motivation for this change

  11% more kvantum, perhaps :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lsp-plugins: 1.1.5 -> 1.1.7
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58322
updated_at: 2019-04-14 04:56:38
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lsp-plugins/versions.



  meta.description for lsp-plugins is: '"Collection of open-source audio plugins"'.

  [Release on GitHub](https://github.com/sadko4u/lsp-plugins/releases/tag/lsp-plugins-1.1.7)


  [Compare changes on GitHub](https://github.com/sadko4u/lsp-plugins/compare/lsp-plugins-1.1.5...lsp-plugins-1.1.7)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1.7 with grep in /nix/store/55a6sxzw2hy8kivrn40lnn8l9dass8hr-lsp-plugins-1.1.7
  - directory tree listing: https://gist.github.com/32a4188267d149a77dc964d220db7f6e
  - du listing: https://gist.github.com/cfe753f8b3e8548c94c064d2b15f7b06

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  6 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  lsp-plugins
  pulseeffects

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/55a6sxzw2hy8kivrn40lnn8l9dass8hr-lsp-plugins-1.1.7 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A lsp-plugins https://github.com/r-ryantm/nixpkgs/archive/20a257754e97b480735b2cda0c737ec3b474a5fb.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/55a6sxzw2hy8kivrn40lnn8l9dass8hr-lsp-plugins-1.1.7
  ls -la /nix/store/55a6sxzw2hy8kivrn40lnn8l9dass8hr-lsp-plugins-1.1.7/bin
  ```


  </details>
  <br/>


  cc @magnetophon for testing.


state: closed
title: ltc-tools: 0.6.4 -> 0.7.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58323
updated_at: 2019-04-14 04:56:41
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ltc-tools/versions.



  meta.description for ltc-tools is: '"Tools to deal with linear-timecode (LTC)"'.

  [Release on GitHub](https://github.com/x42/ltc-tools/releases/tag/v0.7.0)


  [Compare changes on GitHub](https://github.com/x42/ltc-tools/compare/v0.6.4...v0.7.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.7.0 with grep in /nix/store/x27cmvpx4pjyha9mmrsdx6sr7azrwzq8-ltc-tools-0.7.0
  - directory tree listing: https://gist.github.com/fd6edad0600e5162b533242ced0ed787
  - du listing: https://gist.github.com/c65e90203a202583208f839803cdff68

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ltc-tools

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/x27cmvpx4pjyha9mmrsdx6sr7azrwzq8-ltc-tools-0.7.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ltc-tools https://github.com/r-ryantm/nixpkgs/archive/409f168b1795774759b93bed339531f861d5afcc.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/x27cmvpx4pjyha9mmrsdx6sr7azrwzq8-ltc-tools-0.7.0
  ls -la /nix/store/x27cmvpx4pjyha9mmrsdx6sr7azrwzq8-ltc-tools-0.7.0/bin
  ```


  </details>
  <br/>


  cc @tg-x for testing.


state: closed
title: khal: 0.9.10 -> 0.10.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58324
updated_at: 2019-03-31 18:36:31
body:
  ###### Motivation for this change

  https://github.com/pimutils/khal/releases/tag/v0.10.0

  * new dep, click-log
  * enable tests (pass!)

  Release notes mention 'only dateutil < 2.7 is supported',
  which may be a problem as ours is currently 2.8.

  There's a history of python-dateutil version particularity
  in previous releases (such as 0.9.10 upgrading from),
  unsure if should override to older or if it's just a suggestion.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lxrandr: 0.3.1 -> 0.3.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58325
updated_at: 2019-03-31 02:47:20
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/lxrandr/versions.



  meta.description for lxrandr is: '"LXRandR is the standard screen manager of LXDE."'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.3.2 with grep in /nix/store/715qpnfk1mrvrc4s2rsp35n2b4rqpa8z-lxrandr-0.3.2
  - directory tree listing: https://gist.github.com/63a8a5cc5f922732f46d36276a165734
  - du listing: https://gist.github.com/77daad7a857ad6d387004e304037fcd3

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  lxrandr

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/715qpnfk1mrvrc4s2rsp35n2b4rqpa8z-lxrandr-0.3.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A lxrandr https://github.com/r-ryantm/nixpkgs/archive/0b47bc2957179eddbc97885d706348fd1e217465.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/715qpnfk1mrvrc4s2rsp35n2b4rqpa8z-lxrandr-0.3.2
  ls -la /nix/store/715qpnfk1mrvrc4s2rsp35n2b4rqpa8z-lxrandr-0.3.2/bin
  ```


  </details>
  <br/>


  cc @rawkode for testing.


state: closed
title: pythonPackages.pyarrow: fix build
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/58326
updated_at: 2019-03-27 01:18:40
body:
  ###### Motivation for this change

  Fixes pyarrow build.
  cc #56826

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: all-packages: try `with`ing spliced packages.
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/58327
updated_at: 2019-03-27 01:49:29
body:
  ###### Motivation for this change

  This is an experiment. On one hand, it should unbreak some cross things,
  on the other, if `inherit` is used for things other than overriding it
  will lead to "doubly spliced" packages, which is an insane mess.

  CC @matthewbauer

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffsend: 0.2.39 -> 0.2.42
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/58328
updated_at: 2019-04-04 21:44:45
body:
  ###### Motivation for this change
  https://github.com/timvisee/ffsend/releases/tag/v0.2.42

  Add support for `xsel` instead of `xclip` on Linux.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [X] other Linux distributions (Linux via the `nixos/nix` Docker image)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  In the Linux Docker image I tested both with and without the `preferXsel` arg.


state: closed
title: Add vim plugin vim-beancount
user_login: siriobalmelli
html_url: https://github.com/NixOS/nixpkgs/pull/58329
updated_at: 2019-04-18 17:53:24
body:
  Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>

  ###### Motivation for this change

  Needed beancount syntax support; added this to vim-plugins as per usual

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: TI MSP430 cross compiling
user_login: AerialX
html_url: https://github.com/NixOS/nixpkgs/pull/58330
updated_at: 2019-03-30 01:30:07
body:
  ###### Motivation for this change

  Enables compiling for MSP430 microcontrollers.

  ###### Remaining unsure points

  - [ ] Is `fetchzip` appropriate here or is `fetchurl` better to use when the archive is likely an archive that won't superficially change?
  - [ ] Should `msp430GccSupport` be included in stdenv or should it just be expected to be added to `buildInputs` of any packages targeting msp430 devices?
    - For reference, the `msp430GccSupport` package contains headers, symbols, and linker scripts for the registers and memory layout of each of the hundreds of MSP430 SKUs.
    - Using the `-mmcu=` flag with gcc will pull in the appropriate ldscript and header, so I'm assuming this should be included in gcc, libc, or stdenv in some way.
  - [ ] Is the current approach (symlink wrapper derivation to combine support files with newlib) the correct idiom to use here? Is there some better way to add the support files as additional default cflags/ldflags search paths for stdenv?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mandoc: 1.14.4 -> 1.14.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58331
updated_at: 2019-04-14 04:56:50
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/mandoc/versions.



  meta.description for mandoc is: '"suite of tools compiling mdoc and man"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/3126111c1ea0c40ca4480072fdd93db8
  - du listing: https://gist.github.com/4eac6160fd8559be29b1f6b3042dda72

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  630 total rebuild path(s)

  569 package rebuild(s)

  22 x86_64-linux rebuild(s)
  22 i686-linux rebuild(s)
  564 x86_64-darwin rebuild(s)
  22 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  altcoins.bitcoin-abc
  altcoins.bitcoin-classic
  altcoins.bitcoin-unlimited
  altcoins.bitcoin-xt
  altcoins.bitcoind-abc
  altcoins.bitcoind-classic
  altcoins.bitcoind-unlimited
  altcoins.bitcoind-xt
  altcoins.dashpay
  altcoins.litecoin
  altcoins.litecoind
  aws-sam-cli
  backintime-common
  beancount
  bepasty
  bindfs
  bitcoin-xt
  bsdbuild
  btrbk
  calc
  ceph
  ceph-dev
  chronos
  cloud-init
  cloud-utils
  cookiecutter
  cozy
  doitlive
  dotfiles
  elasticsearch
  elasticsearch-curator
  elasticsearch-oss
  elasticsearch5
  elasticsearch6
  elasticsearch6-oss
  elasticsearchPlugins.discovery-ec2
  elasticsearchPlugins.elasticsearch_analysis_lemmagen
  elasticsearchPlugins.search_guard
  elmPackages.elm
  emscripten
  fava
  fdroidserver
  firefox-unwrapped
  firefoxPackages.firefox
  flexget
  fuse-overlayfs
  gandi-cli
  gazebo
  gazebo-headless
  gazeboSimulator.gazebo6

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/2q5cssi1dy65ybijxxar6r4c5m4g57jx-mandoc-1.14.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A mandoc https://github.com/r-ryantm/nixpkgs/archive/73d1ae2cbfa246a1feda02dfcaa10d60fcfbdef7.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/2q5cssi1dy65ybijxxar6r4c5m4g57jx-mandoc-1.14.5
  ls -la /nix/store/2q5cssi1dy65ybijxxar6r4c5m4g57jx-mandoc-1.14.5/bin
  ```


  </details>
  <br/>


  cc @bb010g @ramkromberg for testing.


state: closed
title: masterpdfeditor: 5.2.20 -> 5.3.22
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58332
updated_at: 2019-03-31 02:47:34
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/masterpdfeditor/versions.



  meta.description for masterpdfeditor is: '"Master PDF Editor"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 5.3.22 with grep in /nix/store/f9ymxyy680zcmsz64ma1qwaishscqlzw-masterpdfeditor-5.3.22
  - directory tree listing: https://gist.github.com/38a8ca618baed37966827ea5942abeff
  - du listing: https://gist.github.com/f31a20f9dcab4b23caf06fc388b2fbd6

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  0 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  0 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  masterpdfeditor

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/f9ymxyy680zcmsz64ma1qwaishscqlzw-masterpdfeditor-5.3.22 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A masterpdfeditor https://github.com/r-ryantm/nixpkgs/archive/7f1a7b1d7dccf7cc758196c70c9c0d9b37e31bfb.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/f9ymxyy680zcmsz64ma1qwaishscqlzw-masterpdfeditor-5.3.22
  ls -la /nix/store/f9ymxyy680zcmsz64ma1qwaishscqlzw-masterpdfeditor-5.3.22/bin
  ```


  </details>
  <br/>


  cc @cmcdragonkai @flokli for testing.


state: closed
title: matomo: 3.8.1 -> 3.9.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58333
updated_at: 2019-04-01 18:34:29
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/matomo/versions.



  meta.description for matomo is: '"A real-time web analytics application"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.9.0 with grep in /nix/store/w739rw9pjcb4mxcjhw94znjypiwh2srl-matomo-3.9.0
  - directory tree listing: https://gist.github.com/c9bc18ca05fbf8ab2bbca669c5cc4862
  - du listing: https://gist.github.com/c625408a7dee735e3798c54e8251209d

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  matomo

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/w739rw9pjcb4mxcjhw94znjypiwh2srl-matomo-3.9.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A matomo https://github.com/r-ryantm/nixpkgs/archive/139243406b186ede9e389f5acd6c120123a9b1ed.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/w739rw9pjcb4mxcjhw94znjypiwh2srl-matomo-3.9.0
  ls -la /nix/store/w739rw9pjcb4mxcjhw94znjypiwh2srl-matomo-3.9.0/bin
  ```


  </details>
  <br/>


  cc @florianjacob for testing.


state: closed
title: matio: 1.5.13 -> 1.5.14
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58334
updated_at: 2019-03-31 02:47:37
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/matio/versions.



  meta.description for matio is: '"A C library for reading and writing Matlab MAT files"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.5.14 with grep in /nix/store/043mfbysy2id989g7d7bj6w30snwds3d-matio-1.5.14
  - directory tree listing: https://gist.github.com/ab04f83001842d53324c3327453e55f5
  - du listing: https://gist.github.com/db6ba4e5c2eb8e938f6e85ccd6cbaf12

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  kst
  matio

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/043mfbysy2id989g7d7bj6w30snwds3d-matio-1.5.14 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A matio https://github.com/r-ryantm/nixpkgs/archive/899b79aa017a934c0e11338c72f7b31f91e9e297.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/043mfbysy2id989g7d7bj6w30snwds3d-matio-1.5.14
  ls -la /nix/store/043mfbysy2id989g7d7bj6w30snwds3d-matio-1.5.14/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: mdk: 1.2.9 -> 1.2.10
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58335
updated_at: 2019-03-31 02:45:09
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnu-mdk/versions.



  meta.description for mdk is: '"GNU MIX Development Kit (MDK)"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.2.10 with grep in /nix/store/aknfvmlz7q0vw81xv1dqsdy05pv5vqq0-gnu-mdk-1.2.10
  - directory tree listing: https://gist.github.com/74a0ae280e9e4922c576de8bb963b55e
  - du listing: https://gist.github.com/5fd971bad12caad1d12f225172654860

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  mdk

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/aknfvmlz7q0vw81xv1dqsdy05pv5vqq0-gnu-mdk-1.2.10 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A mdk https://github.com/r-ryantm/nixpkgs/archive/dfad2e2a2d94e78e2f0ee464c9f8318e66a57bca.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/aknfvmlz7q0vw81xv1dqsdy05pv5vqq0-gnu-mdk-1.2.10
  ls -la /nix/store/aknfvmlz7q0vw81xv1dqsdy05pv5vqq0-gnu-mdk-1.2.10/bin
  ```


  </details>
  <br/>


state: closed
title: nixos/prometheus: add tls_config option
user_login: thatsmydoing
html_url: https://github.com/NixOS/nixpkgs/pull/58337
updated_at: 2019-03-29 06:37:55
body:
  ###### Motivation for this change
  The option was notably missing and has existed since Prometheus 1.8 and later.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: monit: 5.25.2 -> 5.25.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58338
updated_at: 2019-03-31 02:47:53
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/monit/versions.



  meta.description for monit is: '"Monitoring system"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 5.25.3 with grep in /nix/store/gfq4ib15inrx47ybj7h5kbndxxlsrn6v-monit-5.25.3
  - directory tree listing: https://gist.github.com/8acb3cedf747c8a2cdcff246c06d8f97
  - du listing: https://gist.github.com/41b5d52dca742d75e4b5d0ef7c057d94

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  monit

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/gfq4ib15inrx47ybj7h5kbndxxlsrn6v-monit-5.25.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A monit https://github.com/r-ryantm/nixpkgs/archive/79ed374fdeb9224c02d2ecb27f3a773bcaf48d42.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/gfq4ib15inrx47ybj7h5kbndxxlsrn6v-monit-5.25.3
  ls -la /nix/store/gfq4ib15inrx47ybj7h5kbndxxlsrn6v-monit-5.25.3/bin
  ```


  </details>
  <br/>


  cc @7c6f434c @wmertens for testing.


state: closed
title: ms-sys: 2.5.3 -> 2.6.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58339
updated_at: 2019-03-31 02:47:56
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ms-sys/versions.



  meta.description for ms-sys is: '"A program for writing Microsoft-compatible boot records"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.6.0 with grep in /nix/store/qzbbx0l7lvjbyr3zs1qxgslc2snwl8rc-ms-sys-2.6.0
  - directory tree listing: https://gist.github.com/8212431782903db01b18839f6e25ea62
  - du listing: https://gist.github.com/0ee59edb5eff23515aefa215d5f48530

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ms-sys

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/qzbbx0l7lvjbyr3zs1qxgslc2snwl8rc-ms-sys-2.6.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ms-sys https://github.com/r-ryantm/nixpkgs/archive/f6efbc1fdc371386444a91ece62519a1493dddda.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/qzbbx0l7lvjbyr3zs1qxgslc2snwl8rc-ms-sys-2.6.0
  ls -la /nix/store/qzbbx0l7lvjbyr3zs1qxgslc2snwl8rc-ms-sys-2.6.0/bin
  ```


  </details>
  <br/>


state: closed
title: zola: 0.5.1 -> 0.6.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/58340
updated_at: 2019-03-27 07:32:00
body:
  [changelog](https://github.com/getzola/zola/blob/master/CHANGELOG.md#060-2019-03-25)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [WIP] ghc.withPackages: can add user arguments to wrapper
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/58341
updated_at: 2019-03-28 05:07:31
body:
  ###### Motivation for this change
  I am trying to debug a haskell library used by my program. Everytime I change this library, I need to relaunch the nix-shell of my haskell program to get an up to date ghc environment.
  My idea is to wrap the GHC with an `-i/local/lib/we/debug`. Because the library I debug is also in NIX_GHC_LIBDIR, I wonder if I can prefix NIX_GHC_LIBDIR so that ghc picks the debug version over the one in the environment. 
  If there is a better way let me know.

  One difficulty is I am not sure how to pass `postBuild`, `makeWrapper` args to withPackages, the feature seem unused ?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: drawpile: 2.1.3 -> 2.1.4
user_login: fgaz
html_url: https://github.com/NixOS/nixpkgs/pull/58342
updated_at: 2019-03-27 10:52:31
body:
  ###### Motivation for this change

  https://drawpile.net/news/release-2.1.4/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: beamPackages.hex: 0.17.1 -> 0.20.1
user_login: peterromfeldhk
html_url: https://github.com/NixOS/nixpkgs/pull/58343
updated_at: 2019-07-03 11:24:40
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [itsx] init at 1.1.1
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58344
updated_at: 2019-03-26 10:16:08
body:
  ###### Motivation for this change
  Perl script needed into our computing center for biologists

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: add finalImageName parameter for pullImage
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/pull/58345
updated_at: 2019-03-28 15:25:02
body:
  ###### Motivation for this change

  I need to change image name.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/kubernetes: add local path provisioner addon
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/pull/58346
updated_at: 2019-03-26 10:09:25
body:
  ###### Motivation for this change

  I need local storage for tests

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tzdata: 2018g -> 2019a
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58347
updated_at: 2019-03-27 08:41:17
body:
  ###### Motivation for this change

  Upstream released a new version.

  http://mm.icann.org/pipermail/tz-announce/2019-March/000055.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] tzdata: 2018g -> 2019a
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58348
updated_at: 2019-03-27 08:34:16
body:
  ###### Motivation for this change

  Backport to 19.03 of #58347

  Upstream released a new version.

  http://mm.icann.org/pipermail/tz-announce/2019-March/000055.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] tzdata: 2018g -> 2019a
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58349
updated_at: 2019-03-27 08:30:33
body:
  ###### Motivation for this change

  Backport to 18.09 of #58347

  Upstream released a new version.

  http://mm.icann.org/pipermail/tz-announce/2019-March/000055.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: storePathToLayer use runtimeShell in script
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/pull/58350
updated_at: 2019-04-06 17:06:10
body:
  ###### Motivation for this change

  Just a fix so docker images correctly build on systems that are not nixos based

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] thunderbird: 60.5.1 -> 60.6.0
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58352
updated_at: 2019-04-12 14:05:29
body:
  ###### Motivation for this change

  Backport of the backport #58034  :-)

  cc @Mic92 @taku0 

  I haven't built it yet - lack of (mobile) computation power & no access to private keys..

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clementine: update to qt5
user_login: marius851000
html_url: https://github.com/NixOS/nixpkgs/pull/58353
updated_at: 2019-03-27 08:41:02
body:
  ###### Motivation for this change
  thinked that qt5 was able to automatically include transparency in application. not the case, but having qt5 rather qt4 should be better.

  ###### Things done

  replaced qt4 by qt5, with libsforqt5.callpackage rather than just callpackage
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aragorn: init at 1.2.38
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58354
updated_at: 2019-04-29 11:18:05
body:
  ###### Motivation for this change
  Soft needed by the biologists using our computing center (GRICAD) 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] ghostscript: add patch for CVE-2019-6116
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58355
updated_at: 2019-03-28 22:45:27
body:
  ###### Motivation for this change

  Backport of #58314

  This is tagged as version 9.26a in the ghostpdl repo, but unfortunately
  there are no tarballs released with that version number so far. We'll
  continue calling this version 9.26 for now for simplicity's sake (and we
  can switch to 9.26a and remove the patch when it's properly released).

  Fixes #58262
  Fixes #58089

  (cherry picked from commit 91c46d17d5c8b3a69cbae62d91290e53168fe9d2)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sabnzbd: 2.3.7 -> 2.3.8
user_login: rembo10
html_url: https://github.com/NixOS/nixpkgs/pull/58357
updated_at: 2019-03-30 23:34:55
body:
  ###### Motivation for this change
  Minor version bump

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.re2: fix build on darwin
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/58359
updated_at: 2019-04-02 07:37:35
body:
  ###### Motivation for this change

  Fixes #58178

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: add nix-prefetch-docker script
user_login: offlinehacker
html_url: https://github.com/NixOS/nixpkgs/pull/58360
updated_at: 2019-04-06 17:21:36
body:
  ###### Motivation for this change

  Have a sane way to get output hash for `dockerTools.pullImage`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.cartopy: fix build
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/58361
updated_at: 2019-04-08 00:04:33
body:
  ###### Motivation for this change
  fallout of https://github.com/NixOS/nixpkgs/pull/54182


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @mredaelli 


state: closed
title: cd-hit: init at 4.8.1
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58362
updated_at: 2019-06-14 00:39:55
body:
  ###### Motivation for this change
  Biology tool needed in our computing center (GRICAD)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ X Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.stdint: 0.5.0 -> 0.5.1
user_login: rixed
html_url: https://github.com/NixOS/nixpkgs/pull/58363
updated_at: 2019-03-27 14:15:03
body:
  ###### Motivation for this change

  I need the bugfixes present in 0.5.1

  ###### Things done

  Notice that the build system has (unfortunately) been changed from makefile to jbuilder which is a
  builder that's been deprecated already. Still, given the right command line dune (its successor)
  manage to build the thing, if not without some warnings.
  Also, the fstar compiler, that uses stdint, does not built ; but it's already broken in master (with the same error message).

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review `~~wip~~` rev HEAD"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Terraform 1.60.0
user_login: memberbetty
html_url: https://github.com/NixOS/nixpkgs/issues/58364
updated_at: 2019-07-08 15:47:51
body:
  ## Issue description
  https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#provider-version-configuration requires version `1.60.0`, which is not packaged anywhere in nixpkgs, but is recommended for an upgrade process.

  ### Steps to reproduce

  ## Technical details
  I am reporting this for 18.09, and master in that order of preference.


state: closed
title: vlc: Add chromecast support
user_login: shazow
html_url: https://github.com/NixOS/nixpkgs/issues/58365
updated_at: 2019-04-01 15:16:43
body:
  The current vlc derivation does not include chromecast support.

  I believe we need to add the flags `--enable-sout --enable-chromecast` during the configuration step to enable it by default, which I think is a reasonable thing to do.

  I tried to do the minimal change myself, but looks like we need some new dependencies that don't exist in nixpkg yet:

  ```diff
  diff --git a/pkgs/applications/video/vlc/default.nix b/pkgs/applications/video/vlc/default.nix
  index cd3999e38c0..777e302e8e5 100644
  --- a/pkgs/applications/video/vlc/default.nix
  +++ b/pkgs/applications/video/vlc/default.nix
  @@ -76,6 +76,8 @@ stdenv.mkDerivation rec {
     # "--enable-foo" flags here
     configureFlags = [
       "--with-kde-solid=$out/share/apps/solid/actions"
  +    "--enable-sout"
  +    "--enable-chromecast"
     ] ++ optional onlyLibVLC "--disable-vlc";
  ```

  ```
  $ nix-env -i vlc -f $PWD
  ...
  checking for protoc... no
  checking for protobuf-lite >= 2.5.0... no
  configure: error: Library protobuf-lite >= 2.5.0 needed for chromecast was not found
  builder for '/nix/store/n8ky60h4n2r67agrgag5m5znijk2df59-vlc-3.0.6.drv' failed with exit code 1
  ```

  I'm still fairly new so it will take some learning to figure out what needs to be done to package protobuf-lite (not sure I'll get around to it anytime soon).

  If anyone else is into making these changes, it would be much appreciated. Or please let me know if I'm off-track here and there's a better way to do this.


state: closed
title: commit for u-boot build of bananapim64
user_login: samrose
html_url: https://github.com/NixOS/nixpkgs/pull/58366
updated_at: 2019-04-24 20:50:02
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: poedit: 1.5.7 -> 2.2.1
user_login: bignaux
html_url: https://github.com/NixOS/nixpkgs/pull/58367
updated_at: 2019-03-30 09:43:34
body:
  ###### Motivation for this change

  poedit was not updated since 2013.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/58368
updated_at: 2019-04-25 01:42:40
title:
   timescaledb: 1.0.0 -> 1.2.2, timescaledb-parallel-copy: 2018-05-14 -> 0.2.0, timescaledb-tune: init at 0.5.0

body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clustal-omega: init at 1.2.4
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58369
updated_at: 2019-05-18 10:16:44
body:
  ###### Motivation for this change
  Tool for biologists using our computing center (GRICAD)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: WIP: Add plasma-phone package
user_login: Slabity
html_url: https://github.com/NixOS/nixpkgs/pull/58370
updated_at: 2019-07-16 02:34:39
body:
  ###### Motivation for this change
  This is a work in progress for getting plasma-mobile software working in NixOS.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libjpeg-turbo: 2.0.1 -> 2.0.2, cleanup
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58374
updated_at: 2019-05-08 12:34:44
body:
  ###### Motivation for this change

  https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.0.2

  * patches included, drop
  * use installCheck to avoid needing to set LD_LIBRARY_PATH

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grpc does not produce shared libraries
user_login: sballert
html_url: https://github.com/NixOS/nixpkgs/issues/58375
updated_at: 2019-04-04 18:37:40
body:
  ## Issue description
  If I try to use the grpc package from the current unstable channel, then this builds only the static libraries.

  ```
  > ls /nix/store/83xh6xap4l4x5xqynwb7fbkf1bf2xcqa-grpc-1.18.0/lib/  
       
  cmake                    
  libaddress_sorting.a     
  libgpr.a                 
  libgrpc.a                
  libgrpc++.a              
  libgrpc_cronet.a         
  libgrpc++_cronet.a       
  libgrpc_csharp_ext.so    
  libgrpc++_error_details.a
  libgrpc_plugin_support.a 
  libgrpcpp_channelz.a     
  libgrpc++_reflection.a   
  libgrpc_unsecure.a       
  libgrpc++_unsecure.a                  
  ```

  I tried to add `"-DBUILD_SHARED_LIBS=ON"` to the `cmakeFlags`, then cmake tries to build the shared libraries, but fails with the following error:

  ```
  ....
  [ 81%] Building CXX object CMakeFiles/grpc++_cronet.dir/src/cpp/server/health/health_check_ser
  vice.cc.o                                                                                    
  [ 81%] Running gRPC C++ protocol buffer compiler on src/proto/grpc/channelz/channelz.proto
  /home/sballert/projects/grpc-helloworld/pkgs/source/build/grpc_cpp_plugin: error while loading
   shared libraries: libgrpc_plugin_support.so: cannot open shared object file: No such file or 
  directory                                                                                    
  --grpc_out: protoc-gen-grpc: Plugin failed with status code 127.
  make[2]: *** [CMakeFiles/grpcpp_channelz.dir/build.make:64: gens/src/proto/grpc/channelz/chann
  elz.grpc.pb.cc] Error 1                                                                      
  make[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/grpcpp_channelz.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....
  [ 81%] Building CXX object CMakeFiles/grpc++_cronet.dir/src/cpp/server/health/health_check_ser
  vice_server_builder_option.cc.o     
  ...
  ```

  Maybe this is an grpc issue?

  ### Steps to reproduce

  ```
  with import <nixpkgs> {};

  stdenv.mkDerivation {
    name = "helloworld";
    buildInputs = [ grpc ];
  }
  ```


  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.30, NixOS, 19.09pre173166.373488e6f4c (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre173166.373488e6f4c"`
   - channels(sballert): `"home-manager"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: cmocka: 1.1.1 -> 1.1.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58376
updated_at: 2019-03-26 21:11:48
body:
  ###### Motivation for this change

  1.1.2: https://cmocka.org/archive/cmocka/2018-08/0000003.html
  1.1.3: https://cmocka.org/archive/cmocka/2018-09/0000000.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: exonerate: init at 2.4.0
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58377
updated_at: 2019-04-19 17:25:59
body:
  ###### Motivation for this change
  Tool for biologists using our computing center

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: waybar: 0.4.0 -> 0.5.0
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/58378
updated_at: 2019-04-10 11:24:30
body:
  ###### Motivation for this change

  Bigger version numbers are better.
  https://github.com/Alexays/Waybar/releases/tag/0.5.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: doc missing: How to use releaseTools.debBuild?
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/issues/58379
updated_at: 2019-04-03 07:44:56
body:
  ## Issue description

  I'm trying to build a debian package out of a nix package. I have:

  ```nix
  let
    pkgs = (import ./default.nix);
    vm   = pkgs.vmTools.diskImageFuns.debian8x86_64 {};
    args = {
      diskImage = vm;
       src  = pkgs.vim;
     };
  in
  pkgs.releaseTools.debBuild args
  ```

  but I get:

  `error: value is a function while a set was expected, at /home/user/nixpkgs/vimdeb.nix:11:2`

  I feel that documentation is missing on how to properly use that function (also same for `releaseTools.rpmBuild`.

  ### Steps to reproduce

  Save the above expression as `vimdeb.nix` and call it with `nix-build ./vimdeb.nix`

  ## Technical details


   - system: `"x86_64-linux"`
   - host os: `Linux 3.10.0-957.el7.x86_64, CentOS Linux, 7 (Core)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.1`
   - channels(user): `"nixpkgs-19.09pre173445.796a8764ab8"`
   - nixpkgs: `/home/user/.nix-defexpr/channels/nixpkgs`


  ---

  Also: Can someone help me building direct and transitive dependencies from nixpkgs package expressions as deb or rpm packages?


state: open
title: talloc: 2.1.14 -> 2.2.0, also update tevent,ldb,tdb
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58380
updated_at: 2019-06-19 12:12:32
body:
  ###### Motivation for this change

  Includes cmocka update (submitted separately)
  since new version of ldb requires it.

  python inputs are used to execute the build (waf)
  but we also expect python bindings to be created
  and installed, set inputs accordingly.

  Need to check how this works re:cross,
  feedback and help testing appreciated :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnupg: 2.2.14 -> 2.2.15
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58381
updated_at: 2019-03-26 19:14:38
body:
  ###### Motivation for this change

  https://dev.gnupg.org/T4434

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ghidraDev misc issues (WIP)
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/58382
updated_at: 2019-04-23 20:19:11
body:
  Note: this issue isn't formatted well, I just needed to dump the info, will clean up later

  The ghidraDev plugin works with a sufficiently new eclipse (4.10 I think?), which can be retrieved from a sufficiently new nixpkgs. There is a gdk problem currently causing a lot of segfaults, which is worked around by the unset.

  `unset GDK_PIXBUF_MODULE_FILE; nix-shell -I "nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz" -p eclipses.eclipse-java`

  _Originally posted by @deliciouslytyped in https://github.com/NixOS/nixpkgs/pull/56959#issuecomment-474289837_

  - [ ] Creating a new Ghidra Module project will fail with `IOError: Failed to find skeleton directory.` if you use nix-build and specify a path like `/home/user/ghidra/result`. My hypothesis is that symlinks are not followed properly. Specifying a direct path to the nix store is successful.
  - [ ] Deal with something like server/svrInstall and the other server dir stuff?
  - [ ] TODO: add some sort of eclipse plugin output to the expression (its just a zip file in a subdir)
  - [ ] TODO: ghidraWithPlugins ?


state: closed
title: samim-fonts: init at 3.1.0
user_login: LinArcX
html_url: https://github.com/NixOS/nixpkgs/pull/58383
updated_at: 2019-03-31 18:03:49
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qmmp: 1.2.5 -> 1.3.1
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/58384
updated_at: 2019-03-26 17:54:49
body:
  ###### Motivation for this change

  cc @bjornfor

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: turses: fix crash when starting with existing config file
user_login: booxter
html_url: https://github.com/NixOS/nixpkgs/pull/58386
updated_at: 2019-03-27 20:18:54
body:
  Fixes #57460

  (cherry picked from commit 6f525a52d0e4a172397450ff11afa3f47e29442c)

  Conflicts:
  	pkgs/applications/networking/instant-messengers/turses/default.nix


state: closed
title: gpgme: 1.12.0 -> 1.13.0
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/58387
updated_at: 2019-03-26 19:07:42
body:
  Upstream release information: https://dev.gnupg.org/T4376

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gpgme: 1.12.0 -> 1.13.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58388
updated_at: 2019-03-26 23:50:33
body:
  ###### Motivation for this change

  https://lists.gnupg.org/pipermail/gnupg-announce/2019q1/000437.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Can't execute Meshroom
user_login: TrevtheForthDev
html_url: https://github.com/NixOS/nixpkgs/issues/58389
updated_at: 2019-06-11 20:44:40
body:
  ## Issue description
  I'm trying to create an environment for Meshroom. I already ran all of the patchelf stuff, and got all of the packages I need. I run ```nix-shell -p binutils stdenv wget dpkg nix-index stdenv.cc zlib python3.out glibc.out``` and try to execute Meshroom, and it throws the error:
  `Fatal Python error: Py_Initialize: Unable to get the locale encoding
  Traceback (most recent call last):
    File "/opt/rh/rh-python36/root/usr/lib64/python3.6/encodings/__init__.py", line 31, in <module>
  zipimport.ZipImportError: can't decompress data; zlib not available
  Aborted`

  ### Steps to reproduce
  `nix-shell -p binutils stdenv wget dpkg nix-index stdenv.cc zlib python3.out glibc.out`
  `./Meshroom`
  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.31, NixOS, 18.09.2394.2d656a97297 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(trev): `""`
   - channels(root): `"nixos-18.09.2394.2d656a97297, nixos-hardware, unstable-19.03pre167858.f2a1a4e93be"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: musescore: 3.0.1 -> 3.0.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58390
updated_at: 2019-03-31 02:47:59
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/musescore/versions.



  meta.description for musescore is: '"Music notation and composition software"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.0.5 with grep in /nix/store/s30g7r6x3ahlyx7iqhrj0jjwqr1w1pi3-musescore-3.0.5
  - directory tree listing: https://gist.github.com/f4ad65f29ab34a679480375df426c825
  - du listing: https://gist.github.com/af08ee04b349ad9b012e0dd8f0563f8a

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  musescore

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/s30g7r6x3ahlyx7iqhrj0jjwqr1w1pi3-musescore-3.0.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A musescore https://github.com/r-ryantm/nixpkgs/archive/46c1867c185c631f323bc8ba9166eb0879e22d71.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/s30g7r6x3ahlyx7iqhrj0jjwqr1w1pi3-musescore-3.0.5
  ls -la /nix/store/s30g7r6x3ahlyx7iqhrj0jjwqr1w1pi3-musescore-3.0.5/bin
  ```


  </details>
  <br/>


  cc @vandenoever for testing.


state: closed
title: nbd: 3.18 -> 3.19
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58391
updated_at: 2019-03-31 02:48:08
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nbd/versions.



  meta.description for nbd is: '"Map arbitrary files as block devices over the network"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.19 with grep in /nix/store/01swjqvf703mdaj2y6pw0mp9i73fsql1-nbd-3.19
  - directory tree listing: https://gist.github.com/ec236126c1b38a5d0d14bce03ac0c413
  - du listing: https://gist.github.com/fb2fa6479e2b8a9588f5c3d30e1d03c1

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  63 total rebuild path(s)

  37 package rebuild(s)

  37 x86_64-linux rebuild(s)
  13 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  13 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  gnome3.gnome-boxes
  libguestfs
  libvirt-glib
  libvmi
  nbd
  python27Packages.guestfs
  python37Packages.guestfs
  qemu_xen
  qemu_xen-light
  qemu_xen_4_10
  qemu_xen_4_10-light
  qemu_xen_4_8
  qemu_xen_4_8-light
  vagrant
  virt-viewer
  virtmanager
  xen
  xen-light
  xen-slim
  xenPackages.xen-light
  xenPackages.xen-slim
  xenPackages.xen-vanilla
  xenPackages.xen_4_10-light
  xenPackages.xen_4_10-slim
  xenPackages.xen_4_10-vanilla
  xenPackages.xen_4_5-light
  xenPackages.xen_4_5-slim
  xenPackages.xen_4_5-vanilla
  xenPackages.xen_4_8-light
  xenPackages.xen_4_8-slim
  xenPackages.xen_4_8-vanilla
  xen_4_10
  xen_4_10-light
  xen_4_10-slim
  xen_4_8
  xen_4_8-light
  xen_4_8-slim

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/01swjqvf703mdaj2y6pw0mp9i73fsql1-nbd-3.19 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A nbd https://github.com/r-ryantm/nixpkgs/archive/ad70015295650547062c8aeb7fb8dd5a96e41f87.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/01swjqvf703mdaj2y6pw0mp9i73fsql1-nbd-3.19
  ls -la /nix/store/01swjqvf703mdaj2y6pw0mp9i73fsql1-nbd-3.19/bin
  ```


  </details>
  <br/>


  cc @peti for testing.


state: closed
title: Update JetBrains IDEs
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/pull/58392
updated_at: 2019-03-29 11:46:43
body:
  ###### Motivation for this change

  Updated to the latest versions with the `update.pl` script, though I didn't include the latest version of Webstorm as I got errors from it.

  <details>

  ```shell
  $ nixpkgs> webstorm 

  (java:13232): Gtk-WARNING **: 19:49:29.377: Unable to locate theme engine in module_path: "adwaita",

  (java:13232): Gtk-WARNING **: 19:49:29.382: Unable to locate theme engine in module_path: "adwaita",
  #
  # A fatal error has been detected by the Java Runtime Environment:
  #
  #  SIGSEGV (0xb) at pc=0x00007f5777f61074, pid=13232, tid=0x00007f5740780700
  #
  # JRE version: OpenJDK Runtime Environment (8.0_152-b06) (build 1.8.0_152-release-1248-b6)
  # Java VM: OpenJDK 64-Bit Server VM (25.152-b6 mixed mode linux-amd64 compressed oops)
  # Problematic frame:
  # C  [libc.so.6+0x132074]  __memcpy_ssse3+0x19f4
  #
  # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
  #
  # An error report file with more information is saved as:
  # /home/sondre/java_error_in_WEBIDE_13232.log
  #
  # If you would like to submit a bug report, please visit:
  #   http://bugreport.java.com/bugreport/crash.jsp
  # The crash happened outside the Java Virtual Machine in native code.
  # See problematic frame for where to report the bug.
  #
  /nix/store/9p5z9x97i45krqjb96rp55vf19bn3crf-webstorm-2019.1/webstorm-2019.1/bin/webstorm.sh: line 213: 13232 Aborted                 "$JAVA_BIN" -classpath "$CLASSPATH" ${VM_OPTIONS} "-XX:ErrorFile=$HOME/java_error_in_WEBIDE_%p.log" "-XX:HeapDumpPath=$HOME/java_error_in_WEBIDE.hprof" -Didea.paths.selector=WebStorm2019.1 "-Djb.vmOptionsFile=$VM_OPTIONS_FILE" ${IDE_PROPERTIES_PROPERTY} -Didea.platform.prefix=WebStorm com.intellij.idea.Main "$@"
  ```

  </details>

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ncompress: 4.2.4.4 -> 4.2.4.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58393
updated_at: 2019-03-31 02:48:11
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ncompress/versions.



  meta.description for ncompress is: '"A fast, simple LZW file compressor"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 4.2.4.5 with grep in /nix/store/jk7l2ca7g7m426dq9gyh5ffp00h2jzfl-ncompress-4.2.4.5
  - directory tree listing: https://gist.github.com/abb33dd63fd921b17445a5c56122f383
  - du listing: https://gist.github.com/2d796ffda054eed38c6025c1aee6fdfb

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  22 total rebuild path(s)

  7 package rebuild(s)

  6 x86_64-linux rebuild(s)
  6 i686-linux rebuild(s)
  5 x86_64-darwin rebuild(s)
  5 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ncompress
  python27Packages.binwalk
  python27Packages.binwalk-full
  python37Packages.binwalk
  python37Packages.binwalk-full
  soulseekqt
  stalin

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/jk7l2ca7g7m426dq9gyh5ffp00h2jzfl-ncompress-4.2.4.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ncompress https://github.com/r-ryantm/nixpkgs/archive/aeae1a386831e1b1297dbdb7d96fee58d651cf88.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/jk7l2ca7g7m426dq9gyh5ffp00h2jzfl-ncompress-4.2.4.5
  ls -la /nix/store/jk7l2ca7g7m426dq9gyh5ffp00h2jzfl-ncompress-4.2.4.5/bin
  ```


  </details>
  <br/>


state: closed
title: Carnix: 0.9 -> 0.10
user_login: P-E-Meunier
html_url: https://github.com/NixOS/nixpkgs/pull/58394
updated_at: 2019-04-08 20:46:15
body:
  ###### Motivation for this change

  Carnix 0.10 can handle even trickier crates such as Sequoia-PGP.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ndisc6: 1.0.3 -> 1.0.4
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58395
updated_at: 2019-03-31 02:48:17
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ndisc6/versions.



  meta.description for ndisc6 is: '"A small collection of useful tools for IPv6 networking"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.0.4 with grep in /nix/store/pdf019rakjrkksq7rimlz4mpv08jyph5-ndisc6-1.0.4
  - directory tree listing: https://gist.github.com/0d461b694511408b4c02e12776734f1a
  - du listing: https://gist.github.com/944d3f0e8e6561a80b607ae0952f092f

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ndisc6

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/pdf019rakjrkksq7rimlz4mpv08jyph5-ndisc6-1.0.4 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ndisc6 https://github.com/r-ryantm/nixpkgs/archive/c332fd0883b09652218a36b4acf4d33252bb473c.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/pdf019rakjrkksq7rimlz4mpv08jyph5-ndisc6-1.0.4
  ls -la /nix/store/pdf019rakjrkksq7rimlz4mpv08jyph5-ndisc6-1.0.4/bin
  ```


  </details>
  <br/>


  cc @edolstra for testing.


state: open
title: nixos/security: don't use sudo.extraRules for wheel rule
user_login: cmacrae
html_url: https://github.com/NixOS/nixpkgs/pull/58396
updated_at: 2019-06-01 20:14:50
body:
  ###### Motivation for this change
  Using `security.sudo.extraRules` to generate the resulting `sudo`
  expression for the 'wheel' group causes problems with other
  `extraRules` definitions for the 'wheel' group (see #58276)

  ###### Things done
  These changes implement the same result, but ensure that the `sudo`
  expression for the 'wheel' group is placed before any `extraRules` the
  user may define.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ngircd: 24 -> 25
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58397
updated_at: 2019-03-31 02:48:21
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ngircd/versions.



  meta.description for ngircd is: '"Next Generation IRC Daemon"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 25 with grep in /nix/store/0gb8qypx7q698zbsm89wzykq00167py2-ngircd-25
  - directory tree listing: https://gist.github.com/8298cf7e656c166835c9a70cfb23bd60
  - du listing: https://gist.github.com/317ad51943d36293a9ed3b1388114c09

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ngircd

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/0gb8qypx7q698zbsm89wzykq00167py2-ngircd-25 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ngircd https://github.com/r-ryantm/nixpkgs/archive/b34a202f1b3b2336833664e782dadec48f435a04.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/0gb8qypx7q698zbsm89wzykq00167py2-ngircd-25
  ls -la /nix/store/0gb8qypx7q698zbsm89wzykq00167py2-ngircd-25/bin
  ```


  </details>
  <br/>


state: closed
title: documize-community: init at 2.2.1
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/58398
updated_at: 2019-04-08 23:01:52
body:
  ###### Motivation for this change

  Documize is an open-source alternative for wiki software like Confluence
  based on Go and EmberJS. This patch adds the sources for the community
  edition[1], for commercial their paid-plan[2] needs to be used.

  For commercial use a derivation that bundles the commercial package and
  contains a `$out/bin/documize` can be passed to
  `services.documize.enable`.

  The package compiles the Go sources, the build process also bundles the
  pre-built frontend from `gui/public` into the binary.

  The NixOS module generates a simple `systemd` unit which starts the
  service as a dynamic user, database and a reverse proxy won't be
  configured.

  [1] https://www.documize.com/get-started/
  [2] https://www.documize.com/pricing/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cnijfilter2: 5.30 -> 5.70
user_login: aszlig
html_url: https://github.com/NixOS/nixpkgs/pull/58399
updated_at: 2019-07-02 06:36:20
body:
  Newly supported series in version 5.40:

  MB2100, MB2700, iB4100, MB5100, MB5400, TS9000, TS8000, TS6000, TS5000, MG3000, E470, G4000

  Newly supported series in version 5.50:

  E200, E300, E3100, TR7500, TR7530, TR8500, TR8530, TR8580, TS200, TS300, TS3100, TS5100, TS6100, TS6130, TS6180, TS8100, TS8180, TS9100, TS9180, TS8130, XK70, XK50

  Newly supported series in version 5.60:

  G3010, G4010

  Newly supported series in version 5.70:

  TS8200, XK80, TS8230, TS8280, TS6200, TS6230, TS6280, TS9500, TR9530, TS9580, TR4500, E4200

  ---

  #### Note that I have only successfully built this but I'm not able test it because I personally don't have a Canon printer. I've done this bump mainly for someone else who owns a newer printer which is only supported in version 5.70.


state: closed
title: kodi: add Wayland support
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/58400
updated_at: 2019-05-01 09:30:41
body:
  ###### Motivation for this change

  Kodi has had support (again) for Wayland since v18.0. It would be nice to ship it in NixOS.

  I mimicked Firefox for Wayland's attribute path for Kodi with plugins:

  - New "plain" Kodi: `kodiPlainWayland`
  - `kodiPlainWayland` gets wrapped with plugins into `kodi-wayland`

  I'm open to suggestions / discussion, particularly on 2 things:

  - The `libxkbcommon` build dependency is specified as `libxkbcommon.dev`, otherwise `kodiPlainWayland` won't build for me (cmake doesn't find xcbcommon), and I don't know why :-/
  - Some GNU/Linux distributions ship a mix between `kodi` and `kodi-wayland`: the `/bin/kodi` script already selects the right Kodi to launch if in a Wayland or X11 environment. So if we have a derivation which compiles both `kodi` + `kodiPlainWayland`, and "copy" `${kodiPlainWayland}/lib/kodi/kodi-wayland` into `${kodi}/lib/kodi/`, we should have something that is both native to X11 and Wayland!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: gitlab: 11.9.0 -> 11.9.1
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/58401
updated_at: 2019-03-26 22:39:50
body:
  ###### Motivation for this change
  GitLab did a patch release earlier today.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.ocaml_extlib: 1.7.5 -> 1.7.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58402
updated_at: 2019-03-31 02:48:27
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-extlib/versions.



  meta.description for ocamlPackages.ocaml_extlib is: '"Enhancements to the OCaml Standard Library modules"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.7.6 with grep in /nix/store/86g1yzciwvp05g41f0p0pnly7fffnqr2-ocaml4.06.1-extlib-1.7.6
  - directory tree listing: https://gist.github.com/e88779b5b9c684ce8d93edaff089fd46
  - du listing: https://gist.github.com/7eb3e0f6b5d890bda1f8aeaf3671bf0d

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  10 total rebuild path(s)

  3 package rebuild(s)

  3 x86_64-linux rebuild(s)
  3 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  3 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  beluga
  google-drive-ocamlfuse
  virt-top

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/86g1yzciwvp05g41f0p0pnly7fffnqr2-ocaml4.06.1-extlib-1.7.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ocamlPackages.ocaml_extlib https://github.com/r-ryantm/nixpkgs/archive/ac8f9fc839e45e3c7c1eba40c214a206f051d074.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/86g1yzciwvp05g41f0p0pnly7fffnqr2-ocaml4.06.1-extlib-1.7.6
  ls -la /nix/store/86g1yzciwvp05g41f0p0pnly7fffnqr2-ocaml4.06.1-extlib-1.7.6/bin
  ```


  </details>
  <br/>


state: closed
title: monero: 0.13.0.4 -> 0.14.0.2
user_login: javgh
html_url: https://github.com/NixOS/nixpkgs/pull/58403
updated_at: 2019-03-27 10:28:58
body:
  ###### Motivation for this change

  As per r/monero: "Approximately the 9th of March there will be a scheduled network upgrade on the Monero network. To be sufficiently prepared, a user, service, merchant, pool operator, or exchange should run CLI v0.14.0.0 or GUI v0.14.0.0."

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of ~~all~~ some binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/systemd: Add suspend-then-hibernate
user_login: Semptic
html_url: https://github.com/NixOS/nixpkgs/pull/58404
updated_at: 2019-03-29 09:58:40
body:
  This is a duplicate of #53025, but also adds the according settings of sleep.conf.

  ###### Motivation for this change
  This pr enables nixos to use suspend-then-hibernate.
  This adds suspend-then-hibernate systemd service/target and
  also adds the according settings for sleep.conf.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.reactivedata: 0.2.1 -> 0.2.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/58405
updated_at: 2019-04-14 04:57:32
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ocaml4.06.1-reactivedata/versions.



  meta.description for ocamlPackages.reactivedata is: '"An OCaml module for functional reactive programming (FRP) based on React"'.


  [Compare changes on GitHub](https://github.com/ocsigen/reactiveData/compare/0.2.1...0.2.2)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.2.2 with grep in /nix/store/26imylw39p2l49pskx3vbl5znsl3np5y-ocaml4.06.1-reactiveData-0.2.2
  - directory tree listing: https://gist.github.com/21a3fa1428fae7ac4ace42861b8e2e04
  - du listing: https://gist.github.com/cf25874f6f71958760a613304b538bfe

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  0 total rebuild path(s)

  0 package rebuild(s)

  0 x86_64-linux rebuild(s)
  0 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  0 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath


  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/26imylw39p2l49pskx3vbl5znsl3np5y-ocaml4.06.1-reactiveData-0.2.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ocamlPackages.reactivedata https://github.com/r-ryantm/nixpkgs/archive/555bffd25f240276769aea834a3fea1f7660083b.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/26imylw39p2l49pskx3vbl5znsl3np5y-ocaml4.06.1-reactiveData-0.2.2
  ls -la /nix/store/26imylw39p2l49pskx3vbl5znsl3np5y-ocaml4.06.1-reactiveData-0.2.2/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: avahi: apply patches for CVE-2017-6519 & CVE-2018-1000845
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58406
updated_at: 2019-03-26 23:03:37
body:
  ###### Motivation for this change

  This applies patches for the two CVEs CVE-2017-6519 & CVE-2018-1000845

  fixes #57137

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] avahi: apply patches for CVE-2017-6519 & CVE-2018-1000845
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58407
updated_at: 2019-03-26 23:03:33
body:
  ###### Motivation for this change

  This applies patches for the two CVEs CVE-2017-6519 & CVE-2018-1000845

  fixes #57137

  (cherry picked from commit 87a762269fc52d459a9326d56272100bfd149597)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avahi: apply patches for CVE-2017-6519 & CVE-2018-1000845
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58408
updated_at: 2019-03-26 23:03:30
body:
  ###### Motivation for this change
  This applies patches for the two CVEs CVE-2017-6519 & CVE-2018-1000845

  fixes #57137

  (cherry picked from commit 87a762269fc52d459a9326d56272100bfd149597)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.vim-stylish-haskell: Patch path to executable
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58409
updated_at: 2019-04-01 03:41:38
body:
  ###### Motivation for this change
  Closes https://github.com/NixOS/nixpkgs/issues/57099

  As one would expect, this increases the closure size of `vimPlugins.vim-stylish-haskell` by a lot, from 3.1KB to 40.6MB, but this is worth it and makes sense.

  Tested this by doing
  ```
  $ cd /path/to/nixpkgs
  $ nix-build -E 'with import ./. {}; neovim.override { configure = { packages.myVimPackage = with pkgs.vimPlugins; { start = [  vim-stylish-haskell ]; }; }; }'
  $ export PATH=""
  $ result/bin/nvim
  ```

  Then opening a non-stylished Haskell file (such as https://github.com/mrkkrp/megaparsec/blob/master/Text/Megaparsec.hs) and hitting `:w` -> stylish does the styling.

  Ping @lrworth

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] gitlab 11.7.5 -> 11.9.1, backport of more fixes and test improvements
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/58410
updated_at: 2019-03-26 23:00:44
body:
  ###### Motivation for this change
  This backports version bumps of gitlab and some recent improvements in the gitlab module and vm tests.

  cc @bgamari @kalbasit @johanot @jslight90 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: adoptopenjdk-bin: Remove libfreetype.so [backport to 18.09]
user_login: tomfitzhenry
html_url: https://github.com/NixOS/nixpkgs/pull/58411
updated_at: 2019-03-27 03:02:11
body:
  ###### Motivation for this change
  Fix kodi building on aarch64: https://hydra.nixos.org/build/91064101 diagnosed in https://github.com/NixOS/nixpkgs/issues/57733

  Merged into master in https://github.com/NixOS/nixpkgs/pull/57750 .

  ###### Things done
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: adoptopenjdk-bin: Remove libfreetype.so [backport to 19.03]
user_login: tomfitzhenry
html_url: https://github.com/NixOS/nixpkgs/pull/58412
updated_at: 2019-03-27 10:37:08
body:
  Backport of 6bae07337e038a1b2b874de1ea3f7a121b9d89b8 to 19.03
  ###### Motivation for this change
  Fix kodi's build on aarch64. https://hydra.nixos.org/build/91130095 diagnosed in https://github.com/NixOS/nixpkgs/issues/57733

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] gitlab 11.7.5 -> 11.9.1, backport of more fixes and test improvements
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/58413
updated_at: 2019-03-26 23:00:41
body:
  ###### Motivation for this change
  This backports version bumps of gitlab and some recent improvements in the gitlab module and vm tests.

  cc @bgamari @kalbasit @johanot @jslight90

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: imagemagick7Big: Revert meta.broken to false
user_login: andersk
html_url: https://github.com/NixOS/nixpkgs/pull/58414
updated_at: 2019-03-27 02:56:39
body:
  ###### Motivation for this change

  imagemagickBig and imagemagick7Big were marked broken in #55634 due to #55118.  #57313 fixed the bug but reverted the broken bit only on imagemagickBig.  Revert it on imagemagick7Big too.

  Cc: @erikarvstedt, @delroth

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fontforge: 20170730 -> 20190317
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58415
updated_at: 2019-04-16 21:10:42
body:
  ###### Motivation for this change

  https://github.com/fontforge/fontforge/releases/tag/20190317

  * add zmq (collab), woff2 (format), readline (cli)
  * "just in case", keep determinism patching
  * fontforge-fonttools: replace with override enabling tools
    Don't see any reason to not include by default,
    so this might make more sense as an alias instead.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnulib: 20180226 -> 20190326
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58416
updated_at: 2019-04-25 21:09:15
body:
  ###### Motivation for this change

  Lots of fixes, support for goodness such as RISC-V and cross-musl
  (apparently!):

  http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=shortlog;h=a18f7ce3c0aa760c33d46bbeb8e5b3a14cf24984;hp=0bec5d56c6938c2f28417bb5fd1c4b05ea2e7d28

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: or-tools: 6.10 -> 7.0, add Python bindings
user_login: andersk
html_url: https://github.com/NixOS/nixpkgs/pull/58417
updated_at: 2019-04-20 08:39:24
body:
  ###### Motivation for this change

  Package the OR-Tools Python bindings (cherry-picked from #51900), and upgrade OR-Tools from 6.10 to 7.0.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: performous: fix build by using boost 166
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/58418
updated_at: 2019-03-27 02:16:27
body:
  ###### Motivation for this change
  #56826 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/ldap: set proper User= and Group= for nslcd service
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/58419
updated_at: 2019-03-28 14:12:19
body:
  ###### Motivation for this change

  eb90d9700958aefbc7b886f2b524c6d04dc1d80d broke nslcd, as `/run/nslcd` was
  created/chowned as root user, while nslcd wants to do parts as nslcd
  user.

  This commit changes the nslcd to run with the proper uid/gid from the
  start (through User= and Group=), so the RuntimeDirectory has proper
  permissions, too.

  In some cases, secrets are baked into nslcd's config file during startup
  (so we don't want to provide it from the store).

  This config file is normally hard-wired to /etc/nslcd.conf, but we don't
  want to use PermissionsStartOnly anymore (#56265), and activation
  scripts are ugly, so redirect /etc/nslcd.conf to /run/nslcd/nslcd.conf,
  which now gets provisioned inside ExecStartPre=.

  This change requires the files referenced to in
  users.ldap.bind.passwordFile and users.ldap.daemon.rootpwmodpwFile to be
  readable by the nslcd user (in the non-nslcd case, this was already the
  case for users.ldap.bind.passwordFile)

  fixes #57783

  In addition, this renames `users.ldap.daemon.rootpwmodpw` to `users.ldap.daemon.rootpwmodpwFile` and `users.ldap.bind.password` to `users.ldap.bind.passwordFile` (as it's really files). I added a `mkRenamedOptionModule` for `users.ldap.bind.password`, but `users.ldap.daemon.rootpwmodpw` wasn't yet part of a release.

  Should be backported to 19.03. / cc @samueldr @lheckemann 

  cc @ju1m

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Remove a bunch of old option renames
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58420
updated_at: 2019-04-01 00:08:23
body:
  ###### Motivation for this change
  I don't think we need to provide backwards compatibility for warnings that have been issues for 4 years by now :)

  Which ones to remove was decided based on the date given by `git blame rename.nix`, I removed all `mkRenamedOptionModule` from 2015 (or earlier, but there are no earlier ones).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos.cron: fix docstring sentence
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/58421
updated_at: 2019-07-16 17:12:41
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chafa: init at 1.0.1
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/58422
updated_at: 2019-04-20 18:54:13
body:
  ###### Motivation for this change
  I read about cool tool on reddit and thought we needed it packaged. it makes cool unicode approximations of images inside your terminal.
  ![koi_terminal](https://user-images.githubusercontent.com/64710/55049191-91b1c400-5021-11e9-87a0-eae4584e930f.png)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cypress: init at 3.2.0
user_login: acyuta108
html_url: https://github.com/NixOS/nixpkgs/pull/58423
updated_at: 2019-07-17 01:34:52
body:
  ###### Motivation for this change
  Missing package.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: package request: the neovim based editor oni2
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/58425
updated_at: 2019-03-27 05:52:33
body:
  ## Issue description
  Follow up of https://github.com/NixOS/nixpkgs/issues/38231, the neovim based GUI editor `oni` is getting replaced by `oni2` with a different stack based on reasonml and the revery framework. These technologies are completely foreign to me but I still would like to test oni2:
  https://github.com/onivim/oni2

  The software itself is alpha so there is no hurry in packaging it but I wonder how hard it would be.


state: closed
title: 19.03 fails to run keybase service because it refuses to run as root
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/58426
updated_at: 2019-03-28 06:01:35
body:
  On 19.03, the keybase service no longer starts as it refuses to start as root user. It says that it should be started as a user service.


state: closed
title: clblas is not buildable
user_login: Shimuuar
html_url: https://github.com/NixOS/nixpkgs/issues/58427
updated_at: 2019-03-29 17:16:07
body:
  ## Issue description

  clblas is not buildable 

  ### Steps to reproduce

  1. `nix-shell -p clblas` which will fail with obscure compile error

  Build fails because of some incompatibility of gtest but if one uses vendored version build succeed without any problem. To do so one need to remove cmake's flag `-DUSE_SYSTEM_GTEST=ON` from derivations. So if one overrides clblas like this it builds fine:

  ```
      clblas = self.lib.overrideDerivation super.clblas (oldAttrs: {
        cmakeFlags = [];
      });
  ```

  I only tested it on 18.09 but according to hydra 19.03 suffers from same problem

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.108, NixOS, 18.09.2394.2d656a97297 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"home-manager-18.09, nixos-18.09.2394.2d656a97297"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  P.S. I run into this issue while trying to install PyMC3


state: closed
title: scons: 3.0.4 -> 3.0.5
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/58428
updated_at: 2019-03-28 11:27:32
body:
  Announcement:
  https://scons.org/scons-305-is-available.html

  Changelog:
  https://raw.githubusercontent.com/SConsProject/scons/rel_3.0.5/src/CHANGES.txt

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python2Packages.nevow, tahoe-lafs: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/58429
updated_at: 2019-04-08 00:04:14
body:
  ###### Motivation for this change

  #56826 - please backport

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] signal-desktop backport
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/58430
updated_at: 2019-03-27 11:20:34
body:
  ###### Motivation for this change

  Last backport for 18.09 - this build will expire on 2019-05-22.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: align generated layer archives with docker's output
user_login: alexbiehl
html_url: https://github.com/NixOS/nixpkgs/pull/58431
updated_at: 2019-03-27 21:21:35
body:
  ###### Motivation for this change

  This PR makes docker images created by nix to be exactly the same as images created by docker. We encountered proprietary software that doesn't implement the full tar spec. 

  @shlevy @grahamc 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/mailcatcher: init module for existing package
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/58432
updated_at: 2019-03-28 00:24:38
body:
  ###### Motivation for this change
  I'm interested in running mailcatcher as a system service.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: peek fails when rendering GIF
user_login: mpickering
html_url: https://github.com/NixOS/nixpkgs/issues/58433
updated_at: 2019-03-30 18:16:24
body:
  ## Issue description

  After recording a gif using peek it aborts whilst trying to save the gif.

  ```[matt@nixos:~/ghc]$ peek
  Using screen recorder backend ffmpeg

  (peek:4697): Gtk-WARNING **: 11:39:02.531: Could not find the icon 'media-record-symbolic-ltr'. The 'hicolor' theme
  was not found either, perhaps you need to install it.
  You can get a copy from:
  	http://icon-theme.freedesktop.org/releases

  (peek:4697): dconf-WARNING **: 11:39:32.999: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.044: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.071: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.091: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.111: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.131: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.147: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.167: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.183: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.200: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.217: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

  (peek:4697): dconf-WARNING **: 11:39:33.233: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files
  realloc(): invalid old size
  Aborted
  ```


  ### Steps to reproduce

  Record a GIF using peek and and try to save it.

  ## Technical details

  ```
  # - system: `"x86_64-linux"`
   - host os: `Linux 4.19.19, NixOS, 19.09.git.da1a2b1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - nixpkgs: `/home/matt/nixpkgs`
  ```


state: closed
title: Add licenses
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/58434
updated_at: 2019-04-09 18:12:41
body:
  ###### Motivation for this change

  Adds licenses for:

  pkgs/applications/networking/browsers/arora/default.nix
  pkgs/development/compilers/aspectj/default.nix
  pkgs/development/interpreters/clisp/default.nix
  pkgs/games/atanks/default.nix
  pkgs/tools/package-management/checkinstall/default.nix

  because I was bored.

  ###### Things done

  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  related to #43716 


state: closed
title: ocaml-syslog: fix missing cmxa file
user_login: rixed
html_url: https://github.com/NixOS/nixpkgs/pull/58435
updated_at: 2019-03-27 14:15:16
body:
  ###### Motivation for this change

  Makefile does not produce native library by default.
  Added an explicit "make all opt" as other ocaml libs do.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: curl: 7.64.0 -> 7.64.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58436
updated_at: 2019-04-17 19:48:56
body:
  ###### Motivation for this change

  https://curl.haxx.se/changes.html#7_64_1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnutls: 3.6.6 -> 3.6.7, security!
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58437
updated_at: 2019-03-28 11:29:42
body:
  ###### Motivation for this change

  https://lists.gnupg.org/pipermail/gnutls-help/2019-March/004497.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: microcodeIntel: 20180807a -> 20190312 (from intel github)
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58438
updated_at: 2019-03-28 22:06:24
body:
  ###### Motivation for this change

  https://github.com/intel/Intel-Linux-Processor-Microcode-Data-Files/blob/microcode-20190312/releasenote#L85

  Bumps microcode on my laptop, for example.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: apitrace: 363 -> 572 (2017-04-21 -> 2019-03-26)
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58439
updated_at: 2019-04-19 05:21:59
body:
  ###### Motivation for this change

  Bump! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - the gl* variants anyway
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oxipng: 2.2.0 -> 2.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58440
updated_at: 2019-03-28 17:35:24
body:
  ###### Motivation for this change

  https://github.com/shssoichiro/oxipng/blob/v2.2.1/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: postgresqlPackages.pipelinedb: init at 1.0.0-13
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/58441
updated_at: 2019-05-18 18:20:14
body:
  ###### Motivation for this change
  Add https://www.pipelinedb.com/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fcitx: 4.2.9.5 -> 4.2.9.6
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/58442
updated_at: 2019-04-08 05:01:58
body:
  Updated url to gitlab.

  ###### Motivation for this change
  none, was looking into how I could input arabic.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: altcoins.aeon: 0.12.8.0 -> 0.12.9.0
user_login: fuwa0529
html_url: https://github.com/NixOS/nixpkgs/pull/58444
updated_at: 2019-04-14 10:51:57
body:
  ###### Motivation for this change
  Version bump

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terminator: fix missing gobject bindings
user_login: borisbabic
html_url: https://github.com/NixOS/nixpkgs/pull/58447
updated_at: 2019-04-12 18:36:52
body:
  See: https://github.com/NixOS/nixpkgs/issues/56943
  ###### Motivation for this change
  Terminator doesn't work because of #56943. This same fix has been applied elsewhere as well, example: https://github.com/NixOS/nixpkgs/commit/64c8f268df0dcda215b0f57a7150d1b87d2af690

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.pybullet: init at 2.4.8
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/58448
updated_at: 2019-03-27 22:17:41
body:
  ###### Motivation for this change

  Making the openai gym usable without the proprietary mujoco physics engine (this uses bullet instead).

  This is the actively developed version from the bullet maintainers, as opposed to the version from the gym maintainers in https://github.com/NixOS/nixpkgs/pull/58451 which has only maintenance support but is still relevant.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: lacaml: Use propagatedBuildInputs for stublibs
user_login: rixed
html_url: https://github.com/NixOS/nixpkgs/pull/58449
updated_at: 2019-03-27 18:05:15
body:
  ###### Motivation for this change

  This frees the packages depending on lacaml to have to repeat this.
  Other ocaml libs seems to do the same for stubs.
  Cf discussion in https://github.com/NixOS/nixpkgs/pull/57954

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spideroak: 7.1.0 -> 7.5.0
user_login: nathantalewis
html_url: https://github.com/NixOS/nixpkgs/pull/58450
updated_at: 2019-03-30 23:27:38
body:
  ###### Motivation for this change
  A few new versions of SpiderOak have been released.

  This is a follow up to https://github.com/NixOS/nixpkgs/pull/55010, but even more versions have been released since then so I'm making this new PR and leaving the old one closed.

  ###### Things done
  This bumps the version and removes 32 bit support, since it is no longer supported upstream for Linux.

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.roboschool: init at 1.0.39
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/58451
updated_at: 2019-03-27 21:26:58
body:
  ###### Motivation for this change

  Making the openai gym usable without the proprietary mujoco physics engine (this uses bullet instead).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.baselines: init at 0.1.5
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/58452
updated_at: 2019-03-27 21:27:27
body:
  ###### Motivation for this change

  Provides reinforcement learning algorithm baseline implementations for research purposes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghidra: improvements
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/pull/58453
updated_at: 2019-06-28 22:50:17
body:
  (wip: botched this  a bit)
  changes so far:
  - dont change the name of the ghidra launcher
  - wrap more launchers with jdk

  Questions:
  - [ ] what should be done with the binaries in the server directory (I haven't looked at this yet)
  - [ ] should all these binaries end up in bin?: are they all things that should end up in `$PATH` if someone uses Ghidra?

  xref: #56959


state: closed
title: brig: Fix build of metrics jobs, cleanup
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/58454
updated_at: 2019-03-27 19:17:56
body:
  ###### Motivation for this change
  The use of `callPackages` instead of `callPackage` caused the metrics job to fail with a rather cryptic error, because `override` and `overrideAttrs` were added to the `meta` attr.

  Also removed apparently unused `fetchgx` arg.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/upower: remove package option
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/58455
updated_at: 2019-04-14 04:05:56
body:
  Haven't had another upower package in nixpkgs since 2a2cb8354ec

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.grpcio: fix build on Darwin
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/58456
updated_at: 2019-06-04 05:55:32
body:
  ###### Motivation for this change

  Builds on Darwin have started to fail recently. This seems to be caused
  by a check in Makefile that verifies whether the system is able to build
  BoringSSL. This check attempts to compile test/build/boringssl.c, which
  is absent in PyPI archives of grpcio.

  This change builds the grpcio module directly from the grpc git
  repository, so that all the files that are necessary for checks are
  present.

  Affects #56826 since darwin builds of this derivation on nixpkgs-19.03
  fail.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go tests fail on macOS/darwin
user_login: svend
html_url: https://github.com/NixOS/nixpkgs/issues/58457
updated_at: 2019-04-26 22:53:03
body:
  ## Issue description

  Installing go on macOS fails while running tests.

  ### Steps to reproduce

  ```
  $ nix-env -iA nixpkgs.go
  ...
  ok      regexp/syntax   1.365s
  --- FAIL: TestSpuriousWakeupsNeverHangSemasleep (2.88s)
      semasleep_test.go:77: Program failed to return on time and has to be killed, issue #27520 still exists
  FAIL
  FAIL    runtime 66.939s
  ok      runtime/debug   0.109s
  ...
  2019/03/27 16:53:39 Failed: exit status 1
  builder for '/nix/store/3gj6zkc2i29dlm9amid7a5yx2xndz095-go-1.12.drv' failed with exit code 1
  error: build of '/nix/store/3gj6zkc2i29dlm9amid7a5yx2xndz095-go-1.12.drv' failed
  ```

  ## Technical details
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.2.0, macOS 10.14.3`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2`
   - channels(ssorensen): `"nixpkgs-19.09pre173445.796a8764ab8"`
   - nixpkgs: `/Users/ssorensen/.nix-defexpr/channels/nixpkgs` 


state: closed
title: nixos/colord: don't run as root
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/58458
updated_at: 2019-03-30 03:42:33
body:
  ###### Motivation for this change
  Implementing one of my suggested improvements in https://github.com/NixOS/nixpkgs/pull/57840

  ###### Things done
  Built a vm and checked that at least the services were running.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qtikz: fix build
user_login: xeji
html_url: https://github.com/NixOS/nixpkgs/pull/58459
updated_at: 2019-03-30 16:28:45
body:
  ###### Motivation for this change

  #56826, please backport.

  qcollectiongenerator was merged into qhelpgenerator in qt 5.12,
  see https://blog.qt.io/blog/2018/11/02/whats-new-qt-help/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform-providers: bump versions
user_login: DzmitrySudnik
html_url: https://github.com/NixOS/nixpkgs/pull/58460
updated_at: 2019-03-27 23:05:04
body:
  ran nixpkgs/pkgs/applications/networking/cluster/terraform-providers/update-all to get that change. Haven't done any manual testing


state: closed
title: terraform-providers: bump versions
user_login: DzmitrySudnik
html_url: https://github.com/NixOS/nixpkgs/pull/58461
updated_at: 2019-03-28 19:40:06
body:
  ran nixpkgs/pkgs/applications/networking/cluster/terraform-providers/update-all to get that change. Tested by building terraform with aws and archive providers (both upgraded here) on MacOS and Linux (NixOS) and using terraform as usual.


state: closed
title: Gogs missing sqlite by default
user_login: neonfuz
html_url: https://github.com/NixOS/nixpkgs/issues/58462
updated_at: 2019-04-24 21:23:46
body:
  ## Issue description
  Ever since PAM was added to gogs, the nix file has been written in a way that disables sqlite if PAM is enabled (including by default). I fixed the issue in a PR here: https://github.com/NixOS/nixpkgs/pull/58290


  ### Steps to reproduce
  Enable gogs as a service. It will NOT include sqlite unless you explicitly disable PAM.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.29, NixOS, 19.09pre173166.373488e6f4c (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(sage): `"nixpkgs-19.09pre173445.796a8764ab8"`
   - channels(root): `"nixos-19.09pre173166.373488e6f4c"`
   - nixpkgs: `/home/sage/.nix-defexpr/channels/nixpkgs`


state: closed
title: [19.03] monero: 0.13 -> 0.14
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/58463
updated_at: 2019-03-28 08:26:14
body:
  ###### Motivation for this change
  Needed to solve #57210 on stable channels

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change
  - [x] Tested execution of all binary files
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/digital-ocean-image: init
user_login: eamsden
html_url: https://github.com/NixOS/nixpkgs/pull/58464
updated_at: 2019-07-08 12:45:18
body:
  ###### Motivation for this change
  A just-works NixOS image that can be uploaded to Digital Ocean, hopefully to be used as a basis for better Digital Ocean support in NixOps.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: polyml: 5.7.1 -> 5.8
user_login: vaibhavsagar
html_url: https://github.com/NixOS/nixpkgs/pull/58466
updated_at: 2019-04-09 15:06:21
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: r-sys: remove obsolete dependency
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/58467
updated_at: 2019-04-06 00:53:58
body:
  ###### Motivation for this change

  Package sys does not require libapparmor https://github.com/jeroen/sys/commit/4e9d208429608e1682e00c4df08028d11d27cbbf. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] kde-applications: 18.12.1 -> 18.12.3
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/58468
updated_at: 2019-03-28 17:33:00
body:
  ###### Motivation for this change
  Backporting https://github.com/NixOS/nixpkgs/pull/56155 was mentioned https://github.com/NixOS/nixpkgs/pull/56155#issuecomment-467182759

  > @lheckemann 
  > Since it's a minor version bump though I suppose we can still backport it to 19.03 after the branch-off.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cloud-utils includes qemu; package qemu-utils?
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/58469
updated_at: 2019-04-16 23:21:12
body:
  ## Issue description

  I'm working on #58464 and realizing that 90% of the image being uploaded is a copy of `qemu`:

  `image -> cloud-init -> cloud-utils -> qemu`

  It looks like the referenced upstream package now uses `qemu-utils`. We should consider packaging it and using it instead and see if it cuts down on image size:

  https://git.launchpad.net/cloud-utils/tree/debian/control


state: closed
title: rPackages: fix missing dependency to libiconv
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/58470
updated_at: 2019-03-28 09:55:34
body:
  ###### Motivation for this change

  These packages require libiconv.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cloud-utils: use `qemu-utils` instead of `qemu`
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/pull/58471
updated_at: 2019-07-11 14:17:25
body:
  ###### Motivation for this change

  Related issue: https://github.com/NixOS/nixpkgs/issues/58469

  This greatly reduces the size of images that use `cloud-init`.
  This seems safe to do per the upstream packaging:
    * https://git.launchpad.net/cloud-utils/tree/debian/control
    * https://packages.debian.org/unstable/qemu-utils


  Before/after:
  ```
  595M     /nix/store/nmn798kahfqf47d4j6zfqwvy7m678hd0-digital-ocean-image
  331M     /nix/store/kvq58qn9iqgpgr4v3dq9vk5zd05jz2ml-digital-ocean-image
  ```

  I've booted this up, but haven't tested extensively. This should be tested with other images, but ought to be at least somewhat safe based on upstream packaging.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emacs: only use patchelf on linux
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/58472
updated_at: 2019-05-01 16:36:27
body:
  ###### Motivation for this change

  This prevents building Emacs with X on Darwin.

  Broken by 5af6e9f75e89dab40b2ac9cb9b0fe92cc66f1311 (#54916)

  Is `stdenv.isLinux` the correct guard for `patchelf`?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/58473
updated_at: 2019-03-28 07:16:57
title:
  19.03 XMonad and Plasma5 when launched from SDDM results in both launching even when only select XMonad

body:
  ## Issue description

  Testing on 19.03, when sddm and xmonad and plasma5 is installed. SDDM presents options on the bottom left `none + xmonad`, `plasma5 + xmonad` or `plasma5 + none`.

  When selecting `none + xmonad`, xmonad is launched, but then KDE plasma5 launches at the same time as if you had selected `plasma5 + xmonad`. Note that selecting `plasma5` only does also launch xmonad.

  This behaviour is not consistent with 18.09.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.31, Formbay ML 2 A, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```

  It's running on nixpkgs: 23fd1394dc6bef03a2ff010278a24403a97f0647


state: closed
title: minikube: 0.35.0 -> 1.0.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/58475
updated_at: 2019-03-31 10:03:28
body:
  ###### Motivation for this change

  Bump `minikube` to version 1.0.0 :tada: — default version for it is k8s 1.14.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skaffold: 0.25.0 -> 0.26.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/58476
updated_at: 2019-03-29 08:14:42
body:
  ###### Motivation for this change

  Bump to latest release :angel: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.13.4 -> 1.13.5
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/58477
updated_at: 2019-03-28 15:37:11
body:
  ###### Motivation for this change
  Bump kubernetes.
  `nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode` runs clean locally.

  Backport to 19.03 please.

  @GrahamcOfBorg build kubernetes

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Jetbrains IDEs
user_login: chpatrick
html_url: https://github.com/NixOS/nixpkgs/pull/58478
updated_at: 2019-03-28 21:26:35
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Using steamcmd in docker: mkdir not found
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/issues/58479
updated_at: 2019-04-06 14:34:19
body:
  ## Issue description

  I tried to create a Docker file using Nix which, in its `Cmd`, just calls `steamcmd --help`. This fails because `steamcmd.sh` contains `mkdir`, which, apparently, isn't put into the Docker image.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.30, NixOS, 19.09pre173349.07b42ccf2de (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(philipp): `""`
   - channels(root): `"nixos-19.09pre173349.07b42ccf2de"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: insecure GnuTLS on darwin
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/issues/58481
updated_at: 2019-05-01 16:31:39
body:
  Darwin has been using old GnuTLS version due to [some issues](https://github.com/NixOS/nixpkgs/commit/d6454e6a1), but that means it's vulnerable...


state: open
title: iwlwifi firmware fails to load after several suspends to RAM
user_login: schmittlauch
html_url: https://github.com/NixOS/nixpkgs/issues/58482
updated_at: 2019-05-15 14:39:21
body:
  ## Issue description

  Since several week the iwlwifi firmware for my Intel Corporation Wireless 7260 (rev 83) card fails to load after resuming from a suspend RAM.
  As at boot the firmware is always loaded successfully, a reboot temporarily fixes the issue.
   
  The issue doesn't appear after each suspen-resume cycle, but after several tries you'll run into it with a very high probability. It seems to have happened once even without suspending and resuming, but only with disabling and enabling the WLAN adapter (soft rfkill).

  The issue appeared both with kernel 4.14.107 and 4.19.31

  Here are the logs:

  journald log:

  ```
  Mär 28 12:24:28 thinknix wpa_supplicant[1492]: rfkill: WLAN unblocked
  Mär 28 12:24:29 thinknix kernel: iwlwifi 0000:03:00.0: Could not load the [0] uCode section
  Mär 28 12:24:29 thinknix kernel: iwlwifi 0000:03:00.0: Failed to start INIT ucode: -5
  Mär 28 12:24:29 thinknix kernel: iwlwifi 0000:03:00.0: Failed to run INIT ucode: -5
  Mär 28 12:24:29 thinknix kernel: iwlwifi 0000:03:00.0: Failed to start RT ucode: -5
  Mär 28 12:24:30 thinknix NetworkManager[1212]: <warn>  [1553772270.9995] platform-linux: do-change-link[3]: failure changing link: failure 5 (Input/output error)
  ```

  dmesg |grep wifi 

  ```
  [   14.476997] iwlwifi 0000:03:00.0: loaded firmware version 17.3216344376.0 op_mode iwlmvm
  [   14.578151] iwlwifi 0000:03:00.0: Detected Intel(R) Dual Band Wireless AC 7260, REV=0x144
  [   14.600870] iwlwifi 0000:03:00.0: base HW address: <censored>
  [   14.873952] iwlwifi 0000:03:00.0 wlp3s0: renamed from wlan0
  ```

  ### Steps to reproduce

  1. Boot NixOS on a system with an Intel 7260 WLAN card (in my case a ThinkPad T440S)
  1. Connect to a WLAN network (in my case using NetworkManager)
  1. suspend to RAM and resume, alternatively: disable and enable WLAN using rfkill
  1. observe whether it is possible to reconnect to a WLAN network
  1. if issue does not appear, goto 3

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.107, NixOS, 18.09.2372.f4b2ae96cc8 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2394.2d656a97297, nixos-unstable-19.09pre173166.373488e6f4c"`
   - channels(user): `"home-manager-18.09"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: dovecot: 2.3.5 -> 2.3.5.1
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/58483
updated_at: 2019-04-08 00:03:15
body:
  ###### Motivation for this change
  https://dovecot.org/list/dovecot-news/2019-March/000401.html
  fixes CVE-2019-7524

  A propos release-18.09: Should we apply https://github.com/dovecot/core/commit/578cf77e84b3d25e2f95f08133a2b0b212aa77cc and https://github.com/dovecot/core/commit/696320b0f3644e928a9d0c71c063f603c3792dbb as patches or upgrade from 2.3.4.1 to 2.3.5.1?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cudnn_cudatoolkit_10: 7.3.1 -> 7.4.2
user_login: sveitser
html_url: https://github.com/NixOS/nixpkgs/pull/58484
updated_at: 2019-04-25 09:54:06
body:
  ###### Motivation for this change

  Update cudnn.

  ```
  [nix-shell:/etc/nixos/nixpkgs]$ nix-review rev e29e315c5f92aa4d1544f231fc3750da52eb63f8
  $ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
  $ git worktree add /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs 6670b4c37d4acfd4c2149fd60356d2d88c3ae4ef
  Preparing worktree (detached HEAD 6670b4c37d4)
  HEAD is now at 6670b4c37d4 Merge pull request #58419 from flokli/ldap-nslcd-startup
  $ nix-env -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs -qaP --xml --out-path --show-trace
  $ git merge --no-commit e29e315c5f92aa4d1544f231fc3750da52eb63f8
  Updating 6670b4c37d4..e29e315c5f9
  Fast-forward
   pkgs/development/libraries/science/math/cudnn/default.nix | 6 +++---
   1 file changed, 3 insertions(+), 3 deletions(-)
  $ nix-env -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs -qaP --xml --out-path --show-trace --meta
  $ nix build --no-link --keep-going --max-jobs 32 --option build-use-sandbox true -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/build.nix
  [6 built, 30 copied (251.6 MiB), 91.7 MiB DL]
  3 package were build:
  cudnn_cudatoolkit_10 python27Packages.tensorflowWithCuda python37Packages.tensorflowWithCuda
  ```


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] dovecot: add patch for CVE-2019-7524
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/58485
updated_at: 2019-03-28 22:02:44
body:
  ###### Motivation for this change
  This applies commits
  https://github.com/dovecot/core/commit/578cf77e84b3d25e2f95f08133a2b0b212aa77cc
  https://github.com/dovecot/core/commit/696320b0f3644e928a9d0c71c063f603c3792dbb

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @peti 


state: closed
title: openmw: 0.44 -> 0.45
user_login: marius851000
html_url: https://github.com/NixOS/nixpkgs/pull/58486
updated_at: 2019-03-30 01:59:35
body:
  ###### Motivation for this change
  openmw received an update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitaly: Run gitaly with procps in scope
user_login: bgamari
html_url: https://github.com/NixOS/nixpkgs/pull/58487
updated_at: 2019-03-28 17:25:18
body:
  ###### Motivation for this change

  Gitaly uses `ps` to track the RSS of `gitlab-ruby` and kills it when it
  detects excessive memory leakage. See
  https://gitlab.com/gitlab-org/gitaly/issues/1562.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/mailcatcher: fix test to be compatible with mailcatcher 7.x series
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/58489
updated_at: 2019-03-29 03:09:41
body:
  ###### Motivation for this change
  Fix test to be compatible with mailcatcher 7.x series

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scrcpy: 1.5 -> 1.8
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/58490
updated_at: 2019-06-03 10:17:55
body:
  [changes](https://github.com/Genymobile/scrcpy/releases)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @deltaevo @lukeadams @tomberek


state: closed
title: sublime3: Fix python api locale
user_login: d10n
html_url: https://github.com/NixOS/nixpkgs/pull/58491
updated_at: 2019-03-29 13:38:03
body:
  ###### Motivation for this change
  With Nix on CentOS 6, I installed sublime3, but after installing Package Control in sublime, I get shown an error saying:

  > Your system's locale is set to a value that can not handle non-ASCII characters. Package Control can not properly work unless this is fixed.
  > 
  > On Linux, please reference your distribution's docs for information on properly setting the LANG and LC_CTYPE environmental variables. As a temporary work-around, you can launch Sublime Text from the terminal with:
  > 
  > LANG=en_US.UTF-8 LC_CTYPE=en_US.UTF-8 sublime_text
  > 

  but my system locale is already en_US.UTF-8.

  This change solves the problem.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
     - *sandboxing messed up on CentOS 6*
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
     - *only tested sublime_text*
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: molden: 5.9.3 -> 5.9.5
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/58492
updated_at: 2019-03-29 19:18:42
body:
  ###### Motivation for this change
  Regular update

  ###### Things done
  Test locally. Works fine.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: octopus: 8.3 -> 8.4
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/58494
updated_at: 2019-03-29 20:28:05
body:
  ###### Motivation for this change
  Regular update. libxc, required by octopus,  is updated from 4.2.3 -> 4.3.4.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: snapper: 0.8.2 -> 0.8.3
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/58496
updated_at: 2019-04-01 10:50:18
body:
  ###### Motivation for this change
  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] virtualenv: Update patch for 16.2.0
user_login: mweinelt
html_url: https://github.com/NixOS/nixpkgs/pull/58499
updated_at: 2019-03-29 06:40:10
body:
  (Cherry-picked from 2556b7bfad8341aa25fa4a3f9a2d4e4c8c85f67f)

  ###### Motivation for this change

  I was affected by https://github.com/NixOS/nixpkgs/issues/57008 on 19.03 (23fd1394dc6bef03a2ff010278a24403a97f0647) and backporting the fix by @glasserc from https://github.com/NixOS/nixpkgs/pull/57533 fixed the issue.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vscode-extensions.vscodevim.vim: init at 1.2.0
user_login: jokogr
html_url: https://github.com/NixOS/nixpkgs/pull/58500
updated_at: 2019-03-28 21:16:09
body:
  ###### Motivation for this change

  Wanted to use some vim keybindings on vscode.

  I have tested it locally and seems to be working for simple things.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: x86 runtime deps in ARM glibc (and most other binaries)
user_login: illegalprime
html_url: https://github.com/NixOS/nixpkgs/issues/58501
updated_at: 2019-04-17 20:07:41
body:
  ## Issue description

  building some cross-compiled packages and inspecting their run-time closures:

  ```
  nix build -f . pkgsCross.aarch64-multiplatform.glibc
  nix-store -q --tree result
  ```

  will show that `result` depends on `/nix/store/b9iyqcsd1gmlfagpi4xqqlswcpx079r1-aarch64-unknown-linux-gnu-stage-final-gcc-debug-7.4.0` (on master d46bf208b6e9a1b0349ac1ade262b4e99760e7be).

  this is because the package isn't spliced correctly:
  ```
  $ tree -L 2 /nix/store/b9iyqcsd1gmlfagpi4xqqlswcpx079r1-aarch64-unknown-linux-gnu-stage-final-gcc-debug-7.4.0
  /nix/store/b9iyqcsd1gmlfagpi4xqqlswcpx079r1-aarch64-unknown-linux-gnu-stage-final-gcc-debug-7.4.0
  ├── aarch64-unknown-linux-gnu
  │   ├── include
  │   ├── lib
  │   ├── lib64
  │   └── sys-include
  ├── bin
  │   ├── aarch64-unknown-linux-gnu-c++
  │   ├── aarch64-unknown-linux-gnu-cpp
  │   ├── aarch64-unknown-linux-gnu-g++
  │   ├── aarch64-unknown-linux-gnu-gcc
  │   ├── aarch64-unknown-linux-gnu-gcc-7.4.0
  │   ├── aarch64-unknown-linux-gnu-gcc-ar
  │   ├── aarch64-unknown-linux-gnu-gcc-nm
  │   ├── aarch64-unknown-linux-gnu-gcc-ranlib
  │   ├── aarch64-unknown-linux-gnu-gcov
  │   ├── aarch64-unknown-linux-gnu-gcov-dump
  │   └── aarch64-unknown-linux-gnu-gcov-tool
  ├── include
  ├── lib
  │   ├── gcc
  │   └── libcc1.a
  ├── lib64 -> lib
  ├── libexec
  │   └── gcc
  ├── nix-support
  │   └── propagated-build-inputs
  └── share
      └── locale
  ```

  The cross compiled packages depend on the `aarch64-unknown-linux-gnu/lib` folder, but this path also contains x86 binaries in it! (like `aarch64-unknown-linux-gnu-gcc`).

  This causes a bunch of other run-time x86 dependencies to be packaged with the cross-compiled binaries.

  @matthewbauer pointed me here: https://github.com/matthewbauer/nixpkgs/blob/static-nix/pkgs/development/compilers/gcc/builder.sh#L203-L287, which is possibly broken.

  Trying to move the ARM libs into the `lib` output caused a cyclic dependency between the lib output and the normal output :( so I'm stuck & posting this issue.

  ### Steps to reproduce

  build a cross-compiled binary with a cross `gcc`, notice that it has x86 binaries in it's run-time closure (assuming the build system is x86):

  ```
  nix build -f . pkgsCross.aarch64-multiplatform.glibc
  nix path-info -r $(readlink -f result) | while read f; do find $f -type f -exec file {} + | grep $(uname -m | tr _ -); done
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.20.6-arch1-1-ARCH, Antergos Linux, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.1`
   - channels(root): `"nixpkgs-19.09pre171945.b36dc66bfea"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`


state: closed
title: postman: 6.7.3 -> 7.0.6
user_login: d10n
html_url: https://github.com/NixOS/nixpkgs/pull/58502
updated_at: 2019-04-03 20:56:56
body:
  ###### Motivation for this change
  To squelch the annoying red "upgrade available" dot

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stellarium: 0.18.3 -> 0.19.0
user_login: geistesk
html_url: https://github.com/NixOS/nixpkgs/pull/58503
updated_at: 2019-03-29 02:52:28
body:
  ###### Motivation for this change
  Update `stellarium` to current version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Static proot, wafHook cross compilation
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/58504
updated_at: 2019-05-18 15:59:41
body:
  ###### Motivation for this change

  Have `pkgsStatic.proot.override {enablePython = false;}` compile.

  ###### Things done

  * Let `wafHook` use the vendored waf even if it is not located at `./waf`
  * Make `wafHook` ignore `--disable-shared` added by pkgsStatic
  * Make `wafHook` add the necessary configure flags for cross compilation transparently
  * adapt tdb and talloc to these modifications
  * fix cross compilation of proot

  ###### Things tested

  Compilation of `tdb`, `talloc` and `proot` (with python disabled) in `pkgs`, `pkgsStatic` and `pkgsCross.raspberryPi`. `pkgsStatic.tdb` does not work because the waf script can only build a shared library.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


  cc @matthewbauer as the author of wafHook.


state: closed
title: cairo: fix cross
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/58505
updated_at: 2019-03-28 22:15:45
body:
  ###### Motivation for this change

  otherwise the build fails with:
  ```
  checking whether float word ordering is bigendian... ./configure: line 19792: strings: command not found
  ./configure: line 19795: strings: command not found
  ```

  Testable with `nix-build . -A pkgsCross.raspberryPi.txtw` (a random derivation depending on cairo only), and then `/nix/store/m11nhrskv9wyy3g1av5jnbkl2ik078pp-qemu-3.1.0/bin/qemu-arm result/bin/txtw -h` works.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update wine{unstable,staging,mono,winetricks}
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/58506
updated_at: 2019-04-17 16:21:22
body:
  ###### Motivation for this change

  * wine{unstable,staging}: 4.2 -> 4.5
  * wine-mono: 4.7.5 -> 4.8.0
  * winetricks: 20181203 -> 20190310

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cairo: fix cross
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/58507
updated_at: 2019-05-18 16:01:14
body:
  ###### Motivation for this change

  I messed up when rebasing https://github.com/NixOS/nixpkgs/pull/58505 on staging.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openrct2: 0.2.1 -> 0.2.2
user_login: geistesk
html_url: https://github.com/NixOS/nixpkgs/pull/58508
updated_at: 2019-03-30 22:09:02
body:
  ###### Motivation for this change
  Updates OpenRCT2 to the current release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos: make hardware.enableAllFirmware enable *all* firmware
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/58509
updated_at: 2019-05-18 15:58:57
body:
  ###### Motivation for this change

  otherwise the name is misleading.

  ###### Things done

  * booted a vm with enableAllFirmware = true and nothing obviously wrong was in dmesg
  * checked that enableRedistributableFirmware evaluates without allowUnfree

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dovecot_pigeonhole: 0.5.4 -> 0.5.5
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/58511
updated_at: 2019-04-08 00:03:47
body:
  ###### Motivation for this change
  This is the appropriate version for dovecot 2.3.5 according to
  https://dovecot.org/pipermail/dovecot-news/2019-March/000400.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: solr: init at 8.0.0
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/58512
updated_at: 2019-04-14 09:57:23
body:
  ###### Motivation for this change
  Don't want to force existing users into new major version right away, let them choose when to upgrade to the 8.x series.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnutls: enable latest version on Darwin
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/58513
updated_at: 2019-04-22 15:18:01
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/commit/d6454e6a1593f12e17d982a1ad30c97ca7cf130a was held back because https://github.com/NixOS/nixpkgs/issues/24693, which was implemented in https://github.com/NixOS/nixpkgs/pull/27598 cc: @vcunat

  Fixes https://github.com/NixOS/nixpkgs/issues/58481

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodejs-11_x: 11.11.0 -> 11.13.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/58514
updated_at: 2019-03-30 15:26:55
body:
  ###### Motivation for this change
  Changelog:
  https://nodejs.org/en/blog/release/v11.12.0/
  https://nodejs.org/en/blog/release/v11.13.0/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hplip: add missing dependency
user_login: hhm0
html_url: https://github.com/NixOS/nixpkgs/pull/58515
updated_at: 2019-07-17 21:18:30
body:
  Graphical programs (e.g. hp-setup) error with:

  ```
  error: No module named enum
  ```

  This adds the `enum` module which fixes the error.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Bazel runfiles helper script overwrites PATH
user_login: dicarlo2
html_url: https://github.com/NixOS/nixpkgs/issues/58516
updated_at: 2019-03-29 19:31:06
body:
  ## Issue description

  `$PATH` is evaluated within nix. Instead, it should be `echo "PATH=\$PATH:${defaultShellPath}"`

  https://github.com/NixOS/nixpkgs/blob/673c8193cdb12abf137e6fd58ec6042b7afc5bed/pkgs/development/tools/build-managers/bazel/default.nix#L215 


state: closed
title: iterm2: fix build
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/58517
updated_at: 2019-03-31 02:08:57
body:
  ###### Motivation for this change

  During iterm2's build, xcodebuild invokes $LD and passes it options such as -isysroot. These options are intended for the linker driver (clang), not for the linker directly. ld64 ($LD) does not recognize these options, causing iterm2's build to fail.

  Set $LD to $CC (clang) as intended, making iterm2's build succeed. This fixes issue #35412.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I tested installing iTerm 2 by running `nix-env -iA iterm2 ~/Projects/nixpkgs/` on a MacBook Pro with the following software configuration:

  * macOS 10.12.6
  * Xcode 8.3.3
    * MacOSX10.12.sdk
    * Apple LLVM version 8.1.0 (clang-802.0.42)
    * x86_64-apple-darwin16.7.0
    * ld64-278.4

  ---


state: closed
title: postfix: 3.4.3 -> 3.4.4
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/58519
updated_at: 2019-03-30 19:03:07
body:
  ###### Motivation for this change
  http://www.postfix.org/announcements/postfix-3.4.4.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: inter,inter-ui: keep font name the same for attributes, split off
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58520
updated_at: 2019-04-05 21:05:23
body:
  Feedback please! This is one solution to the problem,
  but since it's a small amount of work wanted an actual PR
  and so if we like it it's easy to proceed.

  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/57605#issuecomment-477874093

  From upstream repository activity, it appears they're working
  to be included in google fonts?
  However I'm not sure it's worth "waiting" on that,
  and it's nice to have the font you wnt directly sometimes
  instead of the big bundle :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cmocka: 1.1.3 -> 1.1.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58521
updated_at: 2019-03-29 15:04:32
body:
  ###### Motivation for this change

  https://gitlab.com/cmocka/cmocka/tags/cmocka-1.1.5
  slightly more descriptive note about the release
  on https://cmocka.org but not easy to link.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: weston: 5.0.0 -> 6.0.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58522
updated_at: 2019-06-01 05:28:12
body:
  ###### Motivation for this change

  https://lists.freedesktop.org/archives/wayland-devel/2019-March/040356.html
  https://lists.freedesktop.org/archives/wayland-devel/2019-March/040334.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested a handful of the executables, not sure how to use all of them :3.


state: closed
title: gitAndTools.hub: 2.10.0 -> 2.11.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58524
updated_at: 2019-03-29 09:38:32
body:
  ###### Motivation for this change

  https://github.com/github/hub/releases/tag/v2.11.0
  https://github.com/github/hub/releases/tag/v2.10.2
  https://github.com/github/hub/releases/tag/v2.10.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Haskell optional separate bin output
user_login: domenkozar
html_url: https://github.com/NixOS/nixpkgs/pull/58525
updated_at: 2019-04-02 04:33:43
body:
  The first commit adds most minimal separate output support (by not trigger recompilation on generic builder).

  The second commit proves it's already useful.


state: open
title: Add background option to dhcpcd
user_login: bene1618
html_url: https://github.com/NixOS/nixpkgs/pull/58526
updated_at: 2019-05-18 10:19:38
body:
  ###### Motivation for this change

  DHCP waits for an IP address to be assigned before forking to background. This causes a lag during startup. I removed the -w option from the .service file, and added it, optionally, to the dhcpcd.config file. One can now make dhcpcd fork to background automatically by adding "networking.dhcpcd.background = true;" in the NixOS configuration. On my system, this reduced userspace startup time from about 11s to about 3s.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ x ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ x ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: runc: 1.0.0-rc6 -> 1.0.0-rc7
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/58527
updated_at: 2019-03-31 10:03:34
body:
  Signed-off-by: Vincent Demeester <vincent@sbr.pm>

  ###### Motivation for this change

  Bump to latest rc release, see [release notes](https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc7) (mainly CVE-2019-5736)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gradle: 5.0 -> 5.3.1
user_login: groodt
html_url: https://github.com/NixOS/nixpkgs/pull/58528
updated_at: 2019-04-01 18:59:18
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [Package request]: lintian
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/issues/58529
updated_at: 2019-04-03 07:20:51
body:
  ## Issue description

  Might be nice to debug/check debian packages.

  https://salsa.debian.org/lintian/lintian


state: open
title: Gamehub init
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/58530
updated_at: 2019-03-30 04:32:10
body:
  ###### Motivation for this change

  #58189 

  ###### Things done

  This PR is not complete, it's building but wine or any game will not work

  `result/bin/com.github.tkashkin.gamehub --help` is working as expected
  `result/bin/com.github.tkashkin.gamehub` is launching


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: 66.0.1 -> 66.0.2, firefox-bin: 66.0.1 -. 66.0.2
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58531
updated_at: 2019-03-29 22:58:01
body:
  ###### Motivation for this change

  Update to latest release that fixes a few crashes on specific websites

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] firefox: 66.0.1 -> 66.0.2, firefox-bin: 66.0.1 -. 66.0.2
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58532
updated_at: 2019-03-29 22:57:39
body:
  ###### Motivation for this change

  Backport of #58531

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: assaultcube: unstable-2017-05-01 -> unstable-2018-05-20
user_login: bignaux
html_url: https://github.com/NixOS/nixpkgs/pull/58533
updated_at: 2019-03-29 15:02:17
body:
  ###### Motivation for this change

  improve a little the derivation : remove patch and custom script in favor of nixos idioms.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sumatools: init at 1.0.34
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58534
updated_at: 2019-04-24 20:34:36
body:
  ###### Motivation for this change
  Application developed by my research laboratory and used into our computing center

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] firefox: 66.0.1 -> 66.0.2, firefox-bin: 66.0.1 -> 66.0.2
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/58535
updated_at: 2019-03-29 22:57:33
body:
  ###### Motivation for this change

  Backport of #58155 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clblas: turn of gtest, fix build
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/58536
updated_at: 2019-03-29 15:41:44
body:
  ###### Motivation for this change
  clblas does not work anymore with gmock 1.8.1.
  Turning off the test suite does not seem to be the best solution but fixes the build.

  See https://github.com/NixOS/nixpkgs/issues/58427

  Should be back ported to 19.03 (https://github.com/NixOS/nixpkgs/issues/56826)

  CC @artuuge 
  ###### Things done

  * Remove gtest from derivation
  * fix libgpuarray build, which depends on clblas

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lib: lists: Alias map = builtins.map
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/58537
updated_at: 2019-03-29 14:35:47
body:
  Suggested by @Profpatsch (added in trailer in commit message)

  ###### Motivation for this change

  We really should have an alias here for consistency.


state: closed
title: stacks: init at 2.3e
user_login: bzizou
html_url: https://github.com/NixOS/nixpkgs/pull/58538
updated_at: 2019-04-03 12:57:31
body:
  ###### Motivation for this change
  Tool used by biologists in our computing center (GRICAD). The package is in production since a few months, so, has been tested with real use cases.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/nextcloud: Cherry-pick nginx recommendations to 19.03
user_login: herrwiese
html_url: https://github.com/NixOS/nixpkgs/pull/58539
updated_at: 2019-05-02 20:41:00
body:
  ###### Motivation for this change

  This is already present in master, but didn't find its way into 19.03 release yet, which is kind of annoying as it keeps Nextcloud issueing a warning in Settings->Administration Overview, 'Your web server is not properly set up to resolve "/ocm-provider".'

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: JupyterHub broken (ModuleNotFoundError)
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/58540
updated_at: 2019-03-31 15:34:20
body:
  ## Issue description

  JupyterHub seems to be broken.

  ### Steps to reproduce

  Launch JupyterHub and sign in from the browser.

  ```
  $ nix-shell -p "python3.withPackages (ps: with ps; [jupyterhub notebook])"

  [nix-shell:~]$ jupyterhub
  [I 2019-03-29 15:48:37.995 JupyterHub app:1673] Using Authenticator: jupyterhub.auth.PAMAuthenticator-0.9.4
  [I 2019-03-29 15:48:37.995 JupyterHub app:1673] Using Spawner: jupyterhub.spawner.LocalProcessSpawner-0.9.4
  [I 2019-03-29 15:48:37.998 JupyterHub app:1016] Loading cookie_secret from /home/jluttine/jupyterhub_cookie_secret
  [I 2019-03-29 15:48:38.016 JupyterHub proxy:431] Generating new CONFIGPROXY_AUTH_TOKEN
  [W 2019-03-29 15:48:38.017 JupyterHub app:1173] No admin users, admin interface will be unavailable.
  [W 2019-03-29 15:48:38.017 JupyterHub app:1174] Add any administrative users to `c.Authenticator.admin_users` in config.
  [I 2019-03-29 15:48:38.017 JupyterHub app:1201] Not using whitelist. Any authenticated user will be allowed.
  [I 2019-03-29 15:48:38.052 JupyterHub app:1855] Hub API listening on http://127.0.0.1:8081/hub/
  [W 2019-03-29 15:48:38.054 JupyterHub proxy:565] Running JupyterHub without SSL.  I hope there is SSL termination happening somewhere else...
  [I 2019-03-29 15:48:38.054 JupyterHub proxy:567] Starting proxy @ http://:8000
  15:48:38.204 [ConfigProxy] info: Proxying http://*:8000 to (no default)
  15:48:38.207 [ConfigProxy] info: Proxy API at http://127.0.0.1:8001/api/routes
  15:48:38.326 [ConfigProxy] info: 200 GET /api/routes 
  [I 2019-03-29 15:48:38.326 JupyterHub proxy:301] Checking routes
  [I 2019-03-29 15:48:38.326 JupyterHub proxy:370] Adding default route for Hub: / => http://127.0.0.1:8081
  15:48:38.329 [ConfigProxy] info: Adding route / -> http://127.0.0.1:8081
  15:48:38.330 [ConfigProxy] info: 201 POST /api/routes/ 
  [I 2019-03-29 15:48:38.330 JupyterHub app:1912] JupyterHub is now running at http://:8000
  [I 2019-03-29 15:48:48.134 JupyterHub log:158] 302 GET / -> /hub (@127.0.0.1) 0.74ms
  [I 2019-03-29 15:48:48.196 JupyterHub log:158] 302 GET /hub -> /hub/ (jluttine@127.0.0.1) 0.62ms
  [I 2019-03-29 15:48:48.211 JupyterHub log:158] 302 GET /hub/ -> /user/jluttine/ (jluttine@127.0.0.1) 13.70ms
  [I 2019-03-29 15:48:48.224 JupyterHub log:158] 302 GET /user/jluttine/ -> /hub/user/jluttine/ (@127.0.0.1) 2.01ms
  [W 2019-03-29 15:48:48.312 JupyterHub auth:642] Failed to open PAM session for jluttine: [PAM Error 3] Error in service module
  [W 2019-03-29 15:48:48.312 JupyterHub auth:643] Disabling PAM sessions from now on.
  [I 2019-03-29 15:48:48.327 JupyterHub spawner:1100] Spawning jupyterhub-singleuser --port=49063
  Failed to set groups [Errno 1] Operation not permitted
  Traceback (most recent call last):
    File "/nix/store/ghjp7c799wsvbhw67a2w9095nzwxqg76-python3.7-jupyterhub-0.9.4/lib/python3.7/site-packages/jupyterhub/singleuser.py", line 19, in <module>
      import notebook
  ModuleNotFoundError: No module named 'notebook'

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/nix/store/ghjp7c799wsvbhw67a2w9095nzwxqg76-python3.7-jupyterhub-0.9.4/bin/.jupyterhub-singleuser-wrapped", line 4, in <module>
      from jupyterhub.singleuser import main
    File "/nix/store/ghjp7c799wsvbhw67a2w9095nzwxqg76-python3.7-jupyterhub-0.9.4/lib/python3.7/site-packages/jupyterhub/singleuser.py", line 21, in <module>
      raise ImportError("JupyterHub single-user server requires notebook >= 4.0")
  ImportError: JupyterHub single-user server requires notebook >= 4.0
  [W 2019-03-29 15:48:58.272 JupyterHub web:1667] 500 GET /hub/user/jluttine/ (127.0.0.1): Spawner failed to start [status=1]. The logs for jluttine may contain details.
  [E 2019-03-29 15:48:58.306 JupyterHub log:150] {
        "Host": "127.0.0.1:8081",
        "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0",
        "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8",
        "Accept-Language": "en-US,en;q=0.5",
        "Accept-Encoding": "gzip, deflate",
        "Connection": "keep-alive",
        "Cookie": "<censored>",
        "Upgrade-Insecure-Requests": "1"
  ```

  ## Technical details


  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.103, NixOS, 19.09.git.1233c8d (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: closed
title: megahit: init at 1.1.4
user_login: luispedro
html_url: https://github.com/NixOS/nixpkgs/pull/58541
updated_at: 2019-03-31 13:09:49
body:
  This is widely used in bioinformatics for assembling genomes &
  metagenomes


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)

  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  Tested main programme, the rest are used internally


  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.jupyterhub: Fix running locally
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58542
updated_at: 2019-04-01 09:00:13
body:
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/58540

  Ping @jluttine 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) 277.8MB -> 325.1MB (+17%)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libfido2: init at 1.1.0 (and libcor dep)
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58543
updated_at: 2019-05-21 08:25:56
body:
  ###### Motivation for this change

  https://developers.yubico.com/FIDO2/

  Seems good to have-- although don't know of any
  projects using it yet, the recent 1.0.0 release
  might see this change.
  For example it looks like pam-u2f is poised
  to move to this, see upstream PR 98.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.hub: 2.11.0 -> 2.11.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58544
updated_at: 2019-03-29 20:05:44
body:
  ###### Motivation for this change

  https://github.com/github/hub/releases/tag/v2.11.1

  Hopefully this settles down soon ^_^.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/gitlab: Install and fixup vendorised gitlab-shell
user_login: bgamari
html_url: https://github.com/NixOS/nixpkgs/pull/58545
updated_at: 2019-04-02 16:03:14
body:
  ###### Motivation for this change

  gitaly now ships its own vendorised version of gitlab-shell. Previously
  we failed to install this, resulting in
  https://gitlab.com/gitlab-org/gitlab-ce/issues/59403.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: intel-{gmmlib,media-{driver,sdk}}: 18.4.1 -> ~19.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58546
updated_at: 2019-04-26 04:43:48
body:
  ###### Motivation for this change

  Update set of intel driver goodness!


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  closes #58683


state: closed
title: ghc: make disableLargeAddressSpace configurable
user_login: luispedro
html_url: https://github.com/NixOS/nixpkgs/pull/58547
updated_at: 2019-03-29 16:49:07
body:
  ###### Motivation for this change
  Even on Linux/NixOS, it can be useful to have a compiler without the large address space as it creates issues in some contexts (e.g., http://haskell.1045720.n5.nabble.com/Issues-with-the-large-address-space-allocator-and-HPC-systems-with-resource-limits-td5878939.html)

  So, this PR makes the setting configurable.

  ###### Things done

  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions

  ---


state: closed
title: lugaru: init at 1.2
user_login: bignaux
html_url: https://github.com/NixOS/nixpkgs/pull/58548
updated_at: 2019-03-30 21:20:59
body:
  ###### Motivation for this change

  OSS Lugaru !

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffmpeg: 3.4.5 -> 3.4.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58549
updated_at: 2019-03-30 00:15:54
body:
  https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/0ac9001ab9f2bdd7c4306afd1a91d6c78b294d9f:/Changelog


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: whois: 5.4.1 -> 5.4.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58550
updated_at: 2019-03-30 00:14:15
body:
  ###### Motivation for this change

  https://github.com/rfc1036/whois/blob/v5.4.2/debian/changelog

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: Fix PATH escaping
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58551
updated_at: 2019-03-31 02:48:50
body:
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/58516

  Ping @dicarlo2 @Profpatsch (original author of this line)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/deluge: add autFile, config and port options
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/58552
updated_at: 2019-06-04 21:42:22
body:
  ###### Motivation for this change
  It add multiples options to the deluge service to have a level of configuration similar to transmission: config, ports and auth.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfs_unstable: 0.8.0-rc3 -> 2019-03-29
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/pull/58553
updated_at: 2019-03-31 00:25:59
body:
  ###### Motivation for this change

  Adding ssd trim patch to zfs unstable: https://github.com/zfsonlinux/zfs/pull/8419

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Unable to mount NTFS drive from Nautilus
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/issues/58554
updated_at: 2019-03-29 23:56:38
body:
  When I try to open a NTFS-formatted drive from Nautilus, it fails with:

  ```
  Error mounting /dev/sdc1 at /run/media/jtojnar/Elements: wrong fs type, bad option, bad superblock on /dev/sdc1, missing codepage or helper program, or other error
  ```

  I see the following error in journal:

  ```
  ntfs: (device sdc1): parse_options(): Unrecognized mount option windows_names.
  ```


state: closed
title: Cannot change system date
user_login: jappeace
html_url: https://github.com/NixOS/nixpkgs/issues/58555
updated_at: 2019-03-30 10:35:12
body:
  ## Issue description

  I wish to change the system date to prepare an webapp for daylight savings.
  I don't think this is possible.

  ### Steps to reproduce

  ```bash
  #( 03/29/19@ 9:32 )( jappie@portable-jappie-nixos ):~
     sudo timedatectl set-time '2019-04-01'
  [sudo] wachtwoord voor jappie: 
  Failed to set time: Automatic time synchronization is enabled
  #( 03/29/19@ 9:32 )( jappie@portable-jappie-nixos ):~
     sudo timedatectl set-ntp false
  Failed to set ntp: Changing system settings via systemd is not supported on NixOS.

  ```
  I expect to be able to disable ntp so that I can change the system date.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.103, NixOS, 18.09.2253.753f58d9a42 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2266.aabc61049c0, nixos-18.09-18.09.2266.aabc61049c0"`
   - channels(jappie): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: steamcmd: Add needed binaries to PATH
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/58556
updated_at: 2019-04-06 14:34:23
body:
  ###### Motivation for this change
  Should fix https://github.com/NixOS/nixpkgs/issues/58479

  @pmiddend Can you test whether this fixes your issue?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: 0.22.0 doesn't build in Darwin sandbox
user_login: groodt
html_url: https://github.com/NixOS/nixpkgs/pull/58557
updated_at: 2019-03-31 09:17:39
body:
  ###### Motivation for this change
  There have been a number of attempts to include new versions of Bazel in nixpkgs, built on top of the existing derivation for 0.22.0.

  See:
  https://github.com/NixOS/nixpkgs/pull/58147
  https://github.com/NixOS/nixpkgs/pull/58116
  https://github.com/NixOS/nixpkgs/pull/56587

  All of these attempts have stalled because Ofborg builds for Darwin time out and local sandbox builds fail.

  Local failure:
  ```
  no configure script, doing nothing
  building
  mkdir: cannot create directory '/tmp/.bazel-501': Operation not permitted
  builder for '/nix/store/l13iplvdf344kadkd7iqbci65kxly8vz-bazel-0.22.0.drv' failed with exit code 1
  error: build of '/nix/store/l13iplvdf344kadkd7iqbci65kxly8vz-bazel-0.22.0.drv' failed
  ```

  This PR is intended to demonstrate that the 0.22.0 version suffers from the same sandboxing problems and that the currently published 0.22.0 version of Bazel was published with sandboxing disabled.

  To me this indicates that something has changed with Darwin sandboxing on Ofborg to make it more restrictive (and correct) than it was previously. Or, somehow the existing Bazel 0.22.0 on Hydra was published with sandboxing disabled. It doesn't really matter what happened, but it raises an interesting question: What now?

  The Bazel 0.22.0 build is not reproducible under sandboxing and future versions of Bazel are unlikely to build with `sandbox = true` on Darwin unless something significant happens with a JDK version that can execute inside the sandbox.



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bazel: 0.22.0 doesn't build in Darwin sandbox
user_login: groodt
html_url: https://github.com/NixOS/nixpkgs/issues/58558
updated_at: 2019-03-31 20:24:49
body:
  ## Issue description
  bazel: 0.22.0 doesn't build in Darwin sandbox


  ### Steps to reproduce
  Take a look and build the Bazel derivation in this PR:
  https://github.com/NixOS/nixpkgs/pull/58557

  `nix-build -A bazel`

  It will fail on Darwin with `sandbox = true` and succeed with `sandbox = false`


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: dotnetPackages.FsLexYaccRuntime: init at 6.1.0
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/58559
updated_at: 2019-04-05 18:05:54
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: harfbuzz: 2.3.1 -> 2.4.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58560
updated_at: 2019-05-01 03:49:23
body:
  https://github.com/harfbuzz/harfbuzz/releases/tag/2.4.0
  https://lists.freedesktop.org/archives/harfbuzz/2019-March/007277.html


  ###### Motivation for this change

  harfbuzz, unicode 12 \o/!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qownnotes: 19.3.0 -> 19.3.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58561
updated_at: 2019-03-30 22:08:35
body:
  ###### Motivation for this change

  bump! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ttyplot: 1.1 -> 1.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58562
updated_at: 2019-03-30 08:57:12
body:
  ###### Motivation for this change

  bump! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vdirsyncer fails to sync
user_login: loewenheim
html_url: https://github.com/NixOS/nixpkgs/issues/58563
updated_at: 2019-04-08 07:07:32
body:
  ## Issue description
  `vdirsyncer sync` fails with the vdirsyncer version from nixos-unstable. it works if I install vdirsyncer with pip.

  ```
  $ vdirsyncer -vdebug sync 
  debug: Using 1 maximal workers.
  debug: Fetching value for password.fetch with command strategy.
  Syncing contacts/32
  error: Unknown error occurred for contacts/32: Server did not return etag.
  error: Use `-vdebug` to see the full traceback.
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/cli/tasks.py", line 69, in sync_collection
  debug:     partial_sync=pair.partial_sync
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/sync/__init__.py", line 143, in sync
  debug:     b_nonempty = b_info.prepare_new_status()
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/sync/__init__.py", line 60, in prepare_new_status
  debug:     if prefetch else ()):
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/storage/base.py", line 149, in get_multi
  debug:     item, etag = self.get(href)
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/storage/_rust.py", line 42, in get
  debug:     native.check_error(e)
  debug:   File "/nix/store/y9qgx26b2w2lzqhqb7sd9cb6cz8dj7pa-vdirsyncer-unstable-2018-08-05/lib/python3.7/site-packages/vdirsyncer/native.py", line 35, in check_error
  debug:     errors.check_exception(e[0])
  debug:   File "/nix/store/4xg6a6pqm9v3b1vfmjncqy0w18iqfrhj-python3.7-shippai-0.3.2/lib/python3.7/site-packages/shippai/__init__.py", line 150, in check_exception
  debug:     raise exc
  error: 1 out of 2 tasks failed.
  ```

  ## Technical details

  Output of `nix-shell -p nix-info --run "nix-info -m"`:
  ```
  - system: `"x86_64-linux"`
   - host os: `Linux 4.19.30, NixOS, 19.09pre173349.07b42ccf2de (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre173349.07b42ccf2de"`
   - channels(****): `"home-manager"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: xcur2png: init at 0.7.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/58564
updated_at: 2019-04-01 09:39:39
body:
  ###### Motivation for this change

  https://github.com/eworm-de/xcur2png

  > xcur2png is a program which let you take PNG image from X cursor, and generate config-file which is reusable by xcursorgen. To put it simply, it is converter from X cursor to PNG image.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: cgit: add support for default filters
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/58565
updated_at: 2019-06-11 13:28:02
body:
  ###### Motivation for this change

  This adds support for source code and about page filters that are shipped with cgit.
  The new module options default to the previous behaviour.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC package maintainer: @bjornfor 


state: closed
title: blur-effect: init at 1.1.3
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/58566
updated_at: 2019-04-01 03:26:37
body:
  ###### Motivation for this change

  https://github.com/sonald/blur-effect

  > off-screen image blurring utility using OpenGL ES 3.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: openmw: 0.44 -> 0.45
user_login: geekware
html_url: https://github.com/NixOS/nixpkgs/pull/58567
updated_at: 2019-03-30 02:59:45
body:
  ###### Motivation for this change

  Bump openmw-0.44 -> 0.45 plus migrate to Qt5 #33239

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: electron{,_3}: minor updates
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58569
updated_at: 2019-03-31 02:35:15
body:
  ###### Motivation for this change

  Happened to notice, might as well ;).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spleen: init at 1.0.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/58570
updated_at: 2019-03-30 22:03:43
body:
  ###### Motivation for this change

  Default console font on OpenBSD, FWIW:
  https://undeadly.org/cgi?action=article;sid=20190110064857

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - err, fonts :D
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Provide a texlive collection with everything needed by sphinx
user_login: nomeata
html_url: https://github.com/NixOS/nixpkgs/issues/58571
updated_at: 2019-03-31 12:49:05
body:
  I a trying to use nixpkgs to build sphinx documentation, including pdf output, and I am currently writing an expression
  ```
        tex = pkgs.texlive.combine {
          inherit (pkgs.texlive) scheme-basic latexmk cmap collection-fontsrecommended fncychap titlesec tabulary;
        };
  ```
  by trial and error, adding one package at a time.

  This is a bit silly, and I feel that if I call `sphinx latexpdf`, then I should not be concerned with the internal dependencies of sphinx, which are an implementation detail. Also, as sphinx evolve, this will break.

  It would be nice therefore if there was a ready-made derivation or texlive package set for “all things needed by sphinx”.


state: closed
title: stupidterm: 2018-09-25 -> 2019-03-26
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58572
updated_at: 2019-03-31 06:17:42
body:
  ###### Motivation for this change
  Update contains clearing of urgency hint and they started shipping
  their own .desktop file, so we switched to using that.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/58573
updated_at: 2019-03-30 10:45:13
body:
  ###### Motivation for this change

  Regular vim plugins update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages.phpc(s|bf): 3.4.0 -> 3.4.1
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58574
updated_at: 2019-03-31 06:17:18
body:
  ###### Motivation for this change
  Changelog: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.4.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages.phpstan: 0.11.3 -> 0.11.5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58575
updated_at: 2019-03-31 06:18:38
body:
  ###### Motivation for this change
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Gitea: SQLite support broken
user_login: elohmeier
html_url: https://github.com/NixOS/nixpkgs/issues/58576
updated_at: 2019-03-30 13:11:01
body:
  ## Issue description
  SQLite support was broken in Gitea by the latest change to the buildFlags.

  https://github.com/NixOS/nixpkgs/blob/5bc72b87b1a82eccad03c9146a8ce86eeaa9153d/pkgs/applications/version-management/gitea/default.nix#L38

  I'm currently using `buildFlags = "-tags sqlite"` to fix the issue.

  ### Steps to reproduce
  Run Gitea with a configured Sqlite database.


  ## Technical details

   - system: `"x86_64-linux"`                                                               
   - host os: `Linux 4.14.103, NixOS, 18.09.2436.395a543f360 (Jellyfish)`                   
   - multi-user?: `yes`                                                                     
   - sandbox: `yes`                                                                         
   - version: `nix-env (Nix) 2.1.3`                                                         
   - channels(root): `"nixos-18.09.2436.395a543f360, nixos-unstable-19.09pre173349.07b42ccf2de"`                                                                                      
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: gitea: 1.7.3 -> 1.7.5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58577
updated_at: 2019-04-15 05:52:27
body:
  ###### Motivation for this change
  Changelogs:
  https://github.com/go-gitea/gitea/releases/tag/v1.7.5
  https://github.com/go-gitea/gitea/releases/tag/v1.7.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] gitea: 1.7.1 -> 1.7.5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58578
updated_at: 2019-04-15 05:52:30
body:
  ###### Motivation for this change
  Backport of #58577 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: paps: init at 0.7.0
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/58579
updated_at: 2019-03-30 16:36:20
body:
  ###### Motivation for this change
  A Pango to PostScript converter

  paps reads a UTF-8 encoded file and generates a PostScript language rendering of the file. The rendering is done by creating outline curves through the pango ft2 backend.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimpager: Init at 2.06 and master
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/58580
updated_at: 2019-03-31 12:32:12
body:
  Adding a package vimpager-latest because the last release was 2015.

  ###### Motivation for this change

  Closes #56768

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: semver-tool: init at 2.1.0
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/58581
updated_at: 2019-03-31 20:06:12
body:
  Cherry-picked from: https://github.com/alyssais/nixpkgs/commit/eeb175169f65201bd47ece5d0593d3c7c386077d
  Although fixed so that it actually builds.

  ###### Motivation for this change

  Closes: https://github.com/NixOS/nixpkgs/issues/50945
  Superceeds and closes: https://github.com/NixOS/nixpkgs/pull/51004

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mysql.initialDatabases.….schema is not of type `null or path`
user_login: schneefux
html_url: https://github.com/NixOS/nixpkgs/issues/58582
updated_at: 2019-05-27 12:57:22
body:
  ## Issue description
  I have the following mysql configuration:
  ```nix
  services.mysql = {
    enable = true;
    package = pkgs.mysql;
    initialDatabases = [
      { name = "nextcloud"; schema = ""; }
    ];
    initialScript = /etc/nixos/setup-credentials.sql;
  };
  ```
  With the changes from #57550, I get the error
  > The option value 'services.mysql.initialDatabases.[definition 1-entry 1].schema" in `/etc/nixos/configuration.nix' is not of type 'null or path'.

  Is this intentional?

  I looked further and saw that as of #25950, `schema` is now optional. Removing it I get the error
  > cannot coerce null to a string, at /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/databases/mysql.nix:363:66

  ### Steps to reproduce

  see above

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.98, NixOS, 19.09pre173381.2b9aa0ac90e (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre174075.aaae785f903"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: tokei: 9.0.0 -> 9.1.1
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/58583
updated_at: 2019-04-02 18:25:42
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitea: Fix sqlite support and baked-in tags
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/58584
updated_at: 2019-03-31 03:34:45
body:
  ###### Motivation for this change
  Fixes #58576
  Also includes all the tags in --version.
  Needs backport to 19.03, cc #56826 


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Installing with more than one nixos channel fails
user_login: hyperfekt
html_url: https://github.com/NixOS/nixpkgs/issues/58585
updated_at: 2019-03-30 14:23:26
body:
  ## Issue description
  When trying to use `nixos-install` with more than one nixos channel, installation will fail.
  The same does not happen when adding just the `nixos-unstable` channel.

  [This](https://github.com/NixOS/nixpkgs/blob/5c669af4abd5c5cd6842b6e6d5831f28e7f6351d/nixos/modules/installer/tools/nixos-install.sh#L108-L122) is the relevant part in the install script.

  ### Steps to reproduce
  1. Boot from live image
  1. `nix-channel --add https://nixos.org/channels/nixos-19.03 nixos-1903`
  1. `nix-channel --update`
  1. `nixos-generate-config --root /mnt`
  1. `nixos-install --root /mnt`

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.20.0, NixOS, 18.09.2436.395a543f360 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2436.395a543f360, nixos-1903-19.03beta171840.23fd1394dc6, nixos-unstable-19.09pre173349.07b42ccf2de"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: [19.03] gitea: Fix sqlite support and baked-in tags
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/58586
updated_at: 2019-03-30 14:41:03
body:
  (cherry picked from commit 14d0412e93e05b151d58b9ca61fbd4a2de49fac6)

  ###### Motivation for this change
  Backport #58584

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vlc: Add chromecast support; libmicrodns: Init at 0.0.10
user_login: shazow
html_url: https://github.com/NixOS/nixpkgs/pull/58588
updated_at: 2019-04-01 15:16:43
body:
  ###### Motivation for this change

  VLC normally ships with Chromecast support enabled by default, in the official binaries as well as in other distros (arch, ubuntu, possibly others).

  Chromecast support for VLC has been requested on several occasions (https://github.com/NixOS/nixpkgs/pull/35124#issuecomment-385791097, #58365 from me, and [a bunch of times on IRC](https://www.google.ca/search?q="nixos"+"chromecast"+"vlc"+"irc+logs")). 

  This PR adds libmicrodns which is a library written by the VLC team that is required for their Chromecast streaming to function.

  It also adds Chromecast support to the VLC build enabled by default, but can be overridden.

  Fixes #58365.

  This is my first nixpkgs contribution, please be gentle. :blush: 

  Some notes/questions:
  - I'm not sure if this is a strict requirement, but enabling hardware acceleration is important for transcoding especially: https://nixos.wiki/wiki/Accelerated_Video_Playback - I needed to add `intel-media-driver ` to get `libva info: va_openDriver() returns -1` errors to stop. Not sure what's a more generalized solution. Is there a good place to document this? (Otherwise VLC spits out a bunch of errors, might fall back or not)
  - Port 8010 must be open (streaming works by creating a temporary HTTP server on port 8010 which streams the transcoded video, then points the Chromecast to open that local URL). Any suggestions for documenting/enforcing this?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openblas: fix aarch64 build
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/58589
updated_at: 2019-04-07 15:07:04
body:
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/56949

  Attempt to fix the openblas breakage on aarch64
  https://github.com/NixOS/nixpkgs/pull/56216

  If we are not cross compiling then openblas expects:
  * on x86_64 `NO_BINARY_MODE=`
  * on aarch64 `NO_BINARY_MODE=0`

  using the `toString` to translate the value for `NO_BINARY_MODE` is wrong here
  since `mkMakeFlagValue` is supposed to translate bools to string in the right way.

  Needs backport to 19.03

  CC @dtzWill 

  See also: ZHF 19.03, https://github.com/NixOS/nixpkgs/issues/56826

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ZHF 19.03: backports FileSlurp update
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/58591
updated_at: 2019-03-31 19:17:06
body:
  ###### Motivation for this change

  See #57977 

  The referenced commit by @srhb has been orphaned from its tree, and I didn't really know how to cherry-pick + attribute properly. I additionally removed the now unneeded file.

    * https://github.com/NixOS/nixpkgs/commit/ce019a511b155e0ae2c0d76e875e23110033d8af

  cc #56826

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hydra: fix build
user_login: danbst
html_url: https://github.com/NixOS/nixpkgs/pull/58592
updated_at: 2019-03-30 21:00:42
body:
  Apply patch from https://github.com/NixOS/hydra/pull/648
  This patch only affects tests in checkPhase, so nothing should change in runtime.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: riot-desktop uses mkYarnPackage
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/issues/58593
updated_at: 2019-04-12 19:51:09
body:
  ## Issue description
  [yarn2nix was removed from nixpkgs](https://github.com/NixOS/nixpkgs/commit/8559b0a36a40d8341805240de62ba00b70a0a5c1) and this is the only application here that was using.


state: open
title: freediag: init at unstable-2019-02-18
user_login: bignaux
html_url: https://github.com/NixOS/nixpkgs/pull/58594
updated_at: 2019-04-02 02:45:50
body:
  ###### Motivation for this change

  unstable-2019-02-18 since @fenugrec had not released since some years and later the better!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yarn2nix: move to aliases.nix
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/58595
updated_at: 2019-04-12 20:34:23
body:
  ###### Motivation for this change
  IIRC that's where things like this belonged.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/rename: drop system.nixos.{stateVersion, defaultChannel}
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/58596
updated_at: 2019-03-31 00:10:49
body:
  Comment said to remove these before 18.09 was released :(

  ###### Motivation for this change
  I'm not sure if the comment in the file isn't valid anymore?
  But I'm guessing we should remove these now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: riot-desktop: use own yarn2nix
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/58597
updated_at: 2019-04-12 19:51:09
body:
  ###### Motivation for this change

  Use our own copy of `yarn2nix` as that package is being removed (#58424).

  github ref: closes #58593

  CC: @worldofpeace 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mspdebug: darwin fixes and enableParallelBuilding
user_login: AerialX
html_url: https://github.com/NixOS/nixpkgs/pull/58598
updated_at: 2019-07-02 21:52:46
body:
  ###### Motivation for this change

  I didn't realise `enableParallelBuilding` wasn't the default behaviour, and the build needed fixing on darwin. mspdebug's makefile attempts to detect whether homebrew/fink/macports is used on the system, so this kicks it down the right execution path.

  Also includes a precursor to #58600, which allows for plugging in the msp debug stack into the binary's runtimepath (mspdebug uses dlopen to find the library). The derivations themselves are left to the other PR, since they may need more thorough review or may not be appropriate for inclusion in nixpkgs etc.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


