# issues

state: closed
title: xbacklight reports "No outputs have backlight property"
user_login: Luis-Hebendanz
html_url: https://github.com/NixOS/nixpkgs/issues/59927
updated_at: 2019-07-11 14:26:26
body:
  ## Issue description
  The xbacklight utility errors out on 19.03 with:

  ```
   $ xbacklight -set 800  
  No outputs have backlight property
  ```
  And if I specifically define the Monitor following error happens:
  ```
  xbacklight -d eDP-1 -set 800                                                                   
  RANDR Query Version returned error -1
  ```
  I noticed that after upgrading to 19.03 my monitor device names changed from eDP1 to eDP-1 and so on. It probably has something to do with that.
  I used the 5.0 Kernel and the 4.19.35-hardened Kernel both had the same issue.

  On Debian there is anopen issue on that from 2016:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=833508

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.8, NixOS, 19.03.172286.8ea36d73256 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172286.8ea36d73256, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Filtering src recursively when creating a derivation
user_login: lippirk
html_url: https://github.com/NixOS/nixpkgs/issues/59928
updated_at: 2019-04-21 19:23:17
body:
  I'm creating a derivation using items in a big folder, but I only actually want to use a few files to create the derivation. These files are nested in various directories. So I thought I could use `sourceByRegex` to select those files. But unfortunately `sourceByRegex` only seems to search through the top level of a folder.

  For example:

  ```
  $ tree
  .
  ├── 1
  ├── 2
  ├── 3
  ├── default.nix
  ├── folder
  │   ├── 1
  │   └── 2
  └── result -> /nix/store/951h922h1cx55703yk5fqj1l059d7kvg-my-drv

  2 directories, 6 files

  ```
  ```
  $ cat default.nix
  {pkgs ? import <nixpkgs> {}}:
  pkgs.stdenv.mkDerivation {
    name = "my-drv";
    src = pkgs.lib.sources.sourceByRegex ./. ["2" "folder\/.*"];
    installPhase = ''
      set -e
      mkdir -p $out/bin
      cp -r $src/* $out/bin/
      '';
  }

  $ ls /nix/store/951h922h1cx55703yk5fqj1l059d7kvg-my-drv/bin
  2
  ```

  I hoped to see the both the file `2` and also `folder` in that last output, but only `2` was copied.

  Is there another way to achieve this?


state: closed
title: Adding pkgconfig as described in manual breaks kernel compilation with make
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/59929
updated_at: 2019-07-10 06:59:25
body:
  ## Issue description

  In https://nixos.org/nixos/manual/index.html#sec-linux-config-customizing and https://nixos.wiki/wiki/Linux_Kernel#make_menuconfig it is described that to get `make menuconfig` working on a Linux kernel build, you should do:

  ```
  $ nix-shell -E 'with import <nixpkgs> {}; linux.overrideAttrs (o: {nativeBuildInputs=o.nativeBuildInputs ++ [ pkgconfig ncurses ];})'
  [nix-shell] $ unpackPhase && cd linux-*
  [nix-shell] $ make menuconfig
  ```

  Inside that shell though, `make` to build the kernel breaks with `error: "__LIBELF_INTERNAL__" is not defined`.

  Removing `pkgconfig` from the list fixes the issue.

  Why is that happening?

  If we can't fix it, we should at least update the wiki and manual.

  ### Steps to reproduce

  Full repro with `nix 2.0.4` and nixpkgs commit 4a11ce7f261396d06a92b76df702b16dc01b81ca:

  ```
  [root@builder:~/kernel]# mkdir tmpdir

  [root@builder:~/kernel]# cd tmpdir

  [root@builder:~/kernel/tmpdir]# NIX_PATH=nixpkgs=$HOME/kernel/nixpkgs nix-shell -E 'with import <nixpkgs> {}; linux.overrideAttrs (o: {nativeBuildInputs=o.nativeBuildInputs ++ [ pkgconfig ncurses ];})'

  [nix-shell:~/kernel/tmpdir]# unpackPhase
  unpacking source archive /nix/store/z7wzk01hjfgdcbnbzpkq040v7k9hw427-linux-4.19.36.tar.xz
  source root is linux-4.19.36
  setting SOURCE_DATE_EPOCH to timestamp 1555744565 of file linux-4.19.36/virt/lib/irqbypass.c

  [nix-shell:~/kernel/tmpdir]# cd linux-*

  [nix-shell:~/kernel/tmpdir/linux-4.19.36]# cp ../../chromebook-kernel-config .config

  [nix-shell:~/kernel/tmpdir/linux-4.19.36]# yes "" | make oldconfig > /dev/null
  .config:852:warning: symbol value 'm' invalid for NF_NAT_REDIRECT
  .config:955:warning: symbol value 'm' invalid for NF_NAT_MASQUERADE_IPV4
  .config:987:warning: symbol value 'm' invalid for NF_NAT_MASQUERADE_IPV6

  [nix-shell:~/kernel/tmpdir/linux-4.19.36]# make 
    SYSTBL  arch/x86/include/generated/asm/syscalls_32.h
    SYSHDR  arch/x86/include/generated/asm/unistd_32_ia32.h
    SYSHDR  arch/x86/include/generated/asm/unistd_64_x32.h
    SYSTBL  arch/x86/include/generated/asm/syscalls_64.h
    SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
    SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h
    SYSHDR  arch/x86/include/generated/uapi/asm/unistd_x32.h
    HOSTCC  arch/x86/tools/relocs_32.o
    HOSTCC  arch/x86/tools/relocs_64.o
    HOSTCC  arch/x86/tools/relocs_common.o
    HOSTLD  arch/x86/tools/relocs
    UPD     include/config/kernel.release
    WRAP    arch/x86/include/generated/uapi/asm/bpf_perf_event.h
    WRAP    arch/x86/include/generated/uapi/asm/poll.h
    WRAP    arch/x86/include/generated/asm/dma-contiguous.h
    WRAP    arch/x86/include/generated/asm/early_ioremap.h
    WRAP    arch/x86/include/generated/asm/export.h
    WRAP    arch/x86/include/generated/asm/mcs_spinlock.h
    WRAP    arch/x86/include/generated/asm/mm-arch-hooks.h
    UPD     include/generated/uapi/linux/version.h
    UPD     include/generated/utsrelease.h
    CC      kernel/bounds.s
    UPD     include/generated/bounds.h
    UPD     include/generated/timeconst.h
    CC      arch/x86/kernel/asm-offsets.s
    UPD     include/generated/asm-offsets.h
    CALL    scripts/checksyscalls.sh
    DESCEND  objtool
  In file included from <stdin>:1:0:
  /nix/store/0qf90669fmmm1d79fl96msb8rgfz67vb-libelf-0.8.13/include/libelf/libelf.h:28:5: error: "__LIBELF_INTERNAL__" is not defined, evaluates to 0 [-Werror=undef]
   #if __LIBELF_INTERNAL__
       ^~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
    HOSTCC   /root/kernel/tmpdir/linux-4.19.36/tools/objtool/fixdep.o
    HOSTLD   /root/kernel/tmpdir/linux-4.19.36/tools/objtool/fixdep-in.o
    LINK     /root/kernel/tmpdir/linux-4.19.36/tools/objtool/fixdep
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/exec-cmd.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/help.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/pager.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/parse-options.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/run-command.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/sigchain.o
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/subcmd-config.o
    LD       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/libsubcmd-in.o
    AR       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/libsubcmd.a
    GEN      /root/kernel/tmpdir/linux-4.19.36/tools/objtool/arch/x86/lib/inat-tables.c
    CC       /root/kernel/tmpdir/linux-4.19.36/tools/objtool/arch/x86/decode.o
  In file included from arch/x86/../../elf.h:22:0,
                   from arch/x86/decode.c:26:
  /nix/store/0qf90669fmmm1d79fl96msb8rgfz67vb-libelf-0.8.13/include/libelf/gelf.h:25:5: error: "__LIBELF_INTERNAL__" is not defined, evaluates to 0 [-Werror=undef]
   #if __LIBELF_INTERNAL__
       ^~~~~~~~~~~~~~~~~~~
  In file included from arch/x86/../../elf.h:22:0,
                   from arch/x86/decode.c:26:
  /nix/store/0qf90669fmmm1d79fl96msb8rgfz67vb-libelf-0.8.13/include/libelf/gelf.h:31:5: error: "__LIBELF_NEED_LINK_H" is not defined, evaluates to 0 [-Werror=undef]
   #if __LIBELF_NEED_LINK_H
       ^~~~~~~~~~~~~~~~~~~~
  /nix/store/0qf90669fmmm1d79fl96msb8rgfz67vb-libelf-0.8.13/include/libelf/gelf.h:33:7: error: "__LIBELF_NEED_SYS_LINK_H" is not defined, evaluates to 0 [-Werror=undef]
   #elif __LIBELF_NEED_SYS_LINK_H
         ^~~~~~~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
  mv: cannot stat '/root/kernel/tmpdir/linux-4.19.36/tools/objtool/arch/x86/.decode.o.tmp': No such file or directory
  make[4]: *** [/root/kernel/tmpdir/linux-4.19.36/tools/build/Makefile.build:97: /root/kernel/tmpdir/linux-4.19.36/tools/objtool/arch/x86/decode.o] Error 1
  make[3]: *** [/root/kernel/tmpdir/linux-4.19.36/tools/build/Makefile.build:139: arch/x86] Error 2
  make[2]: *** [Makefile:49: /root/kernel/tmpdir/linux-4.19.36/tools/objtool/objtool-in.o] Error 2
  make[1]: *** [Makefile:63: objtool] Error 2
  make: *** [Makefile:1652: tools/objtool] Error 2
  ```


state: closed
title: Guake won't start on NixOS 19.03
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/issues/59930
updated_at: 2019-04-22 03:26:50
body:
  ## Issue description
  I am trying to start the guake terminal under a gnome3 desktop and get 
  ```
  [ERROR] Unable to start Guake, missing mandatory dependency: Keybinder 3
  ```
  Looking at its derivation `keybinder3` is part of the `buildInputs` and should be there. Any ideas what's going wrong here? 

  ### Steps to reproduce
  ```
  nix-env -i guake
  guake
  ```

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.35, NixOS, 19.03.172286.8ea36d73256 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172286.8ea36d73256"`
   - channels(markus): `"nixpkgs-19.03.172286.8ea36d73256"`


state: closed
title: profanity: 0.5.1 -> 0.6.0
user_login: eri451
html_url: https://github.com/NixOS/nixpkgs/pull/59931
updated_at: 2019-04-25 19:45:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I noticed the [announcement of the profanity.im release version 0.6.0](https://github.com/boothj5/profanity/releases/tag/0.6.0)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: startx: fix typos for startx option description
user_login: mlvzk
html_url: https://github.com/NixOS/nixpkgs/pull/59932
updated_at: 2019-04-21 07:46:44
body:
  ###### Motivation for this change

  Fix typos in services.xserver.displayManager.startx.enable.description

  ###### Things done

  `~/.xinintrc` => `~/.xinitrc`
  `autmatically` => `automatically`


state: closed
title: appleseed: 1.9.0-beta -> 2.0.5-beta (fixes build)
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59933
updated_at: 2019-04-24 00:25:06
body:
  ###### Motivation for this change

  `appleseed`'s build looks like it was broken by a bump of `osl`. `1.9.0-beta` doesn't seem to build against this new version, but `2.0.5-beta` does, provided we set `-Wno-unused-but-set-variable`
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: coreutils-8.31 is broken on musl
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/59934
updated_at: 2019-05-12 14:26:22
body:
  ## Issue description

  /cc @dtzWill 

  This appears to be some issue introduced in coreutils 8.31. The log result is:

  ```
  /nix/store/3gpwl9qq007w9dxn09nw9rj0jwpywp50-aarch64-unknown-linux-musl-binutils-2.31.1/bin/aarch64-unknown-linux-musl-ld: lib/libcoreutils.a(strtold.o):/build/coreutils-8.31/lib/strtod.c:305: multiple definition of `minus_zero'; lib/libcoreutils.a(strtod.o):/build/coreutils-8.31/lib/strtod.c:305: first defined here
  ```

  Job is here:

  https://hydra.nixos.org/job/nixpkgs/cross-trunk/aarch64-musl.coreutils.x86_64-linux

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: wla-dx-git: 2017-06-05 -> 2019-03-10
user_login: solson
html_url: https://github.com/NixOS/nixpkgs/pull/59935
updated_at: 2019-07-03 05:08:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I need a newer version of this package so I am bumping the package to the latest git commit. At some point we could replace `wla-dx-git` with an official version numbered release, but the latest one of those is still too old for me.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nordic-polar: 1.4.0 -> 1.5.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59936
updated_at: 2019-04-20 22:00:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [1.5.0](https://github.com/EliverLara/Nordic-Polar/releases/tag/v.1.5.0)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: LilyPond: Fix configure error - incorrectly detected fontforge version
user_login: tex
html_url: https://github.com/NixOS/nixpkgs/pull/59937
updated_at: 2019-04-23 20:27:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix broken build. It fails on Hydra too.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nordic: 1.5.4 -> 1.6.5
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59938
updated_at: 2019-04-21 01:24:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update to version [1.6.5](https://github.com/EliverLara/Nordic/releases/tag/v1.6.5)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.deepin-mutter: fix paths related to plugins and desktop files
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59939
updated_at: 2019-05-05 20:04:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - deepin.deepin-mutter: set plugins dir from environment variable
  - deepin.deepin-mutter: use absolute path in desktop file

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  See also https://github.com/NixOS/nixpkgs/pull/59244#issuecomment-485097016

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.deepin-wm: fix paths related to plugins and desktop files
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59940
updated_at: 2019-05-11 02:36:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - ~~deepin.deepin-wm: set plugins dir from environment variable~~
  - deepin.deepin-wm: use absolute path in desktop file

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  See also https://github.com/NixOS/nixpkgs/pull/59244#issuecomment-485097016


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.dde-polkit-agent: set plugins dir from environment variable
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59941
updated_at: 2019-05-11 23:22:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  deepin.dde-polkit-agent: set plugins dir from environment variable

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  See also https://github.com/NixOS/nixpkgs/pull/59244#issuecomment-485097016


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: neopg: 0.0.4 -> 0.0.6
user_login: erictapen
html_url: https://github.com/NixOS/nixpkgs/pull/59942
updated_at: 2019-04-22 21:46:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/deepin: use only one module for deepin services
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59943
updated_at: 2019-05-05 23:52:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Use a single module for the dbus services, systemd services, kernel modules, groups and users needed by some deepin applications and for the deepin desktop environment.

  The services needed for applications that can be run outside of the deepin desktop environment can be enabled independently. The ones that are useful only for running the desktop are kept together.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  See also https://github.com/NixOS/nixpkgs/pull/59560#issuecomment-483351578.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: librsvg-2.45.5 broken on darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/59944
updated_at: 2019-04-22 03:25:25
body:
  ## Issue description

  Job: https://hydra.nixos.org/job/nixpkgs/trunk/librsvg.x86_64-darwin

  Log:

  ```
    CCLD     librsvg-2.la

  *** Warning: Linking the shared library librsvg-2.la against the
  *** static library /private/tmp/nix-build-librsvg-2.45.5.drv-0/librsvg-2.45.5/target/release/librsvg_internals.a is not portable!
  Undefined symbols for architecture x86_64:
    "_g_desktop_app_info_get_implementations", referenced from:
        gio::auto::desktop_app_info::DesktopAppInfo::get_implementations::hd61cee2ed025f55b in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
    "_g_desktop_app_info_get_type", referenced from:
        _$LT$gio..auto..desktop_app_info..DesktopAppInfo$u20$as$u20$glib..types..StaticType$GT$::static_type::hd437fc3c3909c7bc in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
    "_g_desktop_app_info_new", referenced from:
        gio::auto::desktop_app_info::DesktopAppInfo::new::h24e53ce90e45ff97 in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
    "_g_desktop_app_info_new_from_keyfile", referenced from:
        gio::auto::desktop_app_info::DesktopAppInfo::new_from_keyfile::haba2870e8d2586f9 in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
    "_g_desktop_app_info_search", referenced from:
        gio::desktop_app_info::_$LT$impl$u20$gio..auto..desktop_app_info..DesktopAppInfo$GT$::search::h3714b284ef82ff46 in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
    "_g_desktop_app_info_set_desktop_env", referenced from:
        gio::auto::desktop_app_info::DesktopAppInfo::set_desktop_env::h4f4705081cdf8a2c in librsvg_internals.a(gio-b466a6b949b79cce.gio.8ozrrwrp-cgu.6.rcgu.o)
  ld: symbol(s) not found for architecture x86_64
  ```

  Opened a ticket here:

  https://gitlab.gnome.org/GNOME/librsvg/issues/456

  Looks to be an upstream issue.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: nixos/virtualbox: Fixes configuration to evaluate
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/59945
updated_at: 2019-04-22 00:17:16
body:
  Fixes issue introduced by #57557

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ✔️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ✔️ NixOS
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)

  --

  cc @matthewbauer 


state: closed
title: hyperrogue: add .desktop file and icon
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59946
updated_at: 2019-04-26 03:54:37
body:
  ###### Motivation for this change

  Add .desktop file and icons.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oraclejdk: use working mirror for download
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/59947
updated_at: 2019-04-25 16:35:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  http://download.oracle.com/otn-pub/ was recently renamed to http://download.oracle.com/otn/ and now requires authentication with an Oracle account. http://download.oracle.com/otn-pub/ links don't work anymore, so installing oraclejdk fails.

  Switch to http://javadl.oracle.com/webapps/download/GetFile/, which does not require authentication. This fixes installing oraclejdk.

  Note: The URL for JCE is still broken; this commit only fixes the URL for the JDK.

  This commit fixes nixpkgs issue #59761.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: how to mapping buildInputs nix package to cabal extra-libraries
user_login: clojurians-org
html_url: https://github.com/NixOS/nixpkgs/issues/59948
updated_at: 2019-05-01 05:15:43
body:
  i use oracle-instantclient nix package to build a project.
  but the Extra-Libraries is clntsh for cabal project.
  i have no idea how to build a mapping for nix package and cabal extra-libraries
  ```
  larrys-MBP:db-to-yaml larluo$ nix-shell
  error: anonymous function at /nix/store/khsdqb8dn18hjw1k9x5bmls2s8xh8z0j-cabal2nix-db-to-yaml/default.nix:1:1 called without required argument 'clntsh', at /nix/store/awbp09f74hgxq2wyjx1bcairfjh2psxc-nixpkgs-19.09pre173720.d73f16d6767/nixpkgs/pkgs/development/haskell-modules/make-package-set.nix:87:27
  ```

  ```
  { pkgs ? import <nixpkgs> {}} : 

  with pkgs; 
  let 
    pkg = haskellPackages.developPackage {
      root = ./.;

      modifier = drv: haskell.lib.overrideCabal drv (attrs: {
        buildTools = (attrs.buildTools or []) ++ [haskellPackages.cabal-install] ;
      }) ;
    } ;
    buildInputs = [ oracle-instantclient ] ;
  in pkg.overrideAttrs(attrs: {
    buildInputs = attrs.buildInputs ++ buildInputs ;
  })

  ```

  ```
  larrys-MBP:db-to-yaml larluo$ cat db-to-yaml.cabal                                                                                                                              
  cabal-version:       >=1.10                                                                                                                                                     
  -- Initial package description 'db-to-yaml.cabal' generated by 'cabal                                                                                                           
  -- init'.  For further documentation, see                                                                                                                                       
  -- http://haskell.org/cabal/users-guide/                                                                                                                                        

  name:                db-to-yaml
  version:             0.1.0.0
  -- synopsis:
  -- description:
  -- bug-reports:
  license:             BSD3
  license-file:        LICENSE
  author:              clojurians-org
  maintainer:          larluo@clojurians.org
  -- copyright:
  -- category:
  build-type:          Simple
  extra-source-files:  CHANGELOG.md

  executable db-to-yaml
    main-is:             Main.hs
    other-modules:
        Database.Oracle
      , Database.Oracle.OCIConstants
      , Database.Oracle.OCIFunctions
      , Database.Oracle.Util
    -- other-extensions:
    If os(windows)
      Extra-Libraries: oci
    Else
      Extra-Libraries: clntsh
    build-depends:
        base
      , mtl
      , HDBC
      , bytestring
      , time
      , old-time
    hs-source-dirs:      src
    default-language:    Haskell2010

  ```


state: closed
title: nginxModules: update and add nginx modules
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59949
updated_at: 2019-05-22 18:28:49
body:
  Update nginx modules:
  - http_proxy_connect_module to 16.04.2019
  - dav to 3.0.0
  - lua to 0.10.14
  - upstream-check to 12.08.2018
  - upstream-tarantool to 2.7.1
  - subsFilter to 13.04.2016

  Added nginx modules:
  - live 18.11.2018
  - mpeg-ts 0.1.1
  - coolkit 0.2
  - slowfs-cache 1.10
  - limit-speed 21.05.2014
  - sorted-querystring 0.3
  - video-thumbextractor 0.9.0
  - naxsi 0.56

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nginxMainline: 1.15.10 -> 1.15.12
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59950
updated_at: 2019-04-22 04:50:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update nginx to 1.15.12

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: adoptopenjdk-bin: 11.0.2 -> 11.0.3 [Security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/59951
updated_at: 2019-04-22 21:34:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change

  - Security fixes
  - Other fixes

  https://adoptopenjdk.net/release_notes.html#jdk11_0_3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jellyfin: 10.2.2 -> 10.3.0
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/59952
updated_at: 2019-04-23 10:11:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Tested on a 19.03 server by cherry-picking the commits

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] deepin.deepin-manual: init at 2.0.19
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59953
updated_at: 2019-04-21 11:12:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add the deepin-manual package.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: brogue: add .desktop file and icon
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59954
updated_at: 2019-04-26 03:54:32
body:
  ###### Motivation for this change

  Add XDG .desktop file and icon. Note that the .desktop file included in
  the source archive is not used because it uses unsuitable paths and
  refers to an old version of the game.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/hardened: option to use hardened-malloc systemwide
user_login: joachifm
html_url: https://github.com/NixOS/nixpkgs/pull/59955
updated_at: 2019-05-12 15:18:26
body:
  Not sure if this is the best way to go about this, but seems to "work", in that e.g., double free is detected & killed.

  Not enabled by the hardened profile for now, needs a bit of testing.


state: closed
title: dosbox: add XDG icon
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59956
updated_at: 2019-04-26 03:54:27
body:
  ###### Motivation for this change

  Add an XDG icon for dosbox. The official icon is in .ico format, which
  is not compatible with the freedesktop.org spec, so graphicsmagick is
  included as a build time dependency and used to convert it to a PNG.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: devpi-server: fix build by forcing use of pytest_3
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59957
updated_at: 2019-04-21 12:28:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This is a draft PR because it sits on top of a couple of commits that are already in another PR https://github.com/NixOS/nixpkgs/pull/59431

  Similarly it fixes the build by forcing use of `pytest_3`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "osinfo-db: 20190301 -> 20190319"
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/59958
updated_at: 2019-04-21 13:41:28
body:
  Reverts NixOS/nixpkgs#59626

  It's breaking `libosinfo` test suite
  ```
  /isodetect/haiku: **
  ERROR:test-isodetect.c:414:test_one: assertion failed (shortid == info->shortid): ("haikur1beta1" == "haikunightly")
  FAIL
  ```


state: open
title: Could not connect to wpa_supplicant: (nil) - re-trying
user_login: musq
html_url: https://github.com/NixOS/nixpkgs/issues/59959
updated_at: 2019-04-21 19:21:16
body:
  ## Issue description
  As pointed by #1204, the `wpa_cli` gives the following error when installing NixOS from LiveCD

  `Could not connect to wpa_supplicant: (nil) - re-trying`

  ## Steps to reproduce

  There are 3 scenarios:

  ### cli installer
  1. Boot up the live CD 19.03
  1. Run `wpa_cli` on the prompt from root user
  1. Get error. Wifi doesn't work

  ### gui installer
  1. Boot up the live CD 19.03
  1. Run `systemctl start display-manager` to start KDE
  1. Configure Wifi from the UI
  1. Wifi works

  ### nixos configuration
  1. Reboot on successfully installing nixos using the gui installer
  1. Make sure to keep `networking.wireless.enable = true;` in `/etc/nixos/configuration.nix`
  1. Run `wpa_cli` on the prompt from root user
  1. Get error. Wifi doesn't work

  Note that in both the cases (cli installer & nixos configuration), I've put the following in `/etc/wpa_supplicant.conf`
  ```
  ctrl_interface=/run/wpa_supplicant
  ctrl_interface_group=wheel
  ```

  Running `strace wpa_cli` gives the following error

  ```
  openat(AT_FDCWD, "/var/run/wpa_supplicant", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = -1 ENOENT (No such file or directory)
  ```

  ## Technical details

  Live CD: `https://releases.nixos.org/nixos/19.03/nixos-19.03.172306.73c885246fc/nixos-graphical-19.03.172306.73c885246fc-x86_64-linux.iso`
  Laptop - `Asus Zenbook 430ua`
  System: `x86_64-linux`


state: closed
title: wf-recorder: unstable-2019-03-12 -> unstable-2019-04-21
user_login: CrazedProgrammer
html_url: https://github.com/NixOS/nixpkgs/pull/59960
updated_at: 2019-04-21 16:12:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Updates the `wf-recorder` program to the latest commit from master. A couple things have been added, most notably audio recording support (hence the new `libpulseaudio` dependency).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gifsicle: 1.91 -> 1.92
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59961
updated_at: 2019-04-23 02:47:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `gifsicle` to the latest release.
  http://www.lcdf.org/gifsicle/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: http-parser: 2.9.1 -> 2.9.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59962
updated_at: 2019-04-25 02:26:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `http-parser` to the latest release.
  https://github.com/nodejs/http-parser/releases/tag/v2.9.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: seasocks: init at 1.4.2
user_login: FredeEB
html_url: https://github.com/NixOS/nixpkgs/pull/59965
updated_at: 2019-04-22 22:22:34
body:
  ###### Motivation for this change

  Needed seasocks for a project, so i made a nix package for it!

  ###### Things done

  - Added `pkgs/development/libraries/seasocks/default.nix`
  - Added `seasocks = callPacakge ../development/libraries/seasocks {};`
  - Only tested in nix shell. But works as intended in development environment, correctly setting `$NIX_LDFLAGS` and `$NIX_CFLAGS_COMPILE` to include the needed library and header files.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions (Manjaro)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mate: 1.20 -> 1.22
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59966
updated_at: 2019-04-24 14:54:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update the [MATE Desktop Environment](https://mate-desktop.org) to version 1.22.

  [MATE 1.22 released](https://mate-desktop.org/blog/2019-03-18-mate-1-22-released/)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: nixbox: init at unstable-2019-04-20"
user_login: LinArcX
html_url: https://github.com/NixOS/nixpkgs/pull/59967
updated_at: 2019-05-16 16:52:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I need a central app to manage all nixos operations in one place. So with nixbox i can manage Derivations, Generations(delete them, list them, ..), manage channels, fix nix store, ... in single application without worry to memorize their commands. 


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: guake: fix by setting strictDeps to false
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/59968
updated_at: 2019-04-22 11:13:46
body:
  ###### Motivation for this change
  `StrictDeps` breaks guake (see https://github.com/NixOS/nixpkgs/issues/56943).

  Closes https://github.com/NixOS/nixpkgs/issues/59930

  Needs backport to 19.03
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  Tested on NixOS 19.03
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fix bootstrap when platform.gcc.arch=="skylake"
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59969
updated_at: 2019-04-23 20:24:45
body:
  Exceprt from #59148 needed to bootstrap post-#59225 ```staging``` with ```gcc.arch == "skylake"``` (mainly by avoiding to pass unsupported flags to bootstrap GCC and by preventing to build on the machines which did not declare their architecture as nix-build feature)


state: closed
title: bash_5: 5.0-p2 -> 5.0-p7
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59970
updated_at: 2019-04-21 23:24:42
body:
  ###### Motivation for this change

  https://ftp.gnu.org/gnu/bash/bash-5.0-patches/bash50-003
  https://ftp.gnu.org/gnu/bash/bash-5.0-patches/bash50-004
  https://ftp.gnu.org/gnu/bash/bash-5.0-patches/bash50-005
  https://ftp.gnu.org/gnu/bash/bash-5.0-patches/bash50-006
  https://ftp.gnu.org/gnu/bash/bash-5.0-patches/bash50-007

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: teeworlds: 0.7.2 -> 0.7.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59971
updated_at: 2019-04-21 23:24:04
body:
  ###### Motivation for this change

  https://www.teeworlds.com/forum/viewtopic.php?id=12807

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: shadowfox: 1.5.2 -> 1.7.20, move to buildGoModule
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59972
updated_at: 2019-04-22 04:06:32
body:
  ###### Motivation for this change

  update, remove deps.nix

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: superTuxKart: 0.9.3 -> 1.0
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59973
updated_at: 2019-04-25 04:28:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  http://blog.supertuxkart.net/2019/04/supertuxkart-10-release.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nghttp2: 1.37.0 -> 1.38.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59974
updated_at: 2019-04-22 21:56:06
body:
  ###### Motivation for this change

  https://nghttp2.org/blog/2019/04/18/nghttp2-v1-38-0/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.ColanderAlchemy: fix build by pinning to colander 1.6.0
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59975
updated_at: 2019-04-26 07:15:26
body:
  ###### Motivation for this change
  ColanderAlchemy doesn't seem to have been updated for colander 1.7.0, or at least its tests haven't been and we get a single, subtle test failure around null handling which I don't feel comfortable disabling. Issue filed upstream https://github.com/stefanofontanelli/ColanderAlchemy/issues/107


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rrdtool: add passthru.perlModule
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59976
updated_at: 2019-04-22 21:44:34
body:
  ... so it can be used in `perl.withPackages`

  A bit tricky though, because rrdtool is not in `perlPackages`
  ```nix
  perl.withPackages(p: [ (rrdtool.override{ inherit (p) perl; }) ])
  ```


state: closed
title: Plank don't start in GNOME 3
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/59977
updated_at: 2019-04-21 19:01:45
body:
  ## Issue description

  After the upgrade from NixOS 18.09 to 19.03, plank only shows an error and exits.

  ```
  [davidak@X230:~]$ plank -v
  [INFO 20:40:31.900345] [AbstractMain:229] Plank version: 0.11.4
  [INFO 20:40:31.900454] [AbstractMain:230] Kernel version: 4.19.36
  [INFO 20:40:31.900519] [AbstractMain:231] GLib version: 2.58.2 (2.58.2)
  [INFO 20:40:31.900587] [AbstractMain:234] GTK+ version: 3.24.5 (3.24.5)
  [INFO 20:40:31.900644] [AbstractMain:237] Wnck version: 3.30.0
  [INFO 20:40:31.900701] [AbstractMain:238] Cairo version: 1.16.0
  [INFO 20:40:31.900752] [AbstractMain:239] Pango version: 1.42.4
  [INFO 20:40:31.900799] [AbstractMain:241] + Cairo/Gtk+ HiDPI support enabled
  [INFO 20:40:31.900854] [AbstractMain:244] + Dynamic Quicklists support enabled
  [INFO 20:40:31.900909] [AbstractMain:247] + XInput Barriers support enabled
  [WARN 20:40:31.900994] [Environment:161] XDG_SESSION_CLASS not set in this environment!
  [CRITICAL 20:40:31.901091] [AbstractMain:257] Only X11 environments are supported.
  ```

  Reason: GNOME uses Wayland by default now.

  ```
  [davidak@X230:~]$ loginctl
  SESSION  UID USER    SEAT  TTY 
        2 1000 davidak seat0 tty2

  1 sessions listed.

  [davidak@X230:~]$ loginctl show-session 2 -p Type
  Type=wayland
  ```

  This is a problem upstream has to fix. There is a bugreport from 2016, but no one seem to work on it. https://bugs.launchpad.net/plank/+bug/1632841

  ### Steps to reproduce

  I have plank and bamf added in my config.

  https://github.com/davidak/nixos-config/blob/aa887b50cf601b3ee1bbafc02f92c9f5a7ccc7ae/services/elementary.nix

  Then i try to start plank.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: [demo, do not merge] nix-serve: $PERL5LIB -> perl.withPackages
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59979
updated_at: 2019-07-12 22:21:41
body:
  ###### Motivation for this change

  Do not merge.

  Just a demo how to get rid of manipulation with long ```$PERL5LIB``` using recently introduced ```perl.withPackages```
  Related discussions in https://github.com/NixOS/nixpkgs/pull/55786 https://github.com/NixOS/nixpkgs/pull/53495
  @cleverca22 @peterhoeg 


state: closed
title: perl: 5.28.1 -> 5.28.2
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59980
updated_at: 2019-04-22 02:02:51
body:
  version bump.

  still building here (the very fact the NixOS is still building is promising, because perl is used in bootstrap)


state: open
title: WIP: Add discourse package & nixos module
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/59981
updated_at: 2019-07-06 11:25:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I'd like us to have a fallback story for https://discourse.nixos.org hosting.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This whole thing is very much a WIP at the moment. 

  ~I'm mainly opening this PR to get some help fixing the https://github.com/discourse/mini_racer/ build.~
  ~Build output: https://gist.github.com/adisbladis/a8f073f9a00b51eead6849dea299f236~
  edit: `mini_racer` is fixed, thanks @ju1m

  Things to do:
  - [ ] `execjs` gem fails at runtime, cannot find suitable implementation
  - [ ] Add missing nixos module options (database & redis)
  - [ ] Make test do something more meaningful
  - [ ] nodejs frontend stuffs
  - [ ] ???
  - [ ] Profit


state: closed
title: Pantheon uses icons and settings from previous GNOME session
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/59982
updated_at: 2019-04-22 00:33:35
body:
  ## Issue description

  I upgraded to 19.03 and switched from GNOME 3 to Pantheon.

  I noticed that the elementary icons are not used.

  ![Screenshot from 2019-04-21 22-01-17](https://user-images.githubusercontent.com/91113/56474915-06d9b300-6481-11e9-83c0-1bccdb0be9c8.png)

  the menu icons are also strange:
  ![Screenshot from 2019-04-21 21-41-44](https://user-images.githubusercontent.com/91113/56474929-3e485f80-6481-11e9-9820-aa20be78628e.png)

  and the window decoration is huge for some apps:
  ![Screenshot from 2019-04-21 22-07-04](https://user-images.githubusercontent.com/91113/56474967-dba39380-6481-11e9-9849-e834bff41bb1.png)

  With gnome-tweaks you see, that the default gnome theme and icons are used. I can set them to Elementary.

  ![Screenshot from 2019-04-21 22-15-00](https://user-images.githubusercontent.com/91113/56475053-56b97980-6483-11e9-9418-f34c70153b25.png)

  ![Screenshot from 2019-04-21 22-15-45](https://user-images.githubusercontent.com/91113/56475056-5a4d0080-6483-11e9-86e7-291bcf324a45.png)

  @worldofpeace can you provide a one-liner to reset the settings and add it to the NixOS manual?

  ### Steps to reproduce

  1. use gnome
  2. then use pantheon

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: prometheus-statsd-exporter: 0.4.0 -> 0.9.0
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/59983
updated_at: 2019-05-08 09:12:19
body:
  ###### Motivation for this change

  https://github.com/prometheus/statsd_exporter/releases

  Note that the output binary has changed from `statsd_bridge` to `statsd_exporter` and that the command-line arguments have changed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I sent a counter to it over UDP and it seemed to work.


state: closed
title: switchboard crash when click on "Security & Privacy"
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/59984
updated_at: 2019-04-21 23:39:05
body:
  ## Issue description

  ```
  [davidak@X230:~]$ io.elementary.switchboard

  ** (.io.elementary.switchboard-wrapped_:7560): CRITICAL **: 22:38:13.259: polkit_unix_process_set_property: assertion 'val != -1' failed

  ** (.io.elementary.switchboard-wrapped_:7560): CRITICAL **: 22:38:13.325: file /build/source/src/Views/LockPanel.vala: line 33: uncaught error: Failed to open file “/nix/store/79n8yx4gzhz0wbp6arwqhzcxq9k5i22f-light-locker-1.9.0/share/gsettings-schemas/light-locker-1.9.0/glib-2.0/schemas/gschemas.compiled”: open() failed: No such file or directory (g-file-error-quark, 4)

  (.io.elementary.switchboard-wrapped_:7560): GLib-GIO-CRITICAL **: 22:38:13.325: g_settings_schema_source_lookup: assertion 'source != NULL' failed

  (.io.elementary.switchboard-wrapped_:7560): GLib-GIO-CRITICAL **: 22:38:13.325: g_settings_new_full: assertion 'schema != NULL' failed
  Segmentation fault
  ```

  ### Steps to reproduce

  1. open switchboard
  2. click on "Security & Privacy"
  3. :boom: 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nixos/syncthing: add options for declarative device/folder config
user_login: Lassulus
html_url: https://github.com/NixOS/nixpkgs/pull/59985
updated_at: 2019-05-28 13:49:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  configure syncthing declaratively in `configuration.nix` (the true way ;) )

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: snscrape: 0.1.3 -> 0.2.0
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/59986
updated_at: 2019-04-22 12:34:09
body:
  ###### Motivation for this change

  https://github.com/JustAnotherArchivist/snscrape/commits/v0.2.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I confirmed that `snscrape twitter-user USER` works.


state: closed
title: python.pkgs.gmpy2: backport upstream bugfixes
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59987
updated_at: 2019-04-21 22:09:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Bugfixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/config: add user configuration homeMode option
user_login: danielfrankcom
html_url: https://github.com/NixOS/nixpkgs/pull/59988
updated_at: 2019-07-15 12:30:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change

  In the current user configuration, there is no way to configure the directory permissions when a home directory is created with the createHome option.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sage: 8.7 -> 8.8
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59989
updated_at: 2019-07-02 21:01:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Tracking the betas & release candidates for the next sage update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Support patching nixpkgs
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59990
updated_at: 2019-06-05 09:21:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Sometimes you want to track a specific branch of nixpkgs (like nixpkgs-unstable or some release branch) but you would like to apply some unmerged pull requests or some other patches to that revision.

  Note that overlays are not always sufficient in this case because they don't work for NixOS modules and you're forced to duplicate code which already exists in some commit.

  In this case you could fork nixpkgs, create a branch based on your desired upstream branch and cherry-pick the commits you need on top of that branch. Then everytime you need to upgrade nixpkgs you rebase your branch on the latest upstream branch that you're tracking. This process works but is a
  bit involved and somewhat untransparent.

  This PR implements support in nixpkgs for a simpler and more transparent mechanism to apply some patches to an existing revision. First you fetch your desired revision of nixpkgs like for example:

  ```
    let
      nixpkgs =
        builtins.fetchTarball {
  	url = "https://github.com/NixOS/nixpkgs/archive/86d58407a6bb8ef2e1a58ab50318b149ffd4feda.tar.gz";
  	sha256 = "0a2lkvacn78nza9hlmdx9znp1my3c3jf3xyhk9ydw6lxa348b7sl";
        };
  ```

  Then you import that revision and apply it to a list of patches, for example:

  ```
      patchedPkgs = import nixpkgs {
        patches = pkgs : [
  	# https://github.com/NixOS/nixpkgs/pull/59950
  	(pkgs.fetchpatch {
  	  url = https://github.com/NixOS/nixpkgs/commit/1f770d20550a413e508e081ddc08464e9d08ba3d.patch;
  	  sha256 = "1nlzx171y3r3jbk0qhvnl711kmdk57jlq4na8f8bs8wz2pbffymr";
  	})
        ];
      };
    in patchedPkgs...
  ```

  Note that `patches` should be a function from a nixpkgs set `pkgs` to a list of patch files that can be applied to a nixpkgs directory tree. The `pkgs` set should mainly be used to get the `fetchpatch` function from. Note that `pkgs` is a nixpkgs set for the specified `localSystem` but without `overlays` and `crossOverlays` defined.

  Overlays are applied after patching which means you can have overlays which can depend on the patched content.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: epiphany doesn't respond in Pantheon
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/59991
updated_at: 2019-04-22 02:09:19
body:
  ## Issue description

  ![Screenshot from 2019-04-22 00-39-34](https://user-images.githubusercontent.com/91113/56476445-e79a5000-6497-11e9-86b9-db8b83b90cec.png)

  ### Steps to reproduce

  1. open "Web"
  2. it hangs

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: plymouth shows NixOS version only at shutdown, not at start
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/59992
updated_at: 2019-04-24 09:24:07
body:
  ## Issue description

  It should always show the NixOS version.

  Reproducible on:

  - Lenovo Thinkpad X230 with grub

  Not reproducible on:

  - Apple iMac 11,3 with systemd-boot (EFI)

  ### Steps to reproduce

  1. boot system
  2. shut down system

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.box2d: fix build by moving swig2 to nativeBuildInputs, remove box2d dependency
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59993
updated_at: 2019-04-27 05:45:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  ...fix build by moving swig2 to nativeBuildInputs

  Looking at the future of this package, the original source appears to be unmaintained, and the pypi entry's homepage is an old broken googlecode.com address.

  It's probably worth looking at switching to one of the forks, but which one I'm not particularly sure. I'm not sure how one would gauge the credibility of these sources - https://github.com/pybox2d/pybox2d probably looks the most promising, but then again, anyone can register the "pybox2d" github organization. The bonus from switching upstream would be being able to pull the complete package from github including the tests, which we could then enable.

  **Edit:** Looking at this closer, I realized I was able to remove the `pkgs-box2d` `buildInput` entirely. This dependency turns out to be completely unnecessary - the pypi package includes its own bundled copy of the source (I know - ew.) and building without `pkgs-box2d` results in a binary-identical `.so`.

  This has the side-effect of enabling this package on darwin, which was previously restricted by the apparently linux-only `pkgs-box2d`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
body: Reverts NixOS/nixpkgs#59945
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/59994
updated_at: 2019-04-22 01:00:50
title:
  (do not merge) Revert "nixos/virtualbox: Fixes configuration to evaluate" to ensure ofborg checks this properly


state: closed
title: gnomeExtensions.icon-hider: 21 -> 23
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/59995
updated_at: 2019-04-22 01:48:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade to the latest version, now with GNOME 3.32 support. Mark as not broken. Full changelog available at https://github.com/ikalnytskyi/gnome-shell-extension-icon-hider/compare/v21...v23

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gnomeExtensions.battery-status: mark as not broken
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/59996
updated_at: 2019-04-22 02:17:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This extension does not declare support for GNOME 3.32 (or any other
  recent version), but it does work. I've opened an [upstream pull
  request] to address this. Additionally, add `meta.platforms` and update
  the homepage and GitHub owner to reflect the user that `milliburn`
  redirects to.

  [upstream pull request]: https://github.com/roberth-k/gnome-shell-extension-battery_status/pull/18

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages: mass update
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59997
updated_at: 2019-04-23 13:39:18
body:
  ###### Motivation for this change

  Update ```perl``` and ```perlPackages```
  @rycee @srhb 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "librsvg: 2.44.12 -> 2.45.5"
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59998
updated_at: 2019-04-22 02:45:28
body:
  This reverts commit 43f21c58eafd62d20138f9a6a8286f54d3db8d0b.

  This causes issues on macOS. I can't find a good solution, so it seems like revert is the easiest solution. I've filed an issue upstream here:

  https://gitlab.gnome.org/GNOME/librsvg/issues/456

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: SWT reproducibility
user_login: bb010g
html_url: https://github.com/NixOS/nixpkgs/pull/59999
updated_at: 2019-04-27 09:18:08
body:
  ###### Motivation for this change

  More reproducibility! And less likelihood of breakage moving forward into new versions. Also, the build-support/setup-hooks/canonicalize-jars-hook hook added to support this was pulled from the unused build-support/release/ant-build (& functions only used there sourced from build-support/release/functions.sh), which has been deleted due to being weird and old and not imported by any package built on Hydra in the last 3+ years.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
    - Tested with applications/editor/music/tuxguitar & applications/networking/ipscan (in [my NUR repo](https://github.com/bb010g/nur-packages/blob/a9b04ae395780ab23d09b8657515436ceb8c97e4/pkgs/applications/networking/ipscan/default.nix); planning to submit to Nixpkgs after this merges since it requires upgraded SWT).
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
    - **Decrease** from 648420920 to 648403736
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Atom on Pantheon: can't delete file
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60000
updated_at: 2019-04-22 02:40:11
body:
  ## Issue description

  ![Screenshot from 2019-04-21 23-24-31](https://user-images.githubusercontent.com/91113/56479414-9a2cdb80-64b5-11e9-8284-99457fe059fd.png)

  `Is gvfs-trash installed?`

  Should it get added to the runtime dependencies?

  cc @worldofpeace 

  ### Steps to reproduce

  1. open atom
  2. try to delete a file

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: vivaldi: support snapshots
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/60001
updated_at: 2019-04-24 13:00:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  Stable builds fine and snapshot seems to start fine.
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pytorch: Move cudatoolkit to nativeBuildInputs
user_login: andersk
html_url: https://github.com/NixOS/nixpkgs/pull/60002
updated_at: 2019-07-06 23:52:13
body:
  ###### Motivation for this change

  `nvcc` must be available in `PATH` at build time; otherwise CUDA support will be disabled.

  This is a more minimal version of #57438.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Use ql2nix in nixpkgs
user_login: bradleyjensen
html_url: https://github.com/NixOS/nixpkgs/issues/60003
updated_at: 2019-04-22 07:25:03
body:
  `nixpkgs.lispPackages` needs some help.  I've got a plan, but I need a bit of help integrating it into nixpkgs.

  A few years ago, when I was first getting into Nix, I tried to make `lispPackages` better.  I wanted every quicklisp package to be included.  I wanted every package to be pre-compiled and ready to load.  I wanted a `haskellPackaged`-style experience of creating a compiler environment in which the desired packages (and only the desired packages!) were accessible.

  The lisp ecosystem as it exists today is very much incompatible with those goals.  As you're probably aware, arbitrary compile-time logic is an essential feature of Common Lisp and ASDF system definitions are just Common Lisp code.  The end result is that a lot of packages do nasty things.  For example, some packages use an (asdf-discouraged, but still common) pattern where they check if some other system has been loaded and then behave differently.  That makes reproducible builds very difficult and sharing of compilation artifacts even more difficult.

  I struggled to make it work for so long.  I layered hacks on hacks on hacks, gave up, started over, and found myself layering hacks again.  Eventually, I gave up.  I added the packages I needed to nixpkgs and left shaking my head.  It wasn't meant to be.

  I'm back, and I've got a new plan!  I decided to stop trying to copy `haskellPackages` and to take a bit of inspiration from how the node ecosystem works.  Okay, I admit, I know almost nothing about how the node ecosystem works with Nix.  I just barely dipped my toes in the waters when I realized that I had been approaching the `lispPackages` problem all wrong.  I threw together a little project called `ql2nix`.  Its still quite rough, but it seems to be working.  I haven't tested it on some known-bad packages, but things are looking good so far.

  I want to give up on `lispPackages` as we know it today.  Instead of trying to make Nix into an alternative to Quicklisp, Nix will leverage Quicklisp similarly to how Nix leverages NPM.  Here's the sketch for how it will work.
  1. Using `ql2nix`, you create a Nix manifest of the Quicklisp releases (i.e. source tarballs) and systems (i.e. ASDF systems) that are required for your project.  `ql2nix` pulls that info from your local Quicklisp installation.  So, its just freezing the dependencies you're already using.  The neat thing is this naturally supports alternative Quicklisp dists (i.e. package repositories) that are starting to spring up!
  2. Using the Nix expressions in `ql2nix`, you can then create a Quicklisp dist that contains all and only the systems that were captured in the closure earlier.  You can install this dist into any Quicklisp installation!  After that, `ql:quickload` and such will install using the dependencies captured in step 1.  I'm calling this dist "nixlisp".
  3. Next, using a bit more Nix embedded in `ql2nix`, we can use the nixlisp dist and `ql:bundle-systems` to create a folder containing the systems captured in step 1.  Quicklisp helpfully includes a `bundle.lisp` file that can be loaded to set up ASDF so that it can find the systems contained within the bundle.  `bundle.lisp` doesn't depend on Quicklisp.  Now we've got a simple file that, when loaded, gives us access to all the dependencies that were captured in step 1... except we're not dependent on Quicklisp and the dependencies are contained within the Nix store!

  This will run into problems if a system tries to create files in the source directory.  I know some systems do that.  We can probably get those systems to store their files in ASDF's output directory (`~/.cache/common-lisp/...` by default) using pull requests or patches.

  So... what is left to do?  Well, I don't think `nixpkgs` NEEDS to do anything.  I think `ql2nix` is completely usable on its own without any `nixpkgs` support.  Personally, I'm going to start migrating my personal projects away from using `lispPackages`.  I'm filing this issue because I think you might find it a bit easier to build some Common Lisp programs using `ql2nix`.  For example, `stumpwm` might be easier to maintain if it isn't dependent on keeping `lispPackages` up to date.  I noticed `stumpwm` was broken for a long while about ~1 year ago.  It seemed like the issue stemmed from `lispPackages` being difficult.  I also think that `ql2nix` could use a bit of help from someone that knows how to Nix better than I do.  Am I doing dependency injection the right way?  Is the Nix output of `ql2nix` reasonable?  Stuff like that.


state: open
title: Fix broken homepage URLs
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/60004
updated_at: 2019-07-11 18:17:00
body:
  ## Issue description

  repology has a nice listing of broken homepages in Nixpkgs:

  https://repology.org/repository/nix_unstable/problems

  I went through and fixed a few, but many more still remain. If anyone else would like to work on this, it would be greatly appreciated.

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: Add common packages to Nixpkgs
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/60005
updated_at: 2019-07-11 18:18:10
body:
  ## Issue description

  Repology has a list of packages that are not in Nixpkgs, but included in many others. This is a useful way to find what is missing in Nixpkgs, or perhaps has incorrect names. Correcting this information is useful for Nixpkgs coverage and keeping things up to date.

  All packagers not in nixpkgs, but included in at least 20 other repositories:

  https://repology.org/projects/?search=&maintainer=&category=&inrepo=&notinrepo=nix_unstable&repos=&families=20-&repos_newest=&families_newest=


state: open
title: Make sure unique packages have proper name
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/60006
updated_at: 2019-07-11 18:18:15
body:
  ## Issue description

  Repology lists out some packages that are only available in Nixpkgs. In some cases, that is just because we are the only , which is good. But in other cases, this is because the name used is just incorrect. As a result, we don't get the update information from upstream and can end up having out of date packages.

  https://repology.org/projects/?inrepo=nix_unstable


state: closed
title: pgmetrics: 1.6.1 -> 1.6.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60007
updated_at: 2019-04-22 22:41:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/rapidloop/pgmetrics/releases/tag/v1.6.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: librecad: add .desktop file and icon
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/60008
updated_at: 2019-04-26 03:24:57
body:
  ###### Motivation for this change

  Use the .desktop file and app icon included in the source package.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: HTTPS urls
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60010
updated_at: 2019-04-22 23:08:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Lots of URLs were HTTP redirect to HTTPS. Changed those and checked them
  if there's actual content. Inspired by #60004

  They're mostly homepage URLs so there are probably a lot of source URLs left on HTTP which we should fix.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fcitx-engines.mozc fails on nixos-unstable
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/60011
updated_at: 2019-04-25 05:16:50
body:
  ## Issue description

  Even after I tried to bump the version, it fails with
  ```
  /build/source/src/dictionary/user_dictionary_util.h:119:47: note: passing argument to parameter 'storage' here
        user_dictionary::UserDictionaryStorage *storage,
                                                ^
  ../../dictionary/user_dictionary_session.cc:647:11: error: cannot initialize a parameter of type 'user_dictionary::UserDictionaryStorage *' with an rvalue of type 'std::unique_ptr<mozc::UserDictionaryStorage, std::default_delete<mozc::UserDictionaryStorage> >::pointer' (aka 'mozc::UserDictionaryStorage *')
            storage_.get(), dictionary_id);
            ^~~~~~~~~~~~~~
  /build/source/src/dictionary/user_dictionary_util.h:119:47: note: passing argument to parameter 'storage' here
        user_dictionary::UserDictionaryStorage *storage,
                                                ^
  fatal error: too many errors emitted, stopping now [-ferror-limit=]
  20 errors generated.
  [587/734] CXX obj/dictionary/user_dictionary.user_dictionary_session_handler.o
  [588/734] CXX obj/gui/config_dialog/config_dialog_lib.roman_table_editor.o

  ```

  I believe I may try to bump protobuf as well. Maybe related https://github.com/google/mozc/issues/460

  ### Steps to reproduce



  ## Technical details

  nixos-unstable from 22 April.


state: closed
title: nextcloud-client asks to connect accounts after each reboot
user_login: caugner
html_url: https://github.com/NixOS/nixpkgs/issues/60012
updated_at: 2019-04-29 17:04:43
body:
  ## Issue description

  Since the upgrade to NixOS 19.03 (and nextcloud-client 2.5.0), the `nextcloud-client` tells me `You have been logged out of ***@*** as user ***. Please login again` and asks me to `Connect to your account` after each reboot, even if I entered the login data during the last session.

  ### Steps to reproduce

  1. Install `nextcloud-client` (in my case, globally).
  2. Add one or more accounts (in my case, 4 accounts on 3 servers).
  3. Reboot
  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```terminal
  $ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/9z1b1ldrhxh7brsi6fxnyjm7gk8kiynv-bash-interactive-4.4-p23-dev
  copying path '/nix/store/9z1b1ldrhxh7brsi6fxnyjm7gk8kiynv-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.35, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600"`
   - channels(hobby): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  --
  Potential causes: #52355 #53881 #54484 #55673
  Cc: @flokli @averelld @Ma27


state: closed
title: Mumble fails to build
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/issues/60013
updated_at: 2019-04-22 22:25:01
body:
  ## Issue description

  Hydra log:
  https://hydra.nixos.org/build/92486838
  ```
  In file included from BanEditor.cpp:36:0:
  Global.h:142:11: error: expected ',' or '...' before '(' token
   #define g (*Global::g_global_struct)
             ^
  compilation terminated due to -Wfatal-errors.
  ```

  This might be related to this upstream issue:
  https://github.com/mumble-voip/mumble/issues/3617

  I tried to apply the PR fixing the above issue but the patch is on master and therefore can't be applied directly to 1.2.19 without conflicts

  ### Steps to reproduce

  `nix-build -A mumble` on latest nixpkgs master


state: closed
title: gitea: 1.7.6 -> 1.8.0
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60014
updated_at: 2019-05-01 11:30:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/go-gitea/gitea/releases/tag/v1.8.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: protobuf: 3.7.0 -> 3.7.1
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/60015
updated_at: 2019-04-24 09:10:32
body:
  Fix fctix mozc issue https://github.com/NixOS/nixpkgs/issues/60011
  I tried to bump moz as well but it failed with various errors, this should be good enough.
  ```
            ^
  ../../unix/fcitx/fcitx_key_event_handler.cc:209:10: error: no template named 'set'; did you mean 'std::set'?
      for (set<commands::KeyEvent::ModifierKey>::const_iterator it =
           ^~~
           std::set
  /nix/store/pm4rg0bdiaj5b748kncp9vf7n3x446sd-gcc-7.4.0/include/c++/7.4.0/bits/stl_multiset.h:69:11: note: 'std::set' declared here
      class set;
            ^
  13 errors generated.


  ```
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tup: Let tup passthrough NIX_* env vars
user_login: tfc
html_url: https://github.com/NixOS/nixpkgs/pull/60016
updated_at: 2019-05-04 12:55:28
body:
  ###### Motivation for this change

  `tup` prunes all environment variables for all subprocesses that it starts. Some variables like `PATH` are passed through. This prevents `nix-shell` C and C++ environments from giving the compiler the right include and library folders for compiling/linking with/against external libraries.

  At least the variables are needed for the typical c/c++ wrapper in nix:

  - `NIX_CFLAGS_COMPILE`
  - `NIX_LDFLAGS`
  - `NIX_CC_WRAPPER_x86_64_unknown_linux_gnu_TARGET_HOST` (If this is not set in the env, then the compiler wrapper will also not consume the other two vars, which is critical)

  This PR adds a patch to `tup` which passes through all environment variables that are prefixed with `NIX_` in order to provide a painless build experience in e.g. C++ projects with external libs.

  This only affects the tup workflow in `nix-shell`. (For sandboxed nix build environments, users typically use `tup generate` to generate a shell script that performs the build process, because `tup` wants the SUID bit set, which is not allowed within `nix-build`)

  Example:

  Tup project with `hello.cpp`:

  ```c++
  #include <boost/lexical_cast.hpp>
  #include <iostream>

  int main() {
    std::cout << "Hello World!\n"
      << "Boost: " << (BOOST_VERSION / 100000) << '.'
                   << (BOOST_VERSION / 100 % 1000) << '.'
                   << (BOOST_VERSION % 100) << '\n';
  }
  ```

  ...and `Tupfile`:

  ```
  : hello.cpp |> c++ hello.cpp -o hello |> hello
  ```

  When building this with an unpatched `tup` in a `nix-shell`, you get the following error:

  ```bash
  $ nix-shell -p boost tup --run "tup"
  [ tup ] [0.000s] Scanning filesystem...
  [ tup ] [0.000s] Reading in new environment variables...
  [ tup ] [0.000s] No Tupfiles to parse.
  [ tup ] [0.000s] No files to delete.
  [ tup ] [0.000s] Executing Commands...
  * 0) c++ hello.cpp -o hello                                                                                         
  hello.cpp:1:10: fatal error: boost/lexical_cast.hpp: No such file or directory
   #include <boost/lexical_cast.hpp>
            ^~~~~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
   *** tup messages ***
   *** Command ID=28 failed with return value 1
   [ ] 100%
   *** tup: 1 job failed.
  ```

  The patched version correctly passes through all the nix vars to the compiler wrapper and then it works:

  ```bash
  $ NIX_PATH=nixpkgs=patchednixpkgs nix-shell -p boost tup --run "tup"
  [ tup ] [0.000s] Scanning filesystem...
  [ tup ] [0.011s] Reading in new environment variables...
  [ tup ] [0.011s] Parsing Tupfiles...
   0) [0.003s] .
   [ ] 100%
  [ tup ] [0.020s] No files to delete.                                                                                              
  [ tup ] [0.020s] Generating .gitignore files...
  [ tup ] [0.026s] Executing Commands...
   0) [0.592s] c++ hello.cpp -o hello                                                                                               
   [ ] 100%
  [ tup ] [0.628s] Updated.     
  ```

  ...because this time the compiler got all the include folders right via `NIX_CFLAGS_COMPILE`.

  (please note that in order to perform this at home one needs to delete the `.tup` directory in the project and rerun `tup init` because that folder's state would lead to the same old error)

  An alternative to this patch is prepending the following lines to every tup project's root `Tupfile`:

  ```
  export NIX_CFLAGS_COMPILE
  export NIX_LDFLAGS
  export NIX_CC_WRAPPER_x86_64_unknown_linux_gnu_TARGET_HOST
  ```

  This does also work, but please note that:

  - This is the same for _all_ tup projects just to be able to use `nix-shell`, so i'd personally prefer `tup` not taking these nix-specific env vars away in the first place
  - the `NIX_CC_WRAPPER...` env var name is arch- and OS-specific, so this is not a portable addition to tupfiles... The `tup` patch presented does it right, no matter what target platform is selected, because it is generic.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libvterm-neovim: 2017-11-05 -> 2018-11-26
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/60017
updated_at: 2019-04-23 22:36:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @adisbladis @garbas 


state: closed
title: slurm: 18.08.6.2 -> 18.08.7.1
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/60018
updated_at: 2019-04-29 10:33:57
body:
  ###### Motivation for this change
  Regular update.

  Changelog:
  https://github.com/SchedMD/slurm/blob/slurm-18.08/NEWS

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  nixos/tests/slurm.nix succeeds
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nzbget: fix broken service, as well as some improvements
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/60019
updated_at: 2019-04-27 17:01:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The nzbget service is currently broken and appears to have been for some time.
  https://github.com/NixOS/nixpkgs/pull/51235#pullrequestreview-228910052

  ping @flokli 

  closes #58928.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spotify: add libnotify as dependency
user_login: bebehei
html_url: https://github.com/NixOS/nixpkgs/pull/60020
updated_at: 2019-04-22 18:13:42
body:
  ###### Motivation for this change
  The option `Show desktop notification when the song changes` will only
  work, when libnotify is available in spotify.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/httpd: cleanup old apache2.2 syntax
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/60021
updated_at: 2019-06-07 22:52:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: waf: make reproducible
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/60022
updated_at: 2019-04-22 20:00:08
body:
  ###### Motivation for this change

  Make waf reproducible.

  Please test to see if this is reproducible on your system:

  ```
  grep REVISION= $(nix-build . -A waf )
  ```

  I hope you get `REVISION="492eeeb1294054d82d4520c9c5990db3"`.


state: closed
title: sl: use appropriate compiler
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/60023
updated_at: 2019-04-23 06:47:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Current sl cannot be built on Darwin.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libguestfs-with-appliance: Add package for libguesfs containing libguestfs appliances
user_login: roosemberth
html_url: https://github.com/NixOS/nixpkgs/pull/60024
updated_at: 2019-04-23 18:27:27
body:
  Appliances are necessary when building images using virt-builder.
  (e.g. `virt-builder -o debian-9.img debian-9`)

  Signed-off-by: Roosembert Palacios <roosembert.palacios@epfl.ch>

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Necessary to run virt-builder. Tested by running `virt-builder -o debian-9.img debian-9`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perl.withPackages: strategy to resolve collisions
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/issues/60025
updated_at: 2019-04-22 23:42:41
body:
  ## Issue description

  ```perlPackages``` has some libraries (```ArchiveTar```, ```Encode```, ```JSONPP```, ```CPAN```, ```ExtUtilsMakeMaker```, ```IOCompress```, ```PodChecker```, ```PodParser```, ```PodPerldoc```, ```podlators```) whose older versions are included in ```perl```.

  ```nix
  perl.withPackages(p: with p; [ArchiveTar Encode JSONPP CPAN ExtUtilsMakeMaker
   IOCompress PodChecker PodParser PodPerldoc podlators])
  ```
  fails because some files exist in more than one package passed to ```buildEnv```.

  Possible ways to fix:

  1. by deleting conflicting files from the packages (like it was done with ```Encode``` in
  https://github.com/NixOS/nixpkgs/pull/59215#issuecomment-481485707 https://github.com/NixOS/nixpkgs/pull/59215/commits/f73eb61113998952f742e3c542a9e95d9791abd4). The disadvantage is: in the final environment we get the files from the library included in ```perl```, usually the oldest of the conflicting libraries.

  2. pass ```ignoreCollisions=true``` to ```buildEnv``` hoping the newest of the conflicting libraries will win

  3. assume that ```perl.withPackages(p: [p.ArchiveTar])``` means not to add a library but to upgrade (or to downgrade) the library included in ```perl```, so ```withPackages``` should be smart enough to **remove** the library included in ```perl``` and use the library from the right hand side instead.

  4. forcingly upgrade libraries in ```perl``` to the latest versions in ```perlPackages``` and remove the libraries from ```perlPackages```

  @aanderse 


state: closed
title: nixos/virtualbox: Fixes configuration to evaluate
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/60026
updated_at: 2019-04-22 15:46:38
body:
  Fixes issue introduced by #57557 cc @samueldr 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: liburing: init at 1.0.0pre821_39e0ebd
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60027
updated_at: 2019-04-22 17:07:41
body:
  This adds preliminary support for a pre-release version of the `liburing` package, which will expose a convenient user-space interface to the upcoming `io_uring` API featured in Linux 5.1.

  For the interested, see here for more information about the motivation and design behind this API: http://kernel.dk/io_uring.pdf

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perl.meta.priority += 1
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60028
updated_at: 2019-04-22 23:42:42
body:
  give priority to ```perl``` libraries when they meet the perl derivation in ```buildEnv```.

  The notable case is ```buildEnv``` inside ```perl.withPackages```.

  The ```perl``` derivation includes obsolete versions of some CPAN packages
  which leads to collissions when there are newer versions
  of the same libraries are on the right hand side
  of ```perl.withPackages``` (perhaps indirectly).

  Fixes #60025

  https://github.com/NixOS/nixpkgs/commit/f73eb61113998952f742e3c542a9e95d9791abd4 is undone as no longer needed

  @aanderse


state: closed
title: nixos-container: allow setting custom local and host address
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/60029
updated_at: 2019-06-06 07:41:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I have a nixops network where I deploy containers using the `container`
  backend which uses `nixos-container` intenrally to deploy several
  containers to a certain host.

  During that time I removed and added new containers and while trying to
  deploy those to a different host I realized that it isn't guaranteed
  that each container gets the same IP address which is a problem as some
  parts of the deployment need to know which container is using which IP
  (i.e. to configure port forwarding on the host).

  With this change you can specify the container's IP like this (and don't
  have to use the arbitrarily used 10.233.0.0/16 subnet):

  ```
  $ nixos-container create test --config-file test-container.nix \
      --local-address 10.235.1.2 --host-address 10.235.1.1
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: alacritty: 0.3.0 -> 0.3.1
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/60030
updated_at: 2019-04-22 22:05:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [changelog](https://github.com/jwilm/alacritty/blob/master/CHANGELOG.md#version-031)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tcl/tk: 8.6.6 -> 8.6.9
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60031
updated_at: 2019-04-22 23:53:09
body:
  Changelog for Tcl: https://github.com/tcltk/tcl/blob/core-8-6-9/changes#L8797
  Changelog for Tk: https://github.com/tcltk/tk/blob/master/changes#L7417
  Tk release is actually v8.6.9.1 while Tcl is v8.6.9

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bumps
  Follow-up to #35069

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vscode-extensions.WakaTime.vscode-wakatime: 1.2.13 -> 1.3.0
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/60032
updated_at: 2019-04-24 12:21:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  Working fine on insiders.
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: automysqlinit: init at 3.0_rc6 (19.03 backport)
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/60033
updated_at: 2019-04-22 22:37:06
body:
  (cherry picked from commit 5f4df8e50935e219704389d8467f7edd363896d9)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Backport `automysqlbackup` to 19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nikola auto fails
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60034
updated_at: 2019-04-23 15:29:44
body:
  ## Issue description

  ```
  ERROR: Nikola: In order to use the "auto" command, you must install the "aiohttp" and "watchdog" Python packages.
  ERROR: Nikola: Exiting due to missing dependencies.
  ```

  ### Steps to reproduce

  `nikola auto`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172311.454eea84a75 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(davidak): `""`
   - channels(root): `"nixos-19.03.172311.454eea84a75, nixos-hardware, nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: kde_applications: 18.12.03 -> 19.04.1; kdeFrameworks: 5.56 -> 5.58; plasma-5: 5.15.3 -> 5.15.5
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/60035
updated_at: 2019-05-23 21:45:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Some work will need to be done to make some application work.

  Fixed apps:
  - [x] akonadi
  - [x] kdegraphics-thumbnailers
  - [x] kdenlive
  - [x] kdepim-runtime
  - [x] kio-extras
  - [x] kcalc
  - [x] kmail

  ~kdenlive is trying to download https://github.com/rttrorg/rttr during build~

  ~kdepim-runtime error:~
  ```
  [ 31%] Building CXX object resources/facebook/CMakeFiles/facebookresourcelib.dir/listjob.cpp.o
  In file included from /build/kdepim-runtime-19.04.0/resources/facebook/listjob.cpp:18:0:
  /build/kdepim-runtime-19.04.0/resources/facebook/listjob.h:23:10: fatal error: AkonadiCore/Item: No such file or directory
   #include <AkonadiCore/Item>
            ^~~~~~~~~~~~~~~~~~
  ```

  the plasma5 test is passing and every dependencies are cached on https://nyanloutre.cachix.org

  any help is welcome

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plasma5 test job broken in nixos-unstable
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/issues/60036
updated_at: 2019-04-24 03:49:29
body:
  ## Issue description

  `kio-extras` fails to build: https://hydra.nixos.org/job/nixpkgs/trunk/kdeApplications.kio-extras.x86_64-linux

  This breaks https://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents

  First broken: https://hydra.nixos.org/build/92448979

  Looks like an issue with the `libssh` update (25ebfe22e901017fe863a0a8ea824c790dbce125):
  ```
  CMake Error at /nix/store/06gmnf6lb9dz2jm7kjmk65plw5ck1g1z-libssh-0.8.7-dev/lib/cmake/libssh/libssh-config.cmake:11 (message):
    File or directory
    /nix/store/06gmnf6lb9dz2jm7kjmk65plw5ck1g1z-libssh-0.8.7-dev/lib/libssh.so
    referenced by variable LIBSSH_LIBRARIES does not exist !
  ```

  cc @ttuegel @bkchr and libssh maintainer @svanderburg 


state: closed
title: Backport perl: add .withPackages #59215 #60028
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/60037
updated_at: 2019-04-22 23:42:59
body:
  Backports  #59215 and #60028 to 19.03

  Undraft and merge only once #60028 has been validated and merged, please.

  The initial commit (perl: add .withPackages) had two conflicts. The first one is a possibly missing perl update to stable (?) and the second one was with the signature where I think a cross-compilation change changed it (trivial to fix).

  cc @volth 


state: closed
title: hugin: 2018 -> 2019
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60038
updated_at: 2019-04-22 22:34:27
body:
  ###### Motivation for this change

  http://hugin.sourceforge.net/releases/2019.0.0/en.shtml

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kipi-plugins: 5.9.0 -> 5.9.1, build from dedicated tarball
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60039
updated_at: 2019-04-23 00:17:09
body:
  ###### Motivation for this change

  Update. Also,

  Don't pick out from digikam's source.
  (presumably the plugins used to live there primarily?)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitflow: 1.11.0 -> 1.12.2
user_login: woffs
html_url: https://github.com/NixOS/nixpkgs/pull/60040
updated_at: 2019-04-24 04:28:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: digikam: 6.0.0 -> 6.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60042
updated_at: 2019-05-10 11:22:07
body:
  ###### Motivation for this change

  https://www.digikam.org/news/2019-04-14-6.1.0_release_announcement/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libsForQt5.qca-qt5: 2.1.3 -> 2.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60043
updated_at: 2019-04-28 00:36:12
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kdb: 3.1.0 -> 3.2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60044
updated_at: 2019-04-22 20:47:04
body:
  ###### Motivation for this change

  Bumping along with others...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pipenv: add virualenv to propagatedBuildInputs.
user_login: dgarzon
html_url: https://github.com/NixOS/nixpkgs/pull/60045
updated_at: 2019-04-26 16:28:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skrooge: 2.18.0 -> 2.19.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60046
updated_at: 2019-04-28 03:24:30
body:
  ###### Motivation for this change

  https://skrooge.org/node/236

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kdeconnect: 1.3.3 -> 1.3.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60049
updated_at: 2019-04-27 05:44:39
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trilium: 0.30.6 -> 0.30.8
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60051
updated_at: 2019-04-23 03:38:09
body:
  https://github.com/zadam/trilium/releases/tag/v0.30.8
  https://github.com/zadam/trilium/releases/tag/v0.30.7


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: joplin-desktop: 1.0.142 -> 1.0.143
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60052
updated_at: 2019-04-23 11:55:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/laurent22/joplin/releases/tag/v1.0.143

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hostapd: 2.7 -> 2.8
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60053
updated_at: 2019-05-21 08:12:57
body:
  ###### Motivation for this change

  https://w1.fi/cgit/hostap/plain/hostapd/ChangeLog?h=hostap_2_8

  **Mostly a blind update, other than confirming it builds!**

  Anyone running a router using this? :)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: KDE display resolution only 640x480 with DVI-to-VGA adapter
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60054
updated_at: 2019-04-23 11:51:18
body:
  ## Issue description

  ![IMG_20190422_221957](https://user-images.githubusercontent.com/91113/56578789-c425f100-65ce-11e9-82aa-9c9fc75f9cbf.jpg)

  I have bootet the graphical 19.03 live-image on a gaming PC with NVIDIA GeForce GTX 960, connected an old LCD display with only VGA input using a DVI-to-VGA adapter.

  The display resolution is 640x480 and can't be changed.

  When i change to an active HDMI-to-VGA adapter, i get no signal. I have to reboot. With that i can go up to 1024x768.

  The low resolution is probably a KDE plasma issue. I don't have the problem with Windows 10.

  **Update**: glmark2 shows "VMWare,Inc" as GL_VENDOR.

  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: wpa_supplicant: 2.7 -> 2.8
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60055
updated_at: 2019-04-26 13:08:11
body:
  ###### Motivation for this change

  Testing with your wireless card appreciated!

  I've been using iwd :3 but will give this a go later--
  regardless it'd be good to avoid breaking too many folks' wireless! :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome 3.32.1 staging updates
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/60056
updated_at: 2019-04-27 05:09:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Some gnome 3.32.1 updates for staging:
  https://gitlab.gnome.org/GNOME/glib/blob/2.60.1/NEWS
  https://gitlab.gnome.org/GNOME/libsoup/blob/2.66.1/NEWS
  https://gitlab.gnome.org/GNOME/libcroco/blob/0.6.13/NEWS

  Should probably be merged together with https://github.com/NixOS/nixpkgs/pull/59406

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: Mermaid and mmdc
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/60057
updated_at: 2019-06-26 11:09:26
body:
  [Mermaid](https://mermaidjs.github.io/) generates diagrams and flowcharts from text in a similar manner as markdown. Typically the required component is `mmdc`, which is the binary that generates images from the markup representation.

  GitLab [natively generates](https://docs.gitlab.com/ee/user/markdown.html#mermaid) Mermaid diagrams. Emacs has [a mode](https://github.com/abrochard/mermaid-mode/tree/06beffbbadc4ed25d22f82d377e92f47d79588fd) for it that supports local rendering. Support for GitHub does not exist yet but is [highly demanded](https://github.com/github/markup/issues/533) and is seeing some upstream support. Being able to install it on NixOS would be useful.


state: closed
title: iwd: split ell to separate derivation, update iwd and ell
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60058
updated_at: 2019-04-23 09:58:09
body:
  ###### Motivation for this change

  https://git.kernel.org/pub/scm/network/wireless/iwd.git/plain/ChangeLog?h=0.17
  https://git.kernel.org/pub/scm/network/wireless/iwd.git/plain/ChangeLog?h=0.16
  https://git.kernel.org/pub/scm/network/wireless/iwd.git/plain/ChangeLog?h=0.15

  https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ChangeLog?h=0.19
  https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ChangeLog?h=0.18

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: networkmanager: 1.16.0 -> 1.18.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60060
updated_at: 2019-04-26 20:12:07
body:
  ###### Motivation for this change

  * build w/iwd support since it's free (no dep required!)
  * move to iputils for minor utilities, instead of inetutils
  * ~~libnm-glib has been deprecated for 5 years, don't build support for it~~
    * This is the last release offering this as an option
  * parallel building :)

  https://gitlab.freedesktop.org/NetworkManager/NetworkManager/raw/1.18.0/NEWS

  ###### Things done

  (following is marked based on my testing with a similar branch,
  but not exactly current 'staging'.  FWIW.)
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  FWIW been using this on my system since packaging it yesterday morning.
  ---


state: closed
title: gitlab: 11.9.1 -> 11.9.8
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/60061
updated_at: 2019-04-23 07:57:28
body:
  ###### Motivation for this change
  CVE-2019-10640, https://about.gitlab.com/2019/04/10/critical-security-release-gitlab-11-dot-9-dot-7-released/ (CVE-2019-11000)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mumble: incompatible protobuf version
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/60062
updated_at: 2019-04-23 10:10:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix #60013
  Also see : https://github.com/mumble-voip/mumble/issues/3617

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))

  mumble test is running OK

  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tcl/tk: 8.6.6 -> 8.6.9
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60063
updated_at: 2019-04-27 10:45:07
body:
  Changelog for Tcl: https://github.com/tcltk/tcl/blob/core-8-6-9/changes#L8797
  Changelog for Tk: https://github.com/tcltk/tk/blob/master/changes#L7417
  Tk release is actually v8.6.9.1 while Tcl is v8.6.9

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change

  Version bumps
  Follow-up to #35069

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3.pkgs.aioesphomeapi: 1.8.0 -> 2.0.1
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/60064
updated_at: 2019-04-24 08:02:40
body:
  Pin the protobuf version used by Home Assistant to the version
  required by aioesphomeapi and some components.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.forbiddenfruit: 0.1.2 -> 0.1.3
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/60065
updated_at: 2019-04-23 08:47:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  run tests

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.cmd2: 0.9.11 -> 0.9.12
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/60066
updated_at: 2019-04-24 07:29:30
body:
  Changelog: https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvmPackages_7.compiler-rt: fix typo
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60067
updated_at: 2019-04-23 06:54:06
body:
  ###### Motivation for this change

  Spotted while updating, although it looks familiar...
  (was this fixed in llvm8 expression but not here, maybe?)

  Anyway, I'm not sure immediately how to best test this--
  since builds like
  `pkgsCross.aarch64-multiplatform.llvmPackages_7.compiler-rt`
  encounter errors in the build before getting to this part...

  (it probably is best-tested with llvm-based toolchains, yes? :))

  Ah, here it is:

  d453273fbf86ff1526094a84b01ef8fb9fad98e3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvmPackages_7: 7.0.1 -> 7.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60068
updated_at: 2019-05-06 12:52:41
body:
  ###### Motivation for this change

  Fixy fixes, primarily a particularly gnarly issue.

  Eep, my writing-fu is weak right now sorry!


  ###### Things done

  Still testing, FWIW. :)

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: go-packr: init at 1.13.7
user_login: edude03
html_url: https://github.com/NixOS/nixpkgs/pull/60069
updated_at: 2019-04-23 06:06:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Breaking up  #53691 into nice commits / PRs. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex: modernize package, support i686
user_login: tadfisher
html_url: https://github.com/NixOS/nixpkgs/pull/60070
updated_at: 2019-04-24 23:39:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I've been running this modified package on my server for a while now, and have been meaning to clean it up and submit a PR.

  Essentially, this replaces the manual `patchelf` calls with `autoPatchelfHook`. I did this because Plex would not start on my system since they've added some libraries over time, such as `libboost`, which weren't accounted for in the install script.

  I also added `passthru.updateScript` which queries the same release manifest as the [Plex downloads page](https://www.plex.tv/media-server-downloads/) and does some parsing with `jq` to fetch the latest version and URL. This happens to work for multiple platforms as well, so I threw `i686-linux` support in the package. In the future, it should be possible to support AArch64 and Darwin builds.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: garden-runc: init at 1.17.1
user_login: edude03
html_url: https://github.com/NixOS/nixpkgs/pull/60071
updated_at: 2019-05-06 15:50:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Continuing to break up #53691

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rtl8821au: update for Linux 5.0
user_login: plchldr
html_url: https://github.com/NixOS/nixpkgs/pull/60072
updated_at: 2019-05-27 21:10:41
body:
  I've upgraded to NixOS 19.03 and this was the only issue.
  This change is simple enough, but the lack of a version change upstream puts this in the same spot as the [rtl8814au driver](https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/rtl8814au/default.nix). The nixpkgs manual doesn't seem to contain a policy for this - is it even a problem?


state: closed
title: [19.03] gitlab: 11.9.1 -> 11.9.8
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/60073
updated_at: 2019-04-23 09:24:53
body:
  ###### Motivation for this change
  backport of https://github.com/NixOS/nixpkgs/pull/60061

  CVE-2019-10640, https://about.gitlab.com/2019/04/10/critical-security-release-gitlab-11-dot-9-dot-7-released/ (CVE-2019-11000)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yad: 0.40.0 -> 0.42.0
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60075
updated_at: 2019-04-29 07:41:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upstream update. Also move from gtk2 to gtk3.

  Cc: @grwlf 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: WIP: perlPackages.Carton: init at 1.0.34
user_login: rissson
html_url: https://github.com/NixOS/nixpkgs/pull/60076
updated_at: 2019-04-23 08:23:34
body:
  ###### Motivation for this change

  This is a required tool to install some dependencies for some projects. For example [Lstu](https://framagit.org/fiat-tux/hat-softwares/lstu)

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Update prl-tools to new version on NixOS
user_login: Vonfry
html_url: https://github.com/NixOS/nixpkgs/issues/60077
updated_at: 2019-04-27 06:39:10
body:
  ## Issue description

  Now, version of prl-tools in nixpkgs cannot work in kernel 4.19.

  I try to make a pr on prl-tools(#59817), but it failed.  Some binary files  use `/usr/bin/<sth>` in their code, I have no idea to fix them.

  ### Steps to reproduce

  see: #59817

  ## Technical details

  prl-tools __log__: [gist](https://gist.github.com/Vonfry/58098e51ac7d888d2335cd307ea0d3b4)

  Some of them can be used, but some not. 

  For example, prlcc is one which cannot be run. prlcp is the one which can bu run.


state: closed
title: gitlab-runner: 11.8.0 -> 11.9.2 (release branch)
user_login: kirelagin
html_url: https://github.com/NixOS/nixpkgs/pull/60078
updated_at: 2019-04-25 16:16:06
body:
  ###### Motivation for this change

  GitLab 11.10-rc has recently been deployed to gitlab.com and it breaks `gitlab-runner < 11.9`. This PR cherry-picks commits from `master` that upgrade `gitlab-runner`.

  More details:

  * https://gitlab.com/gitlab-org/gitlab-ee/issues/11122#why-this-happens
  * They have temporarily disabled this feature after runners started failing, but they re-enabled it yesterday, so now runners < 11.9 are failing again.

  Keywords: “Your runner is outdated, please upgrade your runner”, “detached”.

  @bachp @zimbatm 

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: protonmail-bridge 1.1.3-1 goroutine abort on main start
user_login: Siilwyn
html_url: https://github.com/NixOS/nixpkgs/issues/60079
updated_at: 2019-05-07 20:30:53
body:
  ## Issue description
  Running `protonmail-bridge` from the CLI with e.g. `protonmail-bridge --help` or `protonmail-bridge -v` works however trying to start the 'main' functionality causes a crash.

  ### Steps to reproduce
  ```sh
  nix-env -i protonmail-bridge
  protonmail-bridge
  ```

  <details>
    <summary>Full output</summary>

  ```sh
  (process:7874): Gtk-WARNING **: 10:26:48.857: Locale not supported by C library.
  	Using the fallback 'C' locale.
  SIGABRT: abort
  PC=0x7f9436a8fbe0 m=0 sigcode=18446744073709551610
  signal arrived during cgo execution

  goroutine 1 [syscall, locked to thread]:
  runtime.cgocall(0xbfb010, 0xc0001b5758, 0xa53566)
  	/home/common/build/go-1.11.4/src/runtime/cgocall.go:128 +0x5e fp=0xc0001b5728 sp=0xc0001b56f0 pc=0x4b613e
  github.com/therecipe/qt/qml._Cfunc_QQmlApplicationEngine_Load(0x2e5d330, 0x2dc7270)
  	_cgo_gotypes.go:890 +0x41 fp=0xc0001b5758 sp=0xc0001b5728 pc=0xa83e61
  github.com/therecipe/qt/qml.(*QQmlApplicationEngine).Load.func1(0x2e5d330, 0x2dc7270)
  	/home/common/gopath/src/github.com/therecipe/qt/qml/qml-minimal.go:787 +0x8f fp=0xc0001b5790 sp=0xc0001b5758 pc=0xa8fa8f
  github.com/therecipe/qt/qml.(*QQmlApplicationEngine).Load(0xc0000a8100, 0xed2120, 0xc0000a8260)
  	/home/common/gopath/src/github.com/therecipe/qt/qml/qml-minimal.go:787 +0x7c fp=0xc0001b57c0 sp=0xc0001b5790 pc=0xa89c5c
  github.com/ProtonMail/Desktop-Bridge/frontend/qt.(*FrontendQt).qtExecute(0xc0002c4510, 0xe17990, 0xc0002c4510, 0xc0003d0400)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/frontend/qt/frontend.go:291 +0x3c7 fp=0xc0001b5890 sp=0xc0001b57c0 pc=0xaf7bf7
  github.com/ProtonMail/Desktop-Bridge/frontend/qt.(*FrontendQt).Loop(0xc0002c4510, 0xc0001b5988, 0x1)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/frontend/qt/frontend.go:193 +0x59 fp=0xc0001b58c0 sp=0xc0001b5890 pc=0xaf73e9
  main.main.func1(0xc0003a63c0, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/main.go:203 +0x8bf fp=0xc0001b5b48 sp=0xc0001b58c0 pc=0xb962bf
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/urfave/cli.HandleAction(0xca77c0, 0xe19e58, 0xc0003a63c0, 0xc0003d04e0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/urfave/cli/app.go:485 +0xc8 fp=0xc0001b5b70 sp=0xc0001b5b48 pc=0x624528
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/urfave/cli.(*App).Run(0xc0000ceb60, 0xc00009a190, 0x1, 0x1, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/urfave/cli/app.go:259 +0x600 fp=0xc0001b5d80 sp=0xc0001b5b70 pc=0x6226b0
  main.main()
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/main.go:231 +0x4fb fp=0xc0001b5f98 sp=0xc0001b5d80 pc=0xb9562b
  runtime.main()
  	/home/common/build/go-1.11.4/src/runtime/proc.go:201 +0x207 fp=0xc0001b5fe0 sp=0xc0001b5f98 pc=0x4e0e47
  runtime.goexit()
  	/home/common/build/go-1.11.4/src/runtime/asm_amd64.s:1333 +0x1 fp=0xc0001b5fe8 sp=0xc0001b5fe0 pc=0x50d711

  goroutine 19 [syscall]:
  os/signal.signal_recv(0x0)
  	/home/common/build/go-1.11.4/src/runtime/sigqueue.go:139 +0x9c
  os/signal.loop()
  	/home/common/build/go-1.11.4/src/os/signal/signal_unix.go:23 +0x22
  created by os/signal.init.0
  	/home/common/build/go-1.11.4/src/os/signal/signal_unix.go:29 +0x41

  goroutine 4 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/server.startSmtp(0xed10a0, 0xc0004a6050, 0xc000418480, 0xc0004d4180, 0xc0004d40c0, 0xc00002c180)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:153 +0x2d6
  github.com/ProtonMail/Desktop-Bridge/server.Start(0x0, 0x0, 0xc00002c180)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:175 +0x22b
  created by main.main.func1
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/main.go:194 +0x7fd

  goroutine 5 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/frontend/qt.(*FrontendQt).Loop.func1(0xc0002c4510)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/frontend/qt/frontend.go:136 +0x79
  created by github.com/ProtonMail/Desktop-Bridge/frontend/qt.(*FrontendQt).Loop
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/frontend/qt/frontend.go:135 +0x3f

  goroutine 6 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/backend.(*backend).waitForClose(0xc0004bc060, 0xc000091f20)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/backend/backend.go:367 +0x74
  created by github.com/ProtonMail/Desktop-Bridge/backend.New
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/backend/backend.go:115 +0x542

  goroutine 7 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/server.startImap(0xed1080, 0xc0004a4260, 0xc000418480, 0xc0004d4180, 0xc0004d4060, 0xc00002c180)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:108 +0x716
  created by github.com/ProtonMail/Desktop-Bridge/server.Start
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:174 +0x1e8

  goroutine 8 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/server.monitorDisconnectedUsersSMTP(0xc0004b80b0, 0xc0004d40c0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:193 +0xf1
  created by github.com/ProtonMail/Desktop-Bridge/server.startSmtp
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:114 +0x7c

  goroutine 9 [IO wait]:
  internal/poll.runtime_pollWait(0x7f94302bcbc0, 0x72, 0x0)
  	/home/common/build/go-1.11.4/src/runtime/netpoll.go:173 +0x66
  internal/poll.(*pollDesc).wait(0xc000102018, 0x72, 0xc00049a100, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_poll_runtime.go:85 +0x9a
  internal/poll.(*pollDesc).waitRead(0xc000102018, 0xffffffffffffff00, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_poll_runtime.go:90 +0x3d
  internal/poll.(*FD).Accept(0xc000102000, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_unix.go:384 +0x1a0
  net.(*netFD).accept(0xc000102000, 0x0, 0xda6042, 0x3)
  	/home/common/build/go-1.11.4/src/net/fd_unix.go:238 +0x42
  net.(*TCPListener).accept(0xc0004a6058, 0x4de232, 0xc000000008, 0xc000032100)
  	/home/common/build/go-1.11.4/src/net/tcpsock_posix.go:139 +0x2e
  net.(*TCPListener).Accept(0xc0004a6058, 0xe18ae0, 0xc0004b80b0, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/net/tcpsock.go:260 +0x47
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-smtp.(*Server).Serve(0xc0004b80b0, 0xed8800, 0xc0004a6058, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-smtp/server.go:73 +0xc2
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-smtp.(*Server).ListenAndServe(0xc0004b80b0, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-smtp/server.go:139 +0xac
  github.com/ProtonMail/Desktop-Bridge/server.startSmtp.func2(0xc0004b80b0, 0xc0004d4180, 0xc00002c180)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:137 +0x2f
  created by github.com/ProtonMail/Desktop-Bridge/server.startSmtp
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:136 +0x21a

  goroutine 52 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/server.monitorDisconnectedUsersIMAP(0xc0004c03c0, 0xc0004d4060)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:179 +0x157
  created by github.com/ProtonMail/Desktop-Bridge/server.startImap
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:30 +0x7f

  goroutine 53 [IO wait]:
  internal/poll.runtime_pollWait(0x7f94302bcd60, 0x72, 0x0)
  	/home/common/build/go-1.11.4/src/runtime/netpoll.go:173 +0x66
  internal/poll.(*pollDesc).wait(0xc0002e2098, 0x72, 0xc000260000, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_poll_runtime.go:85 +0x9a
  internal/poll.(*pollDesc).waitRead(0xc0002e2098, 0xffffffffffffff00, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_poll_runtime.go:90 +0x3d
  internal/poll.(*FD).Accept(0xc0002e2080, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
  	/home/common/build/go-1.11.4/src/internal/poll/fd_unix.go:384 +0x1a0
  net.(*netFD).accept(0xc0002e2080, 0xa200000000000018, 0xc000065e18, 0xa208300c79f53cdf)
  	/home/common/build/go-1.11.4/src/net/fd_unix.go:238 +0x42
  net.(*TCPListener).accept(0xc00044c018, 0xc000065ea0, 0xc000065ea8, 0x18)
  	/home/common/build/go-1.11.4/src/net/tcpsock_posix.go:139 +0x2e
  net.(*TCPListener).Accept(0xc00044c018, 0xe189e8, 0xc0004c03c0, 0xed8800, 0xc00044c018)
  	/home/common/build/go-1.11.4/src/net/tcpsock.go:260 +0x47
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server.(*Server).Serve(0xc0004c03c0, 0xed8800, 0xc00044c018, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server/server.go:211 +0x1d4
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server.(*Server).ListenAndServe(0xc0004c03c0, 0x0, 0x0)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server/server.go:242 +0xad
  github.com/ProtonMail/Desktop-Bridge/server.startImap.func2(0xc0004c03c0, 0xc0004d4180, 0xc00002c180)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:92 +0x2f
  created by github.com/ProtonMail/Desktop-Bridge/server.startImap
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/server/server.go:91 +0x642

  goroutine 54 [chan receive]:
  github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server.(*Server).listenUpdates(0xc0004c03c0, 0xed8800, 0xc00044c018)
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server/server.go:298 +0xcb
  created by github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server.(*Server).Serve
  	/home/common/gopath/src/github.com/ProtonMail/Desktop-Bridge/vendor/github.com/emersion/go-imap/server/server.go:208 +0x108

  rax    0x0
  rbx    0x7ffe8a85b0d8
  rcx    0x7f9436a8fbe0
  rdx    0x0
  rdi    0x2
  rsi    0x7ffe8a85ae90
  rbp    0x7ffe8a85b280
  rsp    0x7ffe8a85af08
  r8     0x0
  r9     0x7ffe8a85ae90
  r10    0x8
  r11    0x246
  r12    0x2ed4550
  r13    0x0
  r14    0x2c86380
  r15    0x0
  rip    0x7f9436a8fbe0
  rflags 0x246
  cs     0x33
  fs     0x0
  gs     0x0
  ```

  </details>

  ## Technical details
  ```sh
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.4-041904-generic, Ubuntu, 18.10 (Cosmic Cuttlefish)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(siilwyn): `"nixpkgs-19.09pre175347.02bb5e35eae"`
   - nixpkgs: `/home/siilwyn/.nix-defexpr/channels/nixpkgs`
  ```

  Relevant maintainers: @GRBurst @lightdiscord @aaronjanse 


state: closed
title: nginx: use fullchain.pem for ssl_trusted_certificate
user_login: Streetwalrus
html_url: https://github.com/NixOS/nixpkgs/pull/60081
updated_at: 2019-05-03 04:28:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Some ACME clients (such as [the OpenBSD client](https://kristaps.bsd.lv/acme-client/)) do not generate full.pem, which is the same as fullchain.pem + the certificate key (key.pem), which is not necessary for verifying OCSP staples.
  See also #53493.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I haven't tested this PR, but I think it is trivial enough not to break anything. I have a production system where full.pem is a symlink to fullchain.pem to work around its absence.

  ---


state: open
title: Pantheon session crash after lock or suspend with multi-monitors
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60082
updated_at: 2019-05-06 19:04:49
body:
  ## Issue description

  I have this problem on a Lenovo Thinkpad L470, but not on a Thinkpad X230 or custom gaming PC.
  I had issues with X11 sessions before on this device, see https://github.com/NixOS/nixpkgs/issues/44344.

  See the log full of errors: https://gist.github.com/davidak/d2de7f9ef515755db76f3b61b102b664

  And video: https://peertube.social/videos/watch/2c9d8be7-3adb-48ae-a874-799fd9804dd2

  cc @worldofpeace 

  ### Steps to reproduce

  1. lock or suspend session
  2. when locked, the screen get on again after 2 seconds
  3. you login again, screen get black shortly and login screen is shown again
  3. i can't type in password field, only click on "login" without password. it is wrong obviously
  4. then i can type in a password again and get a new session. my former session is crashed

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600, nixos-hardware, nixos-unstable-19.09pre176329.d2602779281"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: python3Packages.Nikola: add missing extra dependencies
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60083
updated_at: 2019-04-23 15:29:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes #60034

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hugo: 0.55.2 -> 0.55.3
user_login: callahad
html_url: https://github.com/NixOS/nixpkgs/pull/60084
updated_at: 2019-04-23 11:51:34
body:
  ###### Motivation for this change

  Version bump.

  - Release notes: https://gohugo.io/news/0.55.3-relnotes/
  - Commit diff: https://github.com/gohugoio/hugo/compare/v0.55.2...release-0.55.3

  ###### Things done

  Built and ran. Compiled my site. It works.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rustfmt: 1.0.1 -> 1.2.1
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/60085
updated_at: 2019-04-23 11:41:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes the build after the rustc 1.34.0 update in
  https://github.com/NixOS/nixpkgs/pull/59366.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doit: fix darwin build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60086
updated_at: 2019-04-23 15:29:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: It's not clear how to enable core dumps
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/60088
updated_at: 2019-04-24 14:01:28
body:
  ## Issue description

  In best case `systemd.coredump.enable = true;` would be enough.

  But the description says: "Note that this alone is not enough to enable core dumps."

  https://nixos.org/nixos/options.html#coredump

  So when it's not possible to extend this option, please add a section to the manual with detailed instructions and code.

  I tried this, but `coredumpctl` still shows no coredumps. But i'm not sure it should.

  ```
    # enable core dumps
    systemd.coredump.enable = true;
    security.pam.loginLimits = [
      { domain = "*"; item = "core"; type = "soft"; value = "unlimited"; }
    ];
    systemd.extraConfig = "DefaultLimitCORE=1000000";
  ```

  I have rebootet after the rebuild.

  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.03.172312.330b9fac600 (Koi)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172312.330b9fac600, nixos-hardware, nixos-unstable-19.09pre176329.d2602779281"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: teeworlds: 0.7.3 -> 0.7.3.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60089
updated_at: 2019-04-23 13:30:52
body:
  ###### Motivation for this change

  https://www.teeworlds.com/?page=news&id=12808

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: valgrind: 3.14.0 -> 3.15.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60091
updated_at: 2019-04-27 05:08:24
body:
  ###### Motivation for this change

  https://sourceforge.net/p/valgrind/mailman/message/36642596/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openblas: turn off AVX512 optimizations
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/60092
updated_at: 2019-04-29 10:32:27
body:
  ###### Motivation for this change
  The AVX512 optimization has a bug in openblas-0.3.5 and can also lead to slower code on Xeon Silver CPUs.

  Closes https://github.com/NixOS/nixpkgs/issues/59708

  Needs backport to 19.03
  ###### Things done
  I checked the fix by running a benchmark test on NixOS 19.03 with the modified make flags on a Xeon Silver 4114 system. The tests that previously failed (see https://github.com/xianyi/OpenBLAS/issues/2029) are now working. Performance is now comparable a fixed target version with `DYANMIC_ARCH=0` and `TARGET=HASWELL`, which is expected.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kind: 0.1.0 -> 0.2.1
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60093
updated_at: 2019-04-23 16:21:19
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages: fix regression in zarith-dependent libraries
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60094
updated_at: 2019-04-26 19:38:57
body:
  ###### Motivation for this change

  See https://github.com/NixOS/nixpkgs/pull/58932#issuecomment-485443775, as well as the explanation in 564653f91d7031495a0b955c744a578352f34576.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildah: 1.7.2 -> 1.7.3
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/60095
updated_at: 2019-05-02 19:33:10
body:
  ###### Motivation for this change

  Bump to latest minor release : [changelog](https://github.com/containers/buildah/releases/tag/v1.7.3).
  Will need to be backport to 19.03 I think :thinking: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.asyncssh: 1.15.1 -> 1.16.1
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60096
updated_at: 2019-04-24 16:41:17
body:
  https://github.com/ronf/asyncssh/blob/master/docs/changes.rst#release-1161-30-mar-2019

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Been waiting forever to pr this :rofl: 


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/openldap: make rootpw option optional
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/60097
updated_at: 2019-05-02 08:06:04
body:
  This allows to store passwords in external files outside of the world-readable
  nix store.

  cc @ciil

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rustup: 1.17.0 -> 1.18.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60098
updated_at: 2019-04-27 10:21:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `rustup` to the latest release.
  https://github.com/rust-lang/rustup.rs/releases/tag/1.18.1
  Changes: https://github.com/rust-lang/rustup.rs/blob/1.18.1/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages: add prefix 'php-' to packages
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/60099
updated_at: 2019-04-24 10:15:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Aadd prefix 'php-' to php packages
  See - https://github.com/NixOS/nixpkgs/pull/59904#issuecomment-485390925

  cc @etu @aanderse 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add mutter nvidiga eglstream support
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/60100
updated_at: 2019-05-18 03:26:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Make it possible to run a gnome shell wayland session using nvidia drivers.

  This is supported on both [fedora](https://src.fedoraproject.org/rpms/mutter/blob/master/f/mutter.spec#_125) and [arch](https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/mutter#n44).

  ###### Things done

  Checked that `mutter` runs (`mutter --wayland --nested`), but I don't have any nvidia hardware so can't be sure that the intended functionality actually works.

  I opted to package https://github.com/NVIDIA/eglexternalplatform inline.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: NixOS remote builder with cross compilation
user_login: dkudriavtsev
html_url: https://github.com/NixOS/nixpkgs/issues/60101
updated_at: 2019-05-27 20:13:30
body:
  ## Issue description

  Is there an established method of using a remote builder with a cross compiler?

  I am attempting to run NixOS on a Raspberry Pi using the armv7 architecture, but there is very little software built for it in Hydra so much of the configuration has to be compiled. This compilation process has now been running for three days.

  Is there a way to run a builder daemon on my x86_64 system to cross compile to ARM  more quickly?


state: closed
title: nginx: 1.14.2 -> 1.16.0
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/60102
updated_at: 2019-04-30 13:21:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update nginxStable and nginxMainline to 1.16.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: aarch32 stdenv should hide the architecture of the builder machine
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/issues/60103
updated_at: 2019-04-24 12:59:10
body:
  ## Issue description

  ```aarch64``` build box is able to compile for ```aarch32```
  https://discourse.nixos.org/t/new-aarch64-and-armv7l-linux-omg-builders/1010

  The problem is: build scripts of many software (openssl, libffi, perl, python, ...) are not aware of ```aarch64``` machines running ```aarch32``` code, detect the host system as ```aarch64``` and then do insane things like compiling ```aarch64``` assemler files into ```aarch32``` build.

  It was not fixed on time expecting @Ericson2314 proposal for "always cross compile" (https://github.com/NixOS/nixpkgs/issues/21471) to be accepted soon, but it did not happen.

  So the idea is to fix ```aarch32``` ```stdenv``` so it would hide from 3rd-party scripts the true architecture of the builder machine  (by providing fake ```uname``` and tricks like that)


state: closed
title: Vulnerability roundup 66: gvfs-1.38.2: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60104
updated_at: 2019-04-24 04:17:35
body:
  [search](https://search.nix.gsc.io/?q=gvfs&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gvfs+in%3Apath&type=Code)

  * [ ] [CVE-2019-3827](https://nvd.nist.gov/vuln/detail/CVE-2019-3827) (nixos-19.03)

  Scanned versions: nixos-19.03: 330b9fac600. May contain false positives.


state: closed
title: Vulnerability roundup 66: patch-2.7.6: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60105
updated_at: 2019-05-08 12:38:09
body:
  [search](https://search.nix.gsc.io/?q=patch&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=patch+in%3Apath&type=Code)

  * [x] [CVE-2018-6952](https://nvd.nist.gov/vuln/detail/CVE-2018-6952) (nixos-19.03)

  Scanned versions: nixos-19.03: 330b9fac600. May contain false positives.


state: closed
title: Vulnerability roundup 66: cups-2.2.6: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60106
updated_at: 2019-06-09 11:53:02
body:
  [search](https://search.nix.gsc.io/?q=cups&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=cups+in%3Apath&type=Code)

  * [x] [CVE-2018-4300](https://nvd.nist.gov/vuln/detail/CVE-2018-4300) (nixos-18.09)

  Scanned versions: nixos-18.09: 571b40d3f50. May contain false positives.


state: closed
title: Vulnerability roundup 66: openssl-1.1.1b: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60107
updated_at: 2019-06-07 06:14:46
body:
  [search](https://search.nix.gsc.io/?q=openssl&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=openssl+in%3Apath&type=Code)

  * [x] [CVE-2019-0190](https://nvd.nist.gov/vuln/detail/CVE-2019-0190) (nixos-unstable)
  * [x] [CVE-2019-1543](https://nvd.nist.gov/vuln/detail/CVE-2019-1543) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: closed
title: Vulnerability roundup 66: php-7.2.17: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60108
updated_at: 2019-04-26 22:58:14
body:
  [search](https://search.nix.gsc.io/?q=php&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=php+in%3Apath&type=Code)

  * [x] [CVE-2018-19935](https://nvd.nist.gov/vuln/detail/CVE-2018-19935) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: closed
title: Vulnerability roundup 66: sqlite-3.27.2: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60109
updated_at: 2019-05-08 09:04:55
body:
  [search](https://search.nix.gsc.io/?q=sqlite&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=sqlite+in%3Apath&type=Code)

  * [x] [CVE-2019-9936](https://nvd.nist.gov/vuln/detail/CVE-2019-9936) (nixos-unstable)
  * [x] [CVE-2019-9937](https://nvd.nist.gov/vuln/detail/CVE-2019-9937) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: open
title: Vulnerability roundup 66: zziplib-0.13.69: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60110
updated_at: 2019-04-23 21:29:08
body:
  [search](https://search.nix.gsc.io/?q=zziplib&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=zziplib+in%3Apath&type=Code)

  * [ ] [CVE-2018-16548](https://nvd.nist.gov/vuln/detail/CVE-2018-16548) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: open
title: Vulnerability roundup 66: samba-4.7.12: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60111
updated_at: 2019-04-23 21:29:08
body:
  [search](https://search.nix.gsc.io/?q=samba&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=samba+in%3Apath&type=Code)

  * [ ] [CVE-2019-3880](https://nvd.nist.gov/vuln/detail/CVE-2019-3880) (nixos-19.03, nixos-18.09)

  Scanned versions: nixos-19.03: 330b9fac600; nixos-18.09: 571b40d3f50. May contain false positives.


state: closed
title: Vulnerability roundup 66: wpa_supplicant-2.6: 3 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60112
updated_at: 2019-06-29 01:14:03
body:
  [search](https://search.nix.gsc.io/?q=wpa_supplicant&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=wpa_supplicant+in%3Apath&type=Code)

  * [ ] [CVE-2019-9497](https://nvd.nist.gov/vuln/detail/CVE-2019-9497) (nixos-18.09)
  * [ ] [CVE-2019-9498](https://nvd.nist.gov/vuln/detail/CVE-2019-9498) (nixos-18.09)
  * [ ] [CVE-2019-9499](https://nvd.nist.gov/vuln/detail/CVE-2019-9499) (nixos-18.09)

  Scanned versions: nixos-18.09: 571b40d3f50. May contain false positives.


state: open
title: Vulnerability roundup 66: python-2.7.16: 4 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60113
updated_at: 2019-04-23 21:29:09
body:
  [search](https://search.nix.gsc.io/?q=python&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=python+in%3Apath&type=Code)

  * [ ] [CVE-2019-9636](https://nvd.nist.gov/vuln/detail/CVE-2019-9636) (nixos-unstable)
  * [ ] [CVE-2019-9740](https://nvd.nist.gov/vuln/detail/CVE-2019-9740) (nixos-unstable)
  * [ ] [CVE-2019-9947](https://nvd.nist.gov/vuln/detail/CVE-2019-9947) (nixos-unstable)
  * [ ] [CVE-2019-9948](https://nvd.nist.gov/vuln/detail/CVE-2019-9948) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: closed
title: Vulnerability roundup 66: samba-4.10.2: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60114
updated_at: 2019-05-16 20:47:26
body:
  [search](https://search.nix.gsc.io/?q=samba&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=samba+in%3Apath&type=Code)

  * [ ] [CVE-2018-1050](https://nvd.nist.gov/vuln/detail/CVE-2018-1050) (nixos-unstable)
  * [ ] [CVE-2018-1057](https://nvd.nist.gov/vuln/detail/CVE-2018-1057) (nixos-unstable)

  Scanned versions: nixos-unstable: d2602779281. May contain false positives.


state: closed
title: Vulnerability roundup 66: libxslt-1.1.33: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60115
updated_at: 2019-05-08 08:58:03
body:
  [search](https://search.nix.gsc.io/?q=libxslt&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libxslt+in%3Apath&type=Code)

  * [x] [CVE-2019-11068](https://nvd.nist.gov/vuln/detail/CVE-2019-11068) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: d2602779281; nixos-19.03: 330b9fac600. May contain false positives.


state: open
title: Vulnerability roundup 66: postgresql-9.6.12: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60116
updated_at: 2019-04-23 21:29:09
body:
  [search](https://search.nix.gsc.io/?q=postgresql&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=postgresql+in%3Apath&type=Code)

  * [ ] [CVE-2018-1058](https://nvd.nist.gov/vuln/detail/CVE-2018-1058) (nixos-unstable, nixos-18.09)
  * [ ] [CVE-2019-9193](https://nvd.nist.gov/vuln/detail/CVE-2019-9193) (nixos-unstable, nixos-18.09)

  Scanned versions: nixos-unstable: d2602779281; nixos-18.09: 571b40d3f50. May contain false positives.


state: closed
title: Vulnerability roundup 66: wpa_supplicant-2.7: 6 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60117
updated_at: 2019-04-29 08:39:49
body:
  [search](https://search.nix.gsc.io/?q=wpa_supplicant&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=wpa_supplicant+in%3Apath&type=Code)

  * [x] [CVE-2019-9494](https://nvd.nist.gov/vuln/detail/CVE-2019-9494) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-9495](https://nvd.nist.gov/vuln/detail/CVE-2019-9495) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-9496](https://nvd.nist.gov/vuln/detail/CVE-2019-9496) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-9497](https://nvd.nist.gov/vuln/detail/CVE-2019-9497) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-9498](https://nvd.nist.gov/vuln/detail/CVE-2019-9498) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-9499](https://nvd.nist.gov/vuln/detail/CVE-2019-9499) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: d2602779281; nixos-19.03: 330b9fac600. May contain false positives.


state: closed
title: Vulnerability roundup 66: webkitgtk-2.20.5: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60118
updated_at: 2019-06-29 01:17:16
body:
  [search](https://search.nix.gsc.io/?q=webkitgtk&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=webkitgtk+in%3Apath&type=Code)

  * [ ] [CVE-2019-11070](https://nvd.nist.gov/vuln/detail/CVE-2019-11070) (nixos-18.09)

  Scanned versions: nixos-18.09: 571b40d3f50. May contain false positives.


state: closed
title: qt 5.12.0 -> 5.12.3 WIP
user_login: vandenoever
html_url: https://github.com/NixOS/nixpkgs/pull/60119
updated_at: 2019-07-11 07:38:31
body:
  ###### Motivation for this change

  Qt 5.12 has received 3 bugfix releases since 5.12.0. However updating it has proven non-trivial. This PR  is a WIP.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: factorio: alpha 0.16.51 -> 0.17.32
user_login: bjpbakker
html_url: https://github.com/NixOS/nixpkgs/pull/60120
updated_at: 2019-04-24 19:05:17
body:
  ###### Motivation for this change
  Backport #59902 to stable channel.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia_x11_beta: stable -> 430.09
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/60121
updated_at: 2019-05-03 20:33:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  Haven't got a clue why the links were changed for the downloads now. `nvidia-settings` and `nvidia-persistenced` are just retrieved from github now since the beta doesn't seem to have it. Beta compiles fine on `5.1.0-rc6`.
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wordgrinder: Fix build
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/60122
updated_at: 2019-04-26 07:31:00
body:
  This fixes the build of the wordgrinder package by disabling the build
  of "xwordgrinder", the non-curses frontend of wordgrinder.

  For re-enabling the build, this patch shall be reverted and then go on
  from there.

  I opted for disabling the x frontend of this program because the whole
  purpose of this is to use a curses writing program (at least for me).
  It seems that hacking around the new build system in nixpkgs is a
  non-trivial task and I wanted to get this package out of the door as
  fast as possible because I already delayed the fix by a few days (or is
  it weeks already), so this is the simple fix.

  If someone wants to have the X frontend again, I can invest more time at
  some point.

  Fixes: 6b2bd330fa ("wordgrinder: Fix sha256 hash")
  Fixes: 19a3abc1b8 ("wordgrinder: 0.7.1 -> 0.7.2")
  CC: @aszlig
  CC: @devhell

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gettext: fix cross build
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/60123
updated_at: 2019-04-24 18:47:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes the cross build of gettext that was broken by the incorrect use of `optional` in #59553.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  cc @strager @veprbl 

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/wireguard: set `networking.firewall.allowedUDPPorts` automatically
user_login: spacekookie
html_url: https://github.com/NixOS/nixpkgs/pull/60124
updated_at: 2019-05-11 18:43:29
body:
  ###### Motivation for this change

  This changes the wireguard module to automatically add the provided
  `listenPort` for an interface to the list of allowed udp ports in the
  firewall. This means that users don't have to do this themselves when
  configuring a wireguard server.
  It also adjusts the wireguard test to not rely on explicitly-set
  firewall ports

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: buildRustCrate: Always set some more environment variables
user_login: kolloch
html_url: https://github.com/NixOS/nixpkgs/issues/60125
updated_at: 2019-04-24 07:33:12
body:
  ## Issue description

  The rust crate "built" assumes that certain environment variables are always set -- to an empty string if necessary. This is what cargo does, so let's emulate that.

  See https://github.com/kolloch/crate2nix/issues/6 for more details.

  ### Steps to reproduce

  See https://github.com/kolloch/crate2nix/issues/6

  ## Technical details

  I am preparing a patch to fix this, so I skip this.


state: closed
title: Kernel oops with 4.19.36 at boot
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/issues/60126
updated_at: 2019-05-06 07:23:17
body:
  ## Issue description
  After updating from NixOS 18.09 / kernel 4.19.34 to NixOS 19.03 / kernel 4.19.36, the kernel oops'es at boot resulting in udevd crash and boot hanging.

  ## Technical details
  Hardware: Lenovo Legion Y720
  Googling turned up this: https://marc.info/?l=linux-input&m=154081045228829&w=2
  Error message:
  ```
  apr 23 23:28:02 nixos kernel: i2c_hid i2c-ITE33D1:00: i2c-ITE33D1:00 supply vdd not found, using dummy regulator
  apr 23 23:28:02 nixos kernel: i2c_hid i2c-ITE33D1:00: Linked as a consumer to regulator.0
  apr 23 23:28:02 nixos kernel: i2c_hid i2c-ITE33D1:00: i2c-ITE33D1:00 supply vddl not found, using dummy regulator
  apr 23 23:28:02 nixos kernel: BUG: unable to handle kernel paging request at 00000d6100000000
  apr 23 23:28:02 nixos kernel: PGD 0 P4D 0 
  apr 23 23:28:02 nixos kernel: Oops: 0000 [#1] SMP NOPTI
  apr 23 23:28:02 nixos kernel: CPU: 7 PID: 704 Comm: systemd-udevd Tainted: P           O      4.19.36 #1-NixOS
  apr 23 23:28:02 nixos kernel: Hardware name: LENOVO 80VR/LNVNB161216, BIOS 4GCN31WW 09/27/2017
  apr 23 23:28:02 nixos kernel: RIP: 0010:strcmp+0x4/0x20
  apr 23 23:28:02 nixos kernel: Code: 09 48 83 c2 01 80 3a 00 75 f7 48 83 c6 01 0f b6 4e ff 48 83 c2 01 84 c9 88 4a ff 75 ed f3 c3 0f 1f 80 00 00 00 00 48 83 c7 01 <0f> b6 47 ff 48 83 c6 01 3a 46 ff 75 07 84 c0 75 eb 31 c0 c3 19 c0
  apr 23 23:28:02 nixos kernel: RSP: 0018:ffffb66d0288f748 EFLAGS: 00010202
  apr 23 23:28:02 nixos kernel: RAX: 0000000000000000 RBX: ffffffffc046fbd0 RCX: 0000000000000000
  apr 23 23:28:02 nixos kernel: RDX: ffffb66d0288f76e RSI: ffffffffc046fbe1 RDI: 00000d6100000001
  apr 23 23:28:02 nixos kernel: RBP: 0000000000000000 R08: ffff8ce17ebdaca8 R09: ffffb66d0288f76e
  apr 23 23:28:02 nixos kernel: R10: ffffb66d0288f6d0 R11: 000000000000038f R12: 00000000fffffffe
  apr 23 23:28:02 nixos kernel: R13: ffffffffc046fbe1 R14: ffff8ce1701d2000 R15: ffff8ce1701d2000
  apr 23 23:28:02 nixos kernel: FS:  00007f85d6537cc0(0000) GS:ffff8ce17ebc0000(0000) knlGS:0000000000000000
  apr 23 23:28:02 nixos kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  apr 23 23:28:02 nixos kernel: CR2: 00000d6100000000 CR3: 00000004b269a006 CR4: 00000000003606e0
  apr 23 23:28:02 nixos kernel: Call Trace:
  apr 23 23:28:02 nixos kernel:  dmi_matches+0x8c/0xc0
  apr 23 23:28:02 nixos kernel:  dmi_first_match+0x26/0x40
  apr 23 23:28:02 nixos kernel:  i2c_hid_get_dmi_i2c_hid_desc_override+0x16/0x40 [i2c_hid]
  apr 23 23:28:02 nixos kernel:  i2c_hid_probe+0x391/0x7c0 [i2c_hid]
  apr 23 23:28:02 nixos kernel:  ? acpi_device_wakeup_disable+0x15/0x50
  apr 23 23:28:02 nixos kernel:  ? i2c_hid_start+0x130/0x130 [i2c_hid]
  apr 23 23:28:02 nixos kernel:  i2c_device_probe+0x1e7/0x260 [i2c_core]
  apr 23 23:28:02 nixos kernel:  really_probe+0x262/0x3d0
  apr 23 23:28:02 nixos kernel:  ? __driver_attach+0x100/0x100
  apr 23 23:28:02 nixos kernel:  driver_probe_device+0x10f/0x120
  apr 23 23:28:02 nixos kernel:  ? __driver_attach+0x100/0x100
  apr 23 23:28:02 nixos kernel:  bus_for_each_drv+0x66/0xb0
  apr 23 23:28:02 nixos kernel:  __device_attach+0xd9/0x150
  apr 23 23:28:02 nixos kernel:  bus_probe_device+0x8a/0xa0
  apr 23 23:28:02 nixos kernel:  device_add+0x48f/0x660
  apr 23 23:28:02 nixos kernel:  i2c_new_device+0x15f/0x350 [i2c_core]
  apr 23 23:28:02 nixos kernel:  i2c_acpi_register_device+0x20/0x60 [i2c_core]
  apr 23 23:28:02 nixos kernel:  i2c_acpi_add_device+0x69/0x70 [i2c_core]
  apr 23 23:28:02 nixos kernel:  acpi_ns_walk_namespace+0xda/0x1aa
  apr 23 23:28:02 nixos kernel:  ? i2c_acpi_register_device+0x60/0x60 [i2c_core]
  apr 23 23:28:02 nixos kernel:  ? i2c_acpi_register_device+0x60/0x60 [i2c_core]
  apr 23 23:28:02 nixos kernel:  acpi_walk_namespace+0x9c/0xcb
  apr 23 23:28:02 nixos kernel:  i2c_acpi_register_devices+0x40/0x60 [i2c_core]
  apr 23 23:28:02 nixos kernel:  i2c_register_adapter+0x168/0x400 [i2c_core]
  apr 23 23:28:02 nixos kernel:  i2c_dw_probe+0x3e5/0xe30 [i2c_designware_core]
  apr 23 23:28:02 nixos kernel:  dw_i2c_plat_probe+0x30d/0x6c0 [i2c_designware_platform]
  apr 23 23:28:02 nixos kernel:  platform_drv_probe+0x3a/0x90
  apr 23 23:28:02 nixos kernel:  ? driver_sysfs_add+0x75/0xd0
  apr 23 23:28:02 nixos kernel:  really_probe+0x262/0x3d0
  apr 23 23:28:02 nixos kernel:  driver_probe_device+0x10f/0x120
  apr 23 23:28:02 nixos kernel:  __driver_attach+0xdc/0x100
  apr 23 23:28:02 nixos kernel:  ? driver_probe_device+0x120/0x120
  apr 23 23:28:02 nixos kernel:  bus_for_each_dev+0x76/0xc0
  apr 23 23:28:02 nixos kernel:  bus_add_driver+0x161/0x260
  apr 23 23:28:02 nixos kernel:  ? 0xffffffffc0474000
  apr 23 23:28:02 nixos kernel:  driver_register+0x5b/0xe0
  apr 23 23:28:02 nixos kernel:  ? 0xffffffffc0474000
  apr 23 23:28:02 nixos kernel:  do_one_initcall+0x46/0x1c8
  apr 23 23:28:02 nixos kernel:  ? _cond_resched+0x15/0x40
  apr 23 23:28:02 nixos kernel:  ? kmem_cache_alloc_trace+0x153/0x1c0
  apr 23 23:28:02 nixos kernel:  do_init_module+0x5b/0x202
  apr 23 23:28:02 nixos kernel:  load_module+0x20c9/0x27a0
  apr 23 23:28:02 nixos kernel:  ? __do_sys_init_module+0x159/0x190
  apr 23 23:28:02 nixos kernel:  ? _cond_resched+0x15/0x40
  apr 23 23:28:02 nixos kernel:  __do_sys_init_module+0x159/0x190
  apr 23 23:28:02 nixos kernel:  do_syscall_64+0x4e/0x100
  apr 23 23:28:02 nixos kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xa9
  apr 23 23:28:02 nixos kernel: RIP: 0033:0x7f85d6acbc2a
  apr 23 23:28:02 nixos kernel: Code: 48 8b 0d 59 c2 0b 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 af 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 26 c2 0b 00 f7 d8 64 89 01 48
  apr 23 23:28:02 nixos kernel: RSP: 002b:00007ffdcfb5cde8 EFLAGS: 00000246 ORIG_RAX: 00000000000000af
  apr 23 23:28:02 nixos kernel: RAX: ffffffffffffffda RBX: 00005588f1002d70 RCX: 00007f85d6acbc2a
  apr 23 23:28:02 nixos kernel: RDX: 00007f85d6c238ad RSI: 00000000000041e8 RDI: 00005588f1039220
  apr 23 23:28:02 nixos kernel: RBP: 00007f85d6c238ad R08: ffffffffffffffe0 R09: 0000000000004c20
  apr 23 23:28:02 nixos kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 00005588f1039220
  apr 23 23:28:02 nixos kernel: R13: 00005588f0ff7bb0 R14: 0000000000020000 R15: 0000000003938700
  apr 23 23:28:02 nixos kernel: Modules linked in: arc4 nvidia_drm(PO+) nvidia_modeset(PO) nvidia_uvm(O) snd_hda_codec_hdmi iwlmvm i915 mac80211 i2c_designware_platform(+) i2c_designware_core intel_wmi_thunderbolt iTCO_wdt wmi_bmof intel_pmc_core x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvmgt vfio_mdev mdev vfio_iommu_type1 iwlwifi vfio uvcvideo kvm videobuf2_vmalloc videobuf2_memops btusb videobuf2_v4l2 btrtl btbcm btintel cec bluetooth irqbypass deflate nls_iso8859_1 videobuf2_common cfg80211 crct10dif_pclmul drm_kms_helper efi_pstore pstore crc32_pclmul snd_hda_intel videodev nls_cp437 ghash_clmulni_intel r8169 vfat intel_cstate snd_hda_codec media realtek ecdh_generic intel_uncore joydev evdev mousedev nvidia(PO) fat mac_hid intel_rapl_perf psmouse drm serio_raw efivars snd_hda_core rfkill mei_me
  apr 23 23:28:02 nixos kernel:  libphy intel_gtt idma64 virt_dma i2c_i801 snd_hwdep mei i2c_algo_bit agpgart intel_lpss_pci intel_pch_thermal intel_lpss fb_sys_fops syscopyarea sysfillrect sysimgblt i2c_hid tpm_crb battery tpm_tis pinctrl_sunrisepoint tpm_tis_core tpm pinctrl_intel acpi_pad rng_core button video wmi ac pcc_cpufreq ipmi_devintf ipmi_msghandler i2c_core snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd soundcore loop cpufreq_powersave vboxnetflt(O) vboxnetadp(O) vboxdrv(O) efivarfs ip_tables x_tables ipv6 crc_ccitt autofs4 ext4 crc32c_generic crc16 mbcache jbd2 fscrypto dm_crypt hid_logitech_hidpp hid_logitech_dj hid_generic usbhid hid sd_mod ahci xhci_pci libahci input_leds led_class xhci_hcd libata atkbd libps2 nvme usbcore aesni_intel scsi_mod aes_x86_64 crypto_simd cryptd glue_helper nvme_core crc32c_intel
  apr 23 23:28:02 nixos kernel:  usb_common i8042 rtc_cmos serio dm_mod
  apr 23 23:28:02 nixos kernel: CR2: 00000d6100000000
  apr 23 23:28:02 nixos kernel: ---[ end trace 805fdf4212e17958 ]---
  apr 23 23:28:02 nixos kernel: psmouse serio1: synaptics: queried max coordinates: x [..5660], y [..4570]
  apr 23 23:28:02 nixos kernel: RIP: 0010:strcmp+0x4/0x20
  apr 23 23:28:02 nixos kernel: Code: 09 48 83 c2 01 80 3a 00 75 f7 48 83 c6 01 0f b6 4e ff 48 83 c2 01 84 c9 88 4a ff 75 ed f3 c3 0f 1f 80 00 00 00 00 48 83 c7 01 <0f> b6 47 ff 48 83 c6 01 3a 46 ff 75 07 84 c0 75 eb 31 c0 c3 19 c0
  apr 23 23:28:02 nixos kernel: RSP: 0018:ffffb66d0288f748 EFLAGS: 00010202
  apr 23 23:28:02 nixos kernel: RAX: 0000000000000000 RBX: ffffffffc046fbd0 RCX: 0000000000000000
  apr 23 23:28:02 nixos kernel: RDX: ffffb66d0288f76e RSI: ffffffffc046fbe1 RDI: 00000d6100000001
  apr 23 23:28:02 nixos kernel: RBP: 0000000000000000 R08: ffff8ce17ebdaca8 R09: ffffb66d0288f76e
  apr 23 23:28:02 nixos kernel: R10: ffffb66d0288f6d0 R11: 000000000000038f R12: 00000000fffffffe
  apr 23 23:28:02 nixos kernel: R13: ffffffffc046fbe1 R14: ffff8ce1701d2000 R15: ffff8ce1701d2000
  apr 23 23:28:02 nixos kernel: FS:  00007f85d6537cc0(0000) GS:ffff8ce17ea00000(0000) knlGS:0000000000000000
  apr 23 23:28:02 nixos kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  apr 23 23:28:02 nixos kernel: CR2: 00007f90c1f00130 CR3: 00000004b269a005 CR4: 00000000003606f0
  apr 23 23:28:02 nixos systemd-udevd[670]: worker [704] terminated by signal 9 (KILL)
  apr 23 23:28:02 nixos systemd-udevd[670]: worker [704] failed while handling '/devices/pci0000:00/0000:00:15.2/i2c_designware.1'
  ```


state: closed
title: buildRustCrate: Fix #60125 - Always set additional env variables during build
user_login: kolloch
html_url: https://github.com/NixOS/nixpkgs/pull/60127
updated_at: 2019-04-24 07:28:04
body:
  Namely `CARGO_PKG_VERSION_PRE` and `CARGO_PKG_HOMEPAGE`
  (as cargo does)

  @P-E-Meunier

  ###### Motivation for this change

  The `built` crate assumes that these environment variables are always set at build time. Cargo does that. Since we are emulating cargo, we should, too.

  ###### Things done

  I build the crate that failed before using the update nixpkgs.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS) 
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xv: init at 0.1.0
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/60128
updated_at: 2019-04-24 01:14:26
body:
  ###### Motivation for this change
  New tool `xv`: https://chrisvest.github.io/xv/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [X] other Linux distributions (Linux in Docker)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Running the Linux build in Docker didn't print the unicode characters correctly, but I'm assuming that's some artifact of the Docker environment. I tested on NixOS and it works properly there.


state: closed
title: prometheus_2: 2.8.1 -> 2.9.1
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/60129
updated_at: 2019-05-05 20:14:56
body:
  ###### Motivation for this change

  https://github.com/prometheus/prometheus/releases

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I am using 2.9.1 and it seems to work fine.


state: closed
title: nodejs-12_x: init at 12.0.0
user_login: lo1tuma
html_url: https://github.com/NixOS/nixpkgs/pull/60130
updated_at: 2019-04-26 06:27:15
body:
  ###### Motivation for this change

  [Release Notes](https://nodejs.org/en/blog/release/v12.0.0/)

  ###### Things done

  nodejs 12 requires libuv 1.28.0 that’s why I’ve updated libuv in this PR as well.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: [wip] fix aarch32 build on aarch64 builder
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60131
updated_at: 2019-07-01 12:30:36
body:
  The community aarch64 build box with Hi1616 CPU is capable to run aarch32 code, so it can work as aarch32 builder.
  It does not requre cross-compilation. It is just like i686 on x86_64.

  But some packages detect target architecture by executing `uname -m`, they get aarch64 and then use the value wrongly.

  This PR is not the complete fix (if the complete fix even possible).
  It fixes essential derivations whose failures prevent to build many other packages/

  Related: #60103 https://discourse.nixos.org/t/new-aarch64-and-armv7l-linux-omg-builders/1010


state: open
title: Remove nodejs-8_x for 19.09 release
user_login: lo1tuma
html_url: https://github.com/NixOS/nixpkgs/issues/60132
updated_at: 2019-04-27 06:47:12
body:
  ## Issue description

  Right now `nodejs-8_x` is in maintenance  mode, while `nodejs-10_x` is the current active LTS version. According to the [nodejs release schedule](https://github.com/nodejs/Release/blob/f4ae92f443f57f4b8f0716859a9a64ba055caac4/README.md) `nodejs-8_x` will reach its end of life in December 2019 because at this date also OpenSSL-1.0.2 will be end of life. 


state: closed
title: qemu: 3.1.0 -> 4.0.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60133
updated_at: 2019-05-21 08:12:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg03851.html

  Middle of rebuild, haven't tried this yet --
  hopefully we only need to remove any patches no longer needed
  and lots of testing :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wpgtk: 6.0.3 -> 6.0.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60134
updated_at: 2019-04-26 04:25:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: joplin-desktop: appimageTools-ify
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60135
updated_at: 2019-04-26 05:18:04
body:
  ###### Motivation for this change

  Same treatment as minetime over in #56259,
  depends on some commits there.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: notable: init at 1.4.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60136
updated_at: 2019-04-26 05:18:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Builds on top of #56259, commits included to facilitate testing.

  Will adjust/rebase as appropriate as that PR advances.

  cc #60135.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: chromaprint: 1.3.2 -> 1.4.3
user_login: hhm0
html_url: https://github.com/NixOS/nixpkgs/pull/60137
updated_at: 2019-05-05 23:19:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  B"H

  This pull updates `chromaprint`, and applies a patch to `clementine` so it builds with the newer `chromaprint`.

  See https://github.com/acoustid/chromaprint/releases/tag/v1.4.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
   - [ ] Assured whether relevant documentation is up to date
   - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wireguard: add generatePrivateKeyFile option + test
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/60138
updated_at: 2019-04-24 14:03:05
body:
  Ideally, private keys never leave the host they're generated on - like
  SSH. Setting generatePrivateKeyFile to true causes the PK to be
  generate automatically.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rxvt_unicode: fix build
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/60139
updated_at: 2019-04-24 08:38:22
body:
  ###### Motivation for this change

  Fixes a last-minute change introduced in #59896 that broke the rxvt package:

  ```
  > :b pkgs.rxvt_unicode-with-plugins
  builder for '/nix/store/a41snhm28vmqqgxnwbc9645cn403y6ng-rxvt-unicode-with-perl-with-unicode3-with-plugins-9.22.drv' failed with exit code 1; last 9 log lines:
    
    Builder called die: makeWrapper doesn't understand the arg 
    Backtrace:
    108 makeWrapper /nix/store/2j5wxs045w8svy2494hh1p8y1d3ah8ak-hook/nix-support/setup-hook
    152 wrapProgram /nix/store/2j5wxs045w8svy2494hh1p8y1d3ah8ak-hook/nix-support/setup-hook
    5 source /build/.attr-0
    1273 genericBuild /nix/store/jqavib0kpn83cp0gjcq9pw8bvfas1kc0-stdenv-linux/setup
    2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh
  ```

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @rnhmjoj @joachifm


state: closed
title: chromium: 73.0.3683.103 -> 74.0.3729.108
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/60140
updated_at: 2019-04-26 04:21:09
body:
  ###### Motivation for this change

  https://chromereleases.googleblog.com/2019/04/stable-channel-update-for-desktop_23.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested stable only: YouTube, audio, WebGL, Octane 2.0 work


state: closed
title: youtube-dl: 2019.04.17 -> 2019.04.24
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60141
updated_at: 2019-04-24 04:12:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `youtube-dl` to the latest release.
  https://github.com/ytdl-org/youtube-dl/releases/tag/2019.04.24
  NOTE:  Updates to `youtube-dl` should be backported, thanks!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rng-tools: 6.6 -> 6.7 and libp11: 0.4.9 -> 0.4.10
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60142
updated_at: 2019-04-29 07:41:46
body:
  ###### Motivation for this change

  https://github.com/nhorman/rng-tools/releases/tag/v6.7

  The libp11 change is included here as rng-tools is now the first consumer of libp11.

  A few other changes:

   - use autoreconfHook instead of doing it manually
   - clean up with/enable flags
   - add support for PKCS11 entropy sources

  PKCS11 is not fully tested yet as my hardware hasn't arrived.

  Cc: @JohnAZoidberg 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] wpa_supplicant: fix SAE and EAP_PWD vulnerabilities
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60143
updated_at: 2019-04-27 15:23:48
body:
  Fixes #60117

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: alacritty: 0.3.1 -> 0.3.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60144
updated_at: 2019-04-24 07:53:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `alacritty` to the latest release.
  https://github.com/jwilm/alacritty/releases/tag/v0.3.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Patch Julia to not recompile packages when mtime is 1
user_login: thomasjm
html_url: https://github.com/NixOS/nixpkgs/pull/60145
updated_at: 2019-04-24 07:16:28
body:
  ###### Motivation for this change

  Julia recompiles a precompiled file if the mtime stored in the `.ji` file differs from the mtime of the `.ji` file. This doesn't work in Nix because Nix changes the mtime of files in the Nix store to 1.

  The exact same situation exists with Python `.pyc` files and is fixed with [this patch](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/cpython/2.7/nix-store-mtime.patch). I applied the exact same solution to Julia in this PR.


  ###### Things done


  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] Ubuntu
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [N/A] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [N/A] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/packagekit: make it not error out + test
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60146
updated_at: 2019-04-26 13:06:40
body:
  ###### Motivation for this change

  We have a nixos module for packagekit, but it doesn't work as we do not have a backend for nix (#21230) so we now make the backend configurable and set it to ```test_nop``` which at least means that other software depending on packagekit (#34756 needs it) will at least not error out complaining about not being able to connect to to packagekit over dbus.

  Cc: @peti @matthewbauer @wizeman 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages: fix missing PyPI references
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60147
updated_at: 2019-04-25 07:16:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  * pythonPackages.pyev: drop: PyPI package removed
  * pythonPackages.python3pika: drop: unmaintained
  * pythonPackages.area53: drop: PyPI package removed
  * pythonPackages.eggdeps: fix PyPI name
  * pythonPackages.mp2: fix PyPI name
  * pythonPackages.mrbob: fix PyPI name
  * pythonPackages.pyaudio: fix PyPI name
  * pythonPackages.pymysqlsa: fix PyPI name
  * pythonPackages.pystache: fix pname
  * pythonPackages.setproctitle: fix PyPI name

  PD. elpy package was also removed from PyPI https://github.com/jorgenschaefer/elpy/issues/1583, I'm going to remove it in another PR

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ipfs: 0.4.19 -> 0.4.20
user_login: elitak
html_url: https://github.com/NixOS/nixpkgs/pull/60148
updated_at: 2019-04-28 15:57:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  The upstream repo no longer uses gx, so I had to generate a deps.nix using vgo2nix, and hand-add 1 broken entry to it.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mosquitto: 1.5.8 -> 1.6 + nixos tests
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60149
updated_at: 2019-04-24 14:29:12
body:
  ###### Motivation for this change

  https://github.com/eclipse/mosquitto/blob/master/ChangeLog.txt

  Also we need some kind of test in place - this is very basic but better than nothing.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [WIP] nixos/mautrix-telegram: init module
user_login: Vskilet
html_url: https://github.com/NixOS/nixpkgs/pull/60151
updated_at: 2019-06-25 08:50:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  On the same pattern that mautrix-whatsapp, I suggest this service for mautrix-telegram.
  What do you think about it @Ma27 :-) ?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "ibus-packages.mozc: pin to protobuf 3.6"
user_login: Lucus16
html_url: https://github.com/NixOS/nixpkgs/pull/60152
updated_at: 2019-04-24 13:13:00
body:
  ###### Motivation for this change

  protobuf was bumped to 3.7.1, which fixes the build issue as described
  in google/mozc#460.

  This reverts commit a19fbaf39ba2b9b1434b3dd159c79d0f645f0a6c.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [Low priority][Info] Output of ps inside init scripts of zsh- zshrc
user_login: SRGOM
html_url: https://github.com/NixOS/nixpkgs/issues/60153
updated_at: 2019-05-20 06:38:54
body:
  ## Issue description
  A lot of people had a similar issue so noting it here so they can reach here.
  `zsh` gives "weird" output for `ps- o cmd,pid` in NixOS (fine in Arch et al). 
  You'd expect something like `.../zsh` (how it happens in other OSs but what you get is: `/run/current-system/sw/bin/`

  ### Steps to reproduce

  ```
  #ps -o cmd, pid inside zshrc
  CMD                           PID
  /run/current-system/sw/bin/  4991
  ps -o cmd,pid                5013
  ```

  ### Solution is to use

  ```
  #ps -p $$ inside zshrc
    PID TTY          TIME CMD
   4991 pts/0    00:00:00 zsh
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.111, NixOS, 18.09.2505.46d3867a08a (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2505.46d3867a08a"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Can't install Jupyterlab with python 3.7
user_login: tcosmo
html_url: https://github.com/NixOS/nixpkgs/issues/60154
updated_at: 2019-04-25 07:41:53
body:
  ## Issue description

  Jupyterlab builder fails on python37 with the error:

  `Collecting jupyterlab-server<0.3.0,>=0.2.0 (from jupyterlab==0.35.4)
    Could not find a version that satisfies the requirement jupyterlab-server<0.3.0,>=0.2.0 (from jupyterlab==0.35.4) (from versions: )
  No matching distribution found for jupyterlab-server<0.3.0,>=0.2.0 (from jupyterlab==0.35.4)
  builder for '/nix/store/cjb48hbc1x4k5y9wd9r0s52basz0xjz5-python3.7-jupyterlab-0.35.4.drv' failed with exit code 1
  `

  Any ideas?

  ### Steps to reproduce

  ` nix-shell -p python37Packages.jupyterlab`


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.104, NixOS, 19.09pre176329.d2602779281 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre176329.d2602779281"`
   - channels(cosmo): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: phpPackages: Wrap mkDerivation to prepend package names
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60155
updated_at: 2019-04-25 05:31:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This will make the file more consistent and easier to follow when we
  have a mixture of buildPecl (which already does this) and straight up
  regular derivations.

  This is a followup from #60099.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fetchurl/fetchzip fails based on file extension?
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/60157
updated_at: 2019-04-28 14:00:39
body:
  ```nix
  with import <nixpkgs> {};
  stdenv.mkDerivation {
     name = "test";
     src = fetchzip {
        name = "cs2d.zip";
        url = "http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266";
        sha256 = "1g66635m8zfsxdmg95c1xz72s6pam9w1myrjwk4dnw697dhpir1p";
        };
  }
  ```
  fails with 
  ```
  trying http://www.unrealsoftware.de/get.php?get=cs2d_1008_win.zip&p=1&cid=1266
  unpacking source archive /build/get.php?get=cs2d_1008_win.zip&p=1&cid=1266
  do not know how to unpack source archive /build/get.php?get=cs2d_1008_win.zip&p=1&cid=1266
  ```

  Also my understanding is maybe the result should be renamed to the `name` attribute?


state: open
title: Boot freezes on starting udev after 18.09 => 19.03 upgrade
user_login: rzetterberg
html_url: https://github.com/NixOS/nixpkgs/issues/60158
updated_at: 2019-05-19 19:00:44
body:
  ## Issue description

  I'm using an encrypted root partition and after entering my passphrase, selecting the first option in grub the boot freezes on loading udev - right before the second passphrase normally appears. 

  I'm not sure how to troubleshoot, since the boot freezes so early. If anyone have any ideas on how to debug, please let me know and I'll try. 

  ## Technical details

  **Computer:** HP x360 Envy 15"

  Encrypted partition for `/` with the following configuration: 

  ```nix
  # Do not modify this file!  It was generated by ‘nixos-generate-config’
  # and may be overwritten by future invocations.  Please make changes
  # to /etc/nixos/configuration.nix instead.
  { config, lib, pkgs, ... }:

  {
    imports =
      [ <nixpkgs/nixos/modules/installer/scan/not-detected.nix>
      ];

    boot.initrd.availableKernelModules = [ "nvme" "xhci_pci" "ahci" "usb_storage" "sd_mod" "rtsx_pci_sdmmc" "amdgpu" ];
    boot.kernelModules = [ "kvm-amd" ];
    boot.extraModulePackages = [ ];

    fileSystems."/" =
      { device = "/dev/disk/by-uuid/e9a6a904-cf3a-4f6e-ade6-52905f9a98ce";
        fsType = "ext4";
      };

    boot.initrd.luks.devices."crypted".device = "/dev/disk/by-uuid/f25a7f52-9ebd-4c30-83c6-d1f531b151f0";

    swapDevices = [ ];

    boot.kernelPackages = pkgs.linuxPackages_latest;

    # https://askubuntu.com/a/1053349
    boot.kernelParams = [
      "idle=nomwait"
      "pcie_aspm=off"
      # https://github.com/NixOS/nixpkgs/issues/44183#issuecomment-408669458
      "amdgpu.dc=1"
    ];
  }
  ```

  ```bash
  $ lsblk -f 
  NAME        FSTYPE      LABEL UUID                                 MOUNTPOINT
  nvme0n1                                                            
  └─nvme0n1p1 crypto_LUKS       f25a7f52-9ebd-4c30-83c6-d1f531b151f0 
    └─crypted ext4              e9a6a904-cf3a-4f6e-ade6-52905f9a98ce /
  ```


state: closed
title: jupyterlab: Fix build
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/60159
updated_at: 2019-04-25 08:03:07
body:
  The build was broken by updating the underlying python library.
  This is the quickfix.

  Fixes: ca67a7200cf ("python37Packages.jupyterlab_server: 0.2.0 -> 0.3.0")

  Closes #60154

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] other Linux distributions (centos7)
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dico: 2.7 -> 2.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60160
updated_at: 2019-04-28 01:00:45
body:
  ###### Motivation for this change

  2.9: http://lists.gnu.org/archive/html/info-gnu/2019-04/msg00009.html
  2.8: http://lists.gnu.org/archive/html/info-gnu/2019-02/msg00011.html

  also: pname, enable tests, remove stale TODO

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rush: 1.8 -> 1.9
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60161
updated_at: 2019-04-26 04:18:21
body:
  ###### Motivation for this change

  http://lists.gnu.org/archive/html/info-gnu/2019-04/msg00007.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jellyfin: 10.3.0 -> 10.3.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60162
updated_at: 2019-04-28 00:48:22
body:
  ###### Motivation for this change

  https://github.com/jellyfin/jellyfin/releases/tag/v10.3.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Seems to run? O:)

  ---


state: closed
title: python3Packages.pygobject3: 3.32.0 -> 3.32.1, pythonPackages.pycairo: 1.18.0 -> 1.18.1
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60164
updated_at: 2019-04-24 16:39:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  See commit msg for News/Changelogs

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tmuxPlugins.vim-tmux-navigator: fix runtimepath
user_login: NickHu
html_url: https://github.com/NixOS/nixpkgs/pull/60165
updated_at: 2019-04-28 15:03:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I was using home-manager to manage my tmux configuration when I noticed that the vim-tmux-navigator plugin didn't seem to work.

  After some investigation, I found that the generated runtimepath for the vim-tmux-navigator plugin was broken:

  ```
  $ nix repl
  Welcome to Nix version 2.2.2. Type :? for help.

  nix-repl> :l <nixpkgs>
  Added 10237 variables.

  nix-repl> pkgs.tmuxPlugins.vim-tmux-navigator.rtp
  "/nix/store/kad7bgna5f6halc84xc793y9c8602iy2-tmuxplugin-vim-tmux-navigator/share/tmux-plugins/vim-tmux-navigator/vim_tmux_navigator.tmux"
  ```

  This file doesn't exist, but `/nix/store/kad7bgna5f6halc84xc793y9c8602iy2-tmuxplugin-vim-tmux-navigator/share/tmux-plugins/vim-tmux-navigator/vim-tmux-navigator.tmux` does. <s>I tracked down the culprit, which was a call to `builtins.replaceStrings` changing the `-` for `_` and removed it; I have no idea why it's there. Perhaps @kalbasit can explain?</s> I added a `rtpFilePath` for vim-tmux-navigator to fix this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: stdenv, treewide: Better configure platforms
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/60166
updated_at: 2019-05-12 15:09:24
body:
  ###### Motivation for this change

  1. Use @lheckemann's trick of an env var, so we don't screw up non-autoconf.
  2. Always pass `build_alias`, so that building `x86_32` on `x86_64`, or `aarch32` on `aarch64`, etc should work.
  3. Remove all `configurePlatforms = [ ];` now that they are not needed.

  CC @Volth, can you confirm this mostly works? We can combine with any package-specific fixes needed from https://github.com/NixOS/nixpkgs/pull/60131.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: taskopen: init at 1.1.4
user_login: winpat
html_url: https://github.com/NixOS/nixpkgs/pull/60167
updated_at: 2019-04-26 04:10:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rust-bindgen: 0.42.2 -> 0.49.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/60168
updated_at: 2019-04-26 11:59:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `rust-bindgen` to the latest release.
  https://github.com/rust-lang/rust-bindgen/releases/tag/v0.49.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix kernel oops on boot due to bug in i2c driver.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60172
updated_at: 2019-04-26 00:26:27
body:
  https://github.com/NixOS/nixpkgs/issues/60126
  https://lkml.org/lkml/2019/4/24/1123

  The patch should be removed in the next round of stable releases because the fix should be included.

  ###### Motivation for this change

  Kernel crash on boot, see https://github.com/NixOS/nixpkgs/issues/60126
  I have verified that it fixes the issue with kernel 4.19.36. I added the patch for 4.14 and 4.9 as well because they are affected (they have the broken patch applies without the fix), but I only checked the build goes past the patch application.

  This is pretty critical. An alternative to merging this would be to rollback the last kernel updates.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex: 1.15.3.876 -> 1.15.4.994
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/60173
updated_at: 2019-05-10 18:44:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to latest version.

  This includes the changes from #56565 which causes merge conflicts otherwiese.

  Sucessfully running on my server.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


