# issues

state: closed
title: [18.09] containerd: 1.1.2 -> 1.1.7
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/59224
updated_at: 2019-04-09 20:37:09
body:
  ###### Motivation for this change

  Bump a few security fix version :sweat_smile: See release notes for all:
  - [1.1.3 release notes](https://github.com/containerd/containerd/releases/tag/v1.1.3)
  - [1.1.4 release notes](https://github.com/containerd/containerd/releases/tag/v1.1.4)
  - [1.1.5 release notes](https://github.com/containerd/containerd/releases/tag/v1.1.5)
  - [1.1.6 release notes](https://github.com/containerd/containerd/releases/tag/v1.1.6)
  - [1.1.7 release notes](https://github.com/containerd/containerd/releases/tag/v1.1.7)

  cc @offlinehacker @grahamc 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cc-wrapper: make machine configuration configurable
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59225
updated_at: 2019-04-25 01:56:27
body:
  It is useful to make these dynamic and not bake them into gcc. This
  means we don’t have to rebuild gcc to change these values. Instead, we
  will pass cflags to gcc based on platform values. This was already
  done hackily for android gcc (which is multi-target), but not for our
  own gccs which are single target.

  To accomplish this, we need to add a few things:

  - add ‘arch’ to cpu
  - add NIX_CFLAGS_COMPILE_BEFORE flag (goes before args)
  - set -march everywhere
  - set mcpu, mfpu, mmode, and mtune based on targetPlatform.gcc flags
  - on arm32, set mfloat-abi based on targetPlatform.parsed.abi.float

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [staging-19.03] containerd: 1.2.5 -> 1.2.6
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/59226
updated_at: 2019-04-09 19:47:42
body:
  ###### Motivation for this change

  Bump containerd to latest release with security fixes : [1.2.6 release notes](https://github.com/containerd/containerd/releases/tag/v1.2.6)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [staging-19.03] runc: 1.0.0-rc6 -> 1.0.0-rc7
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/59227
updated_at: 2019-04-09 19:47:44
body:
  ###### Motivation for this change

  Bump to latest rc release with security fixes, see [release notes](https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc7) (mainly CVE-2019-5736)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-xbuild: init at 0.5.7
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59228
updated_at: 2019-04-10 10:05:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  A tool helps people to automatically cross-compile the sysroot crates core, compiler_builtins, and alloc.

  [https://crates.io/crates/cargo-xbuild](https://crates.io/crates/cargo-xbuild)
  [https://github.com/rust-osdev/cargo-xbuild](https://github.com/rust-osdev/cargo-xbuild)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] flatpak: 1.0.5 -> 1.0.8
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59229
updated_at: 2019-04-10 10:55:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update flatpak to fix some security issues.


state: closed
title: tahoe-lafs: clean up inputs
user_login: exarkun
html_url: https://github.com/NixOS/nixpkgs/pull/59231
updated_at: 2019-04-11 20:22:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  make tahoe-lafs build on aarch64

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libsodium: 1.0.16 -> 1.0.17
user_login: dnaq
html_url: https://github.com/NixOS/nixpkgs/pull/59233
updated_at: 2019-04-16 06:05:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fluentd: 1.2.3 -> 1.4.2
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59234
updated_at: 2019-04-10 10:47:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Revert "resilio-sync: 2.6.2 -> 2.6.3"
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/59235
updated_at: 2019-04-09 21:54:46
body:
  Reverts NixOS/nixpkgs#58871

  Hash for i686-linux has not been updated.
  PR #57728 should be merged instead.


state: closed
title: flightgear & simgear: 2018.2.2 -> 2018.3.1
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59236
updated_at: 2019-04-10 10:10:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/pull/52020

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trellis, yosys, nextpnr: update
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/59237
updated_at: 2019-04-23 20:03:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updates trellis, yosys and nextpnr to their latest commits. This fixes some bugs with the ECP5 and adds new features such as LPF frequency constraints and the HeAP placer.

  I also enabled the nextpnr GUI by default, as it works fine for me if I run it with nixGL (like any Nix package that uses OpenGL).

  ###### Things done

  Tested building and running a VexRiscv based design on an ECP5 85k-5G.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnomeExtensions.appindicator: 23.1 -> 28
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/59239
updated_at: 2019-04-10 03:55:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update the GNOME appindicator support extension to the latest version.
  See the GitHub page for the full changelog:
  https://github.com/ubuntu/gnome-shell-extension-appindicator/compare/v23...v28

  Targeting `staging` with this PR until GNOME 3.32 lands in `master`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tk: use aqua backend on darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59240
updated_at: 2019-04-10 02:50:39
body:
  Most users don’t have xquartz, so let’s use the default window system
  for macOS.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Clang 8 fails to build on MacOS Mojave
user_login: sheeldotme
html_url: https://github.com/NixOS/nixpkgs/issues/59241
updated_at: 2019-05-08 03:19:37
body:
  ## Issue description

  Building clang_8 results in:

  /private/var/folders/f6/g6dgxl4j5_g8p5rq2t1plqnw0000gn/T/nix-build-clang-8.0.0.drv-0/clang/tools/extra/clangd/xpc/../xpc/Conversion.h:14:10: fatal error: 'xpc/xpc.h' file not found
  #include <xpc/xpc.h>
           ^~~~~~~~~~~
  1 error generated.

  ### Steps to reproduce

  1. run: nix-env -iA nixpkgs.clang_8
  2. wait until approximately 88%

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.1`
   - channels(sheelpatel): `"nixpkgs-19.09pre174594.0c0954781e2"`
   - nixpkgs: `/Users/sheelpatel/.nix-defexpr/channels/nixpkgs`


state: closed
title: deepin.deepin-screenshot: init at 4.1.8
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59242
updated_at: 2019-04-13 23:17:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [deepin-screenshot](https://github.com/linuxdeepin/deepin-screenshot), a easy-to-use screenshot tool for Deepin Desktop Environment.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: deepin.dde-dock: init at 4.9.8
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59244
updated_at: 2019-05-02 19:20:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [dde-dock](https://github.com/linuxdeepin/dde-dock), a dock for Deepin Desktop Environment.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: initrd cannot be cross-compiled due to pkgs.writeShellScriptBin usage
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/issues/59245
updated_at: 2019-04-18 13:03:32
body:
  ## Issue description

  The current implementation of pkgs.writeShellScriptBin generates a shell script to be executed on the target, not the host. Looking through most of the usage in nixpkgs, it all seems fine except for the call site in nixos/modules/system/boot/stage-1.nix

  I have a local patch replacing it in stage-1.nix with pkgs.writeTextFile { executable = true; ... } but I'm not sure if there's a better solution for this.

  @matthewbauer @illegalprime  relevant to your interests, maybe.

  ### Steps to reproduce

  Try to cross-compile a NixOS initrd.


state: closed
title: crawl: 0.22.1 -> 0.23.2
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59246
updated_at: 2019-04-11 23:18:50
body:
  ###### Motivation for this change

  Updating to latest version.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.udisks2-qt5: init at 0.0.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59247
updated_at: 2019-04-10 10:31:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [udisks2-qt5](https://github.com/linuxdeepin/udisks2-qt5), UDisks2 D-Bus interfaces binding for Qt5.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: pythonPackages.sqlparse: 0.2.4 -> 0.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59248
updated_at: 2019-05-31 06:03:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: networkmanager: 1.14.6 -> 1.16.0
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/59249
updated_at: 2019-04-23 19:39:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Version bump. this version in particular adds wireguard support which is terrific.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: networkmanager-l2tp: 1.2.12 -> 1.7.0-dev
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/59250
updated_at: 2019-04-10 05:16:37
body:
  I don't know what's the nixos policy regarding this release: it follows gnome rules and thus the odd version number indicates an unstable release.
  Also the homepage contains a license warning https://github.com/nm-l2tp/NetworkManager-l2tp so it might be best to wait for an openssl 3 release before actually merging.
  Meanwhile this is here for those who want to try and to prevent duplicate work. It works for me.
  The closure size should increase as the package now requires openssl and nss.

  Among the new features:
  Adds user or machine TLS certificate support with L2TP/IPsec VPN servers cf:
  https://github.com/nm-l2tp/NetworkManager-l2tp/blob/master/NEWS

  This check has been added in https://github.com/nm-l2tp/NetworkManager-l2tp/commit/56e82afe1fa4193ac60a93b7724cd9cc65797af1,
      i.e. l2tp version 1.7.0.

  The source is not the exact 1.7.0 since a commit was added afterwards to work around nixos limitations.:
  https://github.com/nm-l2tp/NetworkManager-l2tp/commit/8a72e8f57f61083a8e0663103bb8c1394d93439a

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: home-assistant no longer automatically includes proper dependencies
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/59251
updated_at: 2019-04-10 15:02:22
body:
  ## Issue description

  On 0.91.1, many components have stopped working as the required python dependencies are not being pulled in correctly. Manually adding them to ```extraPackages``` in the package override makes things work again.

  Here are some examples:

  ```
  Error setting up platform unifi

  Traceback (most recent call last):
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/components/device_tracker/__init__.py", line 177, in async_setup_platform
      platform.get_scanner, hass, {DOMAIN: p_config})
    File "/nix/store/gbwx5sc4w0i0ipnmsa0nsk88svs983vl-python3-3.7.2/lib/python3.7/concurrent/futures/thread.py", line 57, in run
      result = self.fn(*self.args, **self.kwargs)
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/components/unifi/device_tracker.py", line 66, in get_scanner
      from pyunifi.controller import Controller, APIError
  ModuleNotFoundError: No module named 'pyunifi'

  Error while setting up platform onkyo

  Traceback (most recent call last):
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 126, in _async_setup_platform
      SLOW_SETUP_MAX_WAIT, loop=hass.loop)
    File "/nix/store/gbwx5sc4w0i0ipnmsa0nsk88svs983vl-python3-3.7.2/lib/python3.7/asyncio/tasks.py", line 416, in wait_for
      return fut.result()
    File "/nix/store/gbwx5sc4w0i0ipnmsa0nsk88svs983vl-python3-3.7.2/lib/python3.7/concurrent/futures/thread.py", line 57, in run
      result = self.fn(*self.args, **self.kwargs)
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/components/onkyo/media_player.py", line 100, in setup_platform
      import eiscp
  ModuleNotFoundError: No module named 'eiscp'

  darksky: Error on device update!

  Traceback (most recent call last):
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/helpers/entity_platform.py", line 261, in _async_add_entity
      await entity.async_device_update(warning=False)
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 379, in async_device_update
      await self.hass.async_add_executor_job(self.update)
    File "/nix/store/gbwx5sc4w0i0ipnmsa0nsk88svs983vl-python3-3.7.2/lib/python3.7/concurrent/futures/thread.py", line 57, in run
      result = self.fn(*self.args, **self.kwargs)
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/components/darksky/weather.py", line 197, in update
      self._dark_sky.update()
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/util/__init__.py", line 224, in wrapper
      result = method(*args, **kwargs)
    File "/nix/store/mp3vi175h7dfcvgkd1n45gk3wlrhyhjx-homeassistant-0.91.1/lib/python3.7/site-packages/homeassistant/components/darksky/weather.py", line 223, in update
      import forecastio
  ModuleNotFoundError: No module named 'forecastio'
  ```

  There are several more.

  This is when deploying 0.91.1 from unstable on 19.03


state: closed
title: cocoapods-beta: init at 1.7.0.beta.3
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/59252
updated_at: 2019-04-17 17:47:16
body:
  ###### Motivation for this change
  cocoapods-beta is an alternative attribute for the cocoapods package that provides the latest beta instead of the stable version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Get Android cross working again
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59253
updated_at: 2019-04-10 14:48:39
body:
  Should be backported to 19.03

  Gets the android cross stuff working with the new ndk.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aws-vault: 4.3.0 -> 4.5.1
user_login: andrew-d
html_url: https://github.com/NixOS/nixpkgs/pull/59254
updated_at: 2019-04-10 17:57:32
body:
  ###### Motivation for this change
  aws-vault version 4.5.0 adds support for `pass` (a.k.a. password-store), which is a feature that I'd love to use on NixOS.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  r? @zimbatm (maintainer)


state: closed
title: python3Packages.WazeRouteCalculator: 0.7.2 -> 0.9.0 and pyupdate: 1.3.5 -> 1.3.6
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/59255
updated_at: 2019-04-25 02:48:58
body:
  ###### Motivation for this change

  These 2 are lumped together as they are both only needed by home assistant.

  Cc: @dotlambda 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: quaternion-git: init at 0.0.9.4-rc3
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/59256
updated_at: 2019-04-28 13:51:52
body:
  ###### Motivation for this change

  The whole matrix ecosystem is evolving quite quickly, so we have to introduce both the 0.4 and 0.5 releases of libqmatrixclient in order to be able to try out the new quaternion versions.

  The default library version stays at 0.4.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Python package build input executables not in PATH in development mode shell
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/59257
updated_at: 2019-06-08 09:27:03
body:
  ## Issue description

  Executables of build inputs aren't available in "development mode" nix shell for a Python package.


  ### Steps to reproduce

  I have a directory with the following two files only:

  `setup.py`:

  ```python
  if __name__ == "__main__":
      from setuptools import setup, find_packages
      setup(
          packages = find_packages(),
          name     = "test",
          version  = "0.0.0",
      )
  ```

  `shell.nix`:

  ```nix
  let
    pkgs = import <nixpkgs> {};
  in pkgs.python3Packages.buildPythonPackage rec {
    pname = "test";
    version = "0.0.0";
    src = ./.;
    propagatedBuildInputs = with pkgs.python3Packages; [ jupyterhub pkgs.wget ];
    doCheck = false;
  }
  ```

  I then run `nix-shell --pure` in this directory. In the nix shell, I have neither `jupyterhub` executable nor `wget` executable in PATH.
  I wrote `shell.nix` according to these instructions:

  https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#development-mode

  The package indeed seems to be installed as `pip install -e` I suppose, but the executables of the build inputs aren't in `PATH` in that shell.


  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.33, NixOS, 19.09pre174426.acbdaa569f4 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre174426.acbdaa569f4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: tahoe-lafs: 1.13.0 -> unstable-2019-04-08
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/59258
updated_at: 2019-04-26 13:07:22
body:
  ###### Motivation for this change

  The new version has a lot of improvements and is required to get Gridsync to work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Merge simple updates
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/59259
updated_at: 2019-04-10 20:25:58
body:
  Merges multiple PRs into one. I reviewed all of them. All of them are simple updates (as in "hash and sha update", modulo one "doCheck = false" removal).

  ###### Motivation for this change

  * Closes #59236
  * Closes #59233
  * Closes #59220
  * Closes #59218
  * Closes #59248
  * Closes #59221

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport elk: 6.5.1 -> 6.7.1 to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59261
updated_at: 2019-04-14 13:58:11
body:
  (cherry picked from commit 7062a073e809c2cc75e0cc8b2cb3f6c747e5c2b4)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  @samueldr @lheckemann I would like to use the latest Elasticsearch on the upcoming 19.03 release. This is a backwards compatible upgrade so it should be safe to merge.

  ###### Things done

  @GrahamcOfBorg test elk.ELK-6

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport prometheus2 to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59262
updated_at: 2019-04-16 07:23:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I would like to use Prometheus-2 on the upcoming 19.03 release. @jbgi also [expressed](https://github.com/NixOS/nixpkgs/pull/58255#issuecomment-481160092) a desire for this.

  This backports PRs https://github.com/NixOS/nixpkgs/pull/58255, https://github.com/NixOS/nixpkgs/pull/59175 and https://github.com/NixOS/nixpkgs/pull/59182 to `release-19.03`.

  It also includes a note about this in the 19.03 release notes.

  @samueldr @lheckemann this mainly involves the addition of the new `services.prometheus2` module. However, there's one minor backwards incompatibility: the option `services.prometheus.dataDir` is now required to have `/var/lib/` as a prefix. Note that it defaulted and still defaults to `/var/lib/prometheus`. This is also documented in the 19.03 release notes. I think it's safe to merge. 


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dune: 1.8.2 -> 1.9.0
user_login: Zimmi48
html_url: https://github.com/NixOS/nixpkgs/pull/59263
updated_at: 2019-04-16 13:16:36
body:
  ###### Motivation for this change

  Package update. Personal motivation: Dune 1.9.0 introduces Coq support.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: alertmanager: 0.15.3 -> 0.16.2
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59264
updated_at: 2019-04-10 14:45:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/prometheus/alertmanager/releases/tag/v0.16.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: repology: fix homepage for a few packages - nothing else
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/59265
updated_at: 2019-04-25 02:48:48
body:
  ###### Motivation for this change

  repology was showing a few errors for packages I maintain - think of it as spring cleaning.

  No other changes.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nmapsi4: 0.5.0-alpha1 -> 0.4.80-20180430
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/59266
updated_at: 2019-04-25 02:48:53
body:
  ###### Motivation for this change

  0.5.0-alpha1 was released years ago but that actual latest test version (stable doesn't work with qt5) makes things work with recent qt5 as well as replaces qtwebkit with qtwebengine, so we definitely want that.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: glibc.static breaks gcc
user_login: Lassulus
html_url: https://github.com/NixOS/nixpkgs/issues/59267
updated_at: 2019-04-10 15:37:24
body:
  ## Issue description

  having `glibc.static` in buildInputs produces broken binaries if gcc is called without -static
  calling the binary results in a segfault:
  ```
  segmentation fault  /nix/store/bdgyzm53lbslwfx4q41n3wni3m63hlij-test
  ```

  ### Steps to reproduce

  ```
  { pkgs }: let

    hello_c = pkgs.writeText "hello.c" ''
      int main() {
        return 0;
      }
    '';

  in pkgs.stdenv.mkDerivation {
    name = "test";
    buildInputs = with pkgs; [ glibc.static gcc ];
    phases = [ "buildPhase" ];
    buildPhase = ''
      gcc ${hello_c} -o $out
      $out
    '';
  }
  ```

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, stockholm/NixOS, 19.04.git.2dbdf0185-dirty@mors/19.03.git.67bc63f (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `""`
   - channels(lass): `""`
   - nixpkgs: `/var/src/nixpkgs`


state: open
title: linux: kernel: Add kernels with rt patchset
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/59268
updated_at: 2019-05-20 16:31:47
body:
  This patch adds kernels with the "realtime" patchset.

  ###### Motivation for this change

  Having the realtime kernels in nixpkgs.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I did not test-build this because this may take a rather long time on my machine and I want some feedback first.

  As this was inspired by the [musnix](https://github.com/musnix/musnix/) project, I ping them here:

  @henrytill 
  @magnetophon 

  I imported the kernels into the `all-packages.nix` as an extra attribute to not spam the main namespace. I'm not sure whether this is wanted, but I guess people who do care find what they need and people who do not care are not bothered by that, right?


state: closed
title: Revert "spotify: 1.0.96.181.gf6bc1b6b-12 -> 1.1.0.237.g378f6f25-11"
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/59269
updated_at: 2019-04-10 19:30:40
body:
  This reverts commit ea87db215304c948484023f3a3be330d26c24650.

  See #57800

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/prometheus/alertmanager: use DynamicUser instead of nobody
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59270
updated_at: 2019-04-10 20:56:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  See issue #55370.

  @arianvp care to review?

  The following which includes a test for `alertmanager` passes but I'll ask ofborg to confirm:

  `nix-build nixos/release.nix -A tests.prometheus.x86_64-linux`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-ethereum: 1.8.25 -> 1.8.26
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59272
updated_at: 2019-04-11 04:41:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update go-ethereum to the latest release.

  [https://github.com/ethereum/go-ethereum/releases/tag/v1.8.26](https://github.com/ethereum/go-ethereum/releases/tag/v1.8.26)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: snakemake: 5.2.2 -> 5.4.4
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/59273
updated_at: 2019-04-11 12:41:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @renatoGarcia @Helkafen


state: closed
title: [backport] renpy: 7.1.3 -> 7.2.0
user_login: erosennin
html_url: https://github.com/NixOS/nixpkgs/pull/59274
updated_at: 2019-04-11 18:05:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Ren'Py build is currently broken in release-19.03 due to the failing pygame_sdl2 dependency:

  https://hydra.nixos.org/build/91927653
  https://hydra.nixos.org/build/91927830

  This has already been fixed in master by upgrading renpy and pygame_sdl2 to newer versions. Let's backport that.

  cc #56826

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: crawl: 0.22.1 -> 0.23.2
user_login: anderspapitto
html_url: https://github.com/NixOS/nixpkgs/pull/59275
updated_at: 2019-04-10 20:22:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add mirror for Flash Player plugin files
user_login: zookatron
html_url: https://github.com/NixOS/nixpkgs/issues/59276
updated_at: 2019-04-10 19:44:23
body:
  ## Issue description

  It appears that every time Adobe releases a new version of the Flash Player NPAPI plugin, the old versions are deleted from their server. This causes the NixOS stable channels to suddenly stop building any configuration that includes the `pkgs/applications/networking/browsers/mozilla-plugins/flashplayer` derivations because it can't download the binary files from Adobe. This appears to happen [pretty frequently](https://github.com/NixOS/nixpkgs/issues?utf8=%E2%9C%93&q=Flash+player) and every time it happens it's a really annoying experience where I either need to manually change my version of that package that I'm using or wait for a backport to fix it on the stable channel.

  It would be really great if we could have some kind of mirror for these files so these updates by Adobe don't randomly break system builds before the flashplayer derivations are patched. Frankly I don't really know what would be involved in setting something like this up correctly for NixOS, but I thought it might be good to start off a discussion about how this is affecting the user experience on NixOS.

  ### Steps to reproduce

  1. Add to `etc/nixos/configuration.nix`
  ```
  environment.systemPackages = [ ... pkgs.firefox ... ];
  nixpkgs.config = { ... firefox.enableAdobeFlash = true; ... };
  ```

  2. Wait for Adobe to update Flash Player plugin

  3. `nixos-rebuild build` and get error `error: cannot download flash_player_npapi_linux.x86_64.tar.gz from any mirror`

  ### Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.32, NixOS, 19.03beta172025.91fa6990b25 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: tmux module: environment-variable setup problem
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/issues/59277
updated_at: 2019-04-24 05:00:22
body:
  ## Issue description
  TMUX_TMPDIR is no longer correctly set up for me via this line:
  https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/tmux.nix#L180

  It appears the fallback branch is taken due to some semi-recent change (any info on this appreciated).
  The fallback looks wrong however, the set-environment is generated like
  `export TMUX_TMPDIR="${XDG_RUNTIME_DIR:-"/run/user/\$(id -u)"}"` which results in 
  `/run/user/$(id -u)` actually being set (that is, not interpolating because of the \\).

  ### Steps to reproduce
  unset / don't have `XDG_RUNTIME_DIR` set, and try to use tmux.

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.09.git.de88a59 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre174426.acbdaa569f4"`
   - channels(averell): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: netbsd.mkDerivation: fix darwin build
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/59278
updated_at: 2019-04-11 01:41:07
body:
  Fixes build of netbsd.make on darwin

  Fixes: aab8c7ba437d ('netbsd: add cross target')
  Resolves: #59141

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.nixpkgs-pytools: init at 1.0.0
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/59279
updated_at: 2019-04-11 16:31:01
body:
  ###### Motivation for this change

  nixpkgs-pytools has been added to the nix-community! https://github.com/nix-community/nixpkgs-pytools

  Adding a release to nixpkgs to make it easier to use.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc: @makefu 


state: closed
title: mkchromecast: init at 5872a246
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/59280
updated_at: 2019-04-11 16:08:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This adds the mkchromecast package. i have tested this using:

  ```
  nix-build -A pkgs.mkchromecast .
  result/bin/mkchromecast --port 8080 --video --screencast --resolution 720p
  ```

  And it would show my screen on my TV after a few moments.

  The upgrade of pychromecast was not needed strictly speaking, but it seemed appropriate to enable all functionality of mkchromecast.

  There wasn't a recent release, but that's something that hopefully will come (https://github.com/muammar/mkchromecast/issues/244).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hpl: init at 2.3
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/59281
updated_at: 2019-04-12 22:13:18
body:
  ###### Motivation for this change
  Add the linpack benchmark package (linear algebra benchmark for distributed parallel computers)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: When packaging rubygems, prune git repos from the bundler cache
user_login: burke
html_url: https://github.com/NixOS/nixpkgs/pull/59284
updated_at: 2019-04-11 21:04:36
body:
  When packaging rubygems, prune git repos from the bundler cache:

  There's [a comment](https://github.com/NixOS/nixpkgs/blob/aa004a564954be600b16dd02d05dcb0330b6513c/pkgs/development/ruby-modules/gem/default.nix#L150-L153) not far above this change indicating that it's important to *not* purge the cache, but consider this case:

      gem 'rails', git: 'https://github.com/rails/rails.git'

  Since rails depends on several other gems from its own repository, this results in the Gemfile.lock stanza:

      GIT
        remote: https://github.com/rails/rails.git
        revision: c2093cdf8e48ccc4211195c3523319a1767a205a
        specs:
          actioncable (6.0.0.beta3)
            ...(some dependents)...
          actionmailbox (6.0.0.beta3)
            ...(some dependents)...
          actionmailer (6.0.0.beta3)
            ...(some dependents)...
          ...(and 10 more)...

  Rails is a 200MB+ repo, so when building this, it results in 2.6GB+ of space usage. But even more importantly, nixpkgs will link everything under `lib/` currently, which includes, in this case, the redundant copies of `$out/${ruby.gemPath}/cache/bundler/git/rails-<sha>`:

      these derivations will be built:
        /nix/store/rxsi3i9bkmyw93h5xn99mhw5il59w7sx-your-package.drv
      building '/nix/store/rxsi3i9bkmyw93h5xn99mhw5il59w7sx-your-package.drv'...
      collision between `/nix/store/5qvwx0qyhx19vswg0cv3zdzn18qc8fn7-ruby2.5.5-actiontext-6.0.0.beta3/lib/ruby/gems/2.5.0/cache/bundler/git/rails-fcf0202857b07db1a0f6220dae5ca99319ca0f32/objects/info/packs' and `/nix/store/hybin7vdghvb81sb3j9g4yyym6j2wkh3-ruby2.5.5-actioncable-6.0.0.beta3/lib/ruby/gems/2.5.0/cache/bundler/git/rails-fcf0202857b07db1a0f6220dae5ca99319ca0f32/objects/info/packs'
      builder for '/nix/store/rxsi3i9bkmyw93h5xn99mhw5il59w7sx-your-package.drv' failed with exit code 255
      error: build of '/nix/store/rxsi3i9bkmyw93h5xn99mhw5il59w7sx-your-package.drv' failed

  Long story short, keeping the whole git repo around feels pathological from the get-go, but I'm not sure how to resolve this conflict at all without pruning it. This is distinctly different from a gem cache where a `*.gem` can only ever correspond to one installed gem.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  I haven't actually even figured out how to try this yet to make sure it does what I think it does: I'm interested in discussing whether this is a reasonable change to do at a conceptual level.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Related: https://github.com/bundler/bundler/issues/3327


state: open
title: Build for toolchains for CloudABI / WASI
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/issues/59285
updated_at: 2019-04-11 17:04:45
body:
  https://cloudabi.org/ is a cap-safe "censored POSIX". (https://lwn.net/Articles/674770/ is a good secondary source.) It would be nice if Nixpkgs could cross compiler to this platform. While mainstream software has been ported to run on this platform (https://github.com/NuxiNL/cloudabi-ports), since it is a not standard Unixish, packages shouldn't be expected to work out of the box. Therefore Nixpkgs ought to support it as it does embedded platforms: building toolchains should work (though they aren't cached), but nothing else is supported.

  I'm mainly interested in this so we can cross compile [a ported] Nix to that platform (https://github.com/NixOS/nix/issues/2759) so various experiments can take place.


state: closed
title: afl-qemu: remove unnecessary build dependencies
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59286
updated_at: 2019-04-12 09:29:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This simply removes all the unnecessary build dependencies for the afl-patched qemu. It looks like it was initially a copy of the regular qemu package, but afl only uses qemu in a very minimal manner (e.g. it doesn't even use system mode). So I trimmed this down to what seems to be the bare minimum with a process of trial and error.

  Also added myself to the maintainers list for `afl` as I've tinkered with this package quite a bit now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: netdata temperature plugin broken
user_login: Luis-Hebendanz
html_url: https://github.com/NixOS/nixpkgs/issues/59287
updated_at: 2019-07-03 14:56:07
body:
  ## Issue description

  The temperature plugin is broken called: sensors
  The reason is located in the first few lines of 

  > libexec/netdata/python.d/python_modules/third_party/lm_sensors.py

  to be exact here:

  ```from ctypes import *
  import ctypes.util

  _libc = cdll.LoadLibrary(ctypes.util.find_library("c"))
  _libc.free.argtypes = [c_void_p]
  _hdl = cdll.LoadLibrary(ctypes.util.find_library("sensors"))
  ```

  It searches for the libc library and the sensors c library with ctypes which doesn't succeed.
  The fix is to define an environment variable in the service called LD_LIBRARY_PATH that points to the needed library directories. For more information look here:
  https://docs.python.org/3.7/library/ctypes.html#finding-shared-libraries

  ## Possible solution
  Not tested but this could resolve the problem:
  ```
  serviceConfig = {
  Environment="LD_LIBRARY_PATH=${pkgs.lm_sensors}/lib:${pkgs.libgcc}/lib:$LD_LIBRARY_PATH";

  };

  ```


state: open
title: nextcloud acme bot doesn't work
user_login: Luis-Hebendanz
html_url: https://github.com/NixOS/nixpkgs/issues/59288
updated_at: 2019-06-11 20:11:46
body:
  ## Issue description
  The acme bot doesn't work with the nextcloud service . The reason is the nginx rule defined here:
  https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/web-apps/nextcloud.nix#L434
  It denys access to all folders prefixed with a dot. And it is a rule that has a higher binding value even if it comes after the other rules because of the ~ ^ at the beginning of the rule.
  You could fix the rule in nextcloud or make the default rule of the acme bot get prefixed with ~ ^ which I think is better.


state: closed
title: sh: ps: command not found on darwin
user_login: sheeldotme
html_url: https://github.com/NixOS/nixpkgs/issues/59289
updated_at: 2019-04-11 00:55:41
body:
  ## Issue description

  `sh: ps: command not found` when using CMake derivation.  Possible regression of: https://github.com/NixOS/nixpkgs/issues/2561

  ### Steps to reproduce

  `git clone https://github.com/sheeldotme/reproduction-nix-59289.git`
  `cd reproduction-nix-59289`
  `nix-build`

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.5.0, macOS 10.14.4`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.1`
   - channels(sheelpatel): `"nixpkgs-19.09pre174594.0c0954781e2"`
   - nixpkgs: `/Users/sheelpatel/.nix-defexpr/channels/nixpkgs`


state: closed
title: vocal: 2.3.0 -> 2.4.0
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/59290
updated_at: 2019-04-11 13:45:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Vocal has a new release featuring a number of bug fixes and new features. See the full changelog at https://github.com/needle-and-thread/vocal/releases/tag/2.4.0.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: remove -msse2 flag from haskell vector for current GHC head onwards
user_login: cartazio
html_url: https://github.com/NixOS/nixpkgs/issues/59291
updated_at: 2019-04-24 14:30:46
body:
  ## Issue description
  so currently in 
  nixpkgs theres
  ```
  /.nix-defexpr/channels/nixpkgs/pkgs/development/haskell-modules/configuration-common.nix:
    149    # sse2 flag due to https://github.com/haskell/vector/issues/47.
    150    # dontCheck due to https://github.com/haskell/vector/issues/138
    151:   vector = dontCheck (if pkgs.stdenv.isi686 then appendConfigureFlag super.vector "--ghc-options=-msse2" else super.vector);
    152  
  ```
  a patch I wrote thats now in ghc master  as of today, https://gitlab.haskell.org/ghc/ghc/commit/42504f4a575395a35eec5c3fd7c9ef6e2b54e68e, 

  removes x87 support from ghc, and thus on all intel platforms sse2 support is assumed! 

  so future ghc releases and future nix snapshots of head neednt set the flag, because its always there already. (i did set it up so that it wont complain/error out if you still set the flag, but seems like good to remove over time). 

  this is an FYI, because i'm not sure how one would rearrange the applicable nix code for this..


state: closed
title: pgrouting: init at 2.6.2
user_login: steve-chavez
html_url: https://github.com/NixOS/nixpkgs/pull/59292
updated_at: 2019-04-16 02:23:13
body:
  ###### Motivation for this change
  pgRouting extends the PostGIS / PostgreSQL geospatial database to provide geospatial routing functionality.

  I mostly copied the equivalent archlinux package instructions https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=pgrouting. 

  If there's a more idiomatic way to build the package in nix please let me know.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: qbittorrent: add python as a runtime dependency for tracker search
user_login: MetaDark
html_url: https://github.com/NixOS/nixpkgs/pull/59293
updated_at: 2019-04-12 08:38:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This change wraps qbittorrent with python as a run-time dependency. This ensures that python is included in the resulting closure for tracker search support.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (aarch64_linux, built with guiSupport = false)
     - [x] Arch Linux (x86_64-linux)
     - [ ] macOS
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
     - [x] qbittorrent-nox (requires building with guiSupport = false)
     - [x] qbittorrent
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
     - 387 224 920  bytes &rarr; 451 423 776 bytes
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.pytest-watch: init at 4.2.0
user_login: sveitser
html_url: https://github.com/NixOS/nixpkgs/pull/59295
updated_at: 2019-06-17 06:00:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [pytest-watch](https://github.com/joeyespo/pytest-watch).

  Tested commands `ptw` and `pytest-watch` successfully with python2 and 3.7 on a small test project.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: keepassxc: 2.3.4 -> 2.4.0
user_login: Quiark
html_url: https://github.com/NixOS/nixpkgs/pull/59296
updated_at: 2019-04-11 15:15:42
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskell-generic-builder: disable library-for-ghci by default
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/59297
updated_at: 2019-04-12 12:53:23
body:
  This commit disables the library-for-ghci flag passed to `Setup configure` in the Haskell generic-builder.nix file.

  This stops HSfoo.o files from being built.  Building HSfoo.o files cause doctest to take an extremely long time to load dependencies when running.

  This is a follow-up from https://github.com/NixOS/nixpkgs/pull/58743.  There is more explanation on that PR.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  It is debatable as to whether or not we should make this change.

  The reasons in favor of making this change:

  - Doctest now works for large packages with many dependencies without taking a lot of time to run.  This has been a problem for us at work.  I've also run into this personally with the Haskell package Termonad: https://github.com/cdepillabout/termonad/issues/15
  - It appears that both `stack` and `cabal` use `--disable-library-for-ghci` by default.  It makes sense that nixpkgs would follow this.
  - Disabling `library-for-ghci` reduces the build times very slightly.  The resulting output takes up slightly less disk space.  (I don't think this is a particularly compelling reason though.)

  The reasons against making this change:

  - Maybe someone is depending on `--enable-library-for-ghci` being used?  Maybe disabling it would break their build/workflow somehow?  I have done a bunch of searching around this issue trying to figure out what is going on here, and I haven't found any reference to anyone specifically enabling or disabling `library-for-ghci`, so I would doubt anyone is actively depending on it (although there is a possibility).
  - The GHC documentation claims that enabling `library-for-ghci` causes packages to be loaded into GHCi slightly quicker than when it is disabled: https://github.com/NixOS/nixpkgs/pull/58743#issuecomment-478866824.  However, in the case of `doctest` (which loads packages uses the GHCi API), this seems to not be the case.  I don't know what is going on here.

  My personal opinion is that we should merge this PR and disable `library-for-ghci` by default.  I think it is more important that commonly used tools like `doctest` work well, than having libraries (sometimes?) load slightly quicker in GHCi.

  At some point in the future, I imagine it would be best if we could figure out what's going on with doctest, and whether the bug lies in our nix stuff, doctest, Cabal, GHC, etc.

  Pinging @peti.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.pomodoro: 0.13.4 -> 0.15.1
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59298
updated_at: 2019-04-18 00:17:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fix build because it's failing in staging-next https://hydra.nixos.org/build/91945945
  due to the vala bump. Then noticed it was pretty out of date.

  This brings in a new package [Gom](https://wiki.gnome.org/Projects/Gom).
  I had to make an MR to it because of the PyGObject override
  * https://gitlab.gnome.org/GNOME/gom/merge_requests/3


  ###### Things done
  Built and executed, haven't tested the shell extension though.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Script created by writeScript run at build time
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/59299
updated_at: 2019-06-09 10:45:32
body:
  ## Issue description

  I have a script defined by writeScript and the purpose is to get an executable script to the environment that I launch with nix-shell. However, the script is run at build time when running nix-shell. Is this correct??


  ### Steps to reproduce

  I have the following two files in a directory:

  `shell.nix`:

  ```
  let

    pkgs = import <nixpkgs> {};
    testScript = pkgs.writeScript "test-script" ''
      #!/usr/bin/env nix-shell
      #! nix-shell -i sh -p python3Packages.jupyterlab
      set -x
      this_command_does_not_exist
    '';

  in pkgs.python3Packages.buildPythonPackage rec {
    name = "foobar";
    src = ./.;
    doCheck = false;
    propagatedBuildInputs = [ testScript ];
  }
  ```

  `setup.py`:

  ```
  if __name__ == "__main__":
      from setuptools import setup, find_packages
      setup(
          packages = find_packages(),
          name     = "test",
          version  = "0.0.0",
      )
  ```

  I get the following error:

  ```
  $ nix-shell
  +++ this_command_does_not_exist
  +++ local p=/nix/store/47kisd1gx1dwd07llx6cm9csra42fsdl-command-not-found/bin/command-not-found
  +++ '[' -x /nix/store/47kisd1gx1dwd07llx6cm9csra42fsdl-command-not-found/bin/command-not-found -a -f /nix/var/nix/profiles/per-user/root/channels/nixos/programs.sqlite ']'
  +++ /nix/store/47kisd1gx1dwd07llx6cm9csra42fsdl-command-not-found/bin/command-not-found this_command_does_not_exist
  this_command_does_not_exist: command not found
  + exitHandler
  + exitCode=127
  + set +e
  + '[' -n '' ']'
  + ((  127 != 0  ))
  + runHook failureHook
  ++ shopt -po nounset
  + local 'oldOpts=set +o nounset'
  + set -u
  + local hookName=failureHook
  + shift
  + local 'hooksSlice=failureHooks[@]'
  + local hook
  + for hook in "_callImplicitHook 0 $hookName" ${!hooksSlice+"${!hooksSlice}"}
  + _eval '_callImplicitHook 0 failureHook'
  ++ type -t '_callImplicitHook 0 failureHook'
  + '[' '' = function ']'
  + set +u
  + eval '_callImplicitHook 0 failureHook'
  ++ _callImplicitHook 0 failureHook
  ++ set -u
  ++ local def=0
  ++ local hookName=failureHook
  ++ case "$(type -t "$hookName")" in
  +++ type -t failureHook
  ++ '[' -z '' ']'
  ++ return 0
  + set -u
  + eval 'set +o nounset'
  ++ set +o nounset
  + return 0
  + '[' -n '' ']'
  + exit 127
  ```

  Why does the script get run at build time??

  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.103, NixOS, 19.09.git.1c4e204 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: closed
title: No manpage for weechat
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/59300
updated_at: 2019-05-24 14:27:38
body:
  ## Issue description

  There is no manpage for weechat

  ### Steps to reproduce
  `nix run nixpkgs.weechat -c man weechat`


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.0, NixOS, 19.09.git.c141839 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(teto): `""`
   - channels(root): `""`
   - nixpkgs: `/home/teto/nixpkgs`
  ```


state: open
title: Multipath TCP
user_login: memberbetty
html_url: https://github.com/NixOS/nixpkgs/issues/59301
updated_at: 2019-06-04 16:53:25
body:
  ## Issue description
  This is a nice to have feature and would help give NixOS some credibility for high performance use cases: 

  NixOS is missing from this list: https://multipath-tcp.org/pmwiki.php/Users/Distributions. 

  The way to go would be to have a boolean NixOS module option with `multipath_tcp` in its name. After that works, some documentation could be written, and then it could be submitted to that website.  


state: closed
title: cargo-make: init at 0.17.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59302
updated_at: 2019-04-30 20:48:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `cargo-make` is a Rust runner and build tool.

  [https://sagiegurari.github.io/cargo-make/](https://sagiegurari.github.io/cargo-make/)
  [https://github.com/sagiegurari/cargo-make](https://github.com/sagiegurari/cargo-make)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskell-generic-builder: backport disable-library-for-ghci
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/59303
updated_at: 2019-04-12 12:52:52
body:
  This is a backport of https://github.com/NixOS/nixpkgs/pull/59297 to 19.03.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR causes quite a few rebuilds of Haskell packages, but it should arguably be backported to 19.03 since it is apparently working around a GHC bug (https://gitlab.haskell.org/ghc/ghc/issues/15524) as reported by @michaelpj [here](https://github.com/NixOS/nixpkgs/pull/59297#issuecomment-482035842).

  At work we are following the release-19.03 branch, so it would be helpful for us if this PR got in 19.03 to work around the long build-times caused by this bug.

  (cherry picked from commit 0698b5438bdbed31786fe883332408583f8e6535)

  Pinging @peti.

  I guess I should also ping the release manager for 19.03, but I don't remember who it is.  Maybe @lheckemann or the @NixOS/backports team?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.nixpkgs: 0.2.2 -> 0.2.3
user_login: t184256
html_url: https://github.com/NixOS/nixpkgs/pull/59304
updated_at: 2019-04-11 10:53:18
body:
  ###### Motivation for this change

  I've upstreamed a patch for nixpkgs-python-importer by @adisbladis that dealt with `pythonix` renaming `NixRef` to `NixError`.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: taffybar: unbreak package by default
user_login: mdorman
html_url: https://github.com/NixOS/nixpkgs/pull/59305
updated_at: 2019-07-10 20:17:27
body:
  @peti The gtk library situation seems to have been resolved, so it builds again.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: just: init at 0.4.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59306
updated_at: 2019-04-13 09:30:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `just` is a handy way to save and run project-specific commands.

  [https://github.com/casey/just](https://github.com/casey/just)
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grafana: 6.1.2 -> 6.1.3
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/59307
updated_at: 2019-04-11 17:30:00
body:
  ###### Motivation for this change
  Latest [patch release](https://github.com/grafana/grafana/releases/tag/v6.1.3) with four bug fixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (x86_64-linux & aarch64-linux)
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add ipset to dependencies for sshguard
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/59308
updated_at: 2019-04-11 13:06:35
body:
  This change simply adds ipset to the list of buildInputs for sshguard since this is essential for the application to start and function properly.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jenkins: 2.164.1 -> 2.164.2
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/59309
updated_at: 2019-04-13 03:02:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Security issue resolved in 2.164.2 which was present in 2.164.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hugo: 0.54 -> 0.55
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/pull/59311
updated_at: 2019-04-12 01:52:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updated Hugo to the latest version, see the changelog [here](https://github.com/gohugoio/hugo/releases/tag/v0.55.0). Verified that it works by building the documentation for Hugo.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Displaylink broken on 19.03
user_login: eyJhb
html_url: https://github.com/NixOS/nixpkgs/issues/59312
updated_at: 2019-06-08 19:41:01
body:
  ## Issue description
  Boots up and shows the screen, but it has flickr rows all the way down and 100% unuseable.


  ### Steps to reproduce
  Nixos channel 19.03, build, boot, try to use screen using the Displaylink Dock USB 3.0 DVI.


  ## Technical details
  Using a Lenovo x230 in a docking station, which connects to the USB 3.0 dock `Lenovo ThinkPad Mini Dock Plus Series 3`

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: displaylink: mark broken on 19.03
user_login: eyJhb
html_url: https://github.com/NixOS/nixpkgs/pull/59313
updated_at: 2019-05-23 15:20:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Displaylink does not work on 19.03 from my experience

  See issue https://github.com/NixOS/nixpkgs/issues/59312

  ###### Things done
  Tried using it?

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chez: 9.5.1 -> 9.5.2
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/59314
updated_at: 2019-04-12 16:16:06
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
  - [x] Tested execution of all binary files (usually in `./result/bin/`)


  ---


state: closed
title: nixos/znc: Fix URL XML for config option
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/59315
updated_at: 2019-04-15 03:11:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  Should be backported

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: torcs: anonscm.debian.org has moved
user_login: eri451
html_url: https://github.com/NixOS/nixpkgs/pull/59316
updated_at: 2019-04-24 19:26:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  the patch links returned a HTTP error 401 as
  anonscm.debian.org moved to a gitlab at salsa.debian.org
  I used the non access required download link generated by the new instance
  As @worldofpeace suggested in #58978 I used the last commit involving the files.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghc: apply fix to Haddock in relation to typechecker plugins
user_login: Taneb
html_url: https://github.com/NixOS/nixpkgs/pull/59317
updated_at: 2019-04-11 19:26:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The version of Haddock bundled with GHC 8.6 fails with typechecker modules. This applies a patch which fixes that.

  This is the main issue preventing me from moving away from nixpkgs 18.09 and GHC 8.4 at work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.CGIMinimal: init at 1.29 (19.03 backport)
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59318
updated_at: 2019-04-11 20:03:41
body:
  (cherry picked from commit 26db6d87d805b21acaf5a1d15909afbe4a2753ad)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  #58935

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.DBDOracle: init at 1.76 (19.03 backport)
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59319
updated_at: 2019-04-11 20:04:09
body:
  (cherry picked from commit 73d45ab1b0618c273e0d9212ad9568f42247ea14)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  #58726

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages.sqlsrv & phpPackages.pdo_sqlsrv: 5.6.0 -> 5.6.1
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59320
updated_at: 2019-04-13 10:17:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Version bump.
  Changelog: https://github.com/Microsoft/msphpsql/releases/tag/v5.6.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wmctrl: upd upstream links, clean-up, adopt package
user_login: Anton-Latukha
html_url: https://github.com/NixOS/nixpkgs/pull/59321
updated_at: 2019-04-12 10:26:00
body:
  ###### Motivation for this change

  1. Official page and upstream links do not exist anymore, they were redirects to Google+.
    Found his official webpage now & `sha256` matches.
  2. Clean-up.
  3. Adopted the package.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vulkan-tools: add dependency on vulkan-headers
user_login: acowley
html_url: https://github.com/NixOS/nixpkgs/pull/59322
updated_at: 2019-04-12 01:30:27
body:
  This fixes the build on NixOS.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The vulkan-tools package did not build.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: check-meta: don't execute check-meta.nix 15,000 times
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/59323
updated_at: 2019-04-11 23:44:50
body:
  Generated from https://github.com/NixOS/nix/pull/2761:

  ```
                                                                                            ns     calls ns/call
  - /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 591200 15026 39.3451
  + /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 8744   308   28.3896
  ```

  more, generated by:

  ```
  $ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > before 2>&1
  $ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' before | sort  > before.list
  ```

  applying this patch, then:

  ```
  $ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > after 2>&1
  $ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' after | sort  > after.list
  ```

  and then diffing before.list and after.list to get:

  ```
                                                                                                          calls
  - :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1               7513
  + :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1               154

  - mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23                7513
  + mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23                154

  - mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26                7513
  + mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26                154

  - onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 15026
  + onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 308
  ```

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: LLVM cross compilation should support C++
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/59325
updated_at: 2019-04-13 16:41:08
body:
  ## Issue description
  Bootstrapping libc++ has proven especially hard for me. Apparently the libc++ build scripts assume you have a libc++. This can be tested by trying out the useLLVM flag with some C++ program:

  ```
  nix-build -E '(import <nixpkgs> {
    crossSystem = { config = "armv7l-unknown-linux-musleabihf"; useLLVM = true; };
  }).nix'
  ```

  /cc @ericson2314 @dtzWill

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: steam: fix steamrt trying to use a missing setup.sh
user_login: puffnfresh
html_url: https://github.com/NixOS/nixpkgs/pull/59326
updated_at: 2019-04-18 03:46:37
body:
  I was getting the following error after a Steam update:

      internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

  The script is used to put things on PATH but it doesn't seem we need to do that.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-xbuild: 0.5.7 -> 0.5.8
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59328
updated_at: 2019-04-11 20:48:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to the latest release.
  [https://github.com/rust-osdev/cargo-xbuild/releases/tag/v0.5.8](https://github.com/rust-osdev/cargo-xbuild/releases/tag/v0.5.8)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] bluetoothd segfault
user_login: fadenb
html_url: https://github.com/NixOS/nixpkgs/issues/59329
updated_at: 2019-04-12 18:41:41
body:
  ## Issue description
  When turning on my bluetooth headset and connecting to it bluetoothd segfaults

  ```
  [   16.327080] virbr0: port 1(virbr0-nic) entered listening state
  [   16.352808] virbr0: port 1(virbr0-nic) entered disabled state
  [   18.641488] Bluetooth: RFCOMM TTY layer initialized
  [   18.641492] Bluetooth: RFCOMM socket layer initialized
  [   18.641495] Bluetooth: RFCOMM ver 1.11
  [   37.429935] NET: Registered protocol family 38
  [   52.064692] Bluetooth: hci0: SCO packet for unknown connection handle 0
  [   52.064697] Bluetooth: hci0: SCO packet for unknown connection handle 0
  [   52.064698] Bluetooth: hci0: SCO packet for unknown connection handle 0
  [   52.072769] show_signal_msg: 8 callbacks suppressed
  [   52.072771] bluetoothd[1101]: segfault at 10 ip 000055c29171ab80 sp 00007fff73620ff8 error 4 in bluetoothd[55c29170e000+93000]
  [   52.072776] Code: 08 00 48 89 c6 31 c0 e8 5e 73 02 00 44 8b 5c 24 0c e9 09 fe ff ff e8 af 43 ff ff 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 <4c> 8b 47 10 49 39 78 50 74 06 31 c0 c3 0f 1f 00 41 55 41 54 49 89
  [   52.074690] Bluetooth: hci0: SCO packet for unknown connection handle 0
  [   52.097381] Bluetooth: hci0: SCO packet for unknown connection handle 258
  ```

  A few reboots and git bisect later I identified d28aedd77e32f0a0dfe420aebc7f059a13a04034 as the first bad commit

  (for completeness sake my journey to the commit)
  ```
  602c2b40e7c: good
  2f980e45986: good
  4fe8a27cfea: bad
  de216e66fc8: good
  608461e398f: good
  db4bdf1fe4e: good
  d28aedd77e3: bad
  52c2e78aede: good
  ```

  ### Steps to reproduce
  * boot laptop (Thinkpad X270)
  * run `bluetoothctl`
  * Execute command `connect 2C:41:A1:XX:XX:XX` (previosly paired headset)
  * wait a moment
  * see bluetoothd segfault in dmesg, pavucontrol showed new input and output devices for a short moment

  I tried reverting d28aedd77e32f0a0dfe420aebc7f059a13a04034 but the problem persists. I am not sure if/how it is related. I made sure to check the last good and first bad commit identified by git-bisect multiple times and do not seem to have mistakenly identified the wrong commit.



  ## Technical details

  Hardware: Thinkpad X270
  Intel USB Bluetooth: Bus 001 Device 003: ID 8087:0a2b Intel Corp. 


   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.git.ed07f05 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a, nixos1809-18.09.2505.46d3867a08a"`
   - channels(tristan.helmich): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


  /cc @worldofpeace 


state: closed
title: [19.03] nix repl errors
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/issues/59330
updated_at: 2019-04-11 20:38:38
body:
  ## Issue description

  I just installed 19.03 on my brand new notebook, but when entering nix repl I get:

  ```
  > :l <nixpkgs>
  error: attempt to call something which is not a function but a path, at /nix/store/sdpyaycas6msg0nbpjzalw06j48i1nlw-nixos-19.03.172138.5c52b25283a/nixos/lib/fixed-points.nix:66:67
  ```

  The same happens when I try to install something with `nix-env`:

  ```
  $ nix-env -iA nixos.git-annex
  error: attempt to call something which is not a function but a path, at /nix/store/sdpyaycas6msg0nbpjzalw06j48i1nlw-nixos-19.03.172138.5c52b25283a/nixos/lib/fixed-points.nix:66:67
  ```

  Maybe related to #58585

  ### Steps to reproduce

  Not sure.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  Cannot run this because:

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
  error: attempt to call something which is not a function but a path, at /nix/store/sdpyaycas6msg0nbpjzalw06j48i1nlw-nixos-19.03.172138.5c52b25283a/nixos/lib/fixed-points.nix:66:67
  ```


state: closed
title: [18.09] hslua-1.0.2 fails to build
user_login: themattchan
html_url: https://github.com/NixOS/nixpkgs/issues/59331
updated_at: 2019-05-16 17:25:17
body:
  ## Issue description

  Building `hslua-1.0.2` fails with the following error, which blocks `pandoc` from compiling.

  I am using a pinned version of the `hslua` dependency with a nix expression generated by `cabal2nix cabal://hslua-1.0.2`, on nixpkgs 18.09 (`6a3f5bcb061e1822f50e299f5616a0731636e4e7`) and `ghc843`.

  ```
  ....

  [ 6 of 15] Compiling Foreign.Lua.Core.Functions ( src/Foreign/Lua/Core/Functions.hs, dist/build/Foreign/Lua/Core/Functions.o )
  [ 7 of 15] Compiling Foreign.Lua.Core.Auxiliary ( dist/build/Foreign/Lua/Core/Auxiliary.hs, dist/build/Foreign/Lua/Core/Auxiliary.o )
  clang-5.0: warning: argument unused during compilation: '-nopie' [-Wunused-command-line-argument]

  /private/var/folders/fb/845d7wfd21g3flzcchdmcq740000gn/T/nix-build-hslua-1.0.2.drv-0/ghc36485_0/ghc_63.c:12:145: error:
       error: returning 'void' from a function with incompatible result type 'HsInt32' (aka 'int')
     |
  12 | HsInt32 ghczuwrapperZC2ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCluaLzugetmetatable(void* a1, void* a2) {return luaL_getmetatable(a1, a2);}
     |                                                                                                                                                 ^
  HsInt32 ghczuwrapperZC2ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCluaLzugetmetatable(void* a1, void* a2) {return luaL_getmetatable(a1, a2);}
                                                                                                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~

  /nix/store/jn4cqfhqikdk0p71ickylaym2z60gc7h-lua-5.2.4/include/lauxlib.h:130:32: error:
       note: expanded from macro 'luaL_getmetatable'
      |
  130 | #define luaL_getmetatable(L,n)  (lua_getfield(L, LUA_REGISTRYINDEX, (n)))
      |                                ^
  #define luaL_getmetatable(L,n)  (lua_getfield(L, LUA_REGISTRYINDEX, (n)))
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  /private/var/folders/fb/845d7wfd21g3flzcchdmcq740000gn/T/nix-build-hslua-1.0.2.drv-0/ghc36485_0/ghc_63.c:16:130: error:
       error: use of undeclared identifier 'LUA_PRELOAD_TABLE'
     |
  16 | void* ghczuwrapperZC4ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCLUAzuPRELOADzuTABLE(void) {return LUA_PRELOAD_TABLE;}
     |                                                                                                                                  ^
  void* ghczuwrapperZC4ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCLUAzuPRELOADzuTABLE(void) {return LUA_PRELOAD_TABLE;}
                                                                                                                                   ^

  /private/var/folders/fb/845d7wfd21g3flzcchdmcq740000gn/T/nix-build-hslua-1.0.2.drv-0/ghc36485_0/ghc_63.c:18:129: error:
       error: use of undeclared identifier 'LUA_LOADED_TABLE'
     |
  18 | void* ghczuwrapperZC5ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCLUAzuLOADEDzuTABLE(void) {return LUA_LOADED_TABLE;}
     |                                                                                                                                 ^
  void* ghczuwrapperZC5ZChsluazm1zi0zi2zm7BLqVITBqeMJPeCIxGzzpfTZCForeignziLuaziCoreziAuxiliaryZCLUAzuLOADEDzuTABLE(void) {return LUA_LOADED_TABLE;}
                                                                                                                                  ^
  3 errors generated.

  <no location info>: error:
      `cc' failed in phase `C Compiler'. (Exit code: 1)
  builder for ‘/nix/store/18nfhw70rnnabbwrgf4wmmzq06m8mbr9-hslua-1.0.2.drv’ failed with exit code 1
  cannot build derivation ‘/nix/store/7m8vzv1bs4jb496q4kiq99v224mwdvxq-ghc-8.4.3-with-packages.drv’: 1 dependencies couldn't be built
  error: build of ‘/nix/store/7m8vzv1bs4jb496q4kiq99v224mwdvxq-ghc-8.4.3-with-packages.drv’ failed
  /Users/matt/.nix-profile/bin/nix-shell: failed to build all dependencies
  ```

  ### Steps to reproduce

  clone https://github.com/themattchan/nix1809-hslua-bug and start a `nix-shell`


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  $ nix-shell -p nix-info --run "nix-info -m"                                                                                             these paths will be fetched (0.01 MiB download, 0.03 MiB unpacked):
    /nix/store/b14vgm4840j3czrga6sbs51z48vjx26p-DarwinTools-1
    /nix/store/bm3x04ffa9ppgxg80v0l77dhiq2xnc57-nix-info
  fetching path ‘/nix/store/b14vgm4840j3czrga6sbs51z48vjx26p-DarwinTools-1’...

  *** Downloading ‘https://cache.nixos.org/nar/1xiji9spr43lkqczdbv0vvkgc3l7iblr7lvag21qg3k7528kp5w4.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/b14vgm4840j3czrga6sbs51z48vjx26p-DarwinTools-1’...
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  4648  100  4648    0     0   4648      0  0:00:01 --:--:--  0:00:01 12072

  fetching path ‘/nix/store/bm3x04ffa9ppgxg80v0l77dhiq2xnc57-nix-info’...

  *** Downloading ‘https://cache.nixos.org/nar/1x9jpq0x4qlcw93nhq675ijbhp7yll55s46j2l8vqah266a219dk.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/bm3x04ffa9ppgxg80v0l77dhiq2xnc57-nix-info’...
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  1680  100  1680    0     0   1680      0  0:00:01 --:--:--  0:00:01  3971

   - system: `"x86_64-darwin"`
   - host os: `Darwin 17.7.0, macOS 10.13.6`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(matt): `"nixpkgs-18.03pre133174.edd63e05d1e"`
   - nixpkgs: `/Users/matt/.nix-defexpr/channels/nixpkgs`
  ```


state: open
title: gitAndTools.git-remote-hg: 0.2 -> 1.0.0
user_login: erosennin
html_url: https://github.com/NixOS/nixpkgs/pull/59332
updated_at: 2019-04-15 17:04:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  git-remote-hg-0.2 is broken with recent versions of Mercurial:

  ```
  $ hg init test-hg
  $ cd test-hg
  $ touch README
  $ hg add
  $ hg commit -m 'Add readme'
  $ cd ..
  $ git clone hg::test-hg test-git
  Cloning into 'test-git'...
  Traceback (most recent call last):
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 1333, in <module>
      sys.exit(main(sys.argv))
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 1317, in main
      do_import(parser)
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 729, in do_import
      export_bookmark(repo, bmark)
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 613, in export_bookmark
      export_ref(repo, bmark, 'bookmarks', head)
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 486, in export_ref
      revs = gitrange(repo, tip, head)
    File "/nix/store/5m6xvmcqq5j248i90hnrga7pal6wm3yr-git-remote-hg-0.2-e716a9e1a9e460a45663694ba4e9e8894a8452b2/bin/.git-remote-hg-wrapped", line 453, in gitrange
      pending = set([int(b)])
  TypeError: int() argument must be a string or a number, not 'changectx'
  fatal: stream ends early
  fast-import: dumping crash report to /tmp/test-git/.git/fast_import_crash_16959
  fatal: error while running fast-import
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.zeromq4-haskell_0_8_0: unbreak
user_login: vaibhavsagar
html_url: https://github.com/NixOS/nixpkgs/pull/59333
updated_at: 2019-04-15 17:45:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [WIP] Add Elm 0.18 and update misc Haskell packages.
user_login: dhruvio
html_url: https://github.com/NixOS/nixpkgs/pull/59335
updated_at: 2019-05-24 20:17:01
body:
  **Do not merge. Work in-progress.**

  ###### Motivation for this change

  Add Elm 0.18 (as `elm_0_18`) to the package library. In the past, I used package pinning to use an old commit of this repo to install Elm 0.18. However, upgrading to macOS Mojave caused some regressions in `nixpkgs`. While the necessary fixes were implemented recently in `nixpkgs`, it is no longer possible to pin an older version of `nixpkgs` to use Elm 0.18 on macOS Mojave.

  In addition, I ended up encountering several issues with Haskell modules during the build process. This PR includes those fixes as well:

  - Update QuickCheck dependency for the Diff Haskell package, as Diff's tests break given an API change beginning with QuickCheck 2.12 (not working as expected, so I updated haskell-modules/configuration-common.nix to ignore Diff's tests).
    - See my inline comment under the "Files Changed" tab.
  - Added contravariant dependency to aeson as this is required when compiling with GHC < 8.6.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date.
    - **Note:** I adapted the existing Elm 0.19 Nix code for Elm 0.18. Since it involved modifying script-generated Nix files, I removed the relevant documentation and scripts from the `elm_0_18` directory to avoid confusion and ensure this documentation didn't need to be maintained in two places.
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: check-meta: don't execute check-meta.nix 15,000 times (backport)
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/59336
updated_at: 2019-07-18 10:51:14
body:
  Generated from https://github.com/NixOS/nix/pull/2761:

  ```
                                                                                            ns     calls ns/call
  - /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 591200 15026 39.3451
  + /home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:22:5 8744   308   28.3896
  ```

  more, generated by:

  ```
  $ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > before 2>&1
  $ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' before | sort  > before.list
  ```

  applying this patch, then:

  ```
  $ NIX_SHOW_STATS=1 NIX_COUNT_CALLS=1 nix-instantiate ./pkgs/top-level/release.nix -A unstable > after 2>&1
  $ jq -r '.functions | map((.name + ":" + .file + ":" + (.line|tostring) + ":" + (.column|tostring) + " " + (.count|tostring))) | .[]' after | sort  > after.list
  ```

  and then diffing before.list and after.list to get:

  ```
                                                                                                          calls
  - :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1               7513
  + :/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:4:1               154

  - mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23                7513
  + mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:23                154

  - mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26                7513
  + mutuallyExclusive:/home/grahamc/projects/github.com/NixOS/nixpkgs/lib/lists.nix:658:26                154

  - onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 15026
  + onlyLicenses:/home/grahamc/projects/github.com/NixOS/nixpkgs/pkgs/stdenv/generic/check-meta.nix:21:18 308
  ```

  The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true`:

  | stat                       | before         | after          | Δ               | Δ%      |
  |:---------------------------|---------------:|---------------:|:----------------|--------:|
  | **cpuTime**                |        179.915 |        145.543 | 🡖 34.372        | -19.10% |
  | **envs-bytes**             |  3,900,878,824 |  3,599,483,208 | 🡖 301,395,616   |  -7.73% |
  | **envs-elements**          |    214,426,071 |    185,881,709 | 🡖 28,544,362    | -13.31% |
  | **envs-number**            |    136,591,891 |    132,026,846 | 🡖 4,565,045     |  -3.34% |
  | **gc-heapSize**            | 11,400,048,640 | 12,314,890,240 | 🡕 914,841,600   |   8.02% |
  | **gc-totalBytes**          | 25,976,902,560 | 24,510,740,176 | 🡖 1,466,162,384 |  -5.64% |
  | **list-bytes**             |  1,665,290,080 |  1,665,290,080 | 0               |         |
  | **list-concats**           |      7,264,417 |      7,264,417 | 0               |         |
  | **list-elements**          |    208,161,260 |    208,161,260 | 0               |         |
  | **nrAvoided**              |    191,359,386 |    179,693,661 | 🡖 11,665,725    |  -6.10% |
  | **nrFunctionCalls**        |    119,665,062 |    116,348,547 | 🡖 3,316,515     |  -2.77% |
  | **nrLookups**              |     80,996,257 |     76,069,825 | 🡖 4,926,432     |  -6.08% |
  | **nrOpUpdateValuesCopied** |    213,930,649 |    213,930,649 | 0               |         |
  | **nrOpUpdates**            |     12,025,937 |     12,025,937 | 0               |         |
  | **nrPrimOpCalls**          |     88,105,604 |     86,451,598 | 🡖 1,654,006     |  -1.88% |
  | **nrThunks**               |    196,842,044 |    175,126,701 | 🡖 21,715,343    | -11.03% |
  | **sets-bytes**             |  7,678,425,776 |  7,285,767,928 | 🡖 392,657,848   |  -5.11% |
  | **sets-elements**          |    310,241,340 |    294,373,227 | 🡖 15,868,113    |  -5.11% |
  | **sets-number**            |     29,079,202 |     27,601,310 | 🡖 1,477,892     |  -5.08% |
  | **sizes-Attr**             |             24 |             24 | 0               |         |
  | **sizes-Bindings**         |              8 |              8 | 0               |         |
  | **sizes-Env**              |             16 |             16 | 0               |         |
  | **sizes-Value**            |             24 |             24 | 0               |         |
  | **symbols-bytes**          |     16,474,666 |     16,474,676 | 🡕 10            |   0.00% |
  | **symbols-number**         |        376,426 |        376,427 | 🡕 1             |   0.00% |
  | **values-bytes**           |  6,856,506,288 |  6,316,585,560 | 🡖 539,920,728   |  -7.87% |
  | **values-number**          |    285,687,762 |    263,191,065 | 🡖 22,496,697    |  -7.87% |

  The following information is from `NIX_SHOW_STATS=1 GC_INITIAL_HEAP_SIZE=4g nix-instantiate ./nixos/release-combined.nix -A tested`:

  | stat                       | before         | after          | Δ               | Δ%     |
  |:---------------------------|---------------:|---------------:|:----------------|-------:|
  | **cpuTime**                |        256.071 |        237.531 | 🡖 18.54         | -7.24% |
  | **envs-bytes**             |  7,111,004,192 |  7,041,478,520 | 🡖 69,525,672    | -0.98% |
  | **envs-elements**          |    346,236,940 |    339,588,487 | 🡖 6,648,453     | -1.92% |
  | **envs-number**            |    271,319,292 |    270,298,164 | 🡖 1,021,128     | -0.38% |
  | **gc-heapSize**            |  8,995,291,136 | 10,110,009,344 | 🡕 1,114,718,208 | 12.39% |
  | **gc-totalBytes**          | 37,172,737,408 | 36,878,391,888 | 🡖 294,345,520   | -0.79% |
  | **list-bytes**             |  1,886,162,656 |  1,886,163,472 | 🡕 816           |  0.00% |
  | **list-concats**           |      6,898,114 |      6,898,114 | 0               |        |
  | **list-elements**          |    235,770,332 |    235,770,434 | 🡕 102           |  0.00% |
  | **nrAvoided**              |    328,829,821 |    326,618,157 | 🡖 2,211,664     | -0.67% |
  | **nrFunctionCalls**        |    240,850,845 |    239,998,495 | 🡖 852,350       | -0.35% |
  | **nrLookups**              |    144,849,632 |    142,126,339 | 🡖 2,723,293     | -1.88% |
  | **nrOpUpdateValuesCopied** |    251,032,504 |    251,032,504 | 0               |        |
  | **nrOpUpdates**            |     17,903,110 |     17,903,110 | 0               |        |
  | **nrPrimOpCalls**          |    140,674,913 |    139,485,975 | 🡖 1,188,938     | -0.85% |
  | **nrThunks**               |    294,643,131 |    288,678,022 | 🡖 5,965,109     | -2.02% |
  | **sets-bytes**             |  9,464,322,192 |  9,456,172,048 | 🡖 8,150,144     | -0.09% |
  | **sets-elements**          |    377,474,889 |    377,134,877 | 🡖 340,012       | -0.09% |
  | **sets-number**            |     50,615,607 |     50,616,875 | 🡕 1,268         |  0.00% |
  | **sizes-Attr**             |             24 |             24 | 0               |        |
  | **sizes-Bindings**         |              8 |              8 | 0               |        |
  | **sizes-Env**              |             16 |             16 | 0               |        |
  | **sizes-Value**            |             24 |             24 | 0               |        |
  | **symbols-bytes**          |      3,147,102 |      3,147,064 | 🡖 38            | -0.00% |
  | **symbols-number**         |         82,819 |         82,819 | 0               |        |
  | **values-bytes**           | 11,147,448,768 | 10,996,111,512 | 🡖 151,337,256   | -1.36% |
  | **values-number**          |    464,477,032 |    458,171,313 | 🡖 6,305,719     | -1.36% |

  (cherry picked from commit 817c933878d1eea16af8a0efcb62fff59c698cdb)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59337
updated_at: 2019-04-13 10:07:09
title:
  openshot-qt: 2.4.3 -> 2.4.4, libsForQt5.libopenshot: 0.2.2 -> 0.2.3, libsForQt5.libopenshot-audio: 0.1.7 -> 0.1.8

body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/pull/58734

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvm8: support c++ in cross case
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59338
updated_at: 2019-04-12 18:09:01
body:
  this adds libc++ to the LLVM cross, giving us access to the full
  Nixpkgs set. This requires 4 stages of wrapped compilers:

  - Clang with no libraries
  - Clang with just compiler-rt
  - Clang with Libc, and compiler-rt
  - Clang with Libc++, Libc, and compiler-rt

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Test:

  ```
  with import ./default.nix {
    crossSystem = (import ./lib).systems.examples.aarch64-multiplatform-musl // {useLLVM = true;};
  };
  let
  cpp = builtins.toFile "test.c++" ''
  #include <iostream>

  int main() {
    std::cout << "Hello world!" << std::endl;
  }
  '';
  testdrv = { callPackage, stdenv, llvmPackages_8 }: stdenv.mkDerivation
      {
          name = "cross-test";
          version = "0.1";
          unpackPhase = "true";
          buildInputs = [llvmPackages_8.libunwind];
          buildPhase = ''
              $CXX -lunwind -o test ${cpp}
          '';
          installPhase = ''
              mkdir -p $out/bin
              cp test $out/bin/test
              ${stdenv.hostPlatform.emulator buildPackages} $out/bin/test
          '';
      };
  in callPackage testdrv {}
  ```

  ---


state: closed
title: pantheon updates, etc.
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59339
updated_at: 2019-04-18 16:05:05
body:
  ###### Motivation for this change
  The usual.

  ###### Summary of changes

  * https://github.com/elementary/photos/releases/tag/2.6.3

  The gexiv2 0.12 patch is included in this release.

  * https://github.com/elementary/switchboard-plug-mouse-touchpad/releases/tag/2.2.0
  > Use org.gnome.settings-daemon.plugins.xsettings for middle click paste

  That has been hardcoded with a patch.

  * Using placeholder in https://github.com/NixOS/nixpkgs/commit/b335d5640c04e7940ba1c00965933b9ad3767519 https://github.com/NixOS/nixpkgs/commit/4a690093b1def766576ae2c577a55c037f5c8d13.

  Lastly there's a hardcode-gsettings patch for `networkmanagerapplet` `org.gnome.nm-applet.eap` 
  that is needed for `wingpanel-indicator-network` and `switchboard-plug-network`.
  ##### Though mind the commit msg :smile: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buck: 2017.10.01.01 -> 2019.01.10.01
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59340
updated_at: 2019-04-12 17:37:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Darwin Mojave: request to backport #59278
user_login: dhruvio
html_url: https://github.com/NixOS/nixpkgs/issues/59341
updated_at: 2019-05-24 20:15:00
body:
  A [recent PR](https://github.com/NixOS/nixpkgs/pull/59278) fixed a regression on macOS Mojave that caused certain package builds to fail. The fix is available on master, but should (IMO) also be applied to previous versions of nixpkgs (e.g. 18.09, 18.03, etc), so users that depend on pinning those versions can continue to do so on Mojave.

  For example, I need to use Elm 0.18, and the only way to do this is to pin to `nixos/nixpkgs#18.03`. This doesn't work on Mojave, as I get an error message described by [this ticket](https://github.com/obsidiansystems/obelisk/issues/183).

  I would offer a PR myself, but I think the work required is beyond my skill-set. Is someone able to do this? Or, weigh in whether this is a viable solution? 


state: open
title: nixos/mptcp: multipath TCP module
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/59342
updated_at: 2019-04-17 14:47:59
body:
  Multipath TCP is an IETF extension of TCP that makes use of several TCP connections to speed up transfer/increase reliability/confidentiality. Applications don't have to be changed (yet they can use the new MPTCP API for even better performance), the kernel will use MPTCP when applicable and fall back to TCP otherwise.

  I had this in my repo for a while but https://github.com/NixOS/nixpkgs/issues/59301 convinced me to propose it. It only works with networkmanager for now (you need to update routing tables depending on added/removed interfaces).


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59343
updated_at: 2019-04-12 08:25:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [RFC] Proposal: Engineering a Common "Plugin" Infrastructure
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/59344
updated_at: 2019-07-17 17:04:03
body:
  Edit: I made a WIP PoC library https://github.com/deliciouslytyped/nix-rootedoverlay/ , it still needs a lot of work but seems to be functional.
  ~~Edit: **Help wanted**: someone to hand-hold me through the fixpoint stuff needed for overrides in this infrastructure~~ I think I figured it out.

  There are various separate, probably incompatible implementations of plugin infrastructure across nixpkgs, examples being at least:

  (NOT REVIEWED indicates the author is tentatively aware of a plugin system but has not inspected the implementation)

  - TODO, list here
  - a not-yet-upstreamed implementation for Ghidra cannibalized from Idris
  - NOT REVIEWED: Idris (see above)
  - NOT REVIEWED: firefox / other mozilla software 
  - NOT REVIEWED: Eclipse
  - package managers of interpreted languages (TODO: any 'sub'-package manager?)
    - NOT REVIEWED: python packages
    - NOT REVIEWED: ruby
  - NOT REVIEWED: Jekyll
  - NOT REVIEWED: redmine
  - NOT REVIEWED: perl https://github.com/NixOS/nixpkgs/pull/59215
  - HYPOTHETICAL wine package management
  - NOT REVIEWED retroarch
  - NOT REVIEWED gnome-shell
  - NOT REVIEWED terraform (was suggested for it's simplicity)
  - NOT REVIEWED r/rstudio/rwrapper/rpackages
  No implementation:
  - jenkins (?)

  CONSIDER: asking maintainers of the various systems for input

  The more advanced implementations usually (TODO: substantiate this) use some kind of fix-point mechanism which can be quite hard to understand.

  Would it be possible and reasonable to factor out a plugin handling API that can be specialized to various desired implementations, such that the internal mechanisms do not need to be understood by the user? This could also result in the overall simplification of these components of nixpkgs.

  A generic plugin system should:
  - provide one or more (possibly extensible) methods of applying plugins to a package:
    - feeding plugins back into the original derivation, e.g.
      `{..., plugins ? ... }: mkDerivation ...`
    - merging base and plugin derivations via something like `symlinkJoin`.
      This has the advantage of being faster and less wasteful than rebuilding the base package, but may fail with improper symlink handling? This also may have other failure modes such as runner makeWrapper scripts referring to the original derivation, resulting in the plugins being ignored because they are in a new derivation. (TODO: elaborate on this, this is an issue I ran into.)
    - ...other...?
  - provide the ability to have in-tree (nixpkgs) plugins
  - provide the ability to have out-of-tree plugins via overrides, overlays, or some similar mechanism
  - ...other...?

  Pending questions:
  - What makes a plugin system a plugin system? (I.e. what is the scope of this?)
  - how does https://github.com/NixOS/nixpkgs/pull/44196 relate?


state: closed
title: boringtun: init at 20190407
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59345
updated_at: 2019-04-13 09:30:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  BoringTun is an implementation of the WireGuard® protocol designed for portability and speed.
  https://github.com/cloudflare/boringtun
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: squid4: 4.4 -> 4.6
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59346
updated_at: 2019-04-13 09:30:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update squid4 to the latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rapid-photo-downloader: 0.9.13 -> 0.9.14
user_login: callahad
html_url: https://github.com/NixOS/nixpkgs/pull/59347
updated_at: 2019-04-23 11:54:33
body:
  This updates Rapid Photo Downloader to 0.9.14 and fixes #56815

  ###### Motivation for this change

  - Version bump
  - Actually make it work:
      - Does not require `exiftool` to be present in the user environment
      - Can now successfully find `libmediainfo`
      - Can now successfully generate video thumbnails

  Known issues:

  - Support for RAW images is not fully functional.

      [Rapid Photo Downloader](https://www.damonlynch.net/rapid/) uses [Rawkit](https://rawkit.readthedocs.io/en/latest/) bindings to [libraw](https://www.libraw.org/).

      Rawkit is unmaintained, and its most recent release does not support libraw 0.19. The nixpkgs collection has included 0.19 since [mid-2018](https://github.com/NixOS/nixpkgs/commit/92d48c6a21a0fe1c814d611b8a923688404f83f0#diff-0d9f1728501ca545bce47c7ed02e1214).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: evil-escape lacks a package header
user_login: garry-cairns
html_url: https://github.com/NixOS/nixpkgs/issues/59348
updated_at: 2019-04-12 11:05:11
body:
  ## Issue description

  Builds with `evil-escape` built in to emacs will fail because the package lacks a header. The error message is as follows:

      Warning: (error "Package lacks a file header")
      installing
      Package lacks a file header
      builder for '/nix/store/vjb2bdgz6pa5yl53mag5a2xg2335sk78-emacs-evil-escape-20180910.534.drv' failed with exit code 255

  ### Steps to reproduce

  Build a wrapped emacs in your configuration on 19.03 similar to [mine](https://gitlab.com/garry-cairns/nixos-config/blob/master/emacs.nix), which includes `evil-escape` in its melpa packages.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.111, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - channels(garry): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nixos/manual: update 17.03 -> 19.03 in upgrading section
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/59349
updated_at: 2019-04-12 16:29:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The manual references 17.03 in a few spots in the upgrading section of the manual. I think it makes sense to keep those references current as there are a lot of copy and paste warriors out there and it would be nice to make upgrading as easy as possible.

  ###### Things done
  changed 17.03 -> 19.03 , and updated example to accurately cover this change as well
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] gvfs: 1.38.1 -> 1.38.2
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59350
updated_at: 2019-04-12 20:28:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  fix https://nvd.nist.gov/vuln/detail/CVE-2019-3827

  changelog: https://gitlab.gnome.org/GNOME/gvfs/blob/1.38.2/NEWS

  closes https://github.com/NixOS/nixpkgs/issues/59161

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tautulli: 2.1.26 -> 2.1.28
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/59351
updated_at: 2019-04-12 14:08:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to latest version: https://github.com/Tautulli/Tautulli/releases

  Sucessfully running alongside Plex 1.15.3.876

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.lektor: 2.3 -> 3.1.3
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/59353
updated_at: 2019-04-14 20:20:34
body:
  ###### Motivation for this change

  Company is deploying a lektor based blog wanted to have the latest lektor version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nvidiaLegacy304: dead link (again)
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/issues/59354
updated_at: 2019-04-16 14:10:35
body:
  ## Issue description

  The Debian archive containing the patches for the nvidiaLegacy304 package doesn't exist anymore.

  ```
  trying http://httpredir.debian.org/debian/pool/non-free/n/nvidia-graphics-drivers-legacy-304xx/nvidia
  -graphics-drivers-legacy-304xx_304.137-5.debian.tar.xz                                              
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                     
                                   Dload  Upload   Total   Spent    Left  Speed                       
  100   407  100   407    0     0   8659      0 --:--:-- --:--:-- --:--:--  8847                      
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0                      
  curl: (22) The requested URL returned error: 404 Not Found
  ```

  https://github.com/NixOS/nixpkgs/blob/928d51a9cbb3fee296da23fe297737147eb9bb05/pkgs/os-specific/linux/nvidia-x11/default.nix#L65-L66

  The closest matching files are either `nvidia-graphics-drivers-legacy-304xx_304.137-5~bpo9+1.debian.tar.xz` or `nvidia-graphics-drivers-legacy-304xx_304.137-5~deb9u1.debian.tar.xz`.

  I'm unable to compute the hashes for those file as the `nix-prefetch-url` command line tool returns an error:

  ```
  nix-prefetch-url 'http://cdn-fastly.deb.debian.org/debian/pool/non-free/n/nvidia-graphics-drivers-legacy-304xx/nvidia-graphics-drivers-legacy-304xx_304.137-5~deb9u1.debian.tar.xz'
  error: invalid character '~' in name 'nvidia-graphics-drivers-legacy-304xx_304.137-5~deb9u1.debian.tar.xz'
  ```

  ### Steps to reproduce

  ```
    services.xserver.videoDrivers = [ "nvidiaLegacy304" ];
    nixpkgs.config.allowBroken = true;
  ```

  on NixOS 19.03.


  ## Technical details

  NixOS 18.09 being upgraded to 19.03.


state: closed
title: krunner-pass build failure
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/issues/59355
updated_at: 2019-05-03 07:49:36
body:
  ## Issue description

  After switching to 19.03, krunner-pass failed to build

  ### Steps to reproduce

  `nix-shell -p krunner-pass` on 19.03, it is failing with:

  ```
  [ 88%] Building CXX object CMakeFiles/krunner_pass.dir/pass.o
  [100%] Linking CXX shared module krunner_pass.so
  /nix/store/0y7jmqnj48ikjh37n3dl9kqw9hnn68nq-binutils-2.31.1/bin/ld: cannot find -lQt5::DBus
  collect2: error: ld returned 1 exit status
  make[2]: *** [CMakeFiles/krunner_pass.dir/build.make:99: krunner_pass.so] Error 1
  make[1]: *** [CMakeFiles/Makefile2:175: CMakeFiles/krunner_pass.dir/all] Error 2
  make: *** [Makefile:130: all] Error 2
  builder for '/nix/store/s8a7g0ijn2x50yi5vkkk236022iv1aa3-krunner-pass-1.3.0.drv' failed with exit code 2
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - channels(myuser): `"home-manager-19.03"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: python36Packages.pylint build failure (test phase)
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/issues/59356
updated_at: 2019-04-12 15:49:31
body:
  ## Issue description

  Switching to 19.03 broke pylint's tests (again? #51394)

  ### Steps to reproduce

  `nix-shell -p python36Packages.pylint`

  ```
  =================================== FAILURES ===================================
  ________________ TestNameChecker.test_assign_to_new_keyword_py3 ________________
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - channels(myuser): `"home-manager-19.03"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: fish shell segfaults trying to run script in a NixOS docker
user_login: locallycompact
html_url: https://github.com/NixOS/nixpkgs/issues/59357
updated_at: 2019-04-26 18:12:33
body:
  Hi, I'm trying to execute a fish script which runs fine on my local machine on NixOS, but fails in a NixOS docker. fish --version works in the docker and returns 3.0.2, but attempting to run a script results in many lines of the form.

  ```
  <4> fish: Set status of job 2194 (test ...) to 0 using short circuit
  <3> fish: Created job 2194 from command 'test -f /etc/fish/config.fish' with pgrp -2
  <4> fish: Start job 2194, gid -2 (test -f /etc/fish/config.fish), COMPLETED, NON-INTERACTIVE
  <5> fish: intern /etc/fish/config.fish
  <5> fish: intern /etc/fish/config.fish
  <5> fish: intern /etc/fish/config.fish
  <5> fish: intern /etc/fish/config.fish
  <5> fish: intern /etc/fish/config.fish
  <4> fish: Skipping fork: no output for internal builtin 'test'
  ```

  Full Log here:

  https://gitlab.com/zenhaskell/infra-dockers/pipelines/56255895

  Any script will fail with a segfault. Something as simple as

  ```
  #!/usr/bin/env fish
  echo "foo"
  ```

  will fail.


state: open
title: Multiple buildkite agent support
user_login: Lucus16
html_url: https://github.com/NixOS/nixpkgs/pull/59358
updated_at: 2019-07-15 12:17:14
body:
  ###### Motivation for this change

  For a clearer diff: `git diff master:nixos/modules/services/continuous-integration/buildkite-agent.nix HEAD:nixos/modules/services/continuous-integration/buildkite-agents.nix`

  Buildkite 3 supports multiple agents. We've patched nixpkgs to support this a while ago, but hadn't gotten around to contributing it back yet. There are still a few issues that I'd like opinions and/or contributions for:

  - [ ] We removed the `buildkite2` package, I'm not sure if you're willing to do that at this time. The `buildkite-agent` module now forwards to the `buildkite-agents` which I believe is not compatible with `buildkite2`.
  - [ ] The `meta-data` string option was removed in favor of the `tags` attrset option. The `openssh` options were removed in favor of the optional `sshKeyPath` option because there seems to be no point in requiring a public key and a private key might not always be necessary either. I believe this may break old configurations.

  The initial five patches I've pushed runs in production on our servers, so they're fairly well tested, but if any changes are necessary, we may not be able to test them that easily.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wicd is unable to finilize connection due to error.
user_login: Gonzih
html_url: https://github.com/NixOS/nixpkgs/issues/59359
updated_at: 2019-04-25 03:34:27
body:
  ## Issue description

  On my fresh installation of nixos with wicd enabled instead of networkmanager I get following error at the end of connection process in wicd. Wicd is able to connect to a network, but wicd-gtk ui is stuck in "Done connecting" state.

  My attempts at googling this issue pointed me at the old issues in wicd when it was crashing due to hidden networks being present. Seems like this issue was patched some time ago now.

  ```
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Starting automatic reconnect process
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Throttling autoreconnect
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Caught exception org.freedesktop.DBus.Python.TypeError: Traceback (most recent call last):
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 751, in _message_cb
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     _method_reply_return(connection, message, method_name, signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 254, in _method_reply_return
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     reply.append(signature=signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: TypeError: expected string without null bytes
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Caught exception org.freedesktop.DBus.Python.TypeError: Traceback (most recent call last):
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 751, in _message_cb
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     _method_reply_return(connection, message, method_name, signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 254, in _method_reply_return
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     reply.append(signature=signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: TypeError: expected string without null bytes
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Caught exception org.freedesktop.DBus.Python.TypeError: Traceback (most recent call last):
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 751, in _message_cb
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     _method_reply_return(connection, message, method_name, signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 254, in _method_reply_return
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     reply.append(signature=signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: TypeError: expected string without null bytes
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Caught exception org.freedesktop.DBus.Python.TypeError: Traceback (most recent call last):
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 751, in _message_cb
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     _method_reply_return(connection, message, method_name, signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 254, in _method_reply_return
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     reply.append(signature=signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: TypeError: expected string without null bytes
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: Caught exception org.freedesktop.DBus.Python.TypeError: Traceback (most recent call last):
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 751, in _message_cb
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     _method_reply_return(connection, message, method_name, signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:   File "/nix/store/vbwj8csx5nrrh3dp378qs9ci8qv7ja9q-python2.7-dbus-python-1.2.4/lib/python2.7/site-packages/dbus/service.py", line 254, in _method_reply_return
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]:     reply.append(signature=signature, *retval)
  Apr 12 11:07:00 nixos krvqc6pwinsw452757wlpnlilvcx5aqw-unit-script-wicd-start[9038]: TypeError: expected string without null bytes
  ```

  ### Steps to reproduce

  Setup clean nixos stable installation with wicd support. 
  Relevant networking section of my config:

  ```nix
  { config, pkgs, ... }:

  {
    networking = {
      # Open ports in the firewall.
      # firewall.allowedTCPPorts = [ ... ];
      # firewall.allowedUDPPorts = [ ... ];
      # Or disable the firewall altogether.
      # firewall.enable = false;

      hostName = "nixos"; # Define your hostname.
      useDHCP = false; # Don't run dhclient on wlan0
      wireless.enable = false;  # Enables wireless support via wpa_supplicant.
      networkmanager.enable = false;
      wicd.enable = true;

      # Configure network proxy if necessary
      # proxy.default = "http://user:password@proxy:port/";
      # proxy.noProxy = "127.0.0.1,localhost,internal.domain";
    };
  }
  ```

  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
    /nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev
  copying path '/nix/store/ial8a56ys2rswfq4j2abm3cl99li5b6p-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.110, NixOS, 18.09.2474.222950952f1 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: Environment variables and ~/.xsession regression on 19.03
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/issues/59360
updated_at: 2019-04-12 19:57:35
body:
  ## Issue description
  After upgrading to 19.03, Emacs can't find `SSH_AUTH_SOCK` set by gpg-agent if started from `~/.xsession`.

  In Emacs, M-x `getenv SSH_AUTH_SOCK` returns no match. However, in M-x shell, `printenv SSH_AUTH_SOCK` finds it. It's set properly in non-graphical shells too. However, processes started by Emacs (e.g. git) can't find the ssh agent.

  This is a change/regression from 18.09.


  ### Steps to reproduce
  ```
    programs.gnupg.agent = {
      enable = true;
      enableSSHSupport = true;
    };
    services.xserver.enable = true;
  ```

  ~/.xsession:
  ```
  exec emacs -q
  M-x getenv SSH_AUTH_SOCK (no match)
  M-x shell printenv SSH_AUTH_SOCK
  ```


  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - channels(alex): `"unstable-19.09pre174426.acbdaa569f4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: tomb: add sudo to buildInputs
user_login: bricewge
html_url: https://github.com/NixOS/nixpkgs/pull/59361
updated_at: 2019-04-12 23:39:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This fix the evaluation of tomb package as reported here: https://github.com/NixOS/nixpkgs/pull/57946#issuecomment-482501071.
  In `installCheckPhase` stderr is not masked anymore, that way it's easier to understand why it fail.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ympd service: Allow webPort to be int
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/59362
updated_at: 2019-05-18 11:02:23
body:
  ###### Motivation for this change

  I am lazy and don't want to type `"`. :smile:

  I don't see a reason why this should not be allowed to be int.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I did not yet test-build my system with this change.


state: closed
title: python.pkgs.{tensorflow-probability,dm-sonnet,graph_nets}: init
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59363
updated_at: 2019-04-13 21:12:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I want to work with graph networks in tensorflow. The canonical library depends on `dm-sonnet`, which in turn depends on `tensorflow-probability`.

  The `dm-sonnet` build is based on the `tensorflow` build (though greatly simplified), since I couldn't find any documentation for bazel builds.

  I tested this by building a model to predict the shortest path on graphs, as in the [example](https://colab.research.google.com/github/deepmind/graph_nets/blob/master/graph_nets/demos/shortest_path.ipynb).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: etcd not init etcd.pem with services.kubernetes.roles master
user_login: apeyroux
html_url: https://github.com/NixOS/nixpkgs/issues/59364
updated_at: 2019-05-30 13:34:47
body:
  ## Issue description

  When the `services.kubernetes.roles = ["master"]` is enabled, I have this error when starting the service etcd :

  `avril 12 18:10:01 xps15.px.io etcd[29989]: open /var/lib/kubernetes/secrets/etcd.pem: no such file or directory`

  ### Steps to reproduce

  Use `services.kubernetes.roles = ["master"]` in /etc/nixos/configuration.nix

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: (backport) nixos/manual: update 17.03 -> 19.03 in upgrading section
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/59365
updated_at: 2019-04-12 16:50:42
body:
  nixos/manual: update 17.03 -> 19.03 in upgrading section

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rustc: 1.33.0 -> 1.34.0
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/59366
updated_at: 2019-04-23 11:24:10
body:
  ###### Motivation for this change

  https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1340-2019-04-11

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/hostapd: escape interface names for hostapd
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/59367
updated_at: 2019-05-03 17:31:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Same problem as described in acbadcdbba3e768a936c88e45a843bd72ecf247c.

  When using multiple interfaces for wifi with `networking.wlanInterfaces`
  and the interface for `hostapd` contains a dash, this will fail as
  systemd escapes dashes in its device names.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/tox-node: init
user_login: suhr
html_url: https://github.com/NixOS/nixpkgs/pull/59368
updated_at: 2019-04-15 16:38:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Right now it uses the same uid as tox-bootstrapd, this probably should be changed.


state: closed
title: lib: improve the implementation of the unique function
user_login: Ekleog
html_url: https://github.com/NixOS/nixpkgs/pull/59369
updated_at: 2019-04-15 12:16:40
body:
  ###### Motivation for this change

  http://gsc.io/graph.unstable.svg

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Installation on Docker image (derived from ubuntu:18.04) does not set NIX_PATH
user_login: michaelochurch
html_url: https://github.com/NixOS/nixpkgs/issues/59370
updated_at: 2019-04-13 17:44:25
body:
  ## Issue description

  Version is 2.2.1. It's in a docker container derived from `ubuntu:18.04`.

  I can't run a number of the nix-related calls (e.g. `nix-env` to install Obsidian's obelisk project) because `$NIX_PATH` is not properly set. I don't know what it's supposed to be set to, and I believe other things are not being properly set up by the installation script. 

  ### Steps to reproduce

  Installation is from source, because other modes of installation ran in to the same problem. I run `bootstrap.sh` (even though I believe it's not needed), then `./configure`, then `make` and `make install`. 

  ## Technical details

  ```
  root@b99e6c4f2829:/nix-2.2.1# nix-shell -p nix-info --run "nix-info -m"
  error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at (string):1:13
  ```


state: closed
title: graalvm: rc8->rc15
user_login: hlolli
html_url: https://github.com/NixOS/nixpkgs/pull/59371
updated_at: 2019-05-09 17:59:34
body:
  ###### Motivation for this change
  graal is constantly changeing, and the mx build tool is becoming more important and complex. It took me a week to get this working. Few things off the bat, I use openjdk instead of oraclejdk, reason is simply that the newest openjdk works with graalvm-1.0.0rc15 but oraclejdk does not. So that means I should change the license to GPL-2.0?

  To build graalvm, I used heavily patched mx I named it mx-internal. This patched mx file is probably so patched that it's not unlikely that its intended default behavior is affected (building into home directories could be useful for example), so the vanilla mx command should work like documented.

  ###### Things done
  Bumped mx, jvmci8 and graalvm. Patched mx and graalvm when needed. Added graaljs and intend to add fastr, pythongraal and more polyglot packages. Bumped all the jar dependencies by hand, this all took quite some time, kudos to @volth for their initial work. Like with previous graal nix-expression, this does not produce Sulong's `lli` binary, I'm now looking into how to get that working.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: playonlinux: mark as broken
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59373
updated_at: 2019-04-12 21:50:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Doesn't build. CC @a1russell 

  Error message:

  ```
  ./src/check_direct_rendering.c:31:10: fatal error: X11/Xlib.h: No such file or directory
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cannot use Stack and libsodium
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/59374
updated_at: 2019-04-16 17:34:55
body:
  ## Issue description

  On Ubuntu, installing `libsodium-dev` and building a Stack project that depends on it works as expected. On NixOS it fails with `* Missing (or bad) C library: sodium` even if the libs and includes are specified with `--extra-lib-dirs=/nix/store/n6cnnyj7fq8rislwq1557f00ylpvbk9a-libsodium-1.0.16-dev/lib --extra-include-dirs=/nix/store/n6cnnyj7fq8rislwq1557f00ylpvbk9a-libsodium-1.0.16-dev/include`

  ### Steps to reproduce

  Create a Stack project with `sodium` as a dependency. Install `unstable.libsodium.dev` in a `nix-shell`'s `buildInputs`. Run `stack install` with `--extra-lib-dirs=/nix/store/n6cnnyj7fq8rislwq1557f00ylpvbk9a-libsodium-1.0.16-dev/lib --extra-include-dirs=/nix/store/n6cnnyj7fq8rislwq1557f00ylpvbk9a-libsodium-1.0.16-dev/include`. Note the error:
  ```
  Cabal-simple_mPHDZzAJ_2.2.0.1_ghc-8.4.4: Missing dependency on a foreign
      library:
      * Missing (or bad) C library: sodium
      This problem can usually be solved by installing the system package that
      provides this library (you may need the "-dev" version). If the library is
      already installed but in a non-standard location then you can use the flags
      --extra-include-dirs= and --extra-lib-dirs= to specify where it is.If the
      library file does exist, it may contain errors that are caught by the C
      compiler at the preprocessing stage. In this case you can re-run configure
      with the verbosity flag -v3 to see the error messages.
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.32, NixOS, 18.09.2505.46d3867a08a (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixpkgs-18.09.2505.46d3867a08a"`
   - channels(matt): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`


state: closed
title: aliases: add throw for font-droid
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59375
updated_at: 2019-04-13 18:20:56
body:
  ###### Motivation for this change
  See: https://discourse.nixos.org/t/no-font-droid-in-19-03/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emacs: 26.1 -> 26.2
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/59377
updated_at: 2019-04-13 06:53:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: deepin.deepin-anything: init at 0.0.7
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59378
updated_at: 2019-05-05 18:05:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add [deepin-anything](https://github.com/linuxdeepin/deepin-anything), the Deepin file search tool.

  > It is dedicated to providing Linux users with a lightning-fast file name search function and offline search.

  About packaging deepin for NixOS: https://github.com/NixOS/nixpkgs/issues/59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: enableGhostscriptFonts enabled, but no ghostscript fonts are showing up
user_login: stepcut
html_url: https://github.com/NixOS/nixpkgs/issues/59379
updated_at: 2019-04-15 16:38:02
body:
  ## Issue description

  I have `enableGhostscriptFonts = true` in my config,

  ```
        fonts = {
          enableGhostscriptFonts = true;
          fonts = with pkgs; [
    	  liberation_ttf
            fonts-arphic-ukai
          ];
        };
  ```

  The ghostscript fonts are visible to `fc-cache` and `fc-cat`, but not `fc-list` or `fc-match`.

  When I run `fc-cache -rv` the fonts are found in the ghostscript directory:

  ```
  [jeremy@webserver:/etc/fonts]$ fc-cache -rv
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share: caching, new cache contents: 0 fonts, 2 dirs
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/doc: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/doc/liberation-fonts-2.00.1: caching, new cache contents: 0 fonts, 0 dirs
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype: caching, new cache contents: 12 fonts, 0 dirs
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts/truetype: caching, new cache contents: 4 fonts, 0 dirs
  /nix/store/klfw8kyvxrn87cjc4b57p8r5lafz7yjc-ghostscript-9.25/share/ghostscript/fonts: caching, new cache contents: 52 fonts, 0 dirs
  /home/jeremy/.local/share/fonts: caching, new cache contents: 52 fonts, 0 dirs
  /nix/store/8gn2b5vvlazg608cj1y5l4igp9rckmnq-dejavu-fonts-minimal-2.37: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/8gn2b5vvlazg608cj1y5l4igp9rckmnq-dejavu-fonts-minimal-2.37/share: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/8gn2b5vvlazg608cj1y5l4igp9rckmnq-dejavu-fonts-minimal-2.37/share/fonts: caching, new cache contents: 0 fonts, 1 dirs
  /nix/store/8gn2b5vvlazg608cj1y5l4igp9rckmnq-dejavu-fonts-minimal-2.37/share/fonts/truetype: caching, new cache contents: 1 fonts, 0 dirs
  /home/jeremy/.nix-profile/lib/X11/fonts: skipping, no such directory
  /home/jeremy/.nix-profile/share/fonts: skipping, no such directory
  /nix/var/nix/profiles/default/lib/X11/fonts: skipping, no such directory
  /nix/var/nix/profiles/default/share/fonts: skipping, no such directory
  /home/jeremy/.cache/fontconfig: cleaning cache directory
  /var/cache/fontconfig: not cleaning non-existent cache directory
  /nix/store/fk7yc2rzl3gcakwqmdqar8gfznma7fha-fc-cache: not cleaning unwritable cache directory
  fc-cache: succeeded
  ```
  And `fc-cat | grep Nimbus` shows multiple matches such as:

  ```
  "n022024l.pfb" 0 "Nimbus Mono L:style=Bold Oblique:stylelang=en,en:slant=110:weight=200:width=100:foundry=urw:index=0:outline=True:scalable=True:charset=20-7e a0-17f 192 218-21b 2c6-2c7 2c9 2d8-2dd 394 3bc 400-45f 48c-4c4 4c7-4c8 4cb-4cc 4d0-4f5 4f8-4f9 2013-2014 2018-201a 201c-201e 2020-2022 2026 2030 2039-203a 2044 20ac 2116 2122 2202 2206 2211-2212 2215 2219-221a 221e 2260 2264-2265 25ca f6c3 fb01-fb02:lang=aa|ab|af|av|ay|ba|be|bg|bi|br|bs|bua|ca|ce|ch|chm|co|cs|cv|da|de|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|hr|hu|ia|id|ie|ik|io|is|it|kaa|ki|kk|kl|kum|kv|ky|la|lb|lez|lt|lv|mg|mh|mk|mo|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|os|pl|pt|rm|ro|ru|sah|se|sel|sh|sk|sl|sma|smj|smn|so|sq|sr|ss|st|sv|sw|tg|tk|tl|tn|tr|ts|tt|tyv|uk|uz|vo|vot|wa|wen|wo|xh|yap|zu|an|crh|csb|fil|hsb|ht|jv|kj|ku-tr|kwm|lg|li|mn-mn|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za:fontversion=0:fontformat=Type 1:decorative=False:postscriptname=NimbusMonL-BoldObli:color=False:symbol=False"
  ```

  But when I run `fc-list` none of the ghostscript fonts show up:

  ```
  $ fc-list
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationMono-Italic.ttf: Liberation Mono:style=Italic
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSans-Italic.ttf: Liberation Sans:style=Italic
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts/truetype/ukai.ttc: AR PL UKai TW MBE:style=Book
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSerif-Regular.ttf: Liberation Serif:style=Regular
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSans-Bold.ttf: Liberation Sans:style=Bold
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationMono-BoldItalic.ttf: Liberation Mono:style=Bold Italic
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSans-Regular.ttf: Liberation Sans:style=Regular
  /nix/store/8gn2b5vvlazg608cj1y5l4igp9rckmnq-dejavu-fonts-minimal-2.37/share/fonts/truetype/DejaVuSans.ttf: DejaVu Sans:style=Book
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSans-BoldItalic.ttf: Liberation Sans:style=Bold Italic
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationMono-Bold.ttf: Liberation Mono:style=Bold
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSerif-Bold.ttf: Liberation Serif:style=Bold
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationMono-Regular.ttf: Liberation Mono:style=Regular
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSerif-Italic.ttf: Liberation Serif:style=Italic
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts/truetype/ukai.ttc: AR PL UKai HK:style=Book
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts/truetype/ukai.ttc: AR PL UKai CN:style=Book
  /nix/store/a4zxlbgya1zcmqq4skw5ich7c1gz0brq-fonts-arphic-ukai-0.2.20080216.2/share/fonts/truetype/ukai.ttc: AR PL UKai TW:style=Book
  /nix/store/9agmxvxdpx2haqn4plrjl5ac7ki8mks3-liberation-fonts-2.00.1/share/fonts/truetype/LiberationSerif-BoldItalic.ttf: Liberation Serif:style=Bold Italic
  ```

  And `fc-match Nimbus` does not match:

  ```
  $ fc-match -s "Nimbus Mono L"
  DejaVuSans.ttf: "DejaVu Sans" "Book"
  LiberationMono-Regular.ttf: "Liberation Mono" "Regular"
  LiberationSans-Regular.ttf: "Liberation Sans" "Regular"
  LiberationSerif-Regular.ttf: "Liberation Serif" "Regular"
  ukai.ttc: "AR PL UKai CN" "Book"
  ukai.ttc: "AR PL UKai HK" "Book"
  ukai.ttc: "AR PL UKai TW MBE" "Book"
  LiberationSerif-Italic.ttf: "Liberation Serif" "Italic"
  ```

  ## Technical details

  ```
   nix-info -m
   - system: `"x86_64-linux"`
   - host os: `Linux 4.4.36, NixOS, 19.03pre-git (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-16.09.666.3738950"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: firefox, firefox-bin: 66.0.2 -> 66.0.3
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/59380
updated_at: 2019-04-13 10:47:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - bug fixes
  https://www.mozilla.org/en-US/firefox/66.0.3/releasenotes/


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: automysqlinit: init at 3.0_rc6
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59381
updated_at: 2019-04-22 12:30:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The DBAs at work use this on Debian and asked me to put this script into a cronjob on the new NixOS boxes. I thought I'd do one better and write a configurable service.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtksourceview3: re-enable tests
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59382
updated_at: 2019-04-13 05:17:05
body:
  ###### Motivation for this change
  just want to check with ofborg. works locally for me

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stretchly: init at 0.19.1
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/59383
updated_at: 2019-04-18 00:28:17
body:
  This commit adds the program `stretchly`:

  https://github.com/hovancik/stretchly

  `stretchly` is an Electron app.  Like other Electron apps in nixpkgs, this derivation just packages the binary version for Linux and rewrites rpaths with `patchelf`.  Eventually it would be nice to actually package the source version of `stretchly`.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cannot mount xfs root partition with kernel 4.19 or later
user_login: wirthan
html_url: https://github.com/NixOS/nixpkgs/issues/59384
updated_at: 2019-06-10 15:35:31
body:
  ## Issue description

  After upgrading from 18.09 to 19.03 my system fails to mount the root partition (xfs).

  It runs fsck, and later fails with:
  > mount: mounting /dev/disk/by-uuid/??? on /mnt-root/ failed: Invalid argument
  > An error occured in stage 1 of the boot process ...

  ### Steps to reproduce

  nix-channel --add https://nixos.org/channels/nixos-19.03 nixos
  nix-channel --update
  nixos-rebuild switch

  ## Technical details

  **hardware-configuration.nix:**
  ```
  boot.kernelModules = [ "kvm-intel" "xfs" ];
  fileSystems."/" =
    { device = "/dev/disk/by-uuid/32efabe2-911b-4da9-a9e1-13ec93dc1b4d";
      fsType = "xfs";
      options = ["defaults" "discard" "noatime" "nobarrier"];
    };
  ```
  **/nix/store/rlfna41bld4wlbxvg3yjackkl3nssl7w-etc-fstab:**
  ```
  /dev/disk/by-uuid/32efabe2-911b-4da9-a9e1-13ec93dc1b4d / xfs defaults,discard,noatime,nobarrier 0 1
  /dev/disk/by-uuid/D9A3-1F95 /boot vfat defaults 0 2
  /dev/disk/by-uuid/b7490d95-2dc0-4b5b-b1ae-b5d0690467b0 /home xfs defaults,discard,noatime,nobarrier 0 2
  /dev/disk/by-uuid/1028883d-0360-4779-a5ea-ee2950d6f415 /var/lib/containers xfs defaults,discard,noatime,nobarrier 0 2
  /dev/disk/by-label/swap none swap
  ```


state: closed
title: mdbook: fix Darwin support
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/59385
updated_at: 2019-04-17 17:46:55
body:
  ###### Motivation for this change

  This restores Darwin compatibility. The build is impure now as it links against system CoreFoundation, but we have no alternative.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @Havvy


state: open
title: adoptopenjdk: add version 12
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/59386
updated_at: 2019-04-28 00:44:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add AdoptOpenJDK 12.  We keep 11 since it is LTS version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitea: 1.7.5 -> 1.7.6
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/59387
updated_at: 2019-04-13 10:57:14
body:
  From [release notes](https://github.com/go-gitea/gitea/releases/tag/v1.7.6):

  SECURITY: Prevent remote code execution vulnerability with mirror repo URL settings

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: replace deprecated usage of PermissionsStartOnly (part 1)
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59389
updated_at: 2019-04-19 07:32:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  First round of code ready for merging from https://github.com/NixOS/nixpkgs/pull/56265

  ping @flokli 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dmd, gtk: Remove dontStrip because with binutils 2.31 everything is working again
user_login: ThomasMader
html_url: https://github.com/NixOS/nixpkgs/pull/59390
updated_at: 2019-05-12 15:22:36
body:
  Because binutils 2.31 is merged now https://github.com/NixOS/nixpkgs/issues/40397 is fixed and the workaround (dontStrip=true) can be removed.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03]: gitea: 1.7.5 -> 1.7.6
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/59391
updated_at: 2019-04-13 11:24:45
body:
  see #59387.

  From [release notes](https://github.com/go-gitea/gitea/releases/tag/v1.7.6):

  SECURITY: Prevent remote code execution vulnerability with mirror repo URL settings

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] gitea 1.7.6
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/59392
updated_at: 2019-04-13 11:22:45
body:
  see #59387.

  From [release notes](https://github.com/go-gitea/gitea/releases/tag/v1.7.6):

  SECURITY: Prevent remote code execution vulnerability with mirror repo URL settings

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] firefox: 66.0.2 -> 66.0.3, firefox-bin: 66.0.2 -> 66.0.3
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/59393
updated_at: 2019-04-13 14:32:13
body:
  ###### Motivation for this change

  Backport of #59380

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 19.03 LiveCD does not boot on Thinkpad P52
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/issues/59395
updated_at: 2019-04-17 19:57:30
body:
  ## Issue description

  NixOS-19.03 LiveCD hangs on Thinkpad P52 (the screen is taken with "loglevel=7 debug" added to the kernel command line):
  ![](https://i.imgur.com/0t4gumV.jpg)

  NixOS-19.03 boots only with kernels 4.4 and 4.9 (4.14, 4.19 and 5.0 hang), but in this case it does not see WiFi and Enternet.

  Other Linux LiveCDs (Manjaro, Ubuntu, Xubuntu) boot with kernel-4.19 and no problem


  ## Technical details

  https://releases.nixos.org/nixos/19.03/nixos-19.03.172138.5c52b25283a/nixos-graphical-19.03.172138.5c52b25283a-x86_64-linux.iso


state: closed
title: postgresqlPackages.pg_cron: 1.1.3 -> 1.1.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59396
updated_at: 2019-04-14 23:02:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changelog: https://github.com/rubocop-hq/rubocop/releases/tag/v0.67.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flow: 0.96.0 -> 0.97.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59397
updated_at: 2019-04-13 15:29:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog https://github.com/facebook/flow/releases/tag/v0.97.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix NixOS initrd / stage1 cross-compilation
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/59398
updated_at: 2019-04-18 13:02:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #59245

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xidlehook: 0.6.2 -> 0.7.0
user_login: jD91mZM2
html_url: https://github.com/NixOS/nixpkgs/pull/59399
updated_at: 2019-04-14 20:37:33
body:
  ###### Motivation for this change

  This version adds an `xidlehook-client` to communicate with a socket instance.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: rclone: 1.46 -> 1.47.0 using buildGoModule
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/59400
updated_at: 2019-04-14 07:27:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [v1.47.0 - 2019-04-13](https://rclone.org/changelog/#v1-47-0-2019-04-13)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @danielfullmer


state: closed
title: mxisd: 1.2.0 -> 1.4.3
user_login: mguentner
html_url: https://github.com/NixOS/nixpkgs/pull/59401
updated_at: 2019-05-19 11:00:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @fpletz @hschaeidt :spider_web: 
  I suggest to backport to 19.03


state: closed
title: lalezar-fonts: init at unstable-2017-02-28
user_login: LinArcX
html_url: https://github.com/NixOS/nixpkgs/pull/59402
updated_at: 2019-04-24 16:15:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Can't move windows using KDE with nvidiaLegacy390 on 19.03
user_login: vaibhavsagar
html_url: https://github.com/NixOS/nixpkgs/issues/59403
updated_at: 2019-05-24 15:47:47
body:
  ## Issue description

  I'm using `nvidiaLegacy390` because my video card isn't supported by the current NVIDIA driver, and using KDE I can't seem to move my windows.


  ### Steps to reproduce

  1. Use `nvidiaLegacy390`.
  2. Use KDE.


  ## Technical details

  (Can't open a browser on the machine in question)


state: closed
title: krunner-pass: Add dbus to CMakeLists (fix)
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/pull/59404
updated_at: 2019-04-17 06:39:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #59355 could be fixed by this addition, currently it seems broken on 19.03

  Another PR is opened to the upstream, but we might want to have something here to keep it working.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] Static proot, wafHook cross compilation
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/59405
updated_at: 2019-04-13 16:28:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The main purpose is to quickly backport breaking changes to recently released `wafHook`. `proot` changes are just picked up along.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gobject-introspection: 1.60.0 -> 1.60.1
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59406
updated_at: 2019-04-27 05:09:48
body:
  ###### Things done

  Updated the shlib patches:

  - Upstream now forces basename in sanitize_shlib_path(lib) if the system isn't
    darwin. We patch the function to always prefer absolute paths
  - Due to the above we no longer need the macos patch
  - `sanitize_shlib_path` is applied after `resolve_from_ldd_output` so we need to
    apply `fallback_libpath` afterwards too (else we get stuff like
    `/nix/store/...@rpath/foo.dylib` on darwin)
  - Note that the `fallback_path` no longer have any unit tests. To fix this it might be better making `sanitize_shlib_path` take  `fallback_path` as an argument and return a sanitizer which applies it, though not sure if it's a big deal.

  https://gitlab.gnome.org/GNOME/gobject-introspection/blob/1.60.1/NEWS




  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] Static proot, wafHook cross compilation
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/59407
updated_at: 2019-04-15 16:26:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The main purpose is to quickly backport breaking changes to recently released wafHook. proot changes are just picked up along.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk3: 3.24.7 -> 3.24.8
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59408
updated_at: 2019-04-17 08:22:49
body:
  https://gitlab.gnome.org/GNOME/gtk/blob/3.24.8/NEWS

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Significant number of Haskell packages unnecessarily marked as broken in 19.03
user_login: bgamari
html_url: https://github.com/NixOS/nixpkgs/issues/59409
updated_at: 2019-05-03 13:44:08
body:
  ## Issue description

  For some reason https://github.com/NixOS/nixpkgs/commit/9e7acf8b255fb4aa36d4539f49ecd5d3cca17c7b added `broken=true` to many packages in the default `haskellPackages` package set. `haskellPackages.threadscope` is one example, although there are many others.

  ### Steps to reproduce

  `nix run nixpkgs.haskellPackages.threadscope`

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a, nixpkgs-19.03"`
   - channels(ben): `"nixpkgs-19.03.172138.5c52b25283a, nixpkgs-unstable-19.09pre174594.0c0954781e2"`
   - nixpkgs: `/home/ben/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: mkcert: init at 1.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59410
updated_at: 2019-04-14 02:09:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  init https://github.com/FiloSottile/mkcert

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opam: 2.0.2 -> 2.0.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59411
updated_at: 2019-04-16 09:15:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://opam.ocaml.org/blog/opam-2-0-4/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-tree: 0.25.0 -> 0.26.0
user_login: jD91mZM2
html_url: https://github.com/NixOS/nixpkgs/pull/59412
updated_at: 2019-04-13 20:28:52
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: hexyl: 0.4.0 -> 0.5.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/59413
updated_at: 2019-04-13 23:14:31
body:
  [changelog](https://github.com/sharkdp/hexyl/releases/tag/v0.5.0)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @lilyball


state: open
title: lumo 1.9.0 -> 1.10.1 plus darwin support
user_login: hlolli
html_url: https://github.com/NixOS/nixpkgs/pull/59414
updated_at: 2019-04-13 20:24:41
body:
  ###### Motivation for this change
  New release, also some requests for adding darwin support which I implemented by adding two missing buildDependencies.

  ###### Things done
  Removed and added some npm packages, rebuilt the node10 packages files. Tested in on my linux and on MacOs Sierra in VirtualBox.

  - [ x ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ x ] NixOS
     - [ x ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ x ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk3: 3.24.7 -> 3.24.8
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59415
updated_at: 2019-04-13 20:36:42
body:
  http://ftp.acc.umu.se/pub/gnome/sources/gtk+/3.24/gtk+-3.24.8.news


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zsh-autosuggestions: 0.5.1 -> 0.5.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59416
updated_at: 2019-04-14 20:25:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/zsh-users/zsh-autosuggestions/blob/v0.5.2/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: musl: 1.1.21 -> 1.1.22
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59417
updated_at: 2019-05-01 02:08:34
body:
  https://www.openwall.com/lists/musl/2019/04/10/1


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  cc @nh2 and folks following previous musl+nixpkgs updates:

  * https://github.com/NixOS/rfcs/pull/23

  * https://github.com/NixOS/nixpkgs/pull/54440 1.1.21
  * https://github.com/NixOS/nixpkgs/pull/46064 1.1.20
  * https://github.com/NixOS/nixpkgs/pull/35360 1.1.19

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: simplenote: 1.1.3 -> 1.5.0
user_login: WhoMeNope
html_url: https://github.com/NixOS/nixpkgs/pull/59418
updated_at: 2019-05-12 02:24:43
body:
  ###### Motivation for this change

  Old version was opening a pop-up, offering an upgrade on each open.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Gnome 3.32.1
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59419
updated_at: 2019-04-17 08:22:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Mostly translation updates and few minor fixes. gjs have a few fixes for some segfaults.

  There's changelog links in the commit messages.

  Might be just a bit too large for master, not sure.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Keyboard backlight doesn't work
user_login: pinage404
html_url: https://github.com/NixOS/nixpkgs/issues/59421
updated_at: 2019-04-26 18:30:21
body:
  ## Issue description

  The keyboard backlight has never worked under NixOS but perfectly works under my Windows 10 partition

  The backlight is always powered on at full brightness in blue

  I can change the state (only until the next poweroff) if I :

  1. start under Windows 10
  2. change the brightness, the color or turn it off
  3. restart my laptop

  In this case, the keyboard backlight remains in the state (brightness, color and on / off) given under Windows 10 before the reboot

  I have a [Gigabyte Sabre 15](https://www.gigabyte.com/Laptop/Sabre-15)

  I don't know what kind of information i need to give to solve this problem

  ### Steps to reproduce

  I don't really know ¯\\_(ツ)_/¯

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.110, NixOS, 18.09.2474.222950952f1 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(pinage404): `"nixos-18.09.2505.46d3867a08a, nixos-unstable-19.09pre174426.acbdaa569f4, unstable"`
   - channels(root): `"nixos-18.09.2505.46d3867a08a"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: patchutils: 0.3.3 -> 0.3.4, keep 0.3.3 for fetchpatch
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/59422
updated_at: 2019-05-12 13:24:00
body:
  ###### Motivation for this change

  See #38618

  Closes #38618

  This upgrades patchutils from 0.3.3 -> 0.3.4. However, there were issues with its usage from `fetchpatch` combined with patchutils 0.3.4. One of the possible solutions that was raised by @dezgeg was to add both versions of patchutils. That is what I have attempted to to in this PR. 

  To test whether `fetchpatch` still works:

  ```
  nix-build -A pkgs.clightning.patches .
  ```

  Tried the following to see whether both versions of patchutils are working:

  ```
  nix-build -A pkgs.patchutils_0_3_3 .
  result/bin/lsdiff
  nix-build -A pkgs.patchutils_0_3_4 .
  result/bin/lsdiff
  ```

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Initramfs improvements
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/59423
updated_at: 2019-04-14 10:10:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes #55523

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via `nixos/tests/boot.nix` attr `biosUsb` (probably needs some more :slightly_smiling_face: )
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: journalwatch: fix broken package, general maintenance
user_login: florianjacob
html_url: https://github.com/NixOS/nixpkgs/pull/59424
updated_at: 2019-06-24 19:53:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The `journalwatch` package is broken on 19.03, as the now more strict dependency handling of `buildPythonPackage` uncovered the error of having `pytest` as `buildInput` instead of `checkInput`. This PR fixes that, along with some general maintenance:

  * Move from deprecated `permissionsStartOnly`: https://github.com/NixOS/nixpkgs/pull/56265
  * Move to `fetchFromGitHub`: https://github.com/NixOS/nixpkgs/issues/32997
  * ~~Add `service.journalwatch.package` option for easy change of used package~~

  The ee20ba8 fix pytest checks commit requires a backport to 19.03 to unbreak the package, the other commits are nice to have and should be backwards-compatible, but are not required. I'm sorry I did not notice the breakage prior release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Add libirecovery and idevicerestore
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/59427
updated_at: 2019-04-14 14:27:21
body:
  ###### Motivation for this change

  I want to restore an old iPad to factory settings.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
    - [x] not all but I tested that `idevicerestore -l -e` successfully erased an `iPad3,3` I tried it on to firmware `9.3.5 (build 13G36)` on Ubuntu 16.04 with the built binary
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This PR also removes one unnecessary `--disable-static` configure flag from a dependency.


state: closed
title: watchexec: remove Darwin hack in favor of cf-private
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/59428
updated_at: 2019-04-17 06:27:47
body:
  ###### Motivation for this change

  This removes the hack for Darwin and just uses `cf-private` instead, which does effectively the same thing but in a more standardized way.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @michalrus


state: closed
title: deepin.deepin-screenshot: fix FHS hard coded path
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59429
updated_at: 2019-04-14 00:11:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fix the use of the `fixPath` bash helper function.

  ```
      # Usage:
      #
      #   fixPath <parent dir> <path> <files>
      #
      # replaces occurences of <path> by <parent_dir><path> in <files>
      # removing /usr from the start of <path> if present
  ```

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: browsh: 1.4.13 -> 1.5.0
user_login: DanielFabian
html_url: https://github.com/NixOS/nixpkgs/pull/59430
updated_at: 2019-05-16 07:14:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  1.4.13 is broken with Firefox 66 due to a breaking change in Firefox. Browsh 1.5.0 has a fix for it. Built and tested locally.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pygal: fix build by forcing pytest_3
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59431
updated_at: 2019-05-04 18:01:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: epeg 0.9.2
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/59432
updated_at: 2019-04-24 20:21:35
body:
  New release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/deepin-menu: init
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/59433
updated_at: 2019-04-14 13:29:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add NixOS module for the [deepin-menu](https://github.com/linuxdeepin/deepin-menu) dbus service.

  About packaging deepin for NixOS: #59023

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: <nixpkgs/nixos/modules/installer/cd-dvd/system-tarball.nix> is broken
user_login: furrycatherder
html_url: https://github.com/NixOS/nixpkgs/issues/59434
updated_at: 2019-04-21 00:58:43
body:
  ## Issue description

  The module fails to evaluate since we are calling `make-system-tarball.nix` without a required argument.

  https://github.com/NixOS/nixpkgs/commit/4259f7575e5a715bf4001e22894ce95cdc06385a caused the regression. I'm not sure how to fix this.


  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: nixos: fix system-tarball
user_login: furrycatherder
html_url: https://github.com/NixOS/nixpkgs/pull/59435
updated_at: 2019-04-21 00:58:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Should fix #59434.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ace: 6.5.4 -> 6.5.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59436
updated_at: 2019-04-26 02:51:43
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ace/versions.



  meta.description for ace is: '"ADAPTIVE Communication Environment"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 6.5.5 with grep in /nix/store/j4kyzpb94brnbmssrsr62s1xfsawdc18-ace-6.5.5
  - directory tree listing: https://gist.github.com/ca656a22ec2debcb86571e5289273d37
  - du listing: https://gist.github.com/84eb6c810d68e725bc94776cd068cdcc

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  6 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ace
  yarp

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/j4kyzpb94brnbmssrsr62s1xfsawdc18-ace-6.5.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ace https://github.com/r-ryantm/nixpkgs/archive/07bcdd5ed7e1cfcf60baff60960b6a94a0f4b769.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/j4kyzpb94brnbmssrsr62s1xfsawdc18-ace-6.5.5
  ls -la /nix/store/j4kyzpb94brnbmssrsr62s1xfsawdc18-ace-6.5.5/bin
  ```


  </details>
  <br/>


  cc @nico202 for testing.


state: closed
title: acpica-tools: 20190215 -> 20190405
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59437
updated_at: 2019-04-26 02:51:46
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/acpica-tools/versions.



  meta.description for acpica-tools is: '"ACPICA Tools"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/71ea9d893e61886febba82212bc31720
  - du listing: https://gist.github.com/0f0a43683e2d7b12897300f45b83f5fd

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  acpica-tools

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/bglp6ygsafkzmvvqz3sc5wazdq1558cq-acpica-tools-20190405 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A acpica-tools https://github.com/r-ryantm/nixpkgs/archive/aaa02aec9dec43f10c467edc1ab7e671d4328e33.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/bglp6ygsafkzmvvqz3sc5wazdq1558cq-acpica-tools-20190405
  ls -la /nix/store/bglp6ygsafkzmvvqz3sc5wazdq1558cq-acpica-tools-20190405/bin
  ```


  </details>
  <br/>


  cc @tadfisher for testing.


state: open
title: hpack-convert: 1.0.1 -> 1.0.2
user_login: expipiplus1
html_url: https://github.com/NixOS/nixpkgs/pull/59438
updated_at: 2019-05-22 14:54:02
body:
  1.0.1 does not compile with the current package set


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ammonite: 1.6.4 -> 1.6.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59439
updated_at: 2019-04-26 02:51:49
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ammonite/versions.



  meta.description for ammonite is: '"Improved Scala REPL"'.

  [Release on GitHub](https://github.com/lihaoyi/Ammonite/releases/tag/1.6.6)


  [Compare changes on GitHub](https://github.com/lihaoyi/Ammonite/compare/1.6.4...1.6.6)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.6.6 with grep in /nix/store/pr972n59p7xiajg033f59kl7irhwxlzw-ammonite-1.6.6
  - directory tree listing: https://gist.github.com/95ceea6b2c49421211c2e2a8e367750a
  - du listing: https://gist.github.com/3f1bfbc699029f0dbb685b41392adcd4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ammonite

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/pr972n59p7xiajg033f59kl7irhwxlzw-ammonite-1.6.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ammonite https://github.com/r-ryantm/nixpkgs/archive/ad6cec623cc77c50f8ab5f74626bf8e10c95e83f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/pr972n59p7xiajg033f59kl7irhwxlzw-ammonite-1.6.6
  ls -la /nix/store/pr972n59p7xiajg033f59kl7irhwxlzw-ammonite-1.6.6/bin
  ```


  </details>
  <br/>


  cc @nequissimus for testing.


state: open
title: apr: 1.6.5 -> 1.7.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59440
updated_at: 2019-05-07 17:05:57
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/apr/versions.



  meta.description for apr is: '"The Apache Portable Runtime library"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.7.0 with grep in /nix/store/mq57c49lrvl3fdhfhhgw6w95ygrzci59-apr-1.7.0
  - directory tree listing: https://gist.github.com/dc7cfd39acd366a769e22b6774da6413
  - du listing: https://gist.github.com/6590aedc67790ccaee8b9c857f124612

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  414 total rebuild path(s)

  197 package rebuild(s)

  197 x86_64-linux rebuild(s)
  85 i686-linux rebuild(s)
  54 x86_64-darwin rebuild(s)
  78 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  apacheHttpd
  apacheHttpd_2_4
  apr
  aprutil
  arcanist
  cabal2nix
  chronos
  dep2nix
  drush
  gitAndTools.gitFastExport
  gitAndTools.gitFull
  gitAndTools.gitSVN
  gitAndTools.svn-all-fast-export
  gitAndTools.svn2git
  gitAndTools.svn_all_fast_export
  gitFull
  gitSVN
  gnome3.gnome-user-share
  haxe
  haxePackages.hxcpp
  haxePackages.hxcs
  haxePackages.hxjava
  haxePackages.hxnodejs_4
  haxe_3_2
  haxe_3_4
  hhvm
  hxcpp
  hydra
  icingaweb2
  kcachegrind
  kdeApplications.kcachegrind
  limesurvey
  log4cxx
  lsp-plugins
  marathon
  mate.mate-user-share
  matomo
  mesos
  mod_dnssd
  mod_fastcgi
  mod_python
  mod_wsgi
  modsecurity_standalone
  muse
  nagios
  neko
  nextcloud-news-updater
  nix-prefetch-scripts
  nix-prefetch-svn
  nix-update-source

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/mq57c49lrvl3fdhfhhgw6w95ygrzci59-apr-1.7.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A apr https://github.com/r-ryantm/nixpkgs/archive/a162a721a9dd2c1060b2878383455702130d81fa.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/mq57c49lrvl3fdhfhhgw6w95ygrzci59-apr-1.7.0
  ls -la /nix/store/mq57c49lrvl3fdhfhhgw6w95ygrzci59-apr-1.7.0/bin
  ```


  </details>
  <br/>


  cc @edolstra for testing.


state: closed
title: arc-theme: 20190213 -> 20190330
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59442
updated_at: 2019-04-26 02:51:55
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/arc-theme/versions.



  meta.description for arc-theme is: '"A flat theme with transparent elements for GTK 3, GTK 2 and Gnome-Shell"'.

  [Release on GitHub](https://github.com/NicoHood/arc-theme/releases/tag/20190330)


  [Compare changes on GitHub](https://github.com/NicoHood/arc-theme/compare/20190213...20190330)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/652c0c93fe5d2e4356aa745b842fc6c9
  - du listing: https://gist.github.com/d30ddd8b8f72958b5099580ceb902da3

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  arc-theme

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/v9fzdh80hz3qbfikz7f8rlbsif7ya2sd-arc-theme-20190330 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A arc-theme https://github.com/r-ryantm/nixpkgs/archive/201f1d678ea48b45f3bd9b124805b994518c2fd9.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/v9fzdh80hz3qbfikz7f8rlbsif7ya2sd-arc-theme-20190330
  ls -la /nix/store/v9fzdh80hz3qbfikz7f8rlbsif7ya2sd-arc-theme-20190330/bin
  ```


  </details>
  <br/>


  cc @simonvandel @romildo for testing.


