# issues

state: closed
title: `beets` does not build due to pytest build failure
user_login: nagisa
html_url: https://github.com/NixOS/nixpkgs/issues/64339
updated_at: 2019-07-06 10:19:27
body:
  ## Issue description

  Derivation `81kl20ksz7wjv6anvkmw2bxi6ki5y6z3-python3.7-pytest-3.10.1.drv` fails to build with the following log:

  <details>
  <summary>nix log 81kl20ksz7wjv6anvkmw2bxi6ki5y6z3-python3.7-pytest-3.10.1.drv</summary>

  ```
  @nix { "action": "setPhase", "phase": "unpackPhase" }
  unpacking sources
  unpacking source archive /nix/store/ai5x3bm799035kaj5abxrqickyfrgrmc-pytest-3.10.1.tar.gz
  source root is pytest-3.10.1
  setting SOURCE_DATE_EPOCH to timestamp 1541957655 of file pytest-3.10.1/src/pytest.egg-info/SOURCES.txt
  @nix { "action": "setPhase", "phase": "patchPhase" }
  patching sources
  @nix { "action": "setPhase", "phase": "configurePhase" }
  configuring
  @nix { "action": "setPhase", "phase": "buildPhase" }
  building
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib
  copying src/pytest.py -> build/lib
  creating build/lib/_pytest
  copying src/_pytest/warnings.py -> build/lib/_pytest
  copying src/_pytest/warning_types.py -> build/lib/_pytest
  copying src/_pytest/unittest.py -> build/lib/_pytest
  copying src/_pytest/tmpdir.py -> build/lib/_pytest
  copying src/_pytest/terminal.py -> build/lib/_pytest
  copying src/_pytest/stepwise.py -> build/lib/_pytest
  copying src/_pytest/skipping.py -> build/lib/_pytest
  copying src/_pytest/setupplan.py -> build/lib/_pytest
  copying src/_pytest/setuponly.py -> build/lib/_pytest
  copying src/_pytest/runner.py -> build/lib/_pytest
  copying src/_pytest/resultlog.py -> build/lib/_pytest
  copying src/_pytest/reports.py -> build/lib/_pytest
  copying src/_pytest/recwarn.py -> build/lib/_pytest
  copying src/_pytest/python_api.py -> build/lib/_pytest
  copying src/_pytest/python.py -> build/lib/_pytest
  copying src/_pytest/pytester.py -> build/lib/_pytest
  copying src/_pytest/pathlib.py -> build/lib/_pytest
  copying src/_pytest/pastebin.py -> build/lib/_pytest
  copying src/_pytest/outcomes.py -> build/lib/_pytest
  copying src/_pytest/nose.py -> build/lib/_pytest
  copying src/_pytest/nodes.py -> build/lib/_pytest
  copying src/_pytest/monkeypatch.py -> build/lib/_pytest
  copying src/_pytest/main.py -> build/lib/_pytest
  copying src/_pytest/logging.py -> build/lib/_pytest
  copying src/_pytest/junitxml.py -> build/lib/_pytest
  copying src/_pytest/hookspec.py -> build/lib/_pytest
  copying src/_pytest/helpconfig.py -> build/lib/_pytest
  copying src/_pytest/freeze_support.py -> build/lib/_pytest
  copying src/_pytest/fixtures.py -> build/lib/_pytest
  copying src/_pytest/doctest.py -> build/lib/_pytest
  copying src/_pytest/deprecated.py -> build/lib/_pytest
  copying src/_pytest/debugging.py -> build/lib/_pytest
  copying src/_pytest/compat.py -> build/lib/_pytest
  copying src/_pytest/capture.py -> build/lib/_pytest
  copying src/_pytest/cacheprovider.py -> build/lib/_pytest
  copying src/_pytest/_version.py -> build/lib/_pytest
  copying src/_pytest/_argcomplete.py -> build/lib/_pytest
  copying src/_pytest/__init__.py -> build/lib/_pytest
  creating build/lib/_pytest/assertion
  copying src/_pytest/assertion/util.py -> build/lib/_pytest/assertion
  copying src/_pytest/assertion/truncate.py -> build/lib/_pytest/assertion
  copying src/_pytest/assertion/rewrite.py -> build/lib/_pytest/assertion
  copying src/_pytest/assertion/__init__.py -> build/lib/_pytest/assertion
  creating build/lib/_pytest/_code
  copying src/_pytest/_code/source.py -> build/lib/_pytest/_code
  copying src/_pytest/_code/code.py -> build/lib/_pytest/_code
  copying src/_pytest/_code/_py2traceback.py -> build/lib/_pytest/_code
  copying src/_pytest/_code/__init__.py -> build/lib/_pytest/_code
  creating build/lib/_pytest/mark
  copying src/_pytest/mark/structures.py -> build/lib/_pytest/mark
  copying src/_pytest/mark/legacy.py -> build/lib/_pytest/mark
  copying src/_pytest/mark/evaluate.py -> build/lib/_pytest/mark
  copying src/_pytest/mark/__init__.py -> build/lib/_pytest/mark
  creating build/lib/_pytest/config
  copying src/_pytest/config/findpaths.py -> build/lib/_pytest/config
  copying src/_pytest/config/exceptions.py -> build/lib/_pytest/config
  copying src/_pytest/config/argparsing.py -> build/lib/_pytest/config
  copying src/_pytest/config/__init__.py -> build/lib/_pytest/config
  installing to build/bdist.linux-x86_64/wheel
  running install
  running install_lib
  creating build/bdist.linux-x86_64
  creating build/bdist.linux-x86_64/wheel
  creating build/bdist.linux-x86_64/wheel/_pytest
  creating build/bdist.linux-x86_64/wheel/_pytest/config
  copying build/lib/_pytest/config/__init__.py -> build/bdist.linux-x86_64/wheel/_pytest/config
  copying build/lib/_pytest/config/argparsing.py -> build/bdist.linux-x86_64/wheel/_pytest/config
  copying build/lib/_pytest/config/exceptions.py -> build/bdist.linux-x86_64/wheel/_pytest/config
  copying build/lib/_pytest/config/findpaths.py -> build/bdist.linux-x86_64/wheel/_pytest/config
  creating build/bdist.linux-x86_64/wheel/_pytest/mark
  copying build/lib/_pytest/mark/__init__.py -> build/bdist.linux-x86_64/wheel/_pytest/mark
  copying build/lib/_pytest/mark/evaluate.py -> build/bdist.linux-x86_64/wheel/_pytest/mark
  copying build/lib/_pytest/mark/legacy.py -> build/bdist.linux-x86_64/wheel/_pytest/mark
  copying build/lib/_pytest/mark/structures.py -> build/bdist.linux-x86_64/wheel/_pytest/mark
  creating build/bdist.linux-x86_64/wheel/_pytest/_code
  copying build/lib/_pytest/_code/__init__.py -> build/bdist.linux-x86_64/wheel/_pytest/_code
  copying build/lib/_pytest/_code/_py2traceback.py -> build/bdist.linux-x86_64/wheel/_pytest/_code
  copying build/lib/_pytest/_code/code.py -> build/bdist.linux-x86_64/wheel/_pytest/_code
  copying build/lib/_pytest/_code/source.py -> build/bdist.linux-x86_64/wheel/_pytest/_code
  creating build/bdist.linux-x86_64/wheel/_pytest/assertion
  copying build/lib/_pytest/assertion/__init__.py -> build/bdist.linux-x86_64/wheel/_pytest/assertion
  copying build/lib/_pytest/assertion/rewrite.py -> build/bdist.linux-x86_64/wheel/_pytest/assertion
  copying build/lib/_pytest/assertion/truncate.py -> build/bdist.linux-x86_64/wheel/_pytest/assertion
  copying build/lib/_pytest/assertion/util.py -> build/bdist.linux-x86_64/wheel/_pytest/assertion
  copying build/lib/_pytest/__init__.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/_argcomplete.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/_version.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/cacheprovider.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/capture.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/compat.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/debugging.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/deprecated.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/doctest.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/fixtures.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/freeze_support.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/helpconfig.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/hookspec.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/junitxml.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/logging.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/main.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/monkeypatch.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/nodes.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/nose.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/outcomes.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/pastebin.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/pathlib.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/pytester.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/python.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/python_api.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/recwarn.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/reports.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/resultlog.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/runner.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/setuponly.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/setupplan.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/skipping.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/stepwise.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/terminal.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/tmpdir.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/unittest.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/warning_types.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/_pytest/warnings.py -> build/bdist.linux-x86_64/wheel/_pytest
  copying build/lib/pytest.py -> build/bdist.linux-x86_64/wheel
  running install_egg_info
  running egg_info
  writing src/pytest.egg-info/PKG-INFO
  writing dependency_links to src/pytest.egg-info/dependency_links.txt
  writing entry points to src/pytest.egg-info/entry_points.txt
  writing requirements to src/pytest.egg-info/requires.txt
  writing top-level names to src/pytest.egg-info/top_level.txt
  reading manifest file 'src/pytest.egg-info/SOURCES.txt'
  writing manifest file 'src/pytest.egg-info/SOURCES.txt'
  Copying src/pytest.egg-info to build/bdist.linux-x86_64/wheel/pytest-3.10.1-py3.7.egg-info
  running install_scripts
  creating build/bdist.linux-x86_64/wheel/pytest-3.10.1.dist-info/WHEEL
  creating 'dist/pytest-3.10.1-py2.py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
  adding 'pytest.py'
  adding '_pytest/__init__.py'
  adding '_pytest/_argcomplete.py'
  adding '_pytest/_version.py'
  adding '_pytest/cacheprovider.py'
  adding '_pytest/capture.py'
  adding '_pytest/compat.py'
  adding '_pytest/debugging.py'
  adding '_pytest/deprecated.py'
  adding '_pytest/doctest.py'
  adding '_pytest/fixtures.py'
  adding '_pytest/freeze_support.py'
  adding '_pytest/helpconfig.py'
  adding '_pytest/hookspec.py'
  adding '_pytest/junitxml.py'
  adding '_pytest/logging.py'
  adding '_pytest/main.py'
  adding '_pytest/monkeypatch.py'
  adding '_pytest/nodes.py'
  adding '_pytest/nose.py'
  adding '_pytest/outcomes.py'
  adding '_pytest/pastebin.py'
  adding '_pytest/pathlib.py'
  adding '_pytest/pytester.py'
  adding '_pytest/python.py'
  adding '_pytest/python_api.py'
  adding '_pytest/recwarn.py'
  adding '_pytest/reports.py'
  adding '_pytest/resultlog.py'
  adding '_pytest/runner.py'
  adding '_pytest/setuponly.py'
  adding '_pytest/setupplan.py'
  adding '_pytest/skipping.py'
  adding '_pytest/stepwise.py'
  adding '_pytest/terminal.py'
  adding '_pytest/tmpdir.py'
  adding '_pytest/unittest.py'
  adding '_pytest/warning_types.py'
  adding '_pytest/warnings.py'
  adding '_pytest/_code/__init__.py'
  adding '_pytest/_code/_py2traceback.py'
  adding '_pytest/_code/code.py'
  adding '_pytest/_code/source.py'
  adding '_pytest/assertion/__init__.py'
  adding '_pytest/assertion/rewrite.py'
  adding '_pytest/assertion/truncate.py'
  adding '_pytest/assertion/util.py'
  adding '_pytest/config/__init__.py'
  adding '_pytest/config/argparsing.py'
  adding '_pytest/config/exceptions.py'
  adding '_pytest/config/findpaths.py'
  adding '_pytest/mark/__init__.py'
  adding '_pytest/mark/evaluate.py'
  adding '_pytest/mark/legacy.py'
  adding '_pytest/mark/structures.py'
  adding 'pytest-3.10.1.dist-info/LICENSE'
  adding 'pytest-3.10.1.dist-info/METADATA'
  adding 'pytest-3.10.1.dist-info/WHEEL'
  adding 'pytest-3.10.1.dist-info/entry_points.txt'
  adding 'pytest-3.10.1.dist-info/top_level.txt'
  adding 'pytest-3.10.1.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  @nix { "action": "setPhase", "phase": "installPhase" }
  installing
  /build/pytest-3.10.1/dist /build/pytest-3.10.1
  Processing ./pytest-3.10.1-py2.py3-none-any.whl
  Requirement already satisfied: more-itertools>=4.0.0 in /nix/store/yy87byfhinkrwqkg7jrw6gg5pmv72jwv-python3.7-more-itertools-6.0.0/lib/python3.7/site-packages (from pytest==3.10.1) (6.0.0)
  Requirement already satisfied: py>=1.5.0 in /nix/store/rckdy90j75r5g8f4444003madmgk4ka3-python3.7-py-1.7.0/lib/python3.7/site-packages (from pytest==3.10.1) (1.7.0)
  Requirement already satisfied: attrs>=17.4.0 in /nix/store/nmzcj7vdqfch4jl4ndmkf1mvdyda4xs4-python3.7-attrs-18.2.0/lib/python3.7/site-packages (from pytest==3.10.1) (18.2.0)
  Requirement already satisfied: six>=1.10.0 in /nix/store/imf48xfhb9dg8453gx131icwxrgwnwdv-python3.7-six-1.12.0/lib/python3.7/site-packages (from pytest==3.10.1) (1.12.0)
  Requirement already satisfied: setuptools in /nix/store/pwqjs8nz67h4rid05vwma9z8fbsfmm16-python3.7-bootstrapped-pip-19.1.1/lib/python3.7/site-packages (from pytest==3.10.1) (41.0.1)
  Requirement already satisfied: pluggy>=0.7 in /nix/store/ma1mczcg2x639dqiax99bda1g83nvw04-python3.7-pluggy-0.12.0/lib/python3.7/site-packages (from pytest==3.10.1) (0.12.0)
  Requirement already satisfied: atomicwrites>=1.0 in /nix/store/dv9yfmqpq49qxk8bd435x61rflbfiwnb-python3.7-atomicwrites-1.3.0/lib/python3.7/site-packages (from pytest==3.10.1) (1.3.0)
  Requirement already satisfied: importlib-metadata>=0.12 in /nix/store/s3cb27bv8m2g8izzs1pzvqvciyfis65v-python3.7-importlib-metadata-0.18/lib/python3.7/site-packages (from pluggy>=0.7->pytest==3.10.1) (0.18)
  Requirement already satisfied: zipp>=0.5 in /nix/store/jyyvg50qmi0apdlcyaz7j3cfdkp15fc6-python3.7-zipp-0.5.1/lib/python3.7/site-packages (from importlib-metadata>=0.12->pluggy>=0.7->pytest==3.10.1) (0.5.1)
  Installing collected packages: pytest
    WARNING: The scripts py.test and pytest are installed in '/nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1/bin' which is not on PATH.
    Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
  Successfully installed pytest-3.10.1
  /build/pytest-3.10.1
  @nix { "action": "setPhase", "phase": "fixupPhase" }
  post-installation fixup
  shrinking RPATHs of ELF executables and libraries in /nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1
  strip is /nix/store/qw8rhqk004qmqgnkvkpj85l1s194ang1-binutils-2.31.1/bin/strip
  stripping (with command strip and flags -S) in /nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1/lib  /nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1/bin 
  patching script interpreter paths in /nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1
  checking for references to /build/ in /nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1...
  Rewriting #!/nix/store/0f331h72l3v42szvcqyc9pqg79ghid9m-python3-3.7.3/bin/python3.7 to #!/nix/store/0f331h72l3v42szvcqyc9pqg79ghid9m-python3-3.7.3
  wrapping `/nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1/bin/pytest'...
  Rewriting #!/nix/store/0f331h72l3v42szvcqyc9pqg79ghid9m-python3-3.7.3/bin/python3.7 to #!/nix/store/0f331h72l3v42szvcqyc9pqg79ghid9m-python3-3.7.3
  wrapping `/nix/store/24c9c85nyzhvv129wdbn2g95hhax15l9-python3.7-pytest-3.10.1/bin/py.test'...
  @nix { "action": "setPhase", "phase": "installCheckPhase" }
  running install tests
  ============================= test session starts ==============================
  platform linux -- Python 3.7.3, pytest-3.10.1, py-1.7.0, pluggy-0.12.0
  hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/build/pytest-3.10.1/.hypothesis/examples')
  rootdir: /build/pytest-3.10.1, inifile: tox.ini
  plugins: hypothesis-4.7.3
  collected 2305 items / 1 deselected

  testing/acceptance_test.py ............................................. [  1%]
  .....x...................                                                [  3%]
  testing/deprecated_test.py ......................                        [  3%]
  testing/test_assertion.py ..........F

  =================================== FAILURES ===================================
  _ TestImportHookInstallation.test_installed_plugin_rewrite[development-plain] __

  self = <test_assertion.TestImportHookInstallation object at 0x7ffff36d7dd8>
  testdir = <Testdir local('/build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0')>
  mode = 'plain', plugin_state = 'development'

      @pytest.mark.parametrize("mode", ["plain", "rewrite"])
      @pytest.mark.parametrize("plugin_state", ["development", "installed"])
      def test_installed_plugin_rewrite(self, testdir, mode, plugin_state):
          # Make sure the hook is installed early enough so that plugins
          # installed via setuptools are rewritten.
          testdir.tmpdir.join("hampkg").ensure(dir=1)
          contents = {
              "hampkg/__init__.py": """
                  import pytest
      
                  @pytest.fixture
                  def check_first2():
                      def check(values, value):
                          assert values.pop(0) == value
                      return check
              """,
              "spamplugin.py": """
              import pytest
              from hampkg import check_first2
      
              @pytest.fixture
              def check_first():
                  def check(values, value):
                      assert values.pop(0) == value
                  return check
              """,
              "mainwrapper.py": """
              import pytest, pkg_resources
      
              plugin_state = "{plugin_state}"
      
              class DummyDistInfo(object):
                  project_name = 'spam'
                  version = '1.0'
      
                  def _get_metadata(self, name):
                      # 'RECORD' meta-data only available in installed plugins
                      if name == 'RECORD' and plugin_state == "installed":
                          return ['spamplugin.py,sha256=abc,123',
                                  'hampkg/__init__.py,sha256=abc,123']
                      # 'SOURCES.txt' meta-data only available for plugins in development mode
                      elif name == 'SOURCES.txt' and plugin_state == "development":
                          return ['spamplugin.py',
                                  'hampkg/__init__.py']
                      return []
      
              class DummyEntryPoint(object):
                  name = 'spam'
                  module_name = 'spam.py'
                  attrs = ()
                  extras = None
                  dist = DummyDistInfo()
      
                  def load(self, require=True, *args, **kwargs):
                      import spamplugin
                      return spamplugin
      
              def iter_entry_points(name):
                  yield DummyEntryPoint()
      
              pkg_resources.iter_entry_points = iter_entry_points
              pytest.main()
              """.format(
                  plugin_state=plugin_state
              ),
              "test_foo.py": """
              def test(check_first):
                  check_first([10, 30], 30)
      
              def test2(check_first2):
                  check_first([10, 30], 30)
              """,
          }
          testdir.makepyfile(**contents)
          result = testdir.run(
              sys.executable, "mainwrapper.py", "-s", "--assert=%s" % mode
          )
          if mode == "plain":
              expected = "E       AssertionError"
          elif mode == "rewrite":
              expected = "*assert 10 == 30*"
          else:
              assert 0
  >       result.stdout.fnmatch_lines([expected])
  E       Failed: nomatch: 'E       AssertionError'
  E           and: '============================= test session starts =============================='
  E           and: 'platform linux -- Python 3.7.3, pytest-3.10.1, py-1.7.0, pluggy-0.12.0'
  E           and: "hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/.hypothesis/examples')"
  E           and: 'rootdir: /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0, inifile:'
  E           and: 'plugins: hypothesis-4.7.3'
  E           and: 'collected 2 items'
  E           and: ''
  E           and: 'test_foo.py EE'
  E           and: ''
  E           and: '==================================== ERRORS ===================================='
  E           and: '____________________________ ERROR at setup of test ____________________________'
  E           and: 'file /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py, line 1'
  E           and: '  def test(check_first):'
  E           and: "E       fixture 'check_first' not found"
  E           and: '>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory'
  E           and: ">       use 'pytest --fixtures [testpath]' for help on them."
  E           and: ''
  E           and: '/build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py:1'
  E           and: '___________________________ ERROR at setup of test2 ____________________________'
  E           and: 'file /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py, line 4'
  E           and: '  def test2(check_first2):'
  E           and: "E       fixture 'check_first2' not found"
  E           and: '>       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory'
  E           and: ">       use 'pytest --fixtures [testpath]' for help on them."
  E           and: ''
  E           and: '/build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py:4'
  E           and: '=========================== 2 error in 0.02 seconds ============================'
  E       remains unmatched: 'E       AssertionError'

  /build/pytest-3.10.1/testing/test_assertion.py:237: Failed
  ----------------------------- Captured stdout call -----------------------------
  running: /nix/store/0f331h72l3v42szvcqyc9pqg79ghid9m-python3-3.7.3/bin/python3.7 mainwrapper.py -s --assert=plain
       in: /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0
  ============================= test session starts ==============================
  platform linux -- Python 3.7.3, pytest-3.10.1, py-1.7.0, pluggy-0.12.0
  hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/.hypothesis/examples')
  rootdir: /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0, inifile:
  plugins: hypothesis-4.7.3
  collected 2 items

  test_foo.py EE

  ==================================== ERRORS ====================================
  ____________________________ ERROR at setup of test ____________________________
  file /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py, line 1
    def test(check_first):
  E       fixture 'check_first' not found
  >       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
  >       use 'pytest --fixtures [testpath]' for help on them.

  /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py:1
  ___________________________ ERROR at setup of test2 ____________________________
  file /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py, line 4
    def test2(check_first2):
  E       fixture 'check_first2' not found
  >       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
  >       use 'pytest --fixtures [testpath]' for help on them.

  /build/pytest-of-nixbld/pytest-0/test_installed_plugin_rewrite0/test_foo.py:4
  =========================== 2 error in 0.02 seconds ============================
  =========================== short test summary info ============================
  FAIL testing/test_assertion.py::TestImportHookInstallation::()::test_installed_plugin_rewrite[development-plain]
  XFAIL testing/acceptance_test.py::TestInvocationVariants::()::test_noclass_discovery_if_not_testcase
    decide: feature or bug
  ======== 1 failed, 101 passed, 1 deselected, 1 xfailed in 28.96 seconds ========
  ```

  </details>

  ### Steps to reproduce

  `nix-build '<nixpkgs>' -A beets`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.18, NixOS, 19.09pre180487.d35692126f3 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre184734.721b391f930"`
   - channels(nagisa): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Python wheels cannot be built to nix stores containing a minus
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/issues/64340
updated_at: 2019-07-11 08:35:34
body:
  There's a bash substitution in the unpack phase that looks for the first `-` and discards everything leading up to it:
  https://github.com/NixOS/nixpkgs/blob/8f5edef47e2d7d3667148d7ea8122fb4ec6794d1/pkgs/development/interpreters/python/build-python-package-wheel.nix#L11

  This works fine if you use `/nix`
  ```
  $ src=/nix/store/0g9g34xk8qy80dsz248jkwqx5xw5600c-user-environment
  $ echo ${src#*-}
  user-environment
  ```

  But if you install nix somewhere unusual, with a minus in it, the output has slashes in in and the `cp` fails.
  ```
  $ src=/custom-prefix-foo/nix/store/0g9g34xk8qy80dsz248jkwqx5xw5600c-user-environment
  $ echo ${src#*-}
  prefix-foo/nix/store/0g9g34xk8qy80dsz248jkwqx5xw5600c-user-environment
  ```

  A possible fix is to put a call to `basename` in there, so that we only look at the name of the file (not the complete path to `$src`). So the unpack phase could be replaced with
  ```
  unpackPhase = "mkdir dist; bn=$(basename $src); cp $src dist/\${bn#*-}"
  ```

  Happy to prepare a PR to do this if it's considered sensible.

  If anyone reads this and needs a workaround, something like this should do it:
  ```
  let
    fixWheel = pkg: pkg.overrideAttrs (old: {unpackPhase = "mkdir dist; bn=$(basename $src); cp $src dist/\${bn#*-}";});

    overlay = self: super: {

      python37 = let
        packageOverrides = pyself: pysuper: {
          tensorflow-estimator = fixWheel pysuper.tensorflow-estimator;
      };
      in super.python37.override {inherit packageOverrides;};
    };

    pkgs = import <nixpkgs> { overlays = [overlay]; };
  in
    pkgs.python37.withPackages (ps: [ps.tensorflow-estimator])
  ```


state: open
title: skaffold: 0.30.0 -> 0.33.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/64341
updated_at: 2019-07-06 04:25:27
body:
  ###### Motivation for this change

  Bump to latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kustomize: 2.0.3 -> 3.0.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/64342
updated_at: 2019-07-06 07:53:32
body:
  ###### Motivation for this change

  Bump to latest release : [release notes](https://github.com/kubernetes-sigs/kustomize/blob/master/docs/v3.0.0.md).
  This also migrate the package to use `buildGoModule` as it is now using go modules.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.servant-client-core: apply patch only to 0.15
user_login: mkaito
html_url: https://github.com/NixOS/nixpkgs/pull/64343
updated_at: 2019-07-06 12:57:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  A patch was added unconditionally that only applies to 0.15, breaking
  builds of 0.14.

  ###### Things done
  Apply patch only if version is 0.15.*
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package Request: SVPManager
user_login: OpenSourceAnarchist
html_url: https://github.com/NixOS/nixpkgs/issues/64344
updated_at: 2019-07-06 00:36:56
body:
  ## Issue description

  All the components to successfully use SVP (SmoothVideoPlayer) appear to be included in Nix/NixOS. Using libsvpflow and vapoursynth (or mpv compiled with vapoursynth support) works, but I would like to use SVPManager itself for having a GUI to configure SVP parameters. It is non-free software but the license is a little ambiguous. Pinging @rnhmjoj because I believe he uses SVP on NixOS.

  Using the binary from the Download page results in an error. It will probably work OOTB with patchELF, but I don't have the skill or knowledge to write by own derivation to test.

  Note: The developer supports the ideals of GNU/Linux and specifically makes the Linux version available for free with no features restricted. Thus, the only restriction is that it uses a custom license that does not allow alteration of the source code, but does permit redistribution and non-commercial use.

  Links:
  https://www.svp-team.com/wiki/Main_Page
  https://www.svp-team.com/wiki/SVP:Linux
  http://www.svp-team.com/files/svp4-latest.php?linux
  https://aur.archlinux.org/packages/svp/
  https://aur.archlinux.org/cgit/aur.git/tree/?h=svp


state: open
title: waifu2x-converter-cpp: 5.2.4 -> 5.3 + OpenCL support
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/pull/64345
updated_at: 2019-07-13 20:42:24
body:
  Also with working tests and version info.

  ###### Motivation for this change

  OpenCL allows the program to run on AMD GPUs.

  ###### Things done
  `nix path-info -S`:
  ```
  /nix/store/jla4yvh2wsrprfbm4wkrkakk0k62s91s-waifu2x-converter-cpp-5.2.4   199550760
  /nix/store/flywi3hjjygvldcsx3ljgqkbx2dz4gsn-waifu2x-converter-cpp-5.3     199771712
  ```
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: buildGoModule modSha256 differs from unstable and 19.03
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/issues/64346
updated_at: 2019-07-05 13:02:09
body:
  ## Issue description

  It seems the `modSha256` differs between building on `unstable` and on `19.03`.

  ```shell
  λ nix run -f channel:nixos-19.03 go -c go version 
  [21 copied (591.7 MiB), 141.0 MiB DL]
  go version go1.11.6 linux/amd64
  λ nix run nixpkgs.go -c go version
  [1 copied (373.7 MiB), 95.9 MiB DL]
  go version go1.12.6 linux/amd64
  ```

  There has been so issues with go modules hashes in go 1.12, so it might be the reason why it fails.

  ### Steps to reproduce

  - Using this derivation https://github.com/vdemeester/nur-packages/blob/master/pkgs/athens/default.nix
  - Building on unstable works : [see here](https://travis-ci.com/vdemeester/nur-packages/jobs/213524332)
  - Building on 19.03 fails: [see here](https://travis-ci.com/vdemeester/nur-packages/jobs/213524330)

  ```
  fixed-output derivation produced path '/nix/store/xa2110n19mzfyiwrvwi1j9p5rh39i51r-athens-0.5.0-go-modules' with sha256 hash '0l43q3x5a2vp0s9yng8hr4pb4fh922q8vd6xf1f6qys876x4b4q5' instead of the expected hash '1fanb3mhvnldkryz74yarcwl4ma6353mfkivs5hr678g6785srqj'
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.15-300.fc30.x86_64, Fedora, 30 (Workstation Edition)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(vincent): `"home-manager, nixpkgs-19.09pre184383.e8d00113e23"`
   - nixpkgs: `/home/vincent/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: janet: 0.6.0 -> 1.0.0, build with meson
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/64347
updated_at: 2019-07-06 01:10:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/janet-lang/janet/releases/tag/v1.0.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @andrewchambers 


state: closed
title: pythonPackages.soco: 0.16 -> 0.17
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/64348
updated_at: 2019-07-06 12:25:59
body:
  Now works with latest pytestcov

  This transitively fixes beets (fixes https://github.com/NixOS/nixpkgs/issues/64339) which depends on soco, which now doesn't depend on
  pytest_3 anymore, which depends on pytestcov_3, which is broken.

  An upstream PR for the patch here has been submitted: https://github.com/SoCo/SoCo/pull/670

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cloudflared: 2018.10.3 -> 2019.7.0
user_login: ericnorris
html_url: https://github.com/NixOS/nixpkgs/pull/64349
updated_at: 2019-07-13 18:40:16
body:
  ###### Motivation for this change

  Updating `cloudflared` to `2019.7.0`. I've also switched to using the tagged release in the `rev` field, and included the version in the build flags. I've left the built date unspecified, wasn't sure how to do that and maintain a reproducible build.

  ```
  $ ./result-bin/bin/cloudflared --version
  cloudflared version 2019.7.0 (built unknown)
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Git package unnecessarily depends on GCC
user_login: demin-dmitriy
html_url: https://github.com/NixOS/nixpkgs/issues/64350
updated_at: 2019-07-06 17:37:57
body:
  ## Issue description

  On current master c7276b2b3d05e5191a9b5b7236d63edf49204f79 package gitMinimal depends on gcc, which blows up it's closure size.

  ### Steps to reproduce
  ```sh
  $ nix-store -qR $(nix-build . -A gitMinimal --no-out-link) | grep gcc
  /nix/store/dmgpvd9nl7qa0ydzlqxvdhmxgmq1d1il-gcc-7.4.0-lib
  /nix/store/n4q167a25rkvb043rf0sw7z4cixgv48x-gcc-7.4.0

  $ nix path-info -f . -r gitMinimal -S | sort -k2h | tail -n3
  /nix/store/vyqkax7dmh1jb62klccmwkg00b9951zz-openssl-1.0.2s-dev             90747512
  /nix/store/n4q167a25rkvb043rf0sw7z4cixgv48x-gcc-7.4.0                     177044600
  /nix/store/835jdm4r0xwwnpi0a1683dmmj40065mm-git-2.22.0               	  345567656
  ```

  ## Technical details

  On very old version of nixpkgs (6c064e6b1f34a8416f990db0cc617a7195f71588)  there was no such problem:

  ```sh
  $ nix-store -qR $(nix-build . -A gitMinimal --no-out-link) | grep gcc
  /nix/store/qc84dvliy1dzpidw10yvpi3di5f0q4vj-gcc-7.3.0-lib

  $ nix path-info -f . -r gitMinimal -S | sort -k2h | tail -n3
  /nix/store/ggb7k5x9855j10dz99467djx4rplg32b-perl-5.24.3               	   79216672
  /nix/store/1c0dmikm575as2jqfi07zydwzfpf5jzy-perl-libwww-perl-6.15     	   80209176
  /nix/store/mivirzq63vv8rwm58fl7x7nc6jfzr27w-git-2.17.0                	  152274288
  ```


state: closed
title: fix: #64340 building python wheels in non-standard store
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/pull/64351
updated_at: 2019-07-11 10:01:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This fixes issue #64340 which prevents Python wheels being installed in nix stores that contain at `-`.

  I've tested it with
  ```
  nix-build -E 'with import ./default.nix {}; python37.withPackages (p: [p.tensorflow-estimator p.ipython p.tensorflow])'
  ```
  and checked I can import tensorflow. I did *not* test it with a non-standard store path (I don't have access to one easily right now) but am happy to do so.

  I'm not sure of the contributing conventions for PRs that don't concern specific packages or nixos modules, happy to make any changes required.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Steam: Valve Index not detected
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/64352
updated_at: 2019-07-09 22:07:04
body:
  ## Issue description

  I connected my Valve Index while having Steam and SteamVR started, but it was not detected.

  Steam log when connecting the HMD:

  ```
  sh: lsusb: command not found
  sh: lsusb: command not found
  sh: lsusb: command not found
  Local Device Found
    type: 045e 001b
    path: sdl://0
    serial_number:  - 0
    Manufacturer: 
    Product:      Microsoft SideWinder Force Feedback 2 Joystick
    Release:      100
    Interface:    -1
  ```

  I will try to fix it by adding `lsusb` to Steam package.

  syslog:
  ```

  Jul 04 22:52:02 gaming kernel: usb 3-1.3: new high-speed USB device number 28 using xhci_hcd
  Jul 04 22:52:02 gaming kernel: usb 3-1.3: New USB device found, idVendor=28de, idProduct=2613, bcdDevice= 1.82
  Jul 04 22:52:02 gaming kernel: usb 3-1.3: New USB device strings: Mfr=0, Product=0, SerialNumber=0
  Jul 04 22:52:02 gaming kernel: hub 3-1.3:1.0: USB hub found
  Jul 04 22:52:02 gaming kernel: hub 3-1.3:1.0: 3 ports detected
  Jul 04 22:52:05 gaming kernel: usb 3-1.3.3: new high-speed USB device number 29 using xhci_hcd
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3: New USB device found, idVendor=0424, idProduct=2744, bcdDevice= 2.21
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3: New USB device strings: Mfr=1, Product=2, SerialNumber=0
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3: Product: USB2744
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3: Manufacturer: Microchip Tech
  Jul 04 22:52:06 gaming kernel: hub 3-1.3.3:1.0: USB hub found
  Jul 04 22:52:06 gaming kernel: hub 3-1.3.3:1.0: 5 ports detected
  Jul 04 22:52:06 gaming kernel: usb 4-3: new SuperSpeed Gen 1 USB device number 32 using xhci_hcd
  Jul 04 22:52:06 gaming kernel: usb 4-3: New USB device found, idVendor=0424, idProduct=5744, bcdDevice= 2.21
  Jul 04 22:52:06 gaming kernel: usb 4-3: New USB device strings: Mfr=2, Product=3, SerialNumber=0
  Jul 04 22:52:06 gaming kernel: usb 4-3: Product: USB5744
  Jul 04 22:52:06 gaming kernel: usb 4-3: Manufacturer: Microchip Tech
  Jul 04 22:52:06 gaming kernel: hub 4-3:1.0: USB hub found
  Jul 04 22:52:06 gaming kernel: hub 4-3:1.0: 4 ports detected
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: new full-speed USB device number 30 using xhci_hcd
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: New USB device found, idVendor=28de, idProduct=2300, bcdDevice= 2.00
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: Product: Index HMD
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: Manufacturer: Valve
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.1: SerialNumber: LHR-89917901
  Jul 04 22:52:06 gaming kernel: hid-generic 0003:28DE:2300.0022: hiddev99,hidraw5: USB HID v1.11 Device [Valve Index HMD] on usb-0000:23:00.0-1.3.3.1/input0
  Jul 04 22:52:06 gaming kernel: hid-generic 0003:28DE:2300.0023: hiddev100,hidraw6: USB HID v1.11 Device [Valve Index HMD] on usb-0000:23:00.0-1.3.3.1/input1
  Jul 04 22:52:06 gaming kernel: hid-generic 0003:28DE:2300.0024: hiddev101,hidraw7: USB HID v1.11 Device [Valve Index HMD] on usb-0000:23:00.0-1.3.3.1/input2
  Jul 04 22:52:06 gaming mtp-probe[8225]: checking bus 3, device 30: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.1"
  Jul 04 22:52:06 gaming mtp-probe[8225]: bus: 3, device: 30 was not an MTP device
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.5: new high-speed USB device number 31 using xhci_hcd
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.5: New USB device found, idVendor=0424, idProduct=2740, bcdDevice= 2.00
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.5: New USB device strings: Mfr=1, Product=2, SerialNumber=0
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.5: Product: Hub Controller
  Jul 04 22:52:06 gaming kernel: usb 3-1.3.3.5: Manufacturer: Microchip Tech
  Jul 04 22:52:06 gaming mtp-probe[8230]: checking bus 3, device 31: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.5"
  Jul 04 22:52:06 gaming mtp-probe[8230]: bus: 3, device: 31 was not an MTP device
  Jul 04 22:52:06 gaming mtp-probe[8234]: checking bus 3, device 31: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.5"
  Jul 04 22:52:06 gaming mtp-probe[8234]: bus: 3, device: 31 was not an MTP device
  Jul 04 22:52:06 gaming mtp-probe[8235]: checking bus 3, device 30: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.1"
  Jul 04 22:52:06 gaming mtp-probe[8235]: bus: 3, device: 30 was not an MTP device
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: new full-speed USB device number 32 using xhci_hcd
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: New USB device found, idVendor=28de, idProduct=2102, bcdDevice= 1.00
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: Product: Valve VR Radio
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: Manufacturer: Valve Corporation
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.2: SerialNumber: C27DFDD863-RYB
  Jul 04 22:52:07 gaming kernel: hid-generic 0003:28DE:2102.0025: hiddev102,hidraw8: USB HID v1.11 Device [Valve Corporation Valve VR Radio] on usb-0000:23:00.0-1.3.3.2/input0
  Jul 04 22:52:07 gaming kernel: cdc_acm 3-1.3.3.2:1.1: ttyACM0: USB ACM device
  Jul 04 22:52:07 gaming mtp-probe[8245]: checking bus 3, device 32: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.2"
  Jul 04 22:52:07 gaming mtp-probe[8245]: bus: 3, device: 32 was not an MTP device
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: new full-speed USB device number 33 using xhci_hcd
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: New USB device found, idVendor=28de, idProduct=2102, bcdDevice= 1.00
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: New USB device strings: Mfr=1, Product=2, SerialNumber=3
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: Product: Valve VR Radio & HMD Mic
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: Manufacturer: Valve Corporation
  Jul 04 22:52:07 gaming kernel: usb 3-1.3.3.3: SerialNumber: 8E42C2C784-LYM
  Jul 04 22:52:07 gaming kernel: hid-generic 0003:28DE:2102.0026: hiddev103,hidraw9: USB HID v1.11 Device [Valve Corporation Valve VR Radio & HMD Mic] on usb-0000:23:00.0-1.3.3.3/input0
  Jul 04 22:52:07 gaming mtp-probe[8250]: checking bus 3, device 33: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.3"
  Jul 04 22:52:07 gaming mtp-probe[8250]: bus: 3, device: 33 was not an MTP device
  Jul 04 22:52:07 gaming mtp-probe[8255]: checking bus 3, device 32: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.2"
  Jul 04 22:52:07 gaming mtp-probe[8255]: bus: 3, device: 32 was not an MTP device
  Jul 04 22:52:07 gaming systemd-udevd[8253]: Process '/nix/store/85y79rb3hcm878jfyv6wf67p2vicj3j8-alsa-utils-1.1.8/sbin/alsactl restore 2' failed with exit code 99.
  Jul 04 22:52:07 gaming mtp-probe[8258]: checking bus 3, device 33: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb3/3-1/3-1.3/3-1.3.3/3-1.3.3.3"
  Jul 04 22:52:07 gaming mtp-probe[8258]: bus: 3, device: 33 was not an MTP device
  Jul 04 22:52:07 gaming rtkit-daemon[1896]: Supervising 3 threads of 1 processes of 1 users.
  Jul 04 22:52:07 gaming rtkit-daemon[1896]: Successfully made thread 8261 of process 1894 (/nix/store/jkbs2xf673axs4gdayl8zpycb6n515rx-pulseaudio-12.2/bin/pulseaudio) owned by 'davidak' RT at priority 5.
  Jul 04 22:52:07 gaming rtkit-daemon[1896]: Supervising 4 threads of 1 processes of 1 users.
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: new SuperSpeed Gen 1 USB device number 33 using xhci_hcd
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: New USB device found, idVendor=28de, idProduct=2400, bcdDevice= 0.04
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: Product: 3D Camera
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: Manufacturer: Etron Technology, Inc.
  Jul 04 22:52:08 gaming kernel: usb 4-3.1: SerialNumber: 00000001
  Jul 04 22:52:08 gaming kernel: uvcvideo: Found UVC 1.00 device 3D Camera (28de:2400)
  Jul 04 22:52:09 gaming kernel: uvcvideo 4-3.1:1.0: Entity type for entity Extension 4 was not initialized!
  Jul 04 22:52:09 gaming kernel: uvcvideo 4-3.1:1.0: Entity type for entity Processing 3 was not initialized!
  Jul 04 22:52:09 gaming kernel: uvcvideo 4-3.1:1.0: Entity type for entity Camera 1 was not initialized!
  Jul 04 22:52:09 gaming kernel: input: 3D Camera: eTronVideo as /devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb4/4-3/4-3.1/4-3.1:1.0/input/input29
  Jul 04 22:52:09 gaming mtp-probe[8270]: checking bus 4, device 33: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb4/4-3/4-3.1"
  Jul 04 22:52:09 gaming mtp-probe[8270]: bus: 4, device: 33 was not an MTP device
  Jul 04 22:52:09 gaming mtp-probe[8281]: checking bus 4, device 33: "/sys/devices/pci0000:20/0000:20:09.0/0000:23:00.0/usb4/4-3/4-3.1"
  Jul 04 22:52:09 gaming mtp-probe[8281]: bus: 4, device: 33 was not an MTP device
  ```

  ### Steps to reproduce

  1. open Steam and Steam VR
  1. connect your Valve Index HMD ;)
  1. SteamVR should display the headset, controllers and base stations

  It works on Windows 10.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.56, NixOS, 19.03.173028.7152cb297ad (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173028.7152cb297ad, nixos-hardware, nixos-unstable-19.09pre184359.73392e79aa6"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: gimp-with-plugins: Fix build errors with exiv2-0.27.1
user_login: neilmayhew
html_url: https://github.com/NixOS/nixpkgs/pull/64353
updated_at: 2019-07-12 18:34:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: soundtouch: CVE-2018-1000223 CVE-2018-14044 CVE-2018-14045
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64354
updated_at: 2019-07-07 06:09:49
body:
  ###### Motivation for this change

  Fixes #64187.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/ksm: add option sleep
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/64355
updated_at: 2019-07-06 08:15:50
body:
  ##### Motivation for this change
  Add option sleep to allow change interval before next scan.
  This option is needed to optimize the netdata service - https://docs.netdata.cloud/database/#ksm

  cc @Mic92 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Steam: build fails on stable (URL broken)
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/64356
updated_at: 2019-07-06 08:22:54
body:
  ## Issue description

  It's this issue again:

  ```
  Checking that all programs called by relative paths in udev rules exist in /nix/store/nih5bga6fwphwm1la0wy2pxnv2wng675-systemd-239.20190219/lib/udev... OK
  Checking that all programs called by absolute paths in udev rules exist... OK

  trying http://repo.steampowered.com/steamrt/pool/main/g/gcc-5/gcc-5-base_5.4.0-7.really.6+steamrt1.1+srt2_i386.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  building '/nix/store/khyj03mz00q357nx3dw8hniwf5kdwk3y-libcomerr2.deb.drv'...

  trying http://repo.steampowered.com/steamrt/pool/main/e/e2fsprogs/libcomerr2_1.42-1ubuntu2.3+srt1_amd64.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying https://abbradar.net/steamrt/pool/main/g/gcc-5/gcc-5-base_5.4.0-7.really.6+steamrt1.1+srt2_amd64.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying https://abbradar.net/steamrt/pool/main/g/gcc-5/gcc-5-base_5.4.0-7.really.6+steamrt1.1+srt2_i386.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed

  trying http://repo.steampowered.com/steamrt/pool/main/e/e2fsprogs/libcomerr2_1.42-1ubuntu2.3+srt1_i386.deb
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying https://abbradar.net/steamrt/pool/main/e/e2fsprogs/libcomerr2_1.42-1ubuntu2.3+srt1_amd64.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100   162  100   162    0     0    566      0 --:--:-- --:--:-- --:--:--   566
  100   162  100   162    0     0    532      0 --:--:-- --:--:-- --:--:--   532
  100   162  100   162    0     0    568      0 --:--:-- --:--:-- --:--:--   566
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying https://abbradar.net/steamrt/pool/main/e/e2fsprogs/libcomerr2_1.42-1ubuntu2.3+srt1_i386.deb
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404
  error: cannot download gcc-5-base.deb from any mirror
  builder for '/nix/store/qvkymaxh2gny22bvcglzaga2niihi891-gcc-5-base.deb.drv' failed with exit code 1
  building '/nix/store/2smbkxdvrf5gz9lg3cv8d9bhknicwky7-libgcc1.deb.drv'...
  building '/nix/store/sr3rg53ciy76n33ll9qyscr6ljwf4h63-libgomp1.deb.drv'...
  cannot build derivation '/nix/store/aghh1zqyn176ri01ca9r430ski40z4i1-steam-runtime.json.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/bnrmykgax0dmxh8hny5j2skkp8l0j7h1-steam-runtime-2016-08-13.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/fkyj8mw5sv8w1l4m3fsr4sqspycn70sz-steam-runtime-wrapped.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/0jy9cgblbzf3ian89bxrg4rwrd7yq1bg-steam-run-usr-target.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/ksvjrxavvbavhk3fw9860nhw8i5590h5-steam-usr-target.drv': 1 dependencies couldn't be built
  building '/nix/store/72l98mxm6ziipxw617lasxw4g9w772l0-nix.conf.drv'...
  building '/nix/store/8apcshlh3x8w8jnn2wds33nr4238vmsz-nvidia-x11-415.27-4.19.34.drv'...
  cannot build derivation '/nix/store/v6d89bss13i82d3kq8xzrirsa6zg1saz-steam-fhs.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/ci9d0y26l1wvjs9770i59ajysz87p10g-steam-run-fhs.drv': 1 dependencies couldn't be built
  building '/nix/store/nzaxcnnf7sk7wfma98qj3mnwqg576w3l-unit-docker.service.drv'...
  building '/nix/store/69cd1z0krzyshvg3ccypxq02r7d7lvs4-unit-nix-optimise.service.drv'...
  cannot build derivation '/nix/store/s1nsgbbpi8xcjv9bqqpgczizlksvs7ja-steam-init.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/zx0nj90cxynl9gbrp0x5l601sf23lvhn-steam-run-init.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/46w6xnwaih135zhdiz31y8d3j41kl1bv-steam-run.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/xj44vy9bgdmvqc8br0h2j5x9l1hr9dgs-steam.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/w7s14ww3h5ybxhnp5lciq1ydw9azp95m-system-path.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/w3m14ciy6hnbgcyw91lsh2jhy5jvkadg-nixos-system-gaming-19.03.git.b3318aa.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/w3m14ciy6hnbgcyw91lsh2jhy5jvkadg-nixos-system-gaming-19.03.git.b3318aa.drv' failed
  ```

  cc @abbradar 

  ### Steps to reproduce



  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.56, NixOS, 19.03.173028.7152cb297ad (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173028.7152cb297ad, nixos-hardware, nixos-unstable-19.09pre184359.73392e79aa6"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Backport SteamVR fix
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/pull/64357
updated_at: 2019-07-06 08:25:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This should at least fix the error messages from https://github.com/NixOS/nixpkgs/issues/64352.

  Can't build because of https://github.com/NixOS/nixpkgs/issues/64356!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pyspark fails: `SyntaxError: invalid syntax`
user_login: tscholak
html_url: https://github.com/NixOS/nixpkgs/issues/64358
updated_at: 2019-07-13 14:34:59
body:
  ## Issue description
  `pyspark` won't run because it tries to figure our where the spark home is but to no avail.

  ### Steps to reproduce
  ```
  $ nix-shell -p "python37.withPackages(ps: with ps; [ pyspark ])"
  $ pyspark
    File "/Users/tscholak/.nix-profile/bin/find_spark_home.py", line 2
      export PATH='/nix/store/6lx2gmb5hk4bnyxrm7ldda6yg7rrpbgy-python3-3.7.3/bin:/nix/store/rv0s6hdy0bjzjlrm0xs51lrxhzx5p698-python3.7-pyspark-2.4.3/bin:/nix/store/5fcf9jrs3l4kzcimy5i27jk56wqq90g8-python3.7-setuptools-41.0.1/bin'${PATH:+':'}$PATH
                ^
  SyntaxError: invalid syntax
  /Users/tscholak/.nix-profile/bin/pyspark: line 24: /bin/load-spark-env.sh: No such file or directory
  /Users/tscholak/.nix-profile/bin/pyspark: line 77: /bin/spark-submit: No such file or directory
  /Users/tscholak/.nix-profile/bin/pyspark: line 77: exec: /bin/spark-submit: cannot execute: No such file or directory
  ```

  `/Users/tscholak/.nix-profile/bin/find_spark_home.py` is a shell script,
  ```
  #! /nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/bash -e
  export PATH='/nix/store/6lx2gmb5hk4bnyxrm7ldda6yg7rrpbgy-python3-3.7.3/bin:/nix/store/rv0s6hdy0bjzjlrm0xs51lrxhzx5p698-python3.7-pyspark-2.4.3/bin:/nix/store/5fcf9jrs3l4kzcimy5i27jk56wqq90g8-python3.7-setuptools-41.0.1/bin'${PATH:+':'}$PATH
  export PYTHONNOUSERSITE='true'
  exec -a "$0" "/nix/store/rv0s6hdy0bjzjlrm0xs51lrxhzx5p698-python3.7-pyspark-2.4.3/bin/.find_spark_home.py-wrapped"  "${extraFlagsArray[@]}" "$@"
  ```
  but somehow it got a `.py` extension and is being run by python.

  ## Workaround
  A look into the `pyspark` script shows that `find_spark_home` is not called if the `SPARK_HOME` environment variable is set. Hence this works:
  ```
  $ nix-shell -p "python37.withPackages(ps: with ps; [ pyspark ])"
  $ export SPARK_HOME=`sh /Users/tscholak/.nix-profile/bin/find_spark_home.py`
  $ pyspark --help
  Usage: ./bin/pyspark [options]
  ...
  ```

  ## Technical details
  ```
  $ nix-shell -p nix-info --run "nix-info -m"                                                                                                                                              
   - system: `"x86_64-darwin"`
   - host os: `Darwin 18.6.0, macOS 10.14.5`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(tscholak): `"nixpkgs-19.09pre184777.df738814d1b"`
   - channels(root): `"nixpkgs-19.09pre178895.9ebc6ad944c"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
  ```


state: open
title: Stuck trying to add a binary cache
user_login: Thra11
html_url: https://github.com/NixOS/nixpkgs/issues/64359
updated_at: 2019-07-07 12:15:58
body:
  ## Issue description
  This may be user error...

  I followed the instructions in the wiki to install the armv6l sd-card image and run it on a raspberry pi zerow. However, I seem to be in a catch-22 situation with respect to binary caches:
  1. I want to add `http://nixos-arm.dezgeg.me/channel` as a binary cache.
  2. `/etc/nix/nix.conf` is a symlink to a file in the nix store: to change its contents, I need to edit `/etc/nixos/configuration.nix` and run `nixos-rebuild switch`.
  3. If I run `nixos-rebuild switch` without an armv6l binary cache configured, it tries to rebuild the world, which simply isn't practical on such a feeble processor.
  4. I try to use `--option binary-caches "http://nixos-arm.dezgeg.me/channel"` to specify the binary cache: It fails because the 
  5. As far as I can tell, there's no way to specify `binaryCachePublicKeys` or disable `requireSignedBinaryCaches` on the command line.
  6. I can specify `binaryCachePublicKeys` or disable `requireSignedBinaryCaches` in `/etc/nixos/configuration.nix`, but it won't take effect until I successfully run `nixos-rebuild`
  7. Goto 3.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"armv6l-linux"`
   - host os: `Linux 4.14.50, NixOS, 19.03.git.ca2ba44cab4 (Koi)`
   - multi-user?: `yes`


state: open
title: tor-browser: install fails due to missing noscript xpi
user_login: kazcw
html_url: https://github.com/NixOS/nixpkgs/issues/64360
updated_at: 2019-07-05 23:24:59
body:
  ## Issue description
  The noscript xpi is failing to download from the mirror (informaction).


  ### Steps to reproduce
  `nix-shell -p tor-browser-bundle`


  ## Workaround
  I don't know if there's a more reliable mirror available, but as a workaround I used nix-prefetch-url to get the file 'noscript-8.1.2.xpi' from some website ( https://legacycollector.org/firefox-addons/722/index.html ) and it passed hash check.


state: open
title: tor-browser-bundle-bin no longer available from mirrors
user_login: kazcw
html_url: https://github.com/NixOS/nixpkgs/issues/64361
updated_at: 2019-07-11 22:45:32
body:
  [user@machine:~]$ nix-shell -p tor-browser-bundle-bin
  these derivations will be built:
    /nix/store/fdas7z9nxc0hv087vlcazibq8pvzbysk-torbrowser.desktop.drv
    /nix/store/mvsdahhywqpqcp9f7ly1pyxn485pdy8i-tor-browser-linux64-8.0.8_en-US.tar.xz.drv
    /nix/store/faxypah6i57a5sc69s7r6rv2cq8x3syi-tor-browser-bundle-bin-8.0.8.drv
  building '/nix/store/mvsdahhywqpqcp9f7ly1pyxn485pdy8i-tor-browser-linux64-8.0.8_en-US.tar.xz.drv'...
  building '/nix/store/fdas7z9nxc0hv087vlcazibq8pvzbysk-torbrowser.desktop.drv'...

  trying https://github.com/TheTorProject/gettorbrowser/releases/download/v8.0.8/tor-browser-linux64-8.0.8_en-US.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying https://dist.torproject.org/torbrowser/8.0.8/tor-browser-linux64-8.0.8_en-US.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download tor-browser-linux64-8.0.8_en-US.tar.xz from any mirror
  builder for '/nix/store/mvsdahhywqpqcp9f7ly1pyxn485pdy8i-tor-browser-linux64-8.0.8_en-US.tar.xz.drv' failed with exit code 1
  cannot build derivation '/nix/store/faxypah6i57a5sc69s7r6rv2cq8x3syi-tor-browser-bundle-bin-8.0.8.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/faxypah6i57a5sc69s7r6rv2cq8x3syi-tor-browser-bundle-bin-8.0.8.drv' failed


state: open
title: chezmoi: 1.3.0 -> 1.5.5
user_login: jhillyerd
html_url: https://github.com/NixOS/nixpkgs/pull/64362
updated_at: 2019-07-06 04:19:07
body:
  ###### Motivation for this change

  Update to a recent version.  Note that I chose 1.5.5 over the newer releases (1.5.6 .. 1.5.10), as those releases rely on a [temporary dependency repo](https://github.com/twpayne/chezmoi/blob/v1.5.10/go.mod#L43) that is likely to vanish in the future.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Cannot import opencv python module
user_login: OmnipotentEntity
html_url: https://github.com/NixOS/nixpkgs/issues/64363
updated_at: 2019-07-09 22:47:29
body:
  ## Issue description

  When attempting to run a minimal python file:

      import cv2

  While having the python package `opencv` installed, I receive 

      ModuleNotFoundError: No module named 'cv2'

  ### Steps to reproduce

      $ nix-shell -p "python3.withPackages(ps: with ps; [ opencv ])"
      $ echo "import cv2" | python3 -

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37, NixOS, 19.03.173054.754763ff4ba (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173054.754763ff4ba"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Allow NetworkManager and wireless together
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/64364
updated_at: 2019-07-09 11:40:30
body:
  ###### Motivation for this change
  When NetworkManager is configured to not manage all interfaces, it's
  perfectly fine to have the rest be managed by the standard nixos
  wireless scripts.

  I use
  ```
    networking.networkmanager.unmanaged = [
      "*" "except:type:wwan" "except:type:gsm"
    ];
  ```
  to control everything using networking.wireless except for the mobile
  LTE modem which only works with NetworkManager.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/64365
updated_at: 2019-07-20 12:23:55
title:
  nixos/tt-rss: remove deprecated usage of PermissionsStartOnly, specify a group to run service as, and fix local pgsql database creation

body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/55370
  https://github.com/NixOS/nixpkgs/issues/53852
  https://github.com/NixOS/nixpkgs/issues/40437 (partial fix)
  ~~https://github.com/NixOS/nixpkgs/issues/64312 (potential fix?)~~

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ping @edermi @matthiasbeyer @telotortium for testing and review please.


state: closed
title: pjsip: 2.8 -> 2.9
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/64366
updated_at: 2019-07-15 06:05:37
body:
  ###### Motivation for this change
  Upgrade and make sure it works on aarch64.
  Obsoletes and fixes #64111

  Builds with `nix-build -A pkgsCross.aarch64-multiplatform.pjsip` and doesn't immediately crash with `qemu-aarch64 ./result/bin/pjsua`. So it should be fine :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cue: init at 0.0.3
user_login: solson
html_url: https://github.com/NixOS/nixpkgs/pull/64367
updated_at: 2019-07-06 07:40:37
body:
  ###### Motivation for this change

  Packaging a new development tool, [CUE](https://github.com/cuelang/cue). Despite the 0.0.3 version number, it seems pretty usable.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This is my first time packaging a Go program, so let me know if I'm doing anything poorly.


state: open
title: Cannot set default cpu frequency governor
user_login: fdietze
html_url: https://github.com/NixOS/nixpkgs/issues/64368
updated_at: 2019-07-17 15:53:29
body:
  ## Issue description
  I have the following in my `configuration.nix`:

  ```nix
    powerManagement = {
      enable = true;
      cpuFreqGovernor = "powersave";
    };
  ```

  But when I boot, the governor is set to `performance`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.57, NixOS, 19.03.173052.aef662d2eb5 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(felix): `"nixpkgs-19.09pre184359.73392e79aa6"`
   - channels(root): `"nixos-19.03.173052.aef662d2eb5, nixos-hardware, nixpkgs-unstable-19.09pre182717.b58ada326aa"`
   - nixpkgs: `/home/felix/.nix-defexpr/channels/nixpkgs`


state: closed
title: openjpeg: CVE-2019-12973
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64369
updated_at: 2019-07-17 10:03:57
body:
  ###### Motivation for this change

  Fixes #64182

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 19.03: openjpeg: CVE-2019-12973
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64370
updated_at: 2019-07-20 07:49:52
body:
  (cherry picked from commit 011dc3701840574d47808b0708320b23d22deae3)

  ###### Motivation for this change

  Fixes #64182.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghc: Don't strip compilers
user_login: mpickering
html_url: https://github.com/NixOS/nixpkgs/pull/64371
updated_at: 2019-07-06 10:54:32
body:
  To test this I built a version of the compiler with `dontStrip = True`
  and the vanilla version. The size of the result is both 1.4gb which
  indicates that the stripping doesn't do anything meaningful.

  Not stripping means that the debug rts is properly packaged as it
  should contain DWARF information and unused debugging symbols.

  Fixes #63511

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wavpack: Vulnerability roundup 71
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64372
updated_at: 2019-07-15 13:51:05
body:
  ###### Motivation for this change

  Fixes #64188.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/64373
updated_at: 2019-07-06 11:56:54
body:
  ###### Motivation for this change

  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/luksroot: Add option to save passphrases.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/64374
updated_at: 2019-07-08 16:28:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I needed that another LUKS device gets unlocked automatically using the same passphrase that was used to unlock the LUKS device containing the root file system. This adds an option to the initrd which if enabled will save passphrases to `/run/initrd-saved-passphrases` so that they can be used after the initrd to unlock other devices.

  Maybe using `/run/keys` (which is already a thing and gets mounted automatically, but not in the initrd) would be more appropriate? Not sure where would be the right place to put the code for doing that, and if it could somehow conflict with the fstab entry.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: keybase{,-gui}: 3.0.0 -> 4.1.0
user_login: das-g
html_url: https://github.com/NixOS/nixpkgs/pull/64375
updated_at: 2019-07-14 16:30:04
body:
  ###### Motivation for this change

  Fix #64248 for stable branch by back-porting #60872, #62220 & #64275

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: betterlockscreen: add missing runtime dependencies
user_login: emmanuelrosa
html_url: https://github.com/NixOS/nixpkgs/pull/64376
updated_at: 2019-07-12 13:34:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The motivation for this change is to add missing runtime dependencies on:

   1. procps (pidof)
   2. xrdb

  These dependencies may not be missing when using betterlockscreen from an environment such as the "system path", but they can be witnessed as missing from within a pure nix-shell, for example.

  ## Example 1

  ```
  [nix-shell:~]$ betterlockscreen -u /home/emmanuel/Media/Images/backgrounds/current.jpg
  Got 1366x768 /home/emmanuel/.cache/i3lock/1366x768
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 141: xrdb: command not found
  ```
  ## Example 2

  ```
  [nix-shell:~]$ betterlockscreen -l dimblur
  Got 1366x768 /home/emmanuel/.cache/i3lock/1366x768
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 70: pidof: command not found
  /nix/store/kv7qjbzpn8nsa0rhyw1czy4wjdic88d1-betterlockscreen-3.0.1/bin/.betterlockscreen-wrapped: line 95: pidof: command not found
  ```


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] ~Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))~
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) - before:  148788144 after: 155766472 
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kbfs: 2.11.0 -> 4.1.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64377
updated_at: 2019-07-07 01:50:08
body:
  The kbfs code has been moved to the same
  repo as the keybase package.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes #64248

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: travis: 1.8.9 -> 1.8.10
user_login: Moredread
html_url: https://github.com/NixOS/nixpkgs/pull/64378
updated_at: 2019-07-07 14:10:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport to 19.03: oraclejdk/jdk8cpu: 8u201 -> 8u211
user_login: Moredread
html_url: https://github.com/NixOS/nixpkgs/pull/64379
updated_at: 2019-07-20 23:41:36
body:
  (cherry picked from commit 9e2ec2a2df26a84c02a8da3c536f4a5cd1092dca)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  It seems that Oracle Java 8u201 isn't available anymore, so building packages on 19.03 fails. I.e.:

  ```
  > nix run -f channel:nixos-19.03 mediathekview
  trace: WARNING: Public updates for Oracle Java SE 8 released after January 2019 will not be available for business, commercial or production use without a commercial license. See https://java.com/en/download/release_notice.jsp for more information.
  builder for '/nix/store/l09wp0d9g0l220vmsf8ywyhxfgjcnm4r-jdk-8u201-linux-x64.tar.gz.drv' failed with exit code 1; last 10 log lines:

    trying http://download.oracle.com/otn-pub/java/jdk/8u201-b09/42970487e3af4f5aa5bca3f542482c60/jdk-8u201-linux-x64.tar.gz
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    100   531  100   531    0     0    293      0  0:00:01  0:00:01 --:--:--  1206
      0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
      0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
    curl: (22) The requested URL returned error: 404 Not Found
    error: cannot download jdk-8u201-linux-x64.tar.gz from any mirror
  cannot build derivation '/nix/store/kbddbimhq843aaj7rcsgh5pkl7sdkibm-oraclejre-8u201.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/j0c270s673klpfi831bv6r5mhxrz5n7c-mediathekview-13.2.1.drv': 1 dependencies couldn't be built
  [0 built (1 failed)]
  error: build of '/nix/store/j0c270s673klpfi831bv6r5mhxrz5n7c-mediathekview-13.2.1.drv' failed
  ```

  This PR backports the upgrade to 8u211 to the 19.03 channel.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: graphicsmagick: 1.3.31 -> 1.3.32, security release
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64380
updated_at: 2019-07-06 14:06:00
body:
  ###### Motivation for this change
  Security release fixing numerous issues. See http://www.graphicsmagick.org/NEWS.html#june-15-2019 - presumably too many to assign CVEs to.

  Darwin requires an extra patch, which I've included as a cut-down version of https://sourceforge.net/p/graphicsmagick/code/ci/f30492f40f78d867b43422215057dd21de4ba447 - we weren't able to find an url-addressable endpoint in sourceforge that would give us a raw `.patch`, despite the heroic efforts of @samueldr . Without this, use of pngs is liable to raise a `SIGABRT` and specifically this caused `dosbox` to fail to build on darwin.

  As far as backporting goes - though I'm usually in favour of patching, I do imagine we're going to have to go with a full version bump for 19.03 - you just have to look at the sheer number of fixes in the release notes to see it wouldn't be practical to patch.

  `nox-review` build failures are the same as without the bump, tested on macos 10.13 and non-nixos linux x86_64.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matrix-synapse: 1.0.0 -> 1.1.0
user_login: mguentner
html_url: https://github.com/NixOS/nixpkgs/pull/64381
updated_at: 2019-07-18 19:14:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  @Ralith @fpletz 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matrix-synapse: 1.0.0 -> 1.1.0
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/64382
updated_at: 2019-07-06 16:43:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Had to fix the patch as upstream `setup.py` changed a bit

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kodi: 18.1 -> 18.3
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/64383
updated_at: 2019-07-07 08:47:00
body:
  ##### Motivation for this change

  Upstream update from 18.1 to 18.3 (bug fix release).

  There are some minor changes to make the libdvd{css,nav,read} dependencies build as well (now they all do), but the kodi build system requires some changes in order to actually use them instead of force building them during the main kodi build.

  Cc: @domenkozar @titanous @edwtjo @sephalon

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/zerotierone: Sandbox the systemd service
user_login: gazally
html_url: https://github.com/NixOS/nixpkgs/pull/64384
updated_at: 2019-07-06 20:42:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Reducing the number of services that run as root with full privileges.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: WIP: build-rust-crate: fix for binary crate building.
user_login: dnaq
html_url: https://github.com/NixOS/nixpkgs/pull/64385
updated_at: 2019-07-11 08:13:27
body:
  See #64313.

  build-rust-crate used to always build a crate that had a source file
  with the same name as the crate as a library crate. This would break in
  the cases of the crate being a binary crate containing a source file
  with the same name, e.g. in xargo.

  Cargo used to erroneously allow a crate with the following contents in it's cargo
  toml:
  ```toml
  [lib]
  name = "foo"
  ```
  having its main source file named `src/foo.rs`. This is behaviour that
  cargo warns about.

  This pull request is marked as WIP because the version of way-cooler
  that is in nixpkgs depends on an old version of the crate `c_vec` that
  assumed the erroneous behaviour of cargo. Unfortunately this pull
  request will make the build of way-cooler fail until the dependency is
  updated to a new version.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: greatfet: init at 2019.05.01.dev0
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/64386
updated_at: 2019-07-19 02:33:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I got a greatfet one that I wanted to use with my nixos machine

  ###### Things done
  Just packaged the python libraries needed to use the device.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/openldap: fix assertion
user_login: jameysharp
html_url: https://github.com/NixOS/nixpkgs/pull/64387
updated_at: 2019-07-17 17:42:09
body:
  ###### Motivation for this change

  In commit d43dc68db3f414a527cad632a3f1fb868fc1c902, @Mic92 split the rootpw option to allow specifying it in a file kept outside the Nix store, as an alternative to specifying the password directly in the config.

  Prior to that, rootpw's type was `str`, but in order to allow both alternatives, it had to become `nullOr str` with a default of `null`. So I can see why this assertion, that either rootpw or rootpwFile are specified, makes sense to add here.

  However, these options aren't used if the configDir option is set, so as written this assertion breaks valid configurations, including the configuration used by nixos/tests/ldap.nix.

  So this patch fixes the assertion so that it doesn't fire if configDir is set.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: squashfsTools: fix 4k-align patch regression
user_login: charles-dyfis-net
html_url: https://github.com/NixOS/nixpkgs/pull/64388
updated_at: 2019-07-08 12:01:58
body:
  ###### Motivation for this change

  In #49200, an option to use 4k-aligned squashfs blocks was incorporated. Originally developed by Google, this makes it easy to build squashfs images which tools such as casync/desync/etc. can effectively chunk for easier distribution.

  In 2aafeedd15e33491f637a20baf5b1b3b4fd5b4a3, this patch stopped being successfully applied. I haven't yet determined how this didn't break the build outright, but many of the strings inserted by the patch existed nowhere in the binary at all, and several components *would* have failed to apply, had it actually been attempted.

  In this PR, the patch is updated to apply correctly on top of squashfs 4.4 as modified by the other patches previously applied.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after) *no change; 34038808 both before and after*
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: php73: 7.3.6 -> 7.3.7, 7.2.19 -> 7.2.20 [19.03 backport]
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/64389
updated_at: 2019-07-08 00:15:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/64183
  https://github.com/NixOS/nixpkgs/pull/64326

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/graylog: use `types.lines` for extraConfig
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/64390
updated_at: 2019-07-07 12:57:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The `types.lines` type makes it possible to define `extraConfig` in
  multiple files and simply concat the contents.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.jpylyzer: init at 1.18.0, use to enable openjpeg tests
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64391
updated_at: 2019-07-17 08:34:43
body:
  ###### Motivation for this change
  `jpylyzer` is a "JP2 (JPEG 2000 Part 1) image validator and properties extractor". Added as a python library and application.

  `openjpeg` uses this in its test suite. It seems to me it would be useful to enable the tests for `openjpeg`, with it being one of those packages with a huge list of reverse dependencies, making `nox-review` a far less convenient proxy for checking an `openjpeg` package's correctness.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Systemd confinement tries to create /usr directory and logs an error
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/64392
updated_at: 2019-07-06 21:28:55
body:
  ## Issue description
  When we enable `confinement`,  systemd insists on creating `/usr` which it fails at because `/` is mounted read-only between it trying to create `/usr` and  `TemporaryFileSystem=/` being executed.

  I have no idea _why_ it is trying to create `/usr` in the first place


  cc @aszlig 

  ### Steps to reproduce

  ```
      systemd.services.flopsewops = {
        wantedBy = [ "multi-user.target" ];
        confinement.enable = true;
        confinement.mode = "chroot-only";
        script = "while true; do echo hey; sleep 1; done";
        serviceConfig = {
          StateDirectory = "flopsewopos";
        };
      };

  ```

  ```
  Jul 06 19:59:07 t430s systemd[1]: Started flopsewops.service.
  Jul 06 19:59:07 t430s systemd[8793]: Failed to create directory at /nix/store/4pddxxlhqpphm1dq63imiqgwaqnb71rd-flopsewops-chroot/usr: Read-only file system
  Jul 06 19:59:07 t430s fw8x1n0iwd2nzbmrsii4apyxxsmryli8-unit-script-flopsewops-start[8793]: hey
  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: pythonPackages.wily: init at 1.12.2
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/64393
updated_at: 2019-07-18 20:01:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wireguard-tools: 0.0.20190601 -> 0.0.20190702
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64394
updated_at: 2019-07-08 10:04:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `wireguard-tools` to the latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
  ---
  cc @ericsagnes @Mic92 @elseym @zx2c4


state: closed
title: git: fix bad patch and fix run-time dependency on gcc
user_login: demin-dmitriy
html_url: https://github.com/NixOS/nixpkgs/pull/64395
updated_at: 2019-07-17 08:33:14
body:
  ###### Motivation for this change

  Fixes the issue https://github.com/NixOS/nixpkgs/issues/64350 .

  Problem was that  in previous version of git git-stash was a shell script, but now it's a symlink to git. `postInstall` tried to patch it (in-place) as if it was a script, but instead replaced symlink with a corrupted git copy. `strip` refused to  strip symbols from it, so debug information with references to gcc was left in the resulting package.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  @gloaming might want to take a look at it.


state: closed
title: zabbixctl: init at unstable-2019-07-06
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64396
updated_at: 2019-07-10 10:09:20
body:
  ###### Motivation for this change

   init at unstable-2019-07-06

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: newsboat: 2.15 -> 2.16.1
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/64398
updated_at: 2019-07-07 12:59:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#2161---2019-06-26

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @dotlambda @nicknovitski


state: closed
title: blockbook: init at 0.3.1
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64399
updated_at: 2019-07-16 18:14:57
body:
  ###### Motivation for this change

  init at 0.3.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Missing LibLUV dependency for most recent neovim versions
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/issues/64400
updated_at: 2019-07-17 11:11:26
body:
  ## Issue description
  Since https://github.com/neovim/neovim/pull/10123 `neovim` requires `libluv` for builds.
  See https://github.com/neovim/neovim/wiki/Following-HEAD#20190610

  There's no released version yet containing this change, but it's nice to prepare for this already in order to simplify the update later.

  The build on https://github.com/rvolosatovs/nixpkgs/commit/2b7a3bb484b9312ab500f106e50d3250f6866be7 fails for me with:
  ```
  CMake Error at /nix/store/06zj4w9fdhwfpz9grbm01fqwgsl1ig4g-cmake-3.13.4/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
    Could NOT find LibLUV (missing: LIBLUV_LIBRARY LIBLUV_INCLUDE_DIR)
    (Required is at least version "1.30.0")
  Call Stack (most recent call first):
    /nix/store/06zj4w9fdhwfpz9grbm01fqwgsl1ig4g-cmake-3.13.4/share/cmake-3.13/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
    cmake/FindLibLUV.cmake:34 (find_package_handle_standard_args)
    CMakeLists.txt:386 (find_package)
  ```

  I have no experience with either CMake or Lua, so it's quite hard for me to reason about this and debug, but as far as I understand the issue is that build requires `luv.h`(https://github.com/luvit/luv/blob/1.30.0-0/src/luv.h ???) to be present at build time and `luaPackages.luv` does not contain it:
  ```
  tree $(nix eval --raw nixpkgs.luaPackages.luv)
  /nix/store/gkszplgfs3z05765pbqqq9ahhsv1j8wv-lua5.2-luv-1.29.1-2
  ├── lib
  │   └── lua
  │       └── 5.2
  │           └── luv.so
  ├── luv-1.29.1-2-rocks
  │   ├── luv
  │   │   └── 1.29.1-2
  │   │       ├── doc
  │   │       │   ├── docs.md
  │   │       │   ├── LICENSE.txt
  │   │       │   └── README.md
  │   │       ├── luv-1.29.1-2.rockspec
  │   │       └── rock_manifest
  │   └── manifest
  └── nix-support
      └── propagated-build-inputs
  ```

  Refs https://github.com/neovim/neovim/issues/10181 https://github.com/neovim/neovim/pull/10359#issuecomment-506741724

  cc @manveru


state: closed
title: pythonPackages.spacy: loosen dependency version bounds
user_login: mattmelling
html_url: https://github.com/NixOS/nixpkgs/pull/64401
updated_at: 2019-07-11 07:58:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  `python37Packages.spacy` depends on `0.32.0,<0.33.0`, but `wheel` has recently been updated to `0.33.4`. This change removes the `<0.33.0` restriction to allow compatibility with future versions.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] graphicsmagick: 1.3.31 -> 1.3.32 (security release)
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64402
updated_at: 2019-07-06 23:26:19
body:
  ###### Motivation for this change
  Cherrypick of #64380

  I'm usually in favour of patching for stable branches, but the list of issues covered by this release would make that impractical: http://www.graphicsmagick.org/NEWS.html#june-15-2019
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jellyfin: 10.3.5 -> 10.3.6
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/64403
updated_at: 2019-07-07 09:51:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] wireshark: 2.6.6 -> 2.6.9, security release
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64404
updated_at: 2019-07-07 12:48:25
body:
  ###### Motivation for this change
  Security release(s) fixing multiple issues:

   - https://www.wireshark.org/security/wnpa-sec-2019-06.html CVE-2019-9209
   - https://www.wireshark.org/security/wnpa-sec-2019-07.html CVE-2019-9208
   - https://www.wireshark.org/security/wnpa-sec-2019-08.html CVE-2019-9214
   - https://www.wireshark.org/security/wnpa-sec-2019-09.html CVE-2019-10895
   - https://www.wireshark.org/security/wnpa-sec-2019-10.html CVE-2019-10899
   - https://www.wireshark.org/security/wnpa-sec-2019-14.html CVE-2019-10894
   - https://www.wireshark.org/security/wnpa-sec-2019-15.html CVE-2019-10896
   - https://www.wireshark.org/security/wnpa-sec-2019-17.html CVE-2019-10901
   - https://www.wireshark.org/security/wnpa-sec-2019-18.html CVE-2019-10903
   - https://www.wireshark.org/security/wnpa-sec-2019-19.html (?)

  ~This probably slipped under the radar because they haven't assigned CVEs for these.~ Oh yes they have.

  `nox-review` is happy on non-nixos linux x86_64, on macos 10.13 I only get build failures for packages that already won't build on my machine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/systemd-confinement: Fix DynamicUser support
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/pull/64405
updated_at: 2019-07-08 11:01:29
body:
  Problem was that if you enabled DynamicUser, it would remount
  / as read-only which wouldn't work, as we were using
  the fact that / was read-write to set up all the mounts.

  We work around this by actually making sure all the directories
  that will be mount points exist apriori.  For things
  for which mount points are dynamically generated on the fly,
  we use TemporaryFileSystem (cache, log, state).

  We also use TemporaryFileSystm for /nix/store. However,
  we might not actually need it, as we know all the mount points
  apriori.

  TODO:

  * See how we interact with APIVFS
  * See if we can get rid of the TemporaryFileSystem for /nix/store,
  because currently /nix/store _itself_ is read/write in the container (it
  already was) and that's surely not something we want!

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: arangod default config tries to write into nix store
user_login: SitiSchu
html_url: https://github.com/NixOS/nixpkgs/issues/64406
updated_at: 2019-07-12 20:11:12
body:
  ## Issue description
  The default config file generated by arangodb in `<path-to-arangodb>/etc/arangodb3/arangod.conf` is configured in a way that the log file and the database file would be located inside the Nix store. This causes an error when trying to run arangodb without any additional configuration:

  ```
  cannot write to file '/nix/store/pic4da770rv8y50irj48rk9lif7xdgqy-arangodb-3.3.19/var/log/arangodb3/arangod.log': Read-only file system
  {startup} caught exception during prepare of feature 'Logger': cannot write file
  arangod terminated because of an exception: cannot write file

  ```
  ### Steps to reproduce
  Install arangodb
  Run `arangod` on the command line

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.55, NixOS, 19.03.172979.8634c3b6199 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(sitischu): `""`
   - channels(root): `"nixos-19.03.172979.8634c3b6199"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nixos/icingaweb: Fix module path; Add test
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/64407
updated_at: 2019-07-07 01:18:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nxengine-evo: init at 2.6.4
user_login: scubed2
html_url: https://github.com/NixOS/nixpkgs/pull/64408
updated_at: 2019-07-20 22:20:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add a game.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  So far, I've done:
  nix-env -i nxengine
  to install it, then started a new game and played a bit.  For some reason, the music seems to be going fast, but that's the only issue I've encountered.  (So, only a cosmetic bug.  It is still fully playable, and the game itself is at the right speed.)

  I see that the instructions say there should be a maintainer, but I don't know what to put there.

  Note that the game has 2 parts:
  the engine, which is opensource
  the data, which is freeware and obtained separately
  This package only has the engine.  So, it is not playable by itself.


state: closed
title: soundtouch: 2.0.0 -> 2.1.2
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64409
updated_at: 2019-07-12 01:49:21
body:
  ##### Motivation for this change

  Obsoletes #64354.
  Fixes #64187.

  ###### Things done
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nomad: "Nomad UI is not available in this binary."
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/issues/64410
updated_at: 2019-07-07 13:07:59
body:
  ## Issue description

  nomad appears to be built without the UI.

  ### Steps to reproduce

  On nixpkgs master:

  ```
  nomad agent -dev
  nomad ui
  ```

  and observe your browser opening a page showing:

  ```
  Nomad UI is not available in this binary. To get Nomad UI do one of the following:

  Download an official release

  Run
  make release
  to create your own release binaries.

  Run
  make dev-ui
  to create a development binary with the UI.
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.57-hardened, NixOS, 19.09.git.a3a9b08 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `""`
   - nixpkgs: `/var/nixpkgs`


state: closed
title: nixos/lidarr: re-add home attribute
user_login: davidtwco
html_url: https://github.com/NixOS/nixpkgs/pull/64412
updated_at: 2019-07-12 08:20:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I accidentally removed the `home` attribute on the `lidarr` user 
  in #64113, which I didn't notice broke some things until now. Sorry!

  cc @etu

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/jackett: add package option
user_login: davidtwco
html_url: https://github.com/NixOS/nixpkgs/pull/64413
updated_at: 2019-07-12 08:20:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This allows users of the module to override the package to a newer
  version. Particularly useful as Jackett warns that old versions may not
  work.

  cc @etu (reviewed previous jackett module changes)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
  I've tested this branch on my local configuration to make sure that 
  it works.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Rust 1.36
user_login: edolstra
html_url: https://github.com/NixOS/nixpkgs/pull/64414
updated_at: 2019-07-13 10:22:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update Rust from 1.35.0 to 1.36.0.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emacs: Silence compiler warnings in site-start.el
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/pull/64415
updated_at: 2019-07-08 16:18:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Remove compiler warnings from nixOS's site-start.el

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: duplicity: newly-enabled tests all fail
user_login: simon-weber
html_url: https://github.com/NixOS/nixpkgs/issues/64416
updated_at: 2019-07-15 22:55:22
body:
  ## Issue description

  The tests enabled by @strager in https://github.com/NixOS/nixpkgs/pull/60956 all fail on my system:
  ```
  Ran 418 tests in 11.799s

  FAILED (failures=8, errors=409, skipped=4)
  ```

  All of the errors seem to be variations of:
  ```
  test_locked_excl_if_present (testing.functional.test_selection.TestLockedFoldersNoError)
  Test no error if excluded locked with --exclude-if-present ... rm: cannot remove 'testfiles/select2/1/1sub1/1sub1sub3': Permission denied
  ```

  ### Steps to reproduce

  `nix-build --check '<nixpkgs>' -A duplicity`

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.8.17-galliumos, GalliumOS, 2.1 (Xenon)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(simon): `"nixpkgs-19.09pre184803.d567c486ca5"`
   - nixpkgs: `/home/simon/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: dunst: 1.4.0 -> 1.4.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64417
updated_at: 2019-07-08 03:14:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `dunst` to the latest release.
  - https://github.com/dunst-project/dunst/releases/tag/v1.4.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @GrahamcOfBorg build dunst


state: closed
title: cgit: add patch fixing remote DoS
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64418
updated_at: 2019-07-07 19:46:19
body:
  ###### Motivation for this change
  Issue assigned MGASA-2019-0203 by Mageia.

  https://www.openwall.com/lists/oss-security/2019/05/19/3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: More OctoPrint plugins
user_login: gebner
html_url: https://github.com/NixOS/nixpkgs/pull/64419
updated_at: 2019-07-08 08:27:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  OctoPrint-related updates and plugin additions.

  I removed the sarge version override, which silently broke PrintTimeGenius (and also the pip version check in octoprint, but that one doesn't matter).

  Tested on a raspberry pi 3b+.

  cc maintainer @abbradar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cloudfoundry-cli: 6.41.0 -> 6.45.0 (fixes CVE-2019-3781)
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64420
updated_at: 2019-07-13 17:27:02
body:
  ###### Motivation for this change
  Update, also fixing CVE-2019-3781

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trivial-builders: support '/' in writeTextDir
user_login: rycee
html_url: https://github.com/NixOS/nixpkgs/pull/64421
updated_at: 2019-07-17 07:38:57
body:
  Before one would get the following error

      nix-repl> pkgs.writeTextDir "share/my-file" "foo"
      error: invalid character '/' in name 'share/my-file'

  Fixes #50347

  CC @flokli


state: open
title: pythonPackages.myfitnesspal: init at 1.13.3
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/64422
updated_at: 2019-07-08 19:51:18
body:
  ###### Motivation for this change
  This is a python library for downloading data from the MyFitnessPal API, which is useful for users who want to chart/graph/visualize their data with other tools, such as seaborn or matplotlib.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] cgit: add patch fixing remote DoS
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64423
updated_at: 2019-07-07 19:59:58
body:
  ###### Motivation for this change
  Backport of #64418

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mxisd: 1.4.4 -> 1.4.5
user_login: mguentner
html_url: https://github.com/NixOS/nixpkgs/pull/64424
updated_at: 2019-07-13 10:36:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  @fpletz 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kvmgt service: use modprobe, force-load module
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/64425
updated_at: 2019-07-08 19:21:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Force-load of kernel module was needed for my laptop for some reason. Also moved the kernel option to modprobe configuration - this is somewhat controversial, my reasoning is that options for modules should be there to avoid command line bloat and be a single source of truth.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @gnidorah 


state: closed
title: vimPlugins: Init various coc extension plugins
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/64426
updated_at: 2019-07-10 07:28:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  To allow better "Nixifying" `coc` setup

  According to https://github.com/neoclide/coc.nvim/wiki/Using-coc-extensions#use-vims-plugin-manager-for-coc-extension `coc` extensions can be installed simply by adding them to RTP. (So things like this just work: https://github.com/rvolosatovs/infrastructure/blob/902a410ba2f73b32a18af3e2ccb9762c74d345aa/nixpkgs/neovim/default.nix#L10-L15)
  Caveat: I managed to make it work with `plug` vim plugin backend, `configure.packages.plugins.start` does not seem to work for me again(https://github.com/NixOS/nixpkgs/issues/56338#issuecomment-466972624)
  cc @teto 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chromium: Strip with --strip-unneeded to reduce binary size.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/64427
updated_at: 2019-07-12 20:20:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I noticed that the size of `chromium-unwrapped` derivation (323 MiB) is much more than the size of `google-chrome-stable` (207 MiB). The majority of this difference comes from the binary size (232 MiB vs 142 MiB). I found that stripping with `--strip-unneeded` (instead of `--strip-debug` / `-S` which is the default in the strip hook) reduces the derivation size to 258 MiB and the binary size to 168 MiB (which is still larger than in `google-chrome-stable` though).

  I could not find an explanation regarding what `--strip-unneeded` removes in addition to debug symbols (does anyone know?), but the browser still works. It might make sense to consider stripping this way by default for all packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r18.09] graphicsmagick: 1.3.31 -> 1.3.32 (security release)
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64428
updated_at: 2019-07-09 18:31:54
body:
  ###### Motivation for this change
  Backport of #64380

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37Packages.opencv: remove
user_login: OmnipotentEntity
html_url: https://github.com/NixOS/nixpkgs/pull/64430
updated_at: 2019-07-08 14:11:39
body:
  As far as I can tell after a few days of searching, OpenCV's version 2 does not at all support Python version 3, and other distributions of Python bindings for OpenCV v2.4.x that I could find do not support Python3 for this version series.

  (By not support I mean it doesn't work.)

  Reference issue: #64363 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.nvchecker: 1.4.3 -> 1.4.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64431
updated_at: 2019-07-08 14:05:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rubocop: 0.71.0 -> 0.72.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64432
updated_at: 2019-07-09 06:33:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/rubocop-hq/rubocop/releases/tag/v0.72.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitAndTools.git-gone: init at 0.1.2
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64433
updated_at: 2019-07-09 03:21:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add https://github.com/lunaryorn/git-gone

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.deap: 1.2.2 -> 1.3.0
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64434
updated_at: 2019-07-12 04:51:50
body:
  ###### Motivation for this change
  Just going through repology at this point and updating packages.

  marked sklearn-deap as broken due to https://github.com/rsteca/sklearn-deap/issues/65

  pythonPackages.sklearn-deap still works because we fix it at the last supported version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.flask-caching: 1.4.0 -> 1.7.2
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64435
updated_at: 2019-07-12 04:53:21
body:
  ###### Motivation for this change
  Just updating packages from repology

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```
  [21 built, 213 copied (153.3 MiB), 27.8 MiB DL]
  https://github.com/NixOS/nixpkgs/pull/64435
  24 package were build:
  buku papis python27Packages.azure-cli-core python27Packages.flask-caching python27Packages.flask-common python27Packages.graphite_api python27Packages.habanero python27Packages.httpbin python27Packages.influxgraph python27Packages.knack python27Packages.pytest-httpbin python27Packages.pytest-xprocess python27Packages.vcrpy python37Packages.azure-cli-core python37Packages.flask-caching python37Packages.flask-common python37Packages.graphite_api python37Packages.habanero python37Packages.httpbin python37Packages.influxgraph python37Packages.knack python37Packages.pytest-httpbin python37Packages.pytest-xprocess python37Packages.vcrpy
  ```


state: closed
title: phpPackages.phpstan: 0.11.8 -> 0.11.12
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/64436
updated_at: 2019-07-11 08:13:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.9
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.10
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.11
  Changelog: https://github.com/phpstan/phpstan/releases/tag/0.11.12

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.msrest: 0.6.7 -> 0.6.8
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64438
updated_at: 2019-07-11 07:57:53
body:
  ###### Motivation for this change
  Noticed it was out of date.

  Bug fixes fro serialization with python2 when payloads contain UTF8.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  $ nix path-info -Sh ./result
  /nix/store/37i3jk9xgq7lbazvnwx8d86gqrz07klj-python2.7-msrest-0.6.8       107.1M

  ```
  $ nix-review wip
  ...
  [22 built, 58 copied (179.0 MiB), 31.1 MiB DL]
  17 package were build:
  nixops_1_6_1 python27Packages.azure-cli-core python27Packages.azure-mgmt-common python27Packages.azure-mgmt-compute python27Packages.azure-mgmt-network python27Packages.azure-mgmt-resource python27Packages.azure-mgmt-storage python27Packages.msrest python27Packages.msrestazure python37Packages.azure-cli-core python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-network python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-storage python37Packages.msrest python37Packages.msrestazure
  ```


state: closed
title: opera: 60.0.3255.170 -> 62.0.3331.43
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64439
updated_at: 2019-07-09 02:40:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `opera` to the latest release.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @GrahamcOfBorg build opera


state: closed
title: python2.7-suds-jurko-0.6 broken by recent update of pluggy
user_login: peti
html_url: https://github.com/NixOS/nixpkgs/issues/64440
updated_at: 2019-07-11 17:28:15
body:
  `python27Packages.suds-jurko` fails its test suite in current versions of `master` and therefore no longer compiles. According to `git bisect`, the commit that broke the build is aad6f1ca903a82be5b0a5f0d267b3abd801834ef from @marsam: 

  ~~~
  commit aad6f1ca903a82be5b0a5f0d267b3abd801834ef
  Author: Mario Rodas <marsam@users.noreply.github.com>
  Date:   Fri May 24 20:00:00 2019 -0500

      pythonPackages.pluggy: 0.8.1 -> 0.11.0
  ~~~

  `python2.7-suds-jurko-0.6` is a dependency of `python2.7-pytest-3.10.1`, so this build failure breaks quite a few packages.


state: open
title: fix polybarFull
user_login: justinwoo
html_url: https://github.com/NixOS/nixpkgs/pull/64441
updated_at: 2019-07-10 11:16:09
body:
  this build cannot support both wirelesstools and libnl at the same time,
  and also cannot support both i3 and i3gaps.


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mpv: fix drm and vulkan support
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/64442
updated_at: 2019-07-14 05:07:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Noticed my Vulkan settings in my mpv config weren't doing anything

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  Can someone on Darwin test to see if libplacebo builds on it, and if not, if removing a dependency would fix it (all are optional)?

  I was originally going to add libplacebo as only a vulkan dependency (it's required for it), but mpv uses it for more than just vulkan.


state: open
title: AMD Ryzen 3000 RDRAND Workaround
user_login: ikervagyok
html_url: https://github.com/NixOS/nixpkgs/issues/64443
updated_at: 2019-07-08 13:26:22
body:
  ## Issue description
  Early adopters of the new Ryzens CPUs might find themselves in front of an unbootable system, even though the workaround is already upstream (https://github.com/systemd/systemd/pull/12536/commits/1c53d4a070edbec8ad2d384ba0014d0eb6bae077)

  Does not (yet) affect me, but it seems to be affecting every Ryzen-Linux-review.

  see: 
  https://www.phoronix.com/scan.php?page=article&item=ryzen-3700x-3900x-linux&num=2
  (german) https://www.heise.de/newsticker/meldung/Ryzen-3000-Bekannter-Fehler-bringt-viele-Linux-Distributionen-zu-Fall-4465220.html

  I'd make a PR, if i'd knew the caveats of nixos' systemd fork.


state: closed
title: eksctl: 0.1.38 -> 0.1.39
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64444
updated_at: 2019-07-09 00:20:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `eksctl` to the latest release.
  - https://github.com/weaveworks/eksctl/releases/tag/0.1.39

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pytest_3: fix build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64445
updated_at: 2019-07-10 13:32:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/64440
  cc: @peti 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clightning: 0.7.0 -> 0.7.1
user_login: jonasnick
html_url: https://github.com/NixOS/nixpkgs/pull/64446
updated_at: 2019-07-11 14:51:16
body:
  ###### Motivation for this change

  New minor release with many fixes. See https://github.com/ElementsProject/lightning/releases/tag/v0.7.1 for a list.


  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions (ArchLinux)
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rofi: 1.5.3 -> 1.5.4
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64447
updated_at: 2019-07-09 00:20:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `rofi` to the latest release.
  - https://github.com/davatorium/rofi/releases/tag/1.5.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP]nixos/firejail:added program.firejail.firecfg option
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/pull/64448
updated_at: 2019-07-10 13:49:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The firecfg program already knows how to wrap the correct comands and desktop files

  ###### Things done
  Still work in progress
  ```
  nixos-rebuild build -I nixpkgs=.                                            
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv
    /nix/store/c0496dynbfbjnhwvg8gnk1v5565s7spp-dbus-1.drv
    /nix/store/q6nk3hx6jilcyrqfzkxlirw9x5y8r433-unit-dbus.service.drv
    /nix/store/j86vgqzw8vlr7cqg2j79shczprxl2w68-user-units.drv
    /nix/store/9saqvr99mcbg2s1z8ppcjzfa53b7827z-unit-dbus.service.drv
    /nix/store/d9s25xipg5cszpm2dqzmm44n72ybjnvp-unit-polkit.service.drv
    /nix/store/v1dhqmyk7vpjwf96pwzzg2bc98kckgfr-unit-systemd-fsck-.service.drv
    /nix/store/n7i2b9bgbr50ns9g31dn746wjlsl5qh6-system-units.drv
    /nix/store/v5pl243kw0by169dd0cslgq56p6wy2w8-etc.drv
    /nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv
  building '/nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv'...
  created 6818 symlinks in user environment
  cp: -r not specified; omitting directory '/nix/store/9p6z02r5bmkzqz87fkbh0llj3iwdynrr-system-path'
  builder for '/nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv' failed with exit code 1
  cannot build derivation '/nix/store/c0496dynbfbjnhwvg8gnk1v5565s7spp-dbus-1.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/d9s25xipg5cszpm2dqzmm44n72ybjnvp-unit-polkit.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/v1dhqmyk7vpjwf96pwzzg2bc98kckgfr-unit-systemd-fsck-.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/9saqvr99mcbg2s1z8ppcjzfa53b7827z-unit-dbus.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/q6nk3hx6jilcyrqfzkxlirw9x5y8r433-unit-dbus.service.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/n7i2b9bgbr50ns9g31dn746wjlsl5qh6-system-units.drv': 3 dependencies couldn't be built
  cannot build derivation '/nix/store/j86vgqzw8vlr7cqg2j79shczprxl2w68-user-units.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/v5pl243kw0by169dd0cslgq56p6wy2w8-etc.drv': 4 dependencies couldn't be built
  cannot build derivation '/nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv': 2 dependencies couldn't be built
  error: build of '/nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv' failed
  ```
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: datadog 6: config files saved as JSON instead of YAML
user_login: terlar
html_url: https://github.com/NixOS/nixpkgs/issues/64449
updated_at: 2019-07-12 18:26:38
body:
  ## Issue description
  When configuring DataDog with custom checks they configuration is saved as JSON but in YAML files. It seems the DataDog Agent v6 only support YAML files and ignore badly formatted ones (e.g. JSON).

  > ... from version 6.0.0, the Agent loads any valid YAML file contained in the folder:
  > `/datadog-agent/conf.d/<CHECK_NAME>.d/`.



  See:
  - https://docs.datadoghq.com/agent/guide/agent-configuration-files/?tab=agentv6#checks-configuration-files-for-agent-6
  - https://github.com/NixOS/nixpkgs/blob/f56d507e064d847057e2c81af5b53053e40c8ca0/nixos/modules/services/monitoring/datadog-agent.nix#L145-L182

  ### Steps to reproduce

  ```
  {
    services.datadog-agent = {
      apiKeyFile = secrets/datadog.api_key;
      enable = true;
      enableLiveProcessCollection = true;
      enableTraceAgent = true;
      checks = {
        docker_daemon = {
          init_config = null;
          instances = [
            {
              url = "unix://var/run/docker.sock";
            }
          ];
        };
      };

      diskCheck = {
        init_config = null;
        instances = [
          {
            mount_point_blacklist = [
              "/var/lib/docker/(containers|overlay2)/./(shm|merged)"
              "/run/docker/netns."
              "/sys/kernel/debug/"
              "/run/user/1000/"
            ];
          }
        ];
      };
    };
  }
  ```

  Then see the generated files in `/etc/datadog-agent/conf.d/*/*.yaml`. The content will be JSON as specified within the datadog-agent.nix expression in the checks documentation.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.15, NixOS, 19.09.git.656dcc036fc (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-18.09.2574.a7e559a5504"`
   - nixpkgs: `/home/terje.larsen/src/github.com/terlar/nix-config/nixpkgs` (656dcc0)


state: closed
title: systems/doubles.nix: add Apple doubles
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/64450
updated_at: 2019-07-10 10:37:59
body:
  These are used in cross-compilation to iOS devices and simulators.

  Fallout from #60349.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: django.gis:cannot use GDAL in python project
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/issues/64451
updated_at: 2019-07-10 22:13:23
body:
  ## Issue description
  I have a django project which uses the gis contribution module.
  ```
  python ./manage.py check                            
  Traceback (most recent call last):
    File "./manage.py", line 16, in <module>
      execute_from_command_line(sys.argv)
    File "~/.local/lib/python3.7/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
      utility.execute()
    File "~/.local/lib/python3.7/site-packages/django/core/management/__init__.py", line 357, in execute
      django.setup()
    File "~/.local/lib/python3.7/site-packages/django/__init__.py", line 24, in setup
      apps.populate(settings.INSTALLED_APPS)
    File "~/.local/lib/python3.7/site-packages/django/apps/registry.py", line 114, in populate
      app_config.import_models()
    File "~/.local/lib/python3.7/site-packages/django/apps/config.py", line 211, in import_models
      self.models_module = import_module(models_module_name)
    File "/nix/store/5ml275njn06n151a4yvjc385xkxmjl61-python3-3.7.3/lib/python3.7/importlib/__init__.py", line 127, in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
    File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
    File "<frozen importlib._bootstrap>", line 983, in _find_and_load
    File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "~/.local/lib/python3.7/site-packages/django/contrib/auth/models.py", line 2, in <module>
      from django.contrib.auth.base_user import AbstractBaseUser, BaseUserManager
    File "~/.local/lib/python3.7/site-packages/django/contrib/auth/base_user.py", line 47, in <module>
      class AbstractBaseUser(models.Model):
    File "~/.local/lib/python3.7/site-packages/django/db/models/base.py", line 117, in __new__
      new_class.add_to_class('_meta', Options(meta, app_label))
    File "~/.local/lib/python3.7/site-packages/django/db/models/base.py", line 321, in add_to_class
      value.contribute_to_class(cls, name)
    File "~/.local/lib/python3.7/site-packages/django/db/models/options.py", line 204, in contribute_to_class
      self.db_table = truncate_name(self.db_table, connection.ops.max_name_length())
    File "~/.local/lib/python3.7/site-packages/django/db/__init__.py", line 28, in __getattr__
      return getattr(connections[DEFAULT_DB_ALIAS], item)
    File "~/.local/lib/python3.7/site-packages/django/db/utils.py", line 201, in __getitem__
      backend = load_backend(db['ENGINE'])
    File "~/.local/lib/python3.7/site-packages/django/db/utils.py", line 110, in load_backend
      return import_module('%s.base' % backend_name)
    File "/nix/store/5ml275njn06n151a4yvjc385xkxmjl61-python3-3.7.3/lib/python3.7/importlib/__init__.py", line 127, in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/backends/postgis/base.py", line 6, in <module>
      from .features import DatabaseFeatures
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/backends/postgis/features.py", line 1, in <module>
      from django.contrib.gis.db.backends.base.features import BaseSpatialFeatures
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/backends/base/features.py", line 3, in <module>
      from django.contrib.gis.db.models import aggregates
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/models/__init__.py", line 3, in <module>
      import django.contrib.gis.db.models.functions  # NOQA
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/models/functions.py", line 4, in <module>
      from django.contrib.gis.db.models.fields import BaseSpatialField, GeometryField
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/db/models/fields.py", line 3, in <module>
      from django.contrib.gis import forms, gdal
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/forms/__init__.py", line 3, in <module>
      from .fields import (  # NOQA
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/forms/fields.py", line 2, in <module>
      from django.contrib.gis.gdal import GDALException
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/gdal/__init__.py", line 28, in <module>
      from django.contrib.gis.gdal.datasource import DataSource
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/gdal/datasource.py", line 39, in <module>
      from django.contrib.gis.gdal.driver import Driver
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/gdal/driver.py", line 5, in <module>
      from django.contrib.gis.gdal.prototypes import ds as vcapi, raster as rcapi
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/gdal/prototypes/ds.py", line 9, in <module>
      from django.contrib.gis.gdal.libgdal import GDAL_VERSION, lgdal
    File "~/.local/lib/python3.7/site-packages/django/contrib/gis/gdal/libgdal.py", line 43, in <module>
      % '", "'.join(lib_names)
  django.core.exceptions.ImproperlyConfigured: Could not find the GDAL library (tried "gdal", "GDAL", "gdal2.3.0", "gdal2.2.0", "gdal2.1.0", "gdal2.0.0", "gdal1.11.0"). Is GDAL installed? If it is, try setting GDAL_LIBRARY_PATH in your settings.
  ```

  ### Steps to reproduce
  - Install Django
  - `django-admin startproject test`
  - Add a class with a field from django.contrib.gis 
  - `python ./manage.py check`


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.15, NixOS, 19.09pre184359.73392e79aa6 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre184820.aa2a7e49b82"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nixos/run:Added boot.runOnTmpfs option
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/pull/64452
updated_at: 2019-07-08 17:32:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Because if ArchLinux can have `/run` on tmpfs,why can't we?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cpp-utilities: init at 4.17.1
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/64453
updated_at: 2019-07-10 10:05:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Eventually, I'd like to package [qtutilities](https://github.com/Martchus/qtutilities) and [syncthingtray](https://github.com/Martchus/syncthingtray) as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - Non
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: iproute: 5.1.0 -> 5.2.0
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/64454
updated_at: 2019-07-10 20:10:36
body:
  "Not a lot of big new features in this release. Just the usual array of
  small fixes across the board." [0]

  File changes:
  None

  nix path-info -S:
  5.1.0 46637048
  5.2.0 46627312

  [0]: https://www.spinics.net/lists/netdev/msg584562.html

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ~~WIP as the release is tagged as "vv5.2.0" and not "v5.2.0" (I've notified the maintainer) and might be re-tagged.~~


state: closed
title: jetbrains update via update.pl
user_login: joncojonathan
html_url: https://github.com/NixOS/nixpkgs/pull/64455
updated_at: 2019-07-13 09:02:32
body:
  jetbrains.datagrip: 2019.1.3 -> 2019.1.4
  jetbrains.phpstorm: 2019.1.2 -> 2019.1.3
  jetbrains.rider:    2019.1.1 -> 2019.1.2

  ###### Motivation for this change
  Updated to latest versions.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: audio-recorder: Gstreamer-plugins not available
user_login: GRBurst
html_url: https://github.com/NixOS/nixpkgs/issues/64456
updated_at: 2019-07-08 19:25:34
body:
  ## Issue description
  audio-recorder does not recognize gstreamer-plugins. manually installing them do not solve the problem. 

  ```sh
  $ audio-recorder
  (audio-recorder:5209): GStreamer-CRITICAL **: 21:18:54.090: gst_object_unref: assertion 'object != NULL' failed
  Error:To support m4a format you should install Gstreamer-plugins for .
  Error:Installation of Gstreamer-plugins failed (GST_INSTALL_PLUGINS_HELPER_MISSING).
  Error:
  (audio-recorder:5209): Gtk-WARNING **: 21:18:54.213: Could not find the icon 'audio-recorder-off-ltr'. The 'hicolor' theme
  was not found either, perhaps you need to install it.
  You can get a copy from:
  	http://icon-theme.freedesktop.org/releases

  (audio-recorder:5209): Gdk-CRITICAL **: 21:18:54.231: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed

  (audio-recorder:5209): GStreamer-CRITICAL **: 21:18:58.117: gst_object_unref: assertion 'object != NULL' failed
  Error:To support m4a format you should install Gstreamer-plugins for .
  Error:Installation of Gstreamer-plugins failed (GST_INSTALL_PLUGINS_HELPER_MISSING).
  Error:
  ```


  ### Steps to reproduce
  Start audio-recorder (preferable from command-line) and try to record using `M4A` format.
  The cmd-line produces the error mentioned above.
  Tried it on different NixOS installations.


  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.57, NixOS, 19.03.173054.754763ff4ba (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(user): `"nixos-unstable-19.09pre184359.73392e79aa6"`
   - channels(root): `"nixos-19.03.173054.754763ff4ba, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: open
title: Create a package for Rubinius.
user_login: zacts
html_url: https://github.com/NixOS/nixpkgs/issues/64457
updated_at: 2019-07-19 04:14:13
body:
  I am working on creating a Nixpkgs package for the Rubinius language interpreter:
  [Rubinius GitHub](https://github.com/rubinius/rubinius). Here is my progress so far: https://gist.github.com/zacts/d9cf55a7312e78699e478be431fe2ec9   and   https://gist.github.com/zacts/5b5a8a64ad7941821ba34e0f78404746.


state: open
title: Coreutils build fails with ZFS filesystem
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/issues/64459
updated_at: 2019-07-16 07:03:11
body:
  ## Issue description
  Coreutils build fails when building in a ZFS filesystem (at least I highly suspect that to be the cause), due to a test failure:
  ```
  FAIL: tests/du/basic
  ====================

  --- exp 2019-07-08 20:30:19.141329213 +0000
  +++ out 2019-07-08 20:30:19.124329113 +0000
  @@ -1,7 +1,7 @@
   1      d/sub/2
   2      d/sub
  -9      d/1
  -12     d
  +1      d/1
  +4      d
   ===
   2      d/sub
   10     d
  FAIL tests/du/basic.sh (exit status: 1
  ```


  ### Steps to reproduce
  Try to build coreutils such that the build directory is in ZFS.


  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.57, NixOS, 19.09.git.d543e4f (Loris)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```


state: closed
title: cdrtools: fix for darwin
user_login: Amar1729
html_url: https://github.com/NixOS/nixpkgs/pull/64460
updated_at: 2019-07-12 15:26:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updated `cdrtools` to compile on darwin. Some recent change to macOS frameworks in nix must have fixed this since I used to not be able to build this at all ( closes #60357 )

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pydot_ng tests fail
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/issues/64461
updated_at: 2019-07-08 21:33:56
body:
  ## Issue description
  pydot_ng cannot be built as the tests fail.

  Broken on hydra too: https://hydra.nixos.org/job/nixos/release-19.03/nixpkgs.python37Packages.pydot_ng.x86_64-linux/all

  ### Steps to reproduce
  ```
  $ nix-build -E 'with import <nixpkgs> {}; python37.withPackages (p: [p.pydot_ng])'
  ...
  running install tests
  mkdir: cannot create directory ‘test/my_tests’: File exists
  ...
  ```


  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.15.0-54-generic, Ubuntu, 18.04.2 LTS (Bionic Beaver)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(charlie): `"nixpkgs-19.09pre182571.e829aeefa35"`
   - nixpkgs: `/home/charlie/.nix-defexpr/channels/nixpkgs`
  ```


state: open
title: pydot_ng: fix graphviz path and tests (fixes #64461)
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/pull/64462
updated_at: 2019-07-12 06:46:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This fixes
  * An `mkdir` that fails because the directory already exists, in the check phase
  * A dependency on the `mock` module
  * Substitution of the correct path to graphviz into the source code

  The latter is done via a somewhat ugly patch. Happy to try other approaches!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/graylog: minor fixes, add test
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/64463
updated_at: 2019-07-21 20:59:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This PR consists of three changes:

  * `3464c60`: ensure that the directory which contains the node-id files (`/var/lib/graylog/server` by default) exists. If the directory doesn't exist, graylog's startup breaks.
  * `5dad370`: update `SystemdJournal2Gelf` (a tool which sends journal logs from systemd to graylog) to the latest version. Also modified the package to use `buildGoModule` now.
  * `875f533 `: write a simple test for graylog which ensures that an input can be created and a log message can be sent to it. Further details are explained in the commit message.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.github-webhook: unstable-2016-03-11 to 1.0.2
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64464
updated_at: 2019-07-13 16:50:17
body:
  ###### Motivation for this change
  Fixes builds for repology :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Font Request: Victor Mono
user_login: matthew-piziak
html_url: https://github.com/NixOS/nixpkgs/issues/64465
updated_at: 2019-07-18 22:47:15
body:
  [Victor Mono](https://rubjo.github.io/victor-mono/) is a free programming font with semi-connected cursive italics and symbolic ligatures. 

  The typeface is clean, crisp and narrow, with a large x-height. It is optimised for legible code, and comes in seven weights. It is available in Roman, Italic and Oblique styles.

  ![image](https://user-images.githubusercontent.com/6801001/60857590-2a3b1100-a1d9-11e9-8b23-17fec720bded.png)


state: closed
title: dotnet-sdk build fails. Access denied to obj/ in /nix/store/XXX/XXX/obj/
user_login: kcalvinalvin
html_url: https://github.com/NixOS/nixpkgs/issues/64466
updated_at: 2019-07-17 20:24:40
body:
  ## Issue description
  I'm trying to build a dotnet package and the build is failing because dotnet is denied access to obj/. 


  ### Steps to reproduce
  package used
  https://github.com/kcalvinalvin/calvin-nix-conf/tree/master/pkgs/NBXplorer


  ## Technical details
  Generating MSBuild file /nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-NBXplorer/NBXplorer.Client/obj/NBXplorer.Client.csproj.nuget.g.props.                             
  /nix/store/2nhws4j7h28iyplsdhn0p29harwlbhyz-dotnet-sdk-2.2.103/sdk/2.2.103/NuGet.targets(114,5): error : Access to the path '/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-
  NBXplorer/NBXplorer.Client/obj' is denied. [/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-NBXplorer/NBXplorer.sln]                                                        
  /nix/store/2nhws4j7h28iyplsdhn0p29harwlbhyz-dotnet-sdk-2.2.103/sdk/2.2.103/NuGet.targets(114,5): error :   Permission denied [/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj
  -NBXplorer/NBXplorer.sln]
  Generating MSBuild file /nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-NBXplorer/NBXplorer.Client/obj/NBXplorer.Client.csproj.nuget.g.props.                             
  /nix/store/2nhws4j7h28iyplsdhn0p29harwlbhyz-dotnet-sdk-2.2.103/sdk/2.2.103/NuGet.targets(114,5): error : Access to the path '/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-
  NBXplorer/NBXplorer.Client/obj' is denied. [/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj-NBXplorer/NBXplorer.sln]                                                        
  /nix/store/2nhws4j7h28iyplsdhn0p29harwlbhyz-dotnet-sdk-2.2.103/sdk/2.2.103/NuGet.targets(114,5): error :   Permission denied [/nix/store/vwa04mv982xiz03gxvi780pi6pgzzykj
  -NBXplorer/NBXplorer.sln]
  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: jetbrains.idea-community: add darwin support
user_login: uri-canva
html_url: https://github.com/NixOS/nixpkgs/pull/64467
updated_at: 2019-07-15 03:50:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add darwin support to `jetbrains.idea-community`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: saml2aws: 2.10.0 -> 2.15.0
user_login: pmyjavec
html_url: https://github.com/NixOS/nixpkgs/pull/64468
updated_at: 2019-07-11 08:39:44
body:
  ###### Motivation for this change

  Bump to the latest version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: curaLulzbot version
user_login: jrobinson-uk
html_url: https://github.com/NixOS/nixpkgs/issues/64469
updated_at: 2019-07-13 21:25:55
body:
  https://github.com/NixOS/nixpkgs/blob/9ec7625cee5365c741dee7b45a19aff5d5d56205/pkgs/applications/misc/cura/lulzbot.nix#L8

  Is there a way to install a more recent version of cura-lulzbot edition?


state: closed
title: pythonPackages.pytricia: unstable-2019-01-16 -> 1.0.0
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64470
updated_at: 2019-07-13 17:53:27
body:
  ###### Motivation for this change
  Updating "troubled" repology packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```
  $ nix path-info -Sh ./results/pytho*
  /nix/store/s6wk8z69xnmh5i2wwbldw58nxrwid5gc-python2.7-pytricia-1.0.0      94.6M
  /nix/store/wdsn2lv2khc6c9inzb04af6ph881wvq1-python3.7-pytricia-1.0.0      96.8M
  ```

  ```
  $ nix-review wip
  ...
  [1 built, 0.0 MiB DL]
  2 package were build:
  python27Packages.pytricia python37Packages.pytricia
  ```


state: open
title: pkgsStatic.borgbackup fails
user_login: nomeata
html_url: https://github.com/NixOS/nixpkgs/issues/64471
updated_at: 2019-07-09 08:16:24
body:
  I tried to build a static version of `borgbackup`, but it failed:

  ```
  $ nix build pkgsStatic.borgbackup -f .
  …
  builder for '/nix/store/8xji6vq74qz05bansmk362vfqi005dgg-keyutils-1.6-x86_64-unknown-linux-musl.drv' failed with exit code 1; last 10 log lines:
    grep: /usr/lib/rpm: No such file or directory
    x86_64-unknown-linux-musl-gcc -I. -g -Wall -Werror -o keyctl.o -c keyctl.c
    x86_64-unknown-linux-musl-gcc -I. -DPKGBUILD="\"1970-01-01\"" -DPKGVERSION="\"keyutils-1.6\"" -DAPIVERSION="\"libkeyutils-1.8\"" -g -Wall -Werror -fPIC -o keyutils.os -c keyutils.c
    x86_64-unknown-linux-musl-gcc -g -Wall -Werror -fPIC  -shared -Wl,-soname,libkeyutils.so.1 -Wl,--version-script,version.lds -o libkeyutils.so.1.8 keyutils.os
    /nix/store/b2zlnsp56ccrq2y0ybgwlm3m2ils7xhj-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: /nix/store/zyrpxbdzmqpi2yvxypxkwsp5d2z3g05j-x86_64-unknown-linux-musl-stage-final-gcc-debug-7.4.0/lib/gcc/x86_64-unknown-linux-musl/7.4.0/crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object
    /nix/store/b2zlnsp56ccrq2y0ybgwlm3m2ils7xhj-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: /nix/store/zyrpxbdzmqpi2yvxypxkwsp5d2z3g05j-x86_64-unknown-linux-musl-stage-final-gcc-debug-7.4.0/lib/gcc/x86_64-unknown-linux-musl/7.4.0/crtend.o: relocation R_X86_64_32 against `.ctors' can not be used when making a shared object; recompile with -fPIC
    /nix/store/b2zlnsp56ccrq2y0ybgwlm3m2ils7xhj-x86_64-unknown-linux-musl-binutils-2.31.1/bin/x86_64-unknown-linux-musl-ld: final link failed: nonrepresentable section on output
    collect2: error: ld returned 1 exit status
    make: *** [Makefile:138: libkeyutils.so.1.8] Error 1
    builder for '/nix/store/8xji6vq74qz05bansmk362vfqi005dgg-keyutils-1.6-x86_64-unknown-linux-musl.drv' failed with exit code 2
  cannot build derivation '/nix/store/1amll33h5m5c1w5lvd08iz3rjilzkfq1-libkrb5-1.17-x86_64-unknown-linux-musl.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/p0lqychn6d30nh4kfd0i77xi984m6nqx-openssh-7.9p1-x86_64-unknown-linux-musl.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/28fcvpfy6db21vcw3sckn2pw7rb8b75w-borgbackup-1.1.10-x86_64-unknown-linux-musl.drv': 1 dependencies couldn't be built
  ```

  This is with `nixpkgs` revision 6cc7e33ac8ac7b255bd621e8fbfb29c1fd49966e

  It is not super important to me, so if reports about a random package not building statically are not helpful at this point, feel free to just close this.


state: open
title: problem with gpg-connect-agent
user_login: rndd-AK
html_url: https://github.com/NixOS/nixpkgs/issues/64472
updated_at: 2019-07-09 08:22:17
body:
  ## Issue description

  [rndd@core:~]$ su
  Password:
  gpg-connect-agent: failed to create temporary file '/roo
  gpg-connect-agent: can't connect to the agent: No such f
  gpg-connect-agent: error sending standard options: No ag

  ### Steps to reproduce

    1  type "su" in console
    2 enter your root pass
    3  profit

  my system config https://github.com/rndd-AK/configs_for_Acer_Swift_SF113-31_V1.13/tree/master/nixos
  other configs are default

  ## Technical details

  [rndd@core:~]$ nix-shell -p nix-info --run "nix-info -m"

      system: "x86_64-linux"
      host os: Linux 5.1.14, NixOS, 19.09pre183832.20b993ef2c9 (Loris)
      multi-user?: yes
      sandbox: yes
      version: nix-env (Nix) 2.2.2
      channels(root): "nixos-19.09pre183832.20b993ef2c9"
      channels(rndd): ""
      nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos


state: closed
title: New vim plugins
user_login: Taneb
html_url: https://github.com/NixOS/nixpkgs/pull/64473
updated_at: 2019-07-09 10:01:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I've added a few vim plugins I've used.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cfitsio: 3.450 -> 3.47
user_login: xbreak
html_url: https://github.com/NixOS/nixpkgs/pull/64474
updated_at: 2019-07-18 22:28:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Update to latest release, skipping 3.460. See also [changelog](https://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/docs/changes.txt).


  ###### Things done
  - Use version number without trailing '0'
  - Disable format hardening since it broke the build.
  - Remove the now obsolete (from what I understand) patch `darwin-curl-config.patch` (I need help testing this on Darwin).
  ---
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Tested on CentOS 7.4:
  - [x] cfitsio
  - [ ] ~~ufraw~~ (currently broken on master)
  - [x] indilib
  - [x] gildas
  - [x] giv (manual testing by loading fits-files)

  ---


state: open
title: undervolt: service contains "unrecognized arguments"
user_login: VlivesRaw
html_url: https://github.com/NixOS/nixpkgs/issues/64475
updated_at: 2019-07-10 17:41:19
body:
  ## Issue description
  If you try to enable `undervolt` service it would fail with `undervolt: error: unrecognized arguments: Restart=no`
  I solved the issue by removing `Restart="no"` and `Type="oneshot'` from undervolt.nix, but I still don't understand why it fails, since the syntax seems to be correct.

  ### Steps to reproduce
  add `services.undervolt.enable = true;` to configuration.nix


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.16, NixOS, 19.09pre184855.beff2f8d75e (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre184855.beff2f8d75e, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: movit: 1.6.2 -> 1.6.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64476
updated_at: 2019-07-13 09:07:54
body:
  https://movit.sesse.net/


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ponyc: 0.28.1 -> 0.29.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64477
updated_at: 2019-07-17 09:45:49
body:
  ###### Motivation for this change

  https://www.ponylang.io/blog/2019/07/0.29.0-released/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stern: 1.10.0 -> 1.11.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64478
updated_at: 2019-07-13 16:18:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/wercker/stern/releases/tag/1.11.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: notable: 1.4.0 -> 1.6.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64479
updated_at: 2019-07-17 09:45:15
body:
  ###### Motivation for this change

  Not sure why we (I?) missed updating 1.5.1,
  but 1.6.0 looks good here :).


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: dbeaver: 6.1.0 -> 6.1.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64480
updated_at: 2019-07-11 15:09:02
body:
  ###### Motivation for this change

  https://dbeaver.io/2019/07/07/dbeaver-6-1-2/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: radiotray-ng: 0.2.5 -> 0.2.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64481
updated_at: 2019-07-11 08:11:45
body:
  ###### Motivation for this change

  https://github.com/ebruck/radiotray-ng/releases/tag/v0.2.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xterm: 346 -> 347
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64482
updated_at: 2019-07-15 09:57:35
body:
  ###### Motivation for this change

  https://invisible-island.net/xterm/xterm.log.html#xterm_347

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cri-tools: 1.14.0 -> 1.15.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64483
updated_at: 2019-07-10 07:31:20
body:
  ###### Motivation for this change

  https://github.com/kubernetes-sigs/cri-tools/releases/tag/v1.15.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lazydocker: 0.5 -> 0.5.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64484
updated_at: 2019-07-09 20:18:36
body:
  ###### Motivation for this change

  https://github.com/jesseduffield/lazydocker/releases/tag/v0.5.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: python-jsonrpc-server bad checksum in 19.03
user_login: cdyson37
html_url: https://github.com/NixOS/nixpkgs/issues/64485
updated_at: 2019-07-10 17:40:45
body:
  https://github.com/NixOS/nixpkgs/blob/ed3895a9870816af1e968b1485543212ac2bac13/pkgs/development/python-modules/python-jsonrpc-server/default.nix#L14

  The checksum has changed (!)
  ```
  $ nix-prefetch-url --unpack --print-path http://github.com/palantir/python-jsonrpc-server/archive/0.0.2.tar.gz
  unpacking...
  [0.0 MiB DL]
  07n2f0k7w5ld1bkfadzjvqr1s9crg6zsxnl5x3qz28jhpw5qaxm0
  /nix/store/a2zxg3zpr8g9c25l4z380yfq4fmgcjhr-0.0.2.tar.gz
  ```


state: open
title: elm.elmPackages: Update elm-analyse and node2nix
user_login: turboMaCk
html_url: https://github.com/NixOS/nixpkgs/pull/64486
updated_at: 2019-07-15 14:13:25
body:
  ###### Motivation for this change
  Newer node2nix has fix for the issue that prevented latest `elm-analyse` version to be installed. 

  ###### Things done
  1. Remove version constrain for `elm-analyse`
  2. run `./generate-node-packages.sh`

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lesspipe: 1.82 -> 1.83
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64487
updated_at: 2019-07-11 08:11:16
body:
  ###### Motivation for this change

  Only minimal poking done so far, reports from interested testers
  appreciated!


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: klavaro: 3.08 -> 3.09, patch format-string, espeak support
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64488
updated_at: 2019-07-13 16:31:33
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: vale: 1.4.3 -> 1.5.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64489
updated_at: 2019-07-09 11:35:27
body:
  ###### Motivation for this change

  https://github.com/errata-ai/vale/releases/tag/v1.5.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x]  NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oxipng: 2.2.1 -> 2.2.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64490
updated_at: 2019-07-13 10:34:02
body:
  ###### Motivation for this change

  https://github.com/shssoichiro/oxipng/releases/tag/v2.2.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: powerstat: 0.02.18 -> 0.02.19
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64491
updated_at: 2019-07-13 16:27:45
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: evdi: 1.6.1 -> 1.6.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64492
updated_at: 2019-07-09 11:51:28
body:
  https://github.com/DisplayLink/evdi/releases/tag/v1.6.2

  Since it's short:

      support for 5.2 kernel
      Intel-IOMMU workaround
      workaround for problem with FourCC when switching Xorg <-> Wayland
      fix issues found with Coverity


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: i2pd: 2.26.0 -> 2.27.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64494
updated_at: 2019-07-09 11:59:36
body:
  ###### Motivation for this change

  https://github.com/PurpleI2P/i2pd/releases/tag/2.27.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: libtorrent-rasterbar: 1.1.11 -> 1.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64496
updated_at: 2019-07-11 07:57:16
body:
  ###### Motivation for this change

  https://github.com/arvidn/libtorrent/releases/tag/libtorrent-1_2_1
  https://github.com/arvidn/libtorrent/releases/tag/libtorrent_1_2_0
  https://github.com/arvidn/libtorrent/releases/tag/libtorrent-1_1_13
  https://github.com/arvidn/libtorrent/releases/tag/libtorrent_1_1_12

  Needed for deluge update following shortly, as I recall...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: proj: 5.2.0 -> 6.1.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64497
updated_at: 2019-07-13 10:38:05
body:
  ###### Motivation for this change

  https://proj.org/download.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xscreensaver: 5.40 -> 5.43
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64498
updated_at: 2019-07-09 12:34:01
body:
  ###### Motivation for this change

  https://www.jwz.org/xscreensaver/changelog.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - Tested many but not exhaustive list of screensavers, seems good? :)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: palemoon: 27.9.4 -> 28.6.0.1, refactor
user_login: OPNA2608
html_url: https://github.com/NixOS/nixpkgs/pull/64499
updated_at: 2019-07-21 05:26:02
body:
  supersedes #51161
  closes #51160

  ![Screenshot_NixOS_19 03_2019-07-09_08:36:04](https://user-images.githubusercontent.com/23431373/60887381-8b53fa80-a254-11e9-99c5-96892329948a.png)

  ---

  GConf dependency added as discussed in #55161.

  The NixOS build problem that was encountered there took some log digging to find:
  There was an attempted invocation of `m4` that failed, but didn't causes an abortion of the build phase. Later on, that seemingly resulted in some files missing and an abortion of the install phase.

  This seems to have not been an issue on non-NixOS systems, where the lack of sandboxing lead to `m4` being found inside the user's PATH?

  The configure script also checks for the presence of `wget`, but I don't know what for. Just to be safe, I added it to `buildInputs` as well.

  I think `gstreamer` was deprecated afew versions ago and can be removed from `buildInputs`, I will do some testing in general to figure out what else might not be required anymore though.

  (Also, it looks like Pale Moon can be built for GTK3 so having a `withGtk3` option could make sense, question would be how endorsed that is by upstream and if it may continue using the official branding in that case.)

  ---

  ~~A major *not-nice* aspect of this PR is a set of exceptions that get thrown during the install phase:~~
  ~~They don't abort the installation however, and the browser appears to work fine. I don't know how to fix those yet, but I'll look into it. If anyone wants to help me, be my guest ofc. :slightly_smiling_face:~~

  See comment below.


  ###### Motivation for this change

  see #51160

  tl;dr, the currently packaged version is

  1) out-of-date
  2) frequently complaining about being out-of-date
  3) lacking important security updates that have been added since its release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mesa: fixup darwin build
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/pull/64500
updated_at: 2019-07-09 11:53:17
body:
  by a patch suggested upstream

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Blocking lots of darwin builds.  See previous discussion from https://github.com/NixOS/nixpkgs/pull/63875#issuecomment-506513932

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: skaffold: 0.30.0 -> 0.33.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64501
updated_at: 2019-07-09 12:32:04
body:
  ###### Motivation for this change

  https://github.com/GoogleContainerTools/skaffold/releases/tag/v0.33.0
  https://github.com/GoogleContainerTools/skaffold/releases/tag/v0.32.0
  https://github.com/GoogleContainerTools/skaffold/releases/tag/v0.31.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: krita: 4.2.1 -> 4.2.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64502
updated_at: 2019-07-10 08:50:09
body:
  ###### Motivation for this change

  https://krita.org/en/item/krita-4-2-2-released/

  Haven't build-tested on current master,
  but don't know that anything especially newer is needed.

  Let's just make sure :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gtk: 3.24.8 -> 3.24.9 -> 3.24.10
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64503
updated_at: 2019-07-09 19:58:38
body:
  ###### Motivation for this change

  https://ftp.gnome.org/pub/gnome/sources/gtk+/3.24/gtk+-3.24.10.news
  https://ftp.gnome.org/pub/gnome/sources/gtk+/3.24/gtk+-3.24.9.news

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libdrm: 2.4.98 -> 2.4.99
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64504
updated_at: 2019-07-11 08:17:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://lists.x.org/archives/xorg-announce/2019-July/003001.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jsoncpp: 1.8.4 -> 1.9.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64505
updated_at: 2019-07-09 19:59:25
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: trilium: (0.32.4,0.33.5) -> 0.33.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64506
updated_at: 2019-07-09 20:09:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: electrum: 3.3.6 -> 3.3.7
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64507
updated_at: 2019-07-11 14:16:45
body:
  ###### Motivation for this change

  https://github.com/spesmilo/electrum/blob/master/RELEASE-NOTES

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yubikey-personalization: 1.19.3 -> 1.20.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64508
updated_at: 2019-07-18 20:13:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://developers.yubico.com/yubikey-personalization/Release_Notes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kakoune: 2019.01.20 -> 2019.07.01
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64510
updated_at: 2019-07-15 09:57:17
body:
  ###### Motivation for this change

  https://github.com/mawww/kakoune/releases/tag/v2019.07.01


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: goxel: 0.9.0 -> -> 0.10.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64511
updated_at: 2019-07-09 13:35:42
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: netdata: 1.15.0 -> 1.16.0
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/64512
updated_at: 2019-07-09 15:46:34
body:
  ###### Motivation for this change
  Update netdata to version 1.16.0
  Changelog - https://docs.netdata.cloud/changelog/#v1160-2019-07-08

  cc @Mic92

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: freetype: 2.10.0 -> 2.10.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64513
updated_at: 2019-07-20 05:42:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://sourceforge.net/projects/freetype/files/freetype2/2.10.1/

  I've been experimenting with mini bootstrap to get freetype and harfbuzz
  built with support for the other, as well as using freetype's default
  (instead of "encumbered" cleartype) mostly to see what the state of
  things were and for potentially avoiding any/all color fringing
  without mucking with lcd filter settings.

  This PR simply bumps the freetype version, don't worry :).
  Not sure the bootstrap dance helps anything, but if anyone has
  **recent** images/data/information on default ("Harmony"?) vs
  "encumbered" cleartype that'd be appreciated.

  I've been happy with Harmony so far, but maybe I'm not looking at the
  right details or use different sorts of programs...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: txr: 217 -> 219
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64514
updated_at: 2019-07-09 17:13:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libinput: 1.13.2 -> 1.13.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64515
updated_at: 2019-07-11 14:24:38
body:
  ###### Motivation for this change

     https://lists.freedesktop.org/archives/wayland-devel/2019-June/040675.html

     https://lists.freedesktop.org/archives/wayland-devel/2019-June/040650.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x]  Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: most: 5.0.0a -> 5.1.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64516
updated_at: 2019-07-13 02:19:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `most` to the latest release.
  - https://www.jedsoft.org/releases/most/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @GrahamcOfBorg build most


state: closed
title: django: Init at 2.0.2
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64518
updated_at: 2019-07-09 16:31:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding an older version of Django that is still being used in some projects.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: packr: 2.5.1 -> 2.5.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64519
updated_at: 2019-07-09 13:38:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `packr` to the latest release.
  - https://github.com/gobuffalo/packr/releases/tag/v2.5.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  @GrahamcOfBorg build packr


state: open
title: django-maintenance-mode: init at 0.13.1
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64520
updated_at: 2019-07-12 12:02:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding a missing Django package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: django-ranged-response: init at 0.2.0
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64521
updated_at: 2019-07-10 12:28:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pax-utils: 1.2.2 -> 1.2.4
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64522
updated_at: 2019-07-10 11:54:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `pax-utils` to the latest release.
  * https://gitweb.gentoo.org/proj/pax-utils.git

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: django-simple-captcha: init at 0.5.6
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64523
updated_at: 2019-07-11 10:43:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding a missing Django package. It depends on [django-ranged-response](https://github.com/NixOS/nixpkgs/pull/64521).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: eclipses: 2018-12 -> 2019-06
user_login: jerith666
html_url: https://github.com/NixOS/nixpkgs/pull/64524
updated_at: 2019-07-09 19:28:44
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: rq: init at 1.0
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64525
updated_at: 2019-07-10 19:06:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding a new package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: dj-static: init at 0.0.6
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64527
updated_at: 2019-07-10 15:40:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding a missing Django package, including dependency static3 v0.7.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: filezilla: 3.42.1 -> 3.43.0, libfilezilla: 0.16.0 -> 0.17.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64528
updated_at: 2019-07-14 16:47:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `filezilla` and `libfilezilla` to the latest releases.
  - https://filezilla-project.org/download.php?show_all=1
  - https://lib.filezilla-project.org/
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: picos: init at 1.2.0
user_login: tobiasBora
html_url: https://github.com/NixOS/nixpkgs/pull/64529
updated_at: 2019-07-21 21:34:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Introduce the picos library, a "user friendly Python API to several conic and integer programming solvers, very much like YALMIP or CVX under MATLAB."

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pkg-config does not know any libraries.
user_login: kindaro
html_url: https://github.com/NixOS/nixpkgs/issues/64530
updated_at: 2019-07-17 09:05:58
body:
  ## Issue description

  I need to have some libraries, such as `libsystemd`, available and visible with `pkg-config` to do my programming. Unfortunately, I discover that `pkg-config --list-all` output is completely blank. I can fix it by an appropriate assignment of `PKG_CONFIG_PATH`, but I would expect it to work out
  of the box.

  ### Steps to reproduce

  Install Nix and then install `systemd` and `pkg-config` via `nix-env`.

      % pkg-config --modversion libsystemd
      Package libsystemd was not found in the pkg-config search path.
      Perhaps you should add the directory containing `libsystemd.pc'
      to the PKG_CONFIG_PATH environment variable
      No package 'libsystemd' found
      % export PKG_CONFIG_PATH=$(dirname `find /nix -name 'libsystemd.pc'`)
      % pkg-config --modversion libsystemd
      242

  ## Technical details

      % nix-shell -p nix-info --run "nix-info -m"
      warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixpkgs' does not exist, ignoring
      warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixpkgs' does not exist, ignoring
       - system: `"x86_64-linux"`
       - host os: `Linux 5.1.16-arch1-1-ARCH, Arch Linux, noversion`
       - multi-user?: `yes`
       - sandbox: `yes`
       - version: `nix-env (Nix) 2.2.2`
       - channels(kindaro): `"nixpkgs-19.09pre184803.d567c486ca5"`
      warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels/nixpkgs' does not exist, ignoring
       - nixpkgs: `/home/kindaro/.nix-defexpr/channels/nixpkgs`


state: closed
title: cargo-xbuild: 0.5.12 -> 0.5.13
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64531
updated_at: 2019-07-11 08:09:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `cargo-xbuild` to the latest release.
  - https://github.com/rust-osdev/cargo-xbuild/releases/tag/v0.5.13
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lxd: add criu to path and bash completions, lxc: fix bash completions
user_login: megheaiulian
html_url: https://github.com/NixOS/nixpkgs/pull/64532
updated_at: 2019-07-13 16:20:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Adds `criu` to the path of `lxd` so live migrations can be performed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [lxd] adds bash completions
user_login: megheaiulian
html_url: https://github.com/NixOS/nixpkgs/pull/64533
updated_at: 2019-07-11 20:07:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Adds bash completions 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [lxc] fix bash completions
user_login: megheaiulian
html_url: https://github.com/NixOS/nixpkgs/pull/64534
updated_at: 2019-07-11 20:10:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Moves the `lxc` bash completion file to `lxc-start` and than symlinks all lxc commands that have completions to `lxc-start`. This allows bash completions to work correctly for all `lxc-*` commands.
   
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: txr: 117 -> 220
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64535
updated_at: 2019-07-18 20:21:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Replaces the txr 117 -> 119 PR, will handle that shortly :).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: foliate: init at 1.5.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64536
updated_at: 2019-07-21 22:05:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  "A simple and modern GTK eBook reader".

  Took some wrangling to get gjs to run without having problems finding
  'main' or some resource, see linked issues from code for some details of
  similar.  Does seem to work nicely now, though! ^_^

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x]  Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bazel-buildtools: 0.22.0 -> unstable-2019-06-21
user_login: u-quark
html_url: https://github.com/NixOS/nixpkgs/pull/64537
updated_at: 2019-07-10 14:51:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Continuation from https://github.com/NixOS/nixpkgs/pull/63856

  Update to HEAD of master. There are a few nice features there, so it might make sense to go directly to HEAD.

  I used [go2nix](https://github.com/kamilchm/go2nix) to produce the files, even though I patched `default.nix` to include the meta info.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnupg: 2.2.16 -> 2.2.17
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64538
updated_at: 2019-07-11 17:21:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://lists.gnupg.org/pipermail/gnupg-announce/2019q3/000439.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Still working on rebuilding all the things against it, FWIW, but sending
  along to get same process started by the builders sooner rather than
  later :).

  ---


state: closed
title: gl2ps: init at 1.4.0
user_login: twhitehead
html_url: https://github.com/NixOS/nixpkgs/pull/64539
updated_at: 2019-07-21 14:16:38
body:
  <!-- Nixpkgs  of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions:has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Library required by octave to close #38459. Picked @7c6f434c as maintainer as is the maintainer of octave. Hope this was okay.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: strip setup hook: Strip using --strip-unneeded instead of --strip-debug.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/64540
updated_at: 2019-07-22 07:16:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Reduce binary sizes. See the discussion in #64427.

  According to these, `--strip-unneeded` is the right way to strip and shouldn't break programs:
  https://www.technovelty.org/linux/stripping-shared-libraries.html
  https://www.debian.org/doc/debian-policy/ch-files.html#binaries

  The strip man page describes `--strip-unneeded` as "Remove all symbols that are not needed for relocation processing", which I think means that it strip everything that can be stripped which is not needed to run stuff.

  ###### Things done

  Tested with my system (nixos-unstable, x86-64) including KDE, Chromium, Firefox and VirtualBox. Build succeeded, closure size went from 8.24 GB to 7.91 GB, no runtime problems observed.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mirrors.nix: add alsa-project.org for alsa
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/64541
updated_at: 2019-07-16 17:12:52
body:
  ###### Motivation for this change
  Aside from being an HTTPS endpoint, this is the canonical mirror for alsa
  project downloads.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: deluge: 1.1.11 -> 2.0.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64542
updated_at: 2019-07-11 07:56:18
body:
  ###### Motivation for this change

  Requires libtorrentrasterbar update, will link relevant PR's shortly.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: riot-desktop starts and just displays "Riot is misconfigured"
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/64543
updated_at: 2019-07-13 17:30:40
body:
  ## Issue description

  See screenshot:
  ![output](https://user-images.githubusercontent.com/327028/60919742-ca0aa480-a296-11e9-9af4-5d46e86ee546.png)


  ### Steps to reproduce

  1. install `riot-desktop`.
  2. try to start it


state: closed
title: victor-mono: init at 1.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64544
updated_at: 2019-07-18 00:11:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes #64465.

  Haven't tested installation but inspecting output LGTM-- requester want
  to confirm this works for you? :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nodePackages.dockerfile-language-server-nodejs: init at 0.0.21
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/64545
updated_at: 2019-07-15 01:05:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


