# issues

state: closed
title: [18.09] postfix: 3.3.1 -> 3.3.2
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/51395
updated_at: 2018-12-04 19:57:50
body:
  ###### Motivation for this change
  Backport of #51063
  http://www.postfix.org/announcements/postfix-3.3.2.html

  ~~I also had to cherry-pick two other commits touching `postfix` derivation. Most notably one enabling LDAP support by default.~~ @Mic92
  ~~I think it's safe to backport but feedback welcome on this.~~

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update KDE Connect to 1.3.3
user_login: shreyanshk
html_url: https://github.com/NixOS/nixpkgs/issues/51396
updated_at: 2018-12-03 01:38:32
body:
  Hi,
  Please consider updating KDE Connect version to 1.3.3 (available in the master branch) in the release-18.09 branch so that it can again work with the companion android app.

  Thank you.


state: closed
title: installer: Adds AArch64 UEFI installer support. (Work towards SBBR and EBBR support)
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/51397
updated_at: 2019-02-12 02:32:46
body:
  ###### Motivation for this change

  Eventually make NixOS work with [SBBR](http://infocenter.arm.com/help/topic/com.arm.doc.den0044c/index.html) and [EBBR](https://github.com/ARM-software/ebbr) compliant platforms.

  A good first step for distros is to provide a UEFI-bootable image for ARM.

  This PR makes the build process for the installer image work for AArch64.

  ###### Testing on real-world hardware

  You will need an AArch64 machine which can UEFI boot. This is not as onerous as one could think. Mainline u-boot has the ability to boot UEFI-based images (this is an exercise left to the reader).

  One of the most popuplar SBC, the Raspberry Pi, in its third major revision, the **Raspberry Pi 3B**, can boot Tiano Core, which is a reference UEFI implementation, using `@`andreiw's [64-bit Tiano Core UEFI for the Raspberry Pi 3](https://github.com/andreiw/RaspberryPiPkg). This is one of the way I have verified the work.

  First, pick an SD card you wan to use as your UEFI firmware, it can be really small, it only needs to fit the Tiano Core build. Format one FAT32 partition on it, name it as you want, I chose `$TIANOCORE$` to make sure I don't accidentally use it. Copy the contents of one of the pre-built Tiano Core builds (found under `Binary/prebuilt/*/RELEASE`) to the root of the FAT32 partition. Eject your SD card and put it in the Raspberry Pi. Ensure it boots to Tiano Core (it should show up a gigantic raspberry with a countdown timer, it will eventually boot the UEFI shell).

  Then, burn the AArch64 iso as you would the normal x86_64 iso, (a simple `dd`). Plug that USB drive to the Raspberry Pi, boot it, it should automatically continue to GRUB. For the graphical console to work on the Raspberry Pi, you will need to add `cma=32M` to the command line (press `e`  to edit an entry, `CTRL+X` to boot it.) This PR does not touch the kernel parameters as they are a board-specific quirk.

  > **NOTE**: it's possible that the graphical console may fail late in stage-2, before being given control of the system. This is related to the mainline kernel's vc4 modesetting driver not liking it when the Raspberry Pi's own firmware writes to the buffer (probably wrongly oversimplified explanation). If you get some weirdness there (mainly, being shown older boot messages), it's *not* this PR's fault. Things to try: (1) have a powerful enough, and properly rated power supply (2) add `avoid_warnings=1` to the Raspberry Pi's config.txt. It is possible, most times, to recover by switching back and forth between VTs, so CTRL+ALT+F2 followed by CTRL+ALT+F1 may recover it. 

  ###### Related testing

  A bad rough draft of this implementation was [tested](https://logs.nix.samueldr.com/nixos-aarch64/2018-11-21#1739705) by @nbp on a [SoftIron Overdrive 1000](https://softiron.com/development-tools/overdrive-1000/). I would like it if @nbp could test this cleaned-up build. (It should be 99% equivalent.)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ✔️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ✔️ NixOS
     - ⬜ macOS
     - ⬜ other Linux distributions
  - ⬜ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - ⬜ Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - ✔️ Tested execution of all binary files (usually in `./result/bin/`)
  - 🆖 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ✔️ Assured whether relevant documentation is up to date
  - ✔️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @dezgeg (arm and aarch64 knowledgeable)


state: closed
title: afl-qemu: update to qemu 2.10.0, as specified by afl 2.52b
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/51398
updated_at: 2019-01-06 00:50:56
body:
  refresh patches & configure options directly from afl 2.52b to make
  installation as vanilla as possible

  ###### Motivation for this change

  afl's qemu mode as packaged in `master` and `release-18.09` doesn't work (correct me if it's somehow working for you!), because instead of using the specified 2.10.0, it's been left at 2.3.0. This doesn't work because afl 2.52b passes an env var `QEMU_LOG=nochain`, which qemu 2.3.0 doesn't understand, failing with an error message.

  The patches themselves had also been only minimally updated from what I can see, just enough to get them to compile. Here I've pulled the patches (and `afl-types.h`, `afl-config.h`) fresh from the afl 2.52b sources, but also pulled in a cherrypicked fix from qemu git to build against glibc 2.27.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pagmo2, pythonPackages.pygmo refactor fix broken packages
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/51399
updated_at: 2018-12-14 18:00:25
body:
  ###### Motivation for this change

  Fixed issues with https://github.com/NixOS/nixpkgs/pull/50645 for merging.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Can't rebuild switch, type error at nixos/lib/modules.nix:255:62
user_login: tcosmo
html_url: https://github.com/NixOS/nixpkgs/issues/51400
updated_at: 2018-12-03 12:06:01
body:
  ## Issue description

  Hello, 

  Since today `sudo nixos-rebuild switch` fails on my computer with the following error:

  `error: value is a boolean while a set was expected, at /nix/var/nix/profiles/per-user/root/channels/nixos/lib/modules.nix:255:62`

  This file at this line contains:

  `    // { _definedNames = map (m: { inherit (m) file; names = attrNames m.config; }) configs; };`

  Would you have any idea of what is going wrong?

  Thank you!

  ### Steps to reproduce

  I changed nothing in my configuration simply did `sudo nixos-rebuild switch`.
  My configuration.nix can be found here: https://pastebin.com/HH3u7FHE

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.81, NixOS, 19.03pre159472.80738ed9dc0 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-19.03pre159472.80738ed9dc0"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: all-packages.nix: Alias self to res, deprecating self
user_login: roberth
html_url: https://github.com/NixOS/nixpkgs/pull/51401
updated_at: 2019-02-04 01:19:36
body:
  For historical reasons, self in `all-packages.nix` was ill-named. This removes its usages from `all-packages.nix` and provides a deprecation message for those who use a patched Nixpkgs.

  Some packages seem to depend on the peculiarities of res, as can be seen by making res into an alias of `pkgs` (normally `self`). The `super` variable doesn't have all attributes that are needed.

  Therefore the simple fix is not guaranteed to work and as such,
  usages of `res` need to be changed to `pkgs` or `super`, case by case.

  ###### Motivation for this change

  #34881 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: font-lock-plus: fix recipe
user_login: puffnfresh
html_url: https://github.com/NixOS/nixpkgs/pull/51402
updated_at: 2018-12-02 23:37:11
body:
  Used the wiki fetcher which doesn't seem to exist.

  Replaced with a fake repo. Doesnt seem to be used.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux_latest-libre: update patchset for kernel version
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51403
updated_at: 2018-12-04 11:33:15
body:
  ###### Motivation for this change

  fixes #51219 
  cc @alyssais 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openra: adding individual executables for each mod
user_login: fusion809
html_url: https://github.com/NixOS/nixpkgs/pull/51404
updated_at: 2018-12-19 17:04:22
body:
  OpenRA desktop configuration files presently fail to launch the various mods, as the executable files (`openra-ra` for Red Alert, `openra-cnc` for Tiberian Dawn and `openra-d2k` for Dune 2K) they rely on are not present in this package.

  ###### Motivation for this change
  As previously said the application launchers (i.e. desktop config files) fail to launch the various mods as the executable files they rely upon are not present in PATH (`openra-ra`, `openra-cnc` and `openra-d2k`). This PR creates these executables. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jq: fix download hash
user_login: dylex
html_url: https://github.com/NixOS/nixpkgs/pull/51405
updated_at: 2018-12-02 21:52:56
body:
  ###### Motivation for this change

  It looks like the upstream download file for jq 1.6 has changed (this seems to be an attached source tarball on github, not an actual hash download).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/pmount: add pmount programs module
user_login: Gerschtli
html_url: https://github.com/NixOS/nixpkgs/pull/51406
updated_at: 2018-12-03 17:45:13
body:
  ###### Motivation for this change

  Add pmount module with setuid wrapper.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix NetworkManager-wait-online.service
user_login: M-Gregoire
html_url: https://github.com/NixOS/nixpkgs/pull/51407
updated_at: 2018-12-03 08:55:06
body:
  ###### Motivation for this change

  `NetworkManager-wait-online.service` is broken due to `NetworkManager.service` being renamed `network-manager.service` (See #51375)

  ###### Things done

  Just patched the service to replace `NetworkManager.service` by `network-manager.service`

  @Mic92 Should be good this time!

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnumake: disable subsecond mtime on darwin
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/51408
updated_at: 2019-02-22 04:15:01
body:
  gnumake can support subsecond mtimes if it is available. But Darwin
  doesn’t support setting subsecond mtimes until 10.13! So we can just
  disable this check to avoid the issue where most of our built tools
  use seconds but make uses nanoseconds. Might fix some parallel issues
  along the way.

  Fixes #51221

  /cc @endgame @delroth @thoughtpolice 


state: closed
title: nixos/cockroachdb: supply defaultText for the package option
user_login: pbogdan
html_url: https://github.com/NixOS/nixpkgs/pull/51409
updated_at: 2018-12-03 02:52:15
body:
  ###### Motivation for this change

  This was preventing evaluating the NixOS manual on platforms not supported by `cockroachdb` package itself:

  ```
  Package ‘cockroach-2.1.1’ in /home/pbogdan/nixpkgs/pkgs/servers/sql/cockroachdb/default.nix:59 is not supported on ‘i686-unknown-linux-gnu’, refusing to evaluate.
  ```

  Notably this currently prevents the tested Hydra job from evaluating as the manual is one of the constituents. 

  https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-errors -> CTRL-F "in job ‘tested’:"

  /cc @thoughtpolice 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: intel-media-driver: init at 18.3.0
user_login: jfrankenau
html_url: https://github.com/NixOS/nixpkgs/pull/51410
updated_at: 2018-12-08 14:43:43
body:
  ###### Motivation for this change

  This is the new VA-API driver for Intel chipsets.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  Tested with `vainfo` and `mpv`.


state: closed
title: ntfy: 2.6.0 -> 2.7.0
user_login: jfrankenau
html_url: https://github.com/NixOS/nixpkgs/pull/51411
updated_at: 2018-12-03 10:54:18
body:
  ###### Motivation for this change

  Update and move out of Python modules because this an application and does not provide a Python library. Also build with support for desktop notifications on Linux.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @kamilchm 


state: closed
title: konsole: fix arrow keys
user_login: Synthetica9
html_url: https://github.com/NixOS/nixpkgs/pull/51412
updated_at: 2019-01-09 12:11:33
body:
  ###### Motivation for this change

  (partially?) fixes #29951

  Couldn't get Yakuake to work, so haven't tested that.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: btrfsProgs fails to build on master
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/issues/51413
updated_at: 2018-12-02 23:49:43
body:
  ## Issue description

  ```
  checking for a Python interpreter with version >= 3.4... none
  configure: error: no suitable Python interpreter found
  ```

  Full build logs: https://gist.github.com/delroth/c051107ca2523e8fe4a2e5dca0b480f2

  ### Steps to reproduce

  nix-shell -I nixpkgs=/path/to/nixpkgs -p btrfsProgs

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.80-1-lts, Arch Linux, noversion`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.1.3`
   - channels(delroth): `"nixpkgs-19.03pre159844.7a9acea944d"`
   - nixpkgs: `/home/delroth/.nix-defexpr/channels/nixpkgs`


state: closed
title: Revert "pythonPackages.cypari2: 1.3.1 -> 2.0.1 (#49446)
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/51414
updated_at: 2018-12-02 23:44:40
body:
  ###### Motivation for this change

  This reverts commit 9512841e89e298e40815eea7779973c7905f7a1f.

  The update is causing segfaults. See
  https://trac.sagemath.org/ticket/26442.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update sweethome3d to 6.0
user_login: luzpaz
html_url: https://github.com/NixOS/nixpkgs/issues/51415
updated_at: 2018-12-30 01:29:38
body:
  SweetHome3D released version [6.0 in October](http://sweethome3d.com/blog/2018/10/11/sweet_home_3d_6_0.html). Please consider upgrading the NixOS package as well. Thanks!

  https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/misc/sweethome3d/default.nix


state: closed
title: Cargo segfaults on master
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/issues/51416
updated_at: 2018-12-04 16:56:06
body:
  Cargo segfaults while fetching git dependencies. This is due to a change in libgit2 0.26.8. I have upstream issues here: https://github.com/libgit2/libgit2/pull/4732#issuecomment-443452315 and here: https://github.com/rust-lang/cargo/issues/6365 but figured someone might come hunting here. A simple patch is locally reverting libgit2 to 0.26.6 or 0.26.7 - it doesn't involve many rebuilds.


state: closed
title: vault: 0.11.2 -> 0.11.5
user_login: jvassev
html_url: https://github.com/NixOS/nixpkgs/pull/51417
updated_at: 2018-12-04 22:45:20
body:
  ###### Motivation for this change
  Update bash completion method as described in
  https://www.vaultproject.io/docs/commands/#autocompletion

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dsniff: init at 2.4b1
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/51418
updated_at: 2019-05-18 16:01:26
body:
  ###### Motivation for this change
  I wanted to use tcpkill

  ###### Things done
  upstream does not provide a stable url. So I used debian as source. This enables me to use their 36 patches to have dsniff build with recent version of libraries like openssl. Debian only provides the beta version, like most distros according to repology. This is probably because dsniff is not much maintained. If you think we should not add dsniff to nixpkgs for this reason, I'd understand. I do this PR mainly because I spent time on it, so I'd like to share :)

  Their build system demands static libraries and header files under the same prefix. So I have to override all libraries and merge their outputs. In the end, there is still a reference to openssl for `/nix/store/a23xvnnl29scqqjvcqya6vgs0vnz1shi-openssl-1.1.1/etc/ssl/ct_log_list.cnf` so dsniff will depend on openssl dev output... This is very sad.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] ~Tested execution of all binary files (usually in `./result/bin/`)~ only tcpkill
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodejs.updateScript, thunderbird.updateScript: fix evaluation
user_login: pbogdan
html_url: https://github.com/NixOS/nixpkgs/pull/51421
updated_at: 2018-12-03 04:58:01
body:
  ###### Motivation for this change

  They no longer evaluate after #50977; it makes [the tarball job](https://hydra.nixos.org/build/85290051/log) unhappy.

  /cc @jtojnar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  - [x] `$ nix-build nixos/release-small.nix -A nixpkgs.tarball`


state: closed
title: Csoundqt init 0.9.6-beta2 and python-qt init 3.2
user_login: hlolli
html_url: https://github.com/NixOS/nixpkgs/pull/51422
updated_at: 2018-12-18 05:39:13
body:
  ###### Motivation for this change

  The standard front-end editor for Csound

  ###### Things done

  I included python-qt, a library for embedding python interpreter into qt applications.


  - [ x ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ x ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ x ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: assaultcube: fix version schema
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/pull/51423
updated_at: 2018-12-06 15:57:55
body:
  ###### Motivation for this change

  Change version to correct schema.

  cc maintainer @bignaux

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: systems/parse.nix: support eabihf
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/51425
updated_at: 2019-02-22 04:14:55
body:
  eabihf is an abi that can be used with ARM architectures that support
  the “hard float”. It should probably only be used with ARM32 when you
  are absolutely sure your binaries will run on ARM systems with a FPU.

  Also, add an example "armhf-embedded" to match the preexisting
  arm-embedded system. qmk_firmware needs hard float in a few places, so
  add them here to get that to work.

  Fixes #51184


state: closed
title: logind: make killUserProcesses an option
user_login: benley
html_url: https://github.com/NixOS/nixpkgs/pull/51426
updated_at: 2018-12-11 21:51:21
body:
  Right now it's not at all obvious that one can override this option using `services.logind.extraConfig`; we might as well add an option for `killUserProcesses` directly so it's clear and documented.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scrcpy: 1.3 -> 1.5
user_login: tomberek
html_url: https://github.com/NixOS/nixpkgs/pull/51427
updated_at: 2018-12-07 02:33:25
body:
  ###### Motivation for this change
  Update to newest version

  ###### Things done
  Updated version.
  Added configurations to allow hardware and software rendering.
  Added configuration to remove unneeded errors.
  Added configuration to use prebuilt server directly.
  Tested on Ubuntu, NixOS.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rig: init at 1.11
user_login: tomberek
html_url: https://github.com/NixOS/nixpkgs/pull/51428
updated_at: 2018-12-05 11:41:46
body:
  ###### Motivation for this change
  Simple package, available in other distros.

  ###### Things done
  Took source files from homepage and patches from Debian (thanks Norbert Veber <nveber@debian.org>).

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: glib-networking: build .so on macOS
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/51429
updated_at: 2018-12-03 07:37:55
body:
  GIO needs modules to be named .so. This patch does that for us. Should
  be included in the next release.

  Fixes #41071


state: closed
title: pythonPackages.testfixtures: 6.2.0 -> 6.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/51430
updated_at: 2018-12-03 14:35:24
body:
  ###### Motivation for this change
  fixed build

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jpeginfo: init at 1.6.1
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/51431
updated_at: 2018-12-03 16:05:44
body:
  ###### Motivation for this change
  jpeginfo prints information and tests integrity of JPEG/JFIF files.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mtools: 4.0.21 -> 4.0.22
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/51432
updated_at: 2018-12-08 11:47:50
body:
  https://lists.gnu.org/archive/html/info-gnu/2018-12/msg00000.html


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: radare2: 3.1.0 -> 3.1.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/51433
updated_at: 2018-12-03 07:59:09
body:
  ###### Motivation for this change

  https://github.com/radare/radare2/releases/tag/3.1.1


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix-review: 0.6.1 -> 1.0.1
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51434
updated_at: 2018-12-03 12:09:26
body:
  - use nix build instead of nix-build
  - writes per-build log in the current working directory
  - symlinks the builds in the current working directory
  - detects & deduplicates build aliases
  - markdown reports
  - filter builds by regex
  - generate nix expression files that can be build by the user
  - fix large rebuilds where package names where to large to be passed directly to nix-shell

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using ~`nix-shell -p nox --run "nox-review wip"`~ `nix-review pr 51434`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.gateone: needs tornado_4
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/51435
updated_at: 2018-12-06 04:50:28
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qlcplus: fix udev rules path
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/51437
updated_at: 2018-12-04 17:02:51
body:
  ###### Motivation for this change

  The udev rules are stored at the wrong place in the package, see https://discourse.nixos.org/t/qlcplus-udev-rules/1572/2 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: thunar: 1.7.10 -> 1.8.2
user_login: M-Gregoire
html_url: https://github.com/NixOS/nixpkgs/pull/51438
updated_at: 2018-12-03 17:23:12
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: iwd: 0.11 -> 0.12
user_login: jfrankenau
html_url: https://github.com/NixOS/nixpkgs/pull/51439
updated_at: 2018-12-04 09:21:00
body:
  ###### Motivation for this change

  Update and build with ethernet support.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @Mic92 


state: closed
title: Vulnerability roundup 54: accountsservice-0.6.49: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51441
updated_at: 2019-02-25 17:59:12
body:
  [search](https://search.nix.gsc.io/?q=accountsservice&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=accountsservice+in%3Apath&type=Code)

  * [x] [CVE-2018-14036](https://nvd.nist.gov/vuln/detail/CVE-2018-14036) (nixos-unstable)

  Scanned versions: nixos-unstable: 41cdec2e513; nixos-18.03: 2f06e04b74e. May contain false positives.


state: closed
title: Vulnerability roundup 54: epiphany-3.28.2.1: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51442
updated_at: 2019-02-25 17:59:12
body:
  [search](https://search.nix.gsc.io/?q=epiphany&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=epiphany+in%3Apath&type=Code)

  * [x] [CVE-2018-11396](https://nvd.nist.gov/vuln/detail/CVE-2018-11396) (nixos-unstable)
  * [x] [CVE-2018-12016](https://nvd.nist.gov/vuln/detail/CVE-2018-12016) (nixos-unstable)

  Scanned versions: nixos-unstable: 41cdec2e513; nixos-18.03: 2f06e04b74e. May contain false positives.


state: closed
title: Vulnerability roundup 54: exiv2-0.26: 7 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51443
updated_at: 2019-02-25 17:59:12
body:
  [search](https://search.nix.gsc.io/?q=exiv2&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=exiv2+in%3Apath&type=Code)

  * [ ] [CVE-2017-17723](https://nvd.nist.gov/vuln/detail/CVE-2017-17723) (nixos-unstable)
  * [ ] [CVE-2018-14046](https://nvd.nist.gov/vuln/detail/CVE-2018-14046) (nixos-unstable)
  * [ ] [CVE-2018-14338](https://nvd.nist.gov/vuln/detail/CVE-2018-14338) (nixos-unstable)
  * [ ] [CVE-2018-16336](https://nvd.nist.gov/vuln/detail/CVE-2018-16336) (nixos-unstable)
  * [ ] [CVE-2018-17229](https://nvd.nist.gov/vuln/detail/CVE-2018-17229) (nixos-unstable)
  * [ ] [CVE-2018-17230](https://nvd.nist.gov/vuln/detail/CVE-2018-17230) (nixos-unstable)
  * [ ] [CVE-2018-17282](https://nvd.nist.gov/vuln/detail/CVE-2018-17282) (nixos-unstable)

  Scanned versions: nixos-unstable: 41cdec2e513. May contain false positives.


state: closed
title: kube-router: init at 0.2.3
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/51445
updated_at: 2018-12-06 16:31:42
body:
  ###### Motivation for this change
  Kube-router is a good alternative to flannel and weavenet as a self-contained kubernetes software defined network solution. It's written in Golang and utilizes iptables, ipvs and ip utilities directly.
  Learn more at: https://github.com/cloudnativelabs/kube-router and https://www.kube-router.io/

  As pre-agreed, I've added @colemickens as co-maintainer on this package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/51446
updated_at: 2018-12-03 18:45:03
body:
  ###### Motivation for this change
  Update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libpng: 1.6.35 -> 1.6.36, license v2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/51447
updated_at: 2019-02-19 10:05:56
body:
  ###### Motivation for this change

  https://sourceforge.net/p/png-mng/mailman/message/36483059/


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: CLASSPATH warning in leiningen
user_login: winks
html_url: https://github.com/NixOS/nixpkgs/issues/51448
updated_at: 2018-12-04 02:03:09
body:
  ## Issue description
  Problem: CLASSPATH warning when using `lein repl` in nix-shell

  This is not advisable for leiningen usage, as can be seen from the warning :)

  I'm not a nix expert, but we discussed this on #leiningen /freenode, here's a small chat log:
  ```
  >> Nix operates with things in unconventional places (which allows it to do all that it does). In this case, my CLASSPATH gets set to: /nix/store/rs5d0hp4idpkhs0gcvl0s3imy3s5pzmm-leiningen-2.8.1/share/java/leiningen-2.8.1-standalone.jar
  > the lein warning is correct
  > if you export CLASSPATH that'll infect all your lein invocations
  > rather than finding lein that way, I suggest you patch the lein location in the bin/lein script instead
  > (not to mention other things that care about exported CLASSPATHs)
  > https://salsa.debian.org/clojure-team/leiningen-clojure/blob/master/debian/patches/0003-Update-LEIN_JAR-location-to-match-installed-jar.patch
  > I think what you probably want is to template that value out and set it at install time
  ```

  As far as I can see the relevant file is
  https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/build-managers/leiningen/default.nix but if I got this right this won't actually help here as CLASSPATH is not set by the wrapper script, but by nix-shell or the jdk package? So not sure how to proceed here, except maybe `unset CLASSPATH` in that wrapper script? 

  Tagging @bendlas for having touched the lein nix expression last, sorry :)

  ### Steps to reproduce
  ```
  $ cat test.nix
  { pkgs ? import <nixpkgs> {} }:

  pkgs.stdenv.mkDerivation
  {
    name = "asdf";
    buildInputs = with pkgs;
    [
      # Clojure
      jdk8
      leiningen
    ];
  }
  $ nix-shell test.nix
  ##############
  [nix-shell:~/tmp]$ lein version
  WARNING: You have $CLASSPATH set, probably by accident.
  It is strongly recommended to unset this before proceeding.
  Leiningen 2.8.1 on Java 1.8.0_192 OpenJDK 64-Bit Server VM
  ```
  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.00 MiB download, 0.00 MiB unpacked):
    /nix/store/wsqynhnll3nybp9wn02j66qd5x9xvxsx-nix-info
  copying path '/nix/store/wsqynhnll3nybp9wn02j66qd5x9xvxsx-nix-info' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.15.0-39-generic, Ubuntu, 18.04.1 LTS (Bionic Beaver)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.1.3`
   - channels(florian): `"nixpkgs-19.03pre160658.1bf18e4c852"`
   - nixpkgs: `/home/florian/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: kde-applications: 18.08.1 -> 18.12.0
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/51449
updated_at: 2018-12-16 12:56:25
body:
  ###### Motivation for this change

  This is a preparation of the new kde applications release. Currently this uses the beta release, I will update to the stable on the final release :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [staging-18.09] perl: 5.28.0 -> 5.28.1, 5.26.2 -> 5.26.3
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/51451
updated_at: 2018-12-09 13:30:21
body:
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/51450 to 18.09


state: closed
title: dmrconfig: 2018-11-07 -> 1.0
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/51452
updated_at: 2018-12-03 21:18:22
body:
  ###### Motivation for this change
  Upstream have made a new release that builds, so switched to release versions instead of random commits.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hunspell: unbreak mythes build, due transient dependencies
user_login: avnik
html_url: https://github.com/NixOS/nixpkgs/pull/51454
updated_at: 2018-12-04 00:02:58
body:
  ###### Motivation for this change

  Linking of this was broken
  `/nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/ld: cannot find -ltinfo`

  (and as mythes is transient dependency of libreoffice, LO was broken as well)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghc: don’t add libiconv automatically
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/51455
updated_at: 2019-02-22 04:15:24
body:
  ghc needs it to fail to correctly detect it for later. GHC uses autoconf to detect whether "-liconv" is needed. The test tries a test program that needs libiconv to work. If the test fails, libiconv is added to all LDFLAGS that GHC compiles. We want this to happen so that GHC works outside of Nix's cc-wrapper! So, this PR adds ```dontAddExtraLibs``` that tells cc-wrapper to not add extra libraries. I've added a short description in the docs explaining the situation as well.

  Fixes #46814.


state: closed
title: coqPackages.simple-io: init at 0.2
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/51456
updated_at: 2018-12-10 15:35:40
body:
  Purely functional IO for Coq.

  homepage: https://github.com/Lysxia/coq-simple-io

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia_legacy_340: Remove unneeded/failing patch
user_login: binarin
html_url: https://github.com/NixOS/nixpkgs/pull/51457
updated_at: 2019-04-17 02:00:54
body:
  ###### Motivation for this change

  Packages wasn't building as the patch was not applying and it's no longer needed after upgrade in 045575e744cd581a20929c63590d9b555099c22d. Now the same result is achieved by the following lines in the driver package itself:

      #if defined(NV_DRM_LEGACY_PCI_INIT_PRESENT)
      #define nv_drm_pci_init drm_legacy_pci_init
      #define nv_drm_pci_exit drm_legacy_pci_exit
      #else
      #define nv_drm_pci_init drm_pci_init
      #define nv_drm_pci_exit drm_pci_exit
      #endif


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Vulnerability roundup 54: elfutils: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51458
updated_at: 2018-12-04 08:34:06
body:
  [search](https://search.nix.gsc.io/?q=elfutils&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=elfutils+in%3Apath&type=Code)

  * [x] [CVE-2018-18310](https://nvd.nist.gov/vuln/detail/CVE-2018-18310) (nixos-unstable)

  Scanned versions: nixos-unstable: 3a393eecafb. May contain false positives.


state: closed
title: Vulnerability roundup 54: net-snmp-5.7.3: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51459
updated_at: 2019-03-09 07:02:01
body:
  [search](https://search.nix.gsc.io/?q=net-snmp&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=net-snmp+in%3Apath&type=Code)

  * [x] [CVE-2018-18066](https://nvd.nist.gov/vuln/detail/CVE-2018-18066) (nixos-unstable, nixos-18.09)

  Scanned versions: nixos-unstable: 3a393eecafb; nixos-18.09: db561c90ef3. May contain false positives.


state: open
title: Vulnerability roundup 54: openexr: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51460
updated_at: 2018-12-03 23:33:32
body:
  [search](https://search.nix.gsc.io/?q=openexr&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=openexr+in%3Apath&type=Code)

  * [ ] [CVE-2018-18443](https://nvd.nist.gov/vuln/detail/CVE-2018-18443) (nixos-unstable, nixos-18.09)
  * [ ] [CVE-2018-18444](https://nvd.nist.gov/vuln/detail/CVE-2018-18444) (nixos-unstable, nixos-18.09)

  Scanned versions: nixos-unstable: 3a393eecafb; nixos-18.09: db561c90ef3. May contain false positives.


state: closed
title: Vulnerability roundup 54: strongswan-5.6.3: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51461
updated_at: 2018-12-04 08:33:41
body:
  [search](https://search.nix.gsc.io/?q=strongswan&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=strongswan+in%3Apath&type=Code)

  * [x] [CVE-2018-17540](https://nvd.nist.gov/vuln/detail/CVE-2018-17540) (nixos-18.09)

  Scanned versions: nixos-18.09: db561c90ef3. May contain false positives.


state: closed
title: Vulnerability roundup 54: udisks-2.8.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/51462
updated_at: 2018-12-04 01:15:38
body:
  [search](https://search.nix.gsc.io/?q=udisks&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=udisks+in%3Apath&type=Code)

  * [x] [CVE-2018-17336](https://nvd.nist.gov/vuln/detail/CVE-2018-17336) (nixos-18.09)

  Scanned versions: nixos-18.09: db561c90ef3. May contain false positives.


state: closed
title: Kafka: 2.0.0 -> 2.0.1, Add 2.1
user_login: NeQuissimus
html_url: https://github.com/NixOS/nixpkgs/pull/51463
updated_at: 2018-12-05 00:06:14
body:
  ###### Motivation for this change
  Updates

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add disable core optimizations
user_login: dmjio
html_url: https://github.com/NixOS/nixpkgs/pull/51464
updated_at: 2018-12-03 18:49:44
body:
  Adds a utility function for disabling GHC core optimizations.
  Significantly increases build times.

  ###### Motivation for this change
  This change is common enough it warrants its own function
  This change will allow new Haskell / Nix users to speed up builds.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37 has a runtime dependency on openssl-dev
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/issues/51465
updated_at: 2018-12-26 09:38:55
body:
  ## Issue description
  ```
  $ nix-store -qR $(nix-build -A python3) | grep dev
  /nix/store/45ji26zar3sf62b0ahvly0y8a1szad8r-openssl-1.0.2p-dev
  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: nixos-unstable channel has not updated for 2+ weeks
user_login: peti
html_url: https://github.com/NixOS/nixpkgs/issues/51466
updated_at: 2018-12-03 20:42:58
body:
  The nixos-unstable channel has not updated since 2018-11-17 (80738ed9dc0ce48d7796baed5364eef8072c794d). https://hydra.nixos.org/job/nixos/trunk-combined/tested#tabs-constituents suggests that only a few tests are failing, but clearly those tests will need some attention to succeed again?


state: closed
title: Dropbox fails to start since update 62.4.103
user_login: lucasimi
html_url: https://github.com/NixOS/nixpkgs/issues/51468
updated_at: 2018-12-18 08:07:31
body:
  Dropbox fails to start on NixOS after update 63.4.103. After running `dropbox start` I got an error message suggesting a permission problem. However checking the error log the line which seemed to be relevant was the following one: `ImportError: libglapi.so.0: cannot open shared object file: No such file or directory`.

  I fixed this problem by setting the correct LD_LIBRARY_PATH variable pointing to one of my system's `libglapi.so.0` inside `~/.dropbox-dist/dropbox-lnx.x86_64-62.4.103/dropboxd/`. By running again `dropbox start` I got a similar error complaining about a missing `libxshmfence.so.1`. Using the same trick I managed to solve the issue and now Dropbox starts correctly (I don't know is this is the right way to fix it, but I suspect that upcoming releases will overwrite dropboxd).


state: closed
title: polar-bookshelf: 1.0.13 -> 1.1.0
user_login: noneucat
html_url: https://github.com/NixOS/nixpkgs/pull/51471
updated_at: 2018-12-03 21:42:07
body:
  ###### Motivation for this change
  ```
  # 1.0.14

  - Upgrade to latest semver and firebase-tools 

  - Fixed bug where the lightbox was kept enabled after we deleted an annotation

  - We can now capture a new class of documents that use a vertical height on 
    their CSS selectors. 

  - We can now capture XML documents which used XSL stylesheets.

  - Major refactor of the disk datastore for the pending cloud sync functionality
    we're working on.

  # 1.1.0

  Polar 1.1 is fresh out the door and a lot of amazing features and bug fixes are enabled in this release.

  The biggest feature by far is our support for the 'Save to Polar' chrome extension that allows you to send the URL of your active tab to Polar for content capture.

  This makes it a lot easier to work with Polar as you can just click a button in Chrome and have it sent to Polar.

  We plan on adding support for Safari, and Firefox in the future but we're taking things one step at a time.

  Other features in 1.1 include:
  - Disabling amp for now until we have a better solution on how to show the user that an AMP page is displayed and how to disable / enable it. Otherwise its confusing and often the amp page is WORSE not better.
  - Fixed bugs with the browser size not changing during capture browser changing and also fixed some issues with it not properly accepting the browser change in some situations.
  - Fixed bug in HTML zoom where the page would be truncated improperly.
  - Blocked amp ads during the capture but they aren't blocked during the preview at the moment.
  - "Fixed" nasty anti-aliasing bug in electron by blocking amp ads. They were annoying anyway but for some reason they were breaking chrome rendering - probably due to some web component nonsense.
  - Implemented a new strategy with the vertical height algorithm in the capture system to revert it back to auto instead of a fixed max-height. Works a lot better now.
  - Date/times no longer include ' ago' to be a bit more concise.
  - Added small FAQ entry to enable Anki sync.
  - Fixed a bug where we could select text and not properly work with elements.
  - Renderer analytics didn't understand that a callback without an error wasn't a failure.
  - Upgraded a number of important react packages: react react-dom react-moment react-select @types/react-table @types/react-select @types/react @types/prop-types @types/node-fetch
  - removed inversify package (were not using it)
  - latest fontawesome
  - latest node-fetch
  - fixed issue with electron-builder where it was forcing us to upgrade to the latest version for each release.
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: renderdoc: 1.1 -> 1.2
user_login: Ralith
html_url: https://github.com/NixOS/nixpkgs/pull/51472
updated_at: 2018-12-12 17:28:54
body:
  ###### Motivation for this change
  Routine update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: applications.audio.luppp: new package (at version 1.2.0)
user_login: prusnak
html_url: https://github.com/NixOS/nixpkgs/pull/51473
updated_at: 2018-12-06 18:50:07
body:
  ###### Motivation for this change

  This packages an interesting audio application called Luppp

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kdeconnect: init module
user_login: eliasp
html_url: https://github.com/NixOS/nixpkgs/pull/51474
updated_at: 2019-03-06 21:11:52
body:
  ###### Motivation for this change

  I struggled to get KDE Connect working on NixOS until I found out I manually need to open a few ports by adding this to my `configuration.nix`:

  ```
  networking.firewall.allowedTCPPortRanges = [ { from = 1714; to = 1764; } ];
  networking.firewall.allowedUDPPortRanges = [ { from = 1714; to = 1764; } ];
  ```

  I wanted to make this a little more discoverable/accessible by providing a global option to enable KDE Connect.

  ###### Things done

  - Tested it by:
    - including `nixos/modules/programs/kdeconnect.nix` in my `configuration.nix`
    - disabling my previous lines to make KDE Connect work (see above)
    - setting `programs.kdeconnect.enable = true;`
    - rebuilding my environment
    - testing KDE Connect's functionality (e.g. test-pinging my smartphone from my desktop and vice versa).

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mediawiki: 1.29.1 -> 1.31.1
user_login: redvers
html_url: https://github.com/NixOS/nixpkgs/pull/51475
updated_at: 2018-12-04 07:06:58
body:
  ###### Motivation for this change
  MediaWiki 1.29 is an obsolete release of MediaWiki. The final security and maintenance release was released on 20 September 2018"
  MediaWiki 1.31 is the latest release of MediaWiki

  Sources:

  https://www.mediawiki.org/wiki/MediaWiki_1.29
  https://www.mediawiki.org/wiki/MediaWiki_1.31

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Steam won't install - cannot download libacl1.deb from any mirror
user_login: tejing1
html_url: https://github.com/NixOS/nixpkgs/issues/51476
updated_at: 2018-12-13 20:27:21
body:
  ## Issue description

  I'm trying to move to the 18.09 channel, and I'm finding that I can't install. The output ends with:

  ```
  error: cannot download libacl1.deb from any mirror
  builder for ‘/nix/store/7xycciij6r8ri5sb55i8msq1a9mcn5fv-libacl1.deb.drv’ failed with exit code 1
  building path(s) ‘/nix/store/nz6s87npcf6l7yndnmkkkrjakp6rwvsf-libacl1.deb’
  cannot build derivation ‘/nix/store/ml9gdq2s4lk855wmfsanyd7h34frrav1-steam-runtime.json.drv’: 1 dependencies couldn't be built
  cannot build derivation ‘/nix/store/dlh5sd2l1d48ly0g52p65j8p2cx40lyc-steam-runtime-2016-08-13.drv’: 1 dependencies couldn't be built
  cannot build derivation ‘/nix/store/p61s38r9n9m8ncyz82a14abn9c7c6d5k-steam-runtime-wrapped.drv’: 1 dependencies couldn't be built
  killing process 5764
  building path(s) ‘/nix/store/si6rc9vkmi9smclkfp32qc13g0j50gd5-libappindicator1.deb’
  cannot build derivation ‘/nix/store/1kpk36d1g70kg3583mh4d9yqw2mvppx2-steam-usr-multi.drv’: 1 dependencies couldn't be built
  killing process 5763
  building path(s) ‘/nix/store/mi58snzic3v8as0vinvs9fd44hsgz5h2-steam-wrapper.sh’
  building path(s) ‘/nix/store/rh3r33apc5ggnl0dlf0z5zazhkmydbs6-steam_1.0.0.51.tar.gz’
  building path(s) ‘/nix/store/pbxnxg59q22kxqpxwcbgqiz8gn3nhg9d-lidEvent.sh’
  cannot build derivation ‘/nix/store/nx2chzl1a1yx62nhylgrdgj3kzvbi7pj-steam-fhs.drv’: 1 dependencies couldn't be built
  building path(s) ‘/nix/store/2asccccya8sqlwg7hj7aip328wlc27sr-unit-script-container_-post-start’
  cannot build derivation ‘/nix/store/dy869jgrrzvr7yq85if9b6bik4rbf0fg-steam-init.drv’: 1 dependencies couldn't be built
  building path(s) ‘/nix/store/3imzahm7xaany8xmnrvnd003qpd81jl2-mdadm.conf’
  cannot build derivation ‘/nix/store/sfq496h58qbi0ichyzlagrzz89vkgy16-steam.drv’: 1 dependencies couldn't be built
  killing process 5767
  killing process 5765
  building path(s) ‘/nix/store/v3849iwqmlijidamvaa7y5pdyvkmqx7p-unit-script-container_-pre-start’
  building path(s) ‘/nix/store/gp1w98w8djb4c0xmb453r184sb46yn35-unit-script-container_-pre-stop’
  building path(s) ‘/nix/store/bnxl0fzakzblann7a3liisgf0193qx92-unit-script-container_-start’
  cannot build derivation ‘/nix/store/a380pv1wx5zl860ymnfh62jz6sy5l503-system-path.drv’: 1 dependencies couldn't be built
  killing process 5766
  killing process 2750
  killing process 2749
  killing process 5762
  cannot build derivation ‘/nix/store/x3sby9m29s0awh8k8xdp3llnr8ql0rf9-nixos-system-tejingdesk-18.09.1446.db561c90ef3.drv’: 1 dependencies couldn't be built
  error: build of ‘/nix/store/x3sby9m29s0awh8k8xdp3llnr8ql0rf9-nixos-system-tejingdesk-18.09.1446.db561c90ef3.drv’ failed
  ```

  ### Steps to reproduce

  It seems fairly clear this issue would arise for anyone installing steam on 18.09 without the relevant file already cached.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.86, NixOS, 17.09.3269.14f9ee66e63 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.09.1446.db561c90ef3"`
   - channels(tejing): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs


state: closed
title: sublime3-dev: 3176 → 3183
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/51477
updated_at: 2019-01-07 15:31:36
body:
  ###### Motivation for this change
  Sublime finally switched to GTK 3!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @wmertens @demin-dmitriy @zimbatm


state: closed
title: libffi: swap src URL from FTP to HTTPS
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/51478
updated_at: 2019-02-27 23:05:14
body:
  HTTPS is never worse and often better than FTP, since it's faster, more secure,
  and more likely to be accessible through firewalls.

  This does not change the tarball sha, as confirmed by `nix-prefetch-url`.


state: closed
title: [18.09] udisks: 2.8.0 -> 2.8.1
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/51479
updated_at: 2018-12-03 23:15:12
body:
  https://github.com/storaged-project/udisks/blob/udisks-2.8.1/NEWS
  (cherry picked from commit 9a74fd0b0fdb7243f5f5db944dd326a374cf493a)

  ###### Motivation for this change

  Backport of #47422
  Closes #51462 ( CVE-2018-17336 )

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fetchurl: fix and add extra KDE mirrors
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/51480
updated_at: 2018-12-08 14:39:06
body:
  - The gwdg.de mirror has moved the relative path of its KDE tarballs
  - Add new mirrors from Berkeley and MIT, which are on the list of officially supported mirrors

  https://download.kde.org/extra/download-mirrors.html

  ###### Motivation for this change
  I had some issues downloading KDE source tarballs with the existing mirrors; at least 1 of them is broken, and fixed here.  The newly added ones work.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: radare: remove
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51481
updated_at: 2018-12-03 23:38:39
body:
  This project has been deprecated in 2016.
  Radare2 should been used instead: https://github.com/radare/radare

  cc @viric 

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.12.2 -> 1.12.3
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/51482
updated_at: 2018-12-04 18:17:13
body:
  ###### Motivation for this change
  This release contains various bugfixes and changes for the 1.12.X major of Kubernetes. Most importantly though, a fix for **CVE-2018-1002105**.

  See also: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.12.md#changelog-since-v1122

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Whisper failing with mock missing error
user_login: polynomial
html_url: https://github.com/NixOS/nixpkgs/issues/51484
updated_at: 2018-12-04 00:02:36
body:
  ## Issue description

  We use graphite and the whisper storage system it depends on was upgraded in Nixpkgs from 1.1.3 to 1.1.4 which added a dependency on mock. This appears to have not been added so our builds fail with:

  ```
  running build_ext
  test_whisper (unittest.loader.ModuleImportFailure) ... ERROR

  ======================================================================
  ERROR: test_whisper (unittest.loader.ModuleImportFailure)
  ----------------------------------------------------------------------
  ImportError: Failed to import test module: test_whisper
  Traceback (most recent call last):
    File "/nix/store/irrwwhym6v41phf2707jb8nccf6jzai3-python-2.7.15/lib/python2.7/unittest/loader.py", line 254, in _find_tests
      module = self._get_module_from_name(name)
    File "/nix/store/irrwwhym6v41phf2707jb8nccf6jzai3-python-2.7.15/lib/python2.7/unittest/loader.py", line 232, in _get_module_from_name
      __import__(name)
    File "/tmp/nix-build-python2.7-whisper-1.1.4.drv-0/whisper-1.1.4/test_whisper.py", line 17, in <module>
      from mock import patch, mock_open
  ImportError: No module named mock
  ```


  ### Steps to reproduce

  Try and use the Graphite service with the whisper backend(default).


  ## Technical details

  This was tested on: nixpkgs @ 7ae2ba173f3938170778d1a913e415e2ff78c9e6


state: closed
title: Add mock to the list of whisper's test inputs.
user_login: polynomial
html_url: https://github.com/NixOS/nixpkgs/pull/51485
updated_at: 2018-12-03 23:47:23
body:
  This was required as the versiof whisper was upgraded from
  1.1.3 to 1.1.4 and mock was added as a test dependency in
  that release:
  https://github.com/graphite-project/whisper/commit/703dd9d3a60a0f79383c03a541ee66bd50966a01#diff-62849af500c571aa4532da7be8833e73R14

  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/issues/51484

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.11.4 -> 1.11.5
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/51486
updated_at: 2018-12-05 04:20:08
body:
  ###### Motivation for this change
  This release contains various bugfixes and changes for the 1.11.X major of Kubernetes. Most importantly though, a fix for **CVE-2018-1002105**.

  See also: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.11.md#changelog-since-v1114

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ddclient: 3.8.3 -> 3.9.0
user_login: uvNikita
html_url: https://github.com/NixOS/nixpkgs/pull/51487
updated_at: 2019-02-21 09:14:39
body:
  ###### Motivation for this change
  This release fixes cloudflare protocol usage by switching to a new api
  version. See release notes: https://sourceforge.net/p/ddclient/news/2018/08/ddclient-390-released.
  Partially fixes #26691.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cowsay: fix cross
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/51488
updated_at: 2018-12-03 23:44:17
body:
  The install.sh script looks for all perls in $PATH, tries to execute
  these to test whether that perl is "good", if it is, takes it and
  puts it into the shebang.

  This obviously can't work for cross. As installation seems to be pretty
  trivial, do it in a custom install phase.

  ###### Motivation for this change
  I wanted to cross-compile `cowsay`, who wouldn't want to do that?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mythes: Remove spurious dependency on ncurses
user_login: neilmayhew
html_url: https://github.com/NixOS/nixpkgs/pull/51489
updated_at: 2019-01-03 15:24:49
body:
  ###### Motivation for this change

  A dependency on `ncurses` was added to fix a build failure, but `ncurses` is needed only for a test program which should be in `check_PROGRAMS` instead of `noinst_PROGRAMS`. This change adds a patch for this. I'll submit the patch upstream so it doesn't become a maintenance burden.

  The bug is reported as #51297.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zoom-us: 2.4.129780.0915 -> 2.5.146186.1130
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/51490
updated_at: 2018-12-04 09:25:31
body:
  fixes [CVE-2018-15715](https://nvd.nist.gov/vuln/detail/CVE-2018-15715)

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] zoom-us: 2.4.129780.0915 -> 2.5.146186.1130 (CVE-2018-15715)
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/51491
updated_at: 2018-12-04 09:25:34
body:
  fixes [CVE-2018-15715](https://nvd.nist.gov/vuln/detail/CVE-2018-15715)

  (cherry picked from commit c4177f4e5ba5e1b29c3b51ff02697dc1437cfb91)
  Backport of #51490

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: materia-theme: 20181115 -> 20181125
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/51492
updated_at: 2018-12-04 14:07:07
body:
  ###### Motivation for this change

  Update to version [20181125](https://github.com/nana-4/materia-theme/releases/tag/v20181125)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: docs: Remove nix-repl references
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/51493
updated_at: 2018-12-04 11:13:04
body:
  ###### Motivation for this change

  nix-repl has been deprecated

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nordic-polar: init at 1.3.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/51494
updated_at: 2018-12-04 14:28:20
body:
  ###### Motivation for this change

  Add [nordic-polar](https://github.com/EliverLara/Nordic-Polar), a Gtk3.20+ theme created using the awesome [Nord](https://github.com/arcticicestudio/nord) color palette.

  ![nordic](https://user-images.githubusercontent.com/1217934/49415706-41eb7c00-f756-11e8-9160-d491b38b9c13.png)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Use Interactive bash for GCE
user_login: dingxiangfei2009
html_url: https://github.com/NixOS/nixpkgs/pull/51495
updated_at: 2018-12-05 09:58:44
body:
  ###### Motivation for this change

  Fix #40428. This allows accounts created by GCE to use an interactive Bash instead.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nsjail refers to missing binaries
user_login: andrewchambers
html_url: https://github.com/NixOS/nixpkgs/issues/51496
updated_at: 2018-12-05 00:03:07
body:
  ## Issue description

  nsjail tries to execute /usr/bin/newgidmap and /usr/bin/newuidmap 

  ### Steps to reproduce

  run nsjail with the -U or -G command. 
  From the source code:

  ```
  user.cc:        std::vector<std::string> argv = {"/usr/bin/newgidmap", std::to_string(pid)};
  user.cc:        std::vector<std::string> argv = {"/usr/bin/newuidmap", std::to_string(pid)};
  ```


state: closed
title: nix-{zsh,bash}-completions version bump
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/51497
updated_at: 2018-12-04 10:18:26
body:
  ###### Motivation for this change

  Adds `nixos-option` completion thanks to @Ma27. Also adds full completion to `nix-prefetch-url` so it's now easy to do `nix-prefetch-url -A nam<tab>`, in addition to a few bug fixes.

  bash changelog: https://github.com/hedning/nix-bash-completions/releases/tag/v0.6.7
  zsh changelog: https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.2


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Noto Fonts need to be updated
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/issues/51498
updated_at: 2018-12-06 15:29:32
body:
  ## Issue description

  There's a bug apparently fixed in newer versions of Noto that I'd like to benefit from: https://github.com/googlei18n/noto-fonts/issues/1021

  However, it looks like Google might not be doing releases on GitHub any longer for Noto. I think the nix expression for it needs to be reworked and updated.


state: closed
title: plex-media-player: 2.14.1 -> 2.23.0
user_login: kylewlacy
html_url: https://github.com/NixOS/nixpkgs/pull/51499
updated_at: 2018-12-04 17:33:04
body:
  ###### Motivation for this change

  Updates Plex Media Player to version 2.23.0.920-5bc1a2e5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: noto-fonts: update 2017-10-24 -> 2018-11-30
user_login: colemickens
html_url: https://github.com/NixOS/nixpkgs/pull/51500
updated_at: 2019-03-30 19:30:52
body:
  ###### Motivation for this change

  Update the Noto fonts, particularly to avoid an old ligature issue. Fixes: #51498.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.pygraphviz: add graphviz path
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/51501
updated_at: 2018-12-04 11:08:30
body:
  ###### Motivation for this change

  I noticed that `pygraphviz` is not really working unless I explicitly add `graphviz` to my environment. To fix that, I patch `pygraphviz` to always add `graphviz` to its path.

  Also it depended on `python.pkgs.graphviz` instead of the C package `graphviz`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] python.pkgs.pygraphviz: add graphviz path
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/51502
updated_at: 2018-12-04 11:32:17
body:
  ###### Motivation for this change

  Backport of #51501, since it fixes a bug.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: anki has test failures
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/issues/51503
updated_at: 2018-12-04 14:27:55
body:
  ## Issue description

  I get the following with the latest `nixos-unstable` channel:

  ```
  ../anki-2.1.6-beta1/tests/test_find.py:116: AssertionError
  ________________________________ test_findDupes ________________________________

      def test_findDupes():
          deck = getEmptyCol()
          f = deck.newNote()
          f['Front'] = 'foo'
          f['Back'] = 'bar'
          deck.addNote(f)
          f2 = deck.newNote()
          f2['Front'] = 'baz'
          f2['Back'] = 'bar'
          deck.addNote(f2)
          f3 = deck.newNote()
          f3['Front'] = 'quux'
          f3['Back'] = 'bar'
          deck.addNote(f3)
          f4 = deck.newNote()
          f4['Front'] = 'quuux'
          f4['Back'] = 'nope'
          deck.addNote(f4)
          r = deck.findDupes("Back")
  >       assert r[0][0] == "bar"
  E       IndexError: list index out of range
  ```

  More tests are failing.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.2, NixOS, 19.03pre159472.80738ed9dc0 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(philipp): `""`
   - channels(root): `"nixos-19.03pre161545.7c73f53d836"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: doc: reminder to upgrade linux-libre with linux
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/51504
updated_at: 2018-12-05 13:43:28
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/51403#issuecomment-444061264

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @Mic92


state: closed
title: valgrind: run autoconf to pick up Makefile.am patch
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/51505
updated_at: 2018-12-05 10:07:41
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/51107 added a patch to Makefile.am to fix
  a race condition in the build. It was unfortunately never picked up as we were
  using the generated makefile from the tarball.

  cc #51444 and @srhb 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Remove old Julia versions
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/issues/51506
updated_at: 2019-03-06 08:36:20
body:
  ## Issue description
  Right now we have three different versions of julia (0.6.4, 0.7.0, 1.0.1) in nixpkgs-unstable. However, the latest arpack update broke julia-0.6.4. Are all those versions of julia required or is it possible to remove old version?

  CC @7c6f434c, @rbvermaa, @garrison
  ### Steps to reproduce
  This is the build that broke julia-0.6
  https://hydra.nixos.org/build/82144097


state: closed
title: spotify: 1.0.93.242.gc2341a27-15 -> 1.0.94.262.g3d5c231c-9
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/51507
updated_at: 2018-12-04 13:23:45
body:
  ###### Motivation for this change

  Latest stable spotify version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Steam runtime refactor backport
user_login: Synthetica9
html_url: https://github.com/NixOS/nixpkgs/pull/51508
updated_at: 2018-12-04 18:38:52
body:
  ###### Motivation for this change

  Backport of #49420 

  Closes #51476 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update to gmsh 4.0.6
user_login: luzpaz
html_url: https://github.com/NixOS/nixpkgs/issues/51509
updated_at: 2019-03-08 10:22:02
body:
  https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/math/gmsh/default.nix

  http://gmsh.info/src/gmsh-4.0.6-source.tgz


state: closed
title: Make __DATE__/__TIME__ deterministic when NIX_ENFORCE_PURITY=1
user_login: rht
html_url: https://github.com/NixOS/nixpkgs/pull/51510
updated_at: 2018-12-05 11:19:46
body:
  Extracted from https://github.com/NixOS/nixpkgs/pull/2281/commits/3dba999c62011e64222e593f835f63ebd3f0f47e.

  See #2281. This is the gcc stuff in the list made by @Ekleog in https://github.com/NixOS/nixpkgs/pull/2281#issuecomment-424810028, excluding the PGO commit.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] backport nix-{zsh,bash}-completions
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/51511
updated_at: 2018-12-05 04:22:13
body:
  ###### Motivation for this change

  Fixes a bunch of small issues, and adds completion to `nixos-option` and full completion for `nix-prefetch-url`.


state: closed
title: python37Packages.svgwrite doesn't build on unstable
user_login: bbigras
html_url: https://github.com/NixOS/nixpkgs/issues/51512
updated_at: 2018-12-05 11:44:45
body:
  ## Issue description

  The tests fail and it's preventing me from installing termtosvg.

  ```
  ======================================================================
  ERROR: test_filterRes (tests.test_filters.TestFilter)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 23, in test_filterRes
      f = filters.Filter(resolution=300, profile='full', debug=True)
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 257, in __init__
      self['filterRes'] = str(resolution)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '300' is not a valid value for attribute 'filterRes' at svg-element <filter>.

  ======================================================================
  ERROR: test_order (tests.test_filters.Test_feConvolveMatrix)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 130, in test_order
      pf = f.feConvolveMatrix('input1', order='1 2')
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 223, in __call__
      obj = self.cls(*args, **kwargs) # create an object of type 'cls'
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 72, in __init__
      super(_FilterRequireInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 61, in __init__
      super(_FilterNoInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 69, in __init__
      self.update(extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 85, in update
      self.__setitem__(key, value)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '1 2' is not a valid value for attribute 'order' at svg-element <feConvolveMatrix>.

  ======================================================================
  ERROR: test_stdDeviation (tests.test_filters.Test_feGaussianBlur)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 239, in test_stdDeviation
      self.assertEqual(f.feGaussianBlur("input1", stdDeviation="1 2").tostring(),
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 223, in __call__
      obj = self.cls(*args, **kwargs) # create an object of type 'cls'
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 72, in __init__
      super(_FilterRequireInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 61, in __init__
      super(_FilterNoInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 69, in __init__
      self.update(extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 85, in update
      self.__setitem__(key, value)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '1 2' is not a valid value for attribute 'stdDeviation' at svg-element <feGaussianBlur>.

  ======================================================================
  ERROR: test_radius (tests.test_filters.Test_feMorphology)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 280, in test_radius
      self.assertEqual(f.feMorphology("input1", radius="1,2").tostring(),
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 223, in __call__
      obj = self.cls(*args, **kwargs) # create an object of type 'cls'
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 72, in __init__
      super(_FilterRequireInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 61, in __init__
      super(_FilterNoInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 69, in __init__
      self.update(extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 85, in update
      self.__setitem__(key, value)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '1,2' is not a valid value for attribute 'radius' at svg-element <feMorphology>.

  ======================================================================
  ERROR: test_kernelUnitLength (tests.test_filters.Test_feSpecularLighting)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 314, in test_kernelUnitLength
      self.assertEqual(f.feSpecularLighting("input1", kernelUnitLength="1,2").tostring(),
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 223, in __call__
      obj = self.cls(*args, **kwargs) # create an object of type 'cls'
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 72, in __init__
      super(_FilterRequireInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 61, in __init__
      super(_FilterNoInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 69, in __init__
      self.update(extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 85, in update
      self.__setitem__(key, value)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '1,2' is not a valid value for attribute 'kernelUnitLength' at svg-element <feSpecularLighting>.

  ======================================================================
  ERROR: test_baseFrequency (tests.test_filters.Test_feTurbulence)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_filters.py", line 338, in test_baseFrequency
      self.assertEqual(f.feTurbulence(baseFrequency="1,2").tostring(),
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 223, in __call__
      obj = self.cls(*args, **kwargs) # create an object of type 'cls'
    File "/build/svgwrite-1.1.6/svgwrite/filters.py", line 61, in __init__
      super(_FilterNoInput, self).__init__(**extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 69, in __init__
      self.update(extra)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 85, in update
      self.__setitem__(key, value)
    File "/build/svgwrite-1.1.6/svgwrite/base.py", line 162, in __setitem__
      self.validator.check_svg_attribute_value(self.elementname, key, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 62, in check_svg_attribute_value
      self._check_svg_value(elementname, attributename, value)
    File "/build/svgwrite-1.1.6/svgwrite/validator2.py", line 79, in _check_svg_value
      raise TypeError("'%s' is not a valid value for attribute '%s' at svg-element <%s>." % (value, attributename, elementname))
  TypeError: '1,2' is not a valid value for attribute 'baseFrequency' at svg-element <feTurbulence>.

  ======================================================================
  FAIL: test_is_number_optional_number (tests.test_full11_typechecker.TestFull11TypeChecker)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/svgwrite-1.1.6/tests/test_full11_typechecker.py", line 172, in test_is_number_optional_number
      self.assertTrue(self.checker.is_number_optional_number(' 1, 2'))
  AssertionError: False is not true

  ----------------------------------------------------------------------
  Ran 453 tests in 0.473s

  FAILED (failures=1, errors=6)
  Test failed: <unittest.runner.TextTestResult run=453 errors=6 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=453 errors=6 failures=1>
  builder for '/nix/store/9hg7wa61vhx50nknc2nqinbrzym1cb9z-python3.7-svgwrite-1.1.6.drv' failed with exit code 1
  error: build of '/nix/store/9hg7wa61vhx50nknc2nqinbrzym1cb9z-python3.7-svgwrite-1.1.6.drv' failed
  ```


  ### Steps to reproduce
  - `cd ~/nixpkgs`
  - `git checkout 7c73f53d836af32624468e8de7730be1f033667c`
  - `export NIX_PATH=nixpkgs=/home/bbigras2/nixpkgs`
  - `nix-build -A python37Packages.svgwrite`


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.85, NixOS, 19.03.git.7c73f53 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.1534.d45a0d7a4f5, nixos-unstable-19.03pre161545.7c73f53d836"`
   - nixpkgs: `/home/bbigras2/nixpkgs`


state: closed
title: pythonPackages.python-fontconfig: regenerate sources using cython
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/51513
updated_at: 2018-12-05 19:13:57
body:
  ###### Motivation for this change

  Same issue: https://github.com/mcfletch/pyopengl/issues/11
  This PR fixes an error when building for python3.7

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ntfs-3g: enable extras
user_login: leo60228
html_url: https://github.com/NixOS/nixpkgs/pull/51514
updated_at: 2018-12-05 19:12:10
body:
  ###### Motivation for this change
  Adds a few extra utilities, most of which are useful.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gmp: don't use uname to detect system features
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/51515
updated_at: 2019-01-09 12:22:30
body:
  ###### Motivation for this change

  On 32-bit ARM, gmp is explicitly configured with an alternative way to autodetect the build platform to work around a bug in the default system detection. This has the side effect of making it impossible to build correctly for armv6l on an armv7l machine.

  ###### Things done

  This PR replaces the `configfsf.guess` script with `stdenv.buildPlatform.config`. This makes the build more pure and also makes the derivation a little cleaner because we can use `configureFlags` instead of the `preConfigure` script.

  I split the change into two commits, the first which avoids a mass rebuild on architectures other than 32-bit ARM, and second which cleans up the derivation with a mass rebuild (removing the `preConfigure` attribute).

  I would like to get the first commit into master, and the second into staging, but I'm not sure what the procedure is for that.

  cc @peti @vrthra 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Transient R test failure on hydra 18.09
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/issues/51516
updated_at: 2019-03-05 19:51:55
body:
  ## Issue description

  The hydra job for R is currently [failing](https://hydra.nixos.org/build/85109380#tabs-summary) on 18.09. I cannot reproduce the failure locally.

  CC @peti 


state: open
title: Cross-compiling redis with armv7l-unknown-linux-gnueabi fails
user_login: furrycatherder
html_url: https://github.com/NixOS/nixpkgs/issues/51517
updated_at: 2018-12-05 17:04:24
body:
  ## Issue description

  ```console
  sean@kodenine ~/d/nixbmc> cat default.nix
  with import <nixpkgs> {
    crossSystem.config = "armv7l-unknown-linux-gnueabi";
  };

  callPackage <nixpkgs/nixos/lib/make-squashfs.nix> {
    storeContents = [ redis busybox ];
  }

  sean@kodenine ~/d/nixbmc> nix build
  builder for '/nix/store/zhc824aq2hvgqa54l7mzirv9n1zqdlc5-redis-5.0.1-armv7l-unknown-linux-gnueabi.drv' failed with exit code 2; last 10 log lines:
    make[1]: [Makefile:184: persist-settings] Error 2 (ignored)
        CC adlist.o
    In file included from adlist.c:34:0:
    zmalloc.h:50:10: fatal error: jemalloc/jemalloc.h: No such file or directory
     #include <jemalloc/jemalloc.h>
              ^~~~~~~~~~~~~~~~~~~~~
    compilation terminated.
    make[1]: *** [Makefile:232: adlist.o] Error 1
    make[1]: Leaving directory '/build/redis-5.0.1/src'
    make: *** [Makefile:6: all] Error 2
  cannot build derivation '/nix/store/prsxb48b7lk947cnrg95fldxpd97m84h-closure-info-armv7l-unknown-linux-gnueabi.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/simacjs7x1iw02dy3508386vv0wq2hgn-squashfs.img-armv7l-unknown-linux-gnueabi.drv': 1 dependencies couldn't be built
  [0 built (1 failed)]
  error: build of '/nix/store/simacjs7x1iw02dy3508386vv0wq2hgn-squashfs.img-armv7l-unknown-linux-gnueabi.drv' failed
  ```

  ### Steps to reproduce

  See above `default.nix`. 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.79, NixOS, 18.09.1381.c1427bf45ff (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.1381.c1427bf45ff"`
   - channels(sean): `"nixpkgs-19.03pre159550.5ba0796bf2a, vertiv"`
   - nixpkgs: `/home/sean/.nix-defexpr/channels/nixpkgs`


state: closed
title: nixos: add XDG sounds module
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/51518
updated_at: 2018-12-17 23:44:29
body:
  ###### Motivation for this change
  As suggested in https://github.com/NixOS/nixpkgs/issues/47173.

  Implementation is trivial: AFAICT there's not much to do other than link the directory.

  @jtojnar @worldofpeace (I think you wanted this for the elementary PR)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stdenv: Add a fake date utility together with setup
user_login: rht
html_url: https://github.com/NixOS/nixpkgs/pull/51519
updated_at: 2018-12-04 19:44:46
body:
  This is 1 out of the remaining 3 points (fake date in stdenv, numbering names in stdenv, fake time in stdenv) needed to be resolved for #2281.

  Based on https://github.com/NixOS/nixpkgs/pull/2281/commits/c232efa244cb0ca38bba6392a7d5a88b609f9b92.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos: add AppStream module
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/51520
updated_at: 2018-12-17 23:27:24
body:
  ###### Motivation for this change

  As suggested in https://github.com/NixOS/nixpkgs/issues/47173.

  Implementation is trivial, just linking some paths. `/share/app-info` is a little funny, since it contains both collection metadata and icon caches. I'm pretty sure we don't also need to include `/share/app-info/icons` for that to be merged properly.

  @jtojnar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zafiro-icons: 0.7.2 -> 0.7.3
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/51521
updated_at: 2018-12-04 20:31:16
body:
  ###### Motivation for this change

  - Update to version [0.7.3](https://github.com/zayronxio/Zafiro-icons/releases/tag/v0.7.3)
  - Fix the directory name

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: bind: binaries missing in nix run vs nix-env
user_login: brendan-hall
html_url: https://github.com/NixOS/nixpkgs/issues/51522
updated_at: 2019-04-29 16:29:10
body:
  ## Issue description
  `nix-env` and `nix run` disagree on what binaries (outputs?) to install when called on `<nixpkgs>.bind`.
  For instance, the `dig` binary is missing when using `nix run`, but `mdig` is available either way

  `nix run nixpkgs.dnsutils` *does* make dig available, but not mdig 

  ### Steps to reproduce
  ````console 
  $ dig
  The program ‘dig’ is currently not installed. You can install it by typing:
    nix-env -iA nixos.bind
  $ mdig
  The program ‘mdig’ is currently not installed. You can install it by typing:
    nix-env -iA nixos.bind
  ````
  ````console 
  $ nix run nixpkgs.bind
  $ dig
  The program ‘dig’ is currently not installed. You can install it by typing:
    nix-env -iA nixos.bind
  $ mdig
  mdig: a server '@xxx' is required
  ````
  ````console 
  $ nix run nixpkgs.dnsutils
  $ dig

  ; <<>> DiG 9.12.2 <<>>
  [...]
  $ mdig
  The program ‘mdig’ is currently not installed. You can install it by typing:
    nix-env -iA nixos.bind
  ````
  ````console 
  $ nix-env -iA nixos.bind
  installing 'bind-9.12.2'
  $ dig

  ; <<>> DiG 9.12.2 <<>>
  [...]
  $ mdig
  mdig: a server '@xxx' is required
  ````

  this is repeatable with `unstable` in place of `nixpkgs`/`nixos`

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.84, NixOS, 18.09.1446.db561c90ef3 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(nullvoid): `"unstable-19.03pre159472.80738ed9dc0"`
   - channels(root): `"nixos-18.09.1446.db561c90ef3"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: nsjail: fix path to new{u|g}idmap
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/51523
updated_at: 2018-12-04 21:47:55
body:
  ###### Motivation for this change

  Closes #51496
  /cc @andrewchambers

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Test (failed -- it's still up to the user to define valid rules in `/etc/subuid` and `/etc/subgid` )

  ```ini
  $ sudo ./result/bin/nsjail -Mo -U demo:24000:1 / -- /run/current-system/sw/bin/echo "ABC"
  [2018-12-04T21:28:19+0100] Mode: STANDALONE_ONCE
  [2018-12-04T21:28:19+0100] Jail parameters: hostname:'NSJAIL', chroot:'', process:'/', bind:[::]:0, max_conns_per_ip:0, time_limit:0, personality:0, daemonize:false, clone_newnet:true, clone_newuser:true, clone_newns:true, clone_newpid:true, clone_newipc:true, clonew_newuts:true, clone_newcgroup:true, keep_caps:false, disable_no_new_privs:false, max_cpus:0
  [2018-12-04T21:28:19+0100] Mount point: '/' flags:MS_RDONLY type:'tmpfs' options:'' is_dir:true
  [2018-12-04T21:28:19+0100] Mount point: '/proc' flags:MS_RDONLY type:'proc' options:'' is_dir:true
  [2018-12-04T21:28:19+0100] Uid map: inside_uid:1000 outside_uid:24000 count:1 newuidmap:true
  [2018-12-04T21:28:19+0100] Gid map: inside_gid:0 outside_gid:0 count:1 newgidmap:false
  [2018-12-04T21:28:19+0100] [W][14124] void cmdline::logParams(nsjconf_t*)():262 Process will be GID/EGID=0 in the global user namespace, and will have group root-level access to files
  newuidmap: uid range [1000-1001) -> [24000-24001) not allowed
  [2018-12-04T21:28:19+0100] [E][14124] bool user::uidMapExternal(nsjconf_t*, pid_t)():200 '/nix/store/y8gbyldjb042kyy46dsf84z8f0b2flhq-shadow-4.6/bin/newuidmap' failed
  [2018-12-04T21:28:19+0100] [E][14124] bool subproc::initParent(nsjconf_t*, pid_t, int)():383 Couldn't initialize user namespace for pid 14125
  [2018-12-04T21:28:19+0100] [E][14124] int nsjail::standaloneMode(nsjconf_t*)():146 Couldn't launch the child process
  [2018-12-04T21:28:19+0100] [F][1] bool subproc::runChild(nsjconf_t*, int, int, int)():431 Launching child process failed
  ```

  But at least calls to `newuidmap` or `newgidmap` are working as expected


state: closed
title: vault: 0.11.5 -> 1.0.0
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/51524
updated_at: 2018-12-05 20:13:12
body:
  ###### Motivation for this change

  HackerNews-driven package upgrade

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: all-packages.nix: Fix reference to self warning
user_login: roberth
html_url: https://github.com/NixOS/nixpkgs/pull/51525
updated_at: 2018-12-05 14:39:34
body:
  This reference was added to master while the deprecation PR #51401 was open.

  ###### Motivation for this change

  Breaks the tarball derivation which disallows [warnings](https://github.com/NixOS/nixpkgs/pull/51401#issuecomment-444185862) here.

  cc @NeQuissimus who wrote the offending line before it was offending.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab: 11.5.0 -> 11.5.1
user_login: globin
html_url: https://github.com/NixOS/nixpkgs/pull/51526
updated_at: 2018-12-04 22:15:18
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @flokli 


state: closed
title: [WIP] all-packages.nix: Use pkgs ("self") instead of res (next stage super)
user_login: roberth
html_url: https://github.com/NixOS/nixpkgs/pull/51527
updated_at: 2019-02-02 06:30:55
body:
  ###### Motivation for this change

  `res` is redundant. The goal of this PR is to run it on ofborg so [changes](https://gist.github.com/GrahamcOfBorg/2e3b568727ac6443314a5ffdc5209cdc) can be triaged.

  @Ericson2314 have a look :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockertools buildImage: support new-style image specs
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/51528
updated_at: 2018-12-07 12:59:34
body:
  Docker images used to be, essentially, a linked list of layers. Each
  layer would have a tarball and a json document pointing to its parent,
  and the image pointed to the top layer:

      imageA  ----> layerA
                      |
                      v
                    layerB
                      |
                      v
                    layerC

  The current image spec changed this format to where the Image defined
  the order and set of layers:

      imageA  ---> layerA
              |--> layerB
              `--> layerC

  For backwards compatibility, docker produces images which follow both
  specs: layers point to parents, and images also point to the entire
  list:

      imageA  ---> layerA
              |      |
              |      v
              |--> layerB
              |      |
              |      v
              `--> layerC

  This is nice for tooling which supported the older version and never
  updated to support the newer format.

  Our `buildImage` code only supported the old version, so in order for
  `buildImage` to properly generate an image based on another image
  with `fromImage`, the parent image's layers must fully support the old
  mechanism.

  This is not a problem in general, but is a problem with
  `buildLayeredImage`.

  `buildLayeredImage` creates images with newer image spec, because
  individual store paths don't have a guaranteed parent layer. Including
  a specific parent ID in the layer's json makes the output less likely
  to cache hit when published or pulled.

  This means until now, `buildLayeredImage` could not be the input to
  `buildImage`. 

  The changes in this PR change `buildImage` to only use the layer's
  manifest when locating parent IDs. This does break buildImage on
  extremely old Docker images, though I do wonder how many of these
  exist.

  This work has been sponsored by Target.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: opensans-ttf: change source to salsa, rename to open-sans
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/51529
updated_at: 2018-12-05 23:31:07
body:
  ###### Motivation for this change
  We really shouldn't be fetching this from a web archive.

  ~This also includes the condensed variant.~


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openra-ura: init at 407
user_login: msteen
html_url: https://github.com/NixOS/nixpkgs/pull/51530
updated_at: 2019-01-02 00:27:40
body:
  ###### Motivation for this change
  Red Alert - Unplugged

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitlbee-discord: 0.4.1 -> 0.4.2
user_login: mkaito
html_url: https://github.com/NixOS/nixpkgs/pull/51531
updated_at: 2018-12-08 11:07:03
body:
  ###### Motivation for this change
  https://github.com/sm00th/bitlbee-discord/releases/tag/0.4.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pkgsi686Linux.nixosTests.gitlab: fix 32 bit tests
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/51532
updated_at: 2018-12-05 09:47:20
body:
  GitLab 11.5.1 dropped the dependency to posix_spawn, which is broken on
  32bit. (See https://gitlab.com/gitlab-org/gitlab-ce/issues/53525)

  The only part missing is decreasing virtualisation.memorySize to
  something that a 32 bit qemu still executes.

  The maximum seems to be 2047, and tests passed with that value for me.

  ###### Motivation for this change
  getting [32 bit gitlab vm tests](https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.gitlab.i686-linux) to run.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @globin, can you backport this as alongside #51526?


state: closed
title: loop: unstable-2018-10-02 -> unstable-2018-12-04
user_login: k0ral
html_url: https://github.com/NixOS/nixpkgs/pull/51533
updated_at: 2018-12-05 11:45:56
body:
  ###### Motivation for this change
  Simplify derivation.
  Follow-up of https://github.com/NixOS/nixpkgs/pull/51327#discussion_r238082181 .

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bowtie2: fix missing dependencies
user_login: jbedo
html_url: https://github.com/NixOS/nixpkgs/pull/51534
updated_at: 2018-12-09 23:59:02
body:
  ###### Motivation for this change

  Bowtie2 was missing required dependencies for execution.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/cockroachdb: simplify dataDir management, tweaks
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/51535
updated_at: 2019-01-12 00:12:06
body:
  This cleans up the CockroachDB expression, with a few suggestions from
  @aszlig.

  However, it brought up the note of using systemd's StateDirectory=
  directive, which is a nice feature for managing long-term data files,
  especially for UID/GID assigned services. However, it can only manage
  directories under /var/lib (for global services), so it has to introduce
  a special path to make use of it at all in the case someone wants a path
  at a different root.

  While the dataDir directive at the NixOS level is _occasionally_ useful,
  I've gone ahead and removed it for now, as this expression is so new,
  and it makes the expression cleaner, while other kinks can be worked out
  and people can test drive it.

  CockroachDB's dataDir directive, instead, has been replaced with
  systemd's StateDirectory management to place the data under
  /var/lib/cockroachdb for all uses.

  There's an included RequiresMountsFor= clause like usual though, so if
  people want dependencies for any kind of mounted device at boot
  time/before database startup, it's easy to specify using their own
  mount/filesystems clause.

  This can also be reverted if necessary, but, we can see if anyone ever
  actually wants that later on before doing it -- it's a backwards
  compatible change, anyway.

  Signed-off-by: Austin Seipp <aseipp@pobox.com>

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildRustCreate: export RUSTDOC during cargo config
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/51536
updated_at: 2019-01-12 00:10:03
body:
  See https://github.com/NixOS/nixpkgs/pull/50452#issuecomment-443455411

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: defaultGateway6.interface without defaultGateway6.address
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/issues/51537
updated_at: 2019-02-04 02:31:46
body:
  ## Issue description

  he.net tunnelbroker's instructs to set up the default gateway for IPv6 without the address of the gateway, using only dev.
  ![](http://i.imgur.com/so8Or2Q.png)

  So 
  ```
  defaultGateway6 = { /* address = "???"; */ interface  = "he-ipv6"; };
  ```
   supposes to be a valid setup.

  Although #12500 introduced the option to configure ```defaultGateway6.address``` and ```defaultGateway6.interface``` independently, absense of ```defaultGateway6.address``` (or setting it to "") results in no routing entry added silently


state: closed
title: foundationdb60: 6.0.15 -> 6.0.17
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/51538
updated_at: 2018-12-05 04:33:00
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Applespi: Package and Nixos flag
user_login: gerd2002
html_url: https://github.com/NixOS/nixpkgs/pull/51539
updated_at: 2018-12-27 17:16:05
body:
  ###### Motivation for this change
  Applespi is required on newish macbooks for keyboard and trackpad to work. This adds a package for the driver and a flag to enable it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Get rid of manually setting --enable/disable-static/shared flags
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/issues/51540
updated_at: 2019-04-13 22:41:10
body:
  ## Issue description

  We shouldn't be setting these flags in configureFlags. Packages built in nixpkgs should all have set:

  - --disable-static
  - --enable-shared

  This is done automatically. Some places are setting this manually:

  https://github.com/NixOS/nixpkgs/search?q=--enable-static
  https://github.com/NixOS/nixpkgs/search?q=--disable-static
  https://github.com/NixOS/nixpkgs/search?q=--enable-shared
  https://github.com/NixOS/nixpkgs/search?q=--enable-shared

  Most likely something else is going on that needs to be investigated.


state: closed
title: fix infinite recursion caused by the unnecessary inspection of options
user_login: msteen
html_url: https://github.com/NixOS/nixpkgs/pull/51541
updated_at: 2018-12-24 13:05:56
body:
  ###### Motivation for this change

  When you have a NixOS configuration like the following:
  ```nix
  { config, ... }:

  {
    boot.loader.grub.device = "nodev";
    fileSystems."/" = {
      device = "nodev";
      options = [ "uid=${toString config.users.users.root.uid}" ];
    };
    fileSystems."/foo" = {
      device = "nodev";
    };
  }
  ```

  And you test it like so:
  ```sh
  NIXOS_CONFIG=debug-fs-user-recursion.nix nix-instantiate --eval \
    --expr '(import <nixpkgs/nixos> { }).config.services.rpcbind.enable'
  ```

  You will get infinite recursion:
  1. rpcbind.nix defines `users.extraUsers.rpc`
  2. nfs.nix sets `services.rpcbind.enable` depending on `config.boot.supportedFilesystems`
  3. filesystems.nix defines `boot.supportedFilesystems` based on `toposort fsBefore (attrValues config.fileSystems)`
  4. utils.nix defines `fsBefore` and uses `config.fileSystems.<name>.options` to do so
  5. this file defines `fileSystems."/".options` to refer to `config.users.users` (`extraUsers` is an alias for `users`)
  6. causing infinite recursion

  The original check had this:
  ```nix
  ((any (x: elem x [ "bind" "move" ]) b.options) && (a.mountPoint == b.device))
  ```
  However any file system type that allows a device to be what is also valid in a mount point (i.e. normal directories), like "bind" and "move" do, are the only ones that will ever pass the `a.mountPoint == b.device` condition. Hence the precondition `any (x: elem x [ "bind" "move" ]) b.options` should be unnecessary. Removing the precondition solves the infinite recursion issue.

  Then to address `# FIXME: it's incorrect to simply use hasPrefix here: "/dev/a" is not a parent of "/dev/ab"`, we could just ensure that the prefix check always end with a "/", such that hasPrefix only succeeds if its an actual parent, like so:
  ```nix
  hasPrefix "${a.mountPoint}${optionalString (!(hasSuffix "/" a.mountPoint)) "/"}" b.mountPoint
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.svgwrite: 1.1.6 -> 1.2.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/51542
updated_at: 2018-12-05 11:57:26
body:
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/51512

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37Packages.curtsises fails to install
user_login: mmlb
html_url: https://github.com/NixOS/nixpkgs/issues/51543
updated_at: 2018-12-05 10:52:45
body:
  ## Issue description

  Can't install python37Packages.curtsies because tests fail. Upstream's tests on 3.7 pass.

  ### Steps to reproduce

  nix-shell -p python37Packages.curtsies

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.81, NixOS, 19.03pre161545.7c73f53d836 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-19.03pre161545.7c73f53d836"`
   - channels(manny): `"home-manager"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ## Build Log
  ```
  ❯ nix-shell -p python37Packages.curtsies
  these derivations will be built:
    /nix/store/y5rajl7zkh2sf3z1m4v941whaz0awj80-python3.7-curtsies-0.3.0.drv
  building '/nix/store/y5rajl7zkh2sf3z1m4v941whaz0awj80-python3.7-curtsies-0.3.0.drv'...
  unpacking sources
  unpacking source archive /nix/store/05jpvm3bi1i2mf2xyb5jxy97d7vl43yn-curtsies-0.3.0.tar.gz
  source root is curtsies-0.3.0
  setting SOURCE_DATE_EPOCH to timestamp 1518568442 of file curtsies-0.3.0/setup.cfg
  patching sources
  configuring
  building
  pypandoc not installed, using file contents.
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build/lib
  creating build/lib/curtsies
  copying curtsies/window.py -> build/lib/curtsies
  copying curtsies/termhelpers.py -> build/lib/curtsies
  copying curtsies/termformatconstants.py -> build/lib/curtsies
  copying curtsies/input.py -> build/lib/curtsies
  copying curtsies/formatstringarray.py -> build/lib/curtsies
  copying curtsies/formatstring.py -> build/lib/curtsies
  copying curtsies/fmtfuncs.py -> build/lib/curtsies
  copying curtsies/events.py -> build/lib/curtsies
  copying curtsies/escseqparse.py -> build/lib/curtsies
  copying curtsies/curtsieskeys.py -> build/lib/curtsies
  copying curtsies/configfile_keynames.py -> build/lib/curtsies
  copying curtsies/__init__.py -> build/lib/curtsies
  installing to build/bdist.linux-x86_64/wheel
  running install
  running install_lib
  creating build/bdist.linux-x86_64
  creating build/bdist.linux-x86_64/wheel
  creating build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/__init__.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/configfile_keynames.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/curtsieskeys.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/escseqparse.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/events.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/fmtfuncs.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/formatstring.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/formatstringarray.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/input.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/termformatconstants.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/termhelpers.py -> build/bdist.linux-x86_64/wheel/curtsies
  copying build/lib/curtsies/window.py -> build/bdist.linux-x86_64/wheel/curtsies
  running install_egg_info
  running egg_info
  writing curtsies.egg-info/PKG-INFO
  writing dependency_links to curtsies.egg-info/dependency_links.txt
  writing requirements to curtsies.egg-info/requires.txt
  writing top-level names to curtsies.egg-info/top_level.txt
  reading manifest file 'curtsies.egg-info/SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'curtsies.egg-info/SOURCES.txt'
  Copying curtsies.egg-info to build/bdist.linux-x86_64/wheel/curtsies-0.3.0-py3.7.egg-info
  running install_scripts
  adding license file "LICENSE" (matched pattern "LICEN[CS]E*")
  creating build/bdist.linux-x86_64/wheel/curtsies-0.3.0.dist-info/WHEEL
  creating 'dist/curtsies-0.3.0-py2.py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
  adding 'curtsies/__init__.py'
  adding 'curtsies/configfile_keynames.py'
  adding 'curtsies/curtsieskeys.py'
  adding 'curtsies/escseqparse.py'
  adding 'curtsies/events.py'
  adding 'curtsies/fmtfuncs.py'
  adding 'curtsies/formatstring.py'
  adding 'curtsies/formatstringarray.py'
  adding 'curtsies/input.py'
  adding 'curtsies/termformatconstants.py'
  adding 'curtsies/termhelpers.py'
  adding 'curtsies/window.py'
  adding 'curtsies-0.3.0.dist-info/LICENSE'
  adding 'curtsies-0.3.0.dist-info/METADATA'
  adding 'curtsies-0.3.0.dist-info/WHEEL'
  adding 'curtsies-0.3.0.dist-info/top_level.txt'
  adding 'curtsies-0.3.0.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  installing
  /build/curtsies-0.3.0/dist /build/curtsies-0.3.0
  Processing ./curtsies-0.3.0-py2.py3-none-any.whl
  Requirement already satisfied: wcwidth>=0.1.4 in /nix/store/zd9yafz2y3jhp1laalyn2sk3r6fknc1s-python3.7-wcwidth-0.1.7/lib/python3.7/site-packages (from curtsies==0.3.0) (0.1.7)
  Requirement already satisfied: typing in /nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages (from curtsies==0.3.0) (3.6.6)
  Requirement already satisfied: blessings>=1.5 in /nix/store/gv7y2vbn1n3007i8vrqlwvv8lvwyq0q8-python3.7-blessings-1.6/lib/python3.7/site-packages (from curtsies==0.3.0) (1.6)
  Installing collected packages: curtsies
  Successfully installed curtsies-0.3.0
  /build/curtsies-0.3.0
  post-installation fixup
  shrinking RPATHs of ELF executables and libraries in /nix/store/h3ra1kz7a1hb4b2xw7lcf5fmydiwn1pg-python3.7-curtsies-0.3.0
  strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
  stripping (with command strip and flags -S) in /nix/store/h3ra1kz7a1hb4b2xw7lcf5fmydiwn1pg-python3.7-curtsies-0.3.0/lib
  patching script interpreter paths in /nix/store/h3ra1kz7a1hb4b2xw7lcf5fmydiwn1pg-python3.7-curtsies-0.3.0
  checking for references to /build/ in /nix/store/h3ra1kz7a1hb4b2xw7lcf5fmydiwn1pg-python3.7-curtsies-0.3.0...
  running install tests
  EEEEEEE
  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_configfile_keynames.py", line 5, in <module>
      from curtsies.configfile_keynames import keymap
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_events.py", line 5, in <module>
      from curtsies import events
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_fmtstr.py", line 5, in <module>
      from curtsies.formatstring import (
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_input.py", line 22, in <module>
      from curtsies import events
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_perf.py", line 7, in <module>
      from curtsies.formatstring import (FmtStr, fmtstr, Chunk, linesplit,
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_terminal.py", line 18, in <module>
      from curtsies.window import BaseWindow, FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ======================================================================
  ERROR: Failure: AttributeError (type object 'Callable' has no attribute '_abc_registry')
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
      raise self.exc_val.with_traceback(self.tb)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
      addr.filename, addr.module)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
      return self.importFromDir(dir_path, fqname)
    File "/nix/store/fyqj577s3jjfjlxjyd6b4z35d6m1y9a9-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
      mod = load_module(part_fqname, fh, filename, desc)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 234, in load_module
      return load_source(name, filename, file)
    File "/nix/store/6lm4gi5iv8fbf1b1mm6g3gfnnv63f1gn-python3-3.7.1/lib/python3.7/imp.py", line 171, in load_source
      module = _load(spec)
    File "<frozen importlib._bootstrap>", line 696, in _load
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/build/curtsies-0.3.0/tests/test_window.py", line 6, in <module>
      from curtsies.window import BaseWindow, FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/__init__.py", line 4, in <module>
      from .window import FullscreenWindow, CursorAwareWindow
    File "/build/curtsies-0.3.0/curtsies/window.py", line 13, in <module>
      from .formatstring import fmtstr
    File "/build/curtsies-0.3.0/curtsies/formatstring.py", line 3, in <module>
      from typing import Iterator, Text, Tuple, List, Union, Optional
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1356, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/nix/store/fy7m432p8iwzix0hn662whrz6q2rwlnq-python3.7-typing-3.6.6/lib/python3.7/site-packages/typing.py", line 1004, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'

  ----------------------------------------------------------------------
  Ran 7 tests in 0.078s

  FAILED (errors=7)
  builder for '/nix/store/y5rajl7zkh2sf3z1m4v941whaz0awj80-python3.7-curtsies-0.3.0.drv' failed with exit code 1
  error: build of '/nix/store/y5rajl7zkh2sf3z1m4v941whaz0awj80-python3.7-curtsies-0.3.0.drv' failed
  ```


state: closed
title: prometheus/exporters: fix DynamicUser regression
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/51545
updated_at: 2018-12-05 17:21:30
body:
  ###### Motivation for this change

  fbb7e0c82f297815950e9153c21e561a704bfcd5 inverted logic related to DynamicUser. Instead of setting User/Group when DynamicUser is disabled, it is only set when DynamicUser is enabled. This causes DynamicUser exporters to run as nobody/nobody, and other exporters to run as root.

  prometheus/exporters/tor happens to not work with DynamicUser as is because of a CPython bug, so a prerequisite commit works around the issue by defining a dummy $HOME.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cyrus_sasl: remove old patch
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/51546
updated_at: 2018-12-05 16:58:07
body:
  ###### Motivation for this change

  it was removed with "cyrus_sasl: 2.1.26 -> 2.1.27" https://github.com/NixOS/nixpkgs/commit/b13af1e87b26a3ee7d81c4b237710a93e1f243e8

  but reappeared mistakingly in "Merge staging-next into staging" https://github.com/NixOS/nixpkgs/commit/9b81c7e455c278a45db0f6c21d7e16bb0ff9bf37


state: closed
title: pythonPackages.curtsies: fix build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/51547
updated_at: 2018-12-05 11:56:43
body:
  ###### Motivation for this change
  Fixes https://github.com/NixOS/nixpkgs/issues/51543

  cc: @mmlb 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages: cpan2nix updates
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/51548
updated_at: 2018-12-21 03:42:45
body:
  ###### Motivation for this change

  update perl packages

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skhd: 0.2.2 -> 0.3.0
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/51549
updated_at: 2018-12-07 08:03:45
body:
  ###### Motivation for this change

  Update to the latest version.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: altcoins.aeon: 0.12.6.0 -> 0.12.8.0
user_login: fuwa0529
html_url: https://github.com/NixOS/nixpkgs/pull/51550
updated_at: 2018-12-05 11:28:00
body:
  ###### Motivation for this change
  Version bump

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nginx: do not run anything as root
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/51551
updated_at: 2019-02-22 13:45:50
body:
  Instead tell systemd to run the service as the requested user/group with
  the capability to listen on reserved ports (< 1024).

  ###### Motivation for this change

  Defense in depth: less root processes running on the system.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: reptyr: 0.6.2 -> 0.7.0
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/51552
updated_at: 2018-12-05 17:03:27
body:
  ###### Motivation for this change

  Update reptyr to the latest version. This release adds support for `aarch64-linux`, and removes the need for the build system workarounds.

  ###### Things done

  I added `aarch64-linux` to the supported platforms and also explicitly listed all the supported ARM platforms. I changed it to use `lib.platforms.arm` in #51259, but since then I decided that it would probably be better to explicitly list out the supported platforms, since reptyr would not work on `aarch64-freebsd` (hypothetically - we currently don't support that system), but it would be part of `lib.platforms.arm`.

  I also enabled the tests.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-ethereum: 1.8.17 -> 1.8.19
user_login: lionello
html_url: https://github.com/NixOS/nixpkgs/pull/51553
updated_at: 2018-12-05 16:45:10
body:
  ###### Motivation for this change

  Update to latest Geth

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add cl-jpeg, cl-pdf & cl-typesetting, no extra external deps
user_login: pcrama
html_url: https://github.com/NixOS/nixpkgs/pull/51554
updated_at: 2018-12-05 07:55:06
body:
  ###### Motivation for this change

  I have a Common Lisp app that needed cl-jpeg, cl-pdf and cl-typesetting.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions: Ubuntu 18.04 LTS
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: appimage-run: will not run OpenRA mods, due to it failing to detect Mono, even when installed
user_login: fusion809
html_url: https://github.com/NixOS/nixpkgs/issues/51555
updated_at: 2018-12-05 09:31:08
body:
  ## Issue description
  [OpenRA](https://github.com/OpenRA/OpenRA) provides AppImages for its official mods and via their [SDK](https://github.com/OpenRA/OpenRAModSDK) they make it easier for developers of unofficial mods to distribute their mods as AppImages. 

  The AppImages they provide are unusual in that they do have a host dependency, beyond FUSE and modern standard system libraries, Mono. Presently a compatible version of Mono is installed on my system, namely version 5.8.0.108 (which is the version `mono --version` gave me), but still I see this error dialog box appear:

  ![screenshot_20181205_161758](https://user-images.githubusercontent.com/4717341/49494664-1d091d00-f8ac-11e8-87e7-a7131a2be33e.png)

  When I try to launch the official Red Alert mod using appimage-run. 

  ### Steps to reproduce
  1. Install NixOS 18.09, using my configs: https://github.com/fusion809/NixOS-configs/tree/dc4954f15812bbb319fdcf7644646c9ed9fb968d).
  2. Install Mono 5.8.0.108 and appimage-run with:

  ```bash
  nix-env -f '<nixos-unstable>' -iA mono-5.8.0.108 appimage-run
  ```

  (refer to [note 1](#note) for further details)

  3. Obtain the official release-20180923 Red Alert AppImage from (and yes I have tested this on other AppImages belonging to OpenRA mods): https://github.com/OpenRA/OpenRA/releases/download/release-20180923/OpenRA-Red-Alert-x86_64.AppImage, e.g. by downloading it with wget:

  ```bash
  wget -c https://github.com/OpenRA/OpenRA/releases/download/release-20180923/OpenRA-Red-Alert-x86_64.AppImage
  ```

  4. Set its permissions to executable with:

  ```bash
  chmod +x OpenRA-Red-Alert-x86_64.AppImage
  ```

  5. Run `appimage-run` on it, with:

  ```bash
  appimage-run OpenRA-Red-Alert-x86_64.AppImage
  ```

  and Voila, you should see this error.

  ## Technical details
  ```bash
  $ nix-shell -p nix-info --run "nix-info -m"
  these paths will be fetched (0.35 MiB download, 1.59 MiB unpacked):
    /nix/store/63j8mi5vjyxfc89rhjknwxaxqg3a2sx2-paxctl-0.9
    /nix/store/bqp3d4yhpx6h60fv8jww5id0nkm44034-patchelf-0.9
    /nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux
    /nix/store/kic17fw8wil74k04kzh3dha43izrr9j3-bash-interactive-4.4-p23-dev
    /nix/store/ql3azyviwyc6w73h6prk1j2945skfapf-gnumake-4.2.1
  copying path '/nix/store/kic17fw8wil74k04kzh3dha43izrr9j3-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
  copying path '/nix/store/bqp3d4yhpx6h60fv8jww5id0nkm44034-patchelf-0.9' from 'https://cache.nixos.org'...
  copying path '/nix/store/ql3azyviwyc6w73h6prk1j2945skfapf-gnumake-4.2.1' from 'https://cache.nixos.org'...
  copying path '/nix/store/63j8mi5vjyxfc89rhjknwxaxqg3a2sx2-paxctl-0.9' from 'https://cache.nixos.org'...
  copying path '/nix/store/i6vl5lwlz5jbkg4r6p340dwmj6fha3xq-stdenv-linux' from 'https://cache.nixos.org'...
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.85, NixOS, 18.09.1534.d45a0d7a4f5 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(fusion809): `""`
   - channels(root): `"nixos-18.09.1534.d45a0d7a4f5, nixos-unstable-19.03pre161545.7c73f53d836"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```

  ## Notes:
  1. `nixos-unstable` is the repo mentioned as it is what I was using when I noticed this error. By-the-way, I have also tried adding `mono` to my `systemPackages` array in `/etc/nixos/configuration.nix` and rebuilding. Even after this, and following steps 3-5, I receive this same error. I also tried adding both `mono` and `appimage-run` to this array and rebuilding, and after this I still received this error when trying to run the subsequent steps. In case you're wondering, I made sure to start new shells after rebuilding, so my environment variables should have been properly set up. I verified I was using system `appimage-run and `mono` by running `which mono appimage-run` which returned: 

  ```bash
  /run/current-system/sw/bin/mono
  /run/current-system/sw/bin/appimage-run
  ```

  . 


state: closed
title: hivemind: init at 1.0.4
user_login: sveitser
html_url: https://github.com/NixOS/nixpkgs/pull/51556
updated_at: 2018-12-05 09:17:19
body:
  ###### Motivation for this change
  A "simpler" version of `overmind` without the `tmux` dependency. 

  FYI. When searching the the issues I noticed that there was another, unrelated package called `hivemind` that has since been removed.

  https://github.com/canndrew/nixpkgs/blob/42d7fa2c7160d513c9e043b9f6e1ba6b58b4deaa/pkgs/applications/altcoins/hivemind.nix

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dino: 2018-11-27 -> 2018-11-29
user_login: schmittlauch
html_url: https://github.com/NixOS/nixpkgs/pull/51557
updated_at: 2018-12-05 11:12:12
body:
  ###### Motivation for this change

  I've been testing dino on release-18.09 for several days now, but at a
  newer commit than packaged in nixpkgs-master.
  Thus this updates dino again, to be backported to release-18.09

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dino: backport version bump
user_login: schmittlauch
html_url: https://github.com/NixOS/nixpkgs/pull/51558
updated_at: 2018-12-05 12:31:07
body:
  ###### Motivation for this change

  backport of #51557 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tomcat: update minor versions
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/pull/51561
updated_at: 2019-04-17 02:00:54
body:
  ###### Motivation for this change
  I only tested the 8.5x update myself.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: leela-zero: init at 0.16
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/pull/51562
updated_at: 2018-12-05 21:23:06
body:
  ###### Motivation for this change
  Best freely available Go-engine (requires separate GTP UI).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: makeFontsCache & makeFontsConf don't cross compile
user_login: eburimu
html_url: https://github.com/NixOS/nixpkgs/issues/51563
updated_at: 2018-12-05 23:12:19
body:
  ## Issue description

  Hello, I get the error below, any ideas?

  ```
    9977 building '/nix/store/8rq2d1a55w90zc3616zan5zf3x50jnji-fc-cache-armv7l-unknown-linux-gnueabihf.drv'...
    9978 /nix/store/hl22ci63dfpwiycbslnv6qwsc8q1bqmn-stdenv-linux/setup: line 1288: fc-cache: command not found
    9979 builder for '/nix/store/8rq2d1a55w90zc3616zan5zf3x50jnji-fc-cache-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 127
    9980 cannot build derivation '/nix/store/m3hdbl34dvk6q1ibp6256npxk9qkb909-fc-00-nixos-cache.conf-armv7l-unknown-linux-gnueabihf.drv': 1 dependencies couldn't be built
    9981 building '/nix/store/fg3zjdy6vlz9cfxfc5gh8hgjzp1ci4gc-fc-cache-armv7l-unknown-linux-gnueabihf.drv'...
    9982 /nix/store/hl22ci63dfpwiycbslnv6qwsc8q1bqmn-stdenv-linux/setup: line 1288: fc-cache: command not found
    9983 builder for '/nix/store/fg3zjdy6vlz9cfxfc5gh8hgjzp1ci4gc-fc-cache-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 127
    9984 cannot build derivation '/nix/store/9n45zcc64hdz5bxikkigphbc23nrx218-fc-00-nixos-cache.conf-armv7l-unknown-linux-gnueabihf.drv': 1 dependencies couldn't be built
    9985 building '/nix/store/mawaqhcsd7p351c87z6gsi35cvy8qk0i-fonts.conf-armv7l-unknown-linux-gnueabihf.drv'...
    9986 /build/.attr-0: line 1: xsltproc: command not found
    9987 builder for '/nix/store/mawaqhcsd7p351c87z6gsi35cvy8qk0i-fonts.conf-armv7l-unknown-linux-gnueabihf.drv' failed with exit code 127
  ```


state: open
title: (JavaFXSceneBuilder): Init at version 2
user_login: ysndr
html_url: https://github.com/NixOS/nixpkgs/pull/51564
updated_at: 2018-12-19 17:05:23
body:
  ###### Motivation for this change
  Add JavaFXSceneBuilder to be used standalone or inside intellij or other IDEs

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jenkins: 2.138.3 -> 2.150.1 (security!)
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/51565
updated_at: 2018-12-07 09:41:49
body:
  ###### Motivation for this change

  Fixes several security issues.

  See https://jenkins.io/blog/2018/12/05/security-updates/.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: GCE OSLogin module: init
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/51566
updated_at: 2018-12-24 13:11:50
body:
  ###### Motivation for this change
  ###### TODO
   - [x] get  #50316 merged, rebase on master
   - [x] fix sudo
   - [x] integrate with gke profiles
   - [x] add to release notes

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nginx: 1.14.1 -> 1.14.2
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/51567
updated_at: 2018-12-05 16:56:08
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parity: 2.1.6 -> 2.1.9; parity-beta: 2.2.1 -> 2.2.4
user_login: akru
html_url: https://github.com/NixOS/nixpkgs/pull/51568
updated_at: 2018-12-09 18:11:30
body:
  ###### Motivation for this change

  * https://github.com/paritytech/parity-ethereum/releases/tag/v2.2.4
  * https://github.com/paritytech/parity-ethereum/releases/tag/v2.1.9

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: polkadot: init at 0.2.17
user_login: akru
html_url: https://github.com/NixOS/nixpkgs/pull/51569
updated_at: 2019-04-18 10:44:57
body:
  ###### Motivation for this change

  Implementation of a https://polkadot.network node in Rust.
  https://github.com/paritytech/polkadot

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cassandra: add option to configure logging
user_login: eonpatapon
html_url: https://github.com/NixOS/nixpkgs/pull/51570
updated_at: 2019-01-07 18:41:08
body:
  As cassandra start script hardcodes the location of logback to
  `CASSANDRA_CONF_DIR/logback.xml` there is no way to pass an alternate file
  via `$JVM_OPTS` for example.

  Also, without logback configuration DEBUG level is used which is not
  necessary for standard usage.

  With this commit a default logback configuration is set with log level
  INFO.

  Configuration borrowed from:
  https://docs.datastax.com/en/cassandra/3.0/cassandra/configuration/configLoggingLevels.html

  ###### Motivation for this change

  No way of configuring cassandra logging

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: weechat: fix bad merge
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/51571
updated_at: 2018-12-06 00:40:25
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/44102/commits/8887e1f697d9e13ad277ca7d7054bc42c2459548#r239097413

  9504292b1e9948fb286b1b1cdbe83f66b367b64d accidentally reverted all the changes that had been made to the weechat wrapper since 8887e1f697d9e13ad277ca7d7054bc42c2459548.

  I removed the wrapper, then wrote it again, but this time taking the code from the latest version of weechat before the bad merge.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @Ma27 @lheckemann


state: closed
title: qmltermwidget: add missing utmp lib on darwin
user_login: georgewhewell
html_url: https://github.com/NixOS/nixpkgs/pull/51572
updated_at: 2018-12-09 17:20:14
body:
  ###### Motivation for this change

  qmltermwidget does not build on darwin. tested fix on 10.13.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Updated to pcl 1.9.1
user_login: luzpaz
html_url: https://github.com/NixOS/nixpkgs/issues/51573
updated_at: 2019-04-04 21:19:50
body:
  ## Issue description

  [pcl](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/pcl/default.nix) is in need of an update.

  https://github.com/PointCloudLibrary/pcl/releases/tag/pcl-1.9.1


state: closed
title: Don't substitute packages in comments
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/51574
updated_at: 2018-12-24 08:28:48
body:
  ## Issue description

  so commenting out works.

  ```
  [root@atomic:~]# nixos-rebuild switch
  building Nix...
  building the system configuration...
  error: attribute 'php56' missing, at /root/nixos/machines/atomic/configuration.nix:150:27
  (use '--show-trace' to show detailed location information)
  ```

  Not sure if this is a problem of Nix. Feel free to move the issue.

  ### Steps to reproduce

  ![screenshot from 2018-12-05 16-54-51](https://user-images.githubusercontent.com/91113/49525674-90139300-f8ae-11e8-997b-3539be158cc6.png)


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.84, NixOS, 18.09.1446.db561c90ef3 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.1446.db561c90ef3"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.parsimonious: 0.7.0 -> 0.8.1
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/51575
updated_at: 2018-12-05 19:01:40
body:
  ###### Motivation for this change

  Using it for a parser.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nextcloud: 14.0.3 -> 14.0.4
user_login: ciil
html_url: https://github.com/NixOS/nixpkgs/pull/51577
updated_at: 2018-12-09 17:05:22
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [WIP] imake: only use tradcpp on Darwin
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/51578
updated_at: 2018-12-07 16:02:58
body:
  ###### Motivation for this change

  Fixing `x11_ssh_askpass` on aarch64, see [hydra failure][].

  For reasons I don't understand, when building with `tradcpp` as the `IMAKECPP`, the aarch64 build passes `LinuxMachineDefines` where it should pass `-D__aarch64__`.

  This change was introduced in 613e262fc2f84d068da40ee6c45f0915c00e2193, cc @matthewbauer as the author.

  [hydra failure]: https://hydra.nixos.org/build/85068911

  Good:
  ```
  building
  build flags: SHELL=/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/bash
  gcc -O2 -fno-strict-aliasing      -I/nix/store/xisa9pqa1706nqiprscnp4qgvkqqysg8-xorg-cf-files-1.0.6/include    -Dlinux -D__aarch64__ -D_POSIX_C_SOURCE=199309L                          -D_POSIX_SOURCE -D_XOPEN_SOURCE                                 -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                                   -DFUNCPROTO=15 -DNARROWPROTO       -c -o drawing.o drawing.c
  ...
  ```

  Bad:
  ```
  building
  build flags: SHELL=/nix/store/bsb6596kk4fp20hyl9yl55xwv1ax4b6s-bash-4.4-p23/bin/bash
  gcc -O      -I/nix/store/xisa9pqa1706nqiprscnp4qgvkqqysg8-xorg-cf-files-1.0.6/include    -Dlinux LinuxMachineDefines -D_POSIX_C_SOURCE=199309L                          -D_POSIX_SOURCE -D_XOPEN_SOURCE                                 -D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64                                                                   -DFUNCPROTO=15 -DNARROWPROTO       -c -o drawing.o drawing.c
  gcc: error: LinuxMachineDefines: No such file or directory
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform-docs: init at 0.5.0
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/51579
updated_at: 2018-12-06 11:22:12
body:
  ###### Motivation for this change

  Package needed

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: soapyrtlsdr: init at 0.2.5
user_login: ragnard
html_url: https://github.com/NixOS/nixpkgs/pull/51580
updated_at: 2018-12-06 20:11:42
body:
  ###### Motivation for this change

  Add the Soapy RTL-SDR module which provides support for RTL-SDR dongles within the SoapySDR API and software that supports SoapySDR.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Implement R wrappers as local-only runCommand
user_login: joachifm
html_url: https://github.com/NixOS/nixpkgs/pull/51581
updated_at: 2018-12-07 09:17:44
body:
  ###### Motivation for this change
  I think this is a little simpler.  Tested briefly, but I don't really expect any problems.


state: open
title: supplicant service doesn't restart on resume
user_login: djahandarie
html_url: https://github.com/NixOS/nixpkgs/issues/51582
updated_at: 2018-12-06 07:55:55
body:
  ## Issue description

  The `supplicant` service in NixOS doesn't restart on resume, though the code seems to have the intent that it should.

  In particular, see these lines:
  https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/networking/supplicant.nix#L43
  ```
          # Receive restart event after resume
          partOf = [ "post-resume.target" ];
  ```

  ### Steps to reproduce

  Configure a supplicant service, sleep and resume laptop, observe that the service has been cleanly shutdown on resume instead of restarted.


  ## Technical details

  The nix expression results in the following unit file for me:

  ```
  After=sys-subsystem-net-devices-wlp4s0.device
  Before=network.target
  BindsTo=sys-subsystem-net-devices-wlp4s0.device
  Description=Supplicant wlp4s0
  PartOf=post-resume.target
  Wants=network.target
  ```

  There is the following description of "PartOf" in the systemd manual:

  ```
  PartOf=
  Configures dependencies similar to Requires=, but limited to stopping and restarting of units. When systemd stops or restarts the units listed here, the action is propagated to this unit. Note that this is a one-way dependency — changes to this unit do not affect the listed units.
  ```

  Given this description, I would guess that the `post-resume.target` is stopping on resume, and that stop gets propagated to `supplicant`, which causes it to stop, instead of restart.

  I'm not sure what the right fix is here. Other people seem to have had related issues: https://github.com/NixOS/nixpkgs/issues/19525

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.62, NixOS, 18.09.1446.db561c90ef3 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09, nixos-unstable-19.03pre158246.6141939d6e0"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

  cc @bennofs @groxxda 


state: closed
title: grafana: 5.3.4 -> 5.4.0
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/51583
updated_at: 2018-12-11 13:38:25
body:
  ###### Motivation for this change
  [Latest release](https://github.com/grafana/grafana/releases/tag/v5.4.0) which includes various bugfixes, some new features and also a "breaking change" regarding database connection limits.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Successfully ran tests for 86_64-linux and aarch64-linux
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I updated the default for `database.connMaxLifetime` in the module.

  (Note that go still failes to compile grafana on hosts with too many available cores.)


state: open
title: Fail2ban is not adding iptables rules
user_login: kledis
html_url: https://github.com/NixOS/nixpkgs/issues/51584
updated_at: 2019-02-10 13:09:15
body:
  Chain INPUT (policy ACCEPT)
  target     prot opt source               destination         
  ACCEPT     all  --  anywhere             anywhere             state RELATED,ESTABLISHED
  ACCEPT     tcp  --  216.125.0.0/16       anywhere             tcp dpt:ssh
  ACCEPT     tcp  --  168.61.144.36        anywhere             tcp dpt:ssh
  ACCEPT     tcp  --  anywhere             anywhere             tcp dpts:http:https
  ACCEPT     all  --  216.125.0.0/16       anywhere            
  ACCEPT     tcp  --  anywhere             anywhere             tcp dpt:domain
  ACCEPT     udp  --  anywhere             anywhere             udp dpt:domain

  Chain FORWARD (policy ACCEPT)
  target     prot opt source               destination         

  Chain OUTPUT (policy ACCEPT)
  target     prot opt source               destination



  ● fail2ban.service - Fail2ban Service
     Loaded: loaded (/usr/lib/systemd/system/fail2ban.service; enabled; vendor preset: disabled)
     Active: active (running) since Wed 2018-12-05 18:31:32 UTC; 5min ago
    Process: 29002 ExecStop=/usr/bin/fail2ban-client stop (code=exited, status=0/SUCCESS)
    Process: 29007 ExecStart=/usr/bin/fail2ban-client -x start (code=exited, status=0/SUCCESS)
   Main PID: 29011 (fail2ban-server)
     CGroup: /system.slice/fail2ban.service
             └─29011 /bin/python /usr/bin/fail2ban-server --async -b -s /var/run/fail2ban...

  Dec 05 18:31:29 albania systemd[1]: Starting Fail2ban Service...
  Dec 05 18:31:32 albania fail2ban-client[29007]: Server ready
  Dec 05 18:31:32 albania systemd[1]: Started Fail2ban Service.

  Status
  |- Number of jail:	1
  `- Jail list:	sshd


state: closed
title: tradcpp: improved aarch64 support
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/51585
updated_at: 2019-01-22 17:42:08
body:
  ###### Motivation for this change

  Fixes #51578

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-review pr 51585`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: x2goclient: fix build
user_login: averelld
html_url: https://github.com/NixOS/nixpkgs/pull/51586
updated_at: 2018-12-06 18:07:15
body:
  ###### Motivation for this change
  Build has been broken since the libssh 0.7 -> 0.8 upgrade.
  https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.x2goclient.x86_64-linux

  Note that this builds a non-release version, but has the added benefit of getting rid of the qt5 compatibility patch (and is probably preferrable to manually picking more patches to the 4 months old release).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools: Eliminate layer creation copypasta
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/51587
updated_at: 2019-07-03 02:08:37
body:
  ###### Motivation for this change

  See the second commit, as the first commit is in #51528.

  Essentially, there were several places which ran the same exact commands to build a docker layer, and now there is only one copy of that code :)

  I experimented with deduplicating the _image_ creation code, but boy howdy that is for another day.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: autoPatchelfHook: Use alternative interpreters in multilib envs
user_login: tadfisher
html_url: https://github.com/NixOS/nixpkgs/pull/51588
updated_at: 2018-12-06 21:03:21
body:
  ###### Motivation for this change

  `autoPatchelfHook` correctly restricts the architecture of libraries patched into RPATH, but it does not check that the correct dynamic linker is used for INTERP; instead, it always applies the host's native dynamic linker. This can result in 32-bit binaries using `ld-linux-x86-64.so.2` on x86-64 systems, for example.

  ~~This change passes in both the native and 32-bit linkers for the host platform (note that these can be the same depending on the platform). `autoPatchelfFile` then applies the 32-bit linker for ELF32 files, and the native linker otherwise.~~

  This change searches for interpreters in `$NIX_CC/nix-support` that support the architecture of the patched binary. When building in a multilib stdenv, only a matching interpreter will be patched, otherwise the build fails (with an appropriate error message).

  Mixed 32- and 64-bit binaries can now be patched automatically by `autoPatchelfHook` with no manual fixup needed. I tested existing packages (which are not mixed) using `nox-review` on an x86-64 machine, and also by building `nixpkgs.pkgsi686Linux.<pkg>` for the smattering of packages using this hook that build on i686 natively.

  cc @aszlig 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tigervnc: 1.8.0pre2017041 -> 1.9.0
user_login: tilpner
html_url: https://github.com/NixOS/nixpkgs/pull/51589
updated_at: 2018-12-08 22:55:56
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tzdata: 2018e -> 2018g
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/51590
updated_at: 2018-12-05 22:42:51
body:
  ###### Motivation for this change

  #49625 retargeted at staging and changed URLs to fetch over https and without redirects

  Notable changes:
    - Morocco switched to permanent +01 on 2018-10-27
    - Volgograd moved from +03 to +04 on 2018-10-28
    - Fiji ends DST 2019-01-13, not 2019-01-20
    - Most of Chile changes DST dates, effective 2019-04-06

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] tzdata: 2018e -> 2018g
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/51591
updated_at: 2018-12-05 22:43:15
body:
  ###### Motivation for this change
  Backport of #51590

  Notable changes:
    - Morocco switched to permanent +01 on 2018-10-27
    - Volgograd moved from +03 to +04 on 2018-10-28
    - Fiji ends DST 2019-01-13, not 2019-01-20
    - Most of Chile changes DST dates, effective 2019-04-06

  (cherry picked from commit 7c251741548c23ca7f8765a267faefecb0f2ce13)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yed: 3.18.1.1 -> 3.18.2
user_login: yegortimoshenko
html_url: https://github.com/NixOS/nixpkgs/pull/51592
updated_at: 2018-12-07 17:45:39
body:
  ###### Motivation for this change

  Bump yEd, current derivation won't fetch anymore, they removed the src archive.

  Change `requireFile` to `fetchzip` because that's what [Arch Linux](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=yed) does and EULA doesn't seem to prohibit automated downloads.

  cc @orivej 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.flake8-future-import test fails
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/51593
updated_at: 2018-12-06 01:03:46
body:
  ## Issue description

  ```nix-build -A python3Packages.flake8-future-import $(pwd)``` on latest unstable:

  ```
  ======================================================================
  FAIL: test_annotations (test_flake8_future_import.TestFeatures)
  Verify the feature versions.
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/build/source/test_flake8_future_import.py", line 310, in test
      self.assertIn(feat_name, flake8_future_import.FEATURES)
  AssertionError: 'annotations' not found in {'division': Feature(index=0, name='division', optional=(2, 2, 0), mandatory=(3, 0, 0)), 'absolute_import': Feature(index=1, name='absolute_import', optional=(2,
  5, 0), mandatory=(3, 0, 0)), 'with_statement': Feature(index=2, name='with_statement', optional=(2, 5, 0), mandatory=(2, 6, 0)), 'print_function': Feature(index=3, name='print_function', optional=(2, 6, 0), mandatory=(3, 0, 0)), 'unicode_literals': Feature(index=4, name='unicode_literals', optional=(2, 6, 0), mandatory=(3, 0, 0)), 'generator_stop': Feature(index=5, name='generator_stop', optional=(3, 5, 0), mandatory=(3, 7, 0)), 'nested_scopes': Feature(index=6, name='nested_scopes', optional=(2, 1, 0), mandatory=(2, 2, 0)), 'generators': Feature(index=7, name='generators', optional=(2, 2, 0), mandatory=(2,
  3, 0))}

  ----------------------------------------------------------------------
  Ran 15 tests in 0.013s

  FAILED (failures=1, skipped=1)
  Test failed: <unittest.runner.TextTestResult run=15 errors=0 failures=1>
  File "badsyntax_future3" not found.
  File "badsyntax_future4" not found.
  File "badsyntax_future5" not found.
  File "badsyntax_future6" not found.
  File "badsyntax_future7" not found.
  File "badsyntax_future8" not found.
  File "badsyntax_future9" not found.
  File "badsyntax_future10" not found.
  error: Test failed: <unittest.runner.TextTestResult run=15 errors=0 failures=1>
  builder for '/nix/store/0bl7sjyimdsawpnnkvahinr0hmylpzsn-python3.7-flake8-future-import-0.4.5.drv' failed with exit code 1
  error: build of '/nix/store/0bl7sjyimdsawpnnkvahinr0hmylpzsn-python3.7-flake8-future-import-0.4.5.drv' failed
  ```

  Cc: @dotlambda 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.2, NixOS, 19.03.git.89b1f3dc9f9M (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`


state: closed
title: waf: 2.0.10 -> 2.0.13
user_login: bhipple
html_url: https://github.com/NixOS/nixpkgs/pull/51594
updated_at: 2018-12-06 11:04:23
body:
  ###### Motivation for this change
  Upgrading to latest version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform-provider-secret
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/51595
updated_at: 2018-12-06 10:55:54
body:
  ###### Motivation for this change

  Add one more terraform plugin

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: uwsgi service does not include systemd_logger
user_login: GlennS
html_url: https://github.com/NixOS/nixpkgs/issues/51596
updated_at: 2018-12-07 14:59:17
body:
  ## Issue description

  This is probably just a tidying and/or clearing up my confusion issue.

  I notice that the _uwsgi_ package includes an option `withSystemd`, which includes the `"systemd_logger"` plugin. It's not clear if this part is working — it doens't look like `basePlugins` is actually used anywhere. https://github.com/NixOS/nixpkgs/blob/18.09/pkgs/servers/uwsgi/default.nix#L63

  The _uwsgi_ service ignores this option (defaults to `false`), despite it being a systemd service. https://github.com/NixOS/nixpkgs/blob/18.09/nixos/modules/services/web-servers/uwsgi.nix

  `systemd_logger` isn't included as an option in the normal plugins list.

  It **does** look like logging for the uwsgi service is sort-of working. `journalctl -u uwsgi` works. Perhaps journald is just picking these up from stdout/stderr? The actual code for _systemd_logger_ makes it look like it doesn't do anything extra. https://github.com/unbit/uwsgi/blob/3149df02ed443131c54ea6afb29fcbb0ed4d1139/plugins/systemd_logger/systemd_logger.c#L13

  Using NixPkgs 18.09

  ### Steps to reproduce

  N/A

  ## Technical details

  N/A


state: closed
title: heaptrack: wrap GUI for QT plugins
user_login: bhpdt
html_url: https://github.com/NixOS/nixpkgs/pull/51597
updated_at: 2019-07-17 18:58:04
body:
  The `heaptrack_gui` program requires QT plugins. This works if it's included in
  a full install, since QT will search the users' `$PATH` for plugins; however it
  immediately crashes if run in a pure environment.

  This wraps the program to find the given `qtbase` plugins directory without
  requiring an impure installation.

  Related: https://github.com/NixOS/nixpkgs/issues/9680

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.flake8-future-import: fix build on Python 3.7
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/51599
updated_at: 2018-12-06 01:22:22
body:
  ###### Motivation for this change

  Fixes https://github.com/NixOS/nixpkgs/issues/51593

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: extlinux-conf: fix cross compilation
user_login: eburimu
html_url: https://github.com/NixOS/nixpkgs/pull/51600
updated_at: 2018-12-19 17:01:38
body:
  ###### Motivation for this change

  Fxs:
  ```
   9049 Device                                                                                                                                                                                   Boot  Start     End Sectors  Size Id Type
   9050 /nix/store/5aj337b2ww0ccijwipfygwkffhpl1ll0-nixos-sd-image-19.03.git.7a135ae-armv7l-linux.img-armv7l-unknown-linux-gnueabihf/sd-image/nixos-sd-image-19.03.git.7a135ae-armv7l-linux.img1 *     16384  262143  245760  120M  b W95 FAT32
   9051 /nix/store/5aj337b2ww0ccijwipfygwkffhpl1ll0-nixos-sd-image-19.03.git.7a135ae-armv7l-linux.img-armv7l-unknown-linux-gnueabihf/sd-image/nixos-sd-image-19.03.git.7a135ae-armv7l-linux.img2      262144 7146431 6884288  3.3G 83 Linux
   9052 
   9053 The partition table has been altered.
   9054 Syncing disks.
   9055 6859712+0 records in
   9056 6859712+0 records out
   9057 3512172544 bytes (3.5 GB, 3.3 GiB) copied, 98.8709 s, 35.5 MB/s
   9058 mkfs.fat 4.1 (2017-01-24)
   9059 /nix/store/mcnr9b07b2dc4wp1v3d5h0dncbiapx13-extlinux-conf-builder.sh-armv7l-unknown-linux-gnueabihf: line 38: /nix/store/bf2mqh9w16cszj6p0s7xb1fa19j49hj6-coreutils-8.30-armv7l-unknown-linux-gnueabihf/bin/mkdir: cannot execute binary\
         file: Exec format error
   9060 /nix/store/mcnr9b07b2dc4wp1v3d5h0dncbiapx13-extlinux-conf-builder.sh-armv7l-unknown-linux-gnueabihf: line 39: /nix/store/bf2mqh9w16cszj6p0s7xb1fa19j49hj6-coreutils-8.30-armv7l-unknown-linux-gnueabihf/bin/mkdir: cannot execute binary\
         file: Exec format error
   9061 /nix/store/mcnr9b07b2dc4wp1v3d5h0dncbiapx13-extlinux-conf-builder.sh-armv7l-unknown-linux-gnueabihf: line 107: ./boot/extlinux/extlinux.conf.tmp.296: No such file or directory
   9062 /nix/store/mcnr9b07b2dc4wp1v3d5h0dncbiapx13-extlinux-conf-builder.sh-armv7l-unknown-linux-gnueabihf: line 117: ./boot/extlinux/extlinux.conf.tmp.296: No such file or directory
   9063 /nix/store/mcnr9b07b2dc4wp1v3d5h0dncbiapx13-extlinux-conf-builder.sh-armv7l-unknown-linux-gnueabihf: line 132: /nix/store/bf2mqh9w16cszj6p0s7xb1fa19j49hj6-coreutils-8.30-armv7l-unknown-linux-gnueabihf/bin/mv: cannot execute binary f\
        ile: Exec format error
   9064 Copying bootcode.bin

  ```
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fontconfig: fix cross make-fonts-cache & make-fonts-config
user_login: eburimu
html_url: https://github.com/NixOS/nixpkgs/pull/51601
updated_at: 2018-12-08 17:54:23
body:
  ###### Motivation for this change

  Fxs binary dependencies during cross compilation.
  Fixes: #51563

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chromium 71 backport to stable
user_login: bendlas
html_url: https://github.com/NixOS/nixpkgs/issues/51602
updated_at: 2018-12-09 04:13:01
body:
  ## Issue description

  This commit https://github.com/NixOS/nixpkgs/commit/8942a3e00c678102e1412170e44b49aa885cd955 needs to be backported ASAP, since there are lots of CVEs fixed in it. Problem is: We switched the build to clang 7 on master, and clang 7 doesn't seem to be in stable. Can we get clang 7 in stable, somehow, or is it better to keep scraping for gcc patches, until 18.09 is phased out?

  ### Steps to reproduce

  build chromium from that commit, cherry-picked onto `release-18.09` https://github.com/bendlas/nixpkgs/commit/fac4e364eeca71830aaae4a703ba8e2760500897

  ```
  FAILED: obj/components/google/core/common/common/google_util.o
  g++ -MMD -MF obj/components/google/core/common/common/google_util.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -Igen/shim_headers/zlib_shim -Igen/shim_headers/libpng_shim -Igen/shim_headers/libwebp_shim -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -pthread -m64 -march=x86-64 -Wall -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -fno-delete-null-pointer-checks -Wno-comments -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fno-builtin-abs -fvisibility=hidden -I/nix/store/kkczf0s9g04f5sfiwzd7y0f0qj0hkrgw-glib-2.56.0-dev/include/glib-2.0 -I/nix/store/yh447r6mqpa6i047i46bplzii98l3rdy-glib-2.56.0/lib/glib-2.0/include -I/nix/store/ayqlbmkkdaq697gs8xqjzjh0pd8529id-nspr-4.19-dev/include -I/nix/store/vgw83k7p0cr51g1mkh01had81dzqfrbg-nss-3.39-dev/include/nss -std=gnu++14 -Wno-narrowing -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -c ../../components/google/core/common/google_util.cc -o obj/components/google/core/common/common/google_util.o
  ../../components/google/core/common/google_util.cc: In function 'bool google_util::{anonymous}::IsCanonicalHostGoogleHostname(base::StringPiece, google_util::SubdomainPermission)':
  ../../components/google/core/common/google_util.cc:120:24: error: call of overloaded 'NoDestructor(<brace-enclosed initializer list>)' is ambiguous
         {GOOGLE_TLD_LIST});
                          ^
  ```

  Switching back to clang 6 doesn't work either https://github.com/bendlas/nixpkgs/commit/35b18e787d220a55dca2f2f7789ff2601a556c1c
  ```
  [2/586] CXX obj/buildtools/third_party/libc++/libc++/algorithm.o
  FAILED: obj/buildtools/third_party/libc++/libc++/algorithm.o
  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/buildtools/third_party/libc++/libc++/algorithm.o.d -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_OVERRIDABLE_FUNC_VIS=__attribute__\(\(__visibility__\(\"default\"\)\)\) -DLIBCXX_BUILDING_LIBCXXABI -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"344066-1\" -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=332543 -DCR_LIBCXXABI_REVISION=331450 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fstrict-aliasing -fPIC -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted -std=c++14 -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -fexceptions -frtti -c ../../buildtools/third_party/libc++/trunk/src/algorithm.cpp -o obj/buildtools/third_party/libc++/libc++/algorithm.o
  clang++: error: unknown argument: '-fcomplete-member-pointers'
  ```

  @volth @aszlig @YorikSar @domenkozar 

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.2, NixOS, 19.03pre-git (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-15.09.636.8c44b45"`
   - nixpkgs: `/etc/nixos/pkgs`


state: closed
title: pythonPackages.lz4: remove in favor of pythonPackages.python-lz4
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/51603
updated_at: 2018-12-25 16:31:04
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review pr 51603"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @costrouc


state: closed
title: plasma 5.14.4 and plasma-desktop 5.14.4.1
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/51604
updated_at: 2018-12-07 09:34:03
body:
  @bkchr - in case you are doing your usual plasma update, please note that there is a "5.14.4.1" of plasma-desktop where everything else is just "5.14.4".


state: closed
title: atom, atom-beta: Fixing Exec= line in app launcher
user_login: fusion809
html_url: https://github.com/NixOS/nixpkgs/pull/51605
updated_at: 2018-12-06 15:12:07
body:
  Prior to this commit the application launchers of Atom and Atom Beta executed `/usr/bin/${pname}` instead of what they are meant to, `$out/bin/${pname}`. This is because upstream changed the `Exec=` line from `Exec=/usr/share/${pname}/${pname}` to `Exec=/usr/bin/${pname}` and the `substituteInPlace` line that was meant to adjust this line for Nix was not appropriately updated. 

  ###### Motivation for this change
  Application launchers for atom and atom-beta execute `/usr/bin/${pname}` which doesn't exist, so they fail to launch the application. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rambox: 0.6.2 -> 0.6.3
user_login: anpryl
html_url: https://github.com/NixOS/nixpkgs/pull/51607
updated_at: 2018-12-06 10:56:00
body:
  ###### Motivation for this change

  Update to last version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plex: 1.13.9.5456 -> 1.14.0.5470
user_login: tylermauthe
html_url: https://github.com/NixOS/nixpkgs/pull/51608
updated_at: 2018-12-08 18:55:34
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: emacs: make libXcursor available at runtime for non-GTK builds
user_login: benley
html_url: https://github.com/NixOS/nixpkgs/pull/51609
updated_at: 2019-01-17 02:13:23
body:
  ###### Motivation for this change

  libX11 dynamically loads libXcursor at runtime, but only if the loader knows how to find it.  This fixes mouse cursor sizes & themes for X11 emacs builds that do not use GTK.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: octoprint: 1.3.8 -> 1.3.9
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/51610
updated_at: 2018-12-10 13:20:32
body:
  ###### Motivation for this change

  Apart from upgrading octoprint, perform a number of cleanups concerning dependencies and constraints.

  Cc: @abbradar 

  Also add octoprint-mqtt.

  I haven't actually tried all this out yet (tests pass though) as our printer *just* arrived y'day.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.lablgtk3: init at 3.0.beta1
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/51611
updated_at: 2018-12-13 09:09:14
body:
  ###### Motivation for this change

  https://inbox.ocaml.org/caml-list/966B3CBE-29BB-4336-BDBF-0012723E7099@math.nagoya-u.ac.jp/T/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: unit: init at v1.6
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/51612
updated_at: 2018-12-08 16:49:37
body:
  ###### Motivation for this change
  Add dynamic web and application server - nginx unit v1.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: quassel-webserver: fails to build
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/issues/51614
updated_at: 2018-12-08 16:26:45
body:
  ## Issue description


  happens on ae49c73644c05f1eaf8fbd5e88d0971e3dd6a8c5

  ```
  $ nix log /nix/store/n6xg2icz97gq27ikysmfmp6wfxyr7wvy-node-quassel-webserver-2.2.8.drv 
  ```

  -> error log: https://gist.github.com/d2618cdad8994f6cbb531ec8f2b33782


  ### Steps to reproduce

  ```
  $ nix-shell -p nodePackages.quassel-webserver
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.5, NixOS, 19.03.git.ac4a5f6 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"18.03-18.03.133375.e64482df77b, nixos-18.03-18.03.133375.e64482df77b, nur, unstable-18.03.133375.e64482df77b"`
   - channels(joerg): `"home-manager"`
   - nixpkgs: `/home/joerg/git/nixpkgs`

  cc maintainer @uwap


state: closed
title: solc: 0.5.0 -> 0.5.1
user_login: lionello
html_url: https://github.com/NixOS/nixpkgs/pull/51615
updated_at: 2018-12-06 13:19:47
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: meguca: fails to build
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/issues/51616
updated_at: 2018-12-08 16:25:47
body:
  ## Issue description

  build log: https://gist.github.com/Mic92/160e50a5c922d31696a4295253f6775d


  ### Steps to reproduce

  happens on revision ae49c73644c05f1eaf8fbd5e88d0971e3dd6a8c5
  ```
  $ nix-shell -p meguca
  ```

  cc @chiiruno


state: open
title: Support generating DSA-like DH parameters
user_login: Streetwalrus
html_url: https://github.com/NixOS/nixpkgs/issues/51617
updated_at: 2018-12-06 12:55:34
body:
  The service provided in `security.dhparams` is very slow for large bit sizes.
  [This SE answer](https://security.stackexchange.com/a/95184) explains that it's because OpenSSL tries by default to generate a "strong prime" which is very computationally expensive task. It suggests using the `-dsaparam` option which should be equally secure.
  My experience shows that it's orders of magnitude faster (seconds instead of hours), so it would be useful to support that mode, possibly as an option.


state: closed
title: crashplan: mark as broken
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51618
updated_at: 2018-12-07 10:14:41
body:
  the download link no longer works

  ###### Motivation for this change

  cc @xavp

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyflame: also install flame-chart-json
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51619
updated_at: 2018-12-06 14:14:45
body:
  This is useful to use chrome's flamechart viewer.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  cc @symphorien

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gildas: 20181101_a -> 20181201_a
user_login: smaret
html_url: https://github.com/NixOS/nixpkgs/pull/51620
updated_at: 2018-12-07 22:01:34
body:
  ###### Motivation for this change

  Update Gildas package to the latest upstream.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wine{Unstable, Staging}: 3.20 -> 3.21
user_login: ikervagyok
html_url: https://github.com/NixOS/nixpkgs/pull/51621
updated_at: 2018-12-06 14:51:35
body:
  works with wineStagingWow, didn't test other builds

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: home-assistant: 0.82.1 -> 0.83.3
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/51622
updated_at: 2019-03-21 09:32:30
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flashplayer: 31.0.0.153 -> 32.0.0.101 [Critical security fix]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/51623
updated_at: 2019-04-17 02:00:54
body:
  ###### Motivation for this change

  - Critical security fixes
  - Other updates and fixes

  https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html
  https://helpx.adobe.com/security/products/flash-player/apsb18-42.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/openldap: Support configuring the log level
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/51624
updated_at: 2018-12-14 16:04:31
body:
  ###### Motivation for this change

  I wanted to troubleshoot startup problems.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skaffold: 0.18.0 -> 0.19.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/51625
updated_at: 2018-12-07 17:42:38
body:
  Signed-off-by: Vincent Demeester <vincent@sbr.pm>

  ###### Motivation for this change

  Bump to latest release :angel: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix: add binaryTarball derivation
user_login: ju1m
html_url: https://github.com/NixOS/nixpkgs/pull/51626
updated_at: 2019-02-05 21:46:55
body:
  Copy (and adapt a little) the `binaryTarball` derivation found in `nix`'s `release.nix`:
  https://github.com/NixOS/nix/blob/4aee93d5ce6cf77e314e93074b9da1dcff8979e9/release.nix#L115

  `binaryTarball` is useful for cross-compiling `nix`:
  ```
  nix build nixpkgs.pkgsCross.armv7l-hf-multiplatform.nix.binaryTarball
  ```
  Which builds a `result/nix-2.1.3-armv7a-linux.tar.bz2`
  packing an `install` script which will create a nix store
  and most importantly register in it the closure of the `nix` package
  (using `nix-store --load-db`).

  NOTE: the tarball can be quite bigger than expected (~450Mo), mainly because `gcc` is not stripped by default when cross-compiling.

  ###### Motivation for this change
  Cross-compiling `nix` (eg. for ARM) and packing everything needed to install it in a tarball.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: podman: init at 1.0.0
user_login: vdemeester
html_url: https://github.com/NixOS/nixpkgs/pull/51627
updated_at: 2019-01-21 15:25:30
body:
  Signed-off-by: Vincent Demeester <vincent@sbr.pm>

  ###### Motivation for this change

  podman is a binary build from libpod : libpod is a library used to
  create container pods. podman aims to be *almost* compatible with the
  docker cli but doesn't require a docker daemon.

  If it uses a recent `runc` (aka 1.0.0-rc6), it support user namespaces containers (aka `podman run busybox` as a normal user would work :wink:)

  See https://podman.io

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stdenv: add armv7a-linux system
user_login: ju1m
html_url: https://github.com/NixOS/nixpkgs/pull/51628
updated_at: 2019-03-01 20:36:09
body:
  ###### Motivation for this change
  When building `nix` for ARM like this:
  ```
  nix build nixpkgs.pkgsCross.armv7l-hf-multiplatform.nix
  ```
  And installing it on a Cubieboard2, using https://github.com/NixOS/nixpkgs/pull/51626 .
  One gets an `"armv7a-linux"` system, not an `"armv7l-linux"`.
  ```
  % nix-instantiate --eval -E "(import <nixpkgs> {}).system"
  "armv7a-linux"
  ```

  I don't know the difference, nor the meaning of this "a" (maybe "android"?),
  which maybe comes from `armv7l-hf-multiplatform.gcc.arch = "armv7-a"` in  `lib/systems/platforms.nix`.
  This patch treats `"armv7a-linux"` like `"armv7l-linux"` in order to let nixpkgs find `libc` in nixpkgs:
  ```
  % nix-instantiate --eval -E "(import <nixpkgs> {}).stdenv.cc.libc.name"
  "glibc-2.27"
  ```

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update: quicktemplate, nodePackages: meguca, meguca, hydron
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/pull/51629
updated_at: 2018-12-08 17:40:26
body:
  ###### Motivation for this change
  Version bump
  Fixes #51616

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos: Decide and document scope of configuration
user_login: cyounkins
html_url: https://github.com/NixOS/nixpkgs/issues/51630
updated_at: 2019-01-15 21:26:55
body:
  To what degree should configuration be handled in nix?

  We have a number of related issues:
  - Purity in /etc (#3192 #22005)
  - Only a subset of options are exposed in nixpkgs (Compare https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/networking/ssh/sshd.nix and https://linux.die.net/man/5/sshd_config), many GitHub issues created for exposing options (#30475 #33282)
  - Unclear handling of defaults in options (https://github.com/NixOS/nixpkgs/pull/50849#pullrequestreview-176969593)
  - Configurations can depend on `/nix/store` paths (eg systemd unit path to binary, lighthttpd config wants path to perl)

  Some questions:
  - Should we describe configuration options in nixpkgs? All or a subset?
  - Do we generate configuration in Nix then write it out, or attempt to patch a copied config?
  - Can we reasonably make `/etc` readonly?
  - What parts of a system should be mutable? Users? Services? Containers? Passwords? Network?

  Some opinions:
  - Mirroring upstream configuration options is too much maintenance burden, too hard to get right
  - Allow arbitrary configuration options, validating/type checking where possible
  - Implicitly use upstream defaults
  - Services should "do the right thing" by default. Log to systemd journal, put mutable state in correct directories.
  - It should be hard to get into a broken configuration (like bad network config), but it should be easy to get out of one.

  Please post your thoughts and ideas!

  Edit: Removed questions of bootstrapping


state: closed
title: passExtensions.pass-genphrase: init at 0.1
user_login: seqizz
html_url: https://github.com/NixOS/nixpkgs/pull/51631
updated_at: 2018-12-06 21:06:13
body:
  ###### Motivation for this change

  Genphrase extension generates memorable passwords (like [this xkcd example](https://xkcd.com/936/))

  Please check it though, this is my first contribution and I am sure you can find a lot of errors.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rustc: 1.30.1 -> 1.31.0
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/51632
updated_at: 2018-12-12 17:10:06
body:
  ###### Motivation for this change

  - [x] aarch64-linux
  - [x] x86_64-linux
  - [x] x86_64-darwin

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcc: 7.3 -> 7.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/51633
updated_at: 2018-12-29 21:41:03
body:
  https://gcc.gnu.org/gcc-7/changes.html


  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  I'm still testing this for various configurations, so far so good :).

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pylint: 2.1.1 -> 2.2.2
user_login: jokogr
html_url: https://github.com/NixOS/nixpkgs/pull/51634
updated_at: 2018-12-07 12:01:51
body:
  ###### Motivation for this change

  pylint was failing some tests in `master` and thought to update it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vivaldi: hash changed
user_login: greydot
html_url: https://github.com/NixOS/nixpkgs/issues/51635
updated_at: 2018-12-07 08:48:07
body:
  ## Issue description
  This probably isn't a strictly NixOS issue, but nevertheless should be mentioned.
  The hash for vivaldi-stable_2.1.1337.51-1 has changed. The old one in nixpkgs is 08x6abyz65vx4ycj8ys8sib9z1adb8ybmnrqjck69b30kbz78rj2, while nix-env reports 00rxp6rardxjg17g2b28y2rj8szqlainp4ga6c58z981zkxvdlls.


  ### Steps to reproduce
  1. Switch to unstable channels.
  2. nix-env -i vivaldi


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.85, NixOS, 19.03pre161545.7c73f53d836 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(void): `"nixpkgs-19.03pre160749.3a393eecafb"`
   - channels(root): `"nixos-19.03pre161545.7c73f53d836, nixpkgs-19.03pre160749.3a393eecafb"`
   - nixpkgs: `/home/void/.nix-defexpr/channels/nixpkgs`


state: closed
title: jenkins: 2.138.3 -> 2.150.1
user_login: bchallenor
html_url: https://github.com/NixOS/nixpkgs/pull/51636
updated_at: 2018-12-06 21:17:49
body:
  ###### Motivation for this change
  Multiple security vulnerabilities in Jenkins 2.153 and earlier, and LTS 2.138.3 and earlier.

  https://jenkins.io/security/advisory/2018-12-05/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitwarden-cli: init at 1.6.0
user_login: Wolfereign
html_url: https://github.com/NixOS/nixpkgs/pull/51637
updated_at: 2018-12-10 19:33:48
body:
  ###### Motivation for this change
  Make the bitwarden cli client available to nix/nixos. https://github.com/NixOS/nixpkgs/issues/51212

  ###### Things done
  - added "pkgs/tools/security/bitwarden-cli/default.nix"
  - updated all-packages.nix to include bitwarden-cli
  - added myself to the maintainer list as "wolfereign"

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: btrfs-progs: 4.19 -> 4.19.1
user_login: spencerjanssen
html_url: https://github.com/NixOS/nixpkgs/pull/51638
updated_at: 2018-12-06 22:11:56
body:
  ###### Motivation for this change

  Snapper fails to build with btrfs-progs 4.19.  See openSUSE/snapper#459 and https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg82954.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)).  Ran nixos/tests/snapper.nix
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.vimux: init at 2017-10-24
user_login: twitchard
html_url: https://github.com/NixOS/nixpkgs/pull/51639
updated_at: 2018-12-12 19:58:40
body:
  ###### Motivation for this change
  This is a pretty cool vim plugin

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tectonic: 0.1.9 -> 0.1.11
user_login: das-g
html_url: https://github.com/NixOS/nixpkgs/pull/51640
updated_at: 2018-12-07 14:15:27
body:
  ###### Motivation for this change

  - handles unicode filenames correctly (since [0.1.10](https://github.com/tectonic-typesetting/tectonic/blob/v0.1.11/CHANGELOG.md#0110-2018-sep-28))
  - switch to hopefully more reliable permantent URL for the default bundle (in [0.1.11](https://github.com/tectonic-typesetting/tectonic/blob/v0.1.11/CHANGELOG.md#0111-2018-nov-5))

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  /cc @lluchs


state: closed
title: Allow skipping the use of the PYTHONNOUSERSITE variable
user_login: thomasjm
html_url: https://github.com/NixOS/nixpkgs/pull/51641
updated_at: 2019-05-14 16:39:45
body:
  ###### Motivation for this change

  By default, Nix-installed Python binaries use the `PYTHONNOUSERSITE` variable (see [here](https://docs.python.org/2/using/cmdline.html#envvar-PYTHONNOUSERSITE)) to prevent Python from looking for packages in the user's site-packages directory.

  I wanted to be able to install a Python installation that is slightly impure, so that you can run `pip install --user some_package` and then use the resulting package. This is convenient when you want to set up an environment where the user either can't install new Python packages via Nix, or would prefer to use `pip` directly (for example, if a package version isn't available on Nix).

  So, this PR introduces a flag `skipNoUserSite` that can be used to disable the `PYTHONNOUSERSITE` setting when needed. The change happens in two places:

  1) `pkgs/development/interpreters/python/mk-python-derivation.nix` and `pkgs/development/interpreters/python/wrap.sh`: the change here allows you to disable `PYTHONNOUSERSITE` for individual Python **packages**, i.e. those built by `buildPythonPackage`.
  2) `pkgs/development/interpreters/python/wrapper.nix`: the change here allows you to disable `PYTHONNOUSERSITE` for Python **environments**, i.e. those created by `python.withPackages`. It causes every wrapped binary inside the environment to be user site-packages aware.

  This flag is purely opt-in, so hopefully it's okay to add a little impurity for this use case :)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: erlang: disable parallel building
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/51644
updated_at: 2018-12-08 16:40:39
body:
  ###### Motivation for this change

  All of the Erlang runtimes fail to build on my Hydra with parallel building enabled (implemented in #45484).  The same problem [was observed on an official Hydra machine](https://github.com/NixOS/nixpkgs/pull/47371#issuecomment-425014401) ([and again](https://github.com/NixOS/nixpkgs/pull/47369#issuecomment-424998726)), but ignored as a temporary issue.

  This PR disables parallel building to avoid this build failure.

  ```
  <3> ERLC   ../ebin/asn1ct_gen_ber_bin_v2.beam
  <3> ERLC   ../ebin/asn1ct_rtt.beam
  <3> ERLC   ../ebin/asn1ct_constructed_ber_bin_v2.beam
  <3> GEN    asn1ct_eval_ext.erl
  <3>{"init terminating in do_boot",{undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{file,"prepare_templates.erl"},{line,58}]},{init,start_it,1,[]},{init,start_em,1,[]}]}}
  <3>init terminating in do_boot ()
  <3>
  <3>Crash dump is being written to: erl_crash.dump...done
  <3>make[2]: *** [Makefile:139: asn1ct_eval_ext.erl] Error 1
  <3>make[2]: Leaving directory '/build/source/lib/asn1/src'
  <3>make[1]: *** [/build/source/make/otp_subdir.mk:29: opt] Error 2
  <3>make[1]: Leaving directory '/build/source/lib'
  <3>make: *** [Makefile:550: secondary_bootstrap_build] Error 2
  <3>builder for '/nix/store/5565imavv7imy514fycp2r1qi61qx2m6-erlang-18.3.4.8.drv' failed with exit code 2
  ```

  ```
  <3> ERLC   ../ebin/asn1ct_gen_ber_bin_v2.beam
  <3> ERLC   ../ebin/asn1ct_rtt.beam
  <3> ERLC   ../ebin/asn1ct_constructed_ber_bin_v2.beam
  <3> GEN    asn1ct_eval_ext.erl
  <3>{"init terminating in do_boot",{undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{file,"prepare_templates.erl"},{line,58}]},{init,start_em,1,[]},{init,do_boot,3,[]}]}}
  <3>init terminating in do_boot ()
  <3>
  <3>Crash dump is being written to: erl_crash.dump...done
  <3>make[2]: *** [Makefile:139: asn1ct_eval_ext.erl] Error 1
  <3>make[2]: Leaving directory '/build/source/lib/asn1/src'
  <3>make[1]: *** [/build/source/make/otp_subdir.mk:29: opt] Error 2
  <3>make[1]: Leaving directory '/build/source/lib'
  <3>make: *** [Makefile:550: secondary_bootstrap_build] Error 2
  <3>builder for '/nix/store/sd9kp905syyfqb7gczrp3qpzxvhvl1pj-erlang-19.3.6.11.drv' failed with exit code 2
  ```

  ```
  <3> ERLC   ../ebin/asn1ct_gen_ber_bin_v2.beam
  <3> ERLC   ../ebin/asn1ct_rtt.beam
  <3> ERLC   ../ebin/asn1ct_constructed_ber_bin_v2.beam
  <3> GEN    asn1ct_eval_ext.erl
  <3>{"init terminating in do_boot",{undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{file,"prepare_templates.erl"},{line,58}]},{init,start_em,1,[]},{init,do_boot,3,[]}]}}
  <3>init terminating in do_boot ({undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{_},{_}]},{init,start_em,1,[]},{init,do_boot,3,[]}]})
  <3>
  <3>Crash dump is being written to: erl_crash.dump...done
  <3>make[2]: *** [Makefile:138: asn1ct_eval_ext.erl] Error 1
  <3>make[2]: Leaving directory '/build/source/lib/asn1/src'
  <3>make[1]: *** [/build/source/make/otp_subdir.mk:29: opt] Error 2
  <3>make[1]: Leaving directory '/build/source/lib'
  <3>make: *** [Makefile:557: secondary_bootstrap_build] Error 2
  <3>builder for '/nix/store/2dq6bp93q788bnz4gbbhhiyzrpgh38nz-erlang-20.3.8.9.drv' failed with exit code 2
  ```

  ```
  <3> ERLC   ../ebin/asn1ct_gen_ber_bin_v2.beam
  <3> ERLC   ../ebin/asn1ct_rtt.beam
  <3> ERLC   ../ebin/asn1ct_constructed_ber_bin_v2.beam
  <3> GEN    asn1ct_eval_ext.erl
  <3>{"init terminating in do_boot",{undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{file,"prepare_templates.erl"},{line,58}]},{init,start_em,1,[]},{init,do_boot,3,[]}]}}
  <3>init terminating in do_boot ({undef,[{asn1ct_func,start_link,[],[]},{prepare_templates,gen_asn1ct_eval,1,[{_},{_}]},{init,start_em,1,[]},{init,do_boot,3,[]}]})
  <3>
  <3>Crash dump is being written to: erl_crash.dump...done
  <3>make[2]: *** [Makefile:138: asn1ct_eval_ext.erl] Error 1
  <3>make[2]: Leaving directory '/build/source/lib/asn1/src'
  <3>make[1]: *** [/build/source/make/otp_subdir.mk:29: opt] Error 2
  <3>make[1]: Leaving directory '/build/source/lib'
  <3>make: *** [Makefile:575: secondary_bootstrap_build] Error 2
  <3>builder for '/nix/store/f9h1xf6k0sjri4h0wkgx28b5z1xwxqkw-erlang-21.1.3.drv' failed with exit code 2
  ```

  I don't know why these builds succeed elsewhere, but they fail reliably on my 8 core/16 thread Intel(R) Xeon(R) W-2145 CPU @ 3.70GHz with a NixOS (4.19.7 kernel, btrfs) in VMware on a Windows 10 1803 host.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: sbcl sb-concurrency tests sometimes fail
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/issues/51645
updated_at: 2018-12-07 02:06:38
body:
  ## Issue description

  sbcl's sb-concurrency tests sometimes fail. This was discussed in #42826 but not fixed (I doubt "1.4.10 seems to lack this problem" is true, because the issue is present in 1.4.13.)

  full log: [4rkx16znsdyvyhkf3r4phcydxw67kg1y-sbcl-1.4.13.drv.txt](https://github.com/NixOS/nixpkgs/files/2655608/4rkx16znsdyvyhkf3r4phcydxw67kg1y-sbcl-1.4.13.drv.txt)

  relevant failure:

  ```
  <3>Doing 25 pending tests of 25 tests total.
  <3>Test SB-CONCURRENCY-TEST::FRLOCK.1 failed
  <3>Form: (HANDLER-CASE
  <3>       (WITH-TIMEOUT 10
  <3>         (SB-CONCURRENCY-TEST::TEST-FRLOCKS))
  <3>       (TIMEOUT (SB-CONCURRENCY-TEST::C) (ERROR "~A" SB-CONCURRENCY-TEST::C)))
  <3>Expected values: NIL
  <3>                 NIL
  <3>Actual value: #<SIMPLE-ERROR "~A" {1003F20CE3}>.
  <3> SB-CONCURRENCY-TEST::QUEUE.1 SB-CONCURRENCY-TEST::QUEUE.2
  <3> SB-CONCURRENCY-TEST::QUEUE.3 SB-CONCURRENCY-TEST::QUEUE.4
  <3> SB-CONCURRENCY-TEST::QUEUE.5 SB-CONCURRENCY-TEST::QUEUE.T.1
  <3> SB-CONCURRENCY-TEST::QUEUE.T.2 SB-CONCURRENCY-TEST::QUEUE.T.3
  <3> SB-CONCURRENCY-TEST::MAILBOX-TRIVIA.1 SB-CONCURRENCY-TEST::MAILBOX-TRIVIA.2
  <3> SB-CONCURRENCY-TEST::MAILBOX-TRIVIA.3 SB-CONCURRENCY-TEST::MAILBOX-TIMEOUTS
  <3> SB-CONCURRENCY-TEST::MAILBOX.SINGLE-PRODUCER-SINGLE-CONSUMER
  <3> SB-CONCURRENCY-TEST::MAILBOX.SINGLE-PRODUCER-MULTIPLE-CONSUMERS
  <3> SB-CONCURRENCY-TEST::MAILBOX.MULTIPLE-PRODUCERS-SINGLE-CONSUMER
  <3> SB-CONCURRENCY-TEST::MAILBOX.MULTIPLE-PRODUCERS-MULTIPLE-CONSUMERS
  <3> SB-CONCURRENCY-TEST::MAILBOX.INTERRUPTS-SAFETY.1 SB-CONCURRENCY-TEST::GATE.0
  <3> SB-CONCURRENCY-TEST::GATE.1 SB-CONCURRENCY-TEST::GATE.2
  <3> SB-CONCURRENCY-TEST::GATE-DEADLINE.1 SB-CONCURRENCY-TEST::GATE-DEADLINE.2
  <3> SB-CONCURRENCY-TEST::GATE-TIMEOUT.1 SB-CONCURRENCY-TEST::GATE-TIMEOUT.2
  <3>1 out of 25 total tests failed: SB-CONCURRENCY-TEST::FRLOCK.1.
  <3>WARNING: ignoring expected failures in test-op
  <3>Unhandled SIMPLE-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
  <3>                                    {10005185B3}>:
  <3>  test-op failed with unexpected failures
  <3>
  <3>Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10005185B3}>
  <3>0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #<SIMPLE-ERROR "test-op failed with unexpected failures" {10064064A3}> #<unused argument> :QUIT T)
  <3>1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #<SIMPLE-ERROR "test-op failed with unexpected failures" {10064064A3}>)
  <3>2: (INVOKE-DEBUGGER #<SIMPLE-ERROR "test-op failed with unexpected failures" {10064064A3}>)
  <3>3: (ERROR "test-op failed with unexpected failures")
  <3>4: ((:METHOD ASDF/ACTION:PERFORM (ASDF/LISP-ACTION:TEST-OP (EQL (ASDF/SYSTEM:FIND-SYSTEM "sb-concurrency/tests")))) #<unused argument> #<unused argument>) [fast-method]
  <3>5: ((SB-PCL::EMF ASDF/ACTION:PERFORM) #<unused argument> #<unused argument> #<ASDF/LISP-ACTION:TEST-OP > #<ASDF/SYSTEM:SYSTEM "sb-concurrency/tests">)
  <3>6: ((LAMBDA NIL :IN ASDF/ACTION:CALL-WHILE-VISITING-ACTION))
  <3>7: ((:METHOD ASDF/ACTION:PERFORM-WITH-RESTARTS :AROUND (T T)) #<ASDF/LISP-ACTION:TEST-OP > #<ASDF/SYSTEM:SYSTEM "sb-concurrency/tests">) [fast-method]
  <3>8: ((:METHOD ASDF/PLAN:PERFORM-PLAN (T)) #<ASDF/PLAN:SEQUENTIAL-PLAN {1001FCDCD3}>) [fast-method]
  <3>9: ((FLET SB-C::WITH-IT :IN SB-C::%WITH-COMPILATION-UNIT))
  <3>10: ((:METHOD ASDF/PLAN:PERFORM-PLAN :AROUND (T)) #<ASDF/PLAN:SEQUENTIAL-PLAN {1001FCDCD3}>) [fast-method]
  <3>11: ((:METHOD ASDF/OPERATE:OPERATE (ASDF/OPERATION:OPERATION ASDF/COMPONENT:COMPONENT)) #<ASDF/LISP-ACTION:TEST-OP > #<ASDF/SYSTEM:SYSTEM "sb-concurrency"> :PLAN-CLASS NIL :PLAN-OPTIONS NIL) [fast-method]
  <3>12: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) #<unused argument> #<unused argument> #<ASDF/LISP-ACTION:TEST-OP > #<ASDF/SYSTEM:SYSTEM "sb-concurrency">)
  <3>13: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
  <3>14: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) #<ASDF/LISP-ACTION:TEST-OP > #<ASDF/SYSTEM:SYSTEM "sb-concurrency">) [fast-method]
  <3>15: ((SB-PCL::EMF ASDF/OPERATE:OPERATE) #<unused argument> #<unused argument> ASDF/LISP-ACTION:TEST-OP "sb-concurrency")
  <3>16: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
  <3>17: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:TEST-OP "sb-concurrency") [fast-method]
  <3>18: (ASDF/SESSION:CALL-WITH-ASDF-SESSION #<CLOSURE (LAMBDA NIL :IN ASDF/OPERATE:OPERATE) {1004B7813B}> :OVERRIDE T :KEY NIL :OVERRIDE-CACHE T :OVERRIDE-FORCING NIL)
  <3>19: ((LAMBDA NIL :IN ASDF/OPERATE:OPERATE))
  <3>20: (ASDF/SESSION:CALL-WITH-ASDF-SESSION #<CLOSURE (LAMBDA NIL :IN ASDF/OPERATE:OPERATE) {10037FCAFB}> :OVERRIDE NIL :KEY NIL :OVERRIDE-CACHE NIL :OVERRIDE-FORCING NIL)
  <3>21: ((:METHOD ASDF/OPERATE:OPERATE :AROUND (T T)) ASDF/LISP-ACTION:TEST-OP "sb-concurrency") [fast-method]
  <3>22: (ASDF/OPERATE:TEST-SYSTEM "sb-concurrency")
  <3>23: (SB-INT:SIMPLE-EVAL-IN-LEXENV (ASDF/INTERFACE::TEST-ASDF-CONTRIB "sb-concurrency") #<NULL-LEXENV>)
  <3>24: (EVAL (ASDF/INTERFACE::TEST-ASDF-CONTRIB "sb-concurrency"))
  <3>25: (SB-IMPL::PROCESS-EVAL/LOAD-OPTIONS ((:LOAD . "../asdf-stub.lisp") (:EVAL . "(asdf::test-asdf-contrib \"sb-concurrency\")")))
  <3>26: (SB-IMPL::TOPLEVEL-INIT)
  <3>27: ((FLET SB-UNIX::BODY :IN SAVE-LISP-AND-DIE))
  <3>28: ((FLET "WITHOUT-INTERRUPTS-BODY-27" :IN SAVE-LISP-AND-DIE))
  <3>29: ((LABELS SB-IMPL::RESTART-LISP :IN SAVE-LISP-AND-DIE))
  <3>
  <3>unhandled condition in --disable-debugger mode, quitting
  <3>;
  <3>; compilation unit aborted
  <3>;   caught 1 fatal ERROR condition
  <3>make: *** [../asdf-module.mk:41: test] Error 1
  <3>make: Leaving directory '/build/sbcl-1.4.13/contrib/sb-concurrency'
  ```

  ```
  <3>WARNING! Some of the contrib modules did not build successfully or pass
  <3>their self-tests. Failed contribs:"
  <3>  sb-concurrency
  <3>
  ```

  ### Steps to reproduce

  Run a build of sbcl-1.4.13 on a busy Hydra machine and hope that the tests fail.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  # nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.7, NixOS, 19.03.git.3f179d2 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `""`
   - nixpkgs: `/var/nixpkgs`
  ```


state: closed
title: vivaldi: correct hash
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/51646
updated_at: 2018-12-07 11:03:00
body:
  ###### Motivation for this change
  Fixes #51635

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: binutils: drop the dtneeded.patch?
user_login: pbogdan
html_url: https://github.com/NixOS/nixpkgs/issues/51647
updated_at: 2018-12-28 11:08:16
body:
  ## Issue description

  Nixpkgs appears to patch `binutils` so that the linker uses the `--copy-dt-needed-entries` option by default. This seems to have the effect of the linker being able to resolve dependencies via anything in the transitive dependencies chain. While that may work at build time it doesn't seem to work at run time as unless the dependency is declared explicitly Nix / nixpkgs ensures the dynamic loader won't be able to see it.
  Conceptually `--no-copy-dt-needed-entries` behaviour seems closer to what would be the desired behaviour in Nix / nixpkgs. At the same time I don't have a great deal of understanding here so I may well be wrong. Just opening this issue for discussion as I would like to hear others' opinions and clear up my own misunderstandings.

  ### Steps to reproduce

  Consider the following test program that references a symbol exported by `libgssapi_krb5` shared library:

  ```C
  char gss_krb5_ccache_name ();
  int main ()
  {
      return gss_krb5_ccache_name ();
      return 0;
  }
  ```

  Build it but _don't link it_ against said library but something that has it in its transitive dependency chain:

  ```
  $  gcc test.c -o test -Wl,--copy-dt-needed-entries -lldap_r
  ```

  Observe the compilation succeeding but resulting in a runtime failure:

  ```
  $ ./test: error while loading shared libraries: libgssapi_krb5.so.2: cannot open shared object file: No such file or directory
  ```

  Now build the same program using `--no-copy-dt-needed-entries` linker option:

  ```
  $ gcc test.c -o test -Wl,--no-copy-dt-needed-entries -lldap_r
  /nix/store/ihi9rhwq22y92p9iay1mdvy0lr75wdh2-binutils-2.30/bin/ld: /run/user/1000/cc90p4Wk.o: undefined reference to symbol 'gss_krb5_ccache_name@@gssapi_krb5_2_MIT'
  /nix/store/hr82iai25rdkgkgx7n1hv3p311hs1141-libkrb5-1.15.2/lib/libgssapi_krb5.so.2: error adding symbols: DSO missing from command line
  collect2: error: ld returned 1 exit status
  ```

  ## Technical details

  Affects `binutils` on master, reproducer based on `staging-next`.


state: open
title: noOverflow: An effort to fight integer overflow for security and correctness
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/51649
updated_at: 2018-12-09 13:28:05
body:
  This is an overflow issue coordinating and summarising multiple activities.

  ## Goal

  To build a hardened nixpkgs overlay in which integer overflow is forbidden and fails loudly.

  Fix as many packages as possible and submit as many fixes upstream as possible.

  ## Rationale

  Accidental integer overflow has been a security and correctness nightmare for ages, and is becoming ever more frequent.

  If we continue like this, humanity isn't going to make it far. :rocket: :boom: 

  New programming languages like Rust already improve a lot on this by making all non-explicit integer overflows hard errors -- at least during developer (non-release) builds and runs.

  But this is not enough: Even modern programming languages rely on many existing, older libraries (written e.g. in C) and some very modern and otherwise safe programming languages default to programmers throwing around non-explicit integer conversion constructs (like Haskell's `fromIntegral`, which has caused many bugs).

  We strive to find and fix non-explicit overflow and make the results available.

  We hope that nixpkgs' advanced tooling, programmable package set, and ease-of-community-contribution will make this feasible.

  ## People interested

  @nh2 @dtzWill 

  Add yourself here or ping to be added, or subscribe.

  ## Useful terms

  * **narrowing:** converting a numeric type into one that has smaller domain (not all values fit into the target type), like `64-bit int -> 32-bit int`

  # Items

  Build an overlay to provide:

  * Compilers overridden to emit as many overflow-related warnings as possible
    * [ ] gcc
    * [ ] clang
  * C
    * [ ] Add compiler flags (or write compiler patch) that turn integer overflow into runtime panic
    * [ ] Build and test as much of nixpkgs as possible with it, add patches or exceptions on the way
  * Haskell
    * [ ] Ensure that integer primops that error out on overflow, and those that explicitly allow it, are implemented
    * [ ] Write GHC option or patch that enables them
    * [ ] Build and test as much of `haskellPackages` (or the Stackage subset) as possible with it, add patches or exceptions on the way
  * Rust
    * [ ] Enable overflow checking also in release mode

  This list will get updated as progress is made.

  You can add items here or ask for them to be added in the discussion below.


state: closed
title: cyrus-sasl: Remove private libs from .la files (fixes spice build)
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/51651
updated_at: 2018-12-08 17:25:24
body:
  ###### Motivation for this change

  Version 2.1.27 added the private libs to a bunch of .la files, which in turn
  broke spice's build, https://github.com/NixOS/nixpkgs/pull/51444#issuecomment-444499394

  A cleaner approach would be to just remove the .la files, but I'm unsure if
  that will break anything else.

  cc #51444 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: systrayhelper: 0.0.4 -> 0.0.5
user_login: cryptix
html_url: https://github.com/NixOS/nixpkgs/pull/51652
updated_at: 2019-05-11 21:33:31
body:
  ###### Motivation for this change

  updates to the latest release v0.0.5 which includes some fixes and dependency updates.

  also includes a checkPhase using xvfb_run to spawn go test, which starts i3 and the helper and then uses xdotool to send clicks back to the helper

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libopusenc: init at 0.2.1
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/pull/51654
updated_at: 2018-12-07 13:11:04
body:
  ###### Motivation for this change

  The package was missing and is needed by a newer version of `pyogg`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Bundix is broken on master
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/issues/51656
updated_at: 2018-12-07 16:49:34
body:
  Since 798a2a6c97ff2251dd2796e8fd1b248d704296ba.

  See https://github.com/manveru/bundix/pull/38.

  Just opening an issue here as well for visibility in case anybody else encounters the same issue.


state: open
title: Using `buildOcaml` in `nix-shell` results in error about mkdir
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/51658
updated_at: 2018-12-15 04:13:05
body:
  ## Issue description

  I tried using `buildOcaml` from `ocaml-ng.ocamlPackages_4_07` and when running `nix-shell` it gave me an error about:

  ```
  mkdir: cannot create directory '/nix/store/7mmv0hk8r13vlm8vp88qzl0dkwpppzm8-ocaml-OCaml-Demo-0.0.1': Read-only file system
  ```

  ### Steps to reproduce

  ```
  pkgs.ocaml-ng.ocamlPackages_4_07.buildOcaml {
    name = "OCaml-Demo";
    version = "0.0.1";
    src = null;
  }
  ```

  It appears due to the way `ocamlPackages.findlib` is trying to create some find lib destination directory when `createFindlibDestdir = true;`.


state: closed
title: bundix: 2.4.0 -> 2.4.1
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/51660
updated_at: 2018-12-07 17:09:42
body:
  ###### Motivation for this change

  fixes #51656

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: test: set machines fqdn in /etc/hosts
user_login: eonpatapon
html_url: https://github.com/NixOS/nixpkgs/pull/51661
updated_at: 2019-01-12 19:41:14
body:
  ###### Motivation for this change

  The contents in `/etc/hosts` should follow the format `<ip> <fqdn> [<alias>, ...]`

  IMO, if a domain is configured for the machine, `machine.domain` should be resolvable and not just `machine`.

  It also help in test cases with multiple VMs where applications are using fqdn name to talk to each other.

  I don't think this change will have some impact on existing tests but to be sure it would require to run them all. (not sure how to do that either) WDYT ?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zoom-us: 2.5.146186.1130 -> 2.6.146750.1204
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/51662
updated_at: 2018-12-08 18:28:49
body:
  ###### Motivation for this change
  Regular version bump

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.cytoolz: fix build
user_login: erictapen
html_url: https://github.com/NixOS/nixpkgs/pull/51663
updated_at: 2018-12-12 06:48:47
body:
  cytoolz has a [test failure with Python 3.7](https://github.com/pytoolz/cytoolz/issues/122). There is a [debian patch](https://salsa.debian.org/python-team/modules/python-cytoolz/blob/master/debian/patches/py37.patch) for it, which didn't make it into upstream yet.

  ###### Motivation for this change

  `python3Packages.cytoolz` does not build on `master`.

  ###### Things done

  Apply the patch from debian.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.tlslite-ng: init at 0.7.5, migrate tlslite references to it, delete tlslite
user_login: erictapen
html_url: https://github.com/NixOS/nixpkgs/pull/51664
updated_at: 2018-12-10 13:03:28
body:
  ###### Motivation for this change

  `pythonPackages.tlslite` has a [test failure](https://github.com/trevp/tlslite/issues/121) on Python 3.7. @tomato42, a commiter of tlslite and author of [tlslite-ng](https://github.com/tomato42/tlslite-ng) said, that tlslite is abandoned (last commit 2015) and tlslite-ng should be used as a drop in replacement.

  As it doesn't seem to be adopted widely, I believe that it is suitable to mark `tlslite` as broken. `tlslite-ng` can be dropped-in without much of a hassle.

  ###### Things done

  - Init `pythonPackages.tlslite-ng`
  - Mark `tlslite` as broken
  - Migrate all occurences of `tlslite` to `tlslite-ng`.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opusTools: 0.1.10 -> 0.2
user_login: pmiddend
html_url: https://github.com/NixOS/nixpkgs/pull/51665
updated_at: 2018-12-07 17:42:53
body:
  ###### Motivation for this change

  Now that `libopusenc` is in nixpkgs, we can upgrade opus-tools, too!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: todoman: 3.4.1 -> 3.5.0
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/51667
updated_at: 2018-12-07 17:20:26
body:
  ###### Motivation for this change

  Updating package to latest stable release.

  CC: @leenaars (package maintainer)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3 captures references to build coreutils
user_login: joachifm
html_url: https://github.com/NixOS/nixpkgs/issues/51668
updated_at: 2018-12-26 13:38:46
body:
  Things like install prog, mv, and friends used during config are captured.

  Eliminated via
  ```
  find $out/lib/python*/config-*-* -type f -print -exec nuke-refs '{}' +
  find $out/lib -name '_sysconfigdata_m*.py*' -print -exec nuke-refs '{}' +
  ```
  but I'm sure that's too heavy handed.

  For me, the above nuking also "fixes" https://github.com/NixOS/nixpkgs/issues/51465


