# issues

state: closed
title: cocoapods-beta: 1.7.0.beta.3 -> 1.7.0.rc.1
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/60802
updated_at: 2019-05-07 17:47:40
body:
  ###### Motivation for this change
  https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.0.rc.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: teamviewer: 14.2.2558 -> 14.2.8352
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60803
updated_at: 2019-06-10 10:10:10
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/teamviewer/versions.



  meta.description for teamviewer is: '"Desktop sharing application, providing remote support and online meetings"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 14.2.8352 with grep in /nix/store/mh1k4ycsly1mbiajdm7wmm7am0n9rwmn-teamviewer-14.2.8352
  - directory tree listing: https://gist.github.com/a83b69d974408b6fc10b5af9d2378d20
  - du listing: https://gist.github.com/d5f7dd89a1f90b4e24c981b995c57139

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  0 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  0 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  teamviewer

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/mh1k4ycsly1mbiajdm7wmm7am0n9rwmn-teamviewer-14.2.8352 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A teamviewer https://github.com/r-ryantm/nixpkgs/archive/092cfde875bf9fcc768d44154e83265e75d010cc.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/mh1k4ycsly1mbiajdm7wmm7am0n9rwmn-teamviewer-14.2.8352
  ls -la /nix/store/mh1k4ycsly1mbiajdm7wmm7am0n9rwmn-teamviewer-14.2.8352/bin
  ```


  </details>
  <br/>


  cc @jagajaga for testing.


state: open
title: light: support brightness control keys
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/60804
updated_at: 2019-05-03 23:27:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Motivation for this change

  `light` is a great program for managing display brightness. This pull request maps the brightness control keys in keyboards to commands for `light`. There are a few reasons:

  - Minimalistic desktop environments (e.g., i3) don't have built-in configuration for the keys. This configuration works for those without any need for configuration on the desktop/window manager side.

  - As far as I understand, KDE/GNOME/etc do handle the brightness keys, but then the brightness keys don't work in non-X ttys. This configuration makes the buttons work also in non-X ttys.

  - At least KDE has a "bug" that the brightness can be put to zero which causes the display to go totally black. In my opinion, the screen brightness shouldn't be allowed to go that low, because there are separate buttons/actions to turn on/off the display. So, this configuration uses a minimum brightness of 0.1 to avoid this issue.

  This configuration is similar to `sound.mediaKeys`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rednose: disable test suite
user_login: nixbitcoin
html_url: https://github.com/NixOS/nixpkgs/pull/60805
updated_at: 2019-05-04 06:06:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Building nixops fails because the python test suite gets stuck. The test suite had previously been disabled for Darwin because of a similar error. So now I disabled it entirely because I was also getting an error on a Debian Linux system.

  Fixes #60786

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tortoisehg: 4.9 -> 4.9.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60806
updated_at: 2019-05-11 03:02:56
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tortoisehg/versions.



  meta.description for tortoisehg is: '"Qt based graphical tool for working with Mercurial"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 4.9.1 with grep in /nix/store/72wfnsl1zn7fshzx3qc8yhv0284kh3ip-tortoisehg-4.9.1
  - directory tree listing: https://gist.github.com/e365d0a876441f72aad0ecdecfae8f3f
  - du listing: https://gist.github.com/fab97441e63976a567e6aab370d5425d

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  tortoisehg

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/72wfnsl1zn7fshzx3qc8yhv0284kh3ip-tortoisehg-4.9.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A tortoisehg https://github.com/r-ryantm/nixpkgs/archive/a801f81b0db0001a2f9ca0cb949731badda4e1ea.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/72wfnsl1zn7fshzx3qc8yhv0284kh3ip-tortoisehg-4.9.1
  ls -la /nix/store/72wfnsl1zn7fshzx3qc8yhv0284kh3ip-tortoisehg-4.9.1/bin
  ```


  </details>
  <br/>


  cc @danbst for testing.


state: closed
title: sublimetext3 fails to run
user_login: neilmayhew
html_url: https://github.com/NixOS/nixpkgs/issues/60807
updated_at: 2019-05-10 12:27:22
body:
  ## Issue description

  The `sublime3` executable fails soon after startup with messages about symbols and libraries it cannot load.

  However, these are libraries loaded with `dlopen` because it is able to output some text when run with `--version`.

  Using `git bisect` shows that it broke starting with commit 90f3a237eb51d7e3173f1502d468e99ff777d1b9 and this change seems to be interfering with Sublime's use of `dlopen`.

  ### Steps to reproduce

  ```shellsession
  $ sublime --version
  Unable to load cairo_clip from libcairo.so
  ...
  Unable to load pango_font_description_free from libpango-1.0.so
  ...
  Unable to load g_file_new_for_uri from libgio-2.0.so
  Sublime Text Build 3200
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.114, NixOS, 19.09pre178233.85d160e24b1 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178233.85d160e24b1"`
   - channels($USER): `"nixpkgs-19.09pre178250.c2ac3f9f013"`
   - nixpkgs: `~/.nix-defexpr/channels/nixpkgs`


state: closed
title: mikutter: 3.5.13 -> 3.8.7
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60808
updated_at: 2019-05-03 10:48:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Mikutter was quite out of date, marked as broken, and with security issues.
  There was another attempt to update it at: https://github.com/NixOS/nixpkgs/pull/58966 but it didn't actually run.

  While this version still raises an exception when trying to actually add a twitter account, I think it's a huge step forward, and the new failure seems to be due to an OAuth issue rather than something caused by the packaging (though not 100% certain).

  At least it gives use something to further improve from.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fpm: 1.9.3 -> 1.11.0, use bundlerApp
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60809
updated_at: 2019-05-03 17:01:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This package was old, insecure, and still using `bundlerEnv`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pinentry: fix patch url
user_login: nixbitcoin
html_url: https://github.com/NixOS/nixpkgs/pull/60810
updated_at: 2019-05-03 22:11:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Building pinentry fails because URL is 404. I updated URL slightly, it kept same sha256, and that fixed it.

  Occured during testing of https://github.com/fort-nix/nix-bitcoin/pull/48

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ejson: 1.2.0 -> 1.2.1
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60811
updated_at: 2019-05-03 23:18:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes security issues.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: translate-shell: 0.9.6.9 -> 0.9.6.10
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60812
updated_at: 2019-05-11 03:02:59
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/translate-shell/versions.



  meta.description for translate-shell is: '"Command-line translator using Google Translate, Bing Translator, Yandex.Translate, and Apertium"'.

  [Release on GitHub](https://github.com/soimort/translate-shell/releases/tag/v0.9.6.10)


  [Compare changes on GitHub](https://github.com/soimort/translate-shell/compare/v0.9.6.9...v0.9.6.10)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.9.6.10 with grep in /nix/store/z68aw23ifjpr640dk0b1fkhp35a99jcj-translate-shell-0.9.6.10
  - directory tree listing: https://gist.github.com/e32d41797047da1cb520e8e08570e50e
  - du listing: https://gist.github.com/3b088423ad8f68ba8e3ae1fccdc69046

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  translate-shell

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/z68aw23ifjpr640dk0b1fkhp35a99jcj-translate-shell-0.9.6.10 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A translate-shell https://github.com/r-ryantm/nixpkgs/archive/a872d68060f1887e1cd95a35a6e2feb90e276b58.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/z68aw23ifjpr640dk0b1fkhp35a99jcj-translate-shell-0.9.6.10
  ls -la /nix/store/z68aw23ifjpr640dk0b1fkhp35a99jcj-translate-shell-0.9.6.10/bin
  ```


  </details>
  <br/>


  cc @ebzzry @infinisil for testing.


state: closed
title: pythonPackages.purepng: fix for py3.7, enable tests
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60813
updated_at: 2019-05-06 15:09:17
body:
  ###### Motivation for this change
  Didn't build on py3.7.

  The pypi package we were using includes pre-cythonized versions of some components, however these were cythonized with a py3.7-unaware cython which is what caused the main breakage. Fetching the equivalent version from github allows us to offer either the pure-python version or one we cythonize ourselves dependent on whether the `cython` package is provided.

  The added bonus of using a github checkout is that the tests are included, so I've enabled these.

  These tests revealed that for full py3.7 compatibility an additional patch is needed from an upstream PR - added.

  I've done a `nox-review` on this and there's one depending package (`worldengine`) that still doesn't build. Think I can probably fix that another time.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: typora: 0.9.68 -> 0.9.70
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60814
updated_at: 2019-05-11 03:03:02
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/typora/versions.



  meta.description for typora is: '"A minimal Markdown reading & writing app"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.9.70 with grep in /nix/store/j1rw6zq2hxpygb20jazcs51g8pplscl1-typora-0.9.70
  - directory tree listing: https://gist.github.com/118b31033b745a54a740aeae0799eb5a
  - du listing: https://gist.github.com/5358c9394145b6e255153314817c6567

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  typora

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/j1rw6zq2hxpygb20jazcs51g8pplscl1-typora-0.9.70 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A typora https://github.com/r-ryantm/nixpkgs/archive/bca4fdd0c9f52b14064ff438a0edf4fd47ced67a.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/j1rw6zq2hxpygb20jazcs51g8pplscl1-typora-0.9.70
  ls -la /nix/store/j1rw6zq2hxpygb20jazcs51g8pplscl1-typora-0.9.70/bin
  ```


  </details>
  <br/>


  cc @jensbin @worldofpeace for testing.


state: closed
title: riot-desktop: 1.0.7 -> 1.0.8
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/60815
updated_at: 2019-05-03 00:22:18
body:
  ###### Motivation for this change

  This PR:
  * updates `riot-desktop` to the latest version,
  * adds some note for maintainers to keep both `riot-web` and `riot-desktop` versions in sync,
  * adds myself as a maintainer of `riot-web`

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: unrar: 5.7.4 -> 5.7.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60817
updated_at: 2019-05-11 03:03:07
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/unrar/versions.



  meta.description for unrar is: '"Utility for RAR archives"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/5ab9da3ab805581b0c7fffcc89ab78ee
  - du listing: https://gist.github.com/33a97b1fa5ce542de043af3e735452fc

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  20 total rebuild path(s)

  7 package rebuild(s)

  7 x86_64-linux rebuild(s)
  5 i686-linux rebuild(s)
  4 x86_64-darwin rebuild(s)
  4 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  pdfread
  pyload
  rarcrack
  sabnzbd
  unp
  unrar
  zod

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/xmwf5f504g0kxbnd7nak7140p0wkidls-unrar-5.7.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A unrar https://github.com/r-ryantm/nixpkgs/archive/7893a6e2c09eb923f2c7c5eda9a864ec756890bc.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/xmwf5f504g0kxbnd7nak7140p0wkidls-unrar-5.7.5
  ls -la /nix/store/xmwf5f504g0kxbnd7nak7140p0wkidls-unrar-5.7.5/bin
  ```


  </details>
  <br/>


state: open
title: wireguard: allow routes to overlap with other routes
user_login: ryantrinkle
html_url: https://github.com/NixOS/nixpkgs/pull/60818
updated_at: 2019-05-03 20:15:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I like to use wireguard to maintain a constant connection to my office and my home network, but I'm frequently physically connected to those networks.  Without this patch, starting wireguard would fail for whichever network I was physically connected to, because `ip route replace` didn't play nicely with the (correct) overlapping local routes.

  This patch fixes this by explicitly deleting the routes for the wireguard interface, then re-adding the new ones (in case they have changed).  I didn't make an attempt to avoid deleting and re-adding unchanged routes, because I figure people will expect restarting wireguard to entail a short downtime (and this is very short).

  I also arbitrarily picked a metric of 10000 to ensure that traffic is directed to the local connection in preference to wireguard, when the local connection is available.  I'm sure there's a better way of choosing a metric, but this works 100% reliably for me, and I suspect it will also for most others.

  This is the kind of PR that often languishes, so if I don't get any pushback within the next week or so, I'll assume it's good and go ahead and merge.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [N/A] macOS
     - [N/A] other Linux distributions
  - [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [N/A] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [N/A] Tested execution of all binary files (usually in `./result/bin/`)
  - [N/A] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [N/A] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linuxPackages.vhba: 20190302 -> 20190410
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60819
updated_at: 2019-05-19 19:21:27
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vhba/versions.



  meta.description for linuxPackages.vhba is: '"Provides a Virtual (SCSI) HBA"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/f7b8b9a10fd60f39e4f59b7ac406c3b0
  - du listing: https://gist.github.com/69ae65a6c0ae79df350af1f6234ee062

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  57 total rebuild path(s)

  19 package rebuild(s)

  19 x86_64-linux rebuild(s)
  19 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  19 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  linuxPackages-libre.vhba
  linuxPackages.vhba
  linuxPackages_4_14.vhba
  linuxPackages_4_19.vhba
  linuxPackages_4_4.vhba
  linuxPackages_4_9.vhba
  linuxPackages_5_0.vhba
  linuxPackages_hardened.vhba
  linuxPackages_hardkernel_4_14.vhba
  linuxPackages_hardkernel_latest.vhba
  linuxPackages_latest-libre.vhba
  linuxPackages_latest.vhba
  linuxPackages_latest_hardened.vhba
  linuxPackages_latest_xen_dom0.vhba
  linuxPackages_latest_xen_dom0_hardened.vhba
  linuxPackages_testing_bcachefs.vhba
  linuxPackages_testing_hardened.vhba
  linuxPackages_xen_dom0.vhba
  linuxPackages_xen_dom0_hardened.vhba

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/zi2zcrk7r7bl4ah9fkr24wwxkqb8pbjb-vhba-20190410 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A linuxPackages.vhba https://github.com/r-ryantm/nixpkgs/archive/c2708f9e9639e6edac1d34dc62bf17f52305c4cf.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/zi2zcrk7r7bl4ah9fkr24wwxkqb8pbjb-vhba-20190410
  ls -la /nix/store/zi2zcrk7r7bl4ah9fkr24wwxkqb8pbjb-vhba-20190410/bin
  ```


  </details>
  <br/>


  cc @bendlas for testing.


state: closed
title: vim: 8.1.0675 -> 8.1.1234
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60820
updated_at: 2019-05-11 03:03:14
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vim/versions.



  meta.description for vim is: '"The most popular clone of the VI editor"'.


  [Compare changes on GitHub](https://github.com/vim/vim/compare/v8.1.0675...v8.1.1234)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 8.1.1234 with grep in /nix/store/vsy07434yqx1prba1g7wn3hxqc2k007i-vim-8.1.1234
  - directory tree listing: https://gist.github.com/4a6e956526f67ba64921fad1274bfc95
  - du listing: https://gist.github.com/591f561f3ce4bf24ce6593ff8aeb763b

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  528 total rebuild path(s)

  435 package rebuild(s)

  435 x86_64-linux rebuild(s)
  42 i686-linux rebuild(s)
  11 x86_64-darwin rebuild(s)
  40 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  appimagekit
  apt-dater
  astroid
  backintime
  backintime-common
  backintime-qt4
  cron
  cryptominisat
  diffoscope
  doomseeker
  ezquake
  faust
  faust2
  faust2alqt
  faust2alsa
  faust2csound
  faust2firefox
  faust2jack
  faust2jaqt
  faust2ladspa
  faust2lv2
  faustlive
  fcron
  foo-yc20
  foo2zjs
  libdigidocpp
  mfcj6510dw-cupswrapper
  mfcj6510dwlpr
  microscheme
  percona-xtrabackup
  purePackages.faust
  python27Packages.cmd2
  python27Packages.cmd2_8
  python37Packages.cmd2
  python37Packages.cmd2_8
  python37Packages.cmd2_9
  qdigidoc
  stp
  sysbench
  tambura
  ttyd
  unixtools.xxd
  vim
  vimHugeX
  vimPlugins.CheckAttach
  vimPlugins.Colour-Sampler-Pack
  vimPlugins.Improved-AnsiEsc
  vimPlugins.Jenkinsfile-vim-syntax
  vimPlugins.LanguageClient-neovim
  vimPlugins.NeoSolarized

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/vsy07434yqx1prba1g7wn3hxqc2k007i-vim-8.1.1234 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vim https://github.com/r-ryantm/nixpkgs/archive/a529bc7f596e808ad612d2a7f50de297d8681978.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/vsy07434yqx1prba1g7wn3hxqc2k007i-vim-8.1.1234
  ls -la /nix/store/vsy07434yqx1prba1g7wn3hxqc2k007i-vim-8.1.1234/bin
  ```


  </details>
  <br/>


  cc @lovek323 for testing.


state: closed
title: vbam: 2.1.2 -> 2.1.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60821
updated_at: 2019-05-11 03:03:17
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/visualboyadvance-m/versions.



  meta.description for vbam is: '"A merge of the original Visual Boy Advance forks"'.

  [Release on GitHub](https://github.com/visualboyadvance-m/visualboyadvance-m/releases/tag/v2.1.3)


  [Compare changes on GitHub](https://github.com/visualboyadvance-m/visualboyadvance-m/compare/v2.1.2...v2.1.3)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.1.3 with grep in /nix/store/sqvm2yayqn8f7jsg546j0lznp46i5mr7-visualboyadvance-m-2.1.3
  - directory tree listing: https://gist.github.com/3f96c8138557e878e8288373633d30d8
  - du listing: https://gist.github.com/5a19a84cb92c7e65eb45f9d7e96ed0ba

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  vbam

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/sqvm2yayqn8f7jsg546j0lznp46i5mr7-visualboyadvance-m-2.1.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vbam https://github.com/r-ryantm/nixpkgs/archive/8807e54c124ba3915f6eff81010997d2779a8cbd.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/sqvm2yayqn8f7jsg546j0lznp46i5mr7-visualboyadvance-m-2.1.3
  ls -la /nix/store/sqvm2yayqn8f7jsg546j0lznp46i5mr7-visualboyadvance-m-2.1.3/bin
  ```


  </details>
  <br/>


  cc @Lassulus for testing.


state: closed
title: vnstat: 2.1 -> 2.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60822
updated_at: 2019-05-11 03:03:20
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vnstat/versions.



  meta.description for vnstat is: '"Console-based network statistics utility for Linux"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.2 with grep in /nix/store/5q90g1iy7rwfisc4p8f4r1g9zm81dn78-vnstat-2.2
  - directory tree listing: https://gist.github.com/58a897139e00d6c6c7152e604584133a
  - du listing: https://gist.github.com/a01239460f3c532adccd2970e383589f

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  vnstat

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/5q90g1iy7rwfisc4p8f4r1g9zm81dn78-vnstat-2.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vnstat https://github.com/r-ryantm/nixpkgs/archive/765a58918b55b40da5db45a60a63bb0f0e091170.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/5q90g1iy7rwfisc4p8f4r1g9zm81dn78-vnstat-2.2
  ls -la /nix/store/5q90g1iy7rwfisc4p8f4r1g9zm81dn78-vnstat-2.2/bin
  ```


  </details>
  <br/>


state: closed
title: vulkan-tools: 1.1.101.0 -> 1.1.106.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60823
updated_at: 2019-05-11 03:03:25
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-tools/versions.



  meta.description for vulkan-tools is: '"LunarG Vulkan loader"'.


  [Compare changes on GitHub](https://github.com/KhronosGroup/Vulkan-Tools/compare/sdk-1.1.101.0...sdk-1.1.106.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/14e93356e75daa6252d66e9defe465f0
  - du listing: https://gist.github.com/88649233db3fc15f77eaa3fb3f4ffad9

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  vulkan-tools

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/29s68wsp4vaniibxvnhyfdsxjayh8c12-vulkan-tools-1.1.106.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vulkan-tools https://github.com/r-ryantm/nixpkgs/archive/a54a13f6e7a13ed0e14748365ca0a49d058f387a.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/29s68wsp4vaniibxvnhyfdsxjayh8c12-vulkan-tools-1.1.106.0
  ls -la /nix/store/29s68wsp4vaniibxvnhyfdsxjayh8c12-vulkan-tools-1.1.106.0/bin
  ```


  </details>
  <br/>


  cc @ralith for testing.


state: closed
title: vte: 0.56.1 -> 0.56.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60824
updated_at: 2019-05-11 03:03:23
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vte/versions.



  meta.description for vte is: '"A library implementing a terminal emulator widget for GTK+"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.56.2 with grep in /nix/store/yashq6k6l564fz2mv30rlzzsslwadmxs-vte-0.56.2
  - directory tree listing: https://gist.github.com/96e0688903e2b39f552acd064f9f6ce9
  - du listing: https://gist.github.com/8cd9a3f204486f8775572ac91d65d3a0

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  129 total rebuild path(s)

  42 package rebuild(s)

  42 x86_64-linux rebuild(s)
  41 i686-linux rebuild(s)
  5 x86_64-darwin rebuild(s)
  41 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  aqemu
  cloud-init
  cloud-utils
  deepin.deepin-terminal
  gnome-builder
  gnome3.gnome-boxes
  gnome3.gnome-color-manager
  gnome3.gnome-control-center
  gnome3.gnome-terminal
  gnome3.gnome_control_center
  gnome3.gnome_terminal
  gnome3.nemiver
  gnome3.vinagre
  gnome3.vte
  gtkd
  guake
  haskellPackages.gi-vte
  libguestfs
  libguestfs-with-appliance
  lxterminal
  mate.mate-terminal
  minikube
  mlterm
  pantheon.elementary-code
  pantheon.elementary-terminal
  python27Packages.guestfs
  python37Packages.guestfs
  qemu
  qemu_kvm
  qemu_test
  roxterm
  sakura
  stupidterm
  terminator
  termonad-with-packages
  tilda
  tilix
  vagrant
  virtmanager
  vte
  xfce4-13.xfce4-terminal
  xfceUnstable.xfce4-terminal

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/yashq6k6l564fz2mv30rlzzsslwadmxs-vte-0.56.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vte https://github.com/r-ryantm/nixpkgs/archive/0df09b0947fa13a32b8db1d8c9f51c4e50c0d3df.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/yashq6k6l564fz2mv30rlzzsslwadmxs-vte-0.56.2
  ls -la /nix/store/yashq6k6l564fz2mv30rlzzsslwadmxs-vte-0.56.2/bin
  ```


  </details>
  <br/>


  cc @astsmtl @antono @lethalman for testing.


state: open
title: update ipython-kernel, ghc-parser, ihaskell to latest versions
user_login: vaibhavsagar
html_url: https://github.com/NixOS/nixpkgs/issues/60825
updated_at: 2019-05-28 09:22:40
body:
  ## Issue description

  What's the process for including the latest `ghc-parser`, `ipython-kernel`, and `ihaskell` in `hackage-packages.nix`? AFAICT it involves editing `configuration-hackage2nix.yaml` but I'm not sure what edits to make. They're included in the latest Stackage `nightly` resolvers if that helps.


  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: libvpx: 1.7.0 -> 1.8.0
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/60826
updated_at: 2019-05-04 01:57:55
body:
  * [ ] Based on #54398, merge that first
  * [ ] Solve [Firefox issue](https://github.com/NixOS/nixpkgs/pull/60826#issuecomment-489068445)

  ###### Motivation for this change

  New version, and gstreamer 1.16's plugin requires a newer version or it won't be compiled in.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
    - No, Firefox issue, see above
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: release-cross.nix: add mesa to platforms
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/60827
updated_at: 2019-05-06 19:53:20
body:
  mesa is very portable and useful. we should make sure these work on
  all of the platforms we support

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Mark some bad platforms
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/60828
updated_at: 2019-05-06 19:54:09
body:
  Marks broken platforms for:

  - valgrind
  - kexectools
  - libseccomp

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: krunner-pass: fix the build
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/60829
updated_at: 2019-05-03 08:05:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes #59355

  Cc: @seqizz @worldofpeace 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: looking-glass-client build failure
user_login: MicrosoftTakeover
html_url: https://github.com/NixOS/nixpkgs/issues/60830
updated_at: 2019-05-03 17:07:53
body:
  ## Issue description
  ```$ sudo nixos-rebuild switch                                                                                                                                                                                                                                                                                                  
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/ygr0f5giydw8virjy14vscllh4ncff6s-looking-glass-client-a12.drv
    /nix/store/ljm1wapslzwfs9zrai78fax9cf4s5v7s-system-path.drv
    /nix/store/5bkddm6y52kxywsb5191lwjpk9qqxgdk-unit-systemd-fsck-.service.drv
    /nix/store/bs3g1dgsd8kz7faa880p6h1jirgsb85y-unit-accounts-daemon.service.drv
    /nix/store/f4cxds166hfhiyhh94wgpfkbdcn0kxzh-dbus-1.drv
    /nix/store/n4zrki7b5m1i5np873hcpxf1s4agili0-unit-dbus.service.drv
    /nix/store/wighhqqw9xhg75jpzwcjmv608kal3cw2-unit-polkit.service.drv
    /nix/store/90i24pkqfcbnmwmk2z6hypk7r49pkjx1-system-units.drv
    /nix/store/pq0a3v4bflki5ysf1cczakbkajdm81cj-unit-dbus.service.drv
    /nix/store/f6y8j95fdl79d7nfyih8igi2cxxhdm71-user-units.drv
    /nix/store/9vdnary7r52z33xbjcqab6pvlvc07dr6-xsession.drv
    /nix/store/l3pc6cczqy26sqc3qafd2r6ppagqj777-xsession-wrapper.drv
    /nix/store/pikfjpcypbm0mlr9qwr9sf7dyg448day-desktops.drv
    /nix/store/zpm14gb4jpn2cpjryb51zrfxq1v5bvav-lightdm.conf.drv
    /nix/store/6xv7054w05hv9ffyzzw32kpwxznbnw9h-etc.drv
    /nix/store/xjqrnrs0r8n4jwb0d2bsyja0mxr4zi44-nixos-system-nixos-workstation-19.09pre177651.aeb464dfd37.drv
  building '/nix/store/ygr0f5giydw8virjy14vscllh4ncff6s-looking-glass-client-a12.drv'...
  unpacking sources
  unpacking source archive /nix/store/if4yklaww60kvb9xh555njln3ppzpszd-source
  source root is source/client
  patching sources
  configuring
  fixing cmake files...
  cmake flags: -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/aiv35zdk7ssd9psdpvvn5145cg2bv798-looking-glass-client-a12/include -DCMAKE_INSTALL_LIBDIR=/nix/store/aiv35zdk7ssd9psdpvvn5145cg2bv798-looking-glass-client-a12/lib -DCMAKE_INSTALL_NAME_DIR=/nix/store/aiv35zdk7ssd9psdpvvn5145cg2bv798-looking-glass-client-a12/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_DEPLOYMENT_TARGET= -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=last -DCMAKE_STRIP=/nix/store/1kl6ms8x56iyhylb2r83lq7j3jbnix7w-binutils-2.31.1/bin/strip -DCMAKE_RANLIB=/nix/store/1kl6ms8x56iyhylb2r83lq7j3jbnix7w-binutils-2.31.1/bin/ranlib -DCMAKE_AR=/nix/store/1kl6ms8x56iyhylb2r83lq7j3jbnix7w-binutils-2.31.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/aiv35zdk7ssd9psdpvvn5145cg2bv798-looking-glass-client-a12
  -- The C compiler identification is GNU 7.4.0
  -- Check for working C compiler: /nix/store/w2px3blinprrzx6wva8x7m0l9l27jzj9-gcc-wrapper-7.4.0/bin/gcc
  -- Check for working C compiler: /nix/store/w2px3blinprrzx6wva8x7m0l9l27jzj9-gcc-wrapper-7.4.0/bin/gcc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Found PkgConfig: /nix/store/7s6n4qpbsiav8s8as35xmh27ssbh1nrz-pkg-config-0.29.2/bin/pkg-config (found version "0.29.2")
  -- Checking for modules 'sdl2;SDL2_ttf;gl;glu;egl;spice-protocol;fontconfig;x11;libconfig;nettle;hogweed'
  --   Found sdl2, version 2.0.9
  --   Found SDL2_ttf, version 2.0.15
  --   Found gl, version 18.3.4
  --   Found glu, version 9.0.0
  --   Found egl, version 18.3.4
  --   Found spice-protocol, version 0.12.15
  --   Found fontconfig, version 2.12.6
  --   Found x11, version 1.6.7
  --   Found libconfig, version 1.7.2
  --   Found nettle, version 3.4.1
  --   Found hogweed, version 3.4.1
  Package expat was not found in the pkg-config search path.
  Perhaps you should add the directory containing `expat.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'expat', required by 'fontconfig', not found
  Package expat was not found in the pkg-config search path.
  Perhaps you should add the directory containing `expat.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'expat', required by 'fontconfig', not found
  Package expat was not found in the pkg-config search path.
  Perhaps you should add the directory containing `expat.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'expat', required by 'fontconfig', not found
  Package expat was not found in the pkg-config search path.
  Perhaps you should add the directory containing `expat.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'expat', required by 'fontconfig', not found
  -- GMP libs: /nix/store/9b6qi566l7icp4z5l0fn86zfcbw8ws3f-gmp-6.1.2/lib/libgmp.so /nix/store/9b6qi566l7icp4z5l0fn86zfcbw8ws3f-gmp-6.1.2/lib/libgmpxx.so
  -- Found GMP: /nix/store/bq3wh9rpy4aqahz24i4z0brmy46lg6yj-gmp-6.1.2-dev/include
  -- Configuring done
  -- Generating done
  CMake Warning:
    Manually-specified variables were not used by the project:

      BUILD_TESTING
      CMAKE_CXX_COMPILER
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_INSTALL_INCLUDEDIR
      CMAKE_INSTALL_LIBDIR


  -- Build files have been written to: /build/source/client/build
  building
  build flags: -j8 -l8 SHELL=/nix/store/yjkch3aia9ny4dq42dbcjrdwqb1y8c33-bash-4.4-p23/bin/bash
  Scanning dependencies of target looking-glass-client
  [ 18%] Building C object CMakeFiles/looking-glass-client.dir/lg-fonts.c.o
  [ 18%] Building C object CMakeFiles/looking-glass-client.dir/main.c.o
  [ 18%] Building C object CMakeFiles/looking-glass-client.dir/ll.c.o
  [ 18%] Building C object CMakeFiles/looking-glass-client.dir/lg-renderer.c.o
  [ 22%] Building C object CMakeFiles/looking-glass-client.dir/utils.c.o
  [ 27%] Building C object CMakeFiles/looking-glass-client.dir/spice/rsa.c.o
  [ 31%] Building C object CMakeFiles/looking-glass-client.dir/spice/spice.c.o
  [ 36%] Building C object CMakeFiles/looking-glass-client.dir/decoders/null.c.o
  [ 40%] Building C object CMakeFiles/looking-glass-client.dir/decoders/yuv420.c.o
  /build/source/client/spice/spice.c:39:10: fatal error: spice/error_codes.h: No such file or directory
   #include <spice/error_codes.h>
            ^~~~~~~~~~~~~~~~~~~~~
  compilation terminated.
  make[2]: *** [CMakeFiles/looking-glass-client.dir/build.make:141: CMakeFiles/looking-glass-client.dir/spice/spice.c.o] Error 1
  make[2]: *** Waiting for unfinished jobs....
  make[1]: *** [CMakeFiles/Makefile2:73: CMakeFiles/looking-glass-client.dir/all] Error 2
  make: *** [Makefile:84: all] Error 2
  builder for '/nix/store/ygr0f5giydw8virjy14vscllh4ncff6s-looking-glass-client-a12.drv' failed with exit code 2
  cannot build derivation '/nix/store/ljm1wapslzwfs9zrai78fax9cf4s5v7s-system-path.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/xjqrnrs0r8n4jwb0d2bsyja0mxr4zi44-nixos-system-nixos-workstation-19.09pre177651.aeb464dfd37.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/xjqrnrs0r8n4jwb0d2bsyja0mxr4zi44-nixos-system-nixos-workstation-19.09pre177651.aeb464dfd37.drv' failed
  ```


  ### Steps to reproduce
  Add looking-glass-client package and rebuild. This used to work but something changed awhile back. I just commented out the package and forgot about it because I wasn't using it at the time. Now I'd like to use it again.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.09pre177651.aeb464dfd37 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre177651.aeb464dfd37"`
   - channels(nix): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Package request: viu
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/issues/60831
updated_at: 2019-05-05 00:20:30
body:
  "command-line application to view images from the terminal written in Rust" https://github.com/atanunq/viu

  I tested it and it seems to be good and useful.


state: closed
title: looking-glass-client: fix build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/60832
updated_at: 2019-05-03 17:07:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  spice-protocol removed the spice/error_codes.h header file [1], which
  looking-glass-client was still using.

  [1] https://gitlab.freedesktop.org/spice/spice-protocol/commit/334cef51d03134a50d85827ea3c2ebc1ebb09e1c

  Fixes https://github.com/NixOS/nixpkgs/issues/60830
  cc: @MicrosoftTakeover


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: chromium: fix widevine
user_login: jflanglois
html_url: https://github.com/NixOS/nixpkgs/pull/60833
updated_at: 2019-06-18 04:50:30
body:
  ###### Motivation for this change
  This change allows widevine to work in chromium (it was previously broken due to a segfault). Newer versions of chromium do not use the libwidevinecdmadapter.so. Instead, libwidevinecdm.so should be installed in the chromium libExec directory.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Gimp plugin "resynthesizer2" is not actually installed
user_login: typedfern
html_url: https://github.com/NixOS/nixpkgs/issues/60834
updated_at: 2019-05-04 13:23:17
body:
  ## Issue description

  Installing the gimpPlugins.resynthesizer2 package does not result in a working plugin; the python scripts are installed, but not the two native executables it depends on (called "resynthesizer" and "resynthesizer"

  ### Steps to reproduce

  Try to install the package "gimpPlugins.resynthesizer2".

  Expected result:
  There should be a few new menu options in the Gimp, amongst them "Filter -> Enhance -> Heal Selection..."

  Actual result:
  No new menu options; python scripts cannot find the executables.

  Possible solution:

  I made it work by creating a derivation that adds a the following postInstall:

  postInstall = "installPlugins src/resynthesizer/resynthesizer src/resynthesizer-gui/resynthesizer_gui";


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.90, NixOS, 18.09.1806.928ff62213b (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(cable): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Vulnerability roundup 67: evince-3.32.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60835
updated_at: 2019-05-25 18:09:15
body:
  [search](https://search.nix.gsc.io/?q=evince&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=evince+in%3Apath&type=Code)

  * [x] [CVE-2019-11459](https://nvd.nist.gov/vuln/detail/CVE-2019-11459) (nixos-unstable)

  Scanned versions: nixos-unstable: dfd8f84aef1. May contain false positives.


state: closed
title: Vulnerability roundup 67: gnome-desktop-3.30.2.1: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60836
updated_at: 2019-05-14 21:19:26
body:
  [search](https://search.nix.gsc.io/?q=gnome-desktop&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gnome-desktop+in%3Apath&type=Code)

  * [x] [CVE-2019-11460](https://nvd.nist.gov/vuln/detail/CVE-2019-11460) (nixos-19.03)

  Scanned versions: nixos-19.03: cf3e277dd0b. May contain false positives.


state: closed
title: Vulnerability roundup 67: gnome-desktop-3.32.1: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60837
updated_at: 2019-05-15 20:49:22
body:
  [search](https://search.nix.gsc.io/?q=gnome-desktop&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gnome-desktop+in%3Apath&type=Code)

  * [x] [CVE-2019-11460](https://nvd.nist.gov/vuln/detail/CVE-2019-11460) (nixos-unstable)

  Scanned versions: nixos-unstable: dfd8f84aef1. May contain false positives.


state: open
title: Vulnerability roundup 67: gstreamer-0.10.36: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60838
updated_at: 2019-05-03 07:40:21
body:
  [search](https://search.nix.gsc.io/?q=gstreamer&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gstreamer+in%3Apath&type=Code)

  * [ ] [CVE-2019-9928](https://nvd.nist.gov/vuln/detail/CVE-2019-9928) (nixos-unstable, nixos-19.03, nixos-18.09)

  Scanned versions: nixos-unstable: dfd8f84aef1; nixos-19.03: cf3e277dd0b; nixos-18.09: 571b40d3f50. May contain false positives.


state: closed
title: Vulnerability roundup 67: libheif-1.4.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60839
updated_at: 2019-05-23 08:13:40
body:
  [search](https://search.nix.gsc.io/?q=libheif&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libheif+in%3Apath&type=Code)

  * [x] [CVE-2019-11471](https://nvd.nist.gov/vuln/detail/CVE-2019-11471) (nixos-unstable)

  Scanned versions: nixos-unstable: dfd8f84aef1. May contain false positives.


state: closed
title: Vulnerability roundup 67: libsass-3.5.4: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60840
updated_at: 2019-06-29 01:16:58
body:
  [search](https://search.nix.gsc.io/?q=libsass&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libsass+in%3Apath&type=Code)

  * [ ] [CVE-2018-20822](https://nvd.nist.gov/vuln/detail/CVE-2018-20822) (nixos-18.09)

  Scanned versions: nixos-18.09: 571b40d3f50. May contain false positives.


state: open
title: pfstools cannot import pictures in RAW format
user_login: typedfern
html_url: https://github.com/NixOS/nixpkgs/issues/60841
updated_at: 2019-05-07 20:23:07
body:
  ## Issue description

  The package "pfstools" installs a bash script, called "pfsindcraw", for importing camera pictures in raw format.

  However, the nix-distributed version fails, because one of the programs it relies on, "pfsinppm", is not compiled (because it requires netpbm being installed).

  ### Steps to reproduce

  1) Install pfstools
  2) Try to import a raw camera picture: pfsindcraw camera.raw >camera.pfs

  Expected result: The output file "camera.pfs" having several megabytes of PFS data.

  Actual result: "pfsinppm program not found. Check if pfstools are compiled with netpbm support."

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.90, NixOS, 18.09.1806.928ff62213b (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(typedfern): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ### Workaround

  I managed to get it to work normally by using tiff instead of pbm as the intermediate format between RAW and PFS; here is the patch:

  ```diff
  diff -pruN a/src/fileformat/pfsindcraw.in b/src/fileformat/pfsindcraw.in
  --- a/src/fileformat/pfsindcraw.in      2017-11-13 18:38:27.000000000 +0100
  +++ b/src/fileformat/pfsindcraw.in      2018-12-30 17:23:03.837192536 +0100
  @@ -28,8 +28,8 @@ if ! which dcraw 2>/dev/null 1>/dev/null
       exit 1;
   fi
   
  -if ! which pfsinppm 2>/dev/null 1>/dev/null; then
  -    echo >&2 "pfsindcraw: pfsinppm program not found. Check if pfstools are compiled with netpbm support."
  +if ! which pfsintiff 2>/dev/null 1>/dev/null; then
  +    echo >&2 "pfsindcraw: pfsintiff program not found. Check if pfstools are compiled with TIFF support."
       exit 1;
   fi
   
  @@ -56,9 +56,9 @@ fi
   while test "$1"; do
   
         file_pattern="$1"
  -
  -      dcraw -c -o $COLORSPACE -4 -w "$file_pattern" | pfsinppm - 2> /dev/null | \
  -          pfstag --set "FILE_NAME=${file_pattern}" --set "LUMINANCE=RELATIVE"
  -      
  +      temporary=`mktemp`
  +      dcraw -c -o $COLORSPACE -4 -w -T "$file_pattern" >$temporary
  +      pfsintiff $temporary 2> /dev/null | pfstag --set "FILE_NAME=${file_pattern}" --set "LUMINANCE=RELATIVE"
  +      rm $temporary
         shift
   done
  ```


state: open
title: Vulnerability roundup 67: libsass-3.5.5: 4 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/60842
updated_at: 2019-05-18 12:20:21
body:
  [search](https://search.nix.gsc.io/?q=libsass&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libsass+in%3Apath&type=Code)

  * [ ] [CVE-2018-20821](https://nvd.nist.gov/vuln/detail/CVE-2018-20821) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2018-19797](https://nvd.nist.gov/vuln/detail/CVE-2018-19797) (nixos-19.03)
  * [ ] [CVE-2018-19826](https://nvd.nist.gov/vuln/detail/CVE-2018-19826) (nixos-19.03)
  * [x] [CVE-2018-19827](https://nvd.nist.gov/vuln/detail/CVE-2018-19827) (nixos-19.03)

  Scanned versions: nixos-unstable: dfd8f84aef1; nixos-19.03: cf3e277dd0b. May contain false positives.


state: open
title: The "pfstools" package doesn't install the "pfsalign" program
user_login: typedfern
html_url: https://github.com/NixOS/nixpkgs/issues/60843
updated_at: 2019-05-04 12:35:39
body:
  ## Issue description

  The command-line tool "pfsalign", included in the pfstools package, uses computer vision (via OpenCV) to align images; with NixOS, however, it is not being built.

  ### Steps to reproduce

  Install pfstools.

  Expected result:
  The pfsalign command being available in bash.

  Actual result:
  No pfsalign command is installed.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.90, NixOS, 18.09.1806.928ff62213b (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(cable): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ### Solution

  The Nix distribution of pfstools uses a different method to find the libexif library (which is needed to build pfsalign), but the part that builds pfsalign was not properly patched to use it. I got it to work with this patch:

  ```diff
  diff -pruN a/src/camera/CMakeLists.txt b/src/camera/CMakeLists.txt
  --- a/src/camera/CMakeLists.txt 2017-11-13 18:38:27.000000000 +0100
  +++ b/src/camera/CMakeLists.txt 2018-12-30 14:55:30.235571520 +0100
  @@ -9,7 +9,7 @@ target_link_libraries(${TRG} pfs)
   install (TARGETS ${TRG} DESTINATION bin)
   install (FILES ${TRG}.1 DESTINATION ${MAN_DIR})
   
  -if( OpenCV_FOUND AND EXIF_FOUND )
  +if( OpenCV_FOUND AND MYPKG_FOUND )
   
          set(TRG pfsalign)
          add_executable(${TRG} ${TRG}.cpp  "${GETOPT_OBJECT}")                  
  ```


state: closed
title: bpftrace: unstable-2018-10-27 -> 0.9
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60844
updated_at: 2019-05-03 17:10:05
body:
  Update bpftrace to the latest pre-release, with a real version number.

  The most notable change now is that bpftrace can use a stable version of
  the 'bcc' toolchain in order to build, meaning no more hacks are needed
  to clone the source code and fix up the build system, etc. This
  simplifies things greatly and removes the old bcc-source patch.

  Similarly, we can remove the gtests patch by just passing
  -DBUILD_TESTING=FALSE when running cmake. This removes the gtest patch.

  However, something does still need to be fixed, at a cost: bpftrace
  requires the kernel -dev package because it wants both objects and
  include directories (some files are only shipped in one or the other).
  Therefore, we remove the dependency on linuxHeaders and instead use
  kernel.dev as the sole input to the build.

  This is both a positive and a negative: the positive is that tools work
  without annoying fatal errors, and that the bpf toolchain is
  synchronized to the linuxPackages.kernel derivation it was built
  against. The downside is that the .dev expression is much heavier as a
  dependency, so bpftrace is now closer to 700mb in closure size. (This
  especially hurts across kernel upgrades requiring a whole new rebuild,
  especially if you have existing nixos generations that won't GC, etc.)

  We probably want to slim this down substantially in the future (and
  there may be a few ways to do that), but as this will probably also
  touch bcc, and as a first cut of the pre-releases, this is probably fine
  while we work out other kings.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: newsboat broken in single-user mode
user_login: yurkobb
html_url: https://github.com/NixOS/nixpkgs/issues/60845
updated_at: 2019-05-03 06:39:16
body:
  ## Issue description
  This is a consequence of NixOS/nix#2762.

  ### Steps to reproduce
  ```
  $ nix-env -i newsboat
  replacing old 'newsboat-2.14.1'
  installing 'newsboat-2.15'
  these derivations will be built:
    /nix/store/3krczr2yrnpnjqjaw23a11k543ywnsza-newsboat-2.15.drv
  building '/nix/store/3krczr2yrnpnjqjaw23a11k543ywnsza-newsboat-2.15.drv'...
  unpacking sources
  unpacking source archive /nix/store/ndqhrldc89207rqi8mda8nz6lj4vdpq9-newsboat-2.15.tar.xz
  do not know how to unpack source archive /nix/store/ndqhrldc89207rqi8mda8nz6lj4vdpq9-newsboat-2.15.tar.xz
  builder for '/nix/store/3krczr2yrnpnjqjaw23a11k543ywnsza-newsboat-2.15.drv' failed with exit code 1
  error: build of '/nix/store/3krczr2yrnpnjqjaw23a11k543ywnsza-newsboat-2.15.drv' failed
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.9-200.fc29.x86_64, Fedora, 29 (Twenty Nine)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(yurb): `"nixpkgs-19.09pre178281.76fad451105"`
   - nixpkgs: `/home/yurb/.nix-defexpr/channels/nixpkgs`
  ```

  cc @nicknovitski @dotlambda 


state: closed
title: cockroachdb: 2.1.6 -> 19.1.0
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60846
updated_at: 2019-05-03 16:27:53
body:
  Signed-off-by: Austin Seipp <aseipp@pobox.com>

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tor: 0.3.5.7 -> 0.4.0.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60847
updated_at: 2019-05-03 09:47:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  First stable release of 4.0.x series!

  https://gitweb.torproject.org/tor.git/plain/ChangeLog?h=tor-0.4.0.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitcoin: 0.17.3 -> 0.18.0, enable and run unit tests
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60848
updated_at: 2019-05-05 00:40:37
body:
  ###### Motivation for this change

  https://bitcoincore.org/en/releases/0.18.0/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lz4: pick upstream fix for Darwin, move to pname
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60849
updated_at: 2019-05-09 13:30:06
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/59812#issuecomment-488850589

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: extrace: init at 0.7
user_login: leahneukirchen
html_url: https://github.com/NixOS/nixpkgs/pull/60851
updated_at: 2019-05-03 09:19:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add extrace 0.7, a tool to trace exec() calls system-wide.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: opensc: use built-in PCSC provider on darwin
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/60852
updated_at: 2019-05-10 16:47:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Make OpenSC usable with hardware tokens on Darwin.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: home-assistant: add sonos component dependencies
user_login: juaningan
html_url: https://github.com/NixOS/nixpkgs/pull/60853
updated_at: 2019-05-20 11:19:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Add required python packages and binding them in the component-packages.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lolcat: use bundlerApp, fix audit warning
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60854
updated_at: 2019-05-04 20:06:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes the warning of `bundler-audit` and uses the cleaner `bundlerApp`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bcat: use https rubygems
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60855
updated_at: 2019-05-03 14:18:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes warning of `bundler-audit`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sass: 3.5.6 -> 3.7.4
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60856
updated_at: 2019-05-04 20:06:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New version and fix for security issue.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus-fritzbox-exporter: 1.0 -> 1.0-32-g90fc0c5
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/60857
updated_at: 2019-05-04 14:06:33
body:
  This bumps ndecker/fritzbox_exporter to a more recent fork (mxschmitt/fritzbox_exporter). This version
  also capable of TR64.

  cc @bachp 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tmuxinator: 0.13.0 -> 1.1.0
user_login: ejpcmac
html_url: https://github.com/NixOS/nixpkgs/pull/60858
updated_at: 2019-05-09 02:23:16
body:
  ###### Motivation for this change

  Tmuxinator was out of date, and 1.1.0 brings compatibility with Tmux 2.9 which is now out on nixpkgs unstable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: moc: refactor options, add patches
user_login: aethelz
html_url: https://github.com/NixOS/nixpkgs/pull/60859
updated_at: 2019-05-19 10:01:42
body:
  Add support for conditional compile options, add pulseaudio and ffmpeg4
  support patches.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Unfortunately, previous version of this package was very basic and did not allow for conditional compile options. 

  Also, it lacked pulseaudio support (it was added with a patch, courtesy of [marienz](https://moc.daper.net/node/831)) and it wouldn't work properly with ffmpeg 4 (support also added via patch, see [here](https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/moc)). I had to change patch formats a bit so that it would work OOTB with nix.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gcc9: init at 9.1.0 (released today)
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/pull/60860
updated_at: 2019-05-08 08:34:08
body:
  It's just a trivial copy of whole gcc8 stuff, only with changed version string and hash.

  ###### Motivation for this change

  https://gcc.gnu.org/gcc-9/changes.html
  I see nothing relevant to packaging in the changes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] N/A Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of **some** binary files (usually in `./result/bin/`)
    [A small project](https://knot-resolver.cz) built fine with the resulting compiler.
  - [ ] _I'll post below._ Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] N/A Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  /cc maintainer @Synthetica9.


state: closed
title: perlPackages: fix build packages for non-default perl
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/60861
updated_at: 2019-05-08 14:14:02
body:
  @aanderse has found a bug https://github.com/NixOS/nixpkgs/pull/60702#issuecomment-488880736  with compiling some packages using non-default ```perl``` (currently there is only ```5.29.9``` as ```perldevel```).

  It seems like a regression after https://github.com/NixOS/nixpkgs/pull/56019 where ```perl``` has been replaced with ```buildPackages.perl``` to fix cross-compilation issues, but while ```perl``` is overrideable and points to ```perl``` of the current context (which could be ```pkgs.perl```, ```pkgs.perldevel```, etc), ```buildPackages.perl``` always points to ```pkgs.buildPackages.perl``` which is always ```perl-5.28```.

  Thus two versions of perl (5.28.2 and 5.29.9) were used simultaneously to build and test some packages which leads to errors.

  @illegalprime to test cross-compilation things
  @srhb
  @rycee 


state: closed
title: qogir-theme: 2019-04-07 -> 2019-05-03
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/60863
updated_at: 2019-05-03 15:28:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [2019-05-03](https://github.com/vinceliuice/Qogir-theme/releases/tag/2019-05-03)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: node-packages' generate.sh makes many duplicate requests
user_login: chreekat
html_url: https://github.com/NixOS/nixpkgs/issues/60864
updated_at: 2019-05-08 04:39:46
body:
  ## Issue description

  I ran generate.sh as per [Nixpkgs manual §9.11](https://nixos.org/nixpkgs/manual/#node.js-packages), and before it had even finished I noticed a great number of duplicate requests to npmjs.org. 

  Since I'm not certain about npm's inner workings, I used tcpdump to confirm that duplicate HTTP requests are being sent.

  ### Some stats

  74% of all requests are duplicates.

  Note: all the below is *only* v10 packages, and I canceled the script before it even ran to completion. (I'm running it again just to confirm.)

  **Edit:** generate.sh fails on master@f0ec7c6f072e0c734d95d3a62344c949faa3443a right now anyway, but I still get the following stats:

  ```
  $ grep '^http 200' reqs | wc
     5881   17643  274467
  $ grep '^http 200' reqs | sort -u |wc
     1541    4623   72882
  ```

  `(5881.0 - 1541)/5881 ~ .74` : **74% of requests are duplicates**.

  ### An example

  ```
  $ grep '^http 200.*ansi-regex' reqs
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  http 200 http://registry.npmjs.org/ansi-regex
  ```

  ### Steps to reproduce

  ```
  nixpkgs $ cd pkgs/development/node-packages
  node-packages $ nix-shell -p nodePackages.node2nix
  nix-shell $ node2nix --nodejs-10 -i node-packages-v10.json \
      -o node-packages-v10.nix  -c composition-v10.nix |& tee reqs

  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.114, NixOS, 18.09.2543.41245517a98 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2543.41245517a98"`
   - channels(b): `"unstable-19.09pre173349.07b42ccf2de"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: mpdcron: 20130809 -> 20161228
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60865
updated_at: 2019-05-04 20:06:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  While this version is also quite old, it includes a few bugfixes. The dependencies are upgraded because of security issues.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: riemann-dash: 0.2.12 -> 0.2.14, use bundlerApp
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60866
updated_at: 2019-05-04 20:06:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New version available, security issues found by `bundler-audit`, and cleaner package using `bundlerApp`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: taskjuggler: fix security issues
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60867
updated_at: 2019-05-04 20:06:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update dependencies to fix security issue in `mail` dependency and using HTTPS.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vmTools: update debian-9.4 repositories to debian-9.8 Release.xz urls
user_login: apeyroux
html_url: https://github.com/NixOS/nixpkgs/pull/60868
updated_at: 2019-05-14 19:08:08
body:
  ###### Motivation for this change

  The old index tries to download packages on urls in 404.
  I tested the modification by building a debian package.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libredirect: do not redirect dlopen by default
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60869
updated_at: 2019-05-04 04:34:30
body:
  For reasons unknown, some programs cannot handle dlopen being overridden, even when no libraries are rewritten. See https://github.com/NixOS/nixpkgs/issues/60807

  As a hack, let's disable dlopen redirection by default. We can investigate in the future.

  Also adding a test for dlopen. It did not detect any issues.

  cc @worldofpeace

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: miraclecast: 20170427 -> 20190403
user_login: dkudriavtsev
html_url: https://github.com/NixOS/nixpkgs/pull/60870
updated_at: 2019-05-07 11:37:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The new version of miraclecast adds features and bug fixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ccid: set platforms to unix
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/60871
updated_at: 2019-05-03 17:20:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upstream supports Linux, macOS and various Unixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update keybase to 3.2.2
user_login: cinemast
html_url: https://github.com/NixOS/nixpkgs/pull/60872
updated_at: 2019-05-03 21:54:55
body:
  ###### Motivation for this change

  Update keybase and keybase-gui to 3.2.2

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: r10k: 2.4.3 -> 3.2.0
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60873
updated_at: 2019-05-04 20:06:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  General and security update, also use `bundlerApp`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gem-config: add vpim
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60874
updated_at: 2019-05-04 20:06:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Small patch to get vpim gem to work on modern Ruby.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gem-config: rugged needs which
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60875
updated_at: 2019-05-04 20:06:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  small change to support the rugged gem in more contexts.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: redis-dump: 0.3.5 -> 0.4.0
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60876
updated_at: 2019-05-04 20:06:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  General update, includes security fixes, uses cleaner `bundlerApp`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nukeReferences: fix for store paths with special characters
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/60877
updated_at: 2019-05-23 21:07:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I'm running nix with store directory in a custom path containing a '+' character. This prevents nukeReferences from working properly because some characters in the path get interpreted as a regular expression special characters. Broken nukeReferences will prevent `python3` from building on my setup because it requires `disallowedReferences = [ openssl.dev ];`.

  The proposed fix implements escaping of the special characters in the store path.

  ###### Things done

  Tested with

  ```nix
  with import <nixpkgs> {};

  stdenvNoCC.mkDerivation {
    name = "nuke-refs-test";

    nativeBuildInputs = [ nukeReferences ];

    buildCommand = ''
      cat > $out <<EOF
      out: $out
      openssl: ${openssl}
      python: ${python}
      EOF
      nuke-refs -e ${openssl} $out
      echo
      echo "> Only out and python should be nuked:"
      cat "$out"

      echo
      echo "> This should fail:"
      nuke-refs -e /not/a/path $out
    '';
  }
  ```

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: usb_modeswitch_data udev rules aren't applied
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/issues/60878
updated_at: 2019-05-03 17:30:07
body:
  ## Issue description

  Hello, I am using a Logitech G920 which should be configured by usb_modeswitch.

  I added usb-modeswitch-data to the udev rules, it shows up in /etc/udev but nothing gets applied.

  By looking at how the package is made it seems it is incorectly patching the udev file: originally it would call a script (`/lib/udev/usb_modeswitch`) but it is replaced by the usb_modeswitch executable (`/bin/usb_modeswitch`) without changing the arguments.

  But the script will not work as it is because `/bin/usb_modeswitch_dispatcher` (which is called by `/lib/udev/usb_modeswitch`) will try to access a lot of hardcoded paths (like `/usr/share/usb_modeswitch` or `/usr/sbin/usb_modeswitch`).

  ### Steps to reproduce

  `hardware.usbWwan.enable=true;`


state: closed
title: php: 7.1.28 -> 7.1.29, 7.2.17 -> 7.2.18, 7.3.4 -> 7.3.5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60879
updated_at: 2019-05-05 09:43:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] backport fixes from #59367, #60638, #60832
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60880
updated_at: 2019-05-03 21:15:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  backport fixes from #59367, #60638, #60832
  ping  @NixOS/backports 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] php: 7.1.27 -> 7.1.29, 7.2.16 -> 7.2.18, 7.3.3 -> 7.3.5
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/60881
updated_at: 2019-05-05 09:44:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: biber: Fix eval
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60883
updated_at: 2019-05-03 20:16:03
body:
  ###### Motivation for this change
  Remove UnicodeCollate dependency, which is part of Perl 5.28 and does not exist separately anymore.

  Add PerlIO::utf8_strict, which lack thereof Biber complains about during build.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: microsoft_gsl: 2017-02-13 -> 2.0.0
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/60884
updated_at: 2019-05-03 23:50:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  GSL now has an official release. Upgrade microsoft_gsl to the latest release (made August 20, 2018).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: obs-studio: 23.0.2 -> 23.1.0
user_login: ankhers
html_url: https://github.com/NixOS/nixpkgs/pull/60885
updated_at: 2019-05-04 12:40:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab-{ce,ee}: 11.9.11 -> 11.10.4
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/60886
updated_at: 2019-05-06 19:38:12
body:
  ###### Motivation for this change
  This bumps gitlab to their latest 11.10.x release, and fixes the updater script to properly order version numbers ;-)

  This is still WIP, as gitaly fails to build, as the `ruby/vendor` folder seems to have disappeared (and I'm not sure what else changed there, too).
  @globin , @fpletz, could you take a look?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fluent-bit: init at 1.0.6
user_login: samrose
html_url: https://github.com/NixOS/nixpkgs/pull/60887
updated_at: 2019-05-21 15:49:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  adding a package that installs https://fluentbit.io

  ###### Things done
  created a pkg, and added to all-packages.nix
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.pygal: fix build by forcing pytest_3 - staging rebase
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60888
updated_at: 2019-05-23 23:27:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This is a rebase of https://github.com/NixOS/nixpkgs/pull/59431 onto `staging`, seeing as it does have a fairly high rebuild count. Please see that PR for details.


state: open
title: KDE / Plasma updates
user_login: vandenoever
html_url: https://github.com/NixOS/nixpkgs/pull/60889
updated_at: 2019-05-04 16:05:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  KDE software in NixOS is not at the latest version. This patch `release-19.03` updates to
   - KDE frameworks 5.57
   - Plasma 5.15
   - KDE applications 19.04

  I've been running my desktop on a nix channel with this patch for a few weeks. So far I've observed only one bug (https://bugs.kde.org/show_bug.cgi?id=406829). I have not been able to look into the details of the bug because:
   - I cannot get Qt 5.12.3 to compile to see if that fixes it (https://github.com/NixOS/nixpkgs/pull/60119)
   - I do not know how to install Qt package and up with debug symbols enabled.


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [~] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: request: texlive 2019! \o/
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/60890
updated_at: 2019-05-04 06:04:06
body:
  Hi folks!

  Another year, another texlive release! Let's help Nix'ers typeset with all the latest and greatest!

  Someone want to get the process started? And is our mirroring situation okay, or are we increasingly imposing on some generous soul?

  I'll poke at this if I can, but unlikely to have time in coming weeks. Can definitely help test though! :)

  ------

  Misc info:

  https://tug.org/texlive/doc/texlive-en/texlive-en.html#news (link won't work when 2020 is out, probably)

  FWIW we have this note: 
  https://github.com/NixOS/nixpkgs/blob/b6d0bdf5136031b49d174e638e7d0bdc8c5e5a12/pkgs/tools/typesetting/tex/texlive/bin.nix#L201


state: closed
title: linuxPackages_testing.perf (5.1.0-rc7) fails to compile
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/issues/60891
updated_at: 2019-05-03 20:16:41
body:
  ## Issue description

  ```
    CC       ui/setup.o
    LINK     libtraceevent.a
    CC       scripts/perl/Perf-Trace-Util/Context.o
    CC       arch/x86/util/header.o
    CC       arch/x86/tests/regs_load.o
    CC       arch/x86/util/tsc.o
    CC       arch/x86/tests/dwarf-unwind.o
    CC       ui/helpline.o
  util/annotate.c:1689:10: fatal error: dis-asm.h: No such file or directory
   #include <dis-asm.h>
            ^~~~~~~~~~~
  compilation terminated.
  mv: cannot stat 'util/.annotate.o.tmp': No such file or directory
  make[4]: *** [/build/linux-5.1-rc7/tools/build/Makefile.build:97: util/annotate.o] Error 1
  make[3]: *** [/build/linux-5.1-rc7/tools/build/Makefile.build:139: util] Error 2
  make[3]: *** Waiting for unfinished jobs....
  ```

  ### Steps to reproduce

  `nix build nixpkgs.linuxPackages_testing.perf`, f40a559cbb6c1dffe144cb4c77ff5e5a443e632f

  ## Technical details

  `dis-asm.h` should come from binutils, so presumably we're missing something here...


state: closed
title: wasm-pack: Update hash.
user_login: kevincox
html_url: https://github.com/NixOS/nixpkgs/pull/60892
updated_at: 2019-05-04 05:48:45
body:
  The previous hash was generated on aarch64. Due to https://github.com/NixOS/nixpkgs/issues/60668 the hash is different on different platforms. I am updating to use the x86_64-linux hash to fix building on hydra.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pygame-1.9.5 fails to build due to changed build scripts
user_login: Dema
html_url: https://github.com/NixOS/nixpkgs/issues/60893
updated_at: 2019-05-04 06:29:11
body:
  ## Issue description
  Build scripts were moved to buildconfig folder and have some changes in place where buildInputs were being injected


  ### Steps to reproduce
  `nix-build -A python37Packages.pygame` fails with

  ```
  these derivations will be built:
    /nix/store/xny15b2frkdghxjvb9kk8frm7c8wnpqk-python3.7-pygame-1.9.5.drv
  building '/nix/store/xny15b2frkdghxjvb9kk8frm7c8wnpqk-python3.7-pygame-1.9.5.drv'...
  unpacking sources
  unpacking source archive /nix/store/dk9gngvrm20b0hylkr4bvbr8c8ikrxf4-pygame-1.9.5.tar.gz
  source root is pygame-1.9.5
  setting SOURCE_DATE_EPOCH to timestamp 1554025714 of file pygame-1.9.5/src_py/version.py
  patching sources
  configuring
  sed: can't read config_unix.py: No such file or directory
  builder for '/nix/store/xny15b2frkdghxjvb9kk8frm7c8wnpqk-python3.7-pygame-1.9.5.drv' failed with exit code 2
  error: build of '/nix/store/xny15b2frkdghxjvb9kk8frm7c8wnpqk-python3.7-pygame-1.9.5.drv' failed
  ```

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37, NixOS, 19.09pre177651.aeb464dfd37 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(dema): `"home-manager, nixpkgs-19.09pre177683.5d09420337f"`
   - channels(root): `"nixos-19.09pre178260.190727db4ea"`
   - nixpkgs: `/home/dema/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: wlroots: 0.5.0 -> 0.6.0
user_login: primeos
html_url: https://github.com/NixOS/nixpkgs/pull/60894
updated_at: 2019-06-04 12:12:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This actually needs to wait for a bit since neither Sway nor Waybar are compatible with 0.6.0 (backwards incompatible changes). Since those are the only packages that depend on wlroots atm, it doesn't really make sense to merge this update yet.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pygame: preConfigure fix
user_login: Dema
html_url: https://github.com/NixOS/nixpkgs/pull/60895
updated_at: 2019-05-04 06:35:09
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upstream moved build scripts to buildconfig folder and added some checks
  for SDL locations. This breaks `sed` expression that was replacing library
  paths. Fixes #60893

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: frei0r-plugins: enable on Darwin
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60896
updated_at: 2019-05-04 00:10:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upstream support Darwin platform
  \+ brew formula for this is pretty straightforward
  (so it should build out-of-the-box)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: 'mess' build failure
user_login: MicrosoftTakeover
html_url: https://github.com/NixOS/nixpkgs/issues/60897
updated_at: 2019-05-06 00:02:01
body:
  ## Issue description
  ```$ sudo nixos-rebuild switch --upgrade                                                                                                                                                                                                                                                                                        
  unpacking channels...
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/4m40jvi19qwshyb5j7prwniw9hbpw7mi-mess0139s.zip.drv
    /nix/store/7l1lmqifvvbff9znlm795hr0jd8a5723-mame0139s.zip.drv
    /nix/store/6mf5d6v4zn620y5pz4nvzqn7hf1sazpn-mess-0.139.drv
    /nix/store/99bim6bvjlcxdbf3qb7cfcyp0m68p6m7-user-environment.drv
    /nix/store/82b01j263idl6cr80784vwg2fzcsk6ap-etc.drv
    /nix/store/xdxhcjc8xx49vzbnm01nbc23l9afqy3n-nixos-system-nixos-workstation-19.09pre178260.190727db4ea.drv
  these paths will be fetched (0.01 MiB download, 0.07 MiB unpacked):
    /nix/store/3k6hy33b1dkdfldii7s5f4vy9lll74x5-mirrors-list
    /nix/store/7i3k0b1pxvva4x91pmv0p4ggirvqqjl3-gconf-3.2.6-dev
  copying path '/nix/store/7i3k0b1pxvva4x91pmv0p4ggirvqqjl3-gconf-3.2.6-dev' from 'https://cache.nixos.org'...
  copying path '/nix/store/3k6hy33b1dkdfldii7s5f4vy9lll74x5-mirrors-list' from 'https://cache.nixos.org'...
  building '/nix/store/7l1lmqifvvbff9znlm795hr0jd8a5723-mame0139s.zip.drv'...
  building '/nix/store/4m40jvi19qwshyb5j7prwniw9hbpw7mi-mess0139s.zip.drv'...

  trying http://www.progettosnaps.net/MESS/src/mess0139s.zip
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed

  trying https://github.com/mamedev/mame/releases/download/mame0139/mame0139s.zip
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100   603    0   603    0     0   1926      0 --:--:-- --:--:-- --:--:--  1926
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download mess0139s.zip from any mirror
  builder for '/nix/store/4m40jvi19qwshyb5j7prwniw9hbpw7mi-mess0139s.zip.drv' failed with exit code 1
  cannot build derivation '/nix/store/6mf5d6v4zn620y5pz4nvzqn7hf1sazpn-mess-0.139.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/99bim6bvjlcxdbf3qb7cfcyp0m68p6m7-user-environment.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/82b01j263idl6cr80784vwg2fzcsk6ap-etc.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/xdxhcjc8xx49vzbnm01nbc23l9afqy3n-nixos-system-nixos-workstation-19.09pre178260.190727db4ea.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/xdxhcjc8xx49vzbnm01nbc23l9afqy3n-nixos-system-nixos-workstation-19.09pre178260.190727db4ea.drv' failed
  ```


  ### Steps to reproduce
  Add mess package and rebuild.


  ## Technical details
  $ nix-shell -p nix-info --run "nix-info -m"                                                                                                                                                                                                  
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.09pre178260.190727db4ea (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178260.190727db4ea"`
   - channels(nix): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: raspberrypifw: 1.20181112 -> 1.20190401
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/60898
updated_at: 2019-05-10 02:42:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updates the Raspberry Pi firmware to the latest version.

  ###### Things done

  Tested booting with updated firmware on a Raspberry Pi 2.

  cc @dezgeg @tavyc 
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: GNOME apps updates
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60899
updated_at: 2019-05-04 02:04:43
body:
  ###### Motivation for this change
  See news in commit msg's for the really trivial changes.

  All binaries were executed successfully on my machine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Slow boot due to dhcpcd (tracking issue)
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/issues/60900
updated_at: 2019-07-12 10:48:02
body:
  ## Issue description

  At boot, the login window must wait for /run/nologin to be removed (see pam_nologin(8)) .
  This happens when systemd launches `systemd-user-sessions.service`, which removes `/run/nologin` when it is started, and creates it when it is stopped.

  Under the default NixOS configuration, there is a significant delay in this process due to systemd waiting for `dhcpcd.service` to fork. The root cause is a gross hack in upstream systemd, which seeks to provide clean termination of inbound SSH sessions by ordering `systemd-user-sessions.service` after `network.target`:
  https://github.com/systemd/systemd/pull/3078/commits/8c856804780681e135d98ca94d08afe247557770 fixes https://github.com/systemd/systemd/issues/2390
  This was done so that at shutdown, systemd will kill the SSH sessions (by stopping `systemd-user-sessions.service`) _before_ bringing down the network.

  The inevitable problem is that now, _local_ logins must wait at boot for `network.target`, which is silly. It wouldn't matter much, except that NixOS has `dhcpcd.service` configured to block `network.target` instead of just `network-online.target`: https://github.com/NixOS/nixpkgs/pull/44524
  It appears that this issue has gone largely unnoticed because other distros either don't use dhcpcd, use it in background mode, ignore the /run/nologin mechanism (which appears to be something of a relic - I can't find much discussion about it), or have `dhcpcd.service` blocking only `network-online.target`, in which case login will be blocked only by a few service initializations that don't take very long.

  #### Workarounds:
  Ordered best to worst, in my opinion. Any of these should be OK for home use.
  1. `systemd.services.systemd-user-sessions.enable = false;` (after rebuild do `rm /run/nologin`)
  2. Use systemd-networkd instead:
  `networking.dhcpcd.enable = false;`
  `systemd.network.enable = true;`
  `systemd.network.networks = {
    internet0 = {
      matchConfig = { Name = "<device>"; };
        networkConfig = { DHCP = "ipv4"; };
    };
  };` (where `<device>` is `eth0` or whatever)
  3. Make `dhcpcd` time out fast, and [unplug seatbelts](https://wiki.archlinux.org/index.php/Dhcpcd):
  `networking.dhcpcd.extraConfig = "timeout 1\nnoarp\nnodelay";`
  Seems to work when multiple interfaces are available. Man page says `If dhcpcd is working on a single interface then dhcpcd will exit when a timeout occurs.` I don't know what will happen in that case.
  4. Make `dhcpcd` fork to background immediately
  `systemd.services.dhcpcd.serviceConfig.ExecStart = pkgs.stdenv.lib.mkForce "@${pkgs.dhcpcd}/sbin/dhcpcd dhcpcd -b --quiet --config /nix/store/<...>-dhcpcd.conf";`
  The nixos module doesn't export the generated conf path, so it has to be found manually (`ps ax | grep dhcp`) and kept updated. Or replace it with a separate one.
  5. Disable pam_nologin.so (how?) - sounds like a Bad Idea
  6. Not recommended: attempting to reconfigure the ordering. It "works", but renders `network.target` inactive, presumably due systemd barfing on a cyclic dependency.

  #### Suggested solution for NixOS:

  - Override the ordering dependency somehow

  See also https://github.com/NixOS/nixpkgs/issues/50930, https://github.com/NixOS/nixpkgs/pull/58526

  ### Steps to reproduce
  Boot a NixOS machine with networking and dhcp(cd) enabled, but no network connection available.

  ### Expected behavior
  The machine should boot and present a login window just as quickly as with the network available.

  ### Actual behavior
  User is presented with a black screen for up to 30 seconds before login window appears.


state: closed
title: viu: init at 0.1 (fixes #60831)
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/pull/60901
updated_at: 2019-05-05 00:20:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  adds viu package, requested in #60831

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: copyKernels should be enabled with ZFS or else grub can break
user_login: jb55
html_url: https://github.com/NixOS/nixpkgs/issues/60902
updated_at: 2019-05-06 18:50:34
body:
  I had an "oh shi" moment recently where every entry in my grub boot menu failed to load and I couldn't boot into nixos, only getting this message:

  ```
  Error: external pointer tables not supported
  Error: you need to load the kernel first.
  ```

  after perusing the old nix-dev mailing list I ran into a message from 2017 by @spinus where he ran into the same issue with ZFS.

   I ended up fixing it by booting with a usb-stick and re-installing with `boot.loader.grub.copyKernels = true`

  A response by @CMCDragonkai explains:

  ```
  Hey glad you solvee it. So the problem was that you were using Grub to
  directly access ZFS root drive to get the kernel, but Nixos uses lots
  of hardlinks and Grub has a problem reading that. So the kernel is now
  copied to /boot. That's actually how it's done in gummiboot and
  probably other bootloaders.
  ```

  Not sure how common this edgecase is but it's terrible when you hit it. Perhaps this option can be turned on when using ZFS?


state: closed
title: networkmanager: sed from gnused, not coreutils! fix bad path
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60903
updated_at: 2019-05-08 03:50:59
body:
  ###### Motivation for this change

  Eep!
  Not sure how likely this is to be causing folks problems
  but definitely should be fixed!

  Don't we check udev rules for valid paths?
  Maybe we can add a check for this sort of thing,
  although TBH really hope there are no other instances.. !

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: networkmanager: match pre-meson pre-upgrade behavior more closely
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60904
updated_at: 2019-05-31 04:07:01
body:
  ###### Motivation for this change

  I don't have a great way to share this information
  as a link or something, haha, but try something
  like the following to see what's changed:

  ```
  $ vim -d <(nix log -f channel:nixos-unstable networkmanager) <(nix log -f channel:nixos-19.03 networkmanager)
  ```

  Particularly look at the post-configure dump of options.
  The version was changed as well, but even so it's unclear
  how many of these changes were intentional or desirable.

  Beyond the values in these commits, changes that may
  be worth discussing/revisitng:

  * asserts and warnings -- we used to specify `--disable-more-warnings`
    which doesn't trivially map (I don't think) but now we're end up
    with "more-logging: true" instead of "more-logging: no" and
    "more-asserts: 100" instead of "more-asserts: 0".
    I don't know this is bad or not but let's just make sure
    these are set as we'd like :).

  We added a number of deps that also enable features/changes
  but since they were blatant in the diff (add arg, add to buildInputs, etc)
  these are presumably what we want (but confirmation would be good).

  Related PRs and such:
  * #59916 - move to meson
  * f748cc85bd2539619aeb1d205120d5bee8e2520a
  * #60903 (submitted a few minutes ago, fixes invalid path for `sed`)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gimpPlugins.resynthesizer2: 2.0.1 → 2.0.3
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60905
updated_at: 2019-05-04 13:23:21
body:
  ###### Motivation for this change
  Fixes `makeFlags`: `$out` is not sufficient to install the binaries, let's use `placeholder`.

  Also update and clean up the expression.

  Closes: https://github.com/NixOS/nixpkgs/issues/60834

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [c] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @typedfern


state: closed
title: GNOME updates staging
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/60906
updated_at: 2019-05-07 22:04:42
body:
  ###### Motivation for this change
  Thing that probably needs most review here is https://github.com/NixOS/nixpkgs/commit/ce4645fc54f65065cdd2e45322c8127fbe2fd02c (folks uses meson!)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (not in this branch)
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: linux 4.19.38 broke zfs module
user_login: jnetod
html_url: https://github.com/NixOS/nixpkgs/issues/60907
updated_at: 2019-06-26 10:18:58
body:
  ## Issue description

  Last linux update  (https://github.com/NixOS/nixpkgs/commit/e0bf73dbde74e66167bd9ccf385a1fbc228c4036) on NixOS 18.09 broke zfs module.

  ### Steps to reproduce

  Using NixOS 18.09

  ```
  boot = {
      kernelPackages = pkgs.linuxPackages_latest;
      supportedFilesystems = [ "zfs" ];
  };
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.37, NixOS, 18.09.2543.41245517a98 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2548.f2132308c45, nixos-hardware"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```
  # nixos-rebuild switch
  building Nix...
  building the system configuration...
  these derivations will be built:
    /nix/store/2fk59rcy34fshcymysa8jb0xi5zmvhds-zfs-kernel-0.7.12-4.19.38.drv
    /nix/store/hs6nrrncrnhjzbbjgmalb1429mjaqxal-kernel-modules.drv
    /nix/store/0i998ig76gl4zrvprvxbvmc0fj4dda3v-kernel-modules-shrunk.drv
    /nix/store/5xgfmhh6gqk6ndhljad04fcc0ilh2d5w-stage-1-init.sh.drv
    /nix/store/191qxbj6cqr532y0qihvk6hdhxpca01f-initrd.drv
    /nix/store/6xs4g4i9nc2xwvbi0znqrl0mn4x5va4y-nixos-system-fedora-18.09.2548.f2132308c45.drv
  building '/nix/store/2fk59rcy34fshcymysa8jb0xi5zmvhds-zfs-kernel-0.7.12-4.19.38.drv'...
  unpacking sources
  unpacking source archive /nix/store/54k7xqn1k3hq9y9rdhgy4bh85kmyww3m-source
  source root is source
  patching sources
  applying patch /nix/store/7ll8b779q1gvr1n009059kz0h6qaf1w6-zfs-0.7.0-rc3...nixos-zfs-0.7.0-rc3.patch
  patching file Makefile.am
  patching file include/Makefile.am
  patching file include/linux/Makefile.am
  Hunk #1 succeeded at 22 (offset 1 line).
  patching file include/sys/Makefile.am
  Hunk #1 succeeded at 130 (offset 1 line).
  patching file include/sys/fm/Makefile.am
  patching file include/sys/fm/fs/Makefile.am
  patching file include/sys/fs/Makefile.am
  patching file module/Makefile.in
  Hunk #1 succeeded at 36 (offset 2 lines).
  Hunk #2 succeeded at 52 (offset 2 lines).
  patching script interpreter paths in scripts
  scripts/zpios-survey.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zloop.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-test/1th-16rc-4rs-1cs-4off.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-test/4th-1024rc-4rs-1cs-4off.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-test/16th-8192rc-4rs-1cs-4off.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-test/1x256th-65536rc-4rs-1cs-4off.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-test/256th-65536rc-4rs-1cs-4off.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/smb.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/dkms.postbuild: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/commitcheck.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-profile/zpios-profile.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-profile/zpios-profile-disk.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-profile/zpios-profile-pids.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-profile/zpios-profile-pre.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios-profile/zpios-profile-post.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpios.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/paxcheck.sh: interpreter directive changed from "/bin/sh" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/sh"
  scripts/zpios-sanity.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/enum-extract.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/bin/perl -w"
  scripts/kmodtool: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zfs.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zpool-create.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zfs2zol-patch.sed: interpreter directive changed from "/bin/sed -f" to "/nix/store/j2kj1w5glbr5pg39ssihqk5622jjsghs-gnused-4.5/bin/sed -f"
  scripts/zol2zfs-patch.sed: interpreter directive changed from "/bin/sed -f" to "/nix/store/j2kj1w5glbr5pg39ssihqk5622jjsghs-gnused-4.5/bin/sed -f"
  scripts/zfs-tests.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/dkms.mkconf: interpreter directive changed from "/bin/sh" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/sh"
  scripts/zimport.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/zfs-helpers.sh: interpreter directive changed from "/bin/bash" to "/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash"
  scripts/cstyle.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/jpdrxba87xm2kkxf7skdh8imszv5zc5n-perl-5.28.1/bin/perl"
  autoreconfPhase
  autoreconf: Entering directory `.'
  autoreconf: configure.ac: not using Gettext
  autoreconf: running: aclocal --force -I config
  autoreconf: configure.ac: tracing
  autoreconf: running: libtoolize --copy --force
  libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'config'.
  libtoolize: copying file 'config/ltmain.sh'
  libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'config'.
  libtoolize: copying file 'config/libtool.m4'
  libtoolize: copying file 'config/ltoptions.m4'
  libtoolize: copying file 'config/ltsugar.m4'
  libtoolize: copying file 'config/ltversion.m4'
  libtoolize: copying file 'config/lt~obsolete.m4'
  autoreconf: running: /nix/store/j9i8rzdnx55iidmqavb3xlgmfgplwj6s-autoconf-2.69/bin/autoconf --force
  autoreconf: running: /nix/store/j9i8rzdnx55iidmqavb3xlgmfgplwj6s-autoconf-2.69/bin/autoheader --force
  autoreconf: running: automake --add-missing --copy --force-missing
  configure.ac:49: installing 'config/compile'
  configure.ac:39: installing 'config/config.guess'
  configure.ac:39: installing 'config/config.sub'
  configure.ac:42: installing 'config/install-sh'
  configure.ac:42: installing 'config/missing'
  cmd/mount_zfs/Makefile.am: installing 'config/depcomp'
  autoreconf: Leaving directory `.'
  configuring
  autoreconf: Entering directory `.'
  autoreconf: configure.ac: not using Gettext
  autoreconf: running: aclocal --force -I config
  autoreconf: configure.ac: tracing
  autoreconf: running: libtoolize --copy --force
  libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'config'.
  libtoolize: copying file 'config/ltmain.sh'
  libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'config'.
  libtoolize: copying file 'config/libtool.m4'
  libtoolize: copying file 'config/ltoptions.m4'
  libtoolize: copying file 'config/ltsugar.m4'
  libtoolize: copying file 'config/ltversion.m4'
  libtoolize: copying file 'config/lt~obsolete.m4'
  autoreconf: running: /nix/store/j9i8rzdnx55iidmqavb3xlgmfgplwj6s-autoconf-2.69/bin/autoconf --force
  autoreconf: running: /nix/store/j9i8rzdnx55iidmqavb3xlgmfgplwj6s-autoconf-2.69/bin/autoheader --force
  autoreconf: running: automake --add-missing --copy --force-missing
  configure.ac:49: installing 'config/compile'
  configure.ac:42: installing 'config/missing'
  cmd/mount_zfs/Makefile.am: installing 'config/depcomp'
  autoreconf: Leaving directory `.'
  fixing libtool script ./config/ltmain.sh
  configure flags: --disable-static --disable-dependency-tracking --prefix=/nix/store/pdwdg4yh97ppwybj854db4q0slrl5m6i-zfs-kernel-0.7.12-4.19.38 --with-config=kernel --with-linux=/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/source --with-linux-obj=/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build --with-spl=/nix/store/5f60k8blgvjw230815029acq9zlbyd8q-spl-0.7.12-4.19.38/libexec/spl --libexecdir=/nix/store/pdwdg4yh97ppwybj854db4q0slrl5m6i-zfs-kernel-0.7.12-4.19.38/libexec
  checking for gawk... gawk
  checking metadata... META file
  checking build system type... x86_64-pc-linux-gnu
  checking host system type... x86_64-pc-linux-gnu
  checking target system type... x86_64-pc-linux-gnu
  checking whether to enable maintainer-specific portions of Makefiles... no
  checking whether make supports nested variables... yes
  checking for a BSD-compatible install... /nix/store/68z2cvbzws1pn0z8dhgfkmws75r2z7gm-coreutils-8.29/bin/install -c
  checking whether build environment is sane... yes
  checking for a thread-safe mkdir -p... /nix/store/68z2cvbzws1pn0z8dhgfkmws75r2z7gm-coreutils-8.29/bin/mkdir -p
  checking whether make sets $(MAKE)... yes
  checking for gcc... gcc
  checking whether the C compiler works... yes
  checking for C compiler default output file name... a.out
  checking for suffix of executables...
  checking whether we are cross compiling... no
  checking for suffix of object files... o
  checking whether we are using the GNU C compiler... yes
  checking whether gcc accepts -g... yes
  checking for gcc option to accept ISO C89... none needed
  checking whether gcc understands -c and -o together... yes
  checking whether make supports the include directive... yes (GNU style)
  checking dependency style of gcc... none
  checking how to print strings... printf
  checking for a sed that does not truncate output... /nix/store/j2kj1w5glbr5pg39ssihqk5622jjsghs-gnused-4.5/bin/sed
  checking for grep that handles long lines and -e... /nix/store/xkzmszz7vp1wdgbpyfvb1wns2qlx9mhz-gnugrep-3.1/bin/grep
  checking for egrep... /nix/store/xkzmszz7vp1wdgbpyfvb1wns2qlx9mhz-gnugrep-3.1/bin/grep -E
  checking for fgrep... /nix/store/xkzmszz7vp1wdgbpyfvb1wns2qlx9mhz-gnugrep-3.1/bin/grep -F
  checking for ld used by gcc... ld
  checking if the linker (ld) is GNU ld... yes
  checking for BSD- or MS-compatible name lister (nm)... nm
  checking the name lister (nm) interface... BSD nm
  checking whether ln -s works... yes
  checking the maximum length of command line arguments... 1572864
  checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
  checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
  checking for ld option to reload object files... -r
  checking for objdump... objdump
  checking how to recognize dependent libraries... pass_all
  checking for dlltool... dlltool
  checking how to associate runtime and link libraries... printf %s\n
  checking for archiver @FILE support... @
  checking for strip... strip
  checking for ranlib... ranlib
  checking command to parse nm output from gcc object... ok
  checking for sysroot... no
  checking for a working dd... /nix/store/68z2cvbzws1pn0z8dhgfkmws75r2z7gm-coreutils-8.29/bin/dd
  checking how to truncate binary pipes... /nix/store/68z2cvbzws1pn0z8dhgfkmws75r2z7gm-coreutils-8.29/bin/dd bs=4096 count=1
  ./configure: line 6821: /usr/bin/file: No such file or directory
  checking for mt... no
  checking if : is a manifest tool... no
  checking how to run the C preprocessor... gcc -E
  checking for ANSI C header files... yes
  checking for sys/types.h... yes
  checking for sys/stat.h... yes
  checking for stdlib.h... yes
  checking for string.h... yes
  checking for memory.h... yes
  checking for strings.h... yes
  checking for inttypes.h... yes
  checking for stdint.h... yes
  checking for unistd.h... yes
  checking for dlfcn.h... yes
  checking for objdir... .libs
  checking if gcc supports -fno-rtti -fno-exceptions... no
  checking for gcc option to produce PIC... -fPIC -DPIC
  checking if gcc PIC flag -fPIC -DPIC works... yes
  checking if gcc static flag -static works... no
  checking if gcc supports -c -o file.o... yes
  checking if gcc supports -c -o file.o... (cached) yes
  checking whether the gcc linker (ld) supports shared libraries... yes
  checking whether -lc should be explicitly linked in... no
  checking dynamic linker characteristics... GNU/Linux ld.so
  checking how to hardcode library paths into programs... immediate
  checking whether stripping libraries is possible... yes
  checking if libtool supports shared libraries... yes
  checking whether to build shared libraries... yes
  checking whether to build static libraries... no
  checking dependency style of gcc... none
  checking whether to build with code coverage support... no
  checking zfs author... OpenZFS on Linux
  checking zfs license... CDDL
  checking linux distribution...
  checking default package type... rpm
  checking default init directory... /nix/store/pdwdg4yh97ppwybj854db4q0slrl5m6i-zfs-kernel-0.7.12-4.19.38/etc/init.d
  checking default init script type... lsb
  checking default init config direectory... /etc/default
  checking whether initramfs-tools is available... no
  checking whether rpm is available... no
  checking whether rpmbuild is available... no
  checking whether spec files are available... yes (rpm/generic/*.spec.in)
  checking whether dpkg is available... no
  checking whether dpkg-buildpackage is available... no
  checking whether alien is available... no
  checking zfs config... kernel
  checking for -Wno-unused-but-set-variable support... yes
  checking for -Wno-bool-compare support... yes
  checking whether host toolchain supports SSE... yes
  checking whether host toolchain supports SSE2... yes
  checking whether host toolchain supports SSE3... yes
  checking whether host toolchain supports SSSE3... yes
  checking whether host toolchain supports SSE4.1... yes
  checking whether host toolchain supports SSE4.2... yes
  checking whether host toolchain supports AVX... yes
  checking whether host toolchain supports AVX2... yes
  checking whether host toolchain supports AVX512F... yes
  checking whether host toolchain supports AVX512CD... yes
  checking whether host toolchain supports AVX512DQ... yes
  checking whether host toolchain supports AVX512BW... yes
  checking whether host toolchain supports AVX512IFMA... yes
  checking whether host toolchain supports AVX512VBMI... yes
  checking whether host toolchain supports AVX512PF... yes
  checking whether host toolchain supports AVX512ER... yes
  checking whether host toolchain supports AVX512VL... yes
  checking for target asm dir... asm-x86_64
  checking kernel source directory... /nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/source
  checking kernel build directory... /nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build
  checking kernel source version... 4.19.38
  checking kernel file name for module symbols... Module.symvers
  checking spl source directory... /nix/store/5f60k8blgvjw230815029acq9zlbyd8q-spl-0.7.12-4.19.38/libexec/spl
  checking spl build directory... /nix/store/5f60k8blgvjw230815029acq9zlbyd8q-spl-0.7.12-4.19.38/libexec/spl/4.19.38
  checking spl source version... 0.7.12-1
  checking spl file name for module symbols... Module.symvers
  checking whether modules can be built... yes
  checking for compile-time stack validation (objtool)... yes
  checking whether kernel was built with 16K or larger stacks... yes
  checking whether kernel was built with CONFIG_DEBUG_LOCK_ALLOC... no
  checking whether DECLARE_EVENT_CLASS() is available... no
  checking whether current->bio_tail exists... no
  checking whether current->bio_list exists... yes
  checking whether super_block->s_user_ns exists... yes
  checking whether submit_bio() wants 1 arg... yes
  checking whether bops->check_events() exists... yes
  checking whether bops->release() is void... void
  checking whether kernel defines fmode_t... yes
  checking whether blkdev_get() wants 3 args... yes
  checking whether blkdev_get_by_path() is available... yes
  checking whether open_bdev_exclusive() is available... no
  checking whether lookup_bdev() wants 1 arg... yes
  checking whether invalidate_bdev() wants 1 arg... yes
  checking whether bdev_logical_block_size() is available... yes
  checking whether bdev_physical_block_size() is available... yes
  checking whether bio has bi_iter... yes
  checking whether BIO_RW_FAILFAST_* are defined... no
  checking whether bio_set_dev() exists... yes
  checking whether REQ_FAILFAST_MASK is defined... yes
  checking whether REQ_OP_DISCARD is defined... yes
  checking whether REQ_OP_SECURE_ERASE is defined... yes
  checking whether REQ_OP_FLUSH is defined... yes
  checking whether bio->bi_opf is defined... yes
  checking whether bio_end_io_t wants 1 arg... yes
  checking whether bio->bi_status exists... yes
  checking whether BIO_RW_BARRIER is defined... no
  checking whether BIO_RW_DISCARD is defined... no
  checking whether blk_queue bdi is dynamic... yes
  checking whether blk_queue_flag_clear() exists... yes
  checking whether blk_queue_flag_set() exists... yes
  checking whether blk_queue_flush() is available... no
  checking whether blk_queue_write_cache() exists... yes
  checking whether blk_queue_write_cache() is GPL-only... yes
  checking whether blk_queue_max_hw_sectors() is available... yes
  checking whether blk_queue_max_segments() is available... yes
  checking whether the BIO_RW_UNPLUG enum is available... no
  checking whether struct blk_plug is available... yes
  checking whether get_disk_and_module() is available... yes
  checking whether get_disk_ro() is available... yes
  checking whether get_gendisk() is available... yes
  checking whether bio_set_op_attrs is available... yes
  checking whether generic_readlink is global... no
  checking whether ql->discard_granularity is available... yes
  checking whether super_block uses const struct xattr_handler... yes
  checking whether xattr_handler has name... yes
  checking whether xattr_handler->get() wants both dentry and inode... yes
  checking whether xattr_handler->set() wants both dentry and inode... yes
  checking whether xattr_handler->list() wants simple... yes
  checking whether inode_owner_or_capable() exists... yes
  checking whether posix_acl_from_xattr() needs user_ns... yes
  checking whether posix_acl_release() is available... yes
  checking whether posix_acl_release() is GPL-only... yes
  checking whether set_cached_acl() is usable... yes
  checking whether posix_acl_chmod exists... no
  checking whether __posix_acl_chmod exists... yes
  checking whether posix_acl_equiv_mode() wants umode_t... yes
  checking whether posix_acl_valid() wants user namespace... yes
  checking whether iops->permission() exists... yes
  checking whether iops->permission() wants nameidata... no
  checking whether iops->check_acl() exists... no
  checking whether iops->check_acl() wants flags... no
  checking whether iops->get_acl() exists... yes
  checking whether iops->set_acl() exists... yes
  checking whether iops->getattr() takes a path... yes
  checking whether iops->getattr() takes a vfsmount... no
  checking whether inode_set_flags() exists... yes
  checking whether inode_set_iversion() exists... yes
  checking whether uncached_acl_sentinel() exists... yes
  checking whether sops->show_options() wants dentry... yes
  checking whether file_inode() is available... yes
  checking whether file_dentry() is available... yes
  checking whether fops->fsync() wants... range
  checking whether sops->evict_inode() exists... yes
  checking whether sops->dirty_inode() wants flags... yes
  checking whether sops->nr_cached_objects() exists... no
  checking whether sops->free_cached_objects() exists... no
  checking whether fops->fallocate() exists... yes
  checking whether iops->fallocate() exists... no
  checking whether fops->aio_fsync() exists... no
  checking whether iops->create()/mkdir()/mknod() take umode_t... yes
  checking whether iops->lookup() passes nameidata... no
  checking whether iops->create() passes nameidata... no
  checking whether iops->get_link() passes delayed... yes
  checking whether i_op->tmpfile() exists... yes
  checking whether iops->truncate_range() exists... no
  checking whether dops->d_automount() exists... yes
  checking whether eops->encode_fh() wants inode... yes
  checking whether eops->commit_metadata() exists... yes
  checking whether clear_inode() is available... yes
  checking whether setattr_prepare() is available... yes
  checking whether insert_inode_locked() is available... yes
  checking whether d_make_root() is available... yes
  checking whether d_obtain_alias() is available... yes
  checking whether d_prune_aliases() is available... yes
  checking whether d_set_d_op() is available... yes
  checking whether dops->d_revalidate() takes struct nameidata... no
  checking whether dentry uses const struct dentry_operations... yes
  checking whether truncate_setsize() is available... yes
  checking whether security_inode_init_security wants 6 args... no
  checking whether security_inode_init_security wants callback... yes
  checking whether fst->mount() exists... yes
  checking whether super_block has s_shrink... no
  checking whether shrink_control has nid... yes
  checking whether super_block has s_instances list_head... no
  checking whether super_block has s_d_op... yes
  checking whether super_setup_bdi_name() exists... yes
  checking whether set_nlink() is available... yes
  checking whether elevator_change() is available... no
  checking whether sget() wants 5 args... yes
  checking whether lseek_execute() is available... no
  checking whether fops->iterate_shared() is available... yes
  checking whether fops->read/write_iter() are available... yes
  checking whether new_sync_read/write() are available... no
  checking whether generic_write_checks() takes kiocb... yes
  checking whether kmap_atomic wants 1 args... yes
  checking whether follow_down_one() is available... yes
  checking whether make_request_fn() returns int... no
  checking whether make_request_fn() returns void... no
  checking whether make_request_fn() returns blk_qc_t... yes
  checking whether 3 arg generic IO accounting symbols are available... no
  checking whether 4 arg generic IO accounting symbols are available... yes
  checking whether asm/fpu/api.h exists... no
  checking whether i_(uid|gid)_(read|write) exist... yes
  checking whether module_param_call() is hardened... yes
  checking whether iops->rename() wants flags... yes
  checking whether generic_setxattr() exists... no
  checking whether current_time() exists... yes
  checking whether global_node_page_state() exists... yes
  checking whether global_zone_page_state() exists... yes
  checking whether enum node_stat_item contains NR_FILE_PAGES... yes
  checking whether enum node_stat_item contains NR_INACTIVE_ANON... yes
  checking whether enum node_stat_item contains NR_INACTIVE_FILE... yes
  checking whether enum node_stat_item contains NR_SLAB_RECLAIMABLE... yes
  checking whether enum zone_stat_item contains NR_FILE_PAGES... no
  checking whether enum zone_stat_item contains NR_INACTIVE_ANON... no
  checking whether enum zone_stat_item contains NR_INACTIVE_FILE... no
  checking whether enum zone_stat_item contains NR_SLAB_RECLAIMABLE... no
  checking global_page_state enums are sane... yes
  checking whether posix_acl has refcount_t... yes
  checking whether ns_capable exists... yes
  checking whether cred_t->user_ns exists... yes
  checking whether kuid_has_mapping/kgid_has_mapping exist... yes
  checking whether in_compat_syscall() is available... yes
  checking whether assertion support will be enabled... no
  checking whether debuginfo support will be forced... no
  checking that generated files are newer than configure... done
  configure: creating ./config.status
  config.status: creating Makefile
  config.status: creating udev/Makefile
  config.status: creating udev/rules.d/Makefile
  config.status: creating etc/Makefile
  config.status: creating etc/init.d/Makefile
  config.status: creating etc/zfs/Makefile
  config.status: creating etc/systemd/Makefile
  config.status: creating etc/systemd/system/Makefile
  config.status: creating etc/sudoers.d/Makefile
  config.status: creating etc/modules-load.d/Makefile
  config.status: creating man/Makefile
  config.status: creating man/man1/Makefile
  config.status: creating man/man5/Makefile
  config.status: creating man/man8/Makefile
  config.status: creating lib/Makefile
  config.status: creating lib/libspl/Makefile
  config.status: creating lib/libspl/asm-generic/Makefile
  config.status: creating lib/libspl/asm-i386/Makefile
  config.status: creating lib/libspl/asm-x86_64/Makefile
  config.status: creating lib/libspl/include/Makefile
  config.status: creating lib/libspl/include/ia32/Makefile
  config.status: creating lib/libspl/include/ia32/sys/Makefile
  config.status: creating lib/libspl/include/rpc/Makefile
  config.status: creating lib/libspl/include/sys/Makefile
  config.status: creating lib/libspl/include/sys/dktp/Makefile
  config.status: creating lib/libspl/include/util/Makefile
  config.status: creating lib/libavl/Makefile
  config.status: creating lib/libefi/Makefile
  config.status: creating lib/libicp/Makefile
  config.status: creating lib/libnvpair/Makefile
  config.status: creating lib/libunicode/Makefile
  config.status: creating lib/libuutil/Makefile
  config.status: creating lib/libzpool/Makefile
  config.status: creating lib/libzfs/libzfs.pc
  config.status: creating lib/libzfs/libzfs_core.pc
  config.status: creating lib/libzfs/Makefile
  config.status: creating lib/libzfs_core/Makefile
  config.status: creating lib/libshare/Makefile
  config.status: creating cmd/Makefile
  config.status: creating cmd/zdb/Makefile
  config.status: creating cmd/zhack/Makefile
  config.status: creating cmd/zfs/Makefile
  config.status: creating cmd/zinject/Makefile
  config.status: creating cmd/zpool/Makefile
  config.status: creating cmd/zstreamdump/Makefile
  config.status: creating cmd/ztest/Makefile
  config.status: creating cmd/zpios/Makefile
  config.status: creating cmd/mount_zfs/Makefile
  config.status: creating cmd/fsck_zfs/Makefile
  config.status: creating cmd/zvol_id/Makefile
  config.status: creating cmd/vdev_id/Makefile
  config.status: creating cmd/arcstat/Makefile
  config.status: creating cmd/dbufstat/Makefile
  config.status: creating cmd/arc_summary/Makefile
  config.status: creating cmd/zed/Makefile
  config.status: creating cmd/raidz_test/Makefile
  config.status: creating cmd/zgenhostid/Makefile
  config.status: creating contrib/Makefile
  config.status: creating contrib/bash_completion.d/Makefile
  config.status: creating contrib/dracut/Makefile
  config.status: creating contrib/dracut/02zfsexpandknowledge/Makefile
  config.status: creating contrib/dracut/90zfs/Makefile
  config.status: creating contrib/initramfs/Makefile
  config.status: creating module/Makefile
  config.status: creating module/avl/Makefile
  config.status: creating module/nvpair/Makefile
  config.status: creating module/unicode/Makefile
  config.status: creating module/zcommon/Makefile
  config.status: creating module/zfs/Makefile
  config.status: creating module/zpios/Makefile
  config.status: creating module/icp/Makefile
  config.status: creating include/Makefile
  config.status: creating include/linux/Makefile
  config.status: creating include/sys/Makefile
  config.status: creating include/sys/fs/Makefile
  config.status: creating include/sys/fm/Makefile
  config.status: creating include/sys/fm/fs/Makefile
  config.status: creating include/sys/crypto/Makefile
  config.status: creating include/sys/sysevent/Makefile
  config.status: creating scripts/Makefile
  config.status: creating scripts/zpios-profile/Makefile
  config.status: creating scripts/zpios-test/Makefile
  config.status: creating scripts/zpool-config/Makefile
  config.status: creating scripts/common.sh
  config.status: creating tests/Makefile
  config.status: creating tests/test-runner/Makefile
  config.status: creating tests/test-runner/cmd/Makefile
  config.status: creating tests/test-runner/include/Makefile
  config.status: creating tests/test-runner/man/Makefile
  config.status: creating tests/runfiles/Makefile
  config.status: creating tests/zfs-tests/Makefile
  config.status: creating tests/zfs-tests/callbacks/Makefile
  config.status: creating tests/zfs-tests/cmd/Makefile
  config.status: creating tests/zfs-tests/cmd/chg_usr_exec/Makefile
  config.status: creating tests/zfs-tests/cmd/user_ns_exec/Makefile
  config.status: creating tests/zfs-tests/cmd/devname2devid/Makefile
  config.status: creating tests/zfs-tests/cmd/dir_rd_update/Makefile
  config.status: creating tests/zfs-tests/cmd/file_check/Makefile
  config.status: creating tests/zfs-tests/cmd/file_trunc/Makefile
  config.status: creating tests/zfs-tests/cmd/file_write/Makefile
  config.status: creating tests/zfs-tests/cmd/largest_file/Makefile
  config.status: creating tests/zfs-tests/cmd/mkbusy/Makefile
  config.status: creating tests/zfs-tests/cmd/mkfile/Makefile
  config.status: creating tests/zfs-tests/cmd/mkfiles/Makefile
  config.status: creating tests/zfs-tests/cmd/mktree/Makefile
  config.status: creating tests/zfs-tests/cmd/mmap_exec/Makefile
  config.status: creating tests/zfs-tests/cmd/mmap_libaio/Makefile
  config.status: creating tests/zfs-tests/cmd/mmapwrite/Makefile
  config.status: creating tests/zfs-tests/cmd/randfree_file/Makefile
  config.status: creating tests/zfs-tests/cmd/readmmap/Makefile
  config.status: creating tests/zfs-tests/cmd/rename_dir/Makefile
  config.status: creating tests/zfs-tests/cmd/rm_lnkcnt_zero_file/Makefile
  config.status: creating tests/zfs-tests/cmd/threadsappend/Makefile
  config.status: creating tests/zfs-tests/cmd/xattrtest/Makefile
  config.status: creating tests/zfs-tests/include/Makefile
  config.status: creating tests/zfs-tests/include/default.cfg
  config.status: creating tests/zfs-tests/tests/Makefile
  config.status: creating tests/zfs-tests/tests/functional/Makefile
  config.status: creating tests/zfs-tests/tests/functional/acl/Makefile
  config.status: creating tests/zfs-tests/tests/functional/acl/posix/Makefile
  config.status: creating tests/zfs-tests/tests/functional/atime/Makefile
  config.status: creating tests/zfs-tests/tests/functional/bootfs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cache/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cachefile/Makefile
  config.status: creating tests/zfs-tests/tests/functional/casenorm/Makefile
  config.status: creating tests/zfs-tests/tests/functional/checksum/Makefile
  config.status: creating tests/zfs-tests/tests/functional/chattr/Makefile
  config.status: creating tests/zfs-tests/tests/functional/clean_mirror/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zdb/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_clone/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_copies/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_create/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_destroy/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_get/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_inherit/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_mount/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_promote/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_property/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_receive/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_rename/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_reservation/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_rollback/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_send/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_set/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_share/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_snapshot/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_unmount/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_unshare/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zfs_upgrade/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_add/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_attach/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_clear/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_create/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_destroy/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_detach/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_expand/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_export/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_get/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_history/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_import/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_labelclear/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_offline/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_online/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_remove/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_replace/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_scrub/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_set/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_status/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_sync/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_root/zpool_upgrade/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_user/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_user/misc/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_user/zfs_list/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_user/zpool_iostat/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cli_user/zpool_list/Makefile
  config.status: creating tests/zfs-tests/tests/functional/compression/Makefile
  config.status: creating tests/zfs-tests/tests/functional/cp_files/Makefile
  config.status: creating tests/zfs-tests/tests/functional/ctime/Makefile
  config.status: creating tests/zfs-tests/tests/functional/delegate/Makefile
  config.status: creating tests/zfs-tests/tests/functional/devices/Makefile
  config.status: creating tests/zfs-tests/tests/functional/events/Makefile
  config.status: creating tests/zfs-tests/tests/functional/exec/Makefile
  config.status: creating tests/zfs-tests/tests/functional/fault/Makefile
  config.status: creating tests/zfs-tests/tests/functional/features/async_destroy/Makefile
  config.status: creating tests/zfs-tests/tests/functional/features/large_dnode/Makefile
  config.status: creating tests/zfs-tests/tests/functional/features/Makefile
  config.status: creating tests/zfs-tests/tests/functional/grow_pool/Makefile
  config.status: creating tests/zfs-tests/tests/functional/grow_replicas/Makefile
  config.status: creating tests/zfs-tests/tests/functional/history/Makefile
  config.status: creating tests/zfs-tests/tests/functional/inheritance/Makefile
  config.status: creating tests/zfs-tests/tests/functional/inuse/Makefile
  config.status: creating tests/zfs-tests/tests/functional/kstat/Makefile
  config.status: creating tests/zfs-tests/tests/functional/large_files/Makefile
  config.status: creating tests/zfs-tests/tests/functional/largest_pool/Makefile
  config.status: creating tests/zfs-tests/tests/functional/link_count/Makefile
  config.status: creating tests/zfs-tests/tests/functional/libzfs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/migration/Makefile
  config.status: creating tests/zfs-tests/tests/functional/mmap/Makefile
  config.status: creating tests/zfs-tests/tests/functional/mmp/Makefile
  config.status: creating tests/zfs-tests/tests/functional/mount/Makefile
  config.status: creating tests/zfs-tests/tests/functional/mv_files/Makefile
  config.status: creating tests/zfs-tests/tests/functional/nestedfs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/no_space/Makefile
  config.status: creating tests/zfs-tests/tests/functional/nopwrite/Makefile
  config.status: creating tests/zfs-tests/tests/functional/online_offline/Makefile
  config.status: creating tests/zfs-tests/tests/functional/pool_names/Makefile
  config.status: creating tests/zfs-tests/tests/functional/poolversion/Makefile
  config.status: creating tests/zfs-tests/tests/functional/privilege/Makefile
  config.status: creating tests/zfs-tests/tests/functional/quota/Makefile
  config.status: creating tests/zfs-tests/tests/functional/raidz/Makefile
  config.status: creating tests/zfs-tests/tests/functional/redundancy/Makefile
  config.status: creating tests/zfs-tests/tests/functional/refquota/Makefile
  config.status: creating tests/zfs-tests/tests/functional/refreserv/Makefile
  config.status: creating tests/zfs-tests/tests/functional/rename_dirs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/replacement/Makefile
  config.status: creating tests/zfs-tests/tests/functional/reservation/Makefile
  config.status: creating tests/zfs-tests/tests/functional/rootpool/Makefile
  config.status: creating tests/zfs-tests/tests/functional/rsend/Makefile
  config.status: creating tests/zfs-tests/tests/functional/scrub_mirror/Makefile
  config.status: creating tests/zfs-tests/tests/functional/slog/Makefile
  config.status: creating tests/zfs-tests/tests/functional/snapshot/Makefile
  config.status: creating tests/zfs-tests/tests/functional/snapused/Makefile
  config.status: creating tests/zfs-tests/tests/functional/sparse/Makefile
  config.status: creating tests/zfs-tests/tests/functional/threadsappend/Makefile
  config.status: creating tests/zfs-tests/tests/functional/tmpfile/Makefile
  config.status: creating tests/zfs-tests/tests/functional/truncate/Makefile
  config.status: creating tests/zfs-tests/tests/functional/user_namespace/Makefile
  config.status: creating tests/zfs-tests/tests/functional/userquota/Makefile
  config.status: creating tests/zfs-tests/tests/functional/upgrade/Makefile
  config.status: creating tests/zfs-tests/tests/functional/vdev_zaps/Makefile
  config.status: creating tests/zfs-tests/tests/functional/write_dirs/Makefile
  config.status: creating tests/zfs-tests/tests/functional/xattr/Makefile
  config.status: creating tests/zfs-tests/tests/functional/zvol/Makefile
  config.status: creating tests/zfs-tests/tests/functional/zvol/zvol_cli/Makefile
  config.status: creating tests/zfs-tests/tests/functional/zvol/zvol_ENOSPC/Makefile
  config.status: creating tests/zfs-tests/tests/functional/zvol/zvol_misc/Makefile
  config.status: creating tests/zfs-tests/tests/functional/zvol/zvol_swap/Makefile
  config.status: creating tests/zfs-tests/tests/perf/Makefile
  config.status: creating tests/zfs-tests/tests/perf/fio/Makefile
  config.status: creating tests/zfs-tests/tests/perf/regression/Makefile
  config.status: creating tests/zfs-tests/tests/perf/scripts/Makefile
  config.status: creating tests/zfs-tests/tests/stress/Makefile
  config.status: creating rpm/Makefile
  config.status: creating rpm/redhat/Makefile
  config.status: creating rpm/redhat/zfs.spec
  config.status: creating rpm/redhat/zfs-kmod.spec
  config.status: creating rpm/redhat/zfs-dkms.spec
  config.status: creating rpm/generic/Makefile
  config.status: creating rpm/generic/zfs.spec
  config.status: creating rpm/generic/zfs-kmod.spec
  config.status: creating rpm/generic/zfs-dkms.spec
  config.status: creating zfs-script-config.sh
  config.status: creating zfs.release
  config.status: creating zfs_config.h
  config.status: executing depfiles commands
  config.status: executing libtool commands
  building
  build flags: -j1 -l1 SHELL=/nix/store/b9p787yqaqi313l9rr0491igjwyzqfmw-bash-4.4-p23/bin/bash
  make  all-recursive
  make[1]: Entering directory '/build/source'
  Making all in include
  make[2]: Entering directory '/build/source/include'
  Making all in linux
  make[3]: Entering directory '/build/source/include/linux'
  make[3]: Nothing to be done for 'all'.
  make[3]: Leaving directory '/build/source/include/linux'
  Making all in sys
  make[3]: Entering directory '/build/source/include/sys'
  Making all in fm
  make[4]: Entering directory '/build/source/include/sys/fm'
  Making all in fs
  make[5]: Entering directory '/build/source/include/sys/fm/fs'
  make[5]: Nothing to be done for 'all'.
  make[5]: Leaving directory '/build/source/include/sys/fm/fs'
  make[5]: Entering directory '/build/source/include/sys/fm'
  make[5]: Nothing to be done for 'all-am'.
  make[5]: Leaving directory '/build/source/include/sys/fm'
  make[4]: Leaving directory '/build/source/include/sys/fm'
  Making all in fs
  make[4]: Entering directory '/build/source/include/sys/fs'
  make[4]: Nothing to be done for 'all'.
  make[4]: Leaving directory '/build/source/include/sys/fs'
  Making all in crypto
  make[4]: Entering directory '/build/source/include/sys/crypto'
  make[4]: Nothing to be done for 'all'.
  make[4]: Leaving directory '/build/source/include/sys/crypto'
  Making all in sysevent
  make[4]: Entering directory '/build/source/include/sys/sysevent'
  make[4]: Nothing to be done for 'all'.
  make[4]: Leaving directory '/build/source/include/sys/sysevent'
  make[4]: Entering directory '/build/source/include/sys'
  make[4]: Nothing to be done for 'all-am'.
  make[4]: Leaving directory '/build/source/include/sys'
  make[3]: Leaving directory '/build/source/include/sys'
  make[3]: Entering directory '/build/source/include'
  make[3]: Nothing to be done for 'all-am'.
  make[3]: Leaving directory '/build/source/include'
  make[2]: Leaving directory '/build/source/include'
  Making all in rpm
  make[2]: Entering directory '/build/source/rpm'
  Making all in generic
  make[3]: Entering directory '/build/source/rpm/generic'
  make[3]: Nothing to be done for 'all'.
  make[3]: Leaving directory '/build/source/rpm/generic'
  Making all in redhat
  make[3]: Entering directory '/build/source/rpm/redhat'
  make[3]: Nothing to be done for 'all'.
  make[3]: Leaving directory '/build/source/rpm/redhat'
  make[3]: Entering directory '/build/source/rpm'
  make[3]: Nothing to be done for 'all-am'.
  make[3]: Leaving directory '/build/source/rpm'
  make[2]: Leaving directory '/build/source/rpm'
  Making all in module
  make[2]: Entering directory '/build/source/module'
  list='icp'; for targetdir in $list; do \
          make -C $targetdir; \
  done
  make[3]: Entering directory '/build/source/module/icp'
  mkdir -p api core spi io os algs algs/aes algs/edonr algs/modes algs/sha1 algs/sha2 algs/skein asm-x86_64 asm-x86_64/aes asm-x86_64/modes asm-x86_64/sha1 asm-x86_64/sha2 asm-i386 asm-generic
  make[3]: Leaving directory '/build/source/module/icp'
  chmod +w Module.symvers
  make -C /nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build SUBDIRS=`pwd`  O=/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build CONFIG_ZFS=m modules
  make[3]: Entering directory '/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build'
    CC [M]  /build/source/module/avl/avl.o
    LD [M]  /build/source/module/avl/zavl.o
    CC [M]  /build/source/module/icp/illumos-crypto.o
    CC [M]  /build/source/module/icp/api/kcf_cipher.o
    CC [M]  /build/source/module/icp/api/kcf_digest.o
    CC [M]  /build/source/module/icp/api/kcf_mac.o
    CC [M]  /build/source/module/icp/api/kcf_miscapi.o
    CC [M]  /build/source/module/icp/api/kcf_ctxops.o
    CC [M]  /build/source/module/icp/core/kcf_callprov.o
    CC [M]  /build/source/module/icp/core/kcf_prov_tabs.o
    CC [M]  /build/source/module/icp/core/kcf_sched.o
    CC [M]  /build/source/module/icp/core/kcf_mech_tabs.o
    CC [M]  /build/source/module/icp/core/kcf_prov_lib.o
    CC [M]  /build/source/module/icp/spi/kcf_spi.o
    CC [M]  /build/source/module/icp/io/aes.o
    CC [M]  /build/source/module/icp/io/edonr_mod.o
    CC [M]  /build/source/module/icp/io/sha1_mod.o
    CC [M]  /build/source/module/icp/io/sha2_mod.o
    CC [M]  /build/source/module/icp/io/skein_mod.o
    CC [M]  /build/source/module/icp/os/modhash.o
    CC [M]  /build/source/module/icp/os/modconf.o
    CC [M]  /build/source/module/icp/algs/modes/cbc.o
    CC [M]  /build/source/module/icp/algs/modes/ccm.o
    CC [M]  /build/source/module/icp/algs/modes/ctr.o
    CC [M]  /build/source/module/icp/algs/modes/ecb.o
    CC [M]  /build/source/module/icp/algs/modes/gcm.o
  In file included from /build/source/module/icp/algs/modes/gcm.c:26:0:
  /build/source/include/linux/simd_x86.h:98:10: fatal error: asm/i387.h: No such file or directory
   #include <asm/i387.h>
            ^~~~~~~~~~~~
  compilation terminated.
  make[7]: *** [/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/source/scripts/Makefile.build:304: /build/source/module/icp/algs/modes/gcm.o] Error 1
  make[6]: *** [/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/source/scripts/Makefile.build:544: /build/source/module/icp] Error 2
  make[5]: *** [/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/source/Makefile:1524: _module_/build/source/module] Error 2
  make[4]: *** [Makefile:146: sub-make] Error 2
  make[3]: *** [Makefile:24: __sub-make] Error 2
  make[3]: Leaving directory '/nix/store/q6d50yz94bprkymakpb100cwpl6c87xb-linux-4.19.38-dev/lib/modules/4.19.38/build'
  make[2]: *** [Makefile:29: modules] Error 2
  make[2]: Leaving directory '/build/source/module'
  make[1]: *** [Makefile:739: all-recursive] Error 1
  make[1]: Leaving directory '/build/source'
  make: *** [Makefile:608: all] Error 2
  builder for '/nix/store/2fk59rcy34fshcymysa8jb0xi5zmvhds-zfs-kernel-0.7.12-4.19.38.drv' failed with exit code 2
  cannot build derivation '/nix/store/hs6nrrncrnhjzbbjgmalb1429mjaqxal-kernel-modules.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/6xs4g4i9nc2xwvbi0znqrl0mn4x5va4y-nixos-system-fedora-18.09.2548.f2132308c45.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/6xs4g4i9nc2xwvbi0znqrl0mn4x5va4y-nixos-system-fedora-18.09.2548.f2132308c45.drv' failed

  ```


state: open
title: gnome3.gnome-boxes fails to launch vm
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/60908
updated_at: 2019-05-04 11:47:45
body:
  ## Issue description

  `gnome-boxes` is failing to launch my virtual machines on my NixOS unstable system:

  ```
  $ gnome-boxes &
  [1] 3518

  (gnome-boxes:3518): Gtk-WARNING **: 23:58:07.576: GtkFlowBox with a model will ignore sort and filter functions

  (gnome-boxes:3518): Gtk-WARNING **: 23:58:07.577: GtkListBox with a model will ignore sort and filter functions

  (gnome-boxes:3518): Boxes-WARNING **: 23:58:11.477: machine.vala:633: Failed to start Fedora-Xfce-Live-x86_64-29-20181029: Unable to start domain: internal error: qemu unexpectedly closed the monitor: 2019-05-04 02:58:11.434+0000: Domain id=3 is tainted: host-cpu
  gbm: failed to open any driver (search paths /run/opengl-driver/lib/dri)
  gbm: Last dlopen error: /run/opengl-driver/lib/dri/i965_dri.so: cannot open shared object file: No such file or directory
  failed to load driver: i965
  gbm: failed to open any driver (search paths /run/opengl-driver/lib/dri)
  gbm: Last dlopen error: /run/opengl-driver/lib/dri/kms_swrast_dri.so: cannot open shared object file: No such file or directory
  failed to load driver: kms_swrast
  gbm: failed to open any driver (search paths /run/opengl-driver/lib/dri)
  gbm: Last dlopen error: /run/opengl-driver/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory
  failed to load swrast driver
  2019-05-04T02:58:11.475275Z qemu-system-x86_64: egl: gbm_create_device failed
  2019-05-04T02:58:11.475326Z qemu-system-x86_64: Failed to initialize EGL render node for SPICE GL
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.10, NixOS, 19.09pre177651.aeb464dfd37 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre178260.190727db4ea"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: networkmanager: Stop using libredirect for building introspection
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/60909
updated_at: 2019-05-05 14:10:42
body:
  ###### Motivation for this change
  A properer fix for https://github.com/NixOS/nixpkgs/issues/60807

  cc @worldofpeace @dtzWill 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport: fish: 3.0.1 -> 3.0.2
user_login: matklad
html_url: https://github.com/NixOS/nixpkgs/pull/60910
updated_at: 2019-05-04 18:38:10
body:
  ###### Motivation for this change

  Backport of https://github.com/NixOS/nixpkgs/pull/56652 to 19.03, which includes fix for https://github.com/fish-shell/fish-shell/issues/5647.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: browserpass: 3.0.1 -> 3.0.6
user_login: Nekdo
html_url: https://github.com/NixOS/nixpkgs/pull/60911
updated_at: 2019-05-04 21:47:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update browserpass from 3.0.1 to 3.0.6.
  Cherry pick commit a10239f92cf04a10f0a92ee986629afef35f1399.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip -b release-19.03"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xmonad-with-packagages needlessly conflicts with ghc
user_login: anka-213
html_url: https://github.com/NixOS/nixpkgs/issues/60914
updated_at: 2019-05-04 21:59:28
body:
  ## Issue description
  For some reason the man page for ghc is included in the output for xmonad-with-packages, which means that it cannot (easily) be installed together with ghc.


  ### Steps to reproduce

  ```
  $ nix-env -f '<nixpkgs>' -iA ghc xmonad-with-packages                                                                                   
  installing 'ghc-8.6.5'
  installing 'xmonad-with-packages-8.6.5'
  building '/nix/store/37s37cjsv5kypgpr2xg5q19rgf5bm22b-user-environment.drv'...
  error: packages '/nix/store/zghq088rbvlikc2ns6adgmhks423mcin-ghc-8.6.5/share/man/man1/ghc.1.gz' and '/nix/store/rhpizad2ys1c99kgyi1fah1fcqzz81wv-xmonad-with-packages-8.6.5/share/man/man1/ghc.1.gz' have the same priority 5; use 'nix-env --set-flag priority NUMBER INSTALLED_PKGNAME' to change the priority of one of the conflicting packages (0 being the highest priority)
  builder for '/nix/store/37s37cjsv5kypgpr2xg5q19rgf5bm22b-user-environment.drv' failed with exit code 1
  error: build of '/nix/store/37s37cjsv5kypgpr2xg5q19rgf5bm22b-user-environment.drv' failed
  ```

  ## Technical details

  ```
  $ ls -Rl /nix/store/rhpizad2ys1c99kgyi1fah1fcqzz81wv-xmonad-with-packages-8.6.5/                                                           
  /nix/store/rhpizad2ys1c99kgyi1fah1fcqzz81wv-xmonad-with-packages-8.6.5/:
  total 0
  dr-xr-xr-x 1 root root 12  1 jan  1970 bin/
  dr-xr-xr-x 1 root root  6  1 jan  1970 share/

  /nix/store/rhpizad2ys1c99kgyi1fah1fcqzz81wv-xmonad-with-packages-8.6.5/bin:
  total 4
  -r-xr-xr-x 1 root root 378  1 jan  1970 xmonad*

  /nix/store/rhpizad2ys1c99kgyi1fah1fcqzz81wv-xmonad-with-packages-8.6.5/share:
  total 4
  lrwxrwxrwx 1 root root 77  1 jan  1970 man -> /nix/store/c27gk5c51hrb60wwgbl751g5rxr3qmpx-ghc-8.6.5-with-packages/share/man/
  ```
  ```
  $ ls -Rl /nix/store/c27gk5c51hrb60wwgbl751g5rxr3qmpx-ghc-8.6.5-with-packages/share/man/                                                    
  /nix/store/c27gk5c51hrb60wwgbl751g5rxr3qmpx-ghc-8.6.5-with-packages/share/man/:
  total 0
  dr-xr-xr-x 1 root root 38  1 jan  1970 man1/

  /nix/store/c27gk5c51hrb60wwgbl751g5rxr3qmpx-ghc-8.6.5-with-packages/share/man/man1:
  total 8
  lrwxrwxrwx 1 root root 77  1 jan  1970 ghc.1.gz -> /nix/store/zghq088rbvlikc2ns6adgmhks423mcin-ghc-8.6.5/share/man/man1/ghc.1.gz
  lrwxrwxrwx 1 root root 82  1 jan  1970 xmonad.1.gz -> /nix/store/k97r4wf1ffmzqf0qii0gky493403ylbx-xmonad-0.15/share/man/man1/xmonad.1.gz
  ```



  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.7-arch1-1-ARCH, Arch Linux, noversion`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.1`
   - channels(root): `"nixpkgs-19.09pre177709.fe41fdc3cbe"`
   - channels(hjulle): `"nixospkgs-19.09pre175916.1fc591f9a5b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
  ```


state: closed
title: kupfer: fix broken build
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/60915
updated_at: 2019-05-05 00:32:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/60498

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Firefox 1548973 Hotfix (addons disabled due to expired intermediate certificate)
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/60916
updated_at: 2019-05-09 11:28:15
body:
  Installing the hotfix:

  I didn't want to turn on user studies and it didn't seem to be pulling the hotfix immediately anyway, so I did some digging and found the hotfix installer at https://normandy.cdn.mozilla.net/api/v1/recipe/.

  Search for `"name": "Hotfix: Update XPI signing intermediate [Bug 1548973]",` and then install the xpi from the `addonUrl` field. **I don't know how supported this method is but it worked for me.  I cannot guarantee user support, so if you can't figure things out yourself/don't consider yourself a power user it's probably a bad idea to rely on this** That said, strictly on topic issues (this isn't really a mozilla issue tracker) will be handled on a best effort basis.

  Example url: `https:// storage.googleapis.com /moz-fx-normandy-prod-addons/extensions/hotfix-update-xpi-intermediate@mozilla.com-1.0.2-signed.xpi`

  Edit: see later in thread for some vague clarification from Mozilla about community workarounds, which FWIW is more or less a reasonable under the circumstances. Likely to attempt to reduce support load. TL;DR: caveat emptor. (nothing has changed)

  Edit2: Fixed typo: `addonIUrl` -> `addonUrl`

  Edit3: For those coming to this issue from other sources: Nixpkgs currently runs firefox 66. For those on an older version where the normandy xpi does not work (unsure if user error, or version incompatibility - have not tested it myself) a more involved workaround that is mentioned in the issue tracker is to extract the certificate from the XPI and manually import it into the certificate store. E.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1549078#c71 


state: closed
title: xmonad-with-packages: Remove ghc manpage
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/60917
updated_at: 2019-05-04 21:58:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This package should only instll the xmonad manpage but not GHCs (it
  doesn't even install GHC in the path).
  Installing both manpages makes this package conflict with the GHC
  derivation. Fixes: #60914

  ###### Things done

  I tested the patch only when applied to `nixpkgs-unstable` because I don't feel like compiling GHC :P

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Gimp: Unable to locate theme engine in module_path: "adwaita",
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/60918
updated_at: 2019-05-10 16:04:25
body:
  ## Issue description

  I ran gimp from terminal and noticed that it prints out following warnings:

  ```
  (.gimp-2.10-wrapped_:26825): Gtk-WARNING **: 18:07:38.285: Unable to locate theme engine in module_path: "adwaita",
  ```

  I don't see anything clearly broken in the UI, but just thought that probably this is some issue that could be fixed.


  ### Steps to reproduce

  Run Gimp from a terminal.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.09.git.3d081ed (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: open
title: fortify hardening still overrides debug builds in many cases
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/60919
updated_at: 2019-05-27 19:32:52
body:
  This is in some way a continuation of #18995 [GCC has unwanted flags](https://github.com/NixOS/nixpkgs/issues/18995).

  Even though that one is marked as solved, I have over the last 2 years encountered many situations where silently `-O2 -D_FORTIFY_SOURCE=2` is added to builds where I have explicitly requested that a debug build be done (which should result in `-O0` / no `-O` flag being passed).

  For example, right now on meson-based builds (on Darwin, but I believe on Linux too), if I set

  ```nix
  mesonBuildType = "debug";
  ```

  it does not have the desired effect unless I also add

  ```
  hardeningDisable = [ "fortify" ];
  ```

  because the fortify hardening adds `-O2 -D_FORTIFY_SOURCE=2` no matter what.

  The same happend to me in various C++ builds, and it's always a big drag in development time when you just can't get your `-O0` debug builds working.

  ---

  Reading the PR description of #28029, it says

  > user supplied -O flags should take precedence over the hardening flags

  so I suspect that this isn't good enough, because most development builds don't add `-O0` explicitly -- instead they add no `-O` flag at all, so even with the PR `-O2` is still added.

  I think we must do _something_ about it because it's a total pain.


state: closed
title: nixos/misc/nixpkgs: fixed syntax error in overlays example
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/60920
updated_at: 2019-05-04 21:28:13
body:
  ###### Motivation for this change

  I was pointed towards a small syntax error in the `nixpkgs.overlays`
  documentation. There was a trailing semicolon after the overlay
  function.

  I also aligned the code a bit better so opening and closing brackets can
  be visually matched much better (IMO).


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rapid-photo-downloader: add vmtouch to wrapped PATH
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60921
updated_at: 2019-05-06 18:40:52
body:
  ###### Motivation for this change
  When testing another PR, noticed that without this, the `analyze-pv-structure` executable complains:
  `To run this program, you need to install vmtouch.`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Fix many gstreamer packages on Darwin
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/pull/60922
updated_at: 2019-05-14 22:21:26
body:
  * [ ] Based on #54398, merge that first.

  ###### Motivation for this change

  See commit messages.

  Darwin evaluation was accidentally broken in the past.

  One commit fixes the evaluation, the other one fixes as many packages to build with as many features as I had time to fix.

  A couple things still don't work, for example the `gst-rtsp-server` example executables print `WARNING **: ... failed to create element 'rtpbin', check your installation` when you try to connect to play the stream, but we'll have to figure that out separately.

  I'm not an OSX user, I just want to make #54398 as useful as possible.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: waf: 2.0.14 -> 2.0.15
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60923
updated_at: 2019-05-19 19:21:32
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/waf/versions.



  meta.description for waf is: '"Meta build system"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.0.15 with grep in /nix/store/87mx6j83c6xnsvg1fljwkc8ymlsgn8pp-waf-2.0.15
  - directory tree listing: https://gist.github.com/f0f8e1cd596bc5ac1ec3989f09e5fb57
  - du listing: https://gist.github.com/7aecd1b96483070a9775fb9dd29bc166

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1870 total rebuild path(s)

  647 package rebuild(s)

  646 x86_64-linux rebuild(s)
  592 i686-linux rebuild(s)
  72 x86_64-darwin rebuild(s)
  560 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  MMA
  SDL2_mixer
  SDL_mixer
  _20kly
  a2jmidid
  adapta-gtk-theme
  adlplug
  aeolus
  afew
  aj-snapshot
  almanah
  alot
  alsaPluginWrapper
  alsaPlugins
  ams-lv2
  anki
  appimage-run
  aravis
  arc-theme
  ardour
  areca
  artyFX
  asc
  astroid
  aubio
  audacious
  audaciousQt5
  audacity
  audio-recorder
  autofs5
  avldrums-lv2
  azureus
  ballAndPaddle
  balsa
  baresip
  baudline
  beneath-a-steel-sky
  beret
  birdfont
  bitmeter
  bitwig-studio
  bitwig-studio1
  bitwig-studio2
  blockhash
  bookworm
  brasero
  brasero-original
  bristol
  byzanz
  calf

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/87mx6j83c6xnsvg1fljwkc8ymlsgn8pp-waf-2.0.15 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A waf https://github.com/r-ryantm/nixpkgs/archive/6a19d1ea40d5ceefb6cd27c4fec0682ca5d6bf84.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/87mx6j83c6xnsvg1fljwkc8ymlsgn8pp-waf-2.0.15
  ls -la /nix/store/87mx6j83c6xnsvg1fljwkc8ymlsgn8pp-waf-2.0.15/bin
  ```


  </details>
  <br/>


  cc @vrthra for testing.


state: closed
title: wallabag: 2.3.6 -> 2.3.7
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60924
updated_at: 2019-05-11 03:03:28
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wallabag/versions.



  meta.description for wallabag is: '"Web page archiver"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.3.7 with grep in /nix/store/hnyb8zzf1kmdcvbpf8w9h9j1hba0ifff-wallabag-2.3.7
  - directory tree listing: https://gist.github.com/f467f9505e866a0fb0c295e6008f19a8
  - du listing: https://gist.github.com/0a0063d6ec2638d6f783aa227a9191f3

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  wallabag

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/hnyb8zzf1kmdcvbpf8w9h9j1hba0ifff-wallabag-2.3.7 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A wallabag https://github.com/r-ryantm/nixpkgs/archive/660b67a1f258cdc262352569a5bc6ab2f32b6f78.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/hnyb8zzf1kmdcvbpf8w9h9j1hba0ifff-wallabag-2.3.7
  ls -la /nix/store/hnyb8zzf1kmdcvbpf8w9h9j1hba0ifff-wallabag-2.3.7/bin
  ```


  </details>
  <br/>


  cc @schneefux for testing.


state: closed
title: libressl: 2.9.0 -> 2.9.1
user_login: ruuda
html_url: https://github.com/NixOS/nixpkgs/pull/60925
updated_at: 2019-05-08 07:47:42
body:
  ###### Motivation for this change

  [LibreSSL upstream released version 2.9.1](https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.9.1-relnotes.txt), a stable release in the 2.9 series.

  ###### Things done

  Just bumping the version was not enough, 2.9.1 would not build. Buildroot ran into the same issue, and resolved it in https://github.com/buildroot/buildroot/commit/e783d60473944f8b39f1def45d8d6b483a062158 by switching to CMake, so I did the same here.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I did test compiling `nginx` and `acme-client` against the new `libressl_2_9`.


state: closed
title: deepin: update packages
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/60926
updated_at: 2019-05-05 16:05:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update deepin packages.

  Installed on a VM and tested some of the applications.

  See also https://github.com/NixOS/nixpkgs/issues/59023.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: hplip: enable the plugin for aarch64
user_login: mebubo
html_url: https://github.com/NixOS/nixpkgs/pull/60927
updated_at: 2019-06-29 17:23:35
body:
  aarch64 is supported by the plugin since version 3.15.4 according to

    https://developers.hp.com/hp-linux-imaging-and-printing/release_notes

  I have tested this change and it worked on my raspberry pi and with my
  printer.

  A minor caveat is that I had to revert to hplip 3.18.5 in order to be
  able to build hplip itself for aarch64. The version 3.19.1 currently
  fails to build on non-x86 because of

    https://bugs.launchpad.net/hplip/+bug/1785230

  It is for this reason that I'm not adding aarch64-linux to the platforms
  list for hplip in this commit.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wings: 2.2.3 -> 2.2.4
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60928
updated_at: 2019-05-11 03:03:31
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wings/versions.



  meta.description for wings is: '"Subdivision modeler inspired by Nendo and Mirai from Izware"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.2.4 with grep in /nix/store/liq845kjw2pqys0lbbdqskkkqc3vyh17-wings-2.2.4
  - directory tree listing: https://gist.github.com/a954416a5aa964c52cbe36612b91567f
  - du listing: https://gist.github.com/17ed1d05c35cb4005e90027112dcdb0f

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  wings

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/liq845kjw2pqys0lbbdqskkkqc3vyh17-wings-2.2.4 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A wings https://github.com/r-ryantm/nixpkgs/archive/baa479ff85ad51c5694e54652afb246f8f2a0c3d.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/liq845kjw2pqys0lbbdqskkkqc3vyh17-wings-2.2.4
  ls -la /nix/store/liq845kjw2pqys0lbbdqskkkqc3vyh17-wings-2.2.4/bin
  ```


  </details>
  <br/>


  cc @viric for testing.


state: closed
title: linkchecker: fix bad interaction with python3
user_login: mboes
html_url: https://github.com/NixOS/nixpkgs/pull/60929
updated_at: 2019-05-06 13:57:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Previously, `nix-shell -p linkchecker python3` would lead to a broken
  `python3` command. That's because Python 2 packages would pollute the
  environment and confuse the interpreter. `linkchecker` has propagated
  build inputs. So the solution is to use `pythonPath` instead, to avoid
  the pollution.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: woeusb: 3.2.12 -> 3.3.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60930
updated_at: 2019-05-11 03:03:34
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/woeusb/versions.



  meta.description for woeusb is: '"Create bootable USB disks from Windows ISO images"'.

  [Release on GitHub](https://github.com/slacka/WoeUSB/releases/tag/v3.3.0)


  [Compare changes on GitHub](https://github.com/slacka/WoeUSB/compare/v3.2.12...v3.3.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.3.0 with grep in /nix/store/grsf31sivfn52rsmrdipr6gcdnwi5lcq-woeusb-3.3.0
  - directory tree listing: https://gist.github.com/6b224667078dba65517bfd75c7590941
  - du listing: https://gist.github.com/6816c171b5233e6231f7a3acbd276a16

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  woeusb

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/grsf31sivfn52rsmrdipr6gcdnwi5lcq-woeusb-3.3.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A woeusb https://github.com/r-ryantm/nixpkgs/archive/e59bc5b8ceec4e487ac09028b54b877c5b70d736.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/grsf31sivfn52rsmrdipr6gcdnwi5lcq-woeusb-3.3.0
  ls -la /nix/store/grsf31sivfn52rsmrdipr6gcdnwi5lcq-woeusb-3.3.0/bin
  ```


  </details>
  <br/>


  cc @bjornfor @gnidorah for testing.


state: closed
title: xmlsec: 1.2.26 -> 1.2.28
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60931
updated_at: 2019-05-11 03:03:37
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xmlsec/versions.



  meta.description for xmlsec is: '"XML Security Library in C based on libxml2"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.2.28 with grep in /nix/store/3nmhbzrc1r5g92rzxmn974j7q39rx4g2-xmlsec-1.2.28
  - directory tree listing: https://gist.github.com/c891d3a0f974e53493344e68b705332f
  - du listing: https://gist.github.com/a5f00ad1739c9387030411bf1a781112

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  28 total rebuild path(s)

  10 package rebuild(s)

  7 x86_64-linux rebuild(s)
  7 i686-linux rebuild(s)
  7 x86_64-darwin rebuild(s)
  7 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  gnucash
  kmymoney
  krunner-pass
  lasso
  matrix-synapse
  oathToolkit
  passExtensions.pass-otp
  python27Packages.pysaml2
  python37Packages.pysaml2
  xmlsec

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/3nmhbzrc1r5g92rzxmn974j7q39rx4g2-xmlsec-1.2.28 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A xmlsec https://github.com/r-ryantm/nixpkgs/archive/a5062a2807b7f4a2595c47dbbdb512caa426ff6a.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/3nmhbzrc1r5g92rzxmn974j7q39rx4g2-xmlsec-1.2.28
  ls -la /nix/store/3nmhbzrc1r5g92rzxmn974j7q39rx4g2-xmlsec-1.2.28/bin
  ```


  </details>
  <br/>


state: closed
title: [treewide] delete (some) unused patches
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60932
updated_at: 2019-05-07 21:34:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Remove a batch of in-tree patches that are not even used anymore :cat2: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xsecurelock: 1.2 -> 1.3.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60933
updated_at: 2019-05-11 03:03:40
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xsecurelock/versions.



  meta.description for xsecurelock is: '"X11 screen lock utility with security in mind"'.

  [Release on GitHub](https://github.com/google/xsecurelock/releases/tag/v1.3)


  [Compare changes on GitHub](https://github.com/google/xsecurelock/compare/v1.2...v1.3)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.3 with grep in /nix/store/3ydlfhx4dg5fl6cfm920305qv0ad49f5-xsecurelock-1.3
  - directory tree listing: https://gist.github.com/eab6882267ba2aa912c32212b356a3b6
  - du listing: https://gist.github.com/eb0611d9473fc6f040d5544f06585317

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  xsecurelock

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/3ydlfhx4dg5fl6cfm920305qv0ad49f5-xsecurelock-1.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A xsecurelock https://github.com/r-ryantm/nixpkgs/archive/34cae6c490a59cf2c6635951bb24ea0d41741e0f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/3ydlfhx4dg5fl6cfm920305qv0ad49f5-xsecurelock-1.3
  ls -la /nix/store/3ydlfhx4dg5fl6cfm920305qv0ad49f5-xsecurelock-1.3/bin
  ```


  </details>
  <br/>


  cc @fpletz for testing.


state: closed
title: zynaddsubfx: 3.0.4 -> 3.0.5
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60934
updated_at: 2019-05-11 03:03:43
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/zynaddsubfx/versions.



  meta.description for zynaddsubfx is: '"High quality software synthesizer"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.0.5 with grep in /nix/store/yf49q132riw1kcckih2f32x552h36kji-zynaddsubfx-3.0.5
  - directory tree listing: https://gist.github.com/aae9ac6ea5adb8861850277186b30e33
  - du listing: https://gist.github.com/a5c08b56ddbc39971ee58129d0aa1564

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  zynaddsubfx

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/yf49q132riw1kcckih2f32x552h36kji-zynaddsubfx-3.0.5 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A zynaddsubfx https://github.com/r-ryantm/nixpkgs/archive/ef8dfcc07f0d202007e6d84ef71f3fce4e7102f0.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/yf49q132riw1kcckih2f32x552h36kji-zynaddsubfx-3.0.5
  ls -la /nix/store/yf49q132riw1kcckih2f32x552h36kji-zynaddsubfx-3.0.5/bin
  ```


  </details>
  <br/>


  cc @cillianderoiste @nico202 for testing.


state: closed
title: gimp: fix GTK_PATH
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/60935
updated_at: 2019-05-10 16:04:25
body:
  Fixes #60918.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.fiona: fix tests on py27 by including mock in checkInputs
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60936
updated_at: 2019-05-05 15:34:09
body:
  ###### Motivation for this change
  Noticed this fails when reviewing https://github.com/NixOS/nixpkgs/pull/60716

  Depending package `cartopy` still fails to build, but I think I can remedy that in another PR.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gimp: bad interpreter
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/60937
updated_at: 2019-05-07 05:05:57
body:
  ## Issue description

  I see the following warnings when running gimp:

  ```
  $ gimp
  GIMP-Warning: Bad interpreter referenced in interpreter file /nix/store/0hsy78qmsclkks0v9ykcmvx0wsllwyw8-gimp-with-plugins-2.10.10/lib/gimp/2.0/interpreters/pygimp.interp: python2

  GIMP-Warning: Bad binary format string in interpreter file /nix/store/0hsy78qmsclkks0v9ykcmvx0wsllwyw8-gimp-with-plugins-2.10.10/lib/gimp/2.0/interpreters/pygimp.interp
  ```

  Not sure if they are critical or not. I do have problems with one Python plugin, not sure if this could be related.

  ### Steps to reproduce

  Run gimp from the terminal. I'm running it from i3+none desktop environment, if that matters.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.36, NixOS, 19.09.git.3d081ed (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/etc/nixpkgs`
  ```


state: closed
title: kernel: Disable VirtualBox guest modules.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60938
updated_at: 2019-05-14 22:49:26
body:
  These break the modules from VirtualBox additions. Fixes issue https://github.com/NixOS/nixpkgs/issues/58127.

  I think this is the thing we should do for now. A proper but harder fix would be to extend the kernel-modules aggregator package (`pkgs/os-specific/linux/kmod/aggregator.nix`) to allow excluding some modules, and make the VirtualBox additions NixOS module set options to exclude the modules from the kernel (or not, if the user wants to use those).

  This is also for 19.03 and 18.09.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Avahi advertises ssh/sftp because they happen to be the samples that ship with the package
user_login: obadz
html_url: https://github.com/NixOS/nixpkgs/issues/60939
updated_at: 2019-05-04 19:51:40
body:
  ## Issue description

  When installing avahi with:

  ```nix
  {
    services.avahi.enable = true;
    services.avahi.publish.enable = true;
    services.avahi.publish.userServices = true;
  }
  ```

  … all hosts advertise two services: ssh & sftp.

  ```
  $ avahi-browse -a | grep wlp1s0
  + wlp1s0 IPv4 my_hostname                                      _ssh._tcp            local
  + wlp1s0 IPv4 my_hostname                                      _sftp-ssh._tcp       local
  ```

  This is simply because they happen to be the sample `.service` files that ship with Avahi:

  ```
  $ ls -l $(nix-build '<nixpkgs>' -A avahi --no-out-link)/etc/avahi/services
  total 8.0K
  -r--r--r-- 1 root root 1.1K Jan  1  1970 sftp-ssh.service
  -r--r--r-- 1 root root 1.1K Jan  1  1970 ssh.service
  ```

  This seems like a bad reason and it cannot be turned off even if the services aren't installed.

  Ideally we'd probably want the services folder to be generated based on some NixOS module config, but until someone wants to shave that yak, I suggest doing this:

  ```diff
  diff --git a/pkgs/development/libraries/avahi/default.nix b/pkgs/development/libraries/avahi/default.nix
  index f276d0bf12e..9c1afc86c5c 100644
  --- a/pkgs/development/libraries/avahi/default.nix
  +++ b/pkgs/development/libraries/avahi/default.nix
  @@ -50,7 +50,9 @@ stdenv.mkDerivation rec {
       avahi-core/socket.c
     '';
   
  -  postInstall =
  +  postInstall = ''
  +    rm -v "$out/etc/avahi/services/"*  # Don't advertise ssh/sftp by default
  +  '' +
       # Maintain compat for mdnsresponder and howl
       stdenv.lib.optionalString withLibdnssdCompat ''
         ln -s avahi-compat-libdns_sd/dns_sd.h "$out/include/dns_sd.h"
  ```

  If nobody has a better idea, I'll submit a pull request on the above. (It's a mass rebuild).

  Cc avahi maintainer @lovek323


state: closed
title: wpscan: 3.4.3 -> 3.5.3, use bundlerApp
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/60940
updated_at: 2019-05-05 13:36:39
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump and cleanup.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Trouble compiling R/Rcpp library with all debug info
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/60941
updated_at: 2019-05-05 23:30:21
body:
  I have the following snippet for reproducing a crash in the `reticulate` R library, which you can run directly with nix-shell:
  ```nix
  let pkgs = import <nixpkgs> {}; in
  with { inherit (pkgs) mkShell enableDebugging rstudioWrapper rWrapper rPackages python3 gdb callPackage lib stdenv writeShellScriptBin; };

  let
    keepDebugInfo' = stdenv: stdenv //
      { mkDerivation = args: stdenv.mkDerivation (args // {
          dontStrip = true;
          hardeningDisable = [ "all" ];
          preConfigure = ''
            export NIX_DEBUG=1
            export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -gdwarf -Og -O0 -g3 -g"
            '';
        });
      };
    stdenv = keepDebugInfo' pkgs.stdenv;
    my_rPackages = callPackage (pkgs.path + "/pkgs/development/r-modules") {
      overrides = {};
      pkgs = pkgs // { callPackage = lib.callPackageWith ( pkgs // { inherit stdenv; }); }; 
      };

    myR = selector: rWrapper.override { packages = selector my_rPackages; };
    rStuff = myR (p: with p; [ reticulate ]); #keras tensorflow ]);
    pyStuff = python.withPackages (p: with p; [ Keras tensorflow ]);

    debugsh = writeShellScriptBin "debug.sh" ''
      #! /usr/bin/env bash
      exec gdb -quiet\
          -ex "set auto-load safe-path /"\
          -ex "set confirm off"\
          -ex "run"\
          -ex "break py_run_string_impl"\
          -ex "run"\
          -ex "info shared"\
          -ex "info locals"\
          -ex "quit" \
          -ex "set confirm on" "$@"
      '';
  in
    mkShell {
      name = "woo-science";
      buildInputs = [
        rStuff
        pyStuff
        gdb
        ];
      shellHook = ''
        exec R --slave --no-restore --vanilla --file=test.r -d ${debugsh}/bin/debug.sh'';
      }

  ```
  The info locals gdb command always complains about no symbol table information, even though everything I looked at suggest that the .so file does have debug symbols in it, I tried to add all debug flags, ...

  Does anyone know how to get this to work?


state: closed
title: matrix-synapse: 0.99.3 -> 0.99.3.2
user_login: mguentner
html_url: https://github.com/NixOS/nixpkgs/pull/60942
updated_at: 2019-05-10 13:38:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  security update:

  * https://github.com/matrix-org/synapse/releases/tag/v0.99.3.1
  * https://github.com/matrix-org/synapse/releases/tag/v0.99.3.2

  cc @fpletz 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virtualbox: 5.2.28 -> 6.0.6
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/60943
updated_at: 2019-05-22 22:22:51
body:
  Quite some fixing was needed to get this to work. See the discussion and comments in commits and comments.

  ###### Things done

  Tested host and guest (including desktop) on 19.03, no breakage observed.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: patchelfUnstable: 0.10-pre-20180509 -> 0.10-pre-20190328
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/60944
updated_at: 2019-05-28 01:34:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Currently `patchelfUnstable` does not include the PR https://github.com/NixOS/patchelf/issues/66, which is needed for some Go packages (like ngrok2).

  I ran this version of patchelf on a new version of ngrok2 and now it is working whereas with version 20180509, patchelf would show the following error:

  ```
  cannot find section ''
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffsend: 0.2.45 -> 0.2.46
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/60945
updated_at: 2019-05-11 03:28:28
body:
  ###### Motivation for this change
  https://github.com/timvisee/ffsend/releases/tag/v0.2.46

  Extend the xclip/xsel support to all BSD variants and add BSD to the supported platforms list.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  A change in this version tweaks clipboard support for all BSD variants, so I figured it was safe to declare that this supported all BSD variants. It seems there's no pre-built `lib.platforms` entry for BSD, just for specific BSD flavors, which is why I ended up using `[ stdenv.lib.systems.inspect.patterns.isBSD ]`. I wasn't sure if there's a better way to do this. I'm also wondering if I should just give up and use `platforms.unix`, except I don't know if `ffsend` works on Cygwin (which is part of `platforms.unix`).


state: closed
title: ngrok2: 2.3.18 -> 2.3.29
user_login: bobvanderlinden
html_url: https://github.com/NixOS/nixpkgs/pull/60946
updated_at: 2019-05-20 13:42:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Note: this PR depends on updating patchelfUnstable. This change is made in #60944 

  To update I ran:

  ```
  nix-shell maintainers/scripts/update.nix --argstr package ngrok-2
  ```

  The result did not run correctly as the binary wasn't patched correctly. The new version of `patchelfUnstable` with the line in the install phase resolved the issue.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix home-assistant netatmo support
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/60947
updated_at: 2019-05-20 11:30:07
body:
  ###### Motivation for this change

  The netatmo components for home-assistant are broken in current nixpkgs due to a missing dependency. That dependency (pyatmo) happens to not be packaged yet, so I'm adding it to nixpkgs as part of this PR.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.cartopy: fix tests for python2.7 using xvfb
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/60948
updated_at: 2019-05-07 19:38:35
body:
  ###### Motivation for this change
  ~Draft PR because this sits on top of https://github.com/NixOS/nixpkgs/pull/60936~

  Python 2.7's tk is over-eager in trying to open an x display, so run the tests in `xvfb`. `xvfb` is quite a heavy dependency (albeit only a build-time one), so ensure this is only used when needed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grab-site: 2.1.11 -> 2.1.15
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/60949
updated_at: 2019-05-05 01:43:36
body:
  ###### Motivation for this change

  https://github.com/ArchiveTeam/grab-site/commits/master

  The repo was moved from [ludios/grab-site](https://github.com/ludios/grab-site) to ArchiveTeam/grab-site.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chromium: 74.0.3729.108 -> 74.0.3729.131
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/60950
updated_at: 2019-05-05 16:04:37
body:
  ###### Motivation for this change

  Fix CVE-2019-5827 CVE-2019-5824

  https://chromereleases.googleblog.com/2019/04/stable-channel-update-for-desktop_30.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I tested stable chromium: audio, YouTube, WebGL, Octane 2.0, all seems to be well.


state: closed
title: hackage2nix: Unmark hnix as broken
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/60951
updated_at: 2019-05-05 21:53:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Builds just fine.

  @peti If you don't mind, I'll be pushing such updates to haskell-updates directly in the future.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: redeclipse: init at 1.6.0
user_login: lambda-11235
html_url: https://github.com/NixOS/nixpkgs/pull/60952
updated_at: 2019-07-02 16:16:57
body:
  Added a package for the FPS Red Eclipse. See https://www.redeclipse.net/.

  ###### Motivation for this change
  I like the game and think others will as well. I also wanted to learn how to package for Nix.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Fix home-assistant fitbit support
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/60953
updated_at: 2019-05-20 11:30:22
body:
  ###### Motivation for this change
  Similar to #60947. The fitbit components for home-assistant are broken in current nixpkgs due to a missing dependency. That dependency (python-fitbit) happens to not be packaged yet, so I'm adding it to nixpkgs as part of this PR.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: networkmanager: network-online --wants--> NetworkManager-wait-online
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/60954
updated_at: 2019-06-06 11:19:37
body:
  ###### Motivation for this change

  Services relying on `network-online.target` were running before
  the network was ready, every time.

  Looking at why this was happening, it seems our `network-online`
  had no actual dependency on the appropriate connectivity check
  when using networkmanager, namely `NetworkManager-wait-online.service`.

  (we get this right for configurations using networkd, I believe)

  Looking at networkmanager's provided service
  `etc/systemd/system/NetworkManager-wait-online.service` there's
  a `WantedBy` in `[Install]` that should be accounted for.

  Running this command before/after the included commit should
  help see the difference:

  (this is after:)
  ```
  $ systemctl show -p Wants,After network-online.target
  Wants=NetworkManager-wait-online.service
  After=network.target NetworkManager-wait-online.service
  ```

  Now my services don't all complain when trying to run
  just a tiny bit too early in my boot :).

  If there's agreement this is the correct configuration
  please 'backport' to at least 19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Pantheon: shutdown always times out
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/issues/60955
updated_at: 2019-05-05 01:36:16
body:
  ## Issue description
  Seems cerbere and systemd have a [bit of a quarrel](https://github.com/elementary/cerbere/issues/6)
  and we usually have to wait the default `DefaultTimeoutStopSec` which is pretty long (90s).

  As a workaround I think we can do what they've done upstream with systemd's config
  ```nix
  systemd.extraConfig = ''
    DefaultTimeoutStopSec=25s
  '';
  ```

  Or any lower value that you think is appropriate.

  I'm avoiding putting that kind of configuration in the Pantheon module because it should
  be up to the user to do this.


state: closed
title: duplicity: enable tests
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/60956
updated_at: 2019-06-04 08:59:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Prevent regressions when upgrading duplicity (or one of its dependencies) by running duplicity's test suite.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bacula: 9.4.2 -> 9.4.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60957
updated_at: 2019-05-11 02:53:08
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bacula/versions.



  meta.description for bacula is: '"Enterprise ready, Network Backup Tool"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 9.4.3 with grep in /nix/store/ygl1njb83pmacbn5almp2mprm9f729ik-bacula-9.4.3
  - directory tree listing: https://gist.github.com/8abd487d2413f6f55b2dcaf62ea2be68
  - du listing: https://gist.github.com/4db0e98429e2b110ba70062f5155377a

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  bacula

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/ygl1njb83pmacbn5almp2mprm9f729ik-bacula-9.4.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A bacula https://github.com/r-ryantm/nixpkgs/archive/41d4eb51f0c51cef016b1cb497a7db7eb9d811c4.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/ygl1njb83pmacbn5almp2mprm9f729ik-bacula-9.4.3
  ls -la /nix/store/ygl1njb83pmacbn5almp2mprm9f729ik-bacula-9.4.3/bin
  ```


  </details>
  <br/>


  cc @domenkozar @lovek323 @proteansec for testing.


state: closed
title: duplicity: 0.7.18.2 -> 0.7.19
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/60958
updated_at: 2019-05-05 11:50:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade duplicity to the latest version. v0.7.19 was released on April 29, 2019: http://duplicity.nongnu.org/CHANGELOG

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitwarden_rs-vault: 2.9.0 -> 2.10.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60959
updated_at: 2019-05-11 02:53:18
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bitwarden_rs-vault/versions.



  meta.description for bitwarden_rs-vault is: '"Integrates the web vault into bitwarden_rs"'.

  [Release on GitHub](https://github.com/dani-garcia/bw_web_builds/releases/tag/v2.10.0)


  [Compare changes on GitHub](https://github.com/dani-garcia/bw_web_builds/compare/v2.9.0...v2.10.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.10.0 with grep in /nix/store/0yf44midc67a70bfcmrcd94awp8zn898-bitwarden_rs-vault-2.10.0
  - directory tree listing: https://gist.github.com/2100d79fd984c51e51763a36f35868ed
  - du listing: https://gist.github.com/70183c95435da4d1d88e27ade91764a7

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  bitwarden_rs-vault

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/0yf44midc67a70bfcmrcd94awp8zn898-bitwarden_rs-vault-2.10.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A bitwarden_rs-vault https://github.com/r-ryantm/nixpkgs/archive/d2d4383b286e9f9c0d4f2050aecaed9901afcc4f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/0yf44midc67a70bfcmrcd94awp8zn898-bitwarden_rs-vault-2.10.0
  ls -la /nix/store/0yf44midc67a70bfcmrcd94awp8zn898-bitwarden_rs-vault-2.10.0/bin
  ```


  </details>
  <br/>


  cc @msteen for testing.


state: closed
title: enlightenment.efl: 1.22.1 -> 1.22.2
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/60960
updated_at: 2019-05-05 14:16:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [1.22.2](https://www.enlightenment.org/news/efl-1.22.2)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: chromium: add myself as maintainer
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/60961
updated_at: 2019-05-05 09:09:21
body:
  ###### Motivation for this change

  I would like to nominate myself for Chromium maintenance. My goal is to get Chromium updates (almost always fixing CVEs) into `master` a little more quickly when other maintainers are busy. I use Chromium heavily and closely watch [Google's stable updates](https://chromereleases.googleblog.com/search/label/Stable%20updates). I have fixed a [NixOS-related audio issue](https://github.com/NixOS/nixpkgs/commit/03960a323db7b83ba0ef46e6906640fa6de0402e) and [a vulnerable version](https://github.com/NixOS/nixpkgs/issues/56998). I also [report Chromium bugs upstream](https://bugs.chromium.org/p/chromium/issues/list?can=1&q=Reporter%3Aivan%40ludios.org+OS%3DLinux&sort=-modified&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified).


state: closed
title: rambox-pro: Switch to using correct electron path
user_login: cawilliamson
html_url: https://github.com/NixOS/nixpkgs/pull/60962
updated_at: 2019-05-05 09:04:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Using the direct path to .electron-wrapped was causing issues with autostart.

  ###### Things done

  Corrected path to bin/electron instead of .electron-wrapped

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dovecot_pigeonhole: 0.5.5 -> 0.5.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60963
updated_at: 2019-05-11 02:53:57
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dovecot-pigeonhole/versions.



  meta.description for dovecot_pigeonhole is: '"A sieve plugin for the Dovecot IMAP server"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.5.6 with grep in /nix/store/l8zy4mw2x9bc2x21v87n253bp9wim5sw-dovecot-pigeonhole-0.5.6
  - directory tree listing: https://gist.github.com/4f5239c6c34c81b5fdb6517c50fc19c4
  - du listing: https://gist.github.com/88b196c2b379d5fe87b63a080387568c

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  dovecot_pigeonhole

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/l8zy4mw2x9bc2x21v87n253bp9wim5sw-dovecot-pigeonhole-0.5.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A dovecot_pigeonhole https://github.com/r-ryantm/nixpkgs/archive/b9efa69b0aead97553dd08092f688b12bdf66fe4.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/l8zy4mw2x9bc2x21v87n253bp9wim5sw-dovecot-pigeonhole-0.5.6
  ls -la /nix/store/l8zy4mw2x9bc2x21v87n253bp9wim5sw-dovecot-pigeonhole-0.5.6/bin
  ```


  </details>
  <br/>


  cc @rickynils for testing.


state: closed
title: drawpile: 2.1.7 -> 2.1.8
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60964
updated_at: 2019-05-11 02:54:00
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/drawpile/versions.



  meta.description for drawpile is: '"A collaborative drawing program that allows multiple users to sketch on the same canvas simultaneously"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.1.8 with grep in /nix/store/qc473s0g2srxwyqw06nk13kv842r0vf9-drawpile-2.1.8
  - directory tree listing: https://gist.github.com/a3010f1ca4482fadf998d790813e905d
  - du listing: https://gist.github.com/c0a3136b124e431af8bc750c11c421ad

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  drawpile
  drawpile-server-headless

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/qc473s0g2srxwyqw06nk13kv842r0vf9-drawpile-2.1.8 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A drawpile https://github.com/r-ryantm/nixpkgs/archive/a75b1c656afeacc316a48fb21f61f35c7d974893.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/qc473s0g2srxwyqw06nk13kv842r0vf9-drawpile-2.1.8
  ls -la /nix/store/qc473s0g2srxwyqw06nk13kv842r0vf9-drawpile-2.1.8/bin
  ```


  </details>
  <br/>


  cc @fgaz for testing.


state: closed
title: dune: 1.9.1 -> 1.9.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60965
updated_at: 2019-05-11 02:54:08
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dune/versions.



  meta.description for dune is: '"A composable build system"'.


  [Compare changes on GitHub](https://github.com/ocaml/dune/compare/1.9.1...1.9.2)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.9.2 with grep in /nix/store/d6npc6mhzavnlcjnqb0v4bwabgjc8q4j-dune-1.9.2
  - directory tree listing: https://gist.github.com/6d97a135237beaabc9e8a95d877b318a
  - du listing: https://gist.github.com/379b5015ed0b3ab6d3d1531e9b9ed9f4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  91 total rebuild path(s)

  25 package rebuild(s)

  25 x86_64-linux rebuild(s)
  24 i686-linux rebuild(s)
  19 x86_64-darwin rebuild(s)
  23 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  acgtk
  alt-ergo
  beluga
  dune
  eff
  flow
  fstar
  google-drive-ocamlfuse
  jackline
  libbap
  libguestfs
  libguestfs-with-appliance
  liquidsoap
  ocaml-top
  ocamlformat
  patdiff
  pyre
  python27Packages.guestfs
  python37Packages.guestfs
  reason
  satysfi
  stog
  trv
  vagrant
  virt-top

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/d6npc6mhzavnlcjnqb0v4bwabgjc8q4j-dune-1.9.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A dune https://github.com/r-ryantm/nixpkgs/archive/569aff03abe9a4a7c5bcd29bb79a573d51cffac6.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/d6npc6mhzavnlcjnqb0v4bwabgjc8q4j-dune-1.9.2
  ls -la /nix/store/d6npc6mhzavnlcjnqb0v4bwabgjc8q4j-dune-1.9.2/bin
  ```


  </details>
  <br/>


  cc @vbgl for testing.


state: closed
title: pantheon.elementary-files: 4.1.7 -> 4.1.8
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60966
updated_at: 2019-05-11 02:54:11
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/elementary-files/versions.



  meta.description for pantheon.elementary-files is: '"File browser designed for elementary OS"'.

  [Release on GitHub](https://github.com/elementary/files/releases/tag/4.1.8)


  [Compare changes on GitHub](https://github.com/elementary/files/compare/4.1.7...4.1.8)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 4.1.8 with grep in /nix/store/b27bv129xirgw892cb166nc3fhxp0gji-elementary-files-4.1.8
  - directory tree listing: https://gist.github.com/67731e5b8f040ff60118c56d473ea572
  - du listing: https://gist.github.com/04468e4f8c2762024bc07b122e031b99

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  pantheon.elementary-files

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/b27bv129xirgw892cb166nc3fhxp0gji-elementary-files-4.1.8 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A pantheon.elementary-files https://github.com/r-ryantm/nixpkgs/archive/c9c6325e78811c2af4e39c9c68ddf1b4ba8b72f6.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/b27bv129xirgw892cb166nc3fhxp0gji-elementary-files-4.1.8
  ls -la /nix/store/b27bv129xirgw892cb166nc3fhxp0gji-elementary-files-4.1.8/bin
  ```


  </details>
  <br/>


  cc @worldofpeace for testing.


state: closed
title: memtest86-efi: init at 8.0
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/60967
updated_at: 2019-05-06 04:34:47
body:
  This updates memtest86 to (almost) the latest version.

  memtest86-4.3.6 is the older version.  It was open source, but marked broken.  memtest86-8.0 is the newer version.  It is no longer open source, but it is possible to build and use.  There appear to be no restrictions on its use or redistribution.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The old memtest86 was marked as broken.

  I plan to send a future PR that actually adds memtest86 as an option for the bootloader.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doctl: 1.12.2 -> 1.16.0
user_login: thoughtpolice
html_url: https://github.com/NixOS/nixpkgs/pull/60968
updated_at: 2019-05-05 18:01:12
body:
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vcv-rack: Correct license, redistribution is allowed
user_login: Moredread
html_url: https://github.com/NixOS/nixpkgs/pull/60969
updated_at: 2019-07-07 14:10:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The package contains resources under different licenses, but they allow redistribution. See https://github.com/VCVRack/Rack/blob/v0.6/README.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: freetds: 1.00.111 -> 1.1.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60970
updated_at: 2019-05-11 02:54:47
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/freetds/versions.



  meta.description for freetds is: '"Libraries to natively talk to Microsoft SQL Server and Sybase databases"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1.6 with grep in /nix/store/b0slh4qz0rq7g9ckxk90zkwkz2fdksyb-freetds-1.1.6
  - directory tree listing: https://gist.github.com/b1841033211b2c0823e21bfa774e9968
  - du listing: https://gist.github.com/8f3f1e6b4b7bd2113e4e48eb38f24f02

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  28 total rebuild path(s)

  8 package rebuild(s)

  8 x86_64-linux rebuild(s)
  7 i686-linux rebuild(s)
  6 x86_64-darwin rebuild(s)
  7 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  check-mssql-health
  freetds
  perl528Packages.DBDsybase
  postgresqlPackages.tds_fdw
  python27Packages.pymssql
  python27Packages.python-sybase
  python37Packages.pymssql
  sqsh

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/b0slh4qz0rq7g9ckxk90zkwkz2fdksyb-freetds-1.1.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A freetds https://github.com/r-ryantm/nixpkgs/archive/4beb8e24b644f0b271fd71b50a6aaf25e6f3b4d6.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/b0slh4qz0rq7g9ckxk90zkwkz2fdksyb-freetds-1.1.6
  ls -la /nix/store/b0slh4qz0rq7g9ckxk90zkwkz2fdksyb-freetds-1.1.6/bin
  ```


  </details>
  <br/>


  cc @peterhoeg for testing.


state: open
title: frostwire-bin: 6.7.4 -> 6.7.9
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60971
updated_at: 2019-05-21 18:55:36
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/frostwire/versions.



  meta.description for frostwire-bin is: '"BitTorrent Client and Cloud File Downloader"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 6.7.9 with grep in /nix/store/c74ckmmmx4xrc6qafwizq28ll734x2hm-frostwire-6.7.9
  - directory tree listing: https://gist.github.com/b39cd25656565b6d65f75e711942a1ff
  - du listing: https://gist.github.com/ff0ed553aa59a93830554f379b5fef33

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  frostwire-bin

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/c74ckmmmx4xrc6qafwizq28ll734x2hm-frostwire-6.7.9 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A frostwire-bin https://github.com/r-ryantm/nixpkgs/archive/c36891f1b5a897a206766f3dce338e98f842e88e.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/c74ckmmmx4xrc6qafwizq28ll734x2hm-frostwire-6.7.9
  ls -la /nix/store/c74ckmmmx4xrc6qafwizq28ll734x2hm-frostwire-6.7.9/bin
  ```


  </details>
  <br/>


  cc @gavinrogers for testing.


state: closed
title: geos: 3.7.1 -> 3.7.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60972
updated_at: 2019-05-11 02:55:07
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/geos/versions.



  meta.description for geos is: '"C++ port of the Java Topology Suite (JTS)"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.7.2 with grep in /nix/store/nndn75wlcl5d96k807965a20bgakvbnh-geos-3.7.2
  - directory tree listing: https://gist.github.com/c62a07a6ce52a5ca2946664bbea1979d
  - du listing: https://gist.github.com/ea41f83fb99e1d6ee52f0ecf09f9ecf7

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  215 total rebuild path(s)

  59 package rebuild(s)

  59 x86_64-linux rebuild(s)
  55 i686-linux rebuild(s)
  44 x86_64-darwin rebuild(s)
  57 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  cura
  gazebo
  gazebo-headless
  gazeboSimulator.gazebo6
  gazeboSimulator.gazebo6-headless
  gazeboSimulator.gazebo7
  gazeboSimulator.gazebo7-headless
  gdal
  gdal_1_11
  geos
  gplates
  grass
  libLAS
  libspatialite
  mapnik
  merkaartor
  mysql-workbench
  openorienteering-mapper
  openscenegraph_3_4
  openspace
  postgresqlPackages.postgis
  python27Packages.basemap
  python27Packages.cartopy
  python27Packages.descartes
  python27Packages.fiona
  python27Packages.gdal
  python27Packages.geoalchemy2
  python27Packages.geopandas
  python27Packages.osmnx
  python27Packages.pyspread
  python27Packages.python-mapnik
  python27Packages.rasterio
  python27Packages.shapely
  python27Packages.tilestache
  python27Packages.worldengine
  python37Packages.aplpy
  python37Packages.basemap
  python37Packages.cartopy
  python37Packages.descartes
  python37Packages.fiona
  python37Packages.gdal
  python37Packages.geoalchemy2
  python37Packages.geopandas
  python37Packages.osmnx
  python37Packages.python-mapnik
  python37Packages.rasterio
  python37Packages.shapely
  python37Packages.uranium
  python37Packages.worldengine
  qgis

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/nndn75wlcl5d96k807965a20bgakvbnh-geos-3.7.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A geos https://github.com/r-ryantm/nixpkgs/archive/97bed5c78714741e37ec20277d7900e7485984c9.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/nndn75wlcl5d96k807965a20bgakvbnh-geos-3.7.2
  ls -la /nix/store/nndn75wlcl5d96k807965a20bgakvbnh-geos-3.7.2/bin
  ```


  </details>
  <br/>


state: closed
title: glib-networking: 2.60.1 -> 2.60.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60973
updated_at: 2019-05-11 02:55:14
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/glib-networking/versions.



  meta.description for glib-networking is: '"Network-related giomodules for glib"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.60.2 with grep in /nix/store/q4xknxybi2zf070wzcsywy62ikvpw8bz-glib-networking-2.60.2
  - directory tree listing: https://gist.github.com/6e59b14efd45c331cc70325fcbde5ba9
  - du listing: https://gist.github.com/426ff583101e79e1e236cd5339bd5dda

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1211 total rebuild path(s)

  407 package rebuild(s)

  407 x86_64-linux rebuild(s)
  384 i686-linux rebuild(s)
  44 x86_64-darwin rebuild(s)
  376 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  adapta-gtk-theme
  almanah
  arc-theme
  areca
  astroid
  azureus
  balsa
  birdfont
  bookworm
  chrome-gnome-shell
  claws-mail
  corebird
  deja-dup
  dino
  discover
  dropbox-cli
  eclipses.eclipse-cpp
  eclipses.eclipse-java
  eclipses.eclipse-modeling
  eclipses.eclipse-platform
  eclipses.eclipse-scala-sdk
  eclipses.eclipse-sdk
  ekiga
  empathy
  eolie
  epiphany
  evolution-data-server
  feedreader
  flatpak
  flatpak-builder
  folks
  fondo
  fwupd
  geoclue2
  gfbgraph
  gimp
  gimp-with-plugins
  gimpPlugins.exposureBlend
  gimpPlugins.focusblur
  gimpPlugins.fourier
  gimpPlugins.gap
  gimpPlugins.gimplensfun
  gimpPlugins.gmic
  gimpPlugins.lightning
  gimpPlugins.lqrPlugin
  gimpPlugins.resynthesizer
  gimpPlugins.resynthesizer2
  gimpPlugins.texturize
  gimpPlugins.ufraw
  gimpPlugins.waveletSharpen

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/q4xknxybi2zf070wzcsywy62ikvpw8bz-glib-networking-2.60.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A glib-networking https://github.com/r-ryantm/nixpkgs/archive/383e8ed2961556d785dc540169c58dbc67b3d576.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/q4xknxybi2zf070wzcsywy62ikvpw8bz-glib-networking-2.60.2
  ls -la /nix/store/q4xknxybi2zf070wzcsywy62ikvpw8bz-glib-networking-2.60.2/bin
  ```


  </details>
  <br/>


state: closed
title: Package Request: ytcc
user_login: MicrosoftTakeover
html_url: https://github.com/NixOS/nixpkgs/issues/60974
updated_at: 2019-05-26 23:55:42
body:
  ytcc (youtube channel checker) is a simple command line application to subscribe to YouTube channels without an account and watch your subscription feed in a video player like mpv without visiting the website.

  https://github.com/woefe/ytcc


state: closed
title: mstpd: 0.0.5.20171113 -> 0.0.7
user_login: c0bw3b
html_url: https://github.com/NixOS/nixpkgs/pull/60975
updated_at: 2019-05-05 16:18:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Package refresh
  \+ fixed installed file structure (some tools under $out/lib were symlink to `/sbin/bridge-stp` instead of `$out/sbin/bridge-stp`)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gssdp: 1.2.0 -> 1.2.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60976
updated_at: 2019-05-11 02:55:26
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gssdp/versions.



  meta.description for gssdp is: '"GObject-based API for handling resource discovery and announcement over SSDP"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.2.1 with grep in /nix/store/4al35bvcf9p68al0fpnl4j44138pjyff-gssdp-1.2.1
  - directory tree listing: https://gist.github.com/7568dea5540451b5fc0747a778e09fa1
  - du listing: https://gist.github.com/340091f16e00f351b9d3fa341f13dcba

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  700 total rebuild path(s)

  237 package rebuild(s)

  237 x86_64-linux rebuild(s)
  226 i686-linux rebuild(s)
  27 x86_64-darwin rebuild(s)
  210 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  adapta-gtk-theme
  almanah
  aravis
  arc-theme
  areca
  astroid
  audio-recorder
  azureus
  balsa
  baresip
  birdfont
  bookworm
  brasero
  brasero-original
  byzanz
  chrome-gnome-shell
  corebird
  cutegram
  deja-dup
  denemo
  dleyna-connector-dbus
  dleyna-core
  dleyna-renderer
  dleyna-server
  dragon
  dropbox-cli
  eclipses.eclipse-cpp
  eclipses.eclipse-java
  eclipses.eclipse-modeling
  eclipses.eclipse-platform
  eclipses.eclipse-scala-sdk
  eclipses.eclipse-sdk
  ekiga
  empathy
  enlightenment.rage
  eolie
  epiphany
  evince
  evolution-data-server
  farstream
  feedreader
  folks
  fractal
  gajim
  gcompris
  gfbgraph
  glom
  gmrender-resurrect
  gnome-builder
  gnome-podcasts

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/4al35bvcf9p68al0fpnl4j44138pjyff-gssdp-1.2.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A gssdp https://github.com/r-ryantm/nixpkgs/archive/458f58698d9a30ff419e75638d266337ae9e74cb.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/4al35bvcf9p68al0fpnl4j44138pjyff-gssdp-1.2.1
  ls -la /nix/store/4al35bvcf9p68al0fpnl4j44138pjyff-gssdp-1.2.1/bin
  ```


  </details>
  <br/>


state: closed
title: gtranslator: 3.32.0 -> 3.32.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60977
updated_at: 2019-05-11 02:55:29
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gtranslator/versions.



  meta.description for gtranslator is: '"GNOME translation making program"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.32.1 with grep in /nix/store/3abbywqwys5qpcc3g17yxqgmifjkdwyl-gtranslator-3.32.1
  - directory tree listing: https://gist.github.com/609ebc6b68114333b3d3cdbbca88f475
  - du listing: https://gist.github.com/d92afb130460cc95cfb321e4da6cdfb9

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  gtranslator

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/3abbywqwys5qpcc3g17yxqgmifjkdwyl-gtranslator-3.32.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A gtranslator https://github.com/r-ryantm/nixpkgs/archive/f11c3edbc6af9943c0047f24a28524d6765da11d.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/3abbywqwys5qpcc3g17yxqgmifjkdwyl-gtranslator-3.32.1
  ls -la /nix/store/3abbywqwys5qpcc3g17yxqgmifjkdwyl-gtranslator-3.32.1/bin
  ```


  </details>
  <br/>


  cc @jtojnar for testing.


state: closed
title: guile-lib: 0.2.2 -> 0.2.6.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/60978
updated_at: 2019-05-19 19:18:03
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/guile-lib/versions.



  meta.description for guile-lib is: '"A collection of useful Guile Scheme modules"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.2.6.1 with grep in /nix/store/nndz8mkvzph1vb787jl4siiynmp89wvz-guile-lib-0.2.6.1
  - directory tree listing: https://gist.github.com/ceff2db5f3d5f7bc14c81b442c749471
  - du listing: https://gist.github.com/6127d8362188780e1aa56e003c33e08d

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  18 total rebuild path(s)

  6 package rebuild(s)

  6 x86_64-linux rebuild(s)
  6 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  6 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  guile-cairo
  guile-gnome
  guile-lib
  guile-reader
  gwrap
  skribilo

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/nndz8mkvzph1vb787jl4siiynmp89wvz-guile-lib-0.2.6.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A guile-lib https://github.com/r-ryantm/nixpkgs/archive/ab44dc015a1bdbfd4b2f8f202e04a00ac11950ff.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/nndz8mkvzph1vb787jl4siiynmp89wvz-guile-lib-0.2.6.1
  ls -la /nix/store/nndz8mkvzph1vb787jl4siiynmp89wvz-guile-lib-0.2.6.1/bin
  ```


  </details>
  <br/>


  cc @vyp for testing.


state: closed
title: compsize: 2018-04-07 -> 1.3
user_login: CrazedProgrammer
html_url: https://github.com/NixOS/nixpkgs/pull/60979
updated_at: 2019-05-11 07:39:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updates [compsize](https://github.com/kilobyte/compsize) to version 1.3 (latest stable version).
  Tested on a real btrfs filesystem with different compression algorithms.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libreoffice: install the unopkg extension management tool
user_login: royneary
html_url: https://github.com/NixOS/nixpkgs/pull/60980
updated_at: 2019-05-05 12:32:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This installs libreoffice's unopkg tool which allows managing libreoffice extensions from command line. unopkg is used by Zotero for example to automatically install its libreoffice extension.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] usb_modeswitch
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/60981
updated_at: 2019-06-25 12:46:14
body:
  ###### Motivation for this change

  usb_modeswitch currently isn't working #60878 

  This is unfortunately quite an extensive change, mostly redoing the packaging of usb-modeswitch itself. Because of the size of the change, I'd like a review from the nixpkgs packaging experts before attempting to upstream this. I have successfully tested this with an "LG L-02C LTE".

  This has the following goals:

  1. Make `DESTDIR` and `PREFIX` work as per usual. Currently `PREFIX` isn't supported due to many hardcoded paths.

  2. Remove hardcoded paths to dependencies and rely on the `PATH` variable instead.

  3. Allow configuration of which init systems to use, instead of checking the state of the build machine.

  Still TODO:

   - [ ] Fix kernel module probing

   - [ ] New default `PREFIX` changes the result of `make install`. Either change the readme, or restore the existing behavior.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: rtorrent-ps, libtorrent-ps: init at 1.1-37c9d4b
user_login: yorickvP
html_url: https://github.com/NixOS/nixpkgs/pull/60982
updated_at: 2019-05-05 11:29:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [rtorrent-ps](https://github.com/pyroscope/rtorrent-ps/) is a popular patch set for rtorrent. These packages are inspired by the [aur PKGBUILD](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=rtorrent-ps)

  (cc: @pyroscope, @ebzzry, @codyopel)

  I also have a pyrocore (python) package that should be upstreamed at some point.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: wireguard: add 'namespace' option to set interface netns
user_login: yorickvP
html_url: https://github.com/NixOS/nixpkgs/pull/60983
updated_at: 2019-06-04 06:21:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The usecase in the first section of https://www.wireguard.com/netns/ (making a network namespace to allow proper sandboxing) is rather easy to support in nixpkgs, and hard outside of it. This PR adds an option to do it.

  (cc: @Lucus16 , @grahamc, @mic92, @xeji, @fpletz )

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date **// can update the wiki after merge**
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


