# issues

state: closed
title: ponyc: FIX $CC undefined, using gcc as the linker
user_login: kamilchm
html_url: https://github.com/NixOS/nixpkgs/pull/33732
updated_at: 2018-01-13 18:24:41
body:
  ###### Motivation for this change

  https://github.com/ponylang/ponyc/issues/2482

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ghc, haskell-modules: ARM cross build fixes.
user_login: dhess
html_url: https://github.com/NixOS/nixpkgs/pull/33733
updated_at: 2018-01-17 06:47:46
body:
  As requested in #33405.

  /cc @Ericson2314 

  ###### Motivation for this change

  Fix ARM cross builds.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stumpwm: Work around dependency load errors during build
user_login: DerGuteMoritz
html_url: https://github.com/NixOS/nixpkgs/pull/33734
updated_at: 2018-04-19 17:23:04
body:
  ###### Motivation for this change

  The stumpwm package has been broken since late 2017. My guess is that this was caused by https://github.com/NixOS/nixpkgs/pull/28810 but it's a bit hard to pinpoint exactly.

  Note that this patch is merely a work-around. Something seems to be wrong with how the stumpwm system's dependency are loaded. As you can see, I worked around this by loading them explicitly before the build. @bradleyjensen since you recently overhauled the quicklisp-to-nix / lisp-packages code, maybe you have an idea of how to properly address this?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskell-modules: swagger2 still needs dontHaddock on armv7l-linux.
user_login: dhess
html_url: https://github.com/NixOS/nixpkgs/pull/33735
updated_at: 2018-01-17 06:47:27
body:
  ###### Motivation for this change

  Sometime while I was fixing these `armv7l-linux` modules, `configuration-common.nix` was re-organized and the author dropped the `dontHaddock` that used to be there on `swagger2`. I didn't notice until after the `armv7l-linux` `dontCheck` for `swagger2` was applied.

  Anyway, `dontHaddock` is still needed for that package on `armv7l-linux`.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: materia-theme: 20171213 -> 20180110
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33736
updated_at: 2018-01-11 22:52:25
body:
  ###### Motivation for this change

  Update to version [20180110](https://github.com/nana-4/materia-theme/releases/tag/v20180110)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: gzip: 1.8 -> 1.9
user_login: lsix
html_url: https://github.com/NixOS/nixpkgs/pull/33737
updated_at: 2018-01-22 07:50:00
body:
  See http://lists.gnu.org/archive/html/info-gnu/2018-01/msg00004.html
  for release informations.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Predictable interface names are gone on unstable
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/issues/33738
updated_at: 2018-01-26 20:17:45
body:
  ## Issue description
  After rebooting into current unstable (f607771d0f5e4fa905afff1c772febd9f3103e1a) interface names have reverted to old style (eth0, ...) despite nixos-option networking.usePredictableInterfaceNames reporting the set value as true.

  I'm using linuxPackages_latest, which is 4.14.12, but I'm not sure it's relevant.

  ## Technical details
  ```
  $ nix-info
  system: "x86_64-linux", multi-user?: yes, version: nix-env (Nix) 1.12pre5810_5d5b931f, channels(root): "", nixpkgs: /home/sarah/src/nixpkgs
  ```
  nixpkgs version: f607771d0f5e4fa905afff1c772febd9f3103e1a


state: closed
title: Apache Spark address CVE-2017-12612
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33739
updated_at: 2018-01-11 18:13:54
body:
  ###### Motivation for this change

  During a routine check I found that our current Apache Spark version is affected by CVE-2017-12612.

  This PR removed the ancient Apache Spark version form the 1.6 branch. It doesn't receive any updates anymore.

  Any objections?

  CC maintainers and contributors:  @thoughtpolice @offlinehacker @cko @mboes @samuelrivas @NixOS/security-notifications 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [17.09] Apache Spark address CVE-2017-12612
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33740
updated_at: 2018-01-12 09:47:22
body:
  ###### Motivation for this change

  During a routine check I found that our current Apache Spark version is affected by CVE-2017-12612.

  This PR marks the ancient Apache Spark version form the 1.6 branch as insecure. It doesn't receive any updates anymore.

  The minor version bump for the 2.1 branch should fix the mentioned CVE among some upstream fixes [1].

  CC maintainers and contributors:  @thoughtpolice @offlinehacker @cko @mboes @samuelrivas 


  [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315420&version=12340295

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: services.phpfpm.phpOptions is ignored
user_login: ivanovsaleksejs
html_url: https://github.com/NixOS/nixpkgs/issues/33741
updated_at: 2018-01-17 13:06:36
body:
  ## Issue description

  Parameter services.phpfpm.phpOptions is ignored. According to documentation it supposed to append configuration options to php.ini file.

  ### Steps to reproduce

  Add
  `services.phpfpm.phpOptions = ''`
  `  cgi.fix_pathinfo = 0;`
  ` '';`


  to .nix file and build. Look for generated php.ini file - option is not set. Also this command
  `$ php-fpm -i | grep pathinfo` outputs
  >  cgi.fix_pathinfo => 1 => 1

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 17.09.2630.81373e421e8 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(aleksejs): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: gdbm: 1.13 -> 1.14
user_login: lsix
html_url: https://github.com/NixOS/nixpkgs/pull/33742
updated_at: 2018-01-14 10:47:05
body:
  See http://lists.gnu.org/archive/html/info-gnu/2018-01/msg00000.html
  for release information

  ###### Motivation for this change

  This is a bugfix release, and it should probably be ported to stable (see release information):  @fpletz 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cassandra: version bump 2.1.15->2.1.19, 2.2.9->2.2.11, 3.0.9->3.0.15
user_login: fuzzy-id
html_url: https://github.com/NixOS/nixpkgs/pull/33743
updated_at: 2018-02-07 12:05:51
body:
  ###### Motivation for this change

  Bump older (but still supported) versions of Apache Cassandra.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I used the new tests of #31410. This tests `nodetool`, `cqlsh` and building a cassandra cluster.

  ---


state: open
title: at-spi2-core: failed to connect to socket
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/33744
updated_at: 2018-01-11 13:38:14
body:
  ## Issue description

  It seems that all gtk applications cannot connect to accessibility bus on unstable NixOS.

  For instance, running `gedit` on a terminal I am getting:
  ```
  $ gedit

  ** (gedit:11959): WARNING **: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/dbus-cbjLtIjt2o: Connection refused
  ```

  The service is enabled in `configuration.nix`:
  ``` nix
    services.gnome3.at-spi2-core.enable = true;
  ```

  It seems that the window manager or desktop is irrelevant, as it happens with openbox, fluxbox, enlightenment, mate, and others.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.12, NixOS, 18.03pre125026.f607771d0f5 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.03pre125026.f607771d0f5"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: open
title: AArch64 for 18.03
user_login: dezgeg
html_url: https://github.com/NixOS/nixpkgs/issues/33745
updated_at: 2019-01-22 22:54:35
body:
  Let's get AArch64 support into a reasonable state for 18.03. 

  - [x] #33749 Make Hydra build the aarch64 sd-image (For Raspberry Pi 3 as the main hardware target) similar to how the ISOs are built: https://github.com/NixOS/nixpkgs/blob/master/nixos/release.nix#L144
  - [x] Refactor x86-isms in https://github.com/NixOS/nixpkgs/blob/master/nixos/release.nix
  - [ ] Implement the Packet image: https://github.com/NixOS/nixpkgs/issues/31606. I have some progress in https://github.com/NixOS/nixpkgs/pull/32618.
  - [ ] ZHF: https://github.com/NixOS/nixpkgs/issues/32326. Let's target to having less failures than Darwin ;)
  - [ ] Perhaps migrate some documentation from the Wiki to the official docs.


state: closed
title: docker-edge: 17.12.0 -> 18.01.0
user_login: NeQuissimus
html_url: https://github.com/NixOS/nixpkgs/pull/33746
updated_at: 2019-04-17 01:59:02
body:
  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qt5: reduce evaluation memory use
user_login: ttuegel
html_url: https://github.com/NixOS/nixpkgs/pull/33747
updated_at: 2018-01-11 20:57:11
body:
  ### Motivation

  Memory use prohibits adding new Qt package sets. Removing `recurseIntoAttrs` from `libsForQt5` reduces memory use by ~60 MB per platform.


  ### Testing

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] ~Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))~
  - [ ] ~Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`~
  - [ ] ~Tested execution of all binary files (usually in `./result/bin/`)~
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: browserpass does not taltk to firefox 57
user_login: wucke13
html_url: https://github.com/NixOS/nixpkgs/issues/33748
updated_at: 2018-04-16 19:00:50
body:
  ## Issue description
  With `firefox-57`, `browserpass` does not work properly. When clicking on the browserpass icon in firefox, browserpass states 'Error talking to browserpass'

  ### Steps to reproduce

  + Install browserpass via `programs.browserpass.enable = true`
  + Install firefox via `environment.systemPackages = with pkgs; [ firefox ]`
  + Install browserpass browserplugin via firefox marketplace
  + Click on browserpass icon in firefox

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.9, NixOS, 17.09.2498.a9ffb7b0b5a (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2498.a9ffb7b0b5a"`
   - channels(wucke13): `"nixpkgs-18.03pre121983.fd7953d95f4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: nixos/release.nix: Refactoring for better multi-system support
user_login: dezgeg
html_url: https://github.com/NixOS/nixpkgs/pull/33749
updated_at: 2018-01-16 17:54:12
body:
  Currently, even if you pass `supportedSystems = [ "aarch64-linux" ]` you
  end up with e.g. `nixos.iso_graphical.x86_64-linux` job. Using the new
  forSubsetOfSystems avoids that.

  This shouldn't affect the usual x86 trunk-combined jobset.

  https://hydra.nixos.org/eval/1425558#tabs-removed for the effect on an aarch64-only jobset.


state: closed
title: tifffile: init at v0.13.0
user_login: lebastr
html_url: https://github.com/NixOS/nixpkgs/pull/33750
updated_at: 2018-01-13 18:19:26
body:
  ###### Motivation for this change
  I needed to read a 16bit tiff files with python. Tifffile reads tiff into numpy array.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Elixir 1.6 RC
user_login: ankhers
html_url: https://github.com/NixOS/nixpkgs/pull/33751
updated_at: 2018-01-11 16:54:34
body:
  ###### Motivation for this change

  New RC for Elixir 1.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avidemux: support alsa
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/33753
updated_at: 2018-01-13 18:24:16
body:
  ###### Motivation for this change

  Avidemux currently doesn't support bare Alsa output, only PulseAudio. Fix that.
  cc maintainers @viric @abbradar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virt-manager: add gobjectIntrospection to nativeBuildInputs
user_login: erosennin
html_url: https://github.com/NixOS/nixpkgs/pull/33754
updated_at: 2018-01-24 12:29:25
body:
  Another package broken by removal of `gobjectIntrospection` from `propagatedBuildInputs` of `atk` (6bbec17d44d700c9d847a486b6168b2ea57e7350).

  This is similar to ea595a0fbfeef0585f4f44ab5173e88018bf0d10, 5350b0f6694fe1aa3f0d8d2523d8301382f72ae5, 2a1425d8b7504572dbceb69e851aa27f05b4fc34, d99321cf68a2b200112f384f311de2c1f87d39d8, etc.

  ###### Motivation for this change

  Without this, `virt-manager` fails to start with this error:
  ```
  Traceback (most recent call last):
    File "/nix/store/5fvw5w6bykry9yqnz0wfrn39s7x3fhcx-virt-manager-1.4.3/share/virt-manager/virt-manager", line 32, in <module>
      gi.require_version('LibvirtGLib', '1.0')
    File "/nix/store/p6fnhmmvr28ziv19c37hr9n6vkcy25an-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/__init__.py", line 130, in require_version
      raise ValueError('Namespace %s not available' % namespace)
  ValueError: Namespace LibvirtGLib not available
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/tests/keymap: disable xterm DM
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/33755
updated_at: 2018-01-15 12:23:36
body:
  ###### Motivation for this change
  Another go at alleviating the flaky keymap tests.

  ###### Things done
  The xterm display manager has been disabled. The test spins up its own xterm, but sometimes the DM xterm would be in focus instead, causing failures..

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pngpp: darwin support
user_login: acowley
html_url: https://github.com/NixOS/nixpkgs/pull/33756
updated_at: 2018-01-11 22:46:28
body:
  1) Building with clang is addressed by navigating a minor #if in some
  of the code.

  2) I noticed that even when things were building correctly, passing
  `${out}` as a variable assignment to `make` was actually not working:
  there were compiler warnings about missing include directories whose
  bogus paths involved the literal string `out`. I ended up fixing this
  by performing the assignment to the make variable `PREFIX` in the
  `Makefile` itself.

  ###### Motivation for this change
  Make pngpp build on darwin.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python: remove unneeded name attributes, remove rec, make afew an application
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/33758
updated_at: 2018-01-20 12:49:13
body:
  ###### Motivation for this change
  As I found out, it's not necessary to specify the `name` for python packages if we set `pname` and `version`. Additionally, get rid of the `rec`, and change the `afew` package to be a python application (what it is, it's not a library).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pgmanage: 10.0.2 -> 10.1.0
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33759
updated_at: 2018-01-12 02:43:11
body:
  ###### Motivation for this change

  https://github.com/pgManage/pgManage/releases/tag/v10.1.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elasticsearch-curator-5.4.1 on release-17.09
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33760
updated_at: 2018-01-14 15:29:57
body:
  ###### Motivation for this change

  @orivej I would like to use `elasticsearch-curator` on 17.09 so I cherry picked the commits from https://github.com/NixOS/nixpkgs/pull/32905 on `release-17.09`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avrgcc: bake path to avr-ar into avr-gcc-ar
user_login: kierdavis
html_url: https://github.com/NixOS/nixpkgs/pull/33762
updated_at: 2018-01-12 15:17:40
body:
  (tl;dr: this fixes a bug in `avrgcc` that's present in master and in the current release)

  `gcc` provides wrappers for `binutils`' `ar`, `nm` and `ranlib`
  executables, which must be used instead when using link-time
  optimisation. See also:
  http://manpages.ubuntu.com/manpages/zesty/man1/aarch64-linux-gnu-gcc-ar-5.1.html

  The upstream version of `avr-gcc-ar` searches in paths passed to
  the `configure` script for the `avr-ar` binary that it wraps, falling
  back to searching `PATH` instead. Thus currently `avr-gcc-ar` works on
  Nix, but only if `avrbinutils` is already in the environment.

  This change bakes the path to `avr-ar` into `avr-gcc-ar`, since its path
  is known at compile time. It also no longer searches `PATH`, meaning the
  user's local environment won't override this path.

  Note that `avr-gcc-nm` and `avr-gcc-ranlib` are compiled from the same
  source file as `avr-gcc-ar`, just with different compiler flags.

  Testing on master (without `avrbinutils` in the environment):

      $ nix-build -A avrgcc
      $ result/bin/avr-gcc-ar --version
      result/bin/avr-gcc-ar: Cannot find binary 'avr-ar'

  Testing on branch with this fix:

      $ nix-build -A avrgcc
      $ result/bin/avr-gcc-ar --version
      GNU ar (GNU Binutils) 2.26.20160125
      ...

  ###### Motivation for this change

  `avr-gcc-ar` shouldn't require any particular package to be present in the user's environment when it is run.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc package maintainer @mguentner


state: closed
title: Radarr: Authentication Bypass Vulnerability
user_login: Moredread
html_url: https://github.com/NixOS/nixpkgs/issues/33763
updated_at: 2018-01-12 03:17:21
body:
  There has been a Authentication Bypass Vulnerability fixed in the latest version of Radarr.

  See https://github.com/Radarr/Radarr/releases/tag/v0.2.0.910 under Fixes

  "Security Vulnerabilities allowing authentication to be bypassed (discovered by Kyle Neideck) [Taloth Saldono]"


state: closed
title: Sonarr: Authentication Bypass Vulnerability
user_login: Moredread
html_url: https://github.com/NixOS/nixpkgs/issues/33764
updated_at: 2018-01-12 03:17:21
body:
  There has been a Authentication Bypass Vulnerability fixed in the latest version of Sonarr.

  See https://github.com/Sonarr/Sonarr/releases/tag/v2.0.0.5085


state: closed
title: python grpcio doesn't build on darwin
user_login: joestein
html_url: https://github.com/NixOS/nixpkgs/issues/33765
updated_at: 2018-04-02 14:53:17
body:
  ## Issue description
  Getting an error trying to build grpcio 1.7.3 on darwin

  make: Circular /private/var/folders/4k/jpntp1hn6b7c9ymh7v044b9h0000gn/T/nix-build-python2.7-grpcio-1.7.3.drv-0/grpcio-1.7.3/libs/opt/libares.a <- /private/var/folders/4k/jpntp1hn6b7c9ymh7v044b9h0000gn/T/nix-build-python2.7-grpcio-1.7.3.drv-0/grpcio-1.7.3/libs/opt/libz.a dependency dropped.
  ar: illegal option -- /
  usage:  ar -d [-TLsv] archive file ...
         	ar -m [-TLsv] archive file ...
         	ar -m [-abiTLsv] position archive file ...
         	ar -p [-TLsv] archive [file ...]
         	ar -q [-cTLsv] archive file ...
         	ar -r [-cuTLsv] archive file ...
         	ar -r [-abciuTLsv] position archive file ...
         	ar -t [-TLsv] archive [file ...]
         	ar -x [-ouTLsv] archive [file ...]
  make: *** [Makefile:8459: /private/var/folders/4k/jpntp1hn6b7c9ymh7v044b9h0000gn/T/nix-build-python2.7-grpcio-1.7.3.drv-0/grpcio-1.7.3/libs/opt/libares.a] Error 1


  ### Steps to reproduce
  ```
  with import <nixpkgs> { };

  let
    my_grpcio = python27.pkgs.buildPythonPackage rec {
      pname = "grpcio";
      version = "1.7.3";

      src = python27.pkgs.fetchPypi {
        inherit pname version;
        sha256 = "1wkrxj1jmf2dyx207fc9ysyns9h27gls3drgg05mzdckjqr5lnl6";
      };

      buildInputs = [ python27Packages.protobuf python27Packages.enum34 python27Packages.futures python27Packages.six ];

      meta = with stdenv.lib; {
        description = "HTTP/2-based RPC framework";
        license = lib.licenses.bsd3;
        homepage = "https://grpc.io/grpc/python/";
        maintainers = with maintainers; [ tbd ];
      };
    };
  in
  stdenv.mkDerivation {
      name = "grpc";
      buildInputs = [ my_grpcio ];
  }
  ```
  nix-shell grpcio.nix

  ## Technical details
   - system: `"x86_64-darwin"`
   - host os: `Darwin 15.6.0, macOS 10.11.6`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.8`
   - channels(joestein): `"nixpkgs-18.03pre125021.73a01aa028c"`
   - nixpkgs: `/Users/joestein/.nix-defexpr/channels/nixpkgs`


state: closed
title: Sonarr & radarr vulnerabilities
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33766
updated_at: 2018-01-12 03:28:34
body:
  ###### Motivation for this change
  Security vulnerabilities found

  Fixes https://github.com/NixOS/nixpkgs/issues/33764
  Fixes https://github.com/NixOS/nixpkgs/issues/33763

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: disable phantomjs support on darwin by default
user_login: corngood
html_url: https://github.com/NixOS/nixpkgs/pull/33767
updated_at: 2018-01-13 16:57:02
body:
  ###### Motivation for this change

  @jwiegley pointed out that phantomjs2 is broken on darwin.

  Could someone test this on macos, or trigger a robot build?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: haskell.compiler.ghcjs install fails on darwin
user_login: qmmdb
html_url: https://github.com/NixOS/nixpkgs/issues/33768
updated_at: 2018-01-12 04:07:56
body:
  ## Issue description

  https://gist.github.com/qmmdb/3bb39f0b78a9c5da1916172ececb86fd
  ```
  ld: library not found for -lncurses
  clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
  `clang' failed in phase `Linker'. (Exit code: 1)
  ```


  ### Steps to reproduce

  Run `nix-shell -p haskell.compiler.ghcjs`


  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 16.7.0, macOS 10.12.6`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixpkgs-18.03pre125021.73a01aa028c"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`


state: closed
title: kde-applications: 17.12.0 -> 17.12.1
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33769
updated_at: 2018-01-13 20:00:24
body:
  ###### Motivation for this change
  Bugfix release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @peterhoeg @bkchr @ttuegel 


state: closed
title: palemoon: .desktop not executable, doesn't include icon in file.
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/issues/33770
updated_at: 2018-01-13 12:47:45
body:
  ## Issue description
  I installed Pale Moon and I noticed it didn't show up in KDE, I checked the usr/share/applications/palemoon.desktop file and it is missing both the +x bit and the icon name. (Possibly missing the icon itself)

  ### Steps to reproduce
  Install Pale Moon.

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.11.0, NixOS, 18.03pre125026.f607771d0f5 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.03pre125026.f607771d0f5"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: pixie: refactor to allow macOS build
user_login: alekcz
html_url: https://github.com/NixOS/nixpkgs/pull/33771
updated_at: 2018-01-19 03:04:07
body:
  ###### Motivation for this change
  - Adding macOS support for pixie (pixie has been support on macOS for quite a while already)
  - Updating the name as discussed on issue 445 (https://github.com/pixie-lang/pixie/issues/455)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stage-1-init.sh: bcachefs and fsck
user_login: Chiiruno
html_url: https://github.com/NixOS/nixpkgs/issues/33772
updated_at: 2018-01-12 07:04:12
body:
  ## Issue description
  Bcachefs fsck is working fine when run from the terminal. `$ bcachefs fsck /dev/sda1`
  I assume bcachefs is not implemented in the fsck program itself, so perhaps having a special-case scenario for bcachefs in stage-1-init.sh until fsck implements it would be ideal, since the bcachefs program does implement a filesystem check?

  ### Steps to reproduce
  Boot with bcachefs filesystem.

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.11.0, NixOS, 18.03pre125026.f607771d0f5 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.03pre125026.f607771d0f5"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: enpass: 5.6.0 -> 5.6.5
user_login: cyraxjoe
html_url: https://github.com/NixOS/nixpkgs/pull/33773
updated_at: 2018-01-12 09:51:33
body:
  ###### Motivation for this change

  New release of Enpass https://www.enpass.io/release-notes/linux/

  The changes in the file were done by using the "refresh" attribute on a nix-shell:
  ```
  nix-shell  ./ -A enpass.refresh
  ```
  which in turns uses `update_script.py` (part of the enpass tooling in nixpkgs)
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Elasticsearch curator 5.4.1 cleanup
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33774
updated_at: 2018-01-14 14:00:03
body:
  ###### Motivation for this change

  @FRidh these are the changes you requested in: https://github.com/NixOS/nixpkgs/pull/33760#pullrequestreview-88400114. Please merge so that I can cherry-pick them in PR #33760.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add documentation to haskell.lib
user_login: roberth
html_url: https://github.com/NixOS/nixpkgs/pull/33775
updated_at: 2018-01-12 10:21:09
body:
  ###### Motivation for this change

  This documents most of the interesting functions in `haskell.lib` and some of the obvious ones. Most of this work was done during the documentation sprint at the NixCon 2017 hackathon in Munich. That's also why this uses the `/* */` syntax, because that was the syntax we found was already in use in many of the 'core' library modules in `/lib`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS - evaluation still works
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update sigal
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/33776
updated_at: 2018-01-12 12:08:22
body:
  Pinging @domenkozar as maintainer. I added myself as maintainer here, I hope that's okay.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [emacs] No longer able to use melpaUnstable from nixos-unstable in a stable Emacs
user_login: michalrus
html_url: https://github.com/NixOS/nixpkgs/issues/33777
updated_at: 2018-07-14 13:25:45
body:
  ## Issue description

  Previously, one could do:

  ```nix
  {
    myEmacs = (pkgs.emacsPackagesNgGen pkgs.emacs25).emacsWithPackages (epkgs:
      # MELPA Unstable @ NixOS Unstable (bleedingest edge)
      (with (pkgs.nixos-unstable.emacsPackagesNgGen base).melpaPackages; [
        dante
        hayoo
      ])
      ++
      (with epkgs.melpaStablePackages; [
        # … regular stable packages here …
      ])
    );
  }
  ```

  Now, this fails with:

  ```
  *-dante-emacs-*/nix-support/setup-hook: line 10: addEnvHooks: command not found
  ```

  Cf. https://github.com/michalrus/dotfiles/commit/e6882789cd0c685b1e35df67e78e0e936c4269f7 — it worked on 1bc288591ea4fe3159b7630dcd2b57733d80a2ff, doesn’t work anymore on f607771d0f5e4fa905afff1c772febd9f3103e1a.

  How to do it now?

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 17.09.2683.360089b3521 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2683.360089b3521"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: pythonPackages.pillow: 4.3.0 -> 5.0.0
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/33778
updated_at: 2019-05-18 11:03:15
body:
  ###### Motivation for this change

  Checking whether this fixes [an issue](https://github.com/saimn/sigal/issues/287) with `sigal`, which uses this lib.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nix copy in runInLinuxVM is very slow
user_login: ledettwy
html_url: https://github.com/NixOS/nixpkgs/issues/33779
updated_at: 2018-01-12 13:32:06
body:
  ## Issue description

  I'm seeing an extreme performance difference between `nix copy` and a regular `cp -rH`. Example output given below:

  Code:
  <pre>
  path=/nix/store/0i2jd68mp5g6h2sa5k9c85rb80sn8hi9-hello
  du -h --max-depth=1 $path;
  time cp -rH $path /mnt/tmp/$(basename $path)
  time nix copy --no-recursive --to "local?root=/mnt" --no-check-sigs $path
  </pre>

  Output:
  <pre>
  44K     /nix/store/0i2jd68mp5g6h2sa5k9c85rb80sn8hi9-hello-2.10/bin
  580K    /nix/store/0i2jd68mp5g6h2sa5k9c85rb80sn8hi9-hello-2.10/share
  628K    /nix/store/0i2jd68mp5g6h2sa5k9c85rb80sn8hi9-hello-2.10

  real    0m0.524s
  user    0m0.005s
  sys     0m0.017s
  warning: the group 'nixbld' specified in 'build-users-group' does not exist
  warning: the group 'nixbld' specified in 'build-users-group' does not exist
  [1 copied (0.2 MiB)]

  real    0m7.033s
  user    0m0.189s
  sys     0m2.453s
  </pre>

  Extend this to 2GB worth of /nix/store paths to copy and the operation takes over an hour.

  ### Steps to reproduce

  I'll try to put together a portable reproducer soon that can be run easily.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 17.09.2683.360089b3521 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixpkgs-17.09.2683.360089b3521, unstable-18.03pre125026.f607771d0f5, nixos-17.09.2683.360089b3521"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: Ruby: 2.2.8 -> 2.2.9, 2.3.5 -> 2.3.6, 2.4.2 -> 2.4.3
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/33780
updated_at: 2018-01-12 13:28:09
body:
  ###### Motivation for this change

  Security issues described in https://www.ruby-lang.org/en/news/2017/12/14/net-ftp-command-injection-cve-2017-17405/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qlipper: 5.0.0 -> 5.1.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33781
updated_at: 2018-01-12 14:01:56
body:
  ###### Motivation for this change

  Update to version [5.1.1](https://github.com/pvanek/qlipper/blob/master/CHANGELOG)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: auquantoolbox: init at 2.0.8
user_login: pallavagarwal07
html_url: https://github.com/NixOS/nixpkgs/pull/33782
updated_at: 2019-03-30 19:40:12
body:
  ###### Motivation for this change
  I need this package for development.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Opencv 3.3.1 release 17.09
user_login: roelvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33783
updated_at: 2018-02-17 08:49:50
body:
  ###### Motivation for this change

  Upgrading OpenCV from 3.2.0 to 3.3.1. Contains many bugfixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of most binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: google-cloud-sdk: 182.0.0 -> 184.0.0
user_login: zimbatm
html_url: https://github.com/NixOS/nixpkgs/pull/33784
updated_at: 2018-01-12 13:51:08
body:
  ###### Motivation for this change

  updgrade !11!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plano-theme: init at 3.24-3
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33786
updated_at: 2018-01-13 12:56:11
body:
  ###### Motivation for this change

  Add [`plano-theme`](https://github.com/lassekongo83/plano-theme)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: digitalbitbox: init at 2.2.2
user_login: vidbina
html_url: https://github.com/NixOS/nixpkgs/pull/33787
updated_at: 2018-02-27 23:39:53
body:
  ###### Motivation for this change

  I just got a [digitalbitbox](https://digitalbitbox.com/) to play around with and couldn't find the apps (searched for `dbb` or `digitalbitbox`) in the nixpkgs index (or any PR or issue for that matter) so here goes...

  For context's sake: Squashed it from [this branch on top of the latest master](https://github.com/vidbina/nixpkgs/tree/add/digitalbitbox-pre-rebase) which followed from [this branch based on my `nixos-version --revision`](https://github.com/vidbina/nixpkgs/tree/wip/digitalbitbox). Maybe that helps clarify some decisions made; however messy.

  ![2018-01-12-160210_3200x1800_scrot](https://user-images.githubusercontent.com/335406/34880853-0a5e3236-f7b2-11e7-9a35-cf85d79bdbec.png)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jgmenu: 0.7.6 -> 0.8
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33789
updated_at: 2018-01-13 12:55:36
body:
  ###### Motivation for this change

  Update to version [0.8](https://github.com/johanmalm/jgmenu/releases/tag/v0.8)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: jenkins: 2.95 -> 2.101
user_login: lo1tuma
html_url: https://github.com/NixOS/nixpkgs/pull/33791
updated_at: 2018-01-13 16:33:55
body:
  ###### Motivation for this change

  [Changelog](https://jenkins.io/changelog/)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: scid-vs-pc: init at version 4.18.1
user_login: paraseba
html_url: https://github.com/NixOS/nixpkgs/pull/33792
updated_at: 2018-01-14 02:21:50
body:
  ###### Motivation for this change
  scid vs. PC is a chess program forked from scid and more maintained than the original. scid was packaged already

  cc: @aszlig (packager of scid)

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flootty: init at 3.2.1
user_login: sellout
html_url: https://github.com/NixOS/nixpkgs/pull/33793
updated_at: 2018-01-22 05:41:51
body:
  ###### Motivation for this change

  Adding a tool I use – the Emacs & Vim plugins for Floobits are already in nixpkgs, and this complements them.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: config.hardware.onlykey configuration option
user_login: yrashk
html_url: https://github.com/NixOS/nixpkgs/pull/33794
updated_at: 2018-05-04 11:04:30
body:
  By default, OnlyKey device (https://crp.to/p/) won't work on Linux (and,
  therefore, NixOS). This is unintuitive and requires one to search for a
  solution in the documentation.

  This change allows one to enable OnlyKey device support directly from
  their NixOS configuration.

  ###### Motivation for this change

  Adding straightforward support for OnlyKey to NixOS.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Tested in a VM
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gstreamermm: 1.8.0 -> 1.10.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33795
updated_at: 2018-01-13 14:23:35
body:
  ###### Motivation for this change

  Update to version [1.10.0](http://ftp.gnome.org/pub/gnome/sources/gstreamermm/1.10/gstreamermm-1.10.0.news)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: /etc/zshrc overrides environment variables like HISTFILE with "history defaults"
user_login: ghost
html_url: https://github.com/NixOS/nixpkgs/issues/33797
updated_at: 2018-01-13 00:51:04
body:
  ## Issue description

  If you set `HISTFILE` variable in `~/.zprofile` it will be overriden by `/etc/zshrc`. You could instead use `~/.zshrc` to set the `HISTFILE` variable but I don't think that's where it belongs to.

  I would suggest

  1. either we remove [these](https://github.com/NixOS/nixpkgs/blob/release-17.09/nixos/modules/programs/zsh/zsh.nix#L152-L157) "history defaults" from `/etc/zshrc` because I don't see any reason why NixOS should not simply use the ZSH defaults of these variables.

  2. Or we move those "history defaults" from `/etc/zshrc` to `/etc/zprofile`.

  ### Steps to reproduce

  Set `HISTFILE` variable in `~/.zprofile` and watch it being overriden by `/etc/zshrc`.


state: open
title: Qt5.6 deprecation tracking issue
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/issues/33798
updated_at: 2019-05-07 20:31:43
body:
  There is not a whole lot of packages still depending on Qt `5.6`  and `5.9` is the current LTS.

  Packages depending on Qt 5.6:
  - [x] qgo (https://github.com/NixOS/nixpkgs/commit/0fbb2f1517e83a0bb35c8e06d57170a3574c2f04)
  - [x] apitrace (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] cool-retro-term (~~Broken package, does not even work with Qt 5.6~~, works when installed in `systemPackages`) (https://github.com/NixOS/nixpkgs/commit/3538492f3308952b74570ddd63e1bc1999f9c641)
  - [x] hotspot (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] owncloud-client (https://github.com/NixOS/nixpkgs/commit/1ec304ce0122ba8bf9d001495f2a03d9f37f0afd)
  - [x] supercollider (https://github.com/NixOS/nixpkgs/commit/7dea1f20ed5512fd2992ced563e9b355e70afe97)
  - [x] qcachegrind (https://github.com/NixOS/nixpkgs/commit/08ab28b9a32254445e3fcf1b8ccb2bd68071bde4)
  - [x] xxdiff-tip (e2f7267ba2f89e858fc60b6033f0f85191b1ee61)
  - [ ] cutegram (Fixed in https://github.com/NixOS/nixpkgs/pull/33823)
  - [x] gpsbabel [(WIP](https://github.com/NixOS/nixpkgs/pull/33836))
  - [x] luminanceHDR (https://github.com/NixOS/nixpkgs/commit/cad14c782b15da7bb5b636a8bd70fee985905b40)
  - [x] mendeley (~~Unfree package, might be tricky~~ (https://github.com/NixOS/nixpkgs/pull/33864))
  - [x] mumble (See https://github.com/NixOS/nixpkgs/pull/33800)
  - [x] smtube (https://github.com/NixOS/nixpkgs/commit/747431cf4229e7f02f691534d7203acb8d1b07e9)
  - [x] notepadqq (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] qgroundcontrol (https://github.com/NixOS/nixpkgs/commit/5f232de6cda58185c4a0a4f3d4a73b9e9f2856be)
  - [x] qsyncthingtray (See https://github.com/NixOS/nixpkgs/pull/33128)
  - [x] rapcad (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] ricochet (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] sigil (https://github.com/NixOS/nixpkgs/commit/4ffc43f49cf0636ca0e4169bf0dd76f61e5a080b)
  - [x] cura (Fixed in https://github.com/NixOS/nixpkgs/pull/33799)
  - [x] teamspeak_client (~~Unfree package, might be tricky~~ (https://github.com/NixOS/nixpkgs/pull/33863))
  - [x] trojita (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [x] vogl (Addressed in https://github.com/NixOS/nixpkgs/pull/33803)
  - [ ] golden-cheetah (Has pre-release that should work with 5.9) 

  cc @ttuegel @peterhoeg @bkchr @yegortimoshenko  


state: closed
title: cura: 3.0.3 -> 3.1.0
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33799
updated_at: 2018-01-13 18:19:23
body:
  ###### Motivation for this change
  Now building with Qt `5.9` (see https://github.com/NixOS/nixpkgs/issues/33798)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @abbradar 


state: closed
title: mumble_git: 2017-05-25 -> 2018-01-12
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33800
updated_at: 2018-01-13 12:20:43
body:
  ###### Motivation for this change
  Now building with Qt 5.9 instead of 5.6. (See https://github.com/NixOS/nixpkgs/issues/33798)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @viric @jgeerds @wkennington


state: closed
title: mblaze: 0.2 -> 0.3
user_login: ajgrf
html_url: https://github.com/NixOS/nixpkgs/pull/33802
updated_at: 2018-01-30 20:48:31
body:
  ###### Motivation for this change

  New release was published today.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Change package builds to use Qt 5.9
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33803
updated_at: 2018-01-13 11:46:08
body:
  ###### Motivation for this change
  See https://github.com/NixOS/nixpkgs/issues/33798

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I have tested running all applications and it seems fine so far but would like a little bit more testing.

  cc maintainers:
  @deepfire 
  @codsl 
  @jgillich 
  @np 
  @7c6f434c 
  @rszibele 
  @nh2 
  @nckx 


state: closed
title: aenum: make tests pass
user_login: yrashk
html_url: https://github.com/NixOS/nixpkgs/pull/33805
updated_at: 2018-01-16 09:40:41
body:
  For Python 2, tests were failing because they depended on a particular
  way of executing the tests module as it defined a global variable
  and created a temporary file. Running it through setup.py didn't work.
  Invoking it directly solved the issue.

  For Python 3, aenum tests were disabled, however, they did't have to
  fail. Configuring UTF8 locale resolved the failure that was happening
  after the above fix for Python 2 was applied.

  ###### Motivation for this change

  Couldn't build another derivation that had to depend on aenum, even on Python 2, as the tests were failing.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I tried to use `nox-review wip`, however, I got a failure on the `dbf` derivation, however, at least for me, building `dbf` fails for Python 2.7 on master nixpkgs anyway (because `aenum`'s tests fail). Any advice on this will be highly appreciated.

  cc @vrthra 


state: closed
title: jdupes: 1.8 -> 1.9
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33806
updated_at: 2018-01-13 09:00:54
body:
  ###### Motivation for this change

  Update to version [1.9](https://github.com/jbruchon/jdupes/releases/tag/v1.9)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Haskell package gitHUD doesn't build
user_login: jlesquembre
html_url: https://github.com/NixOS/nixpkgs/issues/33807
updated_at: 2018-01-18 08:42:37
body:
  ## Issue description
  Haskell package gitHUD doesn't build with latest master.


  ### Steps to reproduce
  ```
  nix-build "<nixpkgs>" -A haskellPackages.gitHUD 
  ```

  Output:
  ```
  these derivations will be built:
    /nix/store/9734f4vggdjfyavizgpp7258zf8j3zc7-gitHUD-1.3.7.drv
  building path(s) ‘/nix/store/8anbmlzr1ldq48cgkwmj735zcf958yvh-gitHUD-1.3.7’, ‘/nix/store/v92mdc1lhiwx8w026dpgk4d1dw7jqyf1-gitHUD-1.3.7-doc’
  setupCompilerEnvironmentPhase
  Build with /nix/store/yffcwqy0qpdvq9d9309dj0skxvdf9nhk-ghc-8.2.2.
  unpacking sources
  unpacking source archive /nix/store/4pvzgz1asylpqa4hm8g2c7y4442vmham-gitHUD-1.3.7.tar.gz
  source root is gitHUD-1.3.7
  setting SOURCE_DATE_EPOCH to timestamp 1490984272 of file gitHUD-1.3.7/gitHUD.cabal
  patching sources
  compileBuildDriverPhase
  setupCompileFlags: -package-db=/tmp/nix-build-gitHUD-1.3.7.drv-0/package.conf.d -j1 -threaded
  [1 of 1] Compiling Main             ( Setup.hs, /tmp/nix-build-gitHUD-1.3.7.drv-0/Main.o )
  Linking Setup ...
  configuring
  configureFlags: --verbose --prefix=/nix/store/8anbmlzr1ldq48cgkwmj735zcf958yvh-gitHUD-1.3.7 --libdir=$prefix/lib/$compiler --libsubdir=$pkgid --docdir=/nix/store/v92mdc1lhiwx8w026dpgk4d1dw7jqyf1-gitHUD-1.3.7-doc/share/doc --with-gcc=gcc --package-db=/tmp/nix-build-gitHUD-1.3.7.drv-0/package.conf.d --ghc-option=-optl=-Wl,-rpath=/nix/store/8anbmlzr1ldq48cgkwmj735zcf958yvh-gitHUD-1.3.7/lib/ghc-8.2.2/gitHUD-1.3.7 --ghc-option=-j1 --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-library-vanilla --enable-executable-dynamic --enable-tests --ghc-option=-split-sections
  Configuring gitHUD-1.3.7...
  CallStack (from HasCallStack):
    die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:948:20 in Cabal-2.0.1.0:Distribution.Simple.Configure
    configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:470:12 in Cabal-2.0.1.0:Distribution.Simple.Configure
    configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:570:20 in Cabal-2.0.1.0:Distribution.Simple
    confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.0.1.0:Distribution.Simple.UserHooks
    configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:174:19 in Cabal-2.0.1.0:Distribution.Simple
    defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:119:27 in Cabal-2.0.1.0:Distribution.Simple
    defaultMain, called at Setup.hs:2:8 in main:Main
  Setup: Encountered missing dependencies:
  tasty-quickcheck ==0.8.*
  builder for ‘/nix/store/9734f4vggdjfyavizgpp7258zf8j3zc7-gitHUD-1.3.7.drv’ failed with exit code 1
  error: build of ‘/nix/store/9734f4vggdjfyavizgpp7258zf8j3zc7-gitHUD-1.3.7.drv’ failed
  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.61, NixOS, 18.03.git.aeff308 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.15`
   - channels(root): `"nixos-16.09.1787.e1874d0"`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```


state: closed
title: webkitgtk: 2.18.4 → 2.18.5
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/33808
updated_at: 2018-01-19 06:22:17
body:
  ###### Motivation for this change
  Fixes [CVE-2017-5753](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-5753) and [CVE-2017-5715](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-5715)

  https://webkitgtk.org/2018/01/10/webkitgtk2.18.5-released.html


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixpkgs-lint: fix
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/33809
updated_at: 2018-01-12 23:42:05
body:
  ###### Motivation for this change
  Gave runtime error before

  Note that while it runs with this change, it throws a warning at runtime because the variable `drvPath` isn't defined in this line: https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/nixpkgs-lint.pl#L151. My perl is insufficient to decipher the meaning of this line and how to get rid of the warning.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: boehm-gc, libatomic_ops: 7.6.0 -> 7.6.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33810
updated_at: 2018-01-26 07:57:07
body:
  ###### Motivation for this change

  boehm-gc: https://github.com/ivmai/bdwgc/releases/tag/v7.6.2
  libatomic_ops: https://github.com/ivmai/libatomic_ops/releases/tag/v7.6.2

  Large number of fixes and (apparently) 7.6.0 was only a "pre-release".

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: release-small: Don't attempt to access "dbus.libs", etc., don't exist
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33811
updated_at: 2018-01-16 20:32:39
body:
  dbus_libs and others do, but they're deprecated.

  Just build 'dbus', these are now its various outputs.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: subtitleeditor: 0.53.0 -> 0.54.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33812
updated_at: 2018-01-13 10:55:20
body:
  ###### Motivation for this change

  Update to version [0.54.0](https://github.com/kitone/subtitleeditor/releases/tag/0.54.0)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: kernel: fix cross compilation
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/33813
updated_at: 2018-02-12 09:39:24
body:
  This PR contains rebased versions of patches from #30882 to fix Linux kernel cross compilation.

  Specifically, this includes:
  5c6473c5ff4879711d28243f4be299380ead10fb - kernel: Enable cross compiling
  d1ccc5d0b48321498a57bfb372fb782701446ad7 - kernel: Use build kmod
  5e917600fc61f996c297aeeeb8a231b75460dfd4 - kernel fixes
  e915e4a7d0cd798070b969517310acaaf378bd39 - kernel: Fix cross-compilation

  5e917600fc61f996c297aeeeb8a231b75460dfd4 has been squashed into 5c6473c5ff4879711d28243f4be299380ead10fb because the changes are closely related.

  There are a few things that I'm not sure about, or didn't seem right to me.

  In 5c6473c5ff4879711d28243f4be299380ead10fb, `pkgs/os-specific/linux/kernel/perf.nix` refers to a [patch that no longer exists in master](https://github.com/NixOS/nixpkgs/pull/30882/commits/5c6473c5ff4879711d28243f4be299380ead10fb#diff-ec4e01e2f58d1c9120aad93a3dde92e4R16) and did not exist in the tree that #30882 is based on. It also seems to revert the [fix that was used to replace the patch](https://github.com/NixOS/nixpkgs/pull/30882/commits/5c6473c5ff4879711d28243f4be299380ead10fb#diff-ec4e01e2f58d1c9120aad93a3dde92e4L45). This seems like it could be due to a bad rebase at some point, but I wanted to make sure there wasn't another reason.

  I put a few other concerns as comments on the diff.

  I have tested cross building 4.14 kernels for `armv7l` and `aarch64`, as well as a native `x86_64` kernel.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Vapoursynth machinery
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33814
updated_at: 2018-01-22 19:05:51
body:
  ###### Motivation for this change
  Besides the version bump this fixes an issue that appeared recently (I couldn't find exactly what caused it): for some reason now `toPythonPath` returns the path for the wrong python version (2.7 instead of 3.6).

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change
  - [x] Tested execution of all binary files
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @FRidh 


state: closed
title: Haddock API (as dep of GHCJS) fails to build on unstable channel
user_login: bradparker
html_url: https://github.com/NixOS/nixpkgs/issues/33815
updated_at: 2018-01-30 05:49:48
body:
  ## Issue description

  Haddock API, (as dep of GHCJS) fails to build on unstable channel with linker error. Can't find `tinfo`.

  Succeeds on the `nixos-17.09` channel.

  Relevant log lines:

  ```
  Preprocessing test suite 'spec' for haddock-api-2.18.1..
  Building test suite 'spec' for haddock-api-2.18.1..
  Linking dist/build/spec/spec ...
  /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/ld.gold: error: cannot find -ltinfo
  collect2: error: ld returned 1 exit status
  `gcc' failed in phase `Linker'. (Exit code: 1)
  builder for ‘/nix/store/ki40120vd11bxbz192ya5340yymiqff3-haddock-api-2.18.1.drv’ failed with exit code 1
  ```

  ### Steps to reproduce

  ```
  $ nix-channel --add nixpkgs https://nixos.org/channels/nixos-unstable
  $ nix-channel --update
  $ nix-shell -p "haskell.packages.ghcjs.ghc"
  ```

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.13.0-1-amd64, PureOS GNU/Linux, noversion`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
  # This channel is the now working version, was "unstable" previously
   - channels(brad): `"nixpkgs-17.09.2683.360089b3521"`
   - nixpkgs: `/home/brad/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: btfs: 2.17 -> 2.18
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33816
updated_at: 2018-01-22 19:05:49
body:
  ###### Motivation for this change
  Version bump

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change (none)
  - [x] Tested execution of all binary files
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ddcutil: 0.8.4 -> 0.8.5
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33817
updated_at: 2018-01-22 19:05:35
body:
  ###### Motivation for this change
  Version bump

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using (none)
  - [x] Tested execution of all binary files
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rewritefs: remove needless quotation
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33818
updated_at: 2018-01-22 19:05:34
body:
  ###### Motivation for this change
  From https://github.com/NixOS/nixpkgs/pull/27809 this should be removed


state: closed
title: bdf2psf 1.170 -> 1.175
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33819
updated_at: 2018-01-22 19:05:33
body:
  ###### Motivation for this change
  Version bump

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using (gohufont)
  - [x] Tested execution of all binary files
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: idris: Error building package - "addEnvHooks: command not found"
user_login: rbasso
html_url: https://github.com/NixOS/nixpkgs/issues/33820
updated_at: 2018-07-13 00:50:18
body:
  ## Issue description

  Cannot build `idris` anymore.

  ### Steps to reproduce

  ```
  > nix-env -f "<nixpkgs>" -iA idris
  replacing old ‘idris-1.1.1’
  installing ‘idris-1.2.0’
  these derivations will be built:
    /nix/store/zn9kyyw32k09b70czrx4dwgy88hhhnb8-prelude-1.2.0.drv
    /nix/store/rb3v57ygmsiilgqq45ibzjpcvpy9bc26-base-1.2.0.drv
    /nix/store/x9jky7dw51g3wdgmk9hllma2dksjfv8z-idris-1.2.0.drv
  building path(s) ‘/nix/store/l6swfs3dmb4h6sgv0rfhiglxilp0bhbk-prelude-1.2.0’
  /nix/store/x4085dqn2v1psvkiww5wn69wnvxd7niq-stdenv/setup: line 114: addEnvHooks: command not found
  builder for ‘/nix/store/zn9kyyw32k09b70czrx4dwgy88hhhnb8-prelude-1.2.0.drv’ failed with exit code 127
  cannot build derivation ‘/nix/store/rb3v57ygmsiilgqq45ibzjpcvpy9bc26-base-1.2.0.drv’: 1 dependencies couldn't be built
  cannot build derivation ‘/nix/store/x9jky7dw51g3wdgmk9hllma2dksjfv8z-idris-1.2.0.drv’: 1 dependencies couldn't be built
  error: build of ‘/nix/store/x9jky7dw51g3wdgmk9hllma2dksjfv8z-idris-1.2.0.drv’ failed
  ```

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.13, NixOS, 18.03.git.d982c61 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `""`
   - channels(user): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```


state: closed
title: services.mysql: properly quote database.name
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/33821
updated_at: 2018-02-08 22:58:26
body:
  ###### Motivation for this change

  Address the quoting issues discussed on #5227.


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review 33821"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libzxcvbn: init at 2.3
user_login: xurei
html_url: https://github.com/NixOS/nixpkgs/pull/33822
updated_at: 2018-01-13 10:47:27
body:
  ###### Motivation for this change

  Dependency for KeepassXC

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cutegram: Build with qt59
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33823
updated_at: 2018-05-14 10:33:09
body:
  ###### Motivation for this change
  See https://github.com/NixOS/nixpkgs/issues/33798

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  Builds and starts fine

  cc @Profpatsch @AndersonTorres 


state: closed
title: physfs: 2.0.3 -> 3.0.1
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/33824
updated_at: 2018-01-19 00:34:23
body:
  ###### Motivation for this change

  New physfs breaks the API so keep v2 around as well.

  Cc: @7c6f434c @viric 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Nikola: included media directive needs micawber (Python Module)
user_login: davidak
html_url: https://github.com/NixOS/nixpkgs/issues/33825
updated_at: 2018-02-15 00:05:01
body:
  ## Issue description

  While building a static website and also in the final result appears this warning:

  `In order to use the media directive, you must install the "micawber" Python package.`

  Example: https://davidak.de/blog/175-davideo-design/

  cc @jluttine

  ### Steps to reproduce

  ```
  nix-shell -p python36Packages.Nikola
  nikola build
  ```

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.11, NixOS, 17.09.2610.d83c8080d1e (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(davidak): `""`
   - channels(root): `"nixos-17.09.2631.0653b73bf61"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: Vulnerabilty Roundup 32
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/33826
updated_at: 2018-10-08 14:58:49
body:
  Scanned nixos/release-combined.nix @ d982c61. May contain false positives.

  ### ffmpeg-3.4.1 ([search](https://search.nix.gsc.io/?q=ffmpeg&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=ffmpeg+in%3Apath&type=Code))
   - [x] [CVE-2017-17555](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-17555) (actually bug in `aubio`, no patch)

  ### gstreamer-0.10.36 ([search](https://search.nix.gsc.io/?q=gstreamer&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gstreamer+in%3Apath&type=Code))
   - [x] [CVE-2016-9447](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2016-9447)

  ### imagemagick-6.9.9-28 ([search](https://search.nix.gsc.io/?q=imagemagick&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=imagemagick+in%3Apath&type=Code))
   - [x] [CVE-2017-17504](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-17504) 

  ### libarchive-3.3.2 ([search](https://search.nix.gsc.io/?q=libarchive&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libarchive+in%3Apath&type=Code))
   - [ ] [CVE-2017-14501](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-14501)
   - [ ] [CVE-2017-14503](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-14503)

  ### libcroco-0.6.12 ([search](https://search.nix.gsc.io/?q=libcroco&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libcroco+in%3Apath&type=Code))
   - [ ] [CVE-2017-8834](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-8834) ([no patch](https://bugzilla.gnome.org/show_bug.cgi?id=782647))
   - [ ] [CVE-2017-8871](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-8871) ([no patch](https://bugzilla.gnome.org/show_bug.cgi?id=782649))

  ### libid3tag-0.15.1b ([search](https://search.nix.gsc.io/?q=libid3tag&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libid3tag+in%3Apath&type=Code))
   - [x] [CVE-2017-11550](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11550) (https://github.com/NixOS/nixpkgs/issues/32117#issuecomment-347291374)
   - [x] [CVE-2017-11551](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11551) (also addressed by debian patches)

  ### libsndfile-1.0.28 ([search](https://search.nix.gsc.io/?q=libsndfile&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libsndfile+in%3Apath&type=Code))
   - [ ] [CVE-2017-14245](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-14245)
   - [ ] [CVE-2017-14246](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-14246)

  ### libtiff-4.0.8 ([search](https://search.nix.gsc.io/?q=libtiff&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libtiff+in%3Apath&type=Code))
   - [ ] [CVE-2017-10688](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-10688)
   - [ ] [CVE-2017-11335](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11335)
   - [ ] [CVE-2017-11613](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11613)
   - [ ] [CVE-2017-12944](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-12944)
   - [ ] [CVE-2017-13726](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13726)
   - [ ] [CVE-2017-13727](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13727)
   - [ ] [CVE-2017-17973](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-17973)
   - [ ] [CVE-2017-9935](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-9935)
   - [ ] [CVE-2017-9936](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-9936)
   - [ ] [CVE-2017-9937](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-9937)

  ### libvorbis-1.3.5 ([search](https://search.nix.gsc.io/?q=libvorbis&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libvorbis+in%3Apath&type=Code))
   - [ ] [CVE-2017-11333](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11333) (https://gitlab.xiph.org/xiph/vorbis/issues/2332)

  ### openldap-2.4.45 ([search](https://search.nix.gsc.io/?q=openldap&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=openldap+in%3Apath&type=Code))
   - [x] [CVE-2017-14159](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-14159)
   - [ ] [CVE-2017-17740](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-17740)

  ### pcre-8.41 ([search](https://search.nix.gsc.io/?q=pcre&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=pcre+in%3Apath&type=Code))
   - [x] [CVE-2017-11164](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-11164)

  ### rsync-3.1.2 ([search](https://search.nix.gsc.io/?q=rsync&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=rsync+in%3Apath&type=Code))
   - [x] [CVE-2017-15994](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-15994)
   - [x] [CVE-2017-16548](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-16548)

  ### systemd-234 ([search](https://search.nix.gsc.io/?q=systemd&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=systemd+in%3Apath&type=Code))
   - [x] [CVE-2017-15908](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-15908)

  ### wpa_supplicant-2.6 ([search](https://search.nix.gsc.io/?q=wpa_supplicant&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=wpa_supplicant+in%3Apath&type=Code))
   - [x] [CVE-2017-13077](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13077)
   - [x] [CVE-2017-13078](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13078)
   - [x] [CVE-2017-13079](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13079)
   - [x] [CVE-2017-13080](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13080)
   - [x] [CVE-2017-13081](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13081)
   - [x] [CVE-2017-13082](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13082)
   - [x] [CVE-2017-13084](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13084)
   - [x] [CVE-2017-13086](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13086)
   - [x] [CVE-2017-13087](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13087)
   - [x] [CVE-2017-13088](https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2017-13088)

  Cc:  @NixOS/security-notifications, @joepie91, @phanimahesh, @the-kenny, @7c6f434c, @k0001, @peterhoeg, @nh2, @LnL7

  Contact @ckauhaus for any questions.


state: closed
title: nextcloud-client: fix icon name in desktop file
user_login: eqyiel
html_url: https://github.com/NixOS/nixpkgs/pull/33827
updated_at: 2018-02-18 23:13:59
body:
  ###### Motivation for this change

  The desktop file bundled with nextcloud calls the icon `nextcloud`, but the
  icons are named `Nextcloud` and so desktop environments won't find it.

  Note that upstream uses the opposite workaround in their appimage creation script (renaming an icon file to match what the desktop file expects): https://github.com/nextcloud/client_theming/blob/d0a46ea2f04eb9fe1b99d4cedfb595bc7664d27f/linux/AppImage/build-appimage.sh#L61

  I'm using the capture group to find matching lines because the translations generate lines like `Icon[ja_JP]=nextcloud` and those need to be changed too.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Ruby: 2.2.8 -> 2.2.9, 2.3.5 -> 2.3.6, 2.4.2 -> 2.4.3
user_login: manveru
html_url: https://github.com/NixOS/nixpkgs/pull/33828
updated_at: 2018-01-13 11:15:54
body:
  (cherry picked from commit e90412debb744dfc481cebf4243e48aef512c726)

  ###### Motivation for this change

  Fixes two security issues:

  * http://blog.rubygems.org/2017/10/09/unsafe-object-deserialization-vulnerability.html
  * https://www.ruby-lang.org/en/news/2017/12/14/net-ftp-command-injection-cve-2017-17405/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: palemoon: install icons
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33829
updated_at: 2018-01-22 19:05:30
body:
  ###### Motivation for this change
  Fix #33770 

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using (none)
  - [x] Tested execution of all binary files
  - [x] Tested the icons are picked up by the DE (xfce at least)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ldc: Disable cdvecfill test to fix build on older processors
user_login: ThomasMader
html_url: https://github.com/NixOS/nixpkgs/pull/33830
updated_at: 2018-01-13 15:31:42
body:
  ###### Motivation for this change

  Continuation of https://github.com/NixOS/nixpkgs/pull/33723 to fix build of ldc on hydra/Linux and other machines with older processors.

  cc @joachifm 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: imagemagick: updates for 6, 7
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33831
updated_at: 2018-01-13 19:56:06
body:
  ###### Motivation for this change

  Security fixes, unfortunately don't seem to be listed anywhere neatly.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc #33826 


state: closed
title: timewarrior: 1.0.0 -> 1.1.0
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/33832
updated_at: 2018-01-13 17:20:29
body:
  The patch does not apply anymore and I'm not sure whether we still need it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnuplot broken by bf132e6 (syntax error) for earlier nix versions
user_login: twhitehead
html_url: https://github.com/NixOS/nixpkgs/issues/33833
updated_at: 2018-01-14 22:11:21
body:
  ## Issue description

  Older versions of `nix-build` (e.g., 1.11.7, but not 1.12pre5788_e3013543) choke on the way `${` was escaped in commit bf132e64

  > error: syntax error, unexpected $undefined, expecting IND_STR or DOLLAR_CURLY or IND_STRING_CLOSE, at /home/tyson/nixpkgs/pkgs/tools/graphics/gnuplot/default.nix:42:44

  ### Steps to reproduce

  With an older nix (e.g., 1.11.7) run the following

  ```
  git clone git@github.com:NixOS/nixpkgs.git
  cd nixpkgs
  nix-build -A gnuplot
  ```

  ## Technical details

  @orivej Looks like `'$'{`causes earlier nix versions to explode.


state: closed
title: bitscope: refactored to expose to nixpkgs-lint
user_login: vidbina
html_url: https://github.com/NixOS/nixpkgs/pull/33834
updated_at: 2018-01-15 07:22:16
body:
  ###### Motivation for this change

  The linter (nixpkgs-lint) was not able to find the bitscope packages
  because I forgot to `recurseIntoAttrs` the bitscope suite set. Furthermore, I inherit the
  `meta` and `name` attributes from the package builder helper. This fixes
  a naming problem since the name of the derivation was formerly set to
  the `attrs.toolName` which didn't postfix the version, whereas nix
  packages are required to adhere to the `${PACKAGENAME}-${VERSION}`
  pattern. 

  In order to keep the produced FHSEnv binary's name short and sweet and produced it with a versionless name and subsequently merged the versioned-name into the resulting derivation.

  Not sure if I'm doing some weird :hankey:... if so, please yell at me so I can fix that and developed a good mental association from preventing me from doing the same in the future :wink:.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: WIP: gpsbabel: Fix build with qt59
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33836
updated_at: 2018-06-03 15:29:58
body:
  ###### Motivation for this change
  Fixes build with Qt 5.9, some tests fail.
  @rycee Could you take a look?

  See [Qt  5.6 deprecation issue](https://github.com/NixOS/nixpkgs/issues/33798)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: guile: 2.2.0 -> 2.2.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33837
updated_at: 2018-01-21 21:55:07
body:
  2.2.3: https://lists.gnu.org/archive/html/guile-devel/2017-12/msg00000.html
  2.2.2: https://lists.gnu.org/archive/html/guile-devel/2017-04/msg00035.html
  2.2.1: https://lists.gnu.org/archive/html/guile-devel/2017-04/msg00034.html

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Idris: fix "addEnvHooks: command not found" (#33820)
user_login: xrvdg
html_url: https://github.com/NixOS/nixpkgs/pull/33838
updated_at: 2018-02-02 11:31:38
body:
  ###### Motivation for this change

  On the current head 'addEnvHooks' doesn't seem to be available in 'preHook'.
  This patch tries to stay as close as the original by moving the code to
  'setupHook' and changing the ln options.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  -  [ ? ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
     - Packages that depend on this are already broken, but that is something for a different issue.
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gephi: 0.9.1 -> 0.9.2
user_login: mimadrid
html_url: https://github.com/NixOS/nixpkgs/pull/33839
updated_at: 2018-01-14 17:10:53
body:
  ###### Motivation for this change

  Update gephi to the last version
  https://github.com/gephi/gephi/wiki/Releases#gephi-092-sep-24-2017

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cytoscape: 3.5.1 -> 3.6.0
user_login: mimadrid
html_url: https://github.com/NixOS/nixpkgs/pull/33840
updated_at: 2018-01-14 17:09:34
body:
  ###### Motivation for this change

  Update cytoscape to the last version
  http://www.cytoscape.org/release_notes_3_6_0.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: skypeforlinux: 8.11.0.4 -> 8.13.0.2
user_login: jonafato
html_url: https://github.com/NixOS/nixpkgs/pull/33841
updated_at: 2018-01-14 17:20:31
body:
  ###### Motivation for this change

  New skypeforlinux release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: resilio-sync: fixed typo knownHosts -> entry.knownHosts
user_login: mimadrid
html_url: https://github.com/NixOS/nixpkgs/pull/33842
updated_at: 2018-01-21 11:30:44
body:
  ###### Motivation for this change

  Fixed #27473

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: myEnvFun incorrectly munges setup.sh
user_login: jwiegley
html_url: https://github.com/NixOS/nixpkgs/issues/33843
updated_at: 2018-01-29 08:01:35
body:
  At https://github.com/nixos/nixpkgs-channels/blob/nixpkgs-unstable/pkgs/misc/my-env/default.nix#L82 we see the following `sed` statement:

  ```
      sed -e 's@set -e@@' \
          -e 's@assertEnvExists\s\+NIX_STORE@:@' \
          -e 's@trap.*@@' \
          -e '1i initialPath="${toString initialPath}"' \
          "$setupNew" > "$s"
  ```

  However, the `setup.sh` source file doesn't begin with `set -e`, but `set -eu`, resulting in a final output that looks like this:

  ```
  initialPath="... lots of stuff ..."
  u
  set -o pipefail
  ```

  I only noticed this when I created a local shell script named `u`, which was then getting invoked with every environment load.


state: closed
title: libxml2: 2.9.5 -> 2.9.7 (fixes CVE-2017-15412)
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33844
updated_at: 2018-01-14 00:28:28
body:
  ###### Motivation for this change

  libxml2: 2.9.5 -> 2.9.7 (fixes CVE-2017-15412)

  For details see [1].

  [1] https://git.gnome.org/browse/libxml2/commit/?id=0f3b843b3534784ef57a4f9b874238aa1fda5a73

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libxml2: 2.9.5 -> 2.9.7 (fixes CVE-2017-15412)
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33845
updated_at: 2018-01-14 08:31:49
body:
  For details see [1].

  [1] https://git.gnome.org/browse/libxml2/commit/?id=0f3b843b3534784ef57a4f9b874238aa1fda5a73

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 2048-in-terminal: 2015-01-15 -> 2017-11-29
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33846
updated_at: 2018-01-17 12:25:28
body:
  Only functionality change AFAICT is
  https://github.com/alewmoose/2048-in-terminal/commit/e7595caa2d07bf9122f15258259d69cf3fb32edd
  which resets the board on exit at game over.

  ###### Motivation for this change

  Mention on nix-devel and ended up checking for newer version than 2015.  Answer is "kinda".

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Can't get rid of `eurosign`
user_login: dpc
html_url: https://github.com/NixOS/nixpkgs/issues/33847
updated_at: 2018-01-18 06:00:14
body:
  ## Issue description

  I've installed NixOs, and no matter what I do, I always get `eurosign:e` in my `setxkbmap` options which breaks polish letter `ę` on the polish keyboard layout. I really enjoy that letter, and I'm missing it a lot, while euro symbol is useless to me, and if you ask me it was a bad idea to create euro currency in the first place.

  ```
  dpc@spinlock ~> setxkbmap -query 
  rules:      evdev
  model:      pc104
  layout:     pl,us
  variant:    ,
  options:    eurosign:e
  ```

  I can do `setxkbmap -option ''` which is the only way to get rid of that option at runtime, it seems. But it will come back after logout/reboot.

  I've tried

  ```
    services.xserver.enable = true;
    services.xserver.layout = "pl";
    services.xserver.xkbOptions = "";
  ```

  and it doesn't seem to do anything.

  Adding more options, just adds them to `eurosign:e`.

  I also tried:

  ```
    # https://github.com/NixOS/nixpkgs/issues/14318#issuecomment-332214410
    services.xserver.desktopManager.gnome3.extraGSettingsOverrides = ''
      [org.gnome.desktop.input-sources]
      sources=[('xkb', 'cz+qwerty')]
      xkb-options=['']
    '';
  ```

  but it doesn't help. `xkb-options=['']` generates compile time error, which I don't understand (but I'm a Nix noob, so there's that).

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 18.03pre125026.f607771d0f5 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(dpc): `""`
   - channels(root): `"nixos-18.03pre125026.f607771d0f5"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ```


state: open
title: [RFC][Fun] Prototype Nix 1.12 fetchFromGitHubWithUpdater
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/33848
updated_at: 2018-01-14 12:34:48
body:
  ## Description

  We needed another of these, right?

  I was exploring using the `update.nix` approach for helping automate checking for github releases,
  and here's what I came up with.  It can certainly be improved but I like it so thought I'd share :).

  So there are a number of quirks:
  * Requires 1.12
  * (Ab)uses 1.12 goodness to pull github release information into a nix expression,
  filters and sorts it, and outputs the latest release.
  * Uses unauthenticated github API so can trigger rate-limiting per-IP if used too much
  * The "update script" generated is a constant, but will be changed once the cached github response expires (or you run with `--option tarball-ttl 0`)
  * The implementation needs to go somewhere else, but wasn't clear where it belonged so it's in an obviously bad place for now :).

  It seems to work surprisingly well considering I'm mostly just pointing Nix at GitHub's API :grin:.

  cc https://github.com/NixOS/nixpkgs/pull/21734

  ## Let me see!

  * [Here's the implementation](https://github.com/dtzWill/nixpkgs/blob/41f3db8a19daf97be60300663c15a9ef6b1a0eb8/pkgs/applications/audio/radiotray-ng/update.nix)
  *  [branch using it for a few of my projects](https://github.com/dtzWill/nixpkgs/tree/experimental/updater).


  ### V2

  Updates when script is executed, still mostly nix

  * [Implementation glue](https://github.com/dtzWill/nixpkgs/blob/3f1853c0d9a1033fd69631ffbd38ffff5b946358/pkgs/applications/audio/radiotray-ng/update.nix)
  * [Actual update checking](https://github.com/dtzWill/nixpkgs/blob/3f1853c0d9a1033fd69631ffbd38ffff5b946358/pkgs/applications/audio/radiotray-ng/update-check.nix)


state: closed
title: rtl-sdr: 0.5.3 -> 0.5.3-git
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/33849
updated_at: 2018-08-16 19:07:54
body:
  ###### Motivation for this change
  Version 0.5.3 is already 4 years old. The latest git version contains bug fixes and feature enhancements like, e.g. bias-T control.  

  ###### Things done
  Tested with a RTL-SDR receiver dongle.
   
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnuradio-osmosdr: 0.1.4->0.1.5-git
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/33850
updated_at: 2019-01-28 15:32:04
body:
  ###### Motivation for this change
  The latest release is from 0.1.4 is from Nov. 2014. This version supports soapysdr as a backend (PR in preparation). Note that this PR needs an updated rtl-sdr version (see PR https://github.com/NixOS/nixpkgs/pull/33849)

  ###### Things done
   Tested with RTL-SDR and airspy devices.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: why3: 0.88.1 -> 0.88.3
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/33851
updated_at: 2018-02-09 11:14:28
body:
  ###### Motivation for this change

  Announce of 0.88.2: https://lists.gforge.inria.fr/pipermail/why3-club/2017-December/001617.html
  Announce of 0.88.3: https://lists.gforge.inria.fr/pipermail/why3-club/2018-January/001622.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Python3-3.6.4 could not download from any binary cache
user_login: bryaan
html_url: https://github.com/NixOS/nixpkgs/issues/33852
updated_at: 2019-02-17 06:49:50
body:
  ## Issue description

  Version 17 and 18 tested and affected.  Initial system build/install, build with Gnome enabled.

  https://cache.nixos.org/0cwxmyjyh1cr3xss6dqsrpmhcmwk89p4zkr59jpds1171z52k8p8.nar.xz
  failed downloading from any binary cache.

  Install fails.  :(
  ![screen shot 2018-01-14 at 3 18 15 am](https://user-images.githubusercontent.com/2250179/34914202-ae08d236-f8db-11e7-8de5-d34c4fc18859.png)


  Is there any way to specify nixos to build from source when it can't download from binary caches?


state: closed
title: teleport: init at v2.4.0
user_login: tomberek
html_url: https://github.com/NixOS/nixpkgs/pull/33853
updated_at: 2018-02-02 12:47:16
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virtmanager: Namespace LibvirtGLib not available
user_login: lschuermann
html_url: https://github.com/NixOS/nixpkgs/issues/33854
updated_at: 2018-01-14 12:23:22
body:
  ## Issue description
  I just did a fresh installation of NixOS and I am on the unstable channel. When starting `virt-manager` I'm getting the following error message:
  ```
  [nix-shell:~]$ virt-manager 
  Traceback (most recent call last):
    File "/nix/store/f0qsv1lmwdfzlbahsscqnqdilriz5xlg-virt-manager-1.4.3/share/virt-manager/virt-manager", line 32, in <module>
      gi.require_version('LibvirtGLib', '1.0')
    File "/nix/store/p6fnhmmvr28ziv19c37hr9n6vkcy25an-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/__init__.py", line 130, in require_version
      raise ValueError('Namespace %s not available' % namespace)
  ValueError: Namespace LibvirtGLib not available
  ```

  This happens when installed as a system-package, in the user environment and in the nix shell.

  The package works as expected in a `nix-shell` based on the 17.09 release:
  `nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs-channels/archive/nixos-17.09.tar.gz -p virtmanager`

  ### Steps to reproduce
  Install `pkgs.virtmanager` on a NixOS system with the `unstable` channel selected.


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 18.03pre125026.f607771d0f5 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.12pre5810_5d5b931f`
   - channels(root): `"nixos"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: pythonPackages.user-agents: init at 1.1.0
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33855
updated_at: 2018-02-08 11:00:57
body:
  ###### Motivation for this change
  Necessary for #33675.

  It would be nice if someone could trigger a build on Darwin since I have no way to test.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @FRidh 


state: closed
title: pythonPackages.versioneer: init at 0.18
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/33856
updated_at: 2018-01-14 14:11:03
body:
  ###### Motivation for this change

  Add versioneer Python package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kde-frameworks: 5.41 -> 5.42
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33857
updated_at: 2018-01-15 09:10:13
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @ttuegel @bkchr @peterhoeg 


state: closed
title: spectre-meltdown-checker: init at 0.29
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33858
updated_at: 2018-01-14 15:38:46
body:
  ###### Motivation for this change
  ~Can someone please help me adding `readelf` to the path?~
  I didn't have any success using
  ```
  makeWrapper $out/lib/spectre-meltdown-checker.sh $out/bin/spectre-meltdown-checker \
    --prefix PATH : ${makeBinPath [ binutils ]}
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.netdisco: init at 1.2.3
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33859
updated_at: 2018-01-14 16:15:30
body:
  ###### Motivation for this change
  Necessary for #33675.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @FRidh 


state: closed
title: release-17.09: ELK: 5.6.1 -> 5.6.5 & add ELK 6.1.0
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33860
updated_at: 2018-01-17 00:29:51
body:
  ###### Motivation for this change

  This is a cherry-pick of https://github.com/NixOS/nixpkgs/pull/32822 on `release-17.09` which upgrades ELK-5 and adds ELK-6.

  The test suite is extended to test both ELK-5 and ELK-6.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Ping @srhb.


state: closed
title: woof: init at 2012-05-31
user_login: lschuermann
html_url: https://github.com/NixOS/nixpkgs/pull/33861
updated_at: 2018-10-14 09:18:11
body:
  ###### Motivation for this change
  `woof` (Web Offer One File) is a small and simple command line utility written in Python that makes file sharing in a local network easy.
  The most basic usecase is to just start it with a file as an argument, which it then serves via an HTTP web-server. Additionally, it is able to compress and serve a folder, provide an upload form, or even offer itself using command line switches.

  This is a very useful utility I would not like to miss on any portable computers.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Note that when `woof` is used with the `-s` option (serving itself), because of how the package gets built, it offers the Python file with the path to the Python interpreter hardcoded inside the Nix-store. I'd accept that as a compromise, as I think that fixing this would either require changing the `woof` source itself or the way Nix packages get built. Also, people wanting to get `woof` should use the awesome Nix package-manager anyway. ;)

  Is it possible for me to become a maintainer for this package? If so, what steps should I follow? I sadly can't remember all of the awesomeness that was shown to me by the NixOS assembly at 34C3.


state: closed
title: python3Packages.pyhomematic: init at 0.1.38
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33862
updated_at: 2018-02-08 11:00:33
body:
  ###### Motivation for this change
  Useful for #33675.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: teamspeak_client: Re-link with qt 5.9
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33863
updated_at: 2018-03-11 10:41:14
body:
  ###### Motivation for this change
  See https://github.com/NixOS/nixpkgs/issues/33798

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested starting the application and clicking around the UI a bit and it seems to work fine.

  cc @bkchr @DeltaEvo @nathanielbaxter 


state: closed
title: mendeley: Re-link with qt 5.9
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/33864
updated_at: 2018-01-15 01:30:53
body:
  ###### Motivation for this change
  See https://github.com/NixOS/nixpkgs/issues/33798

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  As the application requires registration I have only tried to start it and it works.

  cc @dtzWill 


state: closed
title: uget: 2.0.10 -> 2.2.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/33865
updated_at: 2018-01-14 23:46:07
body:
  ###### Motivation for this change

  Update to version [2.2.0](http://ugetdm.com/blog/3-stable/86-uget-220-and-uget-for-android-148-now-available)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: nixos: sg/newgrp should always be available, not chfn
user_login: yesbox
html_url: https://github.com/NixOS/nixpkgs/pull/33866
updated_at: 2018-02-05 18:38:22
body:
  ###### Motivation for this change

  sg and newgrp only changes the current user session and should be
  available to users even if the "users.mutableUsers" option is set.
  These are common, useful commands.

  chfn does modify the /etc/passwd GECOS field which is also controlled
  by the option "users.users.<name?>.description", so it's less
  appropriate to make it available when "users.mutableUsers" is set.

  However, because CHFN_RESTRICT in login.defs is never set in current
  NixOS the chfn functionality is never available to users anyway and
  may as well have its SUID disabled, as only root is able to use it.
  This is recommended in the chfn man page in this case.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mendeley: add update script, use it, add myself as maintainer
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33867
updated_at: 2018-01-15 01:49:53
body:
  New version, it complains about (err "helpfully notifies the user").



  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: snowman: deprecate qt4 variant
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33868
updated_at: 2018-01-15 01:37:58
body:
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: spectre-meltdown-checker: 0.29 -> 0.31
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33869
updated_at: 2018-01-14 22:22:32
body:
  ###### Motivation for this change
  The patch to find NixOS kernel is now merged upstream.

  Since the author explicitly specified `/bin/echo`, I did him a favour and use coreutils' `echo` as well :smile: 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wireshark: 2.4.3 -> 2.4.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33870
updated_at: 2018-01-15 02:14:46
body:
  https://www.wireshark.org/docs/relnotes/wireshark-2.4.4.html

  Multiple CVE's fixed, apparently.



  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  https://www.wireshark.org/docs/relnotes/wireshark-2.4.4.html


state: closed
title: llvm-5: add extra 'python' output for opt-viewer tool
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33871
updated_at: 2018-02-06 22:33:47
body:
  https://github.com/NixOS/nixpkgs/pull/33374#pullrequestreview-87685214

  We don't really support the opt-viewer tool anyway,
  but keep it around in case someone wants to play with it.

  Don't pull python into the closure just for that reason, though.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yajl: small clean up
user_login: pbogdan
html_url: https://github.com/NixOS/nixpkgs/pull/33872
updated_at: 2018-01-19 11:51:52
body:
  - ruby dependency is no longer needed
  - cmake belongs in nativeBuildInputs

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: transmission: fix RCE via dns rebinding attach
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33873
updated_at: 2018-01-14 23:54:04
body:
  ###### Motivation for this change
  For further details see [1] & [2].

  [1] https://github.com/transmission/transmission/pull/468
  [2] http://www.openwall.com/lists/oss-security/2018/01/12/1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: transmission: fix RCE via dns rebinding attach
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33874
updated_at: 2018-01-15 00:48:44
body:
  ###### Motivation for this change
  For further details see [1] & [2].

  [1] https://github.com/transmission/transmission/pull/468
  [2] http://www.openwall.com/lists/oss-security/2018/01/12/1

  (cherry picked from commit 50f48fce0957211b2c703dd91e444f05e3203546)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: shibboleth-se/opensaml: open security issues
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/issues/33875
updated_at: 2018-04-04 20:53:26
body:
  ## Issue description

  There are at least two open security issues (CVE-2017-16852,CVE-2017-16853) which affect shibboleth-se and opensaml.

  The details can be obtained from the upstream annoucement:
  https://shibboleth.net/community/advisories/secadv_20171115.txt

  There are new releases & patches available that fix those open issues.

  Either updating or marking those packages as broken/insecure seems sensible to me.

  CC current maintainers:  @jammerful 


state: closed
title: apache solr: CVE-2017-12629 & CVE-2017-3163
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/issues/33876
updated_at: 2019-03-31 01:42:50
body:
  ## Issue description

  There are at least two potential long-term security issues with the `solr` version in 17.09 (and potentially unstable):

  - CVE-2017-3163:
    When using the Index Replication feature, Apache Solr nodes can pull index files from a master/leader node using an HTTP API which accepts a file name. However, Solr before 5.5.4 and 6.x before 6.4.1 did not validate the file name, hence it was possible to craft a special request involving path traversal, leaving any file readable to the Solr server process exposed. Solr servers protected and restricted by firewall rules and/or authentication would not be at risk since only trusted clients and users would gain direct HTTP access.

  - CVE-2017-12629
    Remote code execution occurs in Apache Solr before 7.1 with Apache Lucene before 7.1 by exploiting XXE in conjunction with use of a Config API add-listener command to reach the RunExecutableListener class. Elasticsearch, although it uses Lucene, is NOT vulnerable to this. Note that the XML external entity expansion vulnerability occurs in the XML Query Parser which is available, by default, for any query request with parameters deftype=xmlparser and can be exploited to upload malicious data to the /upload request handler or as Blind XXE using ftp wrapper in order to read arbitrary local files from the Solr server. Note also that the second vulnerability relates to remote code execution using the RunExecutableListener available on all affected versions of Solr.

  CC maintainers of solr: @rickynils @domenkozar

  From what I can see with a simple search through nixpkgs the following packages are also potentially affected by this (since they ship their own copy of solr):

  - riak 2.2.0 (CC @cstrahan @mdaiter)


state: closed
title: wildmidi: Outdated & open issues (CVE-2017-11661, CVE-2017-11662, CVE-2017-11663, CVE-2017-11664)
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/issues/33877
updated_at: 2018-02-08 11:17:44
body:
  ## Issue description

  `wildmidi` has not been updated in a while and has a few open potential security issues:

  - CVE-2017-11661
    The _WM_SetupMidiEvent function in internal_midi.c:2318 in WildMIDI 0.4.2 can cause a denial of service (invalid memory read and application crash) via a crafted mid file.
  - CVE-2017-11662
    The _WM_ParseNewMidi function in f_midi.c in WildMIDI 0.4.2 can cause a denial of service (invalid memory read and application crash) via a crafted mid file.
  - CVE-2017-11663
    The _WM_SetupMidiEvent function in internal_midi.c:2315 in WildMIDI 0.4.2 can cause a denial of service (invalid memory read and application crash) via a crafted mid file.
  - CVE-2017-11664
    The _WM_SetupMidiEvent function in internal_midi.c:2122 in WildMIDI 0.4.2 can cause a denial of service (invalid memory read and application crash) via a crafted mid file.

  The changelogs (https://github.com/Mindwerks/wildmidi/releases) also provide more fixes:

  ```
  What's new in 0.4.2:

      Fixed CVE-2017-11661, CVE-2017-11662, CVE-2017-11663, CVE-2017-11664
      (Bug #175).
      Fixed WildMidi_Open() might read beyond buffer with too short inputs
      (Bug #178).
      Fixed a buffer overflow during playback with malformed midi files
      (Bug #180).
      GUS patch processing changes to meet users expectations (Bug #132).
      Worked around a build failure with newer FreeBSD versions failing to
      retrieve the ONLCR constant (Bug #171).
      Fixed a minor Windows unicode issue (PR #170).
      A few other fixes / clean-ups.

  What's new in 0.4.1:

      Fixed bug in handling of the "source" directive in config files.
      Fixed a nasty bug in dBm_pan_volume. Other fixes and clean-ups.
      Build system updates. Install a pkg-config file on supported platforms such as Linux. New android ndk makefile.
      File i/o updates.
      Support for OS/2.
      Support for Nintendo 3DS
      Support for Nintendo Wii
      Support for AmigaOS and its variants like MorphOS and AROS.

  What's new in 0.4.0:

  This is a major milestone release!

  We worked hard over the years to improve WildMIDI by looking at how it is used downstream and working with them to offload their MIDI-related burdens and pushing them to WildMIDI. We've included support for the following MIDI-like formats: HMI, HMP, KAR, MIDI Type 2, MUS and XMI. We've expanded our API to help facilitate error detection, logging and on-the-fly conversion from MIDI-likes to MIDI without having to initialize the library first.



      API change: The library now returns audio data in host-endian format, not little-endian.
      API change: WildMidi_GetVersion() added to the api, along with new numeric version macros in the wildmidi_lib.h header. the dso version is changed from 1 to 2.
      API change: All long or unsigned long type _WM_Info fields changed into strictly 32bit fields (int32_t or uint32_t.)
      API change: WildMidi_OpenBuffer() and WildMidi_GetOutput() changed to accept strictly 32bit size parameters, i.e. uint32_t, instead of unsigned long.
      API change: WildMidi_ConvertToMidi() and WildMidi_ConvertBufferToMidi() added for MIDI-like files to be converted to MIDI.
      API change: WildMidi_SetCvtOption() added to support conversion options.
      API change: WildMidi_SongSeek() added to support Type 2 MIDI files.
      API change: WildMidi_GetLyric() added to support embedded text, such as KAR files.
      API change: WildMidi_GetError() and WildMidi_ClearError() added to cleanly check for, retrieve and clear error messages. They no longer go to stderr.
      Support for loading XMI (XMIDI format) files, thanks Ryan Nunn for releasing his code under the LGPL.
      Support for loading MUS (MUS Id format) files, such as from Doom.
      Support for loading HMP/HMI files, such as from Arena and Daggerfall.
      Support for loading KAR (MIDI with Lyrics) and Type 2 MIDI files.
      Build requires cmake-2.8.11 or newer now.

  What's new in 0.3.12:

      Fixed bug in handling of the "source" directive in config files.
      CMake updates from 0.4.x. cmake-2.8.11 or newer is required now.
      Extended OS/2 support to EMX/KLIBC.

  What's new in 0.3.11:

      Support for OS/2.

  What's new in 0.3.10:

      Build system updates.
      File i/o updates.
      Support for AmigaOS and its variants like MorphOS and AROS.

  ```

  It would be great if we could get either
  1. a patched version and/or
  1. an updated version :)


  CC current maintainers: @bjornfor 


state: closed
title: pythonPackages.fritzconnection: init at 0.6.5
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33878
updated_at: 2018-01-18 11:47:28
body:
  ###### Motivation for this change
  Does anyone have an idea why the `substituteInPlace` is only necessary for Python 3?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linux_beagleboard: 4.9.61-ti-r76 -> 4.14.12-ti-r23
user_login: dhess
html_url: https://github.com/NixOS/nixpkgs/pull/33879
updated_at: 2018-01-18 18:25:37
body:
  ###### Motivation for this change

  Upgrade to latest upstream.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: netsniff-ng: 0.6.2 -> 0.6.3
user_login: dhess
html_url: https://github.com/NixOS/nixpkgs/pull/33881
updated_at: 2018-01-17 06:47:07
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: goxel: init at 0.7.2
user_login: tilpner
html_url: https://github.com/NixOS/nixpkgs/pull/33882
updated_at: 2018-01-28 14:33:00
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dcm2niix: init at 1.0.20170130
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33883
updated_at: 2018-01-15 13:28:15
body:
  ###### Motivation for this change
  Add a package used in biomedical imaging

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add packages for suricata
user_login: dhess
html_url: https://github.com/NixOS/nixpkgs/pull/33886
updated_at: 2018-01-17 10:25:24
body:
  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ponyc: 0.21.2 -> 0.21.3
user_login: kamilchm
html_url: https://github.com/NixOS/nixpkgs/pull/33888
updated_at: 2018-01-15 09:28:05
body:
  ###### Motivation for this change

  https://github.com/ponylang/ponyc/issues/2478

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitscope: create derivations with version info
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/33889
updated_at: 2018-02-03 20:15:57
body:
  ###### Motivation for this change
  So far the store paths produced by the bitscope derivations have been
  version-less. Fix it.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openvpn: add option to store credentials
user_login: lschuermann
html_url: https://github.com/NixOS/nixpkgs/pull/33890
updated_at: 2018-10-14 09:24:21
body:
  ###### Motivation for this change
  Many commercial and also a few private OpenVPN Servers don't allow public/private key based authentication but instead require a username/password combination. This change allows these credentials to be set inside the NixOS configuration, enabling to automatically connect to these VPNs.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I'm currently facing the issue, that the generated credentials file inside the Nix-store is readable by all users. I have not found any way to set permissions with the `pkgs.writeTextFile` functions. Is it possible to protect the credentials-file and if so, how can I accomplish that?


state: closed
title: wildmidi: 0.3.9 -> 0.4.2
user_login: bjornfor
html_url: https://github.com/NixOS/nixpkgs/pull/33891
updated_at: 2018-02-08 16:51:35
body:
  ###### Motivation for this change
  0.4.2 fixes the following CVEs:
  CVE-2017-11661
  CVE-2017-11662
  CVE-2017-11663
  CVE-2017-11664

  Fixes #33877.

  ---

  Untested! Also, I'm not sure if this can be backported to release-17.09 due to 0.4.0 seemingly having breaking changes. https://github.com/Mindwerks/wildmidi/releases 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mrtrix3: init at 0.3.16
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33892
updated_at: 2019-03-30 19:40:12
body:
  ###### Motivation for this change
  Add MRTrix3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: apache-directory-studio: add missing desktop item
user_login: flokli
html_url: https://github.com/NixOS/nixpkgs/pull/33893
updated_at: 2018-01-15 15:13:42
body:
  ###### Motivation for this change
  I added Apache Directory Studio, but didn't find it in my application menu.
  This adds the missing `.desktop` file.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ceph: 9.2.0 -> 12.2.2
user_login: adevress
html_url: https://github.com/NixOS/nixpkgs/pull/33894
updated_at: 2018-02-21 16:45:37
body:
  - Update Ceph to last version
  - Solve security vulnerability of the old version
  - Provide shared version of snappy, required for Ceph

  ###### Motivation for this change
  - Make Ceph usable again
  - Provide shared version for snappy

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ispc: 20170807 -> 1.9.2
user_login: guibou
html_url: https://github.com/NixOS/nixpkgs/pull/33896
updated_at: 2018-01-15 14:22:14
body:
  Version bump, fixes #29979

  ###### Motivation for this change

  Upstream version was changed and includes a fix for #29979

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Avoid package attributes starting with a digit
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/33897
updated_at: 2019-02-23 09:36:48
body:
  ###### Motivation for this change
  See the release notes.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - [x] Built NixOS manual
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos: doc: implement related packages in the manual (again)
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/33898
updated_at: 2018-09-23 14:09:51
body:
  ###### What is this?

  #32424 reverted by #33006 brought back to you with laziness and `meta.evaluates` of #33057.
  Closes #33007.

  ###### Things done

  - [X] Seems to work.
  - [X] `configuration.nix(5)` manual builds on x86_64-linux.
  - [ ] `configuration.nix(5)` manual builds on aarch64-linux.

  Please check the last item with OfBorg before merging, I'm too lazy to rebuild aarch64 stdenv just to test this.

  ---

  /cc @grahamc @vcunat


state: closed
title: Lightworks: use old portaudio 2014
user_login: antonxy
html_url: https://github.com/NixOS/nixpkgs/pull/33899
updated_at: 2018-01-15 13:32:51
body:
  ###### Motivation for this change
  Lightworks crashed at startup because of a breaking ABI change from PortAudio 2014 to 2016, see  https://github.com/NixOS/nixpkgs/pull/25552#issuecomment-356940886 for more details.

  I added a portaudio2014 package for the old version of portaudio so lightworks can use this until a lightworks version using the new portaudio is released.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/nginx: allow using existing ACME certificate
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/33900
updated_at: 2018-01-29 00:38:49
body:
  ###### Motivation for this change
  When a domain has a lot of subdomains, it is quite easy to hit the [rate limit](https://letsencrypt.org/docs/rate-limits/). Instead you can define the certificate manually in `security.acme.certs` and list the subdomains in the `extraDomains` option.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Evaluated on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rstudio: 1.1.383 -> 1.1.414
user_login: sifmelcara
html_url: https://github.com/NixOS/nixpkgs/pull/33901
updated_at: 2018-01-18 17:05:04
body:
  ###### Motivation for this change

  Fix build by updating rstudio version.

  Old version of rstudio fails to build on current nixpkgs master because it do not support new version of boost. (https://github.com/rstudio/rstudio/issues/1897)

  ###### Things done

  1. remove openssl patch. Because the issue have been fixed by upstream
  2. change `fetchurl` to `fetchFromGitHub` (#32997)
  3. update the version of `rstudio`, `rmarkdown` and `rsconnect`.

  cc maintainers @ehmry @changlinli @ciil

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bettercap: init at 1.6.2
user_login: y0no
html_url: https://github.com/NixOS/nixpkgs/pull/33902
updated_at: 2018-01-26 15:07:31
body:
  ###### Motivation for this change
  This package was missing

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [RFC] get lua support closer to python
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/33903
updated_at: 2019-02-26 05:35:48
body:
  ###### Motivation for this change

  My motivation is to be able to run neovim tests/plugins which rely on lua.
  This PR can import a whitelist of packages (rockspec and src.rock) from luarocks automatically into nixpkgs.

  ###### Things done

  Delegate lua packages handling to luarocks, similar to what python can do with pipy. 

  i have forked luarocks to generate a list of nix derivations from luarocks packages 
  https://github.com/teto/luarocks/tree/nix (needs cjson) and then run with `luarocks nix [--server=SERVER] PKG_NAME`

  Right now, buildLuarocksPackage works with luarocks rocks (*.src.rock files = a zip archive with a rockspec describing the package + the source code) and rockspecs.

  Possibie improvements
  - [ ] add propagatedBuildInputs to the generated luarocks config `external_deps_dirs = {}`  (https://github.com/luarocks/luarocks/wiki/Paths-and-external-dependencies)
  - [ ] export/use version specific variables such as LUA_PATH_5_2/LUAROCKS_CONFIG_5_2
  - [ ] let luarocks check for dependencies via exporting the different rocktrees in temporary config as is kind of done in torch-distro.nix
  - [ ] remove the luarocks warning about different folder owners 
  - [ ] a better way to tell luarocks where to look for buildInputs https://github.com/luarocks/luarocks/wiki/Platform-agnostic-external-dependencies
  Here is an upstreaming roadmap:
  - [x] update luarocks https://github.com/NixOS/nixpkgs/pull/54454
  - [x] add lua.withPackages https://github.com/NixOS/nixpkgs/pull/54460
  - [ ] convert packages to use lua.withPackages 
    - [x] neovim / mpv https://github.com/NixOS/nixpkgs/pull/55266
    - [x] add wrapLua
    - [ ] mudlet/mpv/conky/vis/quvi/sile/prosody/crawl (Feel free to pick commits from https://github.com/teto/nixpkgs/tree/lua_envs and merge them yourself, I have no time to do it at the moment
  - [ ] convert some packages to luarocks-based packaging (https://github.com/NixOS/nixpkgs/pull/55747)
  - [ ] update documentation https://github.com/NixOS/nixpkgs/pull/55302

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sudo: define extra rules in Nix language
user_login: lschuermann
html_url: https://github.com/NixOS/nixpkgs/pull/33905
updated_at: 2018-10-14 09:18:10
body:
  ###### Motivation for this change
  This change makes it possible to define extra sudo rules by using only the Nix language.
  It has a few benefits over the current way of defining rules, mainly:
   - The rules are type-checked and it is harder to make syntax errors in the sudo file
   - One rule can conveniently be applied for multiple users & groups
   - Rules can now be defined in multiple Nix files and be merged

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: miniupnp{d,c} updates, fix for CVE-2017-1000494
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33906
updated_at: 2018-01-16 04:25:14
body:
  ###### Motivation for this change

  Randomly browsing through issue trackers and checking with nixpkgs made me discover an issue with miniupnpd. Miniupnpc also received an update but I am uncertain if that is also affected by the same issue. Bumping it shouldn't hurt tho..

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests]
  (https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
     - [x] `nixos/tests/bittorent.nix` contains code that uses `miniupnpd` so I used that as a test case.
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: evdi: 1.4.1+git2017-06-12 -> unstable-2018-01-12
user_login: ghost
html_url: https://github.com/NixOS/nixpkgs/pull/33907
updated_at: 2018-01-17 14:11:59
body:
  The currently packaged version does not work with the current kernel.
  This is why I updated to the currently unstable version which seems to
  be working here.
  There is currently no other way to use evdi on a recent kernel.

  ###### Motivation for this change

  Evdi is not usable on a recent kernel.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: WIP: glibc: fix CVE-2018-1000001 (getcwd() absolute path issue)
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33909
updated_at: 2018-01-15 20:26:32
body:
  ###### Motivation for this change

  Fixing CVE-2018-1000001.

  I am currently trying to verify if stuff obviously breaks. My build machine just started building...

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Semi-automated Emacs package updates
user_login: mdorman
html_url: https://github.com/NixOS/nixpkgs/pull/33910
updated_at: 2018-01-16 12:56:57
body:
  Also includes an evaluation fix---`rcirc-menu` moved from melpa-stable to elpa, rendering the override that I put in place some time ago problematic.


state: closed
title: mighttpd2: add service
user_login: fgaz
html_url: https://github.com/NixOS/nixpkgs/pull/33911
updated_at: 2018-01-16 21:30:51
body:
  ###### Motivation for this change

  A service option for the mighttpd2 web server

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: slock: add configuration-hint to the description
user_login: rkoe
html_url: https://github.com/NixOS/nixpkgs/issues/33912
updated_at: 2018-01-15 22:05:05
body:
  ## Issue description

  After installing "slock" and trying to use it, you get the error-message
  > slock: unable to disable OOM killer. Make sure to suid or sgid slock.

  The solution is to use  `programs.slock.enable = true;` as described on https://nixos.wiki/wiki/Slock


  So, I suggest to modify the long description of the slock package to:

  >      longDescription = ''
  >        Simple X display locker. This is the simplest X screen locker.
  >
  >        Note that since slock requires root-priviledges on X11 for accessing passwords
  >        and protecting itself from OOM killing, `programs.slock.enable = true;` must be
  >        added to /etc/nixos/configuration.nix to be able to use slock.
  >      '';


state: closed
title: kpcli: Fix darwin build
user_login: ciderale
html_url: https://github.com/NixOS/nixpkgs/pull/33913
updated_at: 2018-01-16 20:34:11
body:
  ###### Motivation for this change

  Fix kpcli build on darwin as part of #29221 

  ###### Things done


  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: amd-hybrid-graphics module: remove
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/33915
updated_at: 2018-04-15 15:01:46
body:
  ###### Motivation for this change
  This was only applicable to very specific hardware, and the only person
  with an apparent interest in maintaining it (me) no longer uses the
  hardware in question.

  cc @wkennington , original author of the module

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: pythonPackages.nipype: 0.10.0 -> 0.14.0
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33916
updated_at: 2018-01-20 19:26:46
body:
  ###### Motivation for this change
  Many new nipype features in interim, including py3 support

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wakatime: don't run check phase
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33917
updated_at: 2018-01-16 09:41:18
body:
  ###### Motivation for this change
  Wakatime would not previously build for me (`nix-build -A wakatime`).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.nimfa: init at 1.3.1
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33918
updated_at: 2018-01-17 10:02:24
body:
  ###### Motivation for this change
  New Python package for nonnegative matrix factorization (maths and science).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hll2390dw-cups: init at 4.0.0-1
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/33919
updated_at: 2018-06-01 15:30:47
body:
  ###### Motivation for this change

  Adding the driver for my printer.

  This driver is *unified*, it has both the lpr and cupswrapper parts in one, when compared to other older brother drivers. This is why I used the `-cups` suffix. I definitely didn't know what to use.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - NixOS
  - Tested execution of all binary files THROUGH CUPS (it prints!)
  - Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.progressbar2: init at 3.12.0
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/pull/33920
updated_at: 2018-01-17 10:17:48
body:
  ###### Motivation for this change
  New python package, simple to use progress bar

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: arpack derivation partially broken
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/issues/33921
updated_at: 2018-01-23 17:14:44
body:
  ## Issue description
  Running the test suite (`doCheck=true`) in the arpack derivation (master, 34b4d41a844a769a1d34524d9df2241ffc725595), will produce two failed tests (see [log](https://gist.github.com/markuskowa/9c0fa5b53b555fc1cf4ae95e8a85984b))
  The problem does not appear when I build the package against `blas` and `liblapack` instead of `openblas` ([arpack.nix](https://gist.github.com/markuskowa/19f3afe26da837ebc894c0cccf1642d1)). Upgrading `arpack` from version 3.3.0 to 3.5.0 gives the same results.

  I recognized the problem when I tried to build an application (http://octopus-code.org/). Some tests involving `arpack` routines fail when build against the master `arpack`/`openblas` version.

  ### Steps to reproduce
  enable doCheck=true` in pkgs/development/libraries/science/math/arpack/default.nix and build package.

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 17.09.2683.360089b3521 (Hummingbird)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2683.360089b3521"`
   


state: closed
title: Adds support xen domU lightweight containers
user_login: angerman
html_url: https://github.com/NixOS/nixpkgs/pull/33922
updated_at: 2018-07-27 04:30:13
body:
  When runnign nixOS in a xen setup without it's own
  kernel (the kernel and initrd are provided by the host)
  we need to use init-scripts (/sbin/init) instead of grub
  and have no kernel.

  ###### Motivation for this change

  This adds support to run nixOS on DomainFactorys
  (df.eu) JiffyBoxs with the "PV-Kernel". It should also
  allow to run nixOS on similar setups xen guest setups
  where the host provides the kernel.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: molden: init at 5.7
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/33924
updated_at: 2018-01-23 20:14:10
body:
  ###### Motivation for this change
  App to display output from quantum chemistry calculations.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: neovim: don't install desktop file on darwin
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/33925
updated_at: 2018-01-16 09:13:08
body:
  ###### Motivation for this change

  nvim.desktop doesn't exist on darwin so forcefully reading it fails see https://github.com/NixOS/nixpkgs/pull/33639#issuecomment-357857466

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Haskell Cabal Flags Being Ignored?
user_login: idontgetoutmuch
html_url: https://github.com/NixOS/nixpkgs/issues/33926
updated_at: 2018-01-20 06:58:21
body:
  ## Issue description

  `nix-build` fails with a cabal configure error

  ### Steps to reproduce

  `nix-build --attr project1 release1.nix`

  release1.nix:

  ```
  let
  config = {
    packageOverrides = pkgs: rec {
      haskellPackages = pkgs.haskellPackages.override {
        overrides = haskellPackagesNew: haskellPackagesOld: rec {
          project1 =
            haskellPackagesNew.callPackage ./default.nix { };
          hmatrix =
            pkgs.haskell.lib.enableCabalFlag (pkgs.haskell.lib.enableCabalFlag (haskellPackagesNew.callPackage ./hmatrix.nix { }) "openblas") "disable-default-paths";
        };
      };
    };
  };

  pkgs = import <nixpkgs> { inherit config; };

  in
  { project1 = pkgs.haskellPackages.project1;
  }
  ```

  default.nix:

  ```
  { mkDerivation, base, stdenv, hmatrix }:
  mkDerivation {
    pname = "project1";
    version = "1.0.0";
    src = ./.;
    isLibrary = false;
    isExecutable = true;
    executableHaskellDepends = [ base hmatrix ];
    license = stdenv.lib.licenses.bsd3;
  }
  ```

  hmatrix.nix:

  ```
  { mkDerivation, array, base, binary, openblas, bytestring, deepseq
  , liblapack, random, semigroups, split, stdenv, storable-complex
  , vector
  }:
  mkDerivation {
    pname = "hmatrix";
    version = "0.18.1.1";
    src = /Users/dom/hmatrix/packages/base;
    libraryHaskellDepends = [
      array base binary bytestring deepseq random semigroups split
      storable-complex vector
    ];
    librarySystemDepends = [ openblas liblapack ];
    preConfigure = "sed -i hmatrix.cabal -e '/\\/usr\\//D'";
    homepage = "https://github.com/albertoruiz/hmatrix";
    description = "Numeric Linear Algebra";
    license = stdenv.lib.licenses.bsd3;
  }
  ```

  hmatrix.cabal:

  ```
  Name:               hmatrix
  Version:            0.18.1.1
  License:            BSD3
  License-file:       LICENSE
  Author:             Alberto Ruiz
  Maintainer:         Alberto Ruiz
  Stability:          provisional
  Homepage:           https://github.com/albertoruiz/hmatrix
  Synopsis:           Numeric Linear Algebra
  Description:        Linear systems, matrix decompositions, and other numerical computations based on BLAS and LAPACK.
                      .
                      Standard interface: "Numeric.LinearAlgebra".
                      .
                      Safer interface with statically checked dimensions: "Numeric.LinearAlgebra.Static".
                      .
                      Code examples: <http://dis.um.es/~alberto/hmatrix/hmatrix.html>

  Category:           Math
  tested-with:        GHC==8.0

  cabal-version:      >=1.8

  build-type:         Simple

  extra-source-files: THANKS.md CHANGELOG

  extra-source-files: src/Internal/C/lapack-aux.h

  flag openblas
      description:    Link with OpenBLAS (https://github.com/xianyi/OpenBLAS) optimized libraries.
      default:        False
      manual: True

  flag disable-default-paths
      description:    When enabled, don't add default hardcoded include/link dirs by default. Needed for hermetic builds like in nix.
      default:        False
      manual: True

  library

      Build-Depends:      base >= 4.8 && < 5,
                          binary,
                          array,
                          deepseq,
                          random,
                          split,
                          bytestring,
                          storable-complex,
                          semigroups,
                          vector >= 0.8

      hs-source-dirs:     src

      exposed-modules:    Numeric.LinearAlgebra
                          Numeric.LinearAlgebra.Devel
                          Numeric.LinearAlgebra.Data
                          Numeric.LinearAlgebra.HMatrix
                          Numeric.LinearAlgebra.Static

      other-modules:      Internal.Vector
                          Internal.Devel
                          Internal.Vectorized
                          Internal.Matrix
                          Internal.ST
                          Internal.IO
                          Internal.Element
                          Internal.Conversion
                          Internal.LAPACK
                          Internal.Numeric
                          Internal.Algorithms
                          Internal.Random
                          Internal.Container
                          Internal.Sparse
                          Internal.Convolution
                          Internal.Chain
                          Numeric.Vector
                          Internal.CG
                          Numeric.Matrix
                          Internal.Util
                          Internal.Modular
                          Internal.Static

      C-sources:          src/Internal/C/lapack-aux.c
                          src/Internal/C/vector-aux.c


      extensions:         ForeignFunctionInterface

      ghc-options:        -Wall
                          -fno-warn-missing-signatures
                          -fno-warn-orphans
                          -fno-prof-auto

      cc-options:         -O4 -Wall

      if arch(x86_64)
          cc-options:     -msse2
      if arch(i386)
          cc-options:     -msse2


      if os(OSX)
          if flag(openblas)
              if !flag(disable-default-paths)
                  extra-lib-dirs:     /opt/local/lib/openblas/lib
              extra-libraries:    openblas
          else
              extra-libraries:    blas lapack

          if !flag(disable-default-paths)
              extra-lib-dirs: /opt/local/lib/
              include-dirs: /opt/local/include/
              extra-lib-dirs: /usr/local/lib/
              include-dirs: /usr/local/include/
          if arch(i386)
              cc-options: -arch i386
          frameworks: Accelerate

      if os(freebsd)
          if flag(openblas)
              if !flag(disable-default-paths)
                  extra-lib-dirs:     /usr/local/lib/openblas/lib
              extra-libraries:    openblas
          else
              extra-libraries:    blas lapack

          if !flag(disable-default-paths)
              extra-lib-dirs: /usr/local/lib
              include-dirs: /usr/local/include
          extra-libraries: gfortran

      if os(windows)
          if flag(openblas)
              extra-libraries:    libopenblas, libgcc_s_seh-1, libgfortran, libquadmath-0
          else
              extra-libraries:    blas lapack

      if os(linux)
          if flag(openblas)
              if !flag(disable-default-paths)
                  extra-lib-dirs:     /usr/lib/openblas/lib
              extra-libraries:    openblas
          else
              extra-libraries:    blas lapack

          if arch(x86_64)
              cc-options: -fPIC


  source-repository head
      type:     git
      location: https://github.com/albertoruiz/hmatrix
  ```

  The failure is

  ```
  bash-3.2$ nix-build --attr project1 release1.nix
  these derivations will be built:
    /nix/store/kwbz470cnc3bg1zyhq6ckyg88hlygap1-hmatrix-0.18.1.1.drv
    /nix/store/zhfabzxnmq5b230d46h34f7vikxmsh9y-project1-1.0.0.drv
  building path(s) ‘/nix/store/qxvvaq4niags06vlj9w2di9k3abi44y5-hmatrix-0.18.1.1-doc’, ‘/nix/store/vkm582lmmd1mhf09qgv7i60jrsp3xljr-hmatrix-0.18.1.1’
  setupCompilerEnvironmentPhase
  Build with /nix/store/2szhjd6206nmvl0fakkadai4jwfcdycc-ghc-8.0.2.
  unpacking sources
  unpacking source archive /nix/store/6q2zp3wcqwhh4zx0pav8f6dx919cc425-base
  source root is base
  patching sources
  compileBuildDriverPhase
  setupCompileFlags: -package-db=/private/tmp/nix-build-hmatrix-0.18.1.1.drv-0/package.conf.d -j1 -threaded
  [1 of 1] Compiling Main             ( Setup.lhs, /private/tmp/nix-build-hmatrix-0.18.1.1.drv-0/Main.o )
  Linking Setup ...
  configuring
  configureFlags: --verbose --prefix=/nix/store/vkm582lmmd1mhf09qgv7i60jrsp3xljr-hmatrix-0.18.1.1 --libdir=$prefix/lib/$compiler --libsubdir=$pkgid --docdir=/nix/store/qxvvaq4niags06vlj9w2di9k3abi44y5-hmatrix-0.18.1.1-doc/share/doc --with-gcc=clang --package-db=/private/tmp/nix-build-hmatrix-0.18.1.1.drv-0/package.conf.d --ghc-option=-optl=-Wl,-headerpad_max_install_names --ghc-option=-j1 --disable-split-objs --disable-library-profiling --disable-profiling --enable-shared --disable-coverage --enable-library-vanilla --enable-executable-dynamic --enable-tests -fopenblas -fdisable-default-paths --extra-include-dirs=/nix/store/3mj5i7xqii2kd3dpx9avkxmyhnig9zv7-openblas-0.2.20/include --extra-lib-dirs=/nix/store/3mj5i7xqii2kd3dpx9avkxmyhnig9zv7-openblas-0.2.20/lib --extra-lib-dirs=/nix/store/bgbhyzfx5yilan9qydnzyxybd71am6dz-liblapack-3.4.1/lib --extra-include-dirs=/nix/store/vgbc1jcn639f4nrrszxyaagxx0frss2a-atlas-3.10.2/include --extra-lib-dirs=/nix/store/vgbc1jcn639f4nrrszxyaagxx0frss2a-atlas-3.10.2/lib --extra-include-dirs=/nix/store/cfl3g7nakfffmk3a9g8frjbj74wfayra-libc++-4.0.1/include --extra-lib-dirs=/nix/store/cfl3g7nakfffmk3a9g8frjbj74wfayra-libc++-4.0.1/lib
  Setup: hmatrix.cabal:119: 'then' branch of 'if' is empty
  builder for ‘/nix/store/kwbz470cnc3bg1zyhq6ckyg88hlygap1-hmatrix-0.18.1.1.drv’ failed with exit code 1
  cannot build derivation ‘/nix/store/zhfabzxnmq5b230d46h34f7vikxmsh9y-project1-1.0.0.drv’: 1 dependencies couldn't be built
  error: build of ‘/nix/store/zhfabzxnmq5b230d46h34f7vikxmsh9y-project1-1.0.0.drv’ failed`
  ```

  Here is the relevant line:

  https://github.com/albertoruiz/hmatrix/blob/master/packages/base/hmatrix.cabal#L119

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
  bash-3.2$ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-darwin"`
   - host os: `Darwin 17.3.0, macOS 10.13.2`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.15`
   - channels(root): `"nixpkgs-18.03pre122117.14df60d0db9"`
   - channels(dom): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`
  ```


state: closed
title: kimageformats: Fixes build
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/33927
updated_at: 2018-01-16 09:07:19
body:
  ###### Motivation for this change
  Was broken after recent changes.

  @adisbladis 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linode-api: 4.1.2b0 -> 4.1.6b0
user_login: GlennS
html_url: https://github.com/NixOS/nixpkgs/pull/33928
updated_at: 2018-04-05 08:58:47
body:
  ###### Motivation for this change

  Needed because the underlying HTTP endpoint has also changed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [N/A] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))

  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`

  I've run `nix-shell -I "nixpkgs=." -p nox --run "nox-review wip"` . 

  It makes result and result-2 folders for python3.6-linode-api and python2.7-linode-api. I haven't managed to import them into Python though. Presumably I need to do something with the PYTHONPATH environment variable?

  - [N/A] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kinit: Fixes build
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/33930
updated_at: 2018-01-16 11:48:41
body:
  ###### Motivation for this change
  @adisbladis 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.multidict: 3.3.2 -> 4.0.0
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33931
updated_at: 2018-01-21 20:13:04
body:
  ###### Motivation for this change
  `nox-review` shows that httpbin cannot be built. See #33615.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @FRidh @primeos 


state: closed
title: pythonPackages.{pygobject3,gst-python} collision on 17.09
user_login: ashgillman
html_url: https://github.com/NixOS/nixpkgs/issues/33932
updated_at: 2018-01-18 08:45:48
body:
  ## Issue description

  collision between `/nix/store/v8j5nk2lhbgs30ld5zgv4p8fsqdicc91-gst-python-1.10.4/lib/python2.7/site-packages/gi/overrides/__init__.py' and `/nix/store/bc3kdjqbw8yvcm80djk1mp20ri26dm6p-python2.7-pygobject-3.24.1/lib/python2.7/site-packages/gi/overrides/__init__.py'

  I'm happy to have a crack at fixing. Is there a way to specify a priority for example? If so, which would be preferred.

  ### Steps to reproduce

  nix-build on

  ```
  let pkgs = import <nixpkgs> {};
  in
    with pkgs.python27Packages;
    python.buildEnv.override {
      extraLibs = [ gst-python pygobject3 ];
    }
  ```

  Same issue with python35Packages

  ## Technical details

  ```
  gil at 22:00:55 on nixosx in ~/tmp

  ♪ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 4.12.10, NixOS, 17.03.1947.d77e0969a78 (Gorilla)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.14`
   - channels(root): `"nixos-17.09.2752.fea24301317"`
   - channels(gil): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`
  ```


state: closed
title: kwin: Fixes build
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/33933
updated_at: 2018-01-16 13:41:44
body:
  ###### Motivation for this change

  @adisbladis 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kindlegen: Use unzip where necessary
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/33934
updated_at: 2018-01-16 14:04:05
body:
  ###### Motivation for this change

  kindlegen: Cannot unpack on macOS #33145

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimb: 2.11 -> 3.1.0
user_login: S-NA
html_url: https://github.com/NixOS/nixpkgs/pull/33936
updated_at: 2018-04-12 01:17:05
body:
  ###### Motivation for this change
  Updates vimb to no longer depend on webkitgtk24x.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: solc: enable shared libs
user_login: akru
html_url: https://github.com/NixOS/nixpkgs/pull/33937
updated_at: 2018-05-02 09:32:50
body:
  ###### Motivation for this change

  This change enable shared libraries build and installation for solidity compiler.
  Separately added `dev` output for headers.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ClamAV cannot access exim mail queue for scanning
user_login: Criena
html_url: https://github.com/NixOS/nixpkgs/issues/33938
updated_at: 2018-01-16 15:11:05
body:
  ## Issue description

  ClamAV is running as a daemon. Exim stores a received email and tells clamd via its socket where to find the file. ClamAV then tries to access the path, but fails with "permission denied".

  First issue I found and fixed was to add clamav to the exim group, since exim saves the file with exim:exim and 640 access rights. Unfortunately this didn't do the trick.

  Could this be some kind of sandboxing issue?

  ### Steps to reproduce

  I enabled ClamAV:

  > services.clamav = {
  >   daemon.enable = true;
  >   updater.enable = true;
  > };

  And configured exim to find the socket:

  >av_scanner = clamd:/run/clamav/clamd.ctl

  So far everything works, exim can communicate with clamd and also reports the error back that clamd wasn't able to access the file due to permission issues.

  ## Technical details

  > Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.76, NixOS, 17.09.2752.fea24301317 (Hummingbird)`
   - multi-user?: `no`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2752.fea24301317"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: open
title: kernel-less profile/module in nixpkgs/nixos?
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/issues/33940
updated_at: 2018-01-19 16:00:39
body:
  We already have a `isContainer` flag.
  Now there is an [open pull request](https://github.com/NixOS/nixpkgs/pull/33922) to add similar option for paravirtualized kernels.
  I think we could need some module, we can include in case we don't want nixos
  to handle the kernel/bootloader and instead only provide an init script.

  I could imagine the following use cases:

  - containers
  - paravirtualized xen guest
  - some providers that provide their own kernels (i.e. scaleway)
  - some ugly embedded hardware, where we use the non-upstream kernel/u-boot provided by the vendor and only manage the nixos userland.

  Any suggestions?
  cc @dezgeg @andir @NeQuissimus 


state: closed
title: Add and update vim plugins
user_login: andsild
html_url: https://github.com/NixOS/nixpkgs/pull/33942
updated_at: 2018-01-16 20:35:26
body:
  ###### Motivation for this change
  New vim plugins are cool. Updates also.

  ###### Things done
  Updated a few vim plugins and added a few others. Can create separate MR's if thats desirable, or merge the commits.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested with `:nix-shell -I nixpkgs=~/nixpkgs -p vimPlugins.pluginnames2nix --command "vim-plugin-names-to-nix </dev/null"` and by applying the generated conf to [my own neovim](https://github.com/andsild/dotfiles/blob/master/nixpkgs/pkgs/nvim_config.nix).


state: closed
title: Renpy and pygame_sdl2 update - 6.99.14
user_login: rardiol
html_url: https://github.com/NixOS/nixpkgs/pull/33943
updated_at: 2018-03-22 02:26:30
body:
  ###### Motivation for this change

  Ought to fix https://github.com/NixOS/nixpkgs/issues/20448.

  I just tested the tutorial a bit, seems fine. Sphinx however is non-functional. 

  Is this the best format for pygame_sdl2 version number?

  cc @7c6f434c

  edit: fixed the new project launcher executable and added tkinter

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: LibreOffice Writer Spellcheck Does Not Work
user_login: billksun
html_url: https://github.com/NixOS/nixpkgs/issues/33944
updated_at: 2019-01-24 23:06:01
body:
  ## Issue description
  When editing a document in Writer, the spellchecker does not catch any mistakes.  Even with `hunspell` installed.


  ### Steps to reproduce
  1. Open LibreOffice Writer.
  2. Start typing misspelled words.
  3. Observe that there are no squiggly red underline for the misspelled words.
  4. Hit F7 or click on Tools -> Spelling and Grammar...
  5. Observe a popup that says "The spellcheck is complete.", click "OK" and observe that no misspellings are detected.
  6. Install `hunspell` and `hunspellDicts.en-us`, repeat the above steps and observe that the problem still exists.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.73, NixOS, 18.03pre124015.f59a0f7f1a6 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.03pre125130.3a763b91963"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: julia: 0.6.0 -> 0.6.2
user_login: eschnett
html_url: https://github.com/NixOS/nixpkgs/pull/33945
updated_at: 2018-02-02 15:59:08
body:
  ###### Motivation for this change

  Julia 0.6.2 is a minor release containing corrections.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libmpc: 1.0.3 -> 1.1.0
user_login: Chell256
html_url: https://github.com/NixOS/nixpkgs/pull/33946
updated_at: 2018-01-16 20:16:18
body:
  ###### Motivation for this change
  The nix expression was using an outdated fetchurl and a new version was available

  ###### Things done

   - libmpc: 1.0.3 -> 1.1.0
   - updated fetchurl


  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: profile-cleaner: add missing dependency
user_login: S-NA
html_url: https://github.com/NixOS/nixpkgs/pull/33947
updated_at: 2018-04-12 01:17:04
body:
  ###### Motivation for this change
  profile-cleaner does not run correctly without the file utility.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: {llvm,clang}-{4,5}: don't rebuild entire projects just to get manpages
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33948
updated_at: 2018-01-21 21:54:54
body:
  https://github.com/NixOS/nixpkgs/issues/33369#issuecomment-355086339

  Also give manpage derivations different names so that they
  don't clutter up `nix-env -qaP` and such.

  Doesn't change hash for current llvm/clang-unwrapped,
  hopefully avoids mass-rebuild on Darwin.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/release.nix: More refactoring for multi-arch
user_login: dezgeg
html_url: https://github.com/NixOS/nixpkgs/pull/33951
updated_at: 2018-01-19 08:35:51
body:
  Currently, even if you pass `supportedSystems = [ "aarch64-linux" ]` you
  end up with e.g. `nixos.tests.docker` which actually silently runs on
  x86_64-linux. Using the new callTestOnTheseSystems fixes that.
      
  As a side-effect, this also causes renames of e.g. `nixos.tests.docker` -> `nixos.tests.docker.x86_64-linux`, which is IMHO a good thing since it's makes them consistent with the rest of the tests.

  Note: this doesn't fix all such instances, only two common patters. More fixes will come later.

  Effect on aarch64-unstable: https://hydra.nixos.org/eval/1426827#tabs-removed


state: closed
title: fix manual
user_login: ikervagyok
html_url: https://github.com/NixOS/nixpkgs/pull/33952
updated_at: 2018-01-16 20:20:40
body:
  ###### Motivation for this change
  broken by: https://github.com/NixOS/nixpkgs/commit/b55d4c0564b0bde4cbc0c01b6ba7a1276382335a

  Just replaced `<` and `>` by their xml-magic-numbers, to fix the build.

  ###### Things done
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clang: patch cmake files for lib output
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/33953
updated_at: 2018-01-21 00:12:02
body:
  ###### Motivation for this change

  Fixes cmake build issues introduced in #33342.

  /cc @vcunat

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.7.9 -> 1.9.1
user_login: kuznero
html_url: https://github.com/NixOS/nixpkgs/pull/33954
updated_at: 2018-03-02 21:44:20
body:
  ###### Motivation for this change

  Upgrade kubernetes to latest v1.9.1 (as well as kuvecfg to v0.6.0, as well as kubernetes-dashboard to v1.8.2). Related to #30639.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lldb-{4,5}: install manpage
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33955
updated_at: 2018-01-21 21:54:04
body:
  ###### Motivation for this change

  It's just sitting there in docs/, waiting to be included!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Since the file is tiny, doesn't seem worth splitting to separate output.


state: closed
title: [discussion] patchShebangs and cross: what tools to use?
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/33956
updated_at: 2019-06-11 19:21:36
body:
  ## Intro

  patchShebangs rewrites scripts with shebangs to use tools from $PATH.  By "resolving" these references to (absolute) nix store paths the interpreter used can be controlled precisely-- for example, the correct version of python will always be used.

  This is great :+1: and very useful.  Especially on NixOS where not doing so generally means scripts don't work at all.

  ## Problem

  When cross-compiling, there is a bit of a problem: which platform's tools should be used?  PATH is misleading because it may contain various build-time dependencies (from buildPlatform) that are inappropriate for use on hostPlatform.


  ## Solution?

  So, before I wrote this it seemed this was a challenging problem: how to "guess" whether buildPlatform or hostPlatform tools should be used when rewriting shebangs? Nothing in the script will tell  you, so it's anyone's guess how it will be used.....

  Buuuut I think the answer is actually this:  patchShebangs should always patch scripts to use hostPlatform tools, refusing to use tools from buildPlatform (when the two are not the same).

  Should the script need to be executed for the build, then if nativeBuildInputs are used properly then the "hostPlatform" the script was patched for will be the current buildSystem.  If you follow, hopefully makes sense.

  **Feedback on whether it's agreed that  "patchShebangs should only patch to host tools" would be appreciated.**

  ## Forward
  ### Implementing the Solution

  This is a bit tricky, but I haven't thought about it too much.   Thoughts/suggestions welcome!

  ### Related

  Actually, is there any reason for the outputs of a cross-built derivation to have dependencies on things from buildPackages? I expect checking for this strictly would "break" a lot off things, but perhaps that's for the best since it's unclear those outputs would be useful anyway.


state: closed
title: Added support for Factorio's experimental branch.
user_login: seanparsons
html_url: https://github.com/NixOS/nixpkgs/pull/33957
updated_at: 2018-02-16 16:03:59
body:
  ###### Motivation for this change

  Factorio has a normal release version and an experimental release version, it would be nice if NixOS had support for both.

  ###### Things done

  I've added a level of nesting to the original Factorio nix file so that it supports platform, release type and now also experimental/final. Additionally I added a `factorio-experimental` top level package so that it's more easily installed.

  Ideally this would also make it into the 17.09 branch.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mencal: init at 3.0
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/33958
updated_at: 2018-01-17 14:25:01
body:
  ###### Motivation for this change

  Adding mencal.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elk: 6.1.1 -> 6.1.2 (includes security fix)
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33959
updated_at: 2018-01-17 00:30:14
body:
  ###### Motivation for this change

  Normal upgrade but including a security fix for kibana: CVE-2018-3818.

  https://www.elastic.co/guide/en/elasticsearch/reference/current/release-notes-6.1.2.html
  https://www.elastic.co/guide/en/logstash/6.1/logstash-6-1-2.html
  https://www.elastic.co/guide/en/kibana/6.1/release-notes-6.1.2.html
  https://www.elastic.co/guide/en/beats/libbeat/6.1/release-notes-6.1.2.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: elk: 5.6.5 -> 5.6.6 (security fix)
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33960
updated_at: 2018-01-17 01:11:21
body:
  ###### Motivation for this change

  Security fix for CVE-2018-3818.

  https://www.elastic.co/guide/en/kibana/5.6/release-notes-5.6.6.html
  https://www.elastic.co/guide/en/logstash/5.6/logstash-5-6-6.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] ncbi-blast: init at 2.7.1
user_login: orivej
html_url: https://github.com/NixOS/nixpkgs/pull/33961
updated_at: 2019-03-30 19:40:13
body:
  ###### Motivation for this change

  BLAST tools are fundamental for bioinformatics. The official package and packages in various distributions are called `ncbi-blast` or `ncbi-blast+`, so I used this name.

  This PR in its current state is a response to #33956. (I have made it for myself and did not want to publish until I was certain that it was done right, but that issue prompted me to publish it now.) It builds and works. It allows, but does not implement cross compilation. It is not clear that `substitute-paths` helper should be accepted into `all-packages`, be scoped to `ncbi-blast`, be implemented in a different language , or if another approach to packaging Blast+ should be used instead.

  Blast+ build process is powered by a set of hand written Makefiles and shell scripts. They call various coreutils and other tools during the build time, but some of those tools are used during run time. It seemed nontrivial to figure out which occurrences of paths to programs are used during the build, which during the run, and which (if any) at both times, so I went with another approach which is both completely automatic and supports cross compilation. (Cross compilation part is not implemented yet.) The idea is to (1) rewrite absolute paths (e.g. `/bin/sh`, `/usr/bin/find`) to the paths of build platform tools before the configure phase, and (2) rewrite paths of build platform tools with paths of host platform tools after the install phase. (Nix approach imposes the unusual burden that build platform paths are different from host platform paths. My solution alleviates it by using one set of paths to programs at a time. It works on the same principle that Nix uses to detect run time dependencies of packages.)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    (`legacy_blast.pl` and `update_blastdb.pl` are not wrapped with perl yet)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: release-17.09: elk: 6.1.1 -> 6.1.2 (includes security fix)
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33962
updated_at: 2018-01-17 00:49:54
body:
  ###### Motivation for this change

  @globin this is the cherry-pick of https://github.com/NixOS/nixpkgs/pull/33959.

  Contains a security fix for kibana: CVE-2018-3818.

  https://www.elastic.co/guide/en/elasticsearch/reference/current/release-notes-6.1.2.html
  https://www.elastic.co/guide/en/logstash/6.1/logstash-6-1-2.html
  https://www.elastic.co/guide/en/kibana/6.1/release-notes-6.1.2.html
  https://www.elastic.co/guide/en/beats/libbeat/6.1/release-notes-6.1.2.html
  (cherry picked from commit e842ffbb334293bd6d83a2b1eb9ae9039af29b43)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: linuxPackages.extfat-nofuse: fix libelf dependency
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33963
updated_at: 2018-01-17 02:41:48
body:
  ###### Motivation for this change

  Added missing backport that is required with the latest 4.14 kernel.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: batman-adv 2017.4
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33964
updated_at: 2018-01-17 02:18:58
body:
  ###### Motivation for this change

  Update to latest stable release of `batman-adv` and the surrounding tools.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [17.09] batman-adv 2017.4
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/33965
updated_at: 2018-01-17 04:15:21
body:
  ###### Motivation for this change

  Update to latest stable point release (and fix compilation with newer kernels).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gateone: fix url
user_login: tomberek
html_url: https://github.com/NixOS/nixpkgs/pull/33966
updated_at: 2018-02-11 08:15:59
body:
  ###### Motivation for this change

  #30636

  ###### Things done

  Updated Homepage URL

  ---


state: closed
title: maintainers: remove mornfall from packages
user_login: yegortimoshenko
html_url: https://github.com/NixOS/nixpkgs/pull/33967
updated_at: 2018-01-19 05:55:51
body:
  This commit removes @mornfall from `meta.maintainers` in all packages. They have not been active for the last three years. I've found their new email address and asked to approve this change.

  The rationale behind this change is to make it clear which packages are maintained, and by whom, and which are not.


state: closed
title: wp-cli: use as much memory as possible
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/33968
updated_at: 2018-01-18 00:16:57
body:
  ###### Motivation for this change

  Instead of imposing an arbitrary memory limit via php.ini, let wp-cli use as
  much as possible. If you need to limit the memory use, there are mechanisms in
  your OS far better suited for this.

  Cc: @grahamc 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: attrsOf.check = isAttrs
user_login: ledettwy
html_url: https://github.com/NixOS/nixpkgs/issues/33969
updated_at: 2018-01-17 05:59:35
body:
  lib.types.attrsOf.check is not fully implemented. Should actually check if a given attrset is an attrset of the listed type.


state: closed
title: [WIP] anbox: init at 2018-01-06
user_login: lukeadams
html_url: https://github.com/NixOS/nixpkgs/pull/33970
updated_at: 2018-05-30 05:37:13
body:
  ###### Motivation for this change
  pr for tracking

  Anbox allows execution of Android apps within a lxc namespace on the host kernel.
  Requires `binder` and `ashmem` kmods (included in src), in addition to application of kernel patches.

  Probably need to add a NixOS module for this eventually.

  Needed to add dbus-cpp (not the same as dbus-cplusplus) and a few other libraries.

  ~currently library commits are after Anbox, need to rebase~
  _Rebased as much as possible (now anbox init is after deps). Still need to reorder to be in the following order for bisectability:_
  1. libproperties
  2. libprocess
  3. dbus-cpp

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: salt: Prefer to load Nix libcrypto
user_login: aneeshusa
html_url: https://github.com/NixOS/nixpkgs/pull/33971
updated_at: 2018-04-21 19:42:28
body:
  Prefer to load the static Nix version,
  but still fallback to the normal loading pathway if needed.

  Being more aggressive about using the Nix dependency
  improves stability and means Salt works more often,
  namely in cases where find_library/LoadLibrary don't work
  even though we have the Nix libcrypto available.

  We still need to keep the fallback for usage with salt-ssh.

  ###### Motivation for this change

  Better fix than what was in #29020.
  See also #29723 cc @danbst.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: python2.7: Return full path from find_library
user_login: aneeshusa
html_url: https://github.com/NixOS/nixpkgs/pull/33972
updated_at: 2018-11-15 16:35:17
body:
  ###### Motivation for this change

  Fixes #7307. (Also fixes #33971 in a different way; would love to get both patches in.)

  The [upstream cpython patch](https://bugs.python.org/issue21042) to implement this behavior got reverted as it caused issues on some niche platforms, but I think Nixpkgs can punt on those issues for now.

  cc @edolstra and @FRidh who have put in patches around Python's find_library previously.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: release-17.09: elk: 5.6.5 -> 5.6.6 (security fix)
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/33973
updated_at: 2018-01-17 12:10:56
body:
  ###### Motivation for this change

  @globin this is a cherry-pick of https://github.com/NixOS/nixpkgs/pull/33960.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gutenberg: init at 0.3.1
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/33975
updated_at: 2018-02-28 14:05:46
body:
  ###### Motivation for this change

  Reboot of #30737.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oraclejdk: 8u151, 8u152, 9.0.1 -> 8u161, 8u162, 9.0.4 [Critical security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/33976
updated_at: 2018-01-17 14:15:58
body:
  ###### Motivation for this change

  - Critical security fixes.
  - Other fixes and changes.

  http://www.oracle.com/technetwork/java/javase/9-0-4-relnotes-4021191.html
  http://www.oracle.com/technetwork/java/javase/8u161-relnotes-4021379.html
  http://www.oracle.com/technetwork/java/javase/8u162-relnotes-4021436.html
  http://www.oracle.com/technetwork/security-advisory/cpujan2018-3236628.html#AppendixJAVA

  BTW, could you also merge #31552?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pytestrunner: 2.6.2 -> 3.0
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/33977
updated_at: 2018-02-08 11:01:01
body:
  Also add missing dependency to progressbar2

  ~Not yet tested whether this solves the issue, build still running~
  `progressbar2` build fine now.

  Those 501+ rebuilds are a little scary.
  Is a test via `nox-review` sufficient? But I fear such a test would take days on my machine.

  ###### Motivation for this change
  See #33920.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @ashgillman @FRidh 


state: closed
title: mbuffer: 20170806 -> 20171011
user_login: tokudan
html_url: https://github.com/NixOS/nixpkgs/pull/33978
updated_at: 2018-01-17 15:43:49
body:
  ###### Motivation for this change

  Version update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: oraclejre: 9.0.1 -> 9.0.4 [Critical security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/33979
updated_at: 2018-01-17 14:14:52
body:
  ###### Motivation for this change

  Sorry, I forgot to update JREs: #33976.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-vendor: Build from source using carnix
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/33980
updated_at: 2018-02-03 10:28:58
body:
  ###### Motivation for this change

  Build cargo-vendor from source #32254

  So I can try to build firefox on aarch64.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I had a go at building `cargo-vendor` using carnix and buildRustCrate. There are a few awkward things here I'd like to tidy, flagged with "TODO" in the source.

  - `crateOverrides` in the [documentation][rust.md] suggests that you can override any attribute, with an example for `postPatch`, but my `preBuild` hook was ignored. I very crudely added it, but I don't know how it should work.

  - The inference for the source file for a `[[bin]]` section in a `Cargo.toml` file doesn't seem to match cargo. I couldn't find it in the documentation, but the [tests][cargo tests] suggest that the expected location for `foo` is `src/bin/foo.rs`, while accepting `src/main.rs`  with a warning. However in `buildRustCrate`, only `src/main.rs` is checked.

  - `cargo-vendor` itself needs to emit a binary called `cargo-vendor` to be a `cargo` subcommand, but it defaults to `cargo_vendor`.

  - The `src` attribute for the main target is not optional when using `carnix`, defaulting to `./.`. The crate we're building `cargo-vendor`, is in crates.io, and could be fetched with the same logic as the rest of the dependencies. What's preferred here?

  [rust.md]: https://github.com/NixOS/nixpkgs/blob/f297ddb5c97b23756c2a0685536edffeb20720c4/doc/languages-frameworks/rust.md

  [cargo tests]: https://github.com/rust-lang/cargo/blob/5763451096449580e18eadcc9f62278b665f4276/tests/build.rs#L1431-L1449


state: closed
title: initrd cryptsetup bloat: thin-provisioning-tools references boost-dev
user_login: clefru
html_url: https://github.com/NixOS/nixpkgs/issues/33981
updated_at: 2018-02-11 13:08:26
body:
  ## Issue description
  Using cryptsetup in the initrd sucks in the lvm2 dependency which sucks in thin-provisioning which sucks in boost-dev. Investigating the last links shows that thin-provision mentions a .hpp file of boost-dev in its binaries.

  $ strings thin_rmap | grep fl2bqzgij4ky6g84q2zfz40ypai4993c
  /nix/store/fl2bqzgij4ky6g84q2zfz40ypai4993c-boost-1.66_0-dev/include/boost/smart_ptr/shared_ptr.hpp

  Scrubbing this reference should cut the size of my initrd from wooping 77mb to half.

  ### Steps to reproduce
  Build an initrd with luks support

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.13, NixOS, 18.03.git.6e84522 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - nixpkgs: `/nix/nixpkgs`


state: closed
title: gitHUD: disable tests
user_login: jlesquembre
html_url: https://github.com/NixOS/nixpkgs/pull/33982
updated_at: 2018-01-19 17:04:48
body:
  [gitHUD](https://github.com/gbataille/gitHUD) tests require tasty-quickcheck ==0.8.*

  ###### Motivation for this change

  Tries to fix #33807 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hypothesis-python: 3.11.1 -> 3.27.0
user_login: va1entin
html_url: https://github.com/NixOS/nixpkgs/pull/33983
updated_at: 2018-01-20 15:58:54
body:
  ###### Motivation for this change
  I wanted to update PyNaCl in Nixpkgs, but it's tests require this version of hypothesis. I chose 3.27.0 because that's the earliest one with the features needed by pynacl.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). - no maintainer, fits otherwise

  ---


state: closed
title: Skip rebuilding VirtualBox?
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/33984
updated_at: 2018-02-15 18:50:45
body:
  ## Issue description
  When VirtualBox is part of the system configuration, it can take a long time to build from source. When one of the dependencies is updated, it's rebuild, but what is a good way or perhaps workflow to only rebuild VirtualBox when I actually want to. I haven't wanted to upgrade VirtualBox for a long time.


state: closed
title: WIP: hydra: enable darwin build on 2017-11-21
user_login: periklis
html_url: https://github.com/NixOS/nixpkgs/pull/33985
updated_at: 2018-07-25 09:20:38
body:
  ###### Motivation for this change
  Enable hydra builds on macOS to support darwin-based ecosystem. Currently WIP, because of:
  ```
  /nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/bash ../../libtool  --tag=CXX   --mode=link clang++ -I/nix/store/x2r5fphb4gh7jp7brkfd92va40yp9hy0-boehm-gc-7.6.0-dev/include -I/nix/store/j72w
  hnasj6hx49ipnjpc844ndr1b13mz-nix-unstable-1.12pre5849_74f75c85-dev/include/nix -Wall -I ../libhydra -g -O2 -std=c++17 -include nix/config.h   -o hydra-queue-runner hydra_queue_runner-hydra-queue-runner.o
   hydra_queue_runner-queue-monitor.o hydra_queue_runner-dispatcher.o hydra_queue_runner-builder.o hydra_queue_runner-build-result.o hydra_queue_runner-build-remote.o -L/nix/store/5a8601rl5434yaffvs6vlrvzf
  z7qi730-boehm-gc-7.6.0/lib -L/nix/store/d7x3mh58yr5x913d172jl45zqw6ah19z-nix-unstable-1.12pre5849_74f75c85/lib -lnixmain -lnixexpr -lgc -lnixstore -lnixutil -lnixformat -lpqxx                           
  libtool: link: clang++ -I/nix/store/x2r5fphb4gh7jp7brkfd92va40yp9hy0-boehm-gc-7.6.0-dev/include -I/nix/store/j72whnasj6hx49ipnjpc844ndr1b13mz-nix-unstable-1.12pre5849_74f75c85-dev/include/nix -Wall -I ..
  /libhydra -g -O2 -std=c++17 -include nix/config.h -o hydra-queue-runner hydra_queue_runner-hydra-queue-runner.o hydra_queue_runner-queue-monitor.o hydra_queue_runner-dispatcher.o hydra_queue_runner-build
  er.o hydra_queue_runner-build-result.o hydra_queue_runner-build-remote.o  -L/nix/store/5a8601rl5434yaffvs6vlrvzfz7qi730-boehm-gc-7.6.0/lib -L/nix/store/d7x3mh58yr5x913d172jl45zqw6ah19z-nix-unstable-1.12p
  re5849_74f75c85/lib -lnixmain -lnixexpr /nix/store/5a8601rl5434yaffvs6vlrvzfz7qi730-boehm-gc-7.6.0/lib/libgc.dylib -L/nix/store/3v14j0vgq7iiwvwx8zllzzw9fx2ykasx-libatomic_ops-7.6.0/lib -lpthread -lnixsto
  re -lnixutil -lnixformat -lpqxx                                                                                                                                                                           
  Undefined symbols for architecture x86_64:
    "void nix::toJSON<std::__1::atomic<unsigned long long> >(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, std::__1::atomic<unsigned long long> const&)", referenced from:
        State::dumpStatus(Connection&, bool) in hydra_queue_runner-hydra-queue-runner.o
  ld: symbol(s) not found for architecture x86_64
  clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
  ``` 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Elixir: 1.6-rc -> 1.6
user_login: ankhers
html_url: https://github.com/NixOS/nixpkgs/pull/33986
updated_at: 2018-01-18 01:59:42
body:
  ###### Motivation for this change

  New Elixir version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Only english language available in plasma regional settings
user_login: ghost
html_url: https://github.com/NixOS/nixpkgs/issues/33987
updated_at: 2018-05-31 15:26:07
body:
  ## Issue description
  Only english language available in plasma regional settings, but all locales generated.

  ![nixos](https://user-images.githubusercontent.com/29430720/35066325-425c3bfa-fbe1-11e7-9d47-87e9e8eab85b.png)

  ### Steps to reproduce
  1. Open system settings.
  2. Open regional settings.

  ## Technical details
  ```
  - system: `"x86_64-linux"`
   - host os: `Linux 4.9.76, NixOS, 17.09.2754.66b4de79e38 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
  ```


state: closed
title: Fixup debian-patches script, use to fix dead patch URL's
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/33988
updated_at: 2018-01-21 17:40:58
body:
  Mostly I was interesteing in using the debian-patches script,
  but it references the long-dead patch-tracker.

  This "fixes" the script to get patches via sources.debian.org
  but I'm not sure how stable those URL's are.

  Hopefully the answer is "very".

  Patches fixed here are currently dead anyway,
  so at least this way they live for a bit longer.



  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qt510-qtbase: fix darwin build
user_login: LnL7
html_url: https://github.com/NixOS/nixpkgs/pull/33989
updated_at: 2018-01-20 20:01:55
body:
  ###### Motivation for this change

  Includes most of the changes from 37933209588792db24104dbfaef0106c3bef870d,
  moved it to a separate patch to avoid accidental removal.

  Only tested qtbase, but everything else worked fine with the qt510 update.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
user_login: jpotier
html_url: https://github.com/NixOS/nixpkgs/issues/33990
updated_at: 2018-02-04 18:08:15
title:
  nixos-install fails with error: path '/nix/store/gy4yv67gv3j6in0lalw37j353zdmfcwm-nix-1.11.16' is not valid

body:
  ## Issue description

  `nixos-install` fails with `error: path '/nix/store/gy4yv67gv3j6in0lalw37j353zdmfcwm-nix-1.11.16' is not valid`

  ### Steps to reproduce

  Follow the instructions there: https://nixos.wiki/wiki/Install_NixOS_on_Online.Net
  to bootstrap nixos from Ubuntu 16.04.3 LTS (xenial) x86_64

  Used to run without troubles. I suspect something changed with recent nix.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.4.0-97-generic, Ubuntu, 16.04.3 LTS (Xenial Xerus)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2754.66b4de79e38"`
   - channels(eeva): `"nixos-17.09.2754.66b4de79e38"`
   - nixpkgs: `/root/.nix-defexpr/channels/nixos`

  ### Fail log

  http://lpaste.net/2901932243096174592


state: closed
title: aria2 module not working
user_login: spiderbit
html_url: https://github.com/NixOS/nixpkgs/issues/33991
updated_at: 2018-01-31 01:43:09
body:
  Is it possible that somebody forgot to put the aria2.nix line into nixos/modules/module-list.nix

  I can't use:
  `services.aria2.enable = true;`

  and I don't see aria2 entry in module-list-nix

  when I try to rebuild I get:
  `error: The option services.aria2' defined in /etc/nixos/configuration.nix' does not exist.`


state: closed
title: buildbot: 0.9.11 -> 0.9.15.post1
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/33992
updated_at: 2018-02-03 09:06:26
body:
  ###### Motivation for this change

  Updates buildbot to 0.9.15.post1.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [request] readline module
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/33993
updated_at: 2018-02-22 09:29:28
body:
  ## Issue description
  I have improved my local inputrc and was looking to merge the changes systemwide but I couldn't find a way to do so. I looked as how to change /etc/inputrc but it doesn't seem possible right now:
  https://nixos.org/nixos/options.html#readline returns no result.
  A quick grep shows `nixos/modules/programs/bash/inputrc` but my understanding is that inputrc is a readline file and not bash so it could deserve a separate module (with enhanced vi mode/emacs mode)


  ## Technical details

  nixos-unstable


state: closed
title: Idris doesn't have Builtins or Prelude packages available
user_login: changlinli
html_url: https://github.com/NixOS/nixpkgs/issues/33994
updated_at: 2018-07-13 00:52:03
body:
  ## Issue description

  When I run `idris` I get the following message:

  ```
   Can't find import Builtins
   Can't find import Prelude
       ____    __     _                                          
      /  _/___/ /____(_)____                                     
      / // __  / ___/ / ___/     Version 1.2.0
    _/ // /_/ / /  / (__  )      http://www.idris-lang.org/      
   /___/\__,_/_/  /_/____/       Type :? for help               

  Idris is free software with ABSOLUTELY NO WARRANTY.            
  For details type :warranty.
  ```

  The crucial part is the first two lines, which means that I don't have the ability to actually use any of standard library (e.g. `1 + 1` fails out).

  This appears to be something akin to #7014 popping up again.

  It also looks like asking Idris to list the available libraries blows up.

  ```
  idris --listlibs
  Uncaught error: /nix/store/y75ay6zfi5l20zkqnld1q81zw0arsfbg-idris-1.2.0-data/share/ghc-8.2.2/x86_64-linux-ghc-8.2.2/idris-1.2.0/libs/: getDirectoryContents:openDirStream: does not exist (No such file or directory)
  ```


  ### Steps to reproduce

  Install the `haskellPackages.idris` package. Then run `idris` from the command line. You should see the `Can't find import Builtins...` message.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 18.03.git.3a763b9 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `""`
   - nixpkgs: `/etc/nixos/nixpkgs`
  ```

  Note that version of `nixpkgs` being used is in the `host os` name, 3a763b91963ef747b188e7062d7a02119d2ef6d3 


state: closed
title: freetype: 2.7.1 -> 2.9
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/33995
updated_at: 2018-03-16 13:25:44
body:
  ###### Motivation for this change
  Version bump from 2.7.1 to 2.9, also allows us to get rid of some of these patches that have now been rolled into the repo directly.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: acme-client: init at 0.1.6
user_login: pmahoney
html_url: https://github.com/NixOS/nixpkgs/pull/33996
updated_at: 2018-02-25 04:50:03
body:
  ###### Motivation for this change

  Add [acme-client](https://kristaps.bsd.lv/acme-client/) package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gprof2dot does not run when installed with nix-env (ImportError: No module named gprof2dot)
user_login: andersk
html_url: https://github.com/NixOS/nixpkgs/issues/33997
updated_at: 2018-01-18 08:41:34
body:
  ## Issue description

  `gprof2dot` runs correctly inside `nix-shell -p gprof2dot`. But if it’s installed with `nix-env -iA nixos.gprof2dot`, it fails with `ImportError: No module named gprof2dot`.

  The relevant difference is that `nix-shell` puts `/nix/store/fd6g76g205clp2m3mjs13k1gqknw6sf0-gprof2dot-2015-04-27/site-packages` in `PYTHONPATH`. Presumably this should be taken care of by the binary wrapper, but isn’t.

  ### Steps to reproduce

  This works:

  ```
  $ nix-shell -p gprof2dot --run 'gprof2dot --help'
  Usage: 
          gprof2dot [options] [file] ...
  ```

  This does not:

  ```
  $ nix-env -iA nixos.gprof2dot
  installing ‘gprof2dot-2015-04-27’

  $ gprof2dot --help
  Traceback (most recent call last):
    File "/nix/store/fd6g76g205clp2m3mjs13k1gqknw6sf0-gprof2dot-2015-04-27/bin/.gprof2dot-wrapped", line 8, in <module>
      from gprof2dot import main
  ImportError: No module named gprof2dot
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.13, NixOS, 17.09.2731.92d088e891e (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2731.92d088e891e, nixos-unstable-18.03pre123130.1bc288591ea"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: pypy: 5.9.0 -> 5.10.0
user_login: andersk
html_url: https://github.com/NixOS/nixpkgs/pull/33998
updated_at: 2018-01-18 18:53:52
body:
  ###### Motivation for this change

  PyPy 5.10.0 was released on 2017-12-25.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Note: gprof2dot, which depends on pypy, compiles but fails to run outside of nix-shell; this is a pre-existing issue that I’ve reported as #33997.


state: closed
title: innoextract: support extraction of multi-file archives
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/33999
updated_at: 2018-10-08 01:24:38
body:
  ###### Motivation for this change

  innoextract supports a ```--gog``` argument which will process extra multi-file archives distributed by gog.com

  A slight downside is the increase of the closure size from 76MB to 1.4GB so we can of course make the ```withGog``` argument ```false``` instead by default.

  Cc: @abbradar 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Virtmanager fails to launch
user_login: sjau
html_url: https://github.com/NixOS/nixpkgs/issues/34000
updated_at: 2018-01-29 01:27:03
body:
  ## Issue description

  For a few days (maybe 2 weeks or so), virtmanager refuses to start.

  Starting from Kicker the icons shows up for a short while, then disappears.

  Starting from the terminal I get this feedback:

  ```
  virt-manager
  Traceback (most recent call last):
    File "/nix/store/4kl3dca1vrci6hhipnn1l699k662szbv-virt-manager-1.4.3/share/virt-manager/virt-manager", line 32, in <module>
      gi.require_version('LibvirtGLib', '1.0')
    File "/nix/store/p6fnhmmvr28ziv19c37hr9n6vkcy25an-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/__init__.py", line 130, in require_version
      raise ValueError('Namespace %s not available' % namespace)
  ValueError: Namespace LibvirtGLib not available
  ```

  ### Steps to reproduce

  Use Nixos Unstable and add virtmanager to the list of system installed packages.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.13, NixOS, 18.03pre125130.3a763b91963 (Impala)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(hyper): `"nixos-18.03pre123638.1258d9a4914"`
   - channels(root): `"nixos-18.03pre125130.3a763b91963"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: netcat-openbsd: out of date
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/34002
updated_at: 2018-01-18 15:31:08
body:
  ## Issue description
  Debian already has https://packages.debian.org/sid/netcat-openbsd. 

  NixOS 17.09 and master suffer from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870240


state: closed
title: Wireshark 2.4.4 build broken
user_login: aKriJcz
html_url: https://github.com/NixOS/nixpkgs/issues/34003
updated_at: 2018-02-01 07:58:54
body:
  ## Issue description
  Package wireshark-gtk is broken after update to version 2.4.4.

  Brief output with warnings:
  ```
  ...
  CMake Warning at CMakeLists.txt:444 (find_package):
    By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "Qt5Core", but
    CMake did not find one.

    Could not find a package configuration file provided by "Qt5Core" with any
    of the following names:

      Qt5CoreConfig.cmake
      qt5core-config.cmake

    Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
    "Qt5Core_DIR" to a directory containing one of the above files.  If
    "Qt5Core" provides a separate development package or SDK, be sure it has
    been installed.

  ...

  CMake Error at CMakeLists.txt:947 (find_package):
    By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "Qt5Core", but
    CMake did not find one.

    Could not find a package configuration file provided by "Qt5Core" with any
    of the following names:

      Qt5CoreConfig.cmake
      qt5core-config.cmake

    Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
    "Qt5Core_DIR" to a directory containing one of the above files.  If
    "Qt5Core" provides a separate development package or SDK, be sure it has
    been installed.


  -- Configuring incomplete, errors occurred!
  ...
  ```

  ### Steps to reproduce

  Updated system (nixos-rebuild switch --upgrade) with wireshark-gtk in installed packages.

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.76, NixOS, 17.09.2731.92d088e891e (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.2799.d9a2891c32e"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

  ## Temporary fix
  I had to revert to previous version 2.4.2 with configuration override:
  ```
  wireshark-gtk = super.wireshark-gtk.overrideAttrs (oldAttrs: let
    version = "2.4.2";
  in rec {
    name = "wireshark-gtk-${version}";
    src = super.fetchurl {
      url = "http://www.wireshark.org/download/src/all-versions/wireshark-${version}.tar.xz";
      sha256 = "0zglapd3sz08p2z9x8a5va3jnz17b3n5a1bskf7f2dgx6m3v5b6i";
    };
  });
  ```


state: closed
title: netcat-openbsd: 1.130 -> 1.187
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/34004
updated_at: 2018-01-18 15:30:06
body:
  fixes #34002

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Oracle JDK 8 gets upgraded to Oracle JDK 9 on `nix-env -u`
user_login: phdoerfler
html_url: https://github.com/NixOS/nixpkgs/issues/34005
updated_at: 2018-01-25 15:25:41
body:
  ## Issue description & Steps to reproduce

  Install Oracle JDK 8:

      $ nix-env -i oraclejdk-8u151

  Accept license etc… wait a few days until a new update to 8 is out. Show that no other JDK is installed other than 8:

      $ nix-env -q | grep oracle
      oraclejdk-8u151

  Now upgrade all packages:

      $ nix-env -u

  nix tries to install oracle JDK *9*:

  ```
  Unfortunately, we cannot download file jdk-9.0.4_linux-x64_bin.tar.gz automatically.
  Please go to http://www.oracle.com/technetwork/java/javase/downloads/jdk9-downloads-3848520.html to download it yourself, and add it to the Nix store
  using either
    nix-store --add-fixed sha256 jdk-9.0.4_linux-x64_bin.tar.gz
  or
    nix-prefetch-url --type sha256 file:///path/to/jdk-9.0.4_linux-x64_bin.tar.gz

  ```

  Since I explicitly installed JDK 8 and not 9 I expect nix to only upgrade JDK 8 to a newer version of JDK 8 (e.g. from `8u151` to `8u161`).

  ## Technical details

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.77, NixOS, 17.09.2799.d9a2891c32e (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.16`
   - channels(philipp): `""`
   - channels(root): `"nixos-17.09.2799.d9a2891c32e"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

  ```


state: open
title: Avoid kernel sources reference in a kernel module closure
user_login: nlewo
html_url: https://github.com/NixOS/nixpkgs/issues/34006
updated_at: 2018-01-18 14:58:08
body:
  I build a kernel module by using `pkgs.linuxPackages.kernel.dev` to provide kernel sources. The output path of the built module have a reference to the output path of `pkgs.linuxPackages.kernel.dev` because there is occurrences of the `pkgs.linuxPackages.kernel.dev` hash in the module binary.

  This is because the build Makefile in the kernel source (`/nix/store/8isavlq67qrhd9xqb672h4p4waymyj24-linux-4.9.49-dev/lib/modules/4.9.49/build/Makefile`) contains an occurence to the hash:
  ```
  MAKEARGS := -C /nix/store/8isavlq67qrhd9xqb672h4p4waymyj24-linux-4.9.49-dev/lib/modules/4.9.49/source
  ```

  As a workaround, I'm copying kernel sources and patching this Makefile to change this path before building the module. The module works well and there is no more dependencies.

  I don't know what is the good way to avoid this useless dependencies.
  Is it possible to explicitly remove references of a derivation?
  Or is there a parameter at module build time to avoid this?


state: closed
title: weka: 3.8.1 -> 3.8.2
user_login: mimadrid
html_url: https://github.com/NixOS/nixpkgs/pull/34007
updated_at: 2018-01-18 14:45:49
body:
  ###### Motivation for this change

  Update weka to the last version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sshd: provide option to disable firewall altering
user_login: lschuermann
html_url: https://github.com/NixOS/nixpkgs/pull/34008
updated_at: 2018-10-14 09:28:35
body:
  ###### Motivation for this change
  It probably is a good thing, that sshd opens it's ports automatically. In the current state this however also means, that there is no way to manually close these ports again. This PR therefore provides an option to disable automatic opening of sshd ports, if one would want so.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: git: 2.15.1 -> 2.16.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/34009
updated_at: 2018-01-18 15:03:19
body:
  Release notes:
  https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.16.0.txt




  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Update notes:
  * small fixup to ssh-path patch
  * drop send-email PATH patch,
    it is searched by default now
    (although after builtin paths)


state: closed
title: Cannot build Telegram on unstable
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/issues/34010
updated_at: 2018-01-21 15:36:32
body:
  ## Issue description

  Telegram does not build on unstable:

  ```

  [  1%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/common/basic_tokenized_file.o
  [  1%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/common/checked_utf8_string.o
  [  1%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/common/clean_file.o
  [  1%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/common/cpp_file.o
  [  2%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/common/logging.o
  [  2%] Building CXX object CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/lang/generator.o
  In file included from /tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/out/Release/../../Telegram/SourceFiles/codegen/lang/generator.h:30:0,
                   from /tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/lang/generator.cpp:21:
  /tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/out/Release/../../Telegram/SourceFiles/codegen/lang/parsed_file.h:27:18: fatal error: QImage: No such file or directory
   #include <QImage>
                    ^
  compilation terminated.
  make[2]: *** [CMakeFiles/codegen_lang.dir/build.make:183: CMakeFiles/codegen_lang.dir/tmp/nix-build-telegram-desktop-1.1.23.drv-0/tdesktop/Telegram/SourceFiles/codegen/lang/generator.o] Error 1
  make[1]: *** [CMakeFiles/Makefile2:409: CMakeFiles/codegen_lang.dir/all] Error 2
  make: *** [Makefile:84: all] Error 2
  ```

  ### Steps to reproduce

  Install `telegram` on latest unstable.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.12, NixOS, 18.03pre124947.33a4de2941d (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-18.03pre125750.a6dca042722"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: platformio: 3.5.0 -> 3.5.1
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/34011
updated_at: 2018-01-18 15:40:10
body:
  ###### Motivation for this change
  New version released today, I noticed they refactored out the python code, so excellent chance to reduce the package size.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: No audio with tor-browser-bundle-bin-7.0.11
user_login: unode
html_url: https://github.com/NixOS/nixpkgs/issues/34012
updated_at: 2018-01-19 22:09:06
body:
  ## Issue description
  Was using tor-browser-bundle-bin-7.0.7 based on firefox 52.4. Everything worked as expected once using:
  ```
  torbrowserWithAudio = pkgs.torbrowser.override {
        audioSupport = true;
        mediaSupport = true;
      };
  ```
  Upgraded to tor-browser-bundle-bin-7.0.11 based on firefox 52.5. Video is still present but audio is gone.
  I also see the bar-pop-up informing that I should have pulseaudio to play audio.

  I don't have pulseaudio on the system and at least with 7.0.7 everything worked fine.
  I'm aware that the pulseaudio issue has more to do with Firefox but I was under the impression that the pulseaudio-only change was introduced with Firefox 52.0, meaning 52.4 should already be affected but it seems like it wasn't. Not sure how it works there...

  On another system I've managed to use `apulse` to have sound without pulseaudio. This required [patching](https://github.com/i-rinat/apulse#per-app-rpath-trick) one of the libs in Firefox.
  Could something like this be made available in the nix expression so we could have:
  ```
  torbrowserWithAudio = pkgs.torbrowser.override {
        audioSupport = true;
        useApulseAudioWorkaround = true;
        mediaSupport = true;
      };
  ```
  ----

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.9.75, NixOS, 17.09.git.2223d06 (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `"nixos-17.09.1547.2231575a7d"`
   - channels(unode): `"nixos-unstable-18.03pre117690.ab2cc75f78"`
   - nixpkgs: `/var/nixpkgs-channels/nixos-17.09`
  ```


state: closed
title: linuxPackages.perf doesn't build on unstable
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/34013
updated_at: 2018-01-22 17:28:06
body:
  First failing build (4.9.76, but not always): https://hydra.nixos.org/build/67694283
  Latest (4.9.77): https://hydra.nixos.org/build/67712846/nixlog/1

  Looking through the changes for any obvious culprits...


state: closed
title: mathematica: enable installation of localized editions
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/34014
updated_at: 2018-06-13 14:12:35
body:
  ###### Motivation for this change

  Mathematica has many localized editions, e.g. Japanese edition, which I want to install.
  This PR aims to make it easier to add such localized editions.

  For now English (default) and Japanese editions only.
  Fill out information in `l10ns.nix` to add the other localized editions.
  Example usage: `mathematica.override { lang = "ja"; }` derives Japanese edition.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python-telegram-bot: init at 9.0.0
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/34015
updated_at: 2018-04-15 22:35:06
body:
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perf-tools: 20160418 -> 20171219
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/34016
updated_at: 2018-01-21 17:41:05
body:
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix build of linuxPackages.perf
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/34017
updated_at: 2018-01-19 20:00:42
body:
  It should build, but it doesn't.

  https://github.com/NixOS/nixpkgs/issues/34013


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fetchpatch: Add support for an arbitrary extra prefix
user_login: Ericson2314
html_url: https://github.com/NixOS/nixpkgs/pull/34018
updated_at: 2018-01-18 17:39:42
body:
  ###### Motivation for this change

  I need this to patch a cloned submodule from upstream for https://github.com/NixOS/nixpkgs/pull/26799

  We still ensure the old and new ones start, respectfully, with `a/` and `b/`. Use with `stripLen` to ensure tha the old `a/` and `/b` are gone if a new prefix is added.

  ###### Things done

  I checked (disabling cached builds) that existing uses with or without `addPrefixes = true` still have the same hash.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dnsmasq module: test config on system build
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/34019
updated_at: 2019-01-18 18:31:17
body:
  ###### Motivation for this change
  This allows catching issues with the configuration earlier on
  (previously config errors would only be caught at unit start time), and
  reduces the chance of painful outages. The method isn't 100% reliable
  (see comment) but it should be a significant improvement already.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I would like to write a test for this but I don't know of a way to assert that a derivation fails to build. Suggestions welcome!


state: closed
title: linux-steam-integration: Append "Settings" to launcher menu item
user_login: benley
html_url: https://github.com/NixOS/nixpkgs/pull/34020
updated_at: 2018-01-24 18:26:53
body:
  ###### Motivation for this change

  It just shows up as "Linux Steam Integration" otherwise, which is confusing.  The actual LSI launcher's name in the menu is "LSI Steam", right next to this one.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: boomerang: switch to new active fork, cleanup, maintain
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/34021
updated_at: 2018-02-10 15:57:25
body:
  Fixes many bugs and GUI doesn't have missing icons, etc.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update Shibboleth Service Provider Packages
user_login: jammerful
html_url: https://github.com/NixOS/nixpkgs/pull/34022
updated_at: 2018-01-19 23:42:14
body:
  ###### Motivation for this change

  There are a few known vulnerabilities in the current version of shibboleth-sp, opensaml-cpp, and xml-tooling-c as noted in this issue: #33875

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: GHC 8.4: compiler and package fixes
user_login: deepfire
html_url: https://github.com/NixOS/nixpkgs/pull/34023
updated_at: 2018-01-23 10:19:08
body:
  ###### Motivation for this change
  This provides GHC 8.4.1-alpha in Nixpkgs, along with many necessary package overrides.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Packaging request: Sayonara music player
user_login: deepfire
html_url: https://github.com/NixOS/nixpkgs/issues/34024
updated_at: 2018-02-19 19:16:38
body:
  ## Issue description

  Package http://sayonara-player.com/index.php

  Why:
  - it has an interesting library management UI
  - has useful filesystem-based library view
  - generally nice-looking

  Dependencies:
  - quoting http://sayonara-player.com/howto-build.php
  ```
  sudo apt-get install git cmake libgstreamer-plugins-bad-1.0-dev libgstreamer-plugins-base1.0-dev libgstreamer1.0-dev libtag1-dev pkg-config qtbase5-dev qttools5-dev qttools5-dev-tools zlib1g-dev 
  ```
  - summary:  gstreamer, libtag, QT 5, zlib


state: closed
title: minio: 2018-01-02T23-07-00Z -> 2018-01-18T20-33-21Z (Critical Security Update)
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/34025
updated_at: 2018-01-19 17:43:28
body:
  ###### Motivation for this change

  **Critical security fix** that fixes an issue that allows
  bypassing authentication.

  See: https://blog.minio.io/minio-release-jan-18-2018-security-advisory-4c64ca87721b

  @grahamc @ckauhaus Should be backported to stable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: No way to define the broadcast address for statically configured interfaces
user_login: michalrus
html_url: https://github.com/NixOS/nixpkgs/issues/34026
updated_at: 2018-05-11 21:05:33
body:
  ## Issue description

  So here:

  https://github.com/NixOS/nixpkgs/blob/1dade8665a6d38fbab757f336aea1010ce1c811f/nixos/modules/tasks/network-interfaces.nix#L98-L117

  … we have no way to define the broadcast address for the interface.

  ### Steps to reproduce

  In `configuration.nix`:

  ```nix
  {
    networking.interfaces.wlan0.ip4 = [{ address = "10.77.4.1"; prefixLength = 24; }];
  }
  ```

  And now the broadcast is set to `0`:

  ```
  # ifconfig wlan0 | head -2
  wlan0     Link encap:Ethernet  HWaddr 00:AA:AB:03:1C:D5
            inet addr:10.77.4.1  Bcast:0.0.0.0  Mask:255.255.255.0
  ```

  … which makes the machine **not** respond to ARP requests, which is very bad if it’s a local network software router or similar.

  @srhb suggests to use `networking.localCommands` to set it up yourself for now (thank you!).

  ## Technical details

   - system: `"armv7l-linux"`
   - host os: `Linux 4.14.0, NixOS, 18.03.git.b8f7027360 (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.15`
   - channels(root): `"nixos-18.03.git.b8f7027360"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: Plasma5 forces "breeze" theme for SDDM
user_login: va1entin
html_url: https://github.com/NixOS/nixpkgs/issues/34027
updated_at: 2018-02-15 19:57:25
body:
  ## Issue description
  When using Plasma5 as desktop manager, it is impossible to set a theme for SDDM via services.xserver.displayManager.sddm.theme because "breeze" is hard-coded in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/x11/desktop-managers/plasma5.nix on line 194-196

  I am not sure, if there is a technical reason why "breeze" is hard-coded there, but if there isn't, it shouldn't be.


  ### Steps to reproduce
  Set
  `  services.xserver.desktopManager.plasma5.enable = true;
  `
  and 
  `services.xserver.displayManager.sddm.theme = "maledives";` or any other pre-installed SDDM theme

  `nixos-rebuild`

  `error: The unique option services.xserver.displayManager.sddm.theme is defined multiple times, in /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs/nixos/modules/services/x11/desktop-managers/plasma5.nix and /etc/nixos/configuration.nix.
  `

  ### Technical details

  The option is hard-coded on 17.09 aswell as on master, so I guess this does not matter.


state: closed
title: piwik is now matomo
user_login: florianjacob
html_url: https://github.com/NixOS/nixpkgs/pull/34028
updated_at: 2018-02-26 07:29:07
body:
  ###### Motivation for this change
  For the 3.3.0 release, piwik was renamed to matomo: https://matomo.org/changelog/matomo-3-3-0/

  The release does not contain security fixes it seems, it is mainly the renaming. Not sure what to do when they release subsequent versions with security fixes before NixOS 18.0.3 is out, as they won't be “backported” to the old piwik version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Move packageSourceOverrides to haskellLib
user_login: ElvishJerricco
html_url: https://github.com/NixOS/nixpkgs/pull/34030
updated_at: 2018-01-19 11:39:37
body:
  Just moving a library function. I was doing some work with custom package sets and found myself wanting this in the stages before having the package set constructed.


state: closed
title: wine-stable: 2.0.3 -> 3.0
user_login: ikervagyok
html_url: https://github.com/NixOS/nixpkgs/pull/34031
updated_at: 2018-01-22 22:01:23
body:
  ###### Motivation for this change


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: akonadi fails to build on latest unstable
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/34032
updated_at: 2018-01-19 10:09:42
body:
  ## Issue description

  ```
  /tmp/nix-build-akonadi-17.12.1.drv-0/akonadi-17.12.1/src/server/storage/dbconfigpostgresql.cpp: In member function 'virtual bool Akonadi::Server::DbConfigPostgresql::init(QSettings&)':
  /tmp/nix-build-akonadi-17.12.1.drv-0/akonadi-17.12.1/src/server/storage/dbconfigpostgresql.cpp:72:43: error: 'NIXPKGS_POSTGRES_INITDB' was not declared in this scope
           defaultInitDbPath = QLatin1String(NIXPKGS_POSTGRES_INITDB);
                                             ^~~~~~~~~~~~~~~~~~~~~~~
  /tmp/nix-build-akonadi-17.12.1.drv-0/akonadi-17.12.1/src/server/storage/dbconfigpostgresql.cpp:92:33: error: 'NIXPKGS_POSTGRES_PG_CTL' was not declared in this scope
       mServerPath = QLatin1String(NIXPKGS_POSTGRES_PG_CTL);
                                   ^~~~~~~~~~~~~~~~~~~~~~~
  make[2]: *** [src/server/CMakeFiles/libakonadiserver.dir/build.make:1546: src/server/CMakeFiles/libakonadiserver.dir/storage/dbconfigpostgresql.cpp.o] Error 1
  make[1]: *** [CMakeFiles/Makefile2:1316: src/server/CMakeFiles/libakonadiserver.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....
  ```

  Cc: @gnidorah @adisbladis @bkchr 

  ### Steps to reproduce

  Try to install something that needs akonadi.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.13, NixOS, 18.03.git.9e0c8510f83M (Impala)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 1.11.16`
   - channels(root): `""`
   - channels(peter): `""`
   - nixpkgs: `/home/peter/src/active/nixpkgs_unstable`


state: open
title: nixos-install --chroot option
user_login: CMCDragonkai
html_url: https://github.com/NixOS/nixpkgs/issues/34033
updated_at: 2018-11-16 12:06:59
body:
  Reposting from: https://github.com/NixOS/nixpkgs/commit/186c120bed6b5d4a9b1549159aa567005402000c#commitcomment-26939448

  @copumpkin This --chroot option is a bit strange. It enabled me to rebuild my corrupted boot partition by basically setting up my OS while booted in via USB NixOS distro. However before I could I actually run nixos-rebuild, I needed to create /run/user/0. Perhaps this --chroot option should also do this as well. Otherwise it cannot create the temporary files/directories for running nixos-rebuild.

  I also had to be careful with NIXOS_CONFIG setting (because the configuration.nix) may not be at the default position. And afterwards NIX_PATH when invoking the nixos-rebuild.


state: open
title: [WIP] Rust platform improvements
user_login: Ralith
html_url: https://github.com/NixOS/nixpkgs/pull/34034
updated_at: 2018-06-06 19:10:51
body:
  This enables `rustPlatform` to build crates that have dependencies specified as git repositories. Previously, the cargo config file output of `cargo vendor` was being discarded in favor of a hardcoded config, which was missing the extra sections necessary for non-crates.io dependencies to work.

  Unfortunately, this breaks every single `cargoSha256` in nixpkgs, which will be a huge pain to fix. Better ideas very welcome.


state: closed
title: geis: fix python programs
user_login: jraygauthier
html_url: https://github.com/NixOS/nixpkgs/pull/34036
updated_at: 2018-02-18 16:19:16
body:
  ###### Motivation for this change

  Non working python programs.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Also ran the only dependent program `/szhw3miyaqfxsw2lwkrsz4qdp03hd7vz-touchegg-1.1.1/bin/touchegg` successfully.


state: closed
title: Fixed GHCJS
user_login: ElvishJerricco
html_url: https://github.com/NixOS/nixpkgs/pull/34037
updated_at: 2018-01-21 18:55:26
body:
  ###### Motivation for this change

  - The bindists are [not currently suitable](https://github.com/NixOS/nixpkgs/issues/33815) for bootstrapping GHCJS
  - GHCJS needs to be built with the GHC version it represents
  - The `haddock` library in the package set depends on GHC 8.2's `Cabal` version, so needs to be downgraded.
  - `ghcjsHEAD` has a library dependency on `Cabal` (< 2.0), but needs `cabal-install` (>= 2.0) as a build tool. I think the best way to satisfy this is to just pass `pkgs.cabal-install` as the tool.

  We *should* fix the bindists issue, but that's orthogonal to this PR.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: akonadi: Fixes build
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/34038
updated_at: 2018-01-19 13:39:35
body:
  ###### Motivation for this change
  Fixes: https://github.com/NixOS/nixpkgs/issues/34032

  @peterhoeg @adisbladis 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: calligra: Fixes build
user_login: bkchr
html_url: https://github.com/NixOS/nixpkgs/pull/34039
updated_at: 2018-01-19 16:25:33
body:
  ###### Motivation for this change
  @adisbladis 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: r-data.table is not compiled with OpenMP support on Darwin
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/issues/34040
updated_at: 2018-01-19 11:40:10
body:
  ## Issue description

  On Darwin, clang does not have OpenMP by default. So, data.table is not compiled with OpenMP support.

  ### Steps to reproduce

  ```
  % nix-build -E 'with import <nixpkgs> {}; rWrapper.override { packages = [rPackages.data_table]; }'; and ./result/bin/R -q
  /nix/store/nrm45kyljks3fqc85m37jby17dygc70h-R-3.4.3-wrapper
  > library(data.table)
  data.table 1.10.4.3
  **********
  This installation of data.table has not detected OpenMP support. It should still work but in single-threaded mode. If this is a Mac, please ensure you are using R>=3.4.0 and have installed the MacOS binary package from CRAN: see ?install.packages, the 'type=' argument and the 'Binary packages' section. If you compiled from source, please reinstall and precisely follow the installation instructions on the data.table homepage. This warning message should not occur on Windows or Linux. If it does and you've followed the installation instructions on the data.table homepage, please file a GitHub issue.
  **********
    The fastest way to learn (by data.table authors): https://www.datacamp.com/courses/data-analysis-the-data-table-way
    Documentation: ?data.table, example(data.table) and browseVignettes("data.table")
    Release notes, videos and slides: http://r-datatable.com
  ```

  ## Technical details

  - system: `"x86_64-darwin"`
  - host os: `Darwin 17.4.0, macOS 10.13.3`
  - multi-user?: `yes`
  - sandbox: `no`
  - version: `nix-env (Nix) 1.11.16`
  - channels(mnacamura): `"nixpkgs-18.03pre125635.846b5c42f19, darwin"`
  - channels(root): `"nixpkgs-18.03pre118954.79cf1fca89"`
  - nixpkgs: `/Users/mnacamura/Repos/nixpkgs`


state: closed
title: rPackages.data_table: OpenMP support on Darwin
user_login: mnacamura
html_url: https://github.com/NixOS/nixpkgs/pull/34041
updated_at: 2018-01-19 13:03:10
body:
  ###### Motivation for this change

  Fix #34040

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: su does not retain `XDG_RUNTIME_DIR`
user_login: coretemp
html_url: https://github.com/NixOS/nixpkgs/issues/34042
updated_at: 2018-05-07 02:35:38
body:
  ## Issue description
  I expect to be able to run `systemsettings5` without it displaying that `XDG_RUNTIME_DIR` is not set.

  ```
  Login as a plain user and then do
  $ sudo su - 
  # systemsettings5 
  QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
  ```
  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.13.4, NixOS, 17.09.git.39cd40f (Hummingbird)`
   - multi-user?: `yes`
   - sandbox: `no`
   - version: `nix-env (Nix) 1.11.15`
   - channels(root): `"nixos-17.09.2182.7f6f0c49f0"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`


state: closed
title: Unneeded dependencies of virtmanager
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/issues/34043
updated_at: 2018-02-24 23:45:19
body:
  Since [0.10.0](https://github.com/virt-manager/virt-manager/blob/master/NEWS.md#release-0100-june-19-2013), virtmanager no longer depends on pygtk; it is still listed in the dependencies though. Actually, most of the propagated dependencies are not mentioned anywhere in the virt-manager source code.

  https://github.com/NixOS/nixpkgs/blob/899714ae964c3e446c2de081bf007ef238c9f3d6/pkgs/applications/virtualization/virt-manager/default.nix#L30-L35


state: closed
title: [17.09] fix kernel modules that fail with linux-4.14
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/34044
updated_at: 2018-01-19 14:16:29
body:
  ###### Motivation for this change

  Providing a stable kernel to a stable distribution with stable kernel modules ;-)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix remaining 4.14 libelf outbreak
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/34045
updated_at: 2018-01-19 14:16:32
body:
  ###### Motivation for this change

  Fixing up some remainign breakage after the 4.14 libelf dependency issues.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Very strange behavior of fetchpatch
user_login: copumpkin
html_url: https://github.com/NixOS/nixpkgs/issues/34046
updated_at: 2018-01-19 14:58:08
body:
  If I try this command on Darwin and Linux, one of them works and the other does not:

  ```
  $ nix-build -K --check '<nixpkgs>' -A pythonPackages.netaddr.patches.0
  ```

  (for any recent `nixpkgs`)

  On Linux, I get:

  ```
  checking path(s) ‘/nix/store/cwq2b915rlsmnvpjx7gmc78g3mz6q8bf-2ab73f10be7069c9412e853d2d0caf29bd624012.patch’

  trying https://github.com/drkjam/netaddr/commit/2ab73f10be7069c9412e853d2d0caf29bd624012.patch
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
  100  2148    0  2148    0     0   2148      0 --:--:-- --:--:-- --:--:-- 24689
  warning: rewriting hashes in ‘/nix/store/cwq2b915rlsmnvpjx7gmc78g3mz6q8bf-2ab73f10be7069c9412e853d2d0caf29bd624012.patch’; cross fingers
  output path ‘/nix/store/cwq2b915rlsmnvpjx7gmc78g3mz6q8bf-2ab73f10be7069c9412e853d2d0caf29bd624012.patch’ has sha256 hash ‘0s1cdn9v5alpviabhcjmzc0m2pnpq9dh2fnnk2x96dnry1pshg39’ when ‘08rn1s3w9424jhandy4j9sksy852ny00088zh15nirw5ajqg1dn7’ was expected
  ```

  and on Darwin, I get:

  ```
  warning: rewriting hashes in ‘/nix/store/jfcc1ih6ng3dk2rcz8fm2200rq8glgkm-2ab73f10be7069c9412e853d2d0caf29bd624012.patch’; cross fingers
  note: keeping build directory ‘/private/tmp/nix-build-2ab73f10be7069c9412e853d2d0caf29bd624012.patch.drv-0’
  /nix/store/jfcc1ih6ng3dk2rcz8fm2200rq8glgkm-2ab73f10be7069c9412e853d2d0caf29bd624012.patch
  ```

  From what I can see, this is the diff:

  ```diff
  [root@ip:~]# diff -u /nix/store/cwq2b915rlsmnvpjx7gmc78g3mz6q8bf-2ab73f10be7069c9412e853d2d0caf29bd624012.patch /tmp/nix-build-2ab73f10be7069c9412e853d2d0caf29bd624012.patch.drv-0/08rn1s3w9424jhandy4j9sksy852ny00088zh15nirw5ajqg1dn7 
  --- /nix/store/cwq2b915rlsmnvpjx7gmc78g3mz6q8bf-2ab73f10be7069c9412e853d2d0caf29bd624012.patch	1970-01-01 00:00:01.000000000 +0000
  +++ /tmp/nix-build-2ab73f10be7069c9412e853d2d0caf29bd624012.patch.drv-0/08rn1s3w9424jhandy4j9sksy852ny00088zh15nirw5ajqg1dn7	2018-01-19 13:47:24.569096805 +0000
  @@ -1,5 +1,3 @@
  -diff --git a/netaddr/tests/eui/test_ieee_parsers.py b/netaddr/tests/eui/test_ieee_parsers.py
  -index 7877f09..81f1faa 100644
   --- a/netaddr/tests/eui/test_ieee_parsers.py
   +++ b/netaddr/tests/eui/test_ieee_parsers.py
   @@ -12,7 +12,7 @@
  ```


state: closed
title: Qt 5: Fix debug flags
user_login: ttuegel
html_url: https://github.com/NixOS/nixpkgs/pull/34047
updated_at: 2018-01-20 17:51:43
body:
  ### Motivation

  Setting debug flags for Qt 5-based builds incorrectly overrides `NIX_CFLAGS_COMPILE`.

  Incidentally I decided that `debug` should be `true` or `false`, but never `null`. (What would that even mean?)

  ### Testing

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libvirt: add qemu to PATH for libvirtd
user_login: erosennin
html_url: https://github.com/NixOS/nixpkgs/pull/34048
updated_at: 2018-01-24 12:29:25
body:
  ###### Motivation for this change

  `libvirtd` requires `qemu-img` to manage disk images.

  If `qemu-img` is not found by `libvirtd`, attempting to create a `qcow2` image fails with this error:

  ```
  $ cat >/tmp/vol.xml <<EOF
  <volume>
    <name>test</name>
    <capacity>1000</capacity>
    <target>
      <format type="qcow2"/>
    </target>
  </volume>
  EOF
  $ virsh -c qemu:///system vol-create --pool default --file /tmp/vol.xml
  error: Failed to create vol from /tmp/vol.xml
  error: internal error: creation of non-raw file images is not supported without qemu-img.
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: apparmor: updating utilities to fresh python
user_login: corpix
html_url: https://github.com/NixOS/nixpkgs/pull/34049
updated_at: 2018-01-20 08:29:04
body:
  ###### Motivation for this change
  Apparmor utils are broken(I use 9ab77680b6a at the moment). For example, this is `aa-audit --help` output:

  ``` console
  Traceback (most recent call last):
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/bin/.aa-audit-wrapped", line 17, in <module>
      import apparmor.tools
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/lib/python2.7/site-packages/apparmor/tools.py", line 17, in <module>
      import apparmor.aa as apparmor
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/lib/python2.7/site-packages/apparmor/aa.py", line 4345, in <module>
      if cfg['settings'].get('default_owner_prompt', False):
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/lib/python2.7/site-packages/apparmor/config.py", line 27, in __getitem__
      section_val = self.items(section)
    File "/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/lib/python2.7/ConfigParser.py", line 642, in items
      raise NoSectionError(section)
  ConfigParser.NoSectionError: No section: 'settings'
  Error in atexit._run_exitfuncs:
  Traceback (most recent call last):
    File "/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
      func(*targs, **kargs)
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/lib/python2.7/site-packages/apparmor/aa.py", line 128, in on_exit
      debug_logger.debug('Exiting..')
  AttributeError: 'NoneType' object has no attribute 'debug'
  Error in sys.exitfunc:
  Traceback (most recent call last):
    File "/nix/store/6yb5rvr6rvgvx8ylpchwz808djfw07rb-python-2.7.14/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
      func(*targs, **kargs)
    File "/nix/store/jwc12pm1shfkp4bnp8yrf0w74xnryfn5-apparmor-utils-2.10/lib/python2.7/site-packages/apparmor/aa.py", line 128, in on_exit
      debug_logger.debug('Exiting..')
  AttributeError: 'NoneType' object has no attribute 'debug'
  ```

  I was trying to fix them, and decided to update apparmor. Found this PR #33222, but it does not fix the tools, just made an update. Apparmor utils have moved to python 3, so I have updated the python version(python 2 is deprecated in apparmor since 2.11) and added separate derivation for `aa-exec`(it was moved to `binutils` directory inside apparmor source tree).

  Mostly all tools are running successfully now, except two:
  - `aa-notify` probably perl(?) complains about `ERROR: bad programe name '.aa-notify-wrapped'`, I tried to give `.aa-notify-wrapped` different name, after that it failed with `Cannot read '/var/log/kern.log'`. Probably we should have a patch so this tool could work with journald?
  - `aa-remove-unknown` fails with `line 25: /lib/apparmor/rc.apparmor.functions: No such file or directory`. I have no idea what could be done to fix this.

  Based my changes on staging because #33222 is based on staging, feel free to contact me for a rebase :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mono{48,50,54}: Fix libgdiplus path in dll config map
user_login: jammerful
html_url: https://github.com/NixOS/nixpkgs/pull/34050
updated_at: 2018-01-19 23:38:26
body:
  ###### Motivation for this change

  mono/xbuild can't find libgdiplus library in versions 4.8 and greater. Below is difference between versions 4.6 and above:

  ${mono46}/etc/mono/config:

  ```
  <dllmap dll="gdiplus" target="/nix/store/plmc9bs7k4r6szf1sd1ivf30h2mfb44g-libgdiplus-2.10.9/lib/libgdiplus.so" os="!windows"/>
  <dllmap dll="gdiplus.dll" target="/nix/store/plmc9bs7k4r6szf1sd1ivf30h2mfb44g-libgdiplus-2.10.9/lib/libgdiplus.so"  os="!windows"/>
  <dllmap dll="gdi32" target="/nix/store/plmc9bs7k4r6szf1sd1ivf30h2mfb44g-libgdiplus-2.10.9/lib/libgdiplus.so" os="!windows"/>
  <dllmap dll="gdi32.dll" target="/nix/store/plmc9bs7k4r6szf1sd1ivf30h2mfb44g-libgdiplus-2.10.9/lib/libgdiplus.so" os="!windows"/>
  ```

  ${mono{48,50,54}}/etc/mono/config:

  ```
  <dllmap dll="gdiplus" target="libgdiplus.so.0" os="!windows"/>
  <dllmap dll="gdiplus.dll" target="libgdiplus.so.0"  os="!windows"/>
  <dllmap dll="gdi32" target="libgdiplus.so.0" os="!windows"/>
  <dllmap dll="gdi32.dll" target="libgdiplus.so.0" os="!windows"/>
  ```

  This causes the following error to be thrown:

  ```
  Unhandled Exception:
  System.TypeInitializationException: The type initializer for 'System.Drawing.GDIPlus' threw an exception. ---> System.DllNotFoundException: libgdiplus.dylib
    at (wrapper managed-to-native) System.Drawing.GDIPlus:GdiplusStartup (ulong&,System.Drawing.GdiplusStartupInput&,System.Drawing.GdiplusStartupOutput&)
    at System.Drawing.GDIPlus..cctor () [0x000b0] in <5279de5321b24f0b8e1f255c47ecc93c>:0 
     --- End of inner exception stack trace ---
    at System.Drawing.Icon.Dispose () [0x00011] in <5279de5321b24f0b8e1f255c47ecc93c>:0 
    at (wrapper remoting-invoke-with-check) System.Drawing.Icon:Dispose ()
    at System.Drawing.Icon.Finalize () [0x00000] in <5279de5321b24f0b8e1f255c47ecc93c>:0 
  [ERROR] FATAL UNHANDLED EXCEPTION: System.TypeInitializationException: The type initializer for 'System.Drawing.GDIPlus' threw an exception. ---> System.DllNotFoundException: libgdiplus.dylib
    at (wrapper managed-to-native) System.Drawing.GDIPlus:GdiplusStartup (ulong&,System.Drawing.GdiplusStartupInput&,System.Drawing.GdiplusStartupOutput&)
    at System.Drawing.GDIPlus..cctor () [0x000b0] in <5279de5321b24f0b8e1f255c47ecc93c>:0 
     --- End of inner exception stack trace ---
    at System.Drawing.Icon.Dispose () [0x00011] in <5279de5321b24f0b8e1f255c47ecc93c>:0 
    at (wrapper remoting-invoke-with-check) System.Drawing.Icon:Dispose ()
    at System.Drawing.Icon.Finalize () [0x00000] in <5279de5321b24f0b8e1f255c47ecc93c>:0
  ```


  As you can see the sed doesn't work, as it is targeting the wrong string. So simply fix that. Also note **I tested that xbuild can now find the libgdiplus library**.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


