# issues

state: open
title: [darwin] Fix fetchzip call by using https not http
user_login: rw
html_url: https://github.com/NixOS/nixpkgs/pull/64546
updated_at: 2019-07-09 21:37:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The installation of `adv_cmds` on OSX 10.14.4 failed because the hardcoded URL failed to work with fetchzip/fetchurl. This may be due to changes in how AWS hosts S3 files over HTTP/HTTPS.

  This PR updates the hardcoded URL scheme from HTTP to HTTPS. On this OSX machine, the build passes as a result.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cocoapods: 1.7.3 -> 1.7.4
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/64547
updated_at: 2019-07-10 20:06:24
body:
  Also `cocoapods-beta`, which is tracking `cocoapods` for now.

  ###### Motivation for this change
  https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This is a trivial update of a rubygem bundler app.


state: closed
title: etcd: 3.3.1 -> 3.3.13
user_login: edef1c
html_url: https://github.com/NixOS/nixpkgs/pull/64548
updated_at: 2019-07-10 17:11:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  We're over a year behind on etcd releases, and there have been a lot of bugfixes and improvements since.
  While I would've liked to keep them, the release branch drops the tools
  directory as of v3.3.4, [seemingly without explanation](https://github.com/etcd-io/etcd/commit/074e4177707f4daead816c108a06980d77d0aad0). master appears to contain them, so they might return at some point.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: claws: init at v0.3.2
user_login: petabyteboy
html_url: https://github.com/NixOS/nixpkgs/pull/64549
updated_at: 2019-07-10 10:38:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab: 11.10.8 -> 12.0.3
user_login: bgamari
html_url: https://github.com/NixOS/nixpkgs/pull/64550
updated_at: 2019-07-18 00:37:52
body:
  This is a major version bump but things were generally straightforward
  save two wrinkles:

   * it is necessary to ignore collisions in the gitlab bundler
     environment as both `omniauth_oauth2_generic` and
     `apollo_upload_server` provide a `console` executable.

   * grpc had to be patched since its build system expects the `AR`
     environment variable to contain not just the path to `ar` but
     also the `rpc` flags (see the discussion in nixpkgs #63056).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: proj: 5.2.0 -> 6.1.1
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64551
updated_at: 2019-07-15 19:15:08
body:
  ###### Motivation for this change
  Noticed the pyproj package was in a "invalid" state according to repology. So I updated it and it's dependent libray.

  EDIT:
  This turned into bumping proj and fixing all the downstream packages ;(

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  it's a big boi, now that it has the proj package in it's closure
  ```
  $ nix path-info -Sh ./result
  /nix/store/i4bzqhpkzfd82sqj082xb56k85ygl6k1-python3.7-pyproj-2.2.1       170.4M
  ```


state: open
title: openrazer: init at 2.3.1
user_login: evanjs
html_url: https://github.com/NixOS/nixpkgs/pull/64552
updated_at: 2019-07-21 19:28:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Picking up on #47009
  It would be nice to be able to configure Razer stuff from NixOS, etc 
  ###### Things done
  - Kernel drivers for talking to Razer products (keyboards, mice, etc.)
  - Daemon for talking to the kernel drivers.
  - Python library for talking to the daemon.
  - NixOS module hardware.openrazer which adds the kernel drivers and
  daemon to a system.


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  One question, though:
  As this is in place of another PR that went silent, should I edit maintainers and just add myself?  Not sure what the proper route is.


state: closed
title: smlnj: 110.85 -> 110.91
user_login: vaibhavsagar
html_url: https://github.com/NixOS/nixpkgs/pull/64553
updated_at: 2019-07-13 08:16:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: iputils: 20190515 -> 20190709
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/64554
updated_at: 2019-07-17 08:40:57
body:
  ###### Motivation for this change


  https://github.com/iputils/iputils/releases/tag/s20190709

  See release notes for details,
  but of particular note is that
  this expression is now quite simpler
  due to the following:

  * ninfod now builds w/nettle!
  * update includes patches we fetched from upstream
  * cross should be handled now, during move to meson
    * prelim testing confirms, meson makes it much easier
      to get things right re:explanation given in comment
      (not propagating host/target info)

  This also means our iputils is openssl-free,
  which if nothing else is a nice reduction in trans. size :).
  (quick imperfect comparison shows:
    39MB -> 35MB w/glibc
    11.4 -> 7.9 w/musl
  )

  ~~Last outstanding issue in my mind re:this is to check what was broken
  re:musl and idn2 previously and ensure it wasn't something that only
  appeared at runtime.  I believe it wouldn't compile but just want to
  check-- anyway it compiles and seems to work now so, hooray! \o/~~

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
    - clients mostly and hardly exhaustively tested :)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus_2: 2.10.0 -> 2.11.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64555
updated_at: 2019-07-10 13:14:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/prometheus/prometheus/releases/tag/v2.11.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: monoid: 2016-07-21 -> 0.61
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64556
updated_at: 2019-07-15 20:32:21
body:
  ###### Motivation for this change
  Fixing another "problematic" repology package.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  it's big
  $ nix path-info -Sh ./result
  /nix/store/s8xn788iwlmsiibcjrja5kx16s71gp09-monoid-2016-07-21    430.7M
  $ nix path-info -Sh ./result
  /nix/store/y7xgxx35vzawaszjnx2alvcmvrj510qn-monoid-0.61  429.9M


state: closed
title: Cannot invoke gccN in nix-shell, where N = 5, 6, 8.
user_login: kindaro
html_url: https://github.com/NixOS/nixpkgs/issues/64557
updated_at: 2019-07-11 08:26:55
body:
  ## Issue description

  I've been [told](https://github.com/NixOS/nixpkgs/issues/64530) that I should use `nix-shell` when I want to do programming, so that all the libraries are visible and could be linked. I also [discovered][1] that I can use "hidden" versions of some packages, such as `gcc`. Unfortunately, I notice that whatever `gccN` I pick, the `gcc` executable available is always the same, `7.4.0`.

  [1]: https://unix.stackexchange.com/q/529065

  ### Steps to reproduce

      % nix-shell --packages gcc5 --command 'sh -c "command -v gcc"'
      /nix/store/gzx96ys6wczvafmg3p57s9zc6q4xpkzz-gcc-wrapper-7.4.0/bin/gcc
      % nix-shell --packages gcc6 --command 'sh -c "command -v gcc"'
      /nix/store/gzx96ys6wczvafmg3p57s9zc6q4xpkzz-gcc-wrapper-7.4.0/bin/gcc
      % nix-shell --packages gcc7 --command 'sh -c "command -v gcc"'
      /nix/store/gzx96ys6wczvafmg3p57s9zc6q4xpkzz-gcc-wrapper-7.4.0/bin/gcc
      % nix-shell --packages gcc8 --command 'sh -c "command -v gcc"'
      /nix/store/gzx96ys6wczvafmg3p57s9zc6q4xpkzz-gcc-wrapper-7.4.0/bin/gcc
      % nix-shell --packages hello --command 'sh -c "command -v gcc"'
      /nix/store/gzx96ys6wczvafmg3p57s9zc6q4xpkzz-gcc-wrapper-7.4.0/bin/gcc

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.16-arch1-1-ARCH, Arch Linux, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(kindaro): `"nixpkgs-19.09pre184803.d567c486ca5"`
   - nixpkgs: `/home/kindaro/.nix-defexpr/channels/nixpkgs`


state: closed
title: acpica-tools: 20190509 -> 20190703
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64558
updated_at: 2019-07-11 13:56:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `acpica-tools` to the latest release.
  https://acpica.org/downloads/
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: colm: fix cross-compilation
user_login: tathougies
html_url: https://github.com/NixOS/nixpkgs/pull/64559
updated_at: 2019-07-10 13:19:18
body:
  ###### Motivation for this change

  Colm inappropriately uses AC_CHECK_FILES, which is meant to check if a file is available on a host system, rather than in the source tree. It seems to use this for a custom distribution system, which nixpkgs doesn't need. We can eschew all this by just manually evaluating the else case.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Ensure coc extension plugins work out of the box
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/issues/64560
updated_at: 2019-07-15 23:24:13
body:
  ## Issue description
  In https://github.com/NixOS/nixpkgs/pull/64426 some coc vim extension plugins were added, however many are missing overrides, which would make them work out of the box.


state: closed
title: firefoxPackages.tor-browser: 8.5.2 -> 8.5.3
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/64561
updated_at: 2019-07-10 11:39:01
body:
  # `git log`

  - firefoxPackages.tor-browser: 8.5.2 -> 8.5.3

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (2):
      - firefoxPackages.tor-browser
      - tor-browser-bundle
  - On aarch64-linux: ditto
  - On x86_64-darwin:
    - Updated (1):
      - firefoxPackages.tor-browser

  /cc @joachifm


state: closed
title: manual: mention jmacs as emacs imitation
user_login: caadar
html_url: https://github.com/NixOS/nixpkgs/pull/64562
updated_at: 2019-07-13 09:01:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  jmacs is a variant of the JOE editor, installed by default in addition to "joe". It emulate GNU-EMACS and even support unicode (unlike already mentioned Zile and mg, as I know, not sure about Yi).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: make-tarball / lib-tests: reduce duplication
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/64563
updated_at: 2019-07-11 16:02:12
body:
  The misc.nix and systems.nix tests were invoked at three different
  places. Let's not that.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: writefreely: init at 0.10.0
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/pull/64564
updated_at: 2019-07-13 16:32:24
body:
  ###### Motivation for this change

  My attempt with https://github.com/NixOS/nixpkgs/issues/63335

  Does not work yet though. If someone has experience with go packaging, please give it a try!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixphttps://github.com/NixOS/nixpkgs/issues/63335kgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: kjv: init at unstable-2019-03-11
user_login: jtobin
html_url: https://github.com/NixOS/nixpkgs/pull/64565
updated_at: 2019-07-18 09:01:40
body:
  ###### Motivation for this change

  Simply adds Luke Smith's `kjv` to nixpkgs.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: node-packages-v10: add sass cli program
user_login: proger
html_url: https://github.com/NixOS/nixpkgs/pull/64566
updated_at: 2019-07-13 10:25:29
body:
  Adding `nodePackages.sass` which is a popular css preprocessor CLI according to [node section of nixpkgs manual](https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/node.section.md). Includes a regen commit.

  Checklist (i consider unchecked as inapplicable):

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: cargo-flamegraph: init at 0.1.13
user_login: killercup
html_url: https://github.com/NixOS/nixpkgs/pull/64567
updated_at: 2019-07-13 16:33:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: flashplayer: 32.0.0.207 -> 32.0.0.223
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/64568
updated_at: 2019-07-12 13:00:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Important bug fixes.

  https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  - Built packages
    - `nix-env -i -f . -A pkgs.flashplayer`
    - `nix-build -I nixpkgs=. -o flashplayer_i686 -A pkgsi686Linux.flashplayer`
    - `nix-build -I nixpkgs=. -o flashplayer_debug -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -o flashplayer_i686_debug -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"`
    - `nix-build -I nixpkgs=. -o flashplayer_standalone -A pkgs.flashplayer-standalone`
    - `nix-build -I nixpkgs=. -o flashplayer_standalone_debug -A pkgs.flashplayer-standalone-debugger`
    - `nix-build -I nixpkgs=. -o chromium -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"`

  - Played those videos with Firefox (x86_64) and Chromium (x86_64)
    - https://get.adobe.com/flashplayer/about/
    - https://www.dhs.state.il.us/accessibility/tests/flash/video.html

  ---


state: open
title: Implicit behavior of nixos-install --no-root-password is unexpected
user_login: augu5te
html_url: https://github.com/NixOS/nixpkgs/issues/64569
updated_at: 2019-07-10 17:39:09
body:
  ## Issue description
  The resulting differences between nixos-install --no-root-password and nixos-install are error prone.

  In the case of the use of --no-root-password  the root directory contains only etc and nix directories, without it the root directory is totally populated.

  IMHO, the natural expected behavior is to have the same root directory settlement with and without  --no-root-password option.

  The complete root directory settlement seems triggered by nixos-enter but is not called  with --no-root-password option

  ### Steps to reproduce
  Tests conducted with Minimal 19.03 installation CD, qemu and attached virtual disk


state: closed
title: qtutilities: init at 5.13.0
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/64570
updated_at: 2019-07-17 16:09:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - not applicable.
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: AnonIp - Anonymize IP addresses in log files
user_login: htgoebel
html_url: https://github.com/NixOS/nixpkgs/issues/64573
updated_at: 2019-07-11 16:16:38
body:
  Please package Anonip, a tool to anonymize IP addresses in log files.

  It is a simple Python application without any requirements. All required information can be found in he [guix package description for AnonIP](https://git.savannah.gnu.org/cgit/guix.git/commit/?id=582de58c69bd46385196e26434951e1e2d5f32f2).

  ##### Description:
  Anonip masks the last bits of IPv4 and IPv6 addresses in log files. That way most of the relevant information is preserved, while the IP address does not match a particular individuum anymore.

  Depending on your Web server, the log entries may be piped to Anonip directly or via a FIFO (named pipe). Thus the unmasked IP addresses will never be written to any file.

  It's also possible to rewrite existing log files.

  Anonip can also be uses as a Python module in your own Python application.


state: open
title: pythonPackages.simple-salesforce: init at 0.74.3
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64574
updated_at: 2019-07-15 16:03:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adding a missing package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/xdg: add portal option
user_login: pasqui23
html_url: https://github.com/NixOS/nixpkgs/pull/64575
updated_at: 2019-07-20 23:04:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  XDG Portal is useful even outside of flatpack.
  Fixes https://github.com/NixOS/nixpkgs/issues/53454

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.django-csp-nonce: init at 3.5
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64576
updated_at: 2019-07-11 14:44:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Just adding a missing package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox-bin: 67.0.4 -> 68.0 [Critical security fixes]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/64577
updated_at: 2019-07-13 08:12:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Critical security fixes
  - Other improvements

  https://www.mozilla.org/en-US/firefox/68.0/releasenotes/
  https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I could not build the source package. It results in `OSError: [Errno 17] File exists: '/build/firefox-68.0/obj-x86_64-pc-linux-gnu/_virtualenvs/init/lib/python2.7/lib-dynload'`.
  As the update contains critical security fixes, I made this PR only for `firefox-bin` rather than tackling the error. I will investigate it in the weekend if anyone don't. 


state: open
title: Run NixOS tests on Darwin
user_login: nmattia
html_url: https://github.com/NixOS/nixpkgs/issues/64578
updated_at: 2019-07-15 09:17:09
body:
  ## Issue description

  It would be great to be able to run NixOS tests on Darwin. Right now building/running NixOS tests fails on Darwin when building the Linux VMs.

  If one has a Linux builder available, it should be possible to:
  1. Build the Linux VMs on the Linux builder.
  1. Run the tests on Darwin as well as running the start scripts (for interacting with the VMs locally) using hvf instead of KVM.

  My interpretation is that `build-vms.nix` should be tweaked. `buildVM` should take a Linux package set (`pkgs` with `system = "...-linux"`), and the rest of the build (`driver`, `buildVirtualNetwork`) should take a Darwin package set.

  https://github.com/NixOS/nixpkgs/blob/93db55bde5ef7d405c45e76f7304eb3559e80fc4/nixos/lib/build-vms.nix#L30-L43

  Then the `qemu` commands should be changed to use `accel=hvf` (instead of `=kvm`) on Darwin.

  CC @basvandijk 


state: open
title: pythonPackages.django-logentry-admin: init at 1.0.4
user_login: MrMebelMan
html_url: https://github.com/NixOS/nixpkgs/pull/64579
updated_at: 2019-07-10 22:39:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: docker.nix: Add options for named volumes and networks
user_login: mkaito
html_url: https://github.com/NixOS/nixpkgs/pull/64580
updated_at: 2019-07-21 11:35:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I was porting some `docker-compose` stuff to `docker-containers.nix` and found the lack of declarative networks and volumes.

  ###### Things done
  * Added options:
    * `services.docker.volumes = [ "one" "two" ];`
    * `services.docker.networks.foo = {};`
  * Added tests

  A few notes:

  * Code runs in a `docker.service` `postStart`, since I didn't want to tie it to any particular way to run docker containers, plus these entities are "docker-global", and so I think they fit well in the `docker` module.
  * This is probably incompatible with imperative creation of volumes and networks. The code removes any named volumes and networks other than the default ones and the ones declared in the module.
  * The "remove unnecessary things" code is a little more complex than I had hoped for. At least, turns out you can just use `grep` to do a set complement, which is nice.
  * I have never written any nixos tests before, I'm not sure if the way I test for entity removal is the way to go here; feedback is most welcome.
  * `nix-build -A nixosTests.docker` passes on my computer.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: tilt: 0.8.8 -> 0.9.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64581
updated_at: 2019-07-14 00:42:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `tilt` to the latest release.
   - https://github.com/windmilleng/tilt/releases/tag/v0.9.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kube-router: 0.2.5 -> 0.3.1
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64582
updated_at: 2019-07-11 13:56:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `kube-router` to the latest release.
   - https://github.com/cloudnativelabs/kube-router/releases/tag/v0.3.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: clair: 2.0.7 -> 2.0.8
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64583
updated_at: 2019-07-11 07:50:05
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `clair` to the latest release.
   - https://github.com/coreos/clair/releases/tag/v2.0.8
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bitlbee-mastodon: init at 1.4.2
user_login: jpotier
html_url: https://github.com/NixOS/nixpkgs/pull/64584
updated_at: 2019-07-10 19:10:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] (NA) Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] (NA) Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] (NA) Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: archiver: 3.0.0 -> 3.2.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64585
updated_at: 2019-07-11 12:40:26
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `archiver` to the latest release.
  - https://github.com/mholt/archiver/releases/tag/v3.2.0
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gimp-with-plugins does not compile anymore
user_login: tobiasBora
html_url: https://github.com/NixOS/nixpkgs/issues/64586
updated_at: 2019-07-10 22:34:06
body:
  ## Issue description

  I can't install anything anymore on my system because `gimp-with-plugins` fails to install, and when I run `nixos-rebuild switch`, I get an error during the compilation. Note that you can obtain it directly from `nix-build -E "with import <nixpkgs> {}; gimp-with-plugins"`

  ```
  # nixos-rebuid switch
  [...]
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:57:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimppixelrgn.h:48:11: note: declared here
   void      gimp_pixel_rgn_init       (GimpPixelRgn  *pr,
             ^~~~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp:923:77: warning: 'void gimp_pixel_rgn_get_rect(GimpPixelRgn*, guchar*, gint, gint, gint, gint)' is deprecated: Use 'gegl_buffer_get' instead [-Wdeprecated-declarations]
       gimp_pixel_rgn_get_rect (&rgn_in, ImgBuffer, x1, y1, imgwidth, imgheight);
                                                                               ^
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:57:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimppixelrgn.h:80:11: note: declared here
   void      gimp_pixel_rgn_get_rect   (GimpPixelRgn  *pr,
             ^~~~~~~~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp:949:35: warning: 'static lfModifier* lfModifier::Create(const lfLens*, float, int, int)' is deprecated [-Wdeprecated-declarations]
       lfModifier *mod = lfModifier::Create (lenses[0], sLensfunParameters.Crop, imgwidth, imgheight);
  -- Found KF5ItemModels: /nix/store/0xgz2s87px14r74kmbqhaimjrwv0yn96-kitemmodels-5.58.0-dev/lib/cmake/KF5ItemModels/KF5ItemModelsConfig.cmake (found version "5.58.0")
                                     ^~~~~~
  In file included from src/gimplensfun.cpp:30:0:
  /nix/store/sslsjphx656mg6sawyixmm6fd61nfmg5-lensfun-0.3.95/include/lensfun/lensfun.h:2402:35: note: declared here
       DEPRECATED static lfModifier *Create (const lfLens *lens, float crop, int width, int height);
                                     ^~~~~~
  src/gimplensfun.cpp:949:98: warning: 'static lfModifier* lfModifier::Create(const lfLens*, float, int, int)' is deprecated [-Wdeprecated-declarations]
       lfModifier *mod = lfModifier::Create (lenses[0], sLensfunParameters.Crop, imgwidth, imgheight);
                                                                                                    ^
  In file included from src/gimplensfun.cpp:30:0:
  /nix/store/sslsjphx656mg6sawyixmm6fd61nfmg5-lensfun-0.3.95/include/lensfun/lensfun.h:2402:35: note: declared here
       DEPRECATED static lfModifier *Create (const lfLens *lens, float crop, int width, int height);
                                     ^~~~~~
  src/gimplensfun.cpp:952:84: warning: 'int lfModifier::Initialize(const lfLens*, lfPixelFormat, float, float, float, float, lfLensType, int, bool)' is deprecated [-Wdeprecated-declarations]
                            sLensfunParameters.ModifyFlags, sLensfunParameters.Inverse);
                                                                                      ^
  In file included from src/gimplensfun.cpp:30:0:
  /nix/store/sslsjphx656mg6sawyixmm6fd61nfmg5-lensfun-0.3.95/include/lensfun/lensfun.h:2449:20: note: declared here
       DEPRECATED int Initialize (
                      ^~~~~~~~~~
  src/gimplensfun.cpp:1010:81: warning: 'void gimp_pixel_rgn_set_rect(GimpPixelRgn*, const guchar*, gint, gint, gint, gint)' is deprecated: Use 'gegl_buffer_set' instead [-Wdeprecated-declarations]
       gimp_pixel_rgn_set_rect (&rgn_out, ImgBufferOut, x1, y1, imgwidth, imgheight);
                                                                                   ^
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:57:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimppixelrgn.h:104:11: note: declared here
   void      gimp_pixel_rgn_set_rect   (GimpPixelRgn  *pr,
             ^~~~~~~~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp:1012:34: warning: 'void gimp_drawable_flush(GimpDrawable*)' is deprecated: Use 'gegl_buffer_flush' instead [-Wdeprecated-declarations]
       gimp_drawable_flush (drawable);
                                    ^
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:41:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimpdrawable.h:55:16: note: declared here
   void           gimp_drawable_flush                  (GimpDrawable  *drawable);
                  ^~~~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp:1018:35: warning: 'void gimp_drawable_detach(GimpDrawable*)' is deprecated [-Wdeprecated-declarations]
       gimp_drawable_detach (drawable);
                                     ^
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:41:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimpdrawable.h:53:16: note: declared here
   void           gimp_drawable_detach                 (GimpDrawable  *drawable);
                  ^~~~~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp: In function 'int read_opts_from_exif(const char*)':
  src/gimplensfun.cpp:1063:19: error: 'AnyError' in namespace 'Exiv2' does not name a type
       catch (Exiv2::AnyError& e) {
                     ^~~~~~~~
  src/gimplensfun.cpp: In function 'void run(const gchar*, gint, const GimpParam*, gint*, GimpParam**)':
  src/gimplensfun.cpp:1224:59: warning: 'GimpDrawable* gimp_drawable_get(gint32)' is deprecated: Use 'gimp_drawable_get_buffer' instead [-Wdeprecated-declarations]
       drawable = gimp_drawable_get (param[2].data.d_drawable);
                                                             ^
  In file included from /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimp.h:41:0,
                   from src/gimplensfun.cpp:31:
  /nix/store/89n53mna0flc0h8grbdagfawdmqyim0g-gimp-2.10.12/include/gimp-2.0/libgimp/gimpdrawable.h:51:16: note: declared here
   GimpDrawable * gimp_drawable_get                    (gint32         drawable_ID);
                  ^~~~~~~~~~~~~~~~~
  src/gimplensfun.cpp:1269:18: warning: 'void lfDatabase::Destroy()' is deprecated [-Wdeprecated-declarations]
       ldb->Destroy();
                    ^
  In file included from src/gimplensfun.cpp:30:0:
  /nix/store/sslsjphx656mg6sawyixmm6fd61nfmg5-lensfun-0.3.95/include/lensfun/lensfun.h:1757:21: note: declared here
       DEPRECATED void Destroy ();
                       ^~~~~~~
  make: *** [Makefile:51: src/gimplensfun.o] Error 1
  builder for '/nix/store/xpxgy5hxdgn2g043cx2xl2lcyq31ic7z-gimp-plugin-gimplensfun-0.2.4.drv' failed with exit code 2
  cannot build derivation '/nix/store/s9lly3h1rmj71rmv5l1qfvsj6d6mcp0c-gimp-with-plugins-2.10.12.drv': 1 dependencies couldn't be built
  copying path '/nix/store/sgcc7zkpajshmgq5051rxxfmssib9bhl-python-2.7.16-env' from 'https://cache.nixos.org'...
  building '/nix/store/46dkiwk8w5hlia53ysx92si2fa9jvp0j-initrd-fsinfo.drv'...
  building '/nix/store/mza8rgw0g0rc7df16aqqh49abj2i3whm-keymap.drv'...
  cannot build derivation '/nix/store/rw2nhjy95jq2apsjxvi2k7r2vk89z6a0-system-path.drv': 1 dependencies couldn't be built
  building '/nix/store/x7ni38bpn2p1j2x71kdlml870rslwks9-udev-path.drv'...
  building '/nix/store/yi87vyi1mwmv9s0mx7rln38wcby2j2qz-udev-rules.drv'...
  building '/nix/store/pc6v5pqxpgq0n2y2n4kia69md419ismb-unit-NetworkManager-dispatcher.service.drv'...
  cannot build derivation '/nix/store/3ib2cmqh6ljvlbjpncrv0kac5zv0jl8q-nixos-system-colnixos-19.09pre184855.beff2f8d75e.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/3ib2cmqh6ljvlbjpncrv0kac5zv0jl8q-nixos-system-colnixos-19.09pre184855.beff2f8d75e.drv' failed
  ```

  ### Steps to reproduce

  Install or compile `gimp-with-plugins`:

      $ nix-build -E "with import <nixpkgs> {}; gimp-with-plugins"

  I am on `19.09pre184855.beff2f8d75e`.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.52, NixOS, 19.09pre183392.83ba5afcc96 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(me): `""`
   - channels(root): `"nixos-19.09pre184855.beff2f8d75e"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: tdesktop: 1.7.10 -> 1.7.14
user_login: uHOOCCOOHu
html_url: https://github.com/NixOS/nixpkgs/pull/64589
updated_at: 2019-07-11 06:41:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Bump tdesktop: 1.7.10 -> 1.7.14

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
    - From: `/nix/store/3pbi74mhy9xjdz0s9dkgiq68yxpwp1il-telegram-desktop-1.7.10       849051576`
    - To: `/nix/store/bkqbnmsypk18illi2x1fbl3rv7p7qbrs-telegram-desktop-1.7.14      1060342184`
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fzf: 0.17.5 -> 0.18.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64590
updated_at: 2019-07-11 06:22:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `fzf` to the latest release.
  - https://github.com/junegunn/fzf/releases/tag/0.18.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mage: 1.7.1 -> 1.8.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64591
updated_at: 2019-07-12 03:58:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `mage` to the latest release.
  - https://github.com/magefile/mage/releases/tag/v1.8.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dex-oidc: 2.16.0 -> 2.17.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64592
updated_at: 2019-07-10 18:19:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `dex-oidc` to the latest release.
   - https://github.com/dexidp/dex/releases/tag/v2.17.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mako: install dbus service file
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/64593
updated_at: 2019-07-11 12:54:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Absence of dbus service file is a main showstopper for me. I think there is no strict reason to wait for 1.4 release just because of that, instead add it via patch.

  Tested for work at my side.

  Reference https://github.com/NixOS/nixpkgs/issues/57602#issuecomment-502438738

  cc @primeos @dywedir 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Prebuild /etc/passwd and /etc/group if possible
user_login: jameysharp
html_url: https://github.com/NixOS/nixpkgs/pull/64594
updated_at: 2019-07-12 18:30:38
body:
  ###### Motivation for this change

  When `mutableUsers = false` and all users and groups have assigned UID/GIDs, we can precompute exactly what `update-users-groups.pl` would output for `/etc/passwd` and `/etc/group`. In those cases we don't need to run it at activation time; we can generate the right files at build time and just symlink them into place.

  These patches make that happen automatically when it's safe to do so. Until #64268 gets merged most NixOS configurations won't see any benefit because `nscd` doesn't have an assigned UID, but you can always manually assign UIDs and GIDs as needed to make these changes trigger. In my testing I just disabled nscd instead.

  The first few commits are just cleanups that I think are worth applying regardless. In particular, "no output for empty snippets" just makes the generated activation script easier to read. Since the snippets I introduce in later commits are empty under various circumstances, it's nice to have that cleanup in place first.

  I didn't do this because of closure size, but it does reduce the closure size for my test configurations by more than I expected: 187kB savings if no users have `password` or `passwordFile` set. If any users do have one of those options, that adds 32kB to pull in `mkpasswd`, which is still a 155kB savings. Of course, that's all rounding errors in these 539MB closures...

  Hey @peterhoeg and @arianvp, you seemed interested in this work, so here's the pull request I promised.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: tacacs+: init 4.0.4.28
user_login: 0x4A6F
html_url: https://github.com/NixOS/nixpkgs/pull/64595
updated_at: 2019-07-18 18:27:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Adding package for a [TACACS+](http://www.shrubbery.net/tac_plus/) implementation.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: atlassian-jira: 8.2.2 -> 8.2.3
user_login: ciil
html_url: https://github.com/NixOS/nixpkgs/pull/64596
updated_at: 2019-07-11 17:51:08
body:
  ###### Motivation for this change
  https://confluence.atlassian.com/jira/jira-security-advisory-2019-07-10-973486595.html

  Package bump addresses CVE-2019-11581.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-ethereum: 1.8.27 -> 1.9.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64597
updated_at: 2019-07-11 02:19:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `go-ethereum` to the latest release.
  - https://github.com/ethereum/go-ethereum/releases/tag/v1.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Qt 5.12.3
user_login: ttuegel
html_url: https://github.com/NixOS/nixpkgs/pull/64598
updated_at: 2019-07-12 12:12:54
body:
  ###### Motivation for this change

  This is carried over from #60119, but rebased onto the `staging` branch, and with a fix to one of our patches of `qtbase`.

  CC: @vandenoever @bkchr 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: treewide: mesa.drivers -> mesa_drivers
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/64599
updated_at: 2019-07-18 16:06:17
body:
  Partial revert of https://github.com/NixOS/nixpkgs/commit/263f5891b65c841352f5230a1aa7e22ac418a042

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  So I don't rebuild my entire system just for `iris`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-review rev d045bbdc5644982e0c9f7ab969d34b2fbc510497`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: overmind: 2.0.1 -> 2.0.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64600
updated_at: 2019-07-11 13:26:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `overmind` to the latest release.
   - https://github.com/DarthSim/overmind/releases/tag/v2.0.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: treesheets: 2018-8-18 -> 1.0.1
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64601
updated_at: 2019-07-10 22:01:00
body:
  ###### Motivation for this change
  Fixing "troubled" packages on repology

  tested application, seems to work fine, but im not a user of it.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  $ nix path-info -Sh ./result
  /nix/store/wcpz3zkm63fzkgzvdpjmbg80j1zv3zcw-treesheets-2018-08-18        304.9M
  $ nix path-info -Sh ./result
  /nix/store/iv9jkcygk5g2knp0r5pdr878bld6vrql-treesheets-1.0.1     304.9M


state: open
title: `ghc` does not support Unicode, reports locale encoding ASCII.
user_login: kindaro
html_url: https://github.com/NixOS/nixpkgs/issues/64603
updated_at: 2019-07-10 23:44:12
body:
  ## Issue description

  I installed `ghc` via Nix and also via Stack. With the `ghc` binaries provided by Stack, I can easily do Unicode IO. But the Nix `ghc` errors out and pretends to know nothing about Unicode.

  ### Steps to reproduce

      % ghc -e 'putStrLn "x"'
      x
      % ghc -e 'putStrLn "λ"'

      <interactive>:0:11: error:
          lexical error in string/character literal at character '\56526'
      % stack ghc -- -e 'putStrLn "λ"'
      λ

      % ghci
      GHCi, version 8.6.5: http://www.haskell.org/ghc/  :? for help
      Prelude> import System.IO
      Prelude System.IO> localeEncoding  
      ASCII

      % stack repl
      ...
      Configuring GHCi with the following packages: 
      GHCi, version 8.6.5: http://www.haskell.org/ghc/  :? for help
      Loaded GHCi configuration from /run/user/1000/haskell-stack-ghci/2a3bbd58/ghci-script
      Prelude> import System.IO
      Prelude System.IO> localeEncoding 
      UTF-8

      % echo $LANG
      en_US.UTF-8
      % which stack
      /home/kindaro/.nix-profile/bin/stack
      % which ghci
      /nix/store/67g6vwr5mx26h5mickgw17k2irdx1c0d-ghc-8.6.5/bin/ghci

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.16-arch1-1-ARCH, Arch Linux, noversion`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(kindaro): `"nixpkgs-19.09pre184803.d567c486ca5"`
   - nixpkgs: `/home/kindaro/.nix-defexpr/channels/nixpkgs`


state: closed
title: zpaq: fix version and pull from github
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64604
updated_at: 2019-07-11 07:49:50
body:
  ###### Motivation for this change
  [Repology didn't like we were missing the "." between major and minor.](https://repology.org/project/zpaq/versions#nix_unstable)

  The repo was also migrated to git and is using it for releases, so transfered to pulling from github.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```
  $ nix path-info -Sh ./result
  /nix/store/i5b30y5plwgblzl8mfgcnnnb4ql57f35-zpaq-715      32.7M
  $ nix path-info -Sh ./result
  /nix/store/v0i0wf7w6aqq3m8v5zqxc55xyapkck3x-zpaq-7.15     32.7M
  ```

  ```
  $ nix-review wip
  ...
  [1 built, 0.0 MiB DL]
  1 package were build:
  zpaq
  ```

  ```
  $ ./result/bin/zpaq
  zpaq v7.15 journaling archiver, compiled Jan  1 1970
  Usage: zpaq command archive[.zpaq] files... -options...
  ```


state: closed
title: proot: 20190510 -> 5.1.0
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64605
updated_at: 2019-07-10 22:00:50
body:
  ###### Motivation for this change
  [Fix repology entry](https://repology.org/project/proot/versions#nix_unstable). and update the package

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  $ nix path-info -Sh ./result
  /nix/store/1gz638vyk1k8cmypj8zrflaj3yfg9jdy-proot-20190510        94.4M
  $ nix path-info -Sh ./result
  /nix/store/qzwdwjsqn9px5dfs8g5rrppqqjcnpppx-proot-5.1.0   94.1M

  ```
  $ nix-review wip
  ...
  [2 built, 14 copied (21.6 MiB), 4.4 MiB DL]
  2 package were build:
  proot udocker
  ```


state: open
title: useradd changes to /etc/sub[ug]id don't persist past next activation
user_login: jameysharp
html_url: https://github.com/NixOS/nixpkgs/issues/64606
updated_at: 2019-07-10 23:44:26
body:
  ## Issue description

  On a NixOS system with `mutableUsers = true`, the admin is supposed to be able to imperatively add users by running `useradd`.

  The `useradd` command automatically allocates a UID and GID range for the new user if `/etc/subuid` or `/etc/subgid` exist, which they always do on NixOS.

  However, all changes to these two files are overwritten on the next system reboot or `nixos-rebuild`, which to me seems counter to the intent of `mutableUsers`.

  ### Steps to reproduce

  ```sh
  useradd -m testuser
  grep '^testuser:' /etc/sub[ug]id # should match
  /run/current-system/activate
  grep '^testuser:' /etc/sub[ug]id # nothing
  ```
  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.14, NixOS, 19.09.git.6cc7e33 (Loris)`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`

  The channel info isn't meaningful because I built from a git checkout, not my normal channels, and I tested in a container that didn't have access to /nix/var anyway.


state: open
title: Fix build for gimp-with-plugins against exiv2 0.27.1
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/pull/64607
updated_at: 2019-07-18 18:32:27
body:
  ###### Motivation for this change

  Fixes #64586

  ###### Things done

  Path size `1803392632` vs `1798388408` when building against `exiv2 0.26.2018.12.30`

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add an application package for the latest version of
user_login: Bios-Marcel
html_url: https://github.com/NixOS/nixpkgs/pull/64608
updated_at: 2019-07-10 23:24:34
body:
  https://github.com/Bios-Marcel/cordless.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: cordless: init at 2019-06-13
user_login: Bios-Marcel
html_url: https://github.com/NixOS/nixpkgs/pull/64609
updated_at: 2019-07-11 10:16:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gimpPlugins.gimplensfun: fix compilation by bumping to 0.2.5-dev
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/64610
updated_at: 2019-07-10 23:49:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
   Fix #64586. I ran into the same issue on nixos-unstable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Gnome3 and Pantheon in the same system does not build
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/issues/64611
updated_at: 2019-07-11 02:00:59
body:
  ## Issue description

  I want to have gnome3 and pantheon desktop managers in the same NixOS system, so that the user can choose the desired one at login time. So I have on `configuration.nix`:

  ``` nix
    services.xserver.desktopManager.pantheon.enable = true;
    services.xserver.desktopManager.gnome3.enable = true;
  ```

  But `nixos-rebuild` gives the following error:
  ```
  error: The unique option `networking.networkmanager.basePackages.modemmanager' is defined multiple times, in:
   - /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/x11/desktop-managers/pantheon.nix
   - /nix/var/nix/profiles/per-user/root/channels/nixos/nixos/modules/services/x11/desktop-managers/gnome3.nix.
  (use '--show-trace' to show detailed location information)
  ```

  cc @worldofpeace

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.16, NixOS, 19.09pre184855.beff2f8d75e (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre184855.beff2f8d75e"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: emacs: add zmq package
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/64612
updated_at: 2019-07-18 21:51:32
body:
  This builds emacs-zmq.so automatically.

  Fixes #59774

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Update export_kernel_fpu_functions.patch for 5.2?
user_login: fryfrog
html_url: https://github.com/NixOS/nixpkgs/issues/64613
updated_at: 2019-07-11 22:34:12
body:
  Hi, I <3 your `export_kernel_fpu_functions.patch` to bring SIMD/FPU back to recent kernels and use it for my Arch Linux kernel. It looks like they've changed enough that still applies, but with some fuzz/offset.

  ```
  patching file arch/x86/include/asm/fpu/api.h
  Hunk #1 succeeded at 19 (offset 1 line).
  patching file arch/x86/kernel/fpu/core.c
  Hunk #1 succeeded at 94 (offset 1 line).
  Hunk #2 succeeded at 114 with fuzz 2 (offset 3 lines).
  Hunk #3 succeeded at 120 with fuzz 1 (offset -2 lines).
  ```

  Any plans to update it for 5.2 kernels? :)

  https://raw.githubusercontent.com/NixOS/nixpkgs/master/pkgs/os-specific/linux/kernel/export_kernel_fpu_functions.patch

  https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/linux/kernel/export_kernel_fpu_functions.patch

  ```
  diff --git a/arch/x86/include/asm/fpu/api.h b/arch/x86/include/asm/fpu/api.h
  index b774c52e5411..de0d4b67fde7 100644
  --- a/arch/x86/include/asm/fpu/api.h
  +++ b/arch/x86/include/asm/fpu/api.h
  @@ -19,6 +19,8 @@
    * If you intend to use the FPU in softirq you need to check first with
    * irq_fpu_usable() if it is possible.
    */
  +extern void __kernel_fpu_begin(void);
  +extern void __kernel_fpu_end(void);
   extern void kernel_fpu_begin(void);
   extern void kernel_fpu_end(void);
   extern bool irq_fpu_usable(void);
  diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
  index 649fbc3fcf9f..76dfed2bf696 100644
  --- a/arch/x86/kernel/fpu/core.c
  +++ b/arch/x86/kernel/fpu/core.c
  @@ -94,7 +94,7 @@ bool irq_fpu_usable(void)
   }
   EXPORT_SYMBOL(irq_fpu_usable);

  -static void __kernel_fpu_begin(void)
  +void __kernel_fpu_begin(void)
   {
          struct fpu *fpu = &current->thread.fpu;

  @@ -114,11 +114,13 @@ static void __kernel_fpu_begin(void)
          }
          __cpu_invalidate_fpregs_state();
   }
  +EXPORT_SYMBOL(__kernel_fpu_begin);

  -static void __kernel_fpu_end(void)
  +void __kernel_fpu_end(void)
   {
          kernel_fpu_enable();
   }
  +EXPORT_SYMBOL(__kernel_fpu_end);

   void kernel_fpu_begin(void)
   {
  ```

  ^ That is my `git diff` after applying the patch.


state: closed
title: gocryptfs: 1.6.1 -> 1.7
user_login: cw789
html_url: https://github.com/NixOS/nixpkgs/pull/64614
updated_at: 2019-07-17 06:38:28
body:
  ###### Notes for a future gocryptfs updates

  - Delete `fix-unix2syscall_darwin.go-build-failure.patch`
  - Delete `patches` within `default.nix`

  ---

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Just a minor package version update.
  By the way, I haven't worked with go packages before.
  This thing with `deps2nix` is for a noob as me a bit complicated to just update a package.

  Not jet tested, as I still have not a practicable workflow for this here on my side.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37: 3.7.3 -> 3.7.4 for darwin on staging-19.03 is failing
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/issues/64615
updated_at: 2019-07-16 03:27:54
body:
  ## Issue description

  A certain patch does not apply anymore.
  https://nix-cache.s3.amazonaws.com/log/bxjr6fkdrr2hwd1ghd1lz0ifl7daw8i6-python3-3.7.4.drv

  cc @NixOS/darwin-maintainers 


state: open
title: kak-lsp: init at 6.2.1
user_login: spacekookie
html_url: https://github.com/NixOS/nixpkgs/pull/64617
updated_at: 2019-07-14 19:06:19
body:
  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: virt-manager: depends on gtksourceview4, gst-plugins-{base,good}
user_login: astsmtl
html_url: https://github.com/NixOS/nixpkgs/pull/64618
updated_at: 2019-07-15 00:20:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Unable to open virtual machine view in virt-manager. Unable to use SPICE client.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: minecraft-server: 1.14 -> 1.14.3
user_login: rleppink
html_url: https://github.com/NixOS/nixpkgs/pull/64619
updated_at: 2019-07-11 14:16:17
body:
  ###### Motivation for this change
  Update `minecraft-server` to the latest release.
  https://www.minecraft.net/en-us/download/server/

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doc: fix stdenv.xml
user_login: madjar
html_url: https://github.com/NixOS/nixpkgs/pull/64620
updated_at: 2019-07-11 12:19:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  A duplicated opening tag caused the linter to fail, blocking the whole
  nixpkgs-unstable channel.

  This change makes the manual build again, and should help unblocking nixpkgs-unstable.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/dhcpcd: Before network-online.target
user_login: gloaming
html_url: https://github.com/NixOS/nixpkgs/pull/64621
updated_at: 2019-07-12 10:48:02
body:
  ###### Motivation for this change

  Long overdue!
  Fixes #60900. See also #61098

  ###### Things done

  I ran the following NixOS tests:
  ```
  nixos/tests/networking.nix
  nixos/tests/predictable-interface-names.nix
  nixos/tests/cloud-init.nix
  ```
  They seem to be OK, but the output doesn't actually say "fail" or "success".

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  cc @flokli @worldofpeace


state: closed
title: ofBorg broken when evaulating xml
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/issues/64622
updated_at: 2019-07-11 19:58:36
body:
  ## Issue description
  When ofBorg tries to evaluate a package, he now gets tripped up by:

  ```
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  ```
  I bisected the offending commit to https://github.com/NixOS/nixpkgs/commit/f72d7c49d58e0ab1ea948e015eeee9b4b5af4036

  ```
  $ nix-env -f ./ -qaP --xml --out-path --show-trace > /dev/null
  [04:22:38] jon@jon-desktop /home/jon/projects/nixpkgs ((0426ae63f8a...)|BISECTING)
  $ git bisect good
  Bisecting: 0 revisions left to test after this (roughly 0 steps)
  [f72d7c49d58e0ab1ea948e015eeee9b4b5af4036] Add optional Jupyter kernelspec options from the spec (#55989)
  [04:22:42] jon@jon-desktop /home/jon/projects/nixpkgs ((f72d7c49d58...)|BISECTING)
  $ nix-env -f ./ -qaP --xml --out-path --show-trace > /dev/null
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  ```


  ### Steps to reproduce
  ```
  git checkout f72d7c49d58e0ab1ea948e015eeee9b4b5af4036
  $ nix-env -f ./ -qaP --xml --out-path --show-trace > /dev/null
  trace: { argv = <CODE>; displayName = <CODE>; language = <CODE>; logo32 = <CODE>; logo64 = <CODE>; }
  ....
  ```

  cc @FRidh 

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: cargo-xbuild: 0.5.13 -> 0.5.14
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64623
updated_at: 2019-07-11 12:53:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `cargo-xbuild` to the latest release.
  - https://github.com/rust-osdev/cargo-xbuild/releases/tag/0.5.14

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.sphinxcontrib_plantuml: use top-level plantuml
user_login: roman-kashitsyn
html_url: https://github.com/NixOS/nixpkgs/pull/64625
updated_at: 2019-07-11 14:34:01
body:
  ###### Motivation for this change

  `plantuml` declared in python packages implicitly captures graphviz python library instead of the top-level package and thus doesn't work property after installation, trying to access
  `/nix/store/<hash>-python2.7-graphviz-0.10.1/bin/dot` and failing to find it.


state: closed
title: radare2-cutter: 1.8.0 -> 1.8.3
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/64626
updated_at: 2019-07-17 21:23:36
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.anonip: init at 1.0.0
user_login: mmahut
html_url: https://github.com/NixOS/nixpkgs/pull/64628
updated_at: 2019-07-11 16:27:16
body:
  ###### Motivation for this change

  init at 1.0.0, fixes #64573.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.fetchPypi: support SRI hashes
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/64629
updated_at: 2019-07-11 16:02:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Commit https://github.com/NixOS/nixpkgs/commit/267c8d6b2fea05bc811c8e2c2f4529b1436eeb9a introduced support for SRI hashes to `pkgs.fetchurl`. This PR adds it to `fetchPypi`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.thinc: 7.0.4 -> 7.0.6
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/64630
updated_at: 2019-07-11 16:29:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  7.0.5 and 7.0.6 contain fixes for pickle, unflatten, and threading.

  https://github.com/explosion/thinc/releases/tag/v7.0.5
  https://github.com/explosion/thinc/releases/tag/v7.0.6

  Add myself to the list of maintainers, since I seem to be maintaining
  this ;).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fwupd upgrade of Logitech Unifying dongles fails on 19.03
user_login: mweinelt
html_url: https://github.com/NixOS/nixpkgs/issues/64631
updated_at: 2019-07-11 15:31:52
body:
  ## Issue description

  Updating a Logitech Unifying dongle through fwupd on NixOS 19.03 is impossible due to a bug that was only fixed after v1.2.7.

  https://github.com/hughsie/fwupd/issues/1139
  https://github.com/hughsie/fwupd/commit/b62c3a4fae1104c4a1052adc7b3196afa8c33307

  This is security critical as they are affected by the following vulnerability:

  https://www.heise.de/ct/artikel/Logitech-keyboards-and-mice-vulnerable-to-extensive-cyber-attacks-4464533.html
  https://www.cvedetails.com/cve/CVE-2019-13052/

  ### Steps to reproduce

  1. Connect the Unifying dongle
  2. fwupdmgr refresh
  3. fwupdmgr update
  fails with: "cannot handle firmware requirement 'not-child'"

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.16, NixOS, 19.03.git.ecc64b374b2 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.173085.ecc64b374b2, nixos-hardware, nixos-unstable-19.09pre184820.aa2a7e49b82"`
   - channels(hexa): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: sensu-go: 5.10.0 -> 5.11.0
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/64632
updated_at: 2019-07-13 16:02:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Package update

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bazel: 0.27.0 -> 0.28.0
user_login: guibou
html_url: https://github.com/NixOS/nixpkgs/pull/64633
updated_at: 2019-07-16 18:26:07
body:
  ###### Motivation for this change

  Bazel bump to 0.28. I also refactored the following:

  - bazel fetched at runtime dependencies are not hardcoded in a file anymore.
  - overrided repositories, used to prefetch bazel dependencies used during test, are now used using `--distdir`, which removes a lot of boilerplate.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Python: add sitecustomize.py, listen to NIX_PYTHONPATH
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/64634
updated_at: 2019-07-13 07:37:41
body:
  ##### Motivation for this change

  Split from https://github.com/NixOS/nixpkgs/pull/25985.

  Add a `sitecustomize.py` file that listens to `NIX_PYTHONPATH` and unsets it afterwards. This gives the same feature as both `PYTHONHOME` and `PYTHONPATH`, however, without preventing the user from using those environment variables, and without leaking the variable.

  This variable is now used in `python.buildEnv`, thereby solving issues with a leaking `PYTHONHOME` which could break nested Python programs/environments.

  In the future we may choose to use this as well in `buildPythonPackage`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Is there are something like hoogle for nix?
user_login: rndd-AK
html_url: https://github.com/NixOS/nixpkgs/issues/64635
updated_at: 2019-07-12 20:53:11
body:
  I'm looking for something like hoongle (https://hoogle.haskell.org) for nix. In other words - is there any db of nixos packages API for writing defaults..?


state: closed
title: electrum 3.3.8, optional qt, darwin fixes
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/64636
updated_at: 2019-07-12 07:45:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ```
  nix path-info -Sh -f . electrum '((import ./. { }).electrum.override { enableQt = false; })' 
  /nix/store/nghcaigbxqx5z856aayp2wzdrjra6vv0-electrum-3.3.8	 450.5M
  /nix/store/zj2jscg0w8shsxqfp9xf4zdcck4fdqn1-electrum-3.3.8	   1.5G
  ```

  [darwin build tested/logged here](https://dev.azure.com/arcnmx/nixexprs/_build/results?buildId=362)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qt512.qtwebengine: darwin patch
user_login: arcnmx
html_url: https://github.com/NixOS/nixpkgs/pull/64637
updated_at: 2019-07-11 21:06:15
body:
  ###### Motivation for this change

  This same patch is currently applied to qtwebengine-5.11 (which is [broken](https://hydra.nixos.org/job/nixpkgs/trunk/qt511.qtwebengine.x86_64-darwin) regardless), it just seems to have been omitted from 5.12 in #56440. Doesn't actually fix the build but expands on @veprbl's changes to get past [failing to start the build](https://hydra.nixos.org/build/96030738/nixlog/1), and maybe someone will feel like investigating the actual failure related to macos sdk versions/headers.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: atlassian-jira: 8.1.0 -> 8.1.2
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/64638
updated_at: 2019-07-15 12:26:14
body:
  ###### Motivation for this change

  Same motivation as #64596 : CVE-2019-11581
  https://confluence.atlassian.com/jira/jira-security-advisory-2019-07-10-973486595.html

  ping @ciil @globin 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fasttext: 0.2.0 -> 0.9.1
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/64639
updated_at: 2019-07-12 00:13:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changes:

  - Refactoring of internal classes.
  - Better unicode handling.

  https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.fasttext: 0.2.0 -> 0.9.1
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/64640
updated_at: 2019-07-12 00:12:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Changes:

  - Refactoring of internal classes.
  - Better unicode handling.
  - New Python API: https://fasttext.cc/docs/en/python-module.html

  https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Pantheon keyboard input (mostly) ignored
user_login: joseph-long
html_url: https://github.com/NixOS/nixpkgs/issues/64641
updated_at: 2019-07-12 08:00:31
body:
  ## Issue description

  After enabling pantheon and LightDM in `/etc/nixos/configuration.nix`, I can log in and see a Pantheon desktop. However, I don't seem to be able to send keyboard input to Terminal or xterm. Searching the Applications menu did work, however.

  Probably unrelated, transparency seems to be broken on my machine... window shadows render as large opaque black borders on windows.

  ### Steps to reproduce

  1. Log in to Pantheon session
  2. Open Terminal by searching in Applications menu, note working input
  3. Try to type in Terminal, note no change

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.58, NixOS, 19.03.173085.ecc64b374b2 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.optuna: init at 0.13.0
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/64642
updated_at: 2019-07-13 18:12:11
body:
  ###### Motivation for this change

  Listened to an awesome optuna talk at SciPy! So I wanted to contribute the package to nixpkgs

  This closes PR #31954

  ###### Things done

   - pythonPackages.scikit-optimize: init at 0.6 
   - pythonPackages.optuna: init at 0.13.0 
   - pythonPackages.lightgbm: init at 2.2.3 
   - pythonPackages.cliff: init at 2.15.0 

  cc: @wd15 @g-votte thanks to the awesome nix and optuna talks :smile: 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] pythonPackages.fipy: init at 3.3
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/64643
updated_at: 2019-07-14 17:47:18
body:
  ###### Motivation for this change

  Adding nist package

  ###### Things done

  cc @wd15

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grpcui: init at 0.2.0
user_login: pradyuman
html_url: https://github.com/NixOS/nixpkgs/pull/64644
updated_at: 2019-07-12 02:04:15
body:
  ###### Motivation for this change
  I'd like to get this straight from nixpkgs so it's easier for other team members to use as well.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: citrix_workspace: add 1906 (`citrix_workspace_19_6_0`)
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/64645
updated_at: 2019-07-12 07:28:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New release available:
  https://www.citrix.com/downloads/workspace-app/linux/workspace-app-for-linux-latest.html

  Apart from the new version the following things changed:

  * Updated the docs as all notes about `citrix_receiver` also apply for
    `citrix_workspace`. Also added a deprecation warning about the
    upcoming removal.

  * Removed the `libidn_134` override as neither `citrix_workspace_19_3_0`
    nor `citrix_workspace_19_6_0` require this library anymore according
    to `readelf -d ./result/opt/citrix-icaclient/wfica` (in contrast to
    `citrix_receiver_13_10_0`).

  * Added myself as maintainer as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mariadb: fix mytop script
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/64646
updated_at: 2019-07-22 10:33:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  ```
  ~/nixpkgs> nix-shell -p mysql.client --run mytop
  /tmp/nix-shell-632-0/rc: /nix/store/fzfx1sr6pfrqhqy7n7jh89sbxr4v7da5-mariadb-client-10.2.17-bin/bin/mytop: /usr/bin/perl: bad interpreter: No such file or directory
  ```

  @volth Is this an acceptable way to fix this? Do I need `propagatedBuildInputs` here?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvm_*,clang_*: allow src overrides
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/64647
updated_at: 2019-07-17 08:30:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  While implementing #64319 it was discovered that it is not possible to override `src` for `llvm` and `clang` because the string interpolation of `src` is used to define an `unpackPhase`. This PR changes it to using environment variable so that it can be easily changed with `overrideAttrs`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested compilation of all pkgs that depend on this change using `nix-review pr --build-args "--option build-use-sandbox false" 64647 -p clang_35 -p clang_38 -p clang_39 -p clang_4 -p clang_5 -p clang_6 -p clang_7 -p clang_8 -p llvm_35 -p llvm_38 -p llvm_39 -p llvm_4 -p llvm_5 -p llvm_6 -p llvm_7 -p llvm_8`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: 2019.07.02 -> 2019.07.12
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64648
updated_at: 2019-07-12 03:59:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `youtube-dl` to the latest release.
  https://github.com/ytdl-org/youtube-dl/releases/tag/2019.07.12
  **NOTE**: Updates to `youtube-dl` should be backported, thanks!
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: eksctl: 0.1.39 -> 0.1.40
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64649
updated_at: 2019-07-13 09:35:03
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `eksctl` to the latest release.
  - https://github.com/weaveworks/eksctl/releases/tag/0.1.40
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vala: 0.44.3 -> 0.44.5
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64650
updated_at: 2019-07-14 04:24:41
body:
  https://gitlab.gnome.org/GNOME/vala/raw/0.44.5/NEWS

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffmpeg-full does not build on macOS
user_login: bdesham
html_url: https://github.com/NixOS/nixpkgs/issues/64651
updated_at: 2019-07-13 13:24:40
body:
  ## Issue description

  ffmpeg-full does not build on my machine (macOS 10.13). If I add

  ```
  {
    packageOverrides = pkgs: {
      ffmpeg-full = pkgs.ffmpeg-full.override {
        nvenc = false;
      };
    };
  }
  ```

  to my config.nix then I’m able to build the package.

  This issue is fixed in PR #63643, which I opened, but there hasn’t been any activity on that for a while.

  ### Steps to reproduce

  1. `nix-env -iA nixpkgs.ffmpeg-full`

  <details>
  <summary>The output of that command</summary>
  <pre>
  installing 'ffmpeg-full-4.1.3'
  these derivations will be built:
    /nix/store/sn1bf1yh0hfsx4b3qpv791szw2q6xdfk-ffmpeg-full-4.1.3.drv
  these paths will be fetched (0.05 MiB download, 0.30 MiB unpacked):
    /nix/store/spmc8abdq71kc6miq0304nyvgrzj7pzj-nv-codec-headers-9.0.18.1
  copying path '/nix/store/spmc8abdq71kc6miq0304nyvgrzj7pzj-nv-codec-headers-9.0.18.1' from 'https://cache.nixos.org'...
  building '/nix/store/sn1bf1yh0hfsx4b3qpv791szw2q6xdfk-ffmpeg-full-4.1.3.drv'...
  unpacking sources
  unpacking source archive /nix/store/x6zd823d3492y1j22plij99gdbylkc2g-ffmpeg-4.1.3.tar.xz
  source root is ffmpeg-4.1.3
  setting SOURCE_DATE_EPOCH to timestamp 1554117394 of file ffmpeg-4.1.3/libavformat/movenc.c
  patching sources
  patching script interpreter paths in .
  ./tools/clean-diff: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/libav-merge-next-commit: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/make_chlayout_test: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/mq5a6ab8828baq55xy4z7089jkmfqmgf-perl-5.28.2/bin/perl"
  ./tools/cl2c: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/unwrap-diff: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/gen-rc: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/plotframes: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/mq5a6ab8828baq55xy4z7089jkmfqmgf-perl-5.28.2/bin/perl"
  ./tools/patcheck: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/murge: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/missing_codec_desc: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tools/dvd2concat: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/mq5a6ab8828baq55xy4z7089jkmfqmgf-perl-5.28.2/bin/perl"
  ./tools/bisect-create: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./compat/cuda/ptx2c.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./compat/windows/mslink: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./compat/windows/makedef: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./compat/solaris/make_sunver.pl: interpreter directive changed from "/usr/bin/env perl" to "/nix/store/mq5a6ab8828baq55xy4z7089jkmfqmgf-perl-5.28.2/bin/perl"
  ./configure: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/copycooker.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/fate.sh: interpreter directive changed from " /bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/lavf-regression.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/fate/source-check.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/regression-funcs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./tests/fate-run.sh: interpreter directive changed from " /bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./ffbuild/pkgconfig_generate.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./ffbuild/version.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  ./doc/doxy-wrapper.sh: interpreter directive changed from "/bin/sh" to "/nix/store/mlsjkws5zc9dja87npqy8g1vrfx1rf23-bash-4.4-p23/bin/sh"
  configuring
  configure flags: --disable-static --prefix=/nix/store/jsakjji01na8rjjl21n80b3hmcanppld-ffmpeg-full-4.1.3 --target_os=darwin --arch=x86_64 --enable-gpl --enable-version3 --disable-nonfree --enable-shared --disable-static --enable-pic --cc=clang --disable-small --enable-runtime-cpudetect --disable-lto --enable-gray --enable-swscale-alpha --enable-hardcoded-tables --enable-safe-bitstream-reader --enable-pthreads --disable-w32threads --disable-os2threads --enable-network --enable-pixelutils --enable-ffmpeg --enable-ffplay --enable-ffprobe --enable-avcodec --enable-avdevice --enable-avfilter --enable-avformat --enable-avresample --enable-avutil --enable-postproc --enable-swresample --enable-swscale --enable-doc --disable-htmlpages --enable-manpages --disable-podpages --disable-txtpages --enable-bzlib --enable-libcelt --disable-libfdk-aac --disable-libflite --enable-fontconfig --enable-libfreetype --disable-frei0r --enable-libfribidi --disable-libgme --enable-gnutls --enable-libgsm --enable-ladspa --enable-libmp3lame --enable-libaom --enable-libass --enable-libbluray --enable-libbs2b --disable-libdc1394 --enable-iconv --disable-libmfx --disable-libmodplug --enable-libmysofa --enable-libopus --enable-libssh --enable-libtheora --disable-libv4l2 --disable-vaapi --enable-vdpau --enable-libvorbis --enable-libvpx --enable-libwebp --enable-xlib --enable-libxcb --enable-libxcb-shm --enable-libxcb-xfixes --enable-libxcb-shape --enable-lzma --enable-nvenc --disable-openal --enable-libopencore-amrnb --disable-opengl --enable-libopenjpeg --disable-openssl --disable-libpulse --enable-librtmp --enable-sdl2 --enable-libsoxr --enable-libspeex --disable-libvidstab --enable-libvo-amrwbenc --enable-libwavpack --enable-libx264 --disable-libx265 --disable-libxavs --enable-libxvid --enable-libzmq --enable-zlib --disable-debug --enable-optimizations --disable-extra-warnings --disable-stripping
  ERROR: nvenc requested, but not all dependencies are satisfied: ffnvcodec

  If you think configure made a mistake, make sure you are using the latest
  version from Git.  If the latest version fails, report the problem to the
  ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.freenode.net.
  Include the log file "ffbuild/config.log" produced by configure as this will help
  solve the problem.
  builder for '/nix/store/sn1bf1yh0hfsx4b3qpv791szw2q6xdfk-ffmpeg-full-4.1.3.drv' failed with exit code 1
  error: build of '/nix/store/sn1bf1yh0hfsx4b3qpv791szw2q6xdfk-ffmpeg-full-4.1.3.drv' failed
  </pre>
  </details>

  ## Technical details

   - system: `"x86_64-darwin"`
   - host os: `Darwin 17.7.0, macOS 10.13.6`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(bdesham): `"nixpkgs-19.09pre184803.d567c486ca5"`
   - nixpkgs: `/Users/bdesham/.nix-defexpr/channels/nixpkgs`


state: closed
title: gitAndTools.hub: 2.12.1 -> 2.12.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64652
updated_at: 2019-07-13 02:18:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `gitAndTools.hub` to the latest release.
   - https://github.com/github/hub/releases/tag/v2.12.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bitwig-studio3: add version 3
user_login: mrVanDalo
html_url: https://github.com/NixOS/nixpkgs/pull/64653
updated_at: 2019-07-15 05:37:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New version of bitwig-studio is released

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: axel: 2.17.1 -> 2.17.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64654
updated_at: 2019-07-12 11:29:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `axel` to the latest release.
  - https://github.com/axel-download-accelerator/axel/releases/tag/v2.17.3
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Vulnerability roundup 72: ffmpeg-4.1.3: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64656
updated_at: 2019-07-13 13:01:36
body:
  [search](https://search.nix.gsc.io/?q=ffmpeg&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=ffmpeg+in%3Apath&type=Code)

  * [ ] [CVE-2019-13312](https://nvd.nist.gov/vuln/detail/CVE-2019-13312) (nixos-unstable)
  * [ ] [CVE-2019-13390](https://nvd.nist.gov/vuln/detail/CVE-2019-13390) (nixos-unstable)

  Scanned versions: nixos-unstable: beff2f8d75e. May contain false positives.


state: closed
title: Vulnerability roundup 72: glib-2.58.2: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64657
updated_at: 2019-07-16 10:02:09
body:
  [search](https://search.nix.gsc.io/?q=glib&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=glib+in%3Apath&type=Code)

  * [x] [CVE-2019-13012](https://nvd.nist.gov/vuln/detail/CVE-2019-13012) (nixos-19.03)

  Scanned versions: nixos-19.03: ecc64b374b2. May contain false positives.


state: closed
title: Vulnerability roundup 72: gnupg-2.2.16: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64658
updated_at: 2019-07-13 13:48:06
body:
  [search](https://search.nix.gsc.io/?q=gnupg&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=gnupg+in%3Apath&type=Code)

  * [x] [CVE-2019-13050](https://nvd.nist.gov/vuln/detail/CVE-2019-13050) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: beff2f8d75e; nixos-19.03: ecc64b374b2. May contain false positives.


state: open
title: Vulnerability roundup 72: imagemagick-6.9.9-34: 5 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64659
updated_at: 2019-07-12 17:01:30
body:
  [search](https://search.nix.gsc.io/?q=imagemagick&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=imagemagick+in%3Apath&type=Code)

  * [ ] [CVE-2019-13133](https://nvd.nist.gov/vuln/detail/CVE-2019-13133) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2019-13134](https://nvd.nist.gov/vuln/detail/CVE-2019-13134) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2019-13135](https://nvd.nist.gov/vuln/detail/CVE-2019-13135) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2019-13136](https://nvd.nist.gov/vuln/detail/CVE-2019-13136) (nixos-unstable, nixos-19.03)
  * [ ] [CVE-2019-13137](https://nvd.nist.gov/vuln/detail/CVE-2019-13137) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: beff2f8d75e; nixos-19.03: ecc64b374b2. May contain false positives.


state: closed
title: Vulnerability roundup 72: libosinfo-1.5.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64660
updated_at: 2019-07-16 20:39:50
body:
  [search](https://search.nix.gsc.io/?q=libosinfo&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libosinfo+in%3Apath&type=Code)

  * [ ] [CVE-2019-13313](https://nvd.nist.gov/vuln/detail/CVE-2019-13313) (nixos-unstable)

  Scanned versions: nixos-unstable: beff2f8d75e. May contain false positives.


state: closed
title: Vulnerability roundup 72: libxslt-1.1.33: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64661
updated_at: 2019-07-20 07:34:27
body:
  [search](https://search.nix.gsc.io/?q=libxslt&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=libxslt+in%3Apath&type=Code)

  * [x] [CVE-2019-13117](https://nvd.nist.gov/vuln/detail/CVE-2019-13117) (nixos-unstable, nixos-19.03)
  * [x] [CVE-2019-13118](https://nvd.nist.gov/vuln/detail/CVE-2019-13118) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: beff2f8d75e; nixos-19.03: ecc64b374b2. May contain false positives.


state: closed
title: Vulnerability roundup 72: soundtouch-2.0.0: 3 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64662
updated_at: 2019-07-13 13:32:21
body:
  [search](https://search.nix.gsc.io/?q=soundtouch&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=soundtouch+in%3Apath&type=Code)

  * [x] [CVE-2018-17096](https://nvd.nist.gov/vuln/detail/CVE-2018-17096) (nixos-unstable)
  * [x] [CVE-2018-17097](https://nvd.nist.gov/vuln/detail/CVE-2018-17097) (nixos-unstable)
  * [x] [CVE-2018-17098](https://nvd.nist.gov/vuln/detail/CVE-2018-17098) (nixos-unstable)

  Scanned versions: nixos-unstable: beff2f8d75e. May contain false positives.


state: open
title: Vulnerability roundup 72: unzip-6.0: 1 advisory
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64663
updated_at: 2019-07-12 17:01:31
body:
  [search](https://search.nix.gsc.io/?q=unzip&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=unzip+in%3Apath&type=Code)

  * [ ] [CVE-2019-13232](https://nvd.nist.gov/vuln/detail/CVE-2019-13232) (nixos-unstable, nixos-19.03)

  Scanned versions: nixos-unstable: beff2f8d75e; nixos-19.03: ecc64b374b2. May contain false positives.


state: closed
title: Vulnerability roundup 72: wavpack-5.1.0: 2 advisories
user_login: ckauhaus
html_url: https://github.com/NixOS/nixpkgs/issues/64664
updated_at: 2019-07-16 16:16:51
body:
  [search](https://search.nix.gsc.io/?q=wavpack&i=fosho&repos=nixos-nixpkgs), [files](https://github.com/NixOS/nixpkgs/search?utf8=%E2%9C%93&q=wavpack+in%3Apath&type=Code)

  * [x] [CVE-2018-19840](https://nvd.nist.gov/vuln/detail/CVE-2018-19840) (nixos-unstable)
  * [x] [CVE-2018-19841](https://nvd.nist.gov/vuln/detail/CVE-2018-19841) (nixos-unstable)

  Scanned versions: nixos-unstable: beff2f8d75e. May contain false positives.


state: closed
title: Using ssh fails with: No user exists for uid 17342423423
user_login: rhajdacki
html_url: https://github.com/NixOS/nixpkgs/issues/64665
updated_at: 2019-07-15 14:02:03
body:
  ## Issue description

  Using ssh (and git via ssh) results in error: `No user exists for uid 17342423423`

  ### Steps to reproduce

  - Install single user Nix on Ubuntu 16.04 using nix-user-chroot method.
  - Execute command `ssh git@github.com`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.4.0-151-generic, Ubuntu, 16.04.6 LTS (Xenial Xerus)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(rafalh): `"nixpkgs-19.09pre185219.ed86bbad84c"`
   - nixpkgs: `/home/rafalh/.nix-defexpr/channels/nixpkgs`


state: closed
title: Alacritty fails with: [ERROR] pw not found
user_login: rhajdacki
html_url: https://github.com/NixOS/nixpkgs/issues/64666
updated_at: 2019-07-15 14:03:39
body:
  ## Issue description

  Alacritty when executed via nixGLNvidia fails with error: `[ERROR] pw not found`

  ### Steps to reproduce

  - Install single user Nix on Ubuntu 16.04 using nix-user-chroot method.
  - Install nixGL: https://github.com/guibou/nixGL
  - Install alacritty
  - Run `nixGLNvidia alacritty`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.4.0-151-generic, Ubuntu, 16.04.6 LTS (Xenial Xerus)`
   - multi-user?: `no`
   - sandbox: `no`
   - version: `nix-env (Nix) 2.2.2`
   - channels(rafalh): `"nixpkgs-19.09pre185219.ed86bbad84c"`
   - nixpkgs: `/home/rafalh/.nix-defexpr/channels/nixpkgs`


state: open
title: quickjs: init at 2019-07-09
user_login: stesie
html_url: https://github.com/NixOS/nixpkgs/pull/64668
updated_at: 2019-07-19 20:04:39
body:
  ###### Motivation for this change

  QuickJS is a new Javascript engine recently published by Fabrice Bellard

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: sortmerna: init at 2.1
user_login: luispedro
html_url: https://github.com/NixOS/nixpkgs/pull/64669
updated_at: 2019-07-12 17:50:10
body:
  This is a useful package in bioinformatics, the corresponding bioconda package has [> 50,000 downloads](https://anaconda.org/bioconda/sortmerna)


  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [x] Tested execution of all binary files (usually in `./result/bin/`)


state: open
title: buildkite service fails to start when secrets aren't globally readable
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/64670
updated_at: 2019-07-13 07:02:33
body:
  ## Issue description

  This is a simple one:

  The `preStart` script in https://github.com/NixOS/nixpkgs/blob/f62f744ac2e7650dd458a9474005e5d5eae18617/nixos/modules/services/continuous-integration/buildkite-agent.nix#L210-L227

  runs as `User = "buildkite-agent";` further down, and it can't do its `cat`ing of e.g. the private key file if that one doesn't have `chmod o+r`.

  To fix that, this should have `PermissionsStartOnly=true` so that the `preStart` runs as `root`, and the script should `chown` the created directories to `buildkite-agent`.

  ### Steps to reproduce

  ```nix
    services.buildkite-agent = {
      enable = true;
      tokenPath = "/var/lib/buildkite/secret-agent-token";
      openssh.privateKeyPath = "/var/lib/buildkite/ssh/id_rsa";
      openssh.publicKeyPath = /var/lib/buildkite/ssh/id_rsa.pub;
    };
  ```

  where `/var/lib/buildkite/ssh/id_rsa` has permissions

  ```
  -rw------- 1 buildkite-agent root 1.8K Jul 12 12:07 /var/lib/buildkite/ssh/id_rsa
  ```


state: closed
title: ansible: 2.8.1 -> 2.8.2
user_login: angristan
html_url: https://github.com/NixOS/nixpkgs/pull/64671
updated_at: 2019-07-13 08:01:10
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ansible: 2.8.1 -> 2.8.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```sh
  stanislas@nixpsla ~/nixpkgs> (ansible/update/2.8.2|✚1) ./result/bin/ansible --version
  ansible 2.8.2
    config file = None
    configured module search path = ['/home/stanislas/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
    ansible python module location = /nix/store/1ip77rqvv64ijkm67d3pmy6vzsd2fz4v-python3.7-ansible-2.8.2/lib/python3.7/site-packages/ansible
    executable location = /nix/store/1ip77rqvv64ijkm67d3pmy6vzsd2fz4v-python3.7-ansible-2.8.2/bin/ansible
    python version = 3.7.3 (default, Mar 25 2019, 20:59:09) [GCC 7.4.0]
  ```


state: closed
title: debianutils: 4.8.6.1 -> 4.8.6.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64672
updated_at: 2019-07-13 09:35:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `debianutils` to the latest release.
  - https://packages.debian.org/sid/debianutils
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: debootstrap: 1.0.114 -> 1.0.115
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64673
updated_at: 2019-07-13 02:17:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `debootstrap` to the latest release.
  - https://packages.debian.org/source/sid/debootstrap

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: fcitx-qt5: 1.2.1 -> 1.2.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64674
updated_at: 2019-07-13 09:44:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `fcitx-qt5` to the latest release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qt-box-editor: init at unstable-2019-07-12
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/64677
updated_at: 2019-07-14 04:08:12
body:
  latest unstable version is only one to build with tesseract4 and qt5

  ###### Motivation for this change

  LGTM I have tested that the binary works for my OCR training

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python.pkgs.scipy: inherit the correct version
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/64678
updated_at: 2019-07-12 20:48:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Because of the missing `rec` the inherited version was actually the
  nixpkgs version. AS a result, the output name depended on how nixpkgs
  was fetched, introducing impurity.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] glib: fix CVE-2019-13012
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64679
updated_at: 2019-07-13 14:16:25
body:
  ### CVE-2019-13012 Description:

  The keyfile settings backend in GLib before 2.59.1 creates directories
  using g_file_make_directory_with_parents (kfsb->dir, NULL, NULL) and
  files using g_file_replace_contents (kfsb->file, contents, length, NULL, FALSE,
  G_FILE_CREATE_REPLACE_DESTINATION, NULL, NULL, NULL).
  Consequently, it does not properly restrict directory (and file) permissions.
  Instead, for directories, 0777 permissions are used; for files, default file
  permissions are used.

  ### Patch Summary:

  Changes the permissions when a directory is created,
  using 700 instead 777 in gio/gkeyfilesettingsbackend.c
  and changes test to run in a temp directory in gio/tests/gsettings.c.

  ---

  Upstream Issue: https://gitlab.gnome.org/GNOME/glib/issues/1658
  Upstream MR: https://gitlab.gnome.org/GNOME/glib/merge_requests/604

  Fixes #64657

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  To fix #64657

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python2.pkgs.scipy: fix fixed output hash
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/64680
updated_at: 2019-07-12 21:19:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Missed in 03226aac623e5197d7910127dbf5bdea93e6aa99.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avro-tools: init at 1.9.0
user_login: davlum
html_url: https://github.com/NixOS/nixpkgs/pull/64681
updated_at: 2019-07-14 20:01:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Access the avro-tools cli.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildPythonPackage: add support for setupPyDistFlags
user_login: aske
html_url: https://github.com/NixOS/nixpkgs/pull/64682
updated_at: 2019-07-13 11:36:56
body:
  Flags passed to the "python setup.py" command.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Allow to pass flags to "python setup.py", see #64627.

  ###### Things done
  Added a new `setupPyDistFlags` option (not sure about the name).

  cc @FRidh 

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: evtest-qt: init at 0.2.0
user_login: alexarice
html_url: https://github.com/NixOS/nixpkgs/pull/64684
updated_at: 2019-07-18 14:12:11
body:
  ###### Motivation for this change
  Appears to be no existing package for this

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  For me this does not work when ran with sudo giving the error:
  ```
  No protocol specified
  qt.qpa.xcb: could not connect to display :0
  ```
  though I expect this may have to do with me running wayland. Everything works fine for me when not running with sudo.
  Further I am no expert with qt or cmake so if I have missed some dependency/ something important please let me know.


state: closed
title: tdlib: init at 1.4.0
user_login: vyorkin
html_url: https://github.com/NixOS/nixpkgs/pull/64685
updated_at: 2019-07-17 06:42:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Adds the [tdlib](https://github.com/tdlib/td) -- a cross-platform library for building Telegram clients.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Spotify + PulseAudio : No Sound
user_login: BadDecisionsAlex
html_url: https://github.com/NixOS/nixpkgs/issues/64686
updated_at: 2019-07-14 21:24:59
body:
  ## Issue description

  You know the deal :(
  This has been happening with a lot of my apps with PulseAudio recently. I'm getting no sound from the app and PulseAudio doesn't even seem to detect Spotify.

  ### Steps to reproduce

  ```nix
  # configuration.nix
  {
    hardware.pulseaudio.enable = true;
    environment.systemPackages = with pkgs; [spotify];
  }
  ```

  ## Technical details

  ```sh
   - system: `"x86_64-linux"`                
   - host os: `Linux 4.19.57, NixOS, 19.09pre184855.beff2f8d75e (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(camus): `"home-manager, nextbookit, nixos-mio"`
   - channels(root): `"home-manager, nixos-19.09pre184855.beff2f8d75e, nixos-hardware, nixos-stable-18.09.2574.a7e559a5504"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: riot-web: fallback to example config
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/64687
updated_at: 2019-07-13 15:14:16
body:
  ###### Motivation for this change

  Since 1.2.2, specifying defaults seems to be required for the app to start.
  This fixes issue #64543 (riot-desktop starts and just displays "Riot is misconfigured").
  The problem isn't apparent when the user is already logged in.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC: @bachp @nyanloutre 


state: closed
title: gtkd: fix build with config.allowAliases=false
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/64688
updated_at: 2019-07-13 15:39:39
body:
  ```
  $ nix-instantiate --show-trace -K -k -E "(import (builtins.fetchTarball https://github.com/NixOS/nixpkgs/archive/19.03.tar.gz) { config.allowAliases = false; }).gtkd"  

  error: while evaluating the attribute 'glib' of the derivation 'gtkd-3.8.5' at /nix/store/72vjs9dvrj8nzsavl0i6j3n6dv62i8jl-source/pkgs/development/libraries/gtkd/default.nix:5:3:           
  attribute 'glib' missing, at /nix/store/72vjs9dvrj8nzsavl0i6j3n6dv62i8jl-source/pkgs/development/libraries/gtkd/default.nix:4:26                                                             
  ```

  @jtojnar 


state: closed
title: python3Packages.scikit-tda: init at 0.0.4
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/64689
updated_at: 2019-07-14 07:55:13
body:
  ###### Motivation for this change

  Went to scipy and saw an awesome package for Topological Data Analysis and wanted to add it to nixpkgs. Thanks @sauln for the great talk!

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: thunderbird, thunderbird-bin: 60.7.2 -> 60.8.0 [Critical security fix]
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/64690
updated_at: 2019-07-13 08:33:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Critical security fix
  - Other bug fix

  https://www.thunderbird.net/en-US/thunderbird/60.8.0/releasenotes/
  https://www.mozilla.org/en-US/security/advisories/mfsa2019-23/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: types: Fix path.check for cleanSourceWith output
user_login: hamishmack
html_url: https://github.com/NixOS/nixpkgs/pull/64691
updated_at: 2019-07-13 02:43:35
body:
  Advantage of `cleanSourceWith` is that it composes without copying intermediate output to the store.  Currently using `path.check` breaks this.  Consider:

  ```nix
  let cleanedSource1 = cleanSourceWith { src = ./.; filter = filter1; };
  in
    assert (path.check cleanedSource1);
    cleanSourceWith { src = cleanedSource1; filter = filter2; }
  ```

  Currently this will copy all the files that pass filter1 to the store in order to check that the resulting path starts with "/".

  Luckily `cleanSourceWith` exposes a `origSrc` property that we can check.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.starfish: init at 0.1.3
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/64692
updated_at: 2019-07-16 22:00:50
body:
  ###### Motivation for this change

  Great scipy talk and wanted to package starfish.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: liv.trivial.version: don't make it available as lib.version
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/64693
updated_at: 2019-07-19 16:30:36
body:
  because it's not uncommon that it gets accidentally used.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hledger-iadd: add a top-level alias
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/64695
updated_at: 2019-07-13 11:09:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @peti


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/64696
updated_at: 2019-07-13 11:10:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nodePackages.scuttlebot -> nodePackages.ssb-server, updated nodePackages_10_x
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/64697
updated_at: 2019-07-14 08:37:23
body:
  Package was renamed upstream.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mate.mate-user-guide: 1.22.1 -> 1.22.2
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/64698
updated_at: 2019-07-13 15:52:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [1.22.2](https://github.com/mate-desktop/mate-user-guide/releases/tag/v1.22.2)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: mate.mate-user-share: 1.22.0 -> 1.22.1
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/64699
updated_at: 2019-07-13 15:51:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to version [1.22.1](https://github.com/mate-desktop/mate-user-share/releases/tag/v1.22.1)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Add network-manager to minimal installation
user_login: SomeDer
html_url: https://github.com/NixOS/nixpkgs/issues/64700
updated_at: 2019-07-16 06:57:46
body:
  I find network-manager easier to use than wpa_supplicant, but network-manager doesn't seem to be present in the installer.


state: closed
title: xfce4-13: rename to xfce4-14
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/64702
updated_at: 2019-07-13 15:48:48
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Xfce-4.13 is the development version leading to Xfce-4.14, now at version 4.14pre2.

  https://simon.shimmerproject.org/2019/07/01/xfce-4-14pre2-released/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: open
title: chronograf: init at 1.7.11
user_login: NefixEstrada
html_url: https://github.com/NixOS/nixpkgs/pull/64703
updated_at: 2019-07-16 12:51:15
body:
  ###### Motivation for this change
  Adding Chronograf to NixOS to have the whole TICK stack available. Also, I want to use it :P

  ###### Things done
  - Created the chronograf package
  - Created the chronograf module
  - Added myself to the maintainers list

  ###### Requirements
  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: spago: init at 0.8.5.0
user_login: Shou
html_url: https://github.com/NixOS/nixpkgs/pull/64704
updated_at: 2019-07-15 14:37:15
body:
  Credit to [justinwoo/easy-purescript-nix][1].

  [1]: https://github.com/justinwoo/easy-purescript-nix

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: protontricks: init at 1.2.3
user_login: MetaDark
html_url: https://github.com/NixOS/nixpkgs/pull/64705
updated_at: 2019-07-20 15:24:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This adds the protontricks package with required dependencies: #61193.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (with gstreamerSupport = false in pkgs/top-level/wine-packages.nix, see #63829)
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: winetricks: 20190310 -> 20190615
user_login: MetaDark
html_url: https://github.com/NixOS/nixpkgs/pull/64706
updated_at: 2019-07-13 14:46:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update winetricks for protontricks (#64705)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pantheon.cerbere: 0.2.4 -> 2.5.0
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64707
updated_at: 2019-07-13 15:19:48
body:
  Fixes #60955

  ###### Motivation for this change
  Upstream should have fixes for #60955 but it seemed like it was still timing out on my
  system so I've opened this for feedback. If it's the case that it's not actually fixed I should
  be able to re-open the issue upstream.

  > https://github.com/elementary/cerbere/releases/tag/2.5.0
  > * Handle SIGHUP and SIGTERM to prevent hang on system shutdown

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prometheus_2: 2.11.0 -> 2.11.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64708
updated_at: 2019-07-15 01:47:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/prometheus/prometheus/releases/tag/v2.11.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tflint: 0.9.0 -> 0.9.1
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64709
updated_at: 2019-07-13 22:16:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/wata727/tflint/releases/tag/v0.9.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform_0_12: 0.12.3 -> 0.12.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64710
updated_at: 2019-07-14 02:20:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/hashicorp/terraform/releases/tag/v0.12.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pythonPackages.lightgbm: fix build on darwin
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64711
updated_at: 2019-07-14 17:51:30
body:
  ###### Motivation for this change
  Fix build on darwin. This was a pretty hard one to debug what with `cmake` being the most debugging-hostile tool on the planet, and build flags that don't do what they're supposed to, but in the end I forced clang to link against `libomp.dylib` by using `NIX_LDFLAGS`.

  Tested on macos 10.13.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] cloudfoundry-cli: 6.41.0 -> 6.43.0, fixing CVE-2019-3781
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64712
updated_at: 2019-07-14 18:01:07
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-3781

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gstreamer-editing-services: disable meson auto features
user_login: jerith666
html_url: https://github.com/NixOS/nixpkgs/pull/64713
updated_at: 2019-07-13 20:09:10
body:
  fixes build break after e529ec326338f660d14fa220b8440d5613d464a0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: fly: init at 5.3.0
user_login: ivanbrennan
html_url: https://github.com/NixOS/nixpkgs/pull/64714
updated_at: 2019-07-15 18:59:00
body:
  Add `fly` CLI for working with [Concourse](https://concourse-ci.org/).

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  There was no existing derivation for fly CLI.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: xonsh: 0.9.6 -> 0.9.8
user_login: Emiller88
html_url: https://github.com/NixOS/nixpkgs/pull/64715
updated_at: 2019-07-17 07:50:22
body:
  Update to correct repo, since a group was created

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Build Tensorflow and libtensorflow from source
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/64716
updated_at: 2019-07-18 14:12:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Restore Tensorflow source build while leaving binary builds . Based on @yorickvP and @timokau work.with some parts taken from both.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @uri-canva for changes regaring Bazel.

  Tested both CUDA and non-CUDA builds of the Python library, both source and binary builds. Didn't test libtensorflow, I assume that if Python library works and `ldd` output is okay libtensorflow is okay too.


state: closed
title: youtube-dl: 2019.07.12 -> 2019.07.16
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64718
updated_at: 2019-07-16 18:10:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `youtube-dl` to the latest release.
  https://github.com/ytdl-org/youtube-dl/releases/tag/2019.07.16
  **NOTE**: Updates to `youtube-dl` should be backported, thanks!
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-bloat: 0.7.1 -> 0.7.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/64719
updated_at: 2019-07-16 02:44:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `cargo-bloat` to the latest release.
  - https://github.com/RazrFalcon/cargo-bloat/releases/tag/v0.7.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wrapQtAppsHook: wrap binaries in libexec
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64720
updated_at: 2019-07-19 20:28:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  See feedback at https://github.com/NixOS/nixpkgs/pull/54525#issuecomment-511164934.
  This should be fine to do, it's already done in `wrapGAppsHook`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: scalyr: init at git-20190628
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/64721
updated_at: 2019-07-14 16:59:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  tool for using scalyr on cli

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hplip: update version to 3.19.6, fix `hpcups` segfault, enable udev rule file
user_login: Yarny0
html_url: https://github.com/NixOS/nixpkgs/pull/64722
updated_at: 2019-07-17 19:27:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  * Regular update 3.19.1 -> 3.19.6 .
  * Segfaults hound `hpcups` since 3.18.7. Add a patch to cure those.
  * Uploading firmware to certain printers requires a udev rule file that was previously deleted in the WithPlugin version of the package. The pull request reinstates that rule file and improves the script that patches paths in the file.
  * Expand package metadata with download URL.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)): *no tests available*
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`: *no depending packages*
  - [x] Tested execution of all binary files (usually in `./result/bin/`): *see note below*
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after): *new version adds 770KiB to package size*
  - [x] Ensured that relevant documentation is up to date: *none*
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  * Most binaries are just python script wrappers. Most scripts fail due to missing GUI support or other reasons. This, however, is not due to this pull request.
  * The pull request was tested with HP LaserJet 1000, connected via USB. Uploading firmware works, triggered by udev. Printing works, with `hpcups` in the filter chain. Tests have been performed with `hplipWithPlugin_3_16_11`, `hplipWithPlugin_3_18_5`, and with `hplipWithPlugin`.
  * CC maintainer @ttuegel, and @jgeerds for 3.18.5
  * @ttuegel: You removed the udev rule file from the WithPlugin version with commit 8ffd6af27e6dfae0a3b4d77db03409f62c5b8d98 ("don't use udev rules to change device owner").  Is this (still) an issue?  If it is, I can try to patch away the offending lines in the rule file.


state: open
title: lib: introduce `foreach` = flip map
user_login: danbst
html_url: https://github.com/NixOS/nixpkgs/pull/64723
updated_at: 2019-07-17 05:04:44
body:
  lib: introduce `foreach` = flip map

  The main purpose is to bring attention to `flip map`, which improves
  code readablity. It is useful when ad-hoc anonymous function
  grows two or more lines in `map` application:

  ```
      map (lcfg:
          let port = lcfg.port;
              portStr = if port != defaultPort then ":${toString port}" else "";
              scheme = if cfg.enableSSL then "https" else "http";
          in "${scheme}://cfg.hostName${portStr}"
      ) (getListen cfg);
  ```
  Compare this to `foreach`-style:
  ```
      foreach (getListen cfg) (lcfg:
          let port = lcfg.port;
              portStr = if port != defaultPort then ":${toString port}" else "";
              scheme = if cfg.enableSSL then "https" else "http";
          in "${scheme}://cfg.hostName${portStr}"
      );
  ```
  (the example was taken with modifications from apache-httpd module)

  This is similar to Haskell's `for` (http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Traversable.html#v:for)

  Extracted and simplified from a more radical approach in https://github.com/NixOS/nixpkgs/pull/57091.


state: closed
title: [r19.03] redis: 5.0.3 -> 5.0.5, fixing CVE-2019-10192 & CVE-2019-10193
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64724
updated_at: 2019-07-14 12:53:02
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-10192
  https://nvd.nist.gov/vuln/detail/CVE-2019-10193

  _Builds_ fine on macos 10.13, but the reverse dependencies seem very unhappy on my machine with or without this bump, so unable to sensibly check them.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Completed missing meta fields
user_login: craigem
html_url: https://github.com/NixOS/nixpkgs/pull/64725
updated_at: 2019-07-15 02:26:17
body:
  ###### Motivation for this change

  More complete package meta data.

  This change just adds missing fields such as long and short descriptions, licence and project home page.

  ###### Things done

  - [ X ] Ensured that relevant documentation is up to date
  - [ X ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: brlaser: add supported printer model
user_login: elohmeier
html_url: https://github.com/NixOS/nixpkgs/pull/64726
updated_at: 2019-07-14 11:50:57
body:
  I've just successfully used the brlaser driver to print a page on my Brother MFC-7440N printer and would like to let others know.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coq: 8.10+beta1 -> 8.10+beta2
user_login: Zimmi48
html_url: https://github.com/NixOS/nixpkgs/pull/64727
updated_at: 2019-07-15 19:01:25
body:
  ###### Motivation for this change

  New testing version of Coq 8.10 released a while ago.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.gnome-boxes: fix hardcoded emulator path
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/64728
updated_at: 2019-07-15 23:24:48
body:
  To avoid this you must install the qemu binaries globally in some
  manner.

  Fixes #57931

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Fix #57931.

  Note that this will probably only affect newly created VMs.
  Past one's will probably have to be corrected manually.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] dosbox: add patches for CVE-2019-7165 & CVE-2019-12594
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64729
updated_at: 2019-07-18 21:33:13
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-7165
  https://nvd.nist.gov/vuln/detail/CVE-2019-12594

  https://sourceforge.net/p/dosbox/bugs/508/

  Raw patches aren't easily extractable from sourceforge's repos, so am using debian's package SCM.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: syncthing: 1.1.4 -> 1.2.0
user_login: emmanuelrosa
html_url: https://github.com/NixOS/nixpkgs/pull/64730
updated_at: 2019-07-19 13:30:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The motivation for this change is to upgrade syntching from 1.1.4 to 1.2.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions (Xubuntu)
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
     - [x] `syncthing-init` - failed; also fails with syncthing-1.1.4
     - [X] `syncthing-relay` - passed
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
     - [x] `syncthing-gtk`
     - [X] `qsyncthingtray`
     - [x] `syncthing-tray` 
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after): before = 59608632, after = 61636056
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ##### Release notes

  - This release does not interoperate with Syncthing 0.14.45 or older.
  - This release adds QUIC with NAT traversal as a new transport protocol. TCP is usually more performant and remains the preferred way of connection when possible.
  - **This release adds automatic crash reporting. See https://docs.syncthing.net/users/crashrep.html for details.**
  - This release makes large / variable block size the only available mode of operation; small / fixed blocks are deprecated. See https://docs.syncthing.net/advanced/folder-uselargeblocks.html for details.
  - This release reverts the version naming change in #4586 (v1.1.4). Versions are now named with the time of their archiving, and the file modification time is unchanged when archiving. An exception to this is the "Trashcan" versioner which does not modify the name - instead it does set the file modification time the time of archiving.


  ---


state: closed
title: dosbox: 0.74-2 -> 0.74-3, fixing CVE-2019-7165, CVE-2019-12594
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64731
updated_at: 2019-07-18 21:35:52
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-7165
  https://nvd.nist.gov/vuln/detail/CVE-2019-12594

  See also #64729
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: 67.0.4 -> 68.0, firefox-esr: 60.7.2esr -> 68.0esr, rust-cbindgen: 0.8.3 -> 0.8.7
user_login: taku0
html_url: https://github.com/NixOS/nixpkgs/pull/64733
updated_at: 2019-07-14 21:07:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  - Critical security fixes
  - Other improvements
  - ESR is now based on version 68.

  https://www.mozilla.org/en-US/firefox/68.0/releasenotes/
  https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/

  Related: #64577

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  `fix-virtualenv-symlinks.patch` deletes all symlinks and `activate_this.py` in virtualenv to force recreate it. Otherwise it results in `OSError: [Errno 17] File exists: '/build/firefox-68.0/obj-x86_64-pc-linux-gnu/_virtualenvs/init/lib/python2.7/lib-dynload'`. See also https://github.com/NixOS/nixpkgs/pull/64577#issuecomment-510131246.

  `rust-cbindgen` and `nss` are required to be up-to-date. `rust-cbindgen` needs nightly compiler for now, so I have added `RUSTC_BOOTSTRAP = 1;`. See https://github.com/eqrion/cbindgen/issues/338 for details.

  This PR may results in mass rebuild. Should I PR against the staging branch rather than the master?


state: closed
title: zeromq: 4.3.1 -> 4.3.2, fixing CVE-2019-13132
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64734
updated_at: 2019-07-17 08:25:36
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-13132
  https://github.com/zeromq/libzmq/issues/3558

  The set of reverse dependencies is ... large, hence this is pointed at `staging`. I have _not_ attempted a `nox-review`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] zeromq: 4.3.1 -> 4.3.2, fixing CVE-2019-13132
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64735
updated_at: 2019-07-18 21:31:43
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-13132
  https://github.com/zeromq/libzmq/issues/3558

  See #64734

  Same deal with the reverse dependencies, hence `staging-19.03`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: add modprobe.d config options for stage 1 (initrd)
user_login: ChrisWills
html_url: https://github.com/NixOS/nixpkgs/pull/64737
updated_at: 2019-07-15 14:33:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I am using Nixos as a Qemu/KVM hypervisor and in order to do PCI-passthrough, I need fine grained control over /etc/modprobe.d/nixos.conf in both the main system and during the stage 1 boot (initrd). A common pattern is to put a line like the following in /etc/modprobe.d/nixos.conf (in both stage 1 and stage 2):
  `options vfio-pci ids=1000:0072`

  Without this line in stage 1, the normal driver for the device gets attached in stage 1 and persists into stage 2. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: magnetico: init package and service
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/64738
updated_at: 2019-07-21 09:05:15
body:
  ###### Motivation for this change
  Wanted to self-host a DHT crawler.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change
  - [x] Tested execution of all binary files
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I have tested basically everything. the crawler works, the web ui works, also authentication.


state: open
title: npm2nix should be removed from nixpkgs
user_login: chaoflow
html_url: https://github.com/NixOS/nixpkgs/issues/64739
updated_at: 2019-07-16 14:45:53
body:
  ## Issue description

  [npm2nix](https://github.com/NixOS/npm2nix) is unmaintained, superseded by node2nix and should therefore be removed from nixpkgs

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: pythonPackages.pyspark: call wrapped python script correctly
user_login: mattmelling
html_url: https://github.com/NixOS/nixpkgs/pull/64740
updated_at: 2019-07-15 20:23:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  See #64358. `pyspark` tries to figure out `SPARK_HOME` by calling a Python script, but it has already been wrapped. This change invokes the wrapped script correctly, as well as sets a correct search path for the `pyspark` package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/gitea: Support SMTP without pw in the store
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/64741
updated_at: 2019-07-21 18:07:50
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox: 67.0.4 -> 68.0, firefox-esr: 60.7.2esr -> 68.0esr, rust-cbindgen: 0.8.3 -> 0.8.7 (v2)
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/64742
updated_at: 2019-07-16 22:42:31
body:
  ###### Motivation for this change

  Newer revision of #64733 since I am not allowed to update the source branch.

  - Critical security fixes
  - Other improvements
  - ESR is now based on version 68.

  https://www.mozilla.org/en-US/firefox/68.0/releasenotes/
  https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/

  Compiling all the versions now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: google-fonts: 2018-07-13 -> 2019-07-14
user_login: spacekookie
html_url: https://github.com/NixOS/nixpkgs/pull/64743
updated_at: 2019-07-21 11:21:21
body:
  ###### Motivation for this change

  This PR updates the `google-fonts` package to a newer version.
  There's some more post-processing to be done because of duplicate
  fonts. The reasoning is documented and it generally seems to work.

  I'm also removing the fixed output derivation hashes. Generally
  they don't really add much in terms of reproducable builds. They
  make updating the package more annoying and cumbersome. Plus, there's
  the issue where if the build starts failing at some point, this will
  be shadowed by the fact that people will just get hydra cached versions.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: squid, squid4: bump/add patch fixing CVE-2019-13345
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64744
updated_at: 2019-07-15 10:34:55
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-13345

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [r19.03] squid, squid4: add patches fixing CVE-2019-13345
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/64745
updated_at: 2019-07-15 10:35:15
body:
  ##### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-13345

  See also #64744
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: stack is broken on Nixos
user_login: greydot
html_url: https://github.com/NixOS/nixpkgs/issues/64746
updated_at: 2019-07-15 16:41:53
body:
  ## Issue description
  See https://github.com/commercialhaskell/stack/issues/4864 for more info. This bug is fixed in stack v2.1.3, while nixpkgs still has v2.1.1.1.


  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: open
title: yaml-cpp: init at 0.6.2
user_login: spacekookie
html_url: https://github.com/NixOS/nixpkgs/pull/64747
updated_at: 2019-07-15 08:55:28
body:
  ###### Things done

  I did test using this library in a project, which will be packaged at a later time.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.buildPerlModule: allow pre/post hooks
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/64748
updated_at: 2019-07-17 08:23:41
body:
  ```buildPerlModule``` did not allow to specify hooks like ```preCheck``` or ```postInstall```
  it also did not allow to override ```buildPhase``` or ```installPhase```

  Working with hooks was a subtle difference between ```buildPerlPackage``` and ```buildPerlModule``` and replacing ```buildPerlPackage``` with ```buildPerlModule``` (or the other way around) resulted with unexpected effects.

  @aanderse @srhb @rycee 


state: closed
title: vimPlugins.coc-nvim: 0.0.72 -> 0.0.73 (and change override)
user_login: malob
html_url: https://github.com/NixOS/nixpkgs/pull/64749
updated_at: 2019-07-18 16:53:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `coc.nvim` requires a `build/index.js` file that's only available in the release version. As such, auto-updating isn't possible with the current script since master doesn't contain this file.

  The previous fix for this added the `index.js` file in for a given release, but this caused issues since when vimPlugins was auto-updated, the override wasn't always updated, resulting in the `index.js` file being out of sync with the rest of the plugin.

  This override solves that problem by completely overriding the plugin with a release version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: firmware-linux-unfree: update to 2019-06-18
user_login: georgewhewell
html_url: https://github.com/NixOS/nixpkgs/pull/64750
updated_at: 2019-07-14 22:49:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  adds firmware for intel ax200

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: pdfcpu: 0.1.25 -> 0.2.1
user_login: doronbehar
html_url: https://github.com/NixOS/nixpkgs/pull/64752
updated_at: 2019-07-16 17:48:53
body:
  ~I switched to buildGoPackage from buildGoModule. There's some problem with using Go modules with this version, upstream was reported: https://github.com/hhrutter/pdfcpu/issues/92 . I used [vgo2nix](https://github.com/adisbladis/vgo2nix) to generate `deps.nix`.~ Upstream fix from 0.2 -> 0.2.1 removed the need for that.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Updating documentation about adding new Vim plugins
user_login: malob
html_url: https://github.com/NixOS/nixpkgs/pull/64753
updated_at: 2019-07-15 16:08:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Documentation about adding Vim plugins to nixpkgs was out of date and scant on details.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cointop: 1.2.0 -> 1.3.4
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64756
updated_at: 2019-07-15 11:22:13
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/miguelmota/cointop/releases/tag/1.3.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37: fix distutils C++ patch
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/64758
updated_at: 2019-07-15 12:02:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update distutils patch to the upstream changes.
  See: https://github.com/python/cpython/commit/6c0e0d1

  Fixes https://github.com/NixOS/nixpkgs/issues/64615

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cannot enable GeoIP2 within Matomo
user_login: joseph-long
html_url: https://github.com/NixOS/nixpkgs/issues/64759
updated_at: 2019-07-15 03:55:04
body:
  ## Issue description

  Matomo wants to manage GeoIP2 database files itself, but since it lives in the Nix store, it can't.

  ### Steps to reproduce

  `services.matomo.enable = true;`, complete setup, and go to activate GeoIP2 in the web-based admin interface under Administration -> System - Geolocation. The option will be grayed out.

  <img width="833" alt="image" src="https://user-images.githubusercontent.com/31168267/61194873-5fcc7800-a679-11e9-8c32-4d5f60f00022.png">


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.48, NixOS, 19.03.172844.caacbe98ce1 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172844.caacbe98ce1"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: localstack: init at 0.9.6
user_login: mogorman
html_url: https://github.com/NixOS/nixpkgs/pull/64760
updated_at: 2019-07-15 13:55:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I wanted to play with localstack. others do to https://github.com/NixOS/nixpkgs/issues/50445

  this is still a wip but thought id post here if others wanted to play while i get it working

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: asdf: 3.3.2 -> 3.3.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64761
updated_at: 2019-07-19 03:56:30
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/asdf/versions.



  meta.description for asdf is: '"Standard software-system definition library for Common Lisp"'.


  meta.homepage for asdf is: '""


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.3.3 with grep in /nix/store/bizskr92zsgsz5c8jffh4kba10c8y20m-asdf-3.3.3
  - directory tree listing: https://gist.github.com/150e99c2e379dd125c192d40b597d81e
  - du listing: https://gist.github.com/8482a5d896d2d0d0e28c481f01a18df0

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  54 total rebuild path(s)

  52 package rebuild(s)

  52 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  asdf
  lispPackages.caveman
  lispPackages.cffi
  lispPackages.cffi-grovel
  lispPackages.cffi-toolchain
  lispPackages.circular-streams
  lispPackages.cl-async
  lispPackages.cl-async-base
  lispPackages.cl-async-repl
  lispPackages.cl-async-ssl
  lispPackages.cl-async-util
  lispPackages.cl-fuse
  lispPackages.cl-fuse-meta-fs
  lispPackages.cl-l10n
  lispPackages.cl-libuv
  lispPackages.cl-mysql
  lispPackages.cl-pdf
  lispPackages.cl-project
  lispPackages.cl-smtp
  lispPackages.cl-test-more
  lispPackages.cl-typesetting
  lispPackages.cl_plus_ssl
  lispPackages.clack
  lispPackages.clack-handler-hunchentoot
  lispPackages.clack-test
  lispPackages.clack-v1-compat
  lispPackages.dbd-mysql
  lispPackages.dbd-sqlite3
  lispPackages.dexador
  lispPackages.drakma
  lispPackages.fast-http
  lispPackages.fast-io
  lispPackages.http-body
  lispPackages.hu_dot_dwim_dot_asdf
  lispPackages.hu_dot_dwim_dot_stefil
  lispPackages.hunchentoot
  lispPackages.iolib
  lispPackages.iolib_dot_grovel
  lispPackages.jonathan
  lispPackages.lack-middleware-backtrace
  lispPackages.lev
  lispPackages.lfarm-ssl
  lispPackages.prove
  lispPackages.query-fs
  lispPackages.quicklisp-to-nix
  lispPackages.quicklisp-to-nix-system-info
  lispPackages.smart-buffer
  lispPackages.sqlite
  lispPackages.static-vectors
  lispPackages.uiop

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/bizskr92zsgsz5c8jffh4kba10c8y20m-asdf-3.3.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A asdf https://github.com/r-ryantm/nixpkgs/archive/bd31f06d8758306e862ee83458559010d8db4fec.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/bizskr92zsgsz5c8jffh4kba10c8y20m-asdf-3.3.3
  ls -la /nix/store/bizskr92zsgsz5c8jffh4kba10c8y20m-asdf-3.3.3/bin
  ```


  </details>
  <br/>


  cc @7c6f434c for testing.


state: closed
title: ammonite: 1.6.8 -> 1.6.9
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64762
updated_at: 2019-07-19 03:56:27
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ammonite/versions.



  meta.description for ammonite is: '"Improved Scala REPL"'.


  meta.homepage for ammonite is: '"http://www.lihaoyi.com/Ammonite/"

  [Release on GitHub](https://github.com/lihaoyi/Ammonite/releases/tag/1.6.9)


  [Compare changes on GitHub](https://github.com/lihaoyi/Ammonite/compare/1.6.8...1.6.9)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.6.9 with grep in /nix/store/ga24g3pl7wfrc9fwvkzs546mrviswjv5-ammonite-1.6.9
  - directory tree listing: https://gist.github.com/6ded9df314c520ee535b757e46a61878
  - du listing: https://gist.github.com/a79111791a82718e2849fce57ba9e061

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  ammonite

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/ga24g3pl7wfrc9fwvkzs546mrviswjv5-ammonite-1.6.9 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ammonite https://github.com/r-ryantm/nixpkgs/archive/5b6c0a15da09852cf3619ecdd35713528bdbe4ef.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/ga24g3pl7wfrc9fwvkzs546mrviswjv5-ammonite-1.6.9
  ls -la /nix/store/ga24g3pl7wfrc9fwvkzs546mrviswjv5-ammonite-1.6.9/bin
  ```


  </details>
  <br/>


  cc @nequissimus for testing.


state: closed
title: amazon-ecs-cli: 1.14.1 -> 1.15.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64763
updated_at: 2019-07-19 03:56:24
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/amazon-ecs-cli/versions.



  meta.description for amazon-ecs-cli is: '"The Amazon ECS command line interface"'.


  meta.homepage for amazon-ecs-cli is: '"https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_CLI.html"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.15.1 with grep in /nix/store/i2hzjhbgslx6szw1njwsf2nszjipg7v6-amazon-ecs-cli-1.15.1
  - directory tree listing: https://gist.github.com/82e891dd991601f7cd74eb7fae637083
  - du listing: https://gist.github.com/d6a483d3c22c35d88f383ae75cab1ed9

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  0 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  0 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  amazon-ecs-cli

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/i2hzjhbgslx6szw1njwsf2nszjipg7v6-amazon-ecs-cli-1.15.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A amazon-ecs-cli https://github.com/r-ryantm/nixpkgs/archive/6f8a7408d9084252db7572a0efebe5f78c4f8acc.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/i2hzjhbgslx6szw1njwsf2nszjipg7v6-amazon-ecs-cli-1.15.1
  ls -la /nix/store/i2hzjhbgslx6szw1njwsf2nszjipg7v6-amazon-ecs-cli-1.15.1/bin
  ```


  </details>
  <br/>


  cc @scriptkiddi for testing.


state: closed
title: calibre: 3.44.0 -> 3.45.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64765
updated_at: 2019-07-19 03:56:47
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/calibre/versions.



  meta.description for calibre is: '"Comprehensive e-book software"'.


  meta.homepage for calibre is: '"https://calibre-ebook.com"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.45.2 with grep in /nix/store/n1fgcyjcb6a22a51z923ymvjny9y1sbs-calibre-3.45.2
  - directory tree listing: https://gist.github.com/b0acb02e11b29426803709ccb5b76901
  - du listing: https://gist.github.com/23e05e23c970a639830be58e66a68663

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  calibre

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/n1fgcyjcb6a22a51z923ymvjny9y1sbs-calibre-3.45.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A calibre https://github.com/r-ryantm/nixpkgs/archive/e9a6ed87b307f1f8c6d4937eb89769048a76e1f0.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/n1fgcyjcb6a22a51z923ymvjny9y1sbs-calibre-3.45.2
  ls -la /nix/store/n1fgcyjcb6a22a51z923ymvjny9y1sbs-calibre-3.45.2/bin
  ```


  </details>
  <br/>


  cc @domenkozar @pSub @AndersonTorres for testing.


state: closed
title: bdf2psf: 1.191 -> 1.192
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64766
updated_at: 2019-07-19 03:56:37
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bdf2psf/versions.



  meta.description for bdf2psf is: '"BDF to PSF converter"'.


  meta.homepage for bdf2psf is: '"https://packages.debian.org/sid/bdf2psf"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.192 with grep in /nix/store/y1w62akyix5q5f4f8fiijq708fxydgz4-bdf2psf-1.192
  - directory tree listing: https://gist.github.com/427b0df7b51127c78171e8acb4b5411e
  - du listing: https://gist.github.com/f117c5292f78712e70456fdb5f1f7563

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  bdf2psf

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/y1w62akyix5q5f4f8fiijq708fxydgz4-bdf2psf-1.192 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A bdf2psf https://github.com/r-ryantm/nixpkgs/archive/869fe62ddd6f2c21ca98cd9b84ffb27a344ffa0d.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/y1w62akyix5q5f4f8fiijq708fxydgz4-bdf2psf-1.192
  ls -la /nix/store/y1w62akyix5q5f4f8fiijq708fxydgz4-bdf2psf-1.192/bin
  ```


  </details>
  <br/>


  cc @rnhmjoj @vrthra for testing.


state: closed
title: adwaita-qt: 1.0 -> 1.0.91
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64767
updated_at: 2019-07-19 03:56:20
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/adwaita-qt/versions.



  meta.description for adwaita-qt is: '"A style to bend Qt applications to look like they belong into GNOME Shell"'.


  meta.homepage for adwaita-qt is: '"https://github.com/FedoraQt/adwaita-qt"

  [Release on GitHub](https://github.com/FedoraQt/adwaita-qt/releases/tag/1.0.91)


  [Compare changes on GitHub](https://github.com/FedoraQt/adwaita-qt/compare/1.0...1.0.91)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/1a558d43dacc5d341c1afe807d12392f
  - du listing: https://gist.github.com/ffdf86c239453728960eca8c958c7e91

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  adwaita-qt

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/n533ihnnl1q9jmyshyfr71vzlpqh3n70-adwaita-qt-1.0.91 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A adwaita-qt https://github.com/r-ryantm/nixpkgs/archive/835fea207b86e990bdc0993e32c8be61c404cf2c.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/n533ihnnl1q9jmyshyfr71vzlpqh3n70-adwaita-qt-1.0.91
  ls -la /nix/store/n533ihnnl1q9jmyshyfr71vzlpqh3n70-adwaita-qt-1.0.91/bin
  ```


  </details>
  <br/>


  cc @worldofpeace for testing.


state: closed
title: bindfs: 1.14.0 -> 1.14.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64768
updated_at: 2019-07-19 03:56:44
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bindfs/versions.



  meta.description for bindfs is: '"A FUSE filesystem for mounting a directory to another location"'.


  meta.homepage for bindfs is: '"https://bindfs.org"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.14.1 with grep in /nix/store/b87icd2526nqssy1j6mjwsjl4i9fpj6h-bindfs-1.14.1
  - directory tree listing: https://gist.github.com/06cd08ca1960a9c32fd8fc818e62c04e
  - du listing: https://gist.github.com/7040345f7c6ae2497e54d4d580abbbe2

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  bindfs

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/b87icd2526nqssy1j6mjwsjl4i9fpj6h-bindfs-1.14.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A bindfs https://github.com/r-ryantm/nixpkgs/archive/08435fd09bd377bdb830bfa0b9f61c4f5d5b496f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/b87icd2526nqssy1j6mjwsjl4i9fpj6h-bindfs-1.14.1
  ls -la /nix/store/b87icd2526nqssy1j6mjwsjl4i9fpj6h-bindfs-1.14.1/bin
  ```


  </details>
  <br/>


  cc @lovek323 for testing.


state: closed
title: commonsLang: 3.6 -> 3.8.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64769
updated_at: 2019-07-19 03:56:54
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/commons-lang/versions.



  meta.description for commonsLang is: '"Provides additional methods to manipulate standard Java library classes"'.


  meta.homepage for commonsLang is: '"http://commons.apache.org/proper/commons-lang"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/b0854f7ba7d93302964e53c711382b9f
  - du listing: https://gist.github.com/0422ea39a6d81f7fb0f6b2f13026727d

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  commonsLang

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/wc1vhpb6xsl443whbhc96rfari4jmmif-commons-lang-3.8.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A commonsLang https://github.com/r-ryantm/nixpkgs/archive/d9aa1239c1851096dac37f8f799488fb049ad5e0.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/wc1vhpb6xsl443whbhc96rfari4jmmif-commons-lang-3.8.1
  ls -la /nix/store/wc1vhpb6xsl443whbhc96rfari4jmmif-commons-lang-3.8.1/bin
  ```


  </details>
  <br/>


  cc @copumpkin for testing.


state: closed
title: babeltrace: 1.5.6 -> 1.5.7
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64770
updated_at: 2019-07-19 03:56:34
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/babeltrace/versions.



  meta.description for babeltrace is: '"Command-line tool and library to read and convert LTTng tracefiles"'.


  meta.homepage for babeltrace is: '"https://www.efficios.com/babeltrace"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.5.7 with grep in /nix/store/2fjimfpdla6n0r6ci6svcy1gvnkj29b1-babeltrace-1.5.7
  - directory tree listing: https://gist.github.com/6fb7e62c4ca7ecf90cf36ea9646f8020
  - du listing: https://gist.github.com/a14ec336e922946085e8b3bd387e9b35

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  28 total rebuild path(s)

  8 package rebuild(s)

  8 x86_64-linux rebuild(s)
  8 i686-linux rebuild(s)
  4 x86_64-darwin rebuild(s)
  8 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  babeltrace
  bareos
  ceph
  ceph-dev
  libceph
  lttv
  samba4Full
  sambaFull

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/2fjimfpdla6n0r6ci6svcy1gvnkj29b1-babeltrace-1.5.7 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A babeltrace https://github.com/r-ryantm/nixpkgs/archive/2c045c8f6def27614ca211814978274d617dd86f.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/2fjimfpdla6n0r6ci6svcy1gvnkj29b1-babeltrace-1.5.7
  ls -la /nix/store/2fjimfpdla6n0r6ci6svcy1gvnkj29b1-babeltrace-1.5.7/bin
  ```


  </details>
  <br/>


  cc @bjornfor for testing.


state: closed
title: aws-checksums: 0.1.2 -> 0.1.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64771
updated_at: 2019-07-20 08:00:07
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/aws-checksums/versions.



  meta.description for aws-checksums is: '"HW accelerated CRC32c and CRC32"'.


  meta.homepage for aws-checksums is: '"https://github.com/awslabs/aws-checksums"

  [Release on GitHub](https://github.com/awslabs/aws-checksums/releases/tag/v0.1.3)


  [Compare changes on GitHub](https://github.com/awslabs/aws-checksums/compare/v0.1.2...v0.1.3)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.1.3 with grep in /nix/store/fc4c1im226bv41rz6490q962cz5fsm2j-aws-checksums-0.1.3
  - directory tree listing: https://gist.github.com/d2a9d6cde81a3f04983fb56781ddc5ee
  - du listing: https://gist.github.com/2dd5e10690b44c99c81a95595a602f91

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  183 total rebuild path(s)

  51 package rebuild(s)

  51 x86_64-linux rebuild(s)
  47 i686-linux rebuild(s)
  38 x86_64-darwin rebuild(s)
  47 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  aws-c-event-stream
  aws-checksums
  aws-sdk-cpp
  bundix
  cabal2nix
  common-updater-scripts
  dep2nix
  discover
  disnix
  disnixos
  fusionInventory
  gnome3.gnome-packagekit
  gnome3.gnome-software
  gnome3.simple-scan
  go2nix
  haskellPackages.nix-paths
  hydra
  lispPackages.quicklisp-to-nix
  lispPackages.quicklisp-to-nix-system-info
  nix
  nix-bundle
  nix-du
  nix-exec
  nix-index
  nix-pin
  nix-plugins
  nix-prefetch
  nix-prefetch-bzr
  nix-prefetch-cvs
  nix-prefetch-docker
  nix-prefetch-git
  nix-prefetch-hg
  nix-prefetch-scripts
  nix-prefetch-svn
  nix-review
  nix-serve
  nix-update-source
  nixFlakes
  nixStable
  nixUnstable
  nixui
  osquery
  packagekit
  packagekit-qt
  plasma5.discover
  pypi2nix
  python37Packages.nixpkgs
  python37Packages.pythonix
  simple-scan
  vgo2nix

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/fc4c1im226bv41rz6490q962cz5fsm2j-aws-checksums-0.1.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A aws-checksums https://github.com/r-ryantm/nixpkgs/archive/e6f566c5bed04f20f205602856f2943bcbd78f39.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/fc4c1im226bv41rz6490q962cz5fsm2j-aws-checksums-0.1.3
  ls -la /nix/store/fc4c1im226bv41rz6490q962cz5fsm2j-aws-checksums-0.1.3/bin
  ```


  </details>
  <br/>


  cc @orivej @edolstra for testing.


state: closed
title: iputils: Completed missing meta.longDescription
user_login: craigem
html_url: https://github.com/NixOS/nixpkgs/pull/64772
updated_at: 2019-07-16 02:56:35
body:
  ###### Motivation for this change

  Provided a more complete and fleshed out meta.longDescription from the project's README

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: exa: 0.8.0 -> 0.9.0
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/64773
updated_at: 2019-07-15 18:28:15
body:
  ###### Motivation for this change
  https://github.com/ogham/exa/releases/tag/v0.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS (with sandbox)
     - [X] macOS (without sandbox)
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  CC @ehegnes 

  Also added myself as a maintainer.


state: closed
title: python37Packages.acme-tiny: 4.0.4 -> 4.1.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64774
updated_at: 2019-07-19 04:00:27
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-acme-tiny/versions.



  meta.description for python37Packages.acme-tiny is: '"A tiny script to issue and renew TLS certs from Let's Encrypt"'.


  meta.homepage for python37Packages.acme-tiny is: '"https://github.com/diafygi/acme-tiny"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - Warning: a test defined in `passthru.tests` did not pass
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 4.1.0 with grep in /nix/store/frfb47g3hmby4mi3gf4xj17b8048j4rc-python3.7-acme-tiny-4.1.0
  - directory tree listing: https://gist.github.com/eb1b2653d6bd866ba373e578c4640ed7
  - du listing: https://gist.github.com/3bb77debcf7ccdefa9c3eda70b7a237e

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  8 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  2 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python27Packages.acme-tiny
  python37Packages.acme-tiny

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/frfb47g3hmby4mi3gf4xj17b8048j4rc-python3.7-acme-tiny-4.1.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.acme-tiny https://github.com/r-ryantm/nixpkgs/archive/c990b091f53b6f52b4db051d0795c85cd60024c7.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/frfb47g3hmby4mi3gf4xj17b8048j4rc-python3.7-acme-tiny-4.1.0
  ls -la /nix/store/frfb47g3hmby4mi3gf4xj17b8048j4rc-python3.7-acme-tiny-4.1.0/bin
  ```


  </details>
  <br/>


state: closed
title: libargon2: 20171227 -> 20190702
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64775
updated_at: 2019-07-19 03:58:22
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libargon2/versions.



  meta.description for libargon2 is: '"A key derivation function that was selected as the winner of the Password Hashing Competition in July 2015"'.


  meta.homepage for libargon2 is: '"https://www.argon2.com/"

  [Release on GitHub](https://github.com/P-H-C/phc-winner-argon2/releases/tag/20190702)


  [Compare changes on GitHub](https://github.com/P-H-C/phc-winner-argon2/compare/20171227...20190702)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 20190702 with grep in /nix/store/fx3sx1fxlm56902v2jwcrj1yaifyb840-libargon2-20190702
  - directory tree listing: https://gist.github.com/55ec0d5f49c6d25dd98394bb03801509
  - du listing: https://gist.github.com/15ed2cecb6979ba7c1a6cc49152bd5ab

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  275 total rebuild path(s)

  200 package rebuild(s)

  200 x86_64-linux rebuild(s)
  28 i686-linux rebuild(s)
  19 x86_64-darwin rebuild(s)
  28 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  arcanist
  drush
  hhvm
  icingaweb2
  kcachegrind
  kdeApplications.kcachegrind
  keepassxc
  libargon2
  lsp-plugins
  matomo
  nagios
  nextcloud-news-updater
  opendht
  phoronix-test-suite
  php
  php-embed
  php-unit
  php72
  php72-embed
  php72-unit
  php72Packages-unit.apcu
  php72Packages-unit.apcu_bc
  php72Packages-unit.ast
  php72Packages-unit.box
  php72Packages-unit.composer
  php72Packages-unit.couchbase
  php72Packages-unit.event
  php72Packages-unit.igbinary
  php72Packages-unit.imagick
  php72Packages-unit.mailparse
  php72Packages-unit.memcached
  php72Packages-unit.oci8
  php72Packages-unit.pcs
  php72Packages-unit.pdo_sqlsrv
  php72Packages-unit.php-cs-fixer
  php72Packages-unit.php-parallel-lint
  php72Packages-unit.php_excel
  php72Packages-unit.phpcbf
  php72Packages-unit.phpcs
  php72Packages-unit.phpstan
  php72Packages-unit.pinba
  php72Packages-unit.pinba7
  php72Packages-unit.protobuf
  php72Packages-unit.redis
  php72Packages-unit.sqlsrv
  php72Packages-unit.v8
  php72Packages-unit.v8js
  php72Packages-unit.xdebug
  php72Packages-unit.yaml
  php72Packages-unit.zmq

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/fx3sx1fxlm56902v2jwcrj1yaifyb840-libargon2-20190702 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A libargon2 https://github.com/r-ryantm/nixpkgs/archive/537d051e12112e891e52dfa4a63ccadd4c5786a2.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/fx3sx1fxlm56902v2jwcrj1yaifyb840-libargon2-20190702
  ls -la /nix/store/fx3sx1fxlm56902v2jwcrj1yaifyb840-libargon2-20190702/bin
  ```


  </details>
  <br/>


  cc @Radvendii @olynch for testing.


state: closed
title: binaryen: 84 -> 86
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64776
updated_at: 2019-07-19 03:56:41
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/binaryen/versions.



  meta.description for binaryen is: '"Compiler infrastructure and toolchain library for WebAssembly, in C++"'.


  meta.homepage for binaryen is: '"https://github.com/WebAssembly/binaryen"

  [Release on GitHub](https://github.com/WebAssembly/binaryen/releases/tag/version_86)


  [Compare changes on GitHub](https://github.com/WebAssembly/binaryen/compare/version_84...version_86)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 86 with grep in /nix/store/8ra51342zl61h0iq35r2lrq875cjakch-binaryen-86
  - directory tree listing: https://gist.github.com/cbb643afb37e7d0fe70130677cfb1e3f
  - du listing: https://gist.github.com/dd36683e6375f52136547c407e1cebf8

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  binaryen

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/8ra51342zl61h0iq35r2lrq875cjakch-binaryen-86 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A binaryen https://github.com/r-ryantm/nixpkgs/archive/980dd7595606b295fccd98d6b12336885b808d15.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/8ra51342zl61h0iq35r2lrq875cjakch-binaryen-86
  ls -la /nix/store/8ra51342zl61h0iq35r2lrq875cjakch-binaryen-86/bin
  ```


  </details>
  <br/>


  cc @asppsa for testing.


state: closed
title: ytcc: enable tests
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/64777
updated_at: 2019-07-18 16:52:22
body:
  ###### Motivation for this change
  Was ripgrepping through nixpkgs and noticed it had tests disabled, enabled to verify it's not going to be broken by upstream dependencies.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Ensured that relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ```
  $ nix path-info -Sh ./result
  /nix/store/hhjr5fk9zbwwpfzjdwzrvk2afps43sjj-ytcc-1.8.1   244.1M
  ```
  ```
  $ nix-review wip
  ...
  [1 built, 0.0 MiB DL]
  1 package were build:
  ytcc

  ```


state: open
title: Add patool package
user_login: rhajdacki
html_url: https://github.com/NixOS/nixpkgs/issues/64778
updated_at: 2019-07-15 09:22:19
body:
  patool is a handy app to handle different types of archives using one unified command.
  Source:
  https://github.com/wummel/patool

  It is basically newer atool which is already in packages.


state: closed
title: ckbcomp: 1.191 -> 1.192
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/64779
updated_at: 2019-07-19 03:56:51
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ckbcomp/versions.



  meta.description for ckbcomp is: '"Compiles a XKB keyboard description to a keymap suitable for loadkeys"'.


  meta.homepage for ckbcomp is: '"https://salsa.debian.org/installer-team/console-setup"


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - The tests defined in `passthru.tests`, if any, passed
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - directory tree listing: https://gist.github.com/ec0aac28f684e5f73c5de5fb07ed1110
  - du listing: https://gist.github.com/fbbd632f288db93a4f78300a606d72d4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  7 total rebuild path(s)

  2 package rebuild(s)

  2 x86_64-linux rebuild(s)
  2 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  2 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  calamares
  ckbcomp

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/4q8j2nwys04ajzjv9cr58wvsvvcl0bwq-ckbcomp-1.192 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ckbcomp https://github.com/r-ryantm/nixpkgs/archive/0c355e254d8cabd6bfd73f76c668bbf50214d5b9.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/4q8j2nwys04ajzjv9cr58wvsvvcl0bwq-ckbcomp-1.192
  ls -la /nix/store/4q8j2nwys04ajzjv9cr58wvsvvcl0bwq-ckbcomp-1.192/bin
  ```


  </details>
  <br/>


  cc @dezgeg for testing.


