# issues

state: closed
title: stress-ng: 0.09.54 -> 0.09.57
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59707
updated_at: 2019-04-26 02:58:42
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/stress-ng/versions.



  meta.description for stress-ng is: '"Stress test a computer system"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.09.57 with grep in /nix/store/w3vqpqkgx9cd3jy80h4dz1r23npdh61h-stress-ng-0.09.57
  - directory tree listing: https://gist.github.com/34327bc6375546f400d0f0f25a7cf833
  - du listing: https://gist.github.com/ea64a3ceec1287f489be06b90041ffa4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  stress-ng

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/w3vqpqkgx9cd3jy80h4dz1r23npdh61h-stress-ng-0.09.57 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A stress-ng https://github.com/r-ryantm/nixpkgs/archive/806a2f581947057890dd6a7824d4903524605308.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/w3vqpqkgx9cd3jy80h4dz1r23npdh61h-stress-ng-0.09.57
  ls -la /nix/store/w3vqpqkgx9cd3jy80h4dz1r23npdh61h-stress-ng-0.09.57/bin
  ```


  </details>
  <br/>


  cc @c0bw3b for testing.


state: open
title: openblas: trouble with DYANAMIC_ARCH feature and bug in AVX512 code
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/issues/59708
updated_at: 2019-04-23 13:40:56
body:
  ## Issue description
  The AVX512 kernel on SKYLAKE-X CPUs seems to have a bug that produces wrong numbers (see https://github.com/xianyi/OpenBLAS/pull/2061). I ran into the bug when I tried to use CP2K (external derivation https://github.com/markuskowa/NixOS-QChem/tree/master/cp2k).

  Seems also to affect `julia` (https://github.com/xianyi/OpenBLAS/issues/1955).

  ~~Unfortunately there is no simple solution available:~~
  * ~~https://github.com/xianyi/OpenBLAS/pull/2061 turns off the problematic kernel but then even the unit tests in CP2K fail (which passed before) leaving openblas in a even more broken state.~~
  * ~~Alternatively the problem could be solved by turning off `DYANAMIC_ARCH` but then compilation fails with `TARGET="ATHLON"`. `TARGET="NEHALEM"` or  `TARGET="HASWELL"` seems to work but this might break `openblas` on older system (> ~8-10 years old)~~.
  * ~~Waiting for openblas 0.3.6 might be the best option (?)~~

  The problem can be solved by setting `NO_AVX512` in the make flags.

  Using the `DYANAMIC_ARCH` feature has another unwanted side effect on some SKYLAKE CPUs. Heavy utilization of  AVX512 instructions can lead to a drastic reduction in CPU clock frequency. On models like the Xeon Scalable Silver which have only one AVX512 unit per core (e.g. 2.2 GHz -> 1.4 GHz), this can lead to significantly slower code. For example a 20 core linpack benchmark (HPL) on a dual CPU Xeon Silver 4114 system yields **400 GFlops with AVX512 turned on** and **570 GFlops with AVX512 disabled** (use AVX2 instead). Note that MKL has a similar problem (https://software.intel.com/en-us/forums/intel-math-kernel-library/topic/776894).

  ### Steps to reproduce
  * Use `dgemm` function on a Skylake series CPUs (?)

  ## Technical details
  * openblas 0.3.5
  * affects NixOS 19.03 and nixpkgs-unstable

  CC @costrouc @dtzWill @ttuegel @vcunat 


state: closed
title: stubby: 0.2.5 -> 0.2.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59709
updated_at: 2019-04-26 02:58:45
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/stubby/versions.



  meta.description for stubby is: '"A local DNS Privacy stub resolver (using DNS-over-TLS)"'.

  [Release on GitHub](https://github.com/getdnsapi/stubby/releases/tag/v0.2.6)


  [Compare changes on GitHub](https://github.com/getdnsapi/stubby/compare/v0.2.5...v0.2.6)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.2.6 with grep in /nix/store/y55552c0srahz7b0964nkrdlvqnxrv6q-stubby-0.2.6
  - directory tree listing: https://gist.github.com/d195048c4c8d670fef9ece226228b825
  - du listing: https://gist.github.com/d56ae57a577ba05dd06f023cbcb71e9a

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  stubby

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/y55552c0srahz7b0964nkrdlvqnxrv6q-stubby-0.2.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A stubby https://github.com/r-ryantm/nixpkgs/archive/b3460fc885bdb8747e64978feef231543fc32baa.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/y55552c0srahz7b0964nkrdlvqnxrv6q-stubby-0.2.6
  ls -la /nix/store/y55552c0srahz7b0964nkrdlvqnxrv6q-stubby-0.2.6/bin
  ```


  </details>
  <br/>


  cc @leenaars for testing.


state: closed
title: streamlink: 1.0.0 -> 1.1.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59710
updated_at: 2019-04-26 02:58:39
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/streamlink/versions.



  meta.description for streamlink is: '"CLI for extracting streams from various websites to video player of your choosing"'.

  [Release on GitHub](https://github.com/streamlink/streamlink/releases/tag/1.1.1)


  [Compare changes on GitHub](https://github.com/streamlink/streamlink/compare/1.0.0...1.1.1)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1.1 with grep in /nix/store/bxqsdwryvy3n9m9zjcyxrb77kbxp4c3z-streamlink-1.1.1
  - directory tree listing: https://gist.github.com/9fd264e1c905f15b5b1bf1f806066739
  - du listing: https://gist.github.com/251362ac4676658f796e5381769c6a62

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  streamlink

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/bxqsdwryvy3n9m9zjcyxrb77kbxp4c3z-streamlink-1.1.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A streamlink https://github.com/r-ryantm/nixpkgs/archive/bfca9f35f60e510cd3adde26e9ceb770cce75db1.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/bxqsdwryvy3n9m9zjcyxrb77kbxp4c3z-streamlink-1.1.1
  ls -la /nix/store/bxqsdwryvy3n9m9zjcyxrb77kbxp4c3z-streamlink-1.1.1/bin
  ```


  </details>
  <br/>


  cc @dezgeg @zraexy @enzime for testing.


state: closed
title: synthv1: 0.9.5 -> 0.9.6
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59711
updated_at: 2019-04-26 02:58:50
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/synthv1/versions.



  meta.description for synthv1 is: '"An old-school 4-oscillator subtractive polyphonic synthesizer with stereo fx"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.9.6 with grep in /nix/store/psqhh1cg69mj0pz65am9clfhplmm9lzz-synthv1-0.9.6
  - directory tree listing: https://gist.github.com/dcb43ba78dee7d7a8890b3b0af9f31cc
  - du listing: https://gist.github.com/fcf58a8128edcde31cab28242d5e2b53

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  synthv1

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/psqhh1cg69mj0pz65am9clfhplmm9lzz-synthv1-0.9.6 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A synthv1 https://github.com/r-ryantm/nixpkgs/archive/bfa33498cef12f08db08fd8f2e033b7346c287a8.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/psqhh1cg69mj0pz65am9clfhplmm9lzz-synthv1-0.9.6
  ls -la /nix/store/psqhh1cg69mj0pz65am9clfhplmm9lzz-synthv1-0.9.6/bin
  ```


  </details>
  <br/>


  cc @cillianderoiste for testing.


state: closed
title: petrinizer: init at 0.9.1.1
user_login: 7c6f434c
html_url: https://github.com/NixOS/nixpkgs/pull/59712
updated_at: 2019-04-16 13:21:54
body:
  ###### Motivation for this change

  Adding a Petrinizer tool used both in previous and ongoing research…

  Will merge my self if the checks pass.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnutar: 1.31 -> 1.32
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59713
updated_at: 2019-04-26 02:53:48
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gnutar/versions.



  meta.description for gnutar is: '"GNU implementation of the `tar' archiver"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.32 with grep in /nix/store/14bfx6qbvhisgiwg903a4759hdyarkj1-gnutar-1.32
  - directory tree listing: https://gist.github.com/4d84ea7a7a2d203ffbaa2a610e13f1ed
  - du listing: https://gist.github.com/2c24a2bdb588996ce66685d7cd2b427e

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  94291 total rebuild path(s)

  27136 package rebuild(s)

  26982 x86_64-linux rebuild(s)
  24808 i686-linux rebuild(s)
  18580 x86_64-darwin rebuild(s)
  23921 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AMB-plugins
  AgdaSheaves
  AgdaStdlib
  CoinMP
  DisnixWebService
  EBTKS
  EmptyEpsilon
  FIL-plugins
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  OVMF
  OVMF-CSM
  PlistCpp
  QuadProgpp
  R
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sixel
  SDL_sound
  SDL_stretch
  SDL_ttf
  SkypeExport
  TotalParserCombinators
  Xaw3d
  _0x0
  _1password
  _2048-in-terminal
  _20kly
  _2bwm
  _389-ds-base
  _90secondportraits
  _915resolution
  _9pfs
  a2jmidid
  a2ps
  a52dec
  aacgain
  aacskeys

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/14bfx6qbvhisgiwg903a4759hdyarkj1-gnutar-1.32 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A gnutar https://github.com/r-ryantm/nixpkgs/archive/0851330df2d823ab8f571e39a0217dee7fc4d6f1.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/14bfx6qbvhisgiwg903a4759hdyarkj1-gnutar-1.32
  ls -la /nix/store/14bfx6qbvhisgiwg903a4759hdyarkj1-gnutar-1.32/bin
  ```


  </details>
  <br/>


state: open
title: [WIP] xSDK initialize libraries for the exascale computing project
user_login: costrouc
html_url: https://github.com/NixOS/nixpkgs/pull/59714
updated_at: 2019-04-16 20:59:32
body:
  ###### Motivation for this change

  I want to make nixos/nixpkgs the place to go for hpc. Currently many scientists with these libraries use https://spack.readthedocs.io/en/latest/ and these are the important core libraries. More to come listed in https://xsdk.info/packages/.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages.mathcomp: 1.7.0 -> 1.8.0
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/59715
updated_at: 2019-04-23 07:35:43
body:
  coqPackages.mathcomp-finmap: 1.1.0 -> 1.2.0
  coqPackages.mathcomp-analysis: 0.1.0 -> 0.2.0

  ###### Motivation for this change

  Major update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages.mathcomp: 1.7.0 -> 1.8.0
user_login: Zimmi48
html_url: https://github.com/NixOS/nixpkgs/pull/59716
updated_at: 2019-04-17 12:32:38
body:
  ###### Motivation for this change

  Compatibility of the math-comp package with upcoming Coq 8.10 release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: enlightenment.terminology: 1.3.2 -> 1.4.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59717
updated_at: 2019-04-26 02:58:53
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/terminology/versions.



  meta.description for enlightenment.terminology is: '"Powerful terminal emulator based on EFL"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.4.0 with grep in /nix/store/bw3nrp4g3q7k8vc9l3zqhqrqdr2g0khz-terminology-1.4.0
  - directory tree listing: https://gist.github.com/cef7bb406ff02142c8afe373b984c3a8
  - du listing: https://gist.github.com/dcafe2b87048df732926b17b8e5274a4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  enlightenment.terminology

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/bw3nrp4g3q7k8vc9l3zqhqrqdr2g0khz-terminology-1.4.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A enlightenment.terminology https://github.com/r-ryantm/nixpkgs/archive/99e1ed7fbae17b46e918b68c6715259e1511dcb3.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/bw3nrp4g3q7k8vc9l3zqhqrqdr2g0khz-terminology-1.4.0
  ls -la /nix/store/bw3nrp4g3q7k8vc9l3zqhqrqdr2g0khz-terminology-1.4.0/bin
  ```


  </details>
  <br/>


  cc @matejc @ftrvxmtrx for testing.


state: open
title: bluej-bin: init at 414
user_login: h0chi
html_url: https://github.com/NixOS/nixpkgs/pull/59718
updated_at: 2019-05-04 04:02:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  BlueJ is used in my programming lecture. Disclaimer: This is my first package submission to nixpkgs.

  ###### Things done
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tgt: 1.0.75 -> 1.0.76
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59719
updated_at: 2019-04-26 02:58:56
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/tgt/versions.



  meta.description for tgt is: '"iSCSI Target daemon with rdma support"'.


  [Compare changes on GitHub](https://github.com/fujita/tgt/compare/v1.0.75...v1.0.76)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.0.76 with grep in /nix/store/qwvjvic0p41dyn1jnndh643llisss11s-tgt-1.0.76
  - directory tree listing: https://gist.github.com/9116a3654f9bddab0d60b381695a2146
  - du listing: https://gist.github.com/f525350cdee20af5ac882d05c11496c4

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  tgt

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/qwvjvic0p41dyn1jnndh643llisss11s-tgt-1.0.76 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A tgt https://github.com/r-ryantm/nixpkgs/archive/ab761bee9e0a39e7ab10b2f88b4a2cce95cbe6a7.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/qwvjvic0p41dyn1jnndh643llisss11s-tgt-1.0.76
  ls -la /nix/store/qwvjvic0p41dyn1jnndh643llisss11s-tgt-1.0.76/bin
  ```


  </details>
  <br/>


state: closed
title: ttfautohint: 1.8.2 -> 1.8.3
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59720
updated_at: 2019-04-26 02:58:59
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ttfautohint/versions.



  meta.description for ttfautohint is: '"An automatic hinter for TrueType fonts"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.8.3 with grep in /nix/store/50m0kdn4msiikgaxxybn4shabzicr33j-ttfautohint-1.8.3
  - directory tree listing: https://gist.github.com/9706514202c13519ee8020785073e4c3
  - du listing: https://gist.github.com/95fea9fc3d5ee1e256d174c4a8fbf4ab

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  12 total rebuild path(s)

  3 package rebuild(s)

  3 x86_64-linux rebuild(s)
  3 i686-linux rebuild(s)
  3 x86_64-darwin rebuild(s)
  3 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  iosevka
  ttfautohint
  ttfautohint-nox

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/50m0kdn4msiikgaxxybn4shabzicr33j-ttfautohint-1.8.3 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A ttfautohint https://github.com/r-ryantm/nixpkgs/archive/29617238e4fa42b2335dc6b33ff964ccdd1db870.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/50m0kdn4msiikgaxxybn4shabzicr33j-ttfautohint-1.8.3
  ls -la /nix/store/50m0kdn4msiikgaxxybn4shabzicr33j-ttfautohint-1.8.3/bin
  ```


  </details>
  <br/>


  cc @cillianderoiste @ndowens for testing.


state: open
title: nano/nix highlighting barely legible under solarized light
user_login: goertzenator
html_url: https://github.com/NixOS/nixpkgs/issues/59721
updated_at: 2019-05-02 00:37:29
body:
  ## Issue description
  Nix syntax highlighting in nano in a solarized light terminal has some barely legible colors (light gray)
  Screenshot:
  ![image](https://user-images.githubusercontent.com/605072/56221128-46db0900-602f-11e9-9d36-ebcff5c36dc9.png)

  There was no nix syntax highlighting prior to 19.03.


  ### Steps to reproduce
  1. Install nixos 19.03.
  2. Install Konsole.
  3. Set color scheme to Solarized Light.


  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a, unstable-19.03pre164964.b0f40b78513"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: urh: 2.5.6 -> 2.5.7
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59722
updated_at: 2019-04-26 02:59:06
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/urh/versions.



  meta.description for urh is: '"Universal Radio Hacker: investigate wireless protocols like a boss"'.

  [Release on GitHub](https://github.com/jopohl/urh/releases/tag/v2.5.7)


  [Compare changes on GitHub](https://github.com/jopohl/urh/compare/v2.5.6...v2.5.7)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.5.7 with grep in /nix/store/wipw7b74asgdc95avc0vav73b4r892i3-urh-2.5.7
  - directory tree listing: https://gist.github.com/b077100f2d653d029aa982e853109495
  - du listing: https://gist.github.com/4a2879798bb7884fb3761d5ef5939856

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  urh

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/wipw7b74asgdc95avc0vav73b4r892i3-urh-2.5.7 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A urh https://github.com/r-ryantm/nixpkgs/archive/639b037d053f4cc2729a42bc97d1b93d32ed9411.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/wipw7b74asgdc95avc0vav73b4r892i3-urh-2.5.7
  ls -la /nix/store/wipw7b74asgdc95avc0vav73b4r892i3-urh-2.5.7/bin
  ```


  </details>
  <br/>


  cc @fpletz for testing.


state: closed
title: urlwatch: 2.16 -> 2.17
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59723
updated_at: 2019-04-26 02:59:10
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/urlwatch/versions.



  meta.description for urlwatch is: '"A tool for monitoring webpages for updates"'.


  [Compare changes on GitHub](https://github.com/thp/urlwatch/compare/2.16...2.17)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.17 with grep in /nix/store/y4kr2grik8s4n6r91zr0fvay58ynyd5m-urlwatch-2.17
  - directory tree listing: https://gist.github.com/f3d662799938e0fbae39ac6d3df27c89
  - du listing: https://gist.github.com/c9244f4cf472c1475588df377ab356b3

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  urlwatch

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/y4kr2grik8s4n6r91zr0fvay58ynyd5m-urlwatch-2.17 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A urlwatch https://github.com/r-ryantm/nixpkgs/archive/542df0b13a370eca3241807839f38b82f9be0f5b.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/y4kr2grik8s4n6r91zr0fvay58ynyd5m-urlwatch-2.17
  ls -la /nix/store/y4kr2grik8s4n6r91zr0fvay58ynyd5m-urlwatch-2.17/bin
  ```


  </details>
  <br/>


  cc @4z3 for testing.


state: closed
title: utf8proc: 2.2.0 -> 2.3.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59724
updated_at: 2019-05-11 03:03:11
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/utf8proc/versions.



  meta.description for utf8proc is: '"A clean C library for processing UTF-8 Unicode data"'.

  [Release on GitHub](https://github.com/JuliaStrings/utf8proc/releases/tag/v2.3.0)


  [Compare changes on GitHub](https://github.com/JuliaLang/utf8proc/compare/v2.2.0...v2.3.0)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.3.0 with grep in /nix/store/2mpzpg04lj3swy8sxgnwl4frj9rmdmdc-utf8proc-2.3.0
  - directory tree listing: https://gist.github.com/580d57bc3facbddbc20987efec0041f0
  - du listing: https://gist.github.com/a045f6f01685145a22bc01222c2e8a74

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  141 total rebuild path(s)

  41 package rebuild(s)

  41 x86_64-linux rebuild(s)
  39 i686-linux rebuild(s)
  32 x86_64-darwin rebuild(s)
  29 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  cabal2nix
  chronos
  dep2nix
  gitAndTools.gitFastExport
  gitAndTools.gitFull
  gitAndTools.gitSVN
  gitAndTools.svn-all-fast-export
  gitAndTools.svn2git
  gitAndTools.svn_all_fast_export
  gitFull
  gitSVN
  hydra
  julia
  julia_07
  julia_1
  julia_10
  julia_11
  marathon
  mesos
  muse
  nix-prefetch-scripts
  nix-prefetch-svn
  nix-update-source
  perl528Packages.SVNSimple
  perldevelPackages.SVNSimple
  python27Packages.pysvn
  rabbitvcs
  rapidsvn
  reposurgeon
  spark
  spark_22
  subversion
  subversionClient
  subversion_1_10
  subversion_1_11
  svn2git
  svnfs
  urjtag
  utf8proc
  vcstool
  ydiff

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/2mpzpg04lj3swy8sxgnwl4frj9rmdmdc-utf8proc-2.3.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A utf8proc https://github.com/r-ryantm/nixpkgs/archive/a0703af2815e2154f84131a3bf375594cc06eff5.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/2mpzpg04lj3swy8sxgnwl4frj9rmdmdc-utf8proc-2.3.0
  ls -la /nix/store/2mpzpg04lj3swy8sxgnwl4frj9rmdmdc-utf8proc-2.3.0/bin
  ```


  </details>
  <br/>


  cc @ftrvxmtrx for testing.


state: closed
title: VSCode: No such file or directory with User Env
user_login: maxkrieger
html_url: https://github.com/NixOS/nixpkgs/issues/59725
updated_at: 2019-04-17 20:39:36
body:
  ## Issue description

  I have the latest version of VSCode installed (`nixpkgs` channel). I tried running `code` in my shells (zsh, bash, sh) and all of them failed with this error:

  ```
  $ ~/ code
  -f: No such file or directory
  dirname: missing operand
  Try 'dirname --help' for more information.
  /nix/store/nhfb7dsg4h010nqh7a64cd3v96yvjp9v-vscode-1.33.0/bin/.code-wrapped: line 35: /../code: No such file or directory
  ```

  My `dirname` version: `dirname (GNU coreutils) 8.29`.

  **However**, `nix-shell -p vscode --run "code"` runs fine. What could possibly be interfering?

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.107, NixOS, 18.09.2367.15f08994517 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(max): `"nixpkgs-19.09pre174594.0c0954781e2"`
   - channels(root): `"nixos-18.09.2505.46d3867a08a, nixos-hardware, unstable-19.03pre166740.422b6bd489a"`
   - nixpkgs: `/home/max/.nix-defexpr/channels/nixpkgs`
  ```


state: closed
title: vbam: 2.1.1 -> 2.1.2
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59726
updated_at: 2019-04-26 02:59:13
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/visualboyadvance-m/versions.



  meta.description for vbam is: '"A merge of the original Visual Boy Advance forks"'.

  [Release on GitHub](https://github.com/visualboyadvance-m/visualboyadvance-m/releases/tag/v2.1.2)


  [Compare changes on GitHub](https://github.com/visualboyadvance-m/visualboyadvance-m/compare/v2.1.1...v2.1.2)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.1.2 with grep in /nix/store/mynjzz858i3k6ikrljsxidmnfhanj3k0-visualboyadvance-m-2.1.2
  - directory tree listing: https://gist.github.com/0edee0fc3cd015c961cecda97a281a98
  - du listing: https://gist.github.com/0729c7ed5b9b50f303a3b97e7a583871

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  3 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  vbam

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/mynjzz858i3k6ikrljsxidmnfhanj3k0-visualboyadvance-m-2.1.2 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vbam https://github.com/r-ryantm/nixpkgs/archive/53d8f238466891074edd9a4ec309028dc3ab8704.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/mynjzz858i3k6ikrljsxidmnfhanj3k0-visualboyadvance-m-2.1.2
  ls -la /nix/store/mynjzz858i3k6ikrljsxidmnfhanj3k0-visualboyadvance-m-2.1.2/bin
  ```


  </details>
  <br/>


  cc @Lassulus for testing.


state: closed
title: vulkan-headers: 1.1.101.0 -> 1.1.106
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59727
updated_at: 2019-04-26 02:59:15
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vulkan-headers/versions.



  meta.description for vulkan-headers is: '"Vulkan Header files and API registry"'.


  [Compare changes on GitHub](https://github.com/KhronosGroup/Vulkan-Headers/compare/sdk-1.1.101.0...sdk-1.1.106)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1.106 with grep in /nix/store/mrng7x83javbfrjn99aryay1ijfbp996-vulkan-headers-1.1.106
  - directory tree listing: https://gist.github.com/7955d5d8201a4ee6908a21b04f82e183
  - du listing: https://gist.github.com/b7bfc04517c05e5609758636eb84bcee

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  162 total rebuild path(s)

  68 package rebuild(s)

  68 x86_64-linux rebuild(s)
  53 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  41 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  curseradio
  deepin.deepin-movie-reborn
  dolphinEmuMaster
  gnome-mpv
  kodiPlugins.steam-launcher
  libretro._4do
  libretro.beetle-pce-fast
  libretro.beetle-psx
  libretro.beetle-saturn
  libretro.bsnes-mercury
  libretro.desmume
  libretro.dolphin
  libretro.fba
  libretro.fceumm
  libretro.gambatte
  libretro.genesis-plus-gx
  libretro.higan-sfc
  libretro.mame
  libretro.mgba
  libretro.mupen64plus
  libretro.nestopia
  libretro.parallel-n64
  libretro.picodrive
  libretro.ppsspp
  libretro.prboom
  libretro.quicknes
  libretro.reicast
  libretro.scummvm
  libretro.snes9x
  libretro.snes9x-next
  libretro.stella
  libretro.vba-m
  libretro.vba-next
  linux-steam-integration
  mpc-qt
  mpv
  mpv-with-scripts
  pipelight
  playonlinux
  plex-media-player
  python27Packages.mpv
  python37Packages.mpv
  renderdoc
  retroarch
  retroarchBare
  rpcs3
  steam
  steam-run
  steam-run-native
  steamcmd

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/mrng7x83javbfrjn99aryay1ijfbp996-vulkan-headers-1.1.106 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A vulkan-headers https://github.com/r-ryantm/nixpkgs/archive/7fa6ebe2ab1f76e5587021c12037a80e77750497.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/mrng7x83javbfrjn99aryay1ijfbp996-vulkan-headers-1.1.106
  ls -la /nix/store/mrng7x83javbfrjn99aryay1ijfbp996-vulkan-headers-1.1.106/bin
  ```


  </details>
  <br/>


  cc @ralith for testing.


state: closed
title: wireguard-tools: 0.0.20190227 -> 0.0.20190406
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59728
updated_at: 2019-04-26 02:59:21
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wireguard-tools/versions.



  meta.description for wireguard-tools is: '"Tools for the WireGuard secure network tunnel"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 0.0.20190406 with grep in /nix/store/drlw4gcvmyi008m0hf5qkip7ij52fa5d-wireguard-tools-0.0.20190406
  - directory tree listing: https://gist.github.com/73cd1a4de09d8f057107e5e8426022b2
  - du listing: https://gist.github.com/271b7a95772eadce24e5a4540a870933

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  61 total rebuild path(s)

  20 package rebuild(s)

  20 x86_64-linux rebuild(s)
  20 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  20 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  linuxPackages-libre.wireguard
  linuxPackages.wireguard
  linuxPackages_4_14.wireguard
  linuxPackages_4_19.wireguard
  linuxPackages_4_4.wireguard
  linuxPackages_4_9.wireguard
  linuxPackages_5_0.wireguard
  linuxPackages_hardened.wireguard
  linuxPackages_hardkernel_4_14.wireguard
  linuxPackages_hardkernel_latest.wireguard
  linuxPackages_latest-libre.wireguard
  linuxPackages_latest.wireguard
  linuxPackages_latest_hardened.wireguard
  linuxPackages_latest_xen_dom0.wireguard
  linuxPackages_latest_xen_dom0_hardened.wireguard
  linuxPackages_testing_bcachefs.wireguard
  linuxPackages_testing_hardened.wireguard
  linuxPackages_xen_dom0.wireguard
  linuxPackages_xen_dom0_hardened.wireguard
  wireguard-tools

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/drlw4gcvmyi008m0hf5qkip7ij52fa5d-wireguard-tools-0.0.20190406 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A wireguard-tools https://github.com/r-ryantm/nixpkgs/archive/08a62e057834be1ed344421394a08338224241a0.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/drlw4gcvmyi008m0hf5qkip7ij52fa5d-wireguard-tools-0.0.20190406
  ls -la /nix/store/drlw4gcvmyi008m0hf5qkip7ij52fa5d-wireguard-tools-0.0.20190406/bin
  ```


  </details>
  <br/>


  cc @elseym @ericsagnes @mic92 @zx2c4 for testing.


state: closed
title: grafana: 6.1.3 -> 6.1.4
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/59729
updated_at: 2019-04-17 15:27:47
body:
  ###### Motivation for this change
  Latest [patch release](https://github.com/grafana/grafana/releases/tag/v6.1.4) with bug fixes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  **needs to be backported to 19.03**


state: closed
title: wire-desktop: 3.7.2891 -> 3.9.2895
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59730
updated_at: 2019-04-26 02:59:18
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/wire-desktop/versions.



  meta.description for wire-desktop is: '"A modern, secure messenger"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 3.9.2895 with grep in /nix/store/nmp8x9j9qjgjlssj6nfcs3f33kj6whyl-wire-desktop-3.9.2895
  - directory tree listing: https://gist.github.com/332605e5371adec5fa00942ca45a5682
  - du listing: https://gist.github.com/b3d6327ab0d4865422d954d175dc7ee5

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  1 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  0 i686-linux rebuild(s)
  0 x86_64-darwin rebuild(s)
  0 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  wire-desktop

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/nmp8x9j9qjgjlssj6nfcs3f33kj6whyl-wire-desktop-3.9.2895 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A wire-desktop https://github.com/r-ryantm/nixpkgs/archive/b3408d088c8ae393f468e3d059f06324f46d1b15.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/nmp8x9j9qjgjlssj6nfcs3f33kj6whyl-wire-desktop-3.9.2895
  ls -la /nix/store/nmp8x9j9qjgjlssj6nfcs3f33kj6whyl-wire-desktop-3.9.2895/bin
  ```


  </details>
  <br/>


  cc @worldofpeace for testing.


state: closed
title: ejabberd: refactor module, add test
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/59731
updated_at: 2019-04-29 22:29:40
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I run ejabberd.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python37Packages.xdot: 1.0 -> 1.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59732
updated_at: 2019-04-26 02:57:57
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-xdot/versions.



  meta.description for python37Packages.xdot is: '"xdot.py is an interactive viewer for graphs written in Graphviz's dot"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.1 with grep in /nix/store/kkj9p9rk8hcfw3cdxs9ippi6d960n71d-python3.7-xdot-1.1
  - directory tree listing: https://gist.github.com/3abc2a725f081e3b797953042aac1e2c
  - du listing: https://gist.github.com/5976e155eadc7700500709245acc89b0

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  4 total rebuild path(s)

  1 package rebuild(s)

  1 x86_64-linux rebuild(s)
  1 i686-linux rebuild(s)
  1 x86_64-darwin rebuild(s)
  1 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  python37Packages.xdot

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/kkj9p9rk8hcfw3cdxs9ippi6d960n71d-python3.7-xdot-1.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A python37Packages.xdot https://github.com/r-ryantm/nixpkgs/archive/46c122acf69b346b51fd9f639c9cc014c14481bc.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/kkj9p9rk8hcfw3cdxs9ippi6d960n71d-python3.7-xdot-1.1
  ls -la /nix/store/kkj9p9rk8hcfw3cdxs9ippi6d960n71d-python3.7-xdot-1.1/bin
  ```


  </details>
  <br/>


state: closed
title: Update libimobiledevice packages, fix usbmuxd
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/59734
updated_at: 2019-04-22 23:49:17
body:
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/pull/54953 updated usbmuxd only, seemingly without testing, because when I updated my system today it didn't work anymore, the issue being https://github.com/libimobiledevice/usbmuxd/issues/95. All these libimobiledevice packages should be updated together such that such things don't happen. This PR updates all of them to their latest master version. I also changed ifuse to use the master version instead of its releases, because there hasn't been a release in a while (see https://github.com/libimobiledevice/ifuse/issues/34).

  Ping @worldofpeace @arilotter 

  This is currently also broken for 19.03 too, <s>PR for a partial backport is incoming</s> after discussions with @grahamc and @samueldr on IRC I decided to instead backport all of these updates, because libimobiledevice doesn't have any stable versions anyways, and not updating all those packages roughly at the same time might lead to more such issues.

  ###### Things done

  I have verified that this fixes above issue, allowing me to use my iPhone for tethering again. I also checked that ifuse can mount the filesystem and that ideviceinstaller can list installed apps.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xmrig-proxy: 2.14.0 -> 2.14.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59735
updated_at: 2019-04-26 02:59:26
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xmrig-proxy/versions.



  meta.description for xmrig-proxy is: '"Monero (XMR) Stratum protocol proxy"'.

  [Release on GitHub](https://github.com/xmrig/xmrig-proxy/releases/tag/v2.14.1)


  [Compare changes on GitHub](https://github.com/xmrig/xmrig-proxy/compare/v2.14.0...v2.14.1)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.14.1 with grep in /nix/store/xf2m32qk6x18r08cn5cp0r0n0h0bz4jc-xmrig-proxy-2.14.1
  - directory tree listing: https://gist.github.com/a7bce2046fd94502383514a5dc18b531
  - du listing: https://gist.github.com/03a9ac94a2fb84a05483040e3a650922

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  45238 total rebuild path(s)

  19845 package rebuild(s)

  9090 x86_64-linux rebuild(s)
  8828 i686-linux rebuild(s)
  18624 x86_64-darwin rebuild(s)
  8696 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  CoinMP
  EBTKS
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_ttf
  TotalParserCombinators
  Xaw3d
  _1password
  _20kly
  _2bwm
  a2jmidid
  a52dec
  aalib
  abc-verifier
  abcm2ps
  abcmidi
  abduco
  abella
  abi-compliance-checker
  abi-dumper
  acgtk
  ack
  acme-client
  acme-sh
  acpitool
  acsccid
  actdiag
  activemq
  adapta-backgrounds
  adapta-gtk-theme
  adapta-kde-theme
  adlplug

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/xf2m32qk6x18r08cn5cp0r0n0h0bz4jc-xmrig-proxy-2.14.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A xmrig-proxy https://github.com/r-ryantm/nixpkgs/archive/afa411c749e7ea49179b8c38b7db9948fd00d01c.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/xf2m32qk6x18r08cn5cp0r0n0h0bz4jc-xmrig-proxy-2.14.1
  ls -la /nix/store/xf2m32qk6x18r08cn5cp0r0n0h0bz4jc-xmrig-proxy-2.14.1/bin
  ```


  </details>
  <br/>


  cc @aij for testing.


state: closed
title: xmr-stak: 2.10.1 -> 2.10.4
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59736
updated_at: 2019-04-26 02:59:24
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/xmr-stak/versions.



  meta.description for xmr-stak is: '"Unified All-in-one Monero miner"'.

  [Release on GitHub](https://github.com/fireice-uk/xmr-stak/releases/tag/2.10.4)


  [Compare changes on GitHub](https://github.com/fireice-uk/xmr-stak/compare/2.10.1...2.10.4)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.10.4 with grep in /nix/store/7lbx1r01h6y7klzxfhhjcjnmlv2skp2q-xmr-stak-2.10.4
  - directory tree listing: https://gist.github.com/a713fe71d9ece3ca092cd0b5a3922044
  - du listing: https://gist.github.com/0a289fe738c4c12bdb12fbd3de053c75

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  45238 total rebuild path(s)

  19845 package rebuild(s)

  9090 x86_64-linux rebuild(s)
  8828 i686-linux rebuild(s)
  18624 x86_64-darwin rebuild(s)
  8696 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  CoinMP
  EBTKS
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_ttf
  TotalParserCombinators
  Xaw3d
  _1password
  _20kly
  _2bwm
  a2jmidid
  a52dec
  aalib
  abc-verifier
  abcm2ps
  abcmidi
  abduco
  abella
  abi-compliance-checker
  abi-dumper
  acgtk
  ack
  acme-client
  acme-sh
  acpitool
  acsccid
  actdiag
  activemq
  adapta-backgrounds
  adapta-gtk-theme
  adapta-kde-theme
  adlplug

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/7lbx1r01h6y7klzxfhhjcjnmlv2skp2q-xmr-stak-2.10.4 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A xmr-stak https://github.com/r-ryantm/nixpkgs/archive/2962c77b6c8f2baa6f55f19640cfa0f9cefe43af.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/7lbx1r01h6y7klzxfhhjcjnmlv2skp2q-xmr-stak-2.10.4
  ls -la /nix/store/7lbx1r01h6y7klzxfhhjcjnmlv2skp2q-xmr-stak-2.10.4/bin
  ```


  </details>
  <br/>


  cc @fpletz @bfortz for testing.


state: closed
title: joker: 0.10.1 -> 0.12.2
user_login: ernestas
html_url: https://github.com/NixOS/nixpkgs/pull/59737
updated_at: 2019-04-19 06:18:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updating version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: yubico-piv-tool: 1.6.2 -> 1.7.0
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59738
updated_at: 2019-04-26 02:59:29
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/yubico-piv-tool/versions.



  meta.description for yubico-piv-tool is: '"Used for interacting with the Privilege and Identification Card (PIV)\napplication on a YubiKey\n"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 1.7.0 with grep in /nix/store/n393gm82lip5cp2172x0y2d9rg5cjsd1-yubico-piv-tool-1.7.0
  - directory tree listing: https://gist.github.com/0f674d210bd091d2239a7b1d7bb4901f
  - du listing: https://gist.github.com/f9529168e6654b66797a28739b0d8d74

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  45240 total rebuild path(s)

  19844 package rebuild(s)

  9090 x86_64-linux rebuild(s)
  8829 i686-linux rebuild(s)
  18624 x86_64-darwin rebuild(s)
  8697 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  CoinMP
  EBTKS
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_ttf
  TotalParserCombinators
  Xaw3d
  _1password
  _20kly
  _2bwm
  a2jmidid
  a52dec
  aalib
  abc-verifier
  abcm2ps
  abcmidi
  abduco
  abella
  abi-compliance-checker
  abi-dumper
  acgtk
  ack
  acme-client
  acme-sh
  acpitool
  acsccid
  actdiag
  activemq
  adapta-backgrounds
  adapta-gtk-theme
  adapta-kde-theme
  adlplug

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/n393gm82lip5cp2172x0y2d9rg5cjsd1-yubico-piv-tool-1.7.0 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A yubico-piv-tool https://github.com/r-ryantm/nixpkgs/archive/a8971ae93466be083d6b3367af1fba10e83f2d15.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/n393gm82lip5cp2172x0y2d9rg5cjsd1-yubico-piv-tool-1.7.0
  ls -la /nix/store/n393gm82lip5cp2172x0y2d9rg5cjsd1-yubico-piv-tool-1.7.0/bin
  ```


  </details>
  <br/>


state: closed
title: zabbix-cli: 1.7.0 -> 2.0.1
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59739
updated_at: 2019-04-27 22:35:40
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/zabbix-cli/versions.



  meta.description for zabbix-cli is: '"Command-line interface for Zabbix"'.

  [Release on GitHub](https://github.com/usit-gd/zabbix-cli/releases/tag/2.0.1)


  [Compare changes on GitHub](https://github.com/usit-gd/zabbix-cli/compare/1.7.0...2.0.1)

  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 2.0.1 with grep in /nix/store/hl746ljq56cgshiidjbihm974iykws7q-zabbix-cli-2.0.1
  - directory tree listing: https://gist.github.com/2385fb13d5ded9ffd2bcf2bcfa039ef6
  - du listing: https://gist.github.com/ac6cbe95ce0fec808c5bdf6193d15ff9

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  45240 total rebuild path(s)

  19844 package rebuild(s)

  9090 x86_64-linux rebuild(s)
  8829 i686-linux rebuild(s)
  18624 x86_64-darwin rebuild(s)
  8697 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  CoinMP
  EBTKS
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_ttf
  TotalParserCombinators
  Xaw3d
  _1password
  _20kly
  _2bwm
  a2jmidid
  a52dec
  aalib
  abc-verifier
  abcm2ps
  abcmidi
  abduco
  abella
  abi-compliance-checker
  abi-dumper
  acgtk
  ack
  acme-client
  acme-sh
  acpitool
  acsccid
  actdiag
  activemq
  adapta-backgrounds
  adapta-gtk-theme
  adapta-kde-theme
  adlplug

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/hl746ljq56cgshiidjbihm974iykws7q-zabbix-cli-2.0.1 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A zabbix-cli https://github.com/r-ryantm/nixpkgs/archive/e2c9f536e873a38696e23ba3b1663beb067bdba3.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/hl746ljq56cgshiidjbihm974iykws7q-zabbix-cli-2.0.1
  ls -la /nix/store/hl746ljq56cgshiidjbihm974iykws7q-zabbix-cli-2.0.1/bin
  ```


  </details>
  <br/>


  cc @womfoo for testing.


state: closed
title: zotero: 5.0.60 -> 5.0.66
user_login: r-ryantm
html_url: https://github.com/NixOS/nixpkgs/pull/59740
updated_at: 2019-04-26 02:59:35
body:
  Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/zotero/versions.



  meta.description for zotero is: '"Collect, organize, cite, and share your research sources"'.


  <details>
  <summary>
  Checks done (click to expand)
  </summary>

  - built on NixOS
  - /bin/sh passed the binary check.
  - 1 of 1 passed binary check by having a zero exit code.
  - 0 of 1 passed binary check by having the new version present in output.
  - found 5.0.66 with grep in /nix/store/lrbra24m9355h0xcbhy3grj6panrbfz9-zotero-5.0.66
  - directory tree listing: https://gist.github.com/1103fbee6fa237ca091b9f86f4b4312d
  - du listing: https://gist.github.com/629228336c32e05449b0828df87f82d5

  </details>
  <details>
  <summary>
  Rebuild report (if merged into master) (click to expand)
  </summary>

  45240 total rebuild path(s)

  19845 package rebuild(s)

  9090 x86_64-linux rebuild(s)
  8829 i686-linux rebuild(s)
  18624 x86_64-darwin rebuild(s)
  8697 aarch64-linux rebuild(s)


  First fifty rebuilds by attrpath
  AgdaSheaves
  AgdaStdlib
  CoinMP
  EBTKS
  Fabric
  LASzip
  Literate
  MMA
  NSPlist
  PlistCpp
  SDL
  SDL2
  SDL2_gfx
  SDL2_image
  SDL2_mixer
  SDL2_net
  SDL2_ttf
  SDL_gfx
  SDL_image
  SDL_mixer
  SDL_net
  SDL_sound
  SDL_ttf
  TotalParserCombinators
  Xaw3d
  _1password
  _20kly
  _2bwm
  a2jmidid
  a52dec
  aalib
  abc-verifier
  abcm2ps
  abcmidi
  abduco
  abella
  abi-compliance-checker
  abi-dumper
  acgtk
  ack
  acme-client
  acme-sh
  acpitool
  acsccid
  actdiag
  activemq
  adapta-backgrounds
  adapta-gtk-theme
  adapta-kde-theme
  adlplug

  </details>

  <details>
  <summary>
  Instructions to test this update (click to expand)
  </summary>

  Either download from Cachix:
  ```
  nix-store -r /nix/store/lrbra24m9355h0xcbhy3grj6panrbfz9-zotero-5.0.66 \
    --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
    --option trusted-public-keys '
    r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    '
  ```
  (r-ryantm's Cachix cache is only trusted for this store-path realization.)

  Or, build yourself:
  ```
  nix-build -A zotero https://github.com/r-ryantm/nixpkgs/archive/d59bd72910447e0d03820dc403d138677c6147d3.tar.gz
  ```

  After you've downloaded or built it, look at the files and if there are any, run the binaries:
  ```
  ls -la /nix/store/lrbra24m9355h0xcbhy3grj6panrbfz9-zotero-5.0.66
  ls -la /nix/store/lrbra24m9355h0xcbhy3grj6panrbfz9-zotero-5.0.66/bin
  ```


  </details>
  <br/>


state: closed
title: nixos/light: add control options
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/59742
updated_at: 2019-04-18 11:10:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  As discussed in https://github.com/NixOS/nixpkgs/issues/57602 and https://github.com/NixOS/nixpkgs/pull/58609

  cc @primeos @oxij in case you're interested

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: androidndk-pkgs: Remove -mfloat flag
user_login: kmicklas
html_url: https://github.com/NixOS/nixpkgs/pull/59743
updated_at: 2019-04-16 23:04:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This flag doesn't actually exist. This is basically a forward-port of https://github.com/NixOS/nixpkgs/pull/58828 now that https://github.com/NixOS/nixpkgs/pull/59253 has been merged.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ripgrep: 11.0.0 -> 11.0.1
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/59744
updated_at: 2019-04-16 21:02:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/BurntSushi/ripgrep/releases/tag/11.0.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @tailhook @lilyball 


state: open
title: Headers not linked from glibc-dev during buildFHSUserEnv
user_login: HackerFoo
html_url: https://github.com/NixOS/nixpkgs/issues/59745
updated_at: 2019-04-18 06:53:52
body:
  ## Issue description

  Headers aren't linked from e.g. /nix/store/sr4253np2gz2bpha4gn8gqlmiw604155-glibc-2.27-dev/include, so string.h and other common headers are missing from /usr/include

  ### Steps to reproduce

  Open a nix-shell with buildFHSUserEnv and glibc in targetPkgs, notice that string.h is missing from /usr/include

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.33, NixOS, 19.09pre175916.1fc591f9a5b (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre175916.1fc591f9a5b"`
   - channels(dusty): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: gtranslator: init at 3.32.0
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/59746
updated_at: 2019-04-17 21:33:05
body:
  Tool for translating Gettext files: https://gitlab.gnome.org/GNOME/gtranslator

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libpam: fix w/musl after update to 1.3.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59747
updated_at: 2019-04-18 16:43:37
body:
  ###### Motivation for this change

  Basically this moves to a similar patch to what we were using before the update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firmwareLinuxNonfree: 20190312 -> 20190416
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59748
updated_at: 2019-04-27 12:36:56
body:
  restore outputHash attributes, since I already have them...

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sarasa-gothic: 0.6.0 -> 0.8.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59749
updated_at: 2019-04-20 22:44:55
body:
  ###### Motivation for this change

  https://github.com/be5invis/Sarasa-Gothic/releases/tag/v0.8.0
  https://github.com/be5invis/Sarasa-Gothic/releases/tag/v0.7.2
  https://github.com/be5invis/Sarasa-Gothic/releases/tag/v0.7.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.gsettings-desktop-schemas -> gsettings-desktop-schemas
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59750
updated_at: 2019-04-17 17:49:39
body:
  gnome3.pomodoro is left out because I don't want to create a conflict.

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: knotes: init
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59751
updated_at: 2019-04-21 18:46:11
body:
  ###### Motivation for this change

  Seems to work properly for basic desktop sticky-notes :).


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dedup: init at 1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59752
updated_at: 2019-04-28 05:28:30
body:
  ###### Motivation for this change

  Neat utility, 1.0 release.o

  https://git.2f30.org/dedup/file/README.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Qsynth backport
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59753
updated_at: 2019-04-19 13:08:05
body:
  ###### Motivation for this change
  Fixes #59672

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Cleanup; Remove old patches
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59754
updated_at: 2019-05-18 20:36:18
body:
  Cleanup some patches and resources that got checked in.

  Effects:

  - boost (cygwin patches)
  - pharo (resource directories)
  - xorg (dri_interface.h)
  - herqq (gcc6.patch)

  Before:

  ```
  $ du -sc pkgs
  104084	pkgs
  ```

  After:

  ```
  $ du -sc pkgs
  103696	pkgs
  ```

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: make-derivation: put patches in all derivations
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59755
updated_at: 2019-04-23 22:33:05
body:
  This puts patches in all derivations even if it unspecified by the
  derivation. By default it will be an empty list. This simplifies
  overrides, as we can now assume that patches is a valid name so that
  this works:

  ```
  self: super: {
    mypkg = super.pkg.overrideAttrs (o: {
      patches = o.patches ++ [ ./my-very-own.patch ];
    });
  }
  ```

  That is, you don’t need to provide a default "or []", make-derivation
  provides one for you.

  Unfortunately, this is a mass rebuild.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Performance improvements
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59756
updated_at: 2019-06-18 16:03:22
body:
  Experiments in improving derivation performance. Trying two things:

  - inlining isCross
  - don't check hardening flags up front

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pycurl fails to build on nixos-unstable
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/issues/59757
updated_at: 2019-04-22 10:16:54
body:
  ## Issue description


  ```
  =================================== FAILURES ===================================
  _________________ MemoryMgmtTest.test_readfunction_collection __________________

  self = <tests.memory_mgmt_test.MemoryMgmtTest testMethod=test_readfunction_collection>

      def test_readfunction_collection(self):
  >       self.check_callback(pycurl.READFUNCTION)

  tests/memory_mgmt_test.py:246:
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
  tests/util.py:192: in decorated
      return fn(*args, **kwargs)
  tests/memory_mgmt_test.py:285: in check_callback
      self.assertTrue(new_object_count in (object_count, object_count-1))
  E   AssertionError: False is not true
  =============================== warnings summary ===============================
  /nix/store/9jy4g0b040s7b0x2jncr3ra09jygk65l-python3.7-bottle-0.12.16/lib/python3.7/site-packages/bottle.py:87
    /nix/store/9jy4g0b040s7b0x2jncr3ra09jygk65l-python3.7-bottle-0.12.16/lib/python3.7/site-packages/bottle.py:87: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
      from collections import MutableMapping as DictMixin

  tests/setopt_lifecycle_test.py:19
    /build/pycurl-7.43.0.2/tests/setopt_lifecycle_test.py:19: PytestWarning: cannot collect test class 'TestString' because it has a __new__ constructor
      class TestString(str):

  tests/memory_mgmt_test.py::MemoryMgmtTest::test_form_bufferptr_memory_leak_gh267
    /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:320: DeprecationWarning: Please use assertTrue instead.
      self.assert_(after_object_count <= before_object_count + 1000, 'Grew from %d to %d objects' % (before_object_count, after_object_count))

  tests/memory_mgmt_test.py::MemoryMgmtTest::test_postfields_unicode_memory_leak_gh252
    /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:300: DeprecationWarning: Please use assertTrue instead.
      self.assert_(after_object_count <= before_object_count + 1000, 'Grew from %d to %d objects' % (before_object_count, after_object_count))

  tests/setopt_test.py::SetoptTest::test_set_httpheader_none
    /build/pycurl-7.43.0.2/tests/setopt_test.py:75: DeprecationWarning: Please use assertEqual instead.
      self.assertEquals(util.b('foo'), io.getvalue())

  tests/setopt_test.py::SetoptTest::test_set_httpheader_none
    /build/pycurl-7.43.0.2/tests/setopt_test.py:81: DeprecationWarning: Please use assertEqual instead.
      self.assertEquals(util.b(''), io.getvalue())

  tests/setopt_test.py::SetoptTest::test_unset_httpheader
    /build/pycurl-7.43.0.2/tests/setopt_test.py:61: DeprecationWarning: Please use assertEqual instead.
      self.assertEquals(util.b('foo'), io.getvalue())

  tests/setopt_test.py::SetoptTest::test_unset_httpheader
    /build/pycurl-7.43.0.2/tests/setopt_test.py:67: DeprecationWarning: Please use assertEqual instead.
      self.assertEquals(util.b(''), io.getvalue())

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  ===Flaky Test Report===

  test_getinfo passed 1 out of the required 1 times. Success!
  test_getinfo_times passed 1 out of the required 1 times. Success!
  test_cyclic_gc passed 1 out of the required 1 times. Success!
  test_debugfunction_collection passed 1 out of the required 1 times. Success!
  test_form_bufferptr_memory_leak_gh267 passed 1 out of the required 1 times. Success!
  test_headerfunction_collection passed 1 out of the required 1 times. Success!
  test_headerfunction_refcounting passed 1 out of the required 1 times. Success!
  test_ioctlfunction_collection passed 1 out of the required 1 times. Success!
  test_multi_collection passed 1 out of the required 1 times. Success!
  test_multi_cycle passed 1 out of the required 1 times. Success!
  test_opensocketfunction_collection passed 1 out of the required 1 times. Success!
  test_postfields_unicode_memory_leak_gh252 passed 1 out of the required 1 times. Success!
  test_progressfunction_collection failed (2 runs remaining out of 3).
          <class 'AssertionError'>
          False is not true
          [<TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:249>, <TracebackEntry /build/pycurl-7.43.0.2/tests/util.py:192>, <TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:285>]
  test_progressfunction_collection passed 1 out of the required 1 times. Success!
  test_readdata_refcounting passed 1 out of the required 1 times. Success!
  test_readfunction_collection failed (2 runs remaining out of 3).
          <class 'AssertionError'>
          False is not true
          [<TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:246>, <TracebackEntry /build/pycurl-7.43.0.2/tests/util.py:192>, <TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:285>]
  test_readfunction_collection failed (1 runs remaining out of 3).
          <class 'AssertionError'>
          False is not true
          [<TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:246>, <TracebackEntry /build/pycurl-7.43.0.2/tests/util.py:192>, <TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:285>]
  test_readfunction_collection failed; it passed 0 out of the required 1 times.
          <class 'AssertionError'>
          False is not true
          [<TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:246>, <TracebackEntry /build/pycurl-7.43.0.2/tests/util.py:192>, <TracebackEntry /build/pycurl-7.43.0.2/tests/memory_mgmt_test.py:285>]
  test_readfunction_refcounting passed 1 out of the required 1 times. Success!
  test_refcounting_bug_in_reset passed 1 out of the required 1 times. Success!
  test_reference_counting passed 1 out of the required 1 times. Success!
  test_seekfunction_collection passed 1 out of the required 1 times. Success!
  test_share_collection passed 1 out of the required 1 times. Success!
  test_share_cycle passed 1 out of the required 1 times. Success!
  test_writedata_refcounting passed 1 out of the required 1 times. Success!
  test_writefunction_collection passed 1 out of the required 1 times. Success!
  test_writefunction_refcounting passed 1 out of the required 1 times. Success!
  test_writeheader_refcounting passed 1 out of the required 1 times. Success!
  test_xferinfofunction_collection passed 1 out of the required 1 times. Success!
  test_curl_ref passed 1 out of the required 1 times. Success!
  test_opensocketfunction_collection passed 1 out of the required 1 times. Success!
  test_seekfunction_collection passed 1 out of the required 1 times. Success!
  test_multi_socket_select passed 1 out of the required 1 times. Success!
  test_pause_via_call passed 1 out of the required 1 times. Success!
  test_pause_via_return passed 1 out of the required 1 times. Success!
  test_post_byte_buffer passed 1 out of the required 1 times. Success!
  test_post_fields_with_ampersand passed 1 out of the required 1 times. Success!
  test_post_file passed 1 out of the required 1 times. Success!
  test_post_list_of_list_of_lists passed 1 out of the required 1 times. Success!
  test_post_list_of_tuple_of_tuples passed 1 out of the required 1 times. Success!
  test_post_multiple_fields passed 1 out of the required 1 times. Success!
  test_post_single_field passed 1 out of the required 1 times. Success!
  test_post_tuple_of_lists_of_tuples passed 1 out of the required 1 times. Success!
  test_post_tuple_of_tuple_of_lists passed 1 out of the required 1 times. Success!
  test_post_tuple_of_tuples_of_tuples passed 1 out of the required 1 times. Success!
  test_post_unicode_buffer passed 1 out of the required 1 times. Success!
  test_post_with_null_byte passed 1 out of the required 1 times. Success!

  ===End Flaky Test Report===
  = 1 failed, 375 passed, 9 skipped, 11 deselected, 8 warnings in 19.84 seconds ==
  ----------------------------------------
  Exception happened during processing of request from ('127.0.0.1', 47296)
  Traceback (most recent call last):
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 138, in run
      self.finish_response()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 180, in finish_response
      self.write(data)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 274, in write
      self.send_headers()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 332, in send_headers
      self.send_preamble()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 255, in send_preamble
      ('Date: %s\r\n' % format_date_time(time.time())).encode('iso-8859-1')
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 453, in _write
      result = self.stdout.write(data)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/socketserver.py", line 799, in write
      self._sock.sendall(b)
  BrokenPipeError: [Errno 32] Broken pipe

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 141, in run
      self.handle_error()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 368, in handle_error
      self.finish_response()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 180, in finish_response
      self.write(data)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 274, in write
      self.send_headers()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 331, in send_headers
      if not self.origin_server or self.client_is_modern():
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 344, in client_is_modern
      return self.environ['SERVER_PROTOCOL'].upper() != 'HTTP/0.9'
  TypeError: 'NoneType' object is not subscriptable

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/socketserver.py", line 316, in _handle_request_noblock
      self.process_request(request, client_address)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/socketserver.py", line 347, in process_request
      self.finish_request(request, client_address)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/socketserver.py", line 360, in finish_request
      self.RequestHandlerClass(request, client_address, self)
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/socketserver.py", line 720, in __init__
      self.handle()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/simple_server.py", line 133, in handle
      handler.run(self.server.get_app())
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/handlers.py", line 144, in run
      self.close()
    File "/nix/store/lmwk7mg8y79m3izdxdlckdn385x7jgl7-python3-3.7.3/lib/python3.7/wsgiref/simple_server.py", line 35, in close
      self.status.split(' ',1)[0], self.bytes_sent
  AttributeError: 'NoneType' object has no attribute 'split'
  ----------------------------------------
  part1part2
  note: keeping build directory '/tmp/nix-build-python3.7-pycurl-7.43.0.2.drv-1'
  builder for '/nix/store/1p8754s04chk6sjjb943z8878sd26mks-python3.7-pycurl-7.43.0.2.drv' failed with exit code 1
  error: build of '/nix/store/1p8754s04chk6sjjb943z8878sd26mks-python3.7-pycurl-7.43.0.2.drv' failed

  ```


  ### Steps to reproduce

  run `nix-build -A python3Packages.pycurl ~/nixpkgs`

  there is no listed maintainer but a blame shows @adisbladis and @FRidh activity on it.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.0, NixOS, 19.09.git.1faecef (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(teto): `""`
   - channels(root): `""`
   - nixpkgs: `/home/teto/nixpkgs`


state: closed
title: python3.7-docutils: build fix on darwin
user_login: virusdave
html_url: https://github.com/NixOS/nixpkgs/pull/59758
updated_at: 2019-04-18 06:37:26
body:
  ###### Motivation for this change
  Fix python docutils package for OSX.  On a relatively clean new macbook,
  with latest OS Mojave 10.14.3, this package failed to build.  A bit of
  searching led to:
  https://coderwall.com/p/-k_93g/mac-os-x-valueerror-unknown-locale-utf-8-in-python
  Setting the other environment variable mentioned there (`LC_ALL`) sufficed to resolve the build failure.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: wesnoth: 1.14.6 -> 1.14.7
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59759
updated_at: 2019-04-17 09:05:34
body:
  ###### Motivation for this change

  Updating to latest version.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: plata-theme: 0.6.0 -> 0.7.6
user_login: tadfisher
html_url: https://github.com/NixOS/nixpkgs/pull/59760
updated_at: 2019-04-18 21:39:57
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `plata-theme` to 0.7.6.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: protonmail: 1.1.3 -> 1.1.4
user_login: GRBurst
html_url: https://github.com/NixOS/nixpkgs/pull/59763
updated_at: 2019-04-17 12:40:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update to latest version

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update wine{unstable,staging,mono}
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/59764
updated_at: 2019-04-18 07:35:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

   - wine{unstable,staging}: 4.5 -> 4.6
   - wine-mono: 4.8.0 -> 4.8.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.gnome-control-center: Add mutter keybindings
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/59765
updated_at: 2019-04-17 23:41:59
body:
  ###### Motivation for this change
  Closes: https://github.com/NixOS/nixpkgs/issues/19590


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vscode: use absolute predetermined path instead of heuristic
user_login: Synthetica9
html_url: https://github.com/NixOS/nixpkgs/pull/59766
updated_at: 2019-04-17 21:51:28
body:
  Fixes #59725

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #59725

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-bloat: init at 0.6.2
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59767
updated_at: 2019-04-18 22:55:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  A tool and Cargo subcommand that helps you find out what takes most of the space in your Rust executable.
  https://github.com/RazrFalcon/cargo-bloat

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gitlab-runner: 11.9.0 -> 11.9.2
user_login: bachp
html_url: https://github.com/NixOS/nixpkgs/pull/59768
updated_at: 2019-04-18 08:11:39
body:
  Fixes issues with git lfs.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport prometheus ec2_sd_config and tls_config options to release-19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59769
updated_at: 2019-04-18 11:44:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I would like to use the new `ec2_sd_config` and `tls_config` prometheus options on NixOS-19.03.

  ###### Things done

  Cherry-picked https://github.com/NixOS/nixpkgs/pull/56017 and https://github.com/NixOS/nixpkgs/pull/54691.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ZFS unstable fails to build with latest Kernel
user_login: Luis-Hebendanz
html_url: https://github.com/NixOS/nixpkgs/issues/59770
updated_at: 2019-04-18 21:46:42
body:
  ## Issue description
  On upgrading my 18.09 zfs encrypted base system with 
  ```
  zfs.enableUnstable = true;
  zfs.requestEncryptionCredentials = true;
  boot.kernelPackages= pkgs.linuxPackages_latest;
  ```
  I got the following error:

  ```
  cc1: some warnings being treated as errors
  make[7]: *** [/nix/store/zqcvpqpl1vy3pjiw9imkapj5n1cpp868-linux-5.0.7-dev/lib/modules/5.0.7/source/scripts/Makefile.build:277: /build/source/module/icp/illumos-crypto.o] Error 1
  make[6]: *** [/nix/store/zqcvpqpl1vy3pjiw9imkapj5n1cpp868-linux-5.0.7-dev/lib/modules/5.0.7/source/scripts/Makefile.build:492: /build/source/module/icp] Error 2
  make[5]: *** [/nix/store/zqcvpqpl1vy3pjiw9imkapj5n1cpp868-linux-5.0.7-dev/lib/modules/5.0.7/source/Makefile:1576: _module_/build/source/module] Error 2
  make[4]: *** [Makefile:171: sub-make] Error 2
  make[3]: *** [Makefile:15: __sub-make] Error 2
  make[3]: Leaving directory '/nix/store/zqcvpqpl1vy3pjiw9imkapj5n1cpp868-linux-5.0.7-dev/lib/modules/5.0.7/build'
  make[2]: *** [Makefile:30: modules] Error 2
  make[2]: Leaving directory '/build/source/module'
  make[1]: *** [Makefile:799: all-recursive] Error 1
  make[1]: Leaving directory '/build/source'
  make: *** [Makefile:668: all] Error 2
  builder for '/nix/store/b811aynkhvf34pgdlhs5y40vc7xphgwg-zfs-kernel-0.8.0-rc3-5.0.7.drv' failed with exit code 2
  cannot build derivation '/nix/store/fwiygb7j4d8isajr8znm8qbyd46f5i97-kernel-modules.drv': 1 dependencies couldn't be built
  cannot build derivation '/nix/store/nmwr49gfsq26qm7xzrsa0k75wj9i97d2-nixos-system-home-server-19.03.172205.ea497998e4b.drv': 1 dependencies couldn't be built
  error: build of '/nix/store/nmwr49gfsq26qm7xzrsa0k75wj9i97d2-nixos-system-home-server-19.03.172205.ea497998e4b.drv' failed
  ```

  Full output: https://gist.github.com/Luis-Hebendanz/333ca4eb855cf9d2889b7386a6477456


  ### Steps to reproduce
  ```
  $ nix-channel --add https://nixos.org/channels/nixos-19.03 nixos
  $ nixos-rebuild switch --upgrade
  ```

  ## Reason (thanks @Ashy)
  https://www.phoronix.com/scan.php?page=news_item&px=ZFS-On-Linux-5.0-Workaround

  ## Workaround
  Not using the latest kernel

  > #boot.kernelPackages= pkgs.linuxPackages_latest;

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 18.09.2519.2aa505b77c0 (Jellyfish)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.1.3`
   - channels(root): `"nixos-18.09.2519.2aa505b77c0"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos


state: closed
title: linuxPackages_hardened fails to build on 19.03
user_login: Luis-Hebendanz
html_url: https://github.com/NixOS/nixpkgs/issues/59771
updated_at: 2019-04-19 11:21:55
body:
  ## Issue description
  Having this in my config:
  > boot.kernelPackages = mkDefault pkgs.linuxPackages_hardened;

  Errors out to:
  ```
  make[1]: Leaving directory '/build/linux-4.19.34/build'
  Error: modDirVersion 4.19.34 specified in the Nix expression is wrong, it should be: 4.19.34-hardened
  builder for '/nix/store/7slfrhibgfsdvx4zn3yi37k448iq3knx-linux-4.19.34.drv' failed with exit code 1
  ```
  Complete Error: https://gist.github.com/Luis-Hebendanz/237f1b0aff6dc2c1051fbeeadc61d4b8


  ### Steps to reproduce

  $ nix-channel --add https://nixos.org/channels/nixos-19.03 nixos
  $ nixos-rebuild switch --upgrade

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172231.7b36963e7a7 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172231.7b36963e7a7"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Gnome File manager doesn't work in 19.03
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/59772
updated_at: 2019-04-18 09:35:04
body:
  ## Issue description
  Pressing file manager in gnome 3 takes around 5 minutes to start up. And then afterwards
  it will say "Files does not respond" and i need to force quit it.


  ### Steps to reproduce
  Enable gnome3 desktop manager and try to browse files
  Nothing happens

  Or in the terminal type:
  ```
  nautilus
  ```

  and nothing happens


state: closed
title: perlPackages.libapreq2 does not install perl module
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/issues/59773
updated_at: 2019-04-19 01:15:21
body:
  ## Issue description
  The `perlPackages.libapreq2` package does not include the perl modules which are part of the upstream source code.

  The missing modules are:
  https://metacpan.org/source/ISAAC/libapreq2-2.13/glue/perl/lib/Apache2
  https://metacpan.org/source/ISAAC/libapreq2-2.13/glue/perl/xsbuilder/APR

  When building locally I see `./configure --enable-perl-glue ...` which leads me to believe the issue might be in the custom `installPhase`:
  ```
      installPhase = ''
        mkdir $out
        make install DESTDIR=$out
        cp -r $out/${pkgs.apacheHttpd.dev}/. $out/.
        cp -r $out/$out/. $out/.
        rm -r $out/nix
      '';
  ```

  @volth do you have any ideas?

  ### Steps to reproduce
  Install `perlPackages.libapreq2` and note there are no perl modules included.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172205.ea497998e4b (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172205.ea497998e4b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: emacs-zmq binary is not installed
user_login: fritz-k
html_url: https://github.com/NixOS/nixpkgs/issues/59774
updated_at: 2019-07-17 21:12:42
body:
  ## Issue description
  [emacs-zmq](https://github.com/dzop/emacs-zmq) is missing a binary. 


  ### Steps to reproduce
  Install
  ```
  (emacsPackagesNgGen emacs).emacsWithPackages (epkgs: [
      epkgs.melpaPackages.jupyter
      ]))
  ```
  running `M-x jupyter-run-repl` warns about a missing binary of emacs-zmq which it then tries to build and fails at.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172138.5c52b25283a (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172138.5c52b25283a"`
   - channels(vu1073): `"home-manager-19.03, nixos-unstable-19.09pre175916.1fc591f9a5b, nixos-18.09-18.09.1985.749a3a0d00b"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: python-language-server: 0.25.0 -> 0.26.1
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/pull/59775
updated_at: 2019-04-17 14:11:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upstream release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixops: 1.6.1 -> 1.7
user_login: AmineChikhaoui
html_url: https://github.com/NixOS/nixpkgs/pull/59776
updated_at: 2019-04-17 15:30:49
body:
  Add release 1.7, also keep version 1.6.1 available for Azure
  backend users. Azure backend was disabled in v1.7 due to the
  python API changes.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lib.converge: optimise
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/59777
updated_at: 2019-04-28 21:39:41
body:
  ###### Motivation for this change

  https://github.com/NixOS/nixpkgs/pull/51884#pullrequestreview-223602570

  Cc: @cstrahan

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: terraform-providers: bump versions
user_login: stephengroat
html_url: https://github.com/NixOS/nixpkgs/pull/59778
updated_at: 2019-04-20 23:43:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  bump terraform-provider versions

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/bumblebee: allow legacy nvidia drivers
user_login: fgaz
html_url: https://github.com/NixOS/nixpkgs/pull/59780
updated_at: 2019-06-26 09:08:56
body:
  ###### Motivation for this change

  I have an old GPU that requires a legacy driver. Without this patch using bumblebee with it is impossible. While this didn't fix my problem and I ended up using nouveau (so I can't properly test this), I think it's a nice addition to the module

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request: gam
user_login: memberbetty
html_url: https://github.com/NixOS/nixpkgs/issues/59781
updated_at: 2019-04-17 17:06:57
body:
  ## Issue description
  It's a tool for managing Google G Suite available at https://github.com/jay0lee/GAM.


state: closed
title: bundix: 2.4.2 -> 2.4.3
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/59782
updated_at: 2019-04-17 17:48:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/manveru/bundix/releases/tag/2.4.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ruby_2_6: 2.6.2 -> 2.6.3
user_login: alyssais
html_url: https://github.com/NixOS/nixpkgs/pull/59783
updated_at: 2019-04-18 10:11:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: WIP: pkgsEmscripten: emscripten package set using cross toolchain
user_login: FRidh
html_url: https://github.com/NixOS/nixpkgs/pull/59784
updated_at: 2019-05-18 07:56:53
body:
  Implement the emscripten package set using the cross toolchain in a similar
  way as `pkgsMusl`.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sage: fix another transient sig_on bug
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59785
updated_at: 2019-04-17 18:39:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Caused a test failure on hydra, backporting upstream fix.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] sage: fix another transient sig_on bug
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59786
updated_at: 2019-04-17 18:39:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Caused a test failure on hydra, backporting upstream fix.

  (cherry picked from commit d75b30774ee6a472fdac7666fb84cbd44cc07bc1)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: glibc: re-enable stripping in cross builds
user_login: delroth
html_url: https://github.com/NixOS/nixpkgs/pull/59787
updated_at: 2019-04-17 20:07:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  References to the host toolchain are leaking through debug symbols in glibc, causing gnu cross-builds to always depend on the host toolchain. The decision to not strip was made in 2009 (c6b526495bc37e63b43c3fc17705cefac81fa904), and I suspect the reasons that justified it back then do not apply anymore in 2019.

  Closure size before:
  /nix/store/v5pxj0bgg627hic2khk4d43z6cjp5v7d-hello-2.10-armv7l-unknown-linux-gnueabihf                            596.8M

  After:
  /nix/store/llp1ncmpar406rc2vhj7g5ix4yqwna3n-hello-2.10-armv7l-unknown-linux-gnueabihf     23.6M

  Fixes #58501 (as far as I can tell). @illegalprime @Thra11 @matthewbauer 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] gnome3.tracker: 2.1.6 -> 2.1.8
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59788
updated_at: 2019-04-18 10:41:21
body:
  Fixes https://github.com/NixOS/nixpkgs/issues/59772

  Also fix path to gdbus in the autostart.

  https://gitlab.gnome.org/GNOME/tracker/blob/2.1.8/NEWS

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tilt: init at 0.7.13
user_login: anton-dessiatov
html_url: https://github.com/NixOS/nixpkgs/pull/59789
updated_at: 2019-04-20 11:28:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  [Tilt](https://tilt.dev/) is a convenient tool to help developers work on microservices locally at their dev machines. It automates edit-compile-deploy cycle against minikube.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfsUnstable: 0.8.0-rc3 -> 0.8.0-rc4
user_login: adisbladis
html_url: https://github.com/NixOS/nixpkgs/pull/59791
updated_at: 2019-04-18 21:37:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grilo-plugins fails to build
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/issues/59792
updated_at: 2019-04-17 23:44:24
body:
  `grilo-plugins` fails to build due to missing `libgdata` headers.

  Apparently this is a regression caused by c2de086b17379492bae278f62911f4fc83a782db

  Interestingly,

  ```meson
  libgdata_dep = dependency('libgdata', version: '>= 0.9.1', required: false)
  libsoup_dep = dependency('libsoup-2.4', required: false)
  warning('libsoup: @0@, libgdata @1@'.format(libsoup_dep.found(), libgdata_dep.found()))
  ```

  prints `WARNING: libsoup: false, libgdata true`, even though `libsoup` is in `Requires`.

  which is incongruous with the way `pkg-config` sees the package:

  ```ShellSession
  pkg-config --cflags libgdata
  Package libsoup-2.4 was not found in the pkg-config search path.
  Perhaps you should add the directory containing `libsoup-2.4.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'libsoup-2.4', required by 'libgdata', not found
  ```

  _Originally posted by @jtojnar in https://github.com/NixOS/nixpkgs/pull/59765#issuecomment-484220957_


state: closed
title: gnome3.grilo-plugins: add dependencies
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/59793
updated_at: 2019-04-17 23:44:29
body:
  ###### Motivation for this change
  Add libsoup dependency which is required by libgdata dependency of YouTube plug-in and also by Dleyna plug-in, and which was removed during previous clean-up.

  Also add dependencies for lua-factory plug-in which is enabled by default by master.

  Partially fixes: https://github.com/NixOS/nixpkgs/issues/59792

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: go-ethereum: 1.8.26 -> 1.8.27
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59794
updated_at: 2019-04-19 09:48:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `go-ethereum` to the latest release.

  https://github.com/ethereum/go-ethereum/releases/tag/v1.8.27

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3{5,6}: Reintroduce bytecode determinism
user_login: bb010g
html_url: https://github.com/NixOS/nixpkgs/pull/59796
updated_at: 2019-04-19 05:33:49
body:
  ###### Motivation for this change

  Originally introduced in #22585, patches to lock down CPython bytecode mtime timestamps were lost in #53123 when the CPython version files were merged, likely due to CPython 3.7 not needing them anymore. These patches should remain in-tree until CPython 3.5 and 3.6 support is dropped completely.

  Found with the [diffoscope](https://diffoscope.org/).

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Due to the scope of this change, I've only tested it on [my NUR](https://github.com/bb010g/nur-packages) Python packages / applications, but tests passed and the `nix-build --check` came up clean on python3-3.6.8, python3.6-setuptools-40.8.0, python3.6-dnspython-1.16.0, python3.6-namedlist-1.7, python3.6-certifi-2018.11.29, python3.6-six-1.12.0, python3.6-webencodings-0.5.1, python3.6-html5lib-1.0.1, python3.6-SQLAlchemy-1.2.14, python3.6-Yapsy-1.12.0, python3.6-singledispatch-3.4.0.3, python3.6-backports_abc-0.5, python3.6-tornado-4.5.3, python3.6-chardet-3.0.4, and python3.6-wpull-2.0.3.

  It's the same patch as before; I'm not sure how much more testing it needs. Applied to staging because I think that's where large rebuild PRs go?


state: closed
title: Gnome Documents & Books package is broken in 19.03
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/59797
updated_at: 2019-04-18 09:30:32
body:
  ## Issue description
  It doesn't start.  crashes with the following log in `journald`

  ```
  Apr 17 23:32:24 t430s .gnome-document[9909]: JS LOG: Can't find a valid getting started PDF document
  Apr 17 23:32:24 t430s .gnome-document[9909]: JS ERROR: TypeError: Application.modeController is null
                                               _init@resource:///org/gnome/Documents/js/notifications.js:189:9
                                               wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                               _Base.prototype._construct@resource:///org/gnome/gjs/modules/_legacy.js:18:5
                                               newClass@resource:///org/gnome/gjs/modules/_legacy.js:114:32
                                               _init@resource:///org/gnome/Documents/js/notifications.js:345:38
                                               wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                               _createWindow@resource:///org/gnome/Documents/js/application.js:420:31
                                               wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                               vfunc_activate@resource:///org/gnome/Documents/js/application.js:475:13
                                               wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                               main@resource:///org/gnome/Documents/js/main.js:48:12
                                               run@resource:///org/gnome/gjs/modules/package.js:225:12
                                               @/nix/store/20p8aq1ccya0s50jsnl4w6np32abn68m-gnome-documents-3.30.0/bin/.gnome-documents-wrapped:6:1

  ```


  ### Steps to reproduce

  ```
  $ gnome-documents
  $ journalctl -xef
  ```


state: closed
title: vscode: patch proper executable
user_login: eadwu
html_url: https://github.com/NixOS/nixpkgs/pull/59798
updated_at: 2019-04-18 06:41:33
body:
  Fixes #59766.
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: janet: 0.4.0 -> 0.4.1
user_login: andrewchambers
html_url: https://github.com/NixOS/nixpkgs/pull/59799
updated_at: 2019-04-19 20:35:36
body:
  ###### Motivation for this change

  Package update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dleyna-renderer: checkout patch in tree
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59800
updated_at: 2019-04-18 00:08:01
body:
  Built this locally and noticed that the hash changed

  wanted: sha256:0x5vj5zfk95avyg6g3nf6gar250cfrgla2ixj2ifn8pcick2d9vq
  got:        sha256:0m7rxv2nnycvwqpc8ak396g8cbb9g6dw290cjbfwhrrhdhbii5qc

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: stretchly: init at 0.19.1 (backport to 19.03)
user_login: cdepillabout
html_url: https://github.com/NixOS/nixpkgs/pull/59801
updated_at: 2019-04-24 05:28:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This backports the stretchly derivation from #59383 to 19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cracklib: fix cross build
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/59802
updated_at: 2019-04-23 20:04:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #56805 broke cross compilation of cracklib (which breaks tons of other things). 

  ###### Things done

  Adding `buildPackages.cracklib` to `nativeBuildInputs` adds the necessary tools to `PATH` to build the dictionary. The `dict-local` target does the same thing as `dict` except it explicitly specifies the output file. This prevents native `cracklib-packer` from trying to write to its own output directory.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/netboot: import -> callPackage
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59803
updated_at: 2019-06-11 01:30:24
body:
  Copy-paste from iso-image.nix
  https://github.com/NixOS/nixpkgs/blob/ca7a18a24b4e54fb8ed2d756cd1c017e1aa67774/nixos/modules/installer/cd-dvd/iso-image.nix#L577-L579

  Besides the simplification, it should use ```pkgs.buildPackages.squashfsTools``` because it is used in ```nativeBuildInputs``` instead of incorrect ```pkgs.squashfsTools``` which was forced by ```import```


state: closed
title: ubootRock64, ubootRockPro64: make compatible with latest dtc
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/59804
updated_at: 2019-05-06 19:08:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The update to U-Boot 1.5.0 dropped the setup.py patch, but it is still needed by dtc 1.4.5, used to build `ubootRock64`.

  ###### Things done

  Add the patch to the dtc 1.4.5 override.

  cc @dezgeg 
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.gnome-control-center: Add mutter keybindings (backport to release-19.03)
user_login: das-g
html_url: https://github.com/NixOS/nixpkgs/pull/59805
updated_at: 2019-04-18 13:21:24
body:
  fixes #19590 for release-19.03

  (cherry picked from commit 1e6fec059dfd2728b6060479182f3c840bbfb661)

  ###### Motivation for this change

  Backport of #59765

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (through `nix-review`, see below)
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using ~`nix-shell -p nix-review --run "nix-review wip"`~ `nix-shell -p nix-review --run "nix-review wip --branch release-19.03"`
  - [x] Tested execution of ~all binary files (usually in `./result/bin/`)~ `results/gnome3.gnome-control-center/bin/gnome-control-center` (produced by the command above, in the nix-shell into which I was dropped by it)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: openssh: 7.9p1 -> 8.0p1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59806
updated_at: 2019-06-20 04:12:24
body:
  ###### Motivation for this change

  https://www.openwall.com/lists/oss-security/2019/04/18/1

  Sending to staging for anticipated build impact,
  please promote to master as needed for security implications.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dhcpcd: 7.1.1 -> 7.2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59807
updated_at: 2019-04-23 23:18:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://roy.marples.name/blog/dhcpcd-7-2-0-released

  D'oh there's a test to run that I haven't checked yet!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libseccomp: 2.4.0 -> 2.4.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59808
updated_at: 2019-04-18 06:39:30
body:
  ###### Motivation for this change

  https://github.com/seccomp/libseccomp/releases/tag/v2.4.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libcap: 2.26 -> 2.27
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59809
updated_at: 2019-04-18 06:43:06
body:
  ###### Motivation for this change

  Appears to contain minor touchups, so low priority I think.

  https://sites.google.com/site/fullycapable/release-notes-for-libcap/releasenotesfor227

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xl2tpd: 1.3.13 -> 1.3.14
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59810
updated_at: 2019-04-18 06:40:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/xelerance/xl2tpd/releases/tag/v1.3.14

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python: provide hasCxxDistutils attribute for pythonPackages.numpy
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/59811
updated_at: 2019-04-28 07:30:13
body:
  Patching numpy.distutils used to be required for pythonPackages.cython
  to build on darwin. It was later accidentally disabled during one of the
  refactorings, but that did not break cython. This change reinstantiates
  the patch. It still applies, so it should be low maintenance and it can
  still be useful.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lz4: 1.8.3 -> 1.9.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59812
updated_at: 2019-05-03 06:18:00
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/lz4/lz4/releases/tag/v1.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zstd: 1.3.8 -> 1.4.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/59813
updated_at: 2019-04-21 23:22:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/facebook/zstd/releases/tag/v1.4.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyflame: fix builds & support 3.7
user_login: bb010g
html_url: https://github.com/NixOS/nixpkgs/pull/59814
updated_at: 2019-04-19 05:32:50
body:
  ###### Motivation for this change

  pyflame's tests weren't terminating and were leaking memory, making `nix-review` for #59796 rather confusing and slower. I fixed them, and added Python 3.7 support while I was at it because why not. (Uber's left the repository stagnant since June of 2018.)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Closes #52827, supersedes #52828. Unlike that PR, `fetchpatch` is used properly and pyflame PRs are documented for any necessary future updates.


state: closed
title: rygel fails to build
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/issues/59815
updated_at: 2019-04-18 12:07:34
body:
  ## Issue description

  rygel fails to build due to a valadoc error when generating docs. The error is:
  `error: Package 'gupnp-1.0' not found in specified Vala API directories or GObject-Introspection GIR directories`

  This prevents gnome3 from being built unless `services.gnome3.rygel.enable` is set to `false`.

  ### Steps to reproduce

  `nix-build '<nixpkgs>' -A gnome3.rygel ~/repos/nixpkgs`

  Tested against `7f2f8f359fe`, which at the time of writing is the HEAD of `nixos-unstable-small`.

  ## Technical details

  System info:
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.35, NixOS, 19.09pre176459.7f2f8f359fe (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre176459.7f2f8f359fe"`
   - channels(chris): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pandoc-imagine: init at unstable-2018-11-19
user_login: Synthetica9
html_url: https://github.com/NixOS/nixpkgs/pull/59816
updated_at: 2019-04-26 10:02:09
body:
  There exists a released version, but it's more than a year behind the latest master. 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: prl-tools: 12.2.1-41615 -> 14.1.3-45485
user_login: Vonfry
html_url: https://github.com/NixOS/nixpkgs/pull/59817
updated_at: 2019-04-23 05:23:28
body:
  cc: @abbradar

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update parallels desktop((a virtual machine software on macos) tools version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.mutter: 3.32.0 -> 3.32.1
user_login: callahad
html_url: https://github.com/NixOS/nixpkgs/pull/59818
updated_at: 2019-04-23 11:55:34
body:
  ###### Motivation for this change

  Version bump.

  Fixes [a few crashes](https://gitlab.gnome.org/GNOME/mutter/merge_requests/506) associated with resume from suspend that were introduced in 3.32.0.

  [NEWS for 3.32.1](https://gitlab.gnome.org/GNOME/mutter/blob/3.32.1/NEWS):

  ```
  * Fix fallback app menu on wayland [Florian; #493]
  * Fix elogind support [Tom; !491]
  * Fix startup notifications not timing out [Carlos; #501]
  * Fix keyboard accessibility toggle from keys
    [Olivier, Carlos; !501, #529, !531]
  * Fix touchscreen input on rotated displays [Carlos; #514]
  * Work around hangul text input bug [Carlos; #1365]
  * Fix blurry wallpaper scaling [Daniel; !505]
  * Fix placement of window menu when using fractional scaling [Jan; #527]
  * Fix repaint issues of offscreen effects on secondary monitors [Daniel; !511]
  * Fix windows not getting focus after launch [Daniel; #505]
  * Properly advertise support for 'underscan' property [Jonas; !507]
  * Improve power-saving handling [Jonas; !506]
  * Fix moving windows by super+touch [Jonas D.; !495]
  * Misc. bug fixes and cleanups [Benjamin, Florian, Adam, Marco, Pablo,
    Erik, Jonas, Heiher, Pekka, Daniel, Olivier, Carlos; !478, !475, !480,
    !482, #490, !488, #491, #480, !477, !496, !492, !485, !515, !519, !521,
    !216, !538, #541, #523]

  Contributors:
    Jonas Ådahl, Pablo Barciela, Benjamin Berg, Tom Briden, Jonas Dreßler,
    Olivier Fourdan, Carlos Garnacho, Jan Alexander Steffens (heftig), Heiher,
    Adam Jackson, Erik Kurzinger, Florian Müllner, Pekka Paalanen,
    Marco Trevisan (Treviño), Daniel van Vugt

  Translators:
    Khaled Hosny [ar], Goran Vidović [hr], Daniel Mustieles [es]
  ```

  ###### Things done

  I'm successfully running this on my personal laptop.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages.tlc: 20180316 -> 20181116
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/59820
updated_at: 2019-04-24 06:55:05
body:
  ###### Motivation for this change

  Compatibility with Coq 8.10.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix-zsh-completions: 0.4.2 -> 0.4.3
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/59821
updated_at: 2019-04-18 12:09:41
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Added new completions for `nixos-build-vms`[1].

  See https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.3

  [1] https://github.com/NixOS/nixpkgs/pull/55121 added support for
  `--option`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] steam: fix steamrt trying to use a missing setup.sh
user_login: srhb
html_url: https://github.com/NixOS/nixpkgs/pull/59822
updated_at: 2019-04-18 20:11:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Backport #59326
  Try to fix steam on 19.03. I haven't actually tested it on 19.03, but I believe it should work just fine.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lambda-mod-zsh-theme: 2017-10-08 -> 2019-04-17
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/59823
updated_at: 2019-04-22 20:57:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  See https://github.com/halfo/lambda-mod-zsh-theme/compare/61c373c...6b83aed

  The newly introduced commit (87e7cd7) adds support for LAMBDA_MOD_N_DIR_LEVELS
  to control the amount of dir levels shown in the prompt.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.rygel: fix build
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/pull/59824
updated_at: 2019-04-18 12:07:38
body:
  Fixes #59815

  * add patch for installation sysconfdir
  * disable api docs

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages.Verdi: 20181102 -> 20190202
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/59825
updated_at: 2019-04-25 06:35:24
body:
  ###### Motivation for this change

  Compatibility with Coq 8.10

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: parity: 2.3 -> 2.4
user_login: akru
html_url: https://github.com/NixOS/nixpkgs/pull/59826
updated_at: 2019-04-23 21:03:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Upgrade to latest version of [parity-ethereum](https://github.com/paritytech/parity-ethereum/releases).

  WARNING: https://github.com/NixOS/nixpkgs/pull/57017 should be merge before this.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/systemd: add an option to suppress system units
user_login: oxij
html_url: https://github.com/NixOS/nixpkgs/pull/59827
updated_at: 2019-04-22 20:47:26
body:
  # What? Why?

  Originally #59742, but I also comment-out a bunch of upstream units (e.g. `rescue` and `time-sync` things) on my NixOS+systemd systems anyway, so this feature is warranted even without that PR, IMHO.

  # `git log`

  - nixos/systemd: add an option to suppress system units

  # `nix-instantiate` environment

  - Host OS: Linux 4.9, SLNOS 19.09
  - Nix: nix-env (Nix) 2.2
  - Multi-user: yes
  - Sandbox: yes
  - NIXPKGS_CONFIG:

  ```nix
  {
    checkMeta = true;
    doCheckByDefault = true;
  }
  ```

  # `nix-env -qaP` diffs

  - On x86_64-linux:
    - Updated (1):
      - tests.nixos-functions.nixos-test
  - On aarch64-linux: ditto
  - On x86_64-darwin: noop


state: closed
title: nixos/prometheus: refactored & added more missing options
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59828
updated_at: 2019-04-18 11:43:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: More gnome 3.32.1
user_login: hedning
html_url: https://github.com/NixOS/nixpkgs/pull/59829
updated_at: 2019-04-19 08:35:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Some more gnome 3.32.1 updates


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: unity3d webgl build module error.
user_login: PlumpMath
html_url: https://github.com/NixOS/nixpkgs/issues/59830
updated_at: 2019-05-19 09:39:39
body:
  ## Issue description
  building webgl..
  occur wasm & clang error.

  welll build good in ubuntu.


  ### Steps to reproduce
  unity-hub too. same problem

  ## Technical details
  # installed package list
  unity3d
  emscripten emscriptenPackages.json_c emscriptenPackages.libxml2 emscriptenPackages.xmlmirror emscriptenPackages.zlib emscriptenfastcomp
  ncurses ncurses6 ncurses5
  cquery
  gnome2.GConf


state: closed
title: Backport "nixos/prometheus: refactored & added more missing options" to release 19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59831
updated_at: 2019-04-18 12:10:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I would like to use the improvements in https://github.com/NixOS/nixpkgs/pull/59828 on `release-19.03`.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Backport "Prometheus pushgateway 0.4.0 -> 0.8.0 & module" to release 19.03
user_login: basvandijk
html_url: https://github.com/NixOS/nixpkgs/pull/59832
updated_at: 2019-04-18 12:41:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I would like to use the latest prometheus pushgateway on NixOS. So this backports the following PRs to `release-19.03`:
  * https://github.com/NixOS/nixpkgs/pull/55982  `prometheus-pushgateway`: 0.4.0 -> 0.7.0
  * https://github.com/NixOS/nixpkgs/pull/59608: `prometheus-pushgateway`: 0.7.0 -> 0.8.0
  * https://github.com/NixOS/nixpkgs/pull/59676: adds the `services.prometheus.pushgateway` module.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mysql-workbench complains about missing org.freedesktop.secrets service
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/59833
updated_at: 2019-04-18 12:46:21
body:
  I need to come back and elaborate on this later but a workaround seems to be to also get gnome3.gnome-keyring and run the daemon (in the foreground?) with `-s -f`. 

  Unrelated issue?: later when actually trying to connect to a MariaDB 10 the whole thing segfaults for me. A further possible workaround seems to be to try using something like dbeaver or squirrel-sql.


state: closed
title: Prodigal: init at 2.6.3
user_login: luispedro
html_url: https://github.com/NixOS/nixpkgs/pull/59834
updated_at: 2019-04-22 03:33:57
body:
  ###### Motivation for this change

  Prodigal is widely used in bioinformatics.

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] other Linux distributions
  - [x] Tested execution of all binary files (usually in `./result/bin/`)


state: closed
title: sops: 3.2.0 -> 3.3.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/59835
updated_at: 2019-04-18 14:08:55
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://github.com/mozilla/sops/releases/tag/3.3.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocaml: 4.08.0+beta2 -> 4.08.0+beta3
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/59836
updated_at: 2019-04-25 06:46:02
body:
  ###### Motivation for this change

  Announcement: https://inbox.ocaml.org/caml-list/7B0DECD5-BF69-48F4-8524-DED5D46700C3@inria.fr/T/#u

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: steamrt 1.1 -> 1.2
user_login: jethrokuan
html_url: https://github.com/NixOS/nixpkgs/pull/59838
updated_at: 2019-04-19 14:32:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update the steam runtime from 1.1 to 1.2.

  Initially, ran into the issue described in https://github.com/NixOS/nixpkgs/pull/59326, but could no longer fetch some of the runtime files because they no longer existed on the mirrors. Updating the runtime with the provided python file fixed things for me.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [18.09] dovecot: fix CVE-2019-10691
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/59839
updated_at: 2019-04-22 21:31:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://dovecot.org/pipermail/dovecot-news/2019-April/000406.html


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dovecot: 2.3.5.1 -> 2.3.5.2
user_login: dotlambda
html_url: https://github.com/NixOS/nixpkgs/pull/59840
updated_at: 2019-04-22 21:31:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://dovecot.org/pipermail/dovecot-news/2019-April/000407.html
  fixes CVE-2019-10691

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Ship usual Python packages with QGIS
user_login: das-g
html_url: https://github.com/NixOS/nixpkgs/issues/59842
updated_at: 2019-05-02 11:37:05
body:
  TL;DR:

  QGIS from NixPkgs seems to be missing the following Python packages, which may be relied on by QGIS plugins:

  - `future`
  - `httplib2`
  - `markupsafe`
  - `plotly`
  - `pyproj`

  ## Issue description

  For non-Nix(OS) systems, QGIS usually ships with a base set of Python packages. Some of them are required by QGIS itself, while others aren't. But QGIS plugins or Python scripts of the user may still rely on them being accessible from within QGIS.

  The QGIS in NixPkgs currently doesn't ship with the complete set of them:

  QGIS 3.4 from NixOS release-19.03 [currently has](https://github.com/NixOS/nixpkgs/blob/a673ef75c16eb9f9f792cbc368b838237ec47590/pkgs/applications/gis/qgis/unwrapped.nix#L9) these `python3Packages` in its `buildInputs`:

  - `chardet`
  - `dateutil`
  - `gdal`
  - `jinja2`
  - `numpy`
  - `owslib`
  - `psycopg2`
  - `pygments`
  - `pyqt5`
  - `pytz`
  - `pyyaml`
  - `qscintilla-qt5`
  - `requests`
  - `sip`
  - `six`
  - `urllib3`

  The Ubuntu package `python3-qgis` (from https://qgis.org/ubuntu-ltr) currently depends on these packages:
  - `python3-dateutil`
  - `python3-future`
  - `python3-httplib2`
  - `python3-jinja2`
  - `python3-markupsafe`
  - `python3-owslib`
  - `python3-plotly`
  - `python3-psycopg2`
  - `python3-pygments`
  - `python3-pyproj`
  - `python3-pyqt5`
  - `python3-pyqt5.qsci`
  - `python3-pyqt5.qtsql`
  - `python3-pyqt5.qtsvg`
  - `python3-pyqt5.qtwebkit`
  - `python3-requests`
  - `python3-sip`
  - `python3-six`
  - `python3-tz`
  - `python3-yaml`

  So assuming that `python3Packages.pytz` corresponds to `python3-tz` and `python3Packages.pyyaml` to `python3-yaml`, the ones **missing in NixOS QGIS are**:

  - `future`
  - `httplib2`
  - `markupsafe`
  - `plotly`
  - `pyproj`

  I dunno yet whether what corresponds to
  - `python3-pyqt5.qsci`
  - `python3-pyqt5.qtsql`
  - `python3-pyqt5.qtsvg`
  - `python3-pyqt5.qtwebkit`

  is already included in `python3Packages.pyqt5`.

  ### Steps to reproduce

  #### To see that some of these are indeed missing:

  1. launch QGIS
  2. in QGIS, click menu "Plugins" > "Python Console"
  3. on the Python REPL that appears, enter
     ```python
     import future
     ```

  ##### Expected

  module is successfully imported (no output)

  ##### Observed

  ```
  Traceback (most recent call last):
    File "/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python3-3.7.3/lib/python3.7/code.py", line 90, in runcode
      exec(code, self.locals)
    File "<input>", line 1, in <module>
    File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 672, in _import
      mod = _builtin_import(name, globals, locals, fromlist, level)
  ModuleNotFoundError: No module named 'future'
  ```

  #### To see that some of these are indeed needed by some Plugins:

  1. launch QGIS
  2. in QGIS, click menu "Plugins" > "Manage and Install Plugins..."
  3. In the plugin list, select "OSMDownloader" (you may use the search bar to find it)
  4. click the "Install plugin" button

  ##### Expected

  Plugin is successfully installed

  ##### Observed

  Lengthy error message:

  <details><summary>"ModuleNotFoundError: No module named 'future'" (click to expand)</summary><blockquote>
  <p>

  </p>
  <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-weight:600; color:#ff0000;">Couldn't load plugin 'OSMDownloader' due to an error when calling its classFactory() method</span> <br></p>
  <h3 style=" margin-top:14px; margin-bottom:12px; margin-left:0px;
    margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style="
      font-size:large; font-weight:600;">ModuleNotFoundError: No module
      named 'future' </span></h3>
  <pre style=" margin-top:12px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-family:'monospace';">Traceback (most recent call last):<br>  File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 335, in startPlugin<br>    plugins[packageName] = package.classFactory(iface)<br>  File "/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python/plugins/OSMDownloader/__init__.py", line 34, in classFactory<br>    from .osmDownloader import OSMDownloader<br>  File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 672, in _import<br>    mod = _builtin_import(name, globals, locals, fromlist, level)<br>  File "/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python/plugins/OSMDownloader/osmDownloader.py", line 31, in <br>    from .osmDownloader_dialog import OSMDownloaderDialog<br>  File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 672, in _import<br>    mod = _builtin_import(name, globals, locals, fromlist, level)<br>  File "/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python/plugins/OSMDownloader/osmDownloader_dialog.py", line 36, in <br>    from .osm_downloader import OSMRequest<br>  File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 672, in _import<br>    mod = _builtin_import(name, globals, locals, fromlist, level)<br>  File "/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python/plugins/OSMDownloader/osm_downloader.py", line 25, in <br>    from future import standard_library<br>  File "/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/qgis/utils.py", line 672, in _import<br>    mod = _builtin_import(name, globals, locals, fromlist, level)<br>ModuleNotFoundError: No module named 'future'<br></span></pre>
  <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><br><span style=" font-weight:600;">Python version:</span> 3.7.3 (default, Mar 25 2019, 20:59:09) [GCC 7.4.0] <br><span style=" font-weight:600;">QGIS version:</span> 3.4.5-Madeira Madeira, exported <br></p>
  <h4 style=" margin-top:12px; margin-bottom:12px; margin-left:0px;
    margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style="
      font-size:medium; font-weight:600;">Python Path:</span></h4>
  <ul style="margin-top: 0px; margin-bottom: 0px; margin-left: 0px;
    margin-right: 0px; -qt-list-indent: 1;">
    <li style=" margin-top:12px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python/plugins</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/xry2nyp8jmrdfrrp0ygq89fyw5vwpzm7-qgis-unwrapped-3.4.5/share/qgis/python/plugins</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/8jkwfdn6hyw7sv464n1a6y5ddzjvzl15-python3.7-qscintilla-2.9.4/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/bn8xa5ww2p9pghjdgcix3w0alwlm00wh-python3.7-setuptools-40.8.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/agcwvy4pwb7m8w95x2jws18gy1jcgqlb-python3.7-PyQt-5.11.3/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/7ycqvb5q94l2474ll25cs2yx621qvhrx-gdal-2.4.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/ii1vfd7mkfvffvyhhkfxkp869lvkk58i-python3.7-Jinja2-2.10/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/fcjvf99dlfajbwzca2mysr3dxl2r8m9v-python3.7-MarkupSafe-1.1.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/i7vrd6sa32jji4brc5rbck2g2r765gdp-python3.7-numpy-1.16.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/xb52h37svdj68v72h0dnsszay538jy68-python3.7-psycopg2-2.7.7/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/50p861jrj4a15717kpnlgx2vi1s1jflf-python3.7-chardet-3.0.4/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/n5svn70dgs31qwc5jmfqs433kd864c4y-python3.7-python-dateutil-2.8.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/1kx85bwdyq7x7n9lzkli02hg1m0aj8d8-python3.7-six-1.12.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/j5awgm0fd0k74iindg9x6p63r8gcdyxx-python3.7-setuptools_scm-3.2.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/nn4vig3gcm1bn0900c7hyxjiv3ynj8kx-python3.7-PyYAML-3.13/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/a157w8x2jid5ybs5n65yhcd14qj70i9k-python3.7-pytz-2018.9/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/fqjiffd9g1xj33ajg75g54sh12fj6gm3-python3.7-requests-2.21.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/v81hggmfs9p22fv7qg9cw00m67c0r952-python3.7-urllib3-1.24.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/waqblxjkq9972igfzz7vyqyfri0pia89-python3.7-asn1crypto-0.24.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/hh2f7n57d6w37346ccv6ycnxh4fdsrmn-python3.7-packaging-19.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/s76v16hl3g0psk4ppblic3bq69xbg6i4-python3.7-pyparsing-2.3.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/iszz2a2jyzhanrjgxq41nxa60fj3nxl8-python3.7-pycparser-2.19/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/cwl7xyfnyn4bbnq3r0739vaw7spvv7bz-python3.7-cffi-1.12.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/zpfdn3090jvwx7hkjbq6lli3dmy3qln4-python3.7-cryptography-2.5/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/8ydh5516n1cmi99vlmag6w45vy4gk90x-python3.7-pyasn1-0.4.5/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/k69sv9c7gsba0k93v3277rmj9403gs2x-python3.7-idna-2.8/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/rpagf4q3x2an2qs3c8d7spg2kgiw5n9n-python3.7-pyOpenSSL-19.0.0/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/p63cylj7lin1g7lqxpx0yhqnh1wqpwlw-python3.7-certifi-2018.11.29/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/2vvrlp3hkz96mq49vrzmiirki5amg876-python3.7-pysocks-1.6.8/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/zw6mks59avymjjcpq4zr0sxn43z5sy23-python3.7-Pygments-2.3.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/7dnji817pa9015q01y6760898gijh2si-python3.7-docutils-0.14/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/szymii8h3m329m2cf1fr57n11490s781-python3.7-sip-4.19.13/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/hw8kqlhq7s01jpyfra61kw2vh82l6al8-python3.7-OWSLib-0.17.1/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/w51pqp1g0s20hrc65rln0flzp997g89v-python3.7-pyproj-unstable-2018-11-13/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/bn8xa5ww2p9pghjdgcix3w0alwlm00wh-python3.7-setuptools-40.8.0/lib/python3.7/site-packages/setuptools-40.8.0-py3.7.egg</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python3-3.7.3/lib/python37.zip</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python3-3.7.3/lib/python3.7</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python3-3.7.3/lib/python3.7/lib-dynload</li>
    <li style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/nix/store/0n8slcq8p5x31kc9hncabsqq9y3fpkzp-python3-3.7.3/lib/python3.7/site-packages</li>
    <li style=" margin-top:0px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">/home/das-g/.local/share/QGIS/QGIS3/profiles/default/python</li>
  </ul>
  </blockquote>
  </details>
  <details><summary>screenshot (click to expand)</summary>

  ![Bildschirmfoto von 2019-04-18 18-05-34](https://user-images.githubusercontent.com/97746/56375004-b48c5e00-6204-11e9-8471-b390b34387e6.png)

  </details>

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172205.ea497998e4b (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.03.172231.7b36963e7a7"`
   - channels(das-g): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: lib/optionalString: ensure it returns string
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59843
updated_at: 2019-06-27 21:03:33
body:
  ###### Motivation for this change

  Enforce type safety a little bit.
  Many evaluation errors expected


state: open
title: folly: support macOS
user_login: strager
html_url: https://github.com/NixOS/nixpkgs/pull/59846
updated_at: 2019-06-11 01:29:49
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Enable building the folly library on macOS (Darwin).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: siji font is installed but not available
user_login: suhr
html_url: https://github.com/NixOS/nixpkgs/issues/59847
updated_at: 2019-04-20 17:13:37
body:
  ## Issue description

  `fc-list siji` finds nothing.

  ```nix
  {
    fonts.fonts = with pkgs; [
      # ...
      siji
    ];
  }
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.09pre175916.1fc591f9a5b (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre175916.1fc591f9a5b, home-manager"`
   - channels(suhr): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: libuv: disable "get_passwd" test
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59849
updated_at: 2019-05-04 16:12:53
body:
  ###### Motivation for this change

  The test fails on non-NixOS Linuxes preventing to use them as remote builders

  Fixes https://github.com/NixOS/nixpkgs/issues/57104

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vulkan-loader: 1.1.101.6 -> 1.1.106
user_login: avnik
html_url: https://github.com/NixOS/nixpkgs/pull/59850
updated_at: 2019-04-18 21:26:25
body:
  ###### Motivation for this change

  Unbreak mismatched vulkan-headers/loader.


  ###### Things done


  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Steam runtime does not build
user_login: dkudriavtsev
html_url: https://github.com/NixOS/nixpkgs/issues/59851
updated_at: 2019-04-25 21:25:12
body:
  ## Issue description

  The Steam runtime has been updated, so the old packages are unable to be fetched and return 404 errors.

  ### Steps to reproduce

  Attempt to install Steam while on the unstable channel.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 5.0.7, NixOS, 19.09pre175916.1fc591f9a5b (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre175916.1fc591f9a5b"`
   - channels(dmitry): `"nixos-19.09pre173080.1222e289b50"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: Memcached: update packages
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59852
updated_at: 2019-04-19 15:52:01
body:
  Update packages:
  - memcached to 1.5.13
  - php-memcached to 3.1.3

  cc @etu 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages.xdebug: 2.6.1 -> 2.7.1
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59853
updated_at: 2019-04-19 15:53:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update php-package xdebug to 2.7.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildMix: fix bootstrapping packages with hyphens in version
user_login: goodsoft
html_url: https://github.com/NixOS/nixpkgs/pull/59854
updated_at: 2019-04-20 11:14:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I'm using `buildMix` to build a package, which has a dependency with a hyphen in its version: `dialyxir-1.0.0-rc6`.
  Due to `mix-bootstrap` using `string:tokens` the dependency ends up in `_build/prod/lib/dyalyxir1.0.0rc6` instead of `_build/prod/lib/dialyxir`.

  Here I'm fixing it to use `string:split`, which splits by first hyphen only, and returns an array with no more than two elements.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: runInLinuxVM, test-driver: pass host's cpu type to guest vm
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59855
updated_at: 2019-04-28 14:08:50
body:
  Otherwise the guest cpu is the most generic one, which does not support SSE4.2, AVX and other ISA extentions.

  There is already some packages which use extended opcodes. They cannot be run in VM.

  With the acceptance of https://github.com/NixOS/nixpkgs/pull/59225 and https://github.com/NixOS/nixpkgs/pull/59148 even ```glibc``` would have AVX instructions in ```memcpy()``` code (if ```platform.gcc.arch``` is at least ```sandybridge```) so almost all the packages from host's nix store shared with the VM via 9p won't run in the VM if the the VM does not have the same CPU as the host.


state: closed
title: nixos/nvidia: Add NVIDIA optimus option to allow external GPUs
user_login: c00w
html_url: https://github.com/NixOS/nixpkgs/pull/59856
updated_at: 2019-05-03 14:34:15
body:
  Without this option - NVIDIA refuses to use an external GPU.

  ###### Motivation for this change
  I have a computer with an external NVIDIA GPU connected. I want to run some monitors off the external GPU and some off the internal intel GPU - After a lot of debugging, this was the required change.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: moviepy is broken in 19.03
user_login: seanparsons
html_url: https://github.com/NixOS/nixpkgs/issues/59857
updated_at: 2019-04-20 09:03:05
body:
  ## Issue description
  `python3Packages.moviepy` is broken in current 19.03 nixpkgs: https://hydra.nixos.org/build/91932416

  ### Steps to reproduce
  Attempt to build `python3Packages.moviepy`, this also fails if I pull in the `python3Packages.requests` with something like `nix-shell`

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172231.7b36963e7a7 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172231.7b36963e7a7"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Fetcher improvements
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/59858
updated_at: 2019-04-19 13:28:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  More clarity in store path names, more abstraction

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: siji: Also package bdf font
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/59859
updated_at: 2019-04-20 20:34:19
body:
  ###### Motivation for this change

  The pcf version seems to be incompatible with newer FreeType versions
  and hence doesn't show up in `fc-list`. A bdf file format is also
  available. After packaging that the font shows up in `fc-list`.

  See: https://github.com/stark/siji/issues/28

  Fixes #59847 

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.pyramid_chameleon: fix build by patching tests
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59860
updated_at: 2019-04-19 10:15:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Seems to have been broken for a while.

  Test suite was failing on a seemingly nonsensical test. Looking into this part of the test suite it appears it started as a modified copy of part of the main pyramid test suite. Presumably this line simply never got converted - change it to match the similar imports.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: perlPackages.libapreq2: install the perl & apache modules
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59861
updated_at: 2019-04-20 00:40:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/NixOS/nixpkgs/issues/59773#issuecomment-484732464
  > libapreq2 is made up of a c library, a perl module, and an apache module. In nixpkgs libapreq2 does not include the perl or apache modules.

  This change adds a perl module and an apache module, while leaving the existing c library completely untouched so is fine to backport to 19.03 as well.

  ###### Things done
  I have tested the perl and apache modules included in this new `libapreq2` build with some existing code which has been running on Debian servers for years now.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix pythonPackages.moviepy
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/59862
updated_at: 2019-04-20 08:57:10
body:
  ###### Motivation for this change
  The package was updated in #55757 but the list of dependencies was not.
  Now it build again and I can import it in python3.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Removes zfs from only the "new_kernel" installer variants
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/59863
updated_at: 2019-04-19 21:36:33
body:
  Fixes #58959.

  This was tested using [this patch to neuter the zfs kernel module](https://gist.github.com/6df53f5e07776199e8e5a2daf4c83b83).

  ```
  nix-build nixos/release-combined.nix -A nixos.iso_minimal_new_kernel.x86_64-linux
  ```

  and on aarch64

  ```
  nix-build nixos/release-combined.nix -A nixos.iso_minimal_new_kernel.aarch64-linux
  ```

  * * *

  I wasn't able to think of an elegant way to reduce the duplication of the list of supported filesystems. Referencing to a configured value within the module system is an infinite recursion.  The only way I thought of is a bit ugly, is through having the list in a `.nix` file which would be imported (and filtered as needed). This would have made one bizarro file which would live within the other module files, but couldn't be added to `imports`.

  Any inputs on ways to remove the mostly duplicated list?


state: open
title: llvm for windows cross compiler
user_login: tmcl
html_url: https://github.com/NixOS/nixpkgs/pull/59865
updated_at: 2019-05-12 03:17:28
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Nixpkgs is almost capable of building GHC as an x86-64 Windows cross compiler. It just needs to useLLVM. The resulting binaries are capable of running on Windows 10 and making basic ffi calls. Note that it still fails if targeting 32-bit i686 on a 64 bit machine. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Win32 is marked as broken so you probably can't run cabal2nix to make things build. It is built as part of ghc so not a big deal.


state: open
title: VirtualBoxOVA does not work for more than 64gb baseImageSize
user_login: dfordivam
html_url: https://github.com/NixOS/nixpkgs/issues/59867
updated_at: 2019-06-02 17:58:03
body:
  ## Issue description
  The standard way to create a nixos virtual box .ova files (`config.system.build.virtualBoxOVA`) does not work if the `baseImageSize` is more than 64gb.


  ### Steps to reproduce
  Specify baseImageSize more than 64gb 

      virtualbox = {
          baseImageSize = 65 * 1024; # in MiB
      }


  ## Technical details
  The VM creation hangs with this output

      [ 3.565686] This architecture does not have kernel memory protection. 
      [ 3.595800] EXT4-fs (vda1): mounted filesystem with ordered data mode. Opts: 
      [ 6.028488] random: crng init done

  This is the `strace` from `cptofs` which does 100% cpu usage and does not finish.

      timer_settime(0, 0, {it_interval={tv_sec=0, tv_nsec=0}, it_value={tv_sec=0, tv_nsec=9839123}}, NULL) = 0
      timer_settime(0, 0, {it_interval={tv_sec=0, tv_nsec=0}, it_value={tv_sec=0, tv_nsec=9764387}}, NULL) = 0

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 4.14.104, NixOS, 19.09pre171786.34aa254f9eb (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre171786.34aa254f9eb"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nixops: remove pinned azure-mgmt-* libraries
user_login: bendlas
html_url: https://github.com/NixOS/nixpkgs/issues/59868
updated_at: 2019-04-19 11:48:10
body:
  ## Issue description

  After [azure support has been disabled](https://github.com/NixOS/nixops/issues/1065#issuecomment-484716162) in nixops, we can remove the locally pinned version in nixpkgs.


state: closed
title: how to input and display unicode character on tty?
user_login: clojurians-org
html_url: https://github.com/NixOS/nixpkgs/issues/59869
updated_at: 2019-05-01 05:14:39
body:
  i can type and display unicode character on jconsole.
  but when i switch to tty(control+alt+f1), then the unicode display became <> messy character, i can't input unicode either.
  i can't find related staff in manual. 
  ```
  [larluo@nixos-larluo:~/my-hr/hbenchmark]$ cat /etc/nixos/configuration.nix
  { config, pkgs, ... } :

  {
    imports =
      [ # Include the results of the hardware scan.
        ./hardware-configuration.nix
      ];

    nixpkgs.config.allowUnsupportedSystem = true; 
    nixpkgs.config.allowBroken = true; 
    nixpkgs.config.allowUnfree = true;

    # Use the systemd-boot EFI boot loader.
    boot.loader.systemd-boot.enable = true;
    boot.loader.efi.canTouchEfiVariables = true;

    networking.hostName = "nixos-larluo"; # Define your hostname.
    networking.wireless.enable = true;  # Enables wireless support via wpa_supplicant.

    virtualisation.docker.enable = true ;
    virtualisation.virtualbox.host.enable = true;

    # Select internationalisation properties.
    i18n = {
      consoleKeyMap = "us";
      defaultLocale = "en_US.UTF-8";
      supportedLocales = [ "en_US.UTF-8/UTF-8"
                           "zh_CN.UTF-8/UTF-8"
                           "zh_CN/GB2312"
                           "zh_CN.GBK/GBK"
                           "zh_CN.GB18030/GB18030"
                           "zh_TW.UTF-8/UTF-8"
                           "zh_TW/BIG5" ];
    };
    i18n.inputMethod = {
      enabled = "fcitx" ;
      fcitx.engines = with pkgs.fcitx-engines; [ rime ] ;
    };

    # Set your time zone.
    time.timeZone = "Asia/Shanghai" ;

    # List packages installed in system profile. To search, run:
    # $ nix search wget
    environment.systemPackages = with pkgs; [
      wget vim
    ];


    # List services that you want to enable:

    # Enable the OpenSSH daemon.
    services.openssh.enable = true;

    # Enable sound.
    sound.enable = true;
    hardware.pulseaudio.enable = true;

    # Enable the X11 windowing system.
    services.xserver.enable = true;
    services.xserver.layout = "us";
    services.xserver.xkbOptions = "eurosign:e";

    # Enable touchpad support.
    services.xserver.libinput.enable = true;

    # Enable the KDE Desktop Environment.
    services.xserver.displayManager.sddm.enable = true;
    services.xserver.desktopManager.plasma5.enable = true;

    services.privoxy.enable = true ;
    services.privoxy.listenAddress = "0.0.0.0:8118" ;
    services.privoxy.extraConfig = ''
      forward-socks5 / 0.0.0.0:1080 .
    '' ;

    users.extraUsers.larluo = {
      isNormalUser = true ;
      home = "/home/larluo" ;
      hashedPassword = "$6$hmE0Eyz0J235ca$mS7HW6HJfWSzlCX3BBszOZGD8wcHSYP8kVHIFZD5KHtzOA9F0aqnmtFPIjIQObw5jIvtIeLyyClnwXF4PPNhJ1" ;
      extraGroups = ["wheel" "networkmanager" "docker" ] ;
    };

    fonts = {
      fontconfig.enable = true;
      enableFontDir = true;
      enableGhostscriptFonts = true;
      fonts = with pkgs; [
        noto-fonts
        noto-fonts-cjk
        noto-fonts-emoji
        wqy_microhei
        wqy_zenhei
      ];
    };


    # This value determines the NixOS release with which your system is to be
    # compatible, in order to avoid breaking some software such as database
    # servers. You should change this only after NixOS release notes say you
    # should.
    system.stateVersion = "18.09"; # Did you read the comment?

    nix.binaryCaches = [ "https://cache.nixos.org/" "https://nixcache.reflex-frp.org" ];
    nix.binaryCachePublicKeys = [ "ryantrinkle.com-1:JJiAKaRv9mWgpVAz8dwewnZe0AzzEAzPkagE9SP5NWI=" ];
  }
  ```


state: closed
title: insomnia: Fix .desktop to link to Nix bin
user_login: phildenhoff
html_url: https://github.com/NixOS/nixpkgs/pull/59870
updated_at: 2019-04-24 13:06:58
body:
  ###### Motivation for this change
  By default, the Insomnia package adds a .desktop icon with an `Exec` path of "/opt/insomnia/insomnia", but that's (generally!) not where Nix installs Insomnia.

  ###### Things done
  I added a `sed` into the "installPhase" to replace the "/opt" path with the "$out" path.

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: calibre: 3.40.1 -> 3.41.3
user_login: pSub
html_url: https://github.com/NixOS/nixpkgs/pull/59871
updated_at: 2019-04-21 16:34:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New features

      Kobo driver: Support for new firmware
      Content server: Add an option to control which book list mode is used by default for new users (Preferences->Sharing over the net->Choose book list mode)
      Content server: Allow clicking on book cover in details page to read the book.

      Closes tickets: 1819058
      Amazon metadata plugin: Add a option to use the mobi-asin to find books.

      Closes tickets: 1823520
      E-book viewer: Allow specifying ToC hrefs via the --open-at command line parameter.

      Closes tickets: 1656573
      Tag Mapper: Allow Title-casing of tags.

      Closes tickets: 1823097
      Manage authors dialog: Add an entry to the right click menu to show books by the current author in the main book list.

      Closes tickets: 1821992
      Lots of internal changes to calibre's codebase to prepare it for python 3 support.

  Bug fixes

      Content server: Fix links to external resources in book details and the viewer not working
      Content server: Fix using a bookmark to load the book list not working if server is password protected.

      Closes tickets: 1819025
      Content server: Book details page: Fix close button not going back to book list after using Next/previous buttons.

      Closes tickets: 1819060
      Kobo driver: Fix update device metadata setting not being saved. Also fix book language not being set correctly on newer firmware.
      PDF Output: Fix 'stroke-dasharray' lines in SVG images in the input document not being rendered correctly.

      Closes tickets: 1821923
      Fix searching for authors on amazon not working because of a change in the amazon URL structure.

      Closes tickets: 1822532
      Cover grid: Check for cover size change due to screen scale change on every paint event and invalidate cache if there is a change.

      Closes tickets: 1723972
      Edit book: Fix Option key + ; not working in the editor.

      Closes tickets: 1823040
      Edit book: Fix pasting images into a book with no Images folder not working correctly.

      Closes tickets: 1817405
      Confirm cancel on library restore dialog

      Closes tickets: 1823204
      EPUB/MOBI Catalogs: Fix presets not being applied for some options.

      Closes tickets: 1821968
      Fix using --insert-metadata with ebook-convert not inserting the title and author metadata from the source document
      Adding books: When adding with auto-merge and auto-convert enabled, also run conversions for books into which the added files are merged.

      Closes tickets: 1822018

  New news sources

      The New Criterion by Darko Miletic

  Improved news sources

      Il Post
      Le Monde Edition Abonnes Papier
      Le Temps
      NASA
      1843
      derStandard
      LA Times



  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Datadog: update packages
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59872
updated_at: 2019-04-27 10:28:29
body:
  Update datadog packages:
  - datadog agent to 6.11.0;
  - datadog process agent to 6.11.0;

  cc @kalbasit 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Add @dingxiangfei2009 to maintainers
user_login: edude03
html_url: https://github.com/NixOS/nixpkgs/pull/59873
updated_at: 2019-04-23 10:36:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Move forward the Concourse PR by committing it in smaller chunks. https://github.com/NixOS/nixpkgs/pull/53691

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins: update
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59874
updated_at: 2019-04-19 08:43:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Regular update.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: matrix-synpase: Fix default identity server
user_login: MazeChaZer
html_url: https://github.com/NixOS/nixpkgs/pull/59875
updated_at: 2019-04-19 14:29:59
body:
  The identity server hosted by the matrix.org-team is available under vector.im.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.re: seq is not needed when OCaml >= 4.07
user_login: Zimmi48
html_url: https://github.com/NixOS/nixpkgs/pull/59876
updated_at: 2019-05-04 11:55:12
body:
  ###### Motivation for this change

  Imitate opam which installs the real seq package only for OCaml < 4.07 and only a META file for OCaml >= 4.07.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  I am not sure how to test the depending packages from the `ocaml-ng.ocamlPackages_4_07` package set. The ones from the default set (4.06) are unchanged and thus not rebuilt by `nix-review`.
  I have tested a few depending packages though, including odoc.


state: closed
title: Gnome 3.32: cycle-windows / cycle-windows-backwards stopped working
user_login: sboehler
html_url: https://github.com/NixOS/nixpkgs/issues/59877
updated_at: 2019-04-19 20:35:41
body:
  ## Issue description

  I have just upgraded to Gnome 3.32 (NixOS Unstable) and seem to be unable to switch windows using the 'org/gnome/desktop/wm/keybindings/cycle-windows' and 'org/gnome/desktop/wm/keybindings/cycle-windows-backwards' actions. The default shortcut is Alt-Escape, but customizing this shortcut does not work either. Resetting my dconf state did not help.

  Other similar actions (cycle-group etc) do work as expected. 

  Not sure whether this is an upstream issue, however both actions work as expected in Ubuntu 19.04 with Gnome 3.32, and I didn't find a relevant issue or commit upstream.

  ### Steps to reproduce

  - Install Gnome 3.32
  - Hit Alt-Escape
  - Observe windows do not switch

  ## Technical details

  - system: `"x86_64-linux"`
   - host os: `Linux 5.0.7, NixOS, 19.09.git.1fc591f (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `""`
   - nixpkgs: `/nix/nixpkgs`


state: closed
title: fix evaluation with `config.allowAliases = false`
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/pull/59879
updated_at: 2019-04-19 13:14:04
body:
  More like https://github.com/NixOS/nixpkgs/pull/57110 https://github.com/NixOS/nixpkgs/pull/57112

  @jtojnar 


state: closed
title: nixos/matrix-synapse: correct trusted_third_party_id_servers default
user_login: florianjacob
html_url: https://github.com/NixOS/nixpkgs/pull/59880
updated_at: 2019-04-22 15:58:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  the servers are equivalent and synchronized, but Riot defaults to use vector.im which leads to a nondescribing 401 error message when registering third party identifiers.
  This adjusts the NixOS default to the upstream default:
  https://github.com/matrix-org/synapse/blob/v0.99.3/docs/sample_config.yaml#L701

  I think we should backport this to 19.03 for out of the box compatibility between a NixOS synapse installation and Riot, and as both servers are run by the same operators and contain the same data, I would consider this backward-compatible.

  Maintainers: @ralith @roblabla @ekleog  @pacien

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cannot install OVMF with SeaBIOS CSM
user_login: shatsky
html_url: https://github.com/NixOS/nixpkgs/issues/59881
updated_at: 2019-04-20 13:20:08
body:
  ## Issue description
  I've enabled libvirtd, got OVMF firmware in `/run/libvirt/nix-ovmf/OVMF_CODE.fd`, symlinked to `/nix/store/5bgi298wvmbgkz95s61ifwaihz68b0wb-OVMF-2017-12-05-fd/FV/OVMF_CODE.fd`. However, VM using it can't boot from MBR-partitioned disk with MBR bootloader or floppy image, it just drops to EFI shell. I guess OVMF is built without SeaBIOS CSM which is required to boot from pre-EFI media. I see there is OVMF-CSM defined in nixpkgs; installing `nixpkgs.OVMF-CSM`, as well as `nixpkgs.OVMF` with or without `--arg seabios true`, only installs same "out" output of the same expression which produces that "fd" output which contains actual image used by qemu.

  I see that both OVMF-CSM is defined in https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L14235 which looks suspicious to me, does it really revert `seabios = null` which is set in preceding one? How can I check which arguments the expression which produced store path had been given? And how can I install CSM-enabled OVMF? Anyway, `nix-env -iA nixos.OVMF` and `nix-env -iA nixos.OVMF-CSM` producing same result looks like a bug.

  ### Steps to reproduce

  Add following to your configuration.nix:

  ` virtualisation.libvirtd.enable = true;`
  `  environment.systemPackages = with pkgs; [
      OVMF-CSM
    ];
  `

  or run `nix-env -iA nixos.OVMF-CSM`. Try to locate CSM-enabled OVMF image.

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.34, NixOS, 19.03.172231.7b36963e7a7 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(eugene): `"nixos-unstable-19.09pre175916.1fc591f9a5b"`
   - channels(root): `"nixos-19.03.172231.7b36963e7a7"`
   - channels(doctor): `"nixpkgs-19.03pre153206.f753852e11d"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: Key-Value pairs in the Yabar configuration
user_login: BKer
html_url: https://github.com/NixOS/nixpkgs/issues/59883
updated_at: 2019-05-07 08:45:26
body:
  ## Issue description

  The  `nixpkgs/nixos/modules/programs/yabar.nix` file allows for adding extra parameters using the .extra parameter. The extra parameters are a key-value pair. This is perfect, however it turns the values into strings and for example the background-color-rgb does not take a String value type. There are several more non String options, see: https://github.com/geommer/yabar/wiki/Bar-specific-options

  ### Steps to reproduce

  Edit `configuration.nix` and add:
  ```
  programs.yabar.enable = true;
  programs.yabar.bars.topbar.extra: { background-color-rgb = "0x0000ff";};
  ```
  Of course also run a rebuild
  Effect, the bar does not change to the desired color.

  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.33-hardened, NixOS, 19.09pre174415.d956f2279b8 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"nixos-19.09pre174415.d956f2279b8"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


  PS. This is all to the best of my current knowledge, as I'm pretty new to NixOS.


state: closed
title: pythonPackages.serversyncstorage: disable if cornice.version != 0.17
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/59884
updated_at: 2019-04-26 06:43:00
body:
  ###### Motivation for this change

  This package doesn't build if accessed directly from the top level without a specially overridden cornice package supplied - as done by `syncserver`. See https://github.com/NixOS/nixpkgs/pull/54739#issuecomment-484850316


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: concatImapStrings(Sep) should be renamed to concatImap1Strings(Sep)
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/59886
updated_at: 2019-04-19 11:56:23
body:
  I think Imap implies zero based indexing.
  A few scripts need to be updated but not many.

  Maybe there can also be a new concatImapStrings(Sep) that is zero-based.


state: closed
title: Add vim-emodeline plugin (Emacs style filetype detection)
user_login: tfc
html_url: https://github.com/NixOS/nixpkgs/pull/59887
updated_at: 2019-04-20 20:00:03
body:
  ###### Motivation for this change

  Having vim emodeline automatic emacs-style filetype detection available as a vim plugin via `<nixpkgs>` would be awesome.

  plugin URL: https://www.vim.org/scripts/script.php?script_id=467

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: git-ignore: 0.2.0 -> 1.0.0
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/pull/59889
updated_at: 2019-04-20 15:56:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update my own package to the latest release.

  ###### Things done
  Tested by installing on my NixOS and macOS machine with `nix-env -f . -i git-ignore` in the `nixpkgs` directory.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Barco clickshare
user_login: Yarny0
html_url: https://github.com/NixOS/nixpkgs/pull/59891
updated_at: 2019-06-11 16:54:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Let NixOS users share their desktops with Barco's ClickShare dongles during presentations etc. See the package's description and Barco's homepage for more information on the technology.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS: x86_64-linux, x86_32-linux
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) ( *does not apply* )
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` ( *does not apply* )
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after): *the package requires 5.9 MiB*
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ocamlPackages.tyxml: 4.2.0 -> 4.3.0 and related updates
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/59892
updated_at: 2019-04-28 15:43:12
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-outdated: init at unstable-2019-04-13
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/pull/59893
updated_at: 2019-04-24 10:55:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This is a pretty useful package for seeing what you can/should update with Cargo that currently can't be straight up installed unless you have `openssl` and `pkgconfig` available (and working, doesn't work on my machine).

  **NOTE:** I have to install this from the latest commit on master right now as there is an issue with `Cargo.lock` not being correct, see [this PR](https://github.com/kbknapp/cargo-outdated/pull/159).

  ###### Things done
  ~~However, this package depends on #57017 as the generated `Cargo.lock` cannot be parsed by the old version of `cargo-vendor` in our repo. I'll update this once/if that is merged.~~ It's been merged and it builds fine.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: HylaFAX: fix ModemGroup, also minor metadata updates (backport to release-19.03)
user_login: Yarny0
html_url: https://github.com/NixOS/nixpkgs/pull/59894
updated_at: 2019-04-24 16:18:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This is a backport of https://github.com/NixOS/nixpkgs/pull/59081 .

  HylaFAX+ handles the ModemGroup parameter differently from the way the relevant manpage claims it is handled. This can lead to stuck jobs.
  I'm using this opportunity to update/improve further minor aspects of the HylaFAX package and module.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS ( *note: no change to the package itself, only hylafax configuration in nixos module and package metadata* )
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: hugo: 0.55.0 -> 0.55.2
user_login: sondr3
html_url: https://github.com/NixOS/nixpkgs/pull/59895
updated_at: 2019-04-20 10:43:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Updated package to account for a bunch of bug fixes.

  ###### Things done
  Ran and verified that it built and served `hugoDocs` properly.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: rxvt_unicode: allow to specify dependencies for plugins
user_login: rnhmjoj
html_url: https://github.com/NixOS/nixpkgs/pull/59896
updated_at: 2019-04-20 10:02:07
body:
  ###### Motivation for this change
  I needed to add some perl modules for a urxvt script.

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change
  - [x] Tested execu (usually in `./result/bin/`)tion of all binary files
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Miscellaneous cross compilation fixes
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/59897
updated_at: 2019-04-20 20:52:27
body:
  This is a collection of fixes to the cross compilation infrastructures that I have collected. Mostly just stuff that I don't want to forget to merge. Summary:

  - fix isCompatible identity
  - add handling for musl when building aws-sdk-cpp
  - fix the ARM isCompatible definitions
  - use isCompatible as a backup for finding bootstrap tools
  - fix spidermonkey compilation
  - expose crossOverlays to Nix command line args

  I can split these up into separate PRs if requested.

  /cc @illegalprime 

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: modd: init at 0.8
user_login: kierdavis
html_url: https://github.com/NixOS/nixpkgs/pull/59898
updated_at: 2019-04-22 21:32:32
body:
  ###### Motivation for this change

  Neat tool that watches files in a project directory and re-runs linters/tests or restarts daemons when a file is modified. More info at [project homepage](https://github.com/cortesi/modd).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: steamrt: fix update script
user_login: nyanloutre
html_url: https://github.com/NixOS/nixpkgs/pull/59899
updated_at: 2019-04-22 09:13:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The package.txt file doesn't exist anymore on upstream.
  The new method is to install two metapackages and their dependencies.

  Reference : https://github.com/ValveSoftware/steam-runtime/commit/8849d366bf9673ab5350d4036171c834acfb8955

  Also I reuse the hash given in the package list so it doesn't have to download everything, resulting in way faster speed.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [request] sclack (CLI slack client)
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/issues/59900
updated_at: 2019-05-05 16:45:28
body:
  https://github.com/haskellcamargo/sclack

  Still under development, but already looks usable and possibly better than other solutions!


state: open
title: cura: weird non-deterministic corruption of larger meshes
user_login: gebner
html_url: https://github.com/NixOS/nixpkgs/issues/59901
updated_at: 2019-04-23 13:59:42
body:
  ## Issue description

  When loading larger STL files, cura sometimes corrupts them in seemingly random ways (every time different, very rarely the import works successfully):

  ![mutilated_benchy1](https://user-images.githubusercontent.com/313929/56435629-72811c00-62d9-11e9-9b5d-4d365083d2ca.png)
  ![mutilated_benchy2](https://user-images.githubusercontent.com/313929/56435631-74e37600-62d9-11e9-8f00-e7cfe7afc7be.png)

  This is not just an OpenGL rendering problem, it also affects the sliced output:

  ![sliced_benchy1](https://user-images.githubusercontent.com/313929/56435649-8593ec00-62d9-11e9-9a4f-5762e11d8e90.png)

  For comparison, this is how it should look like:

  <img width="614" alt="expected_benchy" src="https://user-images.githubusercontent.com/313929/56435660-93497180-62d9-11e9-8036-aaf0c207c28b.PNG">

   - I cannot reproduce this issue on either ubuntu (with the PPA version of cura) or windows.
   - At first I thought this might be a problem with our OpenBLAS version (e.g. like #50407).  However there are no problems on ubuntu, which uses the same numpy and openblas versions.
   - The larger the STL file, the more likely the problems.  For example I could not succesfully import a larger STL file with 3 million faces at all.  (The same file shows no issues in either ubuntu or windows.)
   - The issue also occurs with 3MF files instead of STL.
   - I can also reproduce the issue with cura 3.6 on the stable channel.

  This is the relevant part of the cura log output:
  ```
  2019-04-19 20:31:01,074 - INFO - [Thread-3] STLReader.STLReader.load_file [46]: Using NumPy-STL to load STL data.
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:436: RuntimeWarning: invalid value encountered in true_divide
    n[:, 0] /= l
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:437: RuntimeWarning: invalid value encountered in true_divide
    n[:, 1] /= l
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:438: RuntimeWarning: invalid value encountered in true_divide
    n[:, 2] /= l
  2019-04-19 20:31:01,505 - DEBUG - [Thread-3] UM.Mesh.MeshData.calculateNormalsFromVertices [444]: Calculating normals took 0.03203701972961426 seconds
  2019-04-19 20:31:01,519 - DEBUG - [Thread-3] STLReader.STLReader._read [97]: Loaded a mesh with 677118 vertices
  2019-04-19 20:31:02,156 - DEBUG - [Thread-3] UM.Mesh.MeshData.approximateConvexHull [401]: approximateConvexHull(target_count=1024) Calculating 3D convex hull took 0.635796308517456 seconds. 21245 input vertices. 21245 output vertices.
  /nix/store/rxvw3i2kmnjc3yc41xg4xfc0k2sygr2c-python3.7-numpy-1.16.1/lib/python3.7/site-packages/numpy/linalg/linalg.py:2480: RuntimeWarning: overflow encountered in multiply
    s = (x.conj() * x).real
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:333: RuntimeWarning: invalid value encountered in true_divide
    data[:, 0] /= lengths
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:334: RuntimeWarning: invalid value encountered in true_divide
    data[:, 1] /= lengths
  /nix/store/wmy9m8lam3ja21khh2yfp3crh4lb6pml-python3.7-uranium-4.0.0/lib/python3.7/site-packages/UM/Mesh/MeshData.py:335: RuntimeWarning: invalid value encountered in true_divide
    data[:, 2] /= lengths
  2019-04-19 20:31:02,280 - DEBUG - [Thread-3] UM.FileHandler.ReadFileJob.run [69]: Loading file took 1.2 seconds
  ```

  Compared to ubuntu, the only differences are the `RuntimeWarning` and `Thread-3` (on ubuntu it's `Thread-1`).  The number of imported faces is also the same.

  cc @abbradar @orivej 

  ### Steps to reproduce

  1. Download a [benchy](https://www.thingiverse.com/download:1223854).
  2. `nix-shell -p cura --run cura`
  3. File/Open
  4. Look at the corrupted model (you might need to repeat, sometimes it works)

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.19, NixOS, 19.09pre174426.acbdaa569f4 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(gebner): `""`
   - channels(root): `"nixos-19.09pre174426.acbdaa569f4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: factorio: alpha 0.17.16 -> 0.17.32
user_login: bjpbakker
html_url: https://github.com/NixOS/nixpkgs/pull/59902
updated_at: 2019-04-20 08:28:58
body:
  ###### Motivation for this change
  Game developers released a bunch of updates. Alpha version in current tree (0.17.16) is no longer available for download.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: phpPackages: update php packages
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/59904
updated_at: 2019-04-23 04:52:21
body:
  Update php packages:
  - ast to 1.0.1
  - igbinary to 3.0.1
  - redis to 4.3.0
  - composer to 1.8.5
  - php-cs-fixer to 2.14.2
  - phpcs to 3.4.2
  - phpcbf to 3.4.2
  - psysh to 0.9.9
  - oci8 to 2.2.0

  Mark package php_excel broken.
  Mark package v8 v8js broken - error build package pkgs.v8_6_x
  Sort php packages alphabetically.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mopidy-iris: 3.33.0 -> 3.36.0
user_login: Tomahna
html_url: https://github.com/NixOS/nixpkgs/pull/59905
updated_at: 2019-04-22 22:11:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package request, ueberzug support in ranger
user_login: Alkeryn
html_url: https://github.com/NixOS/nixpkgs/issues/59906
updated_at: 2019-04-26 21:16:47
body:
  So there is a python package called ueberzug that can be used to display images in ranger, it is kinda similar to w3m except it works better and most importantly it works in termite in bspwm which w3m dosen't

  I found out how to install ueberzug but it dosen't work in ranger for some reason ^


state: open
title: GSConnect does not work with GDM
user_login: cyplo
html_url: https://github.com/NixOS/nixpkgs/issues/59907
updated_at: 2019-04-20 15:58:03
body:
  ## Issue description
  Hi ! 
  When using gnome extension gsconnect (both from 19.03 and unstable) it does not work when launched under Gnome3 session that was launched from GDM - both X and Wayland sessions have this problem.
  It works when Gnome is launched from LightDM.

  ### Steps to reproduce
  - install `gnomeExtensions.gsconnect`
  - set 
  ```
  services = {
        desktopManager = {
          gnome3.enable = true;
        };
        displayManager.gdm= {
          enable = true;
          wayland = false;
        };
  };
  ```
  * Observe:
    * gsconnect is available from the tray menu, however clicking `mobile devices -> mobile settings` does not open any window. 
    * Previously configured devices are not visible in the menu either

  Only log entry concerning gsconnect I was able to find is:
  ```
  Apr 19 23:44:22 skinnyv .gnome-shell-wr[1727]: JS ERROR: GSConnect: Gio.DBusError: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.Shell.Extensions.GSConnect was not provided by any .service files
                                                 _settings/<@/etc/profiles/per-user/cyryl/share/gnome-shell/extensions/gsconnect@andyholmes.github.io/extension.js:226:21

  ```

  ## Technical details
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.35, NixOS, 19.03.172286.8ea36d73256 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(cyryl): `""`
   - channels(root): `"nixos-19.03.172286.8ea36d73256"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  Happy to help debugging here but not sure where to start. Thanks !


state: closed
title: pythonPackages.pikepdf: init at 1.2.0
user_login: leenaars
html_url: https://github.com/NixOS/nixpkgs/pull/59908
updated_at: 2019-07-20 11:25:48
body:
  ###### Motivation for this change

  Dependency for e.g. ocrmypdf

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nix-shell -p pythonPackages.sounddevice: patching failed
user_login: tbenst
html_url: https://github.com/NixOS/nixpkgs/issues/59909
updated_at: 2019-04-22 22:01:29
body:
  ## Issue description

  sounddevice patching fails on unstable @FRidh 

  ### Steps to reproduce

  `nix-shell -p pythonPackages.sounddevice`

  ## Technical details
  ```
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.30, NixOS, 19.09pre173349.07b42ccf2de (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2`
   - channels(root): `"home-manager, nixos-19.09pre175916.1fc591f9a5b"`
   - channels(tyler): `"home-manager"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


  ```
  > nix-shell -p pythonPackages.sounddevice
  these derivations will be built:
    /nix/store/2h6vhj06iwscjy395hq78aikg7aslmbm-fix-portaudio-library-path.patch.drv
    /nix/store/8z84sr68bk8m9ir6iazh7kq57aa0xz3n-python2.7-sounddevice-0.3.12.drv
  these paths will be fetched (4.49 MiB download, 29.75 MiB unpacked):
    /nix/store/d63lm0iqkxslpqb4c8f76zr1l2rd5kp8-hook
    /nix/store/g3mckvqyi4ig3hfsb578m5gncgs0lshz-portaudio-190600-20161030
    /nix/store/h13jb8pjmdcm03shbyg2cabqxq58ggi0-python2.7-bootstrapped-pip-19.0.3
    /nix/store/v48k2iwm3526d3aw556gm6l2pla59ij6-python2.7-numpy-1.16.2
  copying path '/nix/store/d63lm0iqkxslpqb4c8f76zr1l2rd5kp8-hook' from 'https://cache.nixos.org'...
  copying path '/nix/store/g3mckvqyi4ig3hfsb578m5gncgs0lshz-portaudio-190600-20161030' from 'https://cache.nixos.org'...
  copying path '/nix/store/h13jb8pjmdcm03shbyg2cabqxq58ggi0-python2.7-bootstrapped-pip-19.0.3' from 'https://cache.nixos.org'...
  copying path '/nix/store/v48k2iwm3526d3aw556gm6l2pla59ij6-python2.7-numpy-1.16.2' from 'https://cache.nixos.org'...
  building '/nix/store/2h6vhj06iwscjy395hq78aikg7aslmbm-fix-portaudio-library-path.patch.drv'...
  building '/nix/store/8z84sr68bk8m9ir6iazh7kq57aa0xz3n-python2.7-sounddevice-0.3.12.drv'...
  unpacking sources
  unpacking source archive /nix/store/v86xdm0aq2hjl2n9gr64yfgp3z7hm1dy-sounddevice-0.3.12.tar.gz
  source root is sounddevice-0.3.12
  setting SOURCE_DATE_EPOCH to timestamp 1535879304 of file sounddevice-0.3.12/sounddevice.egg-info/zip-safe
  patching sources
  applying patch /nix/store/r2zffy62z2wilimlzx712cc0yd7l4yyg-fix-portaudio-library-path.patch
  patching file sounddevice.py
  Hunk #1 FAILED at 58.
  1 out of 1 hunk FAILED -- saving rejects to file sounddevice.py.rej
  builder for '/nix/store/8z84sr68bk8m9ir6iazh7kq57aa0xz3n-python2.7-sounddevice-0.3.12.drv' failed with exit code 1
  error: build of '/nix/store/8z84sr68bk8m9ir6iazh7kq57aa0xz3n-python2.7-sounddevice-0.3.12.drv' failed
  ```


state: closed
title: perlPackages.libapreq2: install the perl & apache modules (19.03 backport)
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59910
updated_at: 2019-04-22 22:11:25
body:
  (cherry picked from commit 2f25d58fc8d6e0edaceb6767efc588b4e0280b3d)

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  19.03 backport of https://github.com/NixOS/nixpkgs/pull/59861 because `libapreq2` is missing required functionality and is almost useless as is. This is safe for a backport because it doesn't modify touch any existing functionality, only adds missing (expected) features.

  ping @xeji as you seem to be keen on merging perl related PRs :smile: 
  NOTE: @volth has given me the ["LGTM"](https://github.com/NixOS/nixpkgs/issues/59773#issuecomment-484736667) on this change.

  ###### Things done
  See https://github.com/NixOS/nixpkgs/pull/59861 for details.
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cleanup redundant text in modules utilizing mkEnableOption
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59911
updated_at: 2019-04-20 13:08:51
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Most of these looks horrible when searching through [options](https://nixos.org/nixos/options.html).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libpst: Fix build
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/59912
updated_at: 2019-04-23 16:52:39
body:
  Disable Python integration because it can't find `-lboost_python`.
  I can't seem to get it to find the library so I just decided to disable Python.

  Build has been broken for almost a year: https://hydra.nixos.org/build/92480675

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fix pythonPackages.sounddevice and upgrade 0.3.12 -> 0.3.13
user_login: JohnAZoidberg
html_url: https://github.com/NixOS/nixpkgs/pull/59913
updated_at: 2019-05-06 21:50:24
body:
  ###### Motivation for this change
  v0.3.12 was broken because the outdated patch didn't apply anymore.
  I upgraded it to 0.3.13 and updated the patch.

  Fixes #59909

  Should probably be backported to 19.03.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: generate-config.pl does not work well with boot.kernelPatches.extraConfig
user_login: nh2
html_url: https://github.com/NixOS/nixpkgs/issues/59914
updated_at: 2019-04-20 03:22:20
body:
  ## Issue description

  I have the fealing that the `generate-config.pl` script is pretty bugged, it keeps failing with `repeated question` and spews out tons of `Error in reading or end of file.` afterwards when trying to use  `boot.kernelPatches.extraConfig`:

  Output:

  ```
  QUESTION:     USB Test and Measurement Class support, NAME: USB_TMC, ALTS: N/m/?, ANSWER: m
  GOT: 
  GOT:     *
  GOT:     * NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may
  GOT:     *
  GOT:     *
  GOT:     * also be needed; see USB_STORAGE Help for more info
  GOT:     *
  QUESTION:     USB Mass Storage support, NAME: USB_STORAGE, ALTS: M/n/?, ANSWER: y
  GOT: 
  GOT: 
  GOT: CONFIG_USB_STORAGE:
  GOT: 
  GOT: Say Y here if you want to connect USB mass storage devices to your
  GOT: computer's USB port. This is the driver you need for USB
  GOT: floppy drives, USB hard disks, USB tape drives, USB CD-ROMs,
  GOT: USB flash devices, and memory sticks, along with
  GOT: similar devices. This driver may also be used for some cameras
  GOT: and card readers.
  GOT: 
  GOT: This option depends on 'SCSI' support being enabled, but you
  GOT: probably also need 'SCSI device support: SCSI disk support'
  GOT: (BLK_DEV_SD) for most USB storage devices.
  GOT: 
  GOT: To compile this driver as a module, choose M here: the
  GOT: module will be called usb-storage.
  GOT: 
  GOT: Symbol: USB_STORAGE [=m]
  GOT: Type  : tristate
  GOT: Prompt: USB Mass Storage support
  GOT:   Location:
  GOT:     -> Device Drivers
  GOT:       -> USB support (USB_SUPPORT [=y])
  GOT:         -> Support for Host-side USB (USB [=m])
  GOT:   Defined at drivers/usb/storage/Kconfig:8
  GOT:   Depends on: USB_SUPPORT [=y] && USB [=m] && SCSI [=y]
  GOT: 
  GOT: 
  GOT: 
  QUESTION:     USB Mass Storage support, NAME: USB_STORAGE, ALTS: M/n/?, ANSWER: y
  repeated question:     USB Mass Storage support at /nix/store/l6m0lgcrls587pz0i644jhfjk6lyj55s-generate-config.pl line 81.

  Error in reading or end of file.

  Error in reading or end of file.

  Error in reading or end of file.

  Error in reading or end of file.
  ```

  and lots more of that, eventually failing with `builder for '/nix/store/jjmxf3ivfp7xbz0y9bcqd9swvfrrc6h9-linux-config-4.4.178.drv' failed with exit code 255`.

  Indeed, it asked a question twice, should the script handle that if stuff is being patched?

  ### Steps to reproduce

  ```
    boot.kernelPatches = [ {
      name = "chromiumos-inspired";
      patch = null;
      # https://cateee.net/lkddb/web-lkddb/BLK_DEV_SD.html
      #   Do not compile this driver as a module if your root file system
      #   (the one containing the directory /) is located on a SCSI disk.
      #   In this case, do not compile the driver for your SCSI host
      #   adapter (below) as a module either.
      extraConfig = ''
        SCSI y
        SCSI_MOD y
        BLK_DEV_SD y
        SCSI_SPI_ATTRS y
        ATA y
        SATA_AHCI y
        ATA_GENERIC y

        BLK_DEV_DM y
        DM_BUFIO y
        DM_BIO_PRISON y
        DM_PERSISTENT_DATA y
        DM_CRYPT y
        DM_THIN_PROVISIONING y
        DM_VERITY y

        USB_NET_DRIVERS y

        INPUT_EVDEV y

        KEYBOARD_CROS_EC y

        SERIO y
        SERIO_I8042 y
        SERIO_LIBPS2 y

        HW_RANDOM y
        HW_RANDOM_TPM y
        HW_RANDOM_INTEL y
        NVRAM y
        TCG_TPM y
        TCG_TIS y
        DEVPORT y

        ITCO_WDT y
        ITCO_VENDOR_SUPPORT y

        SSB_SDIOHOST y

        AGP y
        AGP_INTEL y
        INTEL_GTT y
        DRM y
        DRM_KMS_HELPER y

        FB_SYS_FILLRECT y
        FB_SYS_COPYAREA y
        FB_SYS_IMAGEBLIT y
        FB_SYS_FOPS y
        BACKLIGHT_GENERIC y

        #USB_STORAGE y
        USB_STORAGE_REALTEK y
        USB_UAS y
        USB_SERIAL y

        MMC y
        MMC_BLOCK y
        MMC_BLOCK_MINORS 16

        MMC_SDHCI y
        MMC_SDHCI_PCI y
        MMC_SDHCI_ACPI y
        LEDS_CLASS y

        DMA_OF y

        ASHMEM y
        ANDROID_TIMED_OUTPUT y
        ANDROID_TIMED_GPIO y
        SYNC y
        SW_SYNC y
        SW_SYNC_USER y
        ION y
        ION_DUMMY y
        ACPI_WMI y
        MXM_WMI y

        CHROMEOS_LAPTOP y
        CHROMEOS_PSTORE y
        CROS_EC_CHARDEV y
        CROS_EC_LPC y

        GOOGLE_FIRMWARE y

        EFI_VARS y
        EFI_VARS_PSTORE y
        EXT4_FS y
        EXT4_USE_FOR_EXT2 y
        EXT4_ENCRYPTION y
        JBD2 y
        FS_MBCACHE y
        AUTOFS4_FS y

        PSTORE_RAM y

        ENCRYPTED_KEYS y

        LSM_MMAP_MIN_ADDR 32768
        SECURITY_SELINUX_BOOTPARAM_VALUE 1
        DEFAULT_SECURITY "selinux"
      '';
  ```

  ## Technical details

  On commit 05a53ecd827c5910e34171e7681c56913b29add1


state: closed
title: crawl: add .desktop file and use high-res app icon
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59915
updated_at: 2019-04-26 21:45:09
body:
  ###### Motivation for this change

  The crawl source includes .desktop files but currently they are not
  installed. This change installs them (with the executable path tweaked
  for NixOS compatibility).

  Also included in this change is a patch to use the included high-res app
  icon instead of the default 32x32 icon. The default icon is very low res
  and looks out of place beside other app icons.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: networkmanager: port to Meson
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/59916
updated_at: 2019-04-23 00:41:31
body:
  ###### Motivation for this change
  All hail Meson!

  See the commit messages for details.

  ###### Things done

  I checked that the outputs still match: The `man` and `doc` were moved to separate outputs, Vapi was added to `dev` output, `devdoc` were added, libtool files were removed from `out`.

  I also opened the docs in Devhelp but they suffer from the common `about:blank` bug: `env XDG_DATA_DIRS=$(nix-build -A networkmanager.devdoc --no-link)/share GTK3_MODULES= devhelp`

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


  ---


state: closed
title: cargo-expand: 0.4.10 -> 0.4.11
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/59917
updated_at: 2019-04-20 10:01:06
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-expand` to the latest release.

  https://github.com/dtolnay/cargo-expand/releases/tag/0.4.11

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ffsend: 0.2.42 -> 0.2.45
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/59918
updated_at: 2019-04-23 06:54:27
body:
  ###### Motivation for this change

  https://github.com/timvisee/ffsend/releases/tag/v0.2.45

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: lua: merge lua5.X interpreters
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/59919
updated_at: 2019-06-02 22:41:06
body:
  similar to what was done for python.
  Makes it easier to change the passthru settings and the lua infrastructure.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jool: unstable-20180706 -> 4.0.0
user_login: liclac
html_url: https://github.com/NixOS/nixpkgs/pull/59920
updated_at: 2019-04-23 23:38:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updated `jool` to version 4.0, and fixed it so that it builds on up-to-date kernels.

  Also removed the assertion on the kernel version; upstream doesn't list any constraints on supported kernels anywhere I can see, and if the kernel API makes an incompatible change, we'll notice when it fails to build normally.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gap: 4.10.0 -> 4.10.1
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/59921
updated_at: 2019-04-20 11:17:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Version bump, some patches upstreamed.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Packaging request: Flyve MDM Dashboard
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/59922
updated_at: 2019-05-05 16:39:26
body:
  This is a packaging request, also could be written as a service so it's easy to take into use.

  Flyve MDM is an open source service for Mobile Device Management. See: http://flyve.org/web-mdm-dashboard/

  GitHub: https://github.com/flyve-mdm/web-mdm-dashboard


state: closed
title: freecad: 0.17 -> 0.18.1
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/59923
updated_at: 2019-04-26 08:04:08
body:
  ###### Motivation for this change

  Updating to the latest version. Some simplification has been possible as FreeCAD now includes XDG config files in its release.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: knot-resolver: 3.2.1 -> 4.0.0 -> 4.1.0
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/pull/59924
updated_at: 2019-07-12 21:37:23
body:
  https://lists.nic.cz/pipermail/knot-resolver-users/2019/000136.html

  Works fine for me (as of the 4.0.0 commit), including the nixos service.  Still, I'd like to improve the service to support easy passing of sockets to http module.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] N/A Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after):
      * no changes in runtime dependencies
      * a few KiB changes in the package itself
  - [x] N/A Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fixDarwinDylibNames fails for some libraries
user_login: jacereda
html_url: https://github.com/NixOS/nixpkgs/issues/59925
updated_at: 2019-05-23 17:52:27
body:
  ## Issue description
  While trying to fix the samba build for Darwin I found that it installs some libraries without write permissions. `fixDarwinDylibNames` won't help for those.

  Could it do a `chmod u+w` prior to `install_name_tool`?


state: closed
title: phpPackages.oci8: 2.1.8 -> 2.2.0
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/59926
updated_at: 2019-04-22 21:57:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  php73Packages.oci8 is broken on 19.03 as php7.3 is broken in oci8 2.1.8 according to upstream. The 2.2.0 has addressed this problem. This should be backported to 19.03 as well as it is break fix.

  Note: This package depends on a non-free package and requires an external download + an account.

  ###### Things done
  I have successfully built php71Packages.oci8, php72Packages.oci8, php73Packages.oci8, php71Packages-unit.oci8, php72Packages-unit.oci8, and php73Packages-unit.oci8 against this PR, and have tested the new version of oci8 on php 7.1 and 7.2 on 18.09.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  ping @etu & @Ma27


