# issues

state: closed
title: spidermonkey_60: 60.4.0 -> 60.7.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62691
updated_at: 2019-06-05 15:03:45
body:
  ###### Motivation for this change

  (This should generally track firefox-esr's version, right?)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: harfbuzz: 2.5.0 -> 2.5.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62693
updated_at: 2019-06-07 04:38:22
body:
  ###### Motivation for this change

  https://github.com/harfbuzz/harfbuzz/releases/tag/2.5.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: toybox: 0.8.0 -> 0.8.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62694
updated_at: 2019-06-07 04:32:11
body:
  ###### Motivation for this change

  http://landley.net/toybox/index.html#21-05-2019

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bro: 2.5.5 -> 2.6.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62695
updated_at: 2019-07-15 20:51:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Security fix release mentioned at top of notes, FWIW:

  https://raw.githubusercontent.com/zeek/zeek/bb979702cf9a2fa67b8d1a1c7f88d0b56c6af104/NEWS

  ----

  Seems reasonable but if anyone actually familiar can test or otherwise
  review that'd be appreciated!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: radamsa: 0.5 -> 0.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62696
updated_at: 2019-06-07 10:12:43
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  * new home (github -> gitlab)
  * "modernize" a bit
  * run tests!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: fakechroot: 2.19 -> 2.20.1, prefer patch and official source over "fork"
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62698
updated_at: 2019-07-13 19:40:57
body:
  ###### Motivation for this change

  The most immediate motivation for the source/patch reworking is to
  upgrade the tree without needing to provide an updated version
  with the fix and the upgrade as well.

  Naturally the patch won't necessarily apply to all future versions,
  but that's easy enough to check and happily appears to have no trouble
  with this upgrade.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: udocker: 1.1.1 -> 1.1.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62699
updated_at: 2019-06-07 04:33:28
body:
  ###### Motivation for this change

  Little docker, growing up!

  https://github.com/indigo-dc/udocker/releases/tag/v1.1.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: p11-kit: 0.23.15 -> 0.23.16.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62702
updated_at: 2019-06-09 10:36:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/p11-glue/p11-kit/releases/tag/0.23.16.1
  https://github.com/p11-glue/p11-kit/releases/tag/0.23.16

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: z3: 4.8.4 -> 4.8.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62703
updated_at: 2019-06-11 00:55:28
body:
  * drop included patch


  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: gnss-sdr: 0.0.9 -> 0.0.10 (wip)
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62704
updated_at: 2019-06-05 00:32:58
body:
  ###### Motivation for this change

  https://gnss-sdr.org/gnss-sdr-v0010-released/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
       - rebuilding again to be sure, FWIW
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyotherside: 1.5.4 -> 1.5.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62705
updated_at: 2019-06-06 11:25:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/thp/pyotherside/releases/tag/1.5.5

  Tested the two apps that use it in-tree:
  * yubioath-desktop
  * yubikey-manager-qt

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: buildah: 1.8.2 -> 1.8.3
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62706
updated_at: 2019-06-06 12:07:37
body:
  ###### Motivation for this change

  Looks like nice update:

  https://github.com/containers/buildah/releases/tag/v1.8.3

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: asciidoctor: 1.5.7.1 -> 2.0.10
user_login: michaelpj
html_url: https://github.com/NixOS/nixpkgs/pull/62707
updated_at: 2019-06-12 00:32:58
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  There has been a new major version, so it seems good to upgrade.

  I had to drop two plugins:
  - `asciidoctor-latex` seems dead, and hasn't had any commits since 2015.
  - `asciidoctor-bespoke` also hasn't been updated for over a year, and
  doesn't seem to be compatible with the new version.

  @yacinehmito 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bcompare: init at 4.2.10.23938
user_login: ktor
html_url: https://github.com/NixOS/nixpkgs/pull/62708
updated_at: 2019-06-23 21:22:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  I was missing Beyond Compare merge/diff application in the repo. 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  ###### Notes
  This is initial commit. App works on my NixOS machine with xmonad. I have not tested it with other windows managers.


state: closed
title: nodejs-12_x: 12.3.1 -> 12.4.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62710
updated_at: 2019-06-05 02:56:23
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Changelog: https://nodejs.org/en/blog/release/v12.4.0/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: NixOS module system: improve one of error messages
user_login: danbst
html_url: https://github.com/NixOS/nixpkgs/pull/62712
updated_at: 2019-06-13 09:00:46
body:
  ###### Motivation for this change
  Partially helps with https://github.com/NixOS/nixpkgs/issues/15747

  The error can be reproduced like:
  ```
      $ nix-instantiate ./nixos -A system --arg configuration '
        { fileSystems."/".device = "nodev";
          boot.loader.grub.devices = [ "nodev" ];
          containers.t.config.imports = [ <nixpkgs/nixos/modules/virtualisation/amazon-image.nix> ];
        }'
  ```
      
  Previously error was:
  ```
      error: The unique option `containers.t.networking.hostName' is defined multiple times, in `/nix/var/nix/profiles/per-user/root/channels/nixpkgs/nixos/modules/virtualisation/amazon-image.nix' and `<unknown-file>'.
      (use ‘--show-trace’ to show detailed location information)
  ```
      
  Now it is:
  ```
      error: The unique option `containers.t.networking.hostName' is defined multiple times, in:
       - /nix/var/nix/profiles/per-user/root/channels/nixpkgs/nixos/modules/virtualisation/amazon-image.nix
       - module at /home/danbst/dev/nixpkgs/nixos/modules/virtualisation/containers.nix:470.
      (use '--show-trace' to show detailed location information)
  ```

  What do you think? Is it clearer now?


state: closed
title: vim/neovim: Backports fix for ACE
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/62713
updated_at: 2019-06-05 09:31:24
body:
  ###### Motivation for this change

  Details:

   * https://github.com/numirias/security/blob/cf4f74e0c6c6e4bbd6b59823aa1b85fa913e26eb/doc/2019-06-04_ace-vim-neovim.md

  The vim patch is the upstream commit, with incompatible changes removed.

  The neovim patch is the upstream one directly.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - 🔲 Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - 🔲 Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luaPackages.cjson: move to generated
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62714
updated_at: 2019-07-01 07:10:30
body:
  Tested with nix-review

  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Darwin GL Experiments
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62715
updated_at: 2019-06-06 00:31:08
body:
  Trying to get some GL things to build with Darwin / macOS / XQuartz

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: luaPackages.lpeg: 1.0.1 -> 1.0.2
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62716
updated_at: 2019-06-07 12:17:06
body:
  and move to generated.

  Tested with nix-review.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Luazip update
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62717
updated_at: 2019-06-06 01:03:48
body:
  ###### Motivation for this change
  More automation \o/ 

  ###### Things done
  tested with nix-review

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: coqPackages: fix + add multinomials 1.3 + coqeal 1.0.0
user_login: CohenCyril
html_url: https://github.com/NixOS/nixpkgs/pull/62718
updated_at: 2019-07-02 12:01:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixing my buggy implementation of generation of additional packages for mathcomp and added multinomials release 1.3 and coqeal release 1.0.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dockerTools.buildLayeredImage: restore layer sharing
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/62719
updated_at: 2019-06-06 13:05:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  PR #58431 added /nix/store to each layer.tar. However, the timestamp was
  not explicitly set while adding /nix and /nix/store to the archive. This
  resulted in different SHA256 hashes of layer.tar between image builds.

  This change sets time and owner when tar'ing /nix/store.

  Since #58431 was also backported to 19.03, this change should probably also be backported.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: chromium: 74.0.3729.157 -> 75.0.3770.80
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/62720
updated_at: 2019-06-05 23:42:32
body:
  ###### Motivation for this change

  https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Tested stable on x86_64: YouTube, WebGL, audio, Speedometer, Octane 2.0 are working

  Tested dev on x86_64: YouTube, WebGL, audio are working

  Not seeing any severe Linux bugs listed on https://crbug.com


state: closed
title: pam_u2f: 1.0.8 -> 1.0.9
user_login: fpletz
html_url: https://github.com/NixOS/nixpkgs/pull/62721
updated_at: 2019-06-05 12:29:27
body:
  ###### Motivation for this change
  Fixes CVE-2019-12209 & CVE-2019-12210.

  https://developers.yubico.com/pam-u2f/Release_Notes.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-bloat: 0.6.4 -> 0.7.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62722
updated_at: 2019-06-06 06:54:47
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-bloat` to the latest release.
  https://github.com/RazrFalcon/cargo-bloat/releases/tag/v0.7.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vim: 8.1.1234 -> 8.1.1467 [security]
user_login: tokudan
html_url: https://github.com/NixOS/nixpkgs/pull/62723
updated_at: 2019-06-05 22:49:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  fixes a security issue (details: https://github.com/numirias/security/blob/master/doc/2019-06-04_ace-vim-neovim.md)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gotools: 2019-05-24 -> 2019-06-03
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/62725
updated_at: 2019-06-05 20:52:38
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Upstream update. Hopefully resolves https://github.com/golang/go/issues/30309 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zathura: pass gsettings schemas
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/62726
updated_at: 2019-06-05 16:12:33
body:
  File chooser dialogue in print dialogue requires GTK’s GSettings schemas or it will trigger a trap.

  Closes: https://github.com/NixOS/nixpkgs/issues/16287


state: closed
title: nomachine-client: 6.6.8 -> 6.7.6
user_login: talyz
html_url: https://github.com/NixOS/nixpkgs/pull/62727
updated_at: 2019-06-17 07:33:33
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after) (a reduction of ~4M)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: firefox-wayland: Add missing dependency libglvnd (libEGL)
user_login: talyz
html_url: https://github.com/NixOS/nixpkgs/pull/62728
updated_at: 2019-06-05 23:34:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Firefox running in wayland mode is unable to find and load
  libEGL.so (and says so on stdout). This puts it in "basic"
  mode (unaccelerated graphics) and disables WebGL. Fix this by adding
  libglvnd to the LD_LIBRARY_PATH.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libmatroska: 1.5.0 -> 1.5.2
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/62731
updated_at: 2019-06-05 22:25:32
body:
  ###### Motivation for this change

  Fixes the build, broken by https://github.com/NixOS/nixpkgs/pull/62459

  (libmatroska 1.5.0 expects libebml 1.3.7)

  Currently broken on 

  ```
  installing 'libmatroska-1.5.0'
  these derivations will be built:
    /nix/store/wyn86b98pya06xs9xw06fkikd5crxp41-libmatroska-1.5.0.drv
  building '/nix/store/wyn86b98pya06xs9xw06fkikd5crxp41-libmatroska-1.5.0.drv'...
  unpacking sources
  unpacking source archive /nix/store/i3wq66dndcvkm5jrkhzcsfx7c6d7sgdi-source
  source root is source
  patching sources
  configuring
  fixing cmake files...
  cmake flags: -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/g7471azh71jvbdz5szm8yd782imh5iqz-libmatroska-1.5.0/include -DCMAKE_INSTALL_LIBDIR=/nix/store/g7471azh71jvbdz5szm8yd782imh5iqz-libmatroska-1.5.0/lib -DCMAKE_INSTALL_NAME_DIR=/nix/store/g7471azh71jvbdz5szm8yd782imh5iqz-libmatroska-1.5.0/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_DEPLOYMENT_TARGET= -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=last -DCMAKE_STRIP=/nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/strip -DCMAKE_RANLIB=/nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ranlib -DCMAKE_AR=/nix/store/2dfjlvp38xzkyylwpavnh61azi0d168b-binutils-2.31.1/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/g7471azh71jvbdz5szm8yd782imh5iqz-libmatroska-1.5.0 -DBUILD_SHARED_LIBS=YES
  -- The C compiler identification is GNU 7.4.0
  -- The CXX compiler identification is GNU 7.4.0
  -- Check for working C compiler: /nix/store/ds1prvgw3i3ic8c7axyrw4lwm3d0gqab-gcc-wrapper-7.4.0/bin/gcc
  -- Check for working C compiler: /nix/store/ds1prvgw3i3ic8c7axyrw4lwm3d0gqab-gcc-wrapper-7.4.0/bin/gcc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /nix/store/ds1prvgw3i3ic8c7axyrw4lwm3d0gqab-gcc-wrapper-7.4.0/bin/g++
  -- Check for working CXX compiler: /nix/store/ds1prvgw3i3ic8c7axyrw4lwm3d0gqab-gcc-wrapper-7.4.0/bin/g++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  CMake Error at CMakeLists.txt:8 (find_package):
    By not providing "FindEbml.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "Ebml", but
    CMake did not find one.

    Could not find a package configuration file provided by "Ebml" (requested
    version 1.3.7) with any of the following names:

      EbmlConfig.cmake
      ebml-config.cmake

    Add the installation prefix of "Ebml" to CMAKE_PREFIX_PATH or set
    "Ebml_DIR" to a directory containing one of the above files.  If "Ebml"
    provides a separate development package or SDK, be sure it has been
    installed.


  -- Configuring incomplete, errors occurred!
  See also "/build/source/build/CMakeFiles/CMakeOutput.log".
  builder for '/nix/store/wyn86b98pya06xs9xw06fkikd5crxp41-libmatroska-1.5.0.drv' failed with exit code 1
  error: build of '/nix/store/wyn86b98pya06xs9xw06fkikd5crxp41-libmatroska-1.5.0.drv' failed
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @worldofpeace


state: closed
title: jsonnet: 0.12.1 -> 0.13.0
user_login: nshalman
html_url: https://github.com/NixOS/nixpkgs/pull/62732
updated_at: 2019-06-05 17:31:08
body:
  ###### Motivation for this change
  Version bump

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: qtikz: unstable-20161122 -> 0.12
user_login: layus
html_url: https://github.com/NixOS/nixpkgs/pull/62733
updated_at: 2019-06-18 20:39:12
body:
  ###### Motivation for this change

  No update in two years, and a broken package ;-)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/fail2ban: Make default settings optional/changable
user_login: OPNA2608
html_url: https://github.com/NixOS/nixpkgs/issues/62734
updated_at: 2019-06-08 18:54:33
body:
  ## Issue description
  I'd like to use settings for the DEFAULT and ssh-iptables jails that differ from those automatically set by the module, but there's currently no (easily discoverable?) way of doing so.
  https://github.com/NixOS/nixpkgs/blob/92a047a6c4d46a222e9c323ea85882d0a7a13af8/nixos/modules/services/security/fail2ban.nix#L130-L148

  When specifying different lines, the original ones get appended and override any duplicate setting.

  I think wrapping these default jail definitions with `mkDefault` (which would have the drawback of throwing all default settings out the window if users want only 1 thing changed) or making more options for the most common settings + "extraConfig" would be better. :slightly_smiling_face: 


  ### Steps to reproduce
  1)
  ```nix
  services.fail2ban = {
    enable = true;
    jails.DEFAULT = ''
      bantime = 1d;
    '';
  }
  ```
  2) Check `/etc/fail2ban/jail.conf`.

  There will be 2 `bantime` lines and the first one (yours) will get discarded during executing in favour of the second (default) one.


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

   - system: `x86_64-linux`
   - host os: `Linux 5.1.5, NixOS, 19.03.172745.37698198717 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(bt1cn): `""`
   - channels(root): `"nixos-19.03.172745.37698198717"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: AgdaStdlib: 1.0 -> 1.0.1
user_login: alexarice
html_url: https://github.com/NixOS/nixpkgs/pull/62735
updated_at: 2019-07-21 15:29:54
body:
  ###### Motivation for this change
  New version

  ###### Things done
  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: sagemath8.6 inotebook cannot load jmol
user_login: ghasshee
html_url: https://github.com/NixOS/nixpkgs/issues/62736
updated_at: 2019-06-22 11:41:57
body:
  ## Issue description

  in sage interpreter, it can call jmol correctly. 
  But in inotebook mode, it does not. 

  ### Steps to reproduce

  open browser inotebook with : 
  ```
  sage -inotebook
  ``` 

  Then create new sheet and 
  copy paste and run : 
  ```
  x,y,z = var('x,y,z')
  f = x^3-x*z^2+y^2*z
  g = x^2+y^2+z^2-1
  implicit_plot3d(g*f,(x,-1,1),(y,-1,1),(z,-1,1))
  ``` 


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.5, NixOS, 19.03.172765.55df3fe5f3f (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(ghasshee): `"nixos-19.03.172765.55df3fe5f3f, nixpkgs-19.03pre161900.61c3169a0e1"`
   - channels(root): `"nixos-19.03"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: linux_{5_1,testing}: fix bug null pointer dereference
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62737
updated_at: 2019-06-09 07:58:59
body:
  ###### Motivation for this change
  Fix this issue https://github.com/NixOS/nixpkgs/issues/61909

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: weechatScripts.wee-slack: 2.2.0 -> 2.3.0
user_login: geistesk
html_url: https://github.com/NixOS/nixpkgs/pull/62738
updated_at: 2019-06-11 09:53:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Updates `wee-slack` to the current release.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: adrdox: init at v1.0.0
user_login: chloekek
html_url: https://github.com/NixOS/nixpkgs/pull/62739
updated_at: 2019-06-09 12:13:31
body:
  Adding a package for the adrdox documentation generator for D.

  ###### Motivation for this change

  I like this tool and it wasn't in Nixpkgs so I added it to Nixpkgs. It is used by several D projects for generating HTML documentation from source code.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.spglib: add patch fixing darwin/py27 build
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62740
updated_at: 2019-06-09 21:56:42
body:
  ###### Motivation for this change
  In trying to fix the darwin py27 build for this package, realized it was an upstream problem. Opened upstream issue https://github.com/atztogo/spglib/issues/78, turns out the problem was an incorrect assertion and darwin/py27 was the only combination where its `assert()` wasn't acting as a no-op, so tripping up on this problem.

  `pythonPackages.seekpath` reverse-dependency seems broken, so `nox-review` doesn't _quite_ build fully, but this doesn't break anything new. Tested on non-nixos linux x86_64 and macos 10.13.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: haskellPackages: Don't ignore old overrides
user_login: Infinisil
html_url: https://github.com/NixOS/nixpkgs/pull/62742
updated_at: 2019-06-27 21:32:33
body:
  This prevented `pkgs.haskell.packages.${compiler}` overlays from propagating
  to `pkgs.haskellPackages`

  E.g. if you use this overlay:
  ```nix
  self: super: {
    haskell = super.haskell // {
      packages = super.haskell.packages // {
        ghc865 = super.haskell.packages.ghc865.override (old: {
          overrides = super.lib.composeExtensions (old.overrides or (hself: hsuper: {})) (hself: hsuper: {
            foobarbaz = "foobarbaz";
          });
        });
      };
    };
  }
  ```

  You now have access to `foobarbaz` through `pkgs.haskellPackages.foobarbaz` in addition to `pkgs.haskell.packages.ghc865.foobarbaz`.

  Pinging @peti @r-ryantm @basvandijk @domenkozar


state: open
title: weechatScripts.weechat-otr: init at 1.9.2
user_login: geistesk
html_url: https://github.com/NixOS/nixpkgs/pull/62743
updated_at: 2019-07-06 08:49:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  This PR adds the `otr.py` script for WeeChat.

  As discussed both in the [NixOS Wiki](https://nixos.wiki/wiki/Weechat) and in [`potr`'s issue tracker](https://github.com/python-otr/pure-python-otr/issues/68) before, `potr` does not work properly with the current version of `pycryptodome` and requires an older version of `pycrpto`. Therefore, the last release of `pycrypto`, with Debian's [security patches](https://security-tracker.debian.org/tracker/source-package/python-crypto) applied, will be used.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] matrix-appservice-discord: init at 0.5.1
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/62744
updated_at: 2019-07-07 14:48:23
body:
  ###### Motivation for this change

  This PR adds a package and a module for the [matrix-appservice-discord][1] service.

  [1]: https://github.com/Half-Shot/matrix-appservice-discord

  ###### Blockers / Things to get done

  - [x] ~~Broken node packages due to bad tarballs: https://github.com/NixOS/nixpkgs/issues/62632~~
  - [x] ~~Compilation fails with latest Typescript: https://github.com/Half-Shot/matrix-appservice-discord/issues/487~~
  - [x] ~~Override config with environment variables: https://github.com/Half-Shot/matrix-appservice-discord/pull/485~~
  - [x] ~~Wait for upstream to tag and release 0.5.1 (containing the patches above).~~
  - [x] ~~Removal of app service registration (to protect the AS' token)~~
  - [ ] Serialisation of the config attribute set which contains `mkOverride` values (https://github.com/NixOS/nixpkgs/pull/63589#discussion_r299780638)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] chromium: 74.0.3729.157 -> 75.0.3770.80 (backport)
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/62745
updated_at: 2019-06-07 08:46:52
body:
  ###### Motivation for this change

  Backport #62720 to fix CVEs

  https://chromereleases.googleblog.com/2019/06/stable-channel-update-for-desktop.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.azure-cli-core: init at 2.0.66
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62746
updated_at: 2019-07-09 07:45:02
body:
  ###### Motivation for this change
  Lay the groundwork for [azure-cli repo](https://github.com/Azure/azure-cli), which is the "new azure cli standard". Also know as "azure cli 2.0".

  The azure-cli package will have to wait for #60435 to be merged. And then nix will have modern support for azure :) (at least cli, nixops will be later)

  Separate from #60435 

  Works with python2, python3.6 and python3.7. Unfortunately contextvars is needed for one of the dependencies (msrest) so it's broken on python3.5.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh /nix/store/fsdvfxzz6bwgdvzdhnziw5rjnpjjr896-python3.6-azure-cli-core-2.0.66
  /nix/store/fsdvfxzz6bwgdvzdhnziw5rjnpjjr896-python3.6-azure-cli-core-2.0.66      135.5M


state: open
title: syncthing-gtk fails to start (ValueError: Namespace Notify not available)
user_login: reanimus
html_url: https://github.com/NixOS/nixpkgs/issues/62747
updated_at: 2019-06-06 19:51:40
body:
  ## Issue description
  Syncthing-GTK fails to launch entirely due to an issue importing a dependency. When run, the app outputs an error to the console:

  ```
  Traceback (most recent call last):
    File "/nix/store/grwbfwsjhrihl34cfv4xfd1bz3hkjbnr-syncthing-gtk-0.9.4/bin/..syncthing-gtk-wrapped-wrapped", line 38, in <module>
      from syncthing_gtk.app import App
    File "/nix/store/grwbfwsjhrihl34cfv4xfd1bz3hkjbnr-syncthing-gtk-0.9.4/lib/python2.7/site-packages/syncthing_gtk/app.py", line 17, in <module>
      from syncthing_gtk.notifications import Notifications, HAS_DESKTOP_NOTIFY
    File "/nix/store/grwbfwsjhrihl34cfv4xfd1bz3hkjbnr-syncthing-gtk-0.9.4/lib/python2.7/site-packages/syncthing_gtk/notifications.py", line 19, in <module>
      gi.require_version('Notify', '0.7')
    File "/nix/store/b4xz3qddhvy1jw9jjavrgj5vsanhiljn-python2.7-pygobject-3.30.4/lib/python2.7/site-packages/gi/__init__.py", line 129, in require_version
      raise ValueError('Namespace %s not available' % namespace)
  ValueError: Namespace Notify not available
  ```

  ### Steps to reproduce
  1. Run `syncthing-gtk`

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.03.172801.1a27474d474 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(animus): `""`
   - channels(root): `"nixos-19.03.172801.1a27474d474"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
title: nixos/mediawiki: init service to replace httpd subservice
user_login: aanderse
html_url: https://github.com/NixOS/nixpkgs/pull/62748
updated_at: 2019-07-11 23:32:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Continue to remove `httpd.extraSubservices`.

  See [part 1](https://github.com/NixOS/nixpkgs/pull/57752) and [part 2](https://github.com/NixOS/nixpkgs/pull/62175) for prior work on the topic. I still need to write release notes for 19.09, but waiting for module review before going ahead with that.

  A big thanks to @tstarling of the Wikimedia foundation for all his help on this module over IRC.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnome3.gnome-disk-utility unable to find sgdisk
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/issues/62749
updated_at: 2019-06-08 05:03:42
body:
  ## Issue description

  `gnome3.gnome-disk-utility` is unable to add a partition due to missing `sgdisk` utility.

  ![disks-error](https://user-images.githubusercontent.com/4312404/59000332-587da780-884d-11e9-8e57-5d2fccd7d596.png)

  ### Steps to reproduce

  Attempt to create new luks-encrypted ext4 partition in `gnome-disks`.

  ## Technical details

  This looks to be similar to #34999, however I'm not able to find any reference to `sgdisk` in the source of either gnome-disk-utility or udisks. So I'm not sure what is actually looking for the `sgdisk` command.

  I've also tried adding `gptfdisk` (the Nix derivation that includes `sgdisk`) to the `buildInputs` of both `gnome3.gnome-disk-utility` and `udisks2`, but it doesn't fix the error.

  System info:
   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.09.git.ae71c13 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(chris): `"nixos-19.09pre181629.ae71c13a92f"`
   - channels(root): `"nixos-19.09pre181629.ae71c13a92f"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: font-awesome: 5.8.2 -> 5.9.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62750
updated_at: 2019-06-06 13:38:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update `font-awesome` to the latest release.
  https://github.com/FortAwesome/Font-Awesome/releases/tag/5.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Luazlib renamed to lua-zlib + update + move to generated
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62751
updated_at: 2019-06-06 03:44:50
body:
  ###### Motivation for this change
  As most packages are generated, better stick with the (official) luarocks name. Only sile used luazlib so it shouldn't warrant an alias yet.

  I added a column to track maintainers in maintainers/scripts/luarocks-packages.csv.
  It's not used yet but I will update the script soon to reflect the change.

  Tested binaries with nix-review.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Fixes for x86_64-darwin failures on Hydra
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62752
updated_at: 2019-06-06 13:46:42
body:
  some more fixes for x86_64-darwin failures.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: ledger-live-desktop: init at 1.9.1
user_login: thedavidmeister
html_url: https://github.com/NixOS/nixpkgs/pull/62753
updated_at: 2019-06-30 14:07:38
body:
  ###### Motivation for this change

  Adds ledger live desktop, the app that manages ledger S/X/blue

  https://www.ledger.com/

  ###### Things done

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: imagecodecs-lite: init at 2019.4.20
user_login: tbenst
html_url: https://github.com/NixOS/nixpkgs/pull/62754
updated_at: 2019-06-30 20:00:28
body:
  ###### Motivation for this change
  Block-oriented, in-memory buffer transformation, compression, and decompression functions. Needed for `tifffile`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Tifffile
user_login: tbenst
html_url: https://github.com/NixOS/nixpkgs/pull/62755
updated_at: 2019-06-26 01:05:48
body:
  ###### Motivation for this change
  Add missing dependency to `tifffile`. Note: do not merge until https://github.com/NixOS/nixpkgs/pull/62754 is merged

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Luaposix
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62756
updated_at: 2019-06-06 06:14:06
body:
  ###### Motivation for this change
  tested with nix-review

  ###### Things done
  use official mpack rather than my source.
  move luaposix to generated

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libblockdev: add gptfdisk as a dependency
user_login: lightbulbjim
html_url: https://github.com/NixOS/nixpkgs/pull/62757
updated_at: 2019-06-08 06:52:02
body:
  ###### Motivation for this change

  Certain udisk2 operations (eg creating luks-encrypted ext4 volumes) require libblockdev to have access to the sgdisk utility. This change adds gptfdisk (which includes sgdisk) to libblockdev.

  Fixes #62749.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/zoneminder: font files cannot be found
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62758
updated_at: 2019-07-18 01:27:16
body:
  ###### Motivation for this change

  ZM's paths to font files are wrong so we need to rewrite them.

  The browser will try to access ```/skins/classic/css/fonts/font_file.ttf``` which should just be ```/fonts/font_file.ttf```.

  I have no idea how this used to work, but in any case after this it does.

  Cc: @amazari @aanderse 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: icr: do not wrap crystal so we can use one from the environment
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62759
updated_at: 2019-07-18 01:27:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Further to #61156, do not wrap ```crystal``` so icr will work with whatever crystal is currently available in the environment.

  This means that installing ```icr``` on its own isn't enough to make it work - you need to have crystal available, either in the global environment, the user environment or using something like ```direnv``` (recommended).

  Cc: @c0bw3b 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sile: leverage lua environments
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62760
updated_at: 2019-06-09 14:09:26
body:
  ###### Motivation for this change
  allows to simplify the implementation quite a bit

  ###### Things done

   leverage lua environments

  the package has no maintainer to ping :'(

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: keychain: Add long description
user_login: chreekat
html_url: https://github.com/NixOS/nixpkgs/pull/62761
updated_at: 2019-06-07 17:34:38
body:
  Copied from the project home page today.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Long description was missing.

  ###### Things done

  - [x] Ran `nix-build -A keychain` successfully


state: open
title: vis: leverage lua environments
user_login: teto
html_url: https://github.com/NixOS/nixpkgs/pull/62762
updated_at: 2019-06-06 07:59:10
body:
  simplify implementation but doesn't work; e.g., vis can't detect lpeg

  Haven't looked into it much but does it use the correct lua ? How is vis looking for lpeg ?

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: zfs: 0.7.13 -> 0.8.0
user_login: Mic92
html_url: https://github.com/NixOS/nixpkgs/pull/62763
updated_at: 2019-06-07 10:15:42
body:
  Same as zfsUnstable for the moment.
  We still keep the zfsUnstable expression as we likely
  need it in the near future again.
  Also remove spl since it is no longer needed.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: moonlight-embedded: 2.4.9 -> 2.4.10
user_login: uvNikita
html_url: https://github.com/NixOS/nixpkgs/pull/62764
updated_at: 2019-06-06 09:43:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  From the relese [changelog](https://github.com/irtimmer/moonlight-embedded/releases/tag/v2.4.10):

  > Bugfix release to support GFE 3.19

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Cassandra: Argument list too long
user_login: turion
html_url: https://github.com/NixOS/nixpkgs/issues/62765
updated_at: 2019-07-22 07:49:14
body:
  ## Issue description

  `services.cassandra.enable = true;` is unusable because of the dreaded `Argument list too long` error.

  ### Steps to reproduce

  Create a container with this config:

  ```
  { ... }: {
    services.cassandra.enable = true;
  }
  ```
  Log into the container.

  ```
  [root@cassandra:~]# journalctl | grep Argument
  Jun 06 09:22:07 cassandra cassandra[334]: /nix/store/97gl5mlbfj91n1b64bp5lngnp8cig13n-cassandra-3.11.3/bin/cassandra: line 5: /nix/store/97gl5mlbfj91n1b64bp5lngnp8cig13n-cassandra-3.11.3/bin/cassandra: Argument list too long
  [root@cassandra:~]# systemctl status cassandra
  ● cassandra.service - Apache Cassandra service
     Loaded: loaded (/nix/store/rj2jv6p04ma9qgm592sa9h2xfiqyfyjf-unit-cassandra.service/cassandra.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Thu 2019-06-06 09:22:07 UTC; 6min ago
    Process: 334 ExecStart=/nix/store/97gl5mlbfj91n1b64bp5lngnp8cig13n-cassandra-3.11.3/bin/cassandra -f (code=exited, status=126)
   Main PID: 334 (code=exited, status=126)

  Jun 06 09:22:06 cassandra systemd[1]: Started Apache Cassandra service.
  Jun 06 09:22:07 cassandra systemd[1]: cassandra.service: Main process exited, code=exited, status=126/n/a
  Jun 06 09:22:07 cassandra systemd[1]: cassandra.service: Failed with result 'exit-code'.
  ```

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.45, NixOS, 19.09pre180832.c7bcd4277cc (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre180832.c7bcd4277cc, musnix"`
   - channels(turion): `"nixos-19.03-19.03.172729.0ab85f4d872, nixos-unstable-newer-19.09pre180443.4dd5c93998d"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: open
user_login: arianvp
html_url: https://github.com/NixOS/nixpkgs/issues/62766
updated_at: 2019-06-12 17:19:59
title:
  systemd: systemd-journal-gatewayd.socket exists but is invalid when systemd.enableHttpGateway = false

body:
  ## Issue description
  We load an invalid unit when `enableHttpGateway  = false`

  The cause:

  1. We do not include the upstream unit when it is disabled (https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/system/boot/systemd.nix#L162)

  2. This line creates an empty unit when `enableHttpGateway` is false.  This should be fine _if_ the upstream unit exist, as we will generate an empty **override** unit, but because the upstream unit doesn't exist when `enableHttpGateway = false` we create a **new** empty unit which has invalid contents, instead of overriding an existing unit with no new information

  ## Potential Fix

  Two options:

  1.  Always include the upstream unit, but only have the optional `wantedBy = "sockets.target`  <-- I prefer this one

  2.  Bubble up the conditional, such that we do not create an empty `systemd-journal-gatewayd` unit:

  ```
  systemd.sockets = mkIf (enaleHttpGateway) { sockets.systemd-journal-gatewayd.wantedBy = "sockets.target"; }
  ```


  ### Steps to reproduce

  ```
  [arian@t430s:/var/lib/machines/nginx/etc]$ systemctl status systemd-journal-gatewayd.socket 
  ● systemd-journal-gatewayd.socket
     Loaded: bad-setting (Reason: Unit systemd-journal-gatewayd.socket has a bad unit file setting.)
     Active: inactive (dead)

  Jun 06 12:10:45 t430s systemd[1]: systemd-journal-gatewayd.socket: Unit has no Listen setting (ListenStream=, ListenDatagram=, ListenFIFO=, ...). Refusing.

  [arian@t430s:/var/lib/machines/nginx/etc]$ systemctl cat systemd-journal-gatewayd.socket 
  # /nix/store/kjdfr6g1yzwrhql726hiaghab4lwhwjb-unit-systemd-journal-gatewayd.socket/systemd-journal-gatewayd.socket
  [Unit]

  [Socket]


  ```


  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: grafana: 6.2.1 -> 6.2.2 (security update)
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/62767
updated_at: 2019-06-06 11:00:38
body:
  ###### Motivation for this change
  [Latest patch release](https://github.com/grafana/grafana/releases/tag/v6.2.2) that includes a few bug fixes and a [security fix](https://github.com/grafana/grafana/pull/17363).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS (x86_64-linux & aarch64-linux)
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  **needs to be backported to 19.03**

  /cc @samueldr @lheckemann 


state: closed
title: erlangR21: 21.2.3 -> 21.3.7.1
user_login: ehamberg
html_url: https://github.com/NixOS/nixpkgs/pull/62768
updated_at: 2019-06-19 22:10:06
body:
  ###### Motivation for this change

  Update Erlang/OTP 21 to the latest version.

  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sngrep: init at 1.4.6
user_login: JorisE
html_url: https://github.com/NixOS/nixpkgs/pull/62769
updated_at: 2019-07-14 00:06:44
body:
  Sngrep is used to inspect SIP traffic.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gallery-dl: 1.8.4 -> 1.8.5
user_login: dawidsowa
html_url: https://github.com/NixOS/nixpkgs/pull/62770
updated_at: 2019-06-09 10:37:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updated gallery-dl to [1.8.5](https://github.com/mikf/gallery-dl/releases/tag/v1.8.5)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mpd: 0.20.23 -> 0.21.10 + nixos module support for standard users
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62771
updated_at: 2019-06-06 20:45:03
body:
  ###### Motivation for this change

  Lots of new upstream activity.

  Upstream is now using meson instead of autotools, so that's what we will use too.

  There was a lot of redundant logic in order to deal with optional features (managing both flags and build inputs), so we now just add everything to buildinputs but use the flags to determine what is built in. If a dependency is not used, we don't have a reference to it either.

  The nixos module now allows running mpd in a normal systemd user session (default is still system-wide) and we use the unit files from upstream instead of duplicating them.

  Running fine here.

  Cc: @astsmtl @fuuzetsu @ehmry @fpletz

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/tests/docker-tools: check layer sharing with buildLayeredImage
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/62773
updated_at: 2019-06-08 07:17:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This adds a test that verifies that `buildLayeredImage` leads to shared layers. The test should always succeed, since at least a layer containing the `glibc` leaf is shared between the images. The test succeeds with #62719, but fails before that PR.

  Adapted from grahamc's blog post on layered Docker images in Nix:

  https://grahamc.com/blog/nix-and-layered-docker-images

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 1password: 0.5.5 -> 0.5.6
user_login: kevingriffin
html_url: https://github.com/NixOS/nixpkgs/pull/62774
updated_at: 2019-06-07 08:38:18
body:
  A list of builds of 1Password's CLI tool can be found at https://app-updates.agilebits.com/product_history/CLI

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: erlang/generic-builder.nix doesn't work for Erlang/OTP 22
user_login: ehamberg
html_url: https://github.com/NixOS/nixpkgs/issues/62775
updated_at: 2019-06-18 16:17:30
body:
  While attempting to add Erlang/OTP 22 to nixpkgs, I had to remove `autoreconfHook` and add `autoconf` to `erlang/generic-builder.nix` to get it to build.

  Unfortunately I don't know enough about nix in order to say how support for Erlang/OTP 22 best should be handled. I have attached the patch that led to a successful build of `erlangR22`, but this will probably breaks other versions, since it modifies `erlang/generic-builder.nix`.

  I would be happy to get suggestions on how to proceed – or have someone else with more nix knowledge finish this work. :)

  ```diff
  diff --git a/pkgs/development/interpreters/erlang/R22.nix b/pkgs/development/interpreters/erlang/R22.nix
  new file mode 100644
  index 00000000000..40290afd2d8
  --- /dev/null
  +++ b/pkgs/development/interpreters/erlang/R22.nix
  @@ -0,0 +1,6 @@
  +{ mkDerivation }:
  +
  +mkDerivation rec {
  +  version = "22.0.2";
  +  sha256 = "0i0agp8jxldihym7klwwarpg3i61l9924mjwvx0am4w6k136dd5b";
  +}
  diff --git a/pkgs/development/interpreters/erlang/generic-builder.nix b/pkgs/development/interpreters/erlang/generic-builder.nix
  index bc0b728ecce..914c3a0f5cf 100644
  --- a/pkgs/development/interpreters/erlang/generic-builder.nix
  +++ b/pkgs/development/interpreters/erlang/generic-builder.nix
  @@ -1,5 +1,5 @@
   { pkgs, stdenv, fetchFromGitHub, makeWrapper, gawk, gnum4, gnused
  -, libxml2, libxslt, ncurses, openssl, perl, autoreconfHook
  +, libxml2, libxslt, ncurses, openssl, perl, autoconf
   , openjdk ? null # javacSupport
   , unixODBC ? null # odbcSupport
   , libGLU_combined ? null, wxGTK ? null, wxmac ? null, xorg ? null # wxSupport
  @@ -48,7 +48,7 @@ in stdenv.mkDerivation ({

     inherit src version;

  -  nativeBuildInputs = [ autoreconfHook makeWrapper perl gnum4 libxslt libxml2 ];
  +  nativeBuildInputs = [ autoconf makeWrapper perl gnum4 libxslt libxml2 ];

     buildInputs = [ ncurses openssl ]
       ++ optionals wxSupport wxPackages2
  diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
  index 04e880d9f10..70f1eec76c6 100644
  --- a/pkgs/top-level/all-packages.nix
  +++ b/pkgs/top-level/all-packages.nix
  @@ -8205,7 +8205,7 @@ in
     beam = callPackage ./beam-packages.nix { };

     inherit (beam.interpreters)
  -    erlang erlangR18 erlangR19 erlangR20 erlangR21
  +    erlang erlangR18 erlangR19 erlangR20 erlangR21 erlangR22
       erlang_odbc erlang_javac erlang_odbc_javac erlang_nox erlang_basho_R16B02
       elixir elixir_1_8 elixir_1_7 elixir_1_6 elixir_1_5 elixir_1_4
       lfe lfe_1_2;
  diff --git a/pkgs/top-level/beam-packages.nix b/pkgs/top-level/beam-packages.nix
  index f05cf3d9290..70a21c830f5 100644
  --- a/pkgs/top-level/beam-packages.nix
  +++ b/pkgs/top-level/beam-packages.nix
  @@ -50,6 +50,15 @@ rec {
         javacSupport = true; odbcSupport = true;
       };
       erlangR21_nox = erlangR21.override { wxSupport = false; };
  +    erlangR22 = lib.callErlang ../development/interpreters/erlang/R22.nix {
  +      wxGTK = wxGTK30;
  +    };
  +    erlangR22_odbc = erlangR22.override { odbcSupport = true; };
  +    erlangR22_javac = erlangR22.override { javacSupport = true; };
  +    erlangR22_odbc_javac = erlangR22.override {
  +      javacSupport = true; odbcSupport = true;
  +    };
  +    erlangR22_nox = erlangR22.override { wxSupport = false; };

       # Basho fork, using custom builder.
       erlang_basho_R16B02 = lib.callErlang ../development/interpreters/erlang/R16B02-basho.nix {
  @@ -79,6 +88,7 @@ rec {
       erlangR19 = packagesWith interpreters.erlangR19;
       erlangR20 = packagesWith interpreters.erlangR20;
       erlangR21 = packagesWith interpreters.erlangR21;
  +    erlangR22 = packagesWith interpreters.erlangR22;

     };
   }
  ```


state: closed
title: mariadb: fix clang and darwin build
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/62777
updated_at: 2019-06-06 16:07:53
body:
  The contents of `clang-isfinite.patch` are no longer necessary after
  upstream revision 031fa6d4258574379ca3c1cbe912d235e9581982, which
  includes a similar change.

  Building in c++11 mode removes support for the GCC `typeof` extension
  in favor of the standardized `__typeof__`. This causes errors when
  using the `strmake_buf` macro, which relies on `typeof`.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Emacs Lucid segfaults when making a window
user_login: Warbo
html_url: https://github.com/NixOS/nixpkgs/issues/62778
updated_at: 2019-06-06 15:58:52
body:
  ## Issue description

  I use the Lucid build of Emacs, due to the long-standing X-reconnecting bug in GTK. I do this with `emacs.override { withGTK2 = false; withGTK3 = false; }` and this has been working fine for years.

  After upgrading to NixOS 19.03 I can no longer run Emacs graphically, since it segfaults when trying to create a window. I can use `emacs -nw` to run the console version, and that's fine. I'm currently pinning the version from 18.09, since that works fine.

  ### Steps to reproduce

  I can reproduce the crash with the following command, running in an Xorg display (I also tried it in Xvfb and it crashes there too):

  ```
  $ nix-shell -p gdb -p '(emacs.override { withGTK2 = false; withGTK3 = false; })' --run 'gdb emacs'
  GNU gdb (GDB) 8.2.1
  Copyright (C) 2018 Free Software Foundation, Inc.
  License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
  This is free software: you are free to change and redistribute it.
  There is NO WARRANTY, to the extent permitted by law.
  Type "show copying" and "show warranty" for details.
  This GDB was configured as "i686-unknown-linux-gnu".
  Type "show configuration" for configuration details.
  For bug reporting instructions, please see:
  <http://www.gnu.org/software/gdb/bugs/>.
  Find the GDB manual and other documentation resources online at:
      <http://www.gnu.org/software/gdb/documentation/>.

  For help, type "help".
  Type "apropos word" to search for commands related to "word"...
  Reading symbols from emacs...
  warning: Loadable section ".dynstr" outside of ELF segments
  (no debugging symbols found)...done.
  (gdb) run
  Starting program: /nix/store/kmpm8r6r2pyv3ikshi84gwk360bw6djg-emacs-26.1/bin/emacs 
  [Thread debugging using libthread_db enabled]
  Using host libthread_db library "/nix/store/sjsvwd9sqxjflmslnf8xs48aqpkb2sjy-glibc-2.27/lib/libthread_db.so.1".
  [New Thread 0xb58b2b40 (LWP 20885)]

  (process:20765): GLib-GIO-CRITICAL **: 16:52:09.947: g_settings_schema_source_lookup: assertion 'source != NULL' failed

  Thread 1 "emacs" received signal SIGSEGV, Segmentation fault.
  0xb7be923a in XrmPermStringToQuark ()
     from /nix/store/40j5z6dyc75ibgmagm50r1mb2v9yaykh-libX11-1.6.7/lib/libX11.so.6
  (gdb) backtrace
  #0  0xb7be923a in XrmPermStringToQuark ()
     from /nix/store/40j5z6dyc75ibgmagm50r1mb2v9yaykh-libX11-1.6.7/lib/libX11.so.6
  #1  0xb7d79344 in _XtCompileResourceList ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #2  0xb7d75017 in ObjectClassPartInitialize ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #3  0xb7d61b59 in CallClassPartInit.isra.0 ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #4  0xb7d61b72 in CallClassPartInit.isra.0 ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #5  0xb7d61b72 in CallClassPartInit.isra.0 ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #6  0xb7d61b72 in CallClassPartInit.isra.0 ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #7  0xb7d61b72 in CallClassPartInit.isra.0 ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #8  0xb7d61d75 in XtInitializeWidgetClass ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #9  0xb7d627d1 in _XtCreateWidget ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #10 0xb7d62a2a in XtCreateWidget ()
     from /nix/store/b7nm37ln9cycd6dr3skf6lr1blsvcadc-libXt-1.1.5/lib/libXt.so.6
  #11 0x081194fa in x_window ()
  #12 0x0811a6c6 in Fx_create_frame ()
  #13 0x081a4624 in Ffuncall ()
  #14 0x081dff30 in exec_byte_code ()
  #15 0x081a6c7e in funcall_lambda ()
  #16 0x081a459c in Ffuncall ()
  #17 0x081dff30 in exec_byte_code ()
  #18 0x081a6c7e in funcall_lambda ()
  #19 0x081a459c in Ffuncall ()
  #20 0x081a636c in Fapply ()
  #21 0x081a4624 in Ffuncall ()
  #22 0x081dff30 in exec_byte_code ()
  #23 0x081a6c7e in funcall_lambda ()
  #24 0x081a459c in Ffuncall ()
  #25 0x081dff30 in exec_byte_code ()
  #26 0x081a6c7e in funcall_lambda ()
  #27 0x081a459c in Ffuncall ()
  #28 0x081dff30 in exec_byte_code ()
  #29 0x081a6c7e in funcall_lambda ()
  #30 0x081a459c in Ffuncall ()
  #31 0x081dff30 in exec_byte_code ()
  #32 0x081a6c7e in funcall_lambda ()
  #33 0x081a459c in Ffuncall ()
  #34 0x081dff30 in exec_byte_code ()
  #35 0x081a6c7e in funcall_lambda ()
  #36 0x081a70b9 in apply_lambda ()
  #37 0x081a6717 in eval_sub ()
  #38 0x081a8681 in Feval ()
  #39 0x0812ed72 in top_level_2 ()
  #40 0x081a37cc in internal_condition_case ()
  #41 0x08130223 in top_level_1 ()
  #42 0x081a3716 in internal_catch ()
  #43 0x0812eca4 in command_loop ()
  #44 0x081320a9 in recursive_edit_1 ()
  #45 0x081323f4 in Frecursive_edit ()
  #46 0x08059905 in main ()
  ```

  ## Technical details

  ```
  $ nix-shell -p nix-info --run "nix-info -m"
   - system: `"i686-linux"`
   - host os: `Linux 4.9.52, NixOS, 19.03.172786.606306e0eaa (Koi)`
   - multi-user?: `yes`
   - sandbox: `relaxed`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172786.606306e0eaa"`
   - channels(chris): `"nixos-17.09.2875.c2b668ee726"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```


state: closed
title: Restart declarative containers when their host environment configuration changes
user_login: grahamc
html_url: https://github.com/NixOS/nixpkgs/pull/62779
updated_at: 2019-06-06 16:57:51
body:
  ###### Motivation for this change

  Changing network interfaces or bind mounts on NixOS containers requires a full restart of the container. However, with the prior version, this relationship was not properly represented and only a `reload` would occur:

  ```
  ogden.......> reloading the following units: container@buildkite-builder-grahamc-1.service, container@buildkite-builder-grahamc-10.service, container@buildkite-builder-grahamc-2.service, container@buildkite-builder-grahamc-3.service, container@buildkite-builder-grahamc-4.service, container@buildkite-builder-grahamc-5.service, container@buildkite-builder-grahamc-6.service, container@buildkite-builder-grahamc-7.service, container@buildkite-builder-grahamc-8.service, container@buildkite-builder-grahamc-9.service, dbus.service
  ```

  This is not sufficient and doesn't completely update the container.

  After this change, it properly starts and stops the container when the bind mounts change:

  ```
  ogden.......> updating GRUB 2 menu...
  ogden.......> stopping the following units: container@buildkite-builder-grahamc-1.service, container@buildkite-builder-grahamc-10.service, container@buildkite-builder-grahamc-2.service, container@buildkite-builder-grahamc-3.service, container@buildkite-builder-grahamc-4.service, container@buildkite-builder-grahamc-5.service, container@buildkite-builder-grahamc-6.service, container@buildkite-builder-grahamc-7.service, container@buildkite-builder-grahamc-8.service, container@buildkite-builder-grahamc-9.service
  ogden.......> activating the configuration...
  ogden.......> setting up /etc...
  ogden.......> reloading user units for root...
  ogden.......> reloading user units for grahamc...
  ogden.......> setting up tmpfiles
  ogden.......> starting the following units: container@buildkite-builder-grahamc-1.service, container@buildkite-builder-grahamc-10.service, container@buildkite-builder-grahamc-2.service, container@buildkite-builder-grahamc-3.service, container@buildkite-builder-grahamc-4.service, container@buildkite-builder-grahamc-5.service, container@buildkite-builder-grahamc-6.service, container@buildkite-builder-grahamc-7.service, container@buildkite-builder-grahamc-8.service, container@buildkite-builder-grahamc-9.service
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Test results:

  ```
  $ nix-build ./nixos/tests/containers*; echo $?
  /nix/store/rkjnxm7qkd8yx7drjprl5hc4bbipkqzp-vm-test-run-containers-bridge
  /nix/store/y4q6ffsf21gi452wv90a713ac8khmfcf-vm-test-run-containers-bridge
  /nix/store/3kf7f6574dk4d6ph2pzgv0i4090h0vjq-vm-test-run-containers-hosts
  /nix/store/mcxwmk3na4mjw2a4a54f63jfkfxwh9dx-vm-test-run-containers-imperative
  /nix/store/y738p0y84v98qm49l6pi90z8fj87i47z-vm-test-run-containers-ipv4
  /nix/store/ishfl5njzdpxkql11dvs8ha904wlcz3f-vm-test-run-containers-ipv6
  /nix/store/hfwdd79brbdp0w449lhy44ibxlh9brhz-vm-test-run-containers-macvlans
  /nix/store/yigbf08mza360l668ambakmx6lndlnnk-vm-test-run-containers-physical_interfaces
  /nix/store/fwy1mdh0sfkh0887pc2q3bh92f6k8n1b-vm-test-run-containers-portforward
  /nix/store/aaiv2vzsiz6bpvrg1n53ngj4x224pz8d-vm-test-run-cotnainers-reloadable
  /nix/store/ak44x378g17z6v19a8maph77qqwi9mqh-vm-test-run-containers-restart_networking
  /nix/store/c8g5v6j335mkjiygch1f8i281wmqhxnh-vm-test-run-containers-tmpfs
  ```


state: closed
title: Add mystem package
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/62780
updated_at: 2019-06-06 18:36:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Morphological analysis of Russian text.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.tables: 3.4.4 -> 3.5.2
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/62781
updated_at: 2019-06-15 09:00:20
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update pytables. Fixes, for instance, the following annoying bug: https://github.com/pandas-dev/pandas/issues/24839

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sigrok suite: enable for darwin
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62782
updated_at: 2019-06-07 08:06:01
body:
  ###### Motivation for this change
  Out of curiosity I decided to see if the sigrok suite worked on darwin, and it does appear to from basic inspection.

  Now, I don't actually have any sigrok-compatible hardware on me, so obviously wasn't able to test the full functionality, but the cli is able to find the "dummy" devices and find all its protocol decoders.

  Tested on macos 10.13.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: php: update build config and php package
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62783
updated_at: 2019-06-12 11:16:48
body:
  ###### Motivation for this change
  With enable apxs2Support php automatic buildinfg with --enable-maintainer-zts
  Enable build phpPackages with re2c.
  ```
  checking for re2c... no
  configure: WARNING: You will need re2c 0.13.4 or later if you want to regenerate PHP parsers.
  ```
  Remove options valgrindPcreSupport. This options not used with external PCRE
  ```
  configure: WARNING: PHP is going to be linked with an external PCRE, --with-pcre-valgrind has no effect
  ```
  Update buyild config. Packages autoconf, bison, flex, libtool, pkgconfig, re2c need only build php - https://www.php.net/manual/en/install.unix.php
  ```
  When building directly from Git sources or after custom modifications you might also need:

  autoconf: 2.13+ (for PHP < 5.4.0), 2.59+ (for PHP >= 5.4.0), 2.64+ (for PHP >= 7.2.0)
  automake: 1.4+
  libtool: 1.4.x+ (except 1.4.2)
  re2c: Version 0.13.4 or newer
  flex: Version 2.5.4 (for PHP <= 5.2)
  bison:
  PHP 5.4: 1.28, 1.35, 1.75, 1.875, 2.0, 2.1, 2.2, 2.3, 2.4, 2.4.1, 2.4.2, 2.4.3, 2.5, 2.5.1, 2.6, 2.6.1, 2.6.2, 2.6.4
  PHP 5.5: 2.4, 2.4.1, 2.4.2, 2.4.3, 2.5, 2.5.1, 2.6, 2.6.1, 2.6.2, 2.6.3, 2.6.4, 2.6.5, 2.7
  PHP 5.6: >= 2.4, < 3.0
  PHP 7.0 - 7.3: 2.4 or later (including Bison 3.x)
  PHP 7.4: > 3.0
  ```
  Update phpPackage event to 2.5.2

  cc @etu 
  ###### Things done
  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Emacs packages update: 2019-06-06
user_login: rasendubi
html_url: https://github.com/NixOS/nixpkgs/pull/62784
updated_at: 2019-06-11 20:06:40
body:
  ###### Motivation for this change
  Update elpa-packages, melpa-packages, melpa-stable-packages.

  Checked with nix-instantiate. Going to test with my emacs setup tomorrow.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @peti 


state: closed
title: helmfile: 0.64.1 -> 0.73.0
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/62786
updated_at: 2019-06-07 06:35:08
body:
  ###### Motivation for this change

  Update to newer version, notably for https://github.com/roboll/helmfile/pull/648.
  Also, ditch [vgo2nix](https://github.com/adisbladis/vgo2nix) in favor of [`buildGoModule`](https://nixos.org/nixpkgs/manual/#ssec-go-modules), which works better for me anyway.


  ###### Things done

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: vimPlugins.semshi: init at 2018-12-05
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62787
updated_at: 2019-07-09 07:11:12
body:
  ###### Motivation for this change
  Add nice python QoL neovim plugin. It's semantically aware so it's a bit smarter about highlighting than just a regex based syntax highlighter.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh /nix/store/70c3jm94h20wdp8lyl8dbr2gqm0986gr-vimplugin-semshi-2018-12-05
  /nix/store/70c3jm94h20wdp8lyl8dbr2gqm0986gr-vimplugin-semshi-2018-12-05  117.3K


state: closed
title: pythonPackages.asttokens: fix python3 build
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62788
updated_at: 2019-06-07 06:02:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  cc: @vbgl 
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vimPlugins.vim-csharp: init at 2017-03-29
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62789
updated_at: 2019-06-07 04:46:34
body:
  ###### Motivation for this change
  Better csharp highlighting.

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh /nix/store/hs40lkg1vjcb9b7sds345lysal4rmkw0-vimplugin-vim-csharp-2017-03-29
  /nix/store/hs40lkg1vjcb9b7sds345lysal4rmkw0-vimplugin-vim-csharp-2017-03-29      306.3K


state: closed
title: vimPlugins.SpaceCamp: init at 2019-06-05
user_login: jonringer
html_url: https://github.com/NixOS/nixpkgs/pull/62791
updated_at: 2019-06-07 04:46:43
body:
  ###### Motivation for this change
  Add another colorscheme. :)

  ###### Things done

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [X] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  $ nix path-info -Sh /nix/store/ssiq01sv58fg8fps341n3fw7hn29vcr1-vimplugin-SpaceCamp-2019-06-05
  /nix/store/ssiq01sv58fg8fps341n3fw7hn29vcr1-vimplugin-SpaceCamp-2019-06-05         1.1M


state: closed
title: postgresqlPackages.pgroonga: 2.1.9 -> 2.2.0
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62792
updated_at: 2019-06-09 16:00:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: librime: 1.4.0 -> 1.5.0
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62793
updated_at: 2019-06-07 18:13:11
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `librime` to the latest release.
  https://github.com/rime/librime/releases/tag/1.5.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: public-sans: 1.004 -> 1.005
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62794
updated_at: 2019-06-07 04:35:31
body:
  ###### Motivation for this change

  https://github.com/uswds/public-sans/releases/tag/v1.005

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: grim: 1.1 -> 1.2.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62796
updated_at: 2019-06-09 18:56:36
body:
  ###### Motivation for this change

  https://github.com/emersion/grim/releases/tag/v1.2.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dnscrypt-proxy2: 2.0.22 -> 2.0.25
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62797
updated_at: 2019-06-07 14:30:41
body:
  ###### Motivation for this change

  https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.25
  https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.24
  https://github.com/jedisct1/dnscrypt-proxy/releases/tag/2.0.23

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gnumeric: 1.12.44 -> 1.12.45
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62798
updated_at: 2019-06-20 06:16:44
body:
  ###### Motivation for this change

  http://www.gnumeric.org/announcements/1.12/gnumeric-1.12.45.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pyotherside: 1.5.5 -> 1.5.6
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62799
updated_at: 2019-06-09 19:01:44
body:
  ###### Motivation for this change

  https://github.com/thp/pyotherside/releases/tag/1.5.6

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: ubootRock64, ubootRockPro64: update
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/62800
updated_at: 2019-06-07 22:43:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  This PR updates the Rock64 and RockPro64 U-Boot to the latest commit in ayufan's repo, which fixes some minor issues. I also updated the binary blobs from rkbin. Lastly, I used `extraPatches` instead of `patches` to avoid overriding the patches specified in `buildUBoot`.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: python3Packages.pywebpush: init at 1.9.4
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62801
updated_at: 2019-06-20 09:30:21
body:
  ###### Motivation for this change

  These 3 packages were needed for html5 notifications to work in HA.

  Needs proper testing.

  Cc: @dotlambda 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: tor-browser-bundle: 8.5 -> 8.5.1, security fix!
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62803
updated_at: 2019-06-08 07:58:44
body:
  ###### Motivation for this change

  I think the source variant needs special handling, sorry.

  https://blog.torproject.org/new-release-tor-browser-851

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libevdev: 1.6.0 -> 1.7.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62804
updated_at: 2019-07-17 08:53:52
body:
  ###### Motivation for this change

  https://lists.freedesktop.org/archives/input-tools/2019-June/001512.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: mtdutils: 1.5.2 -> 2.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62805
updated_at: 2019-06-07 08:57:11
body:
  ###### Motivation for this change

  http://lists.infradead.org/pipermail/linux-mtd/2019-March/088267.html

  And the previous releases, hardcoded version in URL I think caused
  this to be missed by auto-updaters for a while now.

  1.5.2, FWIW in 2015:

  http://lists.infradead.org/pipermail/linux-mtd/2015-August/060723.html

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: krita: 4.2.0 -> 4.2.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62806
updated_at: 2019-06-07 14:50:22
body:
  ###### Motivation for this change

  https://cgit.kde.org/krita.git/log/?h=v4.2.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: goxel: 0.8.3 -> 0.9.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62807
updated_at: 2019-06-09 06:11:29
body:
  ###### Motivation for this change

  https://github.com/guillaumechereau/goxel/releases/tag/v0.9.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: minder: init at 1.3.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62808
updated_at: 2019-06-07 08:10:24
body:
  ###### Motivation for this change

  Mind-mapping application for Elementary OS!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: xkeyboardconfig: 2.24 -> 2.27
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62811
updated_at: 2019-07-03 06:52:52
body:
  ###### Motivation for this change

  https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/tags/xkeyboard-config-2.27

  (and intermediate releases)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: bloop: 1.2.5 -> 1.3.2
user_login: Tomahna
html_url: https://github.com/NixOS/nixpkgs/pull/62812
updated_at: 2019-07-18 19:58:38
body:
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/systemd: enable systemd-tmpfiles-setup and -clean for user sessions
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/pull/62813
updated_at: 2019-06-20 09:30:04
body:
  ###### Motivation for this change

  We currently have support for system tmpfiles but not the user equivalents. This PR only enables the units so you can stick files in ```~/.config/user-tmpfiles.d``` and have them work as expected. 

  A next step would be to:
  1. create ```systemd.user.tmpfiles.rules``` similar to ```systemd.tmpfiles.rules```
  2. patch systemd to look into ```/etc/user-tmpfiles.d``` instead of ```/usr/share/user-tmpfiles.d```
  3. write out ```systemd.user.tmpfiles.rules```

  Cc: @Infinisil @fpletz 

  Works fine here with files in ~/.config/user-tmpfiles.d

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: basic.target reached before home directory is mounted with dm-crypt
user_login: peterhoeg
html_url: https://github.com/NixOS/nixpkgs/issues/62814
updated_at: 2019-06-07 07:25:08
body:
  ## Issue description

  Similar to #12281 but not quite.

  Assume you have something that runs before ```basic.target``` but requires files from $HOME which is mounted during login from a dm-crypt volume (example: systemd-tmpfiles-setup from #62813).

  The problem is that ```basic.target``` is reached *before* $HOME is mounted and thus before the configuration files are available.

  ### Steps to reproduce

  1. Apply #62813 
  2. Have a machine with $HOME mounted using pam-mount during login from a dm-crypt volume
  3. Stick the following into ```$HOME/.config/user-tmpfiles.d/test.conf```: ```d %t/test 0700 - - - -```
  4. Log in
  5. Notice how ```systemd-tmpfiles-setup.service``` was run but ```/run/user/$(id -u)/test``` is missing
  6. Manually try running ```systemd-tmpfiles --user --create --remove --boot```
  7. Notice how ```/run/user/$(id -u)/test``` is now present

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.6, NixOS, 19.09.git.aa42aca8104M (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`


state: closed
title: weechat: 2.4 -> 2.5
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/62815
updated_at: 2019-06-07 16:31:18
body:
  ###### Motivation for this change

  Changelog [1]:

    New features
      - core: use getopt to parse command line arguments
      - core: add option weechat.look.prefix_same_nick_middle
      - core: add option weechat.look.buffer_time_same
      - core: use seconds by default in /repeat interval, allow unit for the interval
      - core: allow text in addition to a command in command /repeat
      - core: add option "addreplace" in command /filter
      - api: return allocated string in hook_info callback and function info_get
      - api: replace argument "keep_eol" by "flags" in function string_split
      - api: add function command_options
      - api: add function string_match_list
      - irc: add bar items "irc_nick", "irc_host" and "irc_nick_host"
      - irc: add variable "host" in server structure
      - relay: add support of UNIX socket
      - relay: add option relay.weechat.commands
      - script: use SHA-512 instead of MD5 for script checksum
      - spell: rename aspell plugin to spell
      - trigger: add hooks "info" and "info_hashtable"
      - xfer: rename option xfer.network.speed_limit to xfer.network.speed_limit_send, add option xfer.network.speed_limit_recv

    Bug fixes
      - core: don’t execute command scheduled by /repeat and /wait if the buffer does not exist any more
      - core: set max length to 4096 for /secure passphrase
      - core: refilter only affected buffers on filter change
      - fset: fix slow refresh of fset buffer during /reload
      - irc: fix parsing of MODE command when there are colons after the first mode argument
      - irc: fix memory leak in infos "irc_server_isupport" and "irc_server_isupport_value"
      - irc: fix length of string for SHA-512, SHA-256 and SHA-1 in help on ssl_fingerprint option
      - irc: display an error with /allchan -current or /allpv -current if the current buffer is not an irc buffer
      - irc: fix update of channels modes with arguments when joining a channel
      - irc: quote NICK command argument sent to the server
      - php: fix memory leak in functions string_eval_expression, string_eval_path_home, key_bind, hook_process_hashtable, hook_hsignal_send, info_get_hashtable, hdata_update
      - relay: fix crash when a weechat relay client reloads the relay plugin with /plugin reload relay
      - spell: fix detection of nick followed by the nick completer
      - trigger: fix split of hook arguments

    Tests
      - unit: add tests on function util_signal_search

    Build
      - core: fix value of libdir in file weechat.pc
      - core: fix generation of man page weechat-headless with autotools
      - core: add CMake option "ENABLE_CODE_COVERAGE" to compile with code coverage options (CMake ≥ 3.0 is now required)
      - core: fix compilation on Mac OS 
      - lua: add detection of Lua 5.3 with autotools
      - ruby: add detection of Ruby 2.6
      - tests: fix compilation of tests on FreeBSD

  [1] https://weechat.org/files/changelog/ChangeLog-2.5.html#v2.5

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.14.2 -> 1.14.3 (CVE-2019-11245)
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/62816
updated_at: 2019-06-16 21:15:59
body:
  ###### Motivation for this change
  To fix regression introduced in v1.14.2. Also referred to as: CVE-2019-11245
  See: https://github.com/kubernetes/kubernetes/issues/78308

  Tests run clean locally:
  ```
  $ nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode
  /nix/store/6ggrc2r43xbymxn424x0acmqvg467zh1-vm-test-run-kubernetes-rbac-singlenode
  /nix/store/qibnbw26dyvap65dxih84bgd0fbn7nw7-vm-test-run-kubernetes-rbac-multinode
  /nix/store/f5q27sqqkfxgnyzwgc2h2kdz83445yxp-vm-test-run-kubernetes-dns-singlenode
  /nix/store/a7zkprxpprjga8salr6bpjypaz827j99-vm-test-run-kubernetes-dns-multinode
  ```

  ping @srhb 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: WIP: improve support for crosscompiling to musl32
user_login: wfranzini
html_url: https://github.com/NixOS/nixpkgs/pull/62817
updated_at: 2019-07-17 08:53:25
body:
  ###### Motivation for this change

  Crosscompiling packages to musl32 lead to compilation errors due to the missing `__stack_chk_fail_local` symbol.  Even building nix fails. This PR disable stackprotector for musl32.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: kubernetes: 1.13.6 -> 1.13.7 (CVE-2019-11245)
user_login: johanot
html_url: https://github.com/NixOS/nixpkgs/pull/62818
updated_at: 2019-06-07 11:28:08
body:
  ###### Motivation for this change
  To fix regression introduced in v1.13.6. Also referred to as: CVE-2019-11245
  See: kubernetes/kubernetes#78308

  relates to #62816

  Tests run clean locally:
  ```
  $ nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode
  /nix/store/g557kf9qgzdy509f8ia50pkvql4g334w-vm-test-run-kubernetes-rbac-singlenode
  /nix/store/c6n4966w9cpfsaf1gqn4z9mb09laifiy-vm-test-run-kubernetes-rbac-multinode
  /nix/store/ww40jwpp8xdszy0ixcfa532wdjdlabjx-vm-test-run-kubernetes-dns-singlenode
  /nix/store/1sx28xlidwr9s86zwmbkz25qnhil1155-vm-test-run-kubernetes-dns-multinode
  ```

  ping @srhb 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Package/Service: Pleroma
user_login: matthiasbeyer
html_url: https://github.com/NixOS/nixpkgs/issues/62820
updated_at: 2019-07-03 18:48:44
body:
  ## Issue description

  (I think) We want a plemora package and service.

  This is the tracking issue.

  * (Relevant) Topics: elixir, postgres, 
  * URL: https://pleroma.social/


state: closed
title: jgmenu: 1.1 -> 3.0
user_login: romildo
html_url: https://github.com/NixOS/nixpkgs/pull/62821
updated_at: 2019-06-10 00:00:44
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update to [3.0](https://github.com/johanmalm/jgmenu/releases).


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Update terraform 0 12
user_login: Veske
html_url: https://github.com/NixOS/nixpkgs/pull/62822
updated_at: 2019-06-07 12:00:30
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Terraform 0.12 branch was using an alpha version in the darwin 19.03 channel while Hashicorp had already release stable 0.12 plus 0.12.1 to complement it.

  ###### Things done

  terraform_0_12: 0.12.0-alpha4 -> 0.12.1

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: 1password: 0.5.6 -> 0.5.6-003
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62823
updated_at: 2019-06-08 01:45:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  The downloads page list `0.5.6-003` as latest version

  from [1password team](https://discussions.agilebits.com/discussion/comment/504575/#Comment_504575):
  > For anyone wondering, the build is listed as 0.5.6-003, as we are testing some changes to our build process that will make things more flexible, this is expected :)


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Upgrading EC2 from 18.09 to 19.03 fails
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/62824
updated_at: 2019-06-17 12:27:17
body:
  ## Issue description

  I installed my 18.09 EC2 instance with the links that were in https://nixos.org/nixos/download.html in February. I added a bunch of stuff to `configuration.nix` and switched to `nixos-unstable` channel. Now, after a few months, I tried to upgrade from some February nixos-unstable commit to some June nixos-unstable commit. But I get the following error:

  ```
  $ nixos-rebuild switch
  .....
  ..... many many lines here .....
  .....
  updating GRUB 2 menu...
  installing the GRUB 2 boot loader on /dev/xvda...
  Installing for i386-pc platform.
  /nix/store/3a977zd2c6da1qkxfr7arpxfisvh0vrd-grub-2.04-rc1/sbin/grub-install: error: cannot find a GRUB drive for /dev/xvda.  Check your device.map.
  /nix/store/vb1gr0qmwayfdfmyy9wfd661z188v5mn-install-grub.pl: installation of GRUB on /dev/xvda failed
  warning: error(s) occurred while switching to the new configuration
  ```

  The machine doesn't have `/dev/xvda`. I couldn't figure out why this is now expected if it hasn't been expected in February. How should I upgrade my NixOS on this EC2 instance, any ideas?

  ### Steps to reproduce



  ## Technical details

  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.


state: closed
title: ocaml-ng.ocamlPackages_4_08.ocaml: 4.08.0+rc1 -> 4.08.0+rc2
user_login: vbgl
html_url: https://github.com/NixOS/nixpkgs/pull/62826
updated_at: 2019-06-14 06:53:40
body:
  ###### Motivation for this change

  Announcement: https://inbox.ocaml.org/caml-list/45D5CD8A-1E96-41C9-8116-CAFD1F7F233B@inria.fr/T/#u

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  @GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.ocaml


state: closed
title: syncthing: 1.1.3 -> 1.1.4
user_login: jabranham
html_url: https://github.com/NixOS/nixpkgs/pull/62827
updated_at: 2019-06-09 17:51:16
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  upstream release

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/wireguard: add peer service to interface dependencies
user_login: WilliButz
html_url: https://github.com/NixOS/nixpkgs/pull/62828
updated_at: 2019-06-09 11:48:13
body:
  ###### Motivation for this change
  Previously each oneshot peer service only ran once and was not
  restarted together with the interface unit. Because of this,
  defined peers were missing after restarting their corresponding
  interface unit.

  The issue should be easily reproducible:

  ```
  [root@nixos]# wg show wg0
  interface: wg0
    public key: <pubkey>
    private key: (hidden)
    listening port: 12345

  peer: <peer-pubkey>
    endpoint: <endpoint>
    allowed ips: <allowed-ips>
    latest handshake: 1 second ago
    transfer: 2.25 KiB received, 708 B sent

  [root@nixos]# systemctl stop wireguard-wg0.service

  [root@nixos]# systemctl start wireguard-wg0.service

  [root@nixos]# wg show wg0
  interface: wg0
    public key: <pubkey>
    private key: (hidden)
    listening port: 12345
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---
  /cc @grahamc @fpletz 


state: closed
title: terraform: 0.12.0 -> 0.12.1
user_login: Veske
html_url: https://github.com/NixOS/nixpkgs/pull/62829
updated_at: 2019-06-09 01:11:24
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/hashicorp/terraform/releases/tag/v0.12.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: aerc: init at 0.1.0
user_login: tadeokondrak
html_url: https://github.com/NixOS/nixpkgs/pull/62830
updated_at: 2019-06-08 03:51:14
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  #62648

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Closes #62648.


state: closed
title: writeScript: fix docstring
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/pull/62831
updated_at: 2019-06-09 10:45:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Just some minor fixes/improvements to the docstring of `writeScript`.

  Fixes #59299

  See:
  https://github.com/NixOS/nixpkgs/commit/b23dbb1a5dffbfa3abb47fcd0f1579ac2e6f29fc


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Pinning nixpkgs in configuration.nix?
user_login: jluttine
html_url: https://github.com/NixOS/nixpkgs/issues/62832
updated_at: 2019-07-16 11:35:50
body:
  ## Issue description

  I searched for information on how to pin system-wide nixpkgs in configuration.nix, but I couldn't find. I found a lot of information on how to pin nixpkgs for nix-shell or nix-build though. I'm probably just missing something obvious because I'm expecting this to be something very trivial..

  The point is that I want to specify nixpkgs commit in `configuration.nix` because the configuration is quite tightly tied to nixpkgs version. For instance, module options might change, packages might be removed/added/renamed. Also, for easier reproducability, it'd be great if `configuration.nix` contained all the relevant information so that when passing the file to someone, I don't need to also specify the nixpkgs version and the receiver doesn't have to figure out how to get that nixpkgs version. They would just put the file in place and run `nixos-rebuild switch`, and that's it.

  I tried:

  ```
    nix.nixPath = [
      "nixpkgs=https://github.com/NixOS/nixpkgs/archive/4ab1c14714fc97a27655f3a6877386da3cb237bc.tar.gz"
      "nixos-config=/etc/nixos/configuration.nix"
    ];
  ```

  But this has two shortcomings:

  - There's no hash for verifyingthe content of the URL. I guess this could be easily solved by using `builtins.fetchTarball`, so no real problem here.
  - More importantly, when I modify nixpkgs version, I need to run `nixos-rebuild switch` twice for it to take effect. The first call updates my system wide nixpkgs and the second call updates my system with this new nixpkgs. As far as I understand, this is a bit problematic:
    - First, what if `configuration.nix` isn't compatible with the nixpkgs version that is currently active in the system? Then the build fails and one cannot upgrade the system by just calling `nixos-rebuild switch` although `configuration.nix` would build just fine with the nixpkgs it specifies itself.
    - Second, IIUC, `nixos-rebuild boot` or `nixos-rebuild build` wouldn't use nixpkgs specified in `configuration.nix` but what is currently active in the system.

  So what is the correct way of specifying nixpkgs commit in `configuration.nix`?


state: open
title: extras_require in python packages
user_login: worldofpeace
html_url: https://github.com/NixOS/nixpkgs/issues/62833
updated_at: 2019-06-11 09:21:35
body:
  ## Issue description
  Certain packages will have a [`extras_require`](https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras) in `setup.py`.

  Currently I've advised people to follow the convention of adding an option like
  `with$extra_name` following the name used for the feature in `setup.py`.

  See [mailman-rss](https://github.com/NixOS/nixpkgs/blob/b5f3b7db524788400de609e45fc150b941c501f7/pkgs/development/python-modules/mailman-rss/default.nix#L1) for example. (https://github.com/kyamagu/mailman-rss/blob/master/setup.py#L45).

  Is this something to document specifically for Python in nixpkgs?


state: open
title: kubernetes.el fails to build
user_login: NeQuissimus
html_url: https://github.com/NixOS/nixpkgs/issues/62834
updated_at: 2019-06-08 21:54:49
body:
  ## Issue description

  The emacs package "kubernetes" fails to build.

  ```
  Done (Total of 27 files compiled, 2 skipped)
  Searching for program: No such file or directory, git
  builder for '/nix/store/walfx3q38f4vr9l94i0fyj4m3c71swnl-emacs-kubernetes-20190327.1744.drv' failed with exit code 255
  error: build of '/nix/store/walfx3q38f4vr9l94i0fyj4m3c71swnl-emacs-kubernetes-20190327.1744.drv' failed
  ```


  ### Steps to reproduce

  `nix-build -A emacs26PackagesNg.kubernetes`

  ## Technical details

  ```
  λ nix-shell -p nix-info --run "nix-info -m"
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.7-hardened, NixOS, 19.09.git.7dc8413 (Loris)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.09pre182062.1dc26c32edf"`
   - channels(nequi): `""`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
  ```


state: closed
title: Ipv6 privacy extensions
user_login: lheckemann
html_url: https://github.com/NixOS/nixpkgs/pull/62835
updated_at: 2019-07-14 17:27:59
body:
  ###### Motivation for this change
  #56306

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: gpgme: disable tests on darwin
user_login: veprbl
html_url: https://github.com/NixOS/nixpkgs/pull/62836
updated_at: 2019-06-08 20:32:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Fixes: #60313

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: helmfile: fix modSha256
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/62837
updated_at: 2019-06-08 08:01:53
body:
  ###### Motivation for this change
  Fix #62786  by fixing `modSha256`. It seems like this was another case where my Darwin setup was acting weird.

  ###### Things done
  Remove `stdenv.isDarwin` logic and `stdenv` argument.

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cryptsetup: enable kernel crypto api support again
user_login: fpletz
html_url: https://github.com/NixOS/nixpkgs/pull/62838
updated_at: 2019-06-12 05:05:43
body:
  ###### Motivation for this change
  This is needed for tcrypt and the benchmark subcommand. If enabled,
  it is also used to unlock LUKS2 volumes and therefore the kernel modules
  providing this feature need to be available in our initrd.

  Fixes #42163. #54019.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @cript0nauta @zarelit @hlandau 


state: open
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/62839
updated_at: 2019-06-08 01:13:49
title:
  graphical iso: xorg fails to start in virtualbox with "screens found but none have a usable configuration"

body:
  The solution seems to be some subset of the override here: https://github.com/matthewbauer/nixpkgs/blob/6de20a7fe4d076cadea078b77cd2bc3d52e409aa/nixos/modules/installer/virtualbox-demo.nix#L21 .


state: closed
title: pythonPackages.bjoern: 2.2.3 -> 3.0.1
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62840
updated_at: 2019-06-08 00:18:53
body:
  ###### Motivation for this change
  Upstream has addressed issues noted in https://github.com/NixOS/nixpkgs/pull/62055 and made a new release. This should supersede https://github.com/NixOS/nixpkgs/pull/62055 and https://github.com/NixOS/nixpkgs/pull/61887.

  Test execution seems a little unusual/hit-and-miss for me on macos (tested 10.13), but the exact same problem appears to exist with 2.2.3.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Change handle from c0dehero to pyrolagus
user_login: PyroLagus
html_url: https://github.com/NixOS/nixpkgs/pull/62841
updated_at: 2019-06-08 01:55:04
body:
  ###### Motivation for this change

  I changed my username on GitHub from c0dehero to pyrolagus. This is where I first added my handle to maintainers.nix: https://github.com/NixOS/nixpkgs/pull/7862

  I didn't change [voxelands.nix](https://github.com/NixOS/nixpkgs/blob/6eb186990215d1af5cd37a5898fc0d429531df69/pkgs/games/voxelands/default.nix) because that package is probably better off being deleted; the project looks dead and the URL just redirects to some spam/referral website. Should I open up an issue suggesting deletion, or what is the protocol for package removal?


state: closed
title: lkl: fix cross
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/62842
updated_at: 2019-06-09 21:50:37
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  I was working on lkl and realized it would be easy to make it cross compile.

  ###### Things done

  Adds the necessary `makeFlags` for cross, based on the Linux kernel derivation.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: clickhouse: enable for darwin
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62843
updated_at: 2019-06-20 21:23:52
body:
  ~A draft, because this sits on top of https://github.com/NixOS/nixpkgs/pull/62335 - direct any attention about the `re2` changes to that PR.~
  ###### Motivation for this change
  With a little effort, `clickhouse` builds and appears to work on darwin.

  The main issue is that it wants to be built with gcc (specifically gcc8) rather than clang, and therefore any c++-linked libraries have to be built with gcc too. This is largely achieved through `stdenv`-overriding, but in the case of `boost` requires a minor alteration. I think this is worth it, though - because a gcc-built boost is a valid thing a user might have need of.

  The package overrides are only conditionally applied where needed, because I didn't want to cause linux builds to require these packages to be built specifically with gcc *8* rather than the default.

  Tested on macos 10.13.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/dhcpd fails with networkd if interface has no carrier
user_login: erictapen
html_url: https://github.com/NixOS/nixpkgs/issues/62844
updated_at: 2019-06-10 00:14:09
body:
  ## Issue description

  The `dhcpd` service fails to start when the NixOS networking is managed by `systemd-networkd` and the interface `dhcpd` is listening on has "no carrier", e.g. there is no cable plugged in.

  ```
  ...
  Jun 08 00:36:27 dhcpd[973]: No subnet declaration for br0 (no IPv4 addresses).
  Jun 08 00:36:27 dhcpd[973]: ** Ignoring requests on br0.  If this is not what
  Jun 08 00:36:27 dhcpd[973]:    you want, please write a subnet declaration
  Jun 08 00:36:27 dhcpd[973]:    in your dhcpd.conf file for the network segment
  Jun 08 00:36:27 dhcpd[973]:    to which interface br0 is attached. **
  Jun 08 00:36:27 dhcpd[973]: Not configured to listen on any interfaces!
  ...
  ```

  ### Steps to reproduce

  To reproduce this you would need an interface without carrier, e.g. an unplugged ethernet interface on a laptop.

  ```nix
  # NixOS 19.03
  { pkgs, lib, ... }:{

    networking.useNetworkd = true;

    services.dhcpd4 = {
      enable = true;
      interfaces = [ "yourinterface" ];
      extraConfig = ''
        subnet 192.168.0.0 netmask 255.255.255.0 {
          range 192.168.0.100 192.168.0.200;
          option subnet-mask 255.255.255.0;
          # option broadcast-address 192.168.0.255;
          option routers 192.168.0.1;
        }
      '';
    };

  }
  ```

  ## Technical details

  The problem seems to be, that Networkd only assigns IP addresses if an interface has a carrier. As I don't see any solution on the side of ISC DHCP, I guess it needs to be solved in the Networkd config. Originally I thought setting `ConfigureWithoutCarrier=true` would solve the problem, but it didn't. `IgnoreCarrierLoss=true` looks more promising, but is [only available](https://github.com/systemd/systemd/pull/9262) in Systemd 242.

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.48, NixOS, 19.03 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - nixpkgs: `nixos-19.03`


state: closed
title: nim: 0.19.4 -> 0.20.0
user_login: royneary
html_url: https://github.com/NixOS/nixpkgs/pull/62845
updated_at: 2019-06-26 17:01:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Update to the latest release of Nim.

  What I did:
  - ~~makeWrapper not needed anymore~~
  - link sqlite (needed for the the stdlib sqlite module)
  - update nodejs to 11.x
  - use default phase order (fixes linker errors during test phase)
  - substitution in ./test/async/tioselectors.nim not needed anymore
  - two more tests need to be disabled
  - LD=$CC workaround not needed anymore
  - update mosdepth for it to compile with nim 0.20.0

  nrpl compiles with the new version.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: youtube-dl: 2019.05.20 -> 2019.06.08
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62846
updated_at: 2019-06-08 05:16:35
body:
  ###### Motivation for this change

  Backport please, once approved.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: editline: 1.16.0 -> 1.16.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62847
updated_at: 2019-06-09 09:41:35
body:
  ###### Motivation for this change

  https://github.com/troglobit/editline/releases/tag/1.16.1

  Incorporates the patches we were applying, some of which we authored!
  \o/

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: git: 2.21.0 -> 2.22.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62848
updated_at: 2019-06-14 15:25:27
body:
  ###### Motivation for this change

  https://github.com/git/git/blob/master/Documentation/RelNotes/2.22.0.txt

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Remove Voxelands package
user_login: PyroLagus
html_url: https://github.com/NixOS/nixpkgs/pull/62849
updated_at: 2019-06-09 14:08:08
body:
  ###### Motivation for this change

  The project seems to be dead  (no activity since one year in the [repository](https://gitlab.com/voxelands/voxelands)), and the voxelands domain now redirects to some spam/referral site.


state: closed
title: boehm-gc: remove libatomic_ops, guile: 2.2.3 -> 2.2.4
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/62850
updated_at: 2019-06-15 17:25:25
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Follow up of #54402 for staging. This completely removes the `libatomic_ops` dependency of `boehm-gc` and removes the no longer needed `dontStrip` attribute.

  `libatomic_ops` is not known to be needed on any platform supported by Nix, and if any platform did need it, it would still not work correctly because boehm-gc requires that all dependents link to `libatomic_ops` as well, if `boehm-gc` is linked with `libatomic_ops`. This is not currently done, so any package that uses `boehm-gc` would currently fail to compile on such a hypothetical platform. See #54402 for more details.

  I also updated guile to 2.2.4.

  cc @dtzWill because you reviewed #54402

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: avahi: add Python support
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/62851
updated_at: 2019-06-09 16:09:07
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  Adds support for the avahi Python library. It can be used as `python2Packages.avahi` or `python3Packages.avahi`.

  I tested that the module could be imported.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/desktop-managers/xterm: Defaults to xserver's state
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/62852
updated_at: 2019-06-24 18:48:59
body:
  ###### Motivation for this change

  This enhances #61423, which removed the gating of desktop-managers from
  being linked to the xserver's state.

  This, though, brought in xterm into all systems, even those without X
  servers.

  This change sets the *default* of the xterm desktop-manager to the state
  of the xserver, keeping it enabled by default as a sane fallback.

  The xterm desktop-manager can still be enabled or disabled as needed,
  without it being affected by xserver's state.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - 🔲 Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - 🔲 Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - ☑️ Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @volth, author of #61423


state: closed
title: nixos/sshd: fixes validation for cross-compilation
user_login: samueldr
html_url: https://github.com/NixOS/nixpkgs/pull/62853
updated_at: 2019-06-15 16:05:08
body:
  ###### Motivation for this change

  Make cross-compilation work for `sd-image` without modifications in Nixpkgs.

  This is the only bit which cannot be tackled through options or overlays.

  ~~I **do not like** the solution. Do not merge before one of our cross expert chimed in with another solution.~~

  ~~The issue here is that, AFAIUI, `cfgc.package` will not resolve to the right `nativeBuildInput`, though I do not understand why exactly. This is not as simple as testing with any other sshd, ideally you want to test with the one that will run the configuration. Thus, it needs to be the one configured in the option, but its cross-compiled cousin.~~

  Using @yegortimoshenko's suggestion.

  This was tested by building sd_image through cross-compilation.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - ☑️ Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - ☑️ NixOS
     - 🔲 macOS
     - 🔲 other Linux distributions
  - 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - 🔲 Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - 🔲 Tested execution of all binary files (usually in `./result/bin/`)
  - 🔲 Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - 🔲 Assured whether relevant documentation is up to date
  - ☑️ Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  cc @matthewbauer @Ericson2314 as cross-compilation experts


state: closed
title: nixos/jack: option to adjust dmix buffering
user_login: gnidorah
html_url: https://github.com/NixOS/nixpkgs/pull/62854
updated_at: 2019-06-09 11:54:02
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  cc @Infinisil 

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: LUKS in stage 1 fails silently when keyFile is wrong
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/62855
updated_at: 2019-06-08 08:50:11
body:
  The LUKS phase of stage 1 fails silently if `boot.initrd.luks.devices.?device.keyFile` is set to a nonexistent path. I was following https://elvishjerricco.github.io/2018/12/06/encrypted-boot-on-zfs-with-nixos.html and got it to work in the end. I did not look into it further.


state: open
title: system.build.installBootLoader not overrideable in containers
user_login: volth
html_url: https://github.com/NixOS/nixpkgs/issues/62856
updated_at: 2019-06-08 21:03:44
body:
  ## Issue description

  Options in ```system.build.*``` do not work with ```mkDefault``` and ```mkForce``` so

  this code, added just to shut up a warning
  https://github.com/NixOS/nixpkgs/blob/c8c53fcb1154999dabac350bebe12611a0f75024/nixos/modules/virtualisation/container-config.nix#L18-L19

  makes ```system.build.installBootLoader``` unoverrideable
  so it is not possible to use ```boot.isContainer = true``` together with ```boot.loader.initScript.enable = true``` or a custom ```system.build.installBootLoader``` (although installing ```grub``` is not relevant to container, forming ```/sbin/init``` is)

  ### Steps to reproduce

  ```js
  boot.isContainer = true;
  system.build.installBootLoader = ''something else'';
  ```

  ```system.build.installBootLoader``` will be "/nix/store/.../bin/true" anyway

  ## Technical details

  all nixpkgs in last 5 years


state: closed
title: jellyfin: 10.3.3 -> 10.3.4
user_login: minijackson
html_url: https://github.com/NixOS/nixpkgs/pull/62857
updated_at: 2019-06-08 12:54:19
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Release notes: https://github.com/jellyfin/jellyfin/releases/tag/v10.3.4

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: [19.03] backport wasmtime
user_login: asymmetric
html_url: https://github.com/NixOS/nixpkgs/pull/62858
updated_at: 2019-06-10 19:27:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This is a backport of 2 of @matthewbauer's [wasm](https://github.com/NixOS/nixpkgs/commit/dbb94b984f8282d1d9eada83634fc6777d19bdac) [commits](https://github.com/NixOS/nixpkgs/commit/bfaebc3647bc80137c51185e2a5a332d3420831d), stripped to the bare minimum so that they only just init the package.

  I added myself as a "co-author" as I modified the commit slightly (removed the changes to `lib/systems/default.nix` for example), but credit is all his.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia-x11: Set 32-bit library paths for 32-bit libraries.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/62859
updated_at: 2019-06-15 08:54:52
body:
  Patchelf was being called to point RUNPATH to 64-bit library paths even for 32-bit libraries.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: services.xserver.videoDrivers allows arbitrary value
user_login: chrissound
html_url: https://github.com/NixOS/nixpkgs/issues/62860
updated_at: 2019-06-08 21:02:25
body:
  ## Issue description

  ```
    services.xserver = {
      #videoDrivers = [ "nvidia" ];
      videoDrivers = [ "aoeueoeuo8euoarue8euoa8" ];
  ```

  The above would 'work' fine - a `nixos-rebuild switch` reports no errors, when really it should report an error?


state: closed
title: [r18.09] exim: add patch for CVE-2019-10149
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62861
updated_at: 2019-06-17 12:52:56
body:
  ###### Motivation for this change
  https://nvd.nist.gov/vuln/detail/CVE-2019-10149

  Other releases and master are safe.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: doc: update nixpkgs-mozilla rev
user_login: asymmetric
html_url: https://github.com/NixOS/nixpkgs/pull/62862
updated_at: 2019-06-09 09:01:34
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The previous one didn't work, returning a TOML parse error.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: pythonPackages.matchpy: 0.4.6 -> 0.5.1, fix build
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62863
updated_at: 2019-06-15 18:11:01
body:
  ###### Motivation for this change
  Was trying to fix `matchpy`, realized it was also a bit out of date. This bumps it and also fixes the tests - it really does seem to want `pytest_3` for now (though it looks like it's ok with us tricking it over the hypothesis version)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: [WIP] matrix-appservice-irc: init at 0.12.0
user_login: pacien
html_url: https://github.com/NixOS/nixpkgs/pull/62864
updated_at: 2019-07-07 15:35:30
body:
  ###### Motivation for this change

  This PR introduces a package and a module for [matrix-appservice-irc](https://github.com/matrix-org/matrix-appservice-irc).

  Configuration files are generated from attribute sets (cf https://github.com/NixOS/rfcs/pull/42).

  ###### Blockers

  - [x] ~~Removal of app service registration (to protect the AS' token)~~
  - [ ] Serialisation of the config attribute set which contains `mkOverride` values (https://github.com/NixOS/nixpkgs/pull/63589#discussion_r299780638)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: BCC causes kernel panic on kernel 4.19.48
user_login: mkmodrzew
html_url: https://github.com/NixOS/nixpkgs/issues/62865
updated_at: 2019-06-11 14:23:06
body:
  ## Issue description
  [BCC](https://github.com/NixOS/nixpkgs/tree/master/pkgs/os-specific/linux/bcc) causes kernel panic while trying to run tools that uses kprobes.


  ### Steps to reproduce
  Install NixOS
  nix-env -e linuxPackages.bcc
  opensnoop

  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.7, NixOS, 19.03.172844.caacbe98ce1 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172844.caacbe98ce1, unstable-19.09pre182256.168d1031af4"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ## My observations

  BCC installed directly through nix-env (or configuration.nix and nixos-rebuild) installs previous version (0.8.0). Installing BCC as a dependency of bpftrace install current version (0.9.0).

  ## My workaround

  It took my a while to make it work properly and with quite a few hacks I was able to. First, I upgraded kernel to the newest version. Second, I installed bpftrace to receive newest BCC. Third, problem with running BCC was linking to wrong kernel version. Trying to run any tool resulted in error "chmod(/nix/store/gh7859s2i0lr1y8rppp28n63gpvngds4-linux-4.19.48-dev/lib/modules/5.1.7/) no such file or directory". To avoid that I created symbolic link from `/nix/store/gh7859s2i0lr1y8rppp28n63gpvngds4-linux-4.19.48-dev/lib/modules/5.1.7` to `/nix/store/gh7859s2i0lr1y8rppp28n63gpvngds4-linux-4.19.48-dev/lib/modules/4.19.48/`. Forth, now I was able to run tools without kernel panic, but with warning in python script:
  `
  ...
  File "/nix/store/jz3h2qlk0lww3p3zrjqak557qyjy01ph-bcc-0.9.0/lib/python3.7/site-packages/bcc/table.py", line 625, in _get_event_class
      m = re.match(r"(.*)#(.*)", field)
    File "/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/lib/python3.7/re.py", line 173, in match
      return _compile(pattern, flags).match(string)
  `
  , so I replaced `field` with `field.decode()`. And voila, everything started to work as it supposes in the first place.


state: closed
title: firefox 67.0 -> 67.0.1
user_login: andir
html_url: https://github.com/NixOS/nixpkgs/pull/62866
updated_at: 2019-06-08 21:08:17
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Updating to latest firefox stable release: https://www.mozilla.org/en-US/firefox/67.0.1/releasenotes/

  Also bumping the related packages while we are at it. It has proven useful in the past…


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: reredirect: init at 0.2
user_login: tobim
html_url: https://github.com/NixOS/nixpkgs/pull/62868
updated_at: 2019-06-10 16:40:12
body:
  ###### Motivation for this change
  reredirect - A tool to dynamically redirect outputs of a running program

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: vulkan-loader: Always include /run/opengl-driver(-32)/share in search path.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/62869
updated_at: 2019-06-29 15:24:16
body:
  Even though FALLBACK_DATA_DIRS is set to include this, it only applies when XDG_DATA_DIRS is not defined, so the NixOS opengl.nix module still had to include these in the search path. Use a simple patch to force a default search path, consulted after all other search paths.

  Note that FALLBACK_DATA_DIRS is no longer set, and the default (/usr/local/share:/usr/share) applies.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Allow getting rid of adding these driver paths to `XDG_DATA_DIRS`. That will be a separate PR. Adding these paths to `XDG_DATA_DIRS` may be hurting application startup time due to every application checking them.

  ###### Things done

  Tested that `vulkaninfo` and `vkcube` work without `/run/opengl-driver(-32)/share` in `XDG_DATA_DIRS` (did not work before, unless `XDG_DATA_DIRS` was not set at all), also 32-bit binary on 64-bit system.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nvidia-x11: Put absolute library paths into ICD config files.
user_login: ambrop72
html_url: https://github.com/NixOS/nixpkgs/pull/62870
updated_at: 2019-07-11 18:31:27
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  If absolute library paths are used then use of `RUNPATH` or `LD_LIBRARY_PATH` becomes unnecessary. See the discussion here: https://github.com/NixOS/nixpkgs/pull/60985#discussion_r290238476

  This will allow removing `addOpenGLRunpath` from vulkan-loader and similar things.

  ###### Things done

  Checked that with NVidia all of the following still work, including 32-bit program on 64-bit system: `glxinfo`, `glxgears`, `es2_info`, `es2gears`,`vulkan-info`, `opencl-info`.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: displaylink: broken on xorg.server > 1.19.6
user_login: eyJhb
html_url: https://github.com/NixOS/nixpkgs/issues/62871
updated_at: 2019-06-08 19:45:58
body:
  ## Issue description
  Displaylink is broken as of b981b8e0feffbc12baa68294bb3a291c2f96cffe, which updates xorg.server to be 1.20.3.

  This is a known issue both on the evdi driver (part of DisplayLink) - https://github.com/DisplayLink/evdi/issues/133 and on the official website https://support.displaylink.com/knowledgebase/articles/1181623-displaylink-ubuntu-driver-after-recent-x-upgrades .

  I have tried applying the fix the suggest on there site 
  ```
  services.xserver.config = 
    ''
      Section "Device"
        Identifier "DisplayLink"
        Driver "modesetting"
        Option "PageFlip" "false"
      EndSection  
    '';
  ```

  But that still does not fix the problem, the only solution I have gotten to work is downgrading to 1.19.6.

  I have tried running the latest version of evdi (1.6.1) and Dispalylink (5.1.26), but that still does not solve the problem.


  ### Steps to reproduce
  -


  ## Technical details
  Please run `nix-shell -p nix-info --run "nix-info -m"` and paste the
  results.

  Currently running on 19.03 using commit 00322ccb73ed5d5204b7d9e4fad41573337f1470 on nix-channels nixos-19.03.


state: closed
title: clinfo: init at 2.2.18.04.06
user_login: athas
html_url: https://github.com/NixOS/nixpkgs/pull/62872
updated_at: 2019-06-19 23:37:53
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  `clinfo` is the standard tool for querying the state of OpenCL.  Nixpkgs already has `opencl-info`, but it's older and unmaintained.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind: fix build on armv6l
user_login: lopsided98
html_url: https://github.com/NixOS/nixpkgs/pull/62873
updated_at: 2019-06-09 16:14:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  bind 9.14 cannot be built on armv6l (and older) because it requires the `YIELD` instruction. This requirement was later removed upstream, but this commit is not included in 9.14. See https://gitlab.isc.org/isc-projects/bind9/issues/981

  This breaks NixOS on armv6l because the `host` command, which is part of bind, is installed by default.

  ###### Things done

  Backport the upstream patch that fixes the build on armv6l.

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: SSHGuard shows could not initialize firewall
user_login: R-VdP
html_url: https://github.com/NixOS/nixpkgs/issues/62874
updated_at: 2019-06-08 23:12:55
body:
  ## Issue description
  When the service starts, the following message is printed to the logs:

  sshguard[13576]: sshg-fw-ipset: Could not initialize firewall

  Blocking does not actually work. Blocked hosts can still initialize ssh connections.

  ### Steps to reproduce
  Default sshguard config.


  ## Technical details

   - system: `"x86_64-linux"`
   - host os: `Linux 4.19.47, NixOS, 19.03.172786.606306e0eaa (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172786.606306e0eaa"`
   - channels(XXXX): `"nixpkgs-18.03.132444.9062afb7cb7"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`


state: closed
title: pythonPackages.neuron: fix for darwin
user_login: risicle
html_url: https://github.com/NixOS/nixpkgs/pull/62875
updated_at: 2019-06-09 10:18:59
body:
  ###### Motivation for this change
  Fix build on darwin by un-compensating for some of the darwin quirks the neuron source is expecting but we don't have.

  Also disable for non-x86 as the source claims `#error "This code has only been tested on x86 and powerpc platforms."`

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [x] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.reflex: dontCheck
user_login: endgame
html_url: https://github.com/NixOS/nixpkgs/pull/62876
updated_at: 2019-06-14 15:21:47
body:
  ###### Motivation for this change

  Reflex uses hlint in its test suite, failing the build if there are
  any lint warnings. hlint depends on a newer haskell-src-exts than the
  rest of the nixpkgs haskell infrastructure, so this avoids reflex
  dependening on multiple versions of haskell-src-exts, which would
  otherwise abort the build.

  Tested with
  ```
  nix-build -E '(import ./. {config.allowBroken = true;}).haskellPackages.reflex'
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [X] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
  ---


state: closed
title: emacs-irony: prebuild irony-server executable
user_login: matthewbauer
html_url: https://github.com/NixOS/nixpkgs/pull/62877
updated_at: 2019-06-11 02:44:53
body:
  This has melpaBuild compile the irony-server executable automatically.
  This means each user of the irony executable doesn’t have to wait for
  it to compile on each new use. This depends on this PR to work
  correctly:

  https://github.com/Sarcasm/irony-mode/pull/537

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mirrors: rename sourceforgejp to osdn
user_login: marsam
html_url: https://github.com/NixOS/nixpkgs/pull/62878
updated_at: 2019-06-10 15:54:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  SourceForge.jp renamed to OSDN on May 11, 2015. https://osdn.net/projects/sourceforge/news/24923

  From [Wikipedia](https://en.wikipedia.org/wiki/OSDN#History):
  > On May 11, 2015, the site was renamed from "SourceForge.JP" to "OSDN".[[10](https://osdn.net/projects/sourceforge/news/24923)][[11](http://internet.watch.impress.co.jp/docs/news/20150408_696843.html)] In the same month that OSDN changed the site name, SourceForge caused two controversies: DevShare adware and project hijacking. In contrast, OSDN totally refuses adware bundling and project hijacking.
  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: notes-up: add missing default adwaita-icon-theme
user_login: kuznero
html_url: https://github.com/NixOS/nixpkgs/pull/62879
updated_at: 2019-06-21 18:06:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add missing icon theme (the app looks weird on KDE).

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: sensu-go: init at 5.9.0
user_login: thefloweringash
html_url: https://github.com/NixOS/nixpkgs/pull/62880
updated_at: 2019-06-09 15:51:45
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  New package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [x] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bind: drop a darwin-specific patch
user_login: vcunat
html_url: https://github.com/NixOS/nixpkgs/pull/62882
updated_at: 2019-06-09 07:56:50
body:
  The patch didn't apply since 9.12 -> 9.14 (26026c3).
  I'll hope it's not needed anymore (and let Borg verify that).
  It was reportedly just a configure-time error: e4602677.


state: closed
title: hyperfine: 1.4.0 -> 1.6.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62883
updated_at: 2019-06-09 09:39:22
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  https://github.com/sharkdp/hyperfine/releases/tag/v1.5.0
  https://github.com/sharkdp/hyperfine/releases/tag/v1.6.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: modidy-iris: 3.37.1 -> 3.38.0
user_login: Tomahna
html_url: https://github.com/NixOS/nixpkgs/pull/62884
updated_at: 2019-06-09 09:43:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mtprotoproxy: init package and service
user_login: abbradar
html_url: https://github.com/NixOS/nixpkgs/pull/62885
updated_at: 2019-06-09 09:17:42
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Circumventing censorship in Russia ;_; Better than SOCKS5 if you don't want to set up a proper VPN.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I'll merge after tests pass.


state: closed
title: kitty: 0.14.1 -> 0.14.2
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62886
updated_at: 2019-06-09 16:00:12
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Release: https://github.com/kovidgoyal/kitty/releases/tag/v0.14.2

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: php: Upgrade to php73 as default php
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62887
updated_at: 2019-06-09 16:00:59
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  At the moment we're in the middle of the lifespan for this unstable relase, I thought that it wouldn't hurt to run 7.3 as default now.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [X] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: exim: Fix build with MariaDB
user_login: ajs124
html_url: https://github.com/NixOS/nixpkgs/pull/62888
updated_at: 2019-06-14 21:25:40
body:
  The 10.2 → 10.3 upgrade (#44343) broke it.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: libclc: 2017-11-29 -> 2019-06-09
user_login: athas
html_url: https://github.com/NixOS/nixpkgs/pull/62890
updated_at: 2019-06-12 23:40:52
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  The old version does not compile at all with the current default LLVM in Nixpkgs.  This one does.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: nixos/documentation: nixos-help: use w3m(1) by default
user_login: jtojnar
html_url: https://github.com/NixOS/nixpkgs/pull/62891
updated_at: 2019-06-23 01:37:22
body:
  *Sent by Discourse: https://discourse.nixos.org/t/nixos-documentation-nixos-help-use-w3m-1-by-default/3124*

  ---

  ###### Motivation for this change

  It is referenced in various places, but does not work out of the box:

  	$ nixos-help
  	/run/current-system/sw/bin/nixos-help: unable to start a web browser; please set $BROWSER

  In the user-hidden fallbacks to xdg-open(1) and w3m(1), `nixos-help`
  expects tools to be deliberately installed by users.

  For default installations and new users in general, this is unlikely to
  be the case.  Conversely, chances to use `nixos-help` are even higher
  in such cases.

  Use w3m-nographics by default to ensure documentation is always
  available.  The documentation browser on ttyS8 already does so, but is
  not accessible in every installation, e.g. VMs with only ttyS0 and SSH
  available.

  This obsoletes including it in the base profile's systemPackages,
  so remove the @TODO as done.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: llvm_7: skip failing X86 test cases on armv7l
user_login: womfoo
html_url: https://github.com/NixOS/nixpkgs/pull/62894
updated_at: 2019-06-11 21:47:57
body:
  fixes #57472

  ###### Things done
  tested OK on armv7l

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: Revert "alsaLib: 1.1.8 -> 1.1.9"
user_login: timokau
html_url: https://github.com/NixOS/nixpkgs/pull/62895
updated_at: 2019-06-09 15:59:56
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  This reverts commit 2a5923aa2e37d3e3cc4979879ce466942498f139.

  Breaks sound, at least for some people.
  https://discourse.nixos.org/t/no-sound-on-unstable/3130

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: orc: disable tests on armv7l
user_login: womfoo
html_url: https://github.com/NixOS/nixpkgs/pull/62896
updated_at: 2019-06-11 21:34:16
body:
  also updated bugzilla references to newer gitlab

  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: pinentry: update patch url
user_login: womfoo
html_url: https://github.com/NixOS/nixpkgs/pull/62897
updated_at: 2019-06-09 15:46:25
body:
  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: dconf: disable tests on armv7l
user_login: womfoo
html_url: https://github.com/NixOS/nixpkgs/pull/62898
updated_at: 2019-06-09 21:32:10
body:
  - [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [X] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).


state: closed
title: elmPackages.{elm-test,elm-analyse..}: tooling additions and fixes
user_login: turboMaCk
html_url: https://github.com/NixOS/nixpkgs/pull/62899
updated_at: 2019-06-18 19:32:41
body:
  ## tl;dr
  This adds missing and fixes some existing tooling for elm-lang ecosystem

  ## Motivation
  - `nodePackages.elm-test` is broken
  - many commonly used tools are missing
  - many tools fail to install via npm due to the binwrap issue.

  This PR is based on [nix-elm-tools](https://github.com/turboMaCk/nix-elm-tools)

  **detailed info can be found in commit message**

  few additions remarks which can become dated:

  - elmi-to-json is compiled from source using cabal2nix similar to elm-format
  - there is one patch included - PR is opened in upstream package https://github.com/stoeffel/elmi-to-json/pull/28

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). **[I hope]**

  ---


state: closed
title: php: drop 7.1
user_login: etu
html_url: https://github.com/NixOS/nixpkgs/pull/62901
updated_at: 2019-07-04 13:37:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  PHP 7.1 is currently on life support, as in only recieving security related patches.

  This will only continue until: 2019-12-01

  This date are in the middle of the 19.09 lifecycle. So it would be
  nice to not have it in the 19.09 stable release. Dropping it now would
  also result in less maintanance in updating them.

  The death dates can be seen on following links:
   - https://endoflife.date/php
   - https://php.net/supported-versions.php
   - https://en.wikipedia.org/wiki/PHP#Release_history

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: systemd-networkd: Only generate [Match] if present
user_login: rvolosatovs
html_url: https://github.com/NixOS/nixpkgs/pull/62902
updated_at: 2019-06-11 12:09:32
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  Do not generate `[Match]` sections for `systemd-networkd` files, if there's nothing to generate to avoid errors in log.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: haskellPackages.insert-ordered-containers: fix build
user_login: Izorkin
html_url: https://github.com/NixOS/nixpkgs/pull/62903
updated_at: 2019-06-11 10:01:03
body:
  ###### Motivation for this change
  Fix build package haskellPackages.insert-ordered-containers

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: os-prober: add test and update
user_login: symphorien
html_url: https://github.com/NixOS/nixpkgs/pull/62904
updated_at: 2019-07-21 13:54:31
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update, and add a test to check that updates do not introduce regressions.
  The update should be a noop (it only touches debian specific files: https://salsa.debian.org/installer-team/os-prober/compare/1.76...1.77)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Enable grub debug output by default
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/62905
updated_at: 2019-06-15 17:13:03
body:
  Apparently grub has a `grub_dprintf`function that's used for some manner of debug output. I Could we enable showing it by default?


state: closed
title: nix-build haskell callPackage results in `ghc: can't find a package database at`
user_login: chrissound
html_url: https://github.com/NixOS/nixpkgs/issues/62906
updated_at: 2019-06-09 19:32:18
body:
  ## Issue description

  `nix build` completed successfully earlier today, I don't think I made any changes, however when I now try to build:

  ```
  nix build
  builder for '/nix/store/jqdf06504qkqxchgy1v3dl4r4yk3gq4c-my-xmonad-0.2.0.0.drv' failed with exit code 1; last 10 log lines:
    setupCompilerEnvironmentPhase
    Build with /nix/store/d4c9yp4w96g45fivnljg32zjrvdfp10h-ghc-8.6.4.
    unpacking sources
    unpacking source archive /nix/store/1ry562ycdxbins0c9aqdsn7lk3ags1d4-MyXmonad
    source root is MyXmonad
    patching sources
    compileBuildDriverPhase
    setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
    Loaded package environment from /build/MyXmonad/.ghc.environment.x86_64-linux-8.6.4
    ghc: can't find a package database at /home/chris/.cabal/store/ghc-8.6.4/package.db
  [0 built (1 failed), 0.0 MiB DL]
  error: build of '/nix/store/jqdf06504qkqxchgy1v3dl4r4yk3gq4c-my-xmonad-0.2.0.0.drv' failed
  ```

  And that directory:
  ```
  ll /home/chris/.cabal/store/ghc-8.6.4/package.db
  .rw-r--r--  20k chris  9 Jun 16:04 package.cache
  .rw-r--r-- 2.4k chris  9 Jun 16:04 base-orphans-0.8.1-d1d5c2f906d8b31189d967f92e3dab8d190a4551016acb01a8f15fe2cc62b631.conf
  .rw-r--r-- 1.5k chris  9 Jun 16:04 call-stack-0.1.0-b2e616096efae533904fd282961603c2a650c4d2c0c6d04175ef2ec29243a1fe.conf
  .rw-r--r-- 2.0k chris  9 Jun 16:04 colour-2.3.4-9fb7aba525a78e0132d037e046484b52a23ce1e3e46720a9266c985bde608134.conf
  .rw-r--r-- 1.5k chris  9 Jun 16:04 data-default-class-0.1.2.0-e2fae1c8a626f35fb46dd7274333d0deb7c563f41c08b45f363122b77dc260dc.conf
  .rw-r--r-- 1.7k chris  9 Jun 16:04 extensible-exceptions-0.1.1.4-842e402c16ee90dcd51df6b94f6a971bc12ee71217b9d9ca62dc72dee04f97ea.conf
  .rw-r--r-- 1.5k chris  9 Jun 16:04 old-locale-1.0.0.7-42d3c095826be03d22af56b0ee21c3cc822397c215396c1943b9567f2f9a6c65.conf
  .rw-r--r--    0 chris  2 Jun 22:53 package.cache.lock
  ```

  ## Technical details

  ```
  nix-shell -p nix-info --run "nix-info -m" 
   - system: `"x86_64-linux"`
   - host os: `Linux 5.1.7, NixOS, 19.03.172837.6c3826d1c93 (Koi)`
   - multi-user?: `yes`
   - sandbox: `yes`
   - version: `nix-env (Nix) 2.2.2`
   - channels(root): `"nixos-19.03.172837.6c3826d1c93, unstable-19.09pre181045.61f0936d1cd"`
   - channels(chris): `"nixos-18.09.1898.001b34abcb4, unstable-19.03pre166316.15eb4c361c7"`
   - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

  ```

  ----

  Nix files were generated with `cabal2nix`

  **default.nix**

      { nixpkgs ? import <nixpkgs> {}, compiler ? "ghc864" }:
      nixpkgs.pkgs.haskell.packages.${compiler}.callPackage ./xmonad.nix { }

  **xmonad.nix**

      { mkDerivation, base, containers, deepseq, hpack, lens, mtl
      , pretty-simple, process, stdenv, string-conversions, time, X11
      , xmonad, xmonad-contrib
      }:
      mkDerivation {
        pname = "my-xmonad";
        version = "0.2.0.0";
        src = ./.;
        isLibrary = false;
        isExecutable = true;
        libraryToolDepends = [ hpack ];
        executableHaskellDepends = [
          base containers deepseq lens mtl pretty-simple process
          string-conversions time X11 xmonad xmonad-contrib
        ];
        preConfigure = "hpack";
        license = stdenv.lib.licenses.gpl2;
      }


state: closed
title: pg-safeupdate: init at 1.2
user_login: steve-chavez
html_url: https://github.com/NixOS/nixpkgs/pull/62907
updated_at: 2019-06-11 19:21:53
body:
  ###### Motivation for this change

  [pg-safeupdate](https://github.com/eradman/pg-safeupdate) is a simple extension to PostgreSQL that raises an error if UPDATE and DELETE are executed without specifying conditions.

  To test this works you can do:
  ```sql
  load 'safeupdate';
  create temp table items( id int );
  delete from items;
  -- ERROR:  21000: DELETE requires a WHERE clause
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: Renaming zpool / dataset and back breaks boot under some circumstance
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/62908
updated_at: 2019-06-09 20:10:09
body:
  I renamed my root zpool and dataset using export-import-export for the zpool and zfs rename for the dataset. I forgot to do a nixos-rebuild switch after changing my configuration files to support the new configuration, so I renamed everything back.

  This somehow broke my grub and I couldn't get back to the nixos grub menu.

  Importing and exporting the zpool on the livecd seems to be what fixed the problem in the end, I don't know what's going on. I have not had time to make a reproducer.


state: closed
title: grab-site: 2.1.15 -> 2.1.16
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/62909
updated_at: 2019-06-09 22:21:26
body:
  ###### Motivation for this change

  This release fixes an issue with initial URLs being retried forever on failure:

  https://github.com/ArchiveTeam/grab-site/commits/master

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: synapse-bt: unstable-2019-05-26 -> 1.0
user_login: dywedir
html_url: https://github.com/NixOS/nixpkgs/pull/62910
updated_at: 2019-06-10 22:13:35
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/Luminarys/synapse/releases/tag/1.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mautrix-whatsapp: 2019-02-24 -> 2019-07-04
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/62911
updated_at: 2019-07-12 16:33:01
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Bump to the latest revision of `mautrix-whatsapp` to regain
  compatibility with matrix-synapse 0.99.5.

  Please note that it was necessary to alter some of the sources in
  `deps.nix`, please read the comment at the top of the file for further
  information.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: bcc: 0.9.0 -> 0.10.0
user_login: ivan
html_url: https://github.com/NixOS/nixpkgs/pull/62912
updated_at: 2019-06-11 00:48:57
body:
  ###### Motivation for this change

  This upgrade makes bcc execsnoop work on the latest 4.19 kernel.

  bcc execsnoop 0.9.0 + Linux 4.19.48: instant kernel panic + reboot; don't test this in production (#62865)

  bcc execsnoop 0.9.0 + Linux 4.19.49:

  ```
  # execsnoop                                                     

  PCOMM            PID    PPID   RET ARGS
  Traceback (most recent call last):
    File "_ctypes/callbacks.c", line 232, in 'calling callback function'
    File "/nix/store/zisijlanfkrw95dkbwcfb2hgi34fkqf5-bcc-0.9.0/lib/python3.7/site-packages/bcc/table.py", line 676, in raw_cb_
      callback(cpu, data, size)
    File "/nix/store/zisijlanfkrw95dkbwcfb2hgi34fkqf5-bcc-0.9.0/share/bcc/tools/.execsnoop-wrapped", line 199, in print_event
      event = b["events"].event(data)
    File "/nix/store/zisijlanfkrw95dkbwcfb2hgi34fkqf5-bcc-0.9.0/lib/python3.7/site-packages/bcc/table.py", line 654, in event
      self._event_class = self._get_event_class()
    File "/nix/store/zisijlanfkrw95dkbwcfb2hgi34fkqf5-bcc-0.9.0/lib/python3.7/site-packages/bcc/table.py", line 625, in _get_event_class
      m = re.match(r"(.*)#(.*)", field)
    File "/nix/store/4w1rxv6wfkv728jzmm6pqq3jsqd4yvi7-python3-3.7.3/lib/python3.7/re.py", line 173, in match
      return _compile(pattern, flags).match(string)
  TypeError: cannot use a string pattern on a bytes-like object
  ```

  bcc execsnoop 0.10.0 + Linux 4.19.49: 

  ```
  # execsnoop
  PCOMM            PID    PPID   RET ARGS
  [lots of good output]
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  I haven't tested the other binaries.

  cc maintainers @ragnard @Mic92 @thoughtpolice 


state: open
title: Write a guide for debugging (not even WIP)
user_login: deliciouslytyped
html_url: https://github.com/NixOS/nixpkgs/issues/62913
updated_at: 2019-06-11 01:45:53
body:
  This isn't particularly coherent so far but I figured it's worth starting something.
  The goal would be that when something breaks, you know what tool you need to reach for and how to use it to decrease the search space.
  Somewhat related might be problem _prevention_.

  At least the following should be covered/TODO:

  - search the manuals for keywords such as debug
  - nix evaluation
    - tracing nix expressions, the various lib tracing functions, etc
  - breakpointhook ( + check the manuals)
    - list reference: https://www.youtube.com/watch?v=ULqoCjANK-I
  - seq and laziness
  - printing some things seems to quit the interpreter, I'm not sure whats going on there?
  - NIX_DEBUG
  - https://nixos.wiki/wiki/Nixpkgs/Create_and_debug_packages + check wiki for other materials
  - recursive enableDebugging? (on dependents / deps?) (additionally: would be nice to have homogeneous debug enable infrastructure...but thats not a documentation problem.. i.e. a magic enableDebugging that works on everything)
  - something to help with noticing failing dlopen calls or somesuch
  - testing expressions ( https://github.com/deliciouslytyped/nix-expr-testlib ? )
  Edit:
  - probably strace , though scope creep to general system debugging? on the other hand nix usage is very broad so...


state: open
title: doc/nixos-rebuild(8): add Nix options to summary
user_login: Ma27
html_url: https://github.com/NixOS/nixpkgs/pull/62914
updated_at: 2019-06-13 22:38:46
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  It seems as the sentence at the bottom of the option summary about
  Nix-specific options isn't enough, it's probably more helpful to list
  those options in the synopsis as well.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: cargo-make: 0.19.4 -> 0.19.5
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62915
updated_at: 2019-06-11 12:04:33
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `cargo-make` to the latest release.
  https://github.com/sagiegurari/cargo-make/releases/tag/0.19.5

  **Note**: `doCheck` is set as `false`.
  Some tests fail because they need network access. However, Travis-CI ensures a proper build.
  https://travis-ci.org/sagiegurari/cargo-make/jobs/543478479
  https://travis-ci.org/sagiegurari/cargo-make/jobs/543478480
  https://travis-ci.org/sagiegurari/cargo-make/jobs/543478481

  `cargo-make` is a subcommand for `cargo`. You need to invoke `cargo-make` via `cargo` command.
  To test the binary files in `./result/bin`, consider the following commands:
  ```
  [john@nixos:~/result/bin] PATH=.:$PATH cargo make --version
  cargo-make 0.19.5
  [john@nixos:~/result/bin] makers --version
  makers 0.19.5
  ```

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: alacritty: 0.3.2 -> 0.3.3
user_login: xrelkd
html_url: https://github.com/NixOS/nixpkgs/pull/62916
updated_at: 2019-06-17 03:13:21
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Update `alacritty` to the latest release.
  https://github.com/jwilm/alacritty/releases/tag/v0.3.3
  https://github.com/jwilm/alacritty/blob/v0.3.3/CHANGELOG.md

  **Note**:
  CHANGELOG.md: The xclip dependency has been removed

  cc @Mic92 to review. Thank you!

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: networkmanager_strongswan: 1.4.4 -> 1.4.5
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62919
updated_at: 2019-06-10 03:17:13
body:
  ###### Motivation for this change

  TODO:
  * [ ] Confirm working on appropriate setup(s).
  * [ ] check release notes's mentions of compat or issues

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: xpra: 2.5 -> 2.5.2, mark winswitch broken as discussed
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62920
updated_at: 2019-06-10 11:38:30
body:
  ###### Motivation for this change

  See previous xpra PR: https://github.com/NixOS/nixpkgs/pull/58151

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x]  other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: consul: 1.4.2 -> 1.5.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62921
updated_at: 2019-07-04 16:56:01
body:
  ###### Motivation for this change

  Changelogs, read careful for security and compatibility:

  * https://github.com/hashicorp/consul/blob/v1.5.1/CHANGELOG.md
  * https://github.com/hashicorp/consul/blob/v1.5.0/CHANGELOG.md
    **CVE-2019-9900 and CVE-2019-9901**
  * https://github.com/hashicorp/consul/blob/v1.4.5/CHANGELOG.md
  * https://github.com/hashicorp/consul/blob/v1.4.4/CHANGELOG.md
    **CVE-2019-9764** (introduced in 1.4.3)
  * https://github.com/hashicorp/consul/blob/v1.4.3/CHANGELOG.md

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nomad: 0.8.7 -> 0.9.2
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62922
updated_at: 2019-06-16 18:42:46
body:
  ###### Motivation for this change

  * https://github.com/hashicorp/nomad/blob/v0.9.2/CHANGELOG.md
   **CVE-2019-12618**
  * https://github.com/hashicorp/nomad/blob/v0.9.1/CHANGELOG.md
  * https://github.com/hashicorp/nomad/blob/v0.9.0/CHANGELOG.md

  No more need to pin go go 1.10 AFAICT, drop.


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: xvfb_run: fix hash
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/62926
updated_at: 2019-06-10 16:37:18
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  While trying to upgrade from 18.09 to 19.03 locally, I had to override the `xvfb_run` hash.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: broot: 0.7.5 -> 0.8.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62927
updated_at: 2019-06-13 18:53:52
body:
  ###### Motivation for this change

  https://github.com/Canop/broot/releases/tag/v0.8.0

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  Pretty sure.  Double-checking as we speak, apologies :).  Pruned the
  wrong builder's cache too far :innocent:.

  ---


state: closed
title: curl: 7.65.0 -> 7.65.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62928
updated_at: 2019-07-20 12:18:25
body:
  https://curl.haxx.se/changes.html#7_65_1

  ###### Motivation for this change

  Rebuilding all the things is my favorite! O:)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: z-lua: 1.7.0 -> 1.7.1
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62929
updated_at: 2019-06-10 11:26:15
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  https://github.com/skywind3000/z.lua/releases/tag/v1.7.1

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: libwhich: 2019-03-20 -> 1.1.0
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62930
updated_at: 2019-06-12 04:41:26
body:
  ###### Motivation for this change

  musl, openbsd support

  Also, official release instead of git commit :)

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: acme-tiny: 2016-03-26 -> 4.0.4
user_login: dtzWill
html_url: https://github.com/NixOS/nixpkgs/pull/62931
updated_at: 2019-06-10 14:35:40
body:
  ###### Motivation for this change

  * fetch from pypi
  * nearly fix tests,
    but they seem to hang so leaving disabled for now

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [x] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  Have not tried actually using this script, sorry.


state: open
title: Restoring OpenCL support in Mesa
user_login: athas
html_url: https://github.com/NixOS/nixpkgs/issues/62933
updated_at: 2019-07-06 20:12:31
body:
  Nixpkgs packages Mesa (maintained by @vcunat), which has a reasonable operational OpenCL implementation that works at least on AMD GPUs (and whose OpenGL implementation is probably better than AMDs proprietary one).  Unfortunately, OpenCL support was explicitly removed from the package in d21b6702a3fae4c0c5003b08741f1a1d4d6c815a by @edolstra, apparently to remove dependency bloat (I guess the reason is that OpenCL needs an entire C compiler frontend at runtime).

  I'm a Nix novice, but I've poked around a bit to see how to fix this.  First, libclc must be updated to work at all ([already made a pull request](https://github.com/NixOS/nixpkgs/pull/62890)).  Then, reverting (in spirit) d21b6702a3fae4c0c5003b08741f1a1d4d6c815a makes the derivation at least compile the OpenCL bits again, most importantly `libMesaOpenCL.so` (a whopping 53MiB file!).  The mesa package already contains a separate output "drivers" that depends on LLVM, so perhaps the OpenCL bits could be moved there?  Alternatively, a new "opencl" output could be made.

  There is one more problem.  OpenCL specifies a directory `/etc/OpenCL/vendors`, which should contain text files containing names of ICDs (for example `libMesaOpenCL.so`).  In Nix, this is instead `/run/opengl-driver/etc/OpenCL/vendors`.  I don't understand how to make stuff available there.


state: closed
title: macvim: 7.4.909 -> 8.1.1517
user_login: lilyball
html_url: https://github.com/NixOS/nixpkgs/pull/62934
updated_at: 2019-06-16 22:10:09
body:
  ###### Motivation for this change

  Fix up the macvim package to build again, with the latest snapshot. The patchfile has been recreated by manually reapplying all of the changes from the old patchfile, and the other changes in here were figured out by trial and error (such as the need to unset `LD`).

  Also tweak the package to use python37 by default, and add an option to go back to python27 if desired. I'm not actually sure what the most common python configuration is these days, so this was chosen mostly because python3 is supposed to be the future.

  Disable Sparkle so the user isn't prompted to update a readonly package.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [X] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [X] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---

  This build is impure. It relies on accessing a few tools from `/usr/bin` (including `xcodebuild`), and it sets the minimum deployment target to the current OS version. I tried patching the latter but that resulted in a bunch of warnings during the build process, so I left it alone. This impurity exists for the current broken package too, of course.

  CC @cstrahan


state: closed
title: nixos/release-notes: document changed CargoSha256 hashes
user_login: danieldk
html_url: https://github.com/NixOS/nixpkgs/pull/62935
updated_at: 2019-06-23 13:48:04
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  cargoSha256 hashes change as result of changes in cargo-vendor, as
  discussed in #60668.

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: nixos/memcached: Isolate the service
user_login: dasJ
html_url: https://github.com/NixOS/nixpkgs/pull/62936
updated_at: 2019-06-10 14:40:46
body:
  memcached is (as the name suggests) an in-memory database so FS access
  is not required.

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: Update lilypond*
user_login: yurrriq
html_url: https://github.com/NixOS/nixpkgs/pull/62937
updated_at: 2019-06-11 16:49:08
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  - Rework both to use `fetchgit`
  - ~~Use `rsync` in `lilypond` build~~
  - Add me as maintainer of `lilypond` (and by extension `lilypond-unstable`)
  - Mark `lilypond` broken on darwin (segfault on my machine, been failing on hydra awhile)
  - Upgrade `lilypond-stable` from `2.19.65` to `2.19.83`
  - Prefer `overrideAttrs` to `overrideDerivation` in `lilypond-unstable`
  - Use fonts from `ghostscript` instead of pointing to a nonexistent urw-fonts repo
  - Install fonts to the `lilypond` `datadir`
  - Update LilyJAZZ font

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [x] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: open
title: neovim module: init at 0.3.4
user_login: matoruru
html_url: https://github.com/NixOS/nixpkgs/pull/62938
updated_at: 2019-06-23 13:53:25
body:
  I added a module for neovim settings.

  My motivations for this are that a module for setting default editor to neovim did not exist and to provide the `programs.neovim.defaultEditor`.

  It works on my environment and is almost same to [programs.vim module](https://github.com/NixOS/nixpkgs/blob/release-19.03/nixos/modules/programs/vim.nix).

  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change


  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: jost: init at 3.3
user_login: ar1a
html_url: https://github.com/NixOS/nixpkgs/pull/62939
updated_at: 2019-06-13 06:29:29
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change

  Add the "Jost*" font

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: mpich: 3.3 -> 3.3.1
user_login: markuskowa
html_url: https://github.com/NixOS/nixpkgs/pull/62940
updated_at: 2019-06-11 07:57:23
body:
  ###### Motivation for this change
  Bugfix release: https://github.com/pmodels/mpich/blob/3.3.x/CHANGES

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [x] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [x] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


state: closed
title: openvpn: fix static key mini howto url
user_login: woffs
html_url: https://github.com/NixOS/nixpkgs/pull/62941
updated_at: 2019-06-11 01:24:54
body:
  <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->
  ###### Motivation for this change
  old URL has 404, fix it

  ###### Things done

  <!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
  - Built on platform(s)
     - [ ] NixOS
     - [ ] macOS
     - [ ] other Linux distributions
  - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
  - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
  - [ ] Tested execution of all binary files (usually in `./result/bin/`)
  - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
  - [ ] Assured whether relevant documentation is up to date
  - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

  ---


